author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,853 | 01.03.2021 12:14:47 | 28,800 | 865ca64ee8c0af9eba88a4a04e0730630fae6d8b | tcp: endpoint.Write has to send all data that has been read from payload
io.Reader.ReadFull returns the number of bytes copied and an error if fewer
bytes were read. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -1552,10 +1552,11 @@ func (e *endpoint) Write(p tcpip.Payloader, opts tcpip.WriteOptions) (int64, tcp\nreturn nil, nil\n}\nv := make([]byte, avail)\n- if _, er... | Go | Apache License 2.0 | google/gvisor | tcp: endpoint.Write has to send all data that has been read from payload
io.Reader.ReadFull returns the number of bytes copied and an error if fewer
bytes were read.
PiperOrigin-RevId: 360247614 |
259,907 | 02.03.2021 12:41:06 | 28,800 | a317174673562996a98f5a735771955d6651e233 | [rack] Support running tcp_benchmarks with RACK. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/tcp/tcp_benchmark.sh",
"new_path": "test/benchmarks/tcp/tcp_benchmark.sh",
"diff": "@@ -91,6 +91,9 @@ while [ $# -gt 0 ]; do\n--sack)\nnetstack_opts=\"${netstack_opts} -sack\"\n;;\n+ --rack)\n+ netstack_opts=\"${netstack_opts} -rack\"\n+ ;;\n--... | Go | Apache License 2.0 | google/gvisor | [rack] Support running tcp_benchmarks with RACK.
PiperOrigin-RevId: 360491700 |
259,975 | 02.03.2021 14:08:33 | 28,800 | b8a5420f49a2afd622ec08b5019e1bf537f7da82 | Add reverse flag to mitigate.
Add reverse operation to mitigate that just enables
all CPUs. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/mitigate.go",
"new_path": "runsc/cmd/mitigate.go",
"diff": "@@ -16,7 +16,6 @@ package cmd\nimport (\n\"context\"\n- \"io/ioutil\"\n\"github.com/google/subcommands\"\n\"gvisor.dev/gvisor/pkg/log\"\n@@ -56,14 +55,7 @@ func (m *Mitigate) Execute(_ conte... | Go | Apache License 2.0 | google/gvisor | Add reverse flag to mitigate.
Add reverse operation to mitigate that just enables
all CPUs.
PiperOrigin-RevId: 360511215 |
259,898 | 03.03.2021 12:11:14 | 28,800 | 32578a591c01b1a64ce0bc5c9c62be4e8689232d | Use struct embedding to avoid casts and reuse methods
Removed (*testbench.Connection)(&conn) like casts
Removed redundant definition of Drain, Close and ExpectFrame | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/connections.go",
"new_path": "test/packetimpact/testbench/connections.go",
"diff": "@@ -633,7 +633,9 @@ func (conn *Connection) Drain(t *testing.T) {\n}\n// TCPIPv4 maintains the state for all the layers in a TCP/IPv4 connection.\n-... | Go | Apache License 2.0 | google/gvisor | Use struct embedding to avoid casts and reuse methods
- Removed (*testbench.Connection)(&conn) like casts
- Removed redundant definition of Drain, Close and ExpectFrame
PiperOrigin-RevId: 360727788 |
260,004 | 03.03.2021 12:35:26 | 28,800 | 9c80bcf32d8db3749a57ef104c5c9bab9f57d9c1 | Export faketime to go branch | [
{
"change_type": "MODIFY",
"old_path": "BUILD",
"new_path": "BUILD",
"diff": "@@ -122,6 +122,7 @@ go_path(\n# Packages that are not dependencies of the above.\n\"//pkg/sentry/kernel/memevent\",\n\"//pkg/tcpip/adapters/gonet\",\n+ \"//pkg/tcpip/faketime\",\n\"//pkg/tcpip/link/channel\",\n\"//pkg/tcpi... | Go | Apache License 2.0 | google/gvisor | Export faketime to go branch
PiperOrigin-RevId: 360732928 |
260,003 | 03.03.2021 16:14:27 | 28,800 | 76f0d2c67b75f9916866c07663dae7c7da805dbc | Deflake //pkg/tcpip/tests/integration:forward_test
clientEP.Connect may fail because serverEP was not listening. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/tests/integration/forward_test.go",
"new_path": "pkg/tcpip/tests/integration/forward_test.go",
"diff": "@@ -135,14 +135,15 @@ func TestForwarding(t *testing.T) {\nname string\nproto tcpip.TransportProtocolNumber\nexpectedConnectErr tcpip.Error\n- set... | Go | Apache License 2.0 | google/gvisor | Deflake //pkg/tcpip/tests/integration:forward_test
clientEP.Connect may fail because serverEP was not listening.
PiperOrigin-RevId: 360780667 |
259,854 | 04.03.2021 02:34:51 | 28,800 | 9b1170123d323e1f1e49bf5cf792070629d7ae09 | Fix race in unix socket transport.
transport.baseEndpoint.receiver and transport.baseEndpoint.connected are
protected by transport.baseEndpoint.Mutex. In order to access them without
holding the mutex, we must make a copy.
Notifications must be sent without holding the mutex, so we need the values
without holding the mutex. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/transport/unix.go",
"new_path": "pkg/sentry/socket/unix/transport/unix.go",
"diff": "@@ -816,19 +816,20 @@ func (e *baseEndpoint) Connected() bool {\nfunc (e *baseEndpoint) RecvMsg(ctx context.Context, data [][]byte, creds bool, numRight... | Go | Apache License 2.0 | google/gvisor | Fix race in unix socket transport.
transport.baseEndpoint.receiver and transport.baseEndpoint.connected are
protected by transport.baseEndpoint.Mutex. In order to access them without
holding the mutex, we must make a copy.
Notifications must be sent without holding the mutex, so we need the values
without holding the mutex. |
260,003 | 04.03.2021 10:52:00 | 28,800 | a9face757a2a0b7530999f112def3b633dbdecf4 | Nit fix: Should use maxTimeout in backoffTimer
The only user is in (*handshake).complete and it specifies MaxRTO, so there is
no behavior changes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -606,7 +606,7 @@ func newBackoffTimer(timeout, maxTimeout time.Duration, f func()) (*backoffTimer\nfunc (bt *backoffTimer) reset() tcpip.Error {\nbt.timeout *= 2... | Go | Apache License 2.0 | google/gvisor | Nit fix: Should use maxTimeout in backoffTimer
The only user is in (*handshake).complete and it specifies MaxRTO, so there is
no behavior changes.
PiperOrigin-RevId: 360954447 |
259,898 | 05.03.2021 11:53:18 | 28,800 | 2f0b82a8028019d4c996cf64341f84bb1d1c65b7 | Gather uname information from DUT
Some OSs behave slightly differently, but still within the RFC. It can be useful
to have access to uname information from the testbench. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/dut.go",
"new_path": "test/packetimpact/runner/dut.go",
"diff": "@@ -109,6 +109,7 @@ type dutInfo struct {\ndut DUT\nctrlNet, testNet *dockerutil.Network\nnetInfo *testbench.DUTTestNet\n+ uname *testbench.DUTUname\n}\n// setUpDUT will ... | Go | Apache License 2.0 | google/gvisor | Gather uname information from DUT
Some OSs behave slightly differently, but still within the RFC. It can be useful
to have access to uname information from the testbench.
PiperOrigin-RevId: 361193766 |
260,001 | 05.03.2021 12:03:33 | 28,800 | 808332e9e2e503f9d48b4a64e3151f22cb84e9fb | Implement IterDirent in verity fs | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/verity.go",
"new_path": "pkg/sentry/fsimpl/verity/verity.go",
"diff": "@@ -38,6 +38,7 @@ import (\n\"fmt\"\n\"math\"\n\"strconv\"\n+ \"strings\"\n\"sync/atomic\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n@@ -750,6 +751,50 @@ func (fd *file... | Go | Apache License 2.0 | google/gvisor | Implement IterDirent in verity fs
PiperOrigin-RevId: 361196154 |
260,004 | 05.03.2021 13:29:51 | 28,800 | 498709250a134d4d09a22d11cffdfdc402d9f052 | Include duplicate address holder info in DADResult
The integrator may be interested in who owns a duplicate address so
pass this information (if available) along.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/arp/arp.go",
"new_path": "pkg/tcpip/network/arp/arp.go",
"diff": "@@ -232,7 +232,7 @@ func (e *endpoint) HandlePacket(pkt *stack.PacketBuffer) {\nlinkAddr := tcpip.LinkAddress(h.HardwareAddressSender())\ne.mu.Lock()\n- e.mu.dad.StopLocked(add... | Go | Apache License 2.0 | google/gvisor | Include duplicate address holder info in DADResult
The integrator may be interested in who owns a duplicate address so
pass this information (if available) along.
Fixes #5605.
PiperOrigin-RevId: 361213556 |
260,004 | 05.03.2021 15:04:24 | 28,800 | 2db8f748593c09a283f5ce229bb6bfedc92849d1 | Fix network protocol/endpoint lock order violation
IPv4 would violate the lock ordering of protocol > endpoint when closing
network endpoints by calling `ipv4.protocol.forgetEndpoint` while
holding the network endpoint lock. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/BUILD",
"new_path": "pkg/tcpip/network/ipv4/BUILD",
"diff": "@@ -32,12 +32,14 @@ go_test(\n\"ipv4_test.go\",\n],\ndeps = [\n+ \"//pkg/sync\",\n\"//pkg/tcpip\",\n\"//pkg/tcpip/buffer\",\n\"//pkg/tcpip/checker\",\n\"//pkg/tcpip/faketime\",... | Go | Apache License 2.0 | google/gvisor | Fix network protocol/endpoint lock order violation
IPv4 would violate the lock ordering of protocol > endpoint when closing
network endpoints by calling `ipv4.protocol.forgetEndpoint` while
holding the network endpoint lock.
PiperOrigin-RevId: 361232817 |
259,951 | 05.03.2021 16:50:00 | 28,800 | fb733cdb8f4050fbc8ad083ea05c3e98b99b9acc | Increment the counters when sending Echo requests
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/icmp/endpoint.go",
"new_path": "pkg/tcpip/transport/icmp/endpoint.go",
"diff": "@@ -26,6 +26,8 @@ import (\n\"gvisor.dev/gvisor/pkg/waiter\"\n)\n+// TODO(https://gvisor.dev/issues/5623): Unit test this package.\n+\n// +stateify savable\ntyp... | Go | Apache License 2.0 | google/gvisor | Increment the counters when sending Echo requests
Updates #5597
PiperOrigin-RevId: 361252003 |
259,992 | 08.03.2021 11:16:09 | 28,800 | cabbbb373a62971684bf012a0c2164106395e051 | Fix SocketInetLoopbackTest flakiness
Remove part of test that was making it flaky. It runs for native only,
so not really important since it's not testing gVisor.
Before:
After: | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -705,12 +705,6 @@ TEST_P(SocketInetLoopbackTest, TCPFinWait2Test_NoRandomSave) {\nds.reset();\n- if (!IsRunningOnGvisor()) {\n- ASSERT_THAT(\n-... | Go | Apache License 2.0 | google/gvisor | Fix SocketInetLoopbackTest flakiness
Remove part of test that was making it flaky. It runs for native only,
so not really important since it's not testing gVisor.
Before: http://sponge2/37557c41-298e-408d-9b54-50ba3d41e22f
After: http://sponge2/7bca72be-cb9b-42f8-8c54-af4956c39455
PiperOrigin-RevId: 361611512 |
259,992 | 08.03.2021 14:46:03 | 28,800 | 1b9d45dbe8755914d07937ad348211f60ffcfc01 | Run shards in a single sandbox
Run all tests (or a given test partition) in a single sandbox.
Previously, each individual unit test executed in a new
sandbox, which takes much longer to execute.
Before After
Syscall tests: 37m22.768s 14m5.272s | [
{
"change_type": "MODIFY",
"old_path": "test/perf/BUILD",
"new_path": "test/perf/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"more_shards\")\nload(\"//test/runner:defs.bzl\", \"syscall_test\")\npackage(licenses = [\"notice\"])\n@@ -38,7 +37,6 @@ syscall_test(\nsyscall_test(\nsize = \"enormous\",\n... | Go | Apache License 2.0 | google/gvisor | Run shards in a single sandbox
Run all tests (or a given test partition) in a single sandbox.
Previously, each individual unit test executed in a new
sandbox, which takes much longer to execute.
Before After
Syscall tests: 37m22.768s 14m5.272s
PiperOrigin-RevId: 361661726 |
259,907 | 08.03.2021 15:49:27 | 28,800 | 333e489763cf741035cae7d0b425f22622fea3de | [lisa] Do not generate any tests for dynamic types.
The dynamic type user defines the marshalling logic, so we don't need to test
for things like alignment, absence of slices, etc.
For dynamic types, the go_marshal generator just generates the missing methods
required to implement marshal.Marshallable. | [
{
"change_type": "MODIFY",
"old_path": "tools/go_marshal/gomarshal/generator.go",
"new_path": "tools/go_marshal/gomarshal/generator.go",
"diff": "@@ -427,7 +427,7 @@ func (g *Generator) generateOne(t *marshallableType, fset *token.FileSet) *inter\n// implementations type t.\nfunc (g *Generator) gene... | Go | Apache License 2.0 | google/gvisor | [lisa] Do not generate any tests for dynamic types.
The dynamic type user defines the marshalling logic, so we don't need to test
for things like alignment, absence of slices, etc.
For dynamic types, the go_marshal generator just generates the missing methods
required to implement marshal.Marshallable.
PiperOrigin-RevId: 361676311 |
259,992 | 08.03.2021 16:55:22 | 28,800 | 3c4485966c170850bb677efc88de4c0ecaac1358 | Fix proc test flakiness
Thread from earlier test can show up in `/proc/self/tasks` while the
thread tears down. Account for that when searching for procs for the
first time in the test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc.cc",
"new_path": "test/syscalls/linux/proc.cc",
"diff": "@@ -2162,7 +2162,13 @@ class BlockingChild {\nreturn tid_;\n}\n- void Join() { Stop(); }\n+ void Join() {\n+ {\n+ absl::MutexLock ml(&mu_);\n+ stop_ = true;\n+ }\n+ thread_.Join(... | Go | Apache License 2.0 | google/gvisor | Fix proc test flakiness
Thread from earlier test can show up in `/proc/self/tasks` while the
thread tears down. Account for that when searching for procs for the
first time in the test.
PiperOrigin-RevId: 361689673 |
259,992 | 09.03.2021 20:10:16 | 28,800 | e0e04814b40f1d4077d1cf6001395bd6a919b288 | Fix invalid interface conversion in runner
panic: interface conversion: interface {} is syscall.WaitStatus, not unix.WaitStatus
goroutine 1 [running]:
main.runTestCaseNative(0xc0001fc000, 0xe3, 0xc000119b60, 0x1, 0x1, 0x0, 0x0)
test/runner/runner.go:185 +0xa94
main.main()
test/runner/runner.go:118 +0x745 | [
{
"change_type": "MODIFY",
"old_path": "runsc/specutils/namespace.go",
"new_path": "runsc/specutils/namespace.go",
"diff": "@@ -275,7 +275,7 @@ func MaybeRunAsRoot() error {\n}()\nif err := cmd.Wait(); err != nil {\nif exit, ok := err.(*exec.ExitError); ok {\n- if ws, ok := exit.Sys().(unix.WaitStat... | Go | Apache License 2.0 | google/gvisor | Fix invalid interface conversion in runner
panic: interface conversion: interface {} is syscall.WaitStatus, not unix.WaitStatus
goroutine 1 [running]:
main.runTestCaseNative(0xc0001fc000, 0xe3, 0xc000119b60, 0x1, 0x1, 0x0, 0x0)
test/runner/runner.go:185 +0xa94
main.main()
test/runner/runner.go:118 +0x745
PiperOrigin-RevId: 361957796 |
259,992 | 09.03.2021 20:51:53 | 28,800 | 14fc2ddd6cb2f25482ef0d16ec5e3ffda3dd0f6e | Update flock to v0.8.0 | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -303,8 +303,8 @@ go_repository(\ngo_repository(\nname = \"com_github_gofrs_flock\",\nimportpath = \"github.com/gofrs/flock\",\n- sum = \"h1:JFTFz3HZTGmgMz4E1TabNBNJljROSYgja1b4l50FNVs=\",\n- version = \"v0.6.1-0... | Go | Apache License 2.0 | google/gvisor | Update flock to v0.8.0
PiperOrigin-RevId: 361962416 |
259,962 | 11.03.2021 08:23:55 | 28,800 | 1020ac83f47cd6b178e7655f413fcd4f3cd2aa4c | Move Arch specific code to arch specific files. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/ptrace_amd64.go",
"new_path": "pkg/abi/linux/ptrace_amd64.go",
"diff": "@@ -50,3 +50,14 @@ type PtraceRegs struct {\nFs uint64\nGs uint64\n}\n+\n+// InstructionPointer returns the address of the next instruction to\n+// be executed.\n+func (p *Pt... | Go | Apache License 2.0 | google/gvisor | Move Arch specific code to arch specific files.
PiperOrigin-RevId: 362297474 |
260,001 | 11.03.2021 17:01:13 | 28,800 | df64c3a60f439dec81fd7c96690318588520eb87 | Clear Merkle tree files in RuntimeEnable mode
The Merkle tree files need to be cleared before enabling to avoid
redundant content. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -590,6 +590,23 @@ func (fs *filesystem) lookupAndVerifyLocked(ctx context.Context, parent *dentry,\nreturn nil, err\n}\n+ // Clear the Merkle tree file i... | Go | Apache License 2.0 | google/gvisor | Clear Merkle tree files in RuntimeEnable mode
The Merkle tree files need to be cleared before enabling to avoid
redundant content.
PiperOrigin-RevId: 362409591 |
260,001 | 11.03.2021 17:52:43 | 28,800 | a7197c9c688fdfc2d37005063d3f6dbf9cef2341 | Implement Merkle tree generate tool binary
This binary is used to recursively enable and generate Merkle tree files
for all files and directories in a file system from inside a gVisor
sandbox. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "tools/verity/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_binary\")\n+\n+licenses([\"notice\"])\n+\n+go_binary(\n+ name = \"measure_tool\",\n+ srcs = [\n+ \"measure_tool.go\",\n+ \"measure_tool_unsafe.go\",\n+ ],\n+ pure = True,\n+ deps = [... | Go | Apache License 2.0 | google/gvisor | Implement Merkle tree generate tool binary
This binary is used to recursively enable and generate Merkle tree files
for all files and directories in a file system from inside a gVisor
sandbox.
PiperOrigin-RevId: 362418770 |
259,891 | 11.03.2021 21:12:25 | 28,800 | 002df130655ff5e10196d0a057659a4d7c4f6364 | Remove special casing of socket stress test
With /proc/sys/net/ipv4/ip_local_port_range implemented, the socket stress
test runs in a more normal time and doesn't need to sacrifice coverage to
prevent timeouts. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -65,14 +65,8 @@ syscall_test(\nsyscall_test(\nsize = \"large\",\n- # Produce too many logs in the debug mode.\n- debug = False,\nshard_count = most_shards,\n- # Takes too long for TSAN. Since... | Go | Apache License 2.0 | google/gvisor | Remove special casing of socket stress test
With /proc/sys/net/ipv4/ip_local_port_range implemented, the socket stress
test runs in a more normal time and doesn't need to sacrifice coverage to
prevent timeouts.
PiperOrigin-RevId: 362443366 |
259,898 | 11.03.2021 22:35:26 | 28,800 | ab488702a68b139ee3fffb04931cfd749571ff9a | Support ICMP echo sockets on Linux DUT
By default net.ipv4.ping_group_range is set to "1 0" and no one (even the root)
can create an ICMP socket. Setting it to "0 0" allows root, which we are inside
the container, to create ICMP sockets for packetimpact tests. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/dut.go",
"new_path": "test/packetimpact/runner/dut.go",
"diff": "@@ -249,6 +249,7 @@ func TestWithDUT(ctx context.Context, t *testing.T, mkDevice func(*dockerutil.Co\ntestbenchContainer,\ntestbenchAddr,\ndockerNetworks,\n+ nil, /* sysc... | Go | Apache License 2.0 | google/gvisor | Support ICMP echo sockets on Linux DUT
By default net.ipv4.ping_group_range is set to "1 0" and no one (even the root)
can create an ICMP socket. Setting it to "0 0" allows root, which we are inside
the container, to create ICMP sockets for packetimpact tests.
PiperOrigin-RevId: 362454201 |
259,907 | 13.03.2021 20:27:55 | 28,800 | ee6b22ca63361a61618b00723e8f557d33e72af4 | [perf] Run benchmarks with VFS2.
The run-benchmark target would run the benchmark with VFS1. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -326,6 +326,7 @@ containerd-tests: containerd-test-1.4.3\n## BENCHMARKS_FILTER - filter to be applied to the test suite.\n## BENCHMARKS_OPTIONS - options to be passed to the test.\n## BENCHMARKS_PROFILE - profile ... | Go | Apache License 2.0 | google/gvisor | [perf] Run benchmarks with VFS2.
The run-benchmark target would run the benchmark with VFS1.
PiperOrigin-RevId: 362754188 |
259,907 | 15.03.2021 16:38:46 | 25,200 | ec45d969236bb98a83e7da0466bd67e540c5e8b5 | [op] Make gofer client handle return partial write length when err is nil.
If there was a partial write (when not using the host FD) which did not generate
an error, we were incorrectly returning the number of bytes attempted to write
instead of the number of bytes actually written. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/handle.go",
"new_path": "pkg/sentry/fsimpl/gofer/handle.go",
"diff": "@@ -124,8 +124,9 @@ func (h *handle) writeFromBlocksAt(ctx context.Context, srcs safemem.BlockSeq, o\nreturn 0, cperr\n}\nn, err := h.file.writeAt(ctx, buf[:cp], offs... | Go | Apache License 2.0 | google/gvisor | [op] Make gofer client handle return partial write length when err is nil.
If there was a partial write (when not using the host FD) which did not generate
an error, we were incorrectly returning the number of bytes attempted to write
instead of the number of bytes actually written.
PiperOrigin-RevId: 363058989 |
259,891 | 15.03.2021 18:47:41 | 25,200 | b1d57877264c2b94e3024375efc9914881f0bbe8 | Make netstack (//pkg/tcpip) buildable for 32 bit
Doing so involved breaking dependencies between //pkg/tcpip and the rest
of gVisor, which are discouraged anyways.
Tested on the Go branch via:
gvisor.dev/gvisor/pkg/tcpip/...
Addresses | [
{
"change_type": "MODIFY",
"old_path": "pkg/iovec/BUILD",
"new_path": "pkg/iovec/BUILD",
"diff": "@@ -4,12 +4,12 @@ package(licenses = [\"notice\"])\ngo_library(\nname = \"iovec\",\n- srcs = [\"iovec.go\"],\n- visibility = [\"//:sandbox\"],\n- deps = [\n- \"//pkg/abi/linux\",\n- \"@org_golang_x_sys/... | Go | Apache License 2.0 | google/gvisor | Make netstack (//pkg/tcpip) buildable for 32 bit
Doing so involved breaking dependencies between //pkg/tcpip and the rest
of gVisor, which are discouraged anyways.
Tested on the Go branch via:
gvisor.dev/gvisor/pkg/tcpip/...
Addresses #1446.
PiperOrigin-RevId: 363081778 |
259,992 | 15.03.2021 19:04:16 | 25,200 | 34d0d720679778611fce51ed7f62fbdafa413d60 | Deflake proc_test_native
Terminating tasks from other tests can mess up with the task
list of the current test. Tests were changed to look for added/removed
tasks, ignoring other tasks that may exist while the test is running. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -1705,6 +1705,7 @@ cc_binary(\n\"@com_google_absl//absl/time\",\ngtest,\n\"//test/util:memory_util\",\n+ \"//test/util:multiprocess_util\",\n\"//test/util:posix_error\",\n\"//test... | Go | Apache License 2.0 | google/gvisor | Deflake proc_test_native
Terminating tasks from other tests can mess up with the task
list of the current test. Tests were changed to look for added/removed
tasks, ignoring other tasks that may exist while the test is running.
PiperOrigin-RevId: 363084261 |
259,868 | 15.03.2021 20:09:37 | 25,200 | f4b74218202c8f318c603c57aa35895554194d98 | Move `MaxIovs` back to a variable in `iovec.go`. | [
{
"change_type": "MODIFY",
"old_path": "pkg/iovec/BUILD",
"new_path": "pkg/iovec/BUILD",
"diff": "@@ -4,10 +4,7 @@ package(licenses = [\"notice\"])\ngo_library(\nname = \"iovec\",\n- srcs = [\n- \"iovec.go\",\n- \"iovec_max.go\",\n- ],\n+ srcs = [\"iovec.go\"],\nvisibility = [\"//:sandbox\"],\ndeps ... | Go | Apache License 2.0 | google/gvisor | Move `MaxIovs` back to a variable in `iovec.go`.
PiperOrigin-RevId: 363091954 |
259,868 | 15.03.2021 20:12:40 | 25,200 | f7e841c2cede357c4cbd6117605e3f3d54f1961c | Turn sys_thread constants into variables. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_thread.go",
"new_path": "pkg/sentry/syscalls/linux/sys_thread.go",
"diff": "@@ -31,6 +31,11 @@ import (\n)\nconst (\n+ // exitSignalMask is the signal mask to be sent at exit. Same as CSIGNAL in linux.\n+ exitSignalMask = 0xff\n+)... | Go | Apache License 2.0 | google/gvisor | Turn sys_thread constants into variables.
PiperOrigin-RevId: 363092268 |
260,004 | 16.03.2021 10:28:04 | 25,200 | ebd7c1b889e5d212f4a694d3addbada241936e8e | Do not call into Stack from LinkAddressRequest
Calling into the stack from LinkAddressRequest is not needed as we
already have a reference to the network endpoint (IPv6) or network
interface (IPv4/ARP). | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/arp/arp.go",
"new_path": "pkg/tcpip/network/arp/arp.go",
"diff": "@@ -305,8 +305,6 @@ func (*endpoint) LinkAddressProtocol() tcpip.NetworkProtocolNumber {\n// LinkAddressRequest implements stack.LinkAddressResolver.LinkAddressRequest.\nfunc (... | Go | Apache License 2.0 | google/gvisor | Do not call into Stack from LinkAddressRequest
Calling into the stack from LinkAddressRequest is not needed as we
already have a reference to the network endpoint (IPv6) or network
interface (IPv4/ARP).
PiperOrigin-RevId: 363213973 |
260,004 | 16.03.2021 12:02:52 | 25,200 | 05193de1ccaf487a175dead4121c62b99e02d0f5 | Unexport methods on NDPOption
They are not used outside of the header package. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ndp_options.go",
"new_path": "pkg/tcpip/header/ndp_options.go",
"diff": "@@ -26,33 +26,33 @@ import (\n\"gvisor.dev/gvisor/pkg/tcpip\"\n)\n-// NDPOptionIdentifier is an NDP option type identifier.\n-type NDPOptionIdentifier uint8\n+// ndpOptio... | Go | Apache License 2.0 | google/gvisor | Unexport methods on NDPOption
They are not used outside of the header package.
PiperOrigin-RevId: 363237708 |
259,891 | 16.03.2021 14:53:42 | 25,200 | 607a1e481c276c8ab0c3e194ed04b38bc07b71b6 | setgid directory support in overlayfs | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"new_path": "pkg/sentry/fsimpl/overlay/filesystem.go",
"diff": "@@ -689,13 +689,9 @@ func (fs *filesystem) MkdirAt(ctx context.Context, rp *vfs.ResolvingPath, opts v\n}\nreturn err\n}\n- creds := rp.Credentials()\n+\ni... | Go | Apache License 2.0 | google/gvisor | setgid directory support in overlayfs
PiperOrigin-RevId: 363276495 |
259,898 | 16.03.2021 16:57:31 | 25,200 | 3dd7ad13b4586791cdc1c1efdef90760a7deff8e | Fix tcp_fin_retransmission_netstack_test
Netstack does not check ACK number for FIN-ACK packets and goes into TIMEWAIT
unconditionally. Fixing the state machine will give us back the retransmission
of FIN. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/rcv.go",
"new_path": "pkg/tcpip/transport/tcp/rcv.go",
"diff": "@@ -260,7 +260,7 @@ func (r *receiver) consumeSegment(s *segment, segSeq seqnum.Value, segLen seqnum\ncase StateEstablished:\nr.ep.setEndpointState(StateCloseWait)\ncase St... | Go | Apache License 2.0 | google/gvisor | Fix tcp_fin_retransmission_netstack_test
Netstack does not check ACK number for FIN-ACK packets and goes into TIMEWAIT
unconditionally. Fixing the state machine will give us back the retransmission
of FIN.
PiperOrigin-RevId: 363301883 |
260,004 | 17.03.2021 12:25:59 | 25,200 | d3a433caae7111973915197a9ecc61660df3b810 | Do not use martian loopback packets in tests
Transport demuxer and UDP tests should not use a loopback address as the
source address for packets injected into the stack as martian loopback
packets will be dropped in a later change. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/transport_demuxer_test.go",
"new_path": "pkg/tcpip/stack/transport_demuxer_test.go",
"diff": "@@ -33,8 +33,8 @@ import (\n)\nconst (\n- testSrcAddrV6 = \"\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x01\"\n- test... | Go | Apache License 2.0 | google/gvisor | Do not use martian loopback packets in tests
Transport demuxer and UDP tests should not use a loopback address as the
source address for packets injected into the stack as martian loopback
packets will be dropped in a later change.
PiperOrigin-RevId: 363479681 |
259,975 | 18.03.2021 12:11:59 | 25,200 | 29be908ab69d2d333572f6990d331e494b1e51fd | Address post submit comments for fs benchmarks.
Also, drop fio total reads/writes to 1GB as 10GB is
prohibitively slow. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -186,10 +186,10 @@ steps:\n# For fio, running with --test.benchtime=Xs scales the written/read\n# bytes to several GB. This is not a problem for root/bind/volume mounts,\n# but for ... | Go | Apache License 2.0 | google/gvisor | Address post submit comments for fs benchmarks.
Also, drop fio total reads/writes to 1GB as 10GB is
prohibitively slow.
PiperOrigin-RevId: 363714060 |
259,898 | 22.03.2021 00:04:17 | 25,200 | cbac2d9f97031bdc18cb301e95db7c052dccc1ee | Fix and merge tcp_{outside_the_window,tcp_unacc_seq_ack}_closing
The tests were not using the correct windowSize so the testing segments were
actually within the window for seqNumOffset=0 tests. The issue is already fixed
by | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/defs.bzl",
"new_path": "test/packetimpact/runner/defs.bzl",
"diff": "@@ -202,11 +202,6 @@ ALL_TESTS = [\nPacketimpactTestInfo(\nname = \"tcp_outside_the_window\",\n),\n- PacketimpactTestInfo(\n- name = \"tcp_outside_the_window_closing\... | Go | Apache License 2.0 | google/gvisor | Fix and merge tcp_{outside_the_window,tcp_unacc_seq_ack}_closing
The tests were not using the correct windowSize so the testing segments were
actually within the window for seqNumOffset=0 tests. The issue is already fixed
by #5674.
PiperOrigin-RevId: 364252630 |
259,985 | 22.03.2021 12:00:05 | 25,200 | 6bd2c6ce7307a6422e9aad26b8b3dec006f75e2d | Emit comment about build tags in gomarshal generated files.
This may be useful for tracking down where build tags come from and
understanding tag import issues in generated files. | [
{
"change_type": "MODIFY",
"old_path": "tools/go_marshal/gomarshal/generator.go",
"new_path": "tools/go_marshal/gomarshal/generator.go",
"diff": "@@ -126,6 +126,12 @@ func (g *Generator) writeHeader() error {\nb.emit(\"// Automatically generated marshal implementation. See tools/go_marshal.\\n\\n\")... | Go | Apache License 2.0 | google/gvisor | Emit comment about build tags in gomarshal generated files.
This may be useful for tracking down where build tags come from and
understanding tag import issues in generated files.
PiperOrigin-RevId: 364374931 |
260,004 | 22.03.2021 12:30:03 | 25,200 | a073d76979d1950a52462823c10b495f4f8c3728 | Return tcpip.Error from (*Stack).GetMainNICAddress | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -1619,9 +1619,8 @@ func (e *endpoint) processIPOptions(pkt *stack.PacketBuffer, orig header.IPv4Opt\n// TODO(https://gvisor.dev/issue/4586): This will need tweaking when... | Go | Apache License 2.0 | google/gvisor | Return tcpip.Error from (*Stack).GetMainNICAddress
PiperOrigin-RevId: 364381970 |
259,898 | 22.03.2021 14:07:55 | 25,200 | 9e86dfc9c5b56eaa91485826bcf3f1f7617d2eb0 | Fix logs for packetimpact tests cleanup
Don't cleanup containers in Network.Cleanup, otherwise containers will
be killed and removed several times.
Don't set AutoRemove for containers. This will prevent the confusing
'removal already in progress' messages.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/dockerutil/network.go",
"new_path": "pkg/test/dockerutil/network.go",
"diff": "@@ -102,11 +102,8 @@ func (n *Network) Inspect(ctx context.Context) (types.NetworkResource, error) {\nreturn n.client.NetworkInspect(ctx, n.id, types.NetworkInspectOptions{... | Go | Apache License 2.0 | google/gvisor | Fix logs for packetimpact tests cleanup
- Don't cleanup containers in Network.Cleanup, otherwise containers will
be killed and removed several times.
- Don't set AutoRemove for containers. This will prevent the confusing
'removal already in progress' messages.
Fixes #3795
PiperOrigin-RevId: 364404414 |
259,858 | 22.03.2021 23:14:49 | 25,200 | 7dbd6924a3f428d9b8698a5a7bf2707539722b6f | Update apt repository to limit to supported architectures.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/install.md",
"new_path": "g3doc/user_guide/install.md",
"diff": "@@ -59,7 +59,7 @@ Next, the configure the key used to sign archives and the repository:\n```bash\ncurl -fsSL https://gvisor.dev/archive.key | sudo apt-key add -\n-sudo add-apt-re... | Go | Apache License 2.0 | google/gvisor | Update apt repository to limit to supported architectures.
Fixes #5703
PiperOrigin-RevId: 364492235 |
260,001 | 23.03.2021 11:04:08 | 25,200 | beb11cec7669d029172751e5b4dfe21c0672a25a | Allow FSETXATTR/FGETXATTR host calls for Verity
These host calls are needed for Verity fs to generate/verify hashes. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/gofer.go",
"new_path": "runsc/cmd/gofer.go",
"diff": "@@ -166,7 +166,7 @@ func (g *Gofer) Execute(_ context.Context, f *flag.FlagSet, args ...interface{})\nats := make([]p9.Attacher, 0, len(spec.Mounts)+1)\nap, err := fsgofer.NewAttachPoint(\"/\", fs... | Go | Apache License 2.0 | google/gvisor | Allow FSETXATTR/FGETXATTR host calls for Verity
These host calls are needed for Verity fs to generate/verify hashes.
PiperOrigin-RevId: 364598180 |
259,891 | 23.03.2021 15:40:17 | 25,200 | 92374e51976c8a47e4705943f73cecbc6a27073b | setgid directory support in goferfs
Also adds support for clearing the setuid bit when appropriate (writing,
truncating, changing size, changing UID, or changing GID).
VFS2 only. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/p9.go",
"new_path": "pkg/p9/p9.go",
"diff": "@@ -151,9 +151,16 @@ const (\n// Sticky is a mode bit indicating sticky directories.\nSticky FileMode = 01000\n+ // SetGID is the set group ID bit.\n+ SetGID FileMode = 02000\n+\n+ // SetUID is the set user I... | Go | Apache License 2.0 | google/gvisor | setgid directory support in goferfs
Also adds support for clearing the setuid bit when appropriate (writing,
truncating, changing size, changing UID, or changing GID).
VFS2 only.
PiperOrigin-RevId: 364661835 |
259,992 | 23.03.2021 16:19:02 | 25,200 | 960155cdaad49ccea07e45152f124beeb7e7fdcc | Add --file-access-mounts flag
file-access-mounts flag is similar to --file-access, but controls
non-root mounts that were previously mounted in shared mode only.
This gives more flexibility to control how mounts are shared within
a container. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -792,7 +792,7 @@ func (c *containerMounter) getMountNameAndOptions(conf *config.Config, m specs.M\ncase bind:\nfd := c.fds.remove()\nfsName = gofervfs2.Name\n- opts = p9MountData(fd, c.getMountAcce... | Go | Apache License 2.0 | google/gvisor | Add --file-access-mounts flag
--file-access-mounts flag is similar to --file-access, but controls
non-root mounts that were previously mounted in shared mode only.
This gives more flexibility to control how mounts are shared within
a container.
PiperOrigin-RevId: 364669882 |
259,962 | 24.03.2021 12:05:06 | 25,200 | 72ff6a1cac6ab35132b4f79b1149590e103e5291 | Fix data race in fdbased when accessing fanoutID. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint.go",
"diff": "@@ -41,6 +41,8 @@ package fdbased\nimport (\n\"fmt\"\n+ \"math\"\n+ \"sync/atomic\"\n\"golang.org/x/sys/unix\"\n\"gvisor.dev/gvisor/pkg/binary\"\n@@ -188,7 +190,9 @... | Go | Apache License 2.0 | google/gvisor | Fix data race in fdbased when accessing fanoutID.
PiperOrigin-RevId: 364859173 |
259,884 | 24.03.2021 17:54:45 | 25,200 | e4772bd84512c03ca431701dc139e126a885abd4 | Fix highlighting sidebar menu on the website
Highlighting previously highlighted multiple items in the sidebar if the had
the same page name (not full url). This change simplifies this by adding the
highlight class in the jekyll template rather than javascript, and highlights
only the correct page. | [
{
"change_type": "MODIFY",
"old_path": "website/_includes/footer.html",
"new_path": "website/_includes/footer.html",
"diff": "@@ -27,25 +27,6 @@ if (!doNotTrack) {\n};\nwindow.addEventListener(\"hashchange\", shiftWindow);\n- var highlightCurrentSidebarNav = function() {\n- var href = location.pathn... | Go | Apache License 2.0 | google/gvisor | Fix highlighting sidebar menu on the website
Highlighting previously highlighted multiple items in the sidebar if the had
the same page name (not full url). This change simplifies this by adding the
highlight class in the jekyll template rather than javascript, and highlights
only the correct page.
PiperOrigin-RevId: 364931350 |
259,884 | 24.03.2021 17:55:06 | 25,200 | c27fac421b760e62a8becf5d2c53ddbdf4ae5a4c | Fix path to runsc in CNI tutorial. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/tutorials/cni.md",
"new_path": "g3doc/user_guide/tutorials/cni.md",
"diff": "@@ -131,7 +131,7 @@ sudo sh -c 'echo \"Hello World!\" > rootfs/var/www/html/index.html'\nNext create the `config.json` specifying the network namespace.\n```\n-sudo /... | Go | Apache License 2.0 | google/gvisor | Fix path to runsc in CNI tutorial.
PiperOrigin-RevId: 364931406 |
259,891 | 25.03.2021 11:58:35 | 25,200 | 6b085ba47715a3e7283ec383c1ddf0f8b14dc60c | setgid: skip tests when we can't find usable GIDs | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/setgid.cc",
"new_path": "test/syscalls/linux/setgid.cc",
"diff": "@@ -107,16 +107,7 @@ PosixErrorOr<std::pair<gid_t, gid_t>> Groups() {\nif (!capable.ValueOrDie()) {\nreturn PosixError(EPERM, \"missing CAP_SETGID\");\n}\n- gid_t gid = geteg... | Go | Apache License 2.0 | google/gvisor | setgid: skip tests when we can't find usable GIDs
PiperOrigin-RevId: 365092320 |
259,885 | 25.03.2021 16:47:57 | 25,200 | 79bc446facf3d6920853c4cf35e72d25dd4c1011 | Lock TaskSet mutex for writing in ptraceClone().
This is necessary since ptraceClone() mutates tracer.ptraceTracees. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/ptrace.go",
"new_path": "pkg/sentry/kernel/ptrace.go",
"diff": "@@ -770,8 +770,8 @@ func (t *Task) ptraceClone(kind ptraceCloneKind, child *Task, opts *CloneOptions\nif !t.hasTracer() {\nreturn false\n}\n- t.tg.pidns.owner.mu.RLock()\n- defer... | Go | Apache License 2.0 | google/gvisor | Lock TaskSet mutex for writing in ptraceClone().
This is necessary since ptraceClone() mutates tracer.ptraceTracees.
PiperOrigin-RevId: 365152396 |
259,858 | 01.04.2021 15:33:04 | 25,200 | 513de4039c9ba8fea3fb81c796312f20242c1c5d | Remove invalid dependency. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -154,7 +154,6 @@ cc_library(\ndefines = select_system(),\ndeps = default_net_util() + [\ngtest,\n- \"//net/util:ports\",\n\"@com_google_absl//absl/memory\",\n\"@com_google_absl//a... | Go | Apache License 2.0 | google/gvisor | Remove invalid dependency.
PiperOrigin-RevId: 366344222 |
259,975 | 02.04.2021 10:39:33 | 25,200 | 1b53550e556edc2864eb1525aded5874e931c92b | Add vfs1 to go/runsc-benchmarks | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -340,7 +340,8 @@ BENCHMARKS_FILTER := .\nBENCHMARKS_OPTIONS := -test.benchtime=30s\nBENCHMARKS_ARGS := -test.v -test.bench=$(BENCHMARKS_FILTER) $(BENCHMARKS_OPTIONS)\nBENCHMARKS_PROFILE := -pprof-dir=/tmp/profile ... | Go | Apache License 2.0 | google/gvisor | Add vfs1 to go/runsc-benchmarks
PiperOrigin-RevId: 366470480 |
259,985 | 02.04.2021 19:33:07 | 25,200 | 491b106d62ba97cafb63252bf7d5bdd4749d417a | Implement the runsc verity-prepare command.
Implement a new runsc command to set up a sandbox with verityfs and
run the measure tool. This is loosely forked from the do command, and
currently requires the caller to provide the measure tool binary. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/BUILD",
"new_path": "runsc/boot/BUILD",
"diff": "@@ -66,6 +66,7 @@ go_library(\n\"//pkg/sentry/fsimpl/proc\",\n\"//pkg/sentry/fsimpl/sys\",\n\"//pkg/sentry/fsimpl/tmpfs\",\n+ \"//pkg/sentry/fsimpl/verity\",\n\"//pkg/sentry/inet\",\n\"//pkg/sentry/ke... | Go | Apache License 2.0 | google/gvisor | Implement the runsc verity-prepare command.
Implement a new runsc command to set up a sandbox with verityfs and
run the measure tool. This is loosely forked from the do command, and
currently requires the caller to provide the measure tool binary.
PiperOrigin-RevId: 366553769 |
259,858 | 03.04.2021 00:16:37 | 25,200 | 9a8692c82ac543969cc0c9cf3541f2ab925ba4ac | Remove eternal and enormous tests. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/base/BUILD",
"new_path": "test/benchmarks/base/BUILD",
"diff": "@@ -17,7 +17,6 @@ go_library(\nbenchmark_test(\nname = \"startup_test\",\n- size = \"enormous\",\nsrcs = [\"startup_test.go\"],\nvisibility = [\"//:sandbox\"],\ndeps = [\n@@ -29,7 ... | Go | Apache License 2.0 | google/gvisor | Remove eternal and enormous tests.
PiperOrigin-RevId: 366573366 |
259,992 | 05.04.2021 11:37:56 | 25,200 | 3007ae647d2e7a8800f3550f5ffc53c5e73415ce | Fail tests when container returns non-zero status | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/dockerutil/container.go",
"new_path": "pkg/test/dockerutil/container.go",
"diff": "@@ -434,7 +434,14 @@ func (c *Container) Wait(ctx context.Context) error {\nselect {\ncase err := <-errChan:\nreturn err\n- case <-statusChan:\n+ case res := <-statusCh... | Go | Apache License 2.0 | google/gvisor | Fail tests when container returns non-zero status
PiperOrigin-RevId: 366839955 |
260,001 | 05.04.2021 11:55:11 | 25,200 | 58afd120d35c385d98ad0dfef0be454532035180 | Set Verity bit in verity_prepare cmd
This is needed to enable Xattrs features required by verity. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/verity_prepare.go",
"new_path": "runsc/cmd/verity_prepare.go",
"diff": "@@ -102,5 +102,7 @@ func (c *VerityPrepare) Execute(_ context.Context, f *flag.FlagSet, args ...inte\n// Force no networking, it is not necessary to run the verity measure tool.\... | Go | Apache License 2.0 | google/gvisor | Set Verity bit in verity_prepare cmd
This is needed to enable Xattrs features required by verity.
PiperOrigin-RevId: 366843640 |
260,001 | 05.04.2021 11:56:07 | 25,200 | e21a71bff18ba9da30a0ef977c747376d51ce8cb | Allow user mount for verity fs
Allow user mounting a verity fs on an existing mount by specifying mount
flags root_hash and lower_path. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/verity.go",
"new_path": "pkg/sentry/fsimpl/verity/verity.go",
"diff": "@@ -35,6 +35,7 @@ package verity\nimport (\n\"bytes\"\n+ \"encoding/hex\"\n\"encoding/json\"\n\"fmt\"\n\"math\"\n@@ -105,6 +106,13 @@ var (\nverityMu sync.RWMutex\n... | Go | Apache License 2.0 | google/gvisor | Allow user mount for verity fs
Allow user mounting a verity fs on an existing mount by specifying mount
flags root_hash and lower_path.
PiperOrigin-RevId: 366843846 |
259,891 | 05.04.2021 12:34:12 | 25,200 | e7b2023647df994736ccaaa99a66a8712db2c631 | deflake semaphore test
There's no reason to actually increment the semaphore, it just introduces the
chance of a race. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/semaphore.cc",
"new_path": "test/syscalls/linux/semaphore.cc",
"diff": "@@ -234,14 +234,6 @@ TEST(SemaphoreTest, SemTimedOpBlock) {\nAutoSem sem(semget(IPC_PRIVATE, 1, 0600 | IPC_CREAT));\nASSERT_THAT(sem.get(), SyscallSucceeds());\n- Scope... | Go | Apache License 2.0 | google/gvisor | deflake semaphore test
There's no reason to actually increment the semaphore, it just introduces the
chance of a race.
PiperOrigin-RevId: 366851795 |
259,907 | 05.04.2021 15:59:55 | 25,200 | 2d9095c7a669ad2632f12de8d0918f8bf48b499e | Actually don't run unlink_benchmark with TSAN.
This benchmark currently takes > 15 minutes to run in that case. | [
{
"change_type": "MODIFY",
"old_path": "test/perf/BUILD",
"new_path": "test/perf/BUILD",
"diff": "@@ -127,6 +127,7 @@ syscall_test(\nsize = \"large\",\nadd_overlay = True,\ndebug = False,\n+ tags = [\"nogotsan\"],\ntest = \"//test/perf/linux:unlink_benchmark\",\n)\n@@ -134,6 +135,5 @@ syscall_test(\... | Go | Apache License 2.0 | google/gvisor | Actually don't run unlink_benchmark with TSAN.
This benchmark currently takes > 15 minutes to run in that case.
PiperOrigin-RevId: 366891726 |
259,985 | 05.04.2021 16:00:17 | 25,200 | 88f198c2a9da1bac9726db18af4e7615aaa65476 | Allow default control values to be set for cgroupfs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/cgroupfs.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/cgroupfs.go",
"diff": "@@ -94,6 +94,14 @@ var SupportedMountOptions = []string{\"all\", \"cpu\", \"cpuacct\", \"cpuset\", \"memory\"\n// +stateify savable\ntype FilesystemType str... | Go | Apache License 2.0 | google/gvisor | Allow default control values to be set for cgroupfs.
PiperOrigin-RevId: 366891806 |
259,992 | 05.04.2021 16:58:07 | 25,200 | 198e0dcde2476d847de699dc3c0d20421a855e86 | Add fsstress on tmpfs to presubmit
Updates | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -89,6 +89,9 @@ steps:\n- <<: *common\nlabel: \":person_in_lotus_position: KVM tests\"\ncommand: make kvm-tests\n+ - <<: *common\n+ label: \":weight_lifter: Fsstress test\"\n+ comman... | Go | Apache License 2.0 | google/gvisor | Add fsstress on tmpfs to presubmit
Updates #5273
PiperOrigin-RevId: 366902314 |
259,992 | 05.04.2021 17:07:59 | 25,200 | 661e5ae7ae496332c0b5440980d0a9a00f9b9fbd | Enable Checkpoint/Restore test with VFS2
Closes | [
{
"change_type": "MODIFY",
"old_path": "test/e2e/BUILD",
"new_path": "test/e2e/BUILD",
"diff": "@@ -8,7 +8,6 @@ go_test(\nsrcs = [\n\"exec_test.go\",\n\"integration_test.go\",\n- \"regression_test.go\",\n],\nlibrary = \":integration\",\ntags = [\n"
},
{
"change_type": "MODIFY",
"old_path... | Go | Apache License 2.0 | google/gvisor | Enable Checkpoint/Restore test with VFS2
Closes #3373
PiperOrigin-RevId: 366903991 |
260,001 | 05.04.2021 17:29:30 | 25,200 | 63340e61388621d41a5abb08d8902a1565d02a96 | Add initial verity ioctl syscall tests | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -243,6 +243,10 @@ syscall_test(\ntest = \"//test/syscalls/linux:ioctl_test\",\n)\n+syscall_test(\n+ test = \"//test/syscalls/linux:verity_ioctl_test\",\n+)\n+\nsyscall_test(\ntest = \"//test/... | Go | Apache License 2.0 | google/gvisor | Add initial verity ioctl syscall tests
PiperOrigin-RevId: 366907152 |
259,985 | 05.04.2021 19:44:12 | 25,200 | 7a7fcf2dbaa7bdcdb9b523358de91c71d5cb05d8 | Report task CPU usage through the cpuacct cgroup controller. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/base.go",
"diff": "@@ -167,8 +167,8 @@ func (d *cgroupProcsData) Generate(ctx context.Context, buf *bytes.Buffer) error\npgids := make(map[kernel.ThreadID]struct{})\n- d.fs.tasksMu.Lo... | Go | Apache License 2.0 | google/gvisor | Report task CPU usage through the cpuacct cgroup controller.
PiperOrigin-RevId: 366923274 |
260,004 | 06.04.2021 10:14:10 | 25,200 | d7fd00bad1416fb44b3303331ee223c28c69fe9b | Do not perform MLD for certain multicast scopes
...as per RFC 2710 section 5 page 10.
Test: ipv6_test.TestMLDSkipProtocol | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv6.go",
"new_path": "pkg/tcpip/header/ipv6.go",
"diff": "@@ -142,11 +142,6 @@ const (\n// ipv6MulticastAddressScopeMask is the mask for the scope (scop) field,\n// within the byte holding the field, as per RFC 4291 section 2.7.\nipv6Multicas... | Go | Apache License 2.0 | google/gvisor | Do not perform MLD for certain multicast scopes
...as per RFC 2710 section 5 page 10.
Test: ipv6_test.TestMLDSkipProtocol
PiperOrigin-RevId: 367031126 |
259,853 | 07.04.2021 16:22:43 | 25,200 | 0e55b57452d3437f494690dca67bcc55f11d3c60 | perf/getpid: add a case when syscalls are executed via mov $XXX, %eax; syscall
This is the most often pattern of calling system calls in real applications. | [
{
"change_type": "MODIFY",
"old_path": "test/perf/linux/getpid_benchmark.cc",
"new_path": "test/perf/linux/getpid_benchmark.cc",
"diff": "@@ -31,6 +31,24 @@ void BM_Getpid(benchmark::State& state) {\nBENCHMARK(BM_Getpid);\n+#ifdef __x86_64__\n+\n+#define SYSNO_STR1(x) #x\n+#define SYSNO_STR(x) SYSNO... | Go | Apache License 2.0 | google/gvisor | perf/getpid: add a case when syscalls are executed via mov $XXX, %eax; syscall
This is the most often pattern of calling system calls in real applications.
PiperOrigin-RevId: 367320048 |
259,858 | 07.04.2021 17:10:58 | 25,200 | 192f20788b338900291b0692e2518a8e8bc0f56d | Add internal staging tags to //runsc and //shim binaries. | [
{
"change_type": "MODIFY",
"old_path": "runsc/BUILD",
"new_path": "runsc/BUILD",
"diff": "@@ -9,6 +9,7 @@ go_binary(\n\"version.go\",\n],\npure = True,\n+ tags = [\"staging\"],\nvisibility = [\n\"//visibility:public\",\n],\n"
},
{
"change_type": "MODIFY",
"old_path": "shim/BUILD",
"n... | Go | Apache License 2.0 | google/gvisor | Add internal staging tags to //runsc and //shim binaries.
PiperOrigin-RevId: 367328273 |
259,858 | 08.04.2021 09:31:51 | 25,200 | cbf00d633db744febdac262ecfbc4908aa4e8a2f | Clarify platform errors. | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/sandbox.go",
"new_path": "runsc/sandbox/sandbox.go",
"diff": "@@ -486,7 +486,7 @@ func (s *Sandbox) createSandboxProcess(conf *config.Config, args *Args, startSyn\n}\nif deviceFile, err := gPlatform.OpenDevice(); err != nil {\n- return fmt.Errorf... | Go | Apache License 2.0 | google/gvisor | Clarify platform errors.
PiperOrigin-RevId: 367446222 |
260,004 | 08.04.2021 09:48:17 | 25,200 | 9e4a1e31d4fbf7d4439d503bf318517c92c8e885 | Join all routers group when forwarding is enabled
See comments inline code for rationale.
Test: ip_test.TestJoinLeaveAllRoutersGroup | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv6.go",
"new_path": "pkg/tcpip/header/ipv6.go",
"diff": "@@ -98,12 +98,27 @@ const (\n// The address is ff02::1.\nIPv6AllNodesMulticastAddress tcpip.Address = \"\\xff\\x02\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x00\\x01... | Go | Apache License 2.0 | google/gvisor | Join all routers group when forwarding is enabled
See comments inline code for rationale.
Test: ip_test.TestJoinLeaveAllRoutersGroup
PiperOrigin-RevId: 367449434 |
260,001 | 08.04.2021 11:43:46 | 25,200 | ffeb2a2f54c7363136c29cfe179afedf0889ea3f | Add Children in merkletree generate
This field was missing and should be provided. | [
{
"change_type": "MODIFY",
"old_path": "pkg/merkletree/merkletree.go",
"new_path": "pkg/merkletree/merkletree.go",
"diff": "@@ -238,6 +238,7 @@ func Generate(params *GenerateParams) ([]byte, error) {\nMode: params.Mode,\nUID: params.UID,\nGID: params.GID,\n+ Children: params.Children,\nSymlinkTarget... | Go | Apache License 2.0 | google/gvisor | Add Children in merkletree generate
This field was missing and should be provided.
PiperOrigin-RevId: 367474481 |
259,858 | 08.04.2021 15:16:40 | 25,200 | 5ac79e154532fc594eb6bcc87f3ba5d85aaa5013 | Drop unused escapes information. | [
{
"change_type": "MODIFY",
"old_path": "tools/nogo/analyzers.go",
"new_path": "tools/nogo/analyzers.go",
"diff": "@@ -83,11 +83,6 @@ var AllAnalyzers = []*analysis.Analyzer{\nchecklocks.Analyzer,\n}\n-// EscapeAnalyzers is a list of escape-related analyzers.\n-var EscapeAnalyzers = []*analysis.Analy... | Go | Apache License 2.0 | google/gvisor | Drop unused escapes information.
PiperOrigin-RevId: 367517305 |
260,004 | 08.04.2021 15:28:58 | 25,200 | 091badcb9c19bc2a2ff01f1ca7f4f20f99aef87c | Do not forward link-local packets
As per RFC 3927 section 7 and RFC 4291 section 2.5.6.
Test: forward_test.TestMulticastForwarding | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv4.go",
"new_path": "pkg/tcpip/header/ipv4.go",
"diff": "@@ -178,6 +178,26 @@ const (\nIPv4FlagDontFragment\n)\n+// ipv4LinkLocalUnicastSubnet is the IPv4 link local unicast subnet as defined\n+// by RFC 3927 section 1.\n+var ipv4LinkLocalUn... | Go | Apache License 2.0 | google/gvisor | Do not forward link-local packets
As per RFC 3927 section 7 and RFC 4291 section 2.5.6.
Test: forward_test.TestMulticastForwarding
PiperOrigin-RevId: 367519336 |
260,001 | 08.04.2021 17:59:46 | 25,200 | 496a3654e7af2ee905c1183c622687c6af29069b | Set parent after child is verified
We should only set parent after child is verified. Also, if the parent
is set before verified, destroyLocked() will try to grab parent.dirMu,
which may cause deadlock. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -632,8 +632,6 @@ func (fs *filesystem) lookupAndVerifyLocked(ctx context.Context, parent *dentry,\nchildVD.IncRef()\nchildMerkleVD.IncRef()\n- parent.Inc... | Go | Apache License 2.0 | google/gvisor | Set parent after child is verified
We should only set parent after child is verified. Also, if the parent
is set before verified, destroyLocked() will try to grab parent.dirMu,
which may cause deadlock.
PiperOrigin-RevId: 367543655 |
260,001 | 08.04.2021 18:31:11 | 25,200 | edf30a9bc5a645a7e03fca81f3e5852214588021 | Set root dentry and hash for verity before verify
Set root dentry and root hash in verity fs before we verify the root
directory if a root hash is provided. These are used during
verification. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/verity.go",
"new_path": "pkg/sentry/fsimpl/verity/verity.go",
"diff": "@@ -428,9 +428,15 @@ func (fstype FilesystemType) GetFilesystem(ctx context.Context, vfsObj *vfs.Virt\nd.mode = uint32(stat.Mode)\nd.uid = stat.UID\nd.gid = stat.GI... | Go | Apache License 2.0 | google/gvisor | Set root dentry and hash for verity before verify
Set root dentry and root hash in verity fs before we verify the root
directory if a root hash is provided. These are used during
verification.
PiperOrigin-RevId: 367547346 |
260,004 | 09.04.2021 13:20:05 | 25,200 | 973ace6bd9c4a17fe6858d6a0b2977ddfaca7885 | Rename IsV6LinkLocalAddress to IsV6LinkLocalUnicastAddress
To match the V4 variant. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv6.go",
"new_path": "pkg/tcpip/header/ipv6.go",
"diff": "@@ -391,23 +391,23 @@ func LinkLocalAddr(linkAddr tcpip.LinkAddress) tcpip.Address {\nreturn tcpip.Address(lladdrb[:])\n}\n-// IsV6LinkLocalAddress determines if the provided address i... | Go | Apache License 2.0 | google/gvisor | Rename IsV6LinkLocalAddress to IsV6LinkLocalUnicastAddress
To match the V4 variant.
PiperOrigin-RevId: 367691981 |
260,023 | 09.04.2021 16:51:23 | 25,200 | dc8f6c6914747c700a629b7717e45759cf1f7650 | Move maxListenBacklog check to sentry
Move maxListenBacklog check to the caller of endpoint Listen so that it
is applicable to Unix domain sockets as well.
This was changed in cl/366935921.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_socket.go",
"new_path": "pkg/sentry/syscalls/linux/sys_socket.go",
"diff": "@@ -46,6 +46,9 @@ const maxOptLen = 1024 * 8\n// buffers upto INT_MAX.\nconst maxControlLen = 10 * 1024 * 1024\n+// maxListenBacklog is the maximum limit ... | Go | Apache License 2.0 | google/gvisor | Move maxListenBacklog check to sentry
Move maxListenBacklog check to the caller of endpoint Listen so that it
is applicable to Unix domain sockets as well.
This was changed in cl/366935921.
Reported-by: syzbot+a35ae7cdfdde0c41cf7a@syzkaller.appspotmail.com
PiperOrigin-RevId: 367728052 |
260,001 | 09.04.2021 17:35:32 | 25,200 | ea7faa50579d3d76c6cbb1f7ffba4e16eebf1885 | Return integrity failure only if enabled
If the parent is not enabled in verity stepLocked(), failure to find
the child dentry could just mean an incorrect path. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -553,7 +553,7 @@ func (fs *filesystem) lookupAndVerifyLocked(ctx context.Context, parent *dentry,\n}\nchildVD, err := parent.getLowerAt(ctx, vfsObj, name... | Go | Apache License 2.0 | google/gvisor | Return integrity failure only if enabled
If the parent is not enabled in verity stepLocked(), failure to find
the child dentry could just mean an incorrect path.
PiperOrigin-RevId: 367733412 |
259,858 | 12.04.2021 12:33:15 | 25,200 | 9c87ef53fde887aa4f7151249029b534ca8c0998 | Add /etc/containerd/runsc.toml to conffiles attribute.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "debian/BUILD",
"new_path": "debian/BUILD",
"diff": "@@ -29,6 +29,9 @@ pkg_deb(\narm64 = \"arm64\",\n),\nchanges = \"runsc.changes\",\n+ conffiles = [\n+ \"/etc/containerd/runsc.toml\",\n+ ],\ndata = \":debian-data\",\ndeb = \"runsc.deb\",\n# Note that the desc... | Go | Apache License 2.0 | google/gvisor | Add /etc/containerd/runsc.toml to conffiles attribute.
Fixes #5817
PiperOrigin-RevId: 368060056 |
259,907 | 12.04.2021 13:51:11 | 25,200 | 982fc8b5765795493c25f07d5f86c20a4fc940c1 | [op] Use faster go_marshal methods in netfilter.
Use MarshalUnsafe for packed types as it is faster than MarshalBytes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netfilter.go",
"new_path": "pkg/abi/linux/netfilter.go",
"diff": "@@ -145,13 +145,13 @@ func (ke *KernelIPTEntry) SizeBytes() int {\n// MarshalBytes implements marshal.Marshallable.MarshalBytes.\nfunc (ke *KernelIPTEntry) MarshalBytes(dst []byte)... | Go | Apache License 2.0 | google/gvisor | [op] Use faster go_marshal methods in netfilter.
Use MarshalUnsafe for packed types as it is faster than MarshalBytes.
PiperOrigin-RevId: 368076368 |
259,985 | 12.04.2021 15:10:19 | 25,200 | f4f6ce337aa8ceb46a5a8f783efb770c9a8a2858 | Don't grab TaskSet mu recursively when reading task state.
Reported-by:
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -1854,7 +1854,7 @@ func (k *Kernel) Release() {\nfunc (k *Kernel) PopulateNewCgroupHierarchy(root Cgroup) {\nk.tasks.mu.RLock()\nk.tasks.forEachTaskLocked(func(t *Task) {\n- i... | Go | Apache License 2.0 | google/gvisor | Don't grab TaskSet mu recursively when reading task state.
Reported-by: syzbot+a6ef0f95a2c9e7da26f3@syzkaller.appspotmail.com
Reported-by: syzbot+2eaf8a9f115edec468fe@syzkaller.appspotmail.com
PiperOrigin-RevId: 368093861 |
260,001 | 12.04.2021 15:24:49 | 25,200 | c4c6a71fb9d5ed51d0e9e2d6a78eaabf96174849 | Add DecRef for verity FDs that were missing
Some FileDescriptions in verity fs were opened but DecRef() were missing
after used. This could result in a ref leak. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -229,6 +229,8 @@ func (fs *filesystem) verifyChildLocked(ctx context.Context, parent *dentry, chi\nreturn nil, err\n}\n+ defer parentMerkleFD.DecRef(ctx)... | Go | Apache License 2.0 | google/gvisor | Add DecRef for verity FDs that were missing
Some FileDescriptions in verity fs were opened but DecRef() were missing
after used. This could result in a ref leak.
PiperOrigin-RevId: 368096759 |
259,884 | 12.04.2021 17:54:25 | 25,200 | 90900e4f8f6760f1de34e660030a0155cfd6b40a | Don't mark exported PRs as stale. | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/stale.yml",
"new_path": ".github/workflows/stale.yml",
"diff": "@@ -15,7 +15,7 @@ jobs:\nstale-issue-label: 'stale'\nstale-pr-label: 'stale'\nexempt-issue-labels: 'exported, type: bug, type: cleanup, type: enhancement, type: process, type: pr... | Go | Apache License 2.0 | google/gvisor | Don't mark exported PRs as stale.
PiperOrigin-RevId: 368121539 |
259,975 | 14.04.2021 11:27:05 | 25,200 | 5c1052b6bb2658208f1afaf423aeac98f30235c1 | [syserror] Remove syserror from go_marshal | [
{
"change_type": "MODIFY",
"old_path": "pkg/gohacks/BUILD",
"new_path": "pkg/gohacks/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\")\n+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\npackage(licenses = [\"notice\"])\n@@ -10,3 +10,11 @@ go_library(\nstateify = False,\nvisibility... | Go | Apache License 2.0 | google/gvisor | [syserror] Remove syserror from go_marshal
PiperOrigin-RevId: 368470656 |
260,003 | 14.04.2021 13:23:31 | 25,200 | 272d2e1168733fa7707ad21fca6f7a847f34bf1b | Make the generated test binary name match the target name | [
{
"change_type": "MODIFY",
"old_path": "test/runner/defs.bzl",
"new_path": "test/runner/defs.bzl",
"diff": "@@ -4,7 +4,7 @@ load(\"//tools:defs.bzl\", \"default_platform\", \"platforms\")\ndef _runner_test_impl(ctx):\n# Generate a runner binary.\n- runner = ctx.actions.declare_file(\"%s-runner\" % c... | Go | Apache License 2.0 | google/gvisor | Make the generated test binary name match the target name
PiperOrigin-RevId: 368495641 |
259,860 | 15.04.2021 16:29:15 | 25,200 | b5919d3065a28c1fd6f27612bafd28f06bf3f0d0 | Generate notification when closing host fd.
Thanks ianlewis@ for discovering the bug/fix! | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/host.go",
"new_path": "pkg/sentry/fsimpl/host/host.go",
"diff": "@@ -460,6 +460,9 @@ func (i *inode) DecRef(ctx context.Context) {\nif err := unix.Close(i.hostFD); err != nil {\nlog.Warningf(\"failed to close host fd %d: %v\", i.hostFD, ... | Go | Apache License 2.0 | google/gvisor | Generate notification when closing host fd.
Thanks ianlewis@ for discovering the bug/fix!
PiperOrigin-RevId: 368740744 |
259,992 | 15.04.2021 17:02:51 | 25,200 | 2e5022974908669d55cf7f47ff8fb7ff5c70c34c | Add S/R logic for host.ConnectedEndpoint
Otherwise ConnectedEndpoint.sndbuf will be restored as 0 and writes
to the socket will fail with EAGAIN. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/host/save_restore.go",
"new_path": "pkg/sentry/fsimpl/host/save_restore.go",
"diff": "@@ -68,3 +68,10 @@ func (i *inode) afterLoad() {\n}\n}\n}\n+\n+// afterLoad is invoked by stateify.\n+func (c *ConnectedEndpoint) afterLoad() {\n+ if err :=... | Go | Apache License 2.0 | google/gvisor | Add S/R logic for host.ConnectedEndpoint
Otherwise ConnectedEndpoint.sndbuf will be restored as 0 and writes
to the socket will fail with EAGAIN.
PiperOrigin-RevId: 368746660 |
259,891 | 15.04.2021 17:13:34 | 25,200 | 19dfc4f7af2bd1f204d1973d3e3ced1f1adf615e | Reduce tcp_x_test runtime and memory usage
Reduce the ephemeral port range, which decreases the calls to makeEP. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"new_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"diff": "@@ -4899,7 +4899,13 @@ func TestConnectAvoidsBoundPorts(t *testing.T) {\nt.Fatalf(\"unknown address type: '%s'\", candidateAddressType)\n}\n- start, end := s.Port... | Go | Apache License 2.0 | google/gvisor | Reduce tcp_x_test runtime and memory usage
Reduce the ephemeral port range, which decreases the calls to makeEP.
PiperOrigin-RevId: 368748379 |
259,860 | 15.04.2021 17:23:47 | 25,200 | 82dc881dba7399afa4268c5e3a70624db0b1e7ee | Disable failing socket_ipv4_udp_unbound_loopback_test_linux tests. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ipv4_udp_unbound.cc",
"new_path": "test/syscalls/linux/socket_ipv4_udp_unbound.cc",
"diff": "@@ -80,6 +80,8 @@ TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackNoGroup) {\n// Check that not setting a default send interface prevent... | Go | Apache License 2.0 | google/gvisor | Disable failing socket_ipv4_udp_unbound_loopback_test_linux tests.
PiperOrigin-RevId: 368749894 |
259,896 | 15.04.2021 20:01:04 | 25,200 | 14b7d775c950070378ea799a0b6b7907f67a1f1e | Add field support to the sentry metrics.
Fields allow counter metrics to have multiple tabular values.
At most one field is supported at the moment. | [
{
"change_type": "MODIFY",
"old_path": "pkg/metric/metric.go",
"new_path": "pkg/metric/metric.go",
"diff": "@@ -38,7 +38,7 @@ var (\n)\n// Uint64Metric encapsulates a uint64 that represents some kind of metric to be\n-// monitored.\n+// monitored. We currently support metrics with at most one field.... | Go | Apache License 2.0 | google/gvisor | Add field support to the sentry metrics.
Fields allow counter metrics to have multiple tabular values.
At most one field is supported at the moment.
PiperOrigin-RevId: 368767040 |
260,001 | 15.04.2021 22:10:17 | 25,200 | c980fe573d7a3488dc27c58f84aecf9ae1814f49 | Add verity ioctl test for mount with root hash | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/verity_ioctl.cc",
"new_path": "test/syscalls/linux/verity_ioctl.cc",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n+#include <stdint.h>\n#include <sys/mount.h>\n+#include... | Go | Apache License 2.0 | google/gvisor | Add verity ioctl test for mount with root hash
PiperOrigin-RevId: 368779532 |
259,860 | 16.04.2021 14:26:49 | 25,200 | 81ff6bd9213ebb6752fae97fcbc6037323fa6811 | Use size_t instead of C integer types. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/proc_net.cc",
"new_path": "test/syscalls/linux/proc_net.cc",
"diff": "@@ -419,14 +419,14 @@ TEST(ProcNetSnmp, CheckNetStat) {\nint name_count = 0;\nint value_count = 0;\nstd::vector<absl::string_view> lines = absl::StrSplit(contents, '\\n')... | Go | Apache License 2.0 | google/gvisor | Use size_t instead of C integer types.
PiperOrigin-RevId: 368919557 |
259,898 | 16.04.2021 16:22:09 | 25,200 | 6241f89f49820c193213b2d395bb09030409166d | Include logs for packetimpact tests that are expected to fail | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/dut.go",
"new_path": "test/packetimpact/runner/dut.go",
"diff": "@@ -369,7 +369,6 @@ func TestWithDUT(ctx context.Context, t *testing.T, mkDevice func(*dockerutil.Co\n\"--dut_infos_json\", string(dutInfosBytes),\n)\ntestbenchLogs, err ... | Go | Apache License 2.0 | google/gvisor | Include logs for packetimpact tests that are expected to fail
PiperOrigin-RevId: 368938936 |
259,891 | 16.04.2021 16:26:31 | 25,200 | 32c18f443f567dac21465b3999d1a18b886891d1 | Enlarge port range and fix integer overflow
Also count failed TCP port allocations | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -242,6 +242,7 @@ var Metrics = tcpip.Stats{\nFastRetransmit: mustCreateMetric(\"/netstack/tcp/fast_retransmit\", \"Number of TCP segments which were fast... | Go | Apache License 2.0 | google/gvisor | Enlarge port range and fix integer overflow
Also count failed TCP port allocations
PiperOrigin-RevId: 368939619 |
259,853 | 19.04.2021 12:59:32 | 25,200 | b0333d33a206b3a3cf3bcc90e44793708ed5cb7a | Optimize safemem.Zero
There is a loop that fills a byte array with zero-s. Let's use copy() instead
of setting elements one by one.
The new implementation is two time faster than the previous one and it is more
than 10x faster with the race detector.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/safemem/BUILD",
"new_path": "pkg/safemem/BUILD",
"diff": "@@ -14,6 +14,7 @@ go_library(\ndeps = [\n\"//pkg/gohacks\",\n\"//pkg/safecopy\",\n+ \"//pkg/sync\",\n\"@org_golang_x_sys//unix:go_default_library\",\n],\n)\n"
},
{
"change_type": "MODIFY",
... | Go | Apache License 2.0 | google/gvisor | Optimize safemem.Zero
There is a loop that fills a byte array with zero-s. Let's use copy() instead
of setting elements one by one.
The new implementation is two time faster than the previous one and it is more
than 10x faster with the race detector.
Reported-by: syzbot+5f57d988a5f929af5a91@syzkaller.appspotmail.com
PiperOrigin-RevId: 369283919 |
260,001 | 19.04.2021 18:48:47 | 25,200 | 82eecd2e93a4d2c42ca2b0b88f721f186c8712d9 | Change verity action to be a fs member
Currently the verity action is a global variable, which causes the same
action for all verity mounts, and is overwritten for each new verity
mount. Changed it to a member of verity fs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"new_path": "pkg/sentry/fsimpl/verity/filesystem.go",
"diff": "@@ -200,7 +200,7 @@ func (fs *filesystem) verifyChildLocked(ctx context.Context, parent *dentry, chi\n// contains the expected xattrs. If the file or the xa... | Go | Apache License 2.0 | google/gvisor | Change verity action to be a fs member
Currently the verity action is a global variable, which causes the same
action for all verity mounts, and is overwritten for each new verity
mount. Changed it to a member of verity fs.
PiperOrigin-RevId: 369348522 |
259,951 | 20.04.2021 00:26:54 | 25,200 | 2c8379d95738bb2bc10d2cc7cead6889379e244c | Expose header methods that validate checksums
This is done for IPv4, UDP and TCP headers.
This also changes the packet checkers used in tests to error on
zero-checksum, not sure why it was allowed before.
And while I'm here, make comments' case consistent.
RELNOTES: n/a
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/checker/checker.go",
"new_path": "pkg/tcpip/checker/checker.go",
"diff": "@@ -53,9 +53,8 @@ func IPv4(t *testing.T, b []byte, checkers ...NetworkChecker) {\nt.Error(\"Not a valid IPv4 packet\")\n}\n- xsum := ipv4.CalculateChecksum()\n- if xsum != 0 &... | Go | Apache License 2.0 | google/gvisor | Expose header methods that validate checksums
This is done for IPv4, UDP and TCP headers.
This also changes the packet checkers used in tests to error on
zero-checksum, not sure why it was allowed before.
And while I'm here, make comments' case consistent.
RELNOTES: n/a
Fixes #5049
PiperOrigin-RevId: 369383862 |
259,985 | 21.04.2021 13:34:51 | 25,200 | e3a5da8ce62826f56c0b531590bb472ea717eeac | Stub the custom "job" controller required by some workloads. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/BUILD",
"new_path": "pkg/sentry/fsimpl/cgroupfs/BUILD",
"diff": "@@ -23,6 +23,7 @@ go_library(\n\"cpuacct.go\",\n\"cpuset.go\",\n\"dir_refs.go\",\n+ \"job.go\",\n\"memory.go\",\n],\nvisibility = [\"//pkg/sentry:internal\"],\n"
},
... | Go | Apache License 2.0 | google/gvisor | Stub the custom "job" controller required by some workloads.
PiperOrigin-RevId: 369724358 |
260,001 | 22.04.2021 11:10:35 | 25,200 | dbfdb31e8a014e5e11092de121e825b21c2804c3 | Add verity tests for modified file/Merkle file | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/verity_ioctl.cc",
"new_path": "test/syscalls/linux/verity_ioctl.cc",
"diff": "// limitations under the License.\n#include <stdint.h>\n+#include <stdlib.h>\n#include <sys/mount.h>\n+#include <time.h>\n#include <iomanip>\n#include <sstream>\n... | Go | Apache License 2.0 | google/gvisor | Add verity tests for modified file/Merkle file
PiperOrigin-RevId: 369909691 |
259,985 | 22.04.2021 15:50:01 | 25,200 | d93907110eebdfb1e51dacd9ccffd0f0c2633a81 | Also report mount options through /proc/<pid>/mounts. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -826,6 +826,9 @@ func (vfs *VirtualFilesystem) GenerateProcMounts(ctx context.Context, taskRootDi\nif mnt.Flags.NoExec {\nopts += \",noexec\"\n}\n+ if mopts := mnt.fs.Impl().MountOpti... | Go | Apache License 2.0 | google/gvisor | Also report mount options through /proc/<pid>/mounts.
PiperOrigin-RevId: 369967629 |
259,896 | 22.04.2021 16:04:40 | 25,200 | 0a6eaed50b83a35a687699aa5e871b80605c9f46 | Add weirdness sentry metric.
Weirdness metric contains fields to track the number of clock fallback,
partial result and vsyscalls. This metric will avoid the overhead of
having three different metrics (fallbackMetric, partialResultMetric,
vsyscallCount). | [
{
"change_type": "MODIFY",
"old_path": "pkg/metric/metric.go",
"new_path": "pkg/metric/metric.go",
"diff": "@@ -35,6 +35,11 @@ var (\n// ErrInitializationDone indicates that the caller tried to create a\n// new metric after initialization.\nErrInitializationDone = errors.New(\"metric cannot be creat... | Go | Apache License 2.0 | google/gvisor | Add weirdness sentry metric.
Weirdness metric contains fields to track the number of clock fallback,
partial result and vsyscalls. This metric will avoid the overhead of
having three different metrics (fallbackMetric, partialResultMetric,
vsyscallCount).
PiperOrigin-RevId: 369970218 |
259,992 | 22.04.2021 18:36:15 | 25,200 | d1859fe179bae1614ba91a45497ad63400210863 | Add mlock syscall test | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -3,6 +3,8 @@ load(\"//test/runner:defs.bzl\", \"syscall_test\")\npackage(licenses = [\"notice\"])\n+# Please keep syscall tests ordered alphabetically by name.\n+\nsyscall_test(\ntest = \"//t... | Go | Apache License 2.0 | google/gvisor | Add mlock syscall test
PiperOrigin-RevId: 369993733 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.