author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,992 | 22.04.2021 20:04:17 | 25,200 | 9e4aa04ad1f6e63f4aa99f516b19e4ff2592918b | Remove side effect from mount tests
Dropping CAP_SYS_ADMIN and not restoring it causes
other tests to be skipped. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/mount.cc",
"new_path": "test/syscalls/linux/mount.cc",
"diff": "@@ -67,9 +67,7 @@ TEST(MountTest, MountInvalidTarget) {\nTEST(MountTest, MountPermDenied) {\n// Clear CAP_SYS_ADMIN.\n- if (ASSERT_NO_ERRNO_AND_VALUE(HaveCapability(CAP_SYS_ADM... | Go | Apache License 2.0 | google/gvisor | Remove side effect from mount tests
Dropping CAP_SYS_ADMIN and not restoring it causes
other tests to be skipped.
PiperOrigin-RevId: 370002644 |
259,853 | 23.04.2021 16:43:03 | 25,200 | 80cd26c2f43e78d43e2ff769cf0449e67254e673 | hostinet: parse the timeval structure from a SO_TIMESTAMP control message | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket.go",
"new_path": "pkg/sentry/socket/hostinet/socket.go",
"diff": "@@ -528,7 +528,9 @@ func parseUnixControlMessages(unixControlMessages []unix.SocketControlMessage) s\nswitch unixCmsg.Header.Type {\ncase linux.SO_TIMESTAMP:\nc... | Go | Apache License 2.0 | google/gvisor | hostinet: parse the timeval structure from a SO_TIMESTAMP control message
PiperOrigin-RevId: 370181621 |
260,001 | 23.04.2021 23:58:56 | 25,200 | bf64560681182b0024790f683f4c9aea142e70c5 | Add verity tests for stat, deleted/renamed file | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/verity_ioctl.cc",
"new_path": "test/syscalls/linux/verity_ioctl.cc",
"diff": "#include <stdint.h>\n#include <stdlib.h>\n#include <sys/mount.h>\n+#include <sys/stat.h>\n#include <time.h>\n#include <iomanip>\n@@ -272,6 +273,72 @@ TEST_F(Ioctl... | Go | Apache License 2.0 | google/gvisor | Add verity tests for stat, deleted/renamed file
PiperOrigin-RevId: 370219558 |
259,858 | 26.04.2021 16:25:26 | 25,200 | 36fdc6c9ef565be34f5ab27affed31eb2430e89a | Handle tmpfs with 5 fields in /proc/mounts parsing. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/mount.cc",
"new_path": "test/syscalls/linux/mount.cc",
"diff": "@@ -45,6 +45,7 @@ namespace testing {\nnamespace {\n+using ::testing::AnyOf;\nusing ::testing::Contains;\nusing ::testing::Pair;\n@@ -360,7 +361,8 @@ TEST(MountTest, MountInfo)... | Go | Apache License 2.0 | google/gvisor | Handle tmpfs with 5 fields in /proc/mounts parsing.
PiperOrigin-RevId: 370565903 |
259,896 | 26.04.2021 17:35:16 | 25,200 | 5b207fe7834d9c6541bd99bf75e3dfeebce2d9d5 | Remove metrics: fallback, vsyscallCount and partialResult
The newly added Weirdness metric with fields should be used instead of them.
Simple query for weirdness metric: | [
{
"change_type": "MODIFY",
"old_path": "pkg/metric/metric.go",
"new_path": "pkg/metric/metric.go",
"diff": "@@ -37,7 +37,7 @@ var (\nErrInitializationDone = errors.New(\"metric cannot be created after initialization is complete\")\n// WeirdnessMetric is a metric with fields created to track the numb... | Go | Apache License 2.0 | google/gvisor | Remove metrics: fallback, vsyscallCount and partialResult
The newly added Weirdness metric with fields should be used instead of them.
Simple query for weirdness metric: http://shortn/_DGNk0z2Up6
PiperOrigin-RevId: 370578132 |
259,875 | 27.04.2021 12:05:30 | 25,200 | 9ec49aabd34ecf9eba982439abd2ada4617d576a | Fix SyscallInfo for epoll_pwait in strace. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/linux64_amd64.go",
"new_path": "pkg/sentry/strace/linux64_amd64.go",
"diff": "@@ -305,7 +305,7 @@ var linuxAMD64 = SyscallMap{\n278: makeSyscallInfo(\"vmsplice\", FD, Hex, Hex, Hex),\n279: makeSyscallInfo(\"move_pages\", Hex, Hex, Hex, Hex, H... | Go | Apache License 2.0 | google/gvisor | Fix SyscallInfo for epoll_pwait in strace.
PiperOrigin-RevId: 370733869 |
259,992 | 28.04.2021 14:41:59 | 25,200 | 704728d38fdb3ceaf8dfbfdba84eee183775b90c | Disable test that is always skipped | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/raw_socket_hdrincl.cc",
"new_path": "test/syscalls/linux/raw_socket_hdrincl.cc",
"diff": "@@ -177,10 +177,8 @@ TEST_F(RawHDRINCL, ConnectToLoopback) {\nSyscallSucceeds());\n}\n-TEST_F(RawHDRINCL, SendWithoutConnectSucceeds) {\n// FIXME(gvis... | Go | Apache License 2.0 | google/gvisor | Disable test that is always skipped
PiperOrigin-RevId: 370989166 |
259,884 | 28.04.2021 16:18:21 | 25,200 | 39fdf0b950e2161247b60d8576151c6015a3b47c | Use containerd v2 config format in docs
Fixes | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/containerd/configuration.md",
"new_path": "g3doc/user_guide/containerd/configuration.md",
"diff": "@@ -14,6 +14,7 @@ cat <<EOF | sudo tee /etc/containerd/runsc.toml\noption = \"value\"\n[runsc_config]\nflag = \"value\"\n+EOF\n```\nThe set of o... | Go | Apache License 2.0 | google/gvisor | Use containerd v2 config format in docs
Fixes #5170
PiperOrigin-RevId: 371007691 |
259,992 | 29.04.2021 11:23:19 | 25,200 | 2e442f908142d175e95226e3ad5892902921f8fd | Remove ResolvingPath.Restart | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/resolving_path.go",
"new_path": "pkg/sentry/vfs/resolving_path.go",
"diff": "@@ -46,11 +46,8 @@ type ResolvingPath struct {\nflags uint16\nmustBeDir bool // final file must be a directory?\n- mustBeDirOrig bool\nsymlinks uint8 // number of symli... | Go | Apache License 2.0 | google/gvisor | Remove ResolvingPath.Restart
PiperOrigin-RevId: 371163405 |
260,003 | 29.04.2021 11:41:12 | 25,200 | a41c5fe217e6c40e563669e0a888b33bc125fa88 | netstack: Rename pkt.Data().TrimFront() to DeleteFront(), and ...
... it may now invalidate backing slice references
This is currently safe because TrimFront() in VectorisedView only shrinks the
view. This may not hold under the a different buffer implementation.
Reordering method calls order to allow this. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/icmp.go",
"new_path": "pkg/tcpip/network/ipv4/icmp.go",
"diff": "@@ -163,10 +163,12 @@ func (e *endpoint) handleControl(errInfo stack.TransportError, pkt *stack.Packet\nreturn\n}\n- // Skip the ip header, then deliver the error.\n- pkt.D... | Go | Apache License 2.0 | google/gvisor | netstack: Rename pkt.Data().TrimFront() to DeleteFront(), and ...
... it may now invalidate backing slice references
This is currently safe because TrimFront() in VectorisedView only shrinks the
view. This may not hold under the a different buffer implementation.
Reordering method calls order to allow this.
PiperOrigin-RevId: 371167610 |
260,001 | 29.04.2021 13:59:39 | 25,200 | 669523f7d225006d1fbc7c6a2b347736019908e2 | Remove outdated TODOs in verity | [
{
"change_type": "MODIFY",
"old_path": "pkg/merkletree/merkletree.go",
"new_path": "pkg/merkletree/merkletree.go",
"diff": "@@ -36,7 +36,6 @@ const (\n)\n// DigestSize returns the size (in bytes) of a digest.\n-// TODO(b/156980949): Allow config SHA384.\nfunc DigestSize(hashAlgorithm int) int {\nswi... | Go | Apache License 2.0 | google/gvisor | Remove outdated TODOs in verity
PiperOrigin-RevId: 371198372 |
259,875 | 29.04.2021 15:19:22 | 25,200 | eefa00f4aecc7c72a1866357fbd1bbb58aa6fc5e | Implement epoll_pwait2. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/linux64_amd64.go",
"new_path": "pkg/sentry/strace/linux64_amd64.go",
"diff": "@@ -371,6 +371,7 @@ var linuxAMD64 = SyscallMap{\n433: makeSyscallInfo(\"fspick\", FD, Path, Hex),\n434: makeSyscallInfo(\"pidfd_open\", Hex, Hex),\n435: makeSyscal... | Go | Apache License 2.0 | google/gvisor | Implement epoll_pwait2.
PiperOrigin-RevId: 371216407 |
259,992 | 29.04.2021 16:40:57 | 25,200 | c958c5a4f103725ddbb87f6db66cca9beb06cb84 | Fix up TODOs in the code | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/forwarding_test.go",
"new_path": "pkg/tcpip/stack/forwarding_test.go",
"diff": "@@ -101,7 +101,7 @@ func (f *fwdTestNetworkEndpoint) HandlePacket(pkt *PacketBuffer) {\nReserveHeaderBytes: int(r.MaxHeaderLength()),\nData: vv.ToView().ToVectorise... | Go | Apache License 2.0 | google/gvisor | Fix up TODOs in the code
PiperOrigin-RevId: 371231148 |
260,001 | 30.04.2021 13:25:00 | 25,200 | ea89cd38a11fc63b3ff397c9f5901fa541c8acb4 | Do not return content if verity translate fails
If verification fails for translating mmapped memory, the content should
not be returned. This is not an issue for panic mode, but for error mode
we should return empty content along with the error. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/verity.go",
"new_path": "pkg/sentry/fsimpl/verity/verity.go",
"diff": "@@ -1328,7 +1328,7 @@ func (fd *fileDescription) TestPOSIX(ctx context.Context, uid fslock.UniqueID, t\nfunc (fd *fileDescription) Translate(ctx context.Context, re... | Go | Apache License 2.0 | google/gvisor | Do not return content if verity translate fails
If verification fails for translating mmapped memory, the content should
not be returned. This is not an issue for panic mode, but for error mode
we should return empty content along with the error.
PiperOrigin-RevId: 371393519 |
260,004 | 30.04.2021 17:03:25 | 25,200 | eb2b39f70287b2ee54127699fa34a06484aaed8b | Comment ip package in a single place
Fixes the below linting error:
```
From Golint:
> Package ip has package comment defined in multiple places:
> duplicate_address_detection.go
> generic_multicast_protocol.go
``` | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/ip/generic_multicast_protocol.go",
"new_path": "pkg/tcpip/network/internal/ip/generic_multicast_protocol.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n-// Pac... | Go | Apache License 2.0 | google/gvisor | Comment ip package in a single place
Fixes the below linting error:
```
From Golint:
> Package ip has package comment defined in multiple places:
> duplicate_address_detection.go
> generic_multicast_protocol.go
```
PiperOrigin-RevId: 371430486 |
259,891 | 30.04.2021 17:55:54 | 25,200 | 6fb8c01bb488e22c741a307e030b61c512dcd34f | Fix //test/syscalls:tcp_socket_test_native
The data written was larger than the write buffer, and nobody was reading the
other end. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -3710,6 +3710,7 @@ cc_binary(\ndeps = [\n\":socket_test_util\",\n\"//test/util:file_descriptor\",\n+ \"@com_google_absl//absl/strings\",\n\"@com_google_absl//absl/time\",\ngtest,\... | Go | Apache License 2.0 | google/gvisor | Fix //test/syscalls:tcp_socket_test_native
The data written was larger than the write buffer, and nobody was reading the
other end.
PiperOrigin-RevId: 371436084 |
259,992 | 03.05.2021 13:47:45 | 25,200 | 1947c873423cabcaf5e67b667542421ade7414ff | Fix deadlock in /proc/[pid]/fd/[num]
In order to resolve path names, fsSymlink.Readlink() may need to reenter
kernfs. Change the code so that kernfs.Inode.Readlink() is called without
locks and document the new contract. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"diff": "@@ -612,16 +612,24 @@ afterTrailingSymlink:\n// ReadlinkAt implements vfs.FilesystemImpl.ReadlinkAt.\nfunc (fs *Filesystem) ReadlinkAt(ctx context.Context, ... | Go | Apache License 2.0 | google/gvisor | Fix deadlock in /proc/[pid]/fd/[num]
In order to resolve path names, fsSymlink.Readlink() may need to reenter
kernfs. Change the code so that kernfs.Inode.Readlink() is called without
locks and document the new contract.
PiperOrigin-RevId: 371770222 |
259,860 | 03.05.2021 14:20:19 | 25,200 | 1d92396aaa958d171ee83933612c8d156f427d4a | Temporarily disable atime/mtime check in utimensat test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/utimes.cc",
"new_path": "test/syscalls/linux/utimes.cc",
"diff": "@@ -225,7 +225,8 @@ void TestUtimensat(int dirFd, std::string const& path) {\nEXPECT_GE(mtime3, before);\nEXPECT_LE(mtime3, after);\n- EXPECT_EQ(atime3, mtime3);\n+ // TODO(b... | Go | Apache License 2.0 | google/gvisor | Temporarily disable atime/mtime check in utimensat test.
PiperOrigin-RevId: 371776583 |
260,003 | 03.05.2021 16:31:19 | 25,200 | 4218ba6fb4282b4466ddda05c2ea1ffec837e079 | netstack: Add a test for mixed Push/Consume
Not really designed to be used this way, but it works and it's been relied
upon. Add a test. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/packet_buffer_test.go",
"new_path": "pkg/tcpip/stack/packet_buffer_test.go",
"diff": "@@ -112,23 +112,13 @@ func TestPacketHeaderPush(t *testing.T) {\nif got, want := pk.Size(), allHdrSize+len(test.data); got != want {\nt.Errorf(\"After pk.Size... | Go | Apache License 2.0 | google/gvisor | netstack: Add a test for mixed Push/Consume
Not really designed to be used this way, but it works and it's been relied
upon. Add a test.
PiperOrigin-RevId: 371802756 |
260,004 | 03.05.2021 16:38:51 | 25,200 | f0b3298db07df63fa74559d5689008f9de9980a9 | Convey GSO capabilities through GSOEndpoint
...as all GSO capable endpoints must implement GSOEndpoint. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/channel/channel.go",
"new_path": "pkg/tcpip/link/channel/channel.go",
"diff": "@@ -123,6 +123,9 @@ func (q *queue) RemoveNotify(handle *NotificationHandle) {\nq.notify = notify\n}\n+var _ stack.LinkEndpoint = (*Endpoint)(nil)\n+var _ stack.GSOEn... | Go | Apache License 2.0 | google/gvisor | Convey GSO capabilities through GSOEndpoint
...as all GSO capable endpoints must implement GSOEndpoint.
PiperOrigin-RevId: 371804175 |
260,004 | 03.05.2021 16:44:02 | 25,200 | 279f9fcee763a52d210f8269bc4c871b7eee112f | Implement standard clock safely
Previously, tcpip.StdClock depended on linking with the unexposed method
time.now to implement tcpip.Clock using the time package. This change
updates the standard clock to not require manually linking to this
unexported method and use publicly documented functions from the time
package. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/BUILD",
"new_path": "pkg/tcpip/BUILD",
"diff": "@@ -22,8 +22,9 @@ go_library(\n\"errors.go\",\n\"sock_err_list.go\",\n\"socketops.go\",\n+ \"stdclock.go\",\n+ \"stdclock_state.go\",\n\"tcpip.go\",\n- \"time_unsafe.go\",\n\"timer.go\",\n],\nvisibility... | Go | Apache License 2.0 | google/gvisor | Implement standard clock safely
Previously, tcpip.StdClock depended on linking with the unexposed method
time.now to implement tcpip.Clock using the time package. This change
updates the standard clock to not require manually linking to this
unexported method and use publicly documented functions from the time
package.
PiperOrigin-RevId: 371805101 |
259,860 | 04.05.2021 11:53:02 | 25,200 | dd3875eabecc479d83cb66828a4163c37458170e | Increase error margin for memory accounting test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/memory_accounting.cc",
"new_path": "test/syscalls/linux/memory_accounting.cc",
"diff": "@@ -83,7 +83,7 @@ TEST(MemoryAccounting, AnonAccountingPreservedOnSaveRestore) {\nuint64_t anon_after_alloc = ASSERT_NO_ERRNO_AND_VALUE(AnonUsageFromMem... | Go | Apache License 2.0 | google/gvisor | Increase error margin for memory accounting test.
PiperOrigin-RevId: 371963265 |
259,860 | 04.05.2021 15:56:05 | 25,200 | d496c285aacff88bb858e4efd700aa1e0b2ebad1 | Add TODOs to old reference counting utility. | [
{
"change_type": "MODIFY",
"old_path": "pkg/refs/refcounter.go",
"new_path": "pkg/refs/refcounter.go",
"diff": "@@ -30,6 +30,9 @@ import (\n// RefCounter is the interface to be implemented by objects that are reference\n// counted.\n+//\n+// TODO(gvisor.dev/issue/1624): Get rid of most of this packa... | Go | Apache License 2.0 | google/gvisor | Add TODOs to old reference counting utility.
PiperOrigin-RevId: 372012795 |
260,023 | 04.05.2021 16:40:17 | 25,200 | 682415b6d0035a2af0e7981c31b728762e15bf10 | Use cmp.Diff for tcpip.Error comparison | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/dual_stack_test.go",
"new_path": "pkg/tcpip/transport/tcp/dual_stack_test.go",
"diff": "@@ -19,6 +19,7 @@ import (\n\"testing\"\n\"time\"\n+ \"github.com/google/go-cmp/cmp\"\n\"gvisor.dev/gvisor/pkg/tcpip\"\n\"gvisor.dev/gvisor/pkg/tcpi... | Go | Apache License 2.0 | google/gvisor | Use cmp.Diff for tcpip.Error comparison
PiperOrigin-RevId: 372021039 |
259,891 | 04.05.2021 16:49:11 | 25,200 | 689b369f5788c15f9b018246baa4e318082c0d79 | tcp_socket_test: replace tcp_wmem with SO_SNDBUF | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -3710,7 +3710,6 @@ cc_binary(\ndeps = [\n\":socket_test_util\",\n\"//test/util:file_descriptor\",\n- \"@com_google_absl//absl/strings\",\n\"@com_google_absl//absl/time\",\ngtest,\... | Go | Apache License 2.0 | google/gvisor | tcp_socket_test: replace tcp_wmem with SO_SNDBUF
PiperOrigin-RevId: 372022596 |
259,985 | 04.05.2021 17:38:00 | 25,200 | 5960674c8fe086413c3ef88b29fbb4c6f4c4ca3f | Document how to handle build failures from go-marshal verbosity.
With debugging enabled, go-marshal can generate too much output for
bazel under default configurations, which can cause builds to
fail. The limit defaults to 1 MB. | [
{
"change_type": "MODIFY",
"old_path": "tools/go_marshal/README.md",
"new_path": "tools/go_marshal/README.md",
"diff": "@@ -140,3 +140,6 @@ options, depending on how go-marshal is being invoked:\n- Set `debug = True` on the `go_marshal` BUILD rule.\n- Pass `-debug` to the go-marshal tool invocation.... | Go | Apache License 2.0 | google/gvisor | Document how to handle build failures from go-marshal verbosity.
With debugging enabled, go-marshal can generate too much output for
bazel under default configurations, which can cause builds to
fail. The limit defaults to 1 MB.
PiperOrigin-RevId: 372030402 |
259,907 | 05.05.2021 00:00:52 | 25,200 | d924515b0991a3a14e0b0d7d21268eaed6fafb5b | [perf] Fix profiling in benchmarking jobs.
Due to the docker daemon is passing
the incorrect `--root` flag to runsc. So our profiler is not able to find the
container stat files where it expects them to be. | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/dockerutil/profile.go",
"new_path": "pkg/test/dockerutil/profile.go",
"diff": "@@ -82,10 +82,15 @@ func (p *profile) createProcess(c *Container) error {\n}\n// The root directory of this container's runtime.\n- root := fmt.Sprintf(\"--root=/var/run/do... | Go | Apache License 2.0 | google/gvisor | [perf] Fix profiling in benchmarking jobs.
Due to https://github.com/moby/moby/issues/42345, the docker daemon is passing
the incorrect `--root` flag to runsc. So our profiler is not able to find the
container stat files where it expects them to be.
PiperOrigin-RevId: 372067954 |
259,891 | 18.03.2021 15:38:13 | 25,200 | 4c9340fcbf0cb10c230925e24f082478f7c458a0 | Fix alignment issue with 64-bit atomics on 32 bit machines | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/BUILD",
"new_path": "pkg/tcpip/BUILD",
"diff": "@@ -19,6 +19,8 @@ go_template_instance(\ngo_library(\nname = \"tcpip\",\nsrcs = [\n+ \"aligned.go\",\n+ \"aligned_unsafe.go\",\n\"errors.go\",\n\"sock_err_list.go\",\n\"socketops.go\",\n"
},
{
"... | Go | Apache License 2.0 | google/gvisor | Fix alignment issue with 64-bit atomics on 32 bit machines |
259,891 | 19.03.2021 13:44:26 | 25,200 | 1e2ba2666135e7f28cb3c4185add5a257ad53637 | Moved to atomicbitops and renamed files | [
{
"change_type": "MODIFY",
"old_path": "pkg/atomicbitops/BUILD",
"new_path": "pkg/atomicbitops/BUILD",
"diff": "@@ -5,6 +5,8 @@ package(licenses = [\"notice\"])\ngo_library(\nname = \"atomicbitops\",\nsrcs = [\n+ \"aligned_32bit_unsafe.go\",\n+ \"aligned_64bit.go\",\n\"atomicbitops.go\",\n\"atomicbi... | Go | Apache License 2.0 | google/gvisor | Moved to atomicbitops and renamed files |
259,891 | 05.04.2021 11:54:50 | 25,200 | eded0d28de7f62423e496d89fd2699bb02e2744f | mark types as saveable | [
{
"change_type": "MODIFY",
"old_path": "pkg/atomicbitops/aligned_32bit_unsafe.go",
"new_path": "pkg/atomicbitops/aligned_32bit_unsafe.go",
"diff": "@@ -30,6 +30,8 @@ import (\n// for 64-bit alignment of 64-bit words accessed atomically. The first word in\n// a variable or in an allocated struct, arr... | Go | Apache License 2.0 | google/gvisor | mark types as saveable |
259,891 | 06.05.2021 15:01:09 | 25,200 | 66de003e19642b5d6eb6d3f7660ad638271f3477 | fix build constraints | [
{
"change_type": "MODIFY",
"old_path": "pkg/atomicbitops/aligned_64bit.go",
"new_path": "pkg/atomicbitops/aligned_64bit.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n-// +build !arm,!386\n+// +build amd64 arm64\npackage atomi... | Go | Apache License 2.0 | google/gvisor | fix build constraints |
259,878 | 06.05.2021 18:00:49 | 25,200 | 339001204000a3060628256cd9131ea2a2d4e08a | Implement /proc/cmdline
This change implements /proc/cmdline with a basic faux command line
"BOOT_IMAGE=/vmlinuz-[version]-gvisor quiet" so apps that may expect
it do not receive errors.
Also tests for the existence of /proc/cmdline as part of the system
call test suite | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/tasks.go",
"new_path": "pkg/sentry/fsimpl/proc/tasks.go",
"diff": "@@ -65,6 +65,7 @@ var _ kernfs.Inode = (*tasksInode)(nil)\nfunc (fs *filesystem) newTasksInode(ctx context.Context, k *kernel.Kernel, pidns *kernel.PIDNamespace, fakeCgro... | Go | Apache License 2.0 | google/gvisor | Implement /proc/cmdline
This change implements /proc/cmdline with a basic faux command line
"BOOT_IMAGE=/vmlinuz-[version]-gvisor quiet" so apps that may expect
it do not receive errors.
Also tests for the existence of /proc/cmdline as part of the system
call test suite
PiperOrigin-RevId: 372462070 |
259,891 | 07.05.2021 13:51:09 | 25,200 | 314a5f8d7e7402e66ba5d22f79fa13143a7b69d0 | explicitly 0-index backing array | [
{
"change_type": "MODIFY",
"old_path": "pkg/atomicbitops/aligned_32bit_unsafe.go",
"new_path": "pkg/atomicbitops/aligned_32bit_unsafe.go",
"diff": "@@ -40,7 +40,7 @@ func (aa *AlignedAtomicInt64) ptr() *int64 {\n// In the 15-byte aa.value, there are guaranteed to be 8 contiguous\n// bytes with 64-bi... | Go | Apache License 2.0 | google/gvisor | explicitly 0-index backing array |
259,884 | 10.05.2021 17:27:08 | 25,200 | 1699d702cbfcf6f34bd14327b644738f996feb3b | Fix issue reviver
Fixes invocation of the Github issue reviver by including the required 'path'
command line option. Also updates the issue reviver to add a 'revived' label to
revived issues. Issues with a 'revived' label will no longer be marked as
stale. | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/issue_reviver.yml",
"new_path": ".github/workflows/issue_reviver.yml",
"diff": "@@ -11,7 +11,7 @@ jobs:\nsteps:\n- uses: actions/checkout@v2\nif: github.repository == 'google/gvisor'\n- - run: make run TARGETS=\"//tools/github\" ARGS=\"revive... | Go | Apache License 2.0 | google/gvisor | Fix issue reviver
Fixes invocation of the Github issue reviver by including the required 'path'
command line option. Also updates the issue reviver to add a 'revived' label to
revived issues. Issues with a 'revived' label will no longer be marked as
stale.
PiperOrigin-RevId: 373046772 |
259,951 | 11.05.2021 10:23:06 | 25,200 | 60bdf7ed31bc32bb8413cfdb67cd906ca3d5955a | Move multicounter testutil functions out of network/ip
This is in preparation of having aggregated NIC stats at the stack
level. These validation functions will be needed outside of the
network layer packages to test aggregated NIC stats. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/arp/BUILD",
"new_path": "pkg/tcpip/network/arp/BUILD",
"diff": "@@ -47,7 +47,7 @@ go_test(\nlibrary = \":arp\",\ndeps = [\n\"//pkg/tcpip\",\n- \"//pkg/tcpip/network/internal/testutil\",\n\"//pkg/tcpip/stack\",\n+ \"//pkg/tcpip/testutil\",\n],... | Go | Apache License 2.0 | google/gvisor | Move multicounter testutil functions out of network/ip
This is in preparation of having aggregated NIC stats at the stack
level. These validation functions will be needed outside of the
network layer packages to test aggregated NIC stats.
PiperOrigin-RevId: 373180565 |
259,962 | 11.05.2021 10:26:17 | 25,200 | ebebb3059f7c5dbe42af85715f1c51c23461463b | Change AcquireAssignedAddress to use RLock.
This is a hot path for all incoming packets and we don't
need an exclusive lock here as we are not modifying any
of the fields protected by mu here. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -990,8 +990,8 @@ func (e *endpoint) Close() {\n// AddAndAcquirePermanentAddress implements stack.AddressableEndpoint.\nfunc (e *endpoint) AddAndAcquirePermanentAddress(a... | Go | Apache License 2.0 | google/gvisor | Change AcquireAssignedAddress to use RLock.
This is a hot path for all incoming packets and we don't
need an exclusive lock here as we are not modifying any
of the fields protected by mu here.
PiperOrigin-RevId: 373181254 |
259,975 | 11.05.2021 17:21:24 | 25,200 | 49eb3da98aeb436011ec9d895727b237ec2ea93f | [syserror] Refactor abi/linux.Errno | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -85,6 +85,8 @@ go_library(\ngo_test(\nname = \"linux_test\",\nsize = \"small\",\n- srcs = [\"netfilter_test.go\"],\n+ srcs = [\n+ \"netfilter_test.go\",\n+ ],\nlibrary = \":linux\",\n)\n"
}... | Go | Apache License 2.0 | google/gvisor | [syserror] Refactor abi/linux.Errno
PiperOrigin-RevId: 373265454 |
259,891 | 12.05.2021 10:26:21 | 25,200 | d5f69e0decef6f62706fdeef33ba5f1305e2e431 | Use an exhaustive list of architectures | [
{
"change_type": "MODIFY",
"old_path": "pkg/atomicbitops/aligned_64bit.go",
"new_path": "pkg/atomicbitops/aligned_64bit.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n-// +build amd64 arm64\n+// +build !arm,!mips,!386\npackage... | Go | Apache License 2.0 | google/gvisor | Use an exhaustive list of architectures |
259,860 | 12.05.2021 13:21:47 | 25,200 | 07e32fa6967370ef29327417fd941c5130335fbc | Document design details for refsvfs2 template. | [
{
"change_type": "MODIFY",
"old_path": "pkg/refsvfs2/refs_template.go",
"new_path": "pkg/refsvfs2/refs_template.go",
"diff": "// limitations under the License.\n// Package refs_template defines a template that can be used by reference\n-// counted objects.\n+// counted objects. The template comes wi... | Go | Apache License 2.0 | google/gvisor | Document design details for refsvfs2 template.
PiperOrigin-RevId: 373437576 |
259,905 | 12.05.2021 22:59:21 | -28,800 | ddaa36bde5c55067ca866dbfcbd2e560e3bb356d | Fix file descriptor leak in MultiGetAttr
We need to make sure that all children are closed before
return. But the last child saved in parent isn't closed
after we successfully iterate all the files in "names".
This patch fixes this issue.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/fsgofer.go",
"new_path": "runsc/fsgofer/fsgofer.go",
"diff": "@@ -1247,6 +1247,7 @@ func (l *localFile) MultiGetAttr(names []string) ([]p9.FullStat, error) {\nif parent != l.file.FD() {\n// Parent is no longer needed.\n_ = unix.Close(parent)\n+ p... | Go | Apache License 2.0 | google/gvisor | Fix file descriptor leak in MultiGetAttr
We need to make sure that all children are closed before
return. But the last child saved in parent isn't closed
after we successfully iterate all the files in "names".
This patch fixes this issue.
Fixes #5982
Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> |
259,884 | 12.05.2021 18:06:38 | 25,200 | e6a9780f3cca047577db3fe57eeb0d7444030711 | Fix TODO comments.
Fix TODO comments referring to incorrect issue numbers. Also fix the link in
issue reviver comments to include the right url fragment. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/devtmpfs/devtmpfs.go",
"new_path": "pkg/sentry/fsimpl/devtmpfs/devtmpfs.go",
"diff": "@@ -36,7 +36,7 @@ const Name = \"devtmpfs\"\n//\n// +stateify savable\ntype FilesystemType struct {\n- initOnce sync.Once `state:\"nosave\"` // FIXME(gvisor... | Go | Apache License 2.0 | google/gvisor | Fix TODO comments.
Fix TODO comments referring to incorrect issue numbers. Also fix the link in
issue reviver comments to include the right url fragment.
PiperOrigin-RevId: 373491821 |
260,004 | 13.05.2021 11:22:25 | 25,200 | baa0888f114c586ea490d49a23c3d828fd739b85 | Rename SetForwarding to SetForwardingDefaultAndAllNICs
...to make it clear to callers that all interfaces are updated with the
forwarding flag and that future NICs will be created with the new
forwarding state. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/stack.go",
"new_path": "pkg/sentry/socket/netstack/stack.go",
"diff": "@@ -470,11 +470,8 @@ func (s *Stack) Forwarding(protocol tcpip.NetworkProtocolNumber) bool {\n// SetForwarding implements inet.Stack.SetForwarding.\nfunc (s *Stac... | Go | Apache License 2.0 | google/gvisor | Rename SetForwarding to SetForwardingDefaultAndAllNICs
...to make it clear to callers that all interfaces are updated with the
forwarding flag and that future NICs will be created with the new
forwarding state.
PiperOrigin-RevId: 373618435 |
259,992 | 13.05.2021 14:41:38 | 25,200 | f3478b7516e02ab341324ae1361ea9b019ae4f4e | Fix problem with grouped cgroups
cgroup controllers can be grouped together (e.g. cpu,cpuacct) and
that was confusing Cgroup.Install() into thinking that a cgroup
directory was created by the caller, when it had being created by
another controller that is grouped together. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -342,25 +342,31 @@ func new(pid, cgroupsPath string) (*Cgroup, error) {\n// already exists, it means that the caller has already provided a\n// pre-configured cgroups, and 'res' is igno... | Go | Apache License 2.0 | google/gvisor | Fix problem with grouped cgroups
cgroup controllers can be grouped together (e.g. cpu,cpuacct) and
that was confusing Cgroup.Install() into thinking that a cgroup
directory was created by the caller, when it had being created by
another controller that is grouped together.
PiperOrigin-RevId: 373661336 |
260,023 | 13.05.2021 17:15:08 | 25,200 | 7ea2dcbaece00b5c7310c74fcf99c1fb32e9ec28 | Apply SWS avoidance to ACKs with window updates
When recovering from a zero-receive-window situation, and asked to
send out an ACK, ensure that we apply SWS avoidance in our window
updates.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -1601,7 +1601,7 @@ func (e *endpoint) selectWindow() (wnd seqnum.Size) {\n//\n// For large receive buffers, the threshold is aMSS - once reader reads more\n// ... | Go | Apache License 2.0 | google/gvisor | Apply SWS avoidance to ACKs with window updates
When recovering from a zero-receive-window situation, and asked to
send out an ACK, ensure that we apply SWS avoidance in our window
updates.
Fixes #5984
PiperOrigin-RevId: 373689578 |
260,004 | 13.05.2021 18:52:06 | 25,200 | 2b457d9ee9ba50da4a9208d957053fac2c77932d | Check filter table when forwarding IP packets
This change updates the forwarding path to perform the forwarding hook
with iptables so that the filter table is consulted before a packet is
forwarded
Updates
Test: iptables_test.TestForwardingHook | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/ip/stats.go",
"new_path": "pkg/tcpip/network/internal/ip/stats.go",
"diff": "@@ -74,6 +74,10 @@ type MultiCounterIPStats struct {\n// layer.\nPacketsReceived tcpip.MultiCounterStat\n+ // ValidPacketsReceived is the number of valid IP... | Go | Apache License 2.0 | google/gvisor | Check filter table when forwarding IP packets
This change updates the forwarding path to perform the forwarding hook
with iptables so that the filter table is consulted before a packet is
forwarded
Updates #170.
Test: iptables_test.TestForwardingHook
PiperOrigin-RevId: 373702359 |
260,003 | 14.05.2021 12:47:26 | 25,200 | 436148d68a50e086ae7b967d6a190b3137e68ac8 | Fix panic on consume in a mixed push/consume case
headerOffset() is incorrectly taking account of previous push(), so it thinks
there is more data to consume. This change switches to use pk.reserved as
pivot point.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/packet_buffer.go",
"new_path": "pkg/tcpip/stack/packet_buffer.go",
"diff": "@@ -261,7 +261,7 @@ func (pk *PacketBuffer) consume(typ headerType, size int) (v tcpipbuffer.View, c\nif h.length > 0 {\npanic(fmt.Sprintf(\"consume must not be called ... | Go | Apache License 2.0 | google/gvisor | Fix panic on consume in a mixed push/consume case
headerOffset() is incorrectly taking account of previous push(), so it thinks
there is more data to consume. This change switches to use pk.reserved as
pivot point.
Reported-by: syzbot+64fef9acd509976f9ce7@syzkaller.appspotmail.com
PiperOrigin-RevId: 373846283 |
260,003 | 14.05.2021 12:50:19 | 25,200 | 2ac6b76884c7a8c8b788b4c376098ea48b9fe610 | pkg/buffer: Remove dependency to safemem, code no longer used | [
{
"change_type": "MODIFY",
"old_path": "pkg/buffer/BUILD",
"new_path": "pkg/buffer/BUILD",
"diff": "@@ -21,7 +21,6 @@ go_library(\n\"buffer.go\",\n\"buffer_list.go\",\n\"pool.go\",\n- \"safemem.go\",\n\"view.go\",\n\"view_unsafe.go\",\n],\n@@ -29,8 +28,6 @@ go_library(\ndeps = [\n\"//pkg/context\",\... | Go | Apache License 2.0 | google/gvisor | pkg/buffer: Remove dependency to safemem, code no longer used
PiperOrigin-RevId: 373846881 |
260,001 | 14.05.2021 13:27:14 | 25,200 | eb7e83f645cc21f3219865d38fa7f8e06852c822 | Add verity_mmap tests | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -312,6 +312,10 @@ syscall_test(\ntest = \"//test/syscalls/linux:mmap_test\",\n)\n+syscall_test(\n+ test = \"//test/syscalls/linux:verity_mmap_test\",\n+)\n+\nsyscall_test(\nadd_overlay = True... | Go | Apache License 2.0 | google/gvisor | Add verity_mmap tests
PiperOrigin-RevId: 373854462 |
259,860 | 14.05.2021 14:02:04 | 25,200 | 894187b2c6edbe367135670fb53f2e3f3d24535d | Resolve remaining O_PATH TODOs.
O_PATH is now implemented in vfs2.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -961,7 +961,7 @@ func (d *dentry) open(ctx context.Context, rp *vfs.ResolvingPath, opts *vfs.Open\n}\nreturn &fd.vfsfd, nil\ncase linux.S_IFLNK:\n- // Can'... | Go | Apache License 2.0 | google/gvisor | Resolve remaining O_PATH TODOs.
O_PATH is now implemented in vfs2.
Fixes #2782.
PiperOrigin-RevId: 373861410 |
259,853 | 14.05.2021 15:13:23 | 25,200 | f8d79e94e6fbb44af264394fd96a7c7cca62f98b | Add hash15 label for tests. | [
{
"change_type": "MODIFY",
"old_path": "test/runner/defs.bzl",
"new_path": "test/runner/defs.bzl",
"diff": "@@ -88,6 +88,12 @@ def _syscall_test(\ntags = list(tags)\ntags += [full_platform, \"file_\" + file_access]\n+ # Hash this target into one of 15 buckets. This can be used to\n+ # randomly split... | Go | Apache License 2.0 | google/gvisor | Add hash15 label for tests.
PiperOrigin-RevId: 373875071 |
259,896 | 14.05.2021 16:10:02 | 25,200 | 25f0ab3313c356fcfb9e4282eda3b2aa2278956d | Add new metric for suspicious operations.
The new metric contains fields and will replace the below existing metric:
opened_write_execute_file | [
{
"change_type": "MODIFY",
"old_path": "pkg/metric/metric.go",
"new_path": "pkg/metric/metric.go",
"diff": "@@ -36,10 +36,17 @@ var (\n// new metric after initialization.\nErrInitializationDone = errors.New(\"metric cannot be created after initialization is complete\")\n+ // createdSentryMetrics ind... | Go | Apache License 2.0 | google/gvisor | Add new metric for suspicious operations.
The new metric contains fields and will replace the below existing metric:
- opened_write_execute_file
PiperOrigin-RevId: 373884604 |
259,896 | 14.05.2021 17:20:13 | 25,200 | 8e8b752524e1c1558a0858a121bb56ac1b78456c | Add stuck tasks and startup stuck tasks to weirdness metric
Weirdness metric will replace the below two metrics:
watchdog/stuck_startup_detected
watchdog/stuck_tasks_detected | [
{
"change_type": "MODIFY",
"old_path": "pkg/metric/metric.go",
"new_path": "pkg/metric/metric.go",
"diff": "@@ -40,8 +40,8 @@ var (\ncreatedSentryMetrics = false\n// WeirdnessMetric is a metric with fields created to track the number\n- // of weird occurrences such as time fallback, partial_result a... | Go | Apache License 2.0 | google/gvisor | Add stuck tasks and startup stuck tasks to weirdness metric
Weirdness metric will replace the below two metrics:
- watchdog/stuck_startup_detected
- watchdog/stuck_tasks_detected
PiperOrigin-RevId: 373895696 |
259,977 | 17.05.2021 10:28:34 | 25,200 | 7654181cc7c4f7633a1e96280bfd32391a3fbce3 | Rename variables in IP forwarding tests
Previously, we named domain objects using numbers (e.g. "e1", "e2" etc). This
change renames objects to clarify whether they are part of the incoming or
outgoing path. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4_test.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4_test.go",
"diff": "@@ -118,27 +118,27 @@ type forwardedPacket struct {\nfunc TestForwarding(t *testing.T) {\nconst (\n- nicID1 = 1\n- nicID2 = 2\n+ incomingNICID = 1\n+ outgoingNICI... | Go | Apache License 2.0 | google/gvisor | Rename variables in IP forwarding tests
Previously, we named domain objects using numbers (e.g. "e1", "e2" etc). This
change renames objects to clarify whether they are part of the incoming or
outgoing path.
PiperOrigin-RevId: 374226859 |
259,891 | 17.05.2021 12:11:09 | 25,200 | 303c70194d086aef30c5e04b28836790e2c86e66 | replace use of atomic with AlignedAtomicInt64 | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/socketops.go",
"new_path": "pkg/tcpip/socketops.go",
"diff": "@@ -222,7 +222,7 @@ type SocketOptions struct {\ngetReceiveBufferLimits GetReceiveBufferLimits `state:\"manual\"`\n// receiveBufferSize determines the receive buffer size for this socket.\... | Go | Apache License 2.0 | google/gvisor | replace use of atomic with AlignedAtomicInt64 |
259,885 | 17.05.2021 13:55:03 | 25,200 | e6cd1ff1beefb753101a3e8a43415e27bc474265 | Reduce thread count in TCPResetDuringClose.
This test suffers from extreme contention on
tcpip/stack.AddressableEndpointState.mu via
AddressableEndpointState.decAddressRef, at least when Go race detection is
enabled. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ip_tcp_generic.cc",
"new_path": "test/syscalls/linux/socket_ip_tcp_generic.cc",
"diff": "@@ -1155,7 +1155,7 @@ TEST_P(TCPSocketPairTest, IpMulticastLoopDefault) {\nTEST_P(TCPSocketPairTest, TCPResetDuringClose) {\nDisableSave ds; // ... | Go | Apache License 2.0 | google/gvisor | Reduce thread count in TCPResetDuringClose.
This test suffers from extreme contention on
tcpip/stack.AddressableEndpointState.mu via
AddressableEndpointState.decAddressRef, at least when Go race detection is
enabled.
PiperOrigin-RevId: 374273745 |
259,884 | 17.05.2021 19:42:01 | 25,200 | 32b66bb2be1b3b56138ca856045381519e210b68 | Add badges for Github actions so it's easier to notice when they are failing. | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/stale.yml",
"new_path": ".github/workflows/stale.yml",
"diff": "# The stale workflow closes stale issues and pull requests, unless specific\n# tags have been applied in order to keep them open.\n-name: \"Close stale issues\"\n+name: \"Stale i... | Go | Apache License 2.0 | google/gvisor | Add badges for Github actions so it's easier to notice when they are failing.
PiperOrigin-RevId: 374331016 |
259,896 | 18.05.2021 14:44:09 | 25,200 | e4984f8539560d49847fec84925333966f0c58e8 | Delete /cloud/gvisor/sandbox/sentry/gofer/opened_write_execute_file metric
This metric is replaced by /cloud/gvisor/sandbox/sentry/suspicious_operations
metric with field value opened_write_execute_file. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/file.go",
"new_path": "pkg/sentry/fs/gofer/file.go",
"diff": "@@ -92,7 +92,6 @@ func NewFile(ctx context.Context, dirent *fs.Dirent, name string, flags fs.FileF\n}\nif flags.Write {\nif err := dirent.Inode.CheckPermission(ctx, fs.PermMask{E... | Go | Apache License 2.0 | google/gvisor | Delete /cloud/gvisor/sandbox/sentry/gofer/opened_write_execute_file metric
This metric is replaced by /cloud/gvisor/sandbox/sentry/suspicious_operations
metric with field value opened_write_execute_file.
PiperOrigin-RevId: 374509823 |
259,891 | 18.05.2021 21:55:19 | 25,200 | 8e99cfead78d012114f4478bc9e418e839d0b5f9 | Be explicit about setsid() return values in pty.cc | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/pty.cc",
"new_path": "test/syscalls/linux/pty.cc",
"diff": "@@ -393,7 +393,7 @@ TEST(PtyTrunc, Truncate) {\n// setsid either puts us in a new session or fails because we're already the\n// session leader. Either way, this ensures we're the ... | Go | Apache License 2.0 | google/gvisor | Be explicit about setsid() return values in pty.cc
PiperOrigin-RevId: 374570219 |
259,891 | 18.05.2021 21:55:19 | 25,200 | 52394c34afce6c2a8861d556c9929b1c87c3a201 | use more explicit netstack dependency restrictions
Fuchsia was unable to build when building netstack transitively depended on
golang.org/x/unix constants not defined in Fuchsia. The packages causing this
(safemem and usermem) are no longer in the allowlist.
Tested that this failed at cl/373651666, and passes now that the dependency has
been removed. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/BUILD",
"new_path": "pkg/tcpip/BUILD",
"diff": "@@ -39,12 +39,30 @@ go_library(\ndeps_test(\nname = \"netstack_deps_test\",\nallowed = [\n+ # gVisor deps.\n+ \"//pkg/atomicbitops\",\n+ \"//pkg/buffer\",\n+ \"//pkg/context\",\n+ \"//pkg/gohacks\",\n+ ... | Go | Apache License 2.0 | google/gvisor | use more explicit netstack dependency restrictions
Fuchsia was unable to build when building netstack transitively depended on
golang.org/x/unix constants not defined in Fuchsia. The packages causing this
(safemem and usermem) are no longer in the allowlist.
Tested that this failed at cl/373651666, and passes now that the dependency has
been removed.
PiperOrigin-RevId: 374570220 |
259,963 | 19.05.2021 17:52:01 | -10,800 | 0636c1c929da3b58d3a34262fbc6567f86bfb594 | Allow use of IFF_ONE_QUEUE
Before fix, use of this flag causes an error.
It affects applications like OpenVPN which sets this flag for legacy reasons.
According to linux/if_tun.h "This flag has no real effect". | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/ioctl_tun.go",
"new_path": "pkg/abi/linux/ioctl_tun.go",
"diff": "@@ -26,4 +26,7 @@ const (\nIFF_TAP = 0x0002\nIFF_NO_PI = 0x1000\nIFF_NOFILTER = 0x1000\n+\n+ // According to linux/if_tun.h \"This flag has no real effect\"\n+ IFF_ONE_QUEUE = 0x20... | Go | Apache License 2.0 | google/gvisor | Allow use of IFF_ONE_QUEUE
Before fix, use of this flag causes an error.
It affects applications like OpenVPN which sets this flag for legacy reasons.
According to linux/if_tun.h "This flag has no real effect". |
259,858 | 19.05.2021 10:55:02 | 25,200 | 2f3eda37a4dd64f1202fac1c69ab819fb0bd7a5e | Fix nogo analysis.
Ignore calls to atomic functions in case there is no analysis information.
It is unclear why this has broken in some cases, perhaps these functions
have been replaced by intrinsics as an optimization? | [
{
"change_type": "MODIFY",
"old_path": "tools/checkescape/checkescape.go",
"new_path": "tools/checkescape/checkescape.go",
"diff": "@@ -709,8 +709,13 @@ func run(pass *analysis.Pass, localEscapes bool) (interface{}, error) {\nreturn\n}\n- // Recursively collect information from\n- // the other analy... | Go | Apache License 2.0 | google/gvisor | Fix nogo analysis.
Ignore calls to atomic functions in case there is no analysis information.
It is unclear why this has broken in some cases, perhaps these functions
have been replaced by intrinsics as an optimization?
PiperOrigin-RevId: 374682441 |
259,985 | 20.05.2021 15:07:17 | 25,200 | af229f46a1496f39b012b4e2b244c32bb7d0667c | Fix cgroupfs mount racing with unmount.
Previously, mount could discover a hierarchy being destroyed
concurrently, which resulted in mount attempting to take a ref on an
already destroyed cgroupfs.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/cgroup.go",
"new_path": "pkg/sentry/kernel/cgroup.go",
"diff": "@@ -181,7 +181,23 @@ func (r *CgroupRegistry) FindHierarchy(ctypes []CgroupControllerType) *vfs.Files\nfor _, h := range r.hierarchies {\nif h.match(ctypes) {\n- h.fs.IncRef()\n+... | Go | Apache License 2.0 | google/gvisor | Fix cgroupfs mount racing with unmount.
Previously, mount could discover a hierarchy being destroyed
concurrently, which resulted in mount attempting to take a ref on an
already destroyed cgroupfs.
Reported-by: syzbot+062c0a67798a200f23ee@syzkaller.appspotmail.com
PiperOrigin-RevId: 374959054 |
259,992 | 20.05.2021 17:11:15 | 25,200 | ec542dbedf2f454b8c3e126a19b6910cd9425e92 | Suppress log message when there is no error | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/sandbox.go",
"new_path": "runsc/sandbox/sandbox.go",
"diff": "@@ -131,8 +131,9 @@ func New(conf *config.Config, args *Args) (*Sandbox, error) {\n// The Cleanup object cleans up partially created sandboxes when an error\n// occurs. Any errors occu... | Go | Apache License 2.0 | google/gvisor | Suppress log message when there is no error
PiperOrigin-RevId: 374981100 |
260,023 | 20.05.2021 19:12:27 | 25,200 | 9157a91a4eca7e0811edb20952e9f22ea2c3f13e | Add protocol state to TCPINFO
Add missing protocol state to TCPINFO struct and update packetimpact.
This re-arranges the TCP state definitions to align with Linux.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1127,7 +1127,14 @@ func getSockOptTCP(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, name,\n// TODO(b/64800844): Translate fields once they are ... | Go | Apache License 2.0 | google/gvisor | Add protocol state to TCPINFO
Add missing protocol state to TCPINFO struct and update packetimpact.
This re-arranges the TCP state definitions to align with Linux.
Fixes #478
PiperOrigin-RevId: 374996751 |
259,884 | 20.05.2021 19:40:12 | 25,200 | 28c78eb03ce95bd39ee6b8c6bea6482c9be11edf | Add Knative Services tutorial
This adds a new short tutorial on how to run Knative services in gVisor by
enabling the runtime class feature flag for Knative.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/tutorials/BUILD",
"new_path": "g3doc/user_guide/tutorials/BUILD",
"diff": "@@ -36,11 +36,20 @@ doc(\nweight = \"30\",\n)\n+doc(\n+ name = \"knative\",\n+ src = \"knative.md\",\n+ category = \"User Guide\",\n+ permalink = \"/docs/tutorials/knat... | Go | Apache License 2.0 | google/gvisor | Add Knative Services tutorial
This adds a new short tutorial on how to run Knative services in gVisor by
enabling the runtime class feature flag for Knative.
Fixes #3634
PiperOrigin-RevId: 374999528 |
259,884 | 20.05.2021 23:42:10 | 25,200 | 2bed0bb09661bcd72d2d3470329e88eb7b6966a0 | Send SIGPIPE for closed pipes.
Fixes
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -15,6 +15,7 @@ go_library(\n\"bpf.go\",\n\"capability.go\",\n\"clone.go\",\n+ \"context.go\",\n\"dev.go\",\n\"elf.go\",\n\"epoll.go\",\n@@ -77,6 +78,7 @@ go_library(\ndeps = [\n\"//pkg/abi\",... | Go | Apache License 2.0 | google/gvisor | Send SIGPIPE for closed pipes.
Fixes #5974
Updates #161
PiperOrigin-RevId: 375024740 |
259,951 | 21.05.2021 03:29:15 | 25,200 | 9164154dea012f318c222e8142204a7dd7a5cde8 | Clean-up netstack metrics descriptions | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -77,41 +77,41 @@ func mustCreateGauge(name, description string) *tcpip.StatCounter {\n// Metrics contains metrics exported by netstack.\nvar Metrics = tc... | Go | Apache License 2.0 | google/gvisor | Clean-up netstack metrics descriptions
PiperOrigin-RevId: 375051638 |
260,007 | 21.05.2021 20:17:34 | 25,200 | f77a24966e75271a30ee5a4eefdb90edc2eacb9e | Make many tests build with NDK.
Not all the tests build yet, but many of them do now. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -1517,7 +1517,8 @@ cc_binary(\ncc_binary(\nname = \"partial_bad_buffer_test\",\ntestonly = 1,\n- srcs = [\"partial_bad_buffer.cc\"],\n+ # Android does not support preadv or pwrite... | Go | Apache License 2.0 | google/gvisor | Make many tests build with NDK.
Not all the tests build yet, but many of them do now.
PiperOrigin-RevId: 375209824 |
259,891 | 25.05.2021 13:19:23 | 25,200 | f7bc60603e32d630598eca4663dfd9d03be5802f | setgid directories for VFS1 tmpfs, overlayfs, and goferfs | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/attr.go",
"new_path": "pkg/sentry/fs/attr.go",
"diff": "@@ -478,6 +478,20 @@ func (f FilePermissions) AnyRead() bool {\nreturn f.User.Read || f.Group.Read || f.Other.Read\n}\n+// HasSetUIDOrGID returns true if either the setuid or setgid bit is s... | Go | Apache License 2.0 | google/gvisor | setgid directories for VFS1 tmpfs, overlayfs, and goferfs
PiperOrigin-RevId: 375780659 |
260,001 | 25.05.2021 16:43:50 | 25,200 | 080d122326a55f43ed8bc97c6c319d5ee87b1ca5 | Enable verity after mount in verity_mount test | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -1346,6 +1346,7 @@ cc_binary(\n\"//test/util:temp_path\",\n\"//test/util:test_main\",\n\"//test/util:test_util\",\n+ \"//test/util:verity_util\",\n],\n)\n"
},
{
"change_ty... | Go | Apache License 2.0 | google/gvisor | Enable verity after mount in verity_mount test
PiperOrigin-RevId: 375823719 |
260,001 | 26.05.2021 12:19:11 | 25,200 | 9fcc44f991203343438b489389c2b861040086ac | Add verity getdents tests | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/verity/verity.go",
"new_path": "pkg/sentry/fsimpl/verity/verity.go",
"diff": "@@ -868,6 +868,10 @@ func (fd *fileDescription) IterDirents(ctx context.Context, cb vfs.IterDirentsCa\nfd.mu.Lock()\ndefer fd.mu.Unlock()\n+ if _, err := fd.lowerFD... | Go | Apache License 2.0 | google/gvisor | Add verity getdents tests
PiperOrigin-RevId: 376001603 |
259,891 | 27.05.2021 14:36:35 | 25,200 | dd2e1f07a9c0dddcdfd5f983fc338938a4b11935 | Speed up TestBindToDeviceDistribution
Testing only TestBindToDeviceDistribution decreased from 24s to 11s, and with
TSAN from 186s to 21s.
Note: using `t.Parallel()` actually slows the test down. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/transport_demuxer_test.go",
"new_path": "pkg/tcpip/stack/transport_demuxer_test.go",
"diff": "@@ -18,6 +18,7 @@ import (\n\"io/ioutil\"\n\"math\"\n\"math/rand\"\n+ \"strconv\"\n\"testing\"\n\"gvisor.dev/gvisor/pkg/tcpip\"\n@@ -84,7 +85,8 @@ fun... | Go | Apache License 2.0 | google/gvisor | Speed up TestBindToDeviceDistribution
Testing only TestBindToDeviceDistribution decreased from 24s to 11s, and with
TSAN from 186s to 21s.
Note: using `t.Parallel()` actually slows the test down.
PiperOrigin-RevId: 376251420 |
259,853 | 27.05.2021 15:09:27 | 25,200 | 17df2df75ca092342a29694739d6fbe3bf95b770 | nanosleep has to store the finish time in the restart block
nanosleep has to count time that a thread spent in the stopped state. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/time/time.go",
"new_path": "pkg/sentry/kernel/time/time.go",
"diff": "@@ -458,25 +458,6 @@ func NewTimer(clock Clock, listener TimerListener) *Timer {\nreturn t\n}\n-// After waits for the duration to elapse according to clock and then sends ... | Go | Apache License 2.0 | google/gvisor | nanosleep has to store the finish time in the restart block
nanosleep has to count time that a thread spent in the stopped state.
PiperOrigin-RevId: 376258641 |
259,884 | 27.05.2021 18:55:30 | 25,200 | e8fc815b6ef58b6faa136ef239f89ec98a8e55b4 | Fix specific releases and update install instructions.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/install.md",
"new_path": "g3doc/user_guide/install.md",
"diff": "@@ -138,7 +138,9 @@ sudo add-apt-repository \"deb [arch=amd64,arm64] https://storage.googleapis.com/g\n### Specific release\n-A given release release is available at the followin... | Go | Apache License 2.0 | google/gvisor | Fix specific releases and update install instructions.
Fixes #6084
PiperOrigin-RevId: 376293659 |
259,992 | 27.05.2021 19:51:54 | 25,200 | 394c6089c3b8700164756677f53314d165f8d383 | Fix test_app task-tree
Executing `select {}` to wait forever triggers Go runtime deadlock
detection and kills the child, causing the number actual processes
be less than expected. | [
{
"change_type": "MODIFY",
"old_path": "pkg/test/testutil/BUILD",
"new_path": "pkg/test/testutil/BUILD",
"diff": "@@ -12,6 +12,7 @@ go_library(\n],\nvisibility = [\"//:sandbox\"],\ndeps = [\n+ \"//pkg/sentry/watchdog\",\n\"//pkg/sync\",\n\"//runsc/config\",\n\"//runsc/specutils\",\n"
},
{
"c... | Go | Apache License 2.0 | google/gvisor | Fix test_app task-tree
Executing `select {}` to wait forever triggers Go runtime deadlock
detection and kills the child, causing the number actual processes
be less than expected.
PiperOrigin-RevId: 376298799 |
259,884 | 31.05.2021 20:00:17 | 25,200 | 4f374699818fec39dccdfcb07752fd0f728fe53d | Update comments on ambient caps to point to bug | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/auth/credentials.go",
"new_path": "pkg/sentry/kernel/auth/credentials.go",
"diff": "@@ -125,7 +125,7 @@ func NewUserCredentials(kuid KUID, kgid KGID, extraKGIDs []KGID, capabilities *T\ncreds.EffectiveCaps = capabilities.EffectiveCaps\ncreds.... | Go | Apache License 2.0 | google/gvisor | Update comments on ambient caps to point to bug
PiperOrigin-RevId: 376747671 |
260,019 | 09.12.2020 17:34:23 | -28,800 | 98fd5c241bcaa78f5d8d28d83038f4ec50ce96ee | Fix errors for noescape cases | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/bluepill_arm64.go",
"new_path": "pkg/sentry/platform/kvm/bluepill_arm64.go",
"diff": "@@ -25,29 +25,6 @@ import (\nvar (\n// The action for bluepillSignal is changed by sigaction().\nbluepillSignal = unix.SIGILL\n-\n- // vcpuSErrBounce ... | Go | Apache License 2.0 | google/gvisor | Fix errors for noescape cases
Signed-off-by: Robin Luk <lubin.lu@antgroup.com> |
260,023 | 01.06.2021 10:44:30 | 25,200 | 77dc0f5bc94dff28fa23812f3ad60a8b01e91138 | Ignore RST received for a TCP listener
The current implementation has a bug where TCP listener does not ignore
RSTs from the peer. While handling RST+ACK from the peer, this bug can
complete handshakes that use syncookies. This results in half-open
connection delivered to the accept queue.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/accept.go",
"new_path": "pkg/tcpip/transport/tcp/accept.go",
"diff": "@@ -560,6 +560,10 @@ func (e *endpoint) handleListenSegment(ctx *listenContext, s *segment) tcpip.Err\n}\nswitch {\n+ case s.flags.Contains(header.TCPFlagRst):\n+ e.s... | Go | Apache License 2.0 | google/gvisor | Ignore RST received for a TCP listener
The current implementation has a bug where TCP listener does not ignore
RSTs from the peer. While handling RST+ACK from the peer, this bug can
complete handshakes that use syncookies. This results in half-open
connection delivered to the accept queue.
Fixes #6076
PiperOrigin-RevId: 376868749 |
259,853 | 01.06.2021 15:31:37 | 25,200 | d7d8a0a5aee841dd7958b0e6bc3b544016d19c24 | vfs: Don't allow to mount anything on top of detached mounts | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -220,7 +220,7 @@ func (vfs *VirtualFilesystem) ConnectMountAt(ctx context.Context, creds *auth.Cr\nvdDentry := vd.dentry\nvdDentry.mu.Lock()\nfor {\n- if vdDentry.dead {\n+ if vd.moun... | Go | Apache License 2.0 | google/gvisor | vfs: Don't allow to mount anything on top of detached mounts
PiperOrigin-RevId: 376932659 |
260,007 | 03.06.2021 09:42:42 | 25,200 | ddcd17399b1c1083a132772702d516c154815680 | Reset global_num_signals_received on RegisterSignalHandler
Previously, the value of global_num_signals_received would persist between
tests. Now, we reset the value to zero when we register a signal handler. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/pipe.cc",
"new_path": "test/syscalls/linux/pipe.cc",
"diff": "@@ -53,6 +53,7 @@ void SigRecordingHandler(int signum, siginfo_t* siginfo,\n}\nPosixErrorOr<Cleanup> RegisterSignalHandler(int signum) {\n+ global_num_signals_received = 0;\nstru... | Go | Apache License 2.0 | google/gvisor | Reset global_num_signals_received on RegisterSignalHandler
Previously, the value of global_num_signals_received would persist between
tests. Now, we reset the value to zero when we register a signal handler.
PiperOrigin-RevId: 377308357 |
259,992 | 03.06.2021 20:05:33 | 25,200 | 86cf56eb71215e24fec49272d915f80c9c569c05 | Add additional mmap seccomp rule
HostFileMapper.RegenerateMappings calls mmap with
MAP_SHARED|MAP_FIXED and these were not allowed.
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/seccomp/seccomp.go",
"new_path": "pkg/seccomp/seccomp.go",
"diff": "@@ -36,14 +36,10 @@ const (\n// Install generates BPF code based on the set of syscalls provided. It only\n// allows syscalls that conform to the specification. Syscalls that violate the\n... | Go | Apache License 2.0 | google/gvisor | Add additional mmap seccomp rule
HostFileMapper.RegenerateMappings calls mmap with
MAP_SHARED|MAP_FIXED and these were not allowed.
Closes #6116
PiperOrigin-RevId: 377428463 |
259,967 | 04.06.2021 13:51:05 | 25,200 | 240629524905024c7564d009cbc47c7b44064219 | Add bind syscall tests for ICMP and ICMPv6
Updates
Updates
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -1572,10 +1572,13 @@ cc_binary(\nsrcs = [\"ping_socket.cc\"],\nlinkstatic = 1,\ndeps = [\n+ \":ip_socket_test_util\",\n\":socket_test_util\",\n\"//test/util:file_descriptor\",\n+ ... | Go | Apache License 2.0 | google/gvisor | Add bind syscall tests for ICMP and ICMPv6
Updates #5711
Updates #6021
Updates #6022
PiperOrigin-RevId: 377582446 |
259,967 | 04.06.2021 15:17:04 | 25,200 | a2c88252c84839550bef1543ed5cc904340a8a3e | Allow sniffer receive timeout durations less than one usec
Fixes the erronously signaled fatal error when the sniffer receive timeout
duration is less than one usec. This was caused by the converstion from float64
to int64; the integer conversion truncated the floating point to 0, which
signaled the fatal error. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/testbench/rawsockets.go",
"new_path": "test/packetimpact/testbench/rawsockets.go",
"diff": "@@ -17,7 +17,6 @@ package testbench\nimport (\n\"encoding/binary\"\n\"fmt\"\n- \"math\"\n\"net\"\n\"testing\"\n\"time\"\n@@ -81,19 +80,20 @@ func (s *... | Go | Apache License 2.0 | google/gvisor | Allow sniffer receive timeout durations less than one usec
Fixes the erronously signaled fatal error when the sniffer receive timeout
duration is less than one usec. This was caused by the converstion from float64
to int64; the integer conversion truncated the floating point to 0, which
signaled the fatal error.
PiperOrigin-RevId: 377600179 |
259,858 | 04.06.2021 16:27:41 | 25,200 | fb745d7d9d73482b5b9edce380e4564d9b49d783 | Update GitHub packages. | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -131,10 +131,10 @@ go_repository(\n)\ngo_repository(\n- name = \"com_github_google_go_github_v32\",\n- importpath = \"github.com/google/go-github/v32\",\n- sum = \"h1:GWkQOdXqviCPx7Q7Fj+KyPoGm4SwHRh8rheoPhd27II=... | Go | Apache License 2.0 | google/gvisor | Update GitHub packages.
PiperOrigin-RevId: 377611852 |
259,967 | 04.06.2021 16:44:50 | 25,200 | a2d340739649862a23d86f3e32f1bb3b928697ef | Forward verbose flag to packetimpact tester
Forwards the testing verbose flag to the packetimpact test runner. This is
necessary for debugging inside packetimpact tests. When this flag is present,
all t.Logs in the packetimpact test wil be shown in the resulting test output. | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/dut.go",
"new_path": "test/packetimpact/runner/dut.go",
"diff": "@@ -363,6 +363,9 @@ func TestWithDUT(ctx context.Context, t *testing.T, mkDevice func(*dockerutil.Co\n// and receives packets and also sends POSIX socket commands to the\... | Go | Apache License 2.0 | google/gvisor | Forward verbose flag to packetimpact tester
Forwards the testing verbose flag to the packetimpact test runner. This is
necessary for debugging inside packetimpact tests. When this flag is present,
all t.Logs in the packetimpact test wil be shown in the resulting test output.
PiperOrigin-RevId: 377614550 |
259,885 | 07.06.2021 11:39:57 | 25,200 | ee1003bde2291d6d892701b33c23bd7dd91d44f6 | Implement RENAME_NOREPLACE for all VFS2 filesystem implementations. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -1194,11 +1194,7 @@ func (fs *filesystem) ReadlinkAt(ctx context.Context, rp *vfs.ResolvingPath) (st\n// RenameAt implements vfs.FilesystemImpl.RenameAt.\n... | Go | Apache License 2.0 | google/gvisor | Implement RENAME_NOREPLACE for all VFS2 filesystem implementations.
PiperOrigin-RevId: 377966969 |
259,853 | 07.06.2021 12:13:22 | 25,200 | 7e4e71253ec7c06f2f4eaf387826f08a8b3373cb | cgroupfs: don't add a task in the root cgroup if it is already there. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -1861,7 +1861,9 @@ func (k *Kernel) PopulateNewCgroupHierarchy(root Cgroup) {\nreturn\n}\nt.mu.Lock()\n- t.enterCgroupLocked(root)\n+ // A task can be in the cgroup if it has ... | Go | Apache License 2.0 | google/gvisor | cgroupfs: don't add a task in the root cgroup if it is already there.
PiperOrigin-RevId: 377975013 |
259,853 | 07.06.2021 14:08:28 | 25,200 | b3a44bfab826709fc618e5c14835c06539b054cf | test: use std::vector instead of allocating memory with calloc
A memory that is allocated with calloc has to be freed. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/udp_socket.cc",
"new_path": "test/syscalls/linux/udp_socket.cc",
"diff": "@@ -791,14 +791,14 @@ TEST_P(UdpSocketTest, RecvErrorConnRefused) {\niov.iov_len = kBufLen;\nsize_t control_buf_len = CMSG_SPACE(sizeof(sock_extended_err) + addrlen_)... | Go | Apache License 2.0 | google/gvisor | test: use std::vector instead of allocating memory with calloc
A memory that is allocated with calloc has to be freed.
PiperOrigin-RevId: 378001409 |
260,004 | 07.06.2021 19:56:04 | 25,200 | 77930d0d5ff993d3c870a2237c09193433c89429 | Exclusively lock IPv6 EP when modifying addresses
...as address add/removal updates multicast group memberships and NDP
state.
This partially reverts the change made to the IPv6 endpoint in | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/ipv6.go",
"new_path": "pkg/tcpip/network/ipv6/ipv6.go",
"diff": "@@ -1627,8 +1627,8 @@ func (e *endpoint) NetworkProtocolNumber() tcpip.NetworkProtocolNumber {\nfunc (e *endpoint) AddAndAcquirePermanentAddress(addr tcpip.AddressWithPrefi... | Go | Apache License 2.0 | google/gvisor | Exclusively lock IPv6 EP when modifying addresses
...as address add/removal updates multicast group memberships and NDP
state.
This partially reverts the change made to the IPv6 endpoint in
https://github.com/google/gvisor/commit/ebebb3059f7c5dbe42af85715f1c51c.
PiperOrigin-RevId: 378061726 |
260,005 | 08.06.2021 18:57:46 | -7,200 | a238b0f2f8d3a6857b552f77707b574290ce5857 | Add comment on abseil/grpc dependency precedence | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -1254,6 +1254,9 @@ load(\"@rules_pkg//:deps.bzl\", \"rules_pkg_dependencies\")\nrules_pkg_dependencies()\n# System Call test dependencies.\n+# grpc also has a dependency on abseil but as this is before grpc depe... | Go | Apache License 2.0 | google/gvisor | Add comment on abseil/grpc dependency precedence
Signed-off-by: Esteban Blanc <esteban.blanc@lse.epita.fr> |
259,884 | 08.06.2021 20:05:28 | 25,200 | 927bb26517e7181e18c714d2892595cf1de8d4db | Don't mark issues as stale. | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/issue_reviver.yml",
"new_path": ".github/workflows/issue_reviver.yml",
"diff": "# This workflow revives issues that are still referenced in the code, and may\n-# have been accidentally closed or marked stale.\n+# have been accidentally closed... | Go | Apache License 2.0 | google/gvisor | Don't mark issues as stale.
PiperOrigin-RevId: 378306356 |
259,992 | 09.06.2021 15:51:03 | 25,200 | 1ca981f50f0b2ad273bbcb870bca21c4b1264504 | Remove --overlayfs-stale-read flag
It defaults to true and setting it to false can cause filesytem corruption. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -763,12 +763,10 @@ func (c *containerMounter) createRootMount(ctx context.Context, conf *config.Con\np9FS := mustFindFilesystem(\"9p\")\nopts := p9MountData(fd, conf.FileAccess, false /* vfs2 */)\n... | Go | Apache License 2.0 | google/gvisor | Remove --overlayfs-stale-read flag
It defaults to true and setting it to false can cause filesytem corruption.
PiperOrigin-RevId: 378518663 |
259,885 | 09.06.2021 18:22:27 | 25,200 | 0c37626a07851668307d85c40345c0998a92e30f | Decommit huge-page-aligned regions during reclaim under manual zeroing. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/pgalloc/pgalloc.go",
"new_path": "pkg/sentry/pgalloc/pgalloc.go",
"diff": "@@ -1062,10 +1062,20 @@ func (f *MemoryFile) runReclaim() {\nbreak\n}\n- // If ManualZeroing is in effect, pages will be zeroed on allocation\n- // and may not be freed by de... | Go | Apache License 2.0 | google/gvisor | Decommit huge-page-aligned regions during reclaim under manual zeroing.
PiperOrigin-RevId: 378546551 |
259,891 | 09.06.2021 20:35:11 | 25,200 | 8a7b5a4a8188157a99e5f7654f9235c5332b3552 | Change TODO bug to a more specific issue
This lets us close a tracking bug that's too widely-scoped to be reasonably
finished. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/thread_group.go",
"new_path": "pkg/sentry/kernel/thread_group.go",
"diff": "@@ -490,10 +490,10 @@ func (tg *ThreadGroup) SetForegroundProcessGroup(tty *TTY, pgid ProcessGroupID)\ntg.signalHandlers.mu.Lock()\ndefer tg.signalHandlers.mu.Unlock(... | Go | Apache License 2.0 | google/gvisor | Change TODO bug to a more specific issue
This lets us close a tracking bug that's too widely-scoped to be reasonably
finished.
PiperOrigin-RevId: 378563203 |
259,907 | 09.06.2021 22:51:28 | 25,200 | 8d87a9418aacc175d7a2fa3583f40988e05946cc | [op] Move SignalAct to abi/linux package.
There were also other duplicate definitions of the same struct that I have now
removed.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/signal.go",
"new_path": "pkg/abi/linux/signal.go",
"diff": "@@ -227,6 +227,21 @@ type Sigevent struct {\nUnRemainder [44]byte\n}\n+// LINT.IfChange\n+\n+// SigAction represents struct sigaction.\n+//\n+// +marshal\n+// +stateify savable\n+type Si... | Go | Apache License 2.0 | google/gvisor | [op] Move SignalAct to abi/linux package.
There were also other duplicate definitions of the same struct that I have now
removed.
Updates #214
PiperOrigin-RevId: 378579954 |
259,907 | 10.06.2021 00:58:14 | 25,200 | a51fcf22ebe522c028e99692bbedf04daf0436cc | [op] Move SignalStack to abi/linux package.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -79,6 +79,7 @@ go_library(\n\"//pkg/abi\",\n\"//pkg/bits\",\n\"//pkg/context\",\n+ \"//pkg/hostarch\",\n\"//pkg/marshal\",\n\"//pkg/marshal/primitive\",\n],\n"
},
{
"change_type": "MO... | Go | Apache License 2.0 | google/gvisor | [op] Move SignalStack to abi/linux package.
Updates #214
PiperOrigin-RevId: 378594929 |
259,992 | 10.06.2021 12:43:10 | 25,200 | 8d426b73818cf07aeee3db88478a00b80ad9aafe | Parse mmap protection and flags in strace | [
{
"change_type": "MODIFY",
"old_path": "pkg/refs/refcounter.go",
"new_path": "pkg/refs/refcounter.go",
"diff": "@@ -261,8 +261,8 @@ func (l *LeakMode) Get() interface{} {\n}\n// String implements flag.Value.\n-func (l *LeakMode) String() string {\n- switch *l {\n+func (l LeakMode) String() string {\... | Go | Apache License 2.0 | google/gvisor | Parse mmap protection and flags in strace
PiperOrigin-RevId: 378712518 |
259,992 | 10.06.2021 13:28:06 | 25,200 | 21169357ca913de9cef50da6f235a482b7a3cfab | Add /proc/sys/vm/max_map_count
Set it to int32 max because gVisor doesn't have a limit.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/sys.go",
"new_path": "pkg/sentry/fs/proc/sys.go",
"diff": "@@ -77,6 +77,27 @@ func (*overcommitMemory) ReadSeqFileData(ctx context.Context, h seqfile.SeqHandl\n}, 0\n}\n+// +stateify savable\n+type maxMapCount struct{}\n+\n+// NeedsUpdate im... | Go | Apache License 2.0 | google/gvisor | Add /proc/sys/vm/max_map_count
Set it to int32 max because gVisor doesn't have a limit.
Fixes #2337
PiperOrigin-RevId: 378722230 |
259,992 | 10.06.2021 13:47:43 | 25,200 | d81fcbf85c771a75bcf6600a02b3d411c6f7e383 | Set RLimits during `runsc exec` | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/proc.go",
"new_path": "pkg/sentry/control/proc.go",
"diff": "@@ -99,6 +99,9 @@ type ExecArgs struct {\n// PIDNamespace is the pid namespace for the process being executed.\nPIDNamespace *kernel.PIDNamespace\n+\n+ // Limits is the limit set f... | Go | Apache License 2.0 | google/gvisor | Set RLimits during `runsc exec`
PiperOrigin-RevId: 378726430 |
259,885 | 10.06.2021 15:52:10 | 25,200 | 0058fca32e8ac367c3d6b4396e1b40740d689b54 | Disable all tests dependent on cloud_gvisor::testing::FuseTest. | [
{
"change_type": "MODIFY",
"old_path": "test/fuse/BUILD",
"new_path": "test/fuse/BUILD",
"diff": "@@ -2,75 +2,77 @@ load(\"//test/runner:defs.bzl\", \"syscall_test\")\npackage(licenses = [\"notice\"])\n-syscall_test(\n- fuse = \"True\",\n- test = \"//test/fuse/linux:stat_test\",\n-)\n-\n-syscall_tes... | Go | Apache License 2.0 | google/gvisor | Disable all tests dependent on cloud_gvisor::testing::FuseTest.
PiperOrigin-RevId: 378753134 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.