author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,885 | 10.06.2021 18:22:18 | 25,200 | 0892420c9796358da06ea3ba375ee3e0fa8595ac | Minor VFS2 xattr changes.
Allow the gofer client to use most xattr namespaces. As documented by the
updated comment, this is consistent with e.g. Linux's FUSE client, and allows
gofers to provide extended attributes from FUSE filesystems.
Make tmpfs' listxattr omit xattrs in the "trusted" namespace for
non-privileged users. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/xattr.go",
"new_path": "pkg/abi/linux/xattr.go",
"diff": "@@ -23,6 +23,12 @@ const (\nXATTR_CREATE = 1\nXATTR_REPLACE = 2\n+ XATTR_SECURITY_PREFIX = \"security.\"\n+ XATTR_SECURITY_PREFIX_LEN = len(XATTR_SECURITY_PREFIX)\n+\n+ XATTR_SYSTEM_PREFIX... | Go | Apache License 2.0 | google/gvisor | Minor VFS2 xattr changes.
- Allow the gofer client to use most xattr namespaces. As documented by the
updated comment, this is consistent with e.g. Linux's FUSE client, and allows
gofers to provide extended attributes from FUSE filesystems.
- Make tmpfs' listxattr omit xattrs in the "trusted" namespace for
non-privileged users.
PiperOrigin-RevId: 378778854 |
259,853 | 11.06.2021 16:44:55 | 25,200 | 3c63fce628ccee1f41c9c3a1ff693042ce094503 | Temorary skip test cases that fail on Linux | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/exec.cc",
"new_path": "test/syscalls/linux/exec.cc",
"diff": "@@ -278,6 +278,9 @@ TEST(ExecTest, InterpreterScriptArgNUL) {\n// Trailing whitespace following interpreter path is ignored.\nTEST(ExecTest, InterpreterScriptTrailingWhitespace) ... | Go | Apache License 2.0 | google/gvisor | Temorary skip test cases that fail on Linux
PiperOrigin-RevId: 378974239 |
259,853 | 11.06.2021 18:41:13 | 25,200 | ec6a7ebc75f714e9ac8ae1dc785304661f6e63b4 | Rework the workaround of the XCR0 issue
XCR0 has to be synchronized with the host. We can call xsave from the host
context and then call xrstor from the guest context and vise versa. This means
we need to support the same set of FPU features in both contexts. | [
{
"change_type": "MODIFY",
"old_path": "pkg/ring0/kernel_amd64.go",
"new_path": "pkg/ring0/kernel_amd64.go",
"diff": "@@ -254,6 +254,8 @@ func (c *CPU) SwitchToUser(switchOpts SwitchOpts) (vector Vector) {\nreturn\n}\n+var sentryXCR0 = xgetbv(0)\n+\n// start is the CPU entrypoint.\n//\n// This is ca... | Go | Apache License 2.0 | google/gvisor | Rework the workaround of the XCR0 issue
XCR0 has to be synchronized with the host. We can call xsave from the host
context and then call xrstor from the guest context and vise versa. This means
we need to support the same set of FPU features in both contexts.
PiperOrigin-RevId: 378988281 |
259,884 | 13.06.2021 19:21:46 | 25,200 | 5c9e84622305dc9fd4e9b81eeb7309b8a894f99e | Remove usermem dependency from marshal
Both marshal and usermem are depended on by many packages and a dependency on
marshal can often create circular dependencies. marshal should consider adding
internal dependencies carefully moving forward.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/signal.go",
"new_path": "pkg/abi/linux/signal.go",
"diff": "@@ -293,8 +293,6 @@ type Sigevent struct {\nUnRemainder [44]byte\n}\n-// LINT.IfChange\n-\n// SigAction represents struct sigaction.\n//\n// +marshal\n@@ -306,8 +304,6 @@ type SigAction ... | Go | Apache License 2.0 | google/gvisor | Remove usermem dependency from marshal
Both marshal and usermem are depended on by many packages and a dependency on
marshal can often create circular dependencies. marshal should consider adding
internal dependencies carefully moving forward.
Fixes #6160
PiperOrigin-RevId: 379199882 |
259,975 | 14.06.2021 09:49:59 | 25,200 | 397a59fc956e9d8af05960d31afd4536b62c2399 | Remove debug lines from exec.cc | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/exec.cc",
"new_path": "test/syscalls/linux/exec.cc",
"diff": "@@ -306,9 +306,6 @@ TEST(ExecTest, InterpreterScriptNoPath) {\nTempPath script = ASSERT_NO_ERRNO_AND_VALUE(\nTempPath::CreateFileWith(GetAbsoluteTestTmpdir(), \"#!\\n\\n\", 0755)... | Go | Apache License 2.0 | google/gvisor | Remove debug lines from exec.cc
PiperOrigin-RevId: 379298590 |
260,004 | 14.06.2021 15:27:01 | 25,200 | d4af8da36160643614cae2405c5d829bb7c1bf78 | Rename DefaultRouter event to OffLinkRoute event
This change prepares for a later change which supports the NDP
Route Information option to discover more-specific routes, as
per RFC 4191.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/ndp.go",
"new_path": "pkg/tcpip/network/ipv6/ndp.go",
"diff": "@@ -214,19 +214,17 @@ type NDPDispatcher interface {\n// is also not permitted to call into the stack.\nOnDuplicateAddressDetectionResult(tcpip.NICID, tcpip.Address, stack.DA... | Go | Apache License 2.0 | google/gvisor | Rename DefaultRouter event to OffLinkRoute event
This change prepares for a later change which supports the NDP
Route Information option to discover more-specific routes, as
per RFC 4191.
Updates #6172.
PiperOrigin-RevId: 379361330 |
259,891 | 14.06.2021 17:14:09 | 25,200 | 20c68160459a5f2393facc30f24be5770e628428 | Cleanup lint messages | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/accept_bind.cc",
"new_path": "test/syscalls/linux/accept_bind.cc",
"diff": "@@ -37,7 +37,8 @@ TEST_P(AllSocketPairTest, Listen) {\nsockets->first_addr_size()),\nSyscallSucceeds());\n- ASSERT_THAT(listen(sockets->first_fd(), /* backlog = */ ... | Go | Apache License 2.0 | google/gvisor | Cleanup lint messages
PiperOrigin-RevId: 379380041 |
259,884 | 14.06.2021 18:47:16 | 25,200 | bccc4461545655f4f1b5b03e83e6a1ededde48d8 | Update debugging example
Update the debugging example to use make to make sure the debuggable `runsc`
binary is installed as a docker runtime before attempting to start a container.
Also use nginx as an example container and Accept as an example break point
since it's easy to trigger. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/debugging.md",
"new_path": "g3doc/user_guide/debugging.md",
"diff": "@@ -61,24 +61,39 @@ You can debug gVisor like any other Golang program. If you're running with\nDocker, you'll need to find the sandbox PID and attach the debugger as root.\n... | Go | Apache License 2.0 | google/gvisor | Update debugging example
Update the debugging example to use make to make sure the debuggable `runsc`
binary is installed as a docker runtime before attempting to start a container.
Also use nginx as an example container and Accept as an example break point
since it's easy to trigger.
PiperOrigin-RevId: 379393892 |
260,004 | 14.06.2021 23:06:34 | 25,200 | 3a8ba8ed9d222ac5084f14219dbbd3d3cddbdb8e | Support parsing Prf field in RAs
This change prepares for a later change which actually handles the
Prf field in RAs to discover default routers with preference values,
as per RFC 4191.
Updates
Test: header_test.TestNDPRouterAdvert | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ndp_router_advert.go",
"new_path": "pkg/tcpip/header/ndp_router_advert.go",
"diff": "@@ -19,12 +19,72 @@ import (\n\"time\"\n)\n+// NDPRoutePreference is the preference values for default routers or\n+// more-specific routes.\n+//\n+// As per ... | Go | Apache License 2.0 | google/gvisor | Support parsing Prf field in RAs
This change prepares for a later change which actually handles the
Prf field in RAs to discover default routers with preference values,
as per RFC 4191.
Updates #6172.
Test: header_test.TestNDPRouterAdvert
PiperOrigin-RevId: 379421710 |
259,891 | 15.06.2021 11:29:47 | 25,200 | 488ba4176ed3b255660ca9b39982033101bfc2a4 | Deflake SocketInetLoopbackTest.TCPBacklog
The value can be off by one depending on the kernel we're running.
Tested with --runs_per_test=1000. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -368,7 +368,8 @@ TEST_P(SocketInetLoopbackTest, TCPListenShutdown) {\nTestAddress const& connector = param.connector;\nconstexpr int kBacklog =... | Go | Apache License 2.0 | google/gvisor | Deflake SocketInetLoopbackTest.TCPBacklog
The value can be off by one depending on the kernel we're running.
Tested with --runs_per_test=1000.
PiperOrigin-RevId: 379535390 |
259,853 | 16.06.2021 12:55:27 | 25,200 | 47149b7c4275ddd4404d86eddab6feab4f059ed3 | kvm: mark UpperHalf PTE-s as global
UpperHalf is shared with all address spaces. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"new_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"diff": "@@ -485,7 +485,7 @@ func (m *machine) mapUpperHalf(pageTable *pagetables.PageTables) {\npageTable.Map(\nhostarch.Addr(ring0.KernelStartAddress|r.virtual... | Go | Apache License 2.0 | google/gvisor | kvm: mark UpperHalf PTE-s as global
UpperHalf is shared with all address spaces.
PiperOrigin-RevId: 379790539 |
259,891 | 16.06.2021 14:40:21 | 25,200 | 34152da7e5c3c81253ffe4a433c95789d3002a8e | Fix broken hdrincl test
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/raw/endpoint.go",
"new_path": "pkg/tcpip/transport/raw/endpoint.go",
"diff": "@@ -286,26 +286,6 @@ func (e *endpoint) write(p tcpip.Payloader, opts tcpip.WriteOptions) (int64, tcp\nreturn nil, nil, nil, &tcpip.ErrBadBuffer{}\n}\n- // If thi... | Go | Apache License 2.0 | google/gvisor | Fix broken hdrincl test
Fixes #3159.
PiperOrigin-RevId: 379814096 |
259,891 | 17.06.2021 13:33:12 | 25,200 | 0f5c1f5eafb2cc67a9148bdf346b6083e5a8480c | raw sockets: don't overwrite destination address
Also makes the behavior of raw sockets WRT fragmentation clearer, and makes the
ICMPv4 header-length check explicit.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ip_test.go",
"new_path": "pkg/tcpip/network/ip_test.go",
"diff": "@@ -88,6 +88,7 @@ type testObject struct {\ndataCalls int\ncontrolCalls int\n+ rawCalls int\n}\n// checkValues verifies that the transport protocol, data contents, src & dst\n@... | Go | Apache License 2.0 | google/gvisor | raw sockets: don't overwrite destination address
Also makes the behavior of raw sockets WRT fragmentation clearer, and makes the
ICMPv4 header-length check explicit.
Fixes #3160.
PiperOrigin-RevId: 380033450 |
259,891 | 17.06.2021 15:28:51 | 25,200 | bc27a991851fdffa59f028eecfc22bdd17ccaa55 | remove outdated ip6tables TODOs
IPv6 SO_ORIGINAL_DST is supported, and the flag check as-written will detect
when other flags are needed.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netfilter_ipv6.go",
"new_path": "pkg/abi/linux/netfilter_ipv6.go",
"diff": "@@ -41,7 +41,6 @@ const (\n// IP6T_ORIGINAL_DST is the ip6tables SOL_IPV6 socket option. Corresponds to\n// the value in include/uapi/linux/netfilter_ipv6/ip6_tables.h.\n... | Go | Apache License 2.0 | google/gvisor | remove outdated ip6tables TODOs
IPv6 SO_ORIGINAL_DST is supported, and the flag check as-written will detect
when other flags are needed.
Fixes #3549.
PiperOrigin-RevId: 380059115 |
259,975 | 17.06.2021 17:51:36 | 25,200 | 1f2ce9f46100d6ff958f7c257d3c0a949ede4f4c | [syserror] Change p9 server to use linuxerr.
Change the p9 server to use *errors.Error defined in pkg linuxerr. Done
separate from the client so that we ensure different p9 server/client versions
work with each other. | [
{
"change_type": "MODIFY",
"old_path": "pkg/errors/linuxerr/linuxerr.go",
"new_path": "pkg/errors/linuxerr/linuxerr.go",
"diff": "@@ -27,6 +27,7 @@ import (\nconst maxErrno uint32 = errno.EHWPOISON + 1\nvar (\n+ NOERROR = errors.New(errno.NOERRNO, \"not an error\")\nEPERM = errors.New(errno.EPERM, \... | Go | Apache License 2.0 | google/gvisor | [syserror] Change p9 server to use linuxerr.
Change the p9 server to use *errors.Error defined in pkg linuxerr. Done
separate from the client so that we ensure different p9 server/client versions
work with each other.
PiperOrigin-RevId: 380084491 |
259,992 | 21.06.2021 12:21:42 | 25,200 | d823b7bd975dd2926324971a08f97522b41dd6e7 | Add gcore to list of supported tools | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/compatibility.md",
"new_path": "g3doc/user_guide/compatibility.md",
"diff": "@@ -61,6 +61,7 @@ Most common utilities work. Note that:\n| drill | Working. |\n| env | Working. |\n| find | Working. |\n+| gcore | Working. |\n| gdb | Working. |\n| ... | Go | Apache License 2.0 | google/gvisor | Add gcore to list of supported tools
PiperOrigin-RevId: 380636877 |
259,891 | 21.06.2021 22:13:24 | 25,200 | c6da1b0022484561cf1a37b240b670120936393b | clean up tcpdump TODOs
tcpdump is largely supported. We've also chose not to implement writeable
AF_PACKET sockets, and there's a bug specifically for promiscuous mode
Fixes | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/compatibility.md",
"new_path": "g3doc/user_guide/compatibility.md",
"diff": "@@ -82,7 +82,7 @@ Most common utilities work. Note that:\n| sshd | Partially working. Job control [in progress](https://gvisor.dev/issue/154). |\n| strace | Working. ... | Go | Apache License 2.0 | google/gvisor | clean up tcpdump TODOs
tcpdump is largely supported. We've also chose not to implement writeable
AF_PACKET sockets, and there's a bug specifically for promiscuous mode (#3333).
Fixes #173.
PiperOrigin-RevId: 380733686 |
259,884 | 22.06.2021 01:06:02 | 25,200 | 04a81bc33664b7f7b3da0666b9296e5aaf0f63e7 | Trigger poll/epoll events on zero-length hostinet sendmsg
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket.go",
"new_path": "pkg/sentry/socket/hostinet/socket.go",
"diff": "@@ -67,23 +67,6 @@ type socketOperations struct {\nsocketOpsCommon\n}\n-// socketOpsCommon contains the socket operations common to VFS1 and VFS2.\n-//\n-// +st... | Go | Apache License 2.0 | google/gvisor | Trigger poll/epoll events on zero-length hostinet sendmsg
Fixes #2726
PiperOrigin-RevId: 380753516 |
259,891 | 22.06.2021 18:33:22 | 25,200 | 179ed309f4eaf424c078dba4688eef2731e6649c | netstack: further deflake tcp_test
There are unnecessarily short timeouts in several places.
Note: a later change will switch tcp_test to fake clocks intead of the built-in
`time` package. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"new_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"diff": "@@ -3451,17 +3451,13 @@ loop:\nfor {\nswitch _, err := c.EP.Read(ioutil.Discard, tcpip.ReadOptions{}); err.(type) {\ncase *tcpip.ErrWouldBlock:\n- select {\n- cas... | Go | Apache License 2.0 | google/gvisor | netstack: further deflake tcp_test
There are unnecessarily short timeouts in several places.
Note: a later change will switch tcp_test to fake clocks intead of the built-in
`time` package.
PiperOrigin-RevId: 380935400 |
259,962 | 22.06.2021 23:38:37 | 25,200 | e5fe488b22734e798df760d9646c6b1c5f25c207 | Wake up Writers when tcp socket is shutdown for writes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -2372,6 +2372,9 @@ func (e *endpoint) shutdownLocked(flags tcpip.ShutdownFlags) tcpip.Error {\ne.notifyProtocolGoroutine(notifyTickleWorker)\nreturn nil\n}\n+ ... | Go | Apache License 2.0 | google/gvisor | Wake up Writers when tcp socket is shutdown for writes.
PiperOrigin-RevId: 380967023 |
259,987 | 22.06.2021 14:17:26 | 25,200 | 99f9230e3fbd3b3ede5628eeeb8458175bc9c1a0 | Ensure shim propagates errors over gRPC correctly
This change wraps containerd's errdefs.ToGRPC function with one that
understands Go 1.13-style error wrapping style, which is used
pervasively throughout the shim. With this change, errors that have been
marked with, e.g., `errdefs.ErrNotFound`, will be correctly propagated
back to the containerd server. | [
{
"change_type": "MODIFY",
"old_path": "pkg/shim/BUILD",
"new_path": "pkg/shim/BUILD",
"diff": "@@ -8,6 +8,7 @@ go_library(\n\"api.go\",\n\"debug.go\",\n\"epoll.go\",\n+ \"errors.go\",\n\"options.go\",\n\"service.go\",\n\"service_linux.go\",\n@@ -44,6 +45,8 @@ go_library(\n\"@com_github_gogo_protobu... | Go | Apache License 2.0 | google/gvisor | Ensure shim propagates errors over gRPC correctly
This change wraps containerd's errdefs.ToGRPC function with one that
understands Go 1.13-style error wrapping style, which is used
pervasively throughout the shim. With this change, errors that have been
marked with, e.g., `errdefs.ErrNotFound`, will be correctly propagated
back to the containerd server. |
259,987 | 22.06.2021 14:20:21 | 25,200 | b8430201f0046d78ee5ac6229718fa88c5246c96 | Do not attempt to kill stopped exec processes
While addressed the stopped state for handling signals in the main
process, it did not update exec processes in the same way. This change
mirrors that adjustment for exec processes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/shim/proc/exec_state.go",
"new_path": "pkg/shim/proc/exec_state.go",
"diff": "@@ -151,8 +151,8 @@ func (s *execStoppedState) Delete(ctx context.Context) error {\nreturn nil\n}\n-func (s *execStoppedState) Kill(ctx context.Context, sig uint32, all bool) err... | Go | Apache License 2.0 | google/gvisor | Do not attempt to kill stopped exec processes
While #6204 addressed the stopped state for handling signals in the main
process, it did not update exec processes in the same way. This change
mirrors that adjustment for exec processes. |
259,885 | 23.06.2021 11:13:45 | 25,200 | 6b23d2a08e71ce7d93b1d52e545f792f549225dc | Fix PR_SET_PTRACER applicability to non-leader threads.
Compare
if (!thread_group_leader(tracee))
tracee = rcu_dereference(tracee->group_leader);
in security/yama/yama_lsm.c:ptracer_exception_found(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/ptrace.go",
"new_path": "pkg/sentry/kernel/ptrace.go",
"diff": "@@ -294,7 +294,7 @@ func (t *Task) isYAMADescendantOfLocked(ancestor *Task) bool {\n// Precondition: the TaskSet mutex must be locked (for reading or writing).\nfunc (t *Task) ha... | Go | Apache License 2.0 | google/gvisor | Fix PR_SET_PTRACER applicability to non-leader threads.
Compare
if (!thread_group_leader(tracee))
tracee = rcu_dereference(tracee->group_leader);
in security/yama/yama_lsm.c:ptracer_exception_found().
PiperOrigin-RevId: 381074242 |
259,885 | 23.06.2021 13:15:44 | 25,200 | dfa4b3b90861a61653d0bef8f144bb4e82d21d78 | Move flipcall.packetWindowMmap to memutil. | [
{
"change_type": "MODIFY",
"old_path": "pkg/flipcall/BUILD",
"new_path": "pkg/flipcall/BUILD",
"diff": "@@ -10,9 +10,7 @@ go_library(\n\"flipcall_unsafe.go\",\n\"futex_linux.go\",\n\"io.go\",\n- \"packet_window_allocator.go\",\n- \"packet_window_mmap_amd64.go\",\n- \"packet_window_mmap_arm64.go\",\n... | Go | Apache License 2.0 | google/gvisor | Move flipcall.packetWindowMmap to memutil.
PiperOrigin-RevId: 381100861 |
259,885 | 23.06.2021 17:00:58 | 25,200 | 7e0c1d9f1eae5620d38a6434c27442a350828876 | Use memutil.MapFile for the memory accounting page. | [
{
"change_type": "MODIFY",
"old_path": "nogo.yaml",
"new_path": "nogo.yaml",
"diff": "@@ -177,6 +177,7 @@ analyzers:\n- pkg/sentry/platform/kvm/bluepill_unsafe.go # Special case.\n- pkg/sentry/platform/kvm/machine_unsafe.go # Special case.\n- pkg/sentry/platform/safecopy/safecopy_unsafe.go # Special... | Go | Apache License 2.0 | google/gvisor | Use memutil.MapFile for the memory accounting page.
PiperOrigin-RevId: 381145216 |
259,853 | 24.06.2021 15:33:26 | 25,200 | 2e6195ffe0ad452b2137c32d635d890c9d872e8d | CreateProcessGroup has to check whether a target process stil exists or not
A caller of CreateProcessGroup looks up a thread group without locks, so
the target process can exit before CreateProcessGroup will be called.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/sessions.go",
"new_path": "pkg/sentry/kernel/sessions.go",
"diff": "@@ -369,6 +369,11 @@ func (tg *ThreadGroup) CreateProcessGroup() error {\n// Get the ID for this thread in the current namespace.\nid := tg.pidns.tgids[tg]\n+ // Check whethe... | Go | Apache License 2.0 | google/gvisor | CreateProcessGroup has to check whether a target process stil exists or not
A caller of CreateProcessGroup looks up a thread group without locks, so
the target process can exit before CreateProcessGroup will be called.
Reported-by: syzbot+6abb7c34663dacbd55a8@syzkaller.appspotmail.com
PiperOrigin-RevId: 381351069 |
259,896 | 24.06.2021 16:52:41 | 25,200 | 3e46b660b97ab3fc995ac3f838fc7ddf1bd96a1b | Delete sentry metrics /watchdog/{stuck_startup_detected, stuck_tasks_detected}
These metrics are replaced with WeirdnessMetric with fields
watchdog_stuck_startup and watchdog_stuck_tasks. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/watchdog/watchdog.go",
"new_path": "pkg/sentry/watchdog/watchdog.go",
"diff": "@@ -77,11 +77,6 @@ var DefaultOpts = Opts{\n// trigger it.\nconst descheduleThreshold = 1 * time.Second\n-var (\n- stuckStartup = metric.MustCreateNewUint64Metric(\"/watc... | Go | Apache License 2.0 | google/gvisor | Delete sentry metrics /watchdog/{stuck_startup_detected, stuck_tasks_detected}
- These metrics are replaced with WeirdnessMetric with fields
watchdog_stuck_startup and watchdog_stuck_tasks.
PiperOrigin-RevId: 381365617 |
259,868 | 24.06.2021 17:45:51 | 25,200 | 4470caec4e2fea10f5d116894ca6b3fc9d78789b | Run `:socket_inet_loopback_isolated_test_linux` tests in a container.
This creates new user and network namespaces for all tests in
`:socket_inet_loopback_isolated_test_linux`. | [
{
"change_type": "MODIFY",
"old_path": "test/runner/BUILD",
"new_path": "test/runner/BUILD",
"diff": "@@ -8,6 +8,7 @@ go_binary(\nsrcs = [\"main.go\"],\ndata = [\n\"//runsc\",\n+ \"//test/runner/setup_container\",\n],\nvisibility = [\"//:sandbox\"],\ndeps = [\n"
},
{
"change_type": "MODIFY",... | Go | Apache License 2.0 | google/gvisor | Run `:socket_inet_loopback_isolated_test_linux` tests in a container.
This creates new user and network namespaces for all tests in
`:socket_inet_loopback_isolated_test_linux`.
PiperOrigin-RevId: 381374120 |
260,004 | 24.06.2021 22:38:14 | 25,200 | 1f113b96e68fed452e40855db0cf3efa24b2b9b6 | Incrementally update checksum when NAT-ing
...instead of calculating a fresh checksum to avoid re-calcalculating
a checksum on unchanged bytes.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/checksum.go",
"new_path": "pkg/tcpip/header/checksum.go",
"diff": "@@ -18,6 +18,7 @@ package header\nimport (\n\"encoding/binary\"\n+ \"fmt\"\n\"gvisor.dev/gvisor/pkg/tcpip\"\n\"gvisor.dev/gvisor/pkg/tcpip/buffer\"\n@@ -234,3 +235,64 @@ func P... | Go | Apache License 2.0 | google/gvisor | Incrementally update checksum when NAT-ing
...instead of calculating a fresh checksum to avoid re-calcalculating
a checksum on unchanged bytes.
Fixes #5340.
PiperOrigin-RevId: 381403888 |
259,962 | 25.06.2021 12:23:01 | 25,200 | f00077e8d8d59ee6db93a3ece24c5f3f5156eda5 | Remove sndQueue as its pointless now.
sndQueue made sense when the worker goroutine and the syscall context held
different locks. Now both lock the endpoint lock before doing anything which
means adding to sndQueue is pointless as we move it to writeList immediately
after that in endpoint.Write() by calling e.drainSendQueue. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/tcp.go",
"new_path": "pkg/tcpip/stack/tcp.go",
"diff": "@@ -380,9 +380,6 @@ type TCPSndBufState struct {\n// SndClosed indicates that the endpoint has been closed for sends.\nSndClosed bool\n- // SndBufInQueue is the number of bytes in the send... | Go | Apache License 2.0 | google/gvisor | Remove sndQueue as its pointless now.
sndQueue made sense when the worker goroutine and the syscall context held
different locks. Now both lock the endpoint lock before doing anything which
means adding to sndQueue is pointless as we move it to writeList immediately
after that in endpoint.Write() by calling e.drainSendQueue.
PiperOrigin-RevId: 381523177 |
259,891 | 28.06.2021 10:38:34 | 25,200 | 27cc5a883a3cc077da884c0d058b69b607ec02f2 | check explicitly that AF_PACKET sockets can't write in gVisor | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/packet_socket.cc",
"new_path": "test/syscalls/linux/packet_socket.cc",
"diff": "@@ -231,9 +231,6 @@ TEST_P(CookedPacketTest, Receive) {\n// Send via a packet socket.\nTEST_P(CookedPacketTest, Send) {\n- // We don't implement writing to pack... | Go | Apache License 2.0 | google/gvisor | check explicitly that AF_PACKET sockets can't write in gVisor
PiperOrigin-RevId: 381896875 |
259,891 | 28.06.2021 11:48:13 | 25,200 | 71e1bf1ec737873b14ea6348c973d9ff73b6eaf5 | netstack: deflake TestSynRcvdBadSeqNumber
There was a race wherein Accept() could fail, then the handshake would complete,
and then a waiter would be created to listen for the handshake. In such cases,
no notification was ever sent and the test timed out. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"new_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"diff": "@@ -6077,6 +6077,11 @@ func TestSynRcvdBadSeqNumber(t *testing.T) {\n// complete the connection to test that the large SEQ num\n// did not change the state from S... | Go | Apache License 2.0 | google/gvisor | netstack: deflake TestSynRcvdBadSeqNumber
There was a race wherein Accept() could fail, then the handshake would complete,
and then a waiter would be created to listen for the handshake. In such cases,
no notification was ever sent and the test timed out.
PiperOrigin-RevId: 381913041 |
259,891 | 28.06.2021 14:40:27 | 25,200 | 2cbd82c0d6ff397a301def56d4a25eda07b53a9b | code quality: cleanup lint messages
dns | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/accept_bind.cc",
"new_path": "test/syscalls/linux/accept_bind.cc",
"diff": "@@ -37,9 +37,7 @@ TEST_P(AllSocketPairTest, Listen) {\nsockets->first_addr_size()),\nSyscallSucceeds());\n- ASSERT_THAT(listen(sockets->first_fd(),\n- /* backlog = ... | Go | Apache License 2.0 | google/gvisor | code quality: cleanup lint messages
dns
PiperOrigin-RevId: 381949375 |
259,884 | 28.06.2021 15:59:54 | 25,200 | 2d899a843b7b36799474bbb811a0bd40bc04efce | Exit early with error message on checkpoint/pause w/ hostinet. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -334,6 +334,11 @@ func (cm *containerManager) ExecuteAsync(args *control.ExecArgs, pid *int32) err\n// Checkpoint pauses a sandbox and saves its state.\nfunc (cm *containerManager) ... | Go | Apache License 2.0 | google/gvisor | Exit early with error message on checkpoint/pause w/ hostinet.
PiperOrigin-RevId: 381964660 |
259,885 | 28.06.2021 17:40:33 | 25,200 | 5b2afd24a7ed6d626ede2d06d04378f95c3b62f8 | Allow VFS2 gofer client to mmap from sentry page cache when forced. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"diff": "@@ -678,29 +678,29 @@ func (fd *regularFileFD) Sync(ctx context.Context) error {\n// ConfigureMMap implements vfs.FileDescriptionImpl.ConfigureMMap.\nfunc... | Go | Apache License 2.0 | google/gvisor | Allow VFS2 gofer client to mmap from sentry page cache when forced.
PiperOrigin-RevId: 381982257 |
259,963 | 27.05.2021 17:03:44 | -10,800 | ddbc27365978a7c634354000094f86022d3ecd2f | Fix TUN IFF_NO_PI bug
When TUN is created with IFF_NO_PI flag, there will be no Ethernet header and no packet info, therefore, both read and write will fail.
This commit fix this bug. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/tun/device.go",
"new_path": "pkg/tcpip/link/tun/device.go",
"diff": "@@ -207,6 +207,15 @@ func (d *Device) Write(data []byte) (int64, error) {\nprotocol = pktInfoHdr.Protocol()\ncase ethHdr != nil:\nprotocol = ethHdr.Type()\n+ case d.flags.TUN:\... | Go | Apache License 2.0 | google/gvisor | Fix TUN IFF_NO_PI bug
When TUN is created with IFF_NO_PI flag, there will be no Ethernet header and no packet info, therefore, both read and write will fail.
This commit fix this bug. |
259,963 | 29.06.2021 15:09:44 | -10,800 | e8bc632d07378f4aa0824b5002a51c55b4796d35 | Fix iptables List entries Input interface field
In Linux the list entries command returns the name of the input interface assigned to the iptable rule.
iptables -S
> -A FORWARD -i docker0 -o docker0 -j ACCEPT
Meanwhile, in gVsior this interface name is ignored.
iptables -S
> -A FORWARD -o docker0 -j ACCEPT | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netfilter/ipv4.go",
"new_path": "pkg/sentry/socket/netfilter/ipv4.go",
"diff": "@@ -80,6 +80,8 @@ func getEntries4(table stack.Table, tablename linux.TableName) (linux.KernelIPTG\ncopy(entry.Entry.IP.SrcMask[:], rule.Filter.SrcMask)\ncopy(ent... | Go | Apache License 2.0 | google/gvisor | Fix iptables List entries Input interface field
In Linux the list entries command returns the name of the input interface assigned to the iptable rule.
iptables -S
> -A FORWARD -i docker0 -o docker0 -j ACCEPT
Meanwhile, in gVsior this interface name is ignored.
iptables -S
> -A FORWARD -o docker0 -j ACCEPT |
259,992 | 29.06.2021 10:53:10 | 25,200 | 5f2b3728fc1d71d32912c57d948ba4b15c886f2a | Redirect all calls from `errdefs.ToGRPC` to `utils.ErrToGRPC`
This is to ensure that Go 1.13 error wrapping is correctly
translated to gRPC errors before returning from the shim.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/shim/BUILD",
"new_path": "pkg/shim/BUILD",
"diff": "@@ -8,7 +8,6 @@ go_library(\n\"api.go\",\n\"debug.go\",\n\"epoll.go\",\n- \"errors.go\",\n\"options.go\",\n\"service.go\",\n\"service_linux.go\",\n@@ -45,8 +44,6 @@ go_library(\n\"@com_github_gogo_protobu... | Go | Apache License 2.0 | google/gvisor | Redirect all calls from `errdefs.ToGRPC` to `utils.ErrToGRPC`
This is to ensure that Go 1.13 error wrapping is correctly
translated to gRPC errors before returning from the shim.
Updates #6225
PiperOrigin-RevId: 382120441 |
259,992 | 29.06.2021 14:46:51 | 25,200 | d205926f235258468bfe206388fa1b55cb1ea7fa | Delete PID files right after they are read
The PID files are not used after they are read, so there is
no point in keeping them around until the shim is deleted.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/shim/proc/BUILD",
"new_path": "pkg/shim/proc/BUILD",
"diff": "@@ -20,6 +20,7 @@ go_library(\n\"//shim:__subpackages__\",\n],\ndeps = [\n+ \"//pkg/cleanup\",\n\"//pkg/shim/runsc\",\n\"//pkg/shim/utils\",\n\"@com_github_containerd_console//:go_default_librar... | Go | Apache License 2.0 | google/gvisor | Delete PID files right after they are read
The PID files are not used after they are read, so there is
no point in keeping them around until the shim is deleted.
Updates #6225
PiperOrigin-RevId: 382169916 |
259,909 | 29.06.2021 16:58:12 | 25,200 | 90dbb4b0c7e594ba67fec26c2cdb1dfd7d7454de | Add SIOCGIFFLAGS ioctl support to hostinet. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket_unsafe.go",
"new_path": "pkg/sentry/socket/hostinet/socket_unsafe.go",
"diff": "@@ -67,7 +67,23 @@ func ioctl(ctx context.Context, fd int, io usermem.IO, args arch.SyscallArgument\nAddressSpaceActive: true,\n})\nreturn 0, err\... | Go | Apache License 2.0 | google/gvisor | Add SIOCGIFFLAGS ioctl support to hostinet.
PiperOrigin-RevId: 382194711 |
260,004 | 29.06.2021 21:29:22 | 25,200 | 66a79461a23e5e98c53a809eda442393cd6925b3 | Support parsing NDP Route Information option
This change prepares for a later change which supports the NDP
Route Information option to discover more-specific routes, as
per RFC 4191.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ndp_options.go",
"new_path": "pkg/tcpip/header/ndp_options.go",
"diff": "@@ -233,6 +233,17 @@ func (i *NDPOptionIterator) Next() (NDPOption, bool, error) {\ncase ndpNonceOptionType:\nreturn NDPNonceOption(body), false, nil\n+ case ndpRouteInfo... | Go | Apache License 2.0 | google/gvisor | Support parsing NDP Route Information option
This change prepares for a later change which supports the NDP
Route Information option to discover more-specific routes, as
per RFC 4191.
Updates #6172.
PiperOrigin-RevId: 382225812 |
260,004 | 30.06.2021 18:30:47 | 25,200 | 07ffecef83bd31e78786af901c49a7be93b20517 | Implement fmt.Stringer for NDPRoutePreference | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ndp_router_advert.go",
"new_path": "pkg/tcpip/header/ndp_router_advert.go",
"diff": "@@ -16,9 +16,12 @@ package header\nimport (\n\"encoding/binary\"\n+ \"fmt\"\n\"time\"\n)\n+var _ fmt.Stringer = NDPRoutePreference(0)\n+\n// NDPRoutePreferenc... | Go | Apache License 2.0 | google/gvisor | Implement fmt.Stringer for NDPRoutePreference
PiperOrigin-RevId: 382427879 |
259,992 | 01.07.2021 14:20:16 | 25,200 | 3d4a8824f8e7aafdf6c1d18822b7593fa2e3e6bb | Strace: handle null paths | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/strace.go",
"new_path": "pkg/sentry/strace/strace.go",
"diff": "@@ -133,6 +133,9 @@ func dump(t *kernel.Task, addr hostarch.Addr, size uint, maximumBlobSize uint) s\n}\nfunc path(t *kernel.Task, addr hostarch.Addr) string {\n+ if addr == 0 {\... | Go | Apache License 2.0 | google/gvisor | Strace: handle null paths
PiperOrigin-RevId: 382603592 |
260,004 | 02.07.2021 11:28:49 | 25,200 | a51a4b872ebdc5b9d6a74bb92d932c9197514606 | Discover more specific routes as per RFC 4191
More-specific route discovery allows hosts to pick a more appropriate
router for off-link destinations.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/ndp.go",
"new_path": "pkg/tcpip/network/ipv6/ndp.go",
"diff": "@@ -54,6 +54,11 @@ const (\n// Advertisements, as a host.\ndefaultDiscoverDefaultRouters = true\n+ // defaultDiscoverMoreSpecificRoutes is the default configuration for\n+ //... | Go | Apache License 2.0 | google/gvisor | Discover more specific routes as per RFC 4191
More-specific route discovery allows hosts to pick a more appropriate
router for off-link destinations.
Fixes #6172.
PiperOrigin-RevId: 382779880 |
259,891 | 02.07.2021 18:13:24 | 25,200 | 3d32a05a35bde4cfed861c274c32bfc55acc19c9 | runsc: validate mount targets | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/chroot.go",
"new_path": "runsc/cmd/chroot.go",
"diff": "@@ -30,7 +30,7 @@ func mountInChroot(chroot, src, dst, typ string, flags uint32) error {\nchrootDst := filepath.Join(chroot, dst)\nlog.Infof(\"Mounting %q at %q\", src, chrootDst)\n- if err := s... | Go | Apache License 2.0 | google/gvisor | runsc: validate mount targets
PiperOrigin-RevId: 382845950 |
259,907 | 02.07.2021 18:45:05 | 25,200 | add8bca5ba53b37096bc653900cb278e11681461 | [op] Make TCPNonBlockingConnectClose more reasonable.
This test single handedly causes the syscalls:socket_inet_loopback_test test
variants to take more than an hour to run on some of our testing environments.
Reduce how aggressively this test tries to replicate a fixed flake. This is a
regression test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -707,7 +707,7 @@ TEST_P(SocketInetLoopbackTest, TCPNonBlockingConnectClose) {\n// Try many iterations to catch a race with socket close and han... | Go | Apache License 2.0 | google/gvisor | [op] Make TCPNonBlockingConnectClose more reasonable.
This test single handedly causes the syscalls:socket_inet_loopback_test test
variants to take more than an hour to run on some of our testing environments.
Reduce how aggressively this test tries to replicate a fixed flake. This is a
regression test.
PiperOrigin-RevId: 382849039 |
259,868 | 07.07.2021 12:45:39 | 25,200 | cd558fcb05c30bc08bbb9ba47755c2768fa33316 | Sentry: Measure the time it takes to initialize the Sentry. | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -1306,6 +1306,15 @@ http_archive(\n],\n)\n+http_archive(\n+ name = \"com_google_protobuf\",\n+ sha256 = \"528927e398f4e290001886894dac17c5c6a2e5548f3fb68004cfb01af901b53a\",\n+ strip_prefix = \"protobuf-3.17.3\"... | Go | Apache License 2.0 | google/gvisor | Sentry: Measure the time it takes to initialize the Sentry.
PiperOrigin-RevId: 383472507 |
259,868 | 08.07.2021 12:01:47 | 25,200 | 07f2c8b56b5948759b3df6587a8fcea13fbcc82b | devpts: Notify of echo'd input queue bytes only after locks have been released. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/devpts/BUILD",
"new_path": "pkg/sentry/fsimpl/devpts/BUILD",
"diff": "@@ -60,5 +60,6 @@ go_test(\n\"//pkg/abi/linux\",\n\"//pkg/sentry/contexttest\",\n\"//pkg/usermem\",\n+ \"//pkg/waiter\",\n],\n)\n"
},
{
"change_type": "MODIFY",
... | Go | Apache License 2.0 | google/gvisor | devpts: Notify of echo'd input queue bytes only after locks have been released.
PiperOrigin-RevId: 383684320 |
259,885 | 08.07.2021 12:23:43 | 25,200 | fbd4ccf33339a261812521fbc54554850a70676c | Fix async-signal-unsafety in socket test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket.cc",
"new_path": "test/syscalls/linux/socket.cc",
"diff": "@@ -119,6 +119,9 @@ TEST(SocketTest, UnixSCMRightsOnlyPassedOnce) {\n// Send more than what will fit inside the send/receive buffers, so that it is\n// split into multiple me... | Go | Apache License 2.0 | google/gvisor | Fix async-signal-unsafety in socket test.
PiperOrigin-RevId: 383689096 |
259,885 | 08.07.2021 13:36:49 | 25,200 | 052eb90dc15e04dfd8397ca305c507399360dd0e | Replace kernel.ExitStatus with linux.WaitStatus. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/wait.go",
"new_path": "pkg/abi/linux/wait.go",
"diff": "package linux\n+import (\n+ \"fmt\"\n+)\n+\n// Options for waitpid(2), wait4(2), and/or waitid(2), from\n// include/uapi/linux/wait.h.\nconst (\n@@ -34,3 +38,124 @@ const (\nP_PID = 0x1\nP_P... | Go | Apache License 2.0 | google/gvisor | Replace kernel.ExitStatus with linux.WaitStatus.
PiperOrigin-RevId: 383705129 |
259,891 | 08.07.2021 17:53:49 | 25,200 | f8207a823351055a2aaad633b428fe7c1f0585f0 | clarify safemount behavior | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/chroot.go",
"new_path": "runsc/cmd/chroot.go",
"diff": "@@ -30,7 +30,7 @@ func mountInChroot(chroot, src, dst, typ string, flags uint32) error {\nchrootDst := filepath.Join(chroot, dst)\nlog.Infof(\"Mounting %q at %q\", src, chrootDst)\n- if err := s... | Go | Apache License 2.0 | google/gvisor | clarify safemount behavior
PiperOrigin-RevId: 383750666 |
259,905 | 09.07.2021 10:02:39 | -28,800 | c4c5f4d92a13aa5357002fe5ddf116433ec4e9a7 | runsc: check the error when preparing tree for pivot_root | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/gofer.go",
"new_path": "runsc/cmd/gofer.go",
"diff": "@@ -284,8 +284,12 @@ func setupRootFS(spec *specs.Spec, conf *config.Config) error {\n}\n// Prepare tree structure for pivot_root(2).\n- os.Mkdir(\"/proc/proc\", 0755)\n- os.Mkdir(\"/proc/root\", ... | Go | Apache License 2.0 | google/gvisor | runsc: check the error when preparing tree for pivot_root
Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com> |
259,858 | 09.07.2021 15:57:05 | 25,200 | d78713e2da5331a22fc51fb9a9ad33cc1873879c | Drop unnecessary checklocksignore. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_cgroup.go",
"new_path": "pkg/sentry/kernel/task_cgroup.go",
"diff": "@@ -27,8 +27,6 @@ import (\n// EnterInitialCgroups moves t into an initial set of cgroups.\n//\n// Precondition: t isn't in any cgroups yet, t.cgs is empty.\n-//\n-// +... | Go | Apache License 2.0 | google/gvisor | Drop unnecessary checklocksignore.
PiperOrigin-RevId: 383940663 |
259,858 | 12.07.2021 09:59:40 | 25,200 | 1f396d8c16e179aa5b7b9ea1da6b16fb0b167016 | Prevent the cleanup script from destroying any "bootstrap" containers. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/post-command",
"new_path": ".buildkite/hooks/post-command",
"diff": "@@ -56,8 +56,10 @@ if test \"${BUILDKITE_COMMAND_EXIT_STATUS}\" -ne \"0\"; then\nsudo rm -rf \"${HOME}/go\"\nfi\n-# Kill any running containers (clear state).\n-CONTAINERS=\"... | Go | Apache License 2.0 | google/gvisor | Prevent the cleanup script from destroying any "bootstrap" containers.
PiperOrigin-RevId: 384257460 |
259,885 | 12.07.2021 12:47:08 | 25,200 | 9c09db654e3304ce57a2757b33c87e28df7153dc | Fix async-signal-unsafety in chroot test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -479,6 +479,7 @@ cc_binary(\n\"//test/util:cleanup\",\n\"//test/util:file_descriptor\",\n\"//test/util:fs_util\",\n+ \"@com_google_absl//absl/cleanup\",\n\"@com_google_absl//absl/... | Go | Apache License 2.0 | google/gvisor | Fix async-signal-unsafety in chroot test.
PiperOrigin-RevId: 384295543 |
259,853 | 12.07.2021 13:31:34 | 25,200 | ebe99977a47d93ee769121f9463650cfb924e243 | Mark all functions that are called from a forked child with go:norace | [
{
"change_type": "MODIFY",
"old_path": "pkg/seccomp/seccomp_unsafe.go",
"new_path": "pkg/seccomp/seccomp_unsafe.go",
"diff": "@@ -68,6 +68,10 @@ func SetFilter(instrs []linux.BPFInstruction) error {\n// - Since fork()ed child processes cannot perform heap allocation, it returns\n// a unix.Errno rath... | Go | Apache License 2.0 | google/gvisor | Mark all functions that are called from a forked child with go:norace
PiperOrigin-RevId: 384305599 |
259,858 | 12.07.2021 16:58:30 | 25,200 | 275932bf0852431b6f307ba9c45f26073d20ac62 | Drop dedicated benchmark lifecycle.
Instead, roll the output scraping into the main runner. Pass a perf flag to
the runner in order to control leak checking, apply tags via the macro and
appropriately disable logging. This may be removed in the future. | [
{
"change_type": "MODIFY",
"old_path": "test/util/test_util_impl.cc",
"new_path": "test/util/test_util_impl.cc",
"diff": "#include \"benchmark/benchmark.h\"\n#include \"test/util/logging.h\"\n+extern bool FLAGS_gtest_list_tests;\nextern bool FLAGS_benchmark_list_tests;\nextern std::string FLAGS_benc... | Go | Apache License 2.0 | google/gvisor | Drop dedicated benchmark lifecycle.
Instead, roll the output scraping into the main runner. Pass a perf flag to
the runner in order to control leak checking, apply tags via the macro and
appropriately disable logging. This may be removed in the future.
PiperOrigin-RevId: 384348035 |
259,891 | 12.07.2021 22:34:44 | 25,200 | e35d20f79c4604c41a3b912b41aae322adf96bc7 | netstack: move SO_SNDBUF/RCVBUF clamping logic out of //pkg/tcpip
Keeps Linux-specific behavior out of //pkg/tcpip
Makes it clearer that clamping is done only for setsockopt calls from users
Removes code duplication | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -1682,6 +1682,26 @@ func SetSockOpt(t *kernel.Task, s socket.SocketOps, ep commonEndpoint, level int\nreturn nil\n}\n+func clampBufSize(newSz, min, max i... | Go | Apache License 2.0 | google/gvisor | netstack: move SO_SNDBUF/RCVBUF clamping logic out of //pkg/tcpip
- Keeps Linux-specific behavior out of //pkg/tcpip
- Makes it clearer that clamping is done only for setsockopt calls from users
- Removes code duplication
PiperOrigin-RevId: 384389809 |
260,004 | 13.07.2021 10:19:29 | 25,200 | b4caeaf78f533037d191b61fc83919a3ecd379d1 | Deflake TestRouterSolicitation
Before this change, transmission of the first router solicitation races
with the adding of an IPv6 link-local address. This change creates the
NIC in the disabled state and is only enabled after the address is added
(if required) to avoid this race. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/ndp_test.go",
"new_path": "pkg/tcpip/stack/ndp_test.go",
"diff": "@@ -5356,8 +5356,9 @@ func TestRouterSolicitation(t *testing.T) {\nRandSource: &randSource,\n})\n- if err := s.CreateNIC(nicID, &e); err != nil {\n- t.Fatalf(\"CreateNIC(%d, _) =... | Go | Apache License 2.0 | google/gvisor | Deflake TestRouterSolicitation
Before this change, transmission of the first router solicitation races
with the adding of an IPv6 link-local address. This change creates the
NIC in the disabled state and is only enabled after the address is added
(if required) to avoid this race.
PiperOrigin-RevId: 384493553 |
259,891 | 13.07.2021 11:18:15 | 25,200 | 1fe6db8c542431d3d6e229f563fefbd2f962fc81 | netstack: atomically update buffer sizes
Previously, two calls to set the send or receive buffer size could have raced
and left state wherein:
The actual size depended on one call
The value returned by getsockopt() depended on the other | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/socketops.go",
"new_path": "pkg/tcpip/socketops.go",
"diff": "@@ -17,7 +17,6 @@ package tcpip\nimport (\n\"sync/atomic\"\n- \"gvisor.dev/gvisor/pkg/atomicbitops\"\n\"gvisor.dev/gvisor/pkg/sync\"\n)\n@@ -208,16 +207,24 @@ type SocketOptions struct {\n... | Go | Apache License 2.0 | google/gvisor | netstack: atomically update buffer sizes
Previously, two calls to set the send or receive buffer size could have raced
and left state wherein:
- The actual size depended on one call
- The value returned by getsockopt() depended on the other
PiperOrigin-RevId: 384508720 |
259,992 | 13.07.2021 11:33:49 | 25,200 | c16e69a9d5ec3422b648a6d32842442925285a29 | Use consistent naming for subcontainers
It was confusing to find functions relating to root and non-root
containers. Replace "non-root" and "subcontainer" and make naming
consistent in Sandbox and controller. | [
{
"change_type": "MODIFY",
"old_path": "pkg/shim/proc/exec.go",
"new_path": "pkg/shim/proc/exec.go",
"diff": "@@ -113,7 +113,7 @@ func (e *execProcess) Delete(ctx context.Context) error {\nreturn e.execState.Delete(ctx)\n}\n-func (e *execProcess) delete() error {\n+func (e *execProcess) delete() {\n... | Go | Apache License 2.0 | google/gvisor | Use consistent naming for subcontainers
It was confusing to find functions relating to root and non-root
containers. Replace "non-root" and "subcontainer" and make naming
consistent in Sandbox and controller.
PiperOrigin-RevId: 384512518 |
259,992 | 13.07.2021 17:18:26 | 25,200 | 85a0a353ad185946d39463fddb3ec2cb37876371 | Replace whitelist with allowlist | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/logging.go",
"new_path": "pkg/sentry/control/logging.go",
"diff": "@@ -50,20 +50,20 @@ type LoggingArgs struct {\n// enable strace at all. If this flag is false then a completely\n// pristine copy of the syscall table will be swapped in. Thi... | Go | Apache License 2.0 | google/gvisor | Replace whitelist with allowlist
PiperOrigin-RevId: 384586164 |
259,891 | 14.07.2021 13:40:00 | 25,200 | a1044cb88192ad3891500c867c22f5cb388054e5 | testing: shrink exhaustion test size to avoid timeouts
Tested via:
```
bazel test \
//test/syscalls:socket_ipv4_udp_unbound_loopback_nogotsan_test_runsc_ptrace
--runs_per_test=2000
``` | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ipv4_udp_unbound_loopback_nogotsan.cc",
"new_path": "test/syscalls/linux/socket_ipv4_udp_unbound_loopback_nogotsan.cc",
"diff": "@@ -31,7 +31,7 @@ using IPv4UDPUnboundSocketNogotsanTest = SimpleSocketTest;\n// We disable S/R because ... | Go | Apache License 2.0 | google/gvisor | testing: shrink exhaustion test size to avoid timeouts
Tested via:
```
bazel test \
//test/syscalls:socket_ipv4_udp_unbound_loopback_nogotsan_test_runsc_ptrace
--runs_per_test=2000
```
PiperOrigin-RevId: 384773477 |
259,992 | 14.07.2021 15:17:40 | 25,200 | d02be7858ac5d185751df9a15a27340e349d19e5 | Replace whitelist with allowlist from docs | [
{
"change_type": "MODIFY",
"old_path": "website/blog/2019-11-18-security-basics.md",
"new_path": "website/blog/2019-11-18-security-basics.md",
"diff": "@@ -188,11 +188,11 @@ for direct access to some files. And most files will be remotely accessed\nthrough the Gofers, in which case no FDs are donate... | Go | Apache License 2.0 | google/gvisor | Replace whitelist with allowlist from docs
PiperOrigin-RevId: 384796852 |
260,001 | 14.07.2021 17:43:50 | 25,200 | 5c20fd3bbd30b0a9ecb32995b98cf194dc9600d7 | Add verity symlink tests | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -883,6 +883,10 @@ syscall_test(\ntest = \"//test/syscalls/linux:symlink_test\",\n)\n+syscall_test(\n+ test = \"//test/syscalls/linux:verity_symlink_test\",\n+)\n+\nsyscall_test(\nadd_overlay ... | Go | Apache License 2.0 | google/gvisor | Add verity symlink tests
PiperOrigin-RevId: 384823097 |
259,891 | 15.07.2021 15:32:22 | 25,200 | cd45d7b6c893aa763cdc3ef2f4ac86444b622927 | netstack: support SO_RCVBUFFORCE
TCP is fully supported. As with SO_RCVBUF, other transport protocols perform
no-ops per DefaultSocketOptionsHandler.OnSetReceiveBufferSize. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -49,6 +49,7 @@ import (\n\"gvisor.dev/gvisor/pkg/sentry/fs/fsutil\"\n\"gvisor.dev/gvisor/pkg/sentry/inet\"\n\"gvisor.dev/gvisor/pkg/sentry/kernel\"\n+ \"... | Go | Apache License 2.0 | google/gvisor | netstack: support SO_RCVBUFFORCE
TCP is fully supported. As with SO_RCVBUF, other transport protocols perform
no-ops per DefaultSocketOptionsHandler.OnSetReceiveBufferSize.
PiperOrigin-RevId: 385023239 |
259,891 | 15.07.2021 16:06:18 | 25,200 | 6415efa514db436e33375f67f38c9f783491b692 | buildkite: bump Go version to 1.16
We're currently on 1.13, which can cause build issues with code targeting later
versions. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -8,9 +8,16 @@ function install_pkgs() {\ndone\n}\ninstall_pkgs make \"linux-headers-$(uname -r)\" linux-libc-dev \\\n- graphviz jq curl binutils gnupg gnupg-agent golang-go ... | Go | Apache License 2.0 | google/gvisor | buildkite: bump Go version to 1.16
We're currently on 1.13, which can cause build issues with code targeting later
versions.
PiperOrigin-RevId: 385029528 |
259,868 | 15.07.2021 18:26:01 | 25,200 | b6baa377d85db823c9d1c15658e843d6683835a3 | Update gVisor release signing key to a version that does not expire. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/install.md",
"new_path": "g3doc/user_guide/install.md",
"diff": "@@ -55,7 +55,10 @@ sudo apt-get install -y \\\nsoftware-properties-common\n```\n-Next, the configure the key used to sign archives and the repository:\n+Next, configure the key u... | Go | Apache License 2.0 | google/gvisor | Update gVisor release signing key to a version that does not expire.
PiperOrigin-RevId: 385051420 |
259,992 | 15.07.2021 18:51:10 | 25,200 | 628d7d3a4662a14625895df6ff1ca7a9dbf3a5d7 | Fix refcount increments in gofer.filesystem.Sync.
fs.renameMu is released and reacquired in `dentry.destroyLocked()` allowing
a dentry to be in `fs.syncableDentries` with a negative reference count.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -39,27 +39,15 @@ import (\n// Sync implements vfs.FilesystemImpl.Sync.\nfunc (fs *filesystem) Sync(ctx context.Context) error {\n// Snapshot current syncab... | Go | Apache License 2.0 | google/gvisor | Fix refcount increments in gofer.filesystem.Sync.
fs.renameMu is released and reacquired in `dentry.destroyLocked()` allowing
a dentry to be in `fs.syncableDentries` with a negative reference count.
Fixes #5263
PiperOrigin-RevId: 385054337 |
259,853 | 20.07.2021 12:04:47 | 25,200 | 7ced03b3831983e35cb25ad0a9d5632ea322f9a4 | ring0: Initialize sentryXCR0 from Kernel.init()
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/ring0/kernel_amd64.go",
"new_path": "pkg/ring0/kernel_amd64.go",
"diff": "@@ -19,6 +19,7 @@ package ring0\nimport (\n\"encoding/binary\"\n\"reflect\"\n+ \"sync\"\n\"gvisor.dev/gvisor/pkg/hostarch\"\n\"gvisor.dev/gvisor/pkg/sentry/arch\"\n@@ -30,6 +31,8 @@ ... | Go | Apache License 2.0 | google/gvisor | ring0: Initialize sentryXCR0 from Kernel.init()
Fixes #6300
PiperOrigin-RevId: 385840917 |
259,992 | 20.07.2021 20:53:33 | 25,200 | 990cd1a950955e25dc8935a6aca61906307a0851 | Don't kill container when volume is unmounted
The gofer session is killed when a gofer backed volume is unmounted. The
gofer monitor catches the disconnect and kills the container. This changes
the gofer monitor to only care about the rootfs connections, which cannot
be unmounted.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -742,8 +742,11 @@ func (l *Loader) createContainerProcess(root bool, cid string, info *containerIn\n// ours either way.\ninfo.procArgs.FDTable = fdTable\n- // Setup the child container file... | Go | Apache License 2.0 | google/gvisor | Don't kill container when volume is unmounted
The gofer session is killed when a gofer backed volume is unmounted. The
gofer monitor catches the disconnect and kills the container. This changes
the gofer monitor to only care about the rootfs connections, which cannot
be unmounted.
Fixes #6259
PiperOrigin-RevId: 385929039 |
259,992 | 20.07.2021 22:18:47 | 25,200 | 0184f1a662b893a1634e9b2cf3adff57971b668c | Add fsstress test to goferfs | [
{
"change_type": "MODIFY",
"old_path": "test/fsstress/BUILD",
"new_path": "test/fsstress/BUILD",
"diff": "@@ -14,7 +14,11 @@ go_test(\n\"manual\",\n\"local\",\n],\n- deps = [\"//pkg/test/dockerutil\"],\n+ deps = [\n+ \"//pkg/test/dockerutil\",\n+ \"//pkg/test/testutil\",\n+ \"@com_github_docker_dock... | Go | Apache License 2.0 | google/gvisor | Add fsstress test to goferfs
PiperOrigin-RevId: 385937353 |
260,004 | 20.07.2021 22:47:34 | 25,200 | 9e805ce937ef2f2934e72f873ea4ae8451801c82 | Expose local address from raw sockets | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/raw/endpoint.go",
"new_path": "pkg/tcpip/transport/raw/endpoint.go",
"diff": "@@ -455,8 +455,21 @@ func (e *endpoint) Bind(addr tcpip.FullAddress) tcpip.Error {\n}\n// GetLocalAddress implements tcpip.Endpoint.GetLocalAddress.\n-func (*endp... | Go | Apache License 2.0 | google/gvisor | Expose local address from raw sockets
PiperOrigin-RevId: 385940836 |
259,896 | 20.07.2021 23:11:14 | 25,200 | a4d743db59bc8c05d646ca3d5cd94498cf411d02 | Enable RACK by default in netstack. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -478,7 +478,7 @@ type endpoint struct {\n// shutdownFlags represent the current shutdown state of the endpoint.\nshutdownFlags tcpip.ShutdownFlags\n- // tcpRec... | Go | Apache License 2.0 | google/gvisor | Enable RACK by default in netstack.
PiperOrigin-RevId: 385944428 |
259,885 | 21.07.2021 12:51:41 | 25,200 | a89b2f005b714dbe472ebda702020bb6fb1d9c0a | Use atomics when checking for parent setgid in VFS2 tmpfs file creation.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/tmpfs.go",
"diff": "@@ -397,8 +397,8 @@ func (i *inode) init(impl interface{}, fs *filesystem, kuid auth.KUID, kgid auth\n}\n// Inherit the group and setgid bit as in fs/inode.c:inode_init... | Go | Apache License 2.0 | google/gvisor | Use atomics when checking for parent setgid in VFS2 tmpfs file creation.
Reported-by: syzbot+59550b48e06cc0d3b638@syzkaller.appspotmail.com
PiperOrigin-RevId: 386075453 |
259,884 | 21.07.2021 14:17:13 | 25,200 | c259978dbd793fedd8d1068b875c763ffba09d26 | Fix required Linux version in networking docs. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/networking.md",
"new_path": "g3doc/user_guide/networking.md",
"diff": "@@ -61,7 +61,7 @@ Add the following `runtimeArgs` to your Docker configuration\n### Disable GSO {#gso}\n-If your Linux is older than 4.14.17, you can disable Generic Segmen... | Go | Apache License 2.0 | google/gvisor | Fix required Linux version in networking docs.
PiperOrigin-RevId: 386093826 |
259,896 | 21.07.2021 18:03:48 | 25,200 | f1f746dddcc0eb97c04b7d4a521962edb30cbea8 | Add metric to count number of segments acknowledged by DSACK.
Creates new metric "/tcp/segments_acked_with_dsack" to count the number of
segments acked with DSACK.
Added check to verify the metric is getting incremented when a DSACK is sent
in the unit tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -274,6 +274,7 @@ var Metrics = tcpip.Stats{\nTimeouts: mustCreateMetric(\"/netstack/tcp/timeouts\", \"Number of times RTO expired.\"),\nChecksumErrors: m... | Go | Apache License 2.0 | google/gvisor | Add metric to count number of segments acknowledged by DSACK.
- Creates new metric "/tcp/segments_acked_with_dsack" to count the number of
segments acked with DSACK.
- Added check to verify the metric is getting incremented when a DSACK is sent
in the unit tests.
PiperOrigin-RevId: 386135949 |
259,885 | 22.07.2021 13:39:08 | 25,200 | d5fb4623ea75571f9a04e5694c18f397ba204ad6 | Replace kernel package types for clone and unshare with linux package types. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/clone.go",
"new_path": "pkg/abi/linux/clone.go",
"diff": "@@ -16,13 +16,16 @@ package linux\n// Clone constants per clone(2).\nconst (\n+ CSIGNAL = 0xff\n+\nCLONE_VM = 0x100\nCLONE_FS = 0x200\nCLONE_FILES = 0x400\nCLONE_SIGHAND = 0x800\n- CLONE_P... | Go | Apache License 2.0 | google/gvisor | Replace kernel package types for clone and unshare with linux package types.
PiperOrigin-RevId: 386312456 |
259,891 | 22.07.2021 14:15:00 | 25,200 | 70626b3da217373eb74420e2c3426cc9283265fa | buildkite: move golang installation to VM boot
Rather than re-downloading and installing Go for each pipeline run, we should
just do it at boot. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/pre-command",
"new_path": ".buildkite/hooks/pre-command",
"diff": "@@ -11,14 +11,6 @@ install_pkgs make \"linux-headers-$(uname -r)\" linux-libc-dev \\\ngraphviz jq curl binutils gnupg gnupg-agent gcc pkg-config \\\napt-transport-https ca-cert... | Go | Apache License 2.0 | google/gvisor | buildkite: move golang installation to VM boot
Rather than re-downloading and installing Go for each pipeline run, we should
just do it at boot.
PiperOrigin-RevId: 386320005 |
259,853 | 22.07.2021 15:37:37 | 25,200 | 47f025461e6fdf8da99c780b17c2227696e83845 | runsc: Wait child processes without timeouts
* First, we don't need to poll child processes.
* Second, the 5 seconds timeout is too small if a host is overloaded.
* Third, this can hide bugs in the code when we wait a process that
isn't going to exit. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -789,30 +789,31 @@ func (c *Container) stop() error {\n}\nfunc (c *Container) waitForStopped() error {\n- ctx, cancel := context.WithTimeout(context.Background(), 5*time.Sec... | Go | Apache License 2.0 | google/gvisor | runsc: Wait child processes without timeouts
* First, we don't need to poll child processes.
* Second, the 5 seconds timeout is too small if a host is overloaded.
* Third, this can hide bugs in the code when we wait a process that
isn't going to exit.
PiperOrigin-RevId: 386337586 |
259,853 | 22.07.2021 15:53:06 | 25,200 | 0690c25e062ad1b8dc162b4b4d70ab59879b9bff | kvm: set CR0.NE = 1
CR0.NE enables internal x87 floating point error reporting when set, else
enables PC style x87 error detection.
On AMD, the #MF exception isn't generated if CR0.NE isn't set. | [
{
"change_type": "MODIFY",
"old_path": "pkg/ring0/kernel_amd64.go",
"new_path": "pkg/ring0/kernel_amd64.go",
"diff": "@@ -177,7 +177,7 @@ func (c *CPU) TSS() (uint64, uint16, *SegmentDescriptor) {\n//\n//go:nosplit\nfunc (c *CPU) CR0() uint64 {\n- return _CR0_PE | _CR0_PG | _CR0_AM | _CR0_ET\n+ retu... | Go | Apache License 2.0 | google/gvisor | kvm: set CR0.NE = 1
CR0.NE enables internal x87 floating point error reporting when set, else
enables PC style x87 error detection.
On AMD, the #MF exception isn't generated if CR0.NE isn't set.
PiperOrigin-RevId: 386340269 |
259,985 | 23.07.2021 10:21:31 | 25,200 | c3c5c55d134dcc22480984e3882072b936bae899 | Handle EINTR from socket syscalls in send/recv benchmark.
The benchmark check fails if any of the socket syscalls fail with
EINTR. We see this manifest in S/R lifecycles since S/R has a high
probability of aborting these syscalls with EINTR. | [
{
"change_type": "MODIFY",
"old_path": "test/perf/linux/send_recv_benchmark.cc",
"new_path": "test/perf/linux/send_recv_benchmark.cc",
"diff": "@@ -80,6 +80,9 @@ void BM_Recvmsg(benchmark::State& state) {\nint64_t bytes_received = 0;\nfor (auto ignored : state) {\nint n = recvmsg(recv_socket.get(), ... | Go | Apache License 2.0 | google/gvisor | Handle EINTR from socket syscalls in send/recv benchmark.
The benchmark check fails if any of the socket syscalls fail with
EINTR. We see this manifest in S/R lifecycles since S/R has a high
probability of aborting these syscalls with EINTR.
PiperOrigin-RevId: 386480365 |
259,891 | 23.07.2021 12:04:49 | 25,200 | ea0d9a8f48f13bd15f9450848bd515a337750192 | buildkite: deflake itimer test
The self-admittedly arbitrary threshold of 20% of alarms being sent to the main
thread was being breached. I saw a run of of ~20-23% [1]. We should allow for a
little more breathing room.
1 | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/itimer.cc",
"new_path": "test/syscalls/linux/itimer.cc",
"diff": "@@ -197,9 +197,9 @@ int TestSIGALRMToMainThread() {\n// (but don't guarantee it), so we expect to see most samples on the main\n// thread.\n//\n- // The number of SIGALRMs de... | Go | Apache License 2.0 | google/gvisor | buildkite: deflake itimer test
The self-admittedly arbitrary threshold of 20% of alarms being sent to the main
thread was being breached. I saw a run of of ~20-23% [1]. We should allow for a
little more breathing room.
1 - https://buildkite.com/gvisor/pipeline/builds/7400
PiperOrigin-RevId: 386503482 |
259,891 | 23.07.2021 12:44:10 | 25,200 | dc000e7b7a951dc96b5a2eab46c0b3478cb355ed | update bug number in loopback tests | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_inet_loopback.cc",
"new_path": "test/syscalls/linux/socket_inet_loopback.cc",
"diff": "@@ -308,7 +308,7 @@ TEST_P(SocketInetLoopbackTest, TCPListenShutdownListen) {\nsockaddr_storage conn_addr = connector.addr;\nASSERT_NO_ERRNO(SetAd... | Go | Apache License 2.0 | google/gvisor | update bug number in loopback tests
PiperOrigin-RevId: 386511209 |
259,909 | 23.07.2021 12:47:08 | 25,200 | 0eea96057a8559ae542a0cccfd61ceddc26ceb35 | Add support for SIOCGIFCONF ioctl in hostinet. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket_unsafe.go",
"new_path": "pkg/sentry/socket/hostinet/socket_unsafe.go",
"diff": "@@ -67,7 +67,7 @@ func ioctl(ctx context.Context, fd int, io usermem.IO, args arch.SyscallArgument\nAddressSpaceActive: true,\n})\nreturn 0, err\n... | Go | Apache License 2.0 | google/gvisor | Add support for SIOCGIFCONF ioctl in hostinet.
PiperOrigin-RevId: 386511818 |
259,985 | 23.07.2021 13:34:24 | 25,200 | 3d0a9300050ad9a72d452ec862827e35e3f38dcc | Don't panic on user-controlled state in semaphore syscalls.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"new_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"diff": "@@ -214,15 +214,14 @@ func (r *Registry) Remove(id ipc.ID, creds *auth.Credentials) error {\nr.mu.Lock()\ndefer r.mu.Unlock()\n- r.reg.Remove(id, creds)... | Go | Apache License 2.0 | google/gvisor | Don't panic on user-controlled state in semaphore syscalls.
Reported-by: syzbot+beb099a67f670386a367@syzkaller.appspotmail.com
PiperOrigin-RevId: 386521361 |
260,001 | 23.07.2021 14:33:27 | 25,200 | d2479383639ab15301c4535a91cbbbeb22635a7e | Add verity open benchmark test | [
{
"change_type": "MODIFY",
"old_path": "test/perf/BUILD",
"new_path": "test/perf/BUILD",
"diff": "@@ -139,3 +139,10 @@ syscall_test(\ndebug = False,\ntest = \"//test/perf/linux:write_benchmark\",\n)\n+\n+syscall_test(\n+ size = \"large\",\n+ debug = False,\n+ test = \"//test/perf/linux:verity_open_b... | Go | Apache License 2.0 | google/gvisor | Add verity open benchmark test
PiperOrigin-RevId: 386533065 |
259,885 | 23.07.2021 19:51:11 | 25,200 | 9ba8c40a3a3c7fed40d9137fed8a87fa9d536a22 | Clean up logic for when a VFS2 gofer regular file close causes a flushf. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/regular_file.go",
"diff": "@@ -79,18 +79,23 @@ func (fd *regularFileFD) OnClose(ctx context.Context) error {\nif !fd.vfsfd.IsWritable() {\nreturn nil\n}\n- // Skip flushing if there... | Go | Apache License 2.0 | google/gvisor | Clean up logic for when a VFS2 gofer regular file close causes a flushf.
PiperOrigin-RevId: 386577891 |
259,885 | 27.07.2021 18:11:03 | 25,200 | 964fb3ca768756fbc58d1d9312c53886964ae608 | Use go:build directives in generated files.
Build constraints are now inferred from go:build directives rather than +build
directives. +build directives are still emitted in generated files as required
in Go 1.16 and earlier.
Note that go/build/constraint was added in Go 1.16, so gVisor now requires Go
1.16. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "tools/constraintutil/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_library(\n+ name = \"constraintutil\",\n+ srcs = [\"constraintutil.go\"],\n+ marshal = False,\n+ stateif... | Go | Apache License 2.0 | google/gvisor | Use go:build directives in generated files.
Build constraints are now inferred from go:build directives rather than +build
directives. +build directives are still emitted in generated files as required
in Go 1.16 and earlier.
Note that go/build/constraint was added in Go 1.16, so gVisor now requires Go
1.16.
PiperOrigin-RevId: 387240779 |
259,885 | 28.07.2021 13:47:14 | 25,200 | 44efc282feb0f02196bc775d25166b3f0bb30b7d | Lock gofer.dentry.dataMu before SetAttr RPC modifying file size. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -1161,6 +1161,13 @@ func (d *dentry) setStat(ctx context.Context, creds *auth.Credentials, opts *vfs\nif !d.isSynthetic() {\nif stat.Mask != 0 {\n+ if stat.Mask&linu... | Go | Apache License 2.0 | google/gvisor | Lock gofer.dentry.dataMu before SetAttr RPC modifying file size.
PiperOrigin-RevId: 387427887 |
260,001 | 28.07.2021 14:01:12 | 25,200 | 6bf7d0514be98b6df51436d9a23943e3cc2fdf69 | Add verity read benchmark tests | [
{
"change_type": "MODIFY",
"old_path": "test/perf/BUILD",
"new_path": "test/perf/BUILD",
"diff": "@@ -146,3 +146,10 @@ syscall_test(\ntest = \"//test/perf/linux:verity_open_benchmark\",\nvfs1 = False,\n)\n+\n+syscall_test(\n+ size = \"large\",\n+ debug = False,\n+ test = \"//test/perf/linux:verity_r... | Go | Apache License 2.0 | google/gvisor | Add verity read benchmark tests
PiperOrigin-RevId: 387431049 |
259,910 | 02.08.2021 01:13:42 | -28,800 | 7b300f556ca6415afb80d3dfbbff2ec2aa93d4ca | Add -y to install docker-ce when build image | [
{
"change_type": "MODIFY",
"old_path": "images/default/Dockerfile",
"new_path": "images/default/Dockerfile",
"diff": "@@ -15,7 +15,7 @@ RUN add-apt-repository \\\n\"deb https://download.docker.com/linux/ubuntu \\\n$(lsb_release -cs) \\\nstable\"\n-RUN apt-get install docker-ce-cli\n+RUN apt-get -y i... | Go | Apache License 2.0 | google/gvisor | Add -y to install docker-ce when build image |
260,001 | 03.08.2021 10:54:20 | 25,200 | ceab3327c5bf9b9962d776b85a8a99407ab172f4 | Add verity open_read_close benchmark test | [
{
"change_type": "MODIFY",
"old_path": "test/perf/BUILD",
"new_path": "test/perf/BUILD",
"diff": "@@ -160,3 +160,10 @@ syscall_test(\ntest = \"//test/perf/linux:verity_read_benchmark\",\nvfs1 = False,\n)\n+\n+syscall_test(\n+ size = \"large\",\n+ debug = False,\n+ test = \"//test/perf/linux:verity_o... | Go | Apache License 2.0 | google/gvisor | Add verity open_read_close benchmark test
PiperOrigin-RevId: 388494554 |
260,001 | 03.08.2021 13:46:38 | 25,200 | 8caf231cb14128938a08208a0580e37e20be1fc1 | Add Lifecycle controls
Also change runsc pause/resume cmd to access Lifecycle instead of
containerManager. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/BUILD",
"new_path": "pkg/sentry/control/BUILD",
"diff": "@@ -6,6 +6,7 @@ go_library(\nname = \"control\",\nsrcs = [\n\"control.go\",\n+ \"lifecycle.go\",\n\"logging.go\",\n\"pprof.go\",\n\"proc.go\",\n"
},
{
"change_type": "ADD",
... | Go | Apache License 2.0 | google/gvisor | Add Lifecycle controls
Also change runsc pause/resume cmd to access Lifecycle instead of
containerManager.
PiperOrigin-RevId: 388534928 |
260,001 | 04.08.2021 16:41:27 | 25,200 | cbb99336cee7d37f4050875a95946ca88b7ac690 | Add Fs controls
Add Fs controls and implement "cat" command. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/BUILD",
"new_path": "pkg/sentry/control/BUILD",
"diff": "@@ -6,6 +6,7 @@ go_library(\nname = \"control\",\nsrcs = [\n\"control.go\",\n+ \"fs.go\",\n\"lifecycle.go\",\n\"logging.go\",\n\"pprof.go\",\n@@ -17,6 +18,7 @@ go_library(\n],\ndeps = ... | Go | Apache License 2.0 | google/gvisor | Add Fs controls
Add Fs controls and implement "cat" command.
PiperOrigin-RevId: 388812540 |
260,001 | 04.08.2021 17:15:09 | 25,200 | b9780f96be58ba0cff8612eef4e909431421e936 | Add verity_randread benchmark test | [
{
"change_type": "MODIFY",
"old_path": "test/perf/BUILD",
"new_path": "test/perf/BUILD",
"diff": "@@ -161,6 +161,13 @@ syscall_test(\nvfs1 = False,\n)\n+syscall_test(\n+ size = \"large\",\n+ debug = False,\n+ test = \"//test/perf/linux:verity_randread_benchmark\",\n+ vfs1 = False,\n+)\n+\nsyscall_te... | Go | Apache License 2.0 | google/gvisor | Add verity_randread benchmark test
PiperOrigin-RevId: 388819374 |
259,858 | 05.08.2021 11:15:14 | 25,200 | 919a7da6d792dea17cf59d66fb303788b7e7dbab | Reload the configuration during postinst rather than restarting.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "debian/postinst.sh",
"new_path": "debian/postinst.sh",
"diff": "@@ -22,7 +22,7 @@ fi\nif [ -f /etc/docker/daemon.json ]; then\nrunsc install\nif systemctl is-active -q docker; then\n- systemctl restart docker || echo \"unable to restart docker; you must do so ... | Go | Apache License 2.0 | google/gvisor | Reload the configuration during postinst rather than restarting.
Fixes #6408
PiperOrigin-RevId: 388978814 |
259,985 | 05.08.2021 16:37:32 | 25,200 | a72efae969e6affc406efa9bccaa23b09e99b43c | Skip mmap test cases if underlying FS doesn't support maps.
For file-based mmap tests, the underlying file system may not support
mmaps depending on the sandbox configuration. This is case when
caching is disabled for goferfs. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/mmap.cc",
"new_path": "test/syscalls/linux/mmap.cc",
"diff": "@@ -793,6 +793,19 @@ class MMapFileTest : public MMapTest {\nASSERT_THAT(unlink(filename_.c_str()), SyscallSucceeds());\n}\n+ bool FSSupportsMap() const {\n+ bool supported = tru... | Go | Apache License 2.0 | google/gvisor | Skip mmap test cases if underlying FS doesn't support maps.
For file-based mmap tests, the underlying file system may not support
mmaps depending on the sandbox configuration. This is case when
caching is disabled for goferfs.
PiperOrigin-RevId: 389052722 |
259,985 | 05.08.2021 20:13:54 | 25,200 | 569f605f438dd10e5ffa1d5eb129ba1d15bbf34c | Correctly handle interruptions in blocking msgqueue syscalls.
Reported-by:
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/msgqueue/msgqueue.go",
"new_path": "pkg/sentry/kernel/msgqueue/msgqueue.go",
"diff": "@@ -208,11 +208,13 @@ func (r *Registry) FindByID(id ipc.ID) (*Queue, error) {\n// Send appends a message to the message queue, and returns an error if send... | Go | Apache License 2.0 | google/gvisor | Correctly handle interruptions in blocking msgqueue syscalls.
Reported-by: syzbot+63bde04529f701c76168@syzkaller.appspotmail.com
Reported-by: syzbot+69866b9a16ec29993e6a@syzkaller.appspotmail.com
PiperOrigin-RevId: 389084629 |
260,004 | 09.08.2021 10:16:59 | 25,200 | 34ec00c5e775479b15ae8ad69456cef02f0a545a | Run raw IP socket syscall tests on Fuchsia
+ Do not check for CAP_NET_RAW on Fuchsia
Fuchsia does not support capabilities the same way Linux does. Instead
emulate the check for CAP_NET_RAW by checking if a raw IP sockets may
be created. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -7,6 +7,9 @@ package(\nexports_files(\n[\n+ \"raw_socket.cc\",\n+ \"raw_socket_hdrincl.cc\",\n+ \"raw_socket_icmp.cc\",\n\"socket.cc\",\n\"socket_inet_loopback.cc\",\n\"socket_ine... | Go | Apache License 2.0 | google/gvisor | Run raw IP socket syscall tests on Fuchsia
+ Do not check for CAP_NET_RAW on Fuchsia
Fuchsia does not support capabilities the same way Linux does. Instead
emulate the check for CAP_NET_RAW by checking if a raw IP sockets may
be created.
PiperOrigin-RevId: 389663218 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.