author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
136,224 | 06.12.2017 18:17:48 | 28,800 | 84124045457e115e6be116fa0a7215098ba7f0d5 | ish i2c: use i2c_ports[] to set bus speed
BRANCH=None
TEST=Tested on Soraka ISH modified board, measured I2C speed for std,
fast, fast plus mode.
Commit-Ready: Li1 Feng
Tested-by: Li1 Feng | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/i2c.c",
"new_path": "chip/ish/i2c.c",
"diff": "#define I2C_FLAG_REPEATED_START_DISABLED 0\n#define EVENT_FLAG_I2C_TIMEOUT TASK_EVENT_CUSTOM(1 << 1)\n-#ifndef CONFI_ISH_I2C_PORT0_SPEED\n-#define CONFI_ISH_I2C_PORT0_SPEED I2C_SPEED_FAST\n-#endif\n-\n-#i... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish i2c: use i2c_ports[] to set bus speed
BUG=None
BRANCH=None
TEST=Tested on Soraka ISH modified board, measured I2C speed for std,
fast, fast plus mode.
Change-Id: I0e07c3c73f5f0302fba41ad8e7f83e10e8f0af99
Signed-off-by: li feng <li1.feng@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/817899
Commit-Ready: Li1 Feng <li1.feng@intel.com>
Tested-by: Li1 Feng <li1.feng@intel.com>
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,427 | 08.12.2017 17:36:00 | 25,200 | 69173f990a7c02967261595f27ef98eb312db44a | grunt: Use PPC for USB PD
Use the new PPC functions to fill in more of the USB PD board
code:
board_set_active_charge_port
board_vbus_source_enabled
pd_snk_is_vbus_provided
pd_set_power_supply_ready
pd_power_supply_reset
BRANCH=none
TEST=make BOARD=grunt | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/board.c",
"new_path": "board/grunt/board.c",
"diff": "#include \"thermistor.h\"\n#include \"usb_mux.h\"\n#include \"usb_pd_tcpm.h\"\n+#include \"usbc_ppc.h\"\n#include \"util.h\"\n+#define CPRINTS(format, args...) cprints(CC_USBCHARGE, format, ## a... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Use PPC for USB PD
Use the new PPC functions to fill in more of the USB PD board
code:
board_set_active_charge_port
board_vbus_source_enabled
pd_snk_is_vbus_provided
pd_set_power_supply_ready
pd_power_supply_reset
BUG=b:69378796
BRANCH=none
TEST=make BOARD=grunt
Change-Id: Ie6c7da8575edbb11d5a4d28da3b228abd811a5a7
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/818504
Reviewed-by: Simon Glass <sjg@chromium.org> |
136,297 | 11.12.2017 11:47:02 | -32,400 | e167d36b75ab13892abaf865860a6674a5a09b59 | nautilus : update battery info
Update battery info.
BRANCH=none
TEST=build/flash nautilus, check battery information
Commit-Ready: YongBeum Ha
Tested-by: YongBeum Ha | [
{
"change_type": "MODIFY",
"old_path": "board/nautilus/battery.c",
"new_path": "board/nautilus/battery.c",
"diff": "@@ -25,16 +25,16 @@ static enum battery_present batt_pres_prev = BP_NOT_SURE;\n#define SB_SHUTDOWN_DATA 0x0010\nstatic const struct battery_info info = {\n- .voltage_max = 8800,\n+ .vo... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nautilus : update battery info
Update battery info.
BUG=b:70481430
BRANCH=none
TEST=build/flash nautilus, check battery information
Change-Id: Ia8821bb997f4a936394545ab048dd4ce10dab6a0
Reviewed-on: https://chromium-review.googlesource.com/818673
Commit-Ready: YongBeum Ha <ybha@samsung.com>
Tested-by: YongBeum Ha <ybha@samsung.com>
Reviewed-by: Philip Chen <philipchen@chromium.org> |
136,297 | 11.12.2017 11:40:27 | -32,400 | 313ea684c37a5f21d46304ed9f6515362d003544 | nautilus: Limit input current to fraction of negotiated limit
Limit input current to 96% of negotiated limit
BRANCH=none
TEST=build/flash nautilus, connect adapter and check input current
Commit-Ready: YongBeum Ha
Tested-by: YongBeum Ha | [
{
"change_type": "MODIFY",
"old_path": "board/nautilus/board.c",
"new_path": "board/nautilus/board.c",
"diff": "@@ -502,6 +502,11 @@ int board_set_active_charge_port(int charge_port)\nvoid board_set_charge_limit(int port, int supplier, int charge_ma,\nint max_ma, int charge_mv)\n{\n+ /*\n+ * Limit t... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nautilus: Limit input current to fraction of negotiated limit
Limit input current to 96% of negotiated limit
BUG=b:70481533
BRANCH=none
TEST=build/flash nautilus, connect adapter and check input current
Change-Id: I20e250d8a37f22b471a69329b2e74da2c7ff2763
Reviewed-on: https://chromium-review.googlesource.com/818844
Commit-Ready: YongBeum Ha <ybha@samsung.com>
Tested-by: YongBeum Ha <ybha@samsung.com>
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,197 | 20.11.2017 17:36:55 | -28,800 | 575c03f31c5c92144e8ee034d2b99679db09785f | chip/stm32: Add support for half-duplex UART
BRANCH=none
TEST=make BOARD=wand -j | [
{
"change_type": "MODIFY",
"old_path": "chip/stm32/usart.c",
"new_path": "chip/stm32/usart.c",
"diff": "void usart_init(struct usart_config const *config)\n{\nintptr_t base = config->hw->base;\n- uint32_t cr2;\n+ uint32_t cr2, cr3;\n/*\n* Enable clock to USART, this must be done first, before attemp... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | chip/stm32: Add support for half-duplex UART
BRANCH=none
BUG=b:65697962
TEST=make BOARD=wand -j
Change-Id: I2af4acb5cce6da6ce2f01d6d60cf5e806c9a4ed2
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/821891
Reviewed-by: Vincent Palatin <vpalatin@chromium.org> |
136,407 | 15.12.2017 10:55:42 | 28,800 | 34788758ac86de3587d7ba75848c59199aa49622 | meowth: Fix PPC configs.
There are 2.
BRANCH=None
TEST=Flash meowth. Verify that EC doesn't panic.
Commit-Ready: Aseda Aboagye
Tested-by: Aseda Aboagye | [
{
"change_type": "MODIFY",
"old_path": "board/zoombini/board.c",
"new_path": "board/zoombini/board.c",
"diff": "@@ -182,19 +182,18 @@ const struct i2c_port_t i2c_ports[] = {\nconst unsigned int i2c_ports_used = ARRAY_SIZE(i2c_ports);\n-/* TODO(aaboagye): Add the other ports. 3 for Zoombini, 2 for Me... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | meowth: Fix PPC configs.
There are 2.
BUG=None
BRANCH=None
TEST=Flash meowth. Verify that EC doesn't panic.
Change-Id: Iba0ea28a93ecb67c8b799440b1a7395d4564893b
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/829919
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,230 | 15.12.2017 18:16:40 | 28,800 | f889d14d4e08c9826c92dd2fa81d65908c97f6cd | charger/rt946x: Increase boost current threshold
We should at least be able to source 1.5A.
BRANCH=none
TEST=Confirm reg 0x0a is set correctly
Commit-Ready: Philip Chen
Tested-by: Philip Chen | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/rt946x.c",
"new_path": "driver/charger/rt946x.c",
"diff": "@@ -51,7 +51,7 @@ static const struct charger_init_setting rt946x_charger_init_setting = {\n.ircmp_vclamp = 32,\n.ircmp_res = 25,\n.boost_voltage = 5050,\n- .boost_current = 500,\n+ .boo... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | charger/rt946x: Increase boost current threshold
We should at least be able to source 1.5A.
BUG=b:70524967
BRANCH=none
TEST=Confirm reg 0x0a is set correctly
Change-Id: Ia21af18d72138b5ab81f683df5aaa92c50981694
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/830896
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,407 | 15.12.2017 16:06:56 | 28,800 | 8f63140a2b6c25b4a8fc6e5169d2a2a70c42416d | meowth: Add support for button trigerred recovery.
Also, add the button command. It will be needed for FAFT at some point.
BRANCH=None
TEST=`make -j buildall`
Commit-Ready: Aseda Aboagye
Tested-by: Aseda Aboagye | [
{
"change_type": "MODIFY",
"old_path": "board/zoombini/board.h",
"new_path": "board/zoombini/board.h",
"diff": "/* Optional features */\n#define CONFIG_HIBERNATE_PSL\n#define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands. */\n+#define CONFIG_CMD_BUTTON\n#define CONFIG_CMD_PPC_DUMP\n/* NPCX7 con... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | meowth: Add support for button trigerred recovery.
Also, add the button command. It will be needed for FAFT at some point.
BUG=b:69140339
BRANCH=None
TEST=`make -j buildall`
Change-Id: I66f3193e54dd8f089f34428dd952330a56e7100e
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/830918
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,197 | 18.09.2017 17:02:09 | -28,800 | 9a284576a822c10683ed03daa86266a94a462de9 | wand: Add wand board
hammer derivative, with a battery.
BRANCH=none
TEST=make BOARD=wand -j, flash to reworked hammer board,
battery charging works. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/hammer/battery.c",
"diff": "+/* Copyright 2017 The Chromium OS Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ */\n+\n+#include \"battery.h\"\n+#i... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | wand: Add wand board
hammer derivative, with a battery.
BRANCH=none
BUG=b:66575472
TEST=make BOARD=wand -j, flash to reworked hammer board,
battery charging works.
Change-Id: I42366f4738b35c352b9be0c44a17ebeb323adfd1
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/678756
Reviewed-by: Vincent Palatin <vpalatin@chromium.org> |
136,405 | 16.12.2017 15:14:20 | 28,800 | 66db5b4e8728ef1116d88a4ce1b54f0d403007c3 | Fizz: Set default BJ voltage and current
BRANCH=none
TEST=make runtests && buildall. Boot Fizz and let coreboot set
the adapter current and voltage.
Commit-Ready: Daisuke Nojiri
Tested-by: Daisuke Nojiri | [
{
"change_type": "MODIFY",
"old_path": "board/fizz/board.c",
"new_path": "board/fizz/board.c",
"diff": "@@ -96,9 +96,7 @@ static void adp_in_deferred(void)\nADP_DEBOUNCE_MS * MSEC);\nreturn;\n}\n- if (gpio_get_level(GPIO_POWER_RATE))\n- pi.current = 4620;\n- else\n+ /* Set it to the default. Will be... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Fizz: Set default BJ voltage and current
BUG=b:64442692
BRANCH=none
TEST=make runtests && buildall. Boot Fizz and let coreboot set
the adapter current and voltage.
Change-Id: I1afc37b7d7b8a5d88becdae2ec6644a86022dfba
Reviewed-on: https://chromium-review.googlesource.com/831398
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org> |
136,407 | 19.12.2017 12:10:00 | 28,800 | d8f08ae1a07c2884a8048b50d058653bc7a0f1be | meowth: zoombini: Add support for battery cutoff.
BRANCH=None
TEST=Flash meowth; 'cutoff'; Verify battery is cutoff. | [
{
"change_type": "MODIFY",
"old_path": "board/zoombini/battery.c",
"new_path": "board/zoombini/battery.c",
"diff": "*/\n#include \"battery.h\"\n+#include \"battery_smart.h\"\n+#include \"common.h\"\n+#include \"ec_commands.h\"\n+\n+/* Shutdown mode parameter to write to manufacturer access register ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | meowth: zoombini: Add support for battery cutoff.
BUG=None
BRANCH=None
TEST=Flash meowth; 'cutoff'; Verify battery is cutoff.
Change-Id: I95c3d1c10512c49da4768824c4126a3755af2b1a
Signed-off-by: Aseda Aboagye <aaboagye@google.com> |
136,230 | 19.12.2017 23:41:11 | 28,800 | be434eadd857e157827e9c2b69587e5ca93f1230 | cleanup: power/rk3399: Remove unused power sequence
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "power/rk3399.c",
"new_path": "power/rk3399.c",
"diff": "* Version 1: Control signals PP900_PLL_EN and PP900_PMU_EN\n* are merged with PP900_USB_EN.\n* Version 2: Simplified power tree, fewer control signals.\n- * Version 3: Close to version 1 but more componen... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: power/rk3399: Remove unused power sequence
BUG=none
BRANCH=none
TEST=make buildall -j
Change-Id: I87c7a6274cbcb355a71987b26e8f092fbdbe8fa0
Signed-off-by: Philip Chen <philipchen@google.com> |
136,230 | 20.12.2017 01:25:19 | 28,800 | efc338869d5c593100a6086f09534bfc6e34ce18 | power/rk3399: Fix the power sequence length passed to power_seq_run()
BRANCH=none
TEST=build scarlet | [
{
"change_type": "MODIFY",
"old_path": "power/rk3399.c",
"new_path": "power/rk3399.c",
"diff": "@@ -475,7 +475,7 @@ enum power_state power_handle_state(enum power_state state)\nHOST_SLEEP_EVENT_S3_WAKEABLE_SUSPEND);\nif (!usb_wake_enabled &&\npower_seq_run(s0s3_usb_wake_power_seq,\n- ARRAY_SIZE(s0s3... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | power/rk3399: Fix the power sequence length passed to power_seq_run()
BUG=b:63037490
BRANCH=none
TEST=build scarlet
Change-Id: I80b068a7846037f43e7b385cf8e2ee0b08f42b15
Signed-off-by: Philip Chen <philipchen@google.com> |
136,230 | 15.12.2017 18:47:54 | 28,800 | 24018711127b64f97844e98dfbe6860f7f7cdb0a | scarlet: Set the maximal source current as 1.5A
Scarlet has only one PD port.
Let's always source 1.5A instead of 3A.
BRANCH=none
TEST=Monitor PD packets, see Scarlet rev2 broadcast
source_cap as 'FixedVol=5.00V, MaxCur=1.50A' | [
{
"change_type": "MODIFY",
"old_path": "board/scarlet/board.h",
"new_path": "board/scarlet/board.h",
"diff": "#define CONFIG_USB_PD_LOGGING\n#define CONFIG_USB_PD_PORT_COUNT 1\n#define CONFIG_USB_PD_TCPM_FUSB302\n-#define CONFIG_USB_PD_MAX_SINGLE_SOURCE_CURRENT TYPEC_RP_3A0\n#define CONFIG_USB_PD_VB... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | scarlet: Set the maximal source current as 1.5A
Scarlet has only one PD port.
Let's always source 1.5A instead of 3A.
BUG=b:70524967
BRANCH=none
TEST=Monitor PD packets, see Scarlet rev2 broadcast
source_cap as 'FixedVol=5.00V, MaxCur=1.50A'
Change-Id: Id9bcd69f3a20ef5eb55eb7b17539fd304abb08e4
Signed-off-by: Philip Chen <philipchen@google.com> |
136,197 | 05.10.2017 16:55:49 | -28,800 | 6040852eb7df499b7d5c239b916e353e5c8a894e | poppy: Do not print base detection value if base stays connected
Reduces amount of spam during EC-EC communication.
BRANCH=none
TEST=Flash lux and wand, less spam on console | [
{
"change_type": "MODIFY",
"old_path": "board/poppy/board.c",
"new_path": "board/poppy/board.c",
"diff": "@@ -237,6 +237,11 @@ static int command_detach_base(int argc, char **argv)\nDECLARE_CONSOLE_COMMAND(detachbase, command_detach_base,\nNULL, \"Simulate detach base\");\n+static void print_base_de... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | poppy: Do not print base detection value if base stays connected
Reduces amount of spam during EC-EC communication.
BRANCH=none
BUG=b:65697962
TEST=Flash lux and wand, less spam on console
Change-Id: Ie66a3d0f4711741bf3d605f13e7595373c5246f5
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/725124
Reviewed-by: Vincent Palatin <vpalatin@chromium.org> |
136,197 | 22.12.2017 08:31:29 | -28,800 | 292b4e1bcf1f823092dde11dcb9ddfd26db88773 | fizz/nami: Drop CONFIG_THERMISTOR_NCP15WB
Nothing in fizz/nami code uses that thermistor: the 2 places that
would use it (ec_adc.c and bd99992gw.c) are not compiled in on
fizz/nami.
BRANCH=fizz
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/fizz/board.h",
"new_path": "board/fizz/board.h",
"diff": "/* Sensor */\n#define CONFIG_TEMP_SENSOR\n#define CONFIG_TEMP_SENSOR_TMP432\n-/* TODO(crosbug.com/p/61098): Is this the correct thermistor? */\n-#define CONFIG_THERMISTOR_NCP15WB\n/* USB */\n#unde... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | fizz/nami: Drop CONFIG_THERMISTOR_NCP15WB
Nothing in fizz/nami code uses that thermistor: the 2 places that
would use it (ec_adc.c and bd99992gw.c) are not compiled in on
fizz/nami.
BRANCH=fizz
BUG=none
TEST=make buildall -j
Change-Id: Ib2af8ad066eb05cd9510669600feb26641433eed
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> |
136,197 | 21.12.2017 15:58:46 | -28,800 | 809244140d31a24041344eefe8c82bb47240e9f0 | nautilus/poppy: Drop comment about thermistor
NCP15WB is actually the correct thermistor, let's drop that
copy-pasted comment.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/nautilus/board.h",
"new_path": "board/nautilus/board.h",
"diff": "/* Sensor */\n#define CONFIG_TEMP_SENSOR\n#define CONFIG_TEMP_SENSOR_BD99992GW\n-/* TODO(crosbug.com/p/61098): Is this the correct thermistor? */\n#define CONFIG_THERMISTOR_NCP15WB\n#defin... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nautilus/poppy: Drop comment about thermistor
NCP15WB is actually the correct thermistor, let's drop that
copy-pasted comment.
BRANCH=none
BUG=b:35585396
TEST=make buildall -j
Change-Id: I5577bb70e354a6f2ef6338894793b808fe4b0e9a
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> |
136,267 | 20.12.2017 10:12:06 | -3,600 | 5e93965e944370748a9d114e6de44c8bfe09047e | printf: add %li format for compatibility
For compatibility/convenience, implement the '%li' printf format
as a *32-bit* integer format, as it might be expected by non-EC code.
BRANCH=none
TEST=run on Eve EVT with unspecified external binary and see its traces
are correctly printed. | [
{
"change_type": "MODIFY",
"old_path": "common/printf.c",
"new_path": "common/printf.c",
"diff": "@@ -207,6 +207,12 @@ int vfnprintf(int (*addchar)(void *context, int c), void *context,\n#endif\nswitch (c) {\n+#ifdef CONFIG_PRINTF_LEGACY_LI_FORMAT\n+ case 'i':\n+ /* force 32-bit for compatibility */... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | printf: add %li format for compatibility
For compatibility/convenience, implement the '%li' printf format
as a *32-bit* integer format, as it might be expected by non-EC code.
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
BRANCH=none
BUG=b:70320279
TEST=run on Eve EVT with unspecified external binary and see its traces
are correctly printed.
Change-Id: Iac20e823c74aac4f659176416eebd804c321d47c |
136,333 | 21.12.2017 15:06:32 | 18,000 | 2f1f5a555105cdff9d6b0a3278bf13e617143c9c | ec_chip_mchp: Add LFW files
Add Microchip MEC17xx family little-firmware
(LFW) folder and files. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "chip/mchp/lfw/ec_lfw.c",
"diff": "+/* Copyright 2017 The Chromium OS Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ *\n+ * MCHP MEC SoC little FW\n+ *\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_chip_mchp: Add LFW files
Add Microchip MEC17xx family little-firmware
(LFW) folder and files.
Change-Id: I9142266d41234574730fadccd5a2cc27fe3d8fd7
Signed-off-by: Scott Worley <scott.worley@microchip.corp-partner.google.com> |
136,333 | 21.12.2017 13:56:31 | 18,000 | c334f648bd644f5e72e841458fdac6796efa1ceb | ec_chip_mchp: Add ADC and DMA files
Add Microchip MEC17xx family ADC and DMA
source files for review.
BRANCH=none
TEST=Review only. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "chip/mchp/adc.c",
"diff": "+/* Copyright 2017 The Chromium OS Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ */\n+\n+#include \"adc.h\"\n+#include \"ad... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_chip_mchp: Add ADC and DMA files
Add Microchip MEC17xx family ADC and DMA
source files for review.
BRANCH=none
BUG=
TEST=Review only.
Change-Id: Iccf19223ddd3f6774b90d5fca32079be9b0c4bcc
Signed-off-by: Scott Worley <scott.worley@microchip.corp-partner.google.com> |
136,333 | 20.12.2017 15:03:39 | 18,000 | 304bb8b09c60a75ac8eae72ab017a5996b76afeb | ec_als: ALS now uses CPRINT macros
Modify ALS module to use CPRINT macros with
channel support.
BRANCH=none
TEST=Build board(s) with ALS support such glados.
Test ALS CPRINT messages go out over EC UART and
can be masked off by channel mask UART command. | [
{
"change_type": "MODIFY",
"old_path": "common/als.c",
"new_path": "common/als.c",
"diff": "#include \"timer.h\"\n#include \"util.h\"\n+#define CPUTS(outstr) cputs(CC_ALS, outstr)\n+#define CPRINTS(format, args...) cprints(CC_ALS, format, ## args)\n+#define CPRINTF(format, args...) cprintf(CC_ALS, f... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_als: ALS now uses CPRINT macros
Modify ALS module to use CPRINT macros with
channel support.
BRANCH=none
BUG=
TEST=Build board(s) with ALS support such glados.
Test ALS CPRINT messages go out over EC UART and
can be masked off by channel mask UART command.
Change-Id: I65ffc889d63a778f3fb8995f508773842ba875ef
Signed-off-by: Scott Worley <scott.worley@microchip.corp-partner.google.com> |
136,226 | 27.12.2017 16:12:08 | 28,800 | bc8fda9e0f4737be3fc635832d4099a9e3b5451a | glkrvp: Enable discharge on AC config
This CONFIG DISCHARGE_ON_AC enables discharging
battery even when AC is connected.
BRANCH=glkrvp
TEST=On glkrvp EC console, execute command
"chgstate discharge on" and verify if battery
is discharging with "battery" command. | [
{
"change_type": "MODIFY",
"old_path": "board/glkrvp/board.h",
"new_path": "board/glkrvp/board.h",
"diff": "/* Charger */\n#define CONFIG_CHARGE_MANAGER\n#define CONFIG_CHARGER\n+#define CONFIG_CHARGER_DISCHARGE_ON_AC\n#define CONFIG_CHARGER_INPUT_CURRENT 512\n#define CONFIG_CHARGER_ISL9238\n#define... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | glkrvp: Enable discharge on AC config
This CONFIG DISCHARGE_ON_AC enables discharging
battery even when AC is connected.
BUG=b:71364739
BRANCH=glkrvp
TEST=On glkrvp EC console, execute command
"chgstate discharge on" and verify if battery
is discharging with "battery" command.
Change-Id: I709c7b5ccfea9058961d387a1575db9aebe70707
Signed-off-by: Divya Sasidharan <divya.s.sasidharan@intel.com> |
136,333 | 21.12.2017 14:13:47 | 18,000 | eb29ab7acdcb5b9d88794a3f5d36850f6e33a2a5 | ec_chip_mchp: Add PWM and fan files
Add Microchip MEC17xx family PWM and fan
source files for review
BRANCH=none
TEST=Review only. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "chip/mchp/fan.c",
"diff": "+/* Copyright 2017 The Chromium OS Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ */\n+\n+/* MCHP MEC fan control module. */... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_chip_mchp: Add PWM and fan files
Add Microchip MEC17xx family PWM and fan
source files for review
BRANCH=none
BUG=
TEST=Review only.
Change-Id: I91439ab999a4662d690b58b0fbbb887f643b3673
Signed-off-by: Scott Worley <scott.worley@microchip.corp-partner.google.com> |
136,333 | 20.12.2017 15:32:39 | 18,000 | 940dd625b9edaf1827c9c3a2349a66ec21cd59c8 | ec_driver: Add ADT7481 and TMP411 I2C sensors
Added I2C sensors ADT7481 and TMP411 with config
items and build rules.
BRANCH=none
TEST=Define CONFIG_TEMP_SENSOR_ADT7481 or _TMP411
and build board. | [
{
"change_type": "MODIFY",
"old_path": "driver/build.mk",
"new_path": "driver/build.mk",
"diff": "@@ -73,13 +73,15 @@ driver-$(CONFIG_LED_DRIVER_LP5562)+=led/lp5562.o\ndriver-$(CONFIG_REGULATOR_IR357X)+=regulator_ir357x.o\n# Temperature sensors\n+driver-$(CONFIG_TEMP_SENSOR_ADT7481)+=temp_sensor/adt... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_driver: Add ADT7481 and TMP411 I2C sensors
Added I2C sensors ADT7481 and TMP411 with config
items and build rules.
BRANCH=none
BUG=
TEST=Define CONFIG_TEMP_SENSOR_ADT7481 or _TMP411
and build board.
Change-Id: I4d1eb55ee56ad3f42787538bb839193e683d0a60
Signed-off-by: Scott Worley <scott.worley@microchip.corp-partner.google.com> |
136,333 | 20.12.2017 14:37:31 | 18,000 | f8dc4617128f72cdcef4aae33afd665d3fbc5a2f | ec_flash: Add W25Q128 SPI flash
Add W25Q128 flash device support.
BRANCH=none
TEST=Modify a board build for W25Q128 and check
SPI code sets flash security bits correctly. | [
{
"change_type": "MODIFY",
"old_path": "common/spi_flash_reg.c",
"new_path": "common/spi_flash_reg.c",
"diff": "@@ -72,7 +72,14 @@ static const struct protect_range spi_flash_protect_ranges[] = {\n{ 0, 0, 1, { 0, 1, 1 }, 0, 0x40000 }, /* Lower 1/4 */\n{ 0, 0, 1, { 1, 0, 0 }, 0, 0x80000 }, /* Lower 1... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_flash: Add W25Q128 SPI flash
Add W25Q128 flash device support.
BRANCH=none
BUG=
TEST=Modify a board build for W25Q128 and check
SPI code sets flash security bits correctly.
Change-Id: I6173f4cf751f3fbf68af75983f44d357a0b954f6
Signed-off-by: Scott Worley <scott.worley@microchip.corp-partner.google.com> |
136,333 | 21.12.2017 14:49:50 | 18,000 | c56df0d8314358709ef58f2dd82a858d62e30866 | ec_chip_mchp: Add other hardware files
Add Micorchip MEC17xx family files for
hardware timers, keyboard scan, host
port 80h, UART, and watch dog timer.
BRANCH=none
TEST=Review only. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "chip/mchp/hwtimer.c",
"diff": "+/* Copyright 2017 The Chromium OS Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ */\n+\n+/* Hardware timers driver */\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_chip_mchp: Add other hardware files
Add Micorchip MEC17xx family files for
hardware timers, keyboard scan, host
port 80h, UART, and watch dog timer.
BRANCH=none
BUG=
TEST=Review only.
Change-Id: Iac8a912af4d29521964f606637041b06fa7238ee
Signed-off-by: Scott Worley <scott.worley@microchip.corp-partner.google.com> |
136,333 | 21.12.2017 15:00:28 | 18,000 | 9f5a1556501d4acfb722f8b977d6f67ff2434bcb | ec_chip_mchp: Add MCHP TFDP trace debug files
Add Microchip MEC17xx family trace fifo debug
(TFDP) files. TFDP is a MCHP specific two pin,
output only software message port.
Added TFDP module ID. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "chip/mchp/tfdp.c",
"diff": "+/* Copyright 2017 The Chromium OS Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ */\n+\n+/** @file tfdp.c\n+ *MCHP Trace F... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_chip_mchp: Add MCHP TFDP trace debug files
Add Microchip MEC17xx family trace fifo debug
(TFDP) files. TFDP is a MCHP specific two pin,
output only software message port.
Added TFDP module ID.
Change-Id: Ibe2399a8c3618b207a89552450d80b7901e85f23
Signed-off-by: Scott Worley <scott.worley@microchip.corp-partner.google.com> |
136,197 | 28.12.2017 11:41:35 | -28,800 | 3ce0b8b9246d4685494df941f65e2777250956a0 | wand: Increase PWM frequency to 50kHz
RT4531 wants PWM input frequency between 20 and 100 kHz.
BRANCH=none
TEST=Flash wand, pwm 0 50, check with oscilloscope that frequency
is around 50kHz, and that duty cycle is 50%. | [
{
"change_type": "MODIFY",
"old_path": "board/hammer/board.c",
"new_path": "board/hammer/board.c",
"diff": "@@ -78,7 +78,7 @@ const unsigned int i2c_ports_used = ARRAY_SIZE(i2c_ports);\n#ifdef BOARD_STAFF\n#define KBLIGHT_PWM_FREQ 100 /* Hz */\n#else\n-#define KBLIGHT_PWM_FREQ 10000 /* Hz */\n+#defi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | wand: Increase PWM frequency to 50kHz
RT4531 wants PWM input frequency between 20 and 100 kHz.
BRANCH=none
BUG=b:66575472
TEST=Flash wand, pwm 0 50, check with oscilloscope that frequency
is around 50kHz, and that duty cycle is 50%.
Change-Id: I6a37ef435a51cf730805ef57a0e3ebd05f9820a3
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/845541
Reviewed-by: Furquan Shaikh <furquan@chromium.org> |
136,382 | 03.01.2018 12:36:16 | 25,200 | bb113312271f790639cf6c7fc1da04ecd71f647d | kahlee: Switch thermal I2C over to 1.8V
The SB-TSI temp sensor on the FT4 requires the 1.8V for the I2C bus.
BRANCH=None
TEST=Build, deploy, over servo: `temps`
Commit-Ready: Alec Thilenius
Tested-by: Alec Thilenius | [
{
"change_type": "MODIFY",
"old_path": "board/kahlee/gpio.inc",
"new_path": "board/kahlee/gpio.inc",
"diff": "@@ -27,8 +27,8 @@ GPIO(LID_ACCEL_INT_L, PIN(C, 7), GPIO_INPUT | GPIO_PULL_UP)\nGPIO(ALS_INT_L, PIN(0, 2), GPIO_INPUT | GPIO_PULL_UP)\n/* I2C GPIOs will be set to alt. function later. */\n-GP... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kahlee: Switch thermal I2C over to 1.8V
The SB-TSI temp sensor on the FT4 requires the 1.8V for the I2C bus.
BUG=b:69379715
BRANCH=None
TEST=Build, deploy, over servo: `temps`
Change-Id: I9929d7f5ac4a029f7314bac6eae50ee2c54b8ea4
Reviewed-on: https://chromium-review.googlesource.com/849275
Commit-Ready: Alec Thilenius <athilenius@google.com>
Tested-by: Alec Thilenius <athilenius@google.com>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,197 | 13.12.2017 14:44:48 | -28,800 | cfc69f6fb868b802a6033580ffe0cf73c092aca8 | ec_ec_comm_master: Functions for EC-EC communication master
This adds functions required for the master in EC-EC communication,
requesting base battery static and dynamic information, and charger
control.
BRANCH=none
TEST=Flash lux and wand, EC-EC communication works. | [
{
"change_type": "MODIFY",
"old_path": "common/build.mk",
"new_path": "common/build.mk",
"diff": "@@ -46,6 +46,7 @@ common-$(CONFIG_DEDICATED_RECOVERY_BUTTON)+=button.o\ncommon-$(CONFIG_DEVICE_EVENT)+=device_event.o\ncommon-$(CONFIG_DEVICE_STATE)+=device_state.o\ncommon-$(CONFIG_DPTF)+=dptf.o\n+comm... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_ec_comm_master: Functions for EC-EC communication master
This adds functions required for the master in EC-EC communication,
requesting base battery static and dynamic information, and charger
control.
BRANCH=none
BUG=b:65526215
TEST=Flash lux and wand, EC-EC communication works.
Change-Id: I7a46ee3f5848d22c2c9bea7870cbd7e74141cf3d
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/839201 |
136,197 | 05.01.2018 13:35:14 | -28,800 | 1c0d70d1b0796fc339e7b59eeeed118a081f5908 | soraka: Replace individual files symlinks by directory symlinks
Makes it easier to add new files in poppy folder.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/soraka",
"diff": "+poppy\n\\ No newline at end of file\n"
},
{
"change_type": "DELETE",
"old_path": "board/soraka/battery.c",
"new_path": null,
"diff": "-../poppy/battery.c\n\\ No newline at end of file\n"
},
{
... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | soraka: Replace individual files symlinks by directory symlinks
Makes it easier to add new files in poppy folder.
BRANCH=none
BUG=none
TEST=make buildall -j
Change-Id: I1614d26b4a3766da9aff8c05eaed632a9589955d
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/851553
Reviewed-by: Furquan Shaikh <furquan@chromium.org> |
136,399 | 28.11.2017 12:48:53 | 25,200 | 084af6386f819fa8111dc0998bd28c86e5093e17 | grunt: Add accel, gyro, and motion_sense task.
This adds support for the KX022 and BMI160 sensors.
It also enables the motion_sense task so that the keyboard can be
disabled in tablet mode.
BRANCH=None
TEST=Build | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/board.c",
"new_path": "board/grunt/board.c",
"diff": "#include \"common.h\"\n#include \"compile_time_macros.h\"\n#include \"console.h\"\n+#include \"driver/accel_kionix.h\"\n+#include \"driver/accel_kx022.h\"\n+#include \"driver/accelgyro_bmi160.h\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Add accel, gyro, and motion_sense task.
This adds support for the KX022 and BMI160 sensors.
It also enables the motion_sense task so that the keyboard can be
disabled in tablet mode.
BUG=b:69379570,b:69379621
BRANCH=None
TEST=Build
Change-Id: I72cc8f86ddd8d466b4208ff583e93fd51da63c49
Signed-off-by: Justin TerAvest <teravest@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/794525
Reviewed-by: Gwendal Grignou <gwendal@chromium.org> |
136,282 | 05.01.2018 20:39:43 | -28,800 | 0ebb1c2479caf9936cdc35396a01ed87011d9b4c | Fizz: override DP EQ setting for Deterministic Jitter
Set lower EQ of DP port to 4.5db.
BRANCH=none
TEST=use ectools to read PS8751 reg offset 0xd3 as 0x98 | [
{
"change_type": "MODIFY",
"old_path": "board/fizz/board.c",
"new_path": "board/fizz/board.c",
"diff": "@@ -192,11 +192,20 @@ const struct tcpc_config_t tcpc_config[CONFIG_USB_PD_PORT_COUNT] = {\nTCPC_ALERT_ACTIVE_LOW},\n};\n+static int ps8751_tune_mux(const struct usb_mux *mux)\n+{\n+ /* 0x98 sets ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Fizz: override DP EQ setting for Deterministic Jitter
Set lower EQ of DP port to 4.5db.
BUG=b:71613170
BRANCH=none
TEST=use ectools to read PS8751 reg offset 0xd3 as 0x98
Change-Id: Iedc0002028ead6f0f6fa7aeef4ad2845b028a76b
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/851756
Reviewed-by: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,322 | 16.12.2017 17:27:28 | -32,400 | b167a193e66e3c05ad61d997994072e36cb73773 | nautilus: update sensor rotation matrix.
From rev02, Lid rotation matrix is changed.
So, we have to change rotation matrix as well.
BRANCH=master
TEST=check lid_angle on rev2.
Tested-by: Grace Kao | [
{
"change_type": "MODIFY",
"old_path": "board/nautilus/board.c",
"new_path": "board/nautilus/board.c",
"diff": "@@ -583,8 +583,8 @@ const matrix_3x3_t base_standard_ref = {\nconst matrix_3x3_t lid_standard_ref = {\n{ FLOAT_TO_FP(-1), 0, 0 },\n- { 0, FLOAT_TO_FP(-1), 0},\n- { 0, 0, FLOAT_TO_FP(1)}\n+... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nautilus: update sensor rotation matrix.
From rev02, Lid rotation matrix is changed.
So, we have to change rotation matrix as well.
BRANCH=master
BUG=b:69399214
TEST=check lid_angle on rev2.
Change-Id: I6718b607391aef068bee3c324e85138bac0e283e
Signed-off-by: Jongpil Jung <jongpil19.jung@samsung.com>
Reviewed-on: https://chromium-review.googlesource.com/830990
Tested-by: Grace Kao <grace.kao@intel.com>
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,197 | 28.09.2017 16:27:38 | -28,800 | 9a89170ed4878df8a04cb7d82ea3afc102179107 | lux: Add lux board
lux is a dual-battery poppy derivative.
BRANCH=none
TEST=make BOARD=lux -j | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/lux",
"diff": "+poppy\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/poppy/base_detect_lux.c",
"diff": "+/* Copyright 2018 The Chromium OS Authors. All rights reserved.\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | lux: Add lux board
lux is a dual-battery poppy derivative.
BRANCH=none
BUG=b:67029560
TEST=make BOARD=lux -j
Change-Id: I01fdb1e5e2b4803cdf7f03f9e6ee73603f84a7b8
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/845542
Reviewed-by: Vincent Palatin <vpalatin@chromium.org> |
136,267 | 20.12.2017 10:15:39 | -3,600 | e3323bee6966fbde19f445a6de449b17efbfd06b | stm32mon: add STM32H7 identifier
Add a new chip ID to support the STM32H7x3 parts.
BRANCH=none
TEST=flash_ec --board=meowth_fp
Commit-Ready: Vincent Palatin
Tested-by: Vincent Palatin | [
{
"change_type": "MODIFY",
"old_path": "util/stm32mon.c",
"new_path": "util/stm32mon.c",
"diff": "@@ -93,6 +93,7 @@ struct stm32_def {\n{0x442, \"STM32F09x\", 0x40000, 2048, {13, 13} },\n{0x431, \"STM32F411\", 0x80000, 16384, {13, 19} },\n{0x441, \"STM32F412\", 0x80000, 16384, {13, 19} },\n+ {0x450,... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | stm32mon: add STM32H7 identifier
Add a new chip ID to support the STM32H7x3 parts.
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
BRANCH=none
BUG=b:67081508
TEST=flash_ec --board=meowth_fp
Change-Id: I3897a74f5414e0e6b13890291706134c2d916af9
Reviewed-on: https://chromium-review.googlesource.com/856977
Commit-Ready: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org> |
136,291 | 11.01.2018 15:36:48 | 28,800 | 641f73185f59fe6152fdfa41b04d265eace7f23f | board: rainier: fix accel orientation
Rainier has landscape orientation, therefore needs its accelerometer
base values adjusted.
TEST=Rotate rainier and make sure screen orientation is not off by 90
degrees.
BRANCH=None | [
{
"change_type": "MODIFY",
"old_path": "board/rainier/board.c",
"new_path": "board/rainier/board.c",
"diff": "@@ -352,8 +352,8 @@ static struct bmi160_drv_data_t g_bmi160_data;\n/* Matrix to rotate accelerometer into standard reference frame */\nconst matrix_3x3_t base_standard_ref = {\n- { FLOAT_TO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | board: rainier: fix accel orientation
Rainier has landscape orientation, therefore needs its accelerometer
base values adjusted.
BUG=b:71753415
TEST=Rotate rainier and make sure screen orientation is not off by 90
degrees.
BRANCH=None
Signed-off-by: Ege Mihmanli <egemih@google.com>
Change-Id: I60b49e717c691e34a39e817d2c064ea45b8d53d7
Reviewed-on: https://chromium-review.googlesource.com/862733
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,427 | 12.01.2018 09:08:29 | 28,800 | cb8c63280139ec5990cd57668e81151e4b66856b | grunt: rename volume GPIOs
BRANCH=none
TEST=press volume buttons, see console messages | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/board.h",
"new_path": "board/grunt/board.h",
"diff": "#define CONFIG_KEYBOARD_PROTOCOL_8042\n#define CONFIG_VOLUME_BUTTONS\n-#define GPIO_VOLUME_DOWN_L GPIO_VOLDN_BTN_ODL\n-#define GPIO_VOLUME_UP_L GPIO_VOLUP_BTN_ODL\n#define CONFIG_USB_POWER_DELIV... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: rename volume GPIOs
BUG=b:64935726
BRANCH=none
TEST=press volume buttons, see console messages
Change-Id: I327a166e05bd815acc66d2f6e30fe8ae9d6d1cce
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/864825
Reviewed-by: Simon Glass <sjg@chromium.org> |
136,219 | 11.01.2018 19:17:48 | 28,800 | 2bd336f1d2658ddbad7f5bd148c45eaaed197948 | grunt: Add I2C support for the BMI160
We need to enable I2C_PORT_ACCEL so that the driver supports I2C
transfers.
BRANCH=none
TEST=On EC console:
> accelinit 1
> accelread 1
With this CL we avoid an error | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/board.h",
"new_path": "board/grunt/board.h",
"diff": "#define I2C_PORT_TCPC1 NPCX_I2C_PORT2_0\n#define I2C_PORT_THERMAL NPCX_I2C_PORT3_0\n#define I2C_PORT_SENSOR NPCX_I2C_PORT7_0\n+/* Accelerometer and Gyroscope are the same device. */\n+#define I2... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Add I2C support for the BMI160
We need to enable I2C_PORT_ACCEL so that the driver supports I2C
transfers.
BUG=b:71877225
BRANCH=none
TEST=On EC console:
> accelinit 1
> accelread 1
With this CL we avoid an error
Change-Id: I9b7018ef9615992d91fbf8685832ff73c3cc1172
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/863206
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,291 | 12.01.2018 15:18:43 | 28,800 | 0765c05d33c985dc752bf2c4668c6e7be6d4c671 | rainier: final fix for accel orientation.
Rainier has landscape orientation and last patch was 90 degrees off in
its base rotation value.
TEST=Flash ec on rainier and tilt device.
BRANCH=None | [
{
"change_type": "MODIFY",
"old_path": "board/rainier/board.c",
"new_path": "board/rainier/board.c",
"diff": "@@ -352,8 +352,8 @@ static struct bmi160_drv_data_t g_bmi160_data;\n/* Matrix to rotate accelerometer into standard reference frame */\nconst matrix_3x3_t base_standard_ref = {\n- { 0, FLOAT... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | rainier: final fix for accel orientation.
Rainier has landscape orientation and last patch was 90 degrees off in
its base rotation value.
BUG=b:71753415
TEST=Flash ec on rainier and tilt device.
BRANCH=None
Signed-off-by: Ege Mihmanli <egemih@google.com>
Change-Id: I1d0837b2391ec4d0051c6c9af984d801264fe64c
Reviewed-on: https://chromium-review.googlesource.com/865803
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,427 | 12.01.2018 09:14:54 | 28,800 | dd404f34d54461e4fbd10e3371697799a3e0c4df | grunt: Add CONFIG_VBOOT_HASH
The vboot hash calculation needs to be enabled for EC software sync.
BRANCH=none
TEST=see hash on console | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/board.h",
"new_path": "board/grunt/board.h",
"diff": "#define CONFIG_SPI_FLASH_REGS\n#define CONFIG_SPI_FLASH_W25Q80 /* Internal SPI flash type. */\n-/* EC Modules */\n#define CONFIG_ADC\n+#define CONFIG_BOARD_VERSION\n#define CONFIG_I2C\n+#define ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Add CONFIG_VBOOT_HASH
The vboot hash calculation needs to be enabled for EC software sync.
BUG=b:64935726
BRANCH=none
TEST=see hash on console
Change-Id: I2d26ef997fc9ed803e80cc716a518a2834632269
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/864826
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@google.com> |
136,427 | 12.01.2018 09:37:50 | 28,800 | ad59381ca31fb4728a1da24e28c3b17cf8468dc6 | grunt: Enable BMI160 gyro interrupts
Setup bmi160_interrupt and enable in board_init.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/board.c",
"new_path": "board/grunt/board.c",
"diff": "@@ -196,6 +196,13 @@ const int usb_port_enable[CONFIG_USB_PORT_POWER_SMART_PORT_COUNT] = {\nGPIO_EN_USB_A1_5V,\n};\n+static void board_init(void)\n+{\n+ /* Enable Gyro interrupts */\n+ gpio_enab... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Enable BMI160 gyro interrupts
Setup bmi160_interrupt and enable in board_init.
BUG=b:69379621
BRANCH=none
TEST=none
Change-Id: I80d08146367af0b91d8d9ac1495c85fe8edd0203
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/864827
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,427 | 12.01.2018 11:17:22 | 28,800 | 66bc9c1082771e4da720f93e64aadfae23c1f22e | grunt: Fix ENABLE_BACKLIGHT to be active low
BRANCH=none
TEST=backlight turns on in S0 | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/board.c",
"new_path": "board/grunt/board.c",
"diff": "@@ -203,6 +203,20 @@ static void board_init(void)\n}\nDECLARE_HOOK(HOOK_INIT, board_init, HOOK_PRIO_DEFAULT);\n+static void board_chipset_resume(void)\n+{\n+ /* Turn on display backlight (active... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Fix ENABLE_BACKLIGHT to be active low
BUG=b:71806495
BRANCH=none
TEST=backlight turns on in S0
Change-Id: Ib9271d6cbe9befdf4ed492a9c2b676452e5f4d9b
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/865155
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,297 | 10.01.2018 14:37:09 | -32,400 | 67ae6eb9b02d896d51da725c273d472a6fe01366 | nautilus: support BC1.2 on USB Type-A port
support BC1.2 on USB Type-A port
BRANCH=none
TEST=build/flash nautilus
Commit-Ready: YongBeum Ha
Tested-by: YongBeum Ha | [
{
"change_type": "MODIFY",
"old_path": "board/nautilus/board.c",
"new_path": "board/nautilus/board.c",
"diff": "@@ -196,6 +196,10 @@ struct pi3usb9281_config pi3usb9281_chips[] = {\nBUILD_ASSERT(ARRAY_SIZE(pi3usb9281_chips) ==\nCONFIG_BC12_DETECT_PI3USB9281_CHIP_COUNT);\n+const int usb_port_enable[C... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nautilus: support BC1.2 on USB Type-A port
support BC1.2 on USB Type-A port
BUG=b:71775046
BRANCH=none
TEST=build/flash nautilus
Change-Id: Iff9e95d06c0498d8f093d508bc50a0754e973c37
Reviewed-on: https://chromium-review.googlesource.com/858979
Commit-Ready: YongBeum Ha <ybha@samsung.com>
Tested-by: YongBeum Ha <ybha@samsung.com>
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,427 | 14.01.2018 17:50:27 | 28,800 | 7f1bb54c108d8e01158b5fade051552942664fd0 | grunt: Set source current limit to enable 3A output
Call ppc_set_vbus_source_current_limit to enable 3A output.
BRANCH=none
TEST=connect PD sink and see 5V 3A on both ports | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/usb_pd_policy.c",
"new_path": "board/grunt/usb_pd_policy.c",
"diff": "@@ -125,8 +125,10 @@ void pd_power_supply_reset(int port)\nif (prev_en)\npd_set_vbus_discharge(port, 1);\n+#ifdef CONFIG_USB_PD_MAX_SINGLE_SOURCE_CURRENT\n/* Give back the curren... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Set source current limit to enable 3A output
Call ppc_set_vbus_source_current_limit to enable 3A output.
BUG=b:69378796
BRANCH=none
TEST=connect PD sink and see 5V 3A on both ports
Change-Id: Ia38ebcb3b1b3d1148a00b3050fcda2bd2cf73af5
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/866158
Reviewed-by: Justin TerAvest <teravest@chromium.org> |
136,427 | 15.01.2018 14:42:24 | 28,800 | be1f97a2551549d81f77f0439a23683343234c40 | grunt: Enable TCPC + PPC interrupts and overcurrent GPIOs
BRANCH=none
TEST=PD still works on both ports | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/board.c",
"new_path": "board/grunt/board.c",
"diff": "@@ -91,6 +91,13 @@ void anx74xx_cable_det_interrupt(enum gpio_signal signal)\n}\n#endif\n+static void ppc_interrupt(enum gpio_signal signal)\n+{\n+ int port = (signal == GPIO_USB_C0_SWCTL_INT_OD... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Enable TCPC + PPC interrupts and overcurrent GPIOs
BUG=b:69378796
BRANCH=none
TEST=PD still works on both ports
Change-Id: I6c9d378483d141db821da2a717cf1256099b01ec
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/867234
Reviewed-by: Aaron Durbin <adurbin@google.com> |
136,405 | 03.10.2017 18:28:57 | 25,200 | 6e3e0f87b1384b7adaece5d37887b96b0fdf89dd | CBI: Read board info from EEPROM
This patch adds Cros Board Info APIs. It reads board info from EEPROM.
This patch sets CONFIG_CBI for Fizz to make it use CBI.
BRANCH=none
TEST=Read data from EEPROM.
Commit-Ready: Daisuke Nojiri
Tested-by: Daisuke Nojiri | [
{
"change_type": "MODIFY",
"old_path": "board/fizz/board.c",
"new_path": "board/fizz/board.c",
"diff": "#include \"charger.h\"\n#include \"chipset.h\"\n#include \"console.h\"\n+#include \"cros_board_info.h\"\n#include \"driver/pmic_tps650x30.h\"\n#include \"driver/temp_sensor/tmp432.h\"\n#include \"... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | CBI: Read board info from EEPROM
This patch adds Cros Board Info APIs. It reads board info from EEPROM.
This patch sets CONFIG_CBI for Fizz to make it use CBI.
BUG=b:70294260
BRANCH=none
TEST=Read data from EEPROM.
Change-Id: I7eb4323188817d46b0450f1d65ac34d1b7e4e220
Reviewed-on: https://chromium-review.googlesource.com/707741
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,405 | 12.01.2018 12:52:18 | 28,800 | 5232cdd16bb2e1b15b281b0041c33c55bc9ca52d | CBI: Add host command to get board info
This patch adds host command to get board info from EEPROM.
BRANCH=none
TEST=Run ectool cbi get <type> to get board version, OEM, SKU | [
{
"change_type": "MODIFY",
"old_path": "common/cbi.c",
"new_path": "common/cbi.c",
"diff": "#include \"console.h\"\n#include \"crc8.h\"\n#include \"cros_board_info.h\"\n+#include \"host_command.h\"\n#include \"i2c.h\"\n#include \"util.h\"\n@@ -125,3 +126,31 @@ int board_get_version(void)\nreturn -1;... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | CBI: Add host command to get board info
This patch adds host command to get board info from EEPROM.
BUG=b:70294260
BRANCH=none
TEST=Run ectool cbi get <type> to get board version, OEM, SKU
Change-Id: I41a84d3eea6da9d88fa8122db36dcd1df515842d
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/865161
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
136,405 | 12.01.2018 12:52:18 | 28,800 | bc4b786156b3dd51de75f512d05679d5b413399b | CBI: Add host command to set board info
This patch adds host command to write board information in EERPOM.
BRANCH=none
TEST=Run ectool cbi set <type> <value> to write BOARD_VERSION, OEM_ID,
and SKU_ID. Enable WP and verify cbi set command fails. | [
{
"change_type": "MODIFY",
"old_path": "common/cbi.c",
"new_path": "common/cbi.c",
"diff": "#include \"console.h\"\n#include \"crc8.h\"\n#include \"cros_board_info.h\"\n+#include \"gpio.h\"\n#include \"host_command.h\"\n#include \"i2c.h\"\n#include \"util.h\"\n#define CPRINTS(format, args...) cprint... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | CBI: Add host command to set board info
This patch adds host command to write board information in EERPOM.
BUG=b:70294260
BRANCH=none
TEST=Run ectool cbi set <type> <value> to write BOARD_VERSION, OEM_ID,
and SKU_ID. Enable WP and verify cbi set command fails.
Change-Id: I39536d146313408ace666f350a107d89b331bf7a
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/865570 |
136,256 | 17.01.2018 16:53:59 | 28,800 | d52ba1a4d4801fdba129be64fa4c1c53a7ced817 | backlight: Adding support for active low GPIO signal
BRANCH=none
TEST=Verified with grunt board (with is active low) | [
{
"change_type": "MODIFY",
"old_path": "common/backlight_lid.c",
"new_path": "common/backlight_lid.c",
"diff": "#include \"host_command.h\"\n#include \"lid_switch.h\"\n+\n+/**\n+ * Activate/Deactivate the backlight GPIO pin considering active high or low.\n+ */\n+void enable_backlight(int enabled)\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | backlight: Adding support for active low GPIO signal
BUG=b:72007261
BRANCH=none
TEST=Verified with grunt board (with is active low)
Change-Id: I9a58148b8d92065bec982071ed1d97a466197e9a
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/872233
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,267 | 18.01.2018 17:02:11 | -3,600 | f8825cef150365a70e49464089f0133a418a9c9f | fpsensor: fix test build
Disable the private fp driver calls for test binaries.
BRANCH=none
TEST=make BOARD=meowth_fp tests
Commit-Ready: Vincent Palatin
Tested-by: Vincent Palatin | [
{
"change_type": "MODIFY",
"old_path": "common/fpsensor.c",
"new_path": "common/fpsensor.c",
"diff": "#include \"timer.h\"\n#include \"util.h\"\n#include \"watchdog.h\"\n-#ifdef HAVE_PRIVATE\n+#if defined(HAVE_PRIVATE) && !defined(TEST_BUILD)\n+#define HAVE_FP_PRIVATE_DRIVER\n#define PRIV_HEADER(hea... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | fpsensor: fix test build
Disable the private fp driver calls for test binaries.
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
BRANCH=none
BUG=b:70320279
TEST=make BOARD=meowth_fp tests
Change-Id: I16f241a33ead3ea29e7aa955512e05e679a0c551
Reviewed-on: https://chromium-review.googlesource.com/873923
Commit-Ready: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,197 | 08.01.2018 16:18:13 | -28,800 | 9e71ed4b4de20b375e49b5d6c427c38af022893a | charge_state_v2: Wake charger task when we start/stop providing power
BRANCH=none
TEST=On wand, battery information is quickly updated after
(un)pluging AC on lid (otherwise we might have to wait up to
60 seconds). | [
{
"change_type": "MODIFY",
"old_path": "common/charge_state_v2.c",
"new_path": "common/charge_state_v2.c",
"diff": "@@ -1319,6 +1319,11 @@ int charge_set_output_current_limit(int ma, int mv)\nif (ret != EC_SUCCESS)\nreturn ret;\n+ /* If we start/stop providing power, wake the charger task. */\n+ if ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | charge_state_v2: Wake charger task when we start/stop providing power
BRANCH=none
BUG=b:65697962
TEST=On wand, battery information is quickly updated after
(un)pluging AC on lid (otherwise we might have to wait up to
60 seconds).
Change-Id: I2bd457ba4d38aa4c99638a2576a4132406416de2
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/859401
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,256 | 17.01.2018 16:55:19 | 28,800 | f02c8c4c87cdf9c30b44be9c7ba49e506115a188 | grunt: Enabling backlight lid control module
Enabling backlight control module with active low mode enabled.
BRANCH=none
TEST=Booted grunt board and verified lid sensor toggles backlight | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/board.c",
"new_path": "board/grunt/board.c",
"diff": "@@ -219,20 +219,24 @@ static void board_init(void)\n}\nDECLARE_HOOK(HOOK_INIT, board_init, HOOK_PRIO_DEFAULT);\n-static void board_chipset_resume(void)\n-{\n- /* Turn on display backlight (activ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Enabling backlight lid control module
Enabling backlight control module with active low mode enabled.
BUG=b:72007261
BRANCH=none
TEST=Booted grunt board and verified lid sensor toggles backlight
Change-Id: I14a6eec01c4cda6fcb4b821b9a4b6f266b8fe78b
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/872234
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,230 | 18.01.2018 14:00:11 | 28,800 | 741a81469048ffed2da26189805c4e0c6aa518b4 | scarlet: Update the charging current for Simplo battery
Simplo updated the datesheet and limited the charging current to 3A.
BRANCH=none
TEST=none
Commit-Ready: Philip Chen
Tested-by: Philip Chen | [
{
"change_type": "MODIFY",
"old_path": "board/scarlet/battery.c",
"new_path": "board/scarlet/battery.c",
"diff": "@@ -148,8 +148,8 @@ int charger_profile_override(struct charge_state_data *curr)\n} temp_zones[BATTERY_COUNT][TEMP_ZONE_COUNT] = {\n[BATTERY_SIMPLO] = {\n{0, 150, 1772, 4400}, /* TEMP_ZO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | scarlet: Update the charging current for Simplo battery
Simplo updated the datesheet and limited the charging current to 3A.
BUG=b:70820167
BRANCH=none
TEST=none
Change-Id: I88b9e0ac3ebba401530e2bb6ae08438c56d8506e
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/875145
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,427 | 15.01.2018 15:12:35 | 28,800 | dfda7899b7eb703e987851abe01b2d8d4e35e90f | grunt: Add USB-C DP Hotplug Detect GPIOs
Grunt HW has these driven from EC to SOC, unlike coral which had
the TCPCs drive the HPD signals to SOC.
BRANCH=none
TEST=external display works if GPIOs set high on EC console | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/gpio.inc",
"new_path": "board/grunt/gpio.inc",
"diff": "@@ -78,6 +78,8 @@ GPIO(USB_C0_BC12_VBUS_ON_L, PIN(8, 2), GPIO_ODR_HIGH) /* C0 BC1.2 Power */\nGPIO(USB_C1_BC12_VBUS_ON_L, PIN(B, 1), GPIO_ODR_HIGH) /* C1 BC1.2 Power */\nGPIO(USB_C0_BC12_CHG_D... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Add USB-C DP Hotplug Detect GPIOs
Grunt HW has these driven from EC to SOC, unlike coral which had
the TCPCs drive the HPD signals to SOC.
BUG=b:71810897
BRANCH=none
TEST=external display works if GPIOs set high on EC console
Change-Id: I40d794cccfdbb46f42642ea1410d75e2281028a1
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/867235
Reviewed-by: Aaron Durbin <adurbin@chromium.org> |
136,197 | 17.01.2018 11:13:26 | -28,800 | 667a35bb9c0ffd61d4c7d8a2897a8f7c313a9202 | poppy/nautilus: Enable ACCELGYRO3_INT_L BMI160 interrupts
BRANCH=none
TEST=Flash soraka, AIDA64 works fine | [
{
"change_type": "MODIFY",
"old_path": "board/nautilus/board.c",
"new_path": "board/nautilus/board.c",
"diff": "@@ -443,6 +443,9 @@ static void board_init(void)\ngpio_set_flags(GPIO_I2C3_SCL, GPIO_INPUT);\ngpio_set_flags(GPIO_I2C3_SDA, GPIO_INPUT);\n}\n+\n+ /* Enable Gyro interrupts */\n+ gpio_enabl... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | poppy/nautilus: Enable ACCELGYRO3_INT_L BMI160 interrupts
BRANCH=none
BUG=b:69656838
TEST=Flash soraka, AIDA64 works fine
Change-Id: I98443f3aee8605fbc9b5080cda83ac2b42ba8cd8
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/869550
Reviewed-by: Gwendal Grignou <gwendal@chromium.org> |
136,230 | 22.01.2018 13:35:33 | 28,800 | 632043a544130d3114715ab6454df18d320bccbe | scarlet: Fix ADC unit conversion
To detect the board version correctly, ADC must output mV.
BRANCH=none
TEST='version' command shows correct board version.
Commit-Ready: Philip Chen
Tested-by: Philip Chen | [
{
"change_type": "MODIFY",
"old_path": "board/scarlet/board.c",
"new_path": "board/scarlet/board.c",
"diff": "@@ -70,7 +70,7 @@ static void warm_reset_request_interrupt(enum gpio_signal signal)\n/******************************************************************************/\n/* ADC channels. Must b... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | scarlet: Fix ADC unit conversion
To detect the board version correctly, ADC must output mV.
BUG=b:72233188
BRANCH=none
TEST='version' command shows correct board version.
Change-Id: I68889092719240394f03cb9b21cb0844feb315e5
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/879491
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,264 | 18.01.2018 16:14:40 | 25,200 | 04a9dfe645dff2c7f79fffc7e75b201e4bccaa15 | zoombini: Add support for I2C bus 4
This is used by the keyboard backlight driver. Add support so we can
start talking to this chip.
BRANCH=none
TEST=i2cscan shows a device at 0x6c on bus 4 now | [
{
"change_type": "MODIFY",
"old_path": "board/zoombini/board.c",
"new_path": "board/zoombini/board.c",
"diff": "@@ -166,6 +166,7 @@ BUILD_ASSERT(ARRAY_SIZE(power_signal_list) == POWER_SIGNAL_COUNT);\nconst struct i2c_port_t i2c_ports[] = {\n{\"power\", I2C_PORT_POWER, 100, GPIO_I2C0_SCL, GPIO_I2C0_S... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zoombini: Add support for I2C bus 4
This is used by the keyboard backlight driver. Add support so we can
start talking to this chip.
BUG=b:69379749
BRANCH=none
TEST=i2cscan shows a device at 0x6c on bus 4 now
Change-Id: I951ecd0fa3030f9f408ed0a4504b54950b7ca174
Signed-off-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/879081
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,267 | 23.01.2018 15:03:31 | -3,600 | adeb276aa6a4a1cc341334e8c5db45e16fa8b6c5 | eve_fp: remove board
fp is dead, long life to fp.
BRANCH=none
TEST=make buildall
Commit-Ready: Vincent Palatin
Tested-by: Vincent Palatin | [
{
"change_type": "DELETE",
"old_path": "board/eve_fp/board.c",
"new_path": null,
"diff": "-/* Copyright 2017 The Chromium OS Authors. All rights reserved.\n- * Use of this source code is governed by a BSD-style license that can be\n- * found in the LICENSE file.\n- */\n-\n-#include \"common.h\"\n-#i... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | eve_fp: remove board
fp is dead, long life to fp.
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
BRANCH=none
BUG=b:72360575
TEST=make buildall
Change-Id: Idccb953044018e24d14b6ef1dbf69766fb9b58ab
Reviewed-on: https://chromium-review.googlesource.com/880954
Commit-Ready: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,264 | 23.01.2018 09:24:21 | 25,200 | 73162e60afd2559c9df9836c756dde523275de14 | zoombini: Enable LM3630A driver for keyboard backlight
BRANCH=None
TEST=kblight 100; kblight 50; kblight 0 | [
{
"change_type": "MODIFY",
"old_path": "board/zoombini/board.c",
"new_path": "board/zoombini/board.c",
"diff": "#include \"console.h\"\n#include \"compile_time_macros.h\"\n#include \"driver/als_opt3001.h\"\n+#include \"driver/led/lm3630a.h\"\n#include \"driver/pmic_tps650x30.h\"\n#include \"driver/p... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zoombini: Enable LM3630A driver for keyboard backlight
BUG=b:69379749
BRANCH=None
TEST=kblight 100; kblight 50; kblight 0
Change-Id: I096ed43859e11a7984d9672bfab406f0cb91015f
Signed-off-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/881945
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,264 | 19.01.2018 12:54:04 | 25,200 | f71edad1e7da32c1a9f2f4208da2ce57d0cfd100 | grunt: Enable LM3630A driver for keyboard backlight
BRANCH=None
TEST=kblight 100; kblight 50; kblight 0 | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/board.c",
"new_path": "board/grunt/board.c",
"diff": "#include \"driver/accel_kionix.h\"\n#include \"driver/accel_kx022.h\"\n#include \"driver/accelgyro_bmi160.h\"\n+#include \"driver/led/lm3630a.h\"\n#include \"driver/ppc/sn5s330.h\"\n#include \"d... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Enable LM3630A driver for keyboard backlight
BUG=b:69379749
BRANCH=None
TEST=kblight 100; kblight 50; kblight 0
Change-Id: I003ae1071de0430fe38a48b2e9bccb08207bc019
Signed-off-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/879083
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,372 | 23.01.2018 14:15:50 | 25,200 | 9b7b5460d2ccfdf6cc28ea8115a6bd6be2496141 | grunt: Disable CONFIG_BRINGUP option
Bringup went well so this this option is no longer needed.
TEST=Build & boot
BRANCH=None
Commit-Ready: Martin Roth
Tested-by: Martin Roth | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/board.h",
"new_path": "board/grunt/board.h",
"diff": "/* Accelerometer and Gyroscope are the same device. */\n#define I2C_PORT_ACCEL I2C_PORT_SENSOR\n-#define CONFIG_BRINGUP /* TODO(teravest): Remove this later. */\n-\n/* Sensors */\n#define CONFIG... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Disable CONFIG_BRINGUP option
Bringup went well so this this option is no longer needed.
BUG=None
TEST=Build & boot
BRANCH=None
Change-Id: I415161ab77d2a6b1ce59d6773d3cf78176cd1e96
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://chromium-review.googlesource.com/882182
Commit-Ready: Martin Roth <martinroth@chromium.org>
Tested-by: Martin Roth <martinroth@chromium.org>
Reviewed-by: Justin TerAvest <teravest@chromium.org> |
136,197 | 15.12.2017 16:02:30 | -28,800 | 31c1fc6d43cac12f380a023481e5320892c480d2 | whiskers: Update GPIO for next revision
Looks more similar to original hammer.
BRANCH=none
TEST=make BOARD=whiskers -j | [
{
"change_type": "MODIFY",
"old_path": "board/hammer/board.c",
"new_path": "board/hammer/board.c",
"diff": "@@ -66,8 +66,8 @@ BUILD_ASSERT(ARRAY_SIZE(usb_strings) == USB_STR_COUNT);\n/* I2C ports */\nconst struct i2c_port_t i2c_ports[] = {\n- {\"touchpad\", I2C_PORT_TOUCHPAD, 400,\n- GPIO_TOUCHPAD_I... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | whiskers: Update GPIO for next revision
Looks more similar to original hammer.
BRANCH=none
BUG=b:68934906
TEST=make BOARD=whiskers -j
Change-Id: I0f10240f8c3237b20f60a1217e167ad9539e3953
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/853574
Reviewed-by: Vincent Palatin <vpalatin@chromium.org> |
136,340 | 29.01.2018 09:07:35 | 28,800 | 051aebf5e0ce0246dee3fa6648215ffaa57f9dad | sensors: Remove debug printf
Remove prints when activity triggers.
BRANCH=eve
TEST=compile | [
{
"change_type": "MODIFY",
"old_path": "common/motion_sense.c",
"new_path": "common/motion_sense.c",
"diff": "@@ -800,7 +800,6 @@ static void check_and_queue_gestures(uint32_t *event)\nvector.sensor_num = MOTION_SENSE_ACTIVITY_SENSOR_ID;\nmotion_sense_fifo_add_unit(&vector, NULL, 0);\n#endif\n- CPRI... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | sensors: Remove debug printf
Remove prints when activity triggers.
BUG=b:72533440
BRANCH=eve
TEST=compile
Change-Id: I047e14990ef734c35161293b9c5fbbece0ddab0c
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/890632
Reviewed-by: Duncan Laurie <dlaurie@google.com> |
136,377 | 23.01.2018 17:50:13 | 28,800 | a4e1e476308ed717c0909c0a67e9a45152371dd0 | cr50: add properties to BOARD_ALL_PROPERTIES
Add BOARD_DEEP_SLEEP_DISABLED and BOARD_DETECT_AP_WITH_UART to
BOARD_ALL_PROPERTIES, so they will be updated after cr50 reboots.
BRANCH=cr50
TEST=test deep sleep on scarlet | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/scratch_reg1.h",
"new_path": "board/cr50/scratch_reg1.h",
"diff": "* updated if additional strap related properties are added.\n*/\n#define BOARD_ALL_PROPERTIES (BOARD_SLAVE_CONFIG_SPI | BOARD_SLAVE_CONFIG_I2C \\\n- | BOARD_NEEDS_SYS_RST_PULL_UP | B... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: add properties to BOARD_ALL_PROPERTIES
Add BOARD_DEEP_SLEEP_DISABLED and BOARD_DETECT_AP_WITH_UART to
BOARD_ALL_PROPERTIES, so they will be updated after cr50 reboots.
BUG=b:35647982
BRANCH=cr50
TEST=test deep sleep on scarlet
Change-Id: I8999ae7c6c1dad6799b5fdb99ebf5d7618a21c2b
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/882343
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
136,377 | 23.01.2018 13:26:04 | 28,800 | 4d0eb3be49fac06cdb932a3ac9fb429d97f7a340 | cr50: fix ec and servo detection
This change reenables the gpio interrupts if the signal is not high.
BRANCH=cr50
TEST=firmware_Cr50DeviceState | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/ec_state.c",
"new_path": "board/cr50/ec_state.c",
"diff": "@@ -112,6 +112,11 @@ static void ec_detect(void)\nset_ec_on();\nreturn;\n}\n+ /*\n+ * Make sure the interrupt is enabled. We will need to detect the on\n+ * transition if we enter the off or... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: fix ec and servo detection
This change reenables the gpio interrupts if the signal is not high.
BUG=none
BRANCH=cr50
TEST=firmware_Cr50DeviceState
Change-Id: Iae4e18594954789cd6841e01d1c943de3b389415
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/884306
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
136,297 | 30.01.2018 14:54:49 | -32,400 | 313220c87da431da101fd7a6ca4d75da85ae8e5f | nautilus : fix white led shown issue on ec reset
set gpios of LED to output high(off) when ec reset
BRANCH=none
TEST=build/flash nautilus
Commit-Ready: YongBeum Ha
Tested-by: YongBeum Ha | [
{
"change_type": "MODIFY",
"old_path": "board/nautilus/gpio.inc",
"new_path": "board/nautilus/gpio.inc",
"diff": "@@ -99,9 +99,9 @@ GPIO(USB_A_ILIM_SEL, PIN(0, 0), GPIO_OUT_LOW)\nGPIO(USB1_ENABLE, PIN(0, 1), GPIO_OUT_LOW)\n/* LEDs (2 colors on each port) */\n-GPIO(LED_ACIN, PIN(B, 6), GPIO_OUT_LOW) ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nautilus : fix white led shown issue on ec reset
set gpios of LED to output high(off) when ec reset
BUG=b:72485879
BRANCH=none
TEST=build/flash nautilus
Change-Id: I187dc82839fe7000e004cf58c4811656c905c00a
Signed-off-by: YB.Ha <ybha@samsung.com>
Reviewed-on: https://chromium-review.googlesource.com/892679
Commit-Ready: YongBeum Ha <ybha@samsung.com>
Tested-by: YongBeum Ha <ybha@samsung.com>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org> |
136,234 | 01.11.2017 18:48:48 | 25,200 | f543a8e7982c8facb74502b3e96d83bd336f6522 | glkrvp: Switch from NPCX5 EC to NPCX7 EC
BRANCH=glkrvp
TEST=GLKRVP can boot to OS
Commit-Ready: Vijay P Hiremath
Tested-by: Vijay P Hiremath | [
{
"change_type": "MODIFY",
"old_path": "board/glkrvp/board.c",
"new_path": "board/glkrvp/board.c",
"diff": "@@ -51,6 +51,8 @@ const struct power_signal_info power_signal_list[] = {\n\"SLP_S0_DEASSERTED\"},\n{GPIO_PCH_SLP_S3_L, POWER_SIGNAL_ACTIVE_HIGH, \"SLP_S3_DEASSERTED\"},\n{GPIO_PCH_SLP_S4_L, PO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | glkrvp: Switch from NPCX5 EC to NPCX7 EC
BUG=b:68987606, b:72483287
BRANCH=glkrvp
TEST=GLKRVP can boot to OS
Change-Id: If4b99ca60005b97c59a1d8dc16c4065af63d34d8
Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/750365
Commit-Ready: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Tested-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org> |
136,455 | 24.01.2018 18:26:00 | 28,800 | 9362b0620159acadc5f8231407acca746c1d2c39 | samus_pd: Remove 'adc' console command
Remove console command for flash / RAM savings.
TEST=`make buildall -j`
BRANCH=None
Commit-Ready: Shawn N
Tested-by: Shawn N | [
{
"change_type": "MODIFY",
"old_path": "board/samus_pd/board.h",
"new_path": "board/samus_pd/board.h",
"diff": "#define CONFIG_BOARD_PRE_INIT\n#define CONFIG_CHARGE_MANAGER\n#define CONFIG_CHARGE_RAMP_SW\n+#undef CONFIG_CMD_ADC\n#undef CONFIG_CMD_CHARGE_SUPPLIER_INFO\n#undef CONFIG_CMD_HASH\n#undef ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | samus_pd: Remove 'adc' console command
Remove console command for flash / RAM savings.
BUG=None
TEST=`make buildall -j`
BRANCH=None
Change-Id: Ibfccbdf45e5c86260cc55237387994fdf094c19c
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/885463
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org> |
136,230 | 29.01.2018 12:20:56 | 28,800 | 1c90656d03a2d28392515e374681dce4698ca881 | scarlet: Remove unused macros in battery.c
The macros were added for debug and not used anymore.
Let clean it up.
BRANCH=none
TEST=make BOARD=scarlet
Commit-Ready: Philip Chen
Tested-by: Philip Chen | [
{
"change_type": "MODIFY",
"old_path": "board/scarlet/battery.c",
"new_path": "board/scarlet/battery.c",
"diff": "#include \"gpio.h\"\n#include \"util.h\"\n-#define CPRINTS(format, args...) cprints(CC_USBCHARGE, format, ## args)\n-#define CPRINTF(format, args...) cprintf(CC_USBCHARGE, format, ## arg... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | scarlet: Remove unused macros in battery.c
The macros were added for debug and not used anymore.
Let clean it up.
BUG=none
BRANCH=none
TEST=make BOARD=scarlet
Change-Id: I859fd3ddf2d5271ba26d23696013c83dec98a966
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/891547
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Alexandru M Stan <amstan@chromium.org> |
136,230 | 26.01.2018 18:30:26 | 28,800 | 3a95a6829266782673dbcedb57d867bcd724e5f5 | charger/rt946x: Log the init failure
BRANCH=none
TEST=See the error message when init fails
Commit-Ready: Philip Chen
Tested-by: Philip Chen | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/rt946x.c",
"new_path": "driver/charger/rt946x.c",
"diff": "@@ -746,9 +746,11 @@ static void rt946x_init(void)\n}\nCPRINTF(\"RT946X CHIP REV: 0x%02x\\n\", reg);\n- if (rt946x_init_setting())\n+ if (rt946x_init_setting()) {\n+ CPRINTF(\"RT946X ini... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | charger/rt946x: Log the init failure
BUG=b:72228350
BRANCH=none
TEST=See the error message when init fails
Change-Id: Ib9b1906cb2d0b2427a96ea4823eb3325912f344b
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/890026
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org> |
136,197 | 30.01.2018 15:25:15 | -28,800 | 7ffcd686db8dfc22edf3e94aa6008fbab6aa8bcd | whiskers: Enable LM3630A LED driver
Used to control keyboard backlight.
BRANCH=none
TEST=make BOARD=whiskers -j | [
{
"change_type": "MODIFY",
"old_path": "board/hammer/board.c",
"new_path": "board/hammer/board.c",
"diff": "/* Hammer board configuration */\n#include \"common.h\"\n+#include \"driver/led/lm3630a.h\"\n#include \"ec_version.h\"\n#include \"ec_ec_comm_slave.h\"\n#include \"gpio.h\"\n@@ -162,14 +163,20... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | whiskers: Enable LM3630A LED driver
Used to control keyboard backlight.
BRANCH=none
BUG=b:68934906
TEST=make BOARD=whiskers -j
Change-Id: Ie793ebe91670965a434896530084561a7f1c57d4
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/892842
Reviewed-by: Benjamin Gordon <bmgordon@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org> |
136,256 | 25.01.2018 10:45:22 | 25,200 | 760caca89bfe3d91fe7d66b8d435a105664fd0d3 | usb pd: Adding PPC vbus discharge path
Boards with a PPC will use the PPC to discharge the VBUS line instead
of the TCPC or GPIO discharge path.
BRANCH=none
TEST=Fall time after device removal on grunt within spec now | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_policy.c",
"new_path": "common/usb_pd_policy.c",
"diff": "#include \"util.h\"\n#include \"usb_api.h\"\n#include \"usb_pd.h\"\n+#include \"usbc_ppc.h\"\n#include \"version.h\"\n#ifdef CONFIG_COMMON_RUNTIME\n@@ -1035,6 +1036,8 @@ void pd_set_vbus_d... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb pd: Adding PPC vbus discharge path
Boards with a PPC will use the PPC to discharge the VBUS line instead
of the TCPC or GPIO discharge path.
BRANCH=none
BUG=b:72179253
TEST=Fall time after device removal on grunt within spec now
Change-Id: I822923a1cedb32a20efc3610cce4437ade3387f0
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/886563
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,407 | 22.01.2018 11:49:12 | -28,800 | eb60e291e8c7c178e0814c5d2a5cbe6c207182d2 | led: Only report auto control for supported LEDs.
BRANCH=None
TEST=make -j buildall
Commit-Ready: Aseda Aboagye
Tested-by: Aseda Aboagye | [
{
"change_type": "MODIFY",
"old_path": "common/led_common.c",
"new_path": "common/led_common.c",
"diff": "@@ -19,12 +19,16 @@ static uint32_t led_auto_control_flags = ~0x00;\nstatic int led_is_supported(enum ec_led_id led_id)\n{\nint i;\n+ static int supported_leds = -1;\n+\n+ if (supported_leds == ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | led: Only report auto control for supported LEDs.
BUG=None
BRANCH=None
TEST=make -j buildall
Change-Id: I6508d2bfa01919c89a9b5c1129af35919deb1557
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/888219
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,256 | 31.01.2018 15:58:44 | 25,200 | d138e4dc636f0a58fa2a90ed63b0a996f96e7a82 | cleanup: Correcting VBUS discharge comment
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "driver/ppc/sn5s330.c",
"new_path": "driver/ppc/sn5s330.c",
"diff": "@@ -507,7 +507,8 @@ static int sn5s330_discharge_vbus(int port, int enable)\nstatus = write_reg(port, SN5S330_FUNC_SET3, regval);\nif (status) {\n- CPRINTS(\"Failed to %s vbus\", enable ? \"en... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: Correcting VBUS discharge comment
BRANCH=none
BUG=none
TEST=none
Change-Id: I0e7f21bd56a796d2261ffafa26f603924ac0d66d
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/896395
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,256 | 31.01.2018 08:16:53 | 25,200 | 1b87ee65ac8f3cd895da6ef2e219670d2f9779ec | cleanup: Removing unnecessary CONFIG_USB_PD_DISCHARGE define
CONFIG_USB_PD_DISCHARGE is now defined automatically if you specify one of
the specified options such as CONFIG_USB_PD_DISCHARGE_TCPC
BRANCH=none
TEST=grunt still discharges using PPC | [
{
"change_type": "MODIFY",
"old_path": "board/coral/board.h",
"new_path": "board/coral/board.h",
"diff": "#define CONFIG_USB_PD_CUSTOM_VDM\n#define CONFIG_USB_PD_DUAL_ROLE\n#define CONFIG_USB_PD_DUAL_ROLE_AUTO_TOGGLE\n-#define CONFIG_USB_PD_DISCHARGE\n#define CONFIG_USB_PD_DISCHARGE_TCPC\n#define CO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: Removing unnecessary CONFIG_USB_PD_DISCHARGE define
CONFIG_USB_PD_DISCHARGE is now defined automatically if you specify one of
the specified options such as CONFIG_USB_PD_DISCHARGE_TCPC
BRANCH=none
BUG=none
TEST=grunt still discharges using PPC
Change-Id: I94086cfc58bebce9c62ad6aa52b7740b25276d89
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/894676
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,219 | 01.02.2018 08:20:24 | 25,200 | c23e632984dbd97a91cc2d8434a8849024627d43 | grunt: Rename orange LED to amber
'Amber' seems to be more common in the code base. Rename it for grunt.
BRANCH=none
TEST=make BOARD=grunt -j10 | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/board.c",
"new_path": "board/grunt/board.c",
"diff": "@@ -410,7 +410,7 @@ struct keyboard_scan_config keyscan_config = {\n/* PWM channels. Must be in the exactly same order as in enum pwm_channel. */\nconst struct pwm_t pwm_channels[] = {\n[PWM_CH_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Rename orange LED to amber
'Amber' seems to be more common in the code base. Rename it for grunt.
BUG=b:71902053
BRANCH=none
TEST=make BOARD=grunt -j10
Change-Id: I73a6bff4f113f5c49e70fde6d1f4667b8324a6d8
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/896401
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,396 | 01.02.2018 11:00:40 | 28,800 | 8dba841b4e4e514204f6e002115862fe3229666f | ccd: fix scan-admin warnings
Automated code scanner highlighted a few problems in the recent ode
additions. This patch fixes the problems.
BRANCH=cr50
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "common/ccd_config.c",
"new_path": "common/ccd_config.c",
"diff": "@@ -878,7 +878,8 @@ static int ccd_command_wrapper(int argc, char *password,\n* error code is the first byte after the header.\n*/\nreturn_code = be32toh(vch->tpm_header.command_code);\n- if (re... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ccd: fix scan-admin warnings
Automated code scanner highlighted a few problems in the recent ode
additions. This patch fixes the problems.
BRANCH=cr50
BUG=none
TEST=none
Change-Id: I1f199eb5d2af992384ab04f3010b4b646464a70f
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/897993
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,256 | 01.02.2018 09:32:40 | 25,200 | 74e2f686a9acce51b1507367c29e39f504aaa34d | cleanup: formatting debug message
Adding newline to separate messages better
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "chip/npcx/lpc.c",
"new_path": "chip/npcx/lpc.c",
"diff": "@@ -338,7 +338,7 @@ static void lpc_sib_wait_host_read_done(void)\ndeadline.val = get_time().val + LPC_HOST_TRANSACTION_TIMEOUT_US;\nwhile (IS_BIT_SET(NPCX_SIBCTRL, NPCX_SIBCTRL_CSRD)) {\nif (timestamp_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: formatting debug message
Adding newline to separate messages better
BRANCH=none
TEST=none
BUG=none
Change-Id: Ie454dfc532310c480f350c9b15280bf96634b322
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/897909
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,297 | 01.02.2018 15:39:53 | -32,400 | c721ad9162b9fe20ce872c1d28cd8b1ad60e2c25 | nautilus : clean up gpios
clean up unused gpios
BRANCH=none
TEST=build/flash nautilus
Commit-Ready: YongBeum Ha
Tested-by: YongBeum Ha | [
{
"change_type": "MODIFY",
"old_path": "board/nautilus/board.h",
"new_path": "board/nautilus/board.h",
"diff": "(EC_WIRELESS_SWITCH_WLAN | EC_WIRELESS_SWITCH_WLAN_POWER)\n#define WIRELESS_GPIO_WLAN GPIO_WLAN_OFF_L\n#define WIRELESS_GPIO_WLAN_POWER GPIO_PP3300_DX_WLAN\n-#define WIRELESS_GPIO_WWAN GPI... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nautilus : clean up gpios
clean up unused gpios
BUG=none
BRANCH=none
TEST=build/flash nautilus
Change-Id: Ifdebc885d7f81b560b27bfed5abb93d8976e9641
Signed-off-by: YB.Ha <ybha@samsung.com>
Reviewed-on: https://chromium-review.googlesource.com/897305
Commit-Ready: YongBeum Ha <ybha@samsung.com>
Tested-by: YongBeum Ha <ybha@samsung.com>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org> |
136,396 | 05.02.2018 11:41:57 | 28,800 | 59fe7c7a5861f95da3d3539a55e3ad019a615517 | cr50: prepare to release 0.1.1
The new release will include bug fixes and new features (line RMA
reset, CCD debug, management, etc.).
BRANCH=cr50
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/signer/ec_RW-manifest-dev.json",
"new_path": "util/signer/ec_RW-manifest-dev.json",
"diff": "\"timestamp\": 0,\n\"epoch\": 0, // FWR diversification contributor, 32 bits.\n\"major\": 1, // FW2_HIK_CHAIN counter.\n- \"minor\": 0, // Mostly harmless version... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: prepare to release 0.1.1
The new release will include bug fixes and new features (line RMA
reset, CCD debug, management, etc.).
BRANCH=cr50
BUG=none
TEST=none
Change-Id: I25c22d00acd734ad0b7557cb9469d8b0f4db131e
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/902423
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,256 | 02.02.2018 15:39:33 | 25,200 | 2cbc9f98ad7f7d55645da516873ff7f9d92976b4 | cleanup: adding port info and timing to debug message
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_protocol.c",
"new_path": "common/usb_pd_protocol.c",
"diff": "@@ -621,7 +621,7 @@ static int send_source_cap(int port)\nbit_len = pd_transmit(port, TCPC_TX_SOP, header, src_pdo);\nif (debug_level >= 2)\n- CPRINTF(\"srcCAP>%d\\n\", bit_len);\n+ CP... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: adding port info and timing to debug message
BRANCH=none
TEST=none
BUG=none
Change-Id: I5639be21b285beef61e939f1c70c5ab5a14ade7e
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/900305
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,405 | 05.02.2018 12:54:56 | 28,800 | c8e2deb24dbbf4165acac4d3b72376d98ec210a1 | Fizz/CBI: Create CBI blobs
This patch makes make create EEPROM blobs which contain Cros Board Info.
BRANCH=none
TEST=make buildall. make BOARD=fizz cbi_kench. | [
{
"change_type": "MODIFY",
"old_path": "board/fizz/build.mk",
"new_path": "board/fizz/build.mk",
"diff": "@@ -12,3 +12,30 @@ CHIP_VARIANT:=npcx5m6g\nboard-y=board.o\nboard-$(CONFIG_USB_POWER_DELIVERY)+=usb_pd_policy.o\nboard-y+=led.o\n+\n+brd_ver = 0\n+\n+# Build CBI blob for one model\n+# $1: Prefi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Fizz/CBI: Create CBI blobs
This patch makes make create EEPROM blobs which contain Cros Board Info.
BUG=b:72949522
BRANCH=none
TEST=make buildall. make BOARD=fizz cbi_kench.
Change-Id: Ie4c50f4707285b44c13afc7410a5ea823a26d98e
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/902822
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
136,396 | 07.02.2018 10:20:00 | 28,800 | 8d1422813ee10dcbd13f7a340dafa83728023e9c | cr50: prepare for pre-pvt images' revision bump
This will allow to make differences between pre-pvt and mp images
better visible.
BRANCH=cr50
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/signer/ec_RW-manifest-dev.json",
"new_path": "util/signer/ec_RW-manifest-dev.json",
"diff": "\"timestamp\": 0,\n\"epoch\": 0, // FWR diversification contributor, 32 bits.\n- \"major\": 1, // FW2_HIK_CHAIN counter.\n+ \"major\": 2, // FW2_HIK_CHAIN counter... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: prepare for pre-pvt images' revision bump
This will allow to make differences between pre-pvt and mp images
better visible.
BRANCH=cr50
BUG=none
TEST=none
Change-Id: I3abf24443a208482167231d93983b8edcace5f55
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/907170
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,256 | 05.02.2018 14:42:45 | 25,200 | bbb707727d8586109b9cc9235a234de177652b1f | usb-pd: Adding port number to debug messages
BRANCH=none
TEST=verified debug message on grunt | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_protocol.c",
"new_path": "common/usb_pd_protocol.c",
"diff": "@@ -591,7 +591,7 @@ static int send_control(int port, int type)\nbit_len = pd_transmit(port, TCPC_TX_SOP, header, NULL);\nif (debug_level >= 2)\n- CPRINTF(\"CTRL[%d]>%d\\n\", type, bit... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb-pd: Adding port number to debug messages
BRANCH=none
BUG=none
TEST=verified debug message on grunt
Change-Id: Ibc1632d22b6e4bbc5b95c140db4a7cfb536687c8
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/907417
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,197 | 24.01.2018 12:25:31 | -28,800 | b34b34e6e867f832f134c27790937b35eb6debef | charge_state_v2: No base/lid power transfer in S0ix/S5
BRANCH=none
TEST=Suspend system, see that base does not provide power to lid,
and vice-versa. | [
{
"change_type": "MODIFY",
"old_path": "common/charge_state_v2.c",
"new_path": "common/charge_state_v2.c",
"diff": "@@ -464,6 +464,16 @@ static void charge_allocate_input_current_limit(void)\nprev_lid_system_power = -1;\nprev_lid_battery_power = -1;\n+ /*\n+ * System is suspended/off, let the lid an... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | charge_state_v2: No base/lid power transfer in S0ix/S5
BRANCH=none
BUG=b:71881017
TEST=Suspend system, see that base does not provide power to lid,
and vice-versa.
Change-Id: I54e26c9b8decff2afdebc34adb62d4f5cef18e37
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/882524
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
136,256 | 09.02.2018 08:16:00 | 25,200 | ff11702c40a7bd88fa64444798c40731a09e4166 | grunt: Making control of SCI and SMI interrupt pins more clear
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "board/grunt/gpio.inc",
"new_path": "board/grunt/gpio.inc",
"diff": "@@ -61,8 +61,11 @@ GPIO(I2C5_SDA, PIN(3, 6), GPIO_INPUT) /* EC_I2C_EEPROM_SDA and\nGPIO(I2C7_SCL, PIN(B, 3), GPIO_INPUT | GPIO_SEL_1P8V) /* EC_I2C_SENSOR_SCL */\nGPIO(I2C7_SDA, PIN(B, 2), GPIO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Making control of SCI and SMI interrupt pins more clear
BRANCH=none
BUG=none
TEST=none
Change-Id: I82d0a68f192fdc339af8682b99781cb16802ac32
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/911590
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,396 | 12.02.2018 18:40:25 | 28,800 | 7b44ce57a3273e7ff6b339d3a9214fb891512fa3 | cr50: move to prod RMA key
The new key ID is set to zero.
BRANCH=cr50, cr50-eve
TEST=verified that prod server properly responds to the challenge
generated by a CR50 running on Robo device. | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/board.h",
"new_path": "board/cr50/board.h",
"diff": "@@ -352,13 +352,14 @@ enum nvmem_users {\n#define CONFIG_RMA_AUTH\n#define CONFIG_RNG\n-/* Dummy values to be replaced with real ones. */\n+/* Should be eventually injected into the image at build... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: move to prod RMA key
The new key ID is set to zero.
BRANCH=cr50, cr50-eve
BUG=b:70891959
TEST=verified that prod server properly responds to the challenge
generated by a CR50 running on Robo device.
Change-Id: I1e0da4a2cebca7f985c5f2a6da509c850924a874
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/915503
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org> |
136,405 | 09.02.2018 10:59:11 | 28,800 | 971ef1e03c791e95fe7e1ad8d0ea54da5c4f88d0 | host_command: Count suppressed host commands individually
BRANCH=none
TEST=Verify counters are printed every hour and before sysjump as follows:
[12.540051 HC Suppressed: 0x97=25 0x98=0 0x115=0] | [
{
"change_type": "MODIFY",
"old_path": "board/fizz/board.c",
"new_path": "board/fizz/board.c",
"diff": "#define CPRINTS(format, args...) cprints(CC_USBCHARGE, format, ## args)\n#define CPRINTF(format, args...) cprintf(CC_USBCHARGE, format, ## args)\n-uint16_t host_command_suppressed[] = {\n- EC_CMD_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | host_command: Count suppressed host commands individually
BUG=chromium:803955
BRANCH=none
TEST=Verify counters are printed every hour and before sysjump as follows:
[12.540051 HC Suppressed: 0x97=25 0x98=0 0x115=0]
Change-Id: I1c1aecf316d233f967f1d2f6ee6c9c16cc59bece
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/912150 |
136,312 | 16.02.2018 16:30:31 | 28,800 | 3aff8da158e97b42550844eb5cfcbe9f937130d7 | cr50: fix DEBUG_DRIVE comment
This is the DEBUG_DRIVE register, not the DEBUG_BLOCK_OUTPUT. Copy/paste
error?
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "chip/g/rbox.c",
"new_path": "chip/g/rbox.c",
"diff": "@@ -100,7 +100,7 @@ static void rbox_init(void)\n0x0 << GC_RBOX_DEBUG_TERM_KEY0_OUT_LSB |\n0x1 << GC_RBOX_DEBUG_TERM_KEY1_IN_LSB |\n0x0 << GC_RBOX_DEBUG_TERM_KEY1_OUT_LSB);\n- /* DEBUG_BLOCK_OUTPUT value sh... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: fix DEBUG_DRIVE comment
This is the DEBUG_DRIVE register, not the DEBUG_BLOCK_OUTPUT. Copy/paste
error?
BRANCH=none
BUG=none
TEST=none
Change-Id: Ic915b8675559d6f43d153f3a309becc621416dbe
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/924698
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,405 | 22.02.2018 09:25:50 | 28,800 | 546c606b5f0d4a3b8af54a17f5c729e670061fdc | CBI: Share common code between host tool and firmware
This patch makes EC firmware and cbi-util share the common code.
BRANCH=none
TEST=Set fields using ectool. Verify the contents by cbi command.
Verify cbi-util creates the same binary as before.
Verify emerge ec-utils ec-devutils pass. | [
{
"change_type": "MODIFY",
"old_path": "common/cbi.c",
"new_path": "common/cbi.c",
"diff": "#include \"host_command.h\"\n#include \"i2c.h\"\n#include \"timer.h\"\n+\n+#ifdef HOST_TOOLS_BUILD\n+#include <string.h>\n+#else\n#include \"util.h\"\n+#endif\n+\n+/*\n+ * Functions and variables defined here... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | CBI: Share common code between host tool and firmware
This patch makes EC firmware and cbi-util share the common code.
BUG=b:70294260
BRANCH=none
TEST=Set fields using ectool. Verify the contents by cbi command.
Verify cbi-util creates the same binary as before.
Verify emerge ec-utils ec-devutils pass.
Change-Id: If5e65e48dd03960e0adf23ef775f67aecf785d85
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/932001 |
136,228 | 13.02.2018 21:50:30 | 28,800 | a5f63e0391862b1b8a65904e82721746161cf3de | nautilus: Disable sensor in S5
BRANCH=None
TEST=None | [
{
"change_type": "MODIFY",
"old_path": "board/nautilus/board.c",
"new_path": "board/nautilus/board.c",
"diff": "@@ -424,9 +424,6 @@ static void board_init(void)\n/* Provide AC status to the PCH */\ngpio_set_level(GPIO_PCH_ACOK, extpower_is_present());\n- /* Enable sensors power supply */\n- gpio_set... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nautilus: Disable sensor in S5
BUG=b:73292704
BRANCH=None
TEST=None
Change-Id: I6f2f09232daed87fcd54a356ee13e69bfeda994c
Signed-off-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/918381
Reviewed-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Jerry Parson <jwp@chromium.org> |
136,405 | 22.02.2018 14:50:51 | 28,800 | c6f5fe6d30fa6afde1b341d5cd83542078584046 | npcx/fan: Avoid turning on disabled fans
Fan enable state is controlled in common/fan.c. This patch prevents
npcx fan driver from enabling it.
BRANCH=none
TEST=Verify no 'Fan 0 stalled' is printed in S3 and S5. Verify the
fan spins in S0. | [
{
"change_type": "MODIFY",
"old_path": "chip/npcx/fan.c",
"new_path": "chip/npcx/fan.c",
"diff": "@@ -346,8 +346,11 @@ void fan_tick_func(void)\n/* Make sure rpm mode is enabled */\nif (p_status->fan_mode != TACHO_FAN_RPM) {\np_status->auto_status = FAN_STATUS_STOPPED;\n+ /* Why isn't this 'continue... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | npcx/fan: Avoid turning on disabled fans
Fan enable state is controlled in common/fan.c. This patch prevents
npcx fan driver from enabling it.
BUG=b:73127788
BRANCH=none
TEST=Verify no 'Fan 0 stalled' is printed in S3 and S5. Verify the
fan spins in S0.
Change-Id: I549253a64c91d8a23bb793c3506b5daf1f7642be
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/937941
Reviewed-by: Vincent Palatin <vpalatin@chromium.org> |
136,256 | 23.02.2018 12:28:24 | 25,200 | 284c0c35893ff40a2023d52f58670d3b92172a59 | usb-pd: Tell TCPC and PPC to both source Vconn
BRANCH=none
TEST=verified with grunt that parade TCPC will no longer shut down when
PPC sources Vconn | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_protocol.c",
"new_path": "common/usb_pd_protocol.c",
"diff": "@@ -329,15 +329,17 @@ static void set_polarity(int port, int polarity)\n#ifdef CONFIG_USBC_VCONN\nstatic void set_vconn(int port, int enable)\n{\n-#ifdef CONFIG_USBC_PPC\n/*\n- * USB-C... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb-pd: Tell TCPC and PPC to both source Vconn
BRANCH=none
BUG=b:72961003,b:72956593
TEST=verified with grunt that parade TCPC will no longer shut down when
PPC sources Vconn
Change-Id: I6c1cee4dd8a40a992813841ec227a6af04de5313
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/935301 |
136,256 | 23.02.2018 16:18:35 | 25,200 | 7a0a4d639304dde28fe3ce0b3963f1789603ed5d | yorp: initial add of octopus BOM-A board
BRANCH=none
TEST=build yorp and all other boards | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/yorp/board.c",
"diff": "+/* Copyright 2018 The Chromium OS Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ */\n+\n+/* Yorp board-specific configur... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | yorp: initial add of octopus BOM-A board
BRANCH=none
BUG=b:73811887
TEST=build yorp and all other boards
Change-Id: I2c29ba86f29a3d25128c00c1b55e90f6843bcdd5
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/935367
Reviewed-by: Aaron Durbin <adurbin@chromium.org> |
136,230 | 06.02.2018 18:14:56 | 28,800 | 2f1e99bcef7165c051b08bc365ef6e1f689843e0 | charger/rt946x: Support BC 1.2
BRANCH=none
TEST=Charge Scarlet rev3 with SDP and DCP.
Commit-Ready: Philip Chen
Tested-by: Philip Chen | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/rt946x.c",
"new_path": "driver/charger/rt946x.c",
"diff": "#include \"battery.h\"\n#include \"battery_smart.h\"\n#include \"charger.h\"\n+#include \"charge_manager.h\"\n#include \"common.h\"\n#include \"compile_time_macros.h\"\n#include \"config... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | charger/rt946x: Support BC 1.2
BUG=b:65446459
BRANCH=none
TEST=Charge Scarlet rev3 with SDP and DCP.
Change-Id: I84fb64953c380b96ec852dca2c981331801e4416
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/905399
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
136,405 | 28.02.2018 08:58:52 | 28,800 | 074050c048d04bdc844683fb42f8daeaf667dc98 | Nami: Enable interrupt for BMI160
BRANCH=none
TEST=make BOARD=nami | [
{
"change_type": "MODIFY",
"old_path": "board/nami/board.c",
"new_path": "board/nami/board.c",
"diff": "@@ -412,6 +412,9 @@ static void board_init(void)\n/* Enable pericom BC1.2 interrupts */\ngpio_enable_interrupt(GPIO_USB_C0_BC12_INT_L);\ngpio_enable_interrupt(GPIO_USB_C1_BC12_INT_L);\n+\n+ /* Ena... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Nami: Enable interrupt for BMI160
BUG=b:72335612
BRANCH=none
TEST=make BOARD=nami
Change-Id: Ifcf401b881a40490ead8186be77cc7a097550291
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/941601
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@google.com> |
136,197 | 05.03.2018 14:24:09 | -28,800 | 3d4db585fa751d0b480050003280df79f9a6f8da | charge_state_v2: Reduce OTG voltage to 12V for better efficiency
BRANCH=none
TEST=Flash lux, check that lux adc VBUS voltage when only no
charger is connected is around 12V. | [
{
"change_type": "MODIFY",
"old_path": "common/charge_state_v2.c",
"new_path": "common/charge_state_v2.c",
"diff": "@@ -195,7 +195,7 @@ struct dual_battery_policy {\n};\nstatic const struct dual_battery_policy db_policy = {\n- .otg_voltage = 15000, /* mV */\n+ .otg_voltage = 12000, /* mV */\n.max_ba... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | charge_state_v2: Reduce OTG voltage to 12V for better efficiency
BRANCH=none
BUG=b:73528930
BUG=b:73660652
TEST=Flash lux, check that lux adc VBUS voltage when only no
charger is connected is around 12V.
Change-Id: Iccc245c96ca3c83674446f96f78f1ce15ffa7de2
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/948322
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
136,197 | 06.03.2018 07:49:41 | -28,800 | 00f86c06849158e71cefe13b34d104ca1c6c35b9 | wand: Define CONFIG_KEYBOARD_NEW_KEY
BRANCH=none
TEST=evtest shows events when search or assistant keys are pressed | [
{
"change_type": "MODIFY",
"old_path": "board/hammer/board.h",
"new_path": "board/hammer/board.h",
"diff": "#define CONFIG_KEYBOARD_DEBUG\n#undef CONFIG_KEYBOARD_BOOT_KEYS\n#undef CONFIG_KEYBOARD_RUNTIME_KEYS\n-#if defined(BOARD_HAMMER) || defined(BOARD_WHISKERS)\n+#if defined(BOARD_HAMMER) || defin... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | wand: Define CONFIG_KEYBOARD_NEW_KEY
BRANCH=none
BUG=b:74207950
TEST=evtest shows events when search or assistant keys are pressed
Change-Id: I1816769144b379ba6067b3b50b08b3d208d45b14
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/949904
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
136,197 | 06.03.2018 08:24:03 | -28,800 | 6d567bc45ffcc3b8df2c288f8347d00a250248fc | config: Rename new key to assistant key
Make it clearer what the new key is about.
CONFIG_KEYBOARD_NEW_KEY to CONFIG_KEYBOARD_ASSISTANT_KEY.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/hammer/board.h",
"new_path": "board/hammer/board.h",
"diff": "#undef CONFIG_KEYBOARD_RUNTIME_KEYS\n#if defined(BOARD_HAMMER) || defined(BOARD_WAND) || defined(BOARD_WHISKERS)\n#define CONFIG_KEYBOARD_BOARD_CONFIG\n-#define CONFIG_KEYBOARD_NEW_KEY\n+#defi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | config: Rename new key to assistant key
Make it clearer what the new key is about.
CONFIG_KEYBOARD_NEW_KEY to CONFIG_KEYBOARD_ASSISTANT_KEY.
BRANCH=none
BUG=none
TEST=make buildall -j
Change-Id: Ic2db425b40ff8bc612626b6f644463b1f8ec630e
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/950263
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.