author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
136,208 | 06.09.2018 18:23:36 | -28,800 | b53485334a80ddf0b9bcae0da9e9f31365436e3f | kukui: Enable magnetometer.
TEST=make BOARD=kukui
BRANCH=None
Commit-Ready: Yilun Lin
Tested-by: Yilun Lin | [
{
"change_type": "MODIFY",
"old_path": "board/kukui/board.c",
"new_path": "board/kukui/board.c",
"diff": "@@ -358,6 +358,13 @@ const mat33_fp_t base_standard_ref = {\n{ 0, 0, FLOAT_TO_FP(1)}\n};\n+/* Matrix to rotate accelrator into standard reference frame */\n+const mat33_fp_t mag_standard_ref = {... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui: Enable magnetometer.
TEST=make BOARD=kukui
BUG=b:113364863
BRANCH=None
Change-Id: If56821b9018ae23f086f2d04f9bd15f54de77966
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1235483
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,401 | 03.10.2018 09:44:58 | 21,600 | c992a0edf9dc655bc3bbe373b38901696213513c | glados: Increase size of RO segment
Glados is very tight on code space, but has some data RAM space free.
Rebalance some .data allocation to .text.
BRANCH=none
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "board/glados/board.h",
"new_path": "board/glados/board.h",
"diff": "#define CONFIG_POWER_SIGNAL_INTERRUPT_STORM_DETECT_THRESHOLD 30\n/* All data won't fit in data RAM. So, moving boundary slightly. */\n#undef CONFIG_RO_SIZE\n-#define CONFIG_RO_SIZE (104 * 1024... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | glados: Increase size of RO segment
Glados is very tight on code space, but has some data RAM space free.
Rebalance some .data allocation to .text.
BUG=none
BRANCH=none
TEST=buildall
Change-Id: I88d2ed4090eed04db620962065372c8cd4e8b87b
Signed-off-by: Jonathan Brandmeyer <jbrandmeyer@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1258569
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
136,401 | 03.10.2018 10:13:57 | 21,600 | 356083b7f0b36ffd5b8d387e332ff488810ed47e | tcpc: Simplify ANX74XX device selection
BRANCH=none
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "driver/build.mk",
"new_path": "driver/build.mk",
"diff": "@@ -107,9 +107,7 @@ driver-$(CONFIG_USB_PD_TCPM_TCPCI)+=tcpm/tcpci.o\ndriver-$(CONFIG_USB_PD_TCPM_FUSB302)+=tcpm/fusb302.o\ndriver-$(CONFIG_USB_PD_TCPM_MT6370)+=tcpm/mt6370.o\ndriver-$(CONFIG_USB_PD_TCP... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | tcpc: Simplify ANX74XX device selection
BUG=none
BRANCH=none
TEST=buildall
Change-Id: I8eb4a9027518aa1c7af18e850984a595bd2bbe23
Signed-off-by: Jonathan Brandmeyer <jbrandmeyer@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1258570
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,426 | 02.10.2018 16:39:56 | 25,200 | ce110598773fca8ef888e3a40f3e433da78e75a7 | FIXUP: mkbp: add support for board-specific host notification
This patch improves naming and documentation for the functionality
introduced in crrev.com/c/1247000
TEST=build
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "common/mkbp_event.c",
"new_path": "common/mkbp_event.c",
"diff": "@@ -34,24 +34,24 @@ static int event_is_set(uint8_t event_type)\n}\n#ifndef CONFIG_MKBP_USE_HOST_EVENT\n-void send_mkbp_event_gpio(int active)\n+void mkbp_set_host_active_via_gpio(int active)\n{... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | FIXUP: mkbp: add support for board-specific host notification
This patch improves naming and documentation for the functionality
introduced in crrev.com/c/1247000
TEST=build
BRANCH=none
BUG=b:112366846, b:112112483, b:112111610
Change-Id: Iedd2fc5492a5d35fa9c2475fe248c5aa41e83bb0
Signed-off-by: Enrico Granata <egranata@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1258562
Reviewed-by: Aaron Durbin <adurbin@chromium.org> |
136,305 | 05.10.2018 11:09:00 | 21,600 | 0b52f0e0e6c1d108f84692e0fbfb0ea30753494c | Ampton: confirm thermistor parts
Confirmed that Ampton is using 4050b thermistors (as we'd previously
guessed), so removing TODO
BRANCH=None
TEST=builds
Commit-Ready: Jett Rink | [
{
"change_type": "MODIFY",
"old_path": "board/ampton/board.h",
"new_path": "board/ampton/board.h",
"diff": "#define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands while in dev. */\n/* Sensors */\n-/* TODO(b/115502220): Ampton/Apel: confirm thermistor parts */\n#define CONFIG_TEMP_SENSOR\n#define... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Ampton: confirm thermistor parts
Confirmed that Ampton is using 4050b thermistors (as we'd previously
guessed), so removing TODO
BRANCH=None
BUG=b:115502220
TEST=builds
Change-Id: Ie037eba542ae50cf1f9fa1911e9c33fb839e53dd
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1265064
Commit-Ready: Jett Rink <jettrink@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,198 | 08.10.2018 10:02:38 | 25,200 | cbc8d01cc04f77f4d37ffaf13f3aaeeabfec2058 | cr50: rename a power-button press ISR.
crrev.com/c/1192691 added power_button_release_enable_interrupt()
but didn't rename power_button_enable_interrupt(). This CL renames
one of them to keep them symmetric.
BRANCH=cr50
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/power_button.c",
"new_path": "board/cr50/power_button.c",
"diff": "@@ -39,7 +39,7 @@ void power_button_release_enable_interrupt(int enable)\n*\n* @param enable Enable (!=0) or disable (==0)\n*/\n-static void power_button_enable_interrupt(int enable)... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: rename a power-button press ISR.
crrev.com/c/1192691 added power_button_release_enable_interrupt()
but didn't rename power_button_enable_interrupt(). This CL renames
one of them to keep them symmetric.
BRANCH=cr50
BUG=b:37351386
TEST=none
Change-Id: I96a7705ba2684b26410618f177a95201d2ee0683
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1268856
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,256 | 10.10.2018 13:47:09 | 21,600 | 76f263fd678a5bd12187c91b7a071df4cd414ab0 | tpcp: update comments for CC status for clarity
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "include/usb_pd_tcpm.h",
"new_path": "include/usb_pd_tcpm.h",
"diff": "enum tcpc_cc_voltage_status {\nTYPEC_CC_VOLT_OPEN = 0,\n- TYPEC_CC_VOLT_RA = 1,\n- TYPEC_CC_VOLT_RD = 2,\n- TYPEC_CC_VOLT_SNK_DEF = 5,\n- TYPEC_CC_VOLT_SNK_1_5 = 6,\n- TYPEC_CC_VOLT_SNK_3_0 ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | tpcp: update comments for CC status for clarity
BRANCH=none
BUG=none
TEST=none
Change-Id: I5c5c109a8cda96f62bac59a499ca619348e5e922
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1276705
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,250 | 12.10.2018 11:22:31 | 25,200 | 595dfebde9556bbf6f00f613598551829c580e3f | ec3po: Add threadproc_shim.py library for subprocesses to threads transition.
BRANCH=none
TEST="python threadproc_shim.py" executes without errors. | [
{
"change_type": "MODIFY",
"old_path": "util/ec3po/__init__.py",
"new_path": "util/ec3po/__init__.py",
"diff": "@@ -22,3 +22,4 @@ stopgap until all commands are communicated via host commands.\nimport console\nimport interpreter\n+import threadproc_shim\n"
},
{
"change_type": "ADD",
"old... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec3po: Add threadproc_shim.py library for subprocesses to threads transition.
BRANCH=none
BUG=b:79684405
TEST="python threadproc_shim.py" executes without errors.
Change-Id: I63b7eb01412a3e269dc1d47d7e3e89c6f958cdac
Signed-off-by: Matthew Blecker <matthewb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1278502
Reviewed-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> |
136,256 | 15.10.2018 09:36:17 | 21,600 | 582dfdbe15bbd9118fc2b53cf423544f16cc2d19 | phaser: add sku 4
Add new SKU that is also a convertible.
BRANCH=none
TEST=builds | [
{
"change_type": "MODIFY",
"old_path": "board/phaser/board.c",
"new_path": "board/phaser/board.c",
"diff": "@@ -214,7 +214,7 @@ unsigned int motion_sensor_count = ARRAY_SIZE(motion_sensors);\nstatic int board_is_convertible(void)\n{\n- return sku_id == 2 || sku_id == 3 || sku_id == 255;\n+ return sk... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | phaser: add sku 4
Add new SKU that is also a convertible.
BRANCH=none
BUG=b:117711323
TEST=builds
Change-Id: I89bfdb49b0e23b96e5aacb8b085e9300433c6461
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1280922
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@google.com> |
136,197 | 16.10.2018 16:35:17 | -28,800 | 47cd57ac6b371bf7d13e137601fb4a1a9c18ae1a | kukui/emmc: Remove obsolete code for rev0+rework
The code that uses LDO was only useful for a few rev0 boards with
reworked power supply, let's drop it.
BRANCH=none
TEST=N/A | [
{
"change_type": "MODIFY",
"old_path": "board/kukui/emmc.c",
"new_path": "board/kukui/emmc.c",
"diff": "#include \"clock.h\"\n#include \"console.h\"\n#include \"dma.h\"\n-#include \"driver/charger/rt946x.h\"\n#include \"endian.h\"\n#include \"gpio.h\"\n#include \"hooks.h\"\n@@ -295,16 +294,6 @@ void... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui/emmc: Remove obsolete code for rev0+rework
The code that uses LDO was only useful for a few rev0 boards with
reworked power supply, let's drop it.
BRANCH=none
BUG=b:111773571
TEST=N/A
Change-Id: I48e3a8995b4d45369f1410585a66808210761e83
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1282526
Reviewed-by: Yilun Lin <yllin@chromium.org> |
136,224 | 24.01.2018 17:20:42 | 28,800 | f3700fe58696c917c953d091d0fcfc2077f54b98 | ish: gpio: gpio macro added
BRANCH=none
TEST=Tested on Atlas board with ISH.
Commit-Ready: Li1 Feng
Tested-by: Li1 Feng | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/config_chip.h",
"new_path": "chip/ish/config_chip.h",
"diff": "/* Note: ISH does not use the LPC bus but the protocol. */\n#define CONFIG_HOSTCMD_LPC\n-/* GPIO - to be implemented */\n-#define GPIO_PIN(index) (index)\n-#define GPIO_PIN_MASK(p, m) .por... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: gpio: gpio macro added
BUG=b:116451255
BRANCH=none
TEST=Tested on Atlas board with ISH.
Change-Id: I6b3913d2374e68e9522927ad5609f2867cc56f34
Signed-off-by: li feng <li1.feng@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/885007
Commit-Ready: Li1 Feng <li1.feng@intel.com>
Tested-by: Li1 Feng <li1.feng@intel.com>
Reviewed-by: Caveh Jalali <caveh@google.com>
Reviewed-by: Li1 Feng <li1.feng@intel.com> |
136,224 | 17.10.2018 15:13:21 | 25,200 | 0cbe32e30f489f9ed7e396e07406e9b910c8b0f0 | core/minute-ia/panic: noreturn function should not return
BRANCH=none
TEST=build atlas_ish which use minute-ia and pass
Commit-Ready: Caveh Jalali
Tested-by: Caveh Jalali | [
{
"change_type": "MODIFY",
"old_path": "core/minute-ia/panic.c",
"new_path": "core/minute-ia/panic.c",
"diff": "@@ -49,6 +49,9 @@ void exception_panic(void)\n#ifdef CONFIG_SOFTWARE_PANIC\nvoid software_panic(uint32_t reason, uint32_t info)\n{\n+ /* TODO: store panic log */\n+ while (1)\n+ ;\n}\nvoid... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | core/minute-ia/panic: noreturn function should not return
BUG=b:118296923
BRANCH=none
TEST=build atlas_ish which use minute-ia and pass
Change-Id: I7bd5ea67008e2f82c19390cee2d3a219bf376a30
Signed-off-by: li feng <li1.feng@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/1287150
Commit-Ready: Caveh Jalali <caveh@google.com>
Tested-by: Caveh Jalali <caveh@google.com>
Reviewed-by: Caveh Jalali <caveh@google.com> |
136,207 | 17.10.2018 17:24:01 | -28,800 | 33f6d2d5d32cc24792c463ba730bb79a82a4a529 | Disable the EC Read/Write Protect register at initial.
BRANCH=no
TEST=~/trunk/src/platform/ec/util/flash_ec --board=it83xx_evb
Commit-Ready: Dino Li
Tested-by: Dino Li | [
{
"change_type": "MODIFY",
"old_path": "util/iteflash.c",
"new_path": "util/iteflash.c",
"diff": "@@ -506,6 +506,24 @@ static int dbgr_disable_watchdog(struct common_hnd *chnd)\nreturn 0;\n}\n+/* disable protect path from DBGR */\n+static int dbgr_disable_protect_path(struct common_hnd *chnd)\n+{\n+... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Disable the EC Read/Write Protect register at initial.
BRANCH=no
BUG=None
TEST=~/trunk/src/platform/ec/util/flash_ec --board=it83xx_evb
Change-Id: Ie03605f4d10db0760a7e6e3067837b6f9a21417c
Signed-off-by: Donald Huang <donald.huang@ite.com.tw>
Reviewed-on: https://chromium-review.googlesource.com/1286316
Commit-Ready: Dino Li <Dino.Li@ite.com.tw>
Tested-by: Dino Li <Dino.Li@ite.com.tw>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,224 | 09.04.2018 15:42:31 | 25,200 | e260ea92719bd0462394a2aa4fe05e163ea02306 | atlas_ish: initial board files for atlas_ish
BRANCH=none
TEST=build with BOARD=atlas_ish is successful
Commit-Ready: Li1 Feng
Tested-by: Li1 Feng | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/atlas_ish/board.c",
"diff": "+/* Copyright 2018 The Chromium OS Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ */\n+\n+/* Atlas ISH board-specifi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | atlas_ish: initial board files for atlas_ish
BUG=b:117807679
BRANCH=none
TEST=build with BOARD=atlas_ish is successful
Change-Id: Iddb9a8a5ced24e9b99753a876ec52b0062b80344
Signed-off-by: li feng <li1.feng@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/1003393
Commit-Ready: Li1 Feng <li1.feng@intel.com>
Tested-by: Li1 Feng <li1.feng@intel.com>
Reviewed-by: Caveh Jalali <caveh@google.com>
Reviewed-by: Li1 Feng <li1.feng@intel.com> |
136,396 | 26.10.2018 17:09:10 | 25,200 | d69c0d54fac6736053b07c713029113cb6ac02df | cr50: prepare for releasing 4.11 and 3.11
BRANCH=cr50, cr50-mp
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/signer/ec_RW-manifest-dev.json",
"new_path": "util/signer/ec_RW-manifest-dev.json",
"diff": "\"timestamp\": 0,\n\"epoch\": 0, // FWR diversification contributor, 32 bits.\n\"major\": 4, // FW2_HIK_CHAIN counter.\n- \"minor\": 10, // Mostly harmless versio... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: prepare for releasing 4.11 and 3.11
BRANCH=cr50, cr50-mp
BUG=none
TEST=none
Change-Id: I6f984f84bbefa64780c9f32631c5ab6933129875
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1303474
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,427 | 26.10.2018 09:00:39 | 21,600 | e5e282e43718b7acd706a717dc0fa9a821505dfd | delan: Use CBI EEPROM for board version and SKU ID
Use board version and SKU ID from CBI EEPROM on Delan if the SKU ID
set via resistors + ADC is not valid.
BRANCH=grunt
TEST=Read CBI values from EEPROM | [
{
"change_type": "MODIFY",
"old_path": "baseboard/grunt/baseboard.c",
"new_path": "baseboard/grunt/baseboard.c",
"diff": "#include \"common.h\"\n#include \"compile_time_macros.h\"\n#include \"console.h\"\n+#include \"cros_board_info.h\"\n#include \"driver/accel_kionix.h\"\n#include \"driver/accel_kx... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | delan: Use CBI EEPROM for board version and SKU ID
Use board version and SKU ID from CBI EEPROM on Delan if the SKU ID
set via resistors + ADC is not valid.
BUG=b:76018320
BRANCH=grunt
TEST=Read CBI values from EEPROM
Change-Id: Ie37336934bd6687e46ad6ae62bc1b2e12355c83c
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1301933
Reviewed-by: Jonathan Brandmeyer <jbrandmeyer@chromium.org> |
136,418 | 24.10.2018 10:32:21 | 25,200 | 635b5c98f185ba354d9d8e9d70be56ca27c7cf75 | cheza: Configure GPIO RCAM_VSYNC to operate at 1.8V
This GPIO is connected to 1.8V devices (AP GPIO and camera connector).
BRANCH=none
TEST=Checked the schematic. Can't verify on real hardware, camera
stack not ready yet. | [
{
"change_type": "MODIFY",
"old_path": "board/cheza/gpio.inc",
"new_path": "board/cheza/gpio.inc",
"diff": "@@ -73,7 +73,7 @@ GPIO(ENABLE_BACKLIGHT, PIN(B, 6), GPIO_OUT_LOW) /* EC_BL_DISABLE_L: Backl\n/* Sensors */\nGPIO(ALS_INT_L, PIN(5, 0), GPIO_INPUT) /* ALS sensor interrupt */\nGPIO(P_SENSOR_INT... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cheza: Configure GPIO RCAM_VSYNC to operate at 1.8V
This GPIO is connected to 1.8V devices (AP GPIO and camera connector).
BRANCH=none
BUG=b:118342270
TEST=Checked the schematic. Can't verify on real hardware, camera
stack not ready yet.
Change-Id: Ic3a61e680d0982b956d986505c5f2d44fe270131
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1298367
Reviewed-by: Stephen Boyd <swboyd@chromium.org> |
136,235 | 29.10.2018 11:46:20 | -28,800 | 32467b1ab217213962dcdbd141cbeb608f190520 | Delan: LED Color Change
Changing Delan led color from blue to white
BRANCH=none
TEST=none
Commit-Ready: ChromeOS CL Exonerator Bot
Tested-by: Edward Hill | [
{
"change_type": "MODIFY",
"old_path": "board/delan/board.c",
"new_path": "board/delan/board.c",
"diff": "@@ -105,7 +105,7 @@ const struct pwm_t pwm_channels[] = {\n| PWM_CONFIG_DSLEEP),\n.freq = 100,\n},\n- [PWM_CH_LED2_BLUE] = {\n+ [PWM_CH_LED2_WHITE] = {\n.channel = 2,\n.flags = (PWM_CONFIG_OPEN_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Delan: LED Color Change
Changing Delan led color from blue to white
BUG=b:118418060
BRANCH=none
TEST=none
Change-Id: I41dbf9df8798c2fd69b328eed690fe43167654d0
Signed-off-by: koko <ko_ko@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/1304157
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,418 | 24.10.2018 11:34:12 | 25,200 | a7c864a2332dbb9fc8d5ca3655abef04d2482df1 | cheza: Add internal PU for GPIO USB_C1_OC_ODL
This is an open-drain output from NX5P3290. Need an internal PU in EC.
BRANCH=none
TEST=Ran EC command "gpioget USB_C1_OC_ODL" and checked it high. | [
{
"change_type": "MODIFY",
"old_path": "board/cheza/gpio.inc",
"new_path": "board/cheza/gpio.inc",
"diff": "@@ -124,7 +124,7 @@ GPIO(USBC_MUX_CONF1, PIN(5, 1), GPIO_OUT_HIGH) /* Port-1 enable DP switc\n/* USB-C port-1 interrupts */\nGPIO(USB_C1_DP_HPD, PIN(9, 6), GPIO_INPUT) /* DP HPD from port-1 TC... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cheza: Add internal PU for GPIO USB_C1_OC_ODL
This is an open-drain output from NX5P3290. Need an internal PU in EC.
BRANCH=none
BUG=b:118342484
TEST=Ran EC command "gpioget USB_C1_OC_ODL" and checked it high.
Change-Id: I1e38b9c64a163740c65256fbf551ac28feaade49
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1298368
Reviewed-by: Stephen Boyd <swboyd@chromium.org> |
136,418 | 25.10.2018 10:31:24 | 25,200 | 8d652217d9a006985b58126aa25277ac2c79263d | cheza: Update battery info
The min voltage is 6V according to the spec.
BRANCH=none
TEST=Tested charge and discharge. | [
{
"change_type": "MODIFY",
"old_path": "board/cheza/battery.c",
"new_path": "board/cheza/battery.c",
"diff": "#define SB_SHIP_MODE_REG SB_MANUFACTURER_ACCESS\n#define SB_SHUTDOWN_DATA 0x0010\n-/* Battery info for rev-0 */\n+/* Battery info */\nstatic const struct battery_info info = {\n- /* Copied f... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cheza: Update battery info
The min voltage is 6V according to the spec.
BRANCH=none
BUG=b:74397611
TEST=Tested charge and discharge.
Change-Id: Icf82e7299dbe3175c5b4dbe824108f11888c2ff5
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1299713
Reviewed-by: Philip Chen <philipchen@chromium.org> |
136,405 | 29.10.2018 18:31:20 | 25,200 | 9f42d8f5197f92daf43705cd36438619ff8fc8a4 | Nami: Add keymasks for page-up/down, home, end, delete
BRANCH=none
TEST=Verified all keys on keypad work as expected.
Commit-Ready: Daisuke Nojiri
Tested-by: Daisuke Nojiri | [
{
"change_type": "MODIFY",
"old_path": "board/nami/board.c",
"new_path": "board/nami/board.c",
"diff": "@@ -908,6 +908,26 @@ static void cbi_init(void)\n}\nDECLARE_HOOK(HOOK_INIT, cbi_init, HOOK_PRIO_INIT_I2C + 1);\n+/* Keyboard scan setting */\n+struct keyboard_scan_config keyscan_config = {\n+ /*\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Nami: Add keymasks for page-up/down, home, end, delete
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=b:117126568
BRANCH=none
TEST=Verified all keys on keypad work as expected.
Change-Id: If23b422c1260b8437c59fd13a9280e8d6e87f94b
Reviewed-on: https://chromium-review.googlesource.com/1311374
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
136,282 | 31.10.2018 18:09:24 | -28,800 | 58b9437d7e0e7a7b8941289cf1abdf20c735a24e | meep: enable keyboard factory scanning
This patch add for factory keyboard connector test.
BRANCH=none
TEST=Short keyboard pins and make sure "ectool kbfactorytest" works. | [
{
"change_type": "MODIFY",
"old_path": "board/meep/board.c",
"new_path": "board/meep/board.c",
"diff": "@@ -305,3 +305,21 @@ void lid_angle_peripheral_enable(int enable)\nkeyboard_scan_enable(enable, KB_SCAN_DISABLE_LID_ANGLE);\n}\n#endif\n+\n+#ifdef CONFIG_KEYBOARD_FACTORY_TEST\n+/*\n+ * Map keyboa... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | meep: enable keyboard factory scanning
This patch add for factory keyboard connector test.
BUG=none
BRANCH=none
TEST=Short keyboard pins and make sure "ectool kbfactorytest" works.
Change-Id: Ic343b99343f5f6d7a8967bf1c4bec642638d8568
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/1309572
Reviewed-by: Justin TerAvest <teravest@chromium.org> |
136,396 | 23.10.2018 14:40:41 | 25,200 | 5a2a94eea5c5d7eb47964e211917437e57083399 | config: add flag for ITE EC programming over CCD
This flag will allow to enable inclusion of the relevant source files
in common directories.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "include/config.h",
"new_path": "include/config.h",
"diff": "#undef CONFIG_CASE_CLOSED_DEBUG_V1\n/* Allow unsafe debugging functionality in V1 configuration */\n#undef CONFIG_CASE_CLOSED_DEBUG_V1_UNSAFE\n+/* Enable ITE EC programming by CCD using the INA i2c in... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | config: add flag for ITE EC programming over CCD
This flag will allow to enable inclusion of the relevant source files
in common directories.
BRANCH=none
BUG=b:75976718
TEST=none
Change-Id: I037f811d0b8fd7327534f02f759eead3fd8f3de0
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1305115
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,250 | 31.10.2018 16:32:53 | 25,200 | 34ea5969dd36815de20abbf9ce27fc1583564533 | iteflash: Be more consistent with blank lines and static functions.
This is no-op cleanup.
BRANCH=none
TEST=With Servo v2 "flash_ec --board=bip" continues to work. | [
{
"change_type": "MODIFY",
"old_path": "util/iteflash.c",
"new_path": "util/iteflash.c",
"diff": "#define SPI_CMD_EWSR 0x50 /* Enable Write Status Register */\n#define SPI_CMD_WRSR 0x01 /* Write Status Register */\n-\n/* Size for FTDI outgoing buffer */\n#define FTDI_CMD_BUF_SIZE (1<<12)\n-\n/* Rese... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | iteflash: Be more consistent with blank lines and static functions.
This is no-op cleanup.
BRANCH=none
BUG=b:79684405
TEST=With Servo v2 "flash_ec --board=bip" continues to work.
Change-Id: I0131bd3f766c574a43e692ffd9a9ef842e4be2df
Signed-off-by: Matthew Blecker <matthewb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1311758
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,414 | 01.11.2018 16:00:59 | -28,800 | 23fb902b2066765c08cd68d4f3c54380fdf78709 | cr50: Rename tpm_nvmem_read to tpm_nvmem_ops
A future CL will add non-read operations.
TEST=build
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/build.mk",
"new_path": "board/cr50/build.mk",
"diff": "@@ -56,7 +56,7 @@ board-y += tpm2/tpm_mode.o\nboard-y += tpm2/tpm_state.o\nboard-y += tpm2/trng.o\nboard-y += tpm2/virtual_nvmem.o\n-board-y += tpm_nvmem_read.o\n+board-y += tpm_nvmem_ops.o\nboa... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: Rename tpm_nvmem_read to tpm_nvmem_ops
A future CL will add non-read operations.
TEST=build
BRANCH=none
BUG=b:112604850
Change-Id: Ie024e30b81dff888dcb42adcd4e3b2daded2f4f7
Signed-off-by: Louis Collard <louiscollard@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1312517
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,198 | 02.11.2018 11:53:46 | 25,200 | 15db6d5bbc6c28a4c632eb631e6010fd106d5cc8 | gsctool: minor code pruning.
Removed a redundant if-statement
BRANCH=none
TEST=gsctool -i
Board ID space: 41434245:bebcbdba:00007f7f | [
{
"change_type": "MODIFY",
"old_path": "extra/usb_updater/gsctool.c",
"new_path": "extra/usb_updater/gsctool.c",
"diff": "@@ -1817,12 +1817,11 @@ void process_bid(struct transfer_descriptor *td,\n((const char *)bid)[2],\n((const char *)bid)[3]);\n} else {\n- if (bid_action == bid_get) {\nprintf(\"Bo... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | gsctool: minor code pruning.
Removed a redundant if-statement
BRANCH=none
BUG=none
TEST=gsctool -i
Board ID space: 41434245:bebcbdba:00007f7f
Change-Id: Ie6a1237fb5d1dc6085c1680dc1b37a9b127511f0
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1315629
Reviewed-by: Bob Moragues <moragues@chromium.org> |
136,412 | 04.11.2018 17:32:44 | 28,800 | d20f90a205e86bf49307402a12c49226ae1ee03d | fpsensor: Move the definition of FP_TEMPLATE_FORMAT_VERSION
Move it to ec_commands.h so it's accessible to tools.
BRANCH=nocturne
TEST=make BOARD=nocturne_fp -j | [
{
"change_type": "MODIFY",
"old_path": "common/fpsensor.c",
"new_path": "common/fpsensor.c",
"diff": "#define FP_MAX_FINGER_COUNT 0\n#endif\n#define SBP_ENC_KEY_LEN 16\n-#define FP_TEMPLATE_FORMAT_VERSION 3\n#define FP_ALGORITHM_ENCRYPTED_TEMPLATE_SIZE \\\n(FP_ALGORITHM_TEMPLATE_SIZE + \\\nsizeof(st... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | fpsensor: Move the definition of FP_TEMPLATE_FORMAT_VERSION
Move it to ec_commands.h so it's accessible to tools.
BRANCH=nocturne
BUG=b:73337313
TEST=make BOARD=nocturne_fp -j
Change-Id: Ib7eecee599dde2d755357c2543ad860b64258f3f
Signed-off-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1316706
Reviewed-by: Prashant Malani <pmalani@google.com> |
136,429 | 08.11.2018 13:15:37 | 28,800 | fa66dd458cfaedda81811f5bfce830bd0f065a31 | cr50_fuzz: Fix broken compilation
Adds mock implementation of get_current_pcr_digest() for the fuzz
target.
BRANCH=None
TEST=make -j buildfuzztests | [
{
"change_type": "MODIFY",
"old_path": "fuzz/cr50_fuzz.cc",
"new_path": "fuzz/cr50_fuzz.cc",
"diff": "@@ -41,6 +41,13 @@ extern \"C\" void get_storage_seed(void *buf, size_t *len)\nmemset(buf, 0x77, *len);\n}\n+extern \"C\" uint8_t get_current_pcr_digest(const uint8_t bitmask[2],\n+ uint8_t sha256_o... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50_fuzz: Fix broken compilation
Adds mock implementation of get_current_pcr_digest() for the fuzz
target.
BRANCH=None
BUG=chromium:903487
TEST=make -j buildfuzztests
Change-Id: I55b7da813d4f17ef7f60e045423a3917a052e41c
Signed-off-by: Allen Webb <allenwebb@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/1327128
Reviewed-by: Manoj Gupta <manojgupta@chromium.org> |
136,224 | 24.01.2018 16:08:31 | 28,800 | 12eacd182f5fba9cc744037c04c8e6317752b9fa | ish gpio: added GPIO interrupt to IOAPIC
BRANCH=none
TEST=none
Commit-Ready: Li1 Feng
Tested-by: Li1 Feng | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/gpio.c",
"new_path": "chip/ish/gpio.c",
"diff": "@@ -31,4 +31,12 @@ static void gpio_init(void)\n{\n/* TBD */\n}\n+\n+static void gpio_interrupt(void)\n+{\n+ /*TODO*/\n+}\n+\n+DECLARE_IRQ(ISH_GPIO_IRQ, gpio_interrupt);\n+\nDECLARE_HOOK(HOOK_INIT, gpio... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish gpio: added GPIO interrupt to IOAPIC
BUG=b:116451255
BRANCH=none
TEST=none
Change-Id: I3d6883554393c1733a902eff8ea3680ec9de33e1
Signed-off-by: li feng <li1.feng@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/884604
Commit-Ready: Li1 Feng <li1.feng@intel.com>
Tested-by: Li1 Feng <li1.feng@intel.com>
Reviewed-by: Caveh Jalali <caveh@google.com>
Reviewed-by: Kyoung Il Kim <kyoung.il.kim@intel.com> |
136,224 | 07.03.2018 22:50:55 | 28,800 | c9b5321774df82fa153644f0ef3bf05ed08dd48a | ish gpio: GPIO functionality
BRANCH=none
TEST=Tested on Atlas board, ISH GPIO is working.
Commit-Ready: Caveh Jalali
Tested-by: Li1 Feng | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/gpio.c",
"new_path": "chip/ish/gpio.c",
"diff": "#include \"timer.h\"\n#include \"util.h\"\n+#define ISH_TOTAL_GPIO_PINS 8\n+\ntest_mockable int gpio_get_level(enum gpio_signal signal)\n{\n- return 0;\n+ return !!(ISH_GPIO_GPLR & gpio_list[signal].mas... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish gpio: GPIO functionality
BUG=b:116451255
BRANCH=none
TEST=Tested on Atlas board, ISH GPIO is working.
Change-Id: I29121dd143a5bf44a7431d12d9e05a3510fb4654
Signed-off-by: Sadashiva Rao Pv <sadashiva.rao.pv@intel.com>
Signed-off-by: li feng <li1.feng@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/954718
Commit-Ready: Caveh Jalali <caveh@google.com>
Tested-by: Li1 Feng <li1.feng@intel.com>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,429 | 09.11.2018 09:42:53 | 28,800 | 1c95cff7463ef29bd0c6d087ce8c3d7e17f94c6a | cr50: Add extern "C" to headers used by future fuzzing target.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "builtin/assert.h",
"new_path": "builtin/assert.h",
"diff": "#include \"common.h\"\n#endif\n+#ifdef __cplusplus\n+extern \"C\" {\n+#endif\n+\n#ifdef CONFIG_DEBUG_ASSERT\n#ifdef CONFIG_DEBUG_ASSERT_REBOOTS\n@@ -46,4 +50,8 @@ extern void panic_assert_fail(const c... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: Add extern "C" to headers used by future fuzzing target.
BRANCH=None
BUG=None
TEST=make -j buildall
Change-Id: Icf2cfb6a2657064c10721c0e527d24fbb3be6ab3
Signed-off-by: Allen Webb <allenwebb@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1330102
Reviewed-by: Mike Frysinger <vapier@chromium.org> |
136,429 | 13.11.2018 10:08:40 | 28,800 | 72a29e834d035c29e5127ad9dfba76d0ba06e694 | Makefile.toolchain: Add vars for libprotobuf-mutator.
libprotobuf-mutator is a helper library for fuzzing using protocol
buffers.
BRANCH=None
TEST=make -j buildfuzztests && make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "Makefile.toolchain",
"new_path": "Makefile.toolchain",
"diff": "@@ -96,15 +96,23 @@ endif\nCFLAGS+= -DCHROMIUM_EC\nCXXFLAGS+=-DPROTOBUF_INLINE_NOT_IN_HEADERS=0\n-FTDIVERSION=$(shell $(PKG_CONFIG) --modversion libftdi1 2>/dev/null)\n+FTDIVERSION:=$(shell $(PKG_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Makefile.toolchain: Add vars for libprotobuf-mutator.
libprotobuf-mutator is a helper library for fuzzing using protocol
buffers.
BRANCH=None
BUG=None
TEST=make -j buildfuzztests && make -j buildall
Change-Id: I855691860042bdbdeafe68cc0e0d7bea0f2667cc
Signed-off-by: Allen Webb <allenwebb@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1334030
Reviewed-by: Mike Frysinger <vapier@chromium.org> |
136,256 | 13.11.2018 14:53:54 | 25,200 | 2d1ab813cba0e2aeb6bc5ce482abcf33340d8f67 | ppc/nx20: add more fault condition prints
When the PPC detects a fault condition such as a short or reverse
current, we should print something to the EC console.
BRANCH=none
TEST=build. Couldn't get this to trip on demand though. | [
{
"change_type": "MODIFY",
"old_path": "driver/ppc/nx20p348x.c",
"new_path": "driver/ppc/nx20p348x.c",
"diff": "@@ -227,7 +227,8 @@ static int nx20p348x_init(int port)\nreturn rv;\n/* Mask interrupts for interrupt 1 register */\n- mask = ~(NX20P348X_INT1_OC_5VSRC | NX20P348X_INT1_DBEXIT_ERR);\n+ mas... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ppc/nx20: add more fault condition prints
When the PPC detects a fault condition such as a short or reverse
current, we should print something to the EC console.
BRANCH=none
BUG=b:115307099
TEST=build. Couldn't get this to trip on demand though.
Change-Id: Ib5298074b08a7d7d0d278258822fb7edf562c7aa
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1334527
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,256 | 12.11.2018 16:06:22 | 25,200 | aa4b120fda33ba58b45c8570259a916a716c3161 | octopus: ignore C0 interrupts if in reset
Now that we have a reset line to C0, we should ignore interrupts while
the C0 TCPC is in reset.
BRANCH=none
TEST=flashed on fleex (uses C0 reset) without issue | [
{
"change_type": "MODIFY",
"old_path": "baseboard/octopus/variant_usbc_standalone_tcpcs.c",
"new_path": "baseboard/octopus/variant_usbc_standalone_tcpcs.c",
"diff": "@@ -112,8 +112,11 @@ uint16_t tcpc_get_alert_status(void)\n{\nuint16_t status = 0;\n- if (!gpio_get_level(GPIO_USB_C0_MUX_INT_ODL))\n+... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | octopus: ignore C0 interrupts if in reset
Now that we have a reset line to C0, we should ignore interrupts while
the C0 TCPC is in reset.
BRANCH=none
BUG=none
TEST=flashed on fleex (uses C0 reset) without issue
Change-Id: I014e95f80844b30623d1fba7e59bea8f5eb8572e
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1332807
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,427 | 15.11.2018 13:31:44 | 25,200 | 143e67c9547a8b79b26df8ca206769fb4a114610 | Liara: Add LGC battery
BRANCH=grunt
TEST=Boot Liara with LGC battery;
"cutoff" EC command succeeds;
Plug in AC => boot to OS login.
Tested-by: Josh Tsai | [
{
"change_type": "MODIFY",
"old_path": "board/liara/battery.c",
"new_path": "board/liara/battery.c",
"diff": "@@ -127,6 +127,37 @@ const struct board_batt_params board_battery_info[] = {\n.discharging_max_c = 70,\n},\n},\n+ /*\n+ * LGC 2018 Battery Information for Liara\n+ * Gauge IC: Renesas RAJ240... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Liara: Add LGC battery
BUG=b:113823864
BRANCH=grunt
TEST=Boot Liara with LGC battery;
"cutoff" EC command succeeds;
Plug in AC => boot to OS login.
Change-Id: If2ea7bd1a6888b7bbe5f4eb0dd3217073d32e346
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1337468
Tested-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,429 | 15.11.2018 16:41:17 | 28,800 | da4d64502178778db56fda6419fd9cf2dc9f6df2 | Makefile.toolchain: Add TEST_FUZZ checks.
This prevents a bunch of warnings that show when trying to run
pkg-config for libprotobuf-mutator when not building the fuzzer
targets.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "Makefile.toolchain",
"new_path": "Makefile.toolchain",
"diff": "@@ -106,6 +106,7 @@ endif\nLIBFTDI_CFLAGS:=$(shell $(PKG_CONFIG) --cflags lib${LIBFTDI_NAME})\nLIBFTDI_LDLIBS:=$(shell $(PKG_CONFIG) --libs lib${LIBFTDI_NAME})\n+ifeq ($(TEST_FUZZ),y)\nLIBPROTOBUF... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Makefile.toolchain: Add TEST_FUZZ checks.
This prevents a bunch of warnings that show when trying to run
pkg-config for libprotobuf-mutator when not building the fuzzer
targets.
BRANCH=None
BUG=None
TEST=make -j buildall
Change-Id: Idf8de959d86db744754cd237796ccaacd3668a63
Signed-off-by: Allen Webb <allenwebb@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1338605
Reviewed-by: Mike Frysinger <vapier@chromium.org> |
136,412 | 15.11.2018 14:17:29 | 28,800 | 3d4652613c6d2beea8e0dd90f12612fad8eec4d8 | headers: make EC commands headers C++-friendly
wrap headers in 'extern "C"'
use relative path to #include
BRANCH=None
TEST=make buildall -j
TEST=emerge-nocturne ec-utils | [
{
"change_type": "MODIFY",
"old_path": "include/ec_commands.h",
"new_path": "include/ec_commands.h",
"diff": "#include <stdint.h>\n#endif\n+#ifdef __cplusplus\n+extern \"C\"{\n+#endif\n+\n/*\n* Include common.h for CONFIG_HOSTCMD_ALIGNED, if it's defined. This\n* generates more efficient code for ac... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | headers: make EC commands headers C++-friendly
- wrap headers in 'extern "C"'
- use relative path to #include
BRANCH=None
BUG=chromium:889250
TEST=make buildall -j
TEST=emerge-nocturne ec-utils
Change-Id: I67d8ba88edf77f72bd54500eff169537ffb6257f
Signed-off-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1338599
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org> |
136,427 | 20.11.2018 14:57:58 | 25,200 | 0c28fa95119487b51be5aa189060333f8da0c817 | led_pwm: Add CONFIG_LED_PWM_CHARGE_STATE_ONLY
Add an option for devices that want to show only the charging state,
but on all LEDs.
BRANCH=grunt
TEST=Liara LED is on when charging from either side.
Tested-by: Josh Tsai | [
{
"change_type": "MODIFY",
"old_path": "common/led_pwm.c",
"new_path": "common/led_pwm.c",
"diff": "@@ -160,20 +160,20 @@ static int show_charge_state(void)\npulse_leds(CONFIG_LED_PWM_CHARGE_ERROR_COLOR, 1, 2);\n} else {\n/* Discharging or not charging. */\n-#ifdef CONFIG_LED_PWM_ACTIVE_CHARGE_PORT_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | led_pwm: Add CONFIG_LED_PWM_CHARGE_STATE_ONLY
Add an option for devices that want to show only the charging state,
but on all LEDs.
BUG=b:119746227
BRANCH=grunt
TEST=Liara LED is on when charging from either side.
Change-Id: I819eaf27d3700748e47886855765c2da6f3d9eb8
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1344795
Tested-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,429 | 20.11.2018 14:53:35 | 28,800 | 90f4c546b39336986686a620e43c2f66aab8d6b9 | cr50_fuzz: fix nvmem_vars user number.
The CONFIG_FLASH_NVMEM_VARS_USER_NUM constant was incorrectly defined,
so nvmem_vars was failing with EC_OVERFLOW.
BRANCH=None
TEST=make -j buildfuzztests && ./build/host/cr50_fuzz/cr50_fuzz.exe | [
{
"change_type": "MODIFY",
"old_path": "fuzz/fuzz_config.h",
"new_path": "fuzz/fuzz_config.h",
"diff": "@@ -61,7 +61,7 @@ enum nvmem_users {\nNVMEM_NUM_USERS\n};\n#endif\n-#define CONFIG_FLASH_NVMEM_VARS_USER_NUM NVMEM_NUM_USERS\n+#define CONFIG_FLASH_NVMEM_VARS_USER_NUM NVMEM_CR50\n/***************... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50_fuzz: fix nvmem_vars user number.
The CONFIG_FLASH_NVMEM_VARS_USER_NUM constant was incorrectly defined,
so nvmem_vars was failing with EC_OVERFLOW.
BRANCH=None
BUG=None
TEST=make -j buildfuzztests && ./build/host/cr50_fuzz/cr50_fuzz.exe
Change-Id: I52facfd44423bb69284b54e6831e5e777cf35a05
Signed-off-by: Allen Webb <allenwebb@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1344800
Reviewed-by: Manoj Gupta <manojgupta@chromium.org> |
136,305 | 21.11.2018 11:57:36 | 25,200 | da44489b829098c579541081fc282dec47b6cab0 | Casta: initial EC image
Initial image for casta based on the most recent schematics available.
BRANCH=octopus
TEST=builds | [
{
"change_type": "MODIFY",
"old_path": "baseboard/octopus/baseboard.h",
"new_path": "baseboard/octopus/baseboard.h",
"diff": "#if defined(VARIANT_OCTOPUS_USBC_STANDALONE_TCPCS)\n#define CONFIG_USB_PD_TCPC_LOW_POWER\n#define CONFIG_USB_PD_DUAL_ROLE_AUTO_TOGGLE\n+#if !defined(VARIANT_OCTOPUS_TCPC_0_PS... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Casta: initial EC image
Initial image for casta based on the most recent schematics available.
BUG=b:119174492
BRANCH=octopus
TEST=builds
Change-Id: Ie0575476d79fd8f6c5f697499bc8a660880348e3
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1347011
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,236 | 15.11.2018 11:14:12 | -28,800 | c92a973c55a3030b9a781994b6bf0c2d2a1630c7 | Aleena: switch LED pin
switch Blue and Amber GPIO by different board for power consumption.
BRANCH=master
TEST=`make board=aleena`
Commit-Ready: Edward Hill
Tested-by: Edward Hill | [
{
"change_type": "MODIFY",
"old_path": "board/aleena/gpio.inc",
"new_path": "board/aleena/gpio.inc",
"diff": "@@ -85,8 +85,8 @@ GPIO(SKU_ID1, PIN(F, 0), GPIO_INPUT)\nGPIO(SKU_ID2, PIN(4, 1), GPIO_INPUT)\n/* LED */\n-GPIO(BAT_LED_ORANGE_L, PIN(C, 3), GPIO_OUT_HIGH) /* LED_1_L */\n-GPIO(BAT_LED_BLUE_L... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Aleena: switch LED pin
switch Blue and Amber GPIO by different board for power consumption.
BUG=b:118657568
BRANCH=master
TEST=`make board=aleena`
Signed-off-by: Ryan Zhang <ryan.zhang@quanta.corp-partner.google.com>
Change-Id: Ib782397082f2efc799422db8bf0e2d637db1b32f
Reviewed-on: https://chromium-review.googlesource.com/1345550
Commit-Ready: Edward Hill <ecgh@chromium.org>
Tested-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,256 | 12.11.2018 15:11:42 | 25,200 | 9fd39f0e58ac10abd2e8ae0f0d2734f27776d03e | fleex: update gpio name to latest board revision
No functional changes. Update names to BOARD_ID=2 version of the
schematics.
BRANCH=none
TEST=builds | [
{
"change_type": "MODIFY",
"old_path": "board/fleex/gpio.inc",
"new_path": "board/fleex/gpio.inc",
"diff": "@@ -138,11 +138,11 @@ GPIO(LED_2_CHG_AMBER_L, PIN(C, 4), GPIO_OUT_HIGH)\nGPIO(KB_BL_PWR_EN, PIN(6, 2), GPIO_OUT_LOW)\n/* Camera */\n-GPIO(WFCAM_VSYNC, PIN(0, 3), GPIO_INPUT) /* TP only */\n-GP... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | fleex: update gpio name to latest board revision
No functional changes. Update names to BOARD_ID=2 version of the
schematics.
BRANCH=none
BUG=none
TEST=builds
Change-Id: I05d49aa436e9d08c0f61da3de7032c2875b3054c
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1332467
Reviewed-by: Karthikeyan Ramasubramanian <kramasub@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,256 | 27.11.2018 10:02:37 | 25,200 | eef88764d241f42d27eabf64deb6f95233495adb | octopus: remove OCM erase command
We haven't need the OCM erase command for anlogix TCPCs for a while
since they are being shipped with the OCM pre-erased
BRANCH=octopus
TEST=buildall
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "baseboard/octopus/baseboard.h",
"new_path": "baseboard/octopus/baseboard.h",
"diff": "#define CONFIG_USB_PD_DUAL_ROLE_AUTO_TOGGLE\n#if !defined(VARIANT_OCTOPUS_TCPC_0_PS8751)\n#define CONFIG_USB_PD_TCPM_ANX7447 /* C0 TCPC: ANX7447QN */\n- #define CONFIG_USB_PD... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | octopus: remove OCM erase command
We haven't need the OCM erase command for anlogix TCPCs for a while
since they are being shipped with the OCM pre-erased
BRANCH=octopus
BUG=b:109882250
TEST=buildall
Change-Id: Ic4d2fa1e40037e01d5ed03116e8ceb14840f0ea9
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1352057
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> |
136,340 | 07.07.2018 21:58:04 | 25,200 | 6d6378b8d0f9a08eee75dfb794b5697cdcd4b821 | motion_sense: Remove global fifo_flush_needed, redundant
Instead, use the event flag.
BRANCH=scarlet,poppy
TEST=Compile.
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "common/motion_sense.c",
"new_path": "common/motion_sense.c",
"diff": "@@ -93,8 +93,6 @@ static void print_spoof_mode_status(int id);\n/* Need to wake up the AP */\nstatic int wake_up_needed;\n-/* Need to send flush events */\n-static int fifo_flush_needed;\n/*... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | motion_sense: Remove global fifo_flush_needed, redundant
Instead, use the event flag.
BUG=b:73557414
BRANCH=scarlet,poppy
TEST=Compile.
Change-Id: Ic1b123edb6f67012f38b1022d492492175b5d59d
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1128551
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Alexandru M Stan <amstan@chromium.org> |
136,452 | 28.11.2018 17:11:40 | -28,800 | 8a5814e1a8890c988a5315314597628fa0882a3c | gsctool: correct a typo
TEST=check for correct output with --help flag
BRANCH=master
Commit-Ready: Joel Kitching
Tested-by: Joel Kitching | [
{
"change_type": "MODIFY",
"old_path": "extra/usb_updater/gsctool.c",
"new_path": "extra/usb_updater/gsctool.c",
"diff": "@@ -521,7 +521,7 @@ static void usage(int errs)\n\"images, etc.\\n\"\n\"The required argument is the file name of a full RO+RW\\n\"\n\"binary image.\\n\"\n- \"A typical Chromeboo... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | gsctool: correct a typo
BUG=None
TEST=check for correct output with --help flag
BRANCH=master
Change-Id: Idf0448791e3d043313bc1291810d71d3f4846a6a
Reviewed-on: https://chromium-review.googlesource.com/1351925
Commit-Ready: Joel Kitching <kitching@chromium.org>
Tested-by: Joel Kitching <kitching@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,250 | 27.11.2018 15:15:52 | 28,800 | c1b0bf4bd57ec87a55ffbae4d08ae7422d1a6e44 | servo_micro: Increase maximum I2C-over-USB write and read sizes.
BRANCH=none
TEST=This makes block_write_size up to 254B in iteflash work,
and makes 256B verification reads work. | [
{
"change_type": "MODIFY",
"old_path": "board/servo_micro/board.h",
"new_path": "board/servo_micro/board.h",
"diff": "#define CONFIG_USB_I2C\n#define CONFIG_I2C\n#define CONFIG_I2C_MASTER\n+/*\n+ * iteflash requires 256 byte reads for verifying ITE EC firmware. Without this\n+ * the limit is CONFIG_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | servo_micro: Increase maximum I2C-over-USB write and read sizes.
BRANCH=none
BUG=b:79684405
TEST=This makes block_write_size up to 254B in iteflash work,
and makes 256B verification reads work.
Change-Id: I887f0eaacc87428a4646007520f27bdf5aaa231a
Signed-off-by: Matthew Blecker <matthewb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1351517
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,429 | 03.12.2018 16:20:03 | 28,800 | 5f4f729f2fde645c377b6e3011dab82b1585a469 | cr50_fuzz: Disable this fuzz target until chromeos-ec is fixed.
BRANCH=None
TEST=USE="ubsan asan fuzzer" ./build_packages \
--board=amd64-generic --skip_chroot_upgrade chromeos-ec | [
{
"change_type": "MODIFY",
"old_path": "fuzz/build.mk",
"new_path": "fuzz/build.mk",
"diff": "# fuzzer binaries\n#\n-fuzz-test-list-host = cr50_fuzz host_command_fuzz\n+# TODO(crbug.com/911310) Fix the chromeos-ec build before adding cr50_fuzz back.\n+fuzz-test-list-host = host_command_fuzz\n# For f... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50_fuzz: Disable this fuzz target until chromeos-ec is fixed.
BRANCH=None
BUG=chromium:911310
TEST=USE="ubsan asan fuzzer" ./build_packages \
--board=amd64-generic --skip_chroot_upgrade chromeos-ec
Change-Id: Ib2ffc7035d0f6912834709bb8a5f6b3c11a2c67a
Signed-off-by: Allen Webb <allenwebb@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1359652
Reviewed-by: Manoj Gupta <manojgupta@chromium.org> |
136,429 | 03.12.2018 15:54:11 | 28,800 | cc31a630160817c5ab332e35b0d10a0b8cd772a8 | cr50_fuzz: Fix missing dependencies.
This fixes a dependency problem that was introduced in CL:1184107.
BRANCH=None
TEST=USE="ubsan asan fuzzer" ./build_packages \
--board=amd64-generic --skip_chroot_upgrade chromeos-ec | [
{
"change_type": "MODIFY",
"old_path": "fuzz/build.mk",
"new_path": "fuzz/build.mk",
"diff": "@@ -24,7 +24,10 @@ fuzz-test-list-host = host_command_fuzz\ncr50_fuzz-rw = cr50_fuzz.o pinweaver_model.o mem_hash_tree.o\nhost_command_fuzz-y = host_command_fuzz.o\n-$(out)/RW/fuzz/cr50_fuzz.o: $(out)/gen/f... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50_fuzz: Fix missing dependencies.
This fixes a dependency problem that was introduced in CL:1184107.
BRANCH=None
BUG=chromium:911310
TEST=USE="ubsan asan fuzzer" ./build_packages \
--board=amd64-generic --skip_chroot_upgrade chromeos-ec
Change-Id: Ib4795d6a716fe3fcb7a88bf6a165f96ffe10640a
Signed-off-by: Allen Webb <allenwebb@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1358746
Reviewed-by: Mattias Nissler <mnissler@chromium.org> |
136,418 | 04.12.2018 13:30:54 | 28,800 | 5eb2d70128d9a41ff0b83362e6beec23b7dae3d9 | cheza: Remove the TODO's of verifying the config values
Checked the resistor values. And some timing and power values are all
the same in other boards.
BRANCH=none
TEST=Flashed the EC and verified charging and sourcing. | [
{
"change_type": "MODIFY",
"old_path": "board/cheza/board.h",
"new_path": "board/cheza/board.h",
"diff": "#define CONFIG_CHARGER_PSYS_READ\n#define CONFIG_CHARGER_DISCHARGE_ON_AC\n-/* TODO(b/79163120): Use correct charger values, copied from Lux for rev-0 */\n#define CONFIG_CHARGER_INPUT_CURRENT 512... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cheza: Remove the TODO's of verifying the config values
Checked the resistor values. And some timing and power values are all
the same in other boards.
BRANCH=none
BUG=b:79163120
TEST=Flashed the EC and verified charging and sourcing.
Change-Id: I1574cf539ee36c80694d514f6bd47ccfd8b1660e
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1361681
Reviewed-by: Philip Chen <philipchen@chromium.org> |
136,408 | 31.10.2018 11:31:17 | 25,200 | f4f98c165e76df5941bef5637692e97889f9cabc | Add reference to nami_fp in flash_ec
BRANCH=None
TEST=make BOARD=nami_fp -j | [
{
"change_type": "MODIFY",
"old_path": "util/flash_ec",
"new_path": "util/flash_ec",
"diff": "@@ -73,6 +73,7 @@ BOARDS_STM32=(\nkukui\nmeowth_fp\nminimuffin\n+ nami_fp\nnocturne_fp\noak\noak_pd\n@@ -642,7 +643,7 @@ case \"${BOARD}\" in\nchocodile_bec ) MCU=\"usbpd\" ;;\noak_pd|samus_pd|strago_pd ) M... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Add reference to nami_fp in flash_ec
BRANCH=None
BUG=b:117297043,b:117295290
TEST=make BOARD=nami_fp -j
Change-Id: Ia4b7fee414dc7bef5a2e7ed946ff7d338a17b1b0
Signed-off-by: YH Lin <yueherngl@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1310933
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,429 | 07.12.2018 10:09:57 | 28,800 | 7f325f2e91482aee604de71f19f6669762594818 | cr50_fuzz: Disable this target. It is breaking the chromeos-ec build.
BRANCH=None
TEST=USE="ubsan asan fuzzer" ./build_packages \
--board=amd64-generic --skip_chroot_upgrade chromeos-ec
Tested-by: Allen Webb
Trybot-Ready: Allen Webb | [
{
"change_type": "MODIFY",
"old_path": "fuzz/build.mk",
"new_path": "fuzz/build.mk",
"diff": "# fuzzer binaries\n#\n-fuzz-test-list-host = cr50_fuzz host_command_fuzz usb_pd_fuzz\n+# TODO(crbug.com/911310) Fix the chromeos-ec build before adding cr50_fuzz back.\n+fuzz-test-list-host = host_command_f... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50_fuzz: Disable this target. It is breaking the chromeos-ec build.
BRANCH=None
BUG=chromium:911310
TEST=USE="ubsan asan fuzzer" ./build_packages \
--board=amd64-generic --skip_chroot_upgrade chromeos-ec
Change-Id: I15ac87b14a0f28a62e257bb155f1862753053eb4
Reviewed-on: https://chromium-review.googlesource.com/c/1368010
Tested-by: Allen Webb <allenwebb@google.com>
Trybot-Ready: Allen Webb <allenwebb@google.com>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org> |
136,347 | 03.11.2018 01:36:18 | -19,080 | f645b4591de099c245dd8e69bdc785134fdfdb7a | core/minute-ia: Setup GDT
Setup GDT for main ISH FW
BRANCH=none
TEST=Verify that main ISH FW runs fine when loaded through host FW load flow.
Commit-Ready: Caveh Jalali | [
{
"change_type": "MODIFY",
"old_path": "core/minute-ia/init.S",
"new_path": "core/minute-ia/init.S",
"diff": "@@ -286,12 +286,38 @@ interrupt_descriptor\ninterrupt_descriptor\ninterrupt_descriptor # 255\n+__gdt:\n+ # Entry 0: Null descriptor\n+ .word 0x0000\n+ .word 0x0000\n+ .byte 0x00\n+ .byte 0x0... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | core/minute-ia: Setup GDT
Setup GDT for main ISH FW
BRANCH=none
BUG=b:120051488
TEST=Verify that main ISH FW runs fine when loaded through host FW load flow.
Change-Id: I8101de6c2482abb09ccc8fdc36321fa562e521d7
Signed-off-by: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
Signed-off-by: Sadashiva Rao Pv <sadashiva.rao.pv@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/1316700
Commit-Ready: Caveh Jalali <caveh@google.com>
Reviewed-by: Caveh Jalali <caveh@google.com> |
136,405 | 05.12.2018 09:11:40 | 28,800 | d568d960d5265b9d5f746bcc5021b9c11960a864 | Nami: Add fan min/start/max definition for Syndra
This patch adds fan RPM definitions for Syndra.
BRANCH=none
TEST=buildall
Commit-Ready: Daisuke Nojiri
Tested-by: Daisuke Nojiri | [
{
"change_type": "MODIFY",
"old_path": "board/nami/board.c",
"new_path": "board/nami/board.c",
"diff": "@@ -194,6 +194,12 @@ const struct fan_rpm fan_rpm_3 = {\n.rpm_max = 5500,\n};\n+const struct fan_rpm fan_rpm_4 = {\n+ .rpm_min = 2400,\n+ .rpm_start = 2400,\n+ .rpm_max = 4500,\n+};\n+\nstruct fan... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Nami: Add fan min/start/max definition for Syndra
This patch adds fan RPM definitions for Syndra.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=b:120113410
BRANCH=none
TEST=buildall
Change-Id: I3bbdc98713c2dd8b0ed824a8576ffb2f597240ae
Reviewed-on: https://chromium-review.googlesource.com/1363670
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,408 | 10.12.2018 10:32:41 | 28,800 | e28470f82d0b7da30db435bd451cb3beeb79aa71 | nami_fp: branching nocturne_fp to cope with variations
BRANCH=none
TEST=make BOARD=nami_fp -j | [
{
"change_type": "DELETE",
"old_path": "board/nami_fp",
"new_path": null,
"diff": "-nocturne_fp/\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/nami_fp/board.c",
"diff": "+../nocturne_fp/board.c\n\\ No newline at end of file\n"
... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nami_fp: branching nocturne_fp to cope with variations
BRANCH=none
BUG=b:117297043
TEST=make BOARD=nami_fp -j
Change-Id: I05ad15c621876185a0908ce7599578e7ebcff7df
Signed-off-by: YH Lin <yueherngl@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1369586
Reviewed-by: Shelley Chen <shchen@chromium.org> |
136,312 | 09.11.2018 13:28:01 | 28,800 | 7d03d8557bb3d99ff741478e4417c35a4ca8b8f7 | PRESUBMIT: enable kernel-doc check for include/ec_commands.h
ec_commands.h is often synced with the Linux sources, so it's nice to
sanity-check it.
CQ-DEPEND=CL:1336039
BRANCH=none
TEST=.../pre-upload.py | [
{
"change_type": "MODIFY",
"old_path": "PRESUBMIT.cfg",
"new_path": "PRESUBMIT.cfg",
"diff": "[Hook Overrides]\nbranch_check: true\ncheckpatch_check: true\n+kerneldoc_check: true\n# We are using Linux style indentation with tabs\n# The indentation is checked by checkpatch not the python script\n@@ -... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | PRESUBMIT: enable kernel-doc check for include/ec_commands.h
ec_commands.h is often synced with the Linux sources, so it's nice to
sanity-check it.
CQ-DEPEND=CL:1336039
BRANCH=none
BUG=chromium:621123
TEST=.../pre-upload.py
Change-Id: I56645e613f8689c26ddf6ded1325e270be35da8a
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1330107
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
136,436 | 10.12.2018 13:13:05 | 28,800 | c65597299e493ac5bbbc668c1fcb4d0530c0b070 | nami_fp: Update flash_fp_mcu to ekko gpios
BRANCH=None
TEST=flash_fp_mcu <bin> and make sure bin was updated with:
ectools --name=cros_fp version
Commit-Ready: Shelley Chen
Tested-by: Shelley Chen | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/nami_fp/flash_fp_mcu",
"diff": "+#!/bin/sh\n+# Copyright 2018 The Chromium OS Authors. All rights reserved.\n+# Use of this source code is governed by a BSD-style license that can be\n+# found in the LICENSE file.\n+\n+# Kabylake PCH GPIOs... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nami_fp: Update flash_fp_mcu to ekko gpios
BUG=b:119565385
BRANCH=None
TEST=flash_fp_mcu <bin> and make sure bin was updated with:
ectools --name=cros_fp version
Change-Id: I99673a3fff1e69845f0dd817ac5dfe41f4b85708
Signed-off-by: Shelley Chen <shchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1370745
Commit-Ready: Shelley Chen <shchen@chromium.org>
Tested-by: Shelley Chen <shchen@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org> |
136,405 | 06.12.2018 09:29:10 | 28,800 | 145f3271f7459f7a2fec6ba941f14c1ae00c14a6 | oz554: Move oz554 driver code to common directory
This patch moves oz554 LED driver code from Karma.
BRANCH=none
TEST=buildall
Commit-Ready: Daisuke Nojiri
Tested-by: Daisuke Nojiri | [
{
"change_type": "MODIFY",
"old_path": "baseboard/kalista/baseboard.c",
"new_path": "baseboard/kalista/baseboard.c",
"diff": "#include \"host_command.h\"\n#include \"i2c.h\"\n#include \"math_util.h\"\n+#include \"oz554.h\"\n#include \"pi3usb9281.h\"\n#include \"power.h\"\n#include \"power_button.h\"... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | oz554: Move oz554 driver code to common directory
This patch moves oz554 LED driver code from Karma.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=none
BRANCH=none
TEST=buildall
Change-Id: Ia2808563b9c113e5ea3376f9327dff2578e20906
Reviewed-on: https://chromium-review.googlesource.com/1366015
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,405 | 14.12.2018 09:18:38 | 28,800 | 8be1f0f55cdc7fcd236886ffaccade08612e19a8 | nautilus,reef_mchp: Remove board_is_ramp_allowed
board_is_ramp_allowed is replaced by chg_ramp_allowed and
no longer called.
BRANCH=none
TEST=buildall
Commit-Ready: Daisuke Nojiri
Tested-by: Daisuke Nojiri | [
{
"change_type": "MODIFY",
"old_path": "board/nautilus/board.c",
"new_path": "board/nautilus/board.c",
"diff": "@@ -527,21 +527,6 @@ void board_set_charge_limit(int port, int supplier, int charge_ma,\nCONFIG_CHARGER_INPUT_CURRENT), charge_mv);\n}\n-/**\n- * Return whether ramping is allowed for give... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nautilus,reef_mchp: Remove board_is_ramp_allowed
board_is_ramp_allowed is replaced by chg_ramp_allowed and
no longer called.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=none
BRANCH=none
TEST=buildall
Change-Id: Iedf760567b4034ce7317a0d2479eb7ee937b4680
Reviewed-on: https://chromium-review.googlesource.com/1377342
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,269 | 14.12.2018 13:34:03 | 28,800 | e1f3f89e7ea7945adddd0c2e6838f5e59856cff2 | stm32mon: Add link to SPI protocol
Also fix misspelling.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "util/stm32mon.c",
"new_path": "util/stm32mon.c",
"diff": "* found in the LICENSE file.\n*\n* STM32 SoC system monitor interface tool\n- * For Serial, implement proctol v2.0 as defined in:\n+ * For Serial, implement protocol v2.0 as defined in:\n* http://www.st... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | stm32mon: Add link to SPI protocol
Also fix misspelling.
BRANCH=none
BUG=none
TEST=make buildall -j
Change-Id: I6e17407be36abd83567a2e09ae1c2684e1bc5090
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1378907
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,347 | 03.11.2018 02:13:28 | -19,080 | e5ddc233ebc2285e3d145c6206c86c483bfbae11 | core/minute-ia: Add missing #ifdef CONFIG_FPU
Fix compilation error generated with CONFIG_FPU disabled.
BRANCH=none
TEST=Disable CONFIG_FPU and verify code compiles fine.
Reported-by: Sadashiva Rao Pv | [
{
"change_type": "MODIFY",
"old_path": "core/minute-ia/task.c",
"new_path": "core/minute-ia/task.c",
"diff": "@@ -597,9 +597,11 @@ void task_pre_init(void)\nint i, cs;\nuint32_t *stack_next = (uint32_t *)task_stacks;\n+#ifdef CONFIG_FPU\nuint8_t default_fp_ctx[] = { /*Initial FP state */\n0x7f, 0x03... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | core/minute-ia: Add missing #ifdef CONFIG_FPU
Fix compilation error generated with CONFIG_FPU disabled.
BRANCH=none
BUG=b:120051489
TEST=Disable CONFIG_FPU and verify code compiles fine.
Change-Id: I0ddfe610a33cc2bdebebed4e149afbfa92f2543a
Reported-by: Sadashiva Rao Pv <sadashiva.rao.pv@intel.com>
Signed-off-by: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/1316701
Reviewed-by: Caveh Jalali <caveh@google.com> |
136,339 | 17.12.2018 15:36:19 | -28,800 | e1d83c546f7e3dd0912a6fa9b3842a4d9ff6fc5d | Ampton: modify the led behavior when battery error
BRANCH=octopus
TEST=check the led behavior when battery error
Commit-Ready: James Chao
Tested-by: James Chao | [
{
"change_type": "MODIFY",
"old_path": "board/ampton/led.c",
"new_path": "board/ampton/led.c",
"diff": "@@ -26,8 +26,8 @@ struct led_descriptor led_bat_state_table[LED_NUM_STATES][LED_NUM_PHASES] = {\n[STATE_DISCHARGE_S3] = {{EC_LED_COLOR_AMBER, 1 * LED_ONE_SEC},\n{LED_OFF, 3 * LED_ONE_SEC} },\n[STA... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Ampton: modify the led behavior when battery error
BUG=none
BRANCH=octopus
TEST=check the led behavior when battery error
Change-Id: I9680b7011bb88e5e064f67ae3625534945b5dff7
Signed-off-by: James_Chao <james_chao@asus.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/1381597
Commit-Ready: James Chao <james_chao@asus.corp-partner.google.com>
Tested-by: James Chao <james_chao@asus.corp-partner.google.com>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,230 | 17.12.2018 11:39:25 | 28,800 | 87f2267bfa4b3688754dc19356ad9cb62259dbe4 | casta: Add flash_ec support
BRANCH=octopus
TEST=None
Commit-Ready: Philip Chen
Tested-by: Philip Chen | [
{
"change_type": "MODIFY",
"old_path": "util/flash_ec",
"new_path": "util/flash_ec",
"diff": "@@ -137,6 +137,7 @@ BOARDS_NPCX_SPI=(\nBOARDS_NPCX_INT_SPI=(\natlas\nbobba\n+ casta\nfleex\ngrunt\nmeep\n@@ -147,6 +148,7 @@ BOARDS_NPCX_INT_SPI=(\nBOARDS_NPCX_UUT=(\nbobba\n+ casta\ncheza\nfleex\ngrunt\n@@... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | casta: Add flash_ec support
BUG=b:119174492
BRANCH=octopus
TEST=None
Change-Id: I978bebd91f1098d4de799e2cceff0df6e1af3f3c
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1380712
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,305 | 17.12.2018 12:04:52 | 25,200 | 815c2463e1535eb4cf4b3e6d387d628c0ac66f2b | Octopus: correct keyboard backlight flags
Since we're allowing deep sleep on the NPCX EC in the S0 power state,
the keyboard backlight should be configured to stay on during sleep in
order to prevent it from flashing.
BRANCH=octopus
TEST=builds | [
{
"change_type": "MODIFY",
"old_path": "baseboard/octopus/variant_ec_npcx796fb.c",
"new_path": "baseboard/octopus/variant_ec_npcx796fb.c",
"diff": "#include \"i2c.h\"\n#include \"power.h\"\n#ifdef CONFIG_PWM\n+#include \"pwm.h\"\n#include \"pwm_chip.h\"\n#endif\n#include \"timer.h\"\n@@ -45,7 +46,8 ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Octopus: correct keyboard backlight flags
Since we're allowing deep sleep on the NPCX EC in the S0 power state,
the keyboard backlight should be configured to stay on during sleep in
order to prevent it from flashing.
BRANCH=octopus
BUG=None
TEST=builds
Change-Id: I1f41b9b00e2808520e773497991d389d23bf25fb
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1383195
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,238 | 14.10.2018 21:19:22 | 25,200 | 3dceabb07dc76191ca56d97ee3941a1a84d0a27a | ISH: IPC: enable IPC for HECI
enable IPC for HECI
BRANCH=none
TEST=Tested on Atlas board.
CQ-DEPEND=CL:1279363
Commit-Ready: Hyungwoo Yang
Tested-by: Hyungwoo Yang | [
{
"change_type": "MODIFY",
"old_path": "board/atlas_ish/board.h",
"new_path": "board/atlas_ish/board.h",
"diff": "#define CONFIG_I2C\n#define CONFIG_I2C_MASTER\n+/* ISH IPC */\n+#define CONFIG_ISH_IPC\n/* I2C ports */\n#define I2C_PORT_TP ISH_I2C0\n#define GPIO_I2C_PORT_TP_SCL GPIO_ISH_I2C0_SCL\n"
... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ISH: IPC: enable IPC for HECI
enable IPC for HECI
BUG=b:79676054
BRANCH=none
TEST=Tested on Atlas board.
CQ-DEPEND=CL:1279363
Change-Id: I98568b537b4b812e97c22dff610e1147ed12701d
Reviewed-on: https://chromium-review.googlesource.com/1279311
Commit-Ready: Hyungwoo Yang <hyungwoo.yang@intel.com>
Tested-by: Hyungwoo Yang <hyungwoo.yang@intel.com>
Reviewed-by: Hyungwoo Yang <hyungwoo.yang@intel.com>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,238 | 14.10.2018 21:42:04 | 25,200 | 1c9d56efdaa9d9b10df27a5c488c007e710f3544 | ISH: HECI: enable HECI
enable HECI.
BRANCH=none
TEST=Tested on Atlas board.
CQ-DEPEND=CL:1279432
Commit-Ready: Hyungwoo Yang
Tested-by: Hyungwoo Yang | [
{
"change_type": "MODIFY",
"old_path": "board/atlas_ish/board.h",
"new_path": "board/atlas_ish/board.h",
"diff": "/* ISH IPC */\n#define CONFIG_ISH_IPC\n+/* HECI */\n+#define CONFIG_HECI\n/* I2C ports */\n#define I2C_PORT_TP ISH_I2C0\n#define GPIO_I2C_PORT_TP_SCL GPIO_ISH_I2C0_SCL\n"
},
{
"c... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ISH: HECI: enable HECI
enable HECI.
BUG=b:79676054
BRANCH=none
TEST=Tested on Atlas board.
CQ-DEPEND=CL:1279432
Change-Id: I3184f822e5ad026164b86efbd4b6dabf1102db86
Reviewed-on: https://chromium-review.googlesource.com/1279313
Commit-Ready: Hyungwoo Yang <hyungwoo.yang@intel.com>
Tested-by: Hyungwoo Yang <hyungwoo.yang@intel.com>
Reviewed-by: Hyungwoo Yang <hyungwoo.yang@intel.com>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,238 | 14.10.2018 21:44:58 | 25,200 | 2b0d9e6c40ea71e0f3e66759c758c07e8879ca07 | ISH: HID: enable HID subsystem
enable HID subsystem.
BRANCH=none
TEST=Tested on Atlas board.
CQ-DEPEND=CL:1279433
Commit-Ready: Hyungwoo Yang
Tested-by: Hyungwoo Yang | [
{
"change_type": "MODIFY",
"old_path": "board/atlas_ish/board.h",
"new_path": "board/atlas_ish/board.h",
"diff": "#define CONFIG_ISH_IPC\n/* HECI */\n#define CONFIG_HECI\n+/* HID subsystem */\n+#define CONFIG_HID_SUBSYS\n+\n/* I2C ports */\n#define I2C_PORT_TP ISH_I2C0\n#define GPIO_I2C_PORT_TP_SCL ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ISH: HID: enable HID subsystem
enable HID subsystem.
BUG=b:79676054
BRANCH=none
TEST=Tested on Atlas board.
CQ-DEPEND=CL:1279433
Change-Id: I50ce44c76abe823a68745ee8114cc8f0fabbe36c
Reviewed-on: https://chromium-review.googlesource.com/1279314
Commit-Ready: Hyungwoo Yang <hyungwoo.yang@intel.com>
Tested-by: Hyungwoo Yang <hyungwoo.yang@intel.com>
Reviewed-by: Hyungwoo Yang <hyungwoo.yang@intel.com>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,391 | 28.12.2018 15:27:39 | -28,800 | b53abd8e57bcd4c643ce31822be176d8e364a0d9 | phaser: add sku 5 for Laser
Add new SKU that is also a convertible.
BRANCH=firmware-octopus-11297.B
TEST=builds
Commit-Ready: Justin TerAvest
Tested-by: Justin TerAvest | [
{
"change_type": "MODIFY",
"old_path": "board/phaser/board.c",
"new_path": "board/phaser/board.c",
"diff": "@@ -190,7 +190,8 @@ unsigned int motion_sensor_count = ARRAY_SIZE(motion_sensors);\nstatic int board_is_convertible(void)\n{\n- return sku_id == 2 || sku_id == 3 || sku_id == 4 || sku_id == 25... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | phaser: add sku 5 for Laser
Add new SKU that is also a convertible.
BRANCH=firmware-octopus-11297.B
BUG=b:121457617
TEST=builds
Change-Id: I15f2694c940796fe3869bbde87d3aa927f3e0446
Reviewed-on: https://chromium-review.googlesource.com/1392571
Commit-Ready: Justin TerAvest <teravest@chromium.org>
Tested-by: Justin TerAvest <teravest@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Justin TerAvest <teravest@chromium.org> |
136,429 | 07.01.2019 12:40:10 | 28,800 | 1d9dbd408f7d837cb2725ed0e37d775967f6bb21 | Remove fuzzer test runs from buildall.
This removes the test runs for fuzzer targets temporarily until
crbug.com/918662 is resolved.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "Makefile.rules",
"new_path": "Makefile.rules",
"diff": "@@ -271,7 +271,9 @@ $(run-test-targets): run-%: host-%\n# Fuzzing tests\nfuzz-test-targets=$(foreach t,$(fuzz-test-list-host),host-$(t))\n-run-fuzz-test-targets=$(foreach t,$(fuzz-test-list-host),run-$(t)... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Remove fuzzer test runs from buildall.
This removes the test runs for fuzzer targets temporarily until
crbug.com/918662 is resolved.
BRANCH=None
BUG=chromium:918662
TEST=make -j buildall
Change-Id: I80b9c4cd403924e41704462277da6d288796abc8
Signed-off-by: Allen Webb <allenwebb@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1399201
Reviewed-by: Manoj Gupta <manojgupta@chromium.org> |
136,285 | 02.01.2019 16:26:12 | 28,800 | c78bd78daca4d6a3f5befbfe9475eaf306e5238e | chip: stm32: clock-stm32f4: Implement rtc_set() for RTC
Implement rtc_set() function for STM32F4 chip variant
BRANCH=none
TEST=Using eval-board, use rtc set 0, observe increments | [
{
"change_type": "MODIFY",
"old_path": "chip/stm32/clock-stm32f4.c",
"new_path": "chip/stm32/clock-stm32f4.c",
"diff": "#define RTC_PREDIV_S (RTC_FREQ - 1)\n#define US_PER_RTC_TICK (1000000 / RTC_FREQ)\n-int32_t rtc_ssr_to_us(uint32_t rtcss)\n+int32_t rtcss_to_us(uint32_t rtcss)\n{\nreturn ((RTC_PRE... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | chip: stm32: clock-stm32f4: Implement rtc_set() for RTC
Implement rtc_set() function for STM32F4 chip variant
BUG=none
BRANCH=none
TEST=Using eval-board, use rtc set 0, observe increments
Change-Id: I63abe0c388b7a0ba9ed881b393ffdbcc69e6d75a
Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
Reviewed-on: https://chromium-review.googlesource.com/1401017
Reviewed-by: Philip Chen <philipchen@chromium.org> |
136,396 | 08.01.2019 15:45:48 | 28,800 | d95b1ab9e50b298d938d6bbcfe7e9ef6f68ce64a | cr50: prepare to release versions 0.3.12 and 0.4.12
BRANCH=cr50, cr50-mp
TEST=verified that new locally built image has version 0.4.12 | [
{
"change_type": "MODIFY",
"old_path": "util/signer/ec_RW-manifest-dev.json",
"new_path": "util/signer/ec_RW-manifest-dev.json",
"diff": "\"timestamp\": 0,\n\"epoch\": 0, // FWR diversification contributor, 32 bits.\n\"major\": 4, // FW2_HIK_CHAIN counter.\n- \"minor\": 11, // Mostly harmless versio... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: prepare to release versions 0.3.12 and 0.4.12
BRANCH=cr50, cr50-mp
BUG=none
TEST=verified that new locally built image has version 0.4.12
Change-Id: Ie3f8992e1c5b21a52346e79b2b2efd9a0a028908
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1401213
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,368 | 08.01.2019 09:32:08 | 28,800 | 914ea853c3ff2a79bdc7f050a1967c184c4485a3 | pd: Remove unneeded code from anx74xx.c tcpc driver
Remove unneeded mask from variable
BRANCH=none
TEST=manual
Commit-Ready: ChromeOS CL Exonerator Bot
Tested-by: Sam Hurst | [
{
"change_type": "MODIFY",
"old_path": "driver/tcpm/anx74xx.c",
"new_path": "driver/tcpm/anx74xx.c",
"diff": "@@ -854,16 +854,15 @@ static int anx74xx_tcpm_get_vbus_level(int port)\nstatic int anx74xx_tcpm_get_message_raw(int port, uint32_t *payload, int *head)\n{\n- int reg = 0, rv = EC_SUCCESS;\n-... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | pd: Remove unneeded code from anx74xx.c tcpc driver
Remove unneeded mask from variable
BUG=b:122109575
BRANCH=none
TEST=manual
Change-Id: I257233f73db4f76dc251814cde88ea38eaffef88
Signed-off-by: Sam Hurst <shurst@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1401122
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Sam Hurst <shurst@google.com>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,414 | 10.01.2019 16:03:27 | -28,800 | 9c16be4ddd6f8bb19c3cbc7db9c0a4dae877a8d6 | cr50: Fix C99 style comment in _plat__OwnerClearCallback()
BRANCH=none
TEST=build | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/tpm2/platform.c",
"new_path": "board/cr50/tpm2/platform.c",
"diff": "@@ -93,6 +93,6 @@ BOOL _plat__ShallSurviveOwnerClear(uint32_t index)\nvoid _plat__OwnerClearCallback(void)\n{\n- // Invalidate existing u2f registrations.\n+ /* Invalidate existing... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: Fix C99 style comment in _plat__OwnerClearCallback()
BUG=none
BRANCH=none
TEST=build
Change-Id: Iaaa82222ee049cfc9780f64597b1336b64049931
Signed-off-by: Louis Collard <louiscollard@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1404638
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,256 | 16.01.2019 11:44:47 | 25,200 | 3d8d85cd825db68beaa3c51714a5dd3b3a944a5f | ish: update copyright header to match style
Without this fix presubmit checks complain when touching files
BRANCH=none
TEST=no presumbit complains
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "core/minute-ia/atomic.h",
"new_path": "core/minute-ia/atomic.h",
"diff": "-/* Copyright (c) 2016 The Chromium OS Authors. All rights reserved.\n+/* Copyright 2016 The Chromium OS Authors. All rights reserved.\n* Use of this source code is governed by a BSD-sty... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: update copyright header to match style
Without this fix presubmit checks complain when touching files
BRANCH=none
BUG=none
TEST=no presumbit complains
Change-Id: I2c30865d2782642d4030bc3d922ff92212ff97e8
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1415830
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> |
136,248 | 08.05.2018 17:21:50 | 14,400 | a60d1597d9f9ececf9940c20318d1876348d8f1e | ish: add inline math functions
This change adds inline math functions:
logf(), expf(), powf(), ceilf(),
atan2f(), atanf(), sinf(), cosf(),
acosf()
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "core/minute-ia/include/math.h",
"new_path": "core/minute-ia/include/math.h",
"diff": "#ifndef __CROS_EC_MATH_H\n#define __CROS_EC_MATH_H\n+#include \"config.h\"\n+\n#ifdef CONFIG_FPU\n+\n+#define M_PI 3.14159265358979323846\n+#define M_PI_2 1.57079632679489661... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: add inline math functions
This change adds inline math functions:
logf(), expf(), powf(), ceilf(),
atan2f(), atanf(), sinf(), cosf(),
acosf()
BUG=b:120961468
BRANCH=none
TEST=none
Change-Id: I92460b332b24b6d9971ce989c0cd799111cdd239
Signed-off-by: Rong Chang <rongchang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1077709
Reviewed-by: Tai-Hsu Lin <sheckylin@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,208 | 18.01.2019 13:39:44 | -28,800 | e44b0d6c4bece12b40537bd457c3d1e040a8396d | mt_scp/ipi: Fix typo in IPI macro check.
TEST=make BOARD=kukui_scp -j
BRANCH=None
Commit-Ready: ChromeOS CL Exonerator Bot
Tested-by: Yilun Lin | [
{
"change_type": "MODIFY",
"old_path": "chip/mt_scp/ipi_chip.h",
"new_path": "chip/mt_scp/ipi_chip.h",
"diff": "@@ -69,7 +69,7 @@ extern int *ipi_wakeup_table[];\n* is_wakeup_src: Declare IPI ID as a wake-up source or not\n*/\n#define DECLARE_IPI(_id, handler, is_wakeup_src) \\\n- struct ipi_num_che... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | mt_scp/ipi: Fix typo in IPI macro check.
TEST=make BOARD=kukui_scp -j
BUG=None
BRANCH=None
Change-Id: I18cef1540fd3fe76269a16edab6c622084417c7e
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1420248
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org> |
136,256 | 18.01.2019 08:11:22 | 25,200 | 5d1fc3186a8f9b49695c7b07e0341d0e8e05a156 | cleanup/ish: update copyright header to style
(c) Copyright header is no longer the style. Update so presubmit check
stops complaining
BRANCH=none
TEST=presumbit no longer complains | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/clock.c",
"new_path": "chip/ish/clock.c",
"diff": "-/* Copyright (c) 2016 The Chromium OS Authors. All rights reserved.\n+/* Copyright 2016 The Chromium OS Authors. All rights reserved.\n* Use of this source code is governed by a BSD-style license tha... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup/ish: update copyright header to style
(c) Copyright header is no longer the style. Update so presubmit check
stops complaining
BRANCH=none
BUG=none
TEST=presumbit no longer complains
Change-Id: I0de5558467859cf0b735545161ed9d1c08e0fae4
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1422057 |
136,208 | 17.01.2019 16:02:33 | -28,800 | 48137b5c5e0a6a1f2d78a71014a7ef580c7531d3 | kukui: Remove BOARD_REV 0 GPIO configs.
We don't use P0 boards anymore, so let's remove P0 GPIO configs.
TEST=make BOARD=kukui -j
BRANCH=None
Commit-Ready: Yilun Lin
Tested-by: Yilun Lin | [
{
"change_type": "MODIFY",
"old_path": "board/kukui/board.c",
"new_path": "board/kukui/board.c",
"diff": "@@ -52,7 +52,6 @@ static void tcpc_alert_event(enum gpio_signal signal)\nschedule_deferred_pd_interrupt(0 /* port */);\n}\n-#if BOARD_REV >= 1\nstatic void hall_interrupt(enum gpio_signal signal... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui: Remove BOARD_REV 0 GPIO configs.
We don't use P0 boards anymore, so let's remove P0 GPIO configs.
TEST=make BOARD=kukui -j
BUG=b:122993147
BRANCH=None
Change-Id: I1859c4c9b182a0acee6e314e8c06fb34a3973f10
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1420246
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,208 | 18.01.2019 14:48:15 | -28,800 | 579719f073c3b526d5801a3b0cc886cc8246821f | kukui: Add BOARD_REV 2 configs.
TEST=BOOTBLOCK=... make BOARD=kukui -j flash_ec; and see AP boots.
BRANCH=None
Commit-Ready: Yilun Lin
Tested-by: Yilun Lin | [
{
"change_type": "MODIFY",
"old_path": "board/kukui/board.c",
"new_path": "board/kukui/board.c",
"diff": "@@ -68,6 +68,12 @@ static void gauge_interrupt(enum gpio_signal signal)\n/* ADC channels. Must be in the exactly same order as in enum adc_channel. */\nconst struct adc_t adc_channels[] = {\n[AD... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui: Add BOARD_REV 2 configs.
TEST=BOOTBLOCK=... make BOARD=kukui -j flash_ec; and see AP boots.
BUG=b:122993147
BRANCH=None
Change-Id: I1f76d87aa152ba3c3d7c8697140c7c4769b55d28
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1420247
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Tony Lin <tonycwlin@google.com>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,297 | 23.01.2019 09:31:00 | -32,400 | 97c2e2ef6375aadac795982ecfc6fdc31fe86b3b | casta : implement led
BRANCH=master
TEST=build, flash ec and check led. | [
{
"change_type": "MODIFY",
"old_path": "board/casta/board.h",
"new_path": "board/casta/board.h",
"diff": "#define VARIANT_OCTOPUS_NO_SENSORS\n#include \"baseboard.h\"\n+#define CONFIG_LED_COMMON\n+#define OCTOPUS_POWER_LED\n+\n/* USB PD */\n#undef CONFIG_USB_PD_VBUS_MEASURE_ADC_EACH_PORT\n#define CO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | casta : implement led
BUG=b:122489253
BRANCH=master
TEST=build, flash ec and check led.
Change-Id: I9eaa6f2763c08eaae10fba65fab18548f703e669
Signed-off-by: YongBeum Ha <ybha@samsung.com>
Reviewed-on: https://chromium-review.googlesource.com/1428499
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,418 | 24.01.2019 13:34:38 | 28,800 | 33bddd31a37375556e6b7de0f6f49be5e720741d | cheza: Fix the port argument of overcurrent event
The port should be 1.
BRANCH=none
TEST=Made port-1 overcurrent and checked the interrupt triggered and
the message showed. | [
{
"change_type": "MODIFY",
"old_path": "board/cheza/board.c",
"new_path": "board/cheza/board.c",
"diff": "@@ -129,7 +129,7 @@ static void ppc_interrupt(enum gpio_signal signal)\nstatic void usb1_oc_evt_deferred(void)\n{\n/* Only port-1 has overcurrent GPIO interrupt */\n- board_overcurrent_event(0, ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cheza: Fix the port argument of overcurrent event
The port should be 1.
BRANCH=none
BUG=b:120231371
TEST=Made port-1 overcurrent and checked the interrupt triggered and
the message showed.
Change-Id: Ib66bae7582003df5e2f797ef9eceaa9b0ad530ca
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1437399
Reviewed-by: Stephen Boyd <swboyd@chromium.org> |
136,200 | 16.01.2019 14:48:23 | -28,800 | 0c0fbbe3275b0c069cf50e71603b797633f7b0a9 | Aleena/Kasumi: Add LID sensor config in S0
Add LID sensor config in S0 for angle detection.
BRANCH=none
TEST=make buildall pass, check motion sense data update immediately. | [
{
"change_type": "MODIFY",
"old_path": "baseboard/grunt/baseboard.c",
"new_path": "baseboard/grunt/baseboard.c",
"diff": "@@ -387,6 +387,11 @@ struct motion_sensor_t motion_sensors[] = {\n.max_frequency = KX022_ACCEL_MAX_FREQ,\n.config = {\n/* EC use accel for angle detection */\n+ [SENSOR_CONFIG_EC... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Aleena/Kasumi: Add LID sensor config in S0
Add LID sensor config in S0 for angle detection.
BUG=b:123099883
BRANCH=none
TEST=make buildall pass, check motion sense data update immediately.
Change-Id: I4cdcd9db54a5bbca5cf1eb452fd5d8a6edb3b6e1
Signed-off-by: David Huang <David.Huang@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/1414712
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,256 | 23.01.2019 16:01:23 | 25,200 | 08a9627cb6a7075df1ff7e44ad4d2fa3043c1a83 | ish: add CONFIG_HECI to config.h
CONFIG_HECI is already being used, now we are adding it to config.h for
documentation purposes.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "include/config.h",
"new_path": "include/config.h",
"diff": "*/\n#undef CONFIG_LOW_POWER_S0\n+/*\n+ * Enable Host Embedded Controller Interface protocol. ISH (Intel Sensor Hub)\n+ * Uses this protocol for the basis of communication.\n+ */\n+#undef CONFIG_HECI\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: add CONFIG_HECI to config.h
CONFIG_HECI is already being used, now we are adding it to config.h for
documentation purposes.
BRANCH=none
BUG=none
TEST=none
Change-Id: I8ac351e6c0cab25619caad94d1704f096b86f1c1
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1432316
Reviewed-by: Furquan Shaikh <furquan@chromium.org> |
136,256 | 24.01.2019 10:26:35 | 25,200 | 8176b650153182fad3c828bdd19ebbcee78bad20 | ish: make unimplmented GPIOs perform no-ops
When reading or writing to an UNIMPLEMENTED gpio right now,
it would actually read or write GPIO0. Add guards to prevent
unimplemented GPIOs from interacting with hardware
BRANCH=none
TEST=build and real gpios still work | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/gpio.c",
"new_path": "chip/ish/gpio.c",
"diff": "test_mockable int gpio_get_level(enum gpio_signal signal)\n{\n- return !!(ISH_GPIO_GPLR & gpio_list[signal].mask);\n+ const struct gpio_info *g = gpio_list + signal;\n+\n+ /* Unimplemented GPIOs shouldn... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: make unimplmented GPIOs perform no-ops
When reading or writing to an UNIMPLEMENTED gpio right now,
it would actually read or write GPIO0. Add guards to prevent
unimplemented GPIOs from interacting with hardware
BRANCH=none
BUG=none
TEST=build and real gpios still work
Change-Id: If661ebe66a0b5d4fc4f69bee314c90bce0eedf11
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1435478
Reviewed-by: Furquan Shaikh <furquan@chromium.org> |
136,256 | 24.01.2019 11:14:55 | 25,200 | 9218e9d4843e9b92d52afa34ec68b2951dde2e2d | arcada: remove gpio lines for I2C
The ISH does not support putting the i2c in manual GPIO mode, so
we should leave SCL and SDA fields on i2c_port_t unset
BRANCH=none
TEST=i2c communications still works | [
{
"change_type": "MODIFY",
"old_path": "board/arcada_ish/board.c",
"new_path": "board/arcada_ish/board.c",
"diff": "/* I2C port map */\nconst struct i2c_port_t i2c_ports[] = {\n- {\"sensor\", I2C_PORT_SENSOR, 1000, GPIO_ISH_I2C0_SCL, GPIO_ISH_I2C0_SDA}\n+ {\n+ .name = \"sensor\",\n+ .port = I2C_PORT... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | arcada: remove gpio lines for I2C
The ISH does not support putting the i2c in manual GPIO mode, so
we should leave SCL and SDA fields on i2c_port_t unset
BRANCH=none
BUG=none
TEST=i2c communications still works
Change-Id: I060d41f97f09e26ceb224249b26308e56abc0da4
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1435480
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,256 | 24.01.2019 11:16:17 | 25,200 | 10033d0f9dddc4863cbc2cc49aada8d356def28a | arcada: add hall sensor input GPIO and NB_MODE out
Hook up input gpio for both hall sensors and output gpio for NB_MODE#
that goes from ISH to EC.
BRANCH=none
TEST=verified that LID_CL_NB_L toggles when moving a magnet over HALL2
sensor | [
{
"change_type": "MODIFY",
"old_path": "board/arcada_ish/gpio.inc",
"new_path": "board/arcada_ish/gpio.inc",
"diff": "* found in the LICENSE file.\n*/\n-/* We don't have a ENTERING_RW signal wired to the cr50 but common code needs\n+GPIO(NB_MODE_L, PIN(4), GPIO_OUT_HIGH)\n+GPIO(LID_CL_NB_L, PIN(5), ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | arcada: add hall sensor input GPIO and NB_MODE out
Hook up input gpio for both hall sensors and output gpio for NB_MODE#
that goes from ISH to EC.
BRANCH=none
BUG=b:120295222
TEST=verified that LID_CL_NB_L toggles when moving a magnet over HALL2
sensor
Change-Id: I17797bfda00470392d578d7427cd163653bf1a96
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1435481
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,369 | 25.01.2019 12:32:48 | 28,800 | 79aaef6a388c2e7103cc980ccce2bb9d4206fa25 | powerlog: Don't hijack logger when import as module
BRANCH=master
TEST=No log spam when import as module from autotest
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "extra/usb_power/powerlog.py",
"new_path": "extra/usb_power/powerlog.py",
"diff": "@@ -848,12 +848,14 @@ def main(argv=None):\nargs = parser.parse_args(argv)\n- root_logger = logging.getLogger()\n+ root_logger = logging.getLogger(__name__)\nif args.verbose:\nro... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | powerlog: Don't hijack logger when import as module
BRANCH=master
BUG=b:112865585,b:123259683
TEST=No log spam when import as module from autotest
Change-Id: I7ced102bbb893bc1baa88c625b8c7279a1e32677
Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1437515
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> |
136,259 | 18.12.2018 13:11:31 | 28,800 | 08114a147764a980374aa9288c1d5f0cc8c07b5d | hatch: Add vboot config options to baseboard.h
BRANCH=none
TEST=make buildall
Commit-Ready: Scott Collyer
Tested-by: Scott Collyer | [
{
"change_type": "MODIFY",
"old_path": "baseboard/hatch/baseboard.h",
"new_path": "baseboard/hatch/baseboard.h",
"diff": "#define CONFIG_SPI_FLASH_W25Q80 /* Internal SPI flash type. */\n#define CONFIG_I2C\n+/* EC Defines */\n+#define CONFIG_VBOOT_HASH\n+#define CONFIG_VSTORE\n+#define CONFIG_VSTORE_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | hatch: Add vboot config options to baseboard.h
BRANCH=none
BUG=b:122251649
TEST=make buildall
Change-Id: Iec06940c92fd430c7759c2e4ec25b7bc86344aa1
Signed-off-by: Scott Collyer <scollyer@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1387587
Commit-Ready: Scott Collyer <scollyer@chromium.org>
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> |
136,259 | 20.12.2018 12:51:59 | 28,800 | 16ce90ccf29129157d5cea0bea79dcb29367cd08 | hatch: Add support for fan and temperature sensors
BRANCH=none
TEST=make buildall
Commit-Ready: Scott Collyer
Tested-by: Scott Collyer | [
{
"change_type": "MODIFY",
"old_path": "baseboard/hatch/baseboard.h",
"new_path": "baseboard/hatch/baseboard.h",
"diff": "#define CONFIG_I2C\n/* EC Defines */\n+#define CONFIG_ADC\n#define CONFIG_PWM\n#define CONFIG_VBOOT_HASH\n#define CONFIG_VSTORE\n"
},
{
"change_type": "MODIFY",
"old_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | hatch: Add support for fan and temperature sensors
BRANCH=none
BUG=b:122251649
TEST=make buildall
Change-Id: Ib831eecb7e6df270a266f723e2fc5040b741e72f
Signed-off-by: Scott Collyer <scollyer@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1387592
Commit-Ready: Scott Collyer <scollyer@chromium.org>
Tested-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,265 | 31.01.2019 09:40:44 | -28,800 | a180facf4128a02e6fe614ba988c551593ce0611 | flapjack: Fork board.h/board.c from kukui
BRANCH=none
TEST=BOOTBLOCK=... make BOARD=flapjack -j flash_ec; and see AP boots. | [
{
"change_type": "DELETE",
"old_path": "board/flapjack/board.c",
"new_path": null,
"diff": "-../kukui/board.c\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/flapjack/board.c",
"diff": "+/* Copyright 2018 The Chromium OS Authors. A... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | flapjack: Fork board.h/board.c from kukui
BUG=none
BRANCH=none
TEST=BOOTBLOCK=... make BOARD=flapjack -j flash_ec; and see AP boots.
Change-Id: Ieea89948598e51d8d4623c9d761d8ef8e7c546b2
Signed-off-by: Kaka Ni <nigang@huaqin.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/1445956
Reviewed-by: Nick Sanders <nsanders@chromium.org> |
136,377 | 28.01.2019 16:40:14 | 28,800 | 02390c35e35108ea4474827dbe037541d3b93c76 | cr50: add board_closed_loop_reset property
BRANCH=cr50
TEST=none
Commit-Ready: Mary Ruthven
Tested-by: Mary Ruthven | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/board.c",
"new_path": "board/cr50/board.c",
"diff": "@@ -164,6 +164,11 @@ int board_uses_closed_source_set1(void)\nreturn !!(board_properties & BOARD_CLOSED_SOURCE_SET1);\n}\n+int board_uses_closed_loop_reset(void)\n+{\n+ return !!(board_properties ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: add board_closed_loop_reset property
BUG=b:123544145
BRANCH=cr50
TEST=none
Change-Id: If9b12685f7f70f0653d137bbfa15f6a6232343e0
Signed-off-by: Mary Ruthven <mruthven@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1443868
Commit-Ready: Mary Ruthven <mruthven@chromium.org>
Tested-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,377 | 28.01.2019 18:26:12 | 28,800 | 846eb6500388e81b74730b6a02d44c4ede4b9279 | cr50: add more obvious sections in gpio.inc
Change the comments so it's more obvious what the sections are in
gpio.inc
BRANCH=none
TEST=none
Commit-Ready: Mary Ruthven
Tested-by: Mary Ruthven | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/gpio.inc",
"new_path": "board/cr50/gpio.inc",
"diff": "/* Declare symbolic names for all the GPIOs that we care about.\n* Note: Those with interrupt handlers must be declared first. */\n+/*************************************************************... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: add more obvious sections in gpio.inc
Change the comments so it's more obvious what the sections are in
gpio.inc
BUG=none
BRANCH=none
TEST=none
Change-Id: I11566aa1748519df8cdc3cf9269e2a0c90c2dad9
Signed-off-by: Mary Ruthven <mruthven@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1443869
Commit-Ready: Mary Ruthven <mruthven@chromium.org>
Tested-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,339 | 30.01.2019 15:38:07 | -28,800 | be4160a3ed1e7f88432ea6552d61fad3642acf0e | ps8xxx: put the PS8751's power role to sink state
BRANCH=octopus
TEST=check the external monitor can work
Commit-Ready: James Chao
Tested-by: James Chao | [
{
"change_type": "MODIFY",
"old_path": "driver/tcpm/ps8xxx.c",
"new_path": "driver/tcpm/ps8xxx.c",
"diff": "@@ -207,6 +207,21 @@ struct i2c_stress_test_dev ps8xxx_i2c_stress_test_dev = {\n};\n#endif /* CONFIG_CMD_I2C_STRESS_TEST_TCPC */\n+static int ps8xxx_mux_init(int port)\n+{\n+ tcpci_tcpm_mux_in... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ps8xxx: put the PS8751's power role to sink state
BUG=b:123607435
BRANCH=octopus
TEST=check the external monitor can work
Change-Id: Ibe334576b907774df62865817af6ba5eb3e9d96f
Reviewed-on: https://chromium-review.googlesource.com/1445137
Commit-Ready: James Chao <james_chao@asus.corp-partner.google.com>
Tested-by: James Chao <james_chao@asus.corp-partner.google.com>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,269 | 30.01.2019 09:51:42 | 28,800 | e11ae2cfca63a900e7efff07abc112b57dce4eb2 | flash_fp_mcu: use bash per style guide and remove unused config
BRANCH=nocturne,nami
TEST=flash_fp_mcu /opt/google/biod/fw/nocturne_fp_v2.2.110-b936c0a3c.bin | [
{
"change_type": "MODIFY",
"old_path": "board/nami_fp/flash_fp_mcu",
"new_path": "board/nami_fp/flash_fp_mcu",
"diff": "-#!/bin/sh\n+#!/bin/bash\n# Copyright 2018 The Chromium OS Authors. All rights reserved.\n# Use of this source code is governed by a BSD-style license that can be\n# found in the L... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | flash_fp_mcu: use bash per style guide and remove unused config
https://www.chromium.org/chromium-os/shell-style-guidelines
BRANCH=nocturne,nami
BUG=none
TEST=flash_fp_mcu /opt/google/biod/fw/nocturne_fp_v2.2.110-b936c0a3c.bin
Change-Id: Ic95ab83bf436f3b4bb3af93cc543da07f053fd82
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1446535
Reviewed-by: Nicolas Norvez <norvez@chromium.org> |
136,265 | 29.01.2019 21:00:32 | -28,800 | e17cd2a21f2b2762597cb6346bd359f784c9b43b | flapjack/gpio: Modify GPIO configuration for Board Id 3
Modify GPIO and ADC confiturations for flapjack board_id 3 (P0B & P0C).
CQ-DEPEND=CL:1445956
BRANCH=none
TEST=BOOTBLOCK=... make BOARD=flapjack -j flash_ec; and see AP boots. | [
{
"change_type": "MODIFY",
"old_path": "board/flapjack/board.c",
"new_path": "board/flapjack/board.c",
"diff": "-/* Copyright 2018 The Chromium OS Authors. All rights reserved.\n+/* Copyright 2019 The Chromium OS Authors. All rights reserved.\n* Use of this source code is governed by a BSD-style lic... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | flapjack/gpio: Modify GPIO configuration for Board Id 3
Modify GPIO and ADC confiturations for flapjack board_id 3 (P0B & P0C).
CQ-DEPEND=CL:1445956
BUG=b:123498558
BRANCH=none
TEST=BOOTBLOCK=... make BOARD=flapjack -j flash_ec; and see AP boots.
Change-Id: Iac353c1a4ea92bd028003b6c11647965528ac30a
Signed-off-by: Kaka Ni <nigang@huaqin.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/1438957
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,396 | 01.02.2019 12:42:43 | 28,800 | 10254c179058bf3f55dc6ff6fd84efff49a73029 | Cr50: preapare to release version 0.4.13
BRANCH=cr50
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/signer/ec_RW-manifest-dev.json",
"new_path": "util/signer/ec_RW-manifest-dev.json",
"diff": "\"timestamp\": 0,\n\"epoch\": 0, // FWR diversification contributor, 32 bits.\n\"major\": 4, // FW2_HIK_CHAIN counter.\n- \"minor\": 12, // Mostly harmless versio... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Cr50: preapare to release version 0.4.13
BRANCH=cr50
BUG=none
TEST=none
Change-Id: Idd1d6fb7e7680a8c0400640b0faed6c986b0d8c1
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1450279
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,420 | 15.01.2019 17:04:48 | -3,600 | 10dc115665f8b1f3e7a61ba24505d782564712f8 | core/cortex-m: mark gcc helper function "used"
gcc injects calls to that function without notifying LTO.
BRANCH=cr50, cr50-mp
TEST=after the entire stack was applied Cr50 builds successfully with
CONFIG_LTO enabled, and passes TCG test suite. | [
{
"change_type": "MODIFY",
"old_path": "core/cortex-m/llsr.c",
"new_path": "core/cortex-m/llsr.c",
"diff": "@@ -14,7 +14,7 @@ union words {\nuint32_t w[2];\n};\n-uint64_t __aeabi_llsr(uint64_t v, uint32_t shift)\n+uint64_t __attribute__((used)) __aeabi_llsr(uint64_t v, uint32_t shift)\n{\nunion word... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | core/cortex-m: mark gcc helper function "used"
gcc injects calls to that function without notifying LTO.
BRANCH=cr50, cr50-mp
BUG=b:65253310
TEST=after the entire stack was applied Cr50 builds successfully with
CONFIG_LTO enabled, and passes TCG test suite.
Change-Id: Ie116423a2e8a394dae9d6c7c373786615d9fba4c
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1411540 |
136,405 | 05.02.2019 16:00:11 | 28,800 | 0e23368429f931b8ead7abc1ac63aa0f96f51565 | UART: Export uart_clear_input API
This patch exports the uart_clear_input API.
BRANCH=none
TEST=buildall
Commit-Ready: Daisuke Nojiri
Tested-by: Daisuke Nojiri | [
{
"change_type": "MODIFY",
"old_path": "common/uart_buffering.c",
"new_path": "common/uart_buffering.c",
"diff": "@@ -219,6 +219,14 @@ void uart_process_input(void)\nconsole_has_input();\n}\n+void uart_clear_input(void)\n+{\n+ int scratch __attribute__ ((unused));\n+ while (uart_rx_available())\n+ s... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | UART: Export uart_clear_input API
This patch exports the uart_clear_input API.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=b/119329144
BRANCH=none
TEST=buildall
Change-Id: Ib78b9dbca8ef9efb21c566888fd495b6cf313ada
Reviewed-on: https://chromium-review.googlesource.com/1454987
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
136,340 | 22.01.2019 09:08:25 | 28,800 | 2c38103382d077020d1335a7094190b493ed358b | ec_commands: Fix more warnings from check_patch.pl
Rename lid_ang lid_angle, split long lines.
BRANCH=none
TEST=Compile.
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "common/motion_lid.c",
"new_path": "common/motion_lid.c",
"diff": "@@ -149,21 +149,21 @@ __attribute__((weak)) int board_is_lid_angle_tablet_mode(void)\n* by using MOTIONSENSE_CMD_TABLET_MODE_LID_ANGLE.\n*/\n-#define DEFAULT_TABLET_MODE_ANG (180)\n+#define DEFA... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_commands: Fix more warnings from check_patch.pl
Rename lid_ang lid_angle, split long lines.
BRANCH=none
BUG=none
TEST=Compile.
Change-Id: Idab0877f77d69d8e0b099891834cb775535dd058
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1428759
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Furquan Shaikh <furquan@chromium.org> |
136,340 | 07.02.2019 11:35:21 | 28,800 | 2507a0c6b3ccbfd6c46abf128bbd099c73f50e87 | driver: bmi160: for reference, add for lis2mdl support
BRANCH=none
TEST=compile
Tested-by: Justin TerAvest | [
{
"change_type": "MODIFY",
"old_path": "driver/accelgyro_bmi160.c",
"new_path": "driver/accelgyro_bmi160.c",
"diff": "@@ -653,6 +653,11 @@ void normalize(const struct motion_sensor_t *s, intv3_t v, uint8_t *data)\nif (s->type == MOTIONSENSE_TYPE_MAG)\nbmm150_normalize(s, v, data);\nelse\n+#endif\n+#... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | driver: bmi160: for reference, add for lis2mdl support
BUG=b:110143516,b:115587004
BRANCH=none
TEST=compile
Change-Id: I72953d1c279f739e15e5d14dab2d016e0900a532
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1444094
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Tested-by: Justin TerAvest <teravest@chromium.org> |
136,405 | 07.02.2019 17:01:28 | 28,800 | 6605e420d7ef98c942a5fba3a8974296b0aecfe1 | USB-PD: Make pd_build_request return void
pd_build_request always returns EC_SUCCESS.
BRANCH=none
TEST=buildall
Commit-Ready: ChromeOS CL Exonerator Bot
Tested-by: Daisuke Nojiri | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_policy.c",
"new_path": "common/usb_pd_policy.c",
"diff": "@@ -171,7 +171,7 @@ void pd_extract_pdo_power(uint32_t pdo, uint32_t *ma, uint32_t *mv)\n*ma = MIN(max_ma, PD_MAX_CURRENT_MA);\n}\n-int pd_build_request(int port, uint32_t *rdo, uint32_t *... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | USB-PD: Make pd_build_request return void
pd_build_request always returns EC_SUCCESS.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=none
BRANCH=none
TEST=buildall
Change-Id: Iae826382134a97ba05f930245d4bfd85ebd76528
Reviewed-on: https://chromium-review.googlesource.com/1459823
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.