author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
136,427 | 04.02.2019 14:33:27 | 25,200 | 1f883987e9d71223058d7cb8771607977f3688d5 | aleena: Enable GPIO-based MKBP event notification
Send MKBP events (for sensor data) over GPIO instead of host event.
BRANCH=grunt
TEST=MKBP events still received | [
{
"change_type": "MODIFY",
"old_path": "baseboard/grunt/baseboard.h",
"new_path": "baseboard/grunt/baseboard.h",
"diff": "/* Sensors */\n#define CONFIG_MKBP_EVENT\n-#define CONFIG_MKBP_USE_HOST_EVENT\n#define CONFIG_DYNAMIC_MOTION_SENSOR_COUNT\n/* Thermal */\n"
},
{
"change_type": "MODIFY",
... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | aleena: Enable GPIO-based MKBP event notification
Send MKBP events (for sensor data) over GPIO instead of host event.
BUG=b:123750725
BRANCH=grunt
TEST=MKBP events still received
Change-Id: Ie1b02bbb8df44ade5ec6f1a4ba5dc4c5142e9f39
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1452936
Reviewed-by: Enrico Granata <egranata@chromium.org>
Reviewed-by: Raul E Rangel <rrangel@chromium.org> |
136,230 | 07.02.2019 14:56:43 | 28,800 | da43a91b5626c1db915ec5a6c5f7e1e4fbc0cdf6 | hatch: Define host battery full factor as 100%
BRANCH=none
TEST=EC console shows reasonable battery display pct
Commit-Ready: Philip Chen
Tested-by: Philip Chen | [
{
"change_type": "MODIFY",
"old_path": "baseboard/hatch/baseboard.h",
"new_path": "baseboard/hatch/baseboard.h",
"diff": "#define CONFIG_BATTERY_PRESENT_CUSTOM\n#define CONFIG_BATTERY_REVIVE_DISCONNECT\n#define CONFIG_BATTERY_SMART\n+#undef CONFIG_BATT_HOST_FULL_FACTOR\n+#define CONFIG_BATT_HOST_FUL... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | hatch: Define host battery full factor as 100%
BUG=b:123950652
BRANCH=none
TEST=EC console shows reasonable battery display pct
Change-Id: I1ef72976359f4e187e9a5f46461299b15bbcf40f
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1459819
Commit-Ready: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org> |
136,197 | 29.01.2019 08:58:13 | -28,800 | 13abae16925c01def0a177da5d853f6a416b52cf | kukui_scp: Add update_scp script to deploy to DUT
BRANCH=none
TEST=build/kukui_scp/update_scp $IP elf => see SCP restart | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/kukui_scp/update_scp",
"diff": "+#!/bin/bash\n+# Copyright 2019 The Chromium OS Authors. All rights reserved.\n+# Use of this source code is governed by a BSD-style license that can be\n+# found in the LICENSE file.\n+\n+usage() {\n+ echo ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui_scp: Add update_scp script to deploy to DUT
BRANCH=none
BUG=none
TEST=build/kukui_scp/update_scp $IP elf => see SCP restart
Change-Id: I0028f515e798601e1514bea3b520b6fb0bff2a42
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1445651
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,340 | 31.01.2019 10:04:20 | 28,800 | f1fcc752c69ac041ec8dfd4d77f8d415f0112e4d | driver: lis2dh: fix comments and include
Minor cleanup to lis2dh.
BRANCH=none
TEST=Compile | [
{
"change_type": "MODIFY",
"old_path": "driver/accel_lis2dh.c",
"new_path": "driver/accel_lis2dh.c",
"diff": "@@ -51,8 +51,10 @@ static int set_range(const struct motion_sensor_t *s, int range, int rnd)\nnormalized_range = 2;\n}\n- /* Lock accel resource to prevent another task from attempting\n- * ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | driver: lis2dh: fix comments and include
Minor cleanup to lis2dh.
BUG=none
BRANCH=none
TEST=Compile
Change-Id: Ic34eaa1cb5807bc8df8694e2d06546d60d109a7a
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1449111
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,197 | 13.02.2019 11:24:03 | -28,800 | 69e7d371ff0508740a506c9a9b52c03d35ae94cc | kukui_scp: Change default board to rev2
Also, change UART to be on GPIO 110/112 on >=rev2 (it used to be
on GPIO11/12 on rev1 with rework).
BRANCH=none
TEST=Boot kukui, load kukui_scp, see UART after rework. | [
{
"change_type": "MODIFY",
"old_path": "board/kukui_scp/board.h",
"new_path": "board/kukui_scp/board.h",
"diff": "#ifndef __CROS_EC_BOARD_H\n#define __CROS_EC_BOARD_H\n+/* board revision */\n+#define BOARD_REV 2\n+\n+#if BOARD_REV < 1 || BOARD_REV > 2\n+#error \"Board revision out of range\"\n+#endi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui_scp: Change default board to rev2
Also, change UART to be on GPIO 110/112 on >=rev2 (it used to be
on GPIO11/12 on rev1 with rework).
BRANCH=none
BUG=b:123657432
TEST=Boot kukui, load kukui_scp, see UART after rework.
Change-Id: Ieb7eef8c507008a4514e60d4f1b7f30a3f67da6b
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1469190
Reviewed-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Rong Chang <rongchang@chromium.org> |
136,256 | 07.02.2019 15:14:09 | 25,200 | d256379678ff4068f76a925074a79c738b77b4b7 | ish: print message for misconfigured GPIOs
ISH does not support level-triggered GPIOs, and we should print an
error message when we encounter this bad configuration
BRANCH=none
TEST=manually verified that print occurs | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/gpio.c",
"new_path": "chip/ish/gpio.c",
"diff": "@@ -47,6 +47,22 @@ void gpio_set_flags_by_mask(uint32_t port, uint32_t mask, uint32_t flags)\nif (port == DUMMY_GPIO_BANK)\nreturn;\n+ /* ISH does not support level-trigger interrupts; only edge. */\n+ ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: print message for misconfigured GPIOs
ISH does not support level-triggered GPIOs, and we should print an
error message when we encounter this bad configuration
BRANCH=none
BUG=none
TEST=manually verified that print occurs
Change-Id: I76d5c7bb2c70c664660a1c8fbe362fcbbde77ae6
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1460083
Reviewed-by: Nick Crews <ncrews@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,256 | 30.01.2019 10:19:16 | 25,200 | 490626600b577a07d9d21c59c45bb8a2c8ab775e | lsm6ds3: update comment for clarity
Add more comment for who am i registers since the name for st parts and
who am i register does not seem to mix well.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "driver/accelgyro_lsm6dsm.h",
"new_path": "driver/accelgyro_lsm6dsm.h",
"diff": "/* Who Am I */\n#define LSM6DSM_WHO_AM_I_REG 0x0f\n+/* LSM6DSM/LSM6DSL/LSM6DS3TR-C */\n#define LSM6DSM_WHO_AM_I 0x6a\n+/* LSM6DS3 */\n#define LSM6DS3_WHO_AM_I 0x69\n#define LSM6DSM... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | lsm6ds3: update comment for clarity
Add more comment for who am i registers since the name for st parts and
who am i register does not seem to mix well.
BRANCH=none
BUG=none
TEST=none
Change-Id: I38256c704a81984b720304d7a7499da93802d577
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1470894
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,396 | 14.02.2019 17:07:43 | 28,800 | 60e7a350f0c2052a9691442e0b44ec3363744207 | cr50: prepare to release 0.4.14
Since 0.4.13 testing discovered some issues, a new release is needed.
BRANCH=cr50, cr50-mp
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/signer/ec_RW-manifest-dev.json",
"new_path": "util/signer/ec_RW-manifest-dev.json",
"diff": "\"timestamp\": 0,\n\"epoch\": 0, // FWR diversification contributor, 32 bits.\n\"major\": 4, // FW2_HIK_CHAIN counter.\n- \"minor\": 13, // Mostly harmless versio... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: prepare to release 0.4.14
Since 0.4.13 testing discovered some issues, a new release is needed.
BRANCH=cr50, cr50-mp
BUG=b:124450448
TEST=none
Change-Id: I9b2b4e754584087c78a39d71e8d4ac50906708d9
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1474579
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,420 | 02.02.2019 09:46:51 | -3,600 | a66c36ee98fc109dc2abb4c1fcc8947dd267fcc0 | core/cortex-m*: always use coreboot-sdk
It creates smaller code.
BRANCH=none
TEST=builds with the new compiler
Commit-Ready: Patrick Georgi
Tested-by: Patrick Georgi | [
{
"change_type": "MODIFY",
"old_path": "board/kukui/build.mk",
"new_path": "board/kukui/build.mk",
"diff": "@@ -11,11 +11,6 @@ CHIP:=stm32\nCHIP_FAMILY:=stm32f0\nCHIP_VARIANT:=stm32f09x\n-# Use coreboot-sdk\n-$(call set-option,CROSS_COMPILE_arm,\\\n- $(CROSS_COMPILE_coreboot_sdk_arm),\\\n- /opt/core... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | core/cortex-m*: always use coreboot-sdk
It creates smaller code.
BUG=chromium:851727,b:65441143
BRANCH=none
TEST=builds with the new compiler
Change-Id: I569c6f75a595331fb489323d8b3f02d5dd2d5050
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1450713
Commit-Ready: Patrick Georgi <pgeorgi@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Stefan Reinauer <reinauer@chromium.org> |
136,275 | 13.02.2019 17:54:08 | -28,800 | 2f45ad6eadd33e9d872a6fa249c0b0517ef4fc15 | kukui_scp: Always use watchdog reset on reboot.
TEST=`reboot` in SCP console, and see that it triggers a watchdog reset.
BRANCH=none
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "chip/mt_scp/system.c",
"new_path": "chip/mt_scp/system.c",
"diff": "@@ -232,9 +232,10 @@ void system_reset(int flags)\n}\n}\n- /* SCB AIRCR reset */\n- CPU_NVIC_APINT = 0x05fa0004;\n- /* Spin wait for chip to reboot */\n+ /* Set watchdog timer to small value, ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui_scp: Always use watchdog reset on reboot.
BUG=b:120889996
TEST=`reboot` in SCP console, and see that it triggers a watchdog reset.
BRANCH=none
Change-Id: I4b629dc32dfd3bed8d802b211c1170ff72ee0943
Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1469853
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,256 | 07.02.2019 15:19:49 | 25,200 | 8df604fec43740653366a79f53ec6378b97255f9 | arcada_ish: add sensor and heci tasks
Add sensor configuration for LSM6DS3 and heci host command task to
transfer sensor data to AP
BRANCH=none
TEST=arcada_ish can pass sensor data through iio sysfs interface using
CL stack and under-development kernel driver | [
{
"change_type": "MODIFY",
"old_path": "board/arcada_ish/board.c",
"new_path": "board/arcada_ish/board.c",
"diff": "/* Arcada ISH board-specific configuration */\n+#include \"accelgyro_lsm6dsm.h\"\n#include \"console.h\"\n#include \"gpio.h\"\n+#include \"hooks.h\"\n#include \"host_command.h\"\n#incl... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | arcada_ish: add sensor and heci tasks
Add sensor configuration for LSM6DS3 and heci host command task to
transfer sensor data to AP
BRANCH=none
BUG=b:122281217
TEST=arcada_ish can pass sensor data through iio sysfs interface using
CL stack and under-development kernel driver
Change-Id: Ic9250f6781b8501afe99e2999940020a2437e664
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1460085 |
136,197 | 26.02.2019 10:36:04 | -28,800 | 4894e26bb9ce6ed5d01577608769caec59212e8c | kukui_scp: Let the AP setup the UART pinmux correctly
This helps make our images compatible between P1 and P2.
BRANCH=none
TEST=Flash kukui_scp on P1 and P2, UART works in both cases. | [
{
"change_type": "MODIFY",
"old_path": "board/kukui_scp/board.h",
"new_path": "board/kukui_scp/board.h",
"diff": "#ifndef __CROS_EC_BOARD_H\n#define __CROS_EC_BOARD_H\n-/* board revision */\n-#define BOARD_REV 2\n-\n-#if BOARD_REV < 1 || BOARD_REV > 2\n-#error \"Board revision out of range\"\n-#endi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui_scp: Let the AP setup the UART pinmux correctly
This helps make our images compatible between P1 and P2.
BRANCH=none
BUG=b:124341259
TEST=Flash kukui_scp on P1 and P2, UART works in both cases.
Change-Id: I8f08c37deaa4425ddf82dd6ddba18a9b60c6d147
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1488272
Reviewed-by: Yilun Lin <yllin@chromium.org> |
136,340 | 14.02.2019 10:01:42 | 28,800 | 1993ce167673bcc5971778055f26cb9dc3ec5d49 | ec_commands: Add interface for I2S support for NPCX
Add interface to allow sending I2S commands to EC.
BRANCH=none
TEST=Compile | [
{
"change_type": "MODIFY",
"old_path": "include/ec_commands.h",
"new_path": "include/ec_commands.h",
"diff": "@@ -4466,6 +4466,96 @@ enum mkbp_cec_event {\n};\n/*****************************************************************************/\n+\n+/* Commands for I2S recording on audio codec. */\n+\n+#... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_commands: Add interface for I2S support for NPCX
Add interface to allow sending I2S commands to EC.
BRANCH=none
BUG=b:116766596
TEST=Compile
Change-Id: I8caa29b3a1e1c8a13ca30c7140d5ed143d0dd8ab
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1473514
Reviewed-by: Wai-Hong Tam <waihong@google.com> |
136,412 | 21.02.2019 18:55:33 | 28,800 | bd90bed8c6670dd481f1b67a75dae03b6d284758 | stm32: spi: fix link to bug in comments
Wrong link makes it harder to find the issue at hand, fix the URL
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "chip/stm32/spi.c",
"new_path": "chip/stm32/spi.c",
"diff": "@@ -99,7 +99,7 @@ static const uint8_t out_preamble[4] = {\n* times in order to make sure it actually stays at the repeating byte after DMA\n* ends.\n*\n- * See crbug.com/31390\n+ * See crosbug.com/p/... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | stm32: spi: fix link to bug in comments
Wrong link makes it harder to find the issue at hand, fix the URL
BRANCH=none
BUG=b:35539666
TEST=none
Change-Id: I71bb069c43e540d101cdb60d6fa6f5d4e90a4d13
Signed-off-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1481661
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,412 | 21.02.2019 11:58:45 | 28,800 | 161d43aa085c5f83f58da708804425e1f4e2eaa9 | fpsensor: compilation error if RNG is not supported
FP operations require a working RNG, error if the corresponding config
hasn't been set.
TEST=make with CONFIG_RNG unset, observe failure to build
BRANCH=None | [
{
"change_type": "MODIFY",
"old_path": "common/fpsensor.c",
"new_path": "common/fpsensor.c",
"diff": "#include \"watchdog.h\"\n#if !defined(CONFIG_AES) || !defined(CONFIG_AES_GCM) || \\\n- !defined(CONFIG_ROLLBACK_SECRET_SIZE)\n-#error \"fpsensor requires AES, AES_GCM and ROLLBACK_SECRET_SIZE\"\n+ !... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | fpsensor: compilation error if RNG is not supported
FP operations require a working RNG, error if the corresponding config
hasn't been set.
BUG=b:124770147
TEST=make with CONFIG_RNG unset, observe failure to build
BRANCH=None
Change-Id: I776f9d7012fd627a16a9dea687619f1ff9077d7d
Signed-off-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1481652
Reviewed-by: Tom Hughes <tomhughes@chromium.org> |
136,339 | 27.02.2019 17:42:33 | -28,800 | 0289c0050a8e8993263769fd6bb5ccf2f5c3e3ae | Ampton: tune the gyro axis and direction
BRANCH=octopus
TEST=run the CTS verifier, check the axis and direction is correct | [
{
"change_type": "MODIFY",
"old_path": "board/ampton/board.c",
"new_path": "board/ampton/board.c",
"diff": "@@ -150,6 +150,12 @@ const mat33_fp_t base_standard_ref = {\n{ 0, 0, FLOAT_TO_FP(1)}\n};\n+const mat33_fp_t gyro_standard_ref = {\n+ { 0, FLOAT_TO_FP(-1), 0},\n+ { FLOAT_TO_FP(1), 0, 0},\n+ { ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Ampton: tune the gyro axis and direction
BUG=b:126135808
BRANCH=octopus
TEST=run the CTS verifier, check the axis and direction is correct
Change-Id: I2b6e598e07a5245b452aff8f46c425b72f30b841
Signed-off-by: James_Chao <james_chao@asus.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/1490833
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Commit-Queue: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> |
136,340 | 12.10.2018 11:09:39 | 25,200 | 99adc669fb417eee09a85a5fda5106de0a923d6a | driver: bmi160: Add setting calibration scale
Implement get_scale, set_scale and apply the scale when normalizing.
BRANCH=nocturne
TEST=Check calibscale is taken into account on bmi160. | [
{
"change_type": "MODIFY",
"old_path": "driver/accelgyro_bmi160.c",
"new_path": "driver/accelgyro_bmi160.c",
"diff": "@@ -589,6 +589,29 @@ static int set_offset(const struct motion_sensor_t *s,\nreturn ret;\n}\n+int set_scale(const struct motion_sensor_t *s,\n+ const uint16_t *scale, int16_t temp)\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | driver: bmi160: Add setting calibration scale
Implement get_scale, set_scale and apply the scale when normalizing.
BUG=b:112957338
BRANCH=nocturne
TEST=Check calibscale is taken into account on bmi160.
Change-Id: I2c72053b026fe09798cd1009e77cc36c3c4fdac2
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1279186
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Enrico Granata <egranata@chromium.org> |
136,340 | 26.12.2018 15:31:16 | 28,800 | e86281f149411a421af7b2887e14cbc38e3c43b1 | eve: Set BMI160 INT2 as output
This pin is not used, set it as output to clean FIFO messages.
BRANCH=eve
TEST=Check fifo headers.
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "board/eve/board.h",
"new_path": "board/eve/board.h",
"diff": "#define CONFIG_ACCEL_INTERRUPTS\n#define CONFIG_ACCELGYRO_BMI160_INT_EVENT TASK_EVENT_CUSTOM(4)\n#define CONFIG_ACCELGYRO_SEC_ADDR BMM150_ADDR0 /* 8-bit address */\n+#define CONFIG_ACCELGYRO_BMI160_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | eve: Set BMI160 INT2 as output
This pin is not used, set it as output to clean FIFO messages.
BUG=chromium:917868
BRANCH=eve
TEST=Check fifo headers.
Change-Id: Ib2b783ea65b1ecb56e831440367d043b86022e51
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1390939
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> |
136,340 | 19.12.2018 09:08:12 | 28,800 | 068c46513aac5ecfb06489191fad9fd60e5d750c | math: Add/expose some vector operation
Expose dot procdut and cros product for vector operations.
BRANCH=none
TEST=compile, check unit tests.
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "common/math_util.c",
"new_path": "common/math_util.c",
"diff": "@@ -148,6 +148,28 @@ int vector_magnitude(const intv3_t v)\nreturn int_sqrtf(sum);\n}\n+/* cross_product only works if the vectors magnitudes are around 1<<16. */\n+void cross_product(const intv3_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | math: Add/expose some vector operation
Expose dot procdut and cros product for vector operations.
BUG=b:120346412
BRANCH=none
TEST=compile, check unit tests.
Change-Id: Ief50f31aa6105dc2f0d92caf8b7473a7e141eb45
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1387923
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> |
136,312 | 28.02.2019 11:18:48 | 28,800 | fc519609fd1fba0e8471dde49236a1af365b1404 | I've seen these fail a few times in the last few weeks in the CQ. That
shouldn't happen.
BRANCH=none
TEST=none
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "COMMIT-QUEUE.ini",
"new_path": "COMMIT-QUEUE.ini",
"diff": "# actually test against our EC changes. (That's what FAFT is for)\npre-cq-configs: kevin-no-vmtest-pre-cq reef-no-vmtest-pre-cq\nchell-no-vmtest-pre-cq celes-no-vmtest-pre-cq\n- fizz-no-vmtest-pre-cq\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | COMMIT-QUEUE: add cheza and flapjack to pre-cq
I've seen these fail a few times in the last few weeks in the CQ. That
shouldn't happen.
BRANCH=none
BUG=none
TEST=none
Change-Id: I7ac16973ee2d11a8e5ea272f20d2ee4d9209b557
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1495396
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,256 | 28.02.2019 09:08:05 | 25,200 | f87f7e7634d157306bedf0c18317db219fc79d4a | cleanup: updating comment for ISH
ISH should stand for integrated sensor hub not Intel sensor hub
BRANCH=none
TEST=builds
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "include/ec_commands.h",
"new_path": "include/ec_commands.h",
"diff": "@@ -1342,7 +1342,7 @@ enum ec_feature_code {\nEC_FEATURE_AUDIO_CODEC = 38,\n/* EC Supports SCP. */\nEC_FEATURE_SCP = 39,\n- /* The MCU is Intel Integrated Sensor Hub */\n+ /* The MCU is an I... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: updating comment for ISH
ISH should stand for integrated sensor hub not Intel sensor hub
BRANCH=none
BUG=none
TEST=builds
Change-Id: I9e96eea8deb2d95a4d54b42b1253cb44793089a5
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1495234
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Gwendal Grignou <gwendal@google.com> |
136,396 | 01.03.2019 10:04:10 | 28,800 | 56fcb2c97fbde8b1d23c05d15ab66f3311b81a6a | .clang-format: sort included style options
This is a no-op change making it easier to look up included style
options.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": ".clang-format",
"new_path": ".clang-format",
"diff": "-BasedOnStyle: LLVM\nLanguage: Cpp\n-IndentWidth: 8\n-UseTab: Always\n-BreakBeforeBraces: Linux\nAllowShortIfStatementsOnASingleLine: false\n+BasedOnStyle: LLVM\n+BreakBeforeBraces: Linux\n+ColumnLimit: 80\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | .clang-format: sort included style options
This is a no-op change making it easier to look up included style
options.
BRANCH=none
BUG=none
TEST=none
Change-Id: I5bc1e2c436ffbfef8bd1b28acf77fc34f180f39c
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1496203
Reviewed-by: Raul E Rangel <rrangel@chromium.org> |
136,198 | 28.02.2019 16:58:48 | 28,800 | 5585cddc2907ce3aac8b899c29d550cc81141cb9 | flash_ec: remove board-to-mec1322 conversion logic
Servod already knows ec_chip of chell, glados and strago is 'mec1322'.
CQ-DEPEND=CL:1493037
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/flash_ec",
"new_path": "util/flash_ec",
"diff": "@@ -143,12 +143,6 @@ BOARDS_NRF51=(\nhadoken\n)\n-BOARDS_MEC1322=(\n- chell\n- glados\n- strago\n-)\n-\nBOARDS_SPI_1800MV=(\ncoral\nreef\n@@ -314,10 +308,6 @@ if $(in_array \"${BOARDS_NRF51[@]}\" \"${BOARD}... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | flash_ec: remove board-to-mec1322 conversion logic
Servod already knows ec_chip of chell, glados and strago is 'mec1322'.
CQ-DEPEND=CL:1493037
BUG=b:125837387
BRANCH=none
TEST=none
Change-Id: I49dba2b33aaab40b9e86354cca5b7c5f22ab59a6
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1496162
Reviewed-by: Wai-Hong Tam <waihong@google.com> |
136,377 | 20.02.2019 16:41:50 | 28,800 | b559bd558a357afd29ba4898d22374b3b2050f02 | cr50: add closed loop reset property to mistral
BRANCH=cr50
TEST=make buildall -j
Commit-Ready: Mary Ruthven
Tested-by: Mary Ruthven | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/board.c",
"new_path": "board/cr50/board.c",
"diff": "@@ -257,7 +257,8 @@ static struct board_cfg board_cfg_table[] = {\n{\n.strap_cfg = 0x0B,\n.board_properties = BOARD_SLAVE_CONFIG_SPI |\n- BOARD_USE_PLT_RESET | BOARD_NO_INA_SUPPORT,\n+ BOARD_USE_P... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: add closed loop reset property to mistral
BUG=b:123544145
BRANCH=cr50
TEST=make buildall -j
Change-Id: I39309c73957f0698b573342880a083d14077519f
Signed-off-by: Mary Ruthven <mruthven@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1480712
Commit-Ready: Mary Ruthven <mruthven@chromium.org>
Tested-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,326 | 05.03.2019 13:41:33 | 25,200 | e87f148d10a5dc52dd2895f6567e6f03b8e7ea66 | arcada_ish: Add the gyro to the motion sensor array
The gyro for the LSM6DS3 is needed to get the ACCEL_FIFO working
TEST=built and deployed to arcada device
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "board/arcada_ish/board.c",
"new_path": "board/arcada_ish/board.c",
"diff": "@@ -28,21 +28,22 @@ const struct i2c_port_t i2c_ports[] = {\nconst unsigned int i2c_ports_used = ARRAY_SIZE(i2c_ports);\n/* Sensor config */\n-static struct mutex g_base_mutex;\n+stati... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | arcada_ish: Add the gyro to the motion sensor array
The gyro for the LSM6DS3 is needed to get the ACCEL_FIFO working
BUG=b:123634700
TEST=built and deployed to arcada device
BRANCH=none
Change-Id: I164e39dec6e2b9c10e7864fbcdcae41b1bfb8eb2
Signed-off-by: Mathew King <mathewk@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1503799
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,230 | 07.03.2019 11:41:08 | 28,800 | 938805d1cc5c75631deee48e7dac2b9f6a871d03 | bq25710: Report VBUS as 0 when VBUS is too low to measure
BRANCH=none
TEST=verify VBUS measurement via 'ectool usbpdpower' | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/bq25710.c",
"new_path": "driver/charger/bq25710.c",
"diff": "@@ -324,9 +324,13 @@ int charger_get_vbus_voltage(int port)\nif (rv)\ngoto error;\n- /* LSB => 64mV */\n- return (reg >> BQ25710_ADC_VBUS_STEP_BIT_OFFSET) *\n- BQ25710_ADC_VBUS_STEP_MV... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | bq25710: Report VBUS as 0 when VBUS is too low to measure
BUG=b:124968142
BRANCH=none
TEST=verify VBUS measurement via 'ectool usbpdpower'
Change-Id: I1966537f394016706f96e975c7b54008ea8bfa33
Signed-off-by: Philip Chen <philipchen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1509176
Reviewed-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org> |
136,198 | 28.02.2019 16:47:04 | 28,800 | f294d87354b797698cd66b812b4f9656e81cce59 | flash_ec: remove board-to-nrf51 conversion logic
Servod already knows ec_chip of hadoken is 'nrf51'.
CQ-DEPEND=CL:1493037, CL:1491936
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/flash_ec",
"new_path": "util/flash_ec",
"diff": "@@ -112,10 +112,6 @@ BOARDS_NPCX_SPI=(\nglkrvp\n)\n-BOARDS_NRF51=(\n- hadoken\n-)\n-\nBOARDS_SPI_1800MV=(\ncoral\nreef\n@@ -250,10 +246,6 @@ if $(in_array \"${BOARDS_NPCX_SPI[@]}\" \"${BOARD}\"); then\nSUPP... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | flash_ec: remove board-to-nrf51 conversion logic
Servod already knows ec_chip of hadoken is 'nrf51'.
CQ-DEPEND=CL:1493037, CL:1491936
BUG=b:125837387
BRANCH=none
TEST=none
Change-Id: I96de6d1b98f6e13b99552c7c7aaf0b072371ccaf
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1496196 |
136,197 | 20.02.2019 12:54:11 | -28,800 | 6674b24ac5a1a4fe05fe5b4d2c74e9981b4304b0 | Makefiles.rules: Add rule to create static libraries (.a)
This will be useful for some targets (which will still need to fixup
the dependencies themselves).
BRANCH=none
TEST=With follow-up TEST CLs, libprivate.a can be created | [
{
"change_type": "MODIFY",
"old_path": "Makefile.rules",
"new_path": "Makefile.rules",
"diff": "@@ -91,6 +91,7 @@ cmd_c_to_host = $(HOSTCC) $(HOST_CFLAGS) $(HOST_LDFLAGS) -MMD -MF $@.d -o $@ \\\n$(sort $(foreach c,$($(*F)-objs),util/$(c:%.o=%.c)) $(wildcard $*.c))\ncmd_cxx_to_host = $(HOSTCXX) -std=... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Makefiles.rules: Add rule to create static libraries (.a)
This will be useful for some targets (which will still need to fixup
the dependencies themselves).
BRANCH=none
BUG=b:124804731
TEST=With follow-up TEST CLs, libprivate.a can be created
Change-Id: I5a1f4726794b308824275530b08f327e679eb904
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1475108 |
136,256 | 11.03.2019 10:35:17 | 21,600 | 6e539b64778deffeba0fde677e4770d46f949ea3 | clean: update vconn comment
After looking at old bug, over voltage is not part of the reason we set
Vconn on TCPC before PPC.
BRANCH=none
TEST=none
Commit-Ready: ChromeOS CL Exonerator Bot
Tested-by: Will Arthur | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_protocol.c",
"new_path": "common/usb_pd_protocol.c",
"diff": "@@ -391,8 +391,8 @@ static void set_vconn(int port, int enable)\n{\n/*\n* We always need to tell the TCPC to enable Vconn first, otherwise some\n- * TCPCs get confused and think the CC... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | clean: update vconn comment
After looking at old bug, over voltage is not part of the reason we set
Vconn on TCPC before PPC.
BRANCH=none
BUG=b:72961003
TEST=none
Change-Id: I3b52bf79dc45a6c522604092ea30d0c4538848ce
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1514856
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Will Arthur <wda@google.com> |
136,197 | 22.02.2019 15:36:51 | -28,800 | b364bd251f0d867b2796cbe9fd9160662d0f7ad3 | kukui: Enable MT6370 DB_POSVOUT/DB_NEGVOUT
BRANCH=none
TEST=Boot kukui P2, panel AVDD/AVEE looks good
Commit-Ready: ChromeOS CL Exonerator Bot
Tested-by: Nicolas Boichat | [
{
"change_type": "MODIFY",
"old_path": "board/kukui/board.c",
"new_path": "board/kukui/board.c",
"diff": "@@ -235,9 +235,15 @@ DECLARE_HOOK(HOOK_INIT, board_init, HOOK_PRIO_DEFAULT);\nstatic void board_rev_init(void)\n{\n/* Board revision specific configs. */\n- if (board_get_version() >= 2)\n+ if (... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui: Enable MT6370 DB_POSVOUT/DB_NEGVOUT
BRANCH=none
BUG=b:123669273
TEST=Boot kukui P2, panel AVDD/AVEE looks good
Change-Id: Ie9b8780fdad6e061e967ebb127b27bf63a11db2f
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1482633
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,326 | 05.03.2019 13:49:33 | 25,200 | ae9ac3459d2e76e1b424d6b0d5385bda2c4663ae | arcada_ish: Enable accel interrupts and accel fifo
TEST=Built and deployed to arcada device and tested fifo with
"ectool --name cros_ish motionsense fifo_int_enable 1"
BRANCH=none
Tested-by: Jett Rink | [
{
"change_type": "MODIFY",
"old_path": "board/arcada_ish/board.c",
"new_path": "board/arcada_ish/board.c",
"diff": "@@ -80,6 +80,14 @@ struct motion_sensor_t motion_sensors[] = {\n};\nconst unsigned int motion_sensor_count = ARRAY_SIZE(motion_sensors);\n+/* Initialize board. */\n+static void board_i... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | arcada_ish: Enable accel interrupts and accel fifo
BUG=b:123634700
TEST=Built and deployed to arcada device and tested fifo with
"ectool --name cros_ish motionsense fifo_int_enable 1"
BRANCH=none
Change-Id: I9b8110b0114003b19e8fc1c2f42d8a6a0475dc6f
Signed-off-by: Mathew King <mathewk@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1503800
Tested-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,396 | 12.03.2019 13:55:33 | 25,200 | 946bbd9a353a22a77d86af2a83d8ac5d1a66d665 | cr50: prepare to release 0.4.15
Some new features are available for release, let's create it.
BRANCH=cr50
TEST=none
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "util/signer/ec_RW-manifest-dev.json",
"new_path": "util/signer/ec_RW-manifest-dev.json",
"diff": "\"timestamp\": 0,\n\"epoch\": 0, // FWR diversification contributor, 32 bits.\n\"major\": 4, // FW2_HIK_CHAIN counter.\n- \"minor\": 14, // Mostly harmless versio... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: prepare to release 0.4.15
Some new features are available for release, let's create it.
BRANCH=cr50
BUG=none
TEST=none
Change-Id: If24ac36bd84153b9abfcea36c2c655a97c6e4312
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1519026
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,361 | 22.02.2019 10:59:05 | -28,800 | 9e9a032fa4c345d42fa23dfec7b4fe17e340951a | flapjack: separate battery.c from kukui.
Separate battery.c from kukui to prepare for submitting flapjack
battery parameters.
BRANCH=none
TEST=BOOTBLOCK=... make BOARD=flapjack -j flash_ec; and see AP boots.
Commit-Ready: YH Lin
Tested-by: YH Lin | [
{
"change_type": "DELETE",
"old_path": "board/flapjack/battery.c",
"new_path": null,
"diff": "-../kukui/battery.c\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/flapjack/battery.c",
"diff": "+/* Copyright 2018 The Chromium OS Auth... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | flapjack: separate battery.c from kukui.
Separate battery.c from kukui to prepare for submitting flapjack
battery parameters.
BUG=none
BRANCH=none
TEST=BOOTBLOCK=... make BOARD=flapjack -j flash_ec; and see AP boots.
Change-Id: I8d687276f021fe33bdeb947d38caffc0a9b9dcb2
Reviewed-on: https://chromium-review.googlesource.com/1481771
Commit-Ready: YH Lin <yueherngl@chromium.org>
Tested-by: YH Lin <yueherngl@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,408 | 12.03.2019 20:58:23 | 25,200 | 2ddd0700191c795adf0853866978a5ddd2a88327 | flapjack: get board version from CBI
With CBI in place there's no need to get the board version via
ADC strapping.
BRANCH=none
TEST=Provision CBI board version and check the board version
after reboot. | [
{
"change_type": "MODIFY",
"old_path": "board/flapjack/board.c",
"new_path": "board/flapjack/board.c",
"diff": "@@ -285,81 +285,8 @@ void board_config_pre_init(void)\n(3 << 20) | (3 << 24);\n}\n-enum kukui_board_version {\n- BOARD_VERSION_UNKNOWN = -1,\n- BOARD_VERSION_REV0 = 0,\n- BOARD_VERSION_REV... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | flapjack: get board version from CBI
With CBI in place there's no need to get the board version via
ADC strapping.
BUG=b:123676982
BRANCH=none
TEST=Provision CBI board version and check the board version
after reboot.
Change-Id: If1e5185d9d5c72b9244516141bfa68ffc1f9ad14
Signed-off-by: YH Lin <yueherngl@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1519811
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,427 | 13.03.2019 15:57:58 | 21,600 | 63c9ede6e62aa9f6ebe6a2d7dd1245b70f00c8a1 | tablet_mode: Set EC_HOST_EVENT_MODE_CHANGE in tablet_set_mode()
Move setting of EC_HOST_EVENT_MODE_CHANGE out of dptf.c so it works
on devices that don't use DPTF.
BRANCH=grunt
TEST=evtest shows tablet mode events | [
{
"change_type": "MODIFY",
"old_path": "common/dptf.c",
"new_path": "common/dptf.c",
"diff": "@@ -103,19 +103,6 @@ void dptf_set_temp_threshold(int sensor_id, int temp, int idx, int enable)\n}\n}\n-#ifdef CONFIG_TABLET_MODE\n-/*\n- * When tablet mode changes, send an event to ACPI to retrieve\n- * t... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | tablet_mode: Set EC_HOST_EVENT_MODE_CHANGE in tablet_set_mode()
Move setting of EC_HOST_EVENT_MODE_CHANGE out of dptf.c so it works
on devices that don't use DPTF.
BUG=b:124132058
BRANCH=grunt
TEST=evtest shows tablet mode events
Change-Id: Ie880dfb49838e9f564f755cb18872c9832a3aa91
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1524621
Reviewed-by: Furquan Shaikh <furquan@chromium.org> |
136,396 | 13.03.2019 16:29:44 | 25,200 | 519a9c967c2e883aebcf5ee00a23131e8e51c515 | gsctool: noop clean up
Replace C++ style comments with C style comments and alphabetize the
help output.
BRANCH=none
TEST=gsctool still builds, -h output is ordered. | [
{
"change_type": "MODIFY",
"old_path": "extra/usb_updater/gsctool.c",
"new_path": "extra/usb_updater/gsctool.c",
"diff": "@@ -547,12 +547,6 @@ static void usage(int errs)\n\" Get or set Info1 board ID fields\\n\"\n\" ID could be 32 bit hex or 4 \"\n\"character string.\\n\"\n- \" -S,--sn_bits SN_1:SN... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | gsctool: noop clean up
Replace C++ style comments with C style comments and alphabetize the
help output.
BRANCH=none
BUG=none
TEST=gsctool still builds, -h output is ordered.
Change-Id: I1a6f10873c123d61773911e97cbf32fce7447ff7
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1525147
Reviewed-by: Namyoon Woo <namyoon@chromium.org> |
136,256 | 13.03.2019 12:16:30 | 21,600 | 1765ce690f09320ca2740ada10c6bcafe4813e3a | bip: remove console commands for space
Bip flash is getting low on flash space, so remove unneeded console
commands. This gives us more than 5K free flash (3K more than before)
BRANCH=none
TEST=builds | [
{
"change_type": "MODIFY",
"old_path": "board/bip/board.h",
"new_path": "board/bip/board.h",
"diff": "#undef CONFIG_UART_TX_BUF_SIZE\n#define CONFIG_UART_TX_BUF_SIZE 4096\n+/* Remove commands to give more flash space */\n+#undef CONFIG_CMD_ADC\n+#undef CONFIG_CMD_ACCELSPOOF\n+#undef CONFIG_CMD_BATTF... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | bip: remove console commands for space
Bip flash is getting low on flash space, so remove unneeded console
commands. This gives us more than 5K free flash (3K more than before)
BRANCH=none
BUG=none
TEST=builds
Change-Id: I8f12e3264620b37e7ef60edb394682e5725ef0bc
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1520954
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,282 | 15.03.2019 18:06:32 | -28,800 | f5e3d45ffc068ef5dcb2d5c265d292b60aab9514 | bloog: Remove support for board version 0
bloog is meep follower, synchronize CL:1525064.
BRANCH=octopus
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/bloog/board.c",
"new_path": "board/bloog/board.c",
"diff": "@@ -215,18 +215,6 @@ int board_is_convertible(void)\nreturn sku_id == 255;\n}\n-static void board_update_gpio_from_board_id(uint32_t board_id)\n-{\n- if (board_id == 0) {\n- /*\n- * USB2_OTG_ID ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | bloog: Remove support for board version 0
bloog is meep follower, synchronize CL:1525064.
BUG=none
BRANCH=octopus
TEST=make buildall -j
Change-Id: I774ff552db381949e28ba46583a9b5fb23d32c7e
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/1525901
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,377 | 19.03.2019 13:20:05 | 25,200 | ca3f517b0b27e2be1e3d21cecd9958e2e5263512 | g: add board_id_is_blank
Add board_id_is_blank for checking that all fields of a board id are
0xffffffff.
BRANCH=cr50
TEST=none
Commit-Ready: Mary Ruthven
Tested-by: Mary Ruthven | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/factory_mode.c",
"new_path": "board/cr50/factory_mode.c",
"diff": "@@ -25,8 +25,7 @@ static int board_id_is_erased(void)\nreturn 0;\n}\n- /* If all of the fields are all 0xffffffff, the board id is not set */\n- if (~(id.type & id.type_inv & id.flag... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | g: add board_id_is_blank
Add board_id_is_blank for checking that all fields of a board id are
0xffffffff.
BUG=none
BRANCH=cr50
TEST=none
Change-Id: I591a3529a7f5a2aa4fcd4a7e0ec43356d0e97237
Signed-off-by: Mary Ruthven <mruthven@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1531321
Commit-Ready: Mary Ruthven <mruthven@chromium.org>
Tested-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,192 | 11.03.2019 13:13:48 | 21,600 | 51c89799e029ded73601181eabe285ccdbc86888 | console: add time stamp to EC logs
Prefix all EC log lines with the host's current time,
in YYYY-MM-DD HH:MM:SS format
BRANCH=none
TEST=manual, verify functionality while connected to console
via servod & miniterm | [
{
"change_type": "MODIFY",
"old_path": "util/ec3po/console.py",
"new_path": "util/ec3po/console.py",
"diff": "@@ -13,9 +13,10 @@ session-persistent command history.\nfrom __future__ import print_function\nimport argparse\n+import binascii\nimport copy\nimport ctypes\n-import binascii\n+from datetime... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | console: add time stamp to EC logs
Prefix all EC log lines with the host's current time,
in YYYY-MM-DD HH:MM:SS format
BUG=b:111675966
BRANCH=none
TEST=manual, verify functionality while connected to console
via servod & miniterm
Change-Id: I3ac26301e781a1992628d43c6d6add1eed0ac91f
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1515815
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,340 | 15.03.2019 10:15:46 | 25,200 | 0bfc511527cf2aebfa163c63a1d028419ca0b0c3 | common: Include compile_time_macros.h when needed
Include compile_time_macros.h to files that will use BIT macro.
BRANCH=None
TEST=unit tests. | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/registers.h",
"new_path": "chip/ish/registers.h",
"diff": "#ifndef __ASSEMBLER__\n#include \"common.h\"\n+#include \"compile_time_macros.h\"\n/* ISH GPIO has only one port */\n#define DUMMY_GPIO_BANK -1\n"
},
{
"change_type": "MODIFY",
"ol... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: Include compile_time_macros.h when needed
Include compile_time_macros.h to files that will use BIT macro.
BUG=None
BRANCH=None
TEST=unit tests.
Change-Id: I9d44f4b588620f6770f8d522d422f5dd0d237903
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1525156
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,427 | 25.03.2019 17:01:24 | 21,600 | bab8602f4c974b88a93354baeb32896242465fcd | delan: Remove board
BRANCH=grunt
TEST=none | [
{
"change_type": "DELETE",
"old_path": "board/delan/analyzestack.yaml",
"new_path": null,
"diff": "-../../baseboard/grunt/analyzestack.yaml\n\\ No newline at end of file\n"
},
{
"change_type": "DELETE",
"old_path": "board/delan/battery.c",
"new_path": null,
"diff": "-/* Copyright... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | delan: Remove board
BUG=b:121354442
BRANCH=grunt
TEST=none
Change-Id: Ia7812efa988c4dab5801be3e07ad495f3aa6bfab
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1539096
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,377 | 25.03.2019 15:11:17 | 25,200 | 05e9ae7330cfa6144cbc29c30065a58f667fd48e | cr50: add board_forcing_wp to get force wp state
A lot of places check if cr50 is forcing the wp state. Add a function
for that.
BRANCH=cr50
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/wp.c",
"new_path": "board/cr50/wp.c",
"diff": "@@ -30,6 +30,14 @@ int board_battery_is_present(void)\nreturn !gpio_get_level(GPIO_BATT_PRES_L);\n}\n+/**\n+ * Return non-zero if the wp state is being overridden.\n+ */\n+static int board_forcing_wp(vo... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: add board_forcing_wp to get force wp state
A lot of places check if cr50 is forcing the wp state. Add a function
for that.
BUG=none
BRANCH=cr50
TEST=none
Change-Id: Ie00841bd805f987817ab1dcaab740b97af770eb4
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1539008
Reviewed-by: Namyoon Woo <namyoon@chromium.org> |
136,269 | 07.03.2019 09:52:27 | 28,800 | c654f3d7df3b0b4c4729c45b6f28d251b2e57211 | flash_ec: add support for hatch_fp
Same as nocturne_fp.
BRANCH=None
TEST=manually flash over UART/servo
Commit-Ready: ChromeOS CL Exonerator Bot
Tested-by: Tom Hughes | [
{
"change_type": "MODIFY",
"old_path": "util/flash_ec",
"new_path": "util/flash_ec",
"diff": "@@ -65,6 +65,7 @@ BOARDS_STM32=(\nminimuffin\nnami_fp\nnocturne_fp\n+ hatch_fp\noak_pd\npit\nplankton\n@@ -308,7 +309,7 @@ case \"${BOARD}\" in\nchocodile_bec ) MCU=\"usbpd\" ;;\noak_pd|samus_pd|strago_pd )... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | flash_ec: add support for hatch_fp
Same as nocturne_fp.
BRANCH=None
BUG=b:124996507
TEST=manually flash over UART/servo
Change-Id: I2218a7bfd9dea5b31ec10b1738c9b26ccbd291b9
Signed-off-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1541828
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Tom Hughes <tomhughes@chromium.org> |
136,361 | 22.02.2019 17:34:07 | -28,800 | 592919bd01f8a20c16a6e2907c273b94bc9962c4 | flapjack: add ATL battery model parameters
Add detailed ATL battery information.
BRANCH=None
TEST=None
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "board/flapjack/battery.c",
"new_path": "board/flapjack/battery.c",
"diff": "-/* Copyright 2018 The Chromium OS Authors. All rights reserved.\n+/* Copyright 2019 The Chromium OS Authors. All rights reserved.\n* Use of this source code is governed by a BSD-style... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | flapjack: add ATL battery model parameters
Add detailed ATL battery information.
BUG=b:128583096
BRANCH=None
TEST=None
Change-Id: Ie790fb2f78544f91b4fb58c5da79dcfdb4a3efde
Signed-off-by: YH Lin <yueherngl@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1482634
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,412 | 21.02.2019 19:02:58 | 28,800 | 198e32b42853a507d1482766a6b8c96731038c59 | stm32: spi: fix unused variable error
Don't error out when building for STM32F412.
BRANCH=none
TEST=hatch_fp firmware builds successfully | [
{
"change_type": "MODIFY",
"old_path": "chip/stm32/spi.c",
"new_path": "chip/stm32/spi.c",
"diff": "@@ -279,7 +279,7 @@ static void reply(dma_chan_t *txdma,\n*/\nstatic void tx_status(uint8_t byte)\n{\n- stm32_spi_regs_t *spi = STM32_SPI1_REGS;\n+ stm32_spi_regs_t *spi __attribute__((unused)) = STM3... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | stm32: spi: fix unused variable error
Don't error out when building for STM32F412.
BRANCH=none
BUG=none
TEST=hatch_fp firmware builds successfully
Change-Id: I996a39a6319b7ad5bbfae7e0c7b7746e3f3a243d
Signed-off-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1482058
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,412 | 21.02.2019 12:02:15 | 28,800 | 204eb153327c59688fb430eb51471a76ecc61dee | stm32f412: add TRNG support
No need to set up the TRNG's clock, on STM32F4 it always uses the PLL's
output that is set on boot.
BRANCH=None
TEST=hatch_fp builds. STM32F412's TRNG is not used on other projects. | [
{
"change_type": "MODIFY",
"old_path": "chip/stm32/registers.h",
"new_path": "chip/stm32/registers.h",
"diff": "@@ -1375,6 +1375,7 @@ typedef volatile struct timer_ctlr timer_ctlr_t;\n#define STM32_RCC_AHB1ENR_OTGHSULPIEN BIT(30)\n#define STM32_RCC_AHB2ENR REG32(STM32_RCC_BASE + 0x34)\n+#define STM3... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | stm32f412: add TRNG support
No need to set up the TRNG's clock, on STM32F4 it always uses the PLL's
output that is set on boot.
BRANCH=None
BUG=b:124770147
TEST=hatch_fp builds. STM32F412's TRNG is not used on other projects.
Change-Id: Ie1f268137ee9a3a76cd0350e3ea5b2e85def1b76
Signed-off-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1481653
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,412 | 21.02.2019 19:11:03 | 28,800 | f3715a514e71ffdddc337d7e2635f970dda3c092 | hatch_fp: initial upload
First draft, lots of features still missing.
Dev key generated with this command:
openssl genrsa -3 -out board/hatch_fp/dev_key.pem 3072
BRANCH=none
TEST=make BOARD=hatch_fp | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/hatch_fp/board.c",
"diff": "+/* Copyright 2019 The Chromium OS Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ */\n+/* Meowth Fingerprint MCU conf... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | hatch_fp: initial upload
First draft, lots of features still missing.
Dev key generated with this command:
openssl genrsa -3 -out board/hatch_fp/dev_key.pem 3072
BRANCH=none
BUG=b:124996507
TEST=make BOARD=hatch_fp
Change-Id: I7d7f0ce6807f7db9ee67e2e9b72ba6b2a0b87591
Signed-off-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1482059
Reviewed-by: Tom Hughes <tomhughes@chromium.org> |
136,256 | 02.04.2019 08:51:04 | 21,600 | 0f06fdbcdbf422149d7f5bb9ef969fa119505fbc | arcada_ish: remove unlocked config option
The Unlocked config option doesn't really even apply to arcada, remove
as we get further along.
BRANCH=none
TEST=Flashed on to arcada without issue. | [
{
"change_type": "MODIFY",
"old_path": "board/arcada_ish/board.h",
"new_path": "board/arcada_ish/board.h",
"diff": "#ifndef __CROS_EC_BOARD_H\n#define __CROS_EC_BOARD_H\n-/*\n- * Allow dangerous commands.\n- * TODO: Remove this config before production.\n- */\n-#define CONFIG_SYSTEM_UNLOCKED\n-\n/*\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | arcada_ish: remove unlocked config option
The Unlocked config option doesn't really even apply to arcada, remove
as we get further along.
BRANCH=none
BUG=none
TEST=Flashed on to arcada without issue.
Change-Id: I1de4508a7fa7ee51f562a8806e6a1bbf13f40135
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1548504
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,305 | 29.03.2019 16:02:28 | 21,600 | 6701a4b225a928fb14ffd30ae54701c3d7a24bc8 | Casta: Add MKBP events on EC_AP_INT_ODL
Though casta isn't using sensors, the GPIO for the MKBP events is still
populated so configure and enable it.
BRANCH=octopus
TEST=builds | [
{
"change_type": "MODIFY",
"old_path": "board/casta/board.h",
"new_path": "board/casta/board.h",
"diff": "/* TODO(b/119872005): Casta: confirm thermistor parts */\n#define CONFIG_STEINHART_HART_3V3_13K7_47K_4050B\n#define CONFIG_STEINHART_HART_3V3_51K1_47K_4050B\n-#define CONFIG_MKBP_EVENT\n-#undef ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Casta: Add MKBP events on EC_AP_INT_ODL
Though casta isn't using sensors, the GPIO for the MKBP events is still
populated so configure and enable it.
BUG=None
BRANCH=octopus
TEST=builds
Change-Id: Id5efe1dd79efaeb43a94b6fcd005d5ae7078a03c
Signed-off-by: Diana Z <dzigterman@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1545084
Reviewed-by: Enrico Granata <egranata@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,377 | 27.03.2019 16:30:53 | 25,200 | 4b5cbd49cc11ad3f341c6aea9f372da1c390c0e5 | cr50: add kukui strap
BRANCH=cr50
TEST=kukui uses SPI and PLT_RST_L | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/board.c",
"new_path": "board/cr50/board.c",
"diff": "@@ -261,6 +261,12 @@ static struct board_cfg board_cfg_table[] = {\nBOARD_USE_PLT_RESET | BOARD_NO_INA_SUPPORT |\nBOARD_CLOSED_LOOP_RESET,\n},\n+ /* Kukui: DI0A9 = 5k PU, DIOA1 = 5k PU */\n+ {\n+ ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: add kukui strap
BUG=b:126476180
BRANCH=cr50
TEST=kukui uses SPI and PLT_RST_L
Change-Id: Ibeb28b1c40d07d56c0d9bb760026a01cd7a1a754
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1541693
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,331 | 03.04.2019 09:30:56 | 21,600 | 748c3872b3226b8b65ec7c16fa0b81a1e5d5517b | minute-ia: clean up comments about ISR=0 bug
According to Intel, ISR=0 is actually the intended behavior, so these
scary comments linking to buganizer can be cleaned up.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "core/minute-ia/interrupts.c",
"new_path": "core/minute-ia/interrupts.c",
"diff": "@@ -109,11 +109,9 @@ static const irq_desc_t system_irqs[] = {\n* exception_panic were pushed by the hardware when the exception was\n* called.\n*\n- * This is done since the ISR... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | minute-ia: clean up comments about ISR=0 bug
According to Intel, ISR=0 is actually the intended behavior, so these
scary comments linking to buganizer can be cleaned up.
BUG=b:28444630
BRANCH=none
TEST=make buildall -j
Change-Id: I877556f1719826cb72eee39e4d14e2c10412c7a9
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1550706
Reviewed-by: Raul E Rangel <rrangel@chromium.org> |
136,377 | 27.03.2019 18:04:18 | 25,200 | 907ccfb38f9d3d08a9888a0b44c0c3a28f1dc381 | cr50: make is_sys_rst_asserted static
BRANCH=cr50
TEST=make buildall -j
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/board.c",
"new_path": "board/cr50/board.c",
"diff": "@@ -944,7 +944,7 @@ void deassert_sys_rst(void)\ngpio_set_level(GPIO_SYS_RST_L_OUT, 1);\n}\n-int is_sys_rst_asserted(void)\n+static int is_sys_rst_asserted(void)\n{\n/*\n* SYS_RST_L is pseudo open... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: make is_sys_rst_asserted static
BUG=none
BRANCH=cr50
TEST=make buildall -j
Change-Id: Ic95e75cbfaa15103d83c78dcb9efd5b985f2f190
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1542799
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,198 | 14.01.2019 17:14:08 | 28,800 | b97918b72f1d30120f4598a58f7066d72fbd3e9c | cr50: convert functions into static
BRANCH=cr50
TEST=ran test_that suite:faft_cr50_prepvt on coral. | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/board.c",
"new_path": "board/cr50/board.c",
"diff": "@@ -639,17 +639,6 @@ static void configure_board_specific_gpios(void)\nclosed_source_set1_configure_gpios();\n}\n-void decrement_retry_counter(void)\n-{\n- uint32_t counter = GREG32(PMU, LONG_LIFE... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: convert functions into static
BUG=b:112778363
BRANCH=cr50
TEST=ran test_that suite:faft_cr50_prepvt on coral.
Change-Id: I1b3c573ee5fcb40290541f231c78bf31650c13c4
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1410482
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,280 | 09.04.2019 17:22:03 | -28,800 | 58c41ee275ec06a86c299a8355a0a456e8ad51c1 | button: fix compile error when CONFIG_LED_COMMON not defined
Compiler complains about debug_mode_blink_led defined but not used.
Fix this.
TEST=make
BRANCH=None
Commit-Ready: Ting Shen
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "common/button.c",
"new_path": "common/button.c",
"diff": "@@ -471,11 +471,13 @@ static int debug_button_pressed(int mask)\nreturn debug_button_mask() == mask;\n}\n+#ifdef CONFIG_LED_COMMON\nstatic int debug_mode_blink_led(void)\n{\nreturn ((curr_debug_state !=... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | button: fix compile error when CONFIG_LED_COMMON not defined
Compiler complains about debug_mode_blink_led defined but not used.
Fix this.
BUG=None
TEST=make
BRANCH=None
Change-Id: I6f5431d0867bc4f37bc1e74d48f4b124305d4012
Signed-off-by: Ting Shen <phoenixshen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1559100
Commit-Ready: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Yilun Lin <yllin@chromium.org> |
136,269 | 08.04.2019 15:06:42 | 25,200 | c10784e1fe9e93b392d4a1c8c108de11fbbb27b3 | hatch_fp: Fix slave select (NSS / CS) pin management
BRANCH=none
TEST=Read HWID from fingerprint sensor (slave) on hatch_fp | [
{
"change_type": "MODIFY",
"old_path": "board/hatch_fp/gpio.inc",
"new_path": "board/hatch_fp/gpio.inc",
"diff": "@@ -27,5 +27,10 @@ UNIMPLEMENTED(ENTERING_RW)\nALTERNATE(PIN_MASK(A, 0x0600), GPIO_ALT_USART, MODULE_UART, GPIO_PULL_UP)\n/* SPI1 slave from the AP: PA4/5/6/7 */\nALTERNATE(PIN_MASK(A, 0... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | hatch_fp: Fix slave select (NSS / CS) pin management
BRANCH=none
BUG=b:124996507
TEST=Read HWID from fingerprint sensor (slave) on hatch_fp
Change-Id: I344d7e4a5afec1f7c23f45aca593159ba67e89ed
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1558937
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,198 | 05.04.2019 13:56:15 | 25,200 | 985924cb008d94e811a1adf15a311e41ca9992e6 | iteflash.md: revised the steps in 'Prerequisites for CR50 CCD'
BRANCH=none
TEST=checked the document through Gitiles. | [
{
"change_type": "MODIFY",
"old_path": "util/iteflash.md",
"new_path": "util/iteflash.md",
"diff": "@@ -44,13 +44,13 @@ CR50 pre-PVT minimum firmware version: `0.4.15`\nGooglers, to upgrade CR50 firmware if needed see [How to use CCD on CR50](https://docs.google.com/document/d/1MqDAoBsmGTmrFi-WNOoC5... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | iteflash.md: revised the steps in 'Prerequisites for CR50 CCD'
BRANCH=none
BUG=b:124388894
TEST=checked the document through Gitiles.
Change-Id: I11fe46a8900ec59edee799157358698e4c0e1cc6
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1555026
Reviewed-by: Matthew Blecker <matthewb@chromium.org> |
136,275 | 10.04.2019 15:18:51 | -28,800 | 53d417b1afd56926ecf19b76fe9e6fb440ca5e0a | kukui: scp: Make comment for EC_FEATURE_SCP better.
Since SCP is not a feature that EC can "support", change the wording of
the comment to explain better.
BRANCH=None
TEST=None
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "include/ec_commands.h",
"new_path": "include/ec_commands.h",
"diff": "@@ -1340,7 +1340,7 @@ enum ec_feature_code {\nEC_FEATURE_REFINED_TABLET_MODE_HYSTERESIS = 37,\n/* EC supports audio codec. */\nEC_FEATURE_AUDIO_CODEC = 38,\n- /* EC Supports SCP. */\n+ /* Th... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui: scp: Make comment for EC_FEATURE_SCP better.
Since SCP is not a feature that EC can "support", change the wording of
the comment to explain better.
BUG=None
BRANCH=None
TEST=None
Change-Id: I77ad7df0235b6e034047831c602c3017647f2870
Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1560933
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> |
136,192 | 16.04.2019 10:17:32 | 21,600 | d361522205dd30c9aecab31c5a426cef019bfbd1 | kohaku: Get rid of fan configuration.
Initial implementation was copied from hatch, but Kohaku has no fan.
BRANCH=none
TEST=compiles. | [
{
"change_type": "MODIFY",
"old_path": "board/kohaku/board.c",
"new_path": "board/kohaku/board.c",
"diff": "#include \"driver/tcpm/tcpci.h\"\n#include \"ec_commands.h\"\n#include \"extpower.h\"\n-#include \"fan.h\"\n-#include \"fan_chip.h\"\n#include \"gpio.h\"\n#include \"hooks.h\"\n#include \"host... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kohaku: Get rid of fan configuration.
Initial implementation was copied from hatch, but Kohaku has no fan.
BUG=b:130577450
BRANCH=none
TEST=compiles.
Change-Id: Icbbf4419000938f07613cb4b32f4e82166741e17
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1568763
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> |
136,282 | 22.03.2019 13:38:59 | -28,800 | 16352fb45becc2d37238a9bc1c24439d2a7245cf | bloog: add support keyboard backlight
BRANCH=octopus
TEST=make buildall -j, make sure ec console kbkight
can adjust keyboard backlight brightness.
Commit-Ready: Marco Chen | [
{
"change_type": "MODIFY",
"old_path": "board/bloog/board.h",
"new_path": "board/bloog/board.h",
"diff": "#define CONFIG_LID_ANGLE_UPDATE\n#define CONFIG_LID_ANGLE_SENSOR_BASE BASE_ACCEL\n#define CONFIG_LID_ANGLE_SENSOR_LID LID_ACCEL\n-\n+#define CONFIG_PWM\n+#define CONFIG_PWM_KBLIGHT\n#define CONF... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | bloog: add support keyboard backlight
BUG=b:130142249
BRANCH=octopus
TEST=make buildall -j, make sure ec console kbkight
can adjust keyboard backlight brightness.
Change-Id: I635372efe0b92ff3765de83d9adfe953accd96a1
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/1535084
Commit-Ready: Marco Chen <marcochen@chromium.org>
Reviewed-by: Marco Chen <marcochen@chromium.org> |
136,256 | 11.04.2019 10:26:46 | 21,600 | 8fce0a9a7d19f040feaec666c58b2c0871db7fc9 | ish: move register definitions to register.h
Move bit field definitions to register.h close to their register
location definition.
BRANCH=none
TEST=arcada communication still works
Commit-Ready: Jack Rosenthal | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/ipc_heci.c",
"new_path": "chip/ish/ipc_heci.c",
"diff": "#define MNG_SYNC_FW_CLOCK 5\n#define MNG_ILLEGAL_CMD 0xFF\n-/* Peripheral Interrupt Satus Register */\n-#define IPC_PISR_HOST2ISH_BIT BIT(0)\n-#define IPC_PISR_PMC2ISH_BIT BIT(1)\n-#define IPC_P... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: move register definitions to register.h
Move bit field definitions to register.h close to their register
location definition.
BRANCH=none
BUG=none
TEST=arcada communication still works
Change-Id: I6dfacc24f43a9b8ff490a98c3e231f06f55a1dc6
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1564376
Commit-Ready: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,412 | 18.04.2019 12:44:14 | 25,200 | 16b6098577e6f986b89ac8ae668f022d6a9cb883 | hatch_fp: fix memory mapping of FP buffers
On STM32F412 the buffers are located in the regular SRAM, don't define a
special section.
BRANCH=None
TEST=fpenroll+fpmatch | [
{
"change_type": "MODIFY",
"old_path": "board/hatch_fp/board.h",
"new_path": "board/hatch_fp/board.h",
"diff": "* (shared_mem_init done too late).\n*/\n#define CONFIG_MALLOC\n-/* Special memory regions to store large arrays */\n-#define FP_FRAME_SECTION __SECTION(ahb4)\n-#define FP_TEMPLATE_SECTION ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | hatch_fp: fix memory mapping of FP buffers
On STM32F412 the buffers are located in the regular SRAM, don't define a
special section.
BRANCH=None
BUG=b:124773209
BUG=b:124996507
TEST=fpenroll+fpmatch
Change-Id: I8659e4587973c4e30c891084691b28326346e1d7
Signed-off-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1574658
Reviewed-by: Tom Hughes <tomhughes@chromium.org> |
136,356 | 16.04.2019 17:29:25 | -28,800 | acee1d6dfe2d74af7e7f4e62cfb97bd4c0003364 | Bobba: Add new battery for Driod
new battery: LGC KT0030G020
BRANCH=octopus
TEST=shipping mode and charge parameters are all good.
Commit-Ready: Marco Chen
Tested-by: Marco Chen | [
{
"change_type": "MODIFY",
"old_path": "board/bobba/battery.c",
"new_path": "board/bobba/battery.c",
"diff": "@@ -205,6 +205,35 @@ const struct board_batt_params board_battery_info[] = {\n.discharging_max_c = 75,\n},\n},\n+\n+ /* LGC AP18C8K Battery Information */\n+ [BATTERY_LGC_AP18C8K] = {\n+ .fu... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Bobba: Add new battery for Driod
new battery: LGC KT0030G020
BUG=b:130608940
BRANCH=octopus
TEST=shipping mode and charge parameters are all good.
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Change-Id: Ia07c10f12334412558565e3c0262f0503a45ab29
Reviewed-on: https://chromium-review.googlesource.com/1569089
Commit-Ready: Marco Chen <marcochen@chromium.org>
Tested-by: Marco Chen <marcochen@chromium.org>
Reviewed-by: Marco Chen <marcochen@chromium.org> |
136,248 | 25.03.2019 16:22:41 | -28,800 | b1cc0bc684ad2377716f2ebc11b9f0a9484fa52a | kukui: scp: move CPU clock selection to clock module
CPU clock management should be in clock module.
BRANCH=none
TEST=manual
build and load on kukui, check SCP console command:
> rw 0x405C4000
read 0x405c4000 = 0x00000803 | [
{
"change_type": "MODIFY",
"old_path": "chip/mt_scp/clock.c",
"new_path": "chip/mt_scp/clock.c",
"diff": "@@ -134,6 +134,9 @@ void scp_clock_high_enable(int osc)\nvoid scp_enable_clock(void)\n{\n+ /* Select default CPU clock */\n+ SCP_CLK_SEL = CLK_SEL_SYS_26M;\n+\n/* VREQ */\nSCP_CPU_VREQ = 0x10001... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui: scp: move CPU clock selection to clock module
CPU clock management should be in clock module.
BUG=b:120169529
BRANCH=none
TEST=manual
build and load on kukui, check SCP console command:
> rw 0x405C4000
read 0x405c4000 = 0x00000803
Change-Id: Ic13e9a51cf682af33799b713849fd3a445e6cfdb
Signed-off-by: Rong Chang <rongchang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1538097
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,331 | 22.04.2019 13:11:49 | 21,600 | 3fc3edd0d8f4a445965c4a936db02b03d37bc215 | minute-ia: remove divzero console command
I had forgotten to remove this from testing the panic handler. This is
a duplicate command of "crash divzero" and should be removed.
BRANCH=none
TEST=divzero console command is gone on arcada | [
{
"change_type": "MODIFY",
"old_path": "core/minute-ia/panic.c",
"new_path": "core/minute-ia/panic.c",
"diff": "@@ -127,16 +127,6 @@ __attribute__ ((noreturn)) void __keep exception_panic(\ncontinue;\n}\n-static int command_divzero(int argc, char **argv)\n-{\n- volatile int x = 0;\n-\n- x = 1 / x;\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | minute-ia: remove divzero console command
I had forgotten to remove this from testing the panic handler. This is
a duplicate command of "crash divzero" and should be removed.
BUG=b:126691187
BRANCH=none
TEST=divzero console command is gone on arcada
Change-Id: Id37d3f3749bd4228045cca93a38315ee9c94b2e9
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1576837
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,331 | 15.04.2019 11:14:41 | 21,600 | d2ac74c21848c1cec16d5e72d28f93eb15c5d869 | ish: refactor bit-mask constants to use BIT macro
We should be using the BIT(n) macro rather than (1 << n), as it
prevents errors, and makes the intended purpose a little bit easier to
read.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/aontaskfw/ish_aontask.c",
"new_path": "chip/ish/aontaskfw/ish_aontask.c",
"diff": "@@ -483,7 +483,8 @@ static void sram_power(int on)\nstatic void handle_d0i2(void)\n{\n/* set main SRAM into retention mode*/\n- PMU_LDO_CTRL = PMU_LDO_BIT_RETENTION_ON ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: refactor bit-mask constants to use BIT macro
We should be using the BIT(n) macro rather than (1 << n), as it
prevents errors, and makes the intended purpose a little bit easier to
read.
BRANCH=none
BUG=none
TEST=make buildall -j
Change-Id: Ia727ac2f8e5abfb852ba78d5cba19d7c8af72839
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1567688
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,377 | 25.04.2019 12:39:37 | 25,200 | e941ef3c409a000bbd4a388166cdd80ef71211c2 | cr50: update version to .16
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/signer/ec_RW-manifest-dev.json",
"new_path": "util/signer/ec_RW-manifest-dev.json",
"diff": "\"timestamp\": 0,\n\"epoch\": 0, // FWR diversification contributor, 32 bits.\n\"major\": 4, // FW2_HIK_CHAIN counter.\n- \"minor\": 15, // Mostly harmless versio... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: update version to .16
BRANCH=none
BUG=none
TEST=none
Change-Id: I873b50ebd73c0edd16c278b1fa825378e693d18d
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1584589
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,377 | 26.04.2019 17:00:27 | 25,200 | 0ef5ba062fb1aca3236b6a12cb58248cba16b729 | console: add support for disabling timestamps
People may want to disable timestamps. Add a command to do that.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/ec3po/console.py",
"new_path": "util/ec3po/console.py",
"diff": "@@ -177,6 +177,7 @@ class Console(object):\nself.receiving_oobm_cmd = False\nself.pending_oobm_cmd = ''\nself.interrogation_mode = 'auto'\n+ self.timestamp_enabled = True\nself.look_buffer =... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | console: add support for disabling timestamps
People may want to disable timestamps. Add a command to do that.
BUG=none
BRANCH=none
TEST=none
Change-Id: I702c41a214367b6c58f3d9b932310e1bb7e08b95
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1586588
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> |
136,396 | 29.04.2019 17:09:19 | 25,200 | 262ded1e01a374537e56160811bdad5763b311a5 | nvmem: add logging and restart on app_cipher failures
Just in case there is a failure when encrypting or decrypting NVMEM
objects, add code which detects problems, reports them in the flash
log and reboots.
BRANCH=cr50, cr50-mp
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "common/new_nvmem.c",
"new_path": "common/new_nvmem.c",
"diff": "@@ -337,6 +337,7 @@ static void report_failure(struct nvmem_failure_payload *payload,\noffsetof(struct nvmem_failure_payload, size),\npayload);\nccprintf(\"Logging failure %d\\n\", payload->failur... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nvmem: add logging and restart on app_cipher failures
Just in case there is a failure when encrypting or decrypting NVMEM
objects, add code which detects problems, reports them in the flash
log and reboots.
BRANCH=cr50, cr50-mp
BUG=b:69907320, b:129710256
TEST=none
Change-Id: I22e55941f459b5b45bf4b23781b20601a56b40d8
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1590042
Reviewed-by: Andrey Pronin <apronin@chromium.org> |
136,396 | 30.04.2019 10:33:47 | 25,200 | 15bd8639ef6df248b4474808bd21d80b0c19bac4 | nvmem: add test of recovery from interrupted saves
Add a test which introduces corrupted objects in the flash and
verifies that the initialization function is able to recover.
BRANCH=cr50, cr50-mp
TEST='make run-nvmem' succeeds | [
{
"change_type": "MODIFY",
"old_path": "common/new_nvmem.c",
"new_path": "common/new_nvmem.c",
"diff": "@@ -944,6 +944,11 @@ static enum ec_error_list save_object(const struct nn_container *cont)\nsize_t save_size = aligned_container_size(cont);\nsize_t top_room;\n+#if defined(NVMEM_TEST_BUILD)\n+ i... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nvmem: add test of recovery from interrupted saves
Add a test which introduces corrupted objects in the flash and
verifies that the initialization function is able to recover.
BRANCH=cr50, cr50-mp
BUG=b:69907320, b:129710256
TEST='make run-nvmem' succeeds
Change-Id: Ibb7d8181dfdeb097b79087cdae824564ec28921f
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1590044
Reviewed-by: Andrey Pronin <apronin@chromium.org> |
136,208 | 30.04.2019 14:28:07 | -28,800 | 5e3a5bf39077ea2856d599a7ea7c4643fd5d4acc | krane: Fix g-sensor reference point.
bmi160 on krane rev3 is rotated.
TEST=sysjump rw; boot into UI and see UI rotates accordingly.
BRANCH=None
Commit-Ready: Yilun Lin
Tested-by: Yilun Lin | [
{
"change_type": "MODIFY",
"old_path": "board/kukui/board.c",
"new_path": "board/kukui/board.c",
"diff": "@@ -356,6 +356,15 @@ static struct mutex g_lid_mutex;\nstatic struct bmi160_drv_data_t g_bmi160_data;\n+#ifdef BOARD_KRANE\n+/* Matrix to rotate accelerometer into standard reference frame */\n+... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | krane: Fix g-sensor reference point.
bmi160 on krane rev3 is rotated.
TEST=sysjump rw; boot into UI and see UI rotates accordingly.
BUG=b:131081336
BRANCH=None
Change-Id: I715bc80a2b9c1c69d4347cc326254c032c3d4b4e
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1588298
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,331 | 23.04.2019 09:32:15 | 21,600 | 2487d2012337b19e1c409c1ab5c7f763ec40b5b8 | ish: refactor IPC usage of REG macros into registers.h
This is the final CL needed to resolve b:130573158.
BRANCH=none
TEST=arcada_ish functions as normal after changes | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/aontaskfw/ish_aontask.c",
"new_path": "chip/ish/aontaskfw/ish_aontask.c",
"diff": "@@ -541,7 +541,7 @@ static void handle_d3(void)\nstatic void handle_reset(int pm_state)\n{\n/* disable CSME CSR irq */\n- REG32(IPC_PIMR) &= ~IPC_PIMR_CSME_CSR_BIT;\n+ ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: refactor IPC usage of REG macros into registers.h
This is the final CL needed to resolve b:130573158.
BUG=b:130573158
BRANCH=none
TEST=arcada_ish functions as normal after changes
Change-Id: Ia4cc9bfa95938b9f57fc1cd241cd6821b42a3ce6
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1578435
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,208 | 02.05.2019 17:43:27 | -28,800 | c6d364fad069ac4ba321724f0f40ae3b0bd392ed | krane: Fix DP AUX mux polarity is reversed.
Krane's rev3 DP AUX mux polarity is reversed, and this is a
workaround to fix the issue.
TEST=make BOARD=krane
BRANCH=None
Commit-Ready: Yilun Lin
Tested-by: Yilun Lin | [
{
"change_type": "MODIFY",
"old_path": "board/kukui/usb_pd_policy.c",
"new_path": "board/kukui/usb_pd_policy.c",
"diff": "@@ -52,6 +52,17 @@ void pd_transition_voltage(int idx)\n{\n/* No-operation: we are always 5V */\n}\n+\n+static int board_get_polarity(int port)\n+{\n+#ifdef BOARD_KRANE\n+ /* Kra... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | krane: Fix DP AUX mux polarity is reversed.
Krane's rev3 DP AUX mux polarity is reversed, and this is a
workaround to fix the issue.
TEST=make BOARD=krane
BUG=b:131130013
BRANCH=None
Change-Id: Ie6f3a84fac6bc09d6d588b0e413a9efc29b039fc
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1593194
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,198 | 17.04.2019 12:54:48 | 25,200 | 8e8dd8a8e4a0556b67f2ceed6b0fe1547989d924 | cr50: add buffer_units_mask member into struct queue
"q->buffer_units - 1" is performed many times to wrap head and/or
tail. It should be calculated once.
BRANCH=cr50
TEST=None | [
{
"change_type": "MODIFY",
"old_path": "common/queue.c",
"new_path": "common/queue.c",
"diff": "@@ -70,8 +70,8 @@ int queue_is_full(struct queue const *q)\nstruct queue_chunk queue_get_write_chunk(struct queue const *q)\n{\n- size_t head = q->state->head & (q->buffer_units - 1);\n- size_t tail = q->... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: add buffer_units_mask member into struct queue
"q->buffer_units - 1" is performed many times to wrap head and/or
tail. It should be calculated once.
BUG=None
BRANCH=cr50
TEST=None
Change-Id: I9714147d5a97afd7aaba00d31a8b10bad50d0942
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1572444
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,256 | 03.05.2019 08:59:27 | 21,600 | a87deb3376ca76e76c734f3204a776e828011b5b | ish/heci: print protocol for discarded msgs
Print the protocol id of discarded messages on console
BRANCH=none
TEST=verified that protocol is being printed correctly | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/ipc_heci.c",
"new_path": "chip/ish/ipc_heci.c",
"diff": "@@ -378,7 +378,7 @@ static void handle_msg_recv_interrupt(const uint32_t peer_id)\ntask_set_event(ctx->msg_events[protocol].task_id,\nctx->msg_events[protocol].event, 0);\n} else {\n- CPRINTS(\"... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish/heci: print protocol for discarded msgs
Print the protocol id of discarded messages on console
BRANCH=none
BUG=none
TEST=verified that protocol is being printed correctly
Change-Id: I089ad0c55b89a321edcbf24f25ec13e13fda60b3
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1594109 |
136,314 | 27.03.2019 13:51:48 | 25,200 | b29e540a282f8cf74ec1a38ebf8d10599cb8bed4 | common: add new MOTIONSENSE_TYPE_LIGHT_RGB sensor type
Add a new light sensor type for color light sensors.
BRANCH=master
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "include/ec_commands.h",
"new_path": "include/ec_commands.h",
"diff": "@@ -2408,6 +2408,7 @@ enum motionsensor_type {\nMOTIONSENSE_TYPE_ACTIVITY = 5,\nMOTIONSENSE_TYPE_BARO = 6,\nMOTIONSENSE_TYPE_SYNC = 7,\n+ MOTIONSENSE_TYPE_LIGHT_RGB = 8,\nMOTIONSENSE_TYPE_MA... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: add new MOTIONSENSE_TYPE_LIGHT_RGB sensor type
Add a new light sensor type for color light sensors.
BUG=b:129419982
BRANCH=master
TEST=none
Change-Id: I30cec56761b1f7f90544dda52a90415d39ded337
Signed-off-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1541953
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org> |
136,314 | 27.03.2019 13:55:46 | 25,200 | a7da582b929db5bc80f270e94ba637a04dd6442c | common: add MOTIONSENSE_CHIP_TCS3400
Add new chip definition for AMS TCS3400 light sensor.
BRANCH=master
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "include/ec_commands.h",
"new_path": "include/ec_commands.h",
"diff": "@@ -2442,6 +2442,7 @@ enum motionsensor_chip {\nMOTIONSENSE_CHIP_LSM6DS3 = 17,\nMOTIONSENSE_CHIP_LSM6DSO = 18,\nMOTIONSENSE_CHIP_LNG2DM = 19,\n+ MOTIONSENSE_CHIP_TCS3400 = 20,\nMOTIONSENSE_C... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: add MOTIONSENSE_CHIP_TCS3400
Add new chip definition for AMS TCS3400 light sensor.
BUG=b:129419982
BRANCH=master
TEST=none
Change-Id: Ic66a0922f3c48775f2eaeff0c5ac37a09624a5d6
Signed-off-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1541954
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org> |
136,405 | 02.05.2019 13:26:45 | 25,200 | 6ecb75abf26b4d4447cba78df3153c1b1f6662f2 | Flapjack: Add Sunwoda batteries
This patch adds Sunwoda batteries.
BRANCH=none
TEST=make BOARD=flapjack
Commit-Ready: Daisuke Nojiri
Tested-by: Daisuke Nojiri | [
{
"change_type": "MODIFY",
"old_path": "board/flapjack/battery.c",
"new_path": "board/flapjack/battery.c",
"diff": "#define BATTERY_ATL_CHARGE_MIN_TEMP 0\n#define BATTERY_ATL_CHARGE_MAX_TEMP 60\n+#define BATTERY_SUNWODA_CHARGE_MIN_TEMP 0\n+#define BATTERY_SUNWODA_CHARGE_MAX_TEMP 60\n+\nstatic const ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Flapjack: Add Sunwoda batteries
This patch adds Sunwoda batteries.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=b:130804959
BRANCH=none
TEST=make BOARD=flapjack
Change-Id: Iada9b3248b34315c687ab64b3331ca596f0ef956
Reviewed-on: https://chromium-review.googlesource.com/1593750
Commit-Ready: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: YH Lin <yueherngl@chromium.org> |
136,331 | 06.05.2019 12:57:51 | 21,600 | 9e7244a6c5f436a4f431636d7f16fe5c93335c46 | ish: remove erroneous REG32 in ish_fwsts.h
I'm a screw-up and forgot this in CL:1578435. Since
ish_fwst_is_hup_set is not used (yet), this did not cause any issues.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/ish_fwst.h",
"new_path": "chip/ish/ish_fwst.h",
"diff": "@@ -141,7 +141,7 @@ static inline int ish_fwst_is_hup_set(void)\n/* set fw failure reason */\nstatic inline void ish_fwst_set_fail_reason(uint32_t val)\n{\n- uint32_t fwst = REG32(IPC_ISH_FWSTS)... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: remove erroneous REG32 in ish_fwsts.h
I'm a screw-up and forgot this in CL:1578435. Since
ish_fwst_is_hup_set is not used (yet), this did not cause any issues.
BUG=b:130573158,b:132060059
BRANCH=none
TEST=make buildall -j
Change-Id: I38a25a648b2235bade143fd20acb50a1318da992
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1596312
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,396 | 03.05.2019 13:51:17 | 25,200 | 7e910fa108c6e34b2f27f1980d1cd229a743454b | cr50: prepare to release 0.4.17
BRANCH=cr50
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/signer/ec_RW-manifest-dev.json",
"new_path": "util/signer/ec_RW-manifest-dev.json",
"diff": "\"timestamp\": 0,\n\"epoch\": 0, // FWR diversification contributor, 32 bits.\n\"major\": 4, // FW2_HIK_CHAIN counter.\n- \"minor\": 16, // Mostly harmless versio... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: prepare to release 0.4.17
BRANCH=cr50
BUG=none
TEST=none
Change-Id: I25c87502d3e38b42430c85a4426e43a2f5f6a7f3
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1595157
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,200 | 26.04.2019 21:00:07 | -28,800 | aa0cdc32ba82a0d0a699c4f06d78a589f7c58aa1 | octopus: set KB_BL_PWR_EN to GPIO62 for Droid/Blorb
Droid/Blorb use GPIO62 as KB_BL_PWR_EN to control keyboard backlight
power.
BRANCH=octopus
TEST=Check keyboard backlight power status in S0/S3/S5.
Commit-Ready: Marco Chen | [
{
"change_type": "MODIFY",
"old_path": "board/bobba/gpio.inc",
"new_path": "board/bobba/gpio.inc",
"diff": "@@ -132,8 +132,8 @@ GPIO(BAT_LED_ORANGE_L, PIN(C, 3), GPIO_OUT_HIGH) /* LED_1_L */\nGPIO(BAT_LED_BLUE_L, PIN(C, 4), GPIO_OUT_HIGH) /* LED_2_L */\nGPIO(LED_3_L, PIN(D, 7), GPIO_OUT_HIGH)\n-/* N... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | octopus: set KB_BL_PWR_EN to GPIO62 for Droid/Blorb
Droid/Blorb use GPIO62 as KB_BL_PWR_EN to control keyboard backlight
power.
BRANCH=octopus
BUG=b:130330141
TEST=Check keyboard backlight power status in S0/S3/S5.
Change-Id: I54c269676a6542175b7402b670342af6f744c55a
Signed-off-by: David Huang <David.Huang@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/1584495
Commit-Ready: Marco Chen <marcochen@chromium.org>
Reviewed-by: Marco Chen <marcochen@chromium.org> |
136,340 | 06.05.2019 18:00:33 | 25,200 | b8b8d41c4fe01cb068f2175831bc42e21e54bb1f | board: arcarda_ish: Fix gyro matrix
IMU Accel and Gyro matrices should be identical.
TEST=testing "CTS verifier Gyroscope Measurement Test"
Test was still failing when done manually, but the deltas were due to
user error not invalid axis.
BRANCH=master | [
{
"change_type": "MODIFY",
"old_path": "board/arcada_ish/board.c",
"new_path": "board/arcada_ish/board.c",
"diff": "@@ -91,7 +91,7 @@ struct motion_sensor_t motion_sensors[] = {\n.port = I2C_PORT_SENSOR,\n.addr = LSM6DSM_ADDR1,\n.default_range = 1000 | ROUND_UP_FLAG, /* dps */\n- .rot_standard_ref =... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | board: arcarda_ish: Fix gyro matrix
IMU Accel and Gyro matrices should be identical.
BUG=b:132110508
TEST=testing "CTS verifier Gyroscope Measurement Test"
Test was still failing when done manually, but the deltas were due to
user error not invalid axis.
BRANCH=master
Change-Id: I29f790385d4203f326bceb9a5320b0c833de7b65
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1597965 |
136,377 | 07.05.2019 12:55:09 | 25,200 | ceda91e9ada6ff7e6b0e1d351637aefe94048199 | ccd doc: link cr50 doc in main ccd doc
BRANCH=none
TEST=verify link works
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "docs/case_closed_debugging.md",
"new_path": "docs/case_closed_debugging.md",
"diff": "@@ -93,9 +93,10 @@ not need to be a list of CCD capable device IDs anywhere.\nBasic CCD\n---------\n-Here's the basic information for how to use CCD. Cr50 has more complicate... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ccd doc: link cr50 doc in main ccd doc
BUG=none
BRANCH=none
TEST=verify link works
Change-Id: I774a0dc1c0965f3655c46b09ff9bdd3e12f21200
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1599680
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Kevin Shelton <kmshelton@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,282 | 07.05.2019 10:40:28 | -28,800 | 44adfa912b7686715e02a00055cc4df238afc508 | bloog: add SKU IDs
BRANCH=octopus
TEST=make buildall -j
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "board/bloog/board.c",
"new_path": "board/bloog/board.c",
"diff": "@@ -211,12 +211,13 @@ unsigned int motion_sensor_count = ARRAY_SIZE(motion_sensors);\nint board_is_convertible(void)\n{\n/*\n- * Bloog: 33, 34, 35\n- * Blooguard: 49, 50\n+ * Bloog: 33, 34, 35, ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | bloog: add SKU IDs
BUG=b:132037233
BRANCH=octopus
TEST=make buildall -j
Change-Id: Ifd2d9fdc8c9e9a8a003564d4fb0fa561d3668c5c
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/1598388
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Marco Chen <marcochen@chromium.org> |
136,256 | 10.05.2019 08:11:03 | 21,600 | 8dadabb6810cba442e17025d292444f63880638d | cleanup: fix cros_sh to cros_ish typo
Update command line usage help string for ectool to specify cros_ish
instead of cros_sh.
BRANCH=none
TEST=see usage string update | [
{
"change_type": "MODIFY",
"old_path": "util/ectool.c",
"new_path": "util/ectool.c",
"diff": "@@ -333,7 +333,7 @@ int parse_bool(const char *s, int *dest)\nvoid print_help(const char *prog, int print_cmds)\n{\nprintf(\"Usage: %s [--dev=n] [--interface=dev|i2c|lpc] \", prog);\n- printf(\"[--name=cros... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: fix cros_sh to cros_ish typo
Update command line usage help string for ectool to specify cros_ish
instead of cros_sh.
BRANCH=none
BUG=none
TEST=see usage string update
Change-Id: I52f36b88598af980788eec8a1ed15160ba0f1175
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1605219 |
136,377 | 07.05.2019 13:10:18 | 25,200 | ce957ef6a084580c0d75694bc5d992f252a4a67f | ccd doc: add more to information about using ccd
BRANCH=none
TEST=none
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "docs/case_closed_debugging.md",
"new_path": "docs/case_closed_debugging.md",
"diff": "@@ -61,10 +61,15 @@ closed debugging work because the SBU lines that are used to expose the PD\nMCU's USB interface are not orientation invariant. Only one port on the DUT\nw... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ccd doc: add more to information about using ccd
BUG=none
BRANCH=none
TEST=none
Change-Id: I5776c16032863a2a0f8d5c82f148c80822379dec
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1599681
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,377 | 07.05.2019 15:43:39 | 25,200 | d68548eebbe93a6c3009cf20ddf0da7b27fe2012 | usb_if: use the device with the matching serial number
There might be multiple devices with the same VID:PID connected to the
host. Use the serial number to find the correct device if it is given.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "extra/usb_updater/gsctool.c",
"new_path": "extra/usb_updater/gsctool.c",
"diff": "@@ -2533,7 +2533,7 @@ int main(int argc, char *argv[])\n}\nif (td.ep_type == usb_xfer) {\n- if (usb_findit(vid, pid, USB_SUBCLASS_GOOGLE_CR50,\n+ if (usb_findit(NULL, vid, pid, U... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb_if: use the device with the matching serial number
There might be multiple devices with the same VID:PID connected to the
host. Use the serial number to find the correct device if it is given.
BUG=none
BRANCH=none
TEST=none
Change-Id: I96f31e8e7ceb0dd2c3c643771b38752da88a2a9e
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1600500
Reviewed-by: Matthew Blecker <matthewb@chromium.org> |
136,256 | 09.05.2019 10:22:34 | 21,600 | a05affa8514cb1b8ed324685ce23e9b665de13a4 | ish: correct gpio voltage to 3.3V
The sensor interrupt signal is 3.3V not 1.8V and
ISH GPIO does not support 3.3V away. This was benign but incorrect.
BRANCH=none
TEST=sensor still work | [
{
"change_type": "MODIFY",
"old_path": "board/arcada_ish/gpio.inc",
"new_path": "board/arcada_ish/gpio.inc",
"diff": "* found in the LICENSE file.\n*/\n-GPIO_INT(ACCEL_GYRO_INT_L, PIN(0), GPIO_INT_FALLING | GPIO_SEL_1P8V, lsm6dsm_interrupt)\n+GPIO_INT(ACCEL_GYRO_INT_L, PIN(0), GPIO_INT_FALLING, lsm6... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: correct gpio voltage to 3.3V
The sensor interrupt signal is 3.3V not 1.8V and
ISH GPIO does not support 3.3V away. This was benign but incorrect.
BUG=none
BRANCH=none
TEST=sensor still work
Change-Id: I0335c5c65f8d6a52f4c7df4018133b46d98bca39
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1602491
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,238 | 08.05.2019 16:53:55 | 25,200 | f8840200e0d2032175c8cd11613c8636c3f1711a | ish: update firmware status
Currently we missed some FW status updates that are used by host in
taking critical action.
BRANCH=none
TEST=tested on Arcada platform | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/host_command_heci.c",
"new_path": "chip/ish/host_command_heci.c",
"diff": "#include \"host_command.h\"\n#include \"host_command_heci.h\"\n#include \"ipc_heci.h\"\n+#include \"ish_fwst.h\"\n#include \"util.h\"\n#define CPUTS(outstr) cputs(CC_LPC, outst... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: update firmware status
Currently we missed some FW status updates that are used by host in
taking critical action.
BUG=b:132060059
BRANCH=none
TEST=tested on Arcada platform
Change-Id: I7ad607869f821eae99e37704ab3d6567d180aadd
Signed-off-by: Hyungwoo Yang <hyungwoo.yang@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1601780
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,256 | 08.05.2019 13:23:29 | 21,600 | 1fa9dc3e2e8a2771a854657e0441128a9a119dbc | ish: add more explanations comments for reset flow in aontask
BRANCH=none
TEST=ISH still reset properly on arcada | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/aontaskfw/ish_aontask.c",
"new_path": "chip/ish/aontaskfw/ish_aontask.c",
"diff": "@@ -558,8 +558,33 @@ static void handle_reset(int pm_state)\nsram_power(0);\nwhile (1) {\n-\n- /* check if host ish driver already set the DMA enable flag */\n+ /**\n+ ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: add more explanations comments for reset flow in aontask
BRANCH=none
BUG=none
TEST=ISH still reset properly on arcada
Change-Id: I08a5935c5e8d1728e2984cbc70d75e380eb66f55
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1601349
Reviewed-by: Hebo Hu <hebo.hu@intel.corp-partner.google.com>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org> |
136,331 | 06.05.2019 16:29:35 | 21,600 | e2171125246314a685f1c95d08c5db820b521c81 | ish: set firmware status to running during pre-init
This adds a firmware status update to FWSTS_FW_IS_RUNNING during boot.
BRANCH=none
TEST=Observed firmware status is 7 (IS_RUNNING) during boot before
HECI ready. | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/system.c",
"new_path": "chip/ish/system.c",
"diff": "#include \"cpu.h\"\n#include \"gpio.h\"\n#include \"host_command.h\"\n+#include \"ish_fwst.h\"\n#include \"registers.h\"\n#include \"shared_mem.h\"\n#include \"system.h\"\n@@ -34,6 +35,8 @@ int syst... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: set firmware status to running during pre-init
This adds a firmware status update to FWSTS_FW_IS_RUNNING during boot.
BUG=b:132060059
BRANCH=none
TEST=Observed firmware status is 7 (IS_RUNNING) during boot before
HECI ready.
Change-Id: If41c86838a956023754be960472b8c641416b7c9
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1597674
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,340 | 14.05.2019 01:26:36 | 25,200 | 2c321f4ab89d2ec171f7b3c463893fa5051479fe | FIXUP: driver: lis2mdl: add standalone support
Fix constant used when LIS2MDL is behind LSM6DSM.
BRANCH=none
TEST=meep board compile.
Commit-Ready: ChromeOS CL Exonerator Bot | [
{
"change_type": "MODIFY",
"old_path": "driver/mag_lis2mdl.c",
"new_path": "driver/mag_lis2mdl.c",
"diff": "@@ -150,7 +150,7 @@ int lis2mdl_thru_lsm6dsm_init(const struct motion_sensor_t *s)\nLSM6DSM_MAIN_SENSOR(s),\nCONFIG_ACCELGYRO_SEC_ADDR,\nLIS2MDL_WHO_AM_I_REG, LIS2MDL_WHO_AM_I,\n- LIS2MDL_CFG_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | FIXUP: driver: lis2mdl: add standalone support
Fix constant used when LIS2MDL is behind LSM6DSM.
BUG=b:128619310,b:124085261
BRANCH=none
TEST=meep board compile.
Change-Id: I35ec3659dfedceedfa52400c37972fcf387f6375
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1610315
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Yuval Peress <peress@chromium.org> |
136,287 | 10.05.2019 11:29:33 | 21,600 | 42a82041a83f8e4e8776a5f367e48b2b0f729f9f | board: arcada: Fix magnetometer axis rotation
Fix the rotation of the magnetometer measurements.
BRANCH=None
TEST=Compare raw magnetometer data with pixel 3 | [
{
"change_type": "MODIFY",
"old_path": "board/arcada_ish/board.c",
"new_path": "board/arcada_ish/board.c",
"diff": "@@ -136,7 +136,7 @@ struct motion_sensor_t motion_sensors[] = {\n.port = I2C_PORT_SENSOR,\n.addr = LIS2MDL_ADDR,\n.default_range = 1 << 11, /* 16LSB / uT, fixed */\n- .rot_standard_ref... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | board: arcada: Fix magnetometer axis rotation
Fix the rotation of the magnetometer measurements.
BRANCH=None
BUG=b:128619310
TEST=Compare raw magnetometer data with pixel 3
Change-Id: I3fa407dd4dcc825cc521c8e49a63a635e45f9081
Signed-off-by: Yuval Peress <peress@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1612256
Reviewed-by: Gwendal Grignou <gwendal@chromium.org> |
136,331 | 16.05.2019 15:03:53 | 21,600 | cd45a75e8c0dea45b94dc530fde7c86cc698fd2d | common: chip_save_reset_flags takes uint32_t
The getters and setters for the reset flags should take and return the
same type. `uint32_t' seems the more appropraiate type than `int', so
change the setter to take `uint32_t'.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/system.c",
"new_path": "chip/ish/system.c",
"diff": "@@ -46,7 +46,7 @@ void system_pre_init(void)\nsystem_set_reset_flags(chip_read_reset_flags());\n}\n-void chip_save_reset_flags(int flags)\n+void chip_save_reset_flags(uint32_t flags)\n{\nISH_RESET_F... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: chip_save_reset_flags takes uint32_t
The getters and setters for the reset flags should take and return the
same type. `uint32_t' seems the more appropraiate type than `int', so
change the setter to take `uint32_t'.
BUG=none
BRANCH=none
TEST=make buildall -j
Change-Id: I50928a114858dd51034a048520efa849f5182bd0
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1615648
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,331 | 17.05.2019 09:35:24 | 21,600 | bec3134a2736737fbd8599db02e594f8524aa539 | ish: fix printf format for idlestats command
%ld is for signed numbers, but these are unsigned.
BRANCH=none
TEST=used idlestats command on arcada, verified correct output
Legacy-Commit-Queue: Commit Bot | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/power_mgt.c",
"new_path": "chip/ish/power_mgt.c",
"diff": "@@ -634,41 +634,41 @@ static int command_idle_stats(int argc, char **argv)\nccprintf(\"Aontask exist: %s\\n\", pm_ctx.aon_valid ? \"Yes\" : \"No\");\nccprintf(\"Idle sleep:\\n\");\nccprintf(\"... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: fix printf format for idlestats command
%ld is for signed numbers, but these are unsigned.
BUG=b:132929262
BRANCH=none
TEST=used idlestats command on arcada, verified correct output
Change-Id: Iffe405ae0d62159d8036248593ed0993e7a5742a
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1617068
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,396 | 20.05.2019 17:23:01 | 25,200 | 35048bb784c24f8f4d88e6664cdd4453677f8cb9 | cr50: prepare to release 0.4.18
BRANCH=cr50, cr50-mp
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/signer/ec_RW-manifest-dev.json",
"new_path": "util/signer/ec_RW-manifest-dev.json",
"diff": "\"timestamp\": 0,\n\"epoch\": 0, // FWR diversification contributor, 32 bits.\n\"major\": 4, // FW2_HIK_CHAIN counter.\n- \"minor\": 17, // Mostly harmless versio... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: prepare to release 0.4.18
BRANCH=cr50, cr50-mp
BUG=b:133187513
TEST=none
Change-Id: Ifcddb73577e6510ddc33c97cdf83af1ddcf2a616
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1621073
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,289 | 21.05.2019 14:27:46 | 25,200 | 5f7dedbe84e92d6800e5c9384bd2a05f122d8f77 | common: dptf: Fix function name typo
s/dpft_check_temp_threshold/dptf_check_temp_threshold/
BRANCH=none
TEST=make -j BOARD=hatch
Legacy-Commit-Queue: Commit Bot | [
{
"change_type": "MODIFY",
"old_path": "common/dptf.c",
"new_path": "common/dptf.c",
"diff": "@@ -54,7 +54,7 @@ int dptf_query_next_sensor_event(void)\n}\n/* Return true if any threshold transition occurs. */\n-static int dpft_check_temp_threshold(int sensor_id, int temp)\n+static int dptf_check_tem... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: dptf: Fix function name typo
s/dpft_check_temp_threshold/dptf_check_temp_threshold/
BUG=b:132999028
BRANCH=none
TEST=make -j BOARD=hatch
Change-Id: I453a154ee9e4a58ce88e7d6ffe34f14ae8b08d65
Signed-off-by: Evan Green <evgreen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1623175
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org> |
136,287 | 20.05.2019 21:10:30 | 21,600 | f25a4cf2477a48fccce07047aaa3bb564c46e802 | motionsense: Convert in_spoof_mode to a more generic flags
BRANCH=arcada
TEST=I ran `make buildall` since this change isn't used yet it doesn't
affect run-time behavior.
Legacy-Commit-Queue: Commit Bot | [
{
"change_type": "MODIFY",
"old_path": "common/motion_sense.c",
"new_path": "common/motion_sense.c",
"diff": "@@ -434,9 +434,6 @@ static inline int motion_sense_init(struct motion_sensor_t *sensor)\n{\nint ret, cnt = 3;\n- /* By default, report the actual sensor values. */\n- sensor->in_spoof_mode =... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | motionsense: Convert in_spoof_mode to a more generic flags
BUG=b:129159505
BRANCH=arcada
TEST=I ran `make buildall` since this change isn't used yet it doesn't
affect run-time behavior.
Change-Id: I01857d679b800f9b53762c659ebd9a018cbf16db
Signed-off-by: Yuval Peress <peress@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1612251
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org> |
136,297 | 08.05.2019 14:24:53 | -32,400 | 634a1b059895d3a4080311fb599451a37925413f | kohaku:set EC_INT_L type to open drain
There is leakage on PP3300 and PP1800 because EC_INT_L is set to push-pull.
BRANCH=none
TEST=make -j BOARD=kohaku
Legacy-Commit-Queue: Commit Bot | [
{
"change_type": "MODIFY",
"old_path": "board/kohaku/gpio.inc",
"new_path": "board/kohaku/gpio.inc",
"diff": "@@ -54,7 +54,7 @@ GPIO(EC_PCH_SYS_PWROK, PIN(3, 7), GPIO_OUT_LOW)\nGPIO(CPU_C10_GATE_L, PIN(6, 7), GPIO_INPUT)\n/* MKBP event synchronization */\n-GPIO(EC_INT_L, PIN(7, 0), GPIO_OUT_HIGH)\n+... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kohaku:set EC_INT_L type to open drain
There is leakage on PP3300 and PP1800 because EC_INT_L is set to push-pull.
BUG=b:132211623
BRANCH=none
TEST=make -j BOARD=kohaku
Change-Id: I6bafc9189023a8ffc6d3a6fa53df3fce2da19d35
Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/1600937
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> |
136,282 | 20.05.2019 18:19:29 | -28,800 | 931b4bd0bf604bb41438680b9eb58101863021ec | garg: initial EC image
This image is based on bobba PVT from ToT and SKUID is TBD.
BRANCH=octopus
TEST=make buildall -j
Legacy-Commit-Queue: Commit Bot | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/garg/battery.c",
"diff": "+/* Copyright 2019 The Chromium OS Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ *\n+ * Battery pack vendor provided c... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | garg: initial EC image
This image is based on bobba PVT from ToT and SKUID is TBD.
BUG=b:132668378
BRANCH=octopus
TEST=make buildall -j
Change-Id: I6471b4ec2cf49d682483782384114594f62f916d
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/1616892
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org> |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.