author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
136,384 | 24.05.2019 16:48:26 | 21,600 | 0d73e46eb36455652eafcf7583f4dd8112472b92 | driver/tcpm: Tidy tcpci_tcpm_transmit
Remove hardcoded message header size
Check the return value of tcpc_write_block
Merge unnecessary assignment
BRANCH=none
TEST=none
Found-by: Coverity CID 187542
Legacy-Commit-Queue: Commit Bot | [
{
"change_type": "MODIFY",
"old_path": "driver/tcpm/tcpci.c",
"new_path": "driver/tcpm/tcpci.c",
"diff": "@@ -512,8 +512,8 @@ int tcpci_tcpm_transmit(int port, enum tcpm_transmit_type type,\nint reg = TCPC_REG_TX_DATA;\nint rv, cnt = 4*PD_HEADER_CNT(header);\n- /* TX_BYTE_CNT includes 2 bytes for me... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | driver/tcpm: Tidy tcpci_tcpm_transmit
- Remove hardcoded message header size
- Check the return value of tcpc_write_block
- Merge unnecessary assignment
BUG=none
BRANCH=none
TEST=none
Change-Id: Ic4db769f6f9d62ffb4eb10621b15dc414c0bab26
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 187542
Reviewed-on: https://chromium-review.googlesource.com/1629275
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,384 | 24.05.2019 17:53:05 | 21,600 | 06fc1b203b7914912546a3b442ee2d510814065e | common: Remove unnecessary null check
supported_modes is an array of structs, and addresses of array elements
cannot be null.
BRANCH=none
TEST=none
Found-by: Coverity CID 141742
Legacy-Commit-Queue: Commit Bot | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_policy.c",
"new_path": "common/usb_pd_policy.c",
"diff": "@@ -417,9 +417,6 @@ int allocate_mode(int port, uint16_t svid)\n/* Allocate ... if SVID == 0 enter default supported policy */\nfor (i = 0; i < supported_modes_cnt; i++) {\n- if (!&support... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: Remove unnecessary null check
supported_modes is an array of structs, and addresses of array elements
cannot be null.
BUG=none
BRANCH=none
TEST=none
Change-Id: I1268e024ba8b2469d1bc70be27b3e98044a7ac04
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 141742
Reviewed-on: https://chromium-review.googlesource.com/1629279
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,192 | 28.05.2019 11:17:53 | 21,600 | 21de92a83ce6866115d1f217a9d53291040ddb51 | helios: Update battery pack info
Update board_battery_info with latest battery pack information
BRANCH=none
TEST=make BOARD=helios
Legacy-Commit-Queue: Commit Bot | [
{
"change_type": "MODIFY",
"old_path": "board/helios/battery.c",
"new_path": "board/helios/battery.c",
"diff": "* address, mask, and disconnect value need to be provided.\n*/\nconst struct board_batt_params board_battery_info[] = {\n- /* SMP LIS Dell FMXMT Battery Information */\n- [BATTERY_SMP_LIS]... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | helios: Update battery pack info
Update board_battery_info with latest battery pack information
BUG=b:133381447
BRANCH=none
TEST=make BOARD=helios
Change-Id: I31d751c338c52b44fdae291f94d59282543e4c1c
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1632771
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Scott Collyer <scollyer@chromium.org> |
136,331 | 28.05.2019 10:58:13 | 21,600 | 2f8b5e86453449c729c1e61262b50467ec29ed33 | ish: remove unused ish_dma_page code
ish_dma_page was intended to be used in the aontaskfw implementation,
but we never used it. Remove the unused code.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/dma.c",
"new_path": "chip/ish/dma.c",
"diff": "@@ -183,36 +183,6 @@ int ish_wait_for_dma_done(uint32_t ch)\nreturn dma_poll(DMA_EN_REG_ADDR, 0, DMA_CH_EN_BIT(ch));\n}\n-static int ish_dma_page_internal(uint32_t dst, uint32_t src, enum dma_mode mode)\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: remove unused ish_dma_page code
ish_dma_page was intended to be used in the aontaskfw implementation,
but we never used it. Remove the unused code.
BUG=none
BRANCH=none
TEST=make buildall -j
Change-Id: I33983a4e6c6de082078b8b6b59519fbc095d8022
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1631588
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,269 | 29.05.2019 18:17:09 | 25,200 | b41026d4f3bcddc97cac280bbc2e2865f5a3ec10 | Move fingerprint files to their own directory
We will be adding more files in the future, so this declutters the
common directory. It also lets us add a separate OWNERS file.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "common/build.mk",
"new_path": "common/build.mk",
"diff": "# Common files build\n#\n+# Note that this variable includes the trailing \"/\"\n+_common_dir:=$(dir $(lastword $(MAKEFILE_LIST)))\n+\ncommon-y=util.o\ncommon-y+=version.o printf.o queue.o queue_policie... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Move fingerprint files to their own directory
We will be adding more files in the future, so this declutters the
common directory. It also lets us add a separate OWNERS file.
BRANCH=none
BUG=chromium:968518
TEST=make buildall -j
Change-Id: I22c08851fe2d5fbdb5beff8cc72a68618c85fb0e
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1637440
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,269 | 28.05.2019 17:15:48 | 25,200 | e36f5ff57b2456c61f868af7be3f6929b28f1bf3 | Add OWNERS files for fingerprint
BRANCH=none
TEST=none | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/hatch_fp/OWNERS",
"diff": "+include ../../common/fpsensor/OWNERS\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/nami_fp/OWNERS",
"diff": "+include ../../common/fpsensor/OWNERS\n"
},
{
"change... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Add OWNERS files for fingerprint
BRANCH=none
BUG=chromium:967924
TEST=none
Change-Id: Ief50a64d45cc6862fab3417e3f8350d3c581209e
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1633909
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org> |
136,256 | 03.06.2019 15:26:59 | 21,600 | e0f6c91881b2873a415d9debaf381dfada771629 | arcada: use lid switch instead of gpio
Use the debounced lid switch state for lid close instead of the raw
gpio.
BRANCH=none
TEST=tablet mode state is cleaner around 0 degrees | [
{
"change_type": "MODIFY",
"old_path": "board/arcada_ish/board.c",
"new_path": "board/arcada_ish/board.c",
"diff": "@@ -155,7 +155,7 @@ int board_sensor_at_360(void)\n* closed at 0 degrees. Ignore the hall sensor when the lid close is\n* also active.\n*/\n- return gpio_get_level(GPIO_LID_OPEN) &&\n+... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | arcada: use lid switch instead of gpio
Use the debounced lid switch state for lid close instead of the raw
gpio.
BRANCH=none
BUG=b:126861777
TEST=tablet mode state is cleaner around 0 degrees
Change-Id: I46d7e2ed7fa0af7f276662e5136613caaed539f7
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1641434
Reviewed-by: Duncan Laurie <dlaurie@google.com>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,331 | 04.06.2019 11:16:34 | 21,600 | dc5bb3536677fb332c4a3f71d31b57647ff9a7a8 | ish: don't specify any on-board tests
We have no framework to do on-board testing on ish. The make target
should do nothing.
BRANCH=none
TEST="make BOARD=arcada_ish tests" does nothing | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/build.mk",
"new_path": "chip/ish/build.mk",
"diff": "@@ -27,6 +27,9 @@ chip-$(CONFIG_HID_HECI)+=heci.o system_state_subsys.o ipc_heci.o\nchip-$(CONFIG_DMA_PAGING)+=dma.o\nchip-$(CONFIG_LOW_POWER_IDLE)+=power_mgt.o\n+# There is no framework for on-boar... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: don't specify any on-board tests
We have no framework to do on-board testing on ish. The make target
should do nothing.
BUG=b:134446400
BRANCH=none
TEST="make BOARD=arcada_ish tests" does nothing
Change-Id: Ic71b35a24d37f7b827f6639669c6d43659cda06e
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1643834
Reviewed-by: Yuval Peress <peress@chromium.org> |
136,396 | 05.06.2019 15:52:08 | 25,200 | 5389c763b2a0e2c52098c38087e8895662fa600d | cr50: prepare to release 0.4.19
BRANCH=cr50
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/signer/ec_RW-manifest-dev.json",
"new_path": "util/signer/ec_RW-manifest-dev.json",
"diff": "\"timestamp\": 0,\n\"epoch\": 0, // FWR diversification contributor, 32 bits.\n\"major\": 4, // FW2_HIK_CHAIN counter.\n- \"minor\": 18, // Mostly harmless versio... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: prepare to release 0.4.19
BRANCH=cr50
BUG=none
TEST=none
Change-Id: I1b36658342314e86e3310acd85d821388be3bd57
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1646539
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,269 | 02.05.2019 15:23:23 | 25,200 | 245450a0189391cace7ace17553193cfc10866ce | fpsensor: Add instructions for using screen instead of minicom
Also increase timeout to provide enough time to hit enter when download
prompt pops up.
BRANCH=none
TEST=fpcapture from fingerprint console | [
{
"change_type": "MODIFY",
"old_path": "common/fpsensor/fpsensor.c",
"new_path": "common/fpsensor/fpsensor.c",
"diff": "@@ -684,6 +684,23 @@ DECLARE_HOST_COMMAND(EC_CMD_FP_TEMPLATE, fp_command_template, EC_VER_MASK(0));\n* TMPF=$(mktemp)\n* ascii-xfr -rdv ${TMPF}\n* display ${TMPF}\n+ *\n+ * Alterna... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | fpsensor: Add instructions for using screen instead of minicom
Also increase timeout to provide enough time to hit enter when download
prompt pops up.
BRANCH=none
BUG=b:124996507
TEST=fpcapture from fingerprint console
Change-Id: I1e608161aceae4431dedcaffd648d20549b97a8b
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1593956
Reviewed-by: Nicolas Norvez <norvez@chromium.org> |
136,197 | 13.06.2019 12:30:41 | -28,800 | eb13a9379f7c44f2ef4a67a2e60cbe2610a06b6a | chip/mt_scp: Fix clock selection register values for ULPOSC_1/2
Values were incorrect, previously.
BRANCH=none
TEST=See bug. With CL:1475091, cycle count/time actually matches
the expected frequency. | [
{
"change_type": "MODIFY",
"old_path": "chip/mt_scp/registers.h",
"new_path": "chip/mt_scp/registers.h",
"diff": "#define SCP_CLK_SEL REG32(SCP_CLK_BASE)\n#define CLK_SEL_SYS_26M 0\n#define CLK_SEL_32K 1\n-#define CLK_SEL_ULPOSC_1 2\n-#define CLK_SEL_ULPOSC_2 3\n+#define CLK_SEL_ULPOSC_2 2\n+#define... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | chip/mt_scp: Fix clock selection register values for ULPOSC_1/2
Values were incorrect, previously.
BRANCH=none
BUG=b:125616659
TEST=See bug. With CL:1475091, cycle count/time actually matches
the expected frequency.
Change-Id: Icdca1809dc202d527b708ce3df7ea19ac7f60532
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1657080
Reviewed-by: Yilun Lin <yllin@chromium.org> |
136,197 | 23.05.2019 08:10:58 | -28,800 | 24577344b97f63a1fd28a1a7bd187887445b7193 | kukui_scp/update_scp: Deploy elf file by default
This is what recent kukui MTK ToT require.
BRANCH=none
TEST=make BOARD=kukui_scp -j && board/kukui_scp/update_scp $IP
=> SCP boots | [
{
"change_type": "MODIFY",
"old_path": "board/kukui_scp/update_scp",
"new_path": "board/kukui_scp/update_scp",
"diff": "@@ -20,9 +20,7 @@ INFILE=\"build/kukui_scp/ec.bin\"\ncase \"$2\" in\nbin)\n;;\n-\"\") # Default: flat binary (only allows for SRAM to be loaded)\n- ;;\n-elf)\n+elf|\"\") # Default\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui_scp/update_scp: Deploy elf file by default
This is what recent kukui MTK ToT require.
BRANCH=none
BUG=none
TEST=make BOARD=kukui_scp -j && board/kukui_scp/update_scp $IP
=> SCP boots
Change-Id: I6f309ace6d38d3e3cdb0ad0380a1ace6cb25ead2
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1626889
Reviewed-by: Yilun Lin <yllin@chromium.org> |
136,198 | 14.06.2019 11:11:56 | 25,200 | 30eeccc3523285238837321efb4a506b5eb54e0d | include/util: enclose a arg of POWER_OF_TWO into parentheses
It is something should be done.
BRANCH=None
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "include/util.h",
"new_path": "include/util.h",
"diff": "@@ -53,7 +53,7 @@ extern \"C\" {\n((type *)(((uint8_t *) pointer) - offsetof(type, member)))\n/* True of x is a power of two */\n-#define POWER_OF_TWO(x) (x && !(x & (x - 1)))\n+#define POWER_OF_TWO(x) ((... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | include/util: enclose a arg of POWER_OF_TWO into parentheses
It is something should be done.
BUG=None
BRANCH=None
TEST=make buildall -j
Change-Id: I7a96385cf82ff458446744ae92ffc8349a443098
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1660942
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,438 | 13.06.2019 14:15:20 | 25,200 | 38eb0404ba4e72880e334e47dc7871dc0ed65cb3 | fpsensor: Change new files' year to 2019
Although the code is moved from files created in 2017, these are new
files, so change the year to 2019.
BRANCH=nocturne
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "common/fpsensor/fpsensor_state.c",
"new_path": "common/fpsensor/fpsensor_state.c",
"diff": "-/* Copyright 2017 The Chromium OS Authors. All rights reserved.\n+/* Copyright 2019 The Chromium OS Authors. All rights reserved.\n* Use of this source code is governe... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | fpsensor: Change new files' year to 2019
Although the code is moved from files created in 2017, these are new
files, so change the year to 2019.
BRANCH=nocturne
BUG=none
TEST=make -j buildall
Change-Id: I15015c7ad1a713437b04395fd09e6641019f5ff7
Signed-off-by: Yicheng Li <yichengli@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1660092
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,342 | 04.06.2019 09:38:29 | 25,200 | 70e9e80590d05bad7dbd44fc4d2613633e7b98eb | stm32mon: Added declarations for stm32g0 series | [
{
"change_type": "MODIFY",
"old_path": "util/stm32mon.c",
"new_path": "util/stm32mon.c",
"diff": "@@ -200,6 +200,50 @@ struct stm32_def {\n},\n{0x450, \"STM32H74x\", 0x200000, 131768, {13, 19}, { { 0 } }, { 0 } },\n{0x451, \"STM32F76x\", 0x200000, 32768, {13, 19}, { { 0 } }, { 0 } },\n+ {\n+ .id = 0... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | stm32mon: Added declarations for stm32g0 series
Bug: 132247842
Change-Id: Ib1defbabd6e2835d8ce8485c80f22254d2b49db7
Signed-off-by: jbk@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1620789
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: James Deng <jaamesd@chromium.org> |
136,314 | 31.05.2019 17:16:13 | 25,200 | 3a44908beda662eb7bdf5a7b877c7dadbc8b6d50 | flapjack: add i2c_ports entry for I2C_PORT_ALS
BRANCH=master
TEST=none
Tested-by: Nick Vaccaro | [
{
"change_type": "MODIFY",
"old_path": "board/flapjack/board.c",
"new_path": "board/flapjack/board.c",
"diff": "@@ -238,6 +238,7 @@ BUILD_ASSERT(ARRAY_SIZE(adc_channels) == ADC_CH_COUNT);\nconst struct i2c_port_t i2c_ports[] = {\n{\"charger\", I2C_PORT_CHARGER, 400, GPIO_I2C1_SCL, GPIO_I2C1_SDA},\n{... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | flapjack: add i2c_ports entry for I2C_PORT_ALS
BUG=b:124512628
BRANCH=master
TEST=none
Change-Id: I7cb9f44313fc64cc95ab47628e854fce0a4362b3
Signed-off-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1639646
Tested-by: Nick Vaccaro <nvaccaro@chromium.org>
Commit-Queue: Nick Vaccaro <nvaccaro@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,269 | 18.06.2019 10:47:22 | 25,200 | 2d828d33a460abe1daaf29d5ff364132dfe7aca5 | ec.tasklist: Consolidate duplicate comments
Same as but clean up some files with the
old comments that have been added since that change.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/chocodile_vpdmcu/ec.tasklist",
"new_path": "board/chocodile_vpdmcu/ec.tasklist",
"diff": "*/\n/**\n- * List of enabled tasks in the priority order\n- *\n- * The first one has the lowest priority.\n- *\n- * For each task, use the macro TASK_ALWAYS(n, r, d... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec.tasklist: Consolidate duplicate comments
Same as https://crrev.com/c/1551579, but clean up some files with the
old comments that have been added since that change.
BRANCH=none
BUG=none
TEST=make buildall -j
Change-Id: I4bc7fdc7cb128c48545ea681ab1381610d54fb6d
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1664604
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,269 | 20.06.2019 15:53:48 | 25,200 | d28c0a87edee59d458b847fc5455b1c5cd698f15 | fpsensor: Add unit tests for fp_set_sensor_mode
BRANCH=nocturne
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "include/fpsensor_state.h",
"new_path": "include/fpsensor_state.h",
"diff": "#define PRIV_HEADER(header) STRINGIFY(header)\n#include PRIV_HEADER(FP_SENSOR_PRIVATE)\n#else\n+/* These values are used by the host (emulator) tests. */\n#define FP_SENSOR_IMAGE_SIZE ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | fpsensor: Add unit tests for fp_set_sensor_mode
BRANCH=nocturne
BUG=b:124773209
TEST=make buildall -j
Change-Id: I8337c708005c51435ce8a5ab5d536cccc604f850
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1670347
Reviewed-by: Nicolas Norvez <norvez@chromium.org> |
136,269 | 24.06.2019 10:58:38 | 25,200 | c40573399466395248af0e807c63e9180e0e87d7 | common/fmap: Update doc link
The old link just redirects to source code on github, which is not the
source that we build fmap from.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "common/fmap.c",
"new_path": "common/fmap.c",
"diff": "#include \"util.h\"\n#include \"version.h\"\n-/* FMAP structs. See http://code.google.com/p/flashmap/wiki/FmapSpec */\n+/*\n+ * FMAP structs.\n+ * See https://chromium.googlesource.com/chromiumos/third_part... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common/fmap: Update doc link
The old link just redirects to source code on github, which is not the
source that we build fmap from.
BRANCH=none
BUG=none
TEST=make buildall -j
Change-Id: I013032a1a1c71c238393f23bf5798134cc2d53a2
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1674052
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
136,208 | 24.06.2019 16:32:17 | -28,800 | dbaf95d616543fb89b9d6d2e79f81bd232b95e4c | config.h: Add missing CONFIG_WIRELESS_CHARGER_P9221_R7
TEST=none
BRANCH=none
Tested-by: Yilun Lin | [
{
"change_type": "MODIFY",
"old_path": "include/config.h",
"new_path": "include/config.h",
"diff": "/* Enable trickle charging */\n#undef CONFIG_TRICKLE_CHARGING\n+/* Wireless chargers */\n+#undef CONFIG_WIRELESS_CHARGER_P9221_R7\n+\n/*****************************************************************... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | config.h: Add missing CONFIG_WIRELESS_CHARGER_P9221_R7
TEST=none
BUG=b:126162615
BRANCH=none
Change-Id: I602a45df8b178eef4ddfe3ae0b642640a6313c72
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1673953
Commit-Queue: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Auto-Submit: Yilun Lin <yllin@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,230 | 20.06.2019 15:33:53 | 25,200 | 08429fb35a85944eb7314926a7cba3254b3de86a | kohaku: Add support for TCS3400 as clear ALS and RGB sesnor
BRANCH=none
TEST=build kohaku
Tested-by: Philip Chen | [
{
"change_type": "MODIFY",
"old_path": "board/kohaku/board.c",
"new_path": "board/kohaku/board.c",
"diff": "#include \"driver/accel_bma2x2.h\"\n#include \"driver/accelgyro_bmi160.h\"\n#include \"driver/als_bh1730.h\"\n+#include \"driver/als_tcs3400.h\"\n#include \"driver/ppc/sn5s330.h\"\n#include \"... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kohaku: Add support for TCS3400 as clear ALS and RGB sesnor
BUG=b:134207072, b:135216932
BRANCH=none
TEST=build kohaku
Change-Id: I7b3d01d5dfb193262055b6aff2d101844159aa94
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1670165
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org> |
136,269 | 24.06.2019 16:48:10 | 25,200 | e0075d54e65cd1f3f9379a8ef9568734a383d033 | fpsensor: Add help descriptions for console commands
All the other console commands have help descriptions except for the
fingerprint sensor commands.
BRANCH=none
TEST="help list" in hatch_fp console | [
{
"change_type": "MODIFY",
"old_path": "common/fpsensor/fpsensor.c",
"new_path": "common/fpsensor/fpsensor.c",
"diff": "@@ -646,7 +646,8 @@ int command_fpcapture(int argc, char **argv)\nreturn rc;\n}\n-DECLARE_CONSOLE_COMMAND(fpcapture, command_fpcapture, \"\", \"\");\n+DECLARE_CONSOLE_COMMAND(fpcap... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | fpsensor: Add help descriptions for console commands
All the other console commands have help descriptions except for the
fingerprint sensor commands.
BRANCH=none
BUG=none
TEST="help list" in hatch_fp console
Change-Id: I601c7e49a28693f4b7f4344a6030febb87c2ae20
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1674808
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,377 | 28.06.2019 10:44:28 | 25,200 | ad6d0528341d71b5b74be66e065a85dc70aa0c8a | docs: add cr50 ccd prerequisites
Add some prerequisites that tell you what you need to emerge.
BRANCH=none
TEST=read doc prerequisites. Make sure information and formatting looks
ok. | [
{
"change_type": "MODIFY",
"old_path": "docs/case_closed_debugging_cr50.md",
"new_path": "docs/case_closed_debugging_cr50.md",
"diff": "@@ -65,6 +65,43 @@ Cr50 CCD needs to be opened to access all CCD functionality or to modify\ncapability settings so the device doesn't need to be open to access CCD... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: add cr50 ccd prerequisites
Add some prerequisites that tell you what you need to emerge.
BUG=none
BRANCH=none
TEST=read doc prerequisites. Make sure information and formatting looks
ok.
Change-Id: Iedbbd297b9f98890cb07dc658d2643ebb006ef3f
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1682170
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,256 | 07.06.2019 10:42:50 | 21,600 | 587eb9d49b7642df83916f515f2d7adbafd3d1d1 | doc: add documentation for usb-c on platform/ec
Add documentation for common configuration and touch points that need to
be considered when implementing the USB-C stack on the platform/ec
codebase.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "docs/sitemap.md",
"new_path": "docs/sitemap.md",
"diff": "* [USB Updater](./usb_updater.md)\n+## USB-C\n+\n+* [USB-C Power Delivery and Alternate Modes](./usb-c.md)\n+\n## Miscellaneous\n* [Low Battery Startup](./low_battery_startup.md)\n"
},
{
"change... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | doc: add documentation for usb-c on platform/ec
Add documentation for common configuration and touch points that need to
be considered when implementing the USB-C stack on the platform/ec
codebase.
BRANCH=none
BUG=chromium:974302
TEST=none
Change-Id: I24aef187989c14688985d3cba48a6734ee519d23
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1648609
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,233 | 27.06.2019 17:48:03 | -28,800 | d92daea73957789df43e458d31fadae7d2c64989 | it83xx/i2c_slave: the DMA registers have updated on IT8xxx2
The DMA read and write target address registers have changed.
BRANCH=none
TEST=Testing on IT8320dx and IT83202 EVB. | [
{
"change_type": "MODIFY",
"old_path": "chip/it83xx/i2c_slave.c",
"new_path": "chip/it83xx/i2c_slave.c",
"diff": "@@ -230,6 +230,7 @@ void i2c_slave_enable(int port, uint8_t slv_addr)\n/* Enhanced I2C slave channel D, E, F DMA mode */\nelse {\nint ch, idx;\n+ uint32_t in_data_addr, out_data_addr;\n/... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | it83xx/i2c_slave: the DMA registers have updated on IT8xxx2
The DMA read and write target address registers have changed.
BUG=none
BRANCH=none
TEST=Testing on IT8320dx and IT83202 EVB.
Change-Id: I9e63c3f7f402ed22c461eb86daa5eba0e6dcb58e
Signed-off-by: tim <tim2.lin@ite.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1660071
Commit-Queue: Jett Rink <jettrink@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,396 | 01.07.2019 11:56:36 | 25,200 | 9ba43859c8ed86768e95ea01b7fc5a495af683a8 | cr50: prepare to release 0.4.20
BRANCH=cr50
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/signer/ec_RW-manifest-dev.json",
"new_path": "util/signer/ec_RW-manifest-dev.json",
"diff": "\"timestamp\": 0,\n\"epoch\": 0, // FWR diversification contributor, 32 bits.\n\"major\": 4, // FW2_HIK_CHAIN counter.\n- \"minor\": 19, // Mostly harmless versio... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: prepare to release 0.4.20
BRANCH=cr50
BUG=none
TEST=none
Change-Id: I6f213935a2340d6a5ba5d55c236c187117219e11
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1684238
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,269 | 27.06.2019 16:18:51 | 25,200 | 9981644854bcb9140c7249765d2f7bf59b23becd | hatch_fp: Enable rollback
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/hatch_fp/board.h",
"new_path": "board/hatch_fp/board.h",
"diff": "/*\n* Add rollback protection\n*/\n-/*TODO(b/125506600): Support rollback protection */\n-#if 0\n#define CONFIG_ROLLBACK\n#define CONFIG_ROLLBACK_SECRET_SIZE 32\n-\n+#define CONFIG_MPU\n#d... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | hatch_fp: Enable rollback
BRANCH=none
BUG=b:124996507
TEST=make buildall -j
Change-Id: I49f87cb9f6a6551f83f91d55242f2c5c250e8b83
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1681378
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,269 | 29.03.2019 16:14:36 | 25,200 | d2bee5b58542c40abbd66fde8e551823ed8cc64e | hatch_fp: enable fp_sensor task
BRANCH=none
TEST=fpcapture/fpsensor/fpenroll from the console work | [
{
"change_type": "MODIFY",
"old_path": "board/hatch_fp/board.h",
"new_path": "board/hatch_fp/board.h",
"diff": "#define CONFIG_SPI_MASTER\n#define CONFIG_SPI_FP_PORT 0 /* SPI2: first master config */\n#ifdef SECTION_IS_RW\n-/* TODO(b/124773209): Enable FP once rollback code has been fixed */\n-#if 0... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | hatch_fp: enable fp_sensor task
BRANCH=none
BUG=b:124996507
TEST=fpcapture/fpsensor/fpenroll from the console work
Change-Id: I6f481ed6b5185585aa01506e292b6b31e202a3b7
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1558938
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,280 | 27.06.2019 20:25:20 | -28,800 | 40f6e8fbc509e8cc8cc8c0e0f007aaff3a169b06 | krane: remove als mutex
According to the comments in CL:1666260, we don't need it anymore.
TEST=make
BRANCH=master
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "board/kukui/board.c",
"new_path": "board/kukui/board.c",
"diff": "@@ -433,7 +433,6 @@ int board_get_version(void)\n/* Mutexes */\n#ifdef SECTION_IS_RW\nstatic struct mutex g_lid_mutex;\n-static struct mutex g_als_mutex;\nstatic struct bmi160_drv_data_t g_bmi16... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | krane: remove als mutex
According to the comments in CL:1666260, we don't need it anymore.
BUG=b:129430139
TEST=make
BRANCH=master
Change-Id: I98944518e1e70d2a2ea2a607b3dfd478f9c09e55
Signed-off-by: Ting Shen <phoenixshen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1679855
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Yilun Lin <yllin@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org> |
136,396 | 03.07.2019 13:39:43 | 25,200 | c2f4db3edb894355b5be364760c3e7a023b67b20 | Rename CONFIG_CHARGEN to CONFIG_CMD_CHARGEN
The updated name is more is better aligned with EC codebase use of
CONFIG_ variables.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "common/build.mk",
"new_path": "common/build.mk",
"diff": "@@ -41,7 +41,7 @@ common-$(CONFIG_CROS_BOARD_INFO)+=cbi.o\ncommon-$(CONFIG_CHARGE_MANAGER)+=charge_manager.o\ncommon-$(CONFIG_CHARGE_RAMP_HW)+=charge_ramp.o\ncommon-$(CONFIG_CHARGE_RAMP_SW)+=charge_ramp... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Rename CONFIG_CHARGEN to CONFIG_CMD_CHARGEN
The updated name is more is better aligned with EC codebase use of
CONFIG_ variables.
BRANCH=none
BUG=none
TEST=make buildall -j
Change-Id: I52a35e33debb2cab41c009dbb8938614a810baef
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1688134
Reviewed-by: Namyoon Woo <namyoon@chromium.org> |
136,301 | 08.07.2019 13:43:22 | -32,400 | e071079c52d66dbe4f78421540b5cfaf0bb94895 | kohaku: coordinate a rotation matrix for accel sensor
Adjust the rotation matrix for lid accel to fit the kohaku board.
BRANCH=master
TEST=Boot and check if the system keyboard and touchpad work | [
{
"change_type": "MODIFY",
"old_path": "board/kohaku/board.c",
"new_path": "board/kohaku/board.c",
"diff": "@@ -208,9 +208,9 @@ static const mat33_fp_t base_standard_ref = {\n* sure the rotaiton matrix for the lid sensor is correct.\n*/\nstatic const mat33_fp_t lid_standard_ref = {\n- { 0, FLOAT_TO_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kohaku: coordinate a rotation matrix for accel sensor
Adjust the rotation matrix for lid accel to fit the kohaku board.
BUG=b:136626453
BRANCH=master
TEST=Boot and check if the system keyboard and touchpad work
Change-Id: Icd1f634924693b2e951bbb7cf5d090c980fa95b0
Signed-off-by: Inno.Park <ih.yoo.park@samsung.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1686925
Reviewed-by: Furquan Shaikh <furquan@chromium.org> |
136,280 | 09.07.2019 15:48:02 | -28,800 | 5b74f1393a78742b8883f1fc9d00602ad75869e7 | kukui: code cleanup
Remove unused clode blocks and includes.
TEST=make
BRANCH=master
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "board/kukui/battery.c",
"new_path": "board/kukui/battery.c",
"diff": "@@ -262,9 +262,6 @@ DECLARE_HOOK(HOOK_BATTERY_SOC_CHANGE,\nboard_charge_termination,\nHOOK_PRIO_DEFAULT);\n-/* Customs options controllable by host command. */\n-#define PARAM_FASTCHARGE (CS... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui: code cleanup
Remove unused clode blocks and includes.
BUG=None
TEST=make
BRANCH=master
Change-Id: I66994039e4c215ce652cdef227207a6bbd94b316
Signed-off-by: Ting Shen <phoenixshen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1692364
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org> |
136,256 | 08.07.2019 14:12:23 | 21,600 | 8034b2f86690daf458e8881621556a28e5b59a1a | ish: cleanup i2c constants
Rename i2c constants to expose the speed they represent.
BRANCH=none
TEST=builds. arcada i2c bus speed is correct | [
{
"change_type": "MODIFY",
"old_path": "chip/ish/i2c.c",
"new_path": "chip/ish/i2c.c",
"diff": "@@ -50,9 +50,6 @@ static uint16_t default_lcnt_scl_1000[] = {\nstatic uint16_t default_hcnt_scl_hs[] = { 160, 300, 160, 166, 175, 150, 162 };\nstatic uint16_t default_lcnt_scl_hs[] = { 320, 340, 320, 325,... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ish: cleanup i2c constants
Rename i2c constants to expose the speed they represent.
BRANCH=none
BUG=none
TEST=builds. arcada i2c bus speed is correct
Change-Id: If26f4868053f5df0a83bf1f06b62b6969dd5a44f
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1691310
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,201 | 16.07.2019 15:45:55 | 25,200 | ea49cf673af69904efc8873c77f362bae0ab5830 | ectool: put help menu items in alphabetical order
fo* should come before fp*
TEST=print help
Tested-by: Curtis Malainey | [
{
"change_type": "MODIFY",
"old_path": "util/ectool.c",
"new_path": "util/ectool.c",
"diff": "@@ -133,6 +133,8 @@ const char help_str[] =\n\" Reads from EC flash to a file\\n\"\n\" flashwrite <offset> <infile>\\n\"\n\" Writes to EC flash from a file\\n\"\n+ \" forcelidopen <enable>\\n\"\n+ \" Forces... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ectool: put help menu items in alphabetical order
fo* should come before fp*
TEST=print help
Change-Id: Ic8ea8582bd1aebfb389427d959b8819aecb67378
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1703391
Tested-by: Curtis Malainey <cujomalainey@chromium.org>
Auto-Submit: Curtis Malainey <cujomalainey@chromium.org>
Reviewed-by: Jon Flatley <jflat@chromium.org>
Commit-Queue: Jon Flatley <jflat@chromium.org> |
136,230 | 16.07.2019 13:45:43 | 25,200 | 283338b878bf47fe8f371729b399320225472b1b | kohaku: Support SDI battery pack
BRANCH=none
TEST=battery command on EC console
Tested-by: Philip Chen | [
{
"change_type": "MODIFY",
"old_path": "board/kohaku/battery.c",
"new_path": "board/kohaku/battery.c",
"diff": "@@ -60,10 +60,38 @@ const struct board_batt_params board_battery_info[] = {\n.discharging_max_c = 60,\n},\n},\n+ [BATTERY_SDI] = {\n+ .fuel_gauge = {\n+ .manuf_name = \"SDI\",\n+ .device_n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kohaku: Support SDI battery pack
BUG=b:130578043
BRANCH=none
TEST=battery command on EC console
Change-Id: I2518892dac3daeae8734bd3b45f225f4723dc7c6
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1704788
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org> |
136,234 | 15.07.2019 07:13:15 | 25,200 | 5b4d4edff0d4cd6cf0293799e60bda21e9d0155a | cleanup: Segregate USB MUX related drivers in usb_mux folder
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/octopus/variant_usbc_ec_tcpcs.c",
"new_path": "baseboard/octopus/variant_usbc_ec_tcpcs.c",
"diff": "#include \"console.h\"\n#include \"driver/ppc/sn5s330.h\"\n#include \"driver/tcpm/it83xx_pd.h\"\n-#include \"driver/usb_mux_it5205.h\"\n+#include \"dr... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: Segregate USB MUX related drivers in usb_mux folder
BUG=none
BRANCH=none
TEST=make buildall -j
Change-Id: If44a363d1288cbfabe5c6545e550f2b8fc623227
Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1700793
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,252 | 03.07.2019 16:34:00 | -28,800 | 3e8e4db7892acc2d64410ed24f1f0b333d66978b | Helios:Modify lid and base rotation matrix
Depend on placement modify rotation matrix for the lid and base sensor.
BRANCH=ToT
TEST=Manual
Check EC console accleinfo. | [
{
"change_type": "MODIFY",
"old_path": "board/helios/board.c",
"new_path": "board/helios/board.c",
"diff": "@@ -177,18 +177,13 @@ static struct opt3001_drv_data_t g_opt3001_data = {\n/* Matrix to rotate accelrator into standard reference frame */\nstatic const mat33_fp_t base_standard_ref = {\n{ 0, ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Helios:Modify lid and base rotation matrix
Depend on placement modify rotation matrix for the lid and base sensor.
BUG=b:135554555
BRANCH=ToT
TEST=Manual
Check EC console accleinfo.
Change-Id: I287808dde06ff752f9e10766f3c348e0d63606f3
Signed-off-by: Barney_Liao <barney_liao@pegatron.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1687037
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> |
136,331 | 17.07.2019 08:57:48 | 21,600 | f38fff278e84120b3b59ced556ef562f573b45b1 | presubmit: don't require buildall for changes only in docs/
Markdown docs don't affect the build. Make presubmit slightly nicer.
BRANCH=none
TEST=run util/presubmit_check.sh after committing docs/ only changes | [
{
"change_type": "MODIFY",
"old_path": "util/presubmit_check.sh",
"new_path": "util/presubmit_check.sh",
"diff": "@@ -42,6 +42,8 @@ changed=$(echo \"${changed}\" | grep -v util/uart_stress_tester.py)\nchanged=$(echo \"${changed}\" | grep -v util/presubmit_check.sh)\n# Filter out the OWNERS file.\nch... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | presubmit: don't require buildall for changes only in docs/
Markdown docs don't affect the build. Make presubmit slightly nicer.
BUG=none
BRANCH=none
TEST=run util/presubmit_check.sh after committing docs/ only changes
Change-Id: I273dd071e3cf5e859a0a4f0f97e9011cc4391f0d
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1706613
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,287 | 17.07.2019 11:09:50 | 21,600 | 1251719cc5fd3ca23ace14fe627b010e670b3cf9 | baseboard: octopus: Guard sensor configurations with variant
The octopus baseboard should only declare the sensor CONFIG_ values
if we didn't define the NO_SENSORS variant
BRANCH=None
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/octopus/baseboard.h",
"new_path": "baseboard/octopus/baseboard.h",
"diff": "#undef CONFIG_MOTION_SENSE_RESUME_DELAY_US\n#define CONFIG_MOTION_SENSE_RESUME_DELAY_US (10 * MSEC)\n+#ifndef VARIANT_OCTOPUS_NO_SENSORS\n/*\n* Interrupt and fifo are only us... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | baseboard: octopus: Guard sensor configurations with variant
The octopus baseboard should only declare the sensor CONFIG_ values
if we didn't define the NO_SENSORS variant
BUG=b:137758297
BRANCH=None
TEST=buildall
Change-Id: I32443f08ee7d1412b425bd55c8c40d67f22ef089
Signed-off-by: Yuval Peress <peress@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1706687
Reviewed-by: Enrico Granata <egranata@chromium.org> |
136,280 | 03.07.2019 03:56:32 | 0 | 0ae8c5584d3648c76bd8e8fca0a27ae20d1bb761 | krane: Fix g-sensor reference point for all revisions
This should apply to all Kranes.
TEST=factory accelometer test
BRANCH=master | [
{
"change_type": "MODIFY",
"old_path": "board/kukui/board.c",
"new_path": "board/kukui/board.c",
"diff": "@@ -437,21 +437,20 @@ static struct tcs3400_rgb_drv_data_t g_tcs3400_rgb_data = {\n},\n};\n-#ifdef BOARD_KRANE\n/* Matrix to rotate accelerometer into standard reference frame */\n-static const ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | krane: Fix g-sensor reference point for all revisions
This should apply to all Kranes.
BUG=b:131081336
TEST=factory accelometer test
BRANCH=master
Change-Id: I44313d73bf6dd484101973e153c6b5209128a789
Signed-off-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1687832
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,282 | 19.07.2019 10:47:48 | -28,800 | db49bc03b9b816e8c902a48478a18b9abe52b9a7 | garg: add simplo BYD 916Q2294H battery
BRANCH=octopus
TEST=Test on charging/discharging/battery cut off pass. | [
{
"change_type": "MODIFY",
"old_path": "board/garg/battery.c",
"new_path": "board/garg/battery.c",
"diff": "* address, mask, and disconnect value need to be provided.\n*/\nconst struct board_batt_params board_battery_info[] = {\n- /* Simplo 916Q2286H battery information */\n- [BATTERY_SIMPLO] = {\n+... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | garg: add simplo BYD 916Q2294H battery
BUG=b:135986521,b:136786005
BRANCH=octopus
TEST=Test on charging/discharging/battery cut off pass.
Change-Id: Idda1c4bc027b44980e047dc89ccae3c26e23cfbe
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1710208
Reviewed-by: Marco Chen <marcochen@chromium.org> |
136,377 | 24.07.2019 08:21:20 | 25,200 | 701f45f574cfcf9182e89267e5479af5eb709576 | cr50: add closed loop reset print statements
Add some print statements to closed loop reset, so it's easier to tell
what cr50 is doing.
BRANCH=cr50
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/ap_state.c",
"new_path": "board/cr50/ap_state.c",
"diff": "@@ -119,6 +119,7 @@ void tpm_rst_asserted(enum gpio_signal unused)\nset_state(DEVICE_STATE_DEBOUNCING);\nif (waiting_for_ap_reset) {\n+ CPRINTS(\"CL: done\");\nwaiting_for_ap_reset = 0;\ndea... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: add closed loop reset print statements
Add some print statements to closed loop reset, so it's easier to tell
what cr50 is doing.
BUG=none
BRANCH=cr50
TEST=none
Change-Id: I2b6b28d8eabcd8950fe7105b4382d8b8ed94afa6
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1716927
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,427 | 29.07.2019 16:59:10 | 21,600 | 8dcd9a736b7da6c72b468124c3febbe0ede75a4e | Zork: Use more designated initializers.
Use designated initializers for adc_channels, power_signal_list, i2c_ports,
temp_sensors. And minor related tidy up.
BRANCH=none
TEST=make BOARD=trembyle | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "@@ -55,37 +55,106 @@ const int hibernate_wake_pins_used = ARRAY_SIZE(hibernate_wake_pins);\nconst struct adc_t adc_channels[] = {\n[ADC_TEMP_SENSOR_CHARGER] = {\n- \"CHARGER\", NPC... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Zork: Use more designated initializers.
Use designated initializers for adc_channels, power_signal_list, i2c_ports,
temp_sensors. And minor related tidy up.
BUG=none
BRANCH=none
TEST=make BOARD=trembyle
Change-Id: Iee9d2d1d85ec6844d565e89d698d99d40644a088
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1725369
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,324 | 30.07.2019 09:30:55 | 21,600 | aed16e293cb4bd17b301ac9f1508402bcb233bb1 | Trembyle: Add USB-C sink BC12 driver
Hooked in the PI3USB9201 BC12 driver
BRANCH=none
TEST=make BOARD=trembyle | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "#include \"driver/accel_kionix.h\"\n#include \"driver/accel_kx022.h\"\n#include \"driver/accelgyro_bmi160.h\"\n+#include \"driver/bc12/pi3usb9201.h\"\n#include \"driver/tcpm/ps8xxx... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: Add USB-C sink BC12 driver
Hooked in the PI3USB9201 BC12 driver
BUG=b:138600672
BRANCH=none
TEST=make BOARD=trembyle
Change-Id: I849d182063c62539add88b8a2aa73a149dc25c92
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1726330 |
136,427 | 30.07.2019 11:14:35 | 21,600 | fec7f289d57a4382fa508a8f66615d7f9767e99b | Trembyle: Add IO expanders
Add NCT3807 IO expander drivers and GPIO definitions.
BRANCH=none
TEST=make BOARD=trembyle | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "#include \"extpower.h\"\n#include \"gpio.h\"\n#include \"hooks.h\"\n+#include \"ioexpander.h\"\n+#include \"ioexpander_nct38xx.h\"\n#include \"i2c.h\"\n#include \"keyboard_scan.h\"... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: Add IO expanders
Add NCT3807 IO expander drivers and GPIO definitions.
BUG=b:138599199
BRANCH=none
TEST=make BOARD=trembyle
Change-Id: I1257263225b4146a4a87d350921189b90a2b3901
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1726941
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,324 | 31.07.2019 09:39:28 | 21,600 | 92ee51f7cccc65cba40aaf83c761a29013595068 | Trembyle: Add USB-C PPC drivers
Add SN5S330 USB-C PPC drivers
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "#include \"driver/accel_kx022.h\"\n#include \"driver/accelgyro_bmi160.h\"\n#include \"driver/bc12/pi3usb9201.h\"\n+#include \"driver/ppc/sn5s330.h\"\n#include \"driver/tcpm/ps8xxx.... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: Add USB-C PPC drivers
Add SN5S330 USB-C PPC drivers
BUG=b:138599218
BRANCH=none
TEST=make buildall -j
Change-Id: I697dbba1f5c5bbc809e0de9a633d9102596a3a98
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1729529
Commit-Queue: Edward Hill <ecgh@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,324 | 31.07.2019 11:10:19 | 21,600 | 298abea55f87163aa0b4fd752f834751a31cf07f | Trembyle: Fix USB-C TCPC drivers
Add NCT3807 USB-C TCPC drivers
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "#include \"driver/bc12/pi3usb9201.h\"\n#include \"driver/ppc/sn5s330.h\"\n#include \"driver/tcpm/ps8xxx.h\"\n+#include \"driver/tcpm/nct38xx.h\"\n#include \"driver/temp_sensor/sb_t... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: Fix USB-C TCPC drivers
Add NCT3807 USB-C TCPC drivers
BUG=b:138600238,b:138599948
BRANCH=none
TEST=make buildall -j
Change-Id: Id98df51748beb60e787350265127936b18f4cf46
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1728478
Commit-Queue: Edward Hill <ecgh@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,324 | 05.08.2019 07:38:52 | 21,600 | c5e34fe248736e5a0b2a0d7388d2f996c6b081ff | Trembyle: implement system_get_sku_id
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "@@ -591,10 +591,11 @@ void lid_angle_peripheral_enable(int enable)\n}\n#endif\n+static uint32_t sku_id;\n+\nstatic void cbi_init(void)\n{\nuint32_t board_version = 0;\n- uint32_t s... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: implement system_get_sku_id
BUG=b:138600504
BRANCH=none
TEST=make buildall -j
Change-Id: Ibaa43ae3976c171fc715aef380e0f9f26951b432
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1736695
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,324 | 05.08.2019 08:46:03 | 21,600 | ba753b782a65b2532a3d4682df76f0fbdbe7e2f5 | Trembyle: implement board_set_active_charge_port
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "#include \"usbc_ppc.h\"\n#include \"util.h\"\n+#define CPRINTSUSB(format, args...) cprints(CC_USBCHARGE, format, ## args)\n+#define CPRINTFUSB(format, args...) cprintf(CC_USBCHARGE... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: implement board_set_active_charge_port
BUG=b:138599952
BRANCH=none
TEST=make buildall -j
Change-Id: I82ef7cad0cd6d91d1e4bbcc0d1a2d312dd773e8f
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1736797
Commit-Queue: Edward Hill <ecgh@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,324 | 05.08.2019 10:48:24 | 21,600 | 6b6fd843dbc3e04697992a1717950294cd53e64b | Trembyle: update usb_pd_policy
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.h",
"new_path": "baseboard/zork/baseboard.h",
"diff": "#define CONFIG_USB_PD_DUAL_ROLE\n#define CONFIG_USB_PD_DUAL_ROLE_AUTO_TOGGLE\n#define CONFIG_USB_PD_LOGGING\n+#define CONFIG_USB_PD_MAX_SINGLE_SOURCE_CURRENT TYPEC_RP_3A0\n#define ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: update usb_pd_policy
BUG=b:138599669
BRANCH=none
TEST=make buildall -j
Change-Id: I125a40e316f4d6431412851bd6bd3c8c57118365
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1737132
Commit-Queue: Edward Hill <ecgh@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,286 | 25.07.2019 11:23:09 | -28,800 | d3c9b9d123514742f1b5bed5d0ed9f379147b84b | Hatch: Enable CBI info of board sku
This patch enables get board sku
BRANCH=master
TEST=None
Tested-by: David Huang | [
{
"change_type": "MODIFY",
"old_path": "baseboard/hatch/baseboard.c",
"new_path": "baseboard/hatch/baseboard.c",
"diff": "#include \"charge_state_v2.h\"\n#include \"chipset.h\"\n#include \"console.h\"\n+#include \"cros_board_info.h\"\n#include \"driver/ppc/sn5s330.h\"\n#include \"driver/tcpm/anx7447... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Hatch: Enable CBI info of board sku
This patch enables get board sku
BUG=b:138326244
BRANCH=master
TEST=None
Change-Id: I489de71c75804dd460bda98fa1c49b94c91c8a12
Signed-off-by: ben.chen2@quanta.corp-partner.google.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1716674
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Tested-by: David Huang <David.Huang@quantatw.com>
Commit-Queue: Tim Wawrzynczak <twawrzynczak@chromium.org> |
136,269 | 13.06.2019 11:24:19 | 25,200 | 6f76b0a778ee95f82a947aa7d887b1dbb2bc6ac4 | docs: Add fingerprint (FPMCU) docs
BRANCH=none
TEST=make buildall -j
TEST=View Markdown Preview in CLion
TEST=View Markdown in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/sitemap.md",
"new_path": "docs/sitemap.md",
"diff": "* [Getting Started Quickly](./getting_started_quickly.md)\n* [Core Runtime](./core_runtime.md)\n+* [Write Protection](./write_protection.md)\n## Case Closed Debugging (CCD)\n* [Case Closed Debugging Ove... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: Add fingerprint (FPMCU) docs
BRANCH=none
BUG=chromium:973205
TEST=make buildall -j
TEST=View Markdown Preview in CLion
TEST=View Markdown in gitiles
Change-Id: I64c6060bdf41f69af05a8ffd64d437fb1fd2b507
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1658525
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> |
136,443 | 02.07.2019 10:13:32 | 25,200 | 4c0a361192cca27a301c869cd406fd29843a8187 | Fix typo and clarify doc in fpsensor.h and gpio.wrap
This also brings some minor Doxygen formatting to gpio.wrap.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "include/fpsensor.h",
"new_path": "include/fpsensor.h",
"diff": "/* 8-bit greyscale pixel format as defined by V4L2 headers */\n#define V4L2_PIX_FMT_GREY FOURCC('G', 'R', 'E', 'Y')\n-/* --- fonctions provided by the sensor-specific driver --- */\n+/* --- functi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Fix typo and clarify doc in fpsensor.h and gpio.wrap
This also brings some minor Doxygen formatting to gpio.wrap.
BRANCH=none
BUG=chromium:991365
TEST=make buildall -j
Change-Id: Id6d85263b6ac472b0961240ebb266dd22591d68b
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1685772
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,324 | 06.08.2019 14:38:20 | 21,600 | 2eea4a541cb26c30211d1ed014a113db1a482814 | Trembyle: add fan support
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "#include \"driver/temp_sensor/sb_tsi.h\"\n#include \"ec_commands.h\"\n#include \"extpower.h\"\n+#include \"fan.h\"\n+#include \"fan_chip.h\"\n#include \"gpio.h\"\n#include \"hooks.... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: add fan support
BUG=b:138600244
BRANCH=none
TEST=make buildall -j
Change-Id: Ibaf217e9fccf76dff6b70ae529e089367db89221
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1742039
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,324 | 07.08.2019 10:52:50 | 21,600 | 46ebe63f911331c2db73b65e90f52c0a76476443 | isl9241: add charger_get_vbus_voltage
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.h",
"new_path": "baseboard/zork/baseboard.h",
"diff": "#define CONFIG_USB_PD_TCPM_TCPCI\n#define CONFIG_USB_PD_TRY_SRC\n#define CONFIG_USB_PD_VBUS_DETECT_PPC\n-#define CONFIG_USB_PD_VBUS_MEASURE_CHARGER\n#define CONFIG_USBC_PPC\n#defin... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | isl9241: add charger_get_vbus_voltage
BUG=b:138600692
BRANCH=none
TEST=make buildall -j
Change-Id: Idd20b1833945e37a84db4e7c444d8974f6059f83
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1742532
Commit-Queue: Edward Hill <ecgh@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,324 | 08.08.2019 10:18:58 | 21,600 | 4923a80456d22564077f8d0ddda736147780af92 | Trembyle: enable throttle ap to allow the system to use fan
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.h",
"new_path": "baseboard/zork/baseboard.h",
"diff": "#define CONFIG_BACKLIGHT_LID\n#define CONFIG_BACKLIGHT_LID_ACTIVE_LOW\n#define CONFIG_CMD_AP_RESET_LOG\n+#define CONFIG_CPU_PROCHOT_ACTIVE_LOW\n#define CONFIG_EC_FEATURE_BOARD_OVER... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: enable throttle ap to allow the system to use fan
BUG=b:138600244
BRANCH=none
TEST=make buildall -j
Change-Id: I31b662bbd14388e238d1bd4fd1b5597824dd5749
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1741300
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org> |
136,311 | 06.08.2019 15:21:13 | 21,600 | 278bbbd7a7ce365b7500d0c97e24ffdc4a1c48dc | doc: Add documentation for EC terms
Add documentation for acronyms and technologies used in the EC codebase.
BRANCH=none
TEST=run md_browser.py against changes | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "docs/ec_terms.md",
"diff": "+# EC Acronyms and Technologies\n+\n+## Glossary\n+\n+* **ACCEL - Accelerometer**<a name=\"accel\"></a>\n+\n+ A sensor that measures acceleration, typically over 3-axis. Nominally\n+ provides information about the ori... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | doc: Add documentation for EC terms
Add documentation for acronyms and technologies used in the EC codebase.
BRANCH=none
BUG=none
TEST=run md_browser.py against changes
Change-Id: I2ccc6e7c0c60144ded2e7b8cc171fa2a2897d006
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1740080
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,311 | 08.08.2019 15:46:01 | 21,600 | cbab6baa77eff6d62f21145a85e9ce5dd379278f | doc: switch to markdown anchors
Switch from HTML to markdown anchors for linked references.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "docs/ec_terms.md",
"new_path": "docs/ec_terms.md",
"diff": "## Glossary\n-* **ACCEL - Accelerometer**<a name=\"accel\"></a>\n+* **ACCEL - Accelerometer**{#accel}\nA sensor that measures acceleration, typically over 3-axis. Nominally\nprovides information about... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | doc: switch to markdown anchors
Switch from HTML to markdown anchors for linked references.
BUG=none
BRANCH=none
TEST=none
Change-Id: Ibd032e58cb0bea9234713fa3082db8fb3e259153
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1745346
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,256 | 31.07.2019 09:10:42 | 21,600 | 4d7535975638834bcebda50424bff2e23262fc83 | test: use new TEST_EQ for usb tests
BRANCH=none
TEST=builds and passes. Error have better message now | [
{
"change_type": "MODIFY",
"old_path": "test/usb_sm_framework_h3.c",
"new_path": "test/usb_sm_framework_h3.c",
"diff": "@@ -649,81 +649,82 @@ static int sm_test_C_exit(int port)\nreturn 0;\n}\n+static void run_sm(void)\n+{\n+ task_wake(TASK_ID_TEST);\n+ task_wait_event(5 * MSEC);\n+}\n+\n#if defined... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test: use new TEST_EQ for usb tests
BRANCH=none
BUG=none
TEST=builds and passes. Error have better message now
Change-Id: I606f6d0711ac1333ce8974449751bd8fed31d22d
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1733741
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,256 | 08.08.2019 09:28:03 | 21,600 | a34c6b36d254ad7f537976ba5a3b18844c25e1dc | usb: fix issue with CC line interpretation as DTS
We need to pass both cc1 and cc2 into the get current limit
function.
BRANCH=none
TEST=unit test pass still | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"new_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"diff": "@@ -761,20 +761,18 @@ void pd_prevent_low_power_mode(int port, int prevent)\nstatic void sink_power_sub_states(int port)\n{\n- int cc1;\n- int cc2;\n+ int c... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb: fix issue with CC line interpretation as DTS
We need to pass both cc1 and cc2 into the get current limit
function.
BRANCH=none
BUG=none
TEST=unit test pass still
Change-Id: I123fb315948ee042ad1ea05bb835e618f4ca31de
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1744653
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,258 | 06.08.2019 14:43:55 | 21,600 | c5943df788164d0d2c8e984f72af594542244403 | thermistor: update Steinhart-Hart equations
Add support for 30.9K pull-up on resistor divider with the 47K
thermistor.
BRANCH=none
TEST=Rebuild EC and flash | [
{
"change_type": "MODIFY",
"old_path": "driver/temp_sensor/thermistor.c",
"new_path": "driver/temp_sensor/thermistor.c",
"diff": "@@ -66,7 +66,8 @@ int thermistor_linear_interpolate(uint16_t mv,\n#if defined(CONFIG_STEINHART_HART_3V3_51K1_47K_4050B) || \\\ndefined(CONFIG_STEINHART_HART_3V3_13K7_47K_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | thermistor: update Steinhart-Hart equations
Add support for 30.9K pull-up on resistor divider with the 47K
thermistor.
BRANCH=none
BUG=b:124316213
TEST=Rebuild EC and flash
Change-Id: I5bc72fa67549ab15c0e4e1b0291eb934990ee61b
Signed-off-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1742914
Reviewed-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,258 | 09.08.2019 09:08:23 | 21,600 | bdffc31c6a3dbb692229df7a5d3a58c163fe74c4 | kohaku: update for 30.9K resistor in thermistor divider
The resistor divider on Kohaku for the temperature sensors has
been changed to a 30.9K pull-up with the same 47K thermistor.
BRANCH=none
TEST=Rebuild EC and flash | [
{
"change_type": "MODIFY",
"old_path": "board/kohaku/board.c",
"new_path": "board/kohaku/board.c",
"diff": "@@ -378,12 +378,12 @@ BUILD_ASSERT(ARRAY_SIZE(adc_channels) == ADC_CH_COUNT);\nconst struct temp_sensor_t temp_sensors[] = {\n[TEMP_SENSOR_1] = {.name = \"Temp1\",\n.type = TEMP_SENSOR_TYPE_BO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kohaku: update for 30.9K resistor in thermistor divider
The resistor divider on Kohaku for the temperature sensors has
been changed to a 30.9K pull-up with the same 47K thermistor.
BRANCH=none
BUG=b:124316213
TEST=Rebuild EC and flash
Change-Id: Ida61cc448ece42dbd026846b27fd861054e66189
Signed-off-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1745357
Reviewed-by: Scott Collyer <scollyer@chromium.org> |
136,427 | 09.08.2019 14:21:49 | 21,600 | f4f6504e1f6ea524e4703519c1c0c891a96ed0f7 | Trembyle: Set GPIO pullup and voltage
Add GPIO_PULL_UP and GPIO_SEL_1P8V to GPIOs as needed.
BRANCH=none
TEST=make BOARD=trembyle | [
{
"change_type": "MODIFY",
"old_path": "board/trembyle/gpio.inc",
"new_path": "board/trembyle/gpio.inc",
"diff": "@@ -12,6 +12,8 @@ GPIO_INT(USB_C0_TCPC_INT_ODL, PIN(3, 4), GPIO_INT_FALLING, tcpc_alert_event)\nGPIO_INT(USB_C1_TCPC_INT_ODL, PIN(F, 1), GPIO_INT_FALLING, tcpc_alert_event)\nGPIO_INT(USB... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: Set GPIO pullup and voltage
Add GPIO_PULL_UP and GPIO_SEL_1P8V to GPIOs as needed.
BUG=b:138615773 b:138617417
BRANCH=none
TEST=make BOARD=trembyle
Change-Id: I80401c1cee181acc2df7fb41a5f32ea8c3076a14
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1747006
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,230 | 02.08.2019 14:13:58 | 25,200 | f21845b628b79c3ecbe460d900670757449225ab | cbi-util: Remove OEM_ID from required fields
BRANCH=none
TEST=successfully create a cbi image w/o OEM_ID set
Tested-by: Philip Chen | [
{
"change_type": "MODIFY",
"old_path": "util/cbi-util.c",
"new_path": "util/cbi-util.c",
"diff": "#define ARGS_MASK_BOARD_VERSION BIT(0)\n#define ARGS_MASK_FILENAME BIT(1)\n-#define ARGS_MASK_OEM_ID BIT(2)\n-#define ARGS_MASK_SIZE BIT(3)\n-#define ARGS_MASK_SKU_ID BIT(4)\n+#define ARGS_MASK_SIZE BIT... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cbi-util: Remove OEM_ID from required fields
BUG=b:138663009
BRANCH=none
TEST=successfully create a cbi image w/o OEM_ID set
Change-Id: Ic2b96f6d6f02a433de4f2ddc0777035369fd9c4a
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1734007
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org> |
136,324 | 09.08.2019 10:59:03 | 21,600 | bb7c26f3d4172e715e277f9b0f03c45e3131e917 | Trembyle: Change port 1 PPC to NX20P3483
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "#include \"driver/accel_kx022.h\"\n#include \"driver/accelgyro_bmi160.h\"\n#include \"driver/bc12/pi3usb9201.h\"\n+#include \"driver/ppc/nx20p348x.h\"\n#include \"driver/ppc/sn5s33... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: Change port 1 PPC to NX20P3483
BUG=b:138599218
BRANCH=none
TEST=make buildall -j
Change-Id: If68259e289a2b3e052028ff0b2ffd59076eaf970
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1745569
Commit-Queue: Edward Hill <ecgh@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,377 | 06.08.2019 14:02:22 | 25,200 | 2d43cd05ccae236650f3d69566c9ec33098c0d02 | gsctool: add support for endorsement seed vc
Add support for getting and setting the endorsement key using the vendor
command.
BRANCH=none
TEST=Get/Set endorsement seed using vendor command.
Legacy-Commit-Queue: Commit Bot | [
{
"change_type": "MODIFY",
"old_path": "extra/usb_updater/gsctool.c",
"new_path": "extra/usb_updater/gsctool.c",
"diff": "@@ -262,6 +262,8 @@ static const struct option_container cmd_line_options[] = {\n\"Corrupt the inactive rw\"},\n{{\"device\", required_argument, NULL, 'd'},\n\" VID:PID%USB devic... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | gsctool: add support for endorsement seed vc
Add support for getting and setting the endorsement key using the vendor
command.
BUG=b:138943966
BRANCH=none
TEST=Get/Set endorsement seed using vendor command.
Change-Id: I5c2f5d9efa0fbc236731430cac650785693c8db8
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1740076
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,377 | 07.08.2019 14:14:38 | 25,200 | 95d43c00aeead373dca72c814bd6109b39668386 | gsctool: print devid in image version output
If the image is node locked to a devid, print that information in the
'-b' output.
BRANCH=none
TEST=get version output of node locked and prod signed image.
Legacy-Commit-Queue: Commit Bot | [
{
"change_type": "MODIFY",
"old_path": "extra/usb_updater/gsctool.c",
"new_path": "extra/usb_updater/gsctool.c",
"diff": "@@ -1454,6 +1454,10 @@ static int show_headers_versions(const void *image, bool show_machine_output)\nchar ro_fw_ver[kNumSlots][MAX_FW_VER_LENGTH];\nchar rw_fw_ver[kNumSlots][MAX... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | gsctool: print devid in image version output
If the image is node locked to a devid, print that information in the
'-b' output.
BUG=none
BRANCH=none
TEST=get version output of node locked and prod signed image.
Change-Id: I0db2828d7bd699013ec84467c7e2a4b918bd7b27
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1742913
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org> |
136,324 | 13.08.2019 09:56:26 | 21,600 | e86d9393ba8cdd7e54e9b03805397f37351c4c6e | Trembyle: enable external 32K crystal osc
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.h",
"new_path": "baseboard/zork/baseboard.h",
"diff": "#define CONFIG_CHIPSET_CAN_THROTTLE\n#define CONFIG_CHIPSET_RESET_HOOK\n+/* Use external 32kHz OSC as LFCLK source */\n+#define CONFIG_CLOCK_SRC_EXTERNAL\n+\n#undef CONFIG_EXTPOWER... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: enable external 32K crystal osc
BUG=b:138601174
BRANCH=none
TEST=make buildall -j
Change-Id: Ic2b285a0d1c1f4a43b62bee3db760fedae3bfe6f
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1752599
Commit-Queue: Edward Hill <ecgh@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,269 | 08.08.2019 12:15:17 | 25,200 | a3f937bf0e6301c302c050ddd7f7a97dbd9cb4a0 | docs: Add fingerprint docs for partners
BRANCH=none
TEST=View in gitiles | [
{
"change_type": "ADD",
"old_path": "docs/images/dragonclaw.jpg",
"new_path": "docs/images/dragonclaw.jpg",
"diff": "Binary files /dev/null and b/docs/images/dragonclaw.jpg differ\n"
},
{
"change_type": "ADD",
"old_path": "docs/images/dragonclaw_yoshi_flex_header.jpg",
"new_path": "d... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: Add fingerprint docs for partners
BRANCH=none
BUG=none
TEST=View in gitiles
Change-Id: Ie1dc7ea93f3471dd10863e546b4a9dc001e7f3c1
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1742878
Reviewed-by: Nicolas Norvez <norvez@chromium.org> |
136,287 | 13.08.2019 09:47:25 | 21,600 | 5acd037d36194ff9e9b7184f00e9e538f9683dce | test: Update TEST_EQ to using string format specifier
BRANCH=None
TEST=builds and all tests pass | [
{
"change_type": "MODIFY",
"old_path": "include/test_util.h",
"new_path": "include/test_util.h",
"diff": "if (!((a) op (b))) { \\\nccprintf(\"%d: ASSERSION failed: %s \" #op \" %s\\n\", \\\n__LINE__, #a, #b); \\\n- ccprintf(\"\\t\\tEVAL: \" #fmt \" \" #op \" \" #fmt \"\\n\", \\\n+ ccprintf(\"\\t\\tE... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test: Update TEST_EQ to using string format specifier
BRANCH=None
BUG=None
TEST=builds and all tests pass
Change-Id: Idbb288d8f422b4c01fe27c989bdf1188df509a27
Signed-off-by: Yuval Peress <peress@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1752204
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,197 | 08.08.2019 09:56:09 | -28,800 | 2a6b114c3aa1e24f2fc060bd36e1187faaae073a | hammer: Add magnemite board
A close hammer derivative.
BRANCH=none
TEST=make BOARD=magnemite -j
Flash into staff, see the board boot:
util/flash_ec --board=magnemite --port=9000 | [
{
"change_type": "MODIFY",
"old_path": "board/hammer/board.c",
"new_path": "board/hammer/board.c",
"diff": "@@ -85,6 +85,7 @@ void usb_spi_board_enable(struct usb_spi_config const *config) {}\nvoid usb_spi_board_disable(struct usb_spi_config const *config) {}\n#endif /* !HAS_SPI_TOUCHPAD */\n+#ifdef... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | hammer: Add magnemite board
A close hammer derivative.
BRANCH=none
BUG=b:138968914
TEST=make BOARD=magnemite -j
Flash into staff, see the board boot:
util/flash_ec --board=magnemite --port=9000
Change-Id: Ibe5c3f4b0fb4a31d4667d5dc4d76a691b0e64e39
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1741599
Reviewed-by: Yilun Lin <yllin@chromium.org> |
136,438 | 01.08.2019 13:16:23 | 25,200 | df805d082e0272060d2761bfb065b8421a8eabd9 | common: Prepare always_memset()
Add a config for using always_memset() from third_party/cryptoc
BRANCH=nocturne
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "board/hatch_fp/board.h",
"new_path": "board/hatch_fp/board.h",
"diff": "#define CONFIG_RNG\n+#define CONFIG_ALWAYS_MEMSET\n+\n#define CONFIG_CMD_FLASH\n#define CONFIG_CMD_SPI_XFER\n"
},
{
"change_type": "MODIFY",
"old_path": "board/nocturne_fp/boar... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: Prepare always_memset()
Add a config for using always_memset() from third_party/cryptoc
BRANCH=nocturne
BUG=chromium:968809,chromium:989594,b:130238794
TEST=make -j buildall
Change-Id: I22c83512eb1b8bdc8dac1b26315d25b65831513c
Signed-off-by: Yicheng Li <yichengli@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1731543
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org> |
136,256 | 08.08.2019 10:06:40 | 21,600 | a0ed5aebb22c4d9b83c257b4127a1df372751e14 | usb: de-dup common code from old and new PD stack
We still need to pull out more common code between the two stacks, but
this is scaffolding with a few examples.
BRANCH=none
TEST=unit tests pass | [
{
"change_type": "MODIFY",
"old_path": "baseboard/kalista/baseboard.h",
"new_path": "baseboard/kalista/baseboard.h",
"diff": "@@ -230,7 +230,6 @@ enum OEM_ID {\n/* Board specific handlers */\nvoid board_reset_pd_mcu(void);\nvoid board_set_tcpc_power_mode(int port, int mode);\n-int board_get_battery_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb: de-dup common code from old and new PD stack
We still need to pull out more common code between the two stacks, but
this is scaffolding with a few examples.
BRANCH=none
BUG=b:137493121
TEST=unit tests pass
Change-Id: Ibd9dda1e544e06f02aa3dde48ca7de1539700cfa
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1744655
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,256 | 02.08.2019 16:02:02 | 21,600 | 9647355905baf0d162b51d604c3973ffdc248a90 | usb: remove state transitions in exit
If we transition to a new state in exit, then the
original state we are transitioning to is lost. The
new state machine common code will warn in this scenario.
BRANCH=none
TEST=builds | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_tc_ctvpd_sm.c",
"new_path": "common/usbc/usb_tc_ctvpd_sm.c",
"diff": "@@ -138,7 +138,6 @@ static int tc_disabled_exit(int port)\n}\n#endif\nCPRINTS(\"TCPC p%d resumed!\", port);\n- sm_set_state(port, TC_OBJ(port), tc_unattached_snk);\nreturn 0;... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb: remove state transitions in exit
If we transition to a new state in exit, then the
original state we are transitioning to is lost. The
new state machine common code will warn in this scenario.
BRANCH=none
BUG=none
TEST=builds
Change-Id: I571ff62dd6969bd3743cf33ae5c56dc02ae59724
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1733742
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,256 | 02.08.2019 16:16:22 | 21,600 | d7bb1b0e0a24571f01ca048185bd8b9d882c4f8f | usb: state machines will resume immediately
Instead of waiting for one iteration to resume when we enable it,
restart the state machine immediately
BRANCH=none
TEST=build and units tests | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_pe_ctvpd_sm.c",
"new_path": "common/usbc/usb_pe_ctvpd_sm.c",
"diff": "/* USB Policy Engine Charge-Through VCONN Powered Device module */\n/* Policy Engine Flags */\n-#define PE_FLAGS_MSG_RECEIVED (1 << 0)\n-\n-enum l_state {\n- PE_INIT,\n- PE_R... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb: state machines will resume immediately
Instead of waiting for one iteration to resume when we enable it,
restart the state machine immediately
BRANCH=none
BUG=none
TEST=build and units tests
Change-Id: I6e1d1b281798ad8bd67fb552d4e2c2b36859a7f9
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1733743
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,427 | 15.08.2019 15:06:36 | 21,600 | a1aea89ae15c85d56f52976289a329e7c58bc8f6 | Trembyle: Make GPIO names match schematic
BRANCH=none
TEST=make BOARD=trembyle | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "@@ -111,57 +111,57 @@ const struct i2c_port_t i2c_ports[] = {\n.name = \"tcpc0\",\n.port = I2C_PORT_TCPC0,\n.kbps = 400,\n- .scl = GPIO_I2C0_SCL,\n- .sda = GPIO_I2C0_SDA,\n+ .scl =... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: Make GPIO names match schematic
BUG=none
BRANCH=none
TEST=make BOARD=trembyle
Change-Id: I870bb384e59468c91ad19ebfbdf6d376438ae7ba
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1755648
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,256 | 06.08.2019 14:15:30 | 21,600 | 72405bceb4f8234ad1dc4a64041c0037abd57a21 | test: test nested entry/run calls to set_state
Ensure that a call to set_state will stop the chain of
entry or run calls in parent/child states.
BRANCH=none
TEST=run unit test | [
{
"change_type": "MODIFY",
"old_path": "test/usb_sm_framework_h3.c",
"new_path": "test/usb_sm_framework_h3.c",
"diff": "@@ -140,21 +140,19 @@ enum state {\n};\nstatic const struct usb_state states[];\n+static struct control {\n+ usb_state_ptr a3_entry_to;\n+ usb_state_ptr b3_run_to;\n+ usb_state_ptr... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test: test nested entry/run calls to set_state
Ensure that a call to set_state will stop the chain of
entry or run calls in parent/child states.
BRANCH=none
BUG=none
TEST=run unit test
Change-Id: I38a6eefeb728403503fee5455ed3ec065747a760
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1744656
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,256 | 08.08.2019 09:35:54 | 21,600 | 6d8a5d3f207af7481e2aa114d306f8448d21b74f | test: add baseline test for TC_DRP_TRYSRC SM
BRANCH=none
TEST=unit test pass | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"new_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"diff": "@@ -1706,3 +1706,15 @@ static const struct usb_state tc_states[] = {\n},\n#endif /* CONFIG_USB_PD_TRY_SRC */\n};\n+\n+#ifdef TEST_BUILD\n+const struct test_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test: add baseline test for TC_DRP_TRYSRC SM
BRANCH=none
BUG=none
TEST=unit test pass
Change-Id: I0ecb9f0298fd43ca0db800311a309d98eb1e29b5
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1744658
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,311 | 15.08.2019 15:58:34 | 21,600 | d85f03e3015addc5f7b96b36b2a1d43147f4dae4 | Volteer: Add initial AP signals
Enable ESPI interface and support for IceLake chipset. Configure reset
and power button signals.
BRANCH=none
TEST=make BOARD=volteer | [
{
"change_type": "MODIFY",
"old_path": "baseboard/volteer/baseboard.h",
"new_path": "baseboard/volteer/baseboard.h",
"diff": "#define CONFIG_VSTORE_SLOT_COUNT 1\n/* Host communication */\n+#define CONFIG_HOSTCMD_ESPI\n/* Chipset config */\n+/* TODO - replace with TigerLake once the changes land */\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Volteer: Add initial AP signals
Enable ESPI interface and support for IceLake chipset. Configure reset
and power button signals.
BUG=none
BRANCH=none
TEST=make BOARD=volteer
Change-Id: I6f06a71fc2516781fe3c23b997310a960e6e0bb8
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1758533
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
136,311 | 15.08.2019 13:06:20 | 21,600 | d3784365bf1633dddd6671ee0c5322e87ada9db7 | Volteer: add I2C bus configuration
Configure I2C pins and i2c_ports for Volteer
BRANCH=none
TEST=make BOARD=volteer, make buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/volteer/baseboard.c",
"new_path": "baseboard/volteer/baseboard.c",
"diff": "/* Volteer family-specific configuration */\n#include \"gpio.h\"\n+#include \"i2c.h\"\n/******************************************************************************/\n/* Wa... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Volteer: add I2C bus configuration
Configure I2C pins and i2c_ports for Volteer
BUG=none
BRANCH=none
TEST=make BOARD=volteer, make buildall
Change-Id: I3834a18a94565566b839d1e34befb180a366177c
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1758534
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
136,311 | 13.08.2019 17:07:04 | 21,600 | 0596ecd75a278f0079b09646c95256fe063705fc | doc: Update EC terms
Add more EC definitions. Correct the named anchors in the USB-C
markdown. And a link from the main EC readme.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -45,6 +45,9 @@ running on several different MCUs on Chrome OS devices with various tweaks\nconfusing, so try to be specific and use terms like FPMCU to distinguish the\nfingerprint MCU from \"the EC\".\n+See the... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | doc: Update EC terms
Add more EC definitions. Correct the named anchors in the USB-C
markdown. And a link from the main EC readme.
BUG=none
BRANCH=none
TEST=none
Change-Id: Ica7e7c270373589d850166539fb1b13b1ddbd7e0
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1758826
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,282 | 19.08.2019 19:22:22 | -28,800 | 47a5e51e4a9d0a560da7040b05e3997746629753 | blooglet: remove kbbacklight support with non-kbbacklight SKU.
BRANCH=octopus
TEST=make sure ectool inventory doesn't show keyboard backlight support
with non-kbbacklight SKU. | [
{
"change_type": "MODIFY",
"old_path": "board/bloog/board.c",
"new_path": "board/bloog/board.c",
"diff": "@@ -317,7 +317,8 @@ uint32_t board_override_feature_flags0(uint32_t flags0)\n/*\n* Remove keyboard backlight feature for devices that don't support it.\n*/\n- if (sku_id == 33 || sku_id == 36 ||... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | blooglet: remove kbbacklight support with non-kbbacklight SKU.
BUG=b:138180187
BRANCH=octopus
TEST=make sure ectool inventory doesn't show keyboard backlight support
with non-kbbacklight SKU.
Change-Id: Iac1c9b19e139641b88a0407189608dcc2bbfc360
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1760659
Reviewed-by: Justin TerAvest <teravest@chromium.org> |
136,234 | 16.08.2019 16:09:18 | 25,200 | 456d7da2c104fd5783a380e8bb6616de0d07e08c | ectool: Update usbpdmuxinfo to latest changes
BRANCH=none
TEST=Manually tested on intelrvp, "ectool usbpdmuxinfo"
command shows correct SS mux info | [
{
"change_type": "MODIFY",
"old_path": "util/ectool.c",
"new_path": "util/ectool.c",
"diff": "@@ -5605,17 +5605,13 @@ int cmd_usb_pd_mux_info(int argc, char *argv[])\nreturn rv;\nprintf(\"Port %d: \", i);\n- if (r.flags & USB_PD_MUX_USB_ENABLED)\n- printf(\"USB \");\n- if (r.flags & USB_PD_MUX_DP_EN... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ectool: Update usbpdmuxinfo to latest changes
BUG=b:139140865
BRANCH=none
TEST=Manually tested on intelrvp, "ectool usbpdmuxinfo"
command shows correct SS mux info
Change-Id: Id9dc616f62cb88600c3bcb631c08423661cc32c8
Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1759279
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,278 | 16.08.2019 17:32:44 | 25,200 | 3a2044d812f26a1ac0302a5eeb66eaf9433e78ba | atlas: remove dead BMI160 code
atlas does not have a BMI160, so remove legacy references to it.
BRANCH=none
TEST=compiles. | [
{
"change_type": "MODIFY",
"old_path": "board/atlas/board.c",
"new_path": "board/atlas/board.c",
"diff": "#include \"charge_state.h\"\n#include \"chipset.h\"\n#include \"console.h\"\n-#include \"driver/accelgyro_bmi160.h\"\n#include \"driver/als_opt3001.h\"\n#include \"driver/pmic_bd99992gw.h\"\n#in... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | atlas: remove dead BMI160 code
atlas does not have a BMI160, so remove legacy references to it.
BUG=b:129078548
BRANCH=none
TEST=compiles.
Change-Id: Iadc3b9b885b4436f9e800110cd05d7d1f41b01cf
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1759351
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org> |
136,280 | 26.07.2019 12:13:52 | -28,800 | 7e26c7c66898d1e4609184ae2fa207cddbf0c4fb | jacuzzi: enable usb-a port power on S3
TEST=verify that usb keyboard works without manually enable EN_USBA_5V
BRANCH=master
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "board/jacuzzi/board.c",
"new_path": "board/jacuzzi/board.c",
"diff": "@@ -256,3 +256,17 @@ int charger_is_sourcing_otg_power(int port)\n{\nreturn 0;\n}\n+\n+/* Called on AP S5 -> S3 transition */\n+static void board_chipset_startup(void)\n+{\n+ gpio_set_level(... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | jacuzzi: enable usb-a port power on S3
BUG=b:135895590
TEST=verify that usb keyboard works without manually enable EN_USBA_5V
BRANCH=master
Change-Id: I008936f9082e3363ea296615abdd57b8a5fb0378
Signed-off-by: Ting Shen <phoenixshen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1718630
Tested-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Alexandru M Stan <amstan@chromium.org>
Reviewed-by: Alexandru M Stan <amstan@chromium.org> |
136,208 | 16.08.2019 16:15:59 | -28,800 | 9bbfd9142d39d030bc29dd40a15a29b35cf86b61 | strago: Enable LTO to save flash space.
strago's flash is going to running out.
This CL enable LTO to save spaces.
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "board/strago/board.h",
"new_path": "board/strago/board.h",
"diff": "#define CONFIG_POWER_COMMON\n#define CONFIG_POWER_SHUTDOWN_PAUSE_IN_S5\n#define CONFIG_EXTPOWER_GPIO\n+#define CONFIG_LTO\n/* All data won't fit in data RAM. So, moving boundary slightly. */\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | strago: Enable LTO to save flash space.
strago's flash is going to running out.
This CL enable LTO to save spaces.
TEST=make buildall
BUG=none
BRANCH=none
Change-Id: Id2742c959d1d249d3c90dda1568c5f1a1cc6d187
Signed-off-by: Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1757594
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,414 | 12.08.2019 15:54:40 | -28,800 | 84ba4bb756187dac279c70fe6915e3437199d040 | cr50: Delete legacy U2F implementation
This implementation has been replaced, and is no
longer needed. Removing it frees 2376 bytes in flash.
BRANCH=none
TEST=test_that ... firmware_IntegratedU2F | [
{
"change_type": "MODIFY",
"old_path": "board/cr50/u2f.c",
"new_path": "board/cr50/u2f.c",
"diff": "@@ -173,21 +173,6 @@ int use_g2f(void)\nreturn use_u2f() && u2f_mode == MODE_U2F_EXTENDED;\n}\n-unsigned u2f_custom_dispatch(uint8_t ins, struct apdu apdu,\n- uint8_t *buf, unsigned *ret_len)\n-{\n- i... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: Delete legacy U2F implementation
This implementation has been replaced, and is no
longer needed. Removing it frees 2376 bytes in flash.
BRANCH=none
BUG=b:138578925
TEST=test_that ... firmware_IntegratedU2F
Signed-off-by: Louis Collard <louiscollard@chromium.org>
Change-Id: Id5b2009bb1b56ae25de9173acb5d5e67eaf1caa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1748847
Reviewed-by: Andrey Pronin <apronin@chromium.org> |
136,324 | 16.08.2019 08:04:11 | 21,600 | 5b3ef3d1d46f84aa20b36d4d4e92e5bbb46bc2b0 | USBC PD: update usb-c doc
change new state machine file references to be up to date with
the current code.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "docs/usb-c.md",
"new_path": "docs/usb-c.md",
"diff": "@@ -83,8 +83,11 @@ Right now platform/ec has two different implementations of USB-C PD stack.\n[`usb_pd_protocol.c`](../common/usb_pd_protocol.c)\n2. The newer implementation is broken up into multiple diff... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | USBC PD: update usb-c doc
change new state machine file references to be up to date with
the current code.
BUG=none
BRANCH=none
TEST=none
Change-Id: I4182b71bea107c4b9b852b93dcf59be5f4616f4d
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1757086
Reviewed-by: Jett Rink <jettrink@chromium.org>
Commit-Queue: Jett Rink <jettrink@chromium.org> |
136,269 | 16.08.2019 11:44:12 | 25,200 | 34bfaabb452a2261d16a969c9bda32e1bc2b71da | docs: Add link in navbar to file a bug or report security issue
BRANCH=none
TEST=View in gitiles | [
{
"change_type": "MODIFY",
"old_path": "navbar.md",
"new_path": "navbar.md",
"diff": "* [Home][home]\n* [Documentation](/docs/sitemap.md)\n* [Getting Started Quickly](/docs/getting_started_quickly.md)\n+* [File a Bug](https://bugs.chromium.org/p/chromium/issues/entry?components=OS%3EFirmware%3EEC)\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: Add link in navbar to file a bug or report security issue
BRANCH=none
BUG=none
TEST=View in gitiles
Change-Id: Ib90270011d687e1b1fe78332d1407230776403d1
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1758540
Reviewed-by: Jett Rink <jettrink@chromium.org>
Commit-Queue: Jett Rink <jettrink@chromium.org> |
136,234 | 23.08.2019 10:06:16 | 25,200 | 1830e59046b7f1482c8effb3e3541441499dddaa | tglrvpu_ite: Enable fan and temperature sensor
BRANCH=none
TEST=Manually tested on tglrvp. Fan works as per thermal profile. | [
{
"change_type": "MODIFY",
"old_path": "baseboard/intelrvp/baseboard.c",
"new_path": "baseboard/intelrvp/baseboard.c",
"diff": "@@ -119,9 +119,9 @@ const struct fan_conf fan_conf_0 = {\n/* Physical fan rpm config */\nconst struct fan_rpm fan_rpm_0 = {\n- .rpm_min = 3100,\n- .rpm_start = 3100,\n- .rp... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | tglrvpu_ite: Enable fan and temperature sensor
BUG=b:139882986
BRANCH=none
TEST=Manually tested on tglrvp. Fan works as per thermal profile.
Change-Id: I04b9b5b6319c484932ccdd0703b4cd56d203b9d9
Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1768931
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,282 | 26.08.2019 09:43:54 | -28,800 | 8064c30fe43d1336cbd3ce302792e27c68ae5125 | garg360: add covertible SKU ID
BRANCH=octopus
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/garg/board.c",
"new_path": "board/garg/board.c",
"diff": "@@ -229,8 +229,11 @@ unsigned int motion_sensor_count = ARRAY_SIZE(motion_sensors);\nstatic int board_is_convertible(void)\n{\n- /* Garg: TBD */\n- return sku_id == 255;\n+ /*\n+ * Garg360: 37\n+ ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | garg360: add covertible SKU ID
BUG=b:134854577
BRANCH=octopus
TEST=make buildall -j
Change-Id: I27785f240da97141dd62ee011cfe1e942f803c5b
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1768495
Reviewed-by: Marco Chen <marcochen@chromium.org> |
136,307 | 05.06.2019 09:20:59 | -28,800 | 94528b5d7141e88dd295bde47a9caa80022256e0 | mtk_vcodec: Add the service for h264 decoder
Fix the service to support h264 decoder.
BRANCH=none
TEST=build kukui_scp pass.
Tested-by: Nicolas Boichat | [
{
"change_type": "MODIFY",
"old_path": "board/kukui_scp/build.mk",
"new_path": "board/kukui_scp/build.mk",
"diff": "@@ -9,3 +9,4 @@ CHIP:=mt_scp\nCHIP_VARIANT:=mt8183\nboard-y=board.o\n+board-$(HAS_TASK_VDEC_SERVICE)+=vdec.o\n"
},
{
"change_type": "MODIFY",
"old_path": "board/kukui_scp/e... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | mtk_vcodec: Add the service for h264 decoder
Fix the service to support h264 decoder.
BRANCH=none
BUG=b:123551776
TEST=build kukui_scp pass.
Change-Id: Iccd6389a40239a6d6791543eeb522cc3e5fc3991
Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1644186
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Yilun Lin <yllin@chromium.org> |
136,307 | 29.03.2019 13:46:39 | -28,800 | 991dd9a7258383f56d5ce1fe86a165b7c74213a4 | mtk_vcodec: Add the service for h264 encoder
Fix the service to support h264 encoder.
BRANCH=none
TEST=build kukui_scp pass.
Tested-by: Nicolas Boichat | [
{
"change_type": "MODIFY",
"old_path": "board/kukui_scp/build.mk",
"new_path": "board/kukui_scp/build.mk",
"diff": "@@ -10,3 +10,4 @@ CHIP_VARIANT:=mt8183\nboard-y=board.o\nboard-$(HAS_TASK_VDEC_SERVICE)+=vdec.o\n+board-$(HAS_TASK_VENC_SERVICE)+=venc.o\n"
},
{
"change_type": "MODIFY",
"o... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | mtk_vcodec: Add the service for h264 encoder
Fix the service to support h264 encoder.
BRANCH=none
BUG=b:123551776
TEST=build kukui_scp pass.
Change-Id: I2bc424ff577ee12246ffa73e5d73cfde388fe5cf
Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1535474
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Yilun Lin <yllin@chromium.org> |
136,406 | 16.04.2019 09:46:27 | -28,800 | 2348dd0c629d0ee789a71ac55dc0b98d16896b0a | mtk_isp: Enlarge CONFIG_ROM_SIZE for ISP EC porting
Enlarge ROM size for Camera ISP EC porting
BRANCH=None
TEST=make BOARD=kukui_scp
Tested-by: Nicolas Boichat | [
{
"change_type": "MODIFY",
"old_path": "board/kukui_scp/board.h",
"new_path": "board/kukui_scp/board.h",
"diff": "*/\n#define ICACHE_BASE 0x7C000\n#define CONFIG_ROM_BASE 0x0\n-#define CONFIG_RAM_BASE 0x10000\n+#define CONFIG_RAM_BASE 0x20000\n#define CONFIG_ROM_SIZE (CONFIG_RAM_BASE - CONFIG_ROM_BA... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | mtk_isp: Enlarge CONFIG_ROM_SIZE for ISP EC porting
Enlarge ROM size for Camera ISP EC porting
BRANCH=None
TEST=make BOARD=kukui_scp
BUG=b:139269434
Change-Id: Ia706992e54d1c7eb54d811805f100d1e3739414c
Signed-off-by: Jungo Lin<jungo.lin@mediatek.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1569091
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Yilun Lin <yllin@chromium.org> |
136,406 | 03.04.2019 17:21:47 | -28,800 | 82ac51f46213eb1853db970a3e530e9a8db4d9af | mtk_isp: Add the service for isp P1 driver
BRANCH=none
TEST=build kukui_scp pass & camera test pass
Tested-by: Nicolas Boichat | [
{
"change_type": "MODIFY",
"old_path": "board/kukui_scp/build.mk",
"new_path": "board/kukui_scp/build.mk",
"diff": "@@ -11,3 +11,6 @@ CHIP_VARIANT:=mt8183\nboard-y=board.o\nboard-$(HAS_TASK_VDEC_SERVICE)+=vdec.o\nboard-$(HAS_TASK_VENC_SERVICE)+=venc.o\n+\n+# ISP P1\n+board-$(HAS_TASK_ISP_SERVICE)+=i... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | mtk_isp: Add the service for isp P1 driver
BRANCH=none
BUG=b:139269434
TEST=build kukui_scp pass & camera test pass
Change-Id: I0d3927b0ee6cc9fa738a063939bcf3d03170493e
Signed-off-by: Jungo Lin <Jungo.Lin@mediatek.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1549814
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org> |
136,396 | 26.08.2019 13:57:53 | 25,200 | 7dd8209cf1f7bbda4a6b05206c0f08ab48677441 | cr50: prepare to release 0.{3,4}.21
BRANCH=cr50, cr50-mp
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/signer/ec_RW-manifest-dev.json",
"new_path": "util/signer/ec_RW-manifest-dev.json",
"diff": "\"timestamp\": 0,\n\"epoch\": 0, // FWR diversification contributor, 32 bits.\n\"major\": 4, // FW2_HIK_CHAIN counter.\n- \"minor\": 20, // Mostly harmless versio... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: prepare to release 0.{3,4}.21
BRANCH=cr50, cr50-mp
BUG=none
TEST=none
Change-Id: Ib94b414de9531c9ea603ba377186c90b1c9fd91c
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1769492
Reviewed-by: Mary Ruthven <mruthven@chromium.org> |
136,420 | 27.08.2019 16:12:19 | -7,200 | 9380ae9ffe98639058c487821a90cbe3bde614f2 | common/i2c_master: don't bitshift negatively
That's undefined behavior. Found by Coverity Scan.
BRANCH=none
TEST=none
Tested-by: Patrick Georgi | [
{
"change_type": "MODIFY",
"old_path": "common/i2c_master.c",
"new_path": "common/i2c_master.c",
"diff": "@@ -53,6 +53,10 @@ static int i2c_port_is_locked(int port)\n/* Test the controller, not the port */\nport = i2c_port_to_controller(port);\n#endif\n+ /* can't lock a non-existing port */\n+ if (p... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common/i2c_master: don't bitshift negatively
That's undefined behavior. Found by Coverity Scan.
BUG=none
BRANCH=none
TEST=none
Change-Id: I85927adeee91ccf06a9651f0279999391b2a5e69
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1768651
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Commit-Queue: Patrick Georgi <pgeorgi@chromium.org> |
136,420 | 27.08.2019 16:36:20 | -7,200 | 54146077fc1ed898b7858faf1665ac39d872cf8f | util/ectool: Protect against out-of-memory condition
Found by Coverity Scan
BRANCH=none
TEST=none
Tested-by: Patrick Georgi | [
{
"change_type": "MODIFY",
"old_path": "util/ectool.c",
"new_path": "util/ectool.c",
"diff": "@@ -8656,9 +8656,14 @@ int cmd_tp_frame_get(int argc, char* argv[])\ndata = malloc(ec_max_insize);\nr = malloc(ec_max_insize);\n+ if (data == NULL || r == NULL) {\n+ fprintf(stderr, \"Couldn't allocate memo... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | util/ectool: Protect against out-of-memory condition
Found by Coverity Scan
BUG=none
BRANCH=none
TEST=none
Change-Id: I9c29f915a732e8dc762b6ebcdffda6f433e983c2
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1768652
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Commit-Queue: Patrick Georgi <pgeorgi@chromium.org> |
136,284 | 23.08.2019 17:39:13 | 25,200 | 4646e28429402438a294b93685bcea1d97f02b4d | cr50: added references to FIPS / NIST standards to cryptographic functions
Clarified standards compliance status for cryptographic functions.
BRANCH=cr50
TEST=code compiles, unit tests pass | [
{
"change_type": "MODIFY",
"old_path": "chip/g/dcrypto/aes_cmac.c",
"new_path": "chip/g/dcrypto/aes_cmac.c",
"diff": "* found in the LICENSE file.\n*/\n-/* AES-CMAC-128 implementation according to RFC4493 */\n+/* AES-CMAC-128 implementation according to NIST SP 800-38B, RFC4493 */\n#include \"consol... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: added references to FIPS / NIST standards to cryptographic functions
Clarified standards compliance status for cryptographic functions.
BRANCH=cr50
BUG=b:138574542
TEST=code compiles, unit tests pass
Change-Id: I75ce155b53d1ce049e5063d2aaa1464b75f7d678
Signed-off-by: Vadim Sukhomlinov <sukhomlinov@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1769420
Reviewed-by: Andrey Pronin <apronin@chromium.org> |
136,208 | 26.08.2019 17:01:16 | -28,800 | 2c12e10279e792710b7c803547151679116e2866 | makefile: support PORT for flash_ec
Add variable PORT to select the flashing port.
TEST=make BOARD=kukui flash_ec PORT=9998, and flash success
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -64,6 +64,9 @@ PEM ?= $(BDIR)/dev_key.pem\n# If no bootblock is provided, just pack an empty file.\nBOOTBLOCK ?=\n+# Port for flash_ec. Defaults to 9999.\n+PORT ?= 9999\n+\n# If CONFIG_TOUCHPAD_HASH_FW is set, inc... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | makefile: support PORT for flash_ec
Add variable PORT to select the flashing port.
TEST=make BOARD=kukui flash_ec PORT=9998, and flash success
BUG=none
BRANCH=none
Change-Id: Ic9ba318ffee70ec1f7789f2dcccc6025263e5436
Signed-off-by: Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1770330
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.