author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
136,282 | 29.08.2019 09:31:50 | -28,800 | a15ef31af52679f715a10589ef89b4343141dd91 | grunt: Disable ec_feature kbbacklit for barla refresh SKUs
BRANCH=grunt
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/grunt/baseboard.c",
"new_path": "baseboard/grunt/baseboard.c",
"diff": "@@ -772,6 +772,7 @@ uint32_t board_override_feature_flags0(uint32_t flags0)\nif (sku_id == 16 || sku_id == 17 ||\nsku_id == 20 || sku_id == 21 ||\nsku_id == 32 || sku_id == 33 ||... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | grunt: Disable ec_feature kbbacklit for barla refresh SKUs
BUG=b:139686328
BRANCH=grunt
TEST=make buildall -j
Change-Id: I588874c2f4f9556137d4cc9e895c3f2f6aaa5436
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1772868
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org> |
136,282 | 26.08.2019 10:13:09 | -28,800 | 03e1aecae1cdc4f92e80957fbf8555740956cb1c | garg: remove AR camera support
Garg doesn't support AR camera, remove unused code.
BRANCH=octopus
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/garg/board.c",
"new_path": "board/garg/board.c",
"diff": "#include \"driver/accelgyro_bmi160.h\"\n#include \"driver/charger/bd9995x.h\"\n#include \"driver/ppc/nx20p348x.h\"\n-#include \"driver/sync.h\"\n#include \"driver/tcpm/anx7447.h\"\n#include \"driv... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | garg: remove AR camera support
Garg doesn't support AR camera, remove unused code.
BUG=b:134854577
BRANCH=octopus
TEST=make buildall -j
Change-Id: I593cc5ef856e5708449e28ad84ced8fa21b1ffa3
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1771098
Reviewed-by: Marco Chen <marcochen@chromium.org>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Reviewed-by: Nigel Sale <nsale@google.com> |
136,222 | 13.04.2019 20:15:52 | -28,800 | 083788ac19505f07bfe57a4d8b54a3b11b7554b3 | audio_codec: extract DMIC from I2S RX
DMIC feature is independent. Extract DMIC from I2S RX.
BRANCH=none
TEST=make BOARD=kukui_scp -j | [
{
"change_type": "MODIFY",
"old_path": "include/ec_commands.h",
"new_path": "include/ec_commands.h",
"diff": "@@ -4659,18 +4659,48 @@ enum mkbp_cec_event {\n/*****************************************************************************/\n+/* Commands for DMIC on audio codec. */\n+#define EC_CMD_EC_C... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | audio_codec: extract DMIC from I2S RX
DMIC feature is independent. Extract DMIC from I2S RX.
BRANCH=none
BUG=b:122027734, b:123268236
TEST=make BOARD=kukui_scp -j
Change-Id: Icfd3c6241c7fb72ef8731cb4ca97bc77279f65bb
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1564501
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,457 | 26.04.2019 10:21:47 | -28,800 | 350193684430b379d1ad76220683de8956e89286 | mtk_isp: Add the service for p2 driver
TEST=build kukui_scp pass & check DIP_SERVICE is available
BRANCH=none
Tested-by: Nicolas Boichat | [
{
"change_type": "MODIFY",
"old_path": "board/kukui_scp/board.h",
"new_path": "board/kukui_scp/board.h",
"diff": "#define CONFIG_MKBP_EVENT\n/* Sent MKBP event via IPI. */\n#define CONFIG_MKBP_USE_CUSTOM\n+#define CONFIG_FPU\n/*\n* RW only, no flash\n*/\n#define ICACHE_BASE 0x7C000\n#define CONFIG_R... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | mtk_isp: Add the service for p2 driver
BUG=b:139269434
TEST=build kukui_scp pass & check DIP_SERVICE is available
BRANCH=none
Change-Id: I86500068d77700e13e909b5085ca07d1170138c1
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1584182
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Tested-by: Nicolas Boichat <drinkcat@chromium.org>
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org> |
136,420 | 02.09.2019 13:44:16 | -7,200 | d394166abbeb067e650417028569c96bc390d71c | common/mkbp_event: Avoid accessing an uninitialized variable
Found by Coverity Scan
BRANCH=none
TEST=none
Tested-by: Patrick Georgi | [
{
"change_type": "MODIFY",
"old_path": "common/mkbp_event.c",
"new_path": "common/mkbp_event.c",
"diff": "@@ -316,10 +316,12 @@ static int take_event_if_set(uint8_t event_type)\nstatic int mkbp_get_next_event(struct host_cmd_handler_args *args)\n{\nstatic int last;\n- int i, data_size, evt;\n+ int i... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common/mkbp_event: Avoid accessing an uninitialized variable
Found by Coverity Scan #198896
BUG=none
BRANCH=none
TEST=none
Change-Id: I0f606e49ed30ff15054c296a8e698aca68a955d3
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1781465
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Commit-Queue: Patrick Georgi <pgeorgi@chromium.org> |
136,420 | 02.09.2019 14:11:04 | -7,200 | fa3ddd11c3084916e8836f8eeda4e8daad836836 | util/comm-i2c: Fix memory leak
Found by Coverity
BRANCH=none
TEST=none
Tested-by: Patrick Georgi | [
{
"change_type": "MODIFY",
"old_path": "util/comm-i2c.c",
"new_path": "util/comm-i2c.c",
"diff": "@@ -174,11 +174,11 @@ int comm_init_i2c(void)\n{\nchar *file_path;\nchar buffer[64];\n- FILE *f;\nint i;\n/* find the device number based on the adapter name */\nfor (i = 0; i < I2C_MAX_ADAPTER; i++) {\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | util/comm-i2c: Fix memory leak
Found by Coverity #58167
BUG=none
BRANCH=none
TEST=none
Change-Id: I434d4b140683b4c3440c30b232fab34d781da9d4
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1781466
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Commit-Queue: Patrick Georgi <pgeorgi@chromium.org> |
136,420 | 02.09.2019 14:16:46 | -7,200 | a03de29ec11e96b0bec6104689002e15ccb9add5 | util/uut: Fix printf formats
Found by Coverity Scan #1194{41,48,49,50,53,54,55}
BRANCH=none
TEST=none
Tested-by: Patrick Georgi | [
{
"change_type": "MODIFY",
"old_path": "util/uut/l_com_port.c",
"new_path": "util/uut/l_com_port.c",
"diff": "@@ -102,7 +102,7 @@ void set_read_blocking(int dev_drv, bool block)\nif (tcgetattr(dev_drv, &tty) != 0) {\ndisplay_color_msg(FAIL,\n\"set_read_blocking Error: %d Fail to get attribute \"\n- ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | util/uut: Fix printf formats
Found by Coverity Scan #1194{41,48,49,50,53,54,55}
BUG=none
BRANCH=none
TEST=none
Change-Id: I8fee672359f7b13639d09e603f3aaa11de05e820
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1781468
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Commit-Queue: Patrick Georgi <pgeorgi@chromium.org> |
136,420 | 02.09.2019 17:12:31 | -7,200 | 43d6a36faa96b7a63a8779906272078dc9161e91 | util/iteflash: Close file on error path
Found by Coverity Scan
TEST=none
BRANCH=none
Tested-by: Patrick Georgi | [
{
"change_type": "MODIFY",
"old_path": "util/iteflash.c",
"new_path": "util/iteflash.c",
"diff": "@@ -1502,6 +1502,7 @@ static int write_flash(struct common_hnd *chnd, const char *filename,\nfprintf(stderr, \"%s: Failed to read %d bytes from %s with \"\n\"ferror() %d\\n\", __func__, size, filename, ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | util/iteflash: Close file on error path
Found by Coverity Scan #58166
BUG=none
TEST=none
BRANCH=none
Change-Id: I1caa2a407a2c623c006c500a56c7048649ebb158
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1781470
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Commit-Queue: Patrick Georgi <pgeorgi@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,282 | 05.09.2019 10:52:58 | -28,800 | 7c16f9c666f20daf9c360678f92fcc7145665315 | blooglet: add simplo HIGHPOWER 996QA168H battery
BRANCH=octopus
TEST=Test on charging/discharging/battery cut off pass.
Tested-by: Justin TerAvest | [
{
"change_type": "MODIFY",
"old_path": "board/bloog/battery.c",
"new_path": "board/bloog/battery.c",
"diff": "@@ -206,6 +206,35 @@ const struct board_batt_params board_battery_info[] = {\n},\n},\n+ /* Simplo HIGHPOWER 996QA168H Battery Information */\n+ [BATTERY_SIMPLO_HIGHPOWER] = {\n+ .fuel_gauge ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | blooglet: add simplo HIGHPOWER 996QA168H battery
BUG=b:138089473
BRANCH=octopus
TEST=Test on charging/discharging/battery cut off pass.
Change-Id: I4b345c5738e80f7e32ef7a4fc0bfa84444665e37
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1786877
Tested-by: Justin TerAvest <teravest@chromium.org>
Reviewed-by: Justin TerAvest <teravest@chromium.org>
Commit-Queue: Justin TerAvest <teravest@chromium.org> |
136,324 | 26.08.2019 07:10:44 | 21,600 | 73bb9370b182e4f46d37529365cb4eee78bf7c6f | common: usb_prl_sm add rch_pass_up_message as a state
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_prl_sm.c",
"new_path": "common/usbc/usb_prl_sm.c",
"diff": "@@ -74,6 +74,7 @@ enum usb_prl_hr_state {\n/* Chunked Rx states (Section 6.11.2.1.2) */\nenum usb_rch_state {\nRCH_WAIT_FOR_MESSAGE_FROM_PROTOCOL_LAYER,\n+ RCH_PASS_UP_MESSAGE,\nRCH_PR... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: usb_prl_sm add rch_pass_up_message as a state
BUG=none
BRANCH=none
TEST=make buildall -j
Change-Id: Ib89f2edf6ce1a57cfeb5f59ffac1fde77cbfa803
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1770680
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,234 | 04.09.2019 15:59:45 | 25,200 | df7ecbc55f4b7d67174a14db9dc781789f07ac60 | power: Add power sequencing logic for Tigerlake chipset
Power sequencing logic for Tigerlake is same as Icelake hence
reusing the Icelake code.
BRANCH=none
TEST=tglrvp can boot to S0 | [
{
"change_type": "MODIFY",
"old_path": "baseboard/volteer/baseboard.h",
"new_path": "baseboard/volteer/baseboard.h",
"diff": "#define CONFIG_HOSTCMD_ESPI\n/* Chipset config */\n-/* TODO - replace with TigerLake once the changes land */\n-#define CONFIG_CHIPSET_ICELAKE\n+#define CONFIG_CHIPSET_TIGERL... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | power: Add power sequencing logic for Tigerlake chipset
Power sequencing logic for Tigerlake is same as Icelake hence
reusing the Icelake code.
BUG=b:140508849
BRANCH=none
TEST=tglrvp can boot to S0
Change-Id: Id218422146e5549aa5b246ddbcaedd8e442e376b
Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1785685
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,282 | 03.09.2019 17:49:14 | -28,800 | cc6db929b7e2b2b840528574ba77aa8b15363775 | Dorp: add simplo HIGHPOWER 996QA168H battery
BRANCH=octopus
TEST=Test on charging/discharging/battery cut off pass. | [
{
"change_type": "MODIFY",
"old_path": "board/meep/battery.c",
"new_path": "board/meep/battery.c",
"diff": "@@ -205,6 +205,35 @@ const struct board_batt_params board_battery_info[] = {\n.discharging_max_c = 60,\n},\n},\n+\n+ /* Simplo HIGHPOWER Battery Information */\n+ [BATTERY_SIMPLO_HIGHPOWER] = ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Dorp: add simplo HIGHPOWER 996QA168H battery
BUG=b:138089473
BRANCH=octopus
TEST=Test on charging/discharging/battery cut off pass.
Change-Id: Ib26447af6944c2d21b6603e391f2e2f76c12bb52
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1782397
Reviewed-by: Marco Chen <marcochen@chromium.org> |
136,444 | 05.09.2019 17:09:54 | 25,200 | d0a28788e7d48ce8ecfd8b0c0f16d824e8e28bfb | driver/touchpad_st: Add enable flag to config.h
This flag is used to enable the driver in driver/build.mk, but wasn't
documented in config.h yet.
TEST=`make buildall -j`
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "include/config.h",
"new_path": "include/config.h",
"diff": "/*****************************************************************************/\n/* Touchpad config */\n-/* Enable touchpad, you must pick a driver (currently, only Elan exists) */\n+/* Enable touchpa... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | driver/touchpad_st: Add enable flag to config.h
This flag is used to enable the driver in driver/build.mk, but wasn't
documented in config.h yet.
BUG=none
TEST=`make buildall -j`
BRANCH=none
Change-Id: Id14bced207192cfa884feb47369066ba7afd7118
Signed-off-by: Harry Cutts <hcutts@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1788677
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,282 | 03.09.2019 17:59:49 | -28,800 | 4576018f783b5645794924a562308adbe192ed6f | Barla: add simplo HIGHPOWER 996QA168H battery
BRANCH=grunt
TEST=Test on charging/discharging/battery cut off pass. | [
{
"change_type": "MODIFY",
"old_path": "board/careena/battery.c",
"new_path": "board/careena/battery.c",
"diff": "@@ -211,6 +211,36 @@ const struct board_batt_params board_battery_info[] = {\n.discharging_max_c = 60,\n},\n},\n+\n+ /* Simplo HIGHPOWER Battery Information */\n+ [BATTERY_SIMPLO_HIGHPOW... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Barla: add simplo HIGHPOWER 996QA168H battery
BUG=b:140452269
BRANCH=grunt
TEST=Test on charging/discharging/battery cut off pass.
Change-Id: Iba19c113d94ed0c88372b5bd4317b333dee6d146
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1782398
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org> |
136,280 | 15.08.2019 17:13:53 | -28,800 | d6e38e2b410e96e76b405a39256d9566bc496028 | kukui: enable hw ramp for mt6370
TEST=observe the charging curve (see issue above for result)
BRANCH=none
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "baseboard/kukui/baseboard.h",
"new_path": "baseboard/kukui/baseboard.h",
"diff": "#if defined(VARIANT_KUKUI_CHARGER_MT6370)\n#define CONFIG_CHARGER_MT6370\n#define CONFIG_CHARGER_MT6370_BC12_GPIO\n-#define CONFIG_CHARGE_RAMP_SW\n+#define CONFIG_CHARGE_RAMP_HW\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui: enable hw ramp for mt6370
BUG=b:139012899
TEST=observe the charging curve (see issue above for result)
BRANCH=none
Change-Id: Ic4e6368763db4d741d82fc233e63e428fb67e610
Signed-off-by: Ting Shen <phoenixshen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1755882
Reviewed-by: Yilun Lin <yllin@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org> |
136,208 | 28.08.2019 13:44:54 | -28,800 | 96f258f04526d6cf188ffe4fe73ec14ea108d5fd | cutoff: ensure logs are flushed before cut-off
Logs may not appear in the console without flush
if battery been cut-off.
TEST=See the logs are flushed to console before cutoff
BRANCH=None | [
{
"change_type": "MODIFY",
"old_path": "common/charge_state_v2.c",
"new_path": "common/charge_state_v2.c",
"diff": "@@ -1365,6 +1365,8 @@ static int shutdown_on_critical_battery(void)\nbreak;\ncase CRITICAL_SHUTDOWN_CUTOFF:\nCPRINTS(\"Cutoff due to critical battery\");\n+ /* Ensure logs are flushed.... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cutoff: ensure logs are flushed before cut-off
Logs may not appear in the console without flush
if battery been cut-off.
TEST=See the logs are flushed to console before cutoff
BRANCH=None
BUG=None
Change-Id: I73363856c50dea1ec409b8041d96227d6538bcc3
Signed-off-by: Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1772863
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,311 | 05.09.2019 15:22:42 | 21,600 | 3726540f6250b4f217bbc725a30d89308c72fb44 | docs: Updates to USB-PD
Minor updates to the USB-PD description.
BRANCH=none
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "docs/usb-c.md",
"new_path": "docs/usb-c.md",
"diff": "@@ -80,12 +80,13 @@ Modes in the EC codebase.\nRight now platform/ec has two different implementations of USB-C PD stack.\n1. The older implementation is mainly contained within\n- [`usb_pd_protocol.c`](../... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: Updates to USB-PD
Minor updates to the USB-PD description.
BUG=none
BRANCH=none
TEST=make buildall
Change-Id: Id428f0815027ca25d798b56f00e41b2985609417
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1788245
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,418 | 10.09.2019 10:12:32 | 25,200 | b8aa16feae8b4d66ff78ce899cbda13f7cf74316 | servo_v4: Disable some features to save space
No room left in the flash for the ToT firmware. Remove some features to
save space.
BRANCH=servo
TEST=Built the servo v4 firmware, 560 bytes in flash available. | [
{
"change_type": "MODIFY",
"old_path": "board/servo_v4/board.h",
"new_path": "board/servo_v4/board.h",
"diff": "#undef CONFIG_CMD_MEM\n#undef CONFIG_CMD_SHMEM\n#undef CONFIG_CMD_SYSLOCK\n+#undef CONFIG_CMD_TIMERINFO\n#undef CONFIG_CMD_WAITMS\n/* Enable control of I2C over USB */\n/* PD features */\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | servo_v4: Disable some features to save space
No room left in the flash for the ToT firmware. Remove some features to
save space.
BRANCH=servo
BUG=b:1002121
TEST=Built the servo v4 firmware, 560 bytes in flash available.
Change-Id: I26aeea9cad155085bac7a349b6242d1f2958112f
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1795926
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,442 | 26.07.2019 13:05:55 | -7,200 | 39a9445c094a1572c5a5f932e029df0cb795d7f0 | Fix typo on STM32 i2c driver
On STM32 discovery board build fails due to
a typo on chip/stm32/i2c-stm32l.c in assignement | [
{
"change_type": "MODIFY",
"old_path": "chip/stm32/i2c-stm32l.c",
"new_path": "chip/stm32/i2c-stm32l.c",
"diff": "@@ -169,7 +169,7 @@ int chip_i2c_xfer(const int port,\nconst uint8_t *out, int out_bytes,\nuint8_t *in, int in_bytes, int flags)\n{\n- int addr_8bit == I2C_GET_ADDR(slave_addr_flags) << ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Fix typo on STM32 i2c driver
On STM32 discovery board build fails due to
a typo on chip/stm32/i2c-stm32l.c in assignement
BUG=none
Change-Id: I8e01006f70165b797472eb367e70aebb8dcb9502
Signed-off-by: Mario Tesi <mario.tesi@st.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1720392
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,297 | 18.06.2019 03:38:06 | -32,400 | 6180c3c38d964128ab819dc5a0710833cd786cce | kohaku: implement leds
kohaku has 3-color led and one of them is power led.
BRANCH=none
TEST=emerge-hatch chromeos-ec, update and check leds | [
{
"change_type": "MODIFY",
"old_path": "board/kohaku/board.h",
"new_path": "board/kohaku/board.h",
"diff": "#define CONFIG_KEYBOARD_PROTOCOL_8042\n#define CONFIG_LED_COMMON\n#define CONFIG_LOW_POWER_IDLE\n+#define CONFIG_LED_POWER_LED\n#define CONFIG_HOSTCMD_ESPI\n#define BOARD_TCPC_C1_RESET_POST_DE... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kohaku: implement leds
kohaku has 3-color led and one of them is power led.
BUG=b:131272926
BRANCH=none
TEST=emerge-hatch chromeos-ec, update and check leds
Change-Id: I2845ed1717a69010dfba18349e6f1eeb46586aad
Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1660526
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Scott Collyer <scollyer@chromium.org> |
136,282 | 10.09.2019 20:33:16 | -28,800 | 17c82537eaec047c33281eb2f4fb74e3c5d68a55 | meep: add convertible SKU ID
This patch adds a convertible SKUID for with Stylus but no rear camera
SKU.
BRANCH=octopus
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/meep/board.c",
"new_path": "board/meep/board.c",
"diff": "@@ -209,14 +209,19 @@ struct motion_sensor_t motion_sensors[] = {\nunsigned int motion_sensor_count = ARRAY_SIZE(motion_sensors);\n/*\n- * meep is convertible SKU (SKU ID is 1, 2, 3), mimrock is c... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | meep: add convertible SKU ID
This patch adds a convertible SKUID for with Stylus but no rear camera
SKU.
BUG=b:140360096
BRANCH=octopus
TEST=make buildall -j
Change-Id: Ied51a2385504088b27c06f41263c746aa84c9243
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1795722
Reviewed-by: Marco Chen <marcochen@chromium.org> |
136,282 | 06.09.2019 12:57:33 | -28,800 | e267ffd7bc3163a87cf3eff055f4be37b837aa25 | dratini: Change interrupt handler for EC_RSMRST_L
Clone from CL:1772482.
BRANCH=none
TEST=make BOARD=dratini
Tested-by: Furquan Shaikh | [
{
"change_type": "MODIFY",
"old_path": "board/dratini/gpio.inc",
"new_path": "board/dratini/gpio.inc",
"diff": "@@ -20,7 +20,7 @@ GPIO_INT(SLP_S0_L, PIN(D, 5), GPIO_INT_BOTH, power_signal_interrupt)\nGPIO_INT(SLP_S3_L, PIN(A, 5), GPIO_INT_BOTH, power_signal_interrupt)\nGPIO_INT(SLP_S4_L, PIN(D, 4), ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | dratini: Change interrupt handler for EC_RSMRST_L
Clone from CL:1772482.
BUG=none
BRANCH=none
TEST=make BOARD=dratini
Change-Id: Ib5e039ee094b6e5f1201a4ecef6197c799e943ea
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1788775
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> |
136,282 | 06.09.2019 09:56:25 | -28,800 | 788c0735b35ed5da0587d0fc909618a6b0d42d01 | dratini: Update EC GPIOs for proto and remove unsupport function
1. Correct PP5000_A that just have one pin for proto.
2. Remove ALS support.
BRANCH=none
TEST=make BOARD=dratini | [
{
"change_type": "MODIFY",
"old_path": "board/dratini/board.c",
"new_path": "board/dratini/board.c",
"diff": "@@ -180,43 +180,6 @@ static struct bmi160_drv_data_t g_bmi160_data;\n/* BMA255 private data */\nstatic struct accelgyro_saved_data_t g_bma255_data;\n-/* TCS3400 private data */\n-static stru... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | dratini: Update EC GPIOs for proto and remove unsupport function
1. Correct PP5000_A that just have one pin for proto.
2. Remove ALS support.
BUG=none
BRANCH=none
TEST=make BOARD=dratini
Change-Id: I0b5ccc911facb73d5e32ae5d363db0ad1fd94273
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1788764
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Scott Collyer <scollyer@chromium.org> |
136,420 | 12.09.2019 14:48:50 | -7,200 | 77424e473fd1f47caf6b9e5621defc4bab51468a | chip/nrf51/gpio.c: Actually check the flag (instead of == 0)
Found by Coverity Scan
BRANCH=none
TEST=none
Tested-by: Patrick Georgi | [
{
"change_type": "MODIFY",
"old_path": "chip/nrf51/gpio.c",
"new_path": "chip/nrf51/gpio.c",
"diff": "@@ -257,7 +257,7 @@ int gpio_disable_interrupt(enum gpio_signal signal)\nreturn EC_ERROR_INVAL;\n/* If it's not shared, use INT0-INT3, otherwise use PORT. */\n- if (!(g->flags && GPIO_INT_SHARED)) {... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | chip/nrf51/gpio.c: Actually check the flag (instead of == 0)
Found by Coverity Scan #146623
BUG=none
BRANCH=none
TEST=none
Change-Id: I04ca143f794596c7be00f69ee297b33759125ae2
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1801204
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Commit-Queue: Patrick Georgi <pgeorgi@chromium.org> |
136,420 | 12.09.2019 14:51:08 | -7,200 | 3e7d997d6832487be0ddcf80740b90d047a18d79 | common/btle_ll.c: define default return value
Found by Coverity Scan
BRANCH=none
TEST=none
Tested-by: Patrick Georgi | [
{
"change_type": "MODIFY",
"old_path": "common/btle_ll.c",
"new_path": "common/btle_ll.c",
"diff": "@@ -619,7 +619,7 @@ int ble_ll_adv(int chan)\nint ble_ll_adv_event(void)\n{\nint chan_idx;\n- int rv;\n+ int rv = EC_SUCCESS;\nfor (chan_idx = 0; chan_idx < 3; chan_idx++) {\nif (ll_adv_params.advChan... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common/btle_ll.c: define default return value
Found by Coverity Scan #160945
BUG=none
BRANCH=none
TEST=none
Change-Id: I9689d88785db721c48c29d793c5b783a6f4dd583
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1801205
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Commit-Queue: Patrick Georgi <pgeorgi@chromium.org> |
136,420 | 12.09.2019 15:02:47 | -7,200 | f2086e771d940b35d86e5adcaf21ffe3035e71d2 | driver/tcpm/anx7447: bound port argument
Found by Coverity Scan
BRANCH=none
TEST=none
Tested-by: Patrick Georgi | [
{
"change_type": "MODIFY",
"old_path": "driver/tcpm/anx7447.c",
"new_path": "driver/tcpm/anx7447.c",
"diff": "@@ -285,6 +285,8 @@ static int anx7447_init(int port)\n{\nint rv, reg, i;\n+ ASSERT(port < CONFIG_USB_PD_PORT_COUNT);\n+\nmemset(&anx[port], 0, sizeof(struct anx_state));\n/*\n@@ -491,6 +493... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | driver/tcpm/anx7447: bound port argument
Found by Coverity Scan #187773, #204053
BUG=none
BRANCH=none
TEST=none
Change-Id: Ie7006828d8a5d760097baade6851c72d15e42cf1
Signed-off-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1801206
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Patrick Georgi <pgeorgi@chromium.org>
Commit-Queue: Patrick Georgi <pgeorgi@chromium.org> |
136,278 | 23.08.2019 20:23:12 | 25,200 | c4ba7e80706fe489406df870d6e54064f7793d44 | config.h: remove unused CONFIG_POWER_IGNORE_LID_OPEN
there is no implementation or reference to
CONFIG_POWER_IGNORE_LID_OPEN, so remove it.
BRANCH=none
TEST=verified there are no references to CONFIG_POWER_IGNORE_LID_OPEN | [
{
"change_type": "MODIFY",
"old_path": "include/config.h",
"new_path": "include/config.h",
"diff": "/* Compile common code for AP power state machine */\n#undef CONFIG_POWER_COMMON\n-/* Disable the power-on transition when the lid is opened */\n-#undef CONFIG_POWER_IGNORE_LID_OPEN\n-\n/* Enable a ta... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | config.h: remove unused CONFIG_POWER_IGNORE_LID_OPEN
there is no implementation or reference to
CONFIG_POWER_IGNORE_LID_OPEN, so remove it.
BUG=none
BRANCH=none
TEST=verified there are no references to CONFIG_POWER_IGNORE_LID_OPEN
Change-Id: I6c420cf3b130f9bdf9a05986251e0cd46d6dd9fa
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1772527
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,278 | 05.09.2019 13:38:53 | -28,800 | 9a4cf337a21a936fbe2a26c58e17b5ba72cc633d | config.h: remove unused CONFIG_USB_PORT_POWER_IN_S3
CONFIG_USB_PORT_POWER_IN_S3 is nowhere to be found in the EC source.
BRANCH=none
TEST=verified there are no references to CONFIG_USB_PORT_POWER_IN_S3 | [
{
"change_type": "MODIFY",
"old_path": "include/config.h",
"new_path": "include/config.h",
"diff": "/* Support simple control of power to the device's USB ports */\n#undef CONFIG_USB_PORT_POWER_DUMB\n-/*\n- * Support supplying USB power in S3, if the host leaves the port enabled when\n- * entering S... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | config.h: remove unused CONFIG_USB_PORT_POWER_IN_S3
CONFIG_USB_PORT_POWER_IN_S3 is nowhere to be found in the EC source.
BUG=none
BRANCH=none
TEST=verified there are no references to CONFIG_USB_PORT_POWER_IN_S3
Change-Id: I30c05950dec57f59cd18152c9a71fb01128e87fc
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1787625
Reviewed-by: Caveh Jalali <caveh@google.com> |
136,368 | 11.09.2019 11:25:34 | 25,200 | aa771bf3d3610477d5f359e43f873084201203a4 | pd: Exit DP mode on sysjump
Exits all USB PD Alternate Modes after a system jump
BRANCH=none
TEST=manual
Tested-by: Sam Hurst | [
{
"change_type": "MODIFY",
"old_path": "common/usb_common.c",
"new_path": "common/usb_common.c",
"diff": "#include \"common.h\"\n#include \"charge_state.h\"\n+#include \"task.h\"\n#include \"usb_pd.h\"\n#include \"usb_pd_tcpm.h\"\n#include \"util.h\"\n@@ -209,15 +210,12 @@ void pd_build_request(uint... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | pd: Exit DP mode on sysjump
Exits all USB PD Alternate Modes after a system jump
BUG=b:140807930
BRANCH=none
TEST=manual
Change-Id: Ie0843e0c9f1dcacecc2109cd0565a90cfafed306
Signed-off-by: Sam Hurst <shurst@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1797661
Tested-by: Sam Hurst <shurst@google.com>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,208 | 16.09.2019 16:27:36 | -28,800 | 92b3e86b23b59ebec3e59132cae2b32288fcf1b4 | baseboard/kukui: use BASE_STATE_SWITCH instead
tablet mode will also depend on BASE_ATTACHED_SWITCH.
TEST=see EC sends BASE_ATTACHED event when keyboard attach/detach
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "baseboard/kukui/base_detect_kukui.c",
"new_path": "baseboard/kukui/base_detect_kukui.c",
"diff": "*/\n#include \"adc.h\"\n+#include \"base_state.h\"\n#include \"board.h\"\n#include \"charge_manager.h\"\n#include \"console.h\"\n#include \"gpio.h\"\n#include \"h... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | baseboard/kukui: use BASE_STATE_SWITCH instead
tablet mode will also depend on BASE_ATTACHED_SWITCH.
TEST=see EC sends BASE_ATTACHED event when keyboard attach/detach
BUG=b:140608847
BRANCH=none
Change-Id: Ib7d9bd0e8cf0efb5d0a3808f4649e0d9eb69b6d8
Signed-off-by: Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1806178
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,280 | 13.09.2019 17:31:16 | 0 | baf03777a464986b4956d58e8060f8348bde3298 | jacuzzi: move charger to bitbang port
In board rev 1, ISL9238C is connected to I2C port 2 (bitbanging bus).
TEST=make
BRANCH=master | [
{
"change_type": "MODIFY",
"old_path": "board/jacuzzi/board.c",
"new_path": "board/jacuzzi/board.c",
"diff": "@@ -254,3 +254,9 @@ static void board_chipset_shutdown(void)\ngpio_set_level(GPIO_EN_USBA_5V, 0);\n}\nDECLARE_HOOK(HOOK_CHIPSET_SHUTDOWN, board_chipset_shutdown, HOOK_PRIO_DEFAULT);\n+\n+int... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | jacuzzi: move charger to bitbang port
In board rev 1, ISL9238C is connected to I2C port 2 (bitbanging bus).
BUG=b:138415463
TEST=make
BRANCH=master
Change-Id: If94bc73a66caf1a73cbd0beb23eaf7f35cdea2ba
Signed-off-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1803974
Commit-Queue: Yilun Lin <yllin@chromium.org>
Reviewed-by: Yilun Lin <yllin@chromium.org> |
136,451 | 17.09.2019 15:20:59 | -28,800 | e6ef834fe6ad38e8b6cf2e1c32cfc1d43c072304 | treeya: add battery information
Copied from phaser board. Add battery information for:
- SMP 5B10Q13163
- LGC 5B10Q13162
- Sunwoda 5B10S75394
BRANCH=none
TEST=builds | [
{
"change_type": "MODIFY",
"old_path": "board/treeya/battery.c",
"new_path": "board/treeya/battery.c",
"diff": "* address, mask, and disconnect value need to be provided.\n*/\nconst struct board_batt_params board_battery_info[] = {\n- /* Panasonic AP15O5L Battery Information */\n- [BATTERY_PANASONIC... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | treeya: add battery information
Copied from phaser board. Add battery information for:
- SMP 5B10Q13163
- LGC 5B10Q13162
- Sunwoda 5B10S75394
BRANCH=none
BUG=b:141128721, b:138744661
TEST=builds
Signed-off-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com>
Change-Id: I761417280820904e10e78939886acdf7cdf8aa1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1808822
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,256 | 04.09.2019 11:50:49 | 21,600 | 89d7b00c20a650d118446fe5ef987f7766616ea0 | doc: add link to sitemap for USB power policy
BRANCH=none
TEST=view markdown | [
{
"change_type": "MODIFY",
"old_path": "docs/sitemap.md",
"new_path": "docs/sitemap.md",
"diff": "* [USB Updater](./usb_updater.md)\n-## USB-C\n+## USB\n* [USB-C Power Delivery and Alternate Modes](./usb-c.md)\n+* [USB-A and USB-C Policies for Sourcing Power](./usb_power.md)\n## Miscellaneous\n"
}... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | doc: add link to sitemap for USB power policy
BRANCH=none
BUG=chromium:974302
TEST=view markdown
Change-Id: I3ea124253f885f0fe94e60f89dab07cedcbab344
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1784123
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,311 | 30.08.2019 11:32:50 | 21,600 | 580a54658ad27550a1da5cd6077b901a12d447f2 | doc: Add additional USB terms
Add more USB terms to the EC glossary.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "docs/ec_terms.md",
"new_path": "docs/ec_terms.md",
"diff": "switching, sensor management, and other functions, offloading these tasks\nfrom the [AP](#ap).\n+* **E-Mark - Electronically Marked Cable** {#emark}\n+\n+ See the [USB-C documentation](./usb-c.md#emar... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | doc: Add additional USB terms
Add more USB terms to the EC glossary.
BUG=none
BRANCH=none
TEST=none
Change-Id: Ibc2c0d43959749d9527de08337f4a83b41a429ce
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1778634
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,324 | 27.08.2019 07:35:18 | 21,600 | 4be44b7a0b036e6a27d4588f71761cd499e56e4e | pd: RCH_Processing_Extended_Message cleanup
Change first chunk processing to be handled embedded in
RCH_Wait_For_Message_From_Protocol_Layer run to get the
actual first chunk and don't rely on the chunk headers
to indicate the first chunk
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_prl_sm.c",
"new_path": "common/usbc/usb_prl_sm.c",
"diff": "@@ -935,6 +935,19 @@ static void rch_wait_for_message_from_protocol_layer_run(const int port)\n*/\nif ((RCH_CHK_FLAG(port, PRL_FLAGS_CHUNKING)) &&\nchunked) {\n+ /*\n+ * RCH_Processing... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | pd: RCH_Processing_Extended_Message cleanup
Change first chunk processing to be handled embedded in
RCH_Wait_For_Message_From_Protocol_Layer run to get the
actual first chunk and don't rely on the chunk headers
to indicate the first chunk
BUG=none
BRANCH=none
TEST=make buildall -j
Change-Id: Iadb606dfaca7b3f4d3ff6528dcfbd3e6aad196a4
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1773118 |
136,444 | 18.09.2019 17:57:20 | 25,200 | b3e56d049645a6cc148ff0670b525e29b3b553bc | touchpad_gt7288: support touch width and height
GT7288 firmware version 4 supports these dimensions.
BRANCH=none
TEST=check output of `gt7288_rep` command, comparing palms and fingers. | [
{
"change_type": "MODIFY",
"old_path": "driver/touchpad_gt7288.c",
"new_path": "driver/touchpad_gt7288.c",
"diff": "@@ -87,6 +87,8 @@ static void gt7288_translate_contact(const uint8_t *data,\ncontact->confidence = data[3] & BIT(0);\ncontact->x = UINT16_FROM_BYTE_ARRAY_LE(data, 4);\ncontact->y = UIN... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | touchpad_gt7288: support touch width and height
GT7288 firmware version 4 supports these dimensions.
BRANCH=none
BUG=none
TEST=check output of `gt7288_rep` command, comparing palms and fingers.
Change-Id: I9094d8f86f34e4f319a9743c246461853d0382cf
Signed-off-by: Harry Cutts <hcutts@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1815403
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,324 | 17.09.2019 14:09:18 | 21,600 | 304c2f76ae1c213c82842e7db28730e6aa11f9f3 | trembyle: enable new PD state machine
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.h",
"new_path": "baseboard/zork/baseboard.h",
"diff": "#define CONFIG_KEYBOARD_COL2_INVERTED\n#define CONFIG_KEYBOARD_PROTOCOL_8042\n+/* Enable the new USB-C PD stack */\n+#define CONFIG_USB_PE_SM\n+#define CONFIG_USB_PRL_SM\n+#define ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | trembyle: enable new PD state machine
BUG=b:138599955
BRANCH=none
TEST=make buildall -j
Change-Id: I607ae5cd77809fbcf3dc09a73a1feb814be690f2
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1809245
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,250 | 25.09.2019 10:41:56 | 25,200 | 881d05951d94345c7c5bdea909cf5d393bd66a57 | iteflash.md: Update link to CrOS EC development doc
BRANCH=none
TEST=Used Gitiles to view and follow the updated link. | [
{
"change_type": "MODIFY",
"old_path": "util/iteflash.md",
"new_path": "util/iteflash.md",
"diff": "@@ -6,7 +6,7 @@ First written: 2019-04-02\n<br>\nLast updated: 2019-04-03\n-Familiarity with [Chromium OS](https://www.chromium.org/chromium-os) [Embedded Controller (EC) development](https://www.chro... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | iteflash.md: Update link to CrOS EC development doc
BRANCH=none
BUG=none
TEST=Used Gitiles to view and follow the updated link.
Change-Id: I5be72babb69e4c76b4f38f8370448bf9ab795ba0
Signed-off-by: Matthew Blecker <matthewb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1825501
Reviewed-by: Namyoon Woo <namyoon@chromium.org> |
136,278 | 25.09.2019 02:00:46 | 25,200 | 67c774952bc61a4e31fb2f42866fe02c1426699c | usb_pd_protocol: add missing CPRINTF argument
This adds the missing "port" argument to a printf.
BRANCH=none
TEST=buildall passed, boots on atlas | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_protocol.c",
"new_path": "common/usb_pd_protocol.c",
"diff": "@@ -2541,7 +2541,7 @@ static void pd_partner_port_reset(int port)\npd_update_saved_port_flags(port, PD_BBRMFLG_EXPLICIT_CONTRACT, 0);\n/* Provide Rp for 200 msec. or until we no longer... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb_pd_protocol: add missing CPRINTF argument
This adds the missing "port" argument to a printf.
BUG=none
BRANCH=none
TEST=buildall passed, boots on atlas
Change-Id: Ia0e27b323bf6f274efbd3498c8e7e5c7d7b81a1a
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1825875
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,278 | 25.09.2019 16:56:23 | 25,200 | 1906434c4e62fac6792b6b81874810495be49b2e | tcpci: add missing CPRINTS argument
this adds the missing "port" argument to a CPRINTS.
BRANCH=none
TEST=buildall passes, boots on atlas | [
{
"change_type": "MODIFY",
"old_path": "driver/tcpm/tcpci.c",
"new_path": "driver/tcpm/tcpci.c",
"diff": "@@ -490,7 +490,7 @@ int tcpm_dequeue_message(const int port, uint32_t *const payload,\n&q->buffer[q->tail & CACHE_DEPTH_MASK];\nif (!tcpm_has_pending_message(port)) {\n- CPRINTS(\"C%d No message... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | tcpci: add missing CPRINTS argument
this adds the missing "port" argument to a CPRINTS.
BUG=none
BRANCH=none
TEST=buildall passes, boots on atlas
Change-Id: I9308a4beea716441912aaa06eb206e9d17186cd9
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1825876
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,250 | 26.09.2019 09:36:40 | 25,200 | 2d74095e5c923e40e6230f803537c1e968fd2631 | i2c-pseudo: Minor documentation fixes and clarifications.
BRANCH=none
TEST=Viewed the updated file in Gitiles. | [
{
"change_type": "MODIFY",
"old_path": "extra/i2c_pseudo/Documentation.txt",
"new_path": "extra/i2c_pseudo/Documentation.txt",
"diff": "@@ -73,7 +73,7 @@ Read Command: I2C_ADAPTER_NUM <num>\nExample: \"I2C_ADAPTER_NUM 5\\n\"\nDetails: This is read in response to the GET_ADAPTER_NUM command being wri... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | i2c-pseudo: Minor documentation fixes and clarifications.
BRANCH=none
BUG=none
TEST=Viewed the updated file in Gitiles.
Change-Id: Icd10a54500a2521e4d598997385916d59dd38ab3
Signed-off-by: Matthew Blecker <matthewb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1827239
Reviewed-by: Justin TerAvest <teravest@chromium.org> |
136,311 | 19.09.2019 14:28:41 | 21,600 | 7d3b318f8d77f039eb1fa6c7df7f33a7ca77b262 | volteer: Configure the GPIOs connected to the AP/PCH
This change also corrects the SYS_RESET_L signal.
BRANCH=none
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/volteer/board.h",
"new_path": "board/volteer/board.h",
"diff": "* which purpose.\n*/\n#define GPIO_AC_PRESENT GPIO_ACOK_OD\n+#define GPIO_EC_INT_L EC_PCH_INT_ODL\n#define GPIO_ENTERING_RW GPIO_EC_ENTERING_RW\n#define GPIO_LID_OPEN GPIO_EC_LID_OPEN\n#defi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | volteer: Configure the GPIOs connected to the AP/PCH
This change also corrects the SYS_RESET_L signal.
BUG=b:141265267
BRANCH=none
TEST=make buildall
Change-Id: I9661521ccc0296924840e1a0de02439800c9ca15
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1816867
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
136,286 | 26.09.2019 20:25:50 | -28,800 | 06965455e406e113eb0aa497e29d7b4d291c6b32 | Kindred:Disable tablet mode depends on sku id define
Fix sku id define convertible and clamshell only.
BRANCH=Master
TEST=check ec console log, tablet mode disabled message | [
{
"change_type": "MODIFY",
"old_path": "board/kindred/board.c",
"new_path": "board/kindred/board.c",
"diff": "#include \"spi.h\"\n#include \"switch.h\"\n#include \"system.h\"\n+#include \"tablet_mode.h\"\n#include \"task.h\"\n#include \"temp_sensor.h\"\n#include \"thermal.h\"\n@@ -418,6 +419,8 @@ st... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Kindred:Disable tablet mode depends on sku id define
Fix sku id define convertible and clamshell only.
BUG=b:141597200
BRANCH=Master
TEST=check ec console log, tablet mode disabled message
Change-Id: I0df7b893504f7cfafb2068c1bad4f4cc5f67aa70
Signed-off-by: Ben Chen <ben.chen2@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1826698
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> |
136,311 | 19.09.2019 15:21:33 | 21,600 | 946331e651bf333b209c2f3124e3b35b33b11efe | volteer: Configure EC wake sources
Configure EC chip hibernation wake sources.
BRANCH=none
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/volteer/baseboard.c",
"new_path": "baseboard/volteer/baseboard.c",
"diff": "/******************************************************************************/\n/* Wake up pins */\nconst enum gpio_signal hibernate_wake_pins[] = {\n+ GPIO_LID_OPEN,\n+ GP... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | volteer: Configure EC wake sources
Configure EC chip hibernation wake sources.
BUG=b:141323588
BRANCH=none
TEST=make buildall
Change-Id: I5fec9b97ebcac4382c1b4317b15b0ddb87d2068b
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1816868
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
136,197 | 29.09.2019 10:42:45 | -28,800 | b2621c0cb45dc0280df95c6f975c60b94bad16b2 | hammer: Use different KB scanning matrix for masterball
ODM/OEM decided to change pinout.
BRANCH=none
TEST=make BOARD=masterball
TEST=Check that there is not interrupt conflict in gpio.inc | [
{
"change_type": "MODIFY",
"old_path": "board/hammer/gpio.inc",
"new_path": "board/hammer/gpio.inc",
"diff": "@@ -21,6 +21,31 @@ GPIO_INT(TABLET_MODE_L, PIN(B, 11), GPIO_PULL_UP | GPIO_INT_BOTH, gmr_tablet_swi\n#define GPIO_KB_INPUT (GPIO_INPUT | GPIO_PULL_UP | GPIO_INT_BOTH)\n#define GPIO_KB_OUTPUT... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | hammer: Use different KB scanning matrix for masterball
ODM/OEM decided to change pinout.
BRANCH=none
BUG=b:140596094
TEST=make BOARD=masterball
TEST=Check that there is not interrupt conflict in gpio.inc
Change-Id: I45adaf77faecfb4fb99122abe146691c9c77098b
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1830539
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,256 | 17.09.2019 16:02:58 | 21,600 | 3daa7fb8a4caec652dbe1ee02d505d7fffcab85a | cleanup: fix byte access and ifdefs for BBRAM_PD2
Ensure that PD2 is accessed as a single byte instead of 4 bytes and remove
unnecessary ifdef guards in all chip implementations.
BRANCH=none
TEST=builds | [
{
"change_type": "MODIFY",
"old_path": "chip/it83xx/system.c",
"new_path": "chip/it83xx/system.c",
"diff": "@@ -287,14 +287,12 @@ static int bram_idx_lookup(enum system_bbram_idx idx)\nidx <= SYSTEM_BBRAM_IDX_VBNVBLOCK15)\nreturn BRAM_IDX_NVCONTEXT +\nidx - SYSTEM_BBRAM_IDX_VBNVBLOCK0;\n-#ifdef CONF... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: fix byte access and ifdefs for BBRAM_PD2
Ensure that PD2 is accessed as a single byte instead of 4 bytes and remove
unnecessary ifdef guards in all chip implementations.
BRANCH=none
BUG=none
TEST=builds
Change-Id: I319d8d6a8456662235ab4d8dcda6bda7e8ed7c15
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1809938
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,396 | 01.10.2019 16:05:06 | 25,200 | 4e692f29e3e5af6b85df472e4c4f936c6f461cb9 | cr50: prepare to release 0.{3,4}.23
Note that 0,x.22 is skipped, 0.3.22 will be used for the new factory
image.
BRANCH=cr50, cr50-mp
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/signer/ec_RW-manifest-dev.json",
"new_path": "util/signer/ec_RW-manifest-dev.json",
"diff": "\"timestamp\": 0,\n\"epoch\": 0, // FWR diversification contributor, 32 bits.\n\"major\": 4, // FW2_HIK_CHAIN counter.\n- \"minor\": 21, // Mostly harmless versio... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50: prepare to release 0.{3,4}.23
Note that 0,x.22 is skipped, 0.3.22 will be used for the new factory
image.
BRANCH=cr50, cr50-mp
BUG=none
TEST=none
Change-Id: I4f6d2fefcfade38e9f8443e4faf2c0a58c56ff36
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1834525
Reviewed-by: Andrey Pronin <apronin@chromium.org> |
136,377 | 20.09.2019 13:27:32 | 25,200 | e2aa17f3235644a07b7f91b328dcf46235dbe686 | docs: add tutorial for using suzyq
BRANCH=none
TEST=read doc. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "docs/ccd_howtos.md",
"diff": "+# CCD How-tos\n+This doc contains tutorials for using CCD. These tutorials only cover using GSC\n+CCD. Some use cases will be very similar to using CCD from ryu, servo micro, or\n+servo v4, but these guides are not... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: add tutorial for using suzyq
BUG=b:140551928
BRANCH=none
TEST=read doc.
Change-Id: I1032433de1f8284cffff1e12e906d3fffd5ae32a
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1816871
Reviewed-by: Wai-Hong Tam <waihong@google.com> |
136,269 | 01.10.2019 15:08:19 | 25,200 | 8357a4fb160bda9a3c926c674492cb604421b7f1 | fpsensor: Fix public build
Add stubs for fp_sensor_init and fp_sensor_deinit when building without
the private FP sensor files.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "common/fpsensor/build.mk",
"new_path": "common/fpsensor/build.mk",
"diff": "@@ -12,3 +12,6 @@ all-obj-$(HAS_TASK_FPSENSOR)+=$(_fpsensor_dir)fpsensor_crypto.o\nifneq ($(CONFIG_SPI_FP_PORT),)\nall-obj-$(HAS_TASK_FPSENSOR)+=$(_fpsensor_dir)fpsensor.o\nendif\n+ife... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | fpsensor: Fix public build
Add stubs for fp_sensor_init and fp_sensor_deinit when building without
the private FP sensor files.
BRANCH=none
BUG=b:124773209,b:141924178
TEST=make buildall -j
Change-Id: Ie85a4bb0e568b205ada0d378ae658e8fe478c0a9
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1834274
Reviewed-by: Nicolas Norvez <norvez@chromium.org> |
136,438 | 25.07.2019 17:29:20 | 25,200 | 43e89bafd85ac2c101a2bc68d08d39a1cef19734 | fpsensor: Add hkdf-expand implementation for arbitrary output size.
This can be used to replace hkdf_expand_one_step in more general cases
of HKDF. Also add unit tests for this.
BRANCH=nocturne
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "common/fpsensor/fpsensor_crypto.c",
"new_path": "common/fpsensor/fpsensor_crypto.c",
"diff": "* Use of this source code is governed by a BSD-style license that can be\n* found in the LICENSE file.\n*/\n+#include <stdbool.h>\n#include \"aes.h\"\n#include \"aes-... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | fpsensor: Add hkdf-expand implementation for arbitrary output size.
This can be used to replace hkdf_expand_one_step in more general cases
of HKDF. Also add unit tests for this.
BRANCH=nocturne
BUG=none
TEST=make -j buildall
Change-Id: Ie116b13ee33d171298eccabb8a37b59e702d0218
Signed-off-by: Yicheng Li <yichengli@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1719871
Reviewed-by: Nicolas Norvez <norvez@chromium.org> |
136,338 | 04.10.2019 11:27:18 | 21,600 | 53690d93cfed7649cfd85c512848d41f30d40682 | flash_ec: Support image name with spaces
BRANCH=none
TEST=Flashed a zork ec image with a space in the name | [
{
"change_type": "MODIFY",
"old_path": "util/flash_ec",
"new_path": "util/flash_ec",
"diff": "@@ -886,7 +886,7 @@ function flash_flashrom() {\nif [[ \"${CHIP}\" =~ ^npcx(|_int)_spi$ ]] ; then\n{ # Patch temp image up to SPI_SIZE\n- cat $IMG\n+ cat \"$IMG\"\nif [[ ${IMG_SIZE} -lt ${SPI_SIZE} ]] ; the... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | flash_ec: Support image name with spaces
BUG=none
BRANCH=none
TEST=Flashed a zork ec image with a space in the name
Change-Id: I9915f04f222de7a34e757fddcb30563d66093c71
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1842033
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org> |
136,289 | 23.09.2019 13:23:09 | 25,200 | 44c473cdeae53aba84fc2ababeaeb7d022ea4dd7 | printf: Enable compile-time format checking
Add annotations to allow the compiler to check printf-style format
strings in the EC.
TEST=make -j buildall
BRANCH=None | [
{
"change_type": "MODIFY",
"old_path": "chip/g/loader/debug_printf.h",
"new_path": "chip/g/loader/debug_printf.h",
"diff": "#ifndef __EC_CHIP_G_LOADER_DEBUG_PRINTF_H\n#define __EC_CHIP_G_LOADER_DEBUG_PRINTF_H\n+__attribute__((__format__(__printf__, 1, 2)))\nvoid debug_printf(const char *format, ...)... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | printf: Enable compile-time format checking
Add annotations to allow the compiler to check printf-style format
strings in the EC.
BUG=chromium:984041
TEST=make -j buildall
BRANCH=None
Change-Id: Ic39f37f8362372de7d289becea684d9da535599a
Signed-off-by: Evan Green <evgreen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1733101
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,289 | 26.09.2019 13:36:07 | 25,200 | 3247d52abeb0ccacc49f0d18dadf47c77f8f0177 | test: Add printf test for %pT
Add a couple basic tests for %pT values.
TEST=make -j buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "test/printf.c",
"new_path": "test/printf.c",
"diff": "@@ -257,6 +257,18 @@ test_static int test_vsnprintf_strings(void)\nreturn EC_SUCCESS;\n}\n+test_static int test_vsnprintf_timestamps(void)\n+{\n+ uint64_t ts = 0;\n+\n+ T(expect_success(\"0.000000\", \"%pT\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test: Add printf test for %pT
Add a couple basic tests for %pT values.
BUG=chromium:984041
TEST=make -j buildall
BRANCH=none
Change-Id: I8cb56017b883b6257e1432bd64eae3ae943edf8b
Signed-off-by: Evan Green <evgreen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1828067
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,330 | 04.10.2019 14:22:25 | 21,600 | faacff7deeed02905e31174463c613633062e762 | volteer: Configure GPIOs connected to keyboard
Configure the pins connected to the keyboard scan lines.
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "board/volteer/board.h",
"new_path": "board/volteer/board.h",
"diff": "#define GPIO_EC_INT_L EC_PCH_INT_ODL\n#define GPIO_ENTERING_RW GPIO_EC_ENTERING_RW\n#define GPIO_LID_OPEN GPIO_EC_LID_OPEN\n+#define GPIO_KBD_KSO2 GPIO_EC_KSO_02_INV\n#define GPIO_PCH_WAKE_L... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | volteer: Configure GPIOs connected to keyboard
Configure the pins connected to the keyboard scan lines.
BUG=b:139554320
TEST=make buildall
BRANCH=none
Change-Id: I245122aa589424b1cb397f99b5fd60deb434d87a
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1841884
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,324 | 27.09.2019 13:25:14 | 21,600 | cfb6d3ded36e6b7935f8693532f6f9031643865d | ppc: cleanup ppc
Allow limited PPC chips to default to EC_ERROR_UNIMPLEMENTED
for functions in the driver that are not needed.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "common/usbc_ppc.c",
"new_path": "common/usbc_ppc.c",
"diff": "#include \"usbc_ppc.h\"\n#include \"util.h\"\n+#ifndef TEST_BUILD\n#define CPRINTF(format, args...) cprintf(CC_USBPD, format, ## args)\n#define CPRINTS(format, args...) cprints(CC_USBPD, format, ## ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ppc: cleanup ppc
Allow limited PPC chips to default to EC_ERROR_UNIMPLEMENTED
for functions in the driver that are not needed.
BUG=b:138599218
BRANCH=none
TEST=make buildall -j
Change-Id: I5242ef285eb277c06d516ab09f7a74f76d7d34b2
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1829405
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,324 | 01.10.2019 08:49:02 | 21,600 | 15fe03d7a93a937ca484a6569d19e7930edd3f2f | ppc: add AOZ1380 driver
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "driver/build.mk",
"new_path": "driver/build.mk",
"diff": "@@ -144,6 +144,7 @@ driver-$(CONFIG_USB_MUX_PS8743)+=usb_mux/ps874x.o\ndriver-$(CONFIG_USB_MUX_VIRTUAL)+=usb_mux/virtual.o\n# Type-C Power Path Controllers (PPC)\n+driver-$(CONFIG_USBC_PPC_AOZ1380)+=ppc... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ppc: add AOZ1380 driver
BUG=b:138599218
BRANCH=none
TEST=make buildall -j
Change-Id: Ib06053b2129623683fece8a63ee182d52cb07422
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1833922
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,324 | 01.10.2019 08:53:42 | 21,600 | bd381a6ae29a4ed62d5519f2d2b3ea05ce17f23e | trembyle: change from SN53S330 to AOZ1380
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "#include \"driver/accel_kx022.h\"\n#include \"driver/accelgyro_bmi160.h\"\n#include \"driver/bc12/pi3usb9201.h\"\n+#include \"driver/ppc/aoz1380.h\"\n#include \"driver/ppc/nx20p348... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | trembyle: change from SN53S330 to AOZ1380
BUG=b:138599218
BRANCH=none
TEST=make buildall -j
Change-Id: I1bcbd60636629751a8aad4f2574f33f391a4ad4c
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1833923 |
136,324 | 25.09.2019 11:33:53 | 21,600 | 0783b019fc880443a768acdc1286499a49594baa | pd: FRS enable/disable and interrupt handling
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_pe_drp_sm.c",
"new_path": "common/usbc/usb_pe_drp_sm.c",
"diff": "#define PE_FLAGS_RUN_SOURCE_START_TIMER BIT(19)\n#define PE_FLAGS_VDM_REQUEST_BUSY BIT(20)\n#define PE_FLAGS_VDM_REQUEST_NAKED BIT(21)\n-#define PE_FLAGS_FAST_ROLE_SWAP BIT(22)\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | pd: FRS enable/disable and interrupt handling
BUG=b:138599955
BRANCH=none
TEST=make buildall -j
Change-Id: I0c639aae18e8c2c2d1b457e2e209f8484a834f6b
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1825507
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,324 | 01.10.2019 10:57:11 | 21,600 | 31428c89c02d4ce4f65006fcaf712bb7de86bc99 | tcpc: driver changes for FRS
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "driver/tcpm/nct38xx.c",
"new_path": "driver/tcpm/nct38xx.c",
"diff": "@@ -64,15 +64,29 @@ static int nct38xx_tcpm_init(int port)\nif (rv)\nreturn rv;\n- /* Enable VBus monitor */\n+ /* Enable VBus monitor and Disable FRS */\nrv = tcpc_read(port, TCPC_REG_POWER... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | tcpc: driver changes for FRS
BUG=b:138599955
BRANCH=none
TEST=make buildall -j
Change-Id: Ic8d386355f9297c3da69021999142f35120b214c
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1834022
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,324 | 01.10.2019 10:58:29 | 21,600 | 0df7fdbf07a7d64a13416dc28e1a7538907216c5 | ppc: driver changes for FRS
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "driver/ppc/nx20p348x.c",
"new_path": "driver/ppc/nx20p348x.c",
"diff": "@@ -231,7 +231,7 @@ static int nx20p348x_init(int port)\n/* Mask interrupts for interrupt 1 register */\nmask = ~(NX20P348X_INT1_OC_5VSRC | NX20P348X_INT1_SC_5VSRC |\nNX20P348X_INT1_RCP_5V... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ppc: driver changes for FRS
BUG=b:138599955
BRANCH=none
TEST=make buildall -j
Change-Id: I84f54f4bef9f38bc194e2a45802fb6fcf335e643
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1834023
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,427 | 07.10.2019 17:41:10 | 21,600 | a205c09ca95686739e74394a4aa0e23168110395 | Trembyle: Use correct battery settings.
BRANCH=none
TEST=battery charges ok | [
{
"change_type": "MODIFY",
"old_path": "board/trembyle/battery.c",
"new_path": "board/trembyle/battery.c",
"diff": "* address, mask, and disconnect value need to be provided.\n*/\nconst struct board_batt_params board_battery_info[] = {\n- /* Panasonic AP15O5L Battery Information */\n- [BATTERY_PANAS... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: Use correct battery settings.
BUG=b:138601173
BRANCH=none
TEST=battery charges ok
Change-Id: I5dc993bfeb125ab188029375a5f37b3c06d67dd4
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1845782
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,427 | 07.10.2019 18:27:12 | 21,600 | 84ffa0bd38cba5e5daba8527c6ed09e91ca43edd | Trembyle: Don't enable the new USB-C PD stack yet
Wait for charging to work using the new USB-C PD stack before enabling it.
BRANCH=none
TEST=Plug charger in Trembyle USB-C0 | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.h",
"new_path": "baseboard/zork/baseboard.h",
"diff": "#define CONFIG_KEYBOARD_COL2_INVERTED\n#define CONFIG_KEYBOARD_PROTOCOL_8042\n+/* TODO(b/142284905): Enable new PD stack */\n+#if 0\n/* Enable the new USB-C PD stack */\n#define CO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: Don't enable the new USB-C PD stack yet
Wait for charging to work using the new USB-C PD stack before enabling it.
BUG=b:142284905
BRANCH=none
TEST=Plug charger in Trembyle USB-C0
Change-Id: I9dbadd7d955afbb8d7f7a148ed2ffb0def6c27ff
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1846751
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,256 | 07.10.2019 11:09:01 | 21,600 | dd1dbd8fee7eedef8dad4fe8a8bbec14a0ea5b2e | usbc: fix cc interpretation error
Ensure that two Rp values are interpreted as a debug accessory. Added
unit test for meaningful combinations.
BRANCH=none
TEST=passes unit test. | [
{
"change_type": "MODIFY",
"old_path": "common/usb_common.c",
"new_path": "common/usb_common.c",
"diff": "@@ -97,7 +97,7 @@ enum pd_cc_states pd_get_cc_state(\n/* Port partner is a SRC */\nif (cc_is_rp(cc1) && cc_is_rp(cc2))\n- return PD_CC_DFP_ATTACHED;\n+ return PD_CC_DFP_DEBUG_ACC;\nif (cc_is_rp(... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usbc: fix cc interpretation error
Ensure that two Rp values are interpreted as a debug accessory. Added
unit test for meaningful combinations.
BRANCH=none
BUG=none
TEST=passes unit test.
Change-Id: Ia454382f20f9377edc944dc01be133e062c218b0
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1845811
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,256 | 07.10.2019 11:25:40 | 21,600 | 9c751ff7053b556af82a38164060256fc1ccef55 | cleanup: moving define closer to use
BRANCH=none
TEST=builds | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_tc_vpd_sm.c",
"new_path": "common/usbc/usb_tc_vpd_sm.c",
"diff": "/* Type-C Layer Flags */\n#define TC_FLAGS_VCONN_ON BIT(0)\n-/* Constant used to force an initial debounce cycle */\n-#define PD_CC_UNSET -1\n-\n/**\n* This is the Type-C Port ob... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: moving define closer to use
BRANCH=none
BUG=none
TEST=builds
Change-Id: Ifa60ca375fda22e6d5f79610f10ca1d5b4f2e894
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1845813
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,377 | 20.09.2019 14:35:43 | 25,200 | a575b3abb12d4f05482781f9cff028cfa4fc9917 | docs: add disable write protect howto
BRANCH=none
TEST=read doc | [
{
"change_type": "MODIFY",
"old_path": "docs/ccd_howtos.md",
"new_path": "docs/ccd_howtos.md",
"diff": "@@ -64,6 +64,142 @@ This goes through the steps to connect SuzyQ and start using CCD.\n[Setup CCD] instructions to enable them. Being able to use the cr50\nconsole is a good enough sign that your ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: add disable write protect howto
BUG=b:140551928
BRANCH=none
TEST=read doc
Change-Id: I37409c284a1959c584146e41d3d586785a6683f2
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1816927
Reviewed-by: Wai-Hong Tam <waihong@google.com> |
136,377 | 07.10.2019 15:43:46 | 25,200 | a8237a64b798dbf52419303d4e5c623b82870d98 | docs: ccd gsc: add description of G3 WP issue
Cr50 may not be able to disable write protect in G3. Add a description
and workaround for this issue to the ccd gsc docs.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "docs/case_closed_debugging_cr50.md",
"new_path": "docs/case_closed_debugging_cr50.md",
"diff": "@@ -563,15 +563,15 @@ wp setting is reset to `follow_batt_pres`\ncr50 > wp follow_batt_pres atboot\n-#### HW WP quirks\n+### HW WP Issues\n-##### Chromeboxes\n+####... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: ccd gsc: add description of G3 WP issue
Cr50 may not be able to disable write protect in G3. Add a description
and workaround for this issue to the ccd gsc docs.
BUG=b:140551928
BRANCH=none
TEST=none
Change-Id: I752a1d4fd5a148af44b595924e57aaa7ec64e7a4
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1845780
Reviewed-by: Wai-Hong Tam <waihong@google.com> |
136,377 | 08.10.2019 10:36:45 | 25,200 | 38081d20fe8b15ac7759afa2ee9bf1f34e28dba6 | docs/sitemap: add ccd howtos
BRANCH=none
TEST=link takes you to the howtos doc. | [
{
"change_type": "MODIFY",
"old_path": "docs/sitemap.md",
"new_path": "docs/sitemap.md",
"diff": "* [Case Closed Debugging Overview](./case_closed_debugging.md)\n* [Google Security Chip Case Closed Debugging](./case_closed_debugging_cr50.md)\n+* [Tutorials](./ccd_howtos.md)\n## Fingerprint MCU (FPMC... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs/sitemap: add ccd howtos
BUG=b:140551928
BRANCH=none
TEST=link takes you to the howtos doc.
Change-Id: Id018dccb08bd0e74463b5917f02fcd4f8ad5b867
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1846678
Reviewed-by: Wai-Hong Tam <waihong@google.com> |
136,256 | 08.10.2019 09:25:34 | 21,600 | e3335daa3a22688751ba3137ac507b9a940af9c8 | cleanup: move return to separate line
The return type of state machine functions are void, so put the return
statement on its own line.
BRANCH=none
TEST=builds | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"new_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"diff": "@@ -1845,7 +1845,8 @@ static void tc_attached_snk_run(const int port)\nif (IS_ENABLED(CONFIG_USB_PD_ALT_MODE_DFP))\npd_dfp_exit_mode(port, 0, 0);\n- return ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: move return to separate line
The return type of state machine functions are void, so put the return
statement on its own line.
BRANCH=none
BUG=none
TEST=builds
Change-Id: I30f3922228840dca7441a31f0ef0727a375b351e
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1847774
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,427 | 07.10.2019 17:53:51 | 21,600 | 635f21d41c095f138cb711118a7866fcd0b5bcc4 | Trembyle: Update config for bringup
BRANCH=none
TEST=build | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.h",
"new_path": "baseboard/zork/baseboard.h",
"diff": "#ifndef __CROS_EC_BASEBOARD_H\n#define __CROS_EC_BASEBOARD_H\n-/*\n- * By default, enable all console messages excepted HC, ACPI and event:\n- * The sensor stack is generating a lo... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: Update config for bringup
BUG=none
BRANCH=none
TEST=build
Change-Id: I05c3fa2a8b72941ef1758be45428b9911938d013
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1845783
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,269 | 04.10.2019 14:32:45 | 25,200 | 1b6a44ad9e6c8f69dea9fc184a3b5054bad7df8c | docs: Add dartmonkey to FPMCU partner docs
Also rename dragonclaw to bloonchipper.
BRANCH=none
TEST=View in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/fingerprint/fingerprint-dev-for-partners.md",
"new_path": "docs/fingerprint/fingerprint-dev-for-partners.md",
"diff": "@@ -6,6 +6,8 @@ Chromebooks. The document assumes that you're using Linux to do the development;\npreferably a recent version of Ubuntu ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: Add dartmonkey to FPMCU partner docs
Also rename dragonclaw to bloonchipper.
BRANCH=none
BUG=none
TEST=View in gitiles
Change-Id: Ib2da4547bc4d8dbf44a0bc12b79a9136786a3764
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1842214
Reviewed-by: Craig Hesling <hesling@chromium.org> |
136,208 | 09.10.2019 13:53:39 | -28,800 | 871ab6099445068e2ed6d77663135d1d35f59e2a | usb_pd: drop duplicate func get_max_request_mv()
The function is added by chromium:1737899 and is
duplicate of pd_get_max_voltage().
TEST=make buildall -j
BRANCH=firmware-kukui-12573.B | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_policy.c",
"new_path": "common/usb_pd_policy.c",
"diff": "@@ -119,11 +119,6 @@ uint8_t pd_get_src_cap_cnt(int port)\nreturn pd_src_cap_cnt[port];\n}\n-uint32_t get_max_request_mv(void)\n-{\n- return max_request_mv;\n-}\n-\nvoid pd_process_source_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb_pd: drop duplicate func get_max_request_mv()
The function is added by chromium:1737899 and is
duplicate of pd_get_max_voltage().
TEST=make buildall -j
BUG=None
BRANCH=firmware-kukui-12573.B
Change-Id: Ida1f56d108573a1776dcec8460dd48439427d10d
Signed-off-by: Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1847513
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,192 | 03.10.2019 16:31:01 | 21,600 | 18bc5eba805ae2bb140373ba763acd75e20f8805 | hatch: Add baseboard function for retrieving Board ID
BRANCH=none
TEST=Verify print output matches CBI dump | [
{
"change_type": "MODIFY",
"old_path": "baseboard/hatch/baseboard.c",
"new_path": "baseboard/hatch/baseboard.c",
"diff": "@@ -344,17 +344,24 @@ void lid_angle_peripheral_enable(int enable)\n#endif\nstatic uint8_t sku_id;\n+static uint8_t board_id;\nuint8_t get_board_sku(void)\n{\nreturn sku_id;\n}\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | hatch: Add baseboard function for retrieving Board ID
BUG=none
BRANCH=none
TEST=Verify print output matches CBI dump
Change-Id: I7a61179d1ad8a4d3f7e4eea3d2e94b066176bc20
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1838883
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> |
136,324 | 09.10.2019 11:36:05 | 21,600 | 8cdc3407f73b0c3cf6e5217415c9ff6bc14f42c3 | trembyle: define the IOEX_USB_A0_RETIMER_EN pin
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/trembyle/gpio.inc",
"new_path": "board/trembyle/gpio.inc",
"diff": "@@ -50,6 +50,7 @@ GPIO(DP2_HPD, PIN(C, 1), GPIO_OUT_LOW) /* C1 DP Hotplug Detect */\nGPIO(LED_FULL_L, PIN(6, 0), GPIO_OUT_HIGH)\nGPIO(LED_CHRG_L, PIN(C, 0), GPIO_OUT_HIGH)\n+IOEX(USB_A0_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | trembyle: define the IOEX_USB_A0_RETIMER_EN pin
BUG=b:138600691
BRANCH=none
TEST=make buildall -j
Change-Id: I4083e501e76a626370ebb36fa05418af532f3bc7
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1850192
Commit-Queue: Edward Hill <ecgh@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,311 | 09.10.2019 14:22:57 | 21,600 | ecc3027cdf35ecc7072c3ba3804ccd58032c2929 | volteer: enable CONFIG_BRINGUP
Prevent EC from powering up AP during initial board bringup.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/volteer/board.h",
"new_path": "board/volteer/board.h",
"diff": "/* Optional features */\n#define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands while in dev. */\n+/*\n+ * Prevent the EC from powering up the AP by default for initial board bringup\n+ ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | volteer: enable CONFIG_BRINGUP
Prevent EC from powering up AP during initial board bringup.
BUG=none
BRANCH=none
TEST=make buildall -j
Change-Id: Id0ec787ed34444a9e40174925d8c11a8e71d66d0
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1850276
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,427 | 11.10.2019 14:23:15 | 21,600 | 7912c0fdbec588732e52bea1bd315ff6d102a15f | Test: disable flaky usb_prl test
The usb_prl test continues to be flaky.
Disable it until it can be fixed.
BRANCH=none
TEST=make -j runhosttests | [
{
"change_type": "MODIFY",
"old_path": "test/build.mk",
"new_path": "test/build.mk",
"diff": "@@ -79,7 +79,7 @@ test-list-host += usb_sm_framework_h0\ntest-list-host += usb_typec_vpd\ntest-list-host += usb_typec_ctvpd\ntest-list-host += usb_typec_drp_acc_trysrc\n-test-list-host += usb_prl\n+#test-li... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Test: disable flaky usb_prl test
The usb_prl test continues to be flaky.
Disable it until it can be fixed.
BUG=chromium:1013701
BRANCH=none
TEST=make -j runhosttests
Change-Id: Iebdc3a1c812a8864951522d7134fe8098271c86f
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1856826
Reviewed-by: Raul E Rangel <rrangel@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,287 | 10.10.2019 13:06:46 | 21,600 | 57eac6b37e1565bad779ef8fa7cdd77085f489a1 | common:test: Add comparators to test_util.h
Add <, <=, >, >= tests to test_util.h
BRANCH=None
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "include/test_util.h",
"new_path": "include/test_util.h",
"diff": "#define TEST_EQ(a, b, fmt) TEST_OPERATOR(a, b, ==, fmt)\n#define TEST_NE(a, b, fmt) TEST_OPERATOR(a, b, !=, fmt)\n+#define TEST_LT(a, b, fmt) TEST_OPERATOR(a, b, <, fmt)\n+#define TEST_LE(a, b, ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common:test: Add comparators to test_util.h
Add <, <=, >, >= tests to test_util.h
BUG=None
BRANCH=None
TEST=buildall
Change-Id: I5d8ddfc3eda59f0193707c77d52d97962ef1a325
Signed-off-by: Yuval Peress <peress@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1853694
Reviewed-by: Gwendal Grignou <gwendal@chromium.org> |
136,205 | 01.10.2019 18:28:23 | -28,800 | ffc5335db7e1f15cd5a4d4b48932ad7054a3315e | helios: Support GMR sensor for rev2 board
BRANCH=Master
TEST=Manual
Check tablet mode behavior for board version 1 and 2. | [
{
"change_type": "MODIFY",
"old_path": "board/helios/board.c",
"new_path": "board/helios/board.c",
"diff": "@@ -117,6 +117,18 @@ static void board_lid_interrupt(enum gpio_signal signal)\nlid_interrupt(signal);\n}\n+static void board_gmr_tablet_switch_isr(enum gpio_signal signal)\n+{\n+ /*\n+ * For b... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | helios: Support GMR sensor for rev2 board
BUG=b:141723737
BRANCH=Master
TEST=Manual
Check tablet mode behavior for board version 1 and 2.
Change-Id: Iea992b726d9c5a8e4562362dbd24aec8460742c4
Signed-off-by: Michael5 Chen <michael5_chen@pegatroncorp.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1831933
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> |
136,443 | 10.10.2019 15:51:39 | 25,200 | f6544e75c31e7885888d55a2fd3d804789408ab7 | common: Comment typo correction
Corrects the spelling of "functions".
This is more text than the actual diff.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "include/system.h",
"new_path": "include/system.h",
"diff": "@@ -513,7 +513,7 @@ void delay_sleep_by(uint32_t us);\n/*\n**\n- * Funtctions to control deep sleep behavior. When disabled - the device never\n+ * Functions to control deep sleep behavior. When disab... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: Comment typo correction
Corrects the spelling of "functions".
This is more text than the actual diff.
BRANCH=none
TEST=none
BUG=none
Change-Id: Id911bf020d8db9b1d6ad7bfb62d431c5114a64d8
Signed-off-by: Craig Hesling <hesling@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1854659
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,429 | 14.10.2019 12:58:42 | 25,200 | 4e573dde4722eea04c1840278e6bb257d16ef14b | Fix race condition in spiflashfw.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "Makefile.rules",
"new_path": "Makefile.rules",
"diff": "@@ -589,26 +589,29 @@ $(out)/TAGS: $(out)/cscope.files\n$(out)/tags: $(out)/cscope.files\n$(call quiet,ctags,CTAGS )\n+.PHONY: npx-monitor-dir\n+npx-monitor-dir:\n+ $(Q)mkdir -p ${out}/chip/npcx/spiflashf... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Fix race condition in spiflashfw.
BRANCH=None
BUG=chromium:1011870
TEST=make -j buildall
Change-Id: Ifa0241cf9ea02ecf989fc7257f37c24efb17c3a7
Signed-off-by: Allen Webb <allenwebb@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1860720
Reviewed-by: LaMont Jones <lamontjones@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org> |
136,192 | 14.10.2019 15:25:59 | 21,600 | 77e67bc317ebef9be9acc91e42c4a558a7ff3564 | kohaku: Change halt temperature to 90 C
BRANCH=none
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "board/kohaku/board.c",
"new_path": "board/kohaku/board.c",
"diff": "@@ -438,7 +438,7 @@ const static struct ec_thermal_config thermal_a = {\n.temp_host = {\n[EC_TEMP_THRESH_WARN] = 0,\n[EC_TEMP_THRESH_HIGH] = C_TO_K(75),\n- [EC_TEMP_THRESH_HALT] = C_TO_K(80),\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kohaku: Change halt temperature to 90 C
BUG=b:142410208
BRANCH=none
TEST=buildall
Change-Id: I8eb8d2b8ef35572f50cc3dfd1a56b7503fadb1e1
Signed-off-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1859828
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> |
136,427 | 10.10.2019 15:13:52 | 21,600 | 397042ccdc53aa7e8de7cbb0d085adc189e275d8 | Trembyle: Add USB-A retimer GPIO definitions
Add enable and reset IO expander signal definitions for USB-A PS8811
retimers.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "board/trembyle/gpio.inc",
"new_path": "board/trembyle/gpio.inc",
"diff": "@@ -50,7 +50,8 @@ GPIO(DP2_HPD, PIN(C, 1), GPIO_OUT_LOW) /* C1 DP Hotplug Detect */\nGPIO(LED_FULL_L, PIN(6, 0), GPIO_OUT_HIGH)\nGPIO(LED_CHRG_L, PIN(C, 0), GPIO_OUT_HIGH)\n-IOEX(USB_A0_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: Add USB-A retimer GPIO definitions
Add enable and reset IO expander signal definitions for USB-A PS8811
retimers.
BUG=b:138600008
BRANCH=none
TEST=none
Change-Id: I48731c143c08f450047a920c090c6abc6b30af4f
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1854373
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,427 | 08.10.2019 16:34:22 | 21,600 | d673ee383c432a85901de1d5ad3cf937a484a240 | usbc: make pe_init() static
pe_init() is called via pe_run(), so make it static.
BRANCH=none
TEST=build | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_pe_ctvpd_sm.c",
"new_path": "common/usbc/usb_pe_ctvpd_sm.c",
"diff": "@@ -44,7 +44,7 @@ static void set_state_pe(const int port, enum usb_pe_state new_state)\nset_state(port, &pe[port].ctx, &pe_states[new_state]);\n}\n-void pe_init(int port)\n+... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usbc: make pe_init() static
pe_init() is called via pe_run(), so make it static.
BRANCH=none
BUG=none
TEST=build
Change-Id: I56928369e50a2022fc7e2aee2f68f09ebe7c06b6
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1850191
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,427 | 15.10.2019 13:37:10 | 21,600 | 7508a9a69a061dd74fb0d9d83c8ebf17335a5c38 | NPCX ESPI: fix some typos
BRANCH=none
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "chip/npcx/espi.c",
"new_path": "chip/npcx/espi.c",
"diff": "@@ -611,11 +611,11 @@ void espi_init(void)\nNPCX_ESPICFG |= ESPI_SUPP_CH_ALL;\n/* Support all I/O modes */\n- SET_FIELD(NPCX_ESPICFG, NPCX_ESPICFG_IOMODE_FILED,\n+ SET_FIELD(NPCX_ESPICFG, NPCX_ESPICFG... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | NPCX ESPI: fix some typos
BUG=none
BRANCH=none
TEST=buildall
Change-Id: I7f9089ce8028f12a94d8e73dd58a5bb36ebc614f
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1862090
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,282 | 09.10.2019 18:13:38 | -28,800 | 826c22e41a500be5da388b511f958666b9bc5620 | dratini: enable ec_feature kbbacklit by SKUID
BRANCH=none
TEST=make sure ectool inventory has shown keyboard backlight support
with dratini/dragonair kbbacklit SKU. | [
{
"change_type": "MODIFY",
"old_path": "board/dratini/board.c",
"new_path": "board/dratini/board.c",
"diff": "@@ -372,3 +372,27 @@ void board_overcurrent_event(int port, int is_overcurrented)\n/* Note that the level is inverted because the pin is active low. */\ngpio_set_level(GPIO_USB_C_OC_ODL, !is... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | dratini: enable ec_feature kbbacklit by SKUID
BUG=b:140610519
BRANCH=none
TEST=make sure ectool inventory has shown keyboard backlight support
with dratini/dragonair kbbacklit SKU.
Change-Id: I8fceebc417d4b5b319dbc6126d8311346f09bdcf
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1859234
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> |
136,324 | 15.10.2019 06:53:06 | 21,600 | 2dd2eecaa743a65d8369c7799bbc1450b0d91d0e | pd: fix timer issue on pe_prs_snk_src_source_on_run
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_pe_drp_sm.c",
"new_path": "common/usbc/usb_pe_drp_sm.c",
"diff": "@@ -3069,16 +3069,15 @@ static void pe_prs_snk_src_source_on_entry(int port)\nstatic void pe_prs_snk_src_source_on_run(int port)\n{\n/* Wait until power supply turns on */\n- if ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | pd: fix timer issue on pe_prs_snk_src_source_on_run
BUG=none
BRANCH=none
TEST=make buildall -j
Change-Id: I12fbeb0a85d45bce8173c0c3831f663f5b618cc8
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1862621
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,324 | 14.10.2019 14:06:05 | 21,600 | 7a4e700b6488a138d0c5c55aaa47e626d90a5299 | pd: Add PE FRS unit test for new stack
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/build.mk",
"new_path": "common/usbc/build.mk",
"diff": "@@ -15,6 +15,7 @@ ifneq ($(CONFIG_USB_PE_SM),)\nall-obj-$(CONFIG_USB_TYPEC_VPD)+=$(_usbc_dir)usb_pe_ctvpd_sm.o\nall-obj-$(CONFIG_USB_TYPEC_CTVPD)+=$(_usbc_dir)usb_pe_ctvpd_sm.o\nall-obj-$(CONF... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | pd: Add PE FRS unit test for new stack
BUG=none
BRANCH=none
TEST=make buildall -j
Change-Id: I55453ddf1d1da0fdee902a33e14357716fb12c4a
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1859826
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,190 | 02.10.2019 12:13:17 | 25,200 | b67b7780755c9ffa5f79ce2aa6a2689e15259785 | cleanup: Refactor #ifdefs toenable use of IS_ENABLE
This change fixes #ifdef gaurds around CONFIG_USB_PD_TCPC_LOW_POWER
and CONFIG_USB_PE_SM by replacing it with IS_ENABLED condition
BRANCH=None
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"new_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"diff": "@@ -138,15 +138,12 @@ static struct type_c {\nuint64_t next_role_swap;\n/* Generic timer */\nuint64_t timeout;\n-\n-#ifdef CONFIG_USB_PD_TCPC_LOW_POWER\n/* ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: Refactor #ifdefs toenable use of IS_ENABLE
This change fixes #ifdef gaurds around CONFIG_USB_PD_TCPC_LOW_POWER
and CONFIG_USB_PE_SM by replacing it with IS_ENABLED condition
BUG=b:141971044
BRANCH=None
TEST=make buildall -j
Change-Id: I889752a8c4cdd8e22c97ede99643945fe2db868a
Signed-off-by: Ayushee <ayushee.shah@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1863823
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,287 | 11.10.2019 15:10:16 | 21,600 | 0cb158dec30f315bbb10429c3b28b6933214bcc1 | common: motion_sense: Refactor common code out of event process
Refactor motion_sense_process to include less repeated code.
TEST=buildall and run on Kohaku
BRANCH=None | [
{
"change_type": "MODIFY",
"old_path": "common/motion_sense.c",
"new_path": "common/motion_sense.c",
"diff": "@@ -610,6 +610,38 @@ static inline void increment_sensor_collection(struct motion_sensor_t *sensor,\n}\n}\n+/**\n+ * Commit the data in a sensor's raw_xyz vector. This operation might have\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: motion_sense: Refactor common code out of event process
Refactor motion_sense_process to include less repeated code.
TEST=buildall and run on Kohaku
BUG=None
BRANCH=None
Change-Id: I2e5af84f20cc7e50d3ddfb39d661238643aa99b3
Signed-off-by: Yuval Peress <peress@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1856828
Reviewed-by: Gwendal Grignou <gwendal@chromium.org> |
136,256 | 16.10.2019 14:02:51 | 21,600 | 9ac1ac60ae75405ab1b95e614d2c96d5014e6f34 | charge: allow boards to customize max battery poll time
Some designs need to keep their battery from going to sleep.
Allow boards to specify their max delay for polling the
battery.
BRANCH=octopus
TEST=Verify access battery once per 10 seconds by ec console. | [
{
"change_type": "MODIFY",
"old_path": "include/charge_state.h",
"new_path": "include/charge_state.h",
"diff": "#define CHARGE_POLL_PERIOD_CHARGE (MSEC * 250)\n#define CHARGE_POLL_PERIOD_SHORT (MSEC * 100)\n#define CHARGE_MIN_SLEEP_USEC (MSEC * 50)\n+/* If a board hasn't provided a max sleep, use 1 ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | charge: allow boards to customize max battery poll time
Some designs need to keep their battery from going to sleep.
Allow boards to specify their max delay for polling the
battery.
BUG=b:133375756
BRANCH=octopus
TEST=Verify access battery once per 10 seconds by ec console.
Change-Id: I7e70a45fe643af567434f8187344e0e0d18d733c
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1865253 |
136,330 | 08.10.2019 13:18:53 | 21,600 | f409af3d4ac946a93819fd323d348ae3bdc4141f | volteer: Configure power sequencing signals
Configure power sequencing interrupts and power-enable lines. Leave
SLP_S4_L, which will be virtual, unimplemented for now.
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "board/volteer/board.c",
"new_path": "board/volteer/board.c",
"diff": "#include \"gpio.h\"\n#include \"hooks.h\"\n#include \"lid_switch.h\"\n+#include \"power.h\"\n#include \"power_button.h\"\n#include \"switch.h\"\n#include \"system.h\"\n"
},
{
"change... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | volteer: Configure power sequencing signals
Configure power sequencing interrupts and power-enable lines. Leave
SLP_S4_L, which will be virtual, unimplemented for now.
BUG=b:139553375
TEST=make buildall
BRANCH=none
Change-Id: Idf11290c84deb9ea2a71f5498a4a0db5363d2a3b
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1865481
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,256 | 18.10.2019 11:57:13 | 21,600 | 58ac5f86059f85e24036fd4933a024dadae28f25 | octopus: lock gpio config for reset signal
BRANCH=octopus
TEST=verify that later modification of gpio flag will no allow driving
signal high. | [
{
"change_type": "MODIFY",
"old_path": "board/bloog/gpio.inc",
"new_path": "board/bloog/gpio.inc",
"diff": "@@ -88,8 +88,13 @@ GPIO(EC_BATT_PRES_L, PIN(E, 5), GPIO_INPUT)\n* being asserted. Also, it should be fine to have the EC in hibernate when H1\n* or servo wants to hold the EC in reset since VC... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | octopus: lock gpio config for reset signal
BRANCH=octopus
BUG=b:142953493
TEST=verify that later modification of gpio flag will no allow driving
signal high.
Change-Id: I0b8c1503ba8c03afa3eb6fa4f921b3480106f05b
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1869407
Commit-Queue: Edward Hill <ecgh@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,282 | 17.10.2019 16:09:02 | -28,800 | c40a6814ff463f1557dbaeb594bf2c33cb21cfbd | dratini: enable GMR sensor for tablet mode
BRANCH=none
TEST=Check screen rotation with tablet mode.
Check keyboard disabled and on-screen keyboard enabled with tablet mode. | [
{
"change_type": "MODIFY",
"old_path": "board/dratini/board.c",
"new_path": "board/dratini/board.c",
"diff": "#include \"spi.h\"\n#include \"switch.h\"\n#include \"system.h\"\n+#include \"tablet_mode.h\"\n#include \"task.h\"\n#include \"temp_sensor.h\"\n#include \"thermal.h\"\n"
},
{
"change... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | dratini: enable GMR sensor for tablet mode
BUG=none
BRANCH=none
TEST=Check screen rotation with tablet mode.
Check keyboard disabled and on-screen keyboard enabled with tablet mode.
Change-Id: Ifa3bcc24b19608fb52525208569e8fdde25e99ea
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1866218
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> |
136,427 | 21.10.2019 17:09:40 | 21,600 | e78c4c3c1e0839ba915e15ee2e711e4c0e5bb5d5 | Grunt: Add GPIO_LOCKED to EC_RST_ODL PSL input
BRANCH=grunt
TEST=GPIO is locked as input | [
{
"change_type": "MODIFY",
"old_path": "board/aleena/gpio.inc",
"new_path": "board/aleena/gpio.inc",
"diff": "@@ -26,7 +26,7 @@ GPIO_INT(USB_C0_CABLE_DET, PIN(3, 7), GPIO_INT_RISING, anx74xx_cable_det_inter\nGPIO_INT(6AXIS_INT_L, PIN(8, 6), GPIO_INT_FALLING | GPIO_SEL_1P8V, bmi160_interrupt)\n/* GPI... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Grunt: Add GPIO_LOCKED to EC_RST_ODL PSL input
BRANCH=grunt
BUG=b:143095616
TEST=GPIO is locked as input
Change-Id: I36b123ed068db268d1cd02e990dd720663eaae57
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1873008
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,427 | 14.08.2019 15:31:11 | 21,600 | bd751b403f996c603f28f20810a8fa2bf257553e | usb_mux: Add driver for AMD FP5 USB/DP Mux
BRANCH=none
TEST=build | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "@@ -130,7 +130,7 @@ const struct i2c_port_t i2c_ports[] = {\n},\n{\n.name = \"mux\",\n- .port = I2C_PORT_MUX,\n+ .port = I2C_PORT_USB_MUX,\n.kbps = 400,\n.scl = GPIO_EC_I2C_USBC_AP... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb_mux: Add driver for AMD FP5 USB/DP Mux
BUG=b:138600585
BRANCH=none
TEST=build
Change-Id: I547309c7000e7d3ca8549a7e626a63789665305d
Signed-off-by: Edward Hill <ecgh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1868921
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,256 | 17.10.2019 13:40:27 | 21,600 | 1a775899f44dbb682b2dce94d27493d9dda82588 | mocks: add tcpc and usb mux mocks
BRANCH=none
TEST=use them in CL stack with tests | [
{
"change_type": "MODIFY",
"old_path": "common/mock/build.mk",
"new_path": "common/mock/build.mk",
"diff": "mock-$(HAS_MOCK_FPSENSOR) += fpsensor_mock.o\nmock-$(HAS_MOCK_ROLLBACK) += rollback_mock.o\n+mock-$(HAS_MOCK_TCPC) += tcpc_mock.o\nmock-$(HAS_MOCK_TIMER) += timer_mock.o\n+mock-$(HAS_MOCK_USB_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | mocks: add tcpc and usb mux mocks
BRANCH=none
BUG=none
TEST=use them in CL stack with tests
Change-Id: I8a970dc65f7395264a8c536977951ae305e9c24f
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1868831
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,278 | 16.10.2019 03:02:49 | 25,200 | 3ca7a99d01b5b7e3b9593ed3d097f7ab1330e637 | assert.h: clang-format
this is just a minor cosmetic fix of assert.h courtesy of
clang-format.
BRANCH=none
TEST=make buildall passes | [
{
"change_type": "MODIFY",
"old_path": "builtin/assert.h",
"new_path": "builtin/assert.h",
"diff": "@@ -21,21 +21,25 @@ extern \"C\" {\n#ifdef CONFIG_DEBUG_ASSERT_BRIEF\nextern void panic_assert_fail(const char *fname, int linenum)\n__attribute__((noreturn));\n-#define ASSERT(cond) do { \\\n+#define... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | assert.h: clang-format
this is just a minor cosmetic fix of assert.h courtesy of
clang-format.
BRANCH=none
BUG=none
TEST=make buildall passes
Change-Id: Ic503c22f1d29e0511a3b5ecbf697c5940c93d18c
Signed-off-by: Caveh Jalali <caveh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1864424
Commit-Queue: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,256 | 21.10.2019 09:37:20 | 21,600 | 2746de7e7ed8e8657d1135359ba1d9d1ea1c23f7 | usb: fix out bounds issue for non-SOP* packets
Non SOP* packets (e.g. hard reset) do not have a message
counter, so do not try to access the message counter field.
BRANCH=none
TEST=reproduced fuzz failure locally then verified fix with prints | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_prl_sm.c",
"new_path": "common/usbc/usb_prl_sm.c",
"diff": "@@ -145,7 +145,7 @@ static struct tx_chunked {\n/* Message Reception State Machine Object */\nstatic struct protocol_layer_rx {\n/* message ids for all valid port partners */\n- int ms... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb: fix out bounds issue for non-SOP* packets
Non SOP* packets (e.g. hard reset) do not have a message
counter, so do not try to access the message counter field.
BRANCH=none
BUG=chromium:1016109
TEST=reproduced fuzz failure locally then verified fix with prints
Change-Id: I2e46b43988cba92636eb9da7f86448b037fbc0a8
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1872602 |
136,256 | 21.10.2019 09:39:10 | 21,600 | 5a11fee99739db6905984f7609dfeb37b6fe79c8 | tcpci: remove extra write when sending HARD_RST
Per the TCPCI spec, we don't need to try to write the header or
byte count when sending a non SOP* packet.
BRANCH=none
TEST=PS8751 can still send a hard reset | [
{
"change_type": "MODIFY",
"old_path": "driver/tcpm/tcpci.c",
"new_path": "driver/tcpm/tcpci.c",
"diff": "@@ -559,6 +559,16 @@ int tcpci_tcpm_transmit(int port, enum tcpm_transmit_type type,\nint reg = TCPC_REG_TX_DATA;\nint rv, cnt = 4*PD_HEADER_CNT(header);\n+ /* If not SOP* transmission, just wri... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | tcpci: remove extra write when sending HARD_RST
Per the TCPCI spec, we don't need to try to write the header or
byte count when sending a non SOP* packet.
BRANCH=none
BUG=none
TEST=PS8751 can still send a hard reset
Change-Id: I6cccbc52cf600f7930f0cbc3ac2aab578a81dc51
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1872603 |
136,311 | 23.10.2019 13:26:05 | 21,600 | 664d4e781063463923376bb9b557dc765d37b7e3 | volteer: Add GPIO_LOCKED to EC_RST_ODL PSL input
BRANCH=none
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/volteer/gpio.inc",
"new_path": "board/volteer/gpio.inc",
"diff": "@@ -45,8 +45,13 @@ UNIMPLEMENTED(PCH_DSW_PWROK)\n/*\n* GPIO_INT_BOTH is required for PSL wake from hibernate, but we don't need an\n* interrupt handler because it is automatically handled ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | volteer: Add GPIO_LOCKED to EC_RST_ODL PSL input
BUG=b:143089106
BRANCH=none
TEST=make buildall
Change-Id: I38b9331f6d0707dcd5b19823153549bd5806969f
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1876891
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,331 | 24.10.2019 15:08:59 | 21,600 | ed997d3802c4bf5c2ef42938af1dd8c72c09de65 | host: remove leftovers from using system clock in tests
There was some leftover constants and a #include we are no longer
using due to using a monotonic counter, clean it up.
BRANCH=none
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "Makefile.toolchain",
"new_path": "Makefile.toolchain",
"diff": "@@ -62,7 +62,6 @@ CFLAGS_TEST=$(if $(TEST_BUILD),-DTEST_BUILD=$(EMPTY) \\\n-DTEST_TASKFILE=$(PROJECT).tasklist,) \\\n$(if $(CTS_MODULE), $(CFLAGS_CTS)) \\\n$(if $(EMU_BUILD),-DEMU_BUILD=$(EMPTY)) ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | host: remove leftovers from using system clock in tests
There was some leftover constants and a #include we are no longer
using due to using a monotonic counter, clean it up.
BUG=chromium:1013701
BRANCH=none
TEST=buildall
Change-Id: Ieeb130aef9ee89d65459f52c8f34753c30c3c388
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1879335
Reviewed-by: Edward Hill <ecgh@chromium.org> |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.