patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -32,12 +32,12 @@ class GraphIntegrationTest(PantsRunIntegrationTest):
_ERR_TARGETS = {
'testprojects/src/python/sources:some-missing-some-not': [
"globs('*.txt', '*.rs')",
- "Snapshot(PathGlobs(include=(\'testprojects/src/python/sources/*.txt\', \'testprojects/src/python/sources/*.rs\'), exclude=... | [GraphIntegrationTest->[test_missing_sources_warnings->[setup_sources_targets],test_error_message->[setup_sources_targets,setup_bundle_target],test_missing_bundles_warnings->[setup_bundle_target]]] | This file is used to build a project without a build. A list of possible paths to find files. | Made a question about this into #9033! |
@@ -557,9 +557,9 @@ static int dw_dma_set_config(struct dma_chan_data *channel,
if (dw_chan->lli)
rfree(dw_chan->lli);
- dw_chan->lli = rballoc_align(0, SOF_MEM_CAPS_RAM | SOF_MEM_CAPS_DMA,
- sizeof(struct dw_lli) * channel->desc_count,
- PLATFORM_DCACHE_ALIGN);
+ dw_chan->lli = rballoc(SOF_MEM_FLAG_... | [int->[dw_dma_interrupt_status,DW_DSR,spin_unlock_irq,dw_dma_interrupt_mask,atomic_init,ARRAY_SIZE,dw_dma_stop,DW_FIFO_CHy,DW_CFG_HIGH,platform_dw_dma_set_transfer_size,dw_dma_start,DW_CFG_LOW,dw_dma_avail_data_size,DW_FIFO_CHx,dcache_writeback_region,notifier_event,DW_DMA_LLI_ADDRESS,rballoc_align,rfree,bzero,dma_base... | This function sets the configuration of a channel. This function is called to initialise the descriptors for a channel. This function is called by dw_dma_set_config when a new channel is config the dest width for 32 bit words DMA HW_LLI_DMA_FUNC_DMA_LL This function is called to set the configuration of a channel in th... | how often is this memory accessed @keyonjie? Is it done for every copy? |
@@ -136,12 +136,14 @@ namespace System.Collections
if (Avx2.IsSupported)
{
+ // JIT does not support code hoisting for SIMD yet
+ Vector256<byte> zero = Vector256<byte>.Zero;
fixed (bool* ptr = values)
{
- for... | [BitArray->[BitArrayEnumeratorSimple->[MoveNext->[Get]]]] | Creates a bit array from a list of boolean values. This function checks if the values in the vector are false or equal. | is `(i + Vector256<byte>.Count)` implicitly casting to `long`/`ulong`? The same for the comparison against `values.Length`? |
@@ -160,6 +160,7 @@ class Flow:
on_failure: Callable = None,
validate: bool = None,
result: Optional[Result] = None,
+ terminal_state_handler: Optional[Callable] = None,
):
self._cache = {} # type: dict
| [Flow->[_run->[copy,update],reference_tasks->[_default_reference_tasks],chain->[add_edge],serialized_hash->[serialize],downstream_tasks->[edges_from],add_edge->[copy,add_task],register->[register,update],copy->[copy],upstream_tasks->[edges_to],update->[parameters,update,add_task,add_edge,replace],run->[parameters,_run]... | Initialize a new object with the given parameters. Initialize a new Handler instance. | Might be worth including the signature of `[Flow, State, List[State]], Optional[State]` since it's relatively simple |
@@ -26,7 +26,7 @@ namespace NServiceBus
if (TimeoutsPersister.TryRemove(timeoutId, out timeoutData))
{
- var sendOptions = new DispatchOptions(timeoutData.Destination, new AtomicWithReceiveOperation(), new List<DeliveryConstraint>());
+ var sendOptions = new Dis... | [TimeoutDispatcherProcessorBehavior->[Registration->[InsertBeforeIfExists],Task->[Cooldown,Start,Warmup,Stop],Terminate->[GetPhysicalMessage,UtcNow,State,Destination,TryRemove,TimeSent,Id,ToWireFormattedString,Headers,Dispatch]]] | This method is called when a message is received. | Same here, I will include this in the new pull mentioned |
@@ -42,6 +42,8 @@ import (
"k8s.io/apimachinery/pkg/util/sets"
"k8s.io/apimachinery/pkg/util/validation"
"k8s.io/apimachinery/pkg/util/validation/field"
+
+ utils2 "github.com/gardener/gardener-extensions/controllers/provider-openstack/pkg/utils"
)
var (
| [DeepCopy,ResourceName,Index,DetermineCloudProviderInProfile,TooLong,ValidateImmutableField,NewCIDR,Duplicate,DeepEqual,Duration,ValidateLabelName,Compile,ValidateLabels,NewPath,Required,Atoi,IsValidPercent,IsDNS1123Subdomain,Has,Error,MatchString,CompareVersions,Cmp,FindStringSubmatch,NameIsDNSSubdomain,ValidateSubset... | Imports a list of objects with the given name. ValidateName validates that a given integer or percentage is a valid positive integer. | We don't want to import package from extensions here. |
@@ -230,11 +230,12 @@ class Controls:
if self.sm['plan'].fcw:
self.events.add(EventName.fcw)
if self.sm['model'].frameDropPerc > 1:
- self.events.add(EventName.modeldLagging)
+ #self.events.add(EventName.modeldLagging)
+ pass
# Only allow engagement with brake pressed when stopped... | [Controls->[controlsd_thread->[step],step->[state_transition,update_events,publish_logs,state_control,data_sample]],main->[Controls,controlsd_thread],main] | Compute carEvents from carState and events from the state machine. events for all lane change states A function to handle a single unknown key in the CAN state. | This needs to be gated between an environment variable. Maybe `SIMULATION=1` |
@@ -646,8 +646,10 @@ class Toolbox(QObject, Extension):
Logger.log("e", "Could not find the %s model.", response_type)
break
- self._server_response_data[response_type] = json_data["data"]
- self._m... | [Toolbox->[resetMaterialsQualitiesAndUninstall->[_resetUninstallVariables,closeConfirmResetDialog],launch->[_restart],_updateInstalledModels->[_convertPluginMetadata],install->[_updateInstalledModels],uninstall->[_updateInstalledModels],_fetchPackageUpdates->[_prepareNetworkManager],_onRequestFinished->[resetDownload,i... | Called when the request is finished. If loading is complete set view page to overview and download else ignore it. | Why not? In cases of work-arrounds, it's best to also explain why it's there (eg; I can see what you're doing, but in 3 months from now, no-one will remember the why) |
@@ -129,7 +129,7 @@ class RubricsController < ApplicationController
#collect the names of the criterion that contains an error in it.
criteria_with_errors[i] = key.at(0)
i = i + 1
- flash[:error] = I18n.t('rubric_criteria.upload.syntax_error', :error => "#{e}")
+ flash... | [RubricsController->[destroy->[destroy],yml_upload->[new],create->[new],move_criterion->[index],new->[new],update_positions->[update]]] | This action handles the actual upload of a single . It also handles the validation of the This action is called when the user uploads an error in the rubric_criteria. php. | Line is too long. [86/80] |
@@ -22,3 +22,9 @@ class TranslationErrorCode(Enum):
GRAPHQL_ERROR = "graphql_error"
NOT_FOUND = "not_found"
REQUIRED = "required"
+
+
+class UploadErrorCode(Enum):
+ GRAPHQL_ERROR = "graphql_error"
+ NOT_FOUND = "not_found"
+ REQUIRED = "required"
| [No CFG could be retrieved] | Returns a string describing the error that occurred while querying the graph. | Is there a case when the `NOT_FOUND` error code would be returned for this mutation? Same for `REQUIRED`, since we don't have any validation that would use it. Fields are required at the schema level. |
@@ -220,7 +220,9 @@ public class QuantileSqlAggregatorTest
new QuantilePostAggregator("a7", "a5:agg", 0.999f),
new QuantilePostAggregator("a8", "a8:agg", 0.50f)
))
- .context(ImmutableMap.<String, Object>of("skipEmptyBuckets", true))
+ ... | [QuantileSqlAggregatorTest->[testQuantileOnComplexColumn->[plan,getOnlyElement,of,size,toList,build,get,assertArrayEquals,createPlanner,run,assertEquals,getRecordedQueries],tearDown->[close],testQuantileOnFloatAndLongs->[plan,getOnlyElement,of,size,toList,build,get,assertArrayEquals,createPlanner,run,assertEquals,getRe... | Test quantiles on float and long. MultipleIntervalSegmentSpec creates a new MultipleIntervalSegmentSpec with all intervals in the same order getRecordedQueries - > null if any of the queryLogHook s recordedQueries. | No reason to do a line break here? |
@@ -11,7 +11,13 @@ export default DiscourseRoute.extend({
if (results.found) {
// Avoid polluting the history stack for external links
transition.abort();
- DiscourseURL.routeTo(results.target_url);
+
+ let url = results.target_url;
+ if (transition._discourse_anchor) {
+ ... | [No CFG could be retrieved] | Model for the permalink - check. | Is it possible there's already an anchor and this would be adding a second one? |
@@ -6833,6 +6833,13 @@ def elu(x, alpha=1.0, name=None):
Returns:
output(${out_type}): ${out_comment}
+
+ Examples:
+
+ .. code-block:: python
+
+ x = fluid.layers.data(name="x", shape=[3,10,32,32], dtype="float32")
+ y = fluid.layers.elu(x, alpha=0.2)
"""
helper = Laye... | [ctc_greedy_decoder->[topk],image_resize->[_is_list_or_turple_],sequence_first_step->[sequence_pool],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op],elementwise_min->[_elementwise_op],elementwise_max->[_elementwise_op],logical_not->[_logical_op],conv2d->[_get_default_param_initializer],logical_and->[_logi... | Compute the non - zero non - zero non - zero value of a non - zero non. | ` .. code-block:: python` ~ |
@@ -46,7 +46,7 @@ def publish_event():
sample_members = sample(services, k=randint(1, 4)) # select random subset of team members
event = CloudEvent(
type="Azure.Sdk.Demo",
- source=domain_name,
+ source='/azsdk/members',
... | [publish_event->[randint,send,append,print,sleep,len,format,CloudEvent,range,sample],publish_event,EventGridPublisherClient,AzureKeyCredential] | publish a batch of events with random members. | nit: probably worth a better const string than `'/azsdk/members'`? like `'/demo/domain_name'` |
@@ -272,7 +272,6 @@ class ReceiveLockExpired(AuthenticatedSenderStateChange):
def to_dict(self) -> typing.Dict[str, typing.Any]:
return {
- 'sender': to_checksum_address(self.sender),
'balance_proof': self.balance_proof,
'balance_hash': serialize_bytes(self.balance_p... | [ActionInitInitiator->[__ne__->[__eq__]],ReceiveLockExpired->[__ne__->[__eq__]],ReceiveTransferRefund->[__ne__->[__eq__]],ActionInitMediator->[__ne__->[__eq__]],ReceiveSecretReveal->[__ne__->[__eq__]],ActionInitTarget->[__ne__->[__eq__]],ReceiveTransferRefundCancelRoute->[__ne__->[__eq__]],ReceiveSecretRequest->[__ne__... | Serialize the object to a dictionary. | sender is removed since it's part of the balance proof? |
@@ -9,6 +9,6 @@ internal partial class Interop
internal static partial class Oleaut32
{
[DllImport(Libraries.Oleaut32, ExactSpelling = true, PreserveSig = false)]
- public static extern HRESULT GetErrorInfo(uint dwReserved, ref IErrorInfo pperrinfo);
+ public static extern void GetError... | [Interop->[Oleaut32->[HRESULT->[Oleaut32]]]] | Get the error info for a reserved block. | It would be more appropriate to keep HRESULT and delete `PreserveSig = false` instead. The code that calls it is not interested in the implicit error handling that you get with `PreserveSig = false`. (Also, the standard way to write this with `PreserveSig = false` would be `public static extern IErrorInfo GetErrorInfo(... |
@@ -2506,7 +2506,7 @@ def test_draft_order_update_with_non_draft_order(
assert error["code"] == OrderErrorCode.INVALID.name
-@patch("saleor.graphql.order.mutations.draft_orders.update_order_prices")
+@patch("saleor.graphql.order.mutations.draft_orders.update_order_prices_if_expired")
def test_draft_order_upda... | [test_order_by_token_query_by_staff_with_permission->[post_graphql,to_global_id,get_graphql_content,add,save],test_order_query_with_filter_created->[create,freeze_time,len,post_graphql,get_graphql_content,add],test_draft_order_update_doing_nothing_generates_no_events->[exists,post_graphql,to_global_id,get_graphql_conte... | Test draft order update tax error. | We should rename it. |
@@ -46,6 +46,15 @@ func (e EventJournalD) Write(ee Event) error {
if ee.ContainerExitCode != 0 {
m["PODMAN_EXIT_CODE"] = strconv.Itoa(ee.ContainerExitCode)
}
+ // If we have container labels, we need to convert them to a string so they
+ // can be recorded with the event
+ if len(ee.Details.Attributes) > 0... | [Write->[Itoa,Format,ToHumanReadable,String,Send],String->[String],Read->[Wrapf,GetCursor,GetEntry,AddMatch,Wait,Next,Cause,String,Errorf,Wrap,NewJournal,Done,SeekTail],Parse,Atoi,Errorf] | Write writes the event to the journal. | Should this be LIBPOD_LABELS? |
@@ -44,7 +44,7 @@ function main() {
downloadBuildOutput(FILENAME);
timedExecOrDie('gulp update-packages');
timedExecOrDie('gulp test --integration --nobuild --headless --coverage');
- timedExecOrDie('gulp test --unit --nobuild --headless --coverage');
+ timedExecOrDie('gulp unit --nobuild --headles... | [No CFG could be retrieved] | Main script for the unit and integration tests on a local Travis VM. BuildOutput - Build output for all packages in the system. | Remember to update `contributing/TESTING.md#testing-commands`. It might need a clean up, since there are a large number of testing commands. (Related: #17846) |
@@ -48,8 +48,8 @@ uint16_t HAL_adc_result;
// Public functions
// ------------------------
-// Needed for DELAY_NS() / DELAY_US() on CORTEX-M7
-#if (defined(__arm__) || defined(__thumb__)) && __CORTEX_M == 7
+// Needed for DELAY_NS() / DELAY_US() on CORTEX-M4 to M7
+#if (defined(__arm__) || defined(__thumb__)) && W... | [No CFG could be retrieved] | -------------- Public functions - Public functions - Public functions - Public functions - Public functions - Public functions HAL RCC HAL functions. | I think you can remove LPC. It's M3 and already excluded by previous check |
@@ -396,6 +396,9 @@ public class SimpleParDoFn<InputT, OutputT> implements ParDoFn {
window,
targetTime);
+ fnRunner.onWindowExpiration(
+ window, timer.getOutputTimestamp(), this.stepContext.stateInternals().getKey());
+
// This is for a timer for a window that is expired, ... | [SimpleParDoFn->[NoopOutputsPerElementTracker->[NoopOutputsPerElementTracker],abort->[abort],processElement->[onProcessElementSuccess,reallyStartBundle,onProcessElement,processElement],finishBundle->[finishBundle],processTimer->[processSystemTimer,processUserTimer],processTimers->[reallyStartBundle,processTimer,process... | Process a system timer. | @reuvenlax, Can you guide why we are not considering outputTimestamp in WindmillTimerInternals.windmillTimerToTimerData. TimerData is created as follows: `TimerData.of(id, familyId, namespace, timestamp, timerTypeToTimeDomain(timer.getType()));` I think this is where we lost outputTimestamp. |
@@ -291,6 +291,18 @@ def create_ecg_epochs(raw, ch_name=None, event_id=999, picks=None, tmin=-0.5,
.. versionadded:: 0.14.0
+ qrs_threshold : float | str
+ Between 0 and 1. qrs detection threshold. Can also be "auto" to
+ automatically choose the threshold that generates a reasonable
+ ... | [find_ecg_events->[qrs_detector],create_ecg_epochs->[find_ecg_events]] | Conveniently generate epochs around ECG artifact events. This function is used to apply a specific time - series reservation to a specific time - series Missing nanoseconds in the series. | I don't think we need this one, can just use `raw.crop`. It was probably in `find_ecg_events` before we had this |
@@ -38,7 +38,10 @@ public class VoidCoder extends AtomicCoder<Void> {
private VoidCoder() {}
@Override
- public void encode(Void value, OutputStream outStream) {
+ public void encode(Void value, OutputStream outStream) throws IOException {
+ if (value != null) {
+ throw (new IOException("Attempting to... | [VoidCoder->[VoidCoder]] | Encode a sequence number. | Drop extraneous brackets: `throw (new IOException("Attempting to encode non-null value with VoidCoder."));` -> `throw new IOException("Attempting to encode non-null value with VoidCoder.");` |
@@ -191,6 +191,7 @@ class InstallCommand(RequirementCommand):
cmd_opts.add_option(cmdoptions.no_binary())
cmd_opts.add_option(cmdoptions.only_binary())
cmd_opts.add_option(cmdoptions.prefer_binary())
+ cmd_opts.add_option(cmdoptions.prefer_local_compatible())
cmd_opts.add_opti... | [InstallCommand->[_handle_target_dir->[remove,distutils_scheme,any,append,isdir,ensure_dir,startswith,move,join,islink,exists,warning,listdir,rmtree],_warn_about_conflicts->[check_install_conflicts,critical,error],__init__->[only_binary,use_pep517,no_deps,make_option_group,python_version,abi,progress_bar,ignore_require... | Initialize command line options. Adds options related to packages that are not specified by default. Add missing options and options to the command line. | Wait - on the original issue, I made the point very strongly that I was against this being added to `pip install`. |
@@ -31,7 +31,7 @@ from .utils import tidy_content
log = logging.getLogger('kuma.wiki.tasks')
-render_lock = MemcacheLock('render-stale-documents-lock', expires=60 * 60)
+render_lock = RedisLock('render-stale-documents-lock', expires=60 * 60)
@task(rate_limit='60/m')
| [render_document_chunk->[render_document],build_locale_sitemap->[WikiSitemap]] | Simple task wrapper for the render method of the Document model. | I intend to get rid of all this locking someday. But I haven't got around to it in the last two years, so maybe we have to keep it for a while longer. |
@@ -211,13 +211,12 @@ namespace System.Drawing
#region Cocoa Methods
[DllImport("libobjc.dylib")]
public static extern IntPtr objc_getClass(string className);
- [DllImport("libobjc.dylib")]
- public static extern IntPtr objc_msgSend(IntPtr basePtr, IntPtr selector, string argume... | [CocoaContext->[Synchronize->[CGContextSynchronize],Release->[CGContextRestoreGState]],CarbonContext->[Synchronize->[CGContextSynchronize],Release->[ReleaseContext]]] | Get an object that has a unique selector on the object. | Would this look better as `rect_objc_msgSend_stret(out Rect arect` ? The Xamarin examples are not 100% consistent - majority of them are using `out`, a few exception are using `ref` for some reason. |
@@ -206,9 +206,8 @@ public class HttpPostRequestEncoder implements ChunkedInput<HttpContent> {
throw new NullPointerException("charset");
}
HttpMethod method = request.method();
- if (!(method.equals(HttpMethod.POST) || method.equals(HttpMethod.PUT)
- || method.equal... | [HttpPostRequestEncoder->[encodeNextChunkUrlEncoded->[fillByteBuf],encodeNextChunkMultipart->[fillByteBuf],WrappedHttpRequest->[protocolVersion->[protocolVersion],setUri->[setUri],getDecoderResult->[getDecoderResult],method->[method],setDecoderResult->[setDecoderResult],headers->[headers],uri->[uri],setProtocolVersion-... | Creates a new instance of HttpPostRequestEncoder. FileUpload. encode. | any reason why this is not `IllegalArgumentException`? We are not necessarily encoding data here. |
@@ -71,9 +71,12 @@ class AmpVideo extends AMP.BaseElement {
/** @private {?Element} */
this.video_ = null;
- /** @private {?boolean} */
+ /** @private {boolean} */
this.muted_ = false;
+ /** @private {boolean} */
+ this.isPrerenderAllowed_ = false;
+
/** @private {!../../../src/me... | [No CFG could be retrieved] | Create an object that represents an amp - video element. Replies the video source of the element. | I think this could just be `/** @private */`. The type is unnecessary here because Closure Compiler infers the type when an initial primitive value or a typed function return value is assigned. |
@@ -62,7 +62,7 @@ func (ns *notificationService) NotifyCreateIssueComment(doer *models.User, repo
_ = ns.issueQueue.Push(opts)
}
-func (ns *notificationService) NotifyNewIssue(issue *models.Issue) {
+func (ns *notificationService) NotifyNewIssue(issue *models.Issue, mentions []*models.User) {
_ = ns.issueQueue.P... | [NotifyIssueChangeStatus->[Push],NotifyNewPullRequest->[Push,Error,LoadIssue],NotifyPullReviewRequest->[Push],NotifyNewIssue->[Push],NotifyPullRequestPushCommits->[Push],NotifyIssueChangeAssignee->[Push],NotifyCreateIssueComment->[Push],NotifyMergePullRequest->[Push],NotifyPullRequestReview->[Push],Run->[RunWithShutdow... | NotifyCreateIssueComment creates a comment for an issue. | Also we need send mentions notification to ui, of course that could be another PR. |
@@ -453,6 +453,8 @@ func NewIssuePost(ctx *context.Context, form auth.CreateIssueForm) {
return
}
+ notification.Service.NotifyIssue(issue)
+
log.Trace("Issue created: %d/%d", repo.ID, issue.ID)
ctx.Redirect(ctx.Repo.RepoLink + "/issues/" + com.ToStr(issue.Index))
}
| [ParseInLocation,Status,QueryEscape,GetIssueByIndex,IsPoster,Int64sToMap,IsErrLabelNotExist,Redirect,AllowsPulls,Info,GetTreeEntryByPath,IsErrIssueNotExist,ChangeStatus,New,IsErrPullRequestNotExist,GetAssignees,UpdateLabel,ChangeMilestoneAssign,ToStr,ParamsInt64,IsWriterOfRepo,SetCookie,Render,Split,PairsContains,Detec... | NewIssuePost response for creating new issue Reads the attachment from the file and creates a new attachment. | Should this be put in background too ? is: `go notification.Service.NotifyIssue(issues)` If I read the code correctly the NotifyIssue writes into a channel, is that operation immediate or blocks until someone *reads* from the channel ? (lame gopher here) |
@@ -142,11 +142,14 @@ define([
* volume, such that if (planeMask & (1 << planeIndex) === 0), for k < 31, then
* the parent (and therefore this) volume is completely inside plane[planeIndex]
* and that plane... | [No CFG could be retrieved] | Determines whether a bounding volume intersects the culling volume. 32 planes. | This callback doesn't really belong in `CullingVolume`. The logic of whether to proceed with checking the clipping planes should exist in `Cesium3DTile`. |
@@ -167,12 +167,9 @@ class Agent:
as a hook for child classes to optionally implement.
"""
- def agent_connect(self) -> str:
+ def agent_connect(self) -> None:
"""
Verify agent connection to Prefect Cloud by finding and returning a tenant id
-
- Returns:
- -... | [Agent->[agent_connect->[ConnectionError,debug,type,print,format,info,query_tenant_id],deploy_flow->[NotImplementedError],agent_process->[bool,error,partial,add,len,add_done_callback,run,info,query_flow_runs,submit],_verify_token->[AuthorizationError,graphql],start->[agent_connect,agent_process,debug,heartbeat,max,keys... | Called when the agent is shutting down. | Now that the tenant id query is removed this should perform some basic query to verify that it is connected / authenticated. Otherwise in this current implementation it's just for show |
@@ -25,7 +25,7 @@ var (
flags = pflag.NewFlagSet(`diplomat-sds`, pflag.ExitOnError)
keysDirectory = flags.String("keys-directory", "", "Directory where the keys are stored")
verbosity = flags.Int("verbosity", 1, "Set logging verbosity level")
- port = flags.Int("port", 15123, "Service Discove... | [Flush,RegisterSecretDiscoveryServiceServer,Int,Error,Sprintf,Background,WithCancel,NewGrpc,Lookup,Notify,String,GrpcServe,Parse,Info,NewFlagSet,Set,NewSDSServer] | main import imports the given object into the library. _ - Flag not found in the environment. | Nit : Service Discovery Services |
@@ -778,9 +778,13 @@ int safe_open(const char *pathname, int flags, ...)
*
* @param pathname The path to open.
* @param flags Same mode as for system fopen().
+ * @param ... Optional permissions argument, same as in safe_open()
* @return Same errors as fopen().
*/
-FILE *safe_fopen(const char *path, const cha... | [No CFG could be retrieved] | Opens a file or symlink and returns - 1 if it can t be opened. Safely open a file or directory. | It's not optional here. |
@@ -90,6 +90,10 @@ class BaseTree:
or self.HASH_JOBS
)
+ @cached_property
+ def enable_dos2unix(self):
+ return self.repo and self.repo.config["core"].get("dos2unix")
+
@classmethod
def get_missing_deps(cls):
import importlib
| [BaseTree->[_check_requires->[get_missing_deps,RemoteMissingDepsError],copy->[RemoteActionNotImplemented],move->[remove],upload->[RemoteActionNotImplemented],upload_fobj->[RemoteActionNotImplemented],_download_dir->[walk_files],_download_file->[move,makedirs],get_hash->[exists,isdir],get_dir_hash->[_collect_dir],_colle... | Returns a list of packages that are missing the checksum jobs. | I don't think this really belongs in `BaseTree` long term, but currently we compute MD5's from both `RepoTree` and `LocalTree` |
@@ -666,6 +666,8 @@ func (display *ProgressDisplay) processEndSteps() {
wroteDiagnosticHeader := false
for _, row := range display.eventUrnToResourceRow {
+ wroteResourceHeader := false
+
for id, payloads := range row.DiagInfo().StreamIDToDiagPayloads {
if len(payloads) > 0 {
if id != 0 {
| [filterOutUnnecessaryNodesAndSetDisplayTimes->[filterOutUnnecessaryNodesAndSetDisplayTimes],processEvents->[processNormalEvent,processEndSteps,processTick],processEndSteps->[refreshAllRowsIfInTerminal,writeSimpleMessage,refreshSingleRow,writeBlankLine],handleSystemEvent->[refreshAllRowsIfInTerminal,writeSimpleMessage],... | processEndSteps is called when the end of the processing of the progress steps. This function splits the given message into lines that can be displayed. Write a simple message to the screen. | this was the original intent of the code here. We iterate over each resource so that all the messages are grouped by resource. The intent was that if we then had any diagnostics to show for that resource, we would print out its name once, then all the diags. but my logic was bad (or this got munged around over time), a... |
@@ -15,4 +15,14 @@ class CategoryAndTopicListsSerializer < ApplicationSerializer
users
end
+ def primary_groups
+ groups = object.topic_list.topics.map do |t|
+ t.posters.map { |poster| poster.try(:primary_group) }
+ end
+ groups.flatten!
+ groups.compact!
+ groups.uniq!(&:id)
+ groups... | [CategoryAndTopicListsSerializer->[users->[flatten!,uniq!,compact!,try,map],has_one,has_many]] | Returns an array of users that have not yet been found in the cluster. | Could this be causing a n+1 query? It seems to me like it could be and we should confirm it is not. |
@@ -16,6 +16,12 @@ from KratosMultiphysics import python_linear_solver_factory as linear_solver_fac
from KratosMultiphysics import auxiliary_solver_utilities
import KratosMultiphysics.kratos_utilities as kratos_utils
+if kratos_utils.CheckIfApplicationsAvailable("EigenSolversApplication"):
+ import KratosMultiph... | [MechanicalSolver->[AddDofs->[AddDofs],_create_convergence_criterion->[_get_convergence_criterion_settings],_create_builder_and_solver->[get_linear_solver],_execute_after_reading->[import_constitutive_laws],Initialize->[Initialize],_create_line_search_strategy->[GetComputingModelPart,get_solution_scheme,get_builder_and... | Creates a class which implements the Mechanics Solve API. Returns true if the model part list is valid for compiling. | importing bcs you might need is is not allowed. The factory imports it if necessary (by the way we had problems with this) |
@@ -224,6 +224,11 @@ namespace Microsoft.Xna.Framework.Audio
#region IDisposable Members
+ public bool IsDisposed
+ {
+ get { return false; }
+ }
+
public void Dispose()
{
//_sound.Dispose ();
| [SoundEffect->[Play->[Play,Pitch,Pan,Volume,CreateInstance],LoadAudioStream->[Load],Seek,Write,Begin,Empty,OpenRead,GetFileNameWithoutExtension,Close,LoadAudioStream,ToCharArray,Zero,Length]] | Dispose of the object if it is an object with a non - null tag. | This should be really fixed some day ... |
@@ -143,6 +143,7 @@ def draw_bounding_boxes(
boxes: torch.Tensor,
labels: Optional[List[str]] = None,
colors: Optional[List[Union[str, Tuple[int, int, int]]]] = None,
+ fill: Optional[List[Union[str, Tuple[int, int, int, int]]]] = None,
width: int = 1,
font: Optional[str] = None,
font_s... | [save_image->[make_grid],make_grid->[norm_range->[norm_ip],norm_range]] | Draws bounding boxes on given image. Draw the on the image. | I'm on the fence on this one while trying to balance flexibility and easy-of-use in this API. I think that having this as a list of colors would require people to provide too many parameters and pick too many colors. If you recall the palette size was one of the considerations on the first PR around this util, so addin... |
@@ -65,9 +65,12 @@ class FileBasedSink(iobase.Sink):
compression_type=CompressionTypes.AUTO):
"""
Raises:
- TypeError: if file path parameters are not a string or ValueProvider,
- or if compression_type is not member of CompressionTypes.
- ValueError: if shard_name_t... | [FileBasedSink->[close->[close]],FileBasedSinkWriter->[close->[close],write->[write_record],__init__->[open]]] | Initializes the object with the specified parameters. | Why is syntax for classes alternating between `~exceptions.TypeError` :class:`~apache_beam.options.value_provider.ValueProvider` |
@@ -1,5 +1,6 @@
-class RateLimitCheckerJob < ApplicationJob
- queue_as :rate_limit_checker
+class RateLimitCheckerJob
+ include Sidekiq::Worker
+ sidekiq_options queue: :default, retry: false
def perform(user_id, action)
user = User.find_by(id: user_id)
| [RateLimitCheckerJob->[perform->[call,find_by],queue_as]] | Perform an action on a user if there is no user with this id. | I was wondering if it wouldn't be better to separate the PR that adds Sidekiq from the PR that starts switching jobs. Another thing: don't we have to make sure there are no `RateLimitCheckerJob` running before we switch this over? What happens if after the restart of the dynos`ActiveJob/Delayed::Job` loads the `RateLim... |
@@ -13,10 +13,6 @@ namespace Pulumi
private protected override void ValidateMember(Type memberType, string fullName)
{
- if (typeof(IInput).IsAssignableFrom(memberType))
- {
- throw new InvalidOperationException($"{fullName} must not be an Input<T>");
- ... | [InvokeArgs->[ValidateMember->[IsAssignableFrom]]] | Validate that the given member is not an input. | I'd have to double check, but after removing the implementation below, I suspect no subclass actually has an implementation and `ValidateMember` could be nuked entirely. But that can be cleaned up separately. |
@@ -0,0 +1,14 @@
+package io.quarkus.banner.deployment;
+
+import io.quarkus.runtime.annotations.ConfigItem;
+import io.quarkus.runtime.annotations.ConfigPhase;
+import io.quarkus.runtime.annotations.ConfigRoot;
+
+@ConfigRoot(name = "banner", phase = ConfigPhase.BUILD_TIME)
+public class BannerConfig {
+ /**
+ ... | [No CFG could be retrieved] | No Summary Found. | I think it would be nice to have an example here showing how a user can put a custom banner (and where they need to add this file). Other than this, I'm good with the PR |
@@ -296,7 +296,7 @@ class Jetpack_Search_Helpers {
}
}
- if ( empty( $action ) || empty( $widget ) ) {
+ if ( empty( $widget ) ) {
return false;
}
| [Jetpack_Search_Helpers->[should_rerun_search_in_customizer_preview->[is_preview]]] | This function is used to get the value of a widget in a multi - value array. This function is used to test if a record is in the correct state. | `$action` is always set to something. |
@@ -594,8 +594,9 @@ namespace Dynamo.Models
PreferenceSettings = settings;
PreferenceSettings.PropertyChanged += PreferenceSettings_PropertyChanged;
}
- // If user does not agree to GA terms, do not try to launch the client at all
- if (PreferenceSett... | [DynamoModel->[RemoveWorkspace->[Dispose],Report3DPreviewOutage->[OnPreview3DOutage],InitializeNodeLibrary->[InitializeIncludedNodes],UngroupModel->[DeleteModelInternal],EngineController_RequestCustomNodeRegistration->[RegisterCustomNodeDefinitionWithEngine],Dispose->[Dispose],AddWorkspace->[OnWorkspaceSaved,CheckForIn... | Creates a DynamoModel with all of the default configuration options. Initialize the migration manager. | This is GA instrumentation here, will be removed later and should only be tied to GA agreement. We may want to revert the change here |
@@ -129,7 +129,7 @@ class PermissionManager(object):
user = User.get_collection().find_one({'login': login})
if user is None:
- raise MissingResource(user=login)
+ raise InvalidValue(['login'])
# Make sure resource is a valid string or unicode
if not isinsta... | [PermissionManager->[revoke_permission_from_user->[revoke],revoke->[delete_permission],grant_automatic_permissions_for_resource->[grant],operation_names_to_values->[operation_name_to_value],grant_automatic_permissions_for_user->[grant],grant->[create_permission]]] | Grant permissions on a resource for a user and a set of operations being granted. | Can the docstrings for these functions that raise `InvalidValue` have a `:raises InvalidValue:` added to them along with a reasonable description of when it gets raised? You didn't create this problem, but I do notice it in the PR. |
@@ -539,10 +539,12 @@ get_object_layout(struct pl_jump_map *jmap, struct pl_obj_layout *layout,
layout->ol_shards[0].po_fseq = target->ta_comp.co_fseq;
setbit(tgts_used, target->ta_comp.co_id);
- if (pool_target_unavail(target)) {
+ if (pool_target_unavail(target)&& !(ignore_up == true &&
+ target->ta_comp... | [No CFG could be retrieved] | region Object Class Lookup find the first entry in the list of objects that can be mapped to the target object and. | (style) spaces required around that '&&' (ctx:VxW) |
@@ -741,9 +741,9 @@ EOT
// Check whether the PHP version was the problem
if (true !== $ignorePlatformReqs && $versionSelector->findBestCandidate($name, $requiredVersion, $preferredStability, true)) {
throw new \InvalidArgumentException(sprintf(
- 'Package %s... | [InitCommand->[determineRequirements->[findPackages],formatAuthors->[parseAuthorString],findBestVersionAndNameForPackage->[getMinimumStability,getRepositorySet],getRepositorySet->[getRepos]]] | Finds the best version and name for a package. Finds the best candidate package version. | isn't this always true due to the `if ($requiredVersion)` ? |
@@ -830,7 +830,7 @@ export default Component.extend({
if (this.site.mobileView) {
$("#reply-control .mobile-file-upload").on("click.uploader", function () {
// redirect the click on the hidden file input
- $("#mobile-uploader").click();
+ $("#file-uploader").click();
});
}... | [No CFG could be retrieved] | Upload a single block of images from a link to a link to a link to a link Add a click handler to the image - scale - btn and the preview - btn to replace. | I think it would be better if we got rid of jQuery here too! |
@@ -408,7 +408,9 @@ export function getDataParamsFromAttributes(element, opt_computeParamNameFunc) {
const params = Object.create(null);
for (let i = 0; i < attributes.length; i++) {
const attr = attributes[i];
- const matches = attr.name.match(/^data-param-(.+)/);
+ const attrName = attr.name;
+ co... | [No CFG could be retrieved] | Returns an array of child elements with the given tag name. This method loops up the DOM tree until the window is closed. | I don't think this will work. This changes the behavior for existing pages/clients. I think we should add another parameter to the function that accepts a regex called `opt_paramPattern`. If the value is not provided, you can default to `/^data-param-(.+)/`. Then from instrumentation.js, pass in the value of the patter... |
@@ -1020,7 +1020,7 @@ public class OrganizationDaoTest {
.setName(organizationDto.getName())
.setDescription(organizationDto.getDescription())
.setUrl(organizationDto.getUrl())
- // TODO : .setDefaultQualityGateUuid(dbClient.qualityGateDao().selectBuiltIn(dbSession).getId().toString())
+ ... | [OrganizationDaoTest->[verifyOrganization1->[verifyOrganization1]]] | Creates a new organization object with the same properties as the given organizationDto. | As the commit is only about existing quality gate, nothing should has been done on new one |
@@ -70,6 +70,8 @@ class GoogLeNet(nn.Module):
aux_logits: bool = True,
transform_input: bool = False,
init_weights: Optional[bool] = None,
+ dropout: float = 0.2,
+ dropout_aux: float = 0.7,
blocks: Optional[List[Callable[..., nn.Module]]] = None,
) -> None:
... | [GoogLeNet->[forward->[eager_outputs,_transform_input,_forward]],Inception->[forward->[_forward]]] | Initialize a GOOGLENet model with a sequence of n - classes. Inception block for missing - block - related parameters. | I think it's best for BC reasons to move all new params at the end. |
@@ -284,8 +284,8 @@ void TransientSpatialDependantPorositySolutionBodyForceProcess::SetInitialBodyFo
const double press_grad1 = 0.0;
const double press_grad2 = 0.0;
- r_body_force1 = du1dt + convective1 + 1.0/rho * press_grad1 - 2 * nu * div_of_sym_grad1 + (2.0/3.0) * nu * grad_of_div1;
- ... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - region TransientSpatialDependantPorositySolutionBodyForceProcess Methods. | correct spacing near the end of the line |
@@ -26,6 +26,7 @@ within the functions themselves.
"""
from typing import Any, Optional
+URN = str
def is_asset(obj: Any) -> bool:
"""
| [is_resource->[isinstance],is_asset->[isinstance],is_archive->[isinstance],is_custom_resource->[isinstance],is_output->[isinstance],is_unknown->[isinstance],is_stack->[isinstance],is_custom_timeouts->[isinstance]] | Checks if the given object is an Asset. | The Node.js SDK already has a `type URN = string` alias that it uses throughout its APIs, e.g. `Resource.urn` is typed as `Output<URN>`. However, the Python SDK has always just used `str` (e.g. `Resource.urn` is typed as `Output[str]`). Given the Python SDK doesn't already have an alias for `URN = str`, I wonder if we ... |
@@ -348,7 +348,9 @@ const files = {
templates: [
'shared/shared.module.ts',
'shared/shared-libs.module.ts',
- 'shared/duration.pipe.ts',
+ 'shared/date/duration.pipe.ts',
+ 'shared/date/format-medium-date.pipe.ts',
+ ... | [No CFG could be retrieved] | Services for the given application. The authentication service is a list of all possible authentication services. | Maybe name this `format-medium-datetime.pipe.ts` so that name reflects as accurately as possible the purpose of this pipe? |
@@ -534,6 +534,12 @@ class BlockAdmin(BlockAdminAddMixin, admin.ModelAdmin):
return (details, history, edit)
+ def has_change_permission(self, request, obj=None):
+ if obj and BlockSubmission.get_submission_from_guid(obj.guid):
+ return False
+ else:
+ return super().... | [BlockSubmissionAdmin->[save_model->[is_pending_signoff,has_signoff_permission,has_change_permission],change_view->[is_pending_signoff,has_signoff_permission,has_change_permission,_get_enhanced_guid_context],formfield_for_dbfield->[is_single_guid],has_change_permission->[is_pending_signoff],add_view->[is_single_guid,ha... | Returns a list of fieldsets for the given object. | Should there be a test for this, or is it considered covered by `test_cannot_edit_when_guid_in_blocksubmission`? |
@@ -29,6 +29,8 @@ import shutil
import filecmp
from llnl.util.filesystem import traverse_tree, mkdirp, touch
+import llnl.util.tty as tty
+import spack.error
__all__ = ['LinkTree']
| [LinkTree->[unmerge->[remove,cmp,isdir,ValueError,join,islink,exists,traverse_tree,listdir,rmtree],find_conflict->[exists,traverse_tree,isdir],merge->[append,link,AssertionError,isdir,get,ValueError,touch,join,exists,traverse_tree,mkdirp,listdir],__init__->[exists,IOError]]] | This file is part of Spack. Returns the first file in dest that conflicts with src. | If this imports anything from Spack, it needs to be in `spack.util` not `llnl.util`. The rule of thumb I use is whether the code is general enough (as written) to be used outside Spack, or whether some part of it could be used elsewhere. Here I think this stuff probably belongs in `llnl.util`, but the exceptions need t... |
@@ -841,9 +841,9 @@ for plat_specific in [True, False]:
Returns:
str: include files directory
"""
- if 'python_inc' in self.config_vars:
+ try:
return self.config_vars['python_inc']['false']
- else:
+ except KeyError:
return os.path.jo... | [Python->[deactivate->[write_easy_install_pth,python_ignore],get_sysconfigdata_name->[command,print_string],test->[print_string],config_vars->[command,print_string],activate->[write_easy_install_pth,python_ignore],symlink->[symlink]]] | Directory for the include files and standard library. | I'm fine with these changes, but under what circumstances would `config_vars` have a `python_inc` key but not a `false` key? |
@@ -0,0 +1,10 @@
+package aQute.bnd.build.api;
+
+import java.util.List;
+
+import aQute.bnd.build.Project;
+
+public interface BuildInfo {
+ Project getProject();
+ List<? extends ArtifactInfo> getArtifactInfos();
+}
| [No CFG could be retrieved] | No Summary Found. | This should be `List<ArtifactInfo>`. You never want to use wildcards in a return type since it messes up the code using your API. |
@@ -109,8 +109,8 @@ export function layoutRectFromDomRect(rect) {
/**
* Returns true if the specified two rects overlap by a single pixel.
- * @param {!LayoutRectDef} r1
- * @param {!LayoutRectDef} r2
+ * @param {{top: number, bottom: number, left: number, right: number}} r1
+ * @param {{top: number, bottom: numbe... | [No CFG could be retrieved] | Creates a layout rect based on the specified left top width and height parameters. Returns the position of r1 relative to r2 relative to r1. | This allows being called with ClientRect since `x` and `y` are not needed anyways. |
@@ -40,7 +40,8 @@ namespace System.Reflection.Metadata
{
int callingConventionOrKind = _rawValue & CallingConventionOrKindMask;
- if (callingConventionOrKind > maxCallingConvention)
+ if (callingConventionOrKind > maxCallingConvention
+ &&... | [SignatureHeader->[ToString->[ToString],Equals->[Equals]]] | Relations of header bytes that are used in all method signatures. Replies if the signature attribute is set. | Add similar change to `SignatureKind Kind` as well? |
@@ -659,7 +659,9 @@ class TestQueueBasics(QueueTest):
days, widths, under_7 = data
f = addon.versions.all()[0].all_files[0]
- f.update(created=datetime.now() - timedelta(days=days))
+ d = datetime.now() - timedelta(days=days)
+ f.update(created=d)
+ addon.versions.latest(... | [QueueTest->[_test_queue_count->[generate_files],generate_file->[generate_files],_test_get_queue->[get_queue,generate_files],setUp->[login_as_editor]],TestQueueSearchVersionSpecific->[test_age_of_submission->[search,named_addons,update_beiber]],TestStatusFile->[test_other->[get_file,check_status],test_status_prelim->[c... | Check the missing key in the add - on bar. | This would be a good occasion to stop naming variables `f` and `d` :p |
@@ -0,0 +1,15 @@
+<?php
+/*
+* Plugin Name: a
+*/
+
+use Jetpack\Assets\Logo;
+
+require __DIR__ . '/vendor/autoload.php';
+
+add_action( 'plugins_loaded', function() {
+ add_filter( 'the_content', function() {
+ $logo = new Logo();
+ return $logo->render();
+ } );
+} );
| [No CFG could be retrieved] | No Summary Found. | Do we want to ship the toy plugin with Jetpack? It's mostly meant to test things, right? I don't know if we need to include it with every dev environment from now on? |
@@ -30,10 +30,10 @@ describe ServiceProvider do
end
context 'the record does not exist' do
- let(:service_provider) { ServiceProvider.from_issuer('no-such-issuer') }
+ let(:service_provider) { ServiceProvider.find_by(issuer: 'no-such-issuer') }
- it 'returns NullServiceProvider' do
- ... | [let,be,describe,subject,it,to,before,require,belong_to,include,read,from_issuer,context,be_a,build,with_primary_key,eq,and_return,be_kind_of] | A basic example of how to create a service provider. SP to optionally skip encrypting the SAML response. | The parent `describe` block is for `from_issuer`. Since we're removing the method, maybe we should just remove the block altogether? I think it's fair to assume `find_by` given a nonsense value would return `nil`. |
@@ -276,6 +276,14 @@ public class OzoneManagerServiceProviderImpl
return omLeaderUrl;
}
+ private boolean isOmSpengoEnabled() {
+ if (configuration.get(OZONE_OM_HTTP_AUTH_TYPE, "simple")
+ .equals("kerberos")) {
+ return true;
+ }
+ return false;
+ }
+
/**
* Method to obtain curr... | [OzoneManagerServiceProviderImpl->[stop->[stop],start->[start,registerOMDBTasks],syncDataFromOM->[getAndApplyDeltaUpdatesFromOM,updateReconOmDBWithNewSnapshot],getOzoneManagerDBSnapshot->[getOzoneManagerSnapshotUrl],updateReconOmDBWithNewSnapshot->[getOzoneManagerDBSnapshot]]] | Gets the Ozone Manager Snapshot URL. return null if not a caveat. | nit. Can be simplified to 1 line method. |
@@ -15,10 +15,11 @@ import (
kcmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
ktemplates "k8s.io/kubernetes/pkg/kubectl/util/templates"
+ cmdversion "github.com/openshift/oc/pkg/cli/version"
+ osversion "github.com/openshift/oc/pkg/version"
+
"github.com/openshift/origin/pkg/cmd/flagtypes"
"github.com/opensh... | [Root,UsageFunc,Examples,NewCmdVersion,GLog,NewCmdCompletion,DefaultSubCommandRun,LongDesc,Usage,LocalFlags,AddCommand,HasSuffix,Lookup,ToLower,Get,ActsAsRootCommand,Commands,TrimSuffix,Sprintf,VisitAll,UseOptionsTemplates,PersistentFlags] | CommandFor returns a command for the given base name. OpenShift command for OpenShift. | That looks weird, one should be `openshift/origin/pkg/version` and other should be `openshift/oc/pkg/version`. |
@@ -82,3 +82,11 @@ func ReportToCSV(report *reportingapi.Report) (string, error) {
}
return content, nil
}
+
+func maxCharLimit(item string) string {
+ if utf8.RuneCountInString(item) > 32000 {
+ countToReturn := 32000 - 52
+ return fmt.Sprintf("character limit exceeds 32,000. truncating message: %s", string([]r... | [GetRelease,Error,Timestamp,MarshalString,FormatFloat,GetName,Errorf,GetPlatform] | content - > content. | nitpick: Instead of hardcoding the length of the message, you could have the message in a variable and take its length instead. This would be useful if we ever wanted to tweak the message, etc. |
@@ -20,7 +20,9 @@ use Friendica\Core\Config;
require_once 'boot.php';
require_once 'object/BaseObject.php';
-$a = new App(__DIR__);
+if (empty($a)) {
+ $a = new App(__DIR__);
+}
BaseObject::set_app($a);
// We assume that the index.php is called by a frontend process
| [is_backend,query,get_scheme,save_timestamp,loadHTML,init_page_end,max_processes_reached,appendChild,init_pagehead,maxload_reached,saveHTML,loadXML,importNode] | Load the configuration of a specific object. Check if a node is a known node and if so redirect to the URL. | Again the same code as in `get_app()`! Encapsulate this, please. |
@@ -0,0 +1,8 @@
+class NavigationLink < ApplicationRecord
+ URI_REGEXP = URI::DEFAULT_PARSER.make_regexp(%w[http https]).freeze
+ SVG_REGEXP = /\A<svg .*>/i.freeze
+
+ validates :name, :url, :icon, presence: true
+ validates :url, format: URI_REGEXP
+ validates :icon, format: SVG_REGEXP
+end
| [No CFG could be retrieved] | No Summary Found. | this is missing one validator: `validates :requires_auth, inclusion: { in: [true, false]}` Learned recently that is important :D |
@@ -156,11 +156,11 @@ public class SCMTriggerTest {
p.addTrigger(t);
// Start one build to block others
- assertTrue(p.scheduleBuild(new UserCause()));
+ assertTrue(p.scheduleBuild(new Cause.UserCause()));
buildStarted.block(); // wait for the build to really start
... | [SCMTriggerTest->[TestSCM->[checkout->[checkout]]]] | Multiple polling one build action. | Not to be confused with `hudson.slaves.OfflineCause.UserCause`. |
@@ -274,7 +274,15 @@ public class ChunkOutputWidget extends Composite
{
return expansionState_.addValueChangeHandler(handler);
}
-
+
+ public void renderHtml(String htmlOutput)
+ {
+ if (StringUtil.isNullOrEmpty(htmlOutput))
+ return;
+ final RenderTimer renderTimer = new Render... | [ChunkOutputWidget->[clearCollapsedStyles->[collapsed],completeInterrupt->[showReadyState],hasPlots->[hasPlots],RenderTimer->[cancel->[cancel]],initializeOutput->[attachPresenter,syncHeight],onOutputFinished->[syncHeight],updatePlot->[updatePlot,pendingResize],setPlotPending->[setPlotPending,pendingResize],onResize->[o... | Adds a handler which is called when a chunk of the expansion state changes. | It looks like we create a render timer here but then never use it? |
@@ -794,8 +794,8 @@ func (pkg *Package) marshalObjectData(
}, nil
}
-func (pkg *Package) marshalObject(t *ObjectType) (ComplexTypeSpec, error) {
- data, err := pkg.marshalObjectData(t.Comment, t.Properties, t.Language)
+func (pkg *Package) marshalObject(t *ObjectType, plain bool) (ComplexTypeSpec, error) {
+ data,... | [marshalResource->[marshalObjectData,marshalObject],bindProperties->[newOptionalType,bindType],bindResourceType->[bindResourceTypeDetails],bindEnumTypeDetails->[bindPrimitiveType],marshalType->[marshalType],bindObjectType->[bindObjectTypeDetails],marshalFunction->[marshalObject],bindType->[newMapType,bindPrimitiveType,... | marshalObjectData marshals an object data structure. | These changes are not really fixing a bug in prod code but just enabling the test right? This code does not run in prod contest? Could we move it in a file that only compiles for tests, or mark somehow? Always less spooky reviewing PRs that do not edit prod code. |
@@ -57,11 +57,16 @@ using OpenTK.Platform;
using OpenTK;
using OpenTK.Graphics.OpenGL;
#endif
+#if WINDOWS_PHONE
+using System.Windows;
+#endif
namespace Microsoft.Xna.Framework
{
internal class Threading
{
+ public const int kMaxWaitForUIThread = 12000; // In milliseconds
+
static int ... | [No CFG could be retrieved] | License - The name of the object that is returned by the object. Checks if the code is currently running on the UI thread. | Note here @nezz - this timeout should be 750, no 12000. I put that 12000 in there as a test and forgot to remove it. The timeout is key here because that's why the perceived lock occurs upon startup. |
@@ -334,4 +334,12 @@ TouchBar.TouchBarScrubber = class TouchBarScrubber extends TouchBarItem {
}
}
+TouchBar.TouchBarOtherItemsProxy = class TouchBarOtherItemsProxy extends TouchBarItem {
+ constructor (config) {
+ super()
+ if (config == null) config = {} // no config options anyways
+ this._addImmutab... | [No CFG could be retrieved] | The last two arguments are the last two arguments. | This is a noop, we can just ignore `config` altogether here |
@@ -20,6 +20,10 @@ class Googlebot_Presenter extends Abstract_Indexable_Presenter {
* @return string The googlebot output tag.
*/
public function present() {
+ if ( $this->presentation->model->is_robots_noindex === true ) {
+ return '';
+ }
+
$googlebot = \implode( ', ', $this->get() );
$googlebot = $... | [Googlebot_Presenter->[present->[filter,get]]] | Returns the HTML for the googlebot meta tag. | Why did you put that here and not in the `Indexable_Presentation` or in the `get` method? I would argue that the value itself is empty when no-index is set. |
@@ -202,7 +202,7 @@ const std::string Parameters::const_iterator_adaptor::name()
Parameters::Parameters()
{
- mpRoot = Kratos::make_shared<nlohmann::json>(nlohmann::json::parse( "{}" ));
+ mpRoot = Kratos::make_shared<nlohmann::json>(nlohmann::json::parse( "{}", nullptr, true, true));
mpValue = mpRoot.ge... | [No CFG could be retrieved] | returns current parameter of the parameter list. | they broke their API? I didn't read this in the release notes |
@@ -634,10 +634,10 @@ namespace System.Xml
internal override string XPLocalName { get { return LocalName; } }
- internal override string? GetXPAttribute(string localName, string ns)
+ internal override string GetXPAttribute(string localName, string ns)
{
if (ns == OwnerD... | [XmlElement->[XmlAttribute->[GetAttributeNode],WriteContentTo->[WriteTo],RemoveAttribute->[RemoveAttributeNode],GetAttribute->[GetAttributeNode],HasAttribute->[GetAttributeNode],WriteStartElement->[WriteStartElement,WriteTo],WriteElementTo->[WriteTo],RemoveAll->[RemoveAllAttributes,RemoveAll],RemoveAllChildren->[Remove... | Get an XP attribute. | hm, it might be return null on purpose CC @krwq |
@@ -30,11 +30,9 @@ abstract class AbstractNioMessageChannel extends AbstractNioChannel {
}
@Override
- protected Unsafe newUnsafe() {
- return new NioMessageUnsafe();
- }
+ protected abstract NioMessageUnsafe newUnsafe();
- private class NioMessageUnsafe extends AbstractNioUnsafe {
+ ... | [AbstractNioMessageChannel->[newUnsafe->[NioMessageUnsafe],doFlushMessageBuffer->[doWriteMessages,getWriteSpinCount,isEmpty],NioMessageUnsafe->[read->[inEventLoop,pipeline,inboundMessageBuffer,isOpen,doReadMessages,fireInboundBufferUpdated,close,fireExceptionCaught,voidFuture]]]] | read method. | Let's prepend `Abstract` to the class name like `AbstractServerUnsafe`. |
@@ -81,13 +81,15 @@ module View
operator = all_operators.find { |o| o.name == operator_name }
if operator
store(:historical_routes, generate_last_route(operator))
+ store(:historical_laid_hexes, last_laid_hexes(operator))
else
store(:historical_route... | [MapControls->[route_controls->[generate_last_route]]] | Renders a hidden input that is used to select the last route in the group. | you need to add skip: true to both of these so you don't rerender twice |
@@ -70,10 +70,10 @@ func (c *RuleChecker) CheckWithFit(region *core.RegionInfo, fit *placement.Regio
c.record.refresh(c.cluster)
if len(fit.RuleFits) == 0 {
- checkerCounter.WithLabelValues("rule_checker", "fix-range").Inc()
+ checkerCounter.WithLabelValues("rule_checker", "need-split").Inc()
// If the regio... | [CheckWithFit->[fixRange,fixOrphanPeers,fixRulePeer,ZapError,String,Inc,WithLabelValues,refresh,Debug],isDownPeer->[GetPeer,Warn,GetStoreId,Seconds,GetStore,Uint64,GetId,GetDownSeconds,DownTime,GetDownPeers,GetMaxStoreDownTime,GetOpts],fixRange->[GetEndKey,CreateSplitRegionOperator,GetSplitKeys,GetStartKey,ZapError,Deb... | CheckWithFit checks if a region matches a given fit. | Do we need to update the Grafana json also? |
@@ -94,6 +94,11 @@ var config = {
// input and will suggest another valid device if one is present.
enableNoAudioDetection: true,
+ // Enabling this will show a "Save Logs" link in the GSM popover that can be
+ // used to collect debug information (XMPP IQs, SDP offer/answer cycles)
+ // about the ... | [No CFG could be retrieved] | Enables callstats for a given percentage of users. Valid values for a sequence of images. | do we want to have it in the whitelist? |
@@ -124,6 +124,7 @@ public class SCMException extends IOException {
FAILED_TO_ALLOCATE_ENOUGH_BLOCKS,
INTERNAL_ERROR,
FAILED_TO_INIT_PIPELINE_CHOOSE_POLICY,
- FAILED_TO_INIT_LEADER_CHOOSE_POLICY
+ FAILED_TO_INIT_LEADER_CHOOSE_POLICY,
+ FAILED_TO_FINALIZE_UPGRADE
}
}
| [No CFG could be retrieved] | Get the ethernet chain header from the network. | I don't see any usages for this. |
@@ -204,11 +204,16 @@ public final class HibernateOrmProcessor {
return;
}
+ // we only support the default datasource for now
+ Optional<JdbcDataSourceBuildItem> defaultJdbcDataSourceBuildItem = jdbcDataSourcesBuildItem.stream()
+ .filter(i -> i.isDefault())
+ ... | [HibernateOrmProcessor->[createMetricBuildItem->[build],handleHibernateORMWithNoPersistenceXml->[getSqlLoadScript],registerBeans->[build]]] | Build a Hibernate ORM index with additional jpa model classes. This method is called when the build item is not indexed. This method is called when a managed unit is not available. | I think we should at least warn users if more than one is configured |
@@ -742,7 +742,7 @@ class Var(SymbolNode):
super().__init__()
self._name = name # Name without module prefix
# TODO: Should be Optional[str]
- self._fullname = cast(Bogus[str], None) # Name with module prefix
+ self._fullname = cast('Bogus[str]', None) # Name with module pre... | [ClassDef->[serialize->[serialize],is_generic->[is_generic],deserialize->[ClassDef,deserialize]],TypeAlias->[serialize->[serialize]],FuncDef->[serialize->[serialize],deserialize->[FuncDef]],Decorator->[fullname->[fullname],serialize->[serialize],name->[name],deserialize->[Decorator,deserialize]],TypeVarExpr->[serialize... | Initialize a object. | Why quotes are now needed here? |
@@ -89,6 +89,7 @@ namespace System.Net.Http.Functional.Tests
protected override Task SerializeToStreamAsync(Stream stream, TransportContext context)
{
_tcs.SetResult(true);
+ Ticks = Environment.TickCount64;
return base.SerializeToStreamAsync(st... | [HttpClientHandler_Http11_Cancellation_Test->[Task->[Task]]] | Serialize the object to the given stream. | Is the `TaskCompletionSource` used somewhere? We could probably get rid of it. Otherwise, I'd at least swap setting of `Ticks` with signaling `_tcs` so that if there is someone waiting on it, it will have `Ticks` ready when unblocked. |
@@ -258,6 +258,17 @@ function compile(watch, shouldMinify, opt_preventRemoveAndMakeDir,
include3pDirectories: true,
includePolyfills: false,
}),
+ compileJs('./3p/', 'ampanalytics-lib.js',
+ './dist.3p/' + (shouldMinify ? internalRuntimeVersion : 'current'), {
+ minifiedName: 'ampanaly... | [No CFG could be retrieved] | Compiles a single node - module into a promise. A mage - viewer - host. js. | The type checking issues I was having yesterday on unchanged files are fixed. I had duplicated the "closureCompile(['./3p/ampcontext-lib.js'], './dist'," block beginning on line 653 and changed "ampcontext" to "ampanalytics". It also made "gulp check-types" not report any typing errors in my actual code. Removing that ... |
@@ -586,8 +586,13 @@ test_yield_deletes_extent(void *arg)
2, false);
rc = vos_aggregate(ctx->tsc_coh, &epr, NULL, NULL, NULL, true);
-
assert_success(rc);
+ /*
+ * not totally sure why this is needed, but maybe to wait for
+ * aggregation to finish? But without it, extent_deleted_by_aggregation
+ * t... | [main->[daos_debug_init,assert_success,vos_self_fini,run_scrubbing_tests,daos_debug_fini,print_error,DP_RC,vos_self_init],void->[iov_alloc,assert_success,vos_obj_update,d_iov_set,daos_csummer_init_with_type,sts_ctx_update,sts_ctx_do_scrub,daos_file_is_dax,daos_obj_set_oid,setup_iod_type,DP_RC,sts_ctx_cont_fini,d_sgl_in... | private static void void_yield_deletes_extent test_yield_deletes_. | vos_aggreate() is a synchronous call here. |
@@ -257,8 +257,8 @@ func TopicSearch(ctx *context.Context) {
kw := ctx.Query("q")
topics, err := models.FindTopics(&models.FindTopicOptions{
- Keyword: kw,
- Limit: 10,
+ Keyword: kw,
+ ListOptions: models.ListOptions{PageSize: 10},
})
if err != nil {
log.Error("SearchTopics failed: %v", err)
| [SaveTopics,AddTopic,Status,FindTopics,InternalServerError,Error,SanitizeAndValidateTopics,ValidateTopic,NotFound,ToLower,DeleteTopic,JSON,ToTopicResponse,Params,TrimSpace,Query] | returns a list of topics with the given id. | why not add pagination query optons to **TopicSearch** to0 ?? |
@@ -383,7 +383,7 @@ class Config
self::deprecatedVariable('rrdgraph_real_95th', 'rrdgraph_real_percentile');
self::deprecatedVariable('fping_options.millisec', 'fping_options.interval');
self::deprecatedVariable('discovery_modules.cisco-vrf', 'discovery_modules.vrf');
-
+ self::depreca... | [No CFG could be retrieved] | Process configuration variables. Path to external paths not in bin. | Should `oxidized.groups` not be `oxidized.group`? |
@@ -135,16 +135,9 @@ function publicize_load_more_link() {
add_filter( 'jetpack_learn_more_button_publicize', 'publicize_load_more_link' );
function publicize_more_info() { ?>
- <div class="jp-info-img">
- <a href="http://en.support.wordpress.com/publicize/" target="_blank">
- <img class="jp-info-img" src="<?php... | [No CFG could be retrieved] | Show a more info about the node. | There's a tab here between `for` and `yourself` |
@@ -108,6 +108,9 @@ class MsgDispatcher(MsgDispatcherBase):
def handle_update_search_space(self, data):
self.tuner.update_search_space(data)
+ def handle_feed_tuner_data(self, data):
+ self.tuner.feed_tuner_data(data)
+
def handle_add_customized_trial(self, data):
# data: parame... | [MsgDispatcher->[load_checkpoint->[load_checkpoint],save_checkpoint->[save_checkpoint],_earlystop_notify_tuner->[_handle_final_metric_data],_handle_intermediate_metric_data->[_sort_history],handle_add_customized_trial->[_pack_parameter,_create_parameter_id],handle_request_trial_jobs->[_pack_parameter,_create_parameter_... | Handle the update of the search space. | tuner or tuning? This function is also used by the Advisor. |
@@ -163,8 +163,9 @@ public class SimpleMonitoringInfoBuilder {
*
* @param urn The urn of the MonitoringInfo
*/
- public void setUrn(String urn) {
+ public SimpleMonitoringInfoBuilder setUrn(String urn) {
this.builder.setUrn(urn);
+ return this;
}
/**
| [SimpleMonitoringInfoBuilder->[setInt64Value->[setInt64Value],setUrn->[setUrn],setUrnForUserMetric->[setUrn,userMetricUrn],build->[validate,build]]] | Set the URN of the node. | Nice improvement to follow proper builder pattern, building has been simplified a lot. |
@@ -10,8 +10,8 @@ angular.module('<%=angularAppName%>')
$scope.error = null;
$scope.doNotMatch = null;
$scope.changePassword = function () {
- if ($scope.password != $scope.confirmPassword) {
- $scope.doNotMatch = "ERROR";
+ if ($scope.password !== $scope.... | [No CFG could be retrieved] | A nagios controller that allows to change the password of a user. | I don't care about the warning, 'OK' is just better here |
@@ -47,7 +47,9 @@ class <%= entityClass %>GatlingTest extends Simulation {
.acceptEncodingHeader("gzip, deflate")
.acceptLanguageHeader("fr,fr-fr;q=0.8,en-us;q=0.5,en;q=0.3")
.connectionHeader("keep-alive")
- .userAgentHeader("Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:33.0) Geck... | [No CFG could be retrieved] | Creates a new GATLING test. Create a map of HTTP headers that can be used to authenticate the request. | the condition with `<%_` should be in a new line |
@@ -493,6 +493,13 @@ public final class MetadataManager
{
requireNonNull(prefix, "prefix is null");
+ Optional<QualifiedObjectName> objectName = prefix.asQualifiedObjectName();
+ if (objectName.isPresent()) {
+ return getTableHandle(session, objectName.get())
+ ... | [MetadataManager->[dropRole->[dropRole],getTableMetadata->[getTableMetadata],resolveIndex->[resolveIndex],applySample->[usesLegacyTableLayouts],listEnabledRoles->[listEnabledRoles],getStatisticsCollectionMetadata->[getStatisticsCollectionMetadata],finishDelete->[finishDelete],getUpdateRowIdColumnHandle->[getUpdateRowId... | List all tables with a given prefix. | what is the difference here? You replaced one metastore call with the other. In hive connector this method translates to `getTable` metastore call. |
@@ -364,11 +364,15 @@ namespace Microsoft.Xna.Framework.Graphics
public static BlendingFactorSrc GetBlendFactorSrc (this Blend blend)
{
- switch (blend) {
+ switch (blend) {
+ case Blend.BlendFactor:
+ return BlendingFactorSrc.ConstantColor;
case Blend.DestinationAlpha:
re... | [GraphicsExtensions->[LogGLError->[CheckGLError]]] | Returns the name of the BlendingFactorSrc object with the name of the given blend. | Ugh... so `Blend.InverseBlendFactor` was falling thru to the `default` case? Maybe this is a good reason to make the `default` case throw an exception to avoid this sort of mistake in the future? |
@@ -24,7 +24,10 @@ public interface JobCatalog {
/** Returns an immutable {@link Collection} of {@link JobSpec}s that are known to the catalog. */
Collection<JobSpec> getJobs();
- /** Get a {@link JobSpec} by uri. */
+ /**
+ * Get a {@link JobSpec} by uri.
+ * @throws JobSpecNotFoundException if no such J... | [No CFG could be retrieved] | get all jobs. | can you declare the `JobSpecNotFoundException`? |
@@ -86,9 +86,9 @@ export class WindowPortEmulator {
addEventListener(eventType, handler) {
this.win.addEventListener('message', e => {
if (
- e.origin == this.origin_ &&
- e.source == this.target_ &&
- getData(e)['app'] == APP
+ e.origin === this.origin_ &&
+ e.source =... | [No CFG could be retrieved] | Creates a new instance of the MessagePort class. A class that exports a single . | The `===` seems to be overused here a bit. Why? |
@@ -55,9 +55,14 @@ class Lammps(CMakePackage, CudaPackage):
version('20170901', sha256='5d88d4e92f4e0bb57c8ab30e0d20de556830af820223778b9967bec2184efd46')
def url_for_version(self, version):
- vdate = dt.datetime.strptime(str(version), "%Y%m%d")
- return "https://github.com/lammps/lammps/archi... | [Lammps->[url_for_version->[str,strftime,strptime,format],setup_run_environment->[set],cmake_args->[upper,satisfies,append,format,define,define_from_variant],depends_on,conflicts,format,version,patch,variant]] | Returns a URL for a given version. | @adamjstewart if you have python suggestions here, go ahead. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.