instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
ansible__ansible-79017@173a83e | ansible/ansible | Python | 79,017 | ansible-vault: add newline to the output of the 'encrypt_string' command | ##### SUMMARY
Adds newline to the `ansible-vault encrypt_string ...` output.
Fixes #78932, more details here.
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
Ansible-vault: `encrypt_string` output | 2022-10-04T05:45:06Z | ansible-vault encrypt_string output is missing a new line, causing broken output on copy
### Summary
```
$ ansible-vault encrypt_string secret
Encryption successful
!vault |
$ANSIBLE_VAULT;1.1;AES256
61633966613365393435663962393261376338336136313065376437373838636336623565363239
66... | Files identified in the description:
* [`lib/ansible/utils/encrypt.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/utils/encrypt.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.... | [
{
"body": "### Summary\n\n```\r\n$ ansible-vault encrypt_string secret\r\nEncryption successful\r\n!vault |\r\n $ANSIBLE_VAULT;1.1;AES256\r\n 61633966613365393435663962393261376338336136313065376437373838636336623565363239\r\n 6630383564363634636364613830613561316333623739380a65376433... | f0cc70f9e1d4991957f3a55eb9ef1c5617e4cd2b | {
"head_commit": "173a83eb61ff0740148dd528fd12b4be26900b5f",
"head_commit_message": "ansible-vault: add newline to the output of the 'encrypt_string' command",
"patch_to_review": "diff --git a/lib/ansible/cli/vault.py b/lib/ansible/cli/vault.py\nindex 3e60329de608a2..7dcd213d6040dd 100755\n--- a/lib/ansible/cli/v... | [
{
"diff_hunk": "@@ -384,7 +384,7 @@ def execute_encrypt_string(self):\n sys.stderr.write(err)\n b_outs.append(to_bytes(out))\n \n- self.editor.write_data(b'\\n'.join(b_outs), context.CLIARGS['output_file'] or '-')\n+ self.editor.write_data(b'\\n'.join(b_outs) + b'\\n', ... | 2287b97fa06ca966fe260aa1628440c9bd3cd4a8 | diff --git a/changelogs/fragments/79017-ansible-vault-string-encryption-ending-with-newline.yml b/changelogs/fragments/79017-ansible-vault-string-encryption-ending-with-newline.yml
new file mode 100644
index 00000000000000..4a4ec84eadfb62
--- /dev/null
+++ b/changelogs/fragments/79017-ansible-vault-string-encryption-en... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-78175@7c2f90a | ansible/ansible | Python | 78,175 | Preflight encodings check | ##### SUMMARY
Preflight encodings check. Fixes #77658
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
lib/ansible/cli/__init__.py
##### ADDITIONAL INFORMATION
<!--- Include additional information to help people understand the change here -->
<!--- A step-by-step reproduction of the problem is... | 2022-06-30T19:16:09Z | Implement pre-flight checks for locale and fsencoding
### Summary
Add preflight checks to `lib/ansible/cli/__init__.py` for both the local locale and the fsencoding to ensure they are `UTF-8`, and abort when they are not.
We implicitly require this now, but have never strictly enforced it. Due to using `pathlib` ... | Files identified in the description:
* [`lib/ansible/cli/__init__.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/cli/__init__.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.co... | [
{
"body": "### Summary\r\n\r\nAdd preflight checks to `lib/ansible/cli/__init__.py` for both the local locale and the fsencoding to ensure they are `UTF-8`, and abort when they are not.\r\n\r\nWe implicitly require this now, but have never strictly enforced it. Due to using `pathlib` in more places, to avoid un... | e10851d495fd073e22bdd78ec45a1f8019604b35 | {
"head_commit": "7c2f90a70e6f2a438e47be3ac702da34882b13a3",
"head_commit_message": "Remove inspection of LOCALE_INITIALIZED in get_text_width",
"patch_to_review": "diff --git a/changelogs/fragments/ansible-require-utf8.yml b/changelogs/fragments/ansible-require-utf8.yml\nnew file mode 100644\nindex 0000000000000... | [
{
"diff_hunk": "@@ -40,6 +40,28 @@ def check_blocking_io():\n \n check_blocking_io()\n \n+\n+def check_encoding():\n+ \"\"\"Check file system encoding and locale to ensure UTF-8.\"\"\"\n+ import ansible.utils.locale as locale_utils\n+ fs_enc = sys.getfilesystemencoding()\n+ if fs_enc.lower() != 'utf... | 50527ea9c482635cb44dd2959ac7dbaf92bffa78 | diff --git a/changelogs/fragments/ansible-require-utf8.yml b/changelogs/fragments/ansible-require-utf8.yml
new file mode 100644
index 00000000000000..ee5a4198359650
--- /dev/null
+++ b/changelogs/fragments/ansible-require-utf8.yml
@@ -0,0 +1,6 @@
+major_changes:
+ - ansible - At startup the filesystem encoding and loc... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-78794@299e8a2 | ansible/ansible | Python | 78,794 | Adding two new os.path filters and its docs | Signed-off-by: Shivam Durgbuns <sdurgbun@redhat.com>
##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Adding two new filters based on os.path, specifically: `os.path.commonpath`, `os.path.normpath`
Fixes #78675
##### ISSUE TYPE
<!--- Pick one below and delete the re... | 2022-09-16T12:29:43Z | More os.path filters
### Summary
Please add more filters based on os.path, specifically: `os.path.commonpath`, `os.path.normpath`. It is cheap, but would be handy in such tasks as validation, archive management, programmatic path generation. Can replace a lot of loops and regex filters.
### Issue Type
Feature Idea
... | Files identified in the description:
None
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/devel/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
I would like t... | [
{
"body": "### Summary\n\nPlease add more filters based on os.path, specifically: `os.path.commonpath`, `os.path.normpath`. It is cheap, but would be handy in such tasks as validation, archive management, programmatic path generation. Can replace a lot of loops and regex filters.\n\n### Issue Type\n\nFeature Id... | 3b937123d26473b7005674b8915423e3f38f6105 | {
"head_commit": "299e8a267a6ced068bfb028f946908a2c3cea279",
"head_commit_message": "Adding two new os.path filters and its docs\n\nSigned-off-by: Shivam Durgbuns <sdurgbun@redhat.com>",
"patch_to_review": "diff --git a/docs/docsite/rst/playbook_guide/playbooks_filters.rst b/docs/docsite/rst/playbook_guide/playbo... | [
{
"diff_hunk": "@@ -565,6 +565,16 @@ def path_join(paths):\n raise AnsibleFilterTypeError(\"|path_join expects string or sequence, got %s instead.\" % type(paths))\n \n \n+def commonpath(paths):\n+ '''\n+ takes a list of paths and it returns the longest common path from the given list.\n+ '''",... | db44ecc69b137df0e1d4a97707878da72e9e9254 | diff --git a/docs/docsite/rst/playbook_guide/playbooks_filters.rst b/docs/docsite/rst/playbook_guide/playbooks_filters.rst
index 7a4c7f47a6ce90..395c5474892dc1 100644
--- a/docs/docsite/rst/playbook_guide/playbooks_filters.rst
+++ b/docs/docsite/rst/playbook_guide/playbooks_filters.rst
@@ -2021,6 +2021,7 @@ To join one... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-78317@c465be3 | ansible/ansible | Python | 78,317 | wait_for - Read file and perform comparisons using bytes to avoid decode errors | ##### SUMMARY
wait_for - Read file and perform comparisons using bytes to avoid decode errors. Fixes #78214
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/modules/wait_for.py
##### ADDITIONAL INFORMATION
With the test added, and without this change:
```
TASK [wait_for : test no... | 2022-07-20T15:16:04Z | wait_for with search_regex : UnicodeDecodeError
### Summary
`wait_for` with arguments `path` and `search_regex` throws UnicodeDecodeError when the source file (given in `path`) is not UTF-8. It happens a lot with log files, which is our use case.
It works fine with Python 2.7, fails as soon as I add ` -e ansible_py... | Files identified in the description:
* [`lib/ansible/modules/wait_for.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/wait_for.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://g... | [
{
"body": "### Summary\n\n`wait_for` with arguments `path` and `search_regex` throws UnicodeDecodeError when the source file (given in `path`) is not UTF-8. It happens a lot with log files, which is our use case.\r\n\r\nIt works fine with Python 2.7, fails as soon as I add ` -e ansible_python_interpreter=\"/usr... | 90ef914f77da5cc0b45e54b23ca0cc9dbc58e642 | {
"head_commit": "c465be3da7e28d2e16fbbe13e6559298394f099a",
"head_commit_message": "wait_for - Read file and perform comparisons using bytes to avoid decode errors. Fixes #78214",
"patch_to_review": "diff --git a/changelogs/fragments/78214-wait-for-compare-bytes.yml b/changelogs/fragments/78214-wait-for-compare-... | [
{
"diff_hunk": "@@ -571,22 +580,20 @@ def main():\n # file doesn't exist yet, so continue\n else:\n # File exists. Are there additional things to check?\n- if not compiled_search_re:\n+ if not b_compiled_search_re:\n ... | 031adbe9c263560c3664551a94f9cb5eb25f9f9d | diff --git a/changelogs/fragments/78214-wait-for-compare-bytes.yml b/changelogs/fragments/78214-wait-for-compare-bytes.yml
new file mode 100644
index 00000000000000..252d7ca4a99f49
--- /dev/null
+++ b/changelogs/fragments/78214-wait-for-compare-bytes.yml
@@ -0,0 +1,3 @@
+bugfixes:
+- wait_for - Read file and perform co... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-78128@262b566 | ansible/ansible | Python | 78,128 | add note about permission change | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #25389
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Docs Pull Request
##### COMPONENT NAME
<!--- Write the short n... | 2022-06-23T14:53:05Z | file based modules change ownership after editing.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
lineinfile
##### ANSIBLE VERSION
<!--- Paste verbatim output from “ansible --version” between quotes below -->
```
2.3.0.0
```
##### CONFIGURATION
##### OS / ENVIRONMENT
Centos 7
##### SUMMARY
I... | I was able to reproduce this bug.
I created `userA` and `userB` as part of `usertest` group
Create `ownership.txt` owned by `userA` but write permissions granted through the group permissions to `userB`.
```
[userA tmp]$ ls -al
total 4
drwxrwxrwx. 7 root usertest 126 Jun 9 08:21 .
-rw-rw-r--. 1 userA use... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nlineinfile\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from “ansible --version” between quotes below -->\r\n```\r\n2.3.0.0\r\n```\r\n\r\n##### CONFIGURATION\r\n\r\n##### OS / ENVIRONMENT\r\nCentos 7\r\n\r\n##### SUMMARY\... | 70543402c73fce5d031f39c52209045a42615947 | {
"head_commit": "262b566f8ea6d5d6de9c09a45a1b723d72e8cc97",
"head_commit_message": "add note about permission change",
"patch_to_review": "diff --git a/lib/ansible/modules/lineinfile.py b/lib/ansible/modules/lineinfile.py\nindex 0e1b76f5cbad1e..3337627310baed 100644\n--- a/lib/ansible/modules/lineinfile.py\n+++ ... | [
{
"diff_hunk": "@@ -17,6 +17,8 @@\n - This module ensures a particular line is in a file, or replace an\n existing line using a back-referenced regular expression.\n - This is primarily useful when you want to change a single line in a file only.\n+ - If you use this module to edit a file and if the fi... | 77ad30bd2caae6c622b7f922f8b1a5836a303a37 | diff --git a/lib/ansible/plugins/doc_fragments/files.py b/lib/ansible/plugins/doc_fragments/files.py
index cf953b61714883..2356bd72ce6135 100644
--- a/lib/ansible/plugins/doc_fragments/files.py
+++ b/lib/ansible/plugins/doc_fragments/files.py
@@ -34,10 +34,14 @@ class ModuleDocFragment(object):
owner:
descripti... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-78066@c430bb8 | ansible/ansible | Python | 78,066 | yum: fix releasever for latest | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #78058
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short na... | 2022-06-16T07:31:00Z | yum module "latest" and releasever errors out
### Summary
The yum module fails when releasever is used and state=latest
### Issue Type
Bug Report
### Component Name
yum
### Ansible Version
```console
$ ansible --version
ansible [core 2.11.12]
```
### Configuration
```console
# if using a version older than a... | Files identified in the description:
* [`lib/ansible/modules/yum.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/yum.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/... | [
{
"body": "### Summary\n\nThe yum module fails when releasever is used and state=latest\n\n### Issue Type\n\nBug Report\n\n### Component Name\n\nyum\n\n### Ansible Version\n\n```console\n$ ansible --version\r\nansible [core 2.11.12]\n```\n\n\n### Configuration\n\n```console\n# if using a version older than ansi... | d81a519f2589742a3cfd0a8dcd996d9a6b3d5927 | {
"head_commit": "c430bb886a613872b8899f568fe5a07a8060036c",
"head_commit_message": "yum: fix releasever for latest\n\nFixes #78058",
"patch_to_review": "diff --git a/changelogs/fragments/78058-yum-releasever-latest.yml b/changelogs/fragments/78058-yum-releasever-latest.yml\nnew file mode 100644\nindex 0000000000... | [
{
"diff_hunk": "@@ -1322,7 +1322,7 @@ def latest(self, items, repoq):\n updates = {}\n obsoletes = {}\n update_all = False\n- cmd = None\n+ cmd = self.yum_basecmd",
"line": null,
"original_line": 1325,
"original_start_line": null,
"path": "lib/ansible/module... | 841e065fdfb9c0d505f418617ea8c8c67095573b | diff --git a/changelogs/fragments/78058-yum-releasever-latest.yml b/changelogs/fragments/78058-yum-releasever-latest.yml
new file mode 100644
index 00000000000000..3700345d3eae0f
--- /dev/null
+++ b/changelogs/fragments/78058-yum-releasever-latest.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - "yum - fix traceback when ``releasev... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-77958@65985eb | ansible/ansible | Python | 77,958 | update backport instructions to reflect stable-2.13 | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #77574 77574
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Docs Pull Request
##### COMPONENT NAME
<!--- Write the short... | 2022-06-02T16:15:37Z | Documentation Checklist - ansible-core 2.13 release
### Summary
Documentation checklist to prepare for and deliver the ansible-core 2.13 release. See follow-on comment for the full checklist.
### Issue Type
Documentation Report
### Component Name
docs/docsite/sphinx_conf/core_conf.py
### Ansible Version
```conso... | Files identified in the description:
* [`docs/docsite/sphinx_conf/core_conf.py`](https://github.com/ansible/ansible/blob/devel/docs/docsite/sphinx_conf/core_conf.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot hel... | [
{
"body": "### Summary\n\nDocumentation checklist to prepare for and deliver the ansible-core 2.13 release. See follow-on comment for the full checklist.\n\n### Issue Type\n\nDocumentation Report\n\n### Component Name\n\ndocs/docsite/sphinx_conf/core_conf.py\n\n### Ansible Version\n\n```console\n$ ansible --ver... | f270b4e224174557963120e75bfc81acf1cdde61 | {
"head_commit": "65985ebc6ce3157581775f19f79e048463d9b7d2",
"head_commit_message": "update backport instructions to reflect stable-2.13",
"patch_to_review": "diff --git a/docs/docsite/rst/community/development_process.rst b/docs/docsite/rst/community/development_process.rst\nindex 1e24a4cfda5904..35cb7cb4fe0ef9 ... | [
{
"diff_hunk": "@@ -383,15 +383,15 @@ We do **not** backport features.\n \n .. code-block:: shell\n \n- git push origin backport/2.12/[PR_NUMBER_FROM_DEVEL]\n+ git push origin backport/2.13/[PR_NUMBER_FROM_DEVEL]\n \n-#. Submit the pull request for ``backport/2.12/[PR_NUMBER_FROM_DEVEL]`` against th... | 21d8d5195c221535775c6d4a376dd5f263403b19 | diff --git a/docs/docsite/rst/community/development_process.rst b/docs/docsite/rst/community/development_process.rst
index 1e24a4cfda5904..4fbf7c8b77b3fc 100644
--- a/docs/docsite/rst/community/development_process.rst
+++ b/docs/docsite/rst/community/development_process.rst
@@ -360,7 +360,7 @@ We do **not** backport fe... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-77944@0f6d2a8 | ansible/ansible | Python | 77,944 | preserve add_host/group_by on refresh | fixes #59400
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
inventory, add_host, group_by | 2022-06-01T14:37:10Z | Preserve add_host/group_by data on inventory refresh
##### SUMMARY
Since `add_host` and `group_by` actions only modify the runtime inventory, hosts/groups/vars added by them don't survive a `meta: refresh_inventory` call (since that call completely clears the runtime inventory).
##### ISSUE TYPE
- Feature Idea
... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
Yep... just ... | [
{
"body": "##### SUMMARY\r\nSince `add_host` and `group_by` actions only modify the runtime inventory, hosts/groups/vars added by them don't survive a `meta: refresh_inventory` call (since that call completely clears the runtime inventory). \r\n\r\n##### ISSUE TYPE\r\n- Feature Idea\r\n\r\n##### COMPONENT NAME\... | 9767cda50746f79ba435be1e025e5b6cf487ed74 | {
"head_commit": "0f6d2a8f728b81028d91a51d71347ae8e34eca86",
"head_commit_message": "moar tests",
"patch_to_review": "diff --git a/lib/ansible/inventory/manager.py b/lib/ansible/inventory/manager.py\nindex c55bbe615d7998..d5955b02182813 100644\n--- a/lib/ansible/inventory/manager.py\n+++ b/lib/ansible/inventory/m... | [
{
"diff_hunk": "@@ -648,3 +655,93 @@ def remove_restriction(self):\n \n def clear_pattern_cache(self):\n self._pattern_cache = {}\n+\n+ def add_dynamic_host(self, host_info, result_item):\n+ '''\n+ Helper function to add a new host to inventory based on a task result.\n+ '''\... | 7026be9ac512dd829488480aa2ab9df582f18aaf | diff --git a/changelogs/fragments/fix_inv_refresh.yml b/changelogs/fragments/fix_inv_refresh.yml
new file mode 100644
index 00000000000000..28a741d4b6c6a5
--- /dev/null
+++ b/changelogs/fragments/fix_inv_refresh.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - '"meta: refresh_inventory" does not clobber entries added by add_host/gr... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-77086@1ffb9e5 | ansible/ansible | Python | 77,086 | Update pylint deprecated plugin to use ansible-invalid* symbols | ##### SUMMARY
Update pylint deprecated plugin to use ansible-invalid* symbols
Fixes #77085
##### ISSUE TYPE
- Test Pull Request
##### COMPONENT NAME
test/lib/ansible_test/_util/controller/sanity/pylint/plugins/deprecated.py
##### ADDITIONAL INFORMATION
<!--- Include additional information to help people ... | 2022-02-21T19:46:16Z | `deprecated` pylint plugin bug
### Summary
```
00:55 File "/root/.ansible/test/venv/sanity.pylint/3.10/1d079f27/lib/python3.10/site-packages/pylint/utils/ast_walker.py", line 74, in walk
00:55 callback(astroid)
00:55 File "/root/ansible/test/lib/ansible_test/_util/controller/sanity/pylint/plugins/deprecated... | Files identified in the description:
* [`test/lib/ansible_test/_util/controller/sanity/pylint/plugins/deprecated.py`](https://github.com/ansible/ansible/blob/devel/test/lib/ansible_test/_util/controller/sanity/pylint/plugins/deprecated.py)
If these files are incorrect, please update the `component name` section of the... | [
{
"body": "### Summary\n\n```\r\n00:55 File \"/root/.ansible/test/venv/sanity.pylint/3.10/1d079f27/lib/python3.10/site-packages/pylint/utils/ast_walker.py\", line 74, in walk\r\n00:55 callback(astroid)\r\n00:55 File \"/root/ansible/test/lib/ansible_test/_util/controller/sanity/pylint/plugins/deprecated.... | 901e3d43b1e8a55342ccc2196ecd7e0d9ce243b9 | {
"head_commit": "1ffb9e563f4379ebfadae83e148daa760f410e39",
"head_commit_message": "Update pylint deprecated plugin to use ansible-invalid* symbols",
"patch_to_review": "diff --git a/test/lib/ansible_test/_util/controller/sanity/pylint/plugins/deprecated.py b/test/lib/ansible_test/_util/controller/sanity/pylint/... | [
{
"diff_hunk": "@@ -172,7 +172,7 @@ def _check_date(self, node, date):\n \n def _check_version(self, node, version, collection_name):\n if not isinstance(version, (str, float)):\n- self.add_message('invalid-version', node=node, args=(version,))\n+ self.add_message('ansible-inva... | 94962256a80e24f09a6fb3c0423ba803b56eefaf | diff --git a/changelogs/fragments/77086-correct-pylint-symbols.yml b/changelogs/fragments/77086-correct-pylint-symbols.yml
new file mode 100644
index 00000000000000..0f674eb024453a
--- /dev/null
+++ b/changelogs/fragments/77086-correct-pylint-symbols.yml
@@ -0,0 +1,3 @@
+bugfixes:
+- ansible-test - Pylint Deprecated Pl... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-77685@a657e1b | ansible/ansible | Python | 77,685 | More information on doc parsing errors | fixes #77675
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
ansible-doc | 2022-04-28T20:17:20Z | ansible-test sanity - Include which documentation block is being parsed when raising "Unknown DOCUMENTATION error"
### Summary
It would be helpful if the generic `Unknown DOCUMENTATION error` indicated which of the documentation blocks was being parsed the the time the exception was hit.
### Issue Type
Feature... | Files identified in the description:
* [`bin/ansible-test`](https://github.com/ansible/ansible/blob/devel/bin/ansible-test)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/... | [
{
"body": "### Summary\r\n\r\nIt would be helpful if the generic `Unknown DOCUMENTATION error` indicated which of the documentation blocks was being parsed the the time the exception was hit.\r\n\r\n### Issue Type\r\n\r\nFeature Idea\r\n\r\n### Component Name\r\n\r\nansible-test\r\n\r\n### Additional Informatio... | a3cc6a581ef191faf1c9ec102d1c116c4c2a8778 | {
"head_commit": "a657e1bc62c263dcae3e2170dcaee2f15c8fcdbb",
"head_commit_message": "reverse the lookup",
"patch_to_review": "diff --git a/lib/ansible/parsing/plugin_docs.py b/lib/ansible/parsing/plugin_docs.py\nindex 31d083e5dabd34..780c505805291a 100644\n--- a/lib/ansible/parsing/plugin_docs.py\n+++ b/lib/ansib... | [
{
"diff_hunk": "@@ -26,6 +24,17 @@\n }\n \n \n+def _var2string(value):\n+ ''' reverse lookup of the dict above '''\n+ global string_to_vars\n+ string = None\n+ for k, v in string_to_vars.items():\n+ if v == value:\n+ string = k",
"line": null,
"original_line": 33,
"orig... | 40500717783f6d8cdb9272e9bab6fda33b5504e3 | diff --git a/changelogs/fragments/doc_errors.yml b/changelogs/fragments/doc_errors.yml
new file mode 100644
index 00000000000000..6b4d137f1090fd
--- /dev/null
+++ b/changelogs/fragments/doc_errors.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - documentation construction now gives more information on error.
diff --git a/lib/a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-76560@4ecc0f3 | ansible/ansible | Python | 76,560 | Adds documentation about when/why to use roles | ##### SUMMARY
Fixes #75508.
Current more of a starting point for discussion. This PR expands the page about re-use and roles, discussing when to turn a playbook into a role. My basic take is "when it gets complicated enough." I also went back and looked at [role docs from long-ago versions of Ansible](https://do... | 2021-12-14T20:11:16Z | Docs survey feedback: add tips on when to turn a playbook into a role
### Summary
When is it a good idea to turn a playbook into a role? When should it remain a playbook?
Add some rules of thumb to the role documentation.
### Issue Type
Documentation Report
### Component Name
docs/docsite/rst/user_guide/playb... | Files identified in the description:
* [`docs/docsite/rst/user_guide/playbooks_roles.rst`](https://github.com/ansible/ansible/blob/devel/docs/docsite/rst/user_guide/playbooks_roles.rst)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[cl... | [
{
"body": "### Summary\n\nWhen is it a good idea to turn a playbook into a role? When should it remain a playbook?\r\n\r\nAdd some rules of thumb to the role documentation.\r\n\n\n### Issue Type\n\nDocumentation Report\n\n### Component Name\n\ndocs/docsite/rst/user_guide/playbooks_roles.rst\n\n### Ansible Versi... | 49e1cb9f42fef6953c39ef0dd88470c361fce6a9 | {
"head_commit": "4ecc0f36bbcf6827228c013a5249413c838fdee9",
"head_commit_message": "adds detail, wordsmithing",
"patch_to_review": "diff --git a/docs/docsite/rst/user_guide/playbooks_reuse.rst b/docs/docsite/rst/user_guide/playbooks_reuse.rst\nindex a2095ef3643e60..19aea8745ba4c3 100644\n--- a/docs/docsite/rst/u... | [
{
"diff_hunk": "@@ -4,7 +4,7 @@\n Re-using Ansible artifacts\n **************************\n \n-You can write a simple playbook in one very large file, and most users learn the one-file approach first. However, breaking tasks up into different files is an excellent way to organize complex sets of tasks and reuse... | 3c0eb705223683340dd1df2b7867d70b9bf9f2f9 | diff --git a/docs/docsite/rst/user_guide/playbooks_reuse.rst b/docs/docsite/rst/user_guide/playbooks_reuse.rst
index a2095ef3643e60..f64d3ad477bd8b 100644
--- a/docs/docsite/rst/user_guide/playbooks_reuse.rst
+++ b/docs/docsite/rst/user_guide/playbooks_reuse.rst
@@ -4,7 +4,7 @@
Re-using Ansible artifacts
************... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-76389@a7f9d7e | ansible/ansible | Python | 76,389 | better handling of sudo flag replacement | fixes #76357
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
become/sudo | 2021-11-29T17:28:40Z | sudo module doesn't handle --non-interactive flag
### Summary
Setting ansible_become_flags to a value that includes "--non-interactive" results in "-on-interactive" being given to sudo because the sudo module is removing "-n" from flags, but isn't accounting for the long argument equivalent:
`flags = flags.replace('-... | Files identified in the description:
* [`lib/ansible/plugins/become/sudo.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/become/sudo.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](htt... | [
{
"body": "### Summary\n\nSetting ansible_become_flags to a value that includes \"--non-interactive\" results in \"-on-interactive\" being given to sudo because the sudo module is removing \"-n\" from flags, but isn't accounting for the long argument equivalent:\r\n`flags = flags.replace('-n', '')`\n\n### Issue... | b9b69c1135629bdb2e4d234bb06a5c1af6c8c85c | {
"head_commit": "a7f9d7ea3b0577a45b2612a652eadc7a99188d5d",
"head_commit_message": "slight optimization",
"patch_to_review": "diff --git a/lib/ansible/plugins/become/sudo.py b/lib/ansible/plugins/become/sudo.py\nindex a4093b85f0bbca..9e7c78d3bdd19a 100644\n--- a/lib/ansible/plugins/become/sudo.py\n+++ b/lib/ansi... | [
{
"diff_hunk": "@@ -94,7 +94,13 @@ def build_become_command(self, cmd, shell):\n if self.get_option('become_pass'):\n self.prompt = '[sudo via ansible, key=%s] password:' % self._id\n if flags: # this could be simplified, but kept as is for now for backwards string matching\n- ... | f88f79442fbd4b38da7459feb3c7bdab383b24d2 | diff --git a/changelogs/fragments/fix_sudo_flag_mangling.yml b/changelogs/fragments/fix_sudo_flag_mangling.yml
new file mode 100644
index 00000000000000..8a844de6144da8
--- /dev/null
+++ b/changelogs/fragments/fix_sudo_flag_mangling.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - sudo become plugin, fix handling of non interactive... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-75635@82fabda | ansible/ansible | Python | 75,635 | Skip recursive suboption validation if sub_parameters is not a dict | ##### SUMMARY
Fixes #75612
I tested the same argspec + invalid option with modules and the traceback doesn't occur - this is specific to the role argspec validator.
* Skips recursive suboption validation if the sub_parameter is not a dictionary
* Ensure sub parameter elements is a list to prevent iterating ov... | 2021-09-02T20:40:11Z | Unexpected exception when validating a role argspec when a dict with suboptions is expected but a str is given
### Summary
An exception is thrown when an argspec expecting a dict with suboptions is given a string.
This only occurs when the argument in the argspec has suboptions.
### Issue Type
Bug Report
#... | Files identified in the description:
* [`test/integration/targets/argspec/library/argspec.py`](https://github.com/ansible/ansible/blob/devel/test/integration/targets/argspec/library/argspec.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot comma... | [
{
"body": "### Summary\r\n\r\nAn exception is thrown when an argspec expecting a dict with suboptions is given a string.\r\nThis only occurs when the argument in the argspec has suboptions.\r\n\r\n### Issue Type\r\n\r\nBug Report\r\n\r\n### Component Name\r\n\r\nmodule_utils/common/parameters.py\r\n\r\n### Ansi... | e60ee8234312dc181513fb6dd272bc0f81293a91 | {
"head_commit": "82fabdabdd26593d0ad79ba791513666e86c5bb3",
"head_commit_message": "Preserve no log values for invalid suboption types before skipping element validation",
"patch_to_review": "diff --git a/changelogs/fragments/75635-fix-role-argspec-suboption-validation.yml b/changelogs/fragments/75635-fix-role-a... | [
{
"diff_hunk": "@@ -724,23 +724,24 @@ def _validate_sub_spec(argument_spec, parameters, prefix='', options_context=Non\n options_context.append(param)\n \n # Make sure we can iterate over the elements\n- if isinstance(parameters[param], dict):\n+ if not isinstance(p... | f880686a5c9b6000c3b0386b9298e71ab7f1d00e | diff --git a/changelogs/fragments/75635-fix-role-argspec-suboption-validation.yml b/changelogs/fragments/75635-fix-role-argspec-suboption-validation.yml
new file mode 100644
index 00000000000000..981f2548c364da
--- /dev/null
+++ b/changelogs/fragments/75635-fix-role-argspec-suboption-validation.yml
@@ -0,0 +1,2 @@
+bug... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-76326@8c435e0 | ansible/ansible | Python | 76,326 | catch the case that cowsay is broken | fixes https://github.com/ansible/ansible/issues/72582
add changelog
raise AnsibleError for broken cowsay
add test for broken cowsay
Rebase and alteration of #72592
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short nam... | 2021-11-19T15:15:13Z | broken cowsay leads to unusable ansible
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain the problem ... | Files identified in the description:
None
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
@bernt-matthi... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | c379e61b8b8d4eb40e2bcc3be408b974a6b8fadf | {
"head_commit": "8c435e0d3391cfd2eaa79f56c04cc8f88d0a2f17",
"head_commit_message": "catch the case that cowsay is broken\n\nfixes https://github.com/ansible/ansible/issues/72582\n\n add changelog\n raise AnsibleError for broken cowsay\n add test for broken cowsay\n\n(cherry picked from commit 49e6e81a4be8e0fea6... | [
{
"diff_hunk": "@@ -220,6 +220,9 @@ def __init__(self, verbosity=0):\n cmd = subprocess.Popen([self.b_cowsay, \"-l\"], stdout=subprocess.PIPE, stderr=subprocess.PIPE)\n (out, err) = cmd.communicate()\n self.cows_available = {to_text(c) for c in out.split()}",
... | 91878efff04353c14e4c0e033e0b5c7ed63f6344 | diff --git a/changelogs/fragments/72592-catch-broken-cowsay.yaml b/changelogs/fragments/72592-catch-broken-cowsay.yaml
new file mode 100644
index 00000000000000..0fd5507c38496c
--- /dev/null
+++ b/changelogs/fragments/72592-catch-broken-cowsay.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+ - catch the case that cowsay is broken wh... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-75948@ae64ec4 | ansible/ansible | Python | 75,948 | Check if skeleton is /dev/null while creating home folder | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Add additional check for skeleton is a valid directory in addition to the pure existence of the path.
This prevents `shutil.copytree()` to throw an exception and also allows the use of `/dev/null` as a valid skeleton, which... | 2021-10-07T17:05:24Z | /dev/null must be allowed for skeleton in user module
### Summary
If you set `skeleton` to `/dev/null` in `user` module you get an error saying that it's not a directory. However it's perfectly fine to do `useradd --skel /dev/null`, so ansible shouldn't be limiting the functionality of the `useradd` command.
`usera... | Files identified in the description:
* [`lib/ansible/modules/user.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/user.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.co... | [
{
"body": "### Summary\n\nIf you set `skeleton` to `/dev/null` in `user` module you get an error saying that it's not a directory. However it's perfectly fine to do `useradd --skel /dev/null`, so ansible shouldn't be limiting the functionality of the `useradd` command.\r\n\r\n`useradd --skel /dev/null` will cau... | 801db758d345201daba64603666d0ceab240bf50 | {
"head_commit": "ae64ec41d22a2a0ac76bed8c1198e34980b4eb70",
"head_commit_message": "Check if skeleton is directory while creating home folder\n\nAllow /dev/null as skeleton.",
"patch_to_review": "diff --git a/changelogs/fragments/75063-allow-dev-nul-as-skeleton-for-new-homedir.yml b/changelogs/fragments/75063-al... | [
{
"diff_hunk": "@@ -1247,7 +1247,7 @@ def create_homedir(self, path):\n else:\n skeleton = '/etc/skel'\n \n- if os.path.exists(skeleton):\n+ if os.path.exists(skeleton) and os.path.isdir(skeleton):",
"line": null,
"original_line": 1250,
"original_sta... | 380e6d52f6c9c4999808e0f6a0513cb6fd1ec230 | diff --git a/changelogs/fragments/75063-allow-dev-nul-as-skeleton-for-new-homedir.yml b/changelogs/fragments/75063-allow-dev-nul-as-skeleton-for-new-homedir.yml
new file mode 100644
index 00000000000000..f7e10b74536077
--- /dev/null
+++ b/changelogs/fragments/75063-allow-dev-nul-as-skeleton-for-new-homedir.yml
@@ -0,0 ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-75435@27a7917 | ansible/ansible | Python | 75,435 | Add an `undef` global Jinja function | ##### SUMMARY
Factors in the feedback on the previous attempt #75407 ; I couldn't reopen the PR. This PR originally made a filter, but we felt that wasn't really appropriate given the semantics (it doesn't actually filter anything). I think explicitly calling it Undefined also clarifies its semantics; the fail filter ... | 2021-08-07T22:08:59Z | add a "fail" filter
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
Add a "fail" filter that always returns a FilterError with a specific message.
##### ISSUE TYPE
- Feature Idea
... | Files identified in the description:
* [`lib/ansible/plugins/filter/core.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/filter/core.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](htt... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n\r\nAdd a \"fail\" filter that always returns a FilterError with a specific message.\r\n\r\n##### ISSUE TYPE\r\n... | 90518d8bb5b82827829e364696c326e31c6b3c74 | {
"head_commit": "27a7917172e28ca7874fa81cd0fc7e58db2832bb",
"head_commit_message": "rebuild as the builtin `Undefined`",
"patch_to_review": "diff --git a/changelogs/fragments/75435-creating-Undefined.yml b/changelogs/fragments/75435-creating-Undefined.yml\nnew file mode 100644\nindex 00000000000000..b5ac19c6c433... | [
{
"diff_hunk": "@@ -68,6 +68,11 @@ If you configure Ansible to ignore undefined variables, you may want to define s\n \n The variable value will be used as is, but the template evaluation will raise an error if it is undefined.\n \n+A convenient way of requiring a variable to be overridden is to give it an unde... | 0826760759cba3b05154e134411968ac4eb3ae98 | diff --git a/changelogs/fragments/75435-creating-Undefined.yml b/changelogs/fragments/75435-creating-Undefined.yml
new file mode 100644
index 00000000000000..3e2f8bc578aa41
--- /dev/null
+++ b/changelogs/fragments/75435-creating-Undefined.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - adds the ``undef`` keyword to the templa... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-75411@04109d1 | ansible/ansible | Python | 75,411 | Fix dnf package matching | ##### SUMMARY
Fixes false negatives when checking if a package name is installed. Package names need to be broken into their components before filtering.
Fixes #75311
##### ISSUE TYPE
- Bugfix Pull Request
| 2021-08-05T12:50:27Z | Yum module upgrades packages with state: present or state: installed
### Summary
When running the yum module with state: present or state: installed, certain packages will be upgraded even though they should be skipped with that parameter.
### Issue Type
Bug Report
### Component Name
yum.py
### Ansible Version
`... | Files identified in the description:
* [`lib/ansible/modules/yum.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/yum.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/... | [
{
"body": "### Summary\n\nWhen running the yum module with state: present or state: installed, certain packages will be upgraded even though they should be skipped with that parameter.\n\n### Issue Type\n\nBug Report\n\n### Component Name\n\nyum.py\n\n### Ansible Version\n\n```console\n$ ansible --version\r\nan... | b8ebf32d85220807ac2be29b243b964ee52d7e5f | {
"head_commit": "04109d1c91fd3750d966e4aaeda468712ed496e7",
"head_commit_message": "Simplify splitting on the last '.'",
"patch_to_review": "diff --git a/changelogs/fragments/fix-dnf-filtering-for-installed-package-name.yml b/changelogs/fragments/fix-dnf-filtering-for-installed-package-name.yml\nnew file mode 10... | [
{
"diff_hunk": "@@ -734,7 +737,23 @@ def list_items(self, command):\n \n def _is_installed(self, pkg):\n installed = self.base.sack.query().installed()\n- if installed.filter(name=pkg):\n+\n+ if pkg[-4:] == '.rpm':\n+ pkg = pkg[:-4]\n+",
"line": null,
"original_line"... | 8520300ecf478424a55ec59f28c069c418575ac6 | diff --git a/changelogs/fragments/fix-dnf-filtering-for-installed-package-name.yml b/changelogs/fragments/fix-dnf-filtering-for-installed-package-name.yml
new file mode 100644
index 00000000000000..f8a788a99206c9
--- /dev/null
+++ b/changelogs/fragments/fix-dnf-filtering-for-installed-package-name.yml
@@ -0,0 +1,2 @@
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-75269@d9d1c5e | ansible/ansible | Python | 75,269 | import_role - support templating _from_files with --extra-vars | ##### SUMMARY
Fixes #69097
Makes an imported role's tasks_from/handlers_from/vars_from/defaults_from templatable like `import_playbook` and `import_tasks` and added tests for all three.
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
- Feature Pull Request
| 2021-07-15T23:20:54Z | import_role with extra-vars option
##### SUMMARY
variable from extra-vars is not set while import_role is parsed
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
import_role
##### ANSIBLE VERSION
<!--- Paste verbatim output from "ansible --version" between quotes -->
```paste below
ansible 2.9.7
c... | I'm not positive if there is a resolution to this. It may not be feasible to consult extra vars at this phase of the playbook run. I'd recommend that you switch to `include_role` instead of `import_role` to resolve this issue.
Tags are not taken into account if I use `include_role`
> Tags are not taken into account if... | [
{
"body": "##### SUMMARY\r\n\r\nvariable from extra-vars is not set while import_role is parsed\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nimport_role\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes -->\r\n```paste below\r\nansibl... | 767b2f07b00be12b9366655095cf24120d35092e | {
"head_commit": "d9d1c5eecc0b48e5e6c71c4742a43e3b248d59b2",
"head_commit_message": "Move the fix earlier to include variables from the import_role task\n\nAdd tests for import_playbook and import_tasks\n\nAdd a note to the documentation",
"patch_to_review": "diff --git a/changelogs/fragments/75269-import_role-su... | [
{
"diff_hunk": "@@ -33,6 +33,15 @@ You can incorporate multiple playbooks into a main playbook. However, you can on\n \n Importing incorporates playbooks in other playbooks statically. Ansible runs the plays and tasks in each imported playbook in the order they are listed, just as if they had been defined direc... | 34df5ccf43f2178a8222a021ecb9b2177b316da6 | diff --git a/changelogs/fragments/75269-import_role-support-from-files-templates.yml b/changelogs/fragments/75269-import_role-support-from-files-templates.yml
new file mode 100644
index 00000000000000..1f89a48dd19b8e
--- /dev/null
+++ b/changelogs/fragments/75269-import_role-support-from-files-templates.yml
@@ -0,0 +1,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-75287@2df0b1f | ansible/ansible | Python | 75,287 | fix block var inheritance | fixes #75286
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
core | 2021-07-20T14:29:15Z | `vars:` keyword on inner `block:` does not override `vars:` in outer `block:`
### Summary
If a var is defined in the `vars:` of a block, and then redefined again in the `vars:` of an inner block, the outer value is still used.
`vars:` on a _task_ in the inner block work as expected.
### Issue Type
Bug Repor... | Files identified in the description:
None
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner ---> | [
{
"body": "### Summary\r\n\r\nIf a var is defined in the `vars:` of a block, and then redefined again in the `vars:` of an inner block, the outer value is still used.\r\n\r\n`vars:` on a _task_ in the inner block work as expected.\r\n\r\n### Issue Type\r\n\r\nBug Report\r\n\r\n### Component Name\r\n\r\nunknown\... | 8372f34b67152a27f09d53ffed3a2fa996a44300 | {
"head_commit": "2df0b1ff0f59954b9dd7aa2b9e2a932d398dc72a",
"head_commit_message": "Update changelogs/fragments/fix_block_var_inh.yml\n\nCo-authored-by: Brian Scholer <1260690+briantist@users.noreply.github.com>",
"patch_to_review": "diff --git a/changelogs/fragments/fix_block_var_inh.yml b/changelogs/fragments/... | [
{
"diff_hunk": "@@ -1,7 +1,7 @@\n - debug:\n msg: '{{ test_role_input | default(\"(undefined)\") }}'\n- register: test_role_output\n+ register: non_coll_role_to_call_test_role_output\n \n - assert:\n that:\n- - test_role_input is not defined or test_role_input == test_role_output.msg\n+ - non_co... | 630fff8dd7cbb2e026fc875e7b39799df5022b13 | diff --git a/changelogs/fragments/fix_block_var_inh.yml b/changelogs/fragments/fix_block_var_inh.yml
new file mode 100644
index 00000000000000..b1d2560c1ec4e0
--- /dev/null
+++ b/changelogs/fragments/fix_block_var_inh.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - correctly inherit vars from parent in block (https://github.com/an... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-75235@8dd3e45 | ansible/ansible | Python | 75,235 | Improve ansible-galaxy error for InconsistentCandidate exception | ##### SUMMARY
Fixes #75139
##### ISSUE TYPE
- Bugfix Pull Request
| 2021-07-12T18:37:33Z | Installing collection artifact with mismatch version results in exception
### Summary
When installing a collection artifact from a URL or tarball, with a mismatched `version`, an exception is raised, that should be handled and a better message provided to the user.
### Issue Type
Bug Report
### Component Na... | Files identified in the description:
* [`lib/ansible/galaxy/collection/__init__.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/galaxy/collection/__init__.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for... | [
{
"body": "### Summary\r\n\r\nWhen installing a collection artifact from a URL or tarball, with a mismatched `version`, an exception is raised, that should be handled and a better message provided to the user.\r\n\r\n### Issue Type\r\n\r\nBug Report\r\n\r\n### Component Name\r\n```\r\nlib/ansible/galaxy/collect... | f8bb182589b9ba04bad4d32ee29d5cdcd2d84548 | {
"head_commit": "8dd3e4534a31064b528a4feb6ba5117b693cf7f9",
"head_commit_message": "Update changelogs/fragments/75235-ansible-galaxy-inconsistent-candidate-error.yml\n\nCo-authored-by: Abhijeet Kasurde <akasurde@redhat.com>",
"patch_to_review": "diff --git a/changelogs/fragments/75235-ansible-galaxy-inconsistent... | [
{
"diff_hunk": "@@ -1353,3 +1354,29 @@ def _resolve_depenency_map(\n AnsibleError('\\n'.join(error_msg_lines)),\n dep_exc,\n )\n+ except CollectionDependencyInconsistentCandidate as dep_exc:\n+ parents = [p for p in dep_exc.criterion.iter_parent() if p is not None]\n+\n... | 248e6dcf3761795ba1410ce019a213424ded34e7 | diff --git a/changelogs/fragments/75235-ansible-galaxy-inconsistent-candidate-error.yml b/changelogs/fragments/75235-ansible-galaxy-inconsistent-candidate-error.yml
new file mode 100644
index 00000000000000..e56d524961af42
--- /dev/null
+++ b/changelogs/fragments/75235-ansible-galaxy-inconsistent-candidate-error.yml
@@... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-75155@b9025fd | ansible/ansible | Python | 75,155 | task_executor - use correct value for ssh connection retries | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Since the task and connection both have the same 'retries' keyword, the task default would override the connection value. Making sure not to pass the task value for 'retries' to the connection options resolves the issue.
Se... | 2021-07-01T16:28:36Z | SSH module takes retry option from task keywords, defaulting to 3
### Summary
Starting with ansible-core-2.11.0, the `ssh` module operates with a `retry` setting of `3`.
This has undesired impact when using a `sudo` password and making a typo in the password: the module would make 4 connection attempts, attempting ... | Files identified in the description:
* [`lib/ansible/plugins/connection/ssh.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/connection/ssh.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot hel... | [
{
"body": "### Summary\n\nStarting with ansible-core-2.11.0, the `ssh` module operates with a `retry` setting of `3`.\r\n\r\nThis has undesired impact when using a `sudo` password and making a typo in the password: the module would make 4 connection attempts, attempting a sudo in each connection attempt.\r\n\r\... | 23a84902cb9599fe958a86e7a95520837964726a | {
"head_commit": "b9025fd24e5b2ce5541046d86280a922a9c187b8",
"head_commit_message": "Change option name\n\nBelt and suspenders",
"patch_to_review": "diff --git a/changelogs/fragments/75142-ssh-retries-collision.yml b/changelogs/fragments/75142-ssh-retries-collision.yml\nnew file mode 100644\nindex 00000000000000.... | [
{
"diff_hunk": "@@ -0,0 +1,7 @@\n+bugfixes:\n+ - >-\n+ task_exector/ssh_connection - use the ``retries`` value from ``ssh_connection`` settings,",
"line": null,
"original_line": 3,
"original_start_line": null,
"path": "changelogs/fragments/75142-ssh-retries-collision.yml",
"start_line": ... | e85ef3f1416d3b01d3e171c351e47a41cf72a8bf | diff --git a/changelogs/fragments/75142-ssh-retries-collision.yml b/changelogs/fragments/75142-ssh-retries-collision.yml
new file mode 100644
index 00000000000000..a97895453f3a4c
--- /dev/null
+++ b/changelogs/fragments/75142-ssh-retries-collision.yml
@@ -0,0 +1,7 @@
+bugfixes:
+ - >-
+ task_executor/ssh_connection... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-75092@c645700 | ansible/ansible | Python | 75,092 | Check if a string is possibly a template in `ansible.template.is_template` | ##### SUMMARY
Move `ansible.template.Templar.is_possibly_template` to a standalone function and call it from `ansible.template.is_template`.
If a very large string is not a template, previously `is_template` would go through the entire string before reaching that conclusion. Now it will return before iterating thro... | 2021-06-22T21:09:23Z | Improve performance of `ansible.template.is_template` with quick check short circuit
### Summary
`ansible.template.is_template` tries to loop until it determines if the value is indeed a template. Which means we could loop extremely large strings, that don't even remotely look like templates, before we bail.
Howev... | Files identified in the description:
* [`lib/ansible/template/__init__.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/template/__init__.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https:/... | [
{
"body": "### Summary\n\n`ansible.template.is_template` tries to loop until it determines if the value is indeed a template. Which means we could loop extremely large strings, that don't even remotely look like templates, before we bail.\r\n\r\nHowever, we could benefit from moving `Templar.is_possibly_templa... | 58f26388be7fc20aee8a3f43863c7832eea21fb6 | {
"head_commit": "c6457001bc73a20bbce5dbbbaca4df937af09556",
"head_commit_message": "Add changelog",
"patch_to_review": "diff --git a/changelogs/fragments/74336-is_template-quick-check.yml b/changelogs/fragments/74336-is_template-quick-check.yml\nnew file mode 100644\nindex 00000000000000..2c6b05d74ea993\n--- /de... | [
{
"diff_hunk": "@@ -198,6 +217,11 @@ def is_template(data, jinja_env):\n comment = False\n d2 = jinja_env.preprocess(data)\n \n+ # Quick check to see if this is remotely like a template before doing\n+ # more expensive investigation.\n+ if not is_possibly_template(data, jinja_env):",
"line"... | fad7b078580994c96a2e3b2184aebd19863eb2f2 | diff --git a/changelogs/fragments/74336-is_template-quick-check.yml b/changelogs/fragments/74336-is_template-quick-check.yml
new file mode 100644
index 00000000000000..2c6b05d74ea993
--- /dev/null
+++ b/changelogs/fragments/74336-is_template-quick-check.yml
@@ -0,0 +1,4 @@
+minor_changes:
+ - >-
+ add a quick... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
ansible__ansible-75127@ce87b73 | ansible/ansible | Python | 75,127 | Unfrack extra vars | Since now it is possible to re-reference them mid play, we cannot rely on the initial load having the correct relative path.
fixes #75126
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or featur... | 2021-06-28T15:45:30Z | Ansible fails to load extra variable file on inventory reload
### Summary
Under specific circumstances, when the playbook executes inventory reload, Ansible fails to load variables from the extras file.
### Issue Type
Bug Report
### Component Name
inventory
### Ansible Version
```console
$ ansible --version
ans... | /cc @samdoran As promised, I prepared a sample that replicates the behavior I noticed in one of our integration tests. https://github.com/ansible-collections/servicenow.itsm/blob/48b521fd7e83a22994def9b010b674150c99e8a8/tests/integration/targets/inventory/runme.sh#L39-L43 is the part that started failing with Ansible C... | [
{
"body": "### Summary\n\nUnder specific circumstances, when the playbook executes inventory reload, Ansible fails to load variables from the extras file.\n\n### Issue Type\n\nBug Report\n\n### Component Name\n\ninventory\n\n### Ansible Version\n\n```console\n$ ansible --version\r\nansible [core 2.11.2] \r\n c... | 16a74b798c9eebe2c1df49365270671fb674230d | {
"head_commit": "ce87b73f0af32be960df9002dcaa5acf1d50ce21",
"head_commit_message": "added missing",
"patch_to_review": "diff --git a/changelogs/fragments/extra_vars_unfrack.yml b/changelogs/fragments/extra_vars_unfrack.yml\nnew file mode 100644\nindex 00000000000000..5700e1fff7740b\n--- /dev/null\n+++ b/changelo... | [
{
"diff_hunk": "@@ -88,3 +88,9 @@ fi\n \n # ensure we don't traceback on inventory due to variables with int as key\n ansible-inventory -i inv_with_int.yml --list \"$@\"\n+\n+# test in subshell relative paths work mid play for extra vars in inventory refresh\n+{\n+\tcd 1/2\n+\tansible-playbook -e @../vars.yml ... | 9b80d0187f0753bcf83a65febd3415607e4a495b | diff --git a/changelogs/fragments/extra_vars_unfrack.yml b/changelogs/fragments/extra_vars_unfrack.yml
new file mode 100644
index 00000000000000..5700e1fff7740b
--- /dev/null
+++ b/changelogs/fragments/extra_vars_unfrack.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - Ensure we get full path for extra vars into cliargs to avoid re... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-74924@7688a1b | ansible/ansible | Python | 74,924 | setup module, filter compensate for prefixes | allow user to abstract internal implementation from requested info
fixes #74921
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
modules/setup | 2021-06-07T14:56:47Z | Inconsictency in fact naming, display, and filtering in setup module
### Summary
`setup` module displays facts inside `ansible_facts` dict, but with `ansible_` prefix, also `filter` acts on injected variable names instead of facts, expecting `ansible_` prefix.
### Issue Type
Bug Report
### Component Name
... | Files identified in the description:
* [`lib/ansible/modules/setup.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/setup.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.... | [
{
"body": "### Summary\r\n\r\n`setup` module displays facts inside `ansible_facts` dict, but with `ansible_` prefix, also `filter` acts on injected variable names instead of facts, expecting `ansible_` prefix.\r\n\r\n### Issue Type\r\n\r\nBug Report\r\n\r\n### Component Name\r\n\r\nsetup\r\n\r\n### Ansible Vers... | 5dd8dc8fd089e609d2a14c7ddaf1b11c4f396a0f | {
"head_commit": "7688a1b0b792768f04f19579ebb1f85af0f7f63d",
"head_commit_message": "setup module, filter compensate for prefixes\n\n allow user to abstract internal implementation from requested info",
"patch_to_review": "diff --git a/changelogs/fragments/setup_filter_smarter.yml b/changelogs/fragments/setup_fi... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+bugfixes:\n+ - setup module, fix filter to adjust for missing ansible_ prefix on query.",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "changelogs/fragments/setup_filter_smarter.yml",
"start_line": null,
"text": "@user1:\nThis ... | f8b7880fca431bd2322f24351415ecc99ee24910 | diff --git a/changelogs/fragments/setup_filter_smarter.yml b/changelogs/fragments/setup_filter_smarter.yml
new file mode 100644
index 00000000000000..04fbffc238eefe
--- /dev/null
+++ b/changelogs/fragments/setup_filter_smarter.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - setup module, fix filter to adjust for missing ``ansible_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-74912@697ef96 | ansible/ansible | Python | 74,912 | Add support for unicode in ansible-inventory CLI | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #57378
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short nam... | 2021-06-04T11:59:27Z | ansible-inventory doesn’t use unicode
##### SUMMARY
Unicode content is output in a cryptic escaped form.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
ansible-inventory
##### ANSIBLE VERSION
<!--- Paste verbatim output from "ansible --version" between quotes -->
```paste below
ansible 2.8.0
confi... | Files identified in the description:
* [`lib/ansible/cli/inventory.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/cli/inventory.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github... | [
{
"body": "##### SUMMARY\r\nUnicode content is output in a cryptic escaped form.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nansible-inventory\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes -->\r\n```paste below\r\nansible 2.8.0\r... | 33924d7e8dac0736342032c79136bd75d8dc11bf | {
"head_commit": "697ef96287b348ce3123be4fcd2e9662051beb47",
"head_commit_message": "First test fix",
"patch_to_review": "diff --git a/changelogs/fragments/57378-inventory-cli-unicode.yml b/changelogs/fragments/57378-inventory-cli-unicode.yml\nnew file mode 100644\nindex 00000000000000..50d1d50345956f\n--- /dev/n... | [
{
"diff_hunk": "@@ -105,3 +105,30 @@\n that:\n - result is failed\n - '\"ERROR! The source inventory contains a non-string key\" in result.stderr'\n+\n+- name: \"test json output with unicode characters\"\n+ command: ansible-inventory --list -i {{ role_path }}/files/unicode.yml\n+ register... | 8cf1136215667efe2f262c614d306bd60612c32f | diff --git a/changelogs/fragments/57378-inventory-cli-unicode.yml b/changelogs/fragments/57378-inventory-cli-unicode.yml
new file mode 100644
index 00000000000000..50d1d50345956f
--- /dev/null
+++ b/changelogs/fragments/57378-inventory-cli-unicode.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - Add unicode support to ``ansible-inv... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-74686@fa62b90 | ansible/ansible | Python | 74,686 | replace - better handling of file exceptions | ##### SUMMARY
Existing code was not handling file exceptions. This adds exception handling around the `open` and `read` calls.
Fixes #47429
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
replace
| 2021-05-13T14:24:53Z | replace module - OSError: [Errno 22] Invalid argument
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
When trying ... | Full error:
```
/Users/antoine/.ansible/tmp/ansible-tmp-1540221672.821883-231750250440895/AnsiballZ_replace.py:17: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
import imp
Traceback (most recent call last):
File \"/Users/antoine/.... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nWhen trying to use the replace module... | 1906d75907e36b84609dd860e34cd1563a13f37a | {
"head_commit": "fa62b9000d202177f9e1e652386b439fe94e1857",
"head_commit_message": "add cl",
"patch_to_review": "diff --git a/changelogs/fragments/74686-replace-handle-file-exc.yml b/changelogs/fragments/74686-replace-handle-file-exc.yml\nnew file mode 100644\nindex 00000000000000..8be2daed04fb30\n--- /dev/null\... | [
{
"diff_hunk": "@@ -242,9 +243,11 @@ def main():\n if not os.path.exists(path):\n module.fail_json(rc=257, msg='Path %s does not exist !' % path)\n else:\n- f = open(path, 'rb')\n- contents = to_text(f.read(), errors='surrogate_or_strict', encoding=encoding)\n- f.close()\n+ ... | 0332ffdc71ba01e0d833a75a7df731dcfc20ab4e | diff --git a/changelogs/fragments/74686-replace-handle-file-exc.yml b/changelogs/fragments/74686-replace-handle-file-exc.yml
new file mode 100644
index 00000000000000..8be2daed04fb30
--- /dev/null
+++ b/changelogs/fragments/74686-replace-handle-file-exc.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - replace - better handling of... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-74859@dd31b40 | ansible/ansible | Python | 74,859 | make collection warning message clearer | ##### SUMMARY
Fix for #74767 collection warning message
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/cli
##### ADDITIONAL INFORMATION
Make the warning message state clearer and state that it will pick up a collection if it's within a playbook adjacent directory.
| 2021-05-30T06:57:47Z | Clarify ansible-galaxy collection install warning message
### Summary
```(venv) ➜ ansible-navigator git:(main) ansible-galaxy collection install cisco.ios -p ./collections
Starting galaxy collection install process
[WARNING]: The specified collections path '/Users/bthornto/github/ansible-navigator/collections' is n... | Files identified in the description:
* `lib/ansible/galaxy`
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner ... | [
{
"body": "### Summary\n\n```(venv) ➜ ansible-navigator git:(main) ansible-galaxy collection install cisco.ios -p ./collections\r\nStarting galaxy collection install process\r\n[WARNING]: The specified collections path '/Users/bthornto/github/ansible-navigator/collections' is not part of the configured Ansible... | 5640093f1ca63fd6af231cc8a7fb7d40e1907b8c | {
"head_commit": "dd31b40ff8a1a73276ac14c8c6cb0c9efdaa9519",
"head_commit_message": "Apply suggestions from code review",
"patch_to_review": "diff --git a/lib/ansible/cli/galaxy.py b/lib/ansible/cli/galaxy.py\nindex 3a24c0dbfa9049..6d9f57a9bff368 100644\n--- a/lib/ansible/cli/galaxy.py\n+++ b/lib/ansible/cli/gala... | [
{
"diff_hunk": "@@ -1202,8 +1202,8 @@ def _execute_install_collection(\n collections_path = C.COLLECTIONS_PATHS\n if len([p for p in collections_path if p.startswith(path)]) == 0:\n display.warning(\"The specified collections path '%s' is not part of the configured Ansible \"\n- ... | aee034b5da14e0ce32b11f58b12e67293efb4c46 | diff --git a/lib/ansible/cli/galaxy.py b/lib/ansible/cli/galaxy.py
index 3a24c0dbfa9049..03fe79ac3809de 100644
--- a/lib/ansible/cli/galaxy.py
+++ b/lib/ansible/cli/galaxy.py
@@ -1202,8 +1202,8 @@ def _execute_install_collection(
collections_path = C.COLLECTIONS_PATHS
if len([p for p in collections_pa... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-74582@448b9b0 | ansible/ansible | Python | 74,582 | Role argspec: allow new argument spec file | ##### SUMMARY
Roles containing a defined argument spec in `meta/main.yml` do not currently work on ansible-core versions less than 2.11 because those versions do not allow for the `argument_specs` key in `meta/main.yml`. To solve this, we will allow the role arg specs to be defined in a new file (`meta/argument_spec... | 2021-05-05T20:12:29Z | Ansible < 2.11 fails on roles that contain argument specification
### Summary
If the role contains an argument specification, Ansible < 2.11 fails to use it and reports "ERROR! 'argument_specs' is not a valid attribute for a RoleMetadata".
### Issue Type
Bug Report
### Component Name
include_role
### Ansible Vers... | Files identified in the description:
* [`lib/ansible/playbook/role/include.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/playbook/role/include.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help]... | [
{
"body": "### Summary\n\nIf the role contains an argument specification, Ansible < 2.11 fails to use it and reports \"ERROR! 'argument_specs' is not a valid attribute for a RoleMetadata\".\n\n### Issue Type\n\nBug Report\n\n### Component Name\n\ninclude_role\n\n### Ansible Version\n\n```console\n$ ansible --ve... | aea0c4dd1bf04cfff12b6a1e01d99653787048c3 | {
"head_commit": "448b9b00712a5be3b060c14bc63bba4fdbd5175b",
"head_commit_message": "fix filename building bug and rename some argspec files to test variations",
"patch_to_review": "diff --git a/lib/ansible/cli/doc.py b/lib/ansible/cli/doc.py\nindex faab6ee9bdc7dd..4739a5de5197fc 100644\n--- a/lib/ansible/cli/doc... | [
{
"diff_hunk": "@@ -147,19 +187,23 @@ def _find_all_collection_roles(self, name_filters=None, collection_filter=None):\n roles_dir = os.path.join(path, 'roles')\n if os.path.exists(roles_dir):\n for entry in os.listdir(roles_dir):\n- full_path = os.path... | d18af2345bbe2cab75da93a136fe28459fe64fc2 | diff --git a/changelogs/fragments/74582-role-argspec-new-file.yml b/changelogs/fragments/74582-role-argspec-new-file.yml
new file mode 100644
index 00000000000000..b5504d7db221b7
--- /dev/null
+++ b/changelogs/fragments/74582-role-argspec-new-file.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - roles - allow for role arg specs i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-74526@c1ebd6b | ansible/ansible | Python | 74,526 | dont specify default for port, allow ssh/config | also added general note on how defaults work.
fixes #74524
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
connection/ssh | 2021-04-30T23:43:01Z | Ignoring ~/.ssh/config configuration file
### Summary
After upgrade from "ansible-base(2.10.8)" to "ansible-core(2.11.0)" Ansible is ignoring "~/.ssh/config" configuration file.
### Issue Type
Bug Report
### Component Name
ansible-core
### Ansible Version
```console
ansible [core 2.11.0]
confi... | Files identified in the description:
None
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
This is likel... | [
{
"body": "### Summary\r\n\r\nAfter upgrade from \"ansible-base(2.10.8)\" to \"ansible-core(2.11.0)\" Ansible is ignoring \"~/.ssh/config\" configuration file.\r\n\r\n### Issue Type\r\n\r\nBug Report\r\n\r\n### Component Name\r\n\r\nansible-core\r\n\r\n### Ansible Version\r\n\r\n```console\r\nansible [core 2.11... | fb0d5609cbabc1dc4187b994e24aba6eaef2e198 | {
"head_commit": "c1ebd6b815edb5ba4a93e5c6686da0963fc202f4",
"head_commit_message": "clog",
"patch_to_review": "diff --git a/changelogs/fragments/ssh_porr_default.fix.yml b/changelogs/fragments/ssh_porr_default.fix.yml\nnew file mode 100644\nindex 00000000000000..c5d8eedf76dc58\n--- /dev/null\n+++ b/changelogs/fr... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+bugfixes:\n+ - Remove 'default' from ssh pluing as we want to rely on default from ssh itself or ssh/config.",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "changelogs/fragments/ssh_porr_default.fix.yml",
"start_line": null,
"t... | c3a30b924b2026f519cd3261dd7341a53d2cb939 | diff --git a/changelogs/fragments/ssh_port_default_fix.yml b/changelogs/fragments/ssh_port_default_fix.yml
new file mode 100644
index 00000000000000..1d45e60d2a13b2
--- /dev/null
+++ b/changelogs/fragments/ssh_port_default_fix.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - Remove 'default' from ssh plugin as we want to rely on de... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-74349@86828d9 | ansible/ansible | Python | 74,349 | check /.dockerenv and /.dockerinit to guess a dockercontainer | ##### SUMMARY
check ./dockerenv and /.dockerinit to guess if this is an dockercontainer. Fixes #74326:
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
linux.py | 2021-04-20T16:03:21Z | docker not detected in centos, alpine, debian
### Summary
The facts for ansible_virtualization_type and ansible_virtualization_role are wrong if run in a dockercontainer of centos (tested with 8), alpine or debian (tested with buster). Only in an ubuntu-container (tested with focal or hirsute) are the values correct... | Files identified in the description:
* [`lib/ansible/modules/setup.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/setup.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.... | [
{
"body": "### Summary\r\n\r\nThe facts for ansible_virtualization_type and ansible_virtualization_role are wrong if run in a dockercontainer of centos (tested with 8), alpine or debian (tested with buster). Only in an ubuntu-container (tested with focal or hirsute) are the values correct.\r\nThe problem can be... | 49d4442378636128d6f93e7905dfe8fe06006b9b | {
"head_commit": "86828d99c1521fb72c113ace7b23542a2cba9a6f",
"head_commit_message": "add changelog for #74349",
"patch_to_review": "diff --git a/changelogs/fragments/74349-improve-docker-detection.yml b/changelogs/fragments/74349-improve-docker-detection.yml\nnew file mode 100644\nindex 00000000000000..5d386a3daa... | [
{
"diff_hunk": "@@ -109,6 +109,11 @@ def get_virtual_facts(self):\n virtual_facts['virtualization_type'] = systemd_container\n virtual_facts['virtualization_role'] = 'guest'\n found_virt = True\n+ elif os.path.exists('/.dockerenv') or os.path.exists('/.dock... | c9c3f25cf256c20c6f07b8050d6885cb5f3e4b0d | diff --git a/changelogs/fragments/74349-improve-docker-detection.yml b/changelogs/fragments/74349-improve-docker-detection.yml
new file mode 100644
index 00000000000000..5d386a3daad935
--- /dev/null
+++ b/changelogs/fragments/74349-improve-docker-detection.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - setup - detect docker conta... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-74514@0a3c1e0 | ansible/ansible | Python | 74,514 | warn on walking through pathing issues | fixes #25314
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Feature Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
find
##### ADDITIONAL INFO
```
ansible -m find -a 'path=/root warn=true' localhost
[WARNING]: find had a pr... | 2021-04-30T16:14:02Z | find module does not error when encountering a path with permission denied
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
find module
##### ANSIBLE VERSION
```
ansible 2.2.1.0
config file = /home/ansible/DPP-Deployer_LVC_TEST/ansible.cfg
configured module search path = Default w/o overrides
```
... | Files identified in the description:
* [lib/ansible/modules/files/find.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/files/find.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https:... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nfind module\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.2.1.0\r\n config file = /home/ansible/DPP-Deployer_LVC_TEST/ansible.cfg\r\n configured module search path = Default w/o overrides\r\n```\r\n\r\n##### CONFIGURATION\r\n\r\n##... | 6ea81b84edcb9ab38cd4a3cd716f30e08ad9e087 | {
"head_commit": "0a3c1e0527ea9c996ba7ad264d41c35deaf581c7",
"head_commit_message": "Add 'warn' option to find to show pathing issues\n\n fixes #25314",
"patch_to_review": "diff --git a/changelogs/fragments/find_warn.yml b/changelogs/fragments/find_warn.yml\nnew file mode 100644\nindex 00000000000000..d58bc68fce... | [
{
"diff_hunk": "@@ -129,6 +129,11 @@\n - Default is unlimited depth.\n type: int\n version_added: \"2.6\"\n+ warn:\n+ description:\n+ - Retrun warnings on any issues encountered while walking the paths.",
"line": null,
"original_line": 134,
"original_... | 47f8887d00b484ef4777e349f731cd34c0a30155 | diff --git a/changelogs/fragments/find_walk_warnings.yml b/changelogs/fragments/find_walk_warnings.yml
new file mode 100644
index 00000000000000..248aa976395376
--- /dev/null
+++ b/changelogs/fragments/find_walk_warnings.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - find does not ignore errors from os.walk anymore and issues war... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-74256@a15c7fa | ansible/ansible | Python | 74,256 | Case-insensitive set theory filters |
##### SUMMARY
Fixes #74255
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
Filter plugin
##### ADDITIONAL INFORMATION
Change behavior of `unique` filter: the ansible fallback **is** case-sensitive, so don't fail when using it with `case_sensitive=True`.
| 2021-04-13T16:46:41Z | difference filter unexpectedly performs case-insensitive comparison
### Summary
When using `difference` filter with element that have just case-difference in the value of the filter, only one is kept.
### Issue Type
Feature Request
### Component Name
filters
### Ansible Version
```console
$ ansibl... | Files identified in the description:
None
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
This is becau... | [
{
"body": "### Summary\r\n\r\nWhen using `difference` filter with element that have just case-difference in the value of the filter, only one is kept.\r\n\r\n### Issue Type\r\n\r\nFeature Request\r\n\r\n### Component Name\r\n\r\nfilters\r\n\r\n### Ansible Version\r\n\r\n```console\r\n$ ansible --version\r\nansi... | 6cfe36fa1fce56a04fd4d4953f35243099d83ae6 | {
"head_commit": "a15c7fa7f6498ef87386b85d21302b6d32b3e56f",
"head_commit_message": "Test multiple situations of 'unique' filter errors with fallback not handling specific parameters",
"patch_to_review": "diff --git a/changelogs/fragments/74256-set-theory-filters-behavior.yml b/changelogs/fragments/74256-set-theo... | [
{
"diff_hunk": "@@ -47,6 +47,13 @@ Deprecated\n when: not teardown | bool\n \n \n+Breaking Changes\n+================",
"line": null,
"original_line": 51,
"original_start_line": 50,
"path": "docs/docsite/rst/porting_guides/porting_guide_core_2.12.rst",
"start_line": null,
"text":... | 7db416d791cba0279de2ab1ad29cca05034482cc | diff --git a/changelogs/fragments/74256-set-theory-filters-behavior.yml b/changelogs/fragments/74256-set-theory-filters-behavior.yml
new file mode 100644
index 00000000000000..8793c31bdc83ac
--- /dev/null
+++ b/changelogs/fragments/74256-set-theory-filters-behavior.yml
@@ -0,0 +1,6 @@
+breaking_changes:
+ - intersect,... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-74147@08522ee | ansible/ansible | Python | 74,147 | play - validate hosts entries | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The `Play.load` method is defining `name` by joining values in `hosts` for the play. This should be done in `Play.get_name()`, allowing the `load` method to focus on loading data. Create a separate method for validating the ... | 2021-04-05T21:47:43Z | Unexpected exception when specifying invalid hosts field for task
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain the problem briefly below -->
ansible crashes with an unexp... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
!component =... | [
{
"body": "<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly below -->\r\nansible crashes with an unexpected exception when specifiyng an in... | 7b5dad23214804c79d318784460c5d365f04e852 | {
"head_commit": "08522eea00b1390c3449fe0e4fca1d9dd4547085",
"head_commit_message": "Add _validate_hosts() method\n\nBy defining this method, it gets called automatically by FieldAttributeBase.validate().",
"patch_to_review": "diff --git a/changelogs/fragments/65386-validate-hosts.yml b/changelogs/fragments/65386... | [
{
"diff_hunk": "@@ -97,19 +98,38 @@ def __init__(self):\n def __repr__(self):\n return self.get_name()\n \n+ def _validate_hosts(self, attribute, name, value):\n+ # Only validate 'hosts' if a value was passed in to original data set.\n+ if 'hosts' in self._ds:\n+ # Check ... | 3c87b13617370725d8bce66c323b7acf32db47ca | diff --git a/changelogs/fragments/65386-validate-hosts.yml b/changelogs/fragments/65386-validate-hosts.yml
new file mode 100644
index 00000000000000..611b10ae03beb5
--- /dev/null
+++ b/changelogs/fragments/65386-validate-hosts.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - play - validate the ``hosts`` entry in a play (https://gi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-73999@b2b3d7b | ansible/ansible | Python | 73,999 | Prevent traceback when task depth exceeds python recursion depth | ##### SUMMARY
Prevent traceback when task depth exceeds python recursion depth. Fixes #73996
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/playbook/base.py
##### ADDITIONAL INFORMATION
<!--- Include additional information to help people understand the change here -->
<!--- A step... | 2021-03-22T20:39:07Z | ERROR! Unexpected Exception, this is probably a bug: maximum recursion depth exceeded
### Summary
Hi
I have tried to reproduce live-ish output for the long running job with role in shell but after exactly 240 tries I am getting
`ERROR! Unexpected Exception, this is probably a bug: maximum recursion depth exceed... | Files identified in the description:
None
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner ---> | [
{
"body": "### Summary\r\n\r\nHi\r\nI have tried to reproduce live-ish output for the long running job with role in shell but after exactly 240 tries I am getting \r\n\r\n`ERROR! Unexpected Exception, this is probably a bug: maximum recursion depth exceeded`\r\n\r\n\r\ntried python2 and 3 as interpreter on vers... | 2bff120db6bf96dd0085c6ce1b29f3999b872db4 | {
"head_commit": "b2b3d7bc172a539e9e08f47573bd1279d51a9bf9",
"head_commit_message": "Prevent traceback when task depth exceeds python recursion depth. Fixes #73996",
"patch_to_review": "diff --git a/changelogs/fragments/73996-recursion-depth.yml b/changelogs/fragments/73996-recursion-depth.yml\nnew file mode 1006... | [
{
"diff_hunk": "@@ -315,7 +316,10 @@ def copy(self):\n Create a copy of this object and return it.\n '''\n \n- new_me = self.__class__()\n+ try:\n+ new_me = self.__class__()\n+ except RuntimeError:\n+ raise AnsibleError(\"Exceeded maximum object depth. ... | 3740e22103182f418e27e6fa30b56b7c8ebf10ce | diff --git a/changelogs/fragments/73996-recursion-depth.yml b/changelogs/fragments/73996-recursion-depth.yml
new file mode 100644
index 00000000000000..35af5aa534e158
--- /dev/null
+++ b/changelogs/fragments/73996-recursion-depth.yml
@@ -0,0 +1,3 @@
+bugfixes:
+- Task depth - Prevent exception when the task depth excee... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-73591@1934e57 | ansible/ansible | Python | 73,591 | cron: removal of deprecations and minor fix | name or cron_file is required.
reboot was removed.
updated docs to clarify usage.
now using cron_file=/etc/crontab is an error
fixes #37355
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request... | 2021-02-12T21:51:32Z | Cron module is not idempotent until name option is set
##### ISSUE TYPE
- Feature Idea
##### COMPONENT NAME
cron_module
##### ANSIBLE VERSION
```
ansible 2.3.1.0
config file =
configured module search path = Default w/o overrides
python version = 2.7.10 (default, Feb 7 2017, 00:08:15) [GCC 4.2.1 Co... | Probably this is a feature request and not a bug. This behaviour is described in the documentation of the module[1]:
> name: Description of a crontab entry or, if env is set, the name of environment variable. Required if state=absent. Note that if name is not set and state=present, then a new crontab entry will alwa... | [
{
"body": "##### ISSUE TYPE\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\ncron_module\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.3.1.0\r\n config file =\r\n configured module search path = Default w/o overrides\r\n python version = 2.7.10 (default, Feb 7 2017, 00:08:15) [GCC 4.2.1 Compatible Apple... | 185d41031660a676c43fbb781cd1335902024bfe | {
"head_commit": "1934e574ee4cc9cea4cf3edce2f82f90e34437a5",
"head_commit_message": "rstified",
"patch_to_review": "diff --git a/changelogs/fragments/cron_removals.yml b/changelogs/fragments/cron_removals.yml\nnew file mode 100644\nindex 00000000000000..1e081ccada3093\n--- /dev/null\n+++ b/changelogs/fragments/cr... | [
{
"diff_hunk": "@@ -575,6 +578,9 @@ def main():\n mutually_exclusive=[\n ['insertafter', 'insertbefore'],\n ],\n+ required_one_of=[\n+ ['name', 'cron_file']",
"line": null,
"original_line": 582,
"original_start_line": null,
"path": "lib/ansible/modul... | 6d9a6efa85e095cdb930afccf17b71dc1ea4d020 | diff --git a/changelogs/fragments/cron_removals.yml b/changelogs/fragments/cron_removals.yml
new file mode 100644
index 00000000000000..6d6275cbb823a5
--- /dev/null
+++ b/changelogs/fragments/cron_removals.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - cron, removed previously deprecated 'reboot' and now requires either 'nam... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-73260@f1a0891 | ansible/ansible | Python | 73,260 | default callback - add "show_task_path_on_failure" option | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
When running in verbosity <2, display the file and line number for tasks that fail. This provides
useful information without having to run at increased verbosity.
Fixes #64625
- [x] Add tests
<!--- HINT: Include "Fixes... | 2021-01-15T22:21:57Z | Add Filename and Line number to ansible_failed_task
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Describe the new feature/improvement briefly below -->
I'd like to see variables... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
https://gith... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Describe the new feature/improvement briefly below -->\r\nI'd like to see variables added to ansible_faile... | aa21804165aa51db552d687c8d7c970fce454fbf | {
"head_commit": "f1a089100eef0a2fd1f02338fce0d3891c3a98e2",
"head_commit_message": "default callback - add \"show_task_path_on_failure\" option\n\nWhen running in verbosity <2, display the file and line number for tasks that fail. This provides\nuseful information without having to run at increased verbosity.\n\nC... | [
{
"diff_hunk": "@@ -0,0 +1,5 @@\n+minor_changes:\n+ - >\n+ default callback - add ``show_task_path_on_failure`` option to display file and\n+ line number of tasks only on failed tasks when running at\n+ normal verbosity lev (https://github.com/ansible/ansible/issues/64625)",
"line": null,
"ori... | 64b8d61518a9035f1b6fb45b7b2093bc8ef68120 | diff --git a/changelogs/fragments/64625-show-file-path-on-task-failure-callback-option.yml b/changelogs/fragments/64625-show-file-path-on-task-failure-callback-option.yml
new file mode 100644
index 00000000000000..a06bcf6f5b8ce8
--- /dev/null
+++ b/changelogs/fragments/64625-show-file-path-on-task-failure-callback-opti... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-73204@5ae57ac | ansible/ansible | Python | 73,204 | facts - properly report virtualization facts for Linux guests on bhyve | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #73167
Add unit tests for this specific change. We did not have any tests for this file prior, so more could be added.
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!-... | 2021-01-12T22:33:22Z | Virtualization detection fails for Bhyve guests
##### SUMMARY
When i collect facts from FreeBSD bhyve target, with the command : ansible xxx -m setup | grep "ansible_virtualization_type"
the variable "ansible_virtualization_type" and "ansible_virtualization_role" is "NA".
Result of dmidecode -s system-product-name
... | Files identified in the description:
* [`lib/ansible/module_utils/facts/virtual/linux.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/facts/virtual/linux.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[cl... | [
{
"body": "##### SUMMARY\r\nWhen i collect facts from FreeBSD bhyve target, with the command : ansible xxx -m setup | grep \"ansible_virtualization_type\"\r\nthe variable \"ansible_virtualization_type\" and \"ansible_virtualization_role\" is \"NA\".\r\nResult of dmidecode -s system-product-name\r\n```\r\ndmidec... | d6670da1d7bc81dccd522d1bc27cc25164ef1aba | {
"head_commit": "5ae57ac22496c5d63ecbf0f087ecf2acd79c1582",
"head_commit_message": "facts -properly report virtualization facts for Linux guests on bhyve",
"patch_to_review": "diff --git a/changelogs/fragments/73167-bhyve-facts.yml b/changelogs/fragments/73167-bhyve-facts.yml\nnew file mode 100644\nindex 0000000... | [
{
"diff_hunk": "@@ -352,6 +352,11 @@ def get_virtual_facts(self):\n virtual_facts['virtualization_role'] = 'guest'\n found_virt = True\n \n+ if 'BHYVE' in out:\n+ virtual_facts['virtualization_type'] = 'bhyve'\n+ ... | 52334698f51461df4866788d720549b8870adb86 | diff --git a/changelogs/fragments/73167-bhyve-facts.yml b/changelogs/fragments/73167-bhyve-facts.yml
new file mode 100644
index 00000000000000..d9f6d0fc9048f6
--- /dev/null
+++ b/changelogs/fragments/73167-bhyve-facts.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - facts - properly report virtualization facts for Linux guests runn... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-72979@43071f6 | ansible/ansible | Python | 72,979 | Pass the top level dictionaries to combine_vars | ##### SUMMARY
Fixes #72975
combine_vars uses dict.update() to replace keys
What we're doing now:
```
>>> vars1 = {'test_hash': {'key1': 'value1', 'key2': 'value2'}}
>>> vars2 = {'test_hash': {'key1': 'newvalue'}}
>>> vars1['test_hash'].update(vars2['test_hash'])
>>> vars1
{'test_hash': {'key1': 'newvalue',... | 2020-12-15T16:33:58Z | Hashes are merged instead of replace
##### SUMMARY
Inventory merges hashes instead of replacing them. If you have the same hash variable in 2 different file variables will be merged.
hash_behaviour is not configured, the default "replace".
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
Inventory plugin
... | Files identified in the description:
* [`lib/ansible/plugins/inventory/__init__.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/inventory/__init__.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for... | [
{
"body": "##### SUMMARY\r\nInventory merges hashes instead of replacing them. If you have the same hash variable in 2 different file variables will be merged.\r\nhash_behaviour is not configured, the default \"replace\".\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nInventory plugin\r\... | 7eee2454f617569fd6889f2211f75bc02a35f9f8 | {
"head_commit": "43071f613fcca3524193ccde00d7eac1485f0d03",
"head_commit_message": "changelog",
"patch_to_review": "diff --git a/changelogs/fragments/72979-fix-inventory-merge-hash-replace.yaml b/changelogs/fragments/72979-fix-inventory-merge-hash-replace.yaml\nnew file mode 100644\nindex 00000000000000..4b7b247... | [
{
"diff_hunk": "@@ -246,8 +246,8 @@ def set_variable(self, key, value):\n if key == 'ansible_group_priority':\n self.set_priority(int(value))\n else:\n- if key in self.vars and isinstance(self.vars[key], MutableMapping) and isinstance(value, Mapping):\n- sel... | 978c70b4153a3096632601e2f61e3ae873aa118d | diff --git a/changelogs/fragments/72979-fix-inventory-merge-hash-replace.yaml b/changelogs/fragments/72979-fix-inventory-merge-hash-replace.yaml
new file mode 100644
index 00000000000000..4b7b24720afe78
--- /dev/null
+++ b/changelogs/fragments/72979-fix-inventory-merge-hash-replace.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+ - ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-72879@5bb827a | ansible/ansible | Python | 72,879 | Fix fileglob parameter order bug | ##### SUMMARY
The order of the parameters given to `fileglob` can change the results.
Fixes #72873
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
fileglob
##### ADDITIONAL INFORMATION
<!--- Include additional information to help people under... | 2020-12-07T16:55:33Z | fileglob lookup plugin returns inconsistent values
##### SUMMARY
The `fileglob` lookup plugin returns values inconsistently, depending on the order of arguments (terms) given it.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
fileglob
##### ANSIBLE VERSION
```paste below
ansible 2.10.3
conf... | Files identified in the description:
* [`lib/ansible/plugins/lookup/fileglob.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/lookup/fileglob.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot h... | [
{
"body": "\r\n##### SUMMARY\r\n\r\nThe `fileglob` lookup plugin returns values inconsistently, depending on the order of arguments (terms) given it.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\n\r\nfileglob\r\n\r\n##### ANSIBLE VERSION\r\n\r\n```paste below\r\nansible 2.10.3\r\n conf... | 6608f3aab338f9e4e871afe77ded7b69e50f23f6 | {
"head_commit": "5bb827af202aadb05275369aa334f16bf7ba6c50",
"head_commit_message": "Fix fileglob parameter order bug",
"patch_to_review": "diff --git a/changelogs/fragments/72873-fix-fileglob-ordering.yml b/changelogs/fragments/72873-fix-fileglob-ordering.yml\nnew file mode 100644\nindex 00000000000000..329befc9... | [
{
"diff_hunk": "@@ -76,7 +77,8 @@ def run(self, terms, variables=None, **kwargs):\n for dwimmed_path in found_paths:\n if dwimmed_path:\n globbed = glob.glob(to_bytes(os.path.join(dwimmed_path, term_file), errors='surrogate_or_strict'))\n- ret.e... | be6b8690f15f15886aa11eb73288c8f406640e4c | diff --git a/changelogs/fragments/72873-fix-fileglob-ordering.yml b/changelogs/fragments/72873-fix-fileglob-ordering.yml
new file mode 100644
index 00000000000000..329befc9079be4
--- /dev/null
+++ b/changelogs/fragments/72873-fix-fileglob-ordering.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- Fix fileglob bug where it could return... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-72025@08a5238 | ansible/ansible | Python | 72,025 | WIP: OpenBSD: add uptime to gather_facts | ##### SUMMARY
Fixes #71968
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
lib/ansible/module_utils/facts/hardware/openbsd.py | 2020-09-30T14:31:18Z | gather_facts does not gather uptime from BSD machines
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explai... | Files identified in the description:
* [`lib/ansible/modules/gather_facts.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/gather_facts.py)
* [`lib/ansible/modules/setup.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/setup.py)
If these files are incorrect, please update th... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 6f4aed53772f2b5ff83262575865f2be5b36933b | {
"head_commit": "08a52388ff8a664c0ab1b7a6a357352166fc31a4",
"head_commit_message": "OpenBSD: add uptime to gather_facts",
"patch_to_review": "diff --git a/lib/ansible/module_utils/facts/hardware/openbsd.py b/lib/ansible/module_utils/facts/hardware/openbsd.py\nindex 6b666047373ad5..7f8316a5e1cc20 100644\n--- a/li... | [
{
"diff_hunk": "@@ -115,6 +118,15 @@ def get_memory_facts(self):\n \n return memory_facts\n \n+ def get_uptime_facts(self):\n+ uptime_facts = {}\n+ uptime_seconds = self.sysctl(\"kern.boottime\")",
"line": null,
"original_line": 123,
"original_start_line": null,
"path": ... | d8aba1067caa26508e9c34ede4e248c195a7ff74 | diff --git a/changelogs/fragments/72025-fact-add-uptime-to-openbsd.yml b/changelogs/fragments/72025-fact-add-uptime-to-openbsd.yml
new file mode 100644
index 00000000000000..c201ceaf57c1f2
--- /dev/null
+++ b/changelogs/fragments/72025-fact-add-uptime-to-openbsd.yml
@@ -0,0 +1,3 @@
+---
+minor_changes:
+ - facts - add... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-72546@a01ff4b | ansible/ansible | Python | 72,546 | add return documentation for unarchive. | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #67445
Adds RETURN documentation for unarchive.
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Docs Pull Request
##### C... | 2020-11-09T17:53:37Z | unarchive module: missing documentation on return values
##### SUMMARY
The unarchive module is missing documentation on its return values.
Only the `list_files` option mentions it at all:
> If set to True, return the list of files that are contained in the tarball.
It does not mention how this list is returned (S... | Files identified in the description:
* [`lib/ansible/modules/files/unarchive.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/files/unarchive.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot ... | [
{
"body": "##### SUMMARY\r\nThe unarchive module is missing documentation on its return values.\r\nOnly the `list_files` option mentions it at all:\r\n> If set to True, return the list of files that are contained in the tarball.\r\n\r\nIt does not mention how this list is returned (Spoiler: It's in the `files` ... | 8eab113cb1c6a3fd67b88332b4091f24090598c5 | {
"head_commit": "a01ff4b0c693c3f90c6321ea3bf60a2e6843e01e",
"head_commit_message": "Apply suggestions from code review\n\nCo-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>",
"patch_to_review": "diff --git a/changelogs/fragments/72546-unarchive-returndoc.yml b/changelogs/fragments/72546-unar... | [
{
"diff_hunk": "@@ -141,6 +141,66 @@\n - s/^xxx/yyy/\n '''\n \n+RETURN = r'''\n+dest:\n+ description: Path to the destination directory.\n+ returned: always\n+ type: str\n+ sample: /opt/software\n+files:\n+ description: List of all the files in the archive.\n+ returned: When I(list_files) is True\n+ ... | 44181c433f258386f6ad68b35451e4f6f34a6dea | diff --git a/changelogs/fragments/72546-unarchive-returndoc.yml b/changelogs/fragments/72546-unarchive-returndoc.yml
new file mode 100644
index 00000000000000..9f4fae197f9450
--- /dev/null
+++ b/changelogs/fragments/72546-unarchive-returndoc.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - unarchive - add ``RETURN`` documentat... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-72396@f1eadb0 | ansible/ansible | Python | 72,396 | Add complex example of fileglob with loop | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #48788
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Docs Pull Request
##### COMPONENT NAME
<!--- Write the short name ... | 2020-10-29T18:48:47Z | loop w/ fileglob does not accept lists
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain the problem b... | Hi @philfry, thank you for submitting this issue!
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: thank_submitter --->
Files identified in the description:
* [lib/ansible/plugins/lookup/fileglob.py](https://github.com/ansible/ansible/blob/devel/lib/ansible... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | a51a6f4a259b45593c3f803737c6d5d847258a83 | {
"head_commit": "f1eadb043fef9293cf9dac649d538e1e5024d015",
"head_commit_message": "Explain Python unpacking notation",
"patch_to_review": "diff --git a/docs/docsite/rst/user_guide/complex_data_manipulation.rst b/docs/docsite/rst/user_guide/complex_data_manipulation.rst\nindex 8466a3df2ceeae..8a8ebec538209d 1006... | [
{
"diff_hunk": "@@ -136,6 +136,29 @@ Another way is to avoid adding elements to the list in the first place, so you c\n - \"bar\"\n \n \n+Custom Fileglob Based on a Variable\n+-----------------------------------\n+\n+This example uses `Python argument list unpacking <https://docs.python.org/3/tutorial... | d12fe0f86c50d6679f63f3333447c076021f4564 | diff --git a/docs/docsite/rst/user_guide/complex_data_manipulation.rst b/docs/docsite/rst/user_guide/complex_data_manipulation.rst
index 8466a3df2ceeae..4771e95ed8444e 100644
--- a/docs/docsite/rst/user_guide/complex_data_manipulation.rst
+++ b/docs/docsite/rst/user_guide/complex_data_manipulation.rst
@@ -136,6 +136,29... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-71497@b4797dd | ansible/ansible | Python | 71,497 | add cli parser documentation | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
fixes #71689
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Docs Pull Request
##### COMPONENT NAME
<!--- Write the short nam... | 2020-08-27T20:19:55Z | [1/6] Include deep dive documentation on using the cli_parser
<!--- Verify first that your improvement is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY... | Files identified in the description:
* [`docs/docsite/README.md`](https://github.com/ansible/ansible/blob/devel/docs/docsite/README.md)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/... | [
{
"body": "<!--- Verify first that your improvement is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem brief... | abfb7919dc5bc8d78272f2473bcb39dc5372b79e | {
"head_commit": "b4797ddc52bb622bfe0bf909c03060b53c724fc4",
"head_commit_message": "implement feedback",
"patch_to_review": "diff --git a/docs/docsite/rst/network/dev_guide/developing_plugins_network.rst b/docs/docsite/rst/network/dev_guide/developing_plugins_network.rst\nindex 9c68c60b486648..16df7fed66dec0 100... | [
{
"diff_hunk": "@@ -182,3 +189,77 @@ After adding the ``cliconf`` and ``terminal`` plugins in the expected locations,\n \n * Use the :ref:`cli_command <cli_command_module>` to run an arbitrary command on the network device.\n * Use the :ref:`cli_config <cli_config_module>` to implement configuration changes on... | 4dc1cd906cfb198fc41529c9071b0d32291bd02f | diff --git a/docs/docsite/rst/network/dev_guide/developing_plugins_network.rst b/docs/docsite/rst/network/dev_guide/developing_plugins_network.rst
index 9c68c60b486648..8844fef6a7dece 100644
--- a/docs/docsite/rst/network/dev_guide/developing_plugins_network.rst
+++ b/docs/docsite/rst/network/dev_guide/developing_plugi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-71496@dd95d8b | ansible/ansible | Python | 71,496 | iptables: Reorder comment postition | ##### SUMMARY
Fixes: #71444.
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
iptables | 2020-08-27T20:05:57Z | iptables comment parameter incorrectly positioned in iptables
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
When... | Files identified in the description:
* [`lib/ansible/modules/iptables.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/iptables.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://g... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nWhen using **comment** parameter with... | d083307e369b968db7852d6cd2d5a9008724ab1d | {
"head_commit": "dd95d8b23df3fdfdfae1f2ea615f175caf8a4ee7",
"head_commit_message": "Add changelog",
"patch_to_review": "diff --git a/changelogs/fragments/71496-iptables-reorder-comment-position.yml b/changelogs/fragments/71496-iptables-reorder-comment-position.yml\nnew file mode 100644\nindex 00000000000000..942... | [
{
"diff_hunk": "@@ -876,3 +876,39 @@ def test_insert_rule_with_wait(self):\n '-j',\n 'ACCEPT'\n ])\n+\n+ def test_comment_position_at_end(self):\n+ \"\"\"Test flush without parameters\"\"\"\n+ set_module_args({\n+ 'chain': 'INPUT',\n+ 'jump'... | 4998024775667378fd8efdd6d553ecd8b98cb522 | diff --git a/changelogs/fragments/71496-iptables-reorder-comment-position.yml b/changelogs/fragments/71496-iptables-reorder-comment-position.yml
new file mode 100644
index 00000000000000..942edb22a7c8dd
--- /dev/null
+++ b/changelogs/fragments/71496-iptables-reorder-comment-position.yml
@@ -0,0 +1,2 @@
+minor_changes:
... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-71136@621cec5 | ansible/ansible | Python | 71,136 | Ensure -k is set to delegated hosts without a pass | ##### SUMMARY
The change in https://github.com/ansible/ansible/pull/69244 stopped combining the original vars with the delegated host vars. This meant certain variables set by the play context on the host was not transferred to the delegated host, like `ansible_password`. This change reimplements the combining of conn... | 2020-08-07T01:39:27Z | winrm Kerberos automatic ticket management doesn't work
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Expl... | Files identified in the description:
None
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
!component +w... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 6ac4439a6abe8c87190d25d6ee53962c03b458a1 | {
"head_commit": "621cec5a3afdf4857aaa589309a17843909d704e",
"head_commit_message": "Fix up some broken tests",
"patch_to_review": "diff --git a/changelogs/fragments/delegation_password.yml b/changelogs/fragments/delegation_password.yml\nnew file mode 100644\nindex 00000000000000..c68191b25df86f\n--- /dev/null\n+... | [
{
"diff_hunk": "@@ -507,7 +507,8 @@ def _execute(self, variables=None):\n \n if self._task.delegate_to:\n # use vars from delegated host (which already include task vars) instead of original host\n- cvars = variables.get('ansible_delegated_vars', {}).get(self._task.delegate_to, {}... | 6eb7a5b7673eef415f40a4b0b3c6ba281239d879 | diff --git a/changelogs/fragments/delegation_password.yml b/changelogs/fragments/delegation_password.yml
new file mode 100644
index 00000000000000..c68191b25df86f
--- /dev/null
+++ b/changelogs/fragments/delegation_password.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- Ensure password passed in by -k is used on delegated hosts tha... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-71088@8aa812b | ansible/ansible | Python | 71,088 | add jinja2 global to reserved names | also allow expansion by additional context provided from caller
fixes #41955
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
vars | 2020-08-04T13:46:23Z | jinja keyword collision for variable names
##### SUMMARY
<!--- Explain the problem briefly -->
k8s_raw fails using jinja default filter to default undefined variables
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
k8s_raw
##### ANSIBLE VERSION
```
ansible 2.6.0rc4
(python 3)
```
##### STEPS T... | Files identified in the description:
* [lib/ansible/modules/clustering/k8s/_k8s_raw.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/clustering/k8s/_k8s_raw.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click... | [
{
"body": "##### SUMMARY\r\n<!--- Explain the problem briefly -->\r\nk8s_raw fails using jinja default filter to default undefined variables\r\n\r\n##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nk8s_raw\r\n\r\n##### ANSIBLE VERSION\r\n\r\n```\r\nansible 2.6.0rc4\r\n(python 3)\r\n```\r\n\r\n###... | 4bd7580dd7f41ca484fde21dda94d2dd856108b0 | {
"head_commit": "8aa812b7121c2e46d5db14db4b64c8e808c62e1f",
"head_commit_message": "actually spell conflicting var corerezstly\n\nno need for -E either",
"patch_to_review": "diff --git a/changelogs/fragments/moar_reserved_vars.yml b/changelogs/fragments/moar_reserved_vars.yml\nnew file mode 100644\nindex 0000000... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+bugfixes:\n+ - Handle more varnames that can create conflicts, expand function in general, handle jinja2 globasl in particular.",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "changelogs/fragments/moar_reserved_vars.yml",
"start_li... | 0e9e1260998a33373f392c9e2d5a2a26b39931be | diff --git a/changelogs/fragments/moar_reserved_vars.yml b/changelogs/fragments/moar_reserved_vars.yml
new file mode 100644
index 00000000000000..50a501e65d88d4
--- /dev/null
+++ b/changelogs/fragments/moar_reserved_vars.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - Handle more varnames that can create conflicts, expand a functi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-70890@9d525ef | ansible/ansible | Python | 70,890 | Give subversion module a validate_certs option | ##### SUMMARY
Change:
- Add `validate_certs` option to subversion module. Defaults to off for
backwards compatibility.
Tickets:
- Fixes #22599
- Fixes #40036
Signed-off-by: Rick Elrod <rick@elrod.me>
<!--- Describe the change below, including rationale and design decisions -->
<!--- HINT: Include "Fi... | 2020-07-25T17:31:05Z | Subversion module disables certificate validation.
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Bug Report
##### COMPONENT NAME
<!--- Na... | cc @dsummersl
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
We should add a `validate_certs` parameter to the module to control this behavior.
Files identified in the description:
* [lib/ansible/modules/source_control/subversion.py](https://gi... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the mo... | 4cc4cebc97ab1b9c5f0c424238d5352274b5dbad | {
"head_commit": "9d525ef330aa00af1d8a46980af0ad4f3630d752",
"head_commit_message": "Give subversion module a validate_certs option\n\nChange:\n- Add `validate_certs` option to subversion module. Defaults to off for\n backwards compatibility.\n\nTickets:\n- Fixes #22599\n\nSigned-off-by: Rick Elrod <rick@elrod.me>... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+minor_changes:\n+ - subversion - Now has a ``validate_certs`` option, which, when true, will avoid passing ``--trust-server-cert`` to ``svn`` commands (https://github.com/ansible/ansible/issues/22599)",
"line": null,
"original_line": 2,
"original_start_line": null,... | b2555252181405a9cf5aa80f06e01d1b016dd5da | diff --git a/changelogs/fragments/22599_svn_validate_certs.yml b/changelogs/fragments/22599_svn_validate_certs.yml
new file mode 100644
index 00000000000000..fc4bf8400b0a7a
--- /dev/null
+++ b/changelogs/fragments/22599_svn_validate_certs.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - subversion - ``validate_certs`` option, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-71032@a712f56 | ansible/ansible | Python | 71,032 | dont clobber facts in loop | fixes #71031
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
facts | 2020-07-31T21:09:38Z | task fails when run in a loop using ansible_facts in a conditional and the module returns ansible_facts
##### SUMMARY
<!--- Explain the problem briefly below -->
(I'm so sorry for that title)
When a module that returns `ansible_facts` is run in a loop and has a conditional that is using `ansible_facts`, the firs... | Files identified in the description:
* [`lib/ansible/executor/task_executor.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/executor/task_executor.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot hel... | [
{
"body": "##### SUMMARY\r\n<!--- Explain the problem briefly below -->\r\n\r\n(I'm so sorry for that title)\r\n\r\nWhen a module that returns `ansible_facts` is run in a loop and has a conditional that is using `ansible_facts`, the first iteration of the loop works but subsequent iterations fail with the follo... | 54bee7152b70409f751aefb4affafdd3867df87b | {
"head_commit": "a712f56f9ec756d51b745abd2aa609f6250e7d87",
"head_commit_message": "allow for no facts in source",
"patch_to_review": "diff --git a/lib/ansible/executor/task_executor.py b/lib/ansible/executor/task_executor.py\nindex ee0de5f9d6784b..2e64b613439c01 100644\n--- a/lib/ansible/executor/task_executor.... | [
{
"diff_hunk": "@@ -0,0 +1,6 @@\n+- hosts: localhost\n+ gather_facts: True\n+ tasks:\n+ - bogus_facts:\n+ loop: [1, 2, 3]\n+ when: ansible_facts['virtualization_type'] != 'docker'",
"line": null,
"original_line": 6,
"original_start_line": null,
"path": "test/integration/targets/gatherin... | e8f72647db50db85241aabdf70eb9f549e6cbebc | diff --git a/lib/ansible/executor/task_executor.py b/lib/ansible/executor/task_executor.py
index ee0de5f9d6784b..2e64b613439c01 100644
--- a/lib/ansible/executor/task_executor.py
+++ b/lib/ansible/executor/task_executor.py
@@ -628,7 +628,7 @@ def _evaluate_failed_when_result(result):
else:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-70792@c473a10 | ansible/ansible | Python | 70,792 | yum action plugin: 'use' as an alias of 'use_backend' | ##### SUMMARY
Made changes to the yum action plugin to support **use** as an alias of **use_backend**.
Fixes #70774
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
yum action plugin
| 2020-07-21T22:07:16Z | error while installing packages in ec2 RHEL instance using yum module
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMA... | Files identified in the description:
None
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
Hi @DiptoChak... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 8cccede0d435c799385828ce55521c910dc69b13 | {
"head_commit": "c473a104c2ceccdafc43cabe9d2acddca3052ba0",
"head_commit_message": "Update changelogs/fragments/70792-yum-action-plugin-use-as-alias-of-use-backend.yml\n\nCo-authored-by: Abhijeet Kasurde <akasurde@redhat.com>",
"patch_to_review": "diff --git a/changelogs/fragments/70792-yum-action-plugin-use-as-... | [
{
"diff_hunk": "@@ -47,7 +48,15 @@ def run(self, tmp=None, task_vars=None):\n del tmp # tmp no longer has any effect\n \n # Carry-over concept from the package action plugin\n- module = self._task.args.get('use_backend', \"auto\")\n+ module = 'auto'\n+\n+ if 'use' in self._... | a1aae2c718d08d344d17d1d75cf1c6a94184d824 | diff --git a/changelogs/fragments/70792-yum-action-plugin-use-as-alias-of-use-backend.yml b/changelogs/fragments/70792-yum-action-plugin-use-as-alias-of-use-backend.yml
new file mode 100644
index 00000000000000..6e14eb040630c4
--- /dev/null
+++ b/changelogs/fragments/70792-yum-action-plugin-use-as-alias-of-use-backend.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-70785@7174993 | ansible/ansible | Python | 70,785 | Allow macOS ACLs to work for unpriv -> unpriv | Change:
- Use `chmod +a` in the fallback chain to allow MacOS to use ACLs to
allow an unprivileged user to become an unprivileged user.
Test Plan:
- CI, new tests
Tickets:
- Fixes #70648
Signed-off-by: Rick Elrod <rick@elrod.me>
##### SUMMARY
<!--- Describe the change below, including rationale and d... | 2020-07-21T18:46:31Z | Use `chmod` instead of `setfacl` on macOS when becoming an unprivileged user
##### SUMMARY
Support become unprivileged user on macOS without `allow_world_readable_tmpfiles=true`
##### ISSUE TYPE
- Feature Idea
##### COMPONENT NAME
action, shell, and copy
##### ADDITIONAL INFORMATION
When using become where... | Files identified in the description:
* [`lib/ansible/modules/copy.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/copy.py)
* [`lib/ansible/modules/shell.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/shell.py)
* [`lib/ansible/plugins/action/__init__.py`](https://github.com... | [
{
"body": "##### SUMMARY\r\nSupport become unprivileged user on macOS without `allow_world_readable_tmpfiles=true`\r\n\r\n##### ISSUE TYPE\r\n- Feature Idea\r\n\r\n##### COMPONENT NAME\r\naction, shell, and copy\r\n\r\n##### ADDITIONAL INFORMATION\r\nWhen using become where the login user and the become user ar... | 4f96f9826c38e008112a45599a3550dc3cc98b07 | {
"head_commit": "7174993237d059ff6d602f65034be1208b7e6991",
"head_commit_message": "Allow MacOS ACLs to work for unpriv -> unpriv\n\nChange:\n- Use `chmod +a` in the fallback chain to allow MacOS to use ACLs to\n allow an unprivileged user to become an unprivileged user.\n\nTest Plan:\n- CI, new tests\n\nTickets:... | [
{
"diff_hunk": "@@ -510,7 +510,9 @@ def _fixup_perms2(self, remote_paths, remote_user=None, execute=True):\n file with chown which only works in case the remote_user is\n privileged or the remote systems allows chown calls by unprivileged\n users (e.g. HP-UX)\n- * If the cho... | a2a0679a2b19198a5f2e215d55900735e3313662 | diff --git a/changelogs/fragments/macos-chmod-acl.yml b/changelogs/fragments/macos-chmod-acl.yml
new file mode 100644
index 00000000000000..ed517e2249110b
--- /dev/null
+++ b/changelogs/fragments/macos-chmod-acl.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - When connecting as an unprivileged user, and becoming an unprivileg... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-70610@6e47c56 | ansible/ansible | Python | 70,610 | refactor Python module_utils locator | ##### SUMMARY
* no longer recursive
* embed special-case module code internally
* share common code between collections/not cases
* fixes #70134
* properly support subpackage redirection
* adds support for FQCN redirect targets used by migration (expands to FQ Python name)
* add tests
##### ISSUE TYPE
<!--- ... | 2020-07-13T20:21:28Z | Broken module_utils imports fail horribly
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
Modules that use older m... | Files identified in the description:
* [`lib/ansible/executor/module_common.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/executor/module_common.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot hel... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nModules that use older module_utils i... | 20209c508f13b018b8f44f77749001979aa5f048 | {
"head_commit": "6e47c5661229a87339feeef66a368a8e317b18ba",
"head_commit_message": "refactor Python module_utils locator\n\n* no longer recursive\n* embed special-case module code internally\n* share common code between collections/not cases\n* fixes #70134\n* properly support subpackage redirection\n* adds suppor... | [
{
"diff_hunk": "@@ -7569,388 +7569,394 @@ plugin_routing:\n redirect: ansible_collections.testns.testcoll.plugins.module_utils.base\n sub1.sub2.formerly_core:\n redirect: ansible_collections.testns.testcoll.plugins.module_utils.base\n- common:\n- redirect: f5networks.f5_modules.common\n-... | 0516c7035acb789ab50959d4b2e5fcaffc878051 | diff --git a/changelogs/fragments/module_utils_finder_refactor.yml b/changelogs/fragments/module_utils_finder_refactor.yml
new file mode 100644
index 00000000000000..9078c7856fb183
--- /dev/null
+++ b/changelogs/fragments/module_utils_finder_refactor.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - Python module_utils finder - refa... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-70426@50fbff5 | ansible/ansible | Python | 70,426 | Allow non-ascii (UTF-8) chars in cron file paths and jobs | ##### SUMMARY
It may fix #69492
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
`lib/ansible/modules/cron.py`
| 2020-07-01T21:01:03Z | UnicodeDecodeError using cron module with Python3
##### SUMMARY
I just updated my ansible host & I just fixed some trouble about Python3 on remote host.
I only use cron module once & it was previously working fine.
Now it is failing, returning an exception __main__.CronTabError: ('Unexpected error:', <class 'Unico... | Files identified in the description:
* [`lib/ansible/modules/system/cron.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/cron.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](htt... | [
{
"body": "\r\n##### SUMMARY\r\nI just updated my ansible host & I just fixed some trouble about Python3 on remote host.\r\nI only use cron module once & it was previously working fine.\r\nNow it is failing, returning an exception __main__.CronTabError: ('Unexpected error:', <class 'UnicodeDecodeError'>)\r\n\r\... | ce570691e7401c8dc520e3c68a90e9dbf0cbf619 | {
"head_commit": "50fbff5fa771e106a66d7c1cda1990c0288360a7",
"head_commit_message": "Also use non-ascii chars in replaced text and ensure not to break cron syntax.",
"patch_to_review": "diff --git a/changelogs/fragments/70426-allow-non-ascii-chars-in-cron.yml b/changelogs/fragments/70426-allow-non-ascii-chars-in-... | [
{
"diff_hunk": "@@ -291,15 +292,15 @@ def write(self, backup_file=None):\n Write the crontab to the system. Saves all information.\n \"\"\"\n if backup_file:\n- fileh = open(backup_file, 'w')\n+ fileh = open(backup_file, 'wb')\n elif self.cron_file:\n- ... | d2866555526b9032bd6b39f0e7e1d0b8ce199d41 | diff --git a/changelogs/fragments/70426-allow-non-ascii-chars-in-cron.yml b/changelogs/fragments/70426-allow-non-ascii-chars-in-cron.yml
new file mode 100644
index 00000000000000..65275d82dc0203
--- /dev/null
+++ b/changelogs/fragments/70426-allow-non-ascii-chars-in-cron.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - cron - encod... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-70369@92227c3 | ansible/ansible | Python | 70,369 | update Ansible-maintained platform guides with FQCN | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #69374
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Docs Pull Request
##### COMPONENT NAME
<!--- Write the short... | 2020-06-29T19:19:50Z | Update Ansible-maintained scenario guides to use FQCN
<!--- Verify first that your improvement is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- ... | Files identified in the description:
* [`docs/docsite/README.md`](https://github.com/ansible/ansible/blob/devel/docs/docsite/README.md)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/... | [
{
"body": "<!--- Verify first that your improvement is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem brief... | 9fbd65958d4863fd9cfc226d19586a913c19a58c | {
"head_commit": "92227c38074741afee7468c793663f14b6a1f93a",
"head_commit_message": "fix remainin fqcn",
"patch_to_review": "diff --git a/docs/docsite/rst/network/user_guide/platform_eos.rst b/docs/docsite/rst/network/user_guide/platform_eos.rst\nindex 86cb06581dddb8..065a7dc0627c95 100644\n--- a/docs/docsite/rst... | [
{
"diff_hunk": "@@ -27,11 +28,11 @@ Connections Available\n \n Indirect Access via a bastion (jump host)\n \n- Connection Settings ``ansible_connection: netconf``\n+ Connection Settings ``ansible_connection: ansible.netcommon.netconf``\n ==================== ============================... | 89fe1f554f8ab5fbe0b6e9f9c07ff9cf03c5b502 | diff --git a/docs/docsite/rst/network/user_guide/platform_eos.rst b/docs/docsite/rst/network/user_guide/platform_eos.rst
index 86cb06581dddb8..065a7dc0627c95 100644
--- a/docs/docsite/rst/network/user_guide/platform_eos.rst
+++ b/docs/docsite/rst/network/user_guide/platform_eos.rst
@@ -4,19 +4,20 @@
EOS Platform Optio... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
bentoml__BentoML-4456@6078741 | bentoml/BentoML | Python | 4,456 | fix: Replace backslahes by normal slashes, making bentoml pull possible on windows | ## What does this PR address?
With the as_posix we replace the path's backslahes with slashes, making the bentoml pull command from yatai possible on windows systems.
<!--
Thanks for sending a pull request!
Congrats for making it this far! Here's a 🍱 for you. There are still a few steps ahead.
Please make sur... | 2024-01-26T11:41:12Z | bug: Pulling latest version from Remote Yatai Store does not work on Windows - Path Error
### Describe the bug
I pushed a working model to our local Yatai server. However, I can not pull it again, as the latest model is not found on remote Bento store.
If I add the version code manually the Bento is found but, I ge... | https://github.com/bentoml/BentoML/blob/fa6420e49eab15b544eccd8d7f562fa6544947e8/src/bentoml/_internal/cloud/bentocloud.py#L547
If I change the line to:
```
temp_fs.makedirs(str(p.parent).replace('\\', '/'), recreate=True)
```
it works on my windows system. Is there any problem encountered so far using bentoml w... | [
{
"body": "### Describe the bug\r\n\r\nI pushed a working model to our local Yatai server. However, I can not pull it again, as the latest model is not found on remote Bento store.\r\nIf I add the version code manually the Bento is found but, I get a BentoMLException.\r\n\r\n\r\n\r\nError with latest in the tag... | ed1acba428166576fc61887a7e267cc29e02954e | {
"head_commit": "6078741830acbda2d3cb8f124a87459266270adf",
"head_commit_message": "ci: auto fixes from pre-commit.ci\n\nFor more information, see https://pre-commit.ci",
"patch_to_review": "diff --git a/src/bentoml/_internal/cloud/bentocloud.py b/src/bentoml/_internal/cloud/bentocloud.py\nindex 0cdd38034cf..8f6... | [
{
"diff_hunk": "@@ -544,7 +544,9 @@ def pull_model(model_tag: Tag):\n continue\n p = Path(member.name)\n if p.parent != Path(\".\"):\n- temp_fs.makedirs(str(p.parent), recreate=True)\n+ ... | 8073d3a0187ffe187ef45e0eae8ef7f486e730ae | diff --git a/src/bentoml/_internal/cloud/bentocloud.py b/src/bentoml/_internal/cloud/bentocloud.py
index 0cdd38034cf..b1aac7b9e6d 100644
--- a/src/bentoml/_internal/cloud/bentocloud.py
+++ b/src/bentoml/_internal/cloud/bentocloud.py
@@ -544,7 +544,7 @@ def pull_model(model_tag: Tag):
co... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
bentoml__BentoML-4035@50f6f1b | bentoml/BentoML | Python | 4,035 | feat: PIL image encoder to improve the performance | Signed-off-by: Frost Ming <me@frostming.com>
## What does this PR address?
This adds a data container for PIL image types. Instead of pickling the whold image object, we only extract the bytes data from it.
After change, the performance is 3-4x better.
**Before:** 125 RPS
**After:** 430 RPS
**Development ... | 2023-07-11T07:08:38Z | bug: Bentos performance issues
### Describe the bug
I've been conducting load testing on Bento using the MobileNetV2 model. I've observed that the CPU is fully utilized and upon profiling the app, I discovered that the workers are consuming all of the CPU, despite the relatively low RPS (around 30). To further investi... | Hi there, can you send us the benchmark code that you have and the framework you are using for the testing?
Hey, I've posted the code above to reproduce the issue. (it's basically running a logic-less runner, but ofc happens also when running model inference).
regarding the framework for testing - I used locust.
Oh ... | [
{
"body": "### Describe the bug\n\nI've been conducting load testing on Bento using the MobileNetV2 model. I've observed that the CPU is fully utilized and upon profiling the app, I discovered that the workers are consuming all of the CPU, despite the relatively low RPS (around 30). To further investigate this ... | 5e76eb33e580de0ff890e0d00e0d469eed05352e | {
"head_commit": "50f6f1b2dc042f4f5b3b22aa967bd3bebc53485b",
"head_commit_message": "fix: change errors\n\nSigned-off-by: Frost Ming <me@frostming.com>",
"patch_to_review": "diff --git a/src/bentoml/_internal/external_typing/__init__.py b/src/bentoml/_internal/external_typing/__init__.py\nindex 8fea4d2d365..9cddd... | [
{
"diff_hunk": "@@ -450,6 +449,51 @@ def from_batch_payloads( # pylint: disable=arguments-differ\n return cls.batches_to_batch(batches, batch_dim)\n \n \n+class PILImageContainer(DataContainer[\"ext.PILImage\", \"ext.PILImage\"]):\n+ _error = (\n+ \"PIL.Image doesn't support batch inference.\... | e6a3fee936855f2cd1160e21f8f142e4aa7ff655 | diff --git a/src/bentoml/_internal/external_typing/__init__.py b/src/bentoml/_internal/external_typing/__init__.py
index 8fea4d2d365..9cddd093ca3 100644
--- a/src/bentoml/_internal/external_typing/__init__.py
+++ b/src/bentoml/_internal/external_typing/__init__.py
@@ -34,6 +34,8 @@
from .starlette import ASGIRecei... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
ansible__ansible-70293@d6342e9 | ansible/ansible | Python | 70,293 | Fix delegate_facts with interpreter not being set | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes https://github.com/ansible/ansible/issues/70168
Introduced in https://github.com/ansible/ansible/pull/69604 which was backported to `2.9.10`. This would need to be backported to `2.9` and `2.10`.
This is another ta... | 2020-06-25T10:18:46Z | 2.9.10: UnboundLocalError: local variable 'module_style' referenced before assignment
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically --... | I couldn't reproduce this with an arbitrary lineinfile task. We'll need you to provide a minimal reproducer.
@mkrizek I added a reproducer. It seems related to `delegate_facts=true`
Sounds like this might be related to #69604.
cc @bcoca
Can confirm, we have the same problem, though it only triggers in particular ca... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 45e0f747026c5b6e29b2a32c78785ff970da5655 | {
"head_commit": "d6342e931f6aa86db0294c5fc5d0132cf3b88ca7",
"head_commit_message": "Fix permissions",
"patch_to_review": "diff --git a/changelogs/fragments/70168-fix-delegate_facts-without-interpreter-set.yml b/changelogs/fragments/70168-fix-delegate_facts-without-interpreter-set.yml\nnew file mode 100644\nindex... | [
{
"diff_hunk": "@@ -242,18 +242,22 @@ def _configure_module(self, module_name, module_args, task_vars=None):\n # we'll propagate back to the controller in the task result\n discovered_key = 'discovered_interpreter_%s' % idre.interpreter_name\n \n+ # update the loca... | dbf76c88f6107bd146905858745a472de79a586c | diff --git a/changelogs/fragments/70168-fix-delegate_facts-without-interpreter-set.yml b/changelogs/fragments/70168-fix-delegate_facts-without-interpreter-set.yml
new file mode 100644
index 00000000000000..371778eabb2fc3
--- /dev/null
+++ b/changelogs/fragments/70168-fix-delegate_facts-without-interpreter-set.yml
@@ -0... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
bentoml__BentoML-3926@5272faa | bentoml/BentoML | Python | 3,926 | feat: support parsing space for deletion #3418 | ## What does this PR address?
This PR adds support for parsing space in delete command for both `benotml delete` and `bentoml models delete`
Instead of returning value argument as a STRING , It is removed to take default one. Also added nrgs=-1 to have functionality of multiple targets.
Rest of the code is just pa... | 2023-06-02T12:55:08Z | feature(cli): support parsing space for deletion
### Feature request
Right now we don't support parsing space
```python
bentoml models delete model1 model2 ...
```
will fail.
Note that we can already do
```python
bentoml models delete model1,model2
```
### Motivation
_No response_
### Other
... | Could I try this feature?
yes please go ahead. Feel free to ping me if you run into any issues.
Some place to start with:
- https://github.com/bentoml/BentoML/blob/main/src/bentoml_cli/models.py and https://github.com/bentoml/BentoML/blob/main/src/bentoml_cli/bentos.py
I have some questions to clarify this issue.
... | [
{
"body": "### Feature request\r\n\r\nRight now we don't support parsing space\r\n\r\n```python\r\nbentoml models delete model1 model2 ...\r\n```\r\nwill fail.\r\n\r\nNote that we can already do\r\n\r\n```python\r\nbentoml models delete model1,model2\r\n```\r\n\r\n### Motivation\r\n\r\n_No response_\r\n\r\n### ... | 03b9d7dcc7b28a4378e96ce76c75c6b16c0b6d8b | {
"head_commit": "5272faab24c5919f155b46ca5ff7701724ec3cf4",
"head_commit_message": "add documentation #3418",
"patch_to_review": "diff --git a/src/bentoml_cli/bentos.py b/src/bentoml_cli/bentos.py\nindex eba435ce40b..c504595b4fb 100644\n--- a/src/bentoml_cli/bentos.py\n+++ b/src/bentoml_cli/bentos.py\n@@ -35,7 +... | [
{
"diff_hunk": "@@ -164,6 +168,7 @@ def delete(delete_targets: list[str], yes: bool) -> None: # type: ignore (not a\n * Delete single bento bundle by \"name:version\", e.g: `bentoml delete IrisClassifier:v1`\n * Bulk delete all bento bundles with a specific name, e.g.: `bentoml delete I... | 3215b9278d239a6c2cb8a3fe3d69c65a072eeb9c | diff --git a/src/bentoml_cli/bentos.py b/src/bentoml_cli/bentos.py
index eba435ce40b..d4fb76ca485 100644
--- a/src/bentoml_cli/bentos.py
+++ b/src/bentoml_cli/bentos.py
@@ -35,7 +35,11 @@ def parse_delete_targets_argument_callback(
) -> list[str]:
if value is None:
return value
- delete_targets = valu... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-70284@8e9dfd4 | ansible/ansible | Python | 70,284 | Get serial number of NVMe device without sg_inq | ##### SUMMARY
We can get NVMe device's serial number from `/sys/block/<name>/device/serial` file. We don't need to have `sg_inq`, which requires root.
Fixes #66663
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
Facts collection, linux.py
| 2020-06-25T03:22:27Z | device serial number not retrieved without sudo
##### SUMMARY
NVMe devices can have their serial number read by reading (eg) /sys/block/nvme1n1/device/serial, without having to try and run sg_inq, which requires root.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
Facts collection, linux.py
##### ANSI... | Files identified in the description:
* [`lib/ansible/module_utils/facts/hardware/linux.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/facts/hardware/linux.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
... | [
{
"body": "\r\n##### SUMMARY\r\nNVMe devices can have their serial number read by reading (eg) /sys/block/nvme1n1/device/serial, without having to try and run sg_inq, which requires root.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nFacts collection, linux.py\r\n\r\n##### ANSIBLE VERSI... | 8b96caf712d38994cf478b78e34bf019fc30fc9a | {
"head_commit": "8e9dfd4b87e09b2b3d12f95fb389e9f6cda54c9d",
"head_commit_message": "Add changlelog for #70284",
"patch_to_review": "diff --git a/changelogs/fragments/70284-facts-get-nvme-serial-from-file.yml b/changelogs/fragments/70284-facts-get-nvme-serial-from-file.yml\nnew file mode 100644\nindex 00000000000... | [
{
"diff_hunk": "@@ -700,13 +700,20 @@ def get_device_facts(self):\n \n sg_inq = self.module.get_bin_path('sg_inq')\n \n+ # we can get NVMe device's serial number from /sys/block/<name>/device/serial\n+ serial_path = \"/sys/block/%s/device/serial\" % (block)\n+\n if ... | 7be2e4c67b729105b4f91bf02614ed9ce95b6d98 | diff --git a/changelogs/fragments/70284-facts-get-nvme-serial-from-file.yml b/changelogs/fragments/70284-facts-get-nvme-serial-from-file.yml
new file mode 100644
index 00000000000000..9e89436c039aca
--- /dev/null
+++ b/changelogs/fragments/70284-facts-get-nvme-serial-from-file.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - Facts ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
bentoml__BentoML-3873@00e274c | bentoml/BentoML | Python | 3,873 | doc: add example of adaptive batching for collection parameter types | Signed-off-by: Frost Ming <me@frostming.com>
## What does this PR address?
<!--
Thanks for sending a pull request!
Congrats for making it this far! Here's a 🍱 for you. There are still a few steps ahead.
Please make sure to read the contribution guidelines, then fill out the blanks below before requesting a code re... | 2023-05-19T07:20:20Z | feature: Support for Dict of Tensors in production mode
### Feature request
When running `serve --production`, the invocation to `runner.async_run()` goes through an instance of `DataContainer` according to the input type. If you have a PyTorch model and passes as input a `torch.Tensor`, it will be serialized using `P... | Hi @fernandocamargoai , Thanks for your feedback. I think the problem you met is caused by our current batch combining method for dictionary (which simply group dictionaries to list) does not match how pytorch's batch is combined (which should combine tensors inside the dictionary). We are working to improve this area ... | [
{
"body": "### Feature request\n\nWhen running `serve --production`, the invocation to `runner.async_run()` goes through an instance of `DataContainer` according to the input type. If you have a PyTorch model and passes as input a `torch.Tensor`, it will be serialized using `PyTorchTensorContainer`, sent to the... | e221dc5e0c0b59238b720c04ace4fc5ba0f6f459 | {
"head_commit": "00e274ce7710904dfec7f02062e601fabc045df3",
"head_commit_message": "Update docs/source/guides/batching.rst\n\nCo-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>",
"patch_to_review": "diff --git a/docs/source/guides/batching.rst b/docs/source/guides/batching.rst\nindex 8623c5e0... | [
{
"diff_hunk": "@@ -88,3 +88,52 @@ Error handling\n If adaptive batching cannot keep up with rate of the incoming requests while satisfying the max\n latency configuration, HTTP 503 Service Unavailable is returned. To workaround this error, consider\n relaxing the max latency requirement and further scaling the... | c4784c2101274f11718e368ee43552d9d10a23e4 | diff --git a/docs/source/guides/batching.rst b/docs/source/guides/batching.rst
index 8623c5e09a9..8aca5d42f52 100644
--- a/docs/source/guides/batching.rst
+++ b/docs/source/guides/batching.rst
@@ -88,3 +88,52 @@ Error handling
If adaptive batching cannot keep up with rate of the incoming requests while satisfying the ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-70141@86ee111 | ansible/ansible | Python | 70,141 | fix flatten handling of nulls/nones | fixed null break bug and added option to include
fixes #69012
fixes #69013 (adds clog, tests and options to orig fix)
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
flatt... | 2020-06-18T15:23:20Z | Flatten field yields unexpected results when it hits None
##### SUMMARY
Flatten field yields unexpected results when it hits None. Instead of skipping over none it silently discards the to-be-flatten list. See example below.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
flatten filter
##### ANSIB... | It looks like the issue is with this part of the code:
https://github.com/ansible/ansible/blob/835ad75a0a95566e5d960daf7d962f122eca6d14/lib/ansible/plugins/filter/core.py#L468-L470
That `break` should be a `continue`.
@sivel yes so it looks.
(I was using locally patched version for few days until my conscience ... | [
{
"body": "\r\n##### SUMMARY\r\nFlatten field yields unexpected results when it hits None. Instead of skipping over none it silently discards the to-be-flatten list. See example below.\r\n\r\n\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nflatten filter\r\n\r\n##### ANSIBLE VERSION\r\n\... | 33e25504ac1211559e47ba35b6163b502e7dbc32 | {
"head_commit": "86ee111ca02d47598c583f9514d81838a123578e",
"head_commit_message": "c",
"patch_to_review": "diff --git a/changelogs/fragments/fix_lp_flat.yml b/changelogs/fragments/fix_lp_flat.yml\nnew file mode 100644\nindex 00000000000000..84c5643c642ad0\n--- /dev/null\n+++ b/changelogs/fragments/fix_lp_flat.y... | [
{
"diff_hunk": "@@ -467,13 +467,13 @@ def b64decode(string, encoding='utf-8'):\n return to_text(base64.b64decode(to_bytes(string, errors='surrogate_or_strict')), encoding=encoding)\n \n \n-def flatten(mylist, levels=None):\n+def flatten(mylist, levels=None, skip_nulls=True):\n \n ret = []\n for elem... | 26a17a8987ab5f90859a6bdc41085285ccd9eebe | diff --git a/changelogs/fragments/fix_lp_flat.yml b/changelogs/fragments/fix_lp_flat.yml
new file mode 100644
index 00000000000000..84c5643c642ad0
--- /dev/null
+++ b/changelogs/fragments/fix_lp_flat.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - Continue execution when 'flatten' filter when it hits a None/null value as part of t... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-70056@628a231 | ansible/ansible | Python | 70,056 | Add fail_on_autoremove option to apt module to avoid unintended package removals. | ##### SUMMARY
Fixes #63231
As described in https://github.com/ansible/ansible/issues/63231, apt module removes the existing packages which conflict with the package to install (without no warnings or error), and breaks the system.
In this PR, `--no-remove` will be passed to apt-get command to avoid this issue.
... | 2020-06-14T00:55:25Z | apt uninstalls packages and breaks machine
##### SUMMARY
When doing a harmless apt install for a package, this might uninstall other packages and break stuff heavy, especially if there are lots of pending upgrades.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
apt
##### ANSIBLE VERSION
```
ansible 2.... | Files identified in the description:
* [`lib/ansible/modules/packaging/os/apt.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/packaging/os/apt.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bo... | [
{
"body": "##### SUMMARY\r\nWhen doing a harmless apt install for a package, this might uninstall other packages and break stuff heavy, especially if there are lots of pending upgrades.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\napt\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.8.... | 83f6e4850b12532dc244eb0b436b1d0a49dc09a9 | {
"head_commit": "628a23134547708c561984dc844aa9477f4763ca",
"head_commit_message": "Persuade linters",
"patch_to_review": "diff --git a/changelogs/fragments/70056-add-a-param-to-apt-module-to-avoid-unintended-uninstalls.yml b/changelogs/fragments/70056-add-a-param-to-apt-module-to-avoid-unintended-uninstalls.yml... | [
{
"diff_hunk": "@@ -179,6 +179,35 @@\n - name: uninstall hello with apt\n apt: pkg=hello state=absent purge=yes\n \n+# INSTALL WITHOUT REMOVALS\n+- name: Install hello, that conflicts with hello-traditional\n+ apt: pkg=hello state=present update_cache=no\n+\n+- name: check hello\n+ shell: dpkg-query -l hell... | 38bfdbb3537f552355f12c99799fdec15411990c | diff --git a/changelogs/fragments/70056-add-a-param-to-apt-module-to-avoid-unintended-uninstalls.yml b/changelogs/fragments/70056-add-a-param-to-apt-module-to-avoid-unintended-uninstalls.yml
new file mode 100644
index 00000000000000..4c31a33ed2e849
--- /dev/null
+++ b/changelogs/fragments/70056-add-a-param-to-apt-modul... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-70016@3be22b9 | ansible/ansible | Python | 70,016 | ansible-galaxy - fix collection installation with trailing slashes |
##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
If we fail to find a member when extracting a directory, try adding a trailing slash to the member name. In certain cases, the member in the tarfile will contain a trailing slash but the file name in FILES.json will never ... | 2020-06-11T17:40:24Z | `ansible-galaxy collection install` explodes for some collections on `devel`
#### SUMMARY
<!--- Explain the problem briefly below -->
Installing `amazon.aws` collection fails on ansible/ansible@devel, supposedly because of the embedded symlinks:
```console
ERROR! Unexpected Exception, this is probably a bug: "filen... | bisect: d30fc6c0b359f631130b0e979d9a78a7b3747d48 is the first bad commit
So we should probably cc @jborean93.
As @sivel pointed out, the issue is the actual member in the tar file contains a trailing slash while the call does not:
```
In [18]: t.getmember('tests/unit/modules/placebo_recordings/aws_direct_connect_li... | [
{
"body": "#### SUMMARY\r\n<!--- Explain the problem briefly below -->\r\nInstalling `amazon.aws` collection fails on ansible/ansible@devel, supposedly because of the embedded symlinks:\r\n```console\r\nERROR! Unexpected Exception, this is probably a bug: \"filename 'tests/unit/mod\r\nules/placebo_recordings/aw... | a114da80ee65c66d05d818d63903aae2903d998c | {
"head_commit": "3be22b9c0e790769248429587a666326e9558917",
"head_commit_message": "Add unit tests",
"patch_to_review": "diff --git a/lib/ansible/galaxy/collection.py b/lib/ansible/galaxy/collection.py\nindex 72e4d9a42383ca..7b54b2c28581f8 100644\n--- a/lib/ansible/galaxy/collection.py\n+++ b/lib/ansible/galaxy/... | [
{
"diff_hunk": "@@ -1384,7 +1384,19 @@ def _download_file(url, b_path, expected_hash, validate_certs, headers=None):\n \n def _extract_tar_dir(tar, dirname, b_dest):\n \"\"\" Extracts a directory from a collection tar. \"\"\"\n- tar_member = tar.getmember(to_native(dirname, errors='surrogate_or_strict'))... | 6ccad2691d3c2c4de72bfe2ea536726b98ed1245 | diff --git a/lib/ansible/galaxy/collection.py b/lib/ansible/galaxy/collection.py
index 72e4d9a42383ca..be037911791efd 100644
--- a/lib/ansible/galaxy/collection.py
+++ b/lib/ansible/galaxy/collection.py
@@ -1384,7 +1384,23 @@ def _download_file(url, b_path, expected_hash, validate_certs, headers=None):
def _extract_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-69872@462a519 | ansible/ansible | Python | 69,872 | implemented 'prefix' for file based cache | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
fixes #69465
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short nam... | 2020-06-04T00:11:09Z | jsonfile cache plugin prefix option does not work
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain th... | Files identified in the description:
* [`lib/ansible/plugins/cache/jsonfile.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/cache/jsonfile.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot hel... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 7b632788aad12140bb76889d023e4fe2d4572958 | {
"head_commit": "462a519c08284839851cb0da4bbd2cf6c37cde05",
"head_commit_message": "clog",
"patch_to_review": "diff --git a/changelogs/fragments/add_prefix_to_cache.yml b/changelogs/fragments/add_prefix_to_cache.yml\nnew file mode 100644\nindex 00000000000000..03a859d232943f\n--- /dev/null\n+++ b/changelogs/frag... | [
{
"diff_hunk": "@@ -137,6 +137,14 @@ def validate_cache_connection(self):\n raise AnsibleError(\"error in '%s' cache, configured path (%s) does not have necessary permissions (rwx), disabling plugin\" % (\n self.plugin_name, self._cache_dir))\n \n+ def _get_cache_f... | 6417b246a14f330f090faf936829383f87318078 | diff --git a/changelogs/fragments/add_prefix_to_cache.yml b/changelogs/fragments/add_prefix_to_cache.yml
new file mode 100644
index 00000000000000..ed98052dbf4b00
--- /dev/null
+++ b/changelogs/fragments/add_prefix_to_cache.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - added 'unimplemented' prefix to file based caching
diff --gi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-69102@bc94d9b | ansible/ansible | Python | 69,102 | Allow a collection role to call a standalone role by default | ##### SUMMARY
Fixes #69101
Allow a collection to call a stand alone role, without needing
to explicitly add `ansible.legacy` to the collection search order within the
collection role.
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/playbook/role/definition.py
##### ADDITIONAL IN... | 2020-04-22T16:54:20Z | Collection roles cannot call stand alone roles
##### SUMMARY
A role within a collection, cannot easily call a standalone role
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
lib/ansible/playbook/role/definition.py
##### ANSIBLE VERSION
<!--- Paste verbatim output from "ansible --version" between quotes ... | @geerlingguy , @tima, and @s-hertel, one to keep watch on.
@ericsysmin watching as well. Thanks, @sivel | [
{
"body": "##### SUMMARY\r\nA role within a collection, cannot easily call a standalone role\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nlib/ansible/playbook/role/definition.py\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes -->\r\... | 1e08bb7a6fc8cc5c54034b469920d64984d8af47 | {
"head_commit": "bc94d9b4d0da464466eab9c4690686eab55216f6",
"head_commit_message": "tweaked changelog text",
"patch_to_review": "diff --git a/changelogs/fragments/69101-collection-role-to-standalone-role.yml b/changelogs/fragments/69101-collection-role-to-standalone-role.yml\nnew file mode 100644\nindex 00000000... | [
{
"diff_hunk": "@@ -198,7 +198,8 @@ def _load_role_path(self, role_name):\n role_name = os.path.basename(role_name)\n return (role_name, role_path)\n \n- raise AnsibleError(\"the role '%s' was not found in %s\" % (role_name, \":\".join(role_search_paths)), obj=self._ds)\n+ ... | 97403999c66c8dac67a2707663ef64688e1ea38d | diff --git a/changelogs/fragments/69101-collection-role-to-standalone-role.yml b/changelogs/fragments/69101-collection-role-to-standalone-role.yml
new file mode 100644
index 00000000000000..04e8275af97bda
--- /dev/null
+++ b/changelogs/fragments/69101-collection-role-to-standalone-role.yml
@@ -0,0 +1,5 @@
+bugfixes:
+-... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
bentoml__BentoML-3636@612f1d9 | bentoml/BentoML | Python | 3,636 | chore: http client healthcheck | ## What does this PR address?
Fixes #3315
## Before submitting:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
<!--- If you plan to update documentation or tests in follow-up, p... | 2023-03-04T16:04:17Z | feature: `client.health`
### Feature request
client to have a health function:
```python
client.health()
await client.async_health()
```
### Motivation
For HTTP, would probably just need to invoke `/readyz`, and for gRPC is to invoke the `Health` rpc from `grpc.health.v1.HealthServicer`.
### Other
_No response... | @aarnphm Hi! I'm a newbie to BentoML. May I work on this issue?
Hi there, feel free to pick up this issue after https://github.com/bentoml/BentoML/pull/3280 is merged.
Has anyone started this one? It's being here for a while
feel free to pick it up. The client.health is already implemented for gRPC client. You can go a... | [
{
"body": "### Feature request\n\nclient to have a health function:\r\n```python\r\nclient.health()\r\nawait client.async_health()\r\n```\n\n### Motivation\n\nFor HTTP, would probably just need to invoke `/readyz`, and for gRPC is to invoke the `Health` rpc from `grpc.health.v1.HealthServicer`.\n\n### Other\n\n... | f66cdbde90a6f79319357e58e30cc858fbec4381 | {
"head_commit": "612f1d9d4f672bda380637e5cbe435f7e7a41584",
"head_commit_message": "(fix) move simple_service back, remove retries for tests",
"patch_to_review": "diff --git a/src/bentoml/_internal/client/http.py b/src/bentoml/_internal/client/http.py\nindex c5abd7a22f9..90275cf9868 100644\n--- a/src/bentoml/_in... | [
{
"diff_hunk": "@@ -0,0 +1,25 @@\n+import pytest\n+\n+import bentoml\n+from bentoml.client import HTTPClient\n+\n+pytestmark = pytest.mark.asyncio",
"line": null,
"original_line": 6,
"original_start_line": null,
"path": "tests/e2e/bento_server_http/tests/test_client.py",
"start_line": null,
... | 04d81fa5a488e8379671b2af1207d2511e95c43e | diff --git a/src/bentoml/_internal/client/http.py b/src/bentoml/_internal/client/http.py
index c5abd7a22f9..90275cf9868 100644
--- a/src/bentoml/_internal/client/http.py
+++ b/src/bentoml/_internal/client/http.py
@@ -4,6 +4,7 @@
import time
import socket
import typing as t
+import asyncio
import logging
import url... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-69029@7fd1210 | ansible/ansible | Python | 69,029 | Filter BLACKLIST_EXTS in PluginLoader | ##### SUMMARY
(Note this revives https://github.com/ansible/ansible/pull/27235)
Change:
Rather than hardcoding .pyo and .pyc, filter on all BLACKLIST_EXTS in
the non-legacy logic of PluginLoader (_find_fq_plugin). The two harcoded
extensions are part of BLACKLIST_EXTS already and this simply adds the
rest of ... | 2020-04-19T04:28:03Z | Wrong file used as module
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Idea
##### COMPONENT NAME
<!--- Name of the module/plugin... | I did get unchanged result:
```root@ubuntu-xenial:~/ansible-bug# cat > aws <<EOF
> #!/usr/bin/python
> from ansible.module_utils.basic import AnsibleModule
> module = AnsibleModule({})
> module.exit_json(changed=False)
> EOF
root@ubuntu-xenial:~/ansible-bug# cat > aws.py~ <<EOF
> #!/usr/bin/python
> from ans... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the ... | 1e08bb7a6fc8cc5c54034b469920d64984d8af47 | {
"head_commit": "7fd1210fe939f3249fb2ec5f05de00ffa51774ef",
"head_commit_message": "lint: use {0} instead of {}\n\nSigned-off-by: Rick Elrod <rick@elrod.me>",
"patch_to_review": "diff --git a/lib/ansible/config/base.yml b/lib/ansible/config/base.yml\nindex dfb5fd136db809..457d110b148e43 100644\n--- a/lib/ansible... | [
{
"diff_hunk": "@@ -1648,6 +1648,14 @@ INJECT_FACTS_AS_VARS:\n - {key: inject_facts_as_vars, section: defaults}\n type: boolean\n version_added: \"2.5\"\n+MODULE_IGNORE_EXTS:\n+ name: Module ignore extensions\n+ default: \"{{(BLACKLIST_EXTS + ('.yaml', '.yml', '.ini'))}}\"\n+ description: List of exten... | dc5d77d27d25d81ab2c7df9c7db5eedb89b8a33d | diff --git a/changelogs/fragments/69029-module-ignore-exts.yml b/changelogs/fragments/69029-module-ignore-exts.yml
new file mode 100644
index 00000000000000..a18ba0d504dea4
--- /dev/null
+++ b/changelogs/fragments/69029-module-ignore-exts.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - plugin loader - Add MODULE_IGNORE_EXTS c... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
bentoml__BentoML-3050@94db106 | bentoml/BentoML | Python | 3,050 | feat: cascade health checks to runner | - Added `is_ready` method to `RunnerHandle`'s `init` file, then implemented it in the local and remote runners
- Added new method to `Runner` to check that `RunnerHandle` is ready
- Added new method to HTTP service app's `on_startup` method to check the Runner in loop until it returns true | 2022-09-29T18:30:58Z | feat: Cascade readiness and liveness checks to runners in the same container
Health check endpoints, e.g. `/readyz`, `/livez`, on the API server and runner are limited to checking the health of the processes. Ideally, health check to the API server should be cascaded to the runners deployed in the same bento container. | [
{
"body": "Health check endpoints, e.g. `/readyz`, `/livez`, on the API server and runner are limited to checking the health of the processes. Ideally, health check to the API server should be cascaded to the runners deployed in the same bento container.",
"number": 3029,
"title": "feat: Cascade readine... | a2ef543bf165020e95ae1a0a5839f133174ab991 | {
"head_commit": "94db10633f9a5678de71b63b6d91a7a7a00977d9",
"head_commit_message": "fix type of async_run_method",
"patch_to_review": "diff --git a/src/bentoml/_internal/configuration/containers.py b/src/bentoml/_internal/configuration/containers.py\nindex fa3b5fc128d..1be47509aeb 100644\n--- a/src/bentoml/_inte... | [
{
"diff_hunk": "@@ -42,6 +43,35 @@ def __init__(\n self.bento_service = bento_service\n self.enable_metrics = enable_metrics\n \n+ @inject\n+ async def wait_for_runner_ready(\n+ self,\n+ *,\n+ check_interval: int = 5,\n+ ):",
"line": null,
"original_line": 5... | ff5cb060582e6d6dc1d3b6f1ee8c9303849bc452 | diff --git a/src/bentoml/_internal/configuration/containers.py b/src/bentoml/_internal/configuration/containers.py
index fa3b5fc128d..51746bad765 100644
--- a/src/bentoml/_internal/configuration/containers.py
+++ b/src/bentoml/_internal/configuration/containers.py
@@ -171,6 +171,11 @@ def _is_ip_address(addr: str) -> b... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
ansible__ansible-68971@6e55005 | ansible/ansible | Python | 68,971 | Add variable for DEFAULT_NO_TARGET_SYSLOG | ##### SUMMARY
Expose `DEFAULT_NO_TARGET_SYSLOG` through a variable and add notes that this also affects newer style PowerShell modules. Setting it on the task is done like
```
- win_stat:
path: C:\Windows
vars:
ansible_no_target_syslog: True
```
Fixes https://github.com/ansible/ansible/issues/6865... | 2020-04-16T02:35:14Z | Ansible.Basic - do no output even log if DEFAULT_NO_TARGET_SYSLOG is set
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SU... | Files identified in the description:
* [`lib/ansible/modules/windows/win_stat.ps1`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_stat.ps1)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[click here for b... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 46d82179d8fb32ec51ac0ba03ce4445d17c13d34 | {
"head_commit": "6e55005d9409ae15da8a0cfb96e585328cb6e6b7",
"head_commit_message": "Add variable for DEFAULT_NO_TARGET_SYSLOG",
"patch_to_review": "diff --git a/changelogs/fragments/no_target_syslog-var.yaml b/changelogs/fragments/no_target_syslog-var.yaml\nnew file mode 100644\nindex 00000000000000..9929a690bd9... | [
{
"diff_hunk": "@@ -897,10 +897,14 @@ DEFAULT_NO_LOG:\n DEFAULT_NO_TARGET_SYSLOG:\n name: No syslog on target\n default: False\n- description: Toggle Ansible logging to syslog on the target when it executes tasks.\n+ description:\n+ - Toggle Ansible logging to syslog on the target when it executes tasks.... | b920228bb52c44119f1b1a06725e92ccb50628bc | diff --git a/changelogs/fragments/no_target_syslog-var.yaml b/changelogs/fragments/no_target_syslog-var.yaml
new file mode 100644
index 00000000000000..9929a690bd9040
--- /dev/null
+++ b/changelogs/fragments/no_target_syslog-var.yaml
@@ -0,0 +1,2 @@
+minor_changes:
+- Added the ability to set ``DEFAULT_NO_TARGET_SYSLOG... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
bentoml__BentoML-2902@286a4ea | bentoml/BentoML | Python | 2,902 | feat: Adaptive batching size histogram metrics | ## What does this PR address?
<!--
Thanks for sending a pull request!
Congrats for making it this far! Here's a 🍱 for you. There are still a few steps ahead.
Please make sure to read the contribution guidelines, then fill out the blanks below before requesting a code review.
Name your Pull Request with one ... | 2022-08-13T06:07:32Z | Add more debug/info logs runner indicating adaptive batching logic
**Is your feature request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
Currently there is not too much visibility for the user to visualize or to under... | This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
In debug mode, RunnerApp should:
* log the batch size for each run
* log the latency for each run | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\n<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->\r\n\r\nCurrently there is not too much visibility for the user to visualize or to understand how BentoML's micro-batching works. ... | f9997c559496f808d957e3344e50be99de5bca50 | {
"head_commit": "286a4eac1329123d7c26f9eff0c0e16bcb001ad3",
"head_commit_message": "format",
"patch_to_review": "diff --git a/bentoml/_internal/configuration/containers.py b/bentoml/_internal/configuration/containers.py\nindex a0d92c77013..baf9b52cebf 100644\n--- a/bentoml/_internal/configuration/containers.py\n... | [
{
"diff_hunk": "@@ -96,12 +107,17 @@ class CorkDispatcher:\n The wrapped function should be an async function.\n \"\"\"\n \n+ @inject\n def __init__(\n self,\n+ runner_name: str,\n+ worker_index: int,\n+ method_name: str,\n max_latency_in_ms: int,\n ma... | fd52a9e4808bf2c80005b1b2d713b6bdd9db190b | diff --git a/bentoml/_internal/configuration/containers.py b/bentoml/_internal/configuration/containers.py
index a0d92c77013..aef07d4bb51 100644
--- a/bentoml/_internal/configuration/containers.py
+++ b/bentoml/_internal/configuration/containers.py
@@ -45,10 +45,10 @@
logger = logging.getLogger(__name__)
_check_tra... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
bentoml__BentoML-2862@206b84c | bentoml/BentoML | Python | 2,862 | feat: explicit GPU runner mappings | ## What does this PR address?
<!--
Thanks for sending a pull request!
Congrats for making it this far! Here's a 🍱 for you. There are still a few steps ahead.
Please make sure to read the contribution guidelines, then fill out the blanks below before requesting a code review.
Name your Pull Request with one ... | 2022-08-04T19:01:54Z | feat: Runner to GPUs mapping
### Feature request
The default scheduling strategy implementation schedules the same number of runner (`nvidia.com/gpu` supported) instances as the number of available GPUs. If multiple types of runners are present in the service, they will each be scheduled with the same number of inst... | [
{
"body": "### Feature request\r\n\r\nThe default scheduling strategy implementation schedules the same number of runner (`nvidia.com/gpu` supported) instances as the number of available GPUs. If multiple types of runners are present in the service, they will each be scheduled with the same number of instances ... | 93051327caeb7422762ab7c32046b4ea721f7f6a | {
"head_commit": "206b84cd0cba09863e4290cd044c003010d5975f",
"head_commit_message": "add an assert if you wannt check",
"patch_to_review": "diff --git a/bentoml/_internal/resource.py b/bentoml/_internal/resource.py\nindex 8dbc4182d28..40580b4ceff 100644\n--- a/bentoml/_internal/resource.py\n+++ b/bentoml/_interna... | [
{
"diff_hunk": "@@ -66,3 +71,22 @@ def test_bentoml_configuration_runner_override():\n assert test_runner_batching[\"batching\"][\"max_batch_size\"] == 10\n assert test_runner_batching[\"logging\"][\"access\"][\"enabled\"] is True\n assert test_runner_batching[\"resources\"][\"cpu\"] == 4 # should ... | 9439bc31aa0efba319ad3f4fa59365bfdc0e4769 | diff --git a/bentoml/_internal/resource.py b/bentoml/_internal/resource.py
index 8dbc4182d28..40580b4ceff 100644
--- a/bentoml/_internal/resource.py
+++ b/bentoml/_internal/resource.py
@@ -20,7 +20,9 @@
T = t.TypeVar("T")
-def get_resource(resources: dict[str, t.Any], resource_kind: str) -> t.Any:
+def get_resourc... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
ansible__ansible-68925@d5f94a4 | ansible/ansible | Python | 68,925 | ansible-galaxy - fall back to galaxy.yml when listing collections | ##### SUMMARY
Fixes #67490
Supersedes #67630
Use galaxy.yml as a fallback for `ansible-galaxy collection list` if the collection doesn't contain a MANIFEST.json file.
##### ISSUE TYPE
- Bugfix Pull Request | 2020-04-13T20:44:57Z | ansible-galaxy collection list should examine galaxy.yml for information
##### SUMMARY
The list subcommand throws a lot of warnings about a missing version if the collection was not built and installed via an artifact. This information can often be obtained in the galaxy.yml though, so it would make sense to fallbac... | We could also extend this logic to verify ...
```
(ansible_base) [vagrant@centos8 ~]$ ansible-galaxy collection verify -s http://sivel.eng.ansible.com/api openstack.cloud
[WARNING]: Collection at '/home/vagrant/.ansible/collections/ansible_collections/openstack/cloud' does not have a MANIFEST.json file, cannot det... | [
{
"body": "##### SUMMARY\r\n\r\nThe list subcommand throws a lot of warnings about a missing version if the collection was not built and installed via an artifact. This information can often be obtained in the galaxy.yml though, so it would make sense to fallback to that ...\r\n\r\n```\r\n(ansible_base) [vagran... | 18a66e291dad71128a32d662aa808213acefe0e9 | {
"head_commit": "d5f94a415fb175032f342a0e2f9b7d785d9c25c6",
"head_commit_message": "add a note to the documentation",
"patch_to_review": "diff --git a/docs/docsite/rst/user_guide/collections_using.rst b/docs/docsite/rst/user_guide/collections_using.rst\nindex 1ea1b1acf3798c..230c6407dd1f92 100644\n--- a/docs/doc... | [
{
"diff_hunk": "@@ -195,6 +199,13 @@ f_ansible_galaxy_status \\\n \n [[ $(grep -c 'ansible_test\\.airport' out.txt) -eq 1 ]]\n \n+f_ansible_galaxy_status \\\n+ \"collection list specific collection which contains galaxy.yml\"\n+\n+ ansible-galaxy collection list -p ./install ansible_test.development |... | 9cb33a0474c66bdb3d1855f524537f38063c980a | diff --git a/docs/docsite/rst/user_guide/collections_using.rst b/docs/docsite/rst/user_guide/collections_using.rst
index 1ea1b1acf3798c..230c6407dd1f92 100644
--- a/docs/docsite/rst/user_guide/collections_using.rst
+++ b/docs/docsite/rst/user_guide/collections_using.rst
@@ -114,7 +114,7 @@ collections on a host without... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-68723@5fd5113 | ansible/ansible | Python | 68,723 | Force collections to be static | Templating of collection names does not work at all. Force them to
be static so that a warning is generated for the user.
##### SUMMARY
Attempting to template a collection name within a playbook results in any of the collection roles/modules/etc not being found and generates an error. This will force the collect... | 2020-04-06T19:11:42Z | Using a variable in FQCN of the collection called inside the playbook does not find the roles
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automati... | Files identified in the description:
* [`lib/ansible/module_utils/common/collections.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/common/collections.py)
If these files are incorrect, please update the `component name` section of the description or use the `!component` bot command.
[clic... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | f50df6751787113c3cda6e52e2fd92ae4b325b5b | {
"head_commit": "5fd5113f30609d9a79a6c6942af7d1498b6f6c8d",
"head_commit_message": "Force collections to be static\n\nTemplating of collection names does not work at all. Force them to\nbe static so that a warning is generated for the user.",
"patch_to_review": "diff --git a/lib/ansible/playbook/collectionsearch... | [
{
"diff_hunk": "@@ -32,9 +36,18 @@ def _ensure_default_collection(collection_list=None):\n class CollectionSearch:\n \n # this needs to be populated before we can resolve tasks/roles/etc\n- _collections = FieldAttribute(isa='list', listof=string_types, priority=100, default=_ensure_default_collection)\n+... | 5c7b52d0d4a94c70a759154510837cfc56813f6b | diff --git a/changelogs/fragments/68723-force-static-collections.yaml b/changelogs/fragments/68723-force-static-collections.yaml
new file mode 100644
index 00000000000000..c6aaf86f7153c9
--- /dev/null
+++ b/changelogs/fragments/68723-force-static-collections.yaml
@@ -0,0 +1,3 @@
+bugfixes:
+- Force collection names to ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-68687@b4f10e1 | ansible/ansible | Python | 68,687 | Document how to migrate a standalone role to a collection | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Document how to migrate a standalone role to a collection.
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes https://github.com/ansible/ansible/issues/68473
##### ISSUE TYPE
<!--- Pick one be... | 2020-04-03T20:12:20Z | Document how to convert legacy roles to collections
<!--- Verify first that your improvement is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Ex... | # Migrating Roles to Roles in Collections
This document stands as a guide for Content Authors to migrate “legacy style” Ansible Roles, which we will refer to as Legacy Roles throughout this document, into an Ansible Role that’s a part the more featureful and flexible Ansible Collection format used to distribute Ansi... | [
{
"body": "<!--- Verify first that your improvement is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem brief... | bbdf77a59f50306b34161efc148b572ab257a537 | {
"head_commit": "b4f10e12b2d34220795283ff661bd546b805a860",
"head_commit_message": "address latest feedback",
"patch_to_review": "diff --git a/docs/docsite/rst/dev_guide/developing_collections.rst b/docs/docsite/rst/dev_guide/developing_collections.rst\nindex b1cc89e54e1a89..f24ea38f4cbeb1 100644\n--- a/docs/doc... | [
{
"diff_hunk": "@@ -0,0 +1,411 @@\n+\n+.. _migrating_roles:\n+\n+*************************************************\n+Migrating Roles to Roles in Collections on Galaxy\n+*************************************************\n+\n+You can migrate an existing standalone role into a collection-based role that you can ho... | 1088a99f76ad4fc8bd121fcd4e39d7cc4b106465 | diff --git a/docs/docsite/rst/dev_guide/developing_collections.rst b/docs/docsite/rst/dev_guide/developing_collections.rst
index b1cc89e54e1a89..f24ea38f4cbeb1 100644
--- a/docs/docsite/rst/dev_guide/developing_collections.rst
+++ b/docs/docsite/rst/dev_guide/developing_collections.rst
@@ -83,6 +83,8 @@ Add a 'per plug... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-68576@111c0b8 | ansible/ansible | Python | 68,576 | Properly handle unicode in safe_eval | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #66943
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short n... | 2020-03-31T08:26:53Z | Unicode breaks dict
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
Ansible can't parse unicode correctly, when ... | Files identified in the description:
* [`lib/ansible/modules/files/template.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/files/template.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot he... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n\r\nAnsible can't parse unicode corre... | 2b4ca69bc249b27d853085125a6cb091fd11409e | {
"head_commit": "111c0b8873a61992c61ecff87f6a24b4f76ffab3",
"head_commit_message": "Properly handle unicode in safe_eval\n\nFixes #66943",
"patch_to_review": "diff --git a/changelogs/fragments/66943-handle-unicode-in-safe_eval.yml b/changelogs/fragments/66943-handle-unicode-in-safe_eval.yml\nnew file mode 100644... | [
{
"diff_hunk": "@@ -22,7 +22,9 @@\n import sys\n \n from ansible import constants as C\n-from ansible.module_utils.six import string_types\n+from ansible.module_utils._text import to_native\n+from ansible.module_utils.common.text.converters import container_to_text",
"line": null,
"original_line": 26,
... | 692ba84bda342dfe72f72b6b7f8ca1717969c9cd | diff --git a/changelogs/fragments/66943-handle-unicode-in-safe_eval.yml b/changelogs/fragments/66943-handle-unicode-in-safe_eval.yml
new file mode 100644
index 00000000000000..5e8821b0044781
--- /dev/null
+++ b/changelogs/fragments/66943-handle-unicode-in-safe_eval.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - Properly handle un... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-68260@8c58a7b | ansible/ansible | Python | 68,260 | Add TTY check and argument to disable it (#50603) | ##### SUMMARY
Fixes #50603
Runs a TTY check before launching the editor and raises an error if false. One can add the --no-check flag to override this check and launch the editor anyways.
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
ansible-vault create
##### ADDITIONAL INFORMATION
Running ... | 2020-03-16T19:03:36Z | Ansible-vault shows no editor if put inside $()
##### SUMMARY
<!--- Explain the problem briefly below -->
Essentially the issue is that with Ansible 2.5, if you put `ansible-vault --vault-password-file=key create file.yaml` inside `$(ansible-vault --vault-password-file=key create file.yaml)`, it will launch the $... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
This is expe... | [
{
"body": "\r\n##### SUMMARY\r\n<!--- Explain the problem briefly below -->\r\n\r\nEssentially the issue is that with Ansible 2.5, if you put `ansible-vault --vault-password-file=key create file.yaml` inside `$(ansible-vault --vault-password-file=key create file.yaml)`, it will launch the $EDITOR of choice howe... | 4e8b240b8b74db2453851f12ec82c7f782289187 | {
"head_commit": "8c58a7b204a92db08d53aa496c6d5ec8ad8b0ad7",
"head_commit_message": "Fix formatting",
"patch_to_review": "diff --git a/lib/ansible/cli/vault.py b/lib/ansible/cli/vault.py\nindex 6ea330ab4efc1c..59660ac98dcfd7 100644\n--- a/lib/ansible/cli/vault.py\n+++ b/lib/ansible/cli/vault.py\n@@ -76,6 +76,7 @@... | [
{
"diff_hunk": "@@ -76,6 +76,7 @@ def init_parser(self):\n create_parser = subparsers.add_parser('create', help='Create new vault encrypted file', parents=[vault_id, common])\n create_parser.set_defaults(func=self.execute_create)\n create_parser.add_argument('args', help='Filename', meta... | 517739e52f8e45affb5ef92a70b75e97ae3041d1 | diff --git a/changelogs/fragments/50603-tty-check.yaml b/changelogs/fragments/50603-tty-check.yaml
new file mode 100644
index 00000000000000..9acc5351fbf595
--- /dev/null
+++ b/changelogs/fragments/50603-tty-check.yaml
@@ -0,0 +1,4 @@
+---
+minor_changes:
+ - "ansible-vault create: Now raises an error when opening the... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-68560@4af8af7 | ansible/ansible | Python | 68,560 | Force template module to use non-native Jinja2 | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #46169
ci_complete
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task ... | 2020-03-30T14:50:35Z | template module with jinja2_native erroneously convert json string to dict and corrupt it
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automaticall... | This seems to potentially be a bug in the upstream `NativeEnvironment`:
```
>>> from jinja2.nativetypes import NativeEnvironment as Environment
>>> e = Environment()
>>> t = e.from_string('''{
... "foo": "bar"
... }''')
>>> t.render()
{'foo': 'bar'}
>>> type(t.render())
<class 'dict'>
```
cc @mkrize... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nI'm using the template module to gene... | d083307e369b968db7852d6cd2d5a9008724ab1d | {
"head_commit": "4af8af762b8db06464fbbbe27cf5186d5b5b0ada",
"head_commit_message": "Fix sanity",
"patch_to_review": "diff --git a/changelogs/fragments/46169-non-native-template-module.yml b/changelogs/fragments/46169-non-native-template-module.yml\nnew file mode 100644\nindex 00000000000000..7d004a62968cdd\n--- ... | [
{
"diff_hunk": "@@ -28,6 +30,16 @@\n default: '}}'\n version_added: '2.8'\n type: str\n+ jinja2_native:\n+ description:\n+ - Controls whether to use Jinja2 native types.\n+ - It is off by default even if global jinja2_native is True.\n+ - Has ... | 51702cb34339cc45269b460905ea2cf61e5198b6 | diff --git a/changelogs/fragments/46169-non-native-template-module.yml b/changelogs/fragments/46169-non-native-template-module.yml
new file mode 100644
index 00000000000000..7d004a62968cdd
--- /dev/null
+++ b/changelogs/fragments/46169-non-native-template-module.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - Force the templa... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
bentoml__BentoML-2251@726dee6 | bentoml/BentoML | Python | 2,251 | feat: support picklable_model | <!--- Thanks for sending a pull request!
Please make sure to read the contribution guidelines, then fill out the blanks below before requesting a code review.
Name your Pull Request with one of the following prefixes, e.g. "feat: add support for PyTorch", to indicate the type of changes proposed. This is based on... | 2022-02-04T19:07:04Z | Support PickableModel as a new model type
Save a model or python object, that is pickable, in the model store:
```python
bentoml.pickable_model.save('my_model', obj, method="__call__")
```
Load the obj back:
```python
obj = bentoml.pickable_model.load('my_model:latest')
```
Load the obj back as a runner:
```python
si... | [
{
"body": "Save a model or python object, that is pickable, in the model store:\n```python\nbentoml.pickable_model.save('my_model', obj, method=\"__call__\")\n```\n\nLoad the obj back:\n```python\nobj = bentoml.pickable_model.load('my_model:latest')\n```\n\nLoad the obj back as a runner:\n```python\nsimple_runn... | 3f832a201ba1c8ccbc0bdcc1919154a3aeb29909 | {
"head_commit": "726dee646462f8e99635ac3c26f30acf190cceba",
"head_commit_message": "Apply suggestions from code review\n\nCo-authored-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>",
"patch_to_review": "diff --git a/.github/workflows/frameworks.yml b/.github/workflows/frameworks.yml\nindex 1730913fe0... | [
{
"diff_hunk": "@@ -0,0 +1,287 @@\n+import typing as t\n+from typing import TYPE_CHECKING\n+\n+from simple_di import inject\n+from simple_di import Provide\n+\n+from bentoml import Tag\n+from bentoml import Model\n+from bentoml import Runner\n+from bentoml import SimpleRunner\n+from bentoml.exceptions import Be... | deb874bfa3e650cfccbf5e69e1c5000802f4fd5f | diff --git a/.github/workflows/frameworks.yml b/.github/workflows/frameworks.yml
index ed8911f58bd..85e38d04300 100644
--- a/.github/workflows/frameworks.yml
+++ b/.github/workflows/frameworks.yml
@@ -30,6 +30,7 @@ jobs:
onnx: ${{ steps.filter.outputs.onnx }}
onnxmlir: ${{ steps.filter.outputs.onnxmlir }}... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
ansible__ansible-67632@f15964c | ansible/ansible | Python | 67,632 | ansible-galaxy - add download option | ##### SUMMARY
Add a `ansible-galaxy collection download` command that will download collections and it's dependencies to a format that is easy to install on an offline host. An example of this in action is the following
```
(ansible-py37) jborean:~/dev/ansible_collections$ ansible-galaxy collection download jborea... | 2020-02-21T02:20:22Z | ansible-galaxy cli should have an option to keep the collection tarball when installing collection
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Describe the new feature/improveme... | Files identified in the description:
* [`lib/ansible/galaxy`](https://github.com/ansible/ansible/blob/devel/lib/ansible/galaxy)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibul... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Describe the new feature/improvement briefly below -->\r\nUse case is for customers on air-gapped customer... | 8d8c73729fac81fc07a3764cf2f182aa62b70e48 | {
"head_commit": "f15964cf869fc331513994ec67ec6f8c863d121e",
"head_commit_message": "Fix doc suggestions",
"patch_to_review": "diff --git a/changelogs/fragments/galaxy-download.yaml b/changelogs/fragments/galaxy-download.yaml\nnew file mode 100644\nindex 00000000000000..2887c3d09e8738\n--- /dev/null\n+++ b/change... | [
{
"diff_hunk": "@@ -492,6 +497,41 @@ def build_collection(collection_path, output_path, force):\n _build_collection_tar(b_collection_path, b_collection_output, collection_manifest, file_manifest)\n \n \n+def download_collections(collections, output_path, apis, validate_certs, no_deps):\n+ \"\"\"\n+ Do... | b0116d3cd5d62ac66a267752bf1ec51699793b82 | diff --git a/changelogs/fragments/galaxy-download.yaml b/changelogs/fragments/galaxy-download.yaml
new file mode 100644
index 00000000000000..2887c3d09e8738
--- /dev/null
+++ b/changelogs/fragments/galaxy-download.yaml
@@ -0,0 +1,2 @@
+minor_changes:
+- ansible-galaxy - Add ``download`` option for ``ansible-galaxy coll... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-67508@38315d5 | ansible/ansible | Python | 67,508 | let meta tasks use tags | ##### SUMMARY
Fixes #64558
##### ISSUE TYPE
- Bugfix Pull Request
| 2020-02-18T01:08:18Z | Tags doesn't work properly with module meta
##### SUMMARY
Module meta execute every time, even if the action has a different tag specified.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
meta tasks (end_host, end_play)
##### ANSIBLE VERSION
<!--- Paste verbatim output from "ansible --version" between q... | Files identified in the description:
* [`lib/ansible/modules/utilities/helper/meta.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/utilities/helper/meta.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click h... | [
{
"body": "##### SUMMARY\r\nModule meta execute every time, even if the action has a different tag specified.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nmeta tasks (end_host, end_play)\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quot... | 705c666521994ca8e72f53851f77ca55495e421f | {
"head_commit": "38315d5a137cf007d958b997a52bc666e66f035d",
"head_commit_message": "Support tags for explicit meta tasks\n\nAdd --list-tasks tests for meta tags\n\nchangelog\n\nci_complete",
"patch_to_review": "diff --git a/changelogs/fragments/67508-meta-task-tags.yaml b/changelogs/fragments/67508-meta-task-tag... | [
{
"diff_hunk": "@@ -162,7 +162,7 @@ def _process_block(b):\n if isinstance(task, Block):\n taskmsg += _process_block(task)\n else:\n- if task.action == 'meta':\n+ ... | 3200a5bb54aad05ebc9265876cd4cd366f7aea5f | diff --git a/changelogs/fragments/67508-meta-task-tags.yaml b/changelogs/fragments/67508-meta-task-tags.yaml
new file mode 100644
index 00000000000000..df56076dbb34b9
--- /dev/null
+++ b/changelogs/fragments/67508-meta-task-tags.yaml
@@ -0,0 +1,2 @@
+breaking_changes:
+ - The ``meta`` module now supports tags for user... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-67409@178a68f | ansible/ansible | Python | 67,409 | ansible-galaxy - fix listing specific role and role description | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
If the role was not in the first search path, it was reported as not found.
Get the role description from within `galaxy_info` and fall back to a top level `description` key.
Fix logic around reporting whether or not a r... | 2020-02-13T22:25:24Z | galaxy-info --offline option doesn't work
##### SUMMARY
Running `ansible-galaxy info` command using --offline option does not give the "description" information from role_name/meta/main.yml.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
roles
##### ANSIBLE VERSION
```
2.8
```
##### STEPS TO REPROD... | Files identified in the description:
* [`lib/ansible/galaxy`](https://github.com/ansible/ansible/blob/devel/lib/ansible/galaxy)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibul... | [
{
"body": "##### SUMMARY\r\nRunning `ansible-galaxy info` command using --offline option does not give the \"description\" information from role_name/meta/main.yml. \r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nroles\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n2.8\r\n```\r\n##### STEPS TO R... | c61c0f7ad55f874167056eea7a690a2fc3938005 | {
"head_commit": "178a68f175e2f27673f483749f966d4a5fc90730",
"head_commit_message": "BSD and macOS ruining all the fun",
"patch_to_review": "diff --git a/changelogs/fragments/ansible-galaxy-role-list-specific-fix.yml b/changelogs/fragments/ansible-galaxy-role-list-specific-fix.yml\nnew file mode 100644\nindex 000... | [
{
"diff_hunk": "@@ -580,7 +580,11 @@ def exit_without_ignore(rc=1):\n def _display_role_info(role_info):\n \n text = [u\"\", u\"Role: %s\" % to_text(role_info['name'])]\n- text.append(u\"\\tdescription: %s\" % role_info.get('description', ''))\n+\n+ # Get description from galaxy_info['... | 63de39a7582f29d64a06d2fcf95cae3fc56e36c0 | diff --git a/changelogs/fragments/ansible-galaxy-role-list-specific-fix.yml b/changelogs/fragments/ansible-galaxy-role-list-specific-fix.yml
new file mode 100644
index 00000000000000..eaef1d59523e8c
--- /dev/null
+++ b/changelogs/fragments/ansible-galaxy-role-list-specific-fix.yml
@@ -0,0 +1,6 @@
+bugfixes:
+ - >
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
bentoml__BentoML-1313@ee97b61 | bentoml/BentoML | Python | 1,313 | [Enhancement/CLI]Add "all" option for bento service delete | <!--- Thanks for sending a pull request! Please make sure to read the contribution guidelines, then fill out the blanks below before requesting a code review. -->
## Description
<!--- Describe your changes in detail -->
<!--- Attach screenshots here if appropriate. -->
Add `all` option for bento service delete.
... | 2020-12-08T07:40:49Z | Add `bentoml prune` command for deleting all saved bundles
**Is your feature request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->
**Describe the solution you'd like**
<!-- A clear and concise description of what you... | @parano What is the intended distinction between prune and `bento delete`?
@tahentx `bentoml delete` currently can only delete one saved bundle at a time, this issue was meant for adding support for deleting in batches by labels, service name or DateTime range, and there's a python API for it right now called `prune`:... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\n<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -->\r\n\r\n\r\n**Describe the solution you'd like**\r\n<!-- A clear and concise description of what you want to happen. -->\r\n```\r\... | 506d5026f89916b684493198db5bb2707a11537f | {
"head_commit": "ee97b61ee85c92b5deeb6852c14337498b3a4b43",
"head_commit_message": "formatting",
"patch_to_review": "diff --git a/bentoml/cli/bento_management.py b/bentoml/cli/bento_management.py\nindex 2eb888340f5..d86b525168f 100644\n--- a/bentoml/cli/bento_management.py\n+++ b/bentoml/cli/bento_management.py\... | [
{
"diff_hunk": "@@ -175,39 +172,80 @@ def list_bentos(\n _print_bentos_info(result, output)\n \n @cli.command(\n- help='Delete bento. To delete multiple bentos provide the name '\n- 'version tag separated by \",\" for example \"bentoml delete name:v1,name:v2',\n+ help='Delete be... | c038a9840e1d2d1b885cdf7a68e5a5d4c4c80391 | diff --git a/bentoml/cli/bento_management.py b/bentoml/cli/bento_management.py
index 2eb888340f5..c1fb3e811dc 100644
--- a/bentoml/cli/bento_management.py
+++ b/bentoml/cli/bento_management.py
@@ -18,7 +18,8 @@
from bentoml.utils.lazy_loader import LazyLoader
from bentoml.cli.click_utils import (
_echo,
- par... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
bentoml__BentoML-1297@0f1dd69 | bentoml/BentoML | Python | 1,297 | [Enhancement]Add remote path support for save_to_dir function | <!--- Thanks for sending a pull request! Please make sure to read the contribution guidelines, then fill out the blanks below before requesting a code review. -->
## Description
<!--- Describe your changes in detail -->
<!--- Attach screenshots here if appropriate. -->
Add S3 and Google Cloud Storage support for ... | 2020-12-04T00:10:08Z | `bentoml get` fails for one-off "save to s3" bundle
**Describe the bug**
```bash
$ bentoml get BENTO_TAG
BentoService BENTO_TAG not found - INTERNAL:Bento BENTO_TAG not found in target repository
```
**To Reproduce**
Steps to reproduce the behavior:
1. Caa BentoService#save with s3 path
```
# update last... | Problem is CLI will initialize a YataiService with LocalBentoRepo, when getting information for a BentoService using s3 storage. It will use the LocalBentoRepo instead of the S3 one
Note: `.save("s3://..")` is a legacy behavior, when the `path` parameter is provided, bentoml should assume the user does not want to use ... | [
{
"body": "**Describe the bug**\r\n\r\n```bash\r\n$ bentoml get BENTO_TAG\r\n\r\nBentoService BENTO_TAG not found - INTERNAL:Bento BENTO_TAG not found in target repository\r\n```\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Caa BentoService#save with s3 path\r\n```\r\n# update last line in ... | ba0b9ebf03a516abd48ef22bbb82d3b629a3ce79 | {
"head_commit": "0f1dd69d42f7b993fd0170e4c8f5f526909ef499",
"head_commit_message": "log additional info",
"patch_to_review": "diff --git a/bentoml/saved_bundle/bundler.py b/bentoml/saved_bundle/bundler.py\nindex cb24b561b74..4c369a36099 100644\n--- a/bentoml/saved_bundle/bundler.py\n+++ b/bentoml/saved_bundle/bu... | [
{
"diff_hunk": "@@ -49,7 +53,9 @@ def save_to_dir(bento_service, path, version=None, silent=False):\n is not empty, this call may override existing files in the given path.\n \n :param bento_service (bentoml.service.BentoService): a Bento Service instance\n- :param path (str): Destination of where th... | a2aff0d361bc1241af665843aff684aa51b11dbd | diff --git a/bentoml/saved_bundle/bundler.py b/bentoml/saved_bundle/bundler.py
index cb24b561b74..6975498652c 100644
--- a/bentoml/saved_bundle/bundler.py
+++ b/bentoml/saved_bundle/bundler.py
@@ -16,11 +16,15 @@
import shutil
import stat
import logging
+import tarfile
+from urllib.parse import urlparse
+import re... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
bentoml__BentoML-1568@3175a06 | bentoml/BentoML | Python | 1,568 | [Features] Added testcases and prometheus endpoints for YataiService | <!--- Thanks for sending a pull request! Please make sure to read the contribution guidelines, then fill out the blanks below before requesting a code review. -->
## Description
<!--- Describe your changes in detail -->
<!--- Attach screenshots here if appropriate. -->
- Added prometheus integration for metrics e... | 2021-04-06T06:15:54Z | YataiService monitoring and prometheus endpoint
Currently, there is no easy way to monitor a YataiService deployment.
* Add a '/healthz' HTTP endpoint via the node server, in addition to te gRPC health check endpoint
* Add a '/metrics' HTTP endpoint via the node server, and allow expose metrics from the python gRPC... | I would love to take this on
Hello @parano, I am currently working on this issue, I just wanted to ask, what does the endpoint /healthz do exactly? Thank you!
Hi @CallmeMehdi - I think @aarnphm is currently working on this issue as well, maybe you two can sync up and discuss?
"/healthz" endpoint is a convention i... | [
{
"body": "Currently, there is no easy way to monitor a YataiService deployment.\r\n\r\n* Add a '/healthz' HTTP endpoint via the node server, in addition to te gRPC health check endpoint\r\n* Add a '/metrics' HTTP endpoint via the node server, and allow expose metrics from the python gRPC server",
"number":... | 1bc5443803990e65fd4a730ab9312bef50664eca | {
"head_commit": "3175a0656c37af53963b81027e8acfe622245eea",
"head_commit_message": "changes accordingly with lint.sh, flake8, pytest and pylintrc\n\nfixes tests proto python output under tests\n\nupdate pytest to ignore generated protos",
"patch_to_review": "diff --git a/.flake8 b/.flake8\nindex 7a2b2c06748..e00... | [
{
"diff_hunk": "@@ -143,6 +166,7 @@ def start_yatai_service_grpc_server(\n f'''* Web UI: {f\"running on http://127.0.0.1:{ui_port}/{base_url}\"\n if (with_ui and base_url!=\".\")\n else f\"running on http://127.0.0.1:{ui_port}\" if with_ui else \"off\"}\\n'''\n+ f'* Prometheus run... | b2942a78fc1c62f8481ef379d5c4e55790d9a69a | diff --git a/.flake8 b/.flake8
index 7a2b2c06748..6e02ba2272e 100644
--- a/.flake8
+++ b/.flake8
@@ -1,4 +1,4 @@
[flake8]
ignore = E203, E266, W503, E402
max-line-length = 88
-exclude = proto, _version.py
+exclude = tests/yatai/proto, proto, _version.py
diff --git a/Makefile b/Makefile
index 202434d2bef..2132567b068... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
bentoml__BentoML-1284@9dd88e2 | bentoml/BentoML | Python | 1,284 | Added the healthz issue 1060 feature | <!--- Thanks for sending a pull request! Please make sure to read the contribution guidelines, then fill out the blanks below before requesting a code review. -->
## Description
<!--- Describe your changes in detail -->
<!--- Attach screenshots here if appropriate. -->
I have added the healthz endpoint to the Yat... | 2020-12-01T07:38:41Z | YataiService monitoring and prometheus endpoint
Currently, there is no easy way to monitor a YataiService deployment.
* Add a '/healthz' HTTP endpoint via the node server, in addition to te gRPC health check endpoint
* Add a '/metrics' HTTP endpoint via the node server, and allow expose metrics from the python gRPC... | I would love to take this on
Hello @parano, I am currently working on this issue, I just wanted to ask, what does the endpoint /healthz do exactly? Thank you!
Hi @CallmeMehdi - I think @aarnphm is currently working on this issue as well, maybe you two can sync up and discuss?
"/healthz" endpoint is a convention i... | [
{
"body": "Currently, there is no easy way to monitor a YataiService deployment.\r\n\r\n* Add a '/healthz' HTTP endpoint via the node server, in addition to te gRPC health check endpoint\r\n* Add a '/metrics' HTTP endpoint via the node server, and allow expose metrics from the python gRPC server",
"number":... | 0d56b35e7a6969947c77a8cea685190f2196440f | {
"head_commit": "9dd88e2ba8fe638736d2b9f2663811dcbb24a60f",
"head_commit_message": "Added the healthz issue 1060 feature",
"patch_to_review": "diff --git a/bentoml/yatai/web/src/server.ts b/bentoml/yatai/web/src/server.ts\nindex 2d0bbcb11de..c458ad2b5ee 100644\n--- a/bentoml/yatai/web/src/server.ts\n+++ b/bentom... | [
{
"diff_hunk": "@@ -193,50 +197,28 @@ const createRoutes = (app, yataiClient) => {\n return res.status(500).json(error);\n }\n });\n-\n- return router;\n };\n \n-export const getExpressApp = (grpcAddress: string | null, baseURL: string) => {\n+export const getExpressApp = (grpcAddress: string | nul... | b1654d626f817cad51d509cff60c997a856da2fe | diff --git a/bentoml/yatai/web/src/server.ts b/bentoml/yatai/web/src/server.ts
index 2d0bbcb11de..9aa4c68c6d7 100644
--- a/bentoml/yatai/web/src/server.ts
+++ b/bentoml/yatai/web/src/server.ts
@@ -7,7 +7,7 @@ import { createYataiClient } from "./yatai_client";
import { getLogger } from "./logger";
const logger = getL... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-66583@8abc70f | ansible/ansible | Python | 66,583 | podman - fix rootless container copy no pause | Signed-off-by: Adam Miller <admiller@redhat.com>
##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #66263
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Reques... | 2020-01-17T18:58:39Z | ansible + podman connector not working
##### SUMMARY
When using ansible with the podman connector (rootless container as user), I am not able to execute any commands.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
podman connector plugin
##### ANSIBLE VERSION
```
ansible 2.9.2
config file = N... | I have also opened an issue for the podman team:
https://github.com/containers/libpod/issues/4813
cc @EmilienM @sshnaidm
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
@daniel-wtd answered you in libpod issue, I think it's better to discuss ... | [
{
"body": "##### SUMMARY\r\n\r\nWhen using ansible with the podman connector (rootless container as user), I am not able to execute any commands.\r\n\r\n##### ISSUE TYPE\r\n\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\n\r\npodman connector plugin\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.9.2\r\n confi... | a7e4479d018018a6ec288d015cdf64b9a752dac9 | {
"head_commit": "8abc70f25658386f10aa2b8ab17336dab9e35bfe",
"head_commit_message": "podman - fix rootless container copy no pause\n\nFixes #66263\n\nSigned-off-by: Adam Miller <admiller@redhat.com>",
"patch_to_review": "diff --git a/changelogs/fragments/66263-podman-connection-no-pause-rootless.yml b/changelogs/... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+bugfixes:\n+ - podman connection plugin - fix to handle the new default copy pause rootless containers from upstream",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "changelogs/fragments/66263-podman-connection-no-pause-rootless.yml",
... | b578282c90cd1e475f3ef2c37f7b657cd0ec6107 | diff --git a/changelogs/fragments/66263-podman-connection-no-pause-rootless.yml b/changelogs/fragments/66263-podman-connection-no-pause-rootless.yml
new file mode 100644
index 00000000000000..2bd691de01189c
--- /dev/null
+++ b/changelogs/fragments/66263-podman-connection-no-pause-rootless.yml
@@ -0,0 +1,2 @@
+bugfixes:... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-66461@1f36435 | ansible/ansible | Python | 66,461 | Preserving line endings in blockinfile module | ##### SUMMARY
Preserve line endings in blockinfile module.
Fixes #64966
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
blockinfile
##### ADDITIONAL INFORMATION
I'm not sure if this is the desired way to fix this ... it looks kinda "hacky", but O... | 2020-01-14T07:50:24Z | Ansible blockinfile ^M bug!?
### SUMMARY
In SuSe SLES there is a file: /etc/vimrc. It contains ^M characters, like in line: 101 containing:
map! <ESC>OM ^M
When running module blockinfile on this file it removes the ^M characters.
The blockinfile just needs to adds some lines on the end of the file. Even ... | Files identified in the description:
* [`lib/ansible/modules/files/blockinfile.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/files/blockinfile.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for ... | [
{
"body": "\r\n\r\n### SUMMARY\r\nIn SuSe SLES there is a file: /etc/vimrc. It contains ^M characters, like in line: 101 containing:\r\n map! <ESC>OM ^M\r\nWhen running module blockinfile on this file it removes the ^M characters.\r\nThe blockinfile just needs to adds some lines on the end of the file. Eve... | 564907d8acd25c6300b5bad6fe65b3c6b32c1304 | {
"head_commit": "1f3643531c790eba01a66b798d01474e89a0d024",
"head_commit_message": "Fix sanity checks complaining about test fixtures with mixed line endings",
"patch_to_review": "diff --git a/changelogs/fragments/66461-blockinfile_preserve_line_endings.yaml b/changelogs/fragments/66461-blockinfile_preserve_line... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+bugfixes:\n+ - blockingfile - preserve line endings on update (https://github.com/ansible/ansible/issues/64966)",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "changelogs/fragments/66461-blockinfile_preserve_line_endings.yaml",
"st... | e6711998ee61621c3fc44f3777a70c8358f628d2 | diff --git a/changelogs/fragments/66461-blockinfile_preserve_line_endings.yaml b/changelogs/fragments/66461-blockinfile_preserve_line_endings.yaml
new file mode 100644
index 00000000000000..d2454b2af93d73
--- /dev/null
+++ b/changelogs/fragments/66461-blockinfile_preserve_line_endings.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-66463@cdda843 | ansible/ansible | Python | 66,463 | zabbix_template - fixing errors linked templates and dump/imports | ##### SUMMARY
fixes #66417
Line 409 fixes KeyError if existing template has no linked templates - as Zabbix API isn't returning an empty array either.
Line 417 is needed to mark as changed if new/modified template has no linked but existing one has.
Line 442 is needed to actually update even if link_templates was... | 2020-01-14T08:32:23Z | zabbix_template check_template_changed error
##### SUMMARY
KeyError: 'templates' on second run
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
zabbix_template
##### ANSIBLE VERSION
<!--- Paste verbatim output from "ansible --version" between quotes -->
```paste below
ansible 2.9.2
config file = /mn... | Files identified in the description:
* [`lib/ansible/modules/monitoring/zabbix/zabbix_template.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/monitoring/zabbix/zabbix_template.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component... | [
{
"body": "##### SUMMARY\r\nKeyError: 'templates' on second run\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nzabbix_template\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes -->\r\n```paste below\r\nansible 2.9.2\r\n config file = /... | 6f04f87a139c0ed844f56b4d9e70f71c096f4a66 | {
"head_commit": "cdda843f231ca7982aee303e4bfecef8e5cc23dd",
"head_commit_message": "Create 66463-zabbix_template-fix-error-linktemplate-and-importdump.yml",
"patch_to_review": "diff --git a/changelogs/fragments/66463-zabbix_template-fix-error-linktemplate-and-importdump.yml b/changelogs/fragments/66463-zabbix_te... | [
{
"diff_hunk": "@@ -0,0 +1,6 @@\n+---\n+\n+bugfixes:\n+ - zabbix_template fix for error on linked templates and their removal",
"line": null,
"original_line": 4,
"original_start_line": null,
"path": "changelogs/fragments/66463-zabbix_template-fix-error-linktemplate-and-importdump.yml",
"sta... | cfa73f22f9c1fdad3ae9b26ea3fc1029ae0b04b7 | diff --git a/changelogs/fragments/66463-zabbix_template-fix-error-linktemplate-and-importdump.yml b/changelogs/fragments/66463-zabbix_template-fix-error-linktemplate-and-importdump.yml
new file mode 100644
index 00000000000000..187feee4c3c96a
--- /dev/null
+++ b/changelogs/fragments/66463-zabbix_template-fix-error-link... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-66747@00f180f | ansible/ansible | Python | 66,747 | zabbix_template - enable new update rule to delete missing linked templates | ##### SUMMARY
New update rule is available from 4.0.16 and 4.4.4 up. Add check for version and enable new update rule.
fixes #66720
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
zabbix_template
##### ADDITIONAL INFORMATION
Using new update rule set to true, linked templates getting unlink... | 2020-01-24T07:48:25Z | Linked Templates not updated with xml/json templates
##### SUMMARY
If you import a template with a xml/json file the linked templates of a templates ( so the child templates not the root ones ) aren't processed if you want to remove linked templates.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
zabbix_te... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
Also:
- fis... | [
{
"body": "##### SUMMARY\r\nIf you import a template with a xml/json file the linked templates of a templates ( so the child templates not the root ones ) aren't processed if you want to remove linked templates.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nzabbix_templates\r\n\r\n#####... | 68ab8c23be6e363935743bfcc00846c634c66039 | {
"head_commit": "00f180f1bc88c454f2625bf41b4b5f55e926af52",
"head_commit_message": "Update zabbix_template.py",
"patch_to_review": "diff --git a/changelogs/fragments/66747-zabbix_template-newupdaterule-deletemissinglinkedtemplate.yml b/changelogs/fragments/66747-zabbix_template-newupdaterule-deletemissinglinkedt... | [
{
"diff_hunk": "@@ -605,6 +605,10 @@ def import_template(self, template_content, template_type='json'):\n if LooseVersion(api_version).version[:2] <= LooseVersion('3.2').version:\n update_rules['applications']['updateExisting'] = True\n \n+ if (LooseVersion(api_version).ve... | c12b26c2aa0b52c77b66521858179362e2558531 | diff --git a/changelogs/fragments/66747-zabbix_template-newupdaterule-deletemissinglinkedtemplate.yml b/changelogs/fragments/66747-zabbix_template-newupdaterule-deletemissinglinkedtemplate.yml
new file mode 100644
index 00000000000000..f2fb054c927cba
--- /dev/null
+++ b/changelogs/fragments/66747-zabbix_template-newupd... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-66451@5710b40 | ansible/ansible | Python | 66,451 | win_dns_client DHCP improvements + more | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
- Fixes #66450 : gets nameserver information from the registry so that DHCP status can be ensured. When both DHCP assigned nameservers and static nameservers are set in the registry, then static are used. When DHCP is enabled ... | 2020-01-14T01:06:05Z | win_dns_client should properly report status when setting DHCP
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
The `win_dns_client` module always shows "changed" when setting the adapter ... | Files identified in the description:
* [`lib/ansible/modules/windows/win_dns_client.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_dns_client.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nThe `win_dns_client` module always shows \"changed\" when setting the adapter to use DHCP because the PowerShell... | 57d43d19326a32c0ca940217d7c1677c662bd3dc | {
"head_commit": "5710b40b98a593e28a1551483286926454d3b2e5",
"head_commit_message": "Address review feedback; dedup address-family code",
"patch_to_review": "diff --git a/changelogs/fragments/66451-win_dns_client-dhcp-support.yml b/changelogs/fragments/66451-win_dns_client-dhcp-support.yml\nnew file mode 100644\n... | [
{
"diff_hunk": "@@ -43,6 +41,26 @@ Function Write-DebugLog {\n }\n }\n \n+Function ConvertTo-AnsibleCompatibleObject {\n+ <#\n+ .SYNOPSIS\n+ Adds a ContainsKey method to any object so Get-AnsibleParam can be used\n+ to easily get and verify properties from it.\n+ #>\n+ [CmdletB... | 4e40c1b494b63b84194358815753dddc4a016153 | diff --git a/changelogs/fragments/66451-win_dns_client-dhcp-support.yml b/changelogs/fragments/66451-win_dns_client-dhcp-support.yml
new file mode 100644
index 00000000000000..caddc30f583590
--- /dev/null
+++ b/changelogs/fragments/66451-win_dns_client-dhcp-support.yml
@@ -0,0 +1,6 @@
+minor_changes:
+ - Checks for an... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-66244@7339ffa | ansible/ansible | Python | 66,244 | Fix uptimerobot stacktrace on decode | `req.read()` always returns bytes whereas the json module expects
strings.
I don't know how this worked before.
##### SUMMARY
Fixes #66242
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
uptimerobot module.
##### ADDITIONAL INFORMATION
Currently the uptimerobot module fails with a... | 2020-01-07T15:46:30Z | uptimerobot: fails with stacktrace
##### SUMMARY
The uptimerobot module fails with stacktrace on decoding the upstream response.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
The uptimerobot module.
##### ANSIBLE VERSION
```
ansible 2.8.1
config file = /var/lib/jenkins/workspace/Subtask_Openstack_... | [
{
"body": "##### SUMMARY\r\nThe uptimerobot module fails with stacktrace on decoding the upstream response.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nThe uptimerobot module.\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.8.1\r\n config file = /var/lib/jenkins/workspace/Subtask_Op... | 469f104ec27e99ea26d42685ba027fe03571fac9 | {
"head_commit": "7339ffab86495c81245cadf514b0d1917e21178e",
"head_commit_message": "Fix uptimerobot stacktrace on decode\n\n`req.read()` always returns bytes whereas the json module expects\nstrings.\n\nI don't know how this worked before.",
"patch_to_review": "diff --git a/lib/ansible/modules/monitoring/uptimer... | [
{
"diff_hunk": "@@ -79,7 +79,7 @@ def checkID(module, params):\n data = urlencode(params)\n full_uri = API_BASE + API_ACTIONS['status'] + data\n req, info = fetch_url(module, full_uri)\n- result = req.read()\n+ result = req.read().decode(\"utf-8\")",
"line": null,
"original_line": 82,
... | fc6e252a0118553c49dcbdab60c7744e1e0ba278 | diff --git a/lib/ansible/modules/monitoring/uptimerobot.py b/lib/ansible/modules/monitoring/uptimerobot.py
index 8a16170cd96b20..937bbdfe2bdaf2 100644
--- a/lib/ansible/modules/monitoring/uptimerobot.py
+++ b/lib/ansible/modules/monitoring/uptimerobot.py
@@ -59,6 +59,7 @@
from ansible.module_utils.basic import Ansible... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
ansible__ansible-66226@3bafd35 | ansible/ansible | Python | 66,226 | Document network resource modules | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Add details on network resource modules and their states.
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #65598
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Docs Pull... | 2020-01-06T21:36:04Z | Document Network Resource Module States
<!--- Verify first that your improvement is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
- We need a consolid... | Files identified in the description:
* [`lib/ansible/modules/network/eos/__init__.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/eos/__init__.py)
* [`lib/ansible/modules/network/eos/_eos_interface.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/eos/_eos_int... | [
{
"body": "<!--- Verify first that your improvement is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n- We need a consolidated docume... | 22855f73fb5da10c9403cb5af4212a423973657f | {
"head_commit": "3bafd35db722d180cf037807032f5804d891fd76",
"head_commit_message": "show output",
"patch_to_review": "diff --git a/docs/docsite/rst/network/user_guide/index.rst b/docs/docsite/rst/network/user_guide/index.rst\nindex 8414befb08af22..fc51281fd4263c 100644\n--- a/docs/docsite/rst/network/user_guide/... | [
{
"diff_hunk": "@@ -0,0 +1,158 @@\n+.. _resource_modules:\n+\n+************************\n+Network resource modules\n+************************\n+\n+Ansible 2.9 introduced network resource modules to simplify and standardize how you manage different network devices.\n+\n+\n+.. contents::\n+ :local:\n+\n+Underst... | 64bf8746c99bcd07c8bb3081e6cc123684e61685 | diff --git a/docs/docsite/rst/network/user_guide/index.rst b/docs/docsite/rst/network/user_guide/index.rst
index 8414befb08af22..fc51281fd4263c 100644
--- a/docs/docsite/rst/network/user_guide/index.rst
+++ b/docs/docsite/rst/network/user_guide/index.rst
@@ -16,6 +16,7 @@ If you're new to Ansible, or new to using Ansib... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
bentoml__BentoML-982@ea3b16c | bentoml/BentoML | Python | 982 | Refactor(adapter): generic logic | See description for #972 | 2020-08-11T02:43:17Z | Refactor adapters
## Is your feature request related to a problem? Please describe.
- Allowed users to customize HTTP response/ AWS lambda event like headers, etc
- Made contribution of adapters easier.
- Drier adapter code
- A more handy CLI UX for user defined API function
## Describe the solution you'd like
... | [
{
"body": "## Is your feature request related to a problem? Please describe.\r\n- Allowed users to customize HTTP response/ AWS lambda event like headers, etc\r\n- Made contribution of adapters easier.\r\n- Drier adapter code\r\n- A more handy CLI UX for user defined API function\r\n\r\n## Describe the solution... | 2fae9def11a2a84cee5cfd7d0320ee3d8776cb88 | {
"head_commit": "ea3b16c4a7da6882a4d94f76697aff7c9945e446",
"head_commit_message": "Various changes and typo fixes",
"patch_to_review": "diff --git a/bentoml/__init__.py b/bentoml/__init__.py\nindex 346333ecb5f..c1f09d3b4a9 100644\n--- a/bentoml/__init__.py\n+++ b/bentoml/__init__.py\n@@ -35,7 +35,6 @@\n sav... | [
{
"diff_hunk": "@@ -91,7 +91,7 @@ def parse_cli_input(cli_args: Iterable[str]) -> Iterator[bytes]:\n input_g.add_argument('--input', nargs=\"+\", type=str)\n input_g.add_argument('--input-file', nargs=\"+\")\n \n- parsed_args, _ = parser.parse_known_args(cli_args)\n+ parsed_args, _ = parser.parse_... | 8a3fbcb162926423050a6adb4b970d4514f0e8e9 | diff --git a/bentoml/__init__.py b/bentoml/__init__.py
index 346333ecb5f..c1f09d3b4a9 100644
--- a/bentoml/__init__.py
+++ b/bentoml/__init__.py
@@ -35,7 +35,6 @@
save,
)
-
__all__ = [
"__version__",
"api",
diff --git a/bentoml/_version.py b/bentoml/_version.py
index d3f3d35be71..ce8334d6647 100644
-... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} | |
ansible__ansible-66200@95db948 | ansible/ansible | Python | 66,200 | add note for Azure Availbility Zone | ##### SUMMARY
add note to distribute Azure VMs in Availability Zones
Fixes #66149
##### ISSUE TYPE
Docs Pull Request
##### COMPONENT NAME
Microsoft Azure Guide
| 2020-01-06T05:25:03Z | How to distribute Azure VMs in Availability Zones
<!--- Verify first that your improvement is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
The curren... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
cc @Fred-sun... | [
{
"body": "<!--- Verify first that your improvement is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nThe current 'Microsoft Azure Gu... | d56d0f97e30d728b6ea54149001364afb39c5386 | {
"head_commit": "95db9486a4741e3e3de080e3fa982db07be4c244",
"head_commit_message": "Change title",
"patch_to_review": "diff --git a/docs/docsite/rst/scenario_guides/guide_azure.rst b/docs/docsite/rst/scenario_guides/guide_azure.rst\nindex ff30aeaa3165a9..4b390c84353845 100644\n--- a/docs/docsite/rst/scenario_gui... | [
{
"diff_hunk": "@@ -257,6 +257,31 @@ virtual network already with an existing subnet, you can run the following to cr\n version: latest\n \n \n+Creating a Virtual Machine in Availability Zones\n+..................................................\n+\n+If you want to create a Virtual Machines in Availabil... | 59548a4395a11ff19991d23261ca146f35801f15 | diff --git a/docs/docsite/rst/scenario_guides/guide_azure.rst b/docs/docsite/rst/scenario_guides/guide_azure.rst
index ff30aeaa3165a9..2dfd1096dd41f0 100644
--- a/docs/docsite/rst/scenario_guides/guide_azure.rst
+++ b/docs/docsite/rst/scenario_guides/guide_azure.rst
@@ -257,6 +257,30 @@ virtual network already with an ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
bentoml__BentoML-839@def14ff | bentoml/BentoML | Python | 839 | Custom Web UI support for API Server | <!--- Thanks for sending a pull request! Please make sure to read the contribution guidelines, then fill out the blanks below before requesting a code review. -->
## Description
<!--- Describe your changes in detail -->
<!--- Attach screenshots here if appropriate. -->
Closes #739
Requires a directory to be p... | 2020-06-24T22:37:22Z | Custom service web UI to replace default swagger UI
* Currently when starting a BentoML API model server, it starts a simple web UI in addition to the API endpoints. This Web UI is generated with swagger API schema, it can be used for data scientists to test the API endpoint from a browser. But not ideal for a non-tech... | Hey @parano, I would like to work on this if no one else is already working on it
Thanks, @Korusuke, let me know if you have any questions about it | [
{
"body": "* Currently when starting a BentoML API model server, it starts a simple web UI in addition to the API endpoints. This Web UI is generated with swagger API schema, it can be used for data scientists to test the API endpoint from a browser. But not ideal for a non-technical user to use.\r\n\r\n* This ... | ef1feb7654ebdccc5f4a317a2de537de76705dab | {
"head_commit": "def14ffc45ac2e72c23d352f4b465378858f2694",
"head_commit_message": "Fix _path",
"patch_to_review": "diff --git a/bentoml/__init__.py b/bentoml/__init__.py\nindex 68eec2f58bf..b08631ff8ef 100644\n--- a/bentoml/__init__.py\n+++ b/bentoml/__init__.py\n@@ -29,6 +29,7 @@\n BentoService,\n api_... | [
{
"diff_hunk": "@@ -106,16 +116,18 @@ def start(self):\n # Flask dev server enabled threaded by default, disable it.\n self.app.run(port=self.port, threaded=False)\n \n- @staticmethod\n- def index_view_func():\n+ def index_view_func(self):\n \"\"\"\n The index route for ... | e89f7fc6d73e6093054c58f888358e2f442618ca | diff --git a/bentoml/__init__.py b/bentoml/__init__.py
index 68eec2f58bf..346333ecb5f 100644
--- a/bentoml/__init__.py
+++ b/bentoml/__init__.py
@@ -29,6 +29,7 @@
BentoService,
api_decorator as api,
env_decorator as env,
+ web_static_content_decorator as web_static_content,
artifacts_decorator as... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
bentoml__BentoML-790@342a8cd | bentoml/BentoML | Python | 790 | Add prediction logging to AWS Lambda deployment | <!--- Thanks for sending a pull request! Please make sure to read the contribution guidelines, then fill out the blanks below. -->
## Description
* fix some basic typos in Lambda utils
* made bad python version during Lambda deploy error more descriptive
* add prediction logging to AWS Lambda endpoint
## Motiv... | 2020-06-12T17:48:03Z | Prediction log in AWS Lambda deployment
**Is your feature request related to a problem? Please describe.**
Currently, a BentoService AWS Lambda deployment only logs the prediction request but not the response (a.k.a the output of the model.) of API calls.
**Describe the solution you'd like**
Print the output of ... | [
{
"body": "**Is your feature request related to a problem? Please describe.**\r\nCurrently, a BentoService AWS Lambda deployment only logs the prediction request but not the response (a.k.a the output of the model.) of API calls.\r\n\r\n\r\n**Describe the solution you'd like**\r\nPrint the output of the model a... | 09f51aafeb7f510758f0d372688560a3d56e5d9b | {
"head_commit": "342a8cdef80b7ca26a2a7968baa9a0d5f340396e",
"head_commit_message": "whitespace fixes",
"patch_to_review": "diff --git a/bentoml/yatai/deployment/aws_lambda/lambda_app.py b/bentoml/yatai/deployment/aws_lambda/lambda_app.py\nindex 8f8cab5de36..943e6e5c483 100644\n--- a/bentoml/yatai/deployment/aws_... | [
{
"diff_hunk": "@@ -14,13 +14,17 @@\n \n import os\n import sys\n+import logging\n+\n+logger = logging.getLogger(__name__)\n+logger.setLevel(logging.DEBUG)",
"line": null,
"original_line": 20,
"original_start_line": null,
"path": "bentoml/yatai/deployment/aws_lambda/lambda_app.py",
"start_li... | 319d340b830e3e9e1e7724e8c038523194dae73b | diff --git a/bentoml/yatai/deployment/aws_lambda/lambda_app.py b/bentoml/yatai/deployment/aws_lambda/lambda_app.py
index 8f8cab5de36..d00f074796b 100644
--- a/bentoml/yatai/deployment/aws_lambda/lambda_app.py
+++ b/bentoml/yatai/deployment/aws_lambda/lambda_app.py
@@ -14,6 +14,8 @@
import os
import sys
+import logg... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
ansible__ansible-66006@5467025 | ansible/ansible | Python | 66,006 | RoleRequirement - Include stderr in the error message | ##### SUMMARY
Fixes #41336
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/playbook/role/requirement.py
| 2019-12-20T22:16:06Z | ansible-galaxy hides scm errors
<!---
Verify first that your issue/request is not already reported on GitHub.
THIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.
Also test if the latest release, and devel branch are affected too.
ALWAYS add information AFTER (OUTSIDE) these html comments.
Othe... | Files identified in the description:
* [lib/ansible/galaxy](https://github.com/ansible/ansible/blob/devel/lib/ansible/galaxy)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullb... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nTHIS FORM WILL BE READ BY A MACHINE, COMPLETE ALL SECTIONS AS DESCRIBED.\r\nAlso test if the latest release, and devel branch are affected too.\r\nALWAYS add information AFTER (OUTSIDE) these html comments.\r\nOtherwi... | 9ea5b539b60cb7035f08ac17688976a8e6dfb126 | {
"head_commit": "54670259cc6f15ab2c0df4c4680d8def36f352be",
"head_commit_message": "Don't try to concatenate str and bytes",
"patch_to_review": "diff --git a/lib/ansible/playbook/role/requirement.py b/lib/ansible/playbook/role/requirement.py\nindex 8e974f16848abd..62741680109bdf 100644\n--- a/lib/ansible/playboo... | [
{
"diff_hunk": "@@ -145,11 +145,11 @@ def run_scm_cmd(cmd, tempdir):\n except Exception as e:\n ran = \" \".join(cmd)\n display.debug(\"ran %s:\" % ran)\n- display.debug(\"\\tstdout: \" + stdout)\n- display.debug(\"\\tstderr: \" + stderr)... | 09b0c17ea4ebac82dd6c358a58f4f194918246ee | diff --git a/changelogs/fragments/66006-RoleRequirement-include-stderr-error-msg.yaml b/changelogs/fragments/66006-RoleRequirement-include-stderr-error-msg.yaml
new file mode 100644
index 00000000000000..10464cd95c7e8a
--- /dev/null
+++ b/changelogs/fragments/66006-RoleRequirement-include-stderr-error-msg.yaml
@@ -0,0 ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-65718@f610bd9 | ansible/ansible | Python | 65,718 | Fix netconf plugin related to collections |
##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #65655 (partly)
* Make netconf plugins configurable so that the
information of ncclient device handler
for give platform resides in the platform
specific netconf plugin.
* If the device handler valu... | 2019-12-11T09:24:26Z | NETCONF connections/plugins require rework to support collections
##### SUMMARY
Ansible platform contains some hard coded behaviour that blocks making NETCONF plugins pluggable using Collections (Galaxy).
Detailed issues:
1. NETCONF connection plugin contains a dictionary called `NETWORK_OS_DEVICE_PARAM_MAP` that ... | Files identified in the description:
* [`lib/ansible/plugins/connection/netconf.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/connection/netconf.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here fo... | [
{
"body": "##### SUMMARY\r\nAnsible platform contains some hard coded behaviour that blocks making NETCONF plugins pluggable using Collections (Galaxy).\r\n\r\nDetailed issues:\r\n1. NETCONF connection plugin contains a dictionary called `NETWORK_OS_DEVICE_PARAM_MAP` that translates from `ansible_network_os` to... | d7414d55e14a5c98e381a94f5c8a912afbe6355f | {
"head_commit": "f610bd91e9b6c1a0f95e56340e8c8aaafd7599b6",
"head_commit_message": "Fix netconf plugin related to collections\n\nFixes #65655 (partly)\n\n* Make netconf plugins configurable so that the\n information of ncclient device handler\n for give platform resides in the platform\n specific netconf pl... | [
{
"diff_hunk": "@@ -19,6 +19,23 @@\n from __future__ import (absolute_import, division, print_function)\n __metaclass__ = type\n \n+DOCUMENTATION = \"\"\"\n+---\n+netconf: sros\n+short_description: Use Nokia SROS netconf plugin to run netconf commands on Nokia SROS platform\n+description:\n+ - This sros plugin... | 8a904ffcb495defe5d8c684da614a81d9ac4df8d | diff --git a/changelogs/fragments/netconf_plugin_device_handler.yml b/changelogs/fragments/netconf_plugin_device_handler.yml
new file mode 100644
index 00000000000000..8cde051a5a23da
--- /dev/null
+++ b/changelogs/fragments/netconf_plugin_device_handler.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- Make netconf plugin configurable... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
ansible__ansible-65382@1185756 | ansible/ansible | Python | 65,382 | ufw: add support for interface_in and interface_out | ##### SUMMARY
The UFW module has support for specifying `direction` and `interface`
for UFW rules. Rules with these parameters are built such that
per-interface filtering only apply to a single direction based on the
value of `direction`.
Not being able to specify multiple interfaces complicates things for
`... | 2019-11-29T22:19:48Z | ufw module does not support specifying both in & out interfaces for forwarding rules
##### SUMMARY
Currently the module ufw does not allow to specify two network interfaces for forwarding rules (rule='allow' routed='yes').
What I'd like to achieve is this rule:
`ufw route allow in on ethX out on ethY to 10.0.0.0/8 f... | Files identified in the description:
* [`lib/ansible/modules/system/ufw.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/ufw.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](http... | [
{
"body": "##### SUMMARY\r\nCurrently the module ufw does not allow to specify two network interfaces for forwarding rules (rule='allow' routed='yes').\r\nWhat I'd like to achieve is this rule:\r\n`ufw route allow in on ethX out on ethY to 10.0.0.0/8 from 192.168.0.0/24`\r\n\r\nTo my knowledge, the best one can... | 0d34a2eceea9178553e23f53ed24ba58e3722833 | {
"head_commit": "11857563b73c88aca9ff71f8f5c6169e79fbed4b",
"head_commit_message": "ufw: add unit tests for direction and interface\n\nExtend the unit tests for the UFW module to test the `direction` and\n`interface` parameters. This will help in the implementation of a fix\nfor issue #63903.",
"patch_to_review... | [
{
"diff_hunk": "@@ -327,6 +349,8 @@ def main():\n supports_check_mode=True,\n mutually_exclusive=[\n ['name', 'proto', 'logging'],\n+ ['direction', 'interface_in'],\n+ ['direction', 'interface_out'],",
"line": 355,
"original_line": 355,
"original_sta... | 95c1d84e42be94ff7e120ca82fc7ba30d0629960 | diff --git a/changelogs/fragments/63903-ufw.yaml b/changelogs/fragments/63903-ufw.yaml
new file mode 100644
index 00000000000000..975ecc129d5fa0
--- /dev/null
+++ b/changelogs/fragments/63903-ufw.yaml
@@ -0,0 +1,2 @@
+minor_changes:
+ - ufw - accept ``interface_in`` and ``interface_out`` as parameters.
diff --git a/li... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-65294@713406e | ansible/ansible | Python | 65,294 | Document group module return values | ##### SUMMARY
<!--- Your description here -->
Group module return values are missing from documentation.
Return values were determined by iterating over the combinations of `state` and `system` with existent and non-existent groups.
Output of `ansible --version`:
```
ansible 2.9.0
config file = /etc/ansibl... | 2019-11-26T20:07:41Z | group module return values undocumented
<!--- Verify first that your improvement is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain the pr... | [
{
"body": "<!--- Verify first that your improvement is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem brief... | 4c589661c2add45023f2bff9203e0c4e11efe5f6 | {
"head_commit": "713406e7a968c4bb7960359a3aa00c78f2396749",
"head_commit_message": "Document group module return values\n\n##### SUMMARY\r\n<!--- Your description here -->\r\nGroup module return values are missing from documentation.\r\n\r\nReturn values were determined by iterating over the combinations of `state... | [
{
"diff_hunk": "@@ -74,6 +74,32 @@\n state: present\n '''\n \n+RETURN = r'''\n+gid:\n+ description: Group ID of the group.\n+ returned: When C(state) is 'present'\n+ type: int\n+ sample: 1001\n+",
"line": null,
"original_line": 83,
"original_start_line": null,
"path": "lib/ansible/module... | ebc46f6088adee871a6daebc66672ae0e9f26a26 | diff --git a/lib/ansible/modules/system/group.py b/lib/ansible/modules/system/group.py
index bad3157dcfd045..ac50bc899d35af 100644
--- a/lib/ansible/modules/system/group.py
+++ b/lib/ansible/modules/system/group.py
@@ -74,6 +74,29 @@
state: present
'''
+RETURN = r'''
+gid:
+ description: Group ID of the group.... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
ansible__ansible-65576@472ffdb | ansible/ansible | Python | 65,576 | free strategy - include failed hosts that were notified | ##### SUMMARY
The free strategy was excluding failed hosts that were notified so the base class didn't run handlers on those hosts even when --force-handlers was used.
~WIP while I add a test for it to keep it from breaking in the future.~
Fixes #65254
##### ISSUE TYPE
- Bugfix Pull Request
| 2019-12-05T20:45:56Z | The --force-handlers option if used with 'strategy: free' does not run handlers on all hosts.
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automat... | Files identified in the description:
* [`lib/ansible/plugins/strategy/__init__.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/strategy/__init__.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for ... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | edc7c4ddee3122f356ba8f8b9438fecb7a8ad95e | {
"head_commit": "472ffdb74deaaf59baf1658d809c4313aee644c9",
"head_commit_message": "Use the play iterator instead of TQM for accurate failure representation in blocks",
"patch_to_review": "diff --git a/changelogs/fragments/65576-fix-free-strategy-handler-filtering.yaml b/changelogs/fragments/65576-fix-free-strat... | [
{
"diff_hunk": "@@ -76,6 +80,7 @@ def run(self, iterator, play_context):\n list again, which would end up favoring hosts near the beginning of the\n list.\n '''\n+ self.iterator = iterator",
"line": null,
"original_line": 83,
"original_start_line": null,
"path": "l... | 18f35a97754c10206669339d74c81877e0888635 | diff --git a/changelogs/fragments/65576-fix-free-strategy-handler-filtering.yaml b/changelogs/fragments/65576-fix-free-strategy-handler-filtering.yaml
new file mode 100644
index 00000000000000..87f5fbe095857e
--- /dev/null
+++ b/changelogs/fragments/65576-fix-free-strategy-handler-filtering.yaml
@@ -0,0 +1,4 @@
+bugfix... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.