instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
ansible__ansible-65335@8311052 | ansible/ansible | Python | 65,335 | Added ability to specify plan information for images that require it. | ##### SUMMARY
Added ability to specify billing plan information for images that require it. Images like CIS hardened images on Azure marketplace require plan field to be populated.
Fixes #65268
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
azure_rm_virtualmachinescaleset
##### ADDITIONAL IN... | 2019-11-27T18:41:09Z | azure_rm_virtualmachinescaleset fails when using image that requires plan information
The module azure_rm_virtualmachine has fields for plan information. Module azure_rm_virtualmachinescaleset needs to have them and forward them when creating a VM with an image that requires plan info to be specified. The CIS hardened ... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
@seanw122: G... | [
{
"body": "The module azure_rm_virtualmachine has fields for plan information. Module azure_rm_virtualmachinescaleset needs to have them and forward them when creating a VM with an image that requires plan info to be specified. The CIS hardened images from the Azure Marketplace is a prime example.\r\n",
"nu... | 34ecd6cb25258116d394ffcbaf9ec29504a3919a | {
"head_commit": "8311052641e3d97c735b2e23fcd572848c237715",
"head_commit_message": "Removed extra blank line. Added promotion_code to plan param list.",
"patch_to_review": "diff --git a/changelogs/fragments/65335-add-plan-to-azure-vmscaleset-module.yaml b/changelogs/fragments/65335-add-plan-to-azure-vmscaleset-m... | [
{
"diff_hunk": "@@ -852,6 +927,24 @@ def exec_module(self, **kwargs):\n \n vmss_resource.virtual_machine_profile.storage_profile.data_disks = data_disks\n \n+ # Before creating VM accept terms of plan if `accept_terms` is True\n+ if self.accept_terms... | 58bae51ba89ad027f78a3f748e45b5662d0f6d42 | diff --git a/changelogs/fragments/65335-add-plan-to-azure-vmscaleset-module.yaml b/changelogs/fragments/65335-add-plan-to-azure-vmscaleset-module.yaml
new file mode 100644
index 00000000000000..1b48dff1a35495
--- /dev/null
+++ b/changelogs/fragments/65335-add-plan-to-azure-vmscaleset-module.yaml
@@ -0,0 +1,2 @@
+minor_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-65230@628998d | ansible/ansible | Python | 65,230 | Added required parameter to document DOC-string to produce Documentation. |
Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #64654
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Docs Pull Req... | 2019-11-24T10:56:44Z | [WARNING]: template parsing did not produce documentation
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Ex... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
Both modules... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | f4d45ffdff2bdaeccff3880b2e632727cd8c4529 | {
"head_commit": "628998df4710e44ddbcd63de3524cafcd25e1698",
"head_commit_message": "Added required parameter to document DOC-string to produce Documentation.\n\nSigned-off-by: Satyajit Bulage <sbulage@redhat.com>",
"patch_to_review": "diff --git a/lib/ansible/modules/files/template.py b/lib/ansible/modules/files... | [
{
"diff_hunk": "@@ -17,6 +17,7 @@\n ---\n module: template\n version_added: historical\n+short_description: Create a files and directories by using templates.",
"line": null,
"original_line": 20,
"original_start_line": null,
"path": "lib/ansible/modules/files/template.py",
"start_line": null... | 9a20653155ad47c9e06277669e85bf4c122f186d | diff --git a/lib/ansible/modules/files/template.py b/lib/ansible/modules/files/template.py
index 949c800ce69ee9..1aec5226b8fcaa 100644
--- a/lib/ansible/modules/files/template.py
+++ b/lib/ansible/modules/files/template.py
@@ -17,6 +17,7 @@
---
module: template
version_added: historical
+short_description: Template ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-65229@d19b83c | ansible/ansible | Python | 65,229 | Handle LibraryError exception in postgresql_db | Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Removed `exception` class for `LibraryError` which fixes #65223.
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick ... | 2019-11-24T09:51:00Z | LibraryError doesn't exist in the module ansible.module_utils.postgres
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMM... | Files identified in the description:
* [`lib/ansible/plugins/doc_fragments/postgres.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/doc_fragments/postgres.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nLine 556 in the current file `ansible... | 63b94fca7e96a0fe9fcb92d3af3097e3a309f5ab | {
"head_commit": "d19b83c250258a9ffe1a0212fd6399538434530a",
"head_commit_message": "Fixed LibraryError for issue 65223\n\nSigned-off-by: Satyajit Bulage <sbulage@redhat.com>",
"patch_to_review": "diff --git a/lib/ansible/modules/database/postgresql/postgresql_db.py b/lib/ansible/modules/database/postgresql/postg... | [
{
"diff_hunk": "@@ -201,6 +201,11 @@\n class NotSupportedError(Exception):\n pass\n \n+\n+class LibraryError(Exception):",
"line": null,
"original_line": 205,
"original_start_line": null,
"path": "lib/ansible/modules/database/postgresql/postgresql_db.py",
"start_line": null,
"text": ... | a10882d44683a6179515b0c0040cc03f440dcfe4 | diff --git a/changelogs/fragments/65223-postgresql_db-exception-added.yml b/changelogs/fragments/65223-postgresql_db-exception-added.yml
new file mode 100644
index 00000000000000..51656b12808168
--- /dev/null
+++ b/changelogs/fragments/65223-postgresql_db-exception-added.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - postgresql_d... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-65138@389a2a3 | ansible/ansible | Python | 65,138 | Windows: Add multi-domain forest Support | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
replaces #65042 - as i am still learning the git workflow sorry.
Add multi-domain forest support for win_domain_group_membership by defining the domain of the member if needed:
```
- name: Add a domain user/group from ... | 2019-11-21T07:25:06Z | win_domain_group_membership
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
win_domain_group_membership does not s... | Files identified in the description:
* [`lib/ansible/modules/windows/win_domain_group_membership.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_domain_group_membership.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!compo... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nwin_domain_group_membership does not ... | ede62b8ad44c1c5a59373673068eacf7835d7e7c | {
"head_commit": "389a2a3687d28b90722eddf6ee871ecc66548025",
"head_commit_message": "Add multi-domain forest Support\ncloned extra_args so there is no check for credentials needed.\nFixed Formatting\nadded missing extra_args to pure state",
"patch_to_review": "diff --git a/lib/ansible/modules/windows/win_domain_g... | [
{
"diff_hunk": "@@ -39,6 +39,8 @@ if ($null -ne $domain_server) {\n $extra_args.Server = $domain_server\n }\n \n+$name = Get-ADGroup $name @extra_args",
"line": null,
"original_line": 42,
"original_start_line": null,
"path": "lib/ansible/modules/windows/win_domain_group_membership.ps1",
... | fd0194c8a9894fcb23d7a88663bc170e28a5b1fc | diff --git a/changelogs/fragments/65138-Windows_Multidomain_support.yml b/changelogs/fragments/65138-Windows_Multidomain_support.yml
new file mode 100644
index 00000000000000..d4b286d4ec2502
--- /dev/null
+++ b/changelogs/fragments/65138-Windows_Multidomain_support.yml
@@ -0,0 +1,2 @@
+minor_changes:
+- win_group_membe... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-65050@33ed4dd | ansible/ansible | Python | 65,050 | Add passphrase support for luks_device | ##### SUMMARY
This PR implements support for operating on LUKS devices with passphrases. This enables users to use the `luks_device` module without having to write their passphrase to disk beforehand.
Fixes #52408
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
luks_device | 2019-11-19T10:28:19Z | luks_device: allow to pass keys as text (as opposed to keyfiles)
##### SUMMARY
It would be nice if one could specify the keys directly as content, without having to first write them to disk to use them as keyfiles.
##### ISSUE TYPE
- Feature Idea
##### COMPONENT NAME
luks_device | Files identified in the description:
* [lib/ansible/modules/crypto/luks_device.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/crypto/luks_device.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for ... | [
{
"body": "##### SUMMARY\r\nIt would be nice if one could specify the keys directly as content, without having to first write them to disk to use them as keyfiles.\r\n\r\n##### ISSUE TYPE\r\n- Feature Idea\r\n\r\n##### COMPONENT NAME\r\nluks_device\r\n",
"number": 52408,
"title": "luks_device: allow to ... | 784e5076711620c49097b9f27f9de4c9ea98c950 | {
"head_commit": "33ed4dd80d0ba2fac346d3082d9858bf785a6b1d",
"head_commit_message": "Elevate privileges for luks_device integration tests\n\nSeveral tests in `key-management.yml` don't `become` before executing,\ndespite needing elevated privileges. This commit fixes that.",
"patch_to_review": "diff --git a/test... | [
{
"diff_hunk": "@@ -72,15 +82,26 @@\n new_keyfile:\n description:\n - \"Adds additional key to given container on I(device).\n- Needs I(keyfile) option for authorization. LUKS container\n- supports up to 8 keys. Parameter value is the path\n- to the... | e26ef8780c8efce70d0991d139dda39e44592c94 | diff --git a/changelogs/fragments/52408-luks-device.yaml b/changelogs/fragments/52408-luks-device.yaml
new file mode 100644
index 00000000000000..3ab3b8d6a357a0
--- /dev/null
+++ b/changelogs/fragments/52408-luks-device.yaml
@@ -0,0 +1,2 @@
+minor_changes:
+ - luks_device - accept ``passphrase``, ``new_passphrase`` an... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-64997@dd03fc9 | ansible/ansible | Python | 64,997 | win_disk_facts - Set output array order to be by disk number property | ##### SUMMARY
Not really a bug but not a feature either.
Fixes #63998
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
win_disk_facts.ps1
##### ADDITIONAL INFORMATION
| 2019-11-18T14:00:10Z | Order of elements in ansible_facts['disks'] array does not match actual disk order
##### SUMMARY
On a system with multiple disks, ansible_facts['disks'][0] is not guaranteed to be the first disk.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
win_disk_facts
##### ANSIBLE VERSION
<!--- Paste verbatim ou... | Files identified in the description:
* [`lib/ansible/modules/windows/win_disk_facts.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_disk_facts.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click... | [
{
"body": "##### SUMMARY\r\nOn a system with multiple disks, ansible_facts['disks'][0] is not guaranteed to be the first disk.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nwin_disk_facts\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quot... | 9e92668d4fc9bb0eeceeb241e2be95c05b18362d | {
"head_commit": "dd03fc901abbf431924252c80b624792cd0413cb",
"head_commit_message": "win_disk_facts - Set output array order to be by disk number property - https://github.com/ansible/ansible/issues/63998",
"patch_to_review": "diff --git a/changelogs/fragments/win_disk_facts-Set-output-array-order-by-disk-number.... | [
{
"diff_hunk": "@@ -244,5 +244,8 @@ foreach ($disk in $disks) {\n $result.ansible_facts.ansible_disks += $disk_info\n }\n \n+# Sort by disk number property\n+$result.ansible_facts.ansible_disks = @() + ($result.ansible_facts.ansible_disks | Sort-Object -Property Number)",
"line": null,
"original_lin... | 8480fd38e952329e38f6c7cfd63405fe2a5e9e6d | diff --git a/changelogs/fragments/win_disk_facts-Set-output-array-order-by-disk-number.yml b/changelogs/fragments/win_disk_facts-Set-output-array-order-by-disk-number.yml
new file mode 100644
index 00000000000000..fecf703047d5d5
--- /dev/null
+++ b/changelogs/fragments/win_disk_facts-Set-output-array-order-by-disk-numb... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-65021@f63c26e | ansible/ansible | Python | 65,021 | Add aws elb multiple host header support | ##### SUMMARY
Adds support of multiple host header values. This allows elb rules to look for the existence of multiple host-headers associated with a particular elb rule.
- Removes a print statement that caused incorrectly formatted JSON to be returned
- Casts a string as an integer in rule priority comparison
- ... | 2019-11-18T21:58:01Z | AWS Application Load Balancer Fails with Multiple Host Headers
##### SUMMARY
When using the `host-header` condition for a load balancer rule if there are multiple values for the host header ansible fails to apply the changes with broken json output.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
elbv2
#... | Files identified in the description:
* [`lib/ansible/module_utils/aws/elbv2.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/aws/elbv2.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot he... | [
{
"body": "##### SUMMARY\r\nWhen using the `host-header` condition for a load balancer rule if there are multiple values for the host header ansible fails to apply the changes with broken json output.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nelbv2\r\n\r\n##### ANSIBLE VERSION\r\n``... | 7d4800deb12c0b2894b0715065e1e0ab4caea99f | {
"head_commit": "f63c26e4f295d24fb9f5ee022708f1e87c4225e9",
"head_commit_message": "Add missing quote",
"patch_to_review": "diff --git a/lib/ansible/module_utils/aws/elbv2.py b/lib/ansible/module_utils/aws/elbv2.py\nindex 1a197c8e0b3cbe..0e4a5cd7ec700e 100644\n--- a/lib/ansible/module_utils/aws/elbv2.py\n+++ b/l... | [
{
"diff_hunk": "@@ -117,6 +117,81 @@\n that:\n - alb.changed\n - alb.listeners[0].rules|length == 3\n+ - name:\n+ debug:\n+ msg: \"{{ alb }}\"",
"line": null,
"original_line": 122,
"original_start_line": 120,
"path": "test/integration/targets/elb_application_lb/tas... | 9f66c5311f839e81360a3118b4070b5609be44a1 | diff --git a/lib/ansible/module_utils/aws/elbv2.py b/lib/ansible/module_utils/aws/elbv2.py
index 1a197c8e0b3cbe..0e4a5cd7ec700e 100644
--- a/lib/ansible/module_utils/aws/elbv2.py
+++ b/lib/ansible/module_utils/aws/elbv2.py
@@ -720,7 +720,7 @@ def _compare_condition(self, current_conditions, condition):
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-64401@37fe297 | ansible/ansible | Python | 64,401 | unsafe wrapping should only happen for with_ loops | ##### SUMMARY
unsafe wrapping should only happen for `with_` lookp. Fixes #64379. Addresses #64169
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/executor/task_executor.py
##### ADDITIONAL INFORMATION
cc @geerlingguy | 2019-11-04T17:34:23Z | [2.9] Iterating over a list of hashes with variables doesn't work
##### SUMMARY
<!--- Explain the problem briefly below -->
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
loop
##### ANSIBLE VERSION
<!--- Paste verbatim output from "ansible --version" between quotes -->
```ansible 2.9.0
config file ... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
seems relate... | [
{
"body": "##### SUMMARY\r\n<!--- Explain the problem briefly below -->\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nloop\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes -->\r\n```ansible 2.9.0\r\n config file = /Users/ansible.cfg\... | 8528fbc79091f4aedd5a831318dcc876d48862d5 | {
"head_commit": "37fe2977a286c3007a9c870f16dd81184219a8f0",
"head_commit_message": "typo in changelog fragment",
"patch_to_review": "diff --git a/changelogs/fragments/64379-no-loop-unsafe.yml b/changelogs/fragments/64379-no-loop-unsafe.yml\nnew file mode 100644\nindex 00000000000000..0ec21f4e02e42e\n--- /dev/nul... | [
{
"diff_hunk": "@@ -0,0 +1,5 @@\n+bugfixes:\n+- loops - Do not indiscrimiately mark loop items as unsafe, only apply unsafe",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "changelogs/fragments/64379-no-loop-unsafe.yml",
"start_line": null,
"text": "@user1:\n```s... | 0d76ddb7905cc5d34f55568c61f442a3bb992668 | diff --git a/changelogs/fragments/64379-no-loop-unsafe.yml b/changelogs/fragments/64379-no-loop-unsafe.yml
new file mode 100644
index 00000000000000..5b00b0915b4e76
--- /dev/null
+++ b/changelogs/fragments/64379-no-loop-unsafe.yml
@@ -0,0 +1,5 @@
+bugfixes:
+- loops - Do not indiscriminately mark loop items as unsafe, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-64986@db3ff07 | ansible/ansible | Python | 64,986 | zabbix_host, interface.port parameter is a string | ##### SUMMARY
interface.port should be an string to be able to use macros in that
value.
This fixes the case when interface.port is a macro (eg.: "{$MACRO}" and
force=false.
Because, until now, setting the interface.port to an integer was the
correct way to work with force=false, a type validation has been adde... | 2019-11-18T10:06:58Z | zabbix_host: cannot update host with port set to usermacro
##### SUMMARY
If a host has port set to a usermacro, the host is created successfully. On the next run, the update fails with `ValueError: invalid literal for int() with base 10: {$MACRO}`.
Tested with the latest `zabbix_host` from git.
##### ISSUE TYPE
... | Files identified in the description:
* [`lib/ansible/modules/monitoring/zabbix/zabbix_host.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/monitoring/zabbix/zabbix_host.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot co... | [
{
"body": "##### SUMMARY\r\nIf a host has port set to a usermacro, the host is created successfully. On the next run, the update fails with `ValueError: invalid literal for int() with base 10: {$MACRO}`.\r\n\r\nTested with the latest `zabbix_host` from git.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### C... | 1df62f129aef57327b84978916612fb25369d392 | {
"head_commit": "db3ff07a57379fa9413beb9a1a006d44737af1fd",
"head_commit_message": "zabbix_host, interface.port parameter is a string\n\ninterface.port should be an string to be able to use macros in that\nvalue.\nThis fixes the case when interface.port is a macro (eg.: \"{$MACRO}\" and\nforce=false.\n\nBecause, u... | [
{
"diff_hunk": "@@ -780,6 +780,8 @@ def main():\n interface['ip'] = ''\n if 'main' not in interface:\n interface['main'] = 0\n+ if 'port' in interface and not isinstance(interface['port'], str):\n+ module.fail_json(msg=\"port should be an str... | 55d3021888b81ed39b1960c6f5fed39abc2c88f1 | diff --git a/lib/ansible/modules/monitoring/zabbix/zabbix_host.py b/lib/ansible/modules/monitoring/zabbix/zabbix_host.py
index 0454591bb09abe..97ca36719979d9 100644
--- a/lib/ansible/modules/monitoring/zabbix/zabbix_host.py
+++ b/lib/ansible/modules/monitoring/zabbix/zabbix_host.py
@@ -252,13 +252,13 @@
useip:... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-64477@4d23181 | ansible/ansible | Python | 64,477 | add new command SetManagerNic in redfish_config module | ##### SUMMARY
add SetManagerNic in redfish_config module to set Manager NIC configuration.
Fixes #64475
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
redfish_config
##### ADDITIONAL INFORMATION
none | 2019-11-06T02:48:53Z | redfish_config - Manager - SetManagerNic
##### SUMMARY
This feature would implement a SetManagerNic command for the Manager category of redfish_config, to update Manager NIC configuration.
##### ISSUE TYPE
- Feature Idea
##### COMPONENT NAME
redfish_config
##### ADDITIONAL INFORMATION
This command would h... | Files identified in the description:
* [`lib/ansible/modules/remote_management/redfish/redfish_config.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/remote_management/redfish/redfish_config.py)
If these files are inaccurate, please update the `component name` section of the description or use t... | [
{
"body": "##### SUMMARY\r\nThis feature would implement a SetManagerNic command for the Manager category of redfish_config, to update Manager NIC configuration. \r\n\r\n##### ISSUE TYPE\r\n- Feature Idea\r\n\r\n##### COMPONENT NAME\r\nredfish_config\r\n\r\n##### ADDITIONAL INFORMATION\r\nThis command would hel... | 8c0ab43f050e65a34d404cff196c0d057fff9864 | {
"head_commit": "4d23181231a853fea2cbe61b87d0c73e44e6f7f9",
"head_commit_message": "add new command SetManagerNic in redfish_config module",
"patch_to_review": "diff --git a/lib/ansible/module_utils/redfish_utils.py b/lib/ansible/module_utils/redfish_utils.py\nindex 97bbf30d7defa1..a3bcb9284acf09 100644\n--- a/l... | [
{
"diff_hunk": "@@ -2263,3 +2263,91 @@ def get_manager_health_report(self, manager_uri):\n \n def get_multi_manager_health_report(self):\n return self.aggregate_managers(self.get_manager_health_report)\n+\n+ def set_manager_nic(self, nic_addr, nic_config):\n+ # Get EthernetInterface collec... | db0c39c2b4bc2440cbf9c5bbbd9995ab9a73a6f7 | diff --git a/lib/ansible/module_utils/redfish_utils.py b/lib/ansible/module_utils/redfish_utils.py
index 97bbf30d7defa1..20e02a836150c7 100644
--- a/lib/ansible/module_utils/redfish_utils.py
+++ b/lib/ansible/module_utils/redfish_utils.py
@@ -2263,3 +2263,92 @@ def get_manager_health_report(self, manager_uri):
d... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-63945@976672d | ansible/ansible | Python | 63,945 | Refactor CLI prompt mode check for network plugins |
##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
* Move the CLI prompt mode check logic from action plugin
to the controller side with the cliconf plugins.
* This refactor also allows the network modules
to initialize the persistent connection with the remote ... | 2019-10-25T09:55:55Z | cli_{config, command} modules don't inspect current cli context
##### SUMMARY
- Unlike platform specific modules, cli_command and cli_config modules don't use `action/{{ network_os }}.py` to inspect the current prompt and handle cli context switching from configuration mode to priv exec mode when required.
##### IS... | Files identified in the description:
* [lib/ansible/modules/network/cli/cli_command.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/cli/cli_command.py)
* [lib/ansible/modules/network/cli/cli_config.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/cli/cli_config... | [
{
"body": "##### SUMMARY\r\n- Unlike platform specific modules, cli_command and cli_config modules don't use `action/{{ network_os }}.py` to inspect the current prompt and handle cli context switching from configuration mode to priv exec mode when required.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### C... | e82d407fa8de3a87ae885e35be81936f9c546c99 | {
"head_commit": "976672df73fcb81828f4d4ee8150b85b9a51388c",
"head_commit_message": "Refactor CLI prompt mode check for network plugins\n\n* Move the CLI prompt mode check logic from action plugin\n to the controller side with the cliconf plugins.\n\n* This refactor also allows the network modules\n to initia... | [
{
"diff_hunk": "@@ -85,3 +86,12 @@ def get(self, command, prompt=None, answer=None, sendonly=False, newline=True, c\n def get_capabilities(self):\n result = super(Cliconf, self).get_capabilities()\n return json.dumps(result)\n+\n+ @property",
"line": null,
"original_line": 90,
... | c5856303980ff3f6f2855b536ee03cabc9649e4c | diff --git a/lib/ansible/cli/scripts/ansible_connection_cli_stub.py b/lib/ansible/cli/scripts/ansible_connection_cli_stub.py
index 1f04039329b642..20bfc6b3a8b934 100755
--- a/lib/ansible/cli/scripts/ansible_connection_cli_stub.py
+++ b/lib/ansible/cli/scripts/ansible_connection_cli_stub.py
@@ -305,8 +305,9 @@ def main(... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-63938@8d59da8 | ansible/ansible | Python | 63,938 | VMware Inventory Fixes | ##### SUMMARY
This fixes #63936 and #63937
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/plugins/inventory/vmware_vm_inventory.py
##### ADDITIONAL INFORMATION
The verify file method was removed because it is already implemented by the auto plugin and the current one prevented th... | 2019-10-25T03:03:07Z | VMware inventory not loaded by auto plugin
##### SUMMARY
The vmware_vm_inventory plugin cannot verify the inventory file when being loaded via the auto plugin
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
lib/ansible/plugins/inventory/vmware_vm_inventory.py
##### ANSIBLE VERSION
```paste below
ansibl... | Files identified in the description:
* [`lib/ansible/modules/cloud/vmware/_vmware_category_facts.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/vmware/_vmware_category_facts.py)
* [`lib/ansible/modules/cloud/vmware/_vmware_host_service_facts.py`](https://github.com/ansible/ansible/blob/dev... | [
{
"body": "##### SUMMARY\r\nThe vmware_vm_inventory plugin cannot verify the inventory file when being loaded via the auto plugin\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nlib/ansible/plugins/inventory/vmware_vm_inventory.py\r\n\r\n##### ANSIBLE VERSION\r\n```paste below\r\nansible ... | e60cdc310d5344c00b4f49c9f7dde78d206b25ae | {
"head_commit": "8d59da87e5da40c0dee1a149d05f87883f73f50b",
"head_commit_message": "fix #63936 #63937",
"patch_to_review": "diff --git a/lib/ansible/plugins/inventory/vmware_vm_inventory.py b/lib/ansible/plugins/inventory/vmware_vm_inventory.py\nindex 0ba36d83331a7e..f76a8de797f827 100644\n--- a/lib/ansible/plug... | [
{
"diff_hunk": "@@ -31,12 +31,12 @@\n description: Name of vCenter or ESXi server.\n required: True\n env:\n- - name: VMWARE_SERVER\n+ - name: VMWARE_HOST\n username:\n description: Name of vSphere admin user.\n requir... | 7326f5710e08b55ad87a9982371b6a4f4e663ef3 | diff --git a/lib/ansible/plugins/inventory/vmware_vm_inventory.py b/lib/ansible/plugins/inventory/vmware_vm_inventory.py
index 0ba36d83331a7e..bd8e4d2ad8fe84 100644
--- a/lib/ansible/plugins/inventory/vmware_vm_inventory.py
+++ b/lib/ansible/plugins/inventory/vmware_vm_inventory.py
@@ -16,7 +16,7 @@
- Abhijeet K... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-63650@958dd17 | ansible/ansible | Python | 63,650 | nxos_vlans: fix rmb behaviors and tests | ##### SUMMARY
`nxos_vlans` had several failed behaviors and did not work properly on all nxos platforms.
- facts detection was not working correctly; e.g. when the device cli showed `vlan 1,3-5` the module was only reporting information for vlans 3 and 5.
- The `deleted`, `replaced`, and `overridden` states were ... | 2019-10-17T21:22:56Z | nxos_vlans dies with TypeError: 'NoneType' object has no attribute '__getitem__'
##### SUMMARY
Attempting to rewrite playbooks with nxos_vlan*s*, in 2.9 "preview" RPM, but failing instantly.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
nxos_vlans
##### ANSIBLE VERSION
```
ansible 2.9.0rc4
config ... | [
{
"body": "##### SUMMARY\r\nAttempting to rewrite playbooks with nxos_vlan*s*, in 2.9 \"preview\" RPM, but failing instantly.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nnxos_vlans\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.9.0rc4\r\n config file = /etc/ansible/ansible.cfg\r\n ... | a129499cf48a859fefe5f289d107c6a8bfc535dd | {
"head_commit": "958dd1704e9b1d6b205cd1704176138ad791f557",
"head_commit_message": "whitespace fixes 2",
"patch_to_review": "diff --git a/lib/ansible/module_utils/network/nxos/config/vlans/vlans.py b/lib/ansible/module_utils/network/nxos/config/vlans/vlans.py\nindex 5bd423c01039a4..20774770f0a501 100644\n--- a/l... | [
{
"diff_hunk": "@@ -90,6 +97,8 @@ def set_config(self, existing_vlans_facts):\n want = []\n if config:\n for w in config:\n+ if w.get('vlan_id') == '1':",
"line": null,
"original_line": 100,
"original_start_line": null,
"path": "lib/ansible/module_utils... | 186ec4207e1cb9dc7f4cad01e9ab2ccd357f2ba9 | diff --git a/lib/ansible/module_utils/network/nxos/config/vlans/vlans.py b/lib/ansible/module_utils/network/nxos/config/vlans/vlans.py
index 5bd423c01039a4..16a8cfa856adb4 100644
--- a/lib/ansible/module_utils/network/nxos/config/vlans/vlans.py
+++ b/lib/ansible/module_utils/network/nxos/config/vlans/vlans.py
@@ -34,8 ... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
ansible__ansible-63547@a149e92 | ansible/ansible | Python | 63,547 | mysql_variables: add mode parameter | ##### SUMMARY
mysql_variables: add mode parameter
fixes #60119
continues #62060
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
```lib/ansible/modules/database/mysql/mysql_variables.py``` | 2019-10-16T07:52:39Z | Use the ansible mysql_variables to set mysql variables, the variables settings are invalid after restarting mysql
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Describe the new f... | The hope is that the restart database variables do not expire.
Please complete the information in the issue template so we can better understand this issue.
needs_info
!component =lib/ansible/modules/database/mysql/mysql_variables.py
https://github.com/ansible/ansible/issues/60121
cc @Alexander198961 @Andersson007 @... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Describe the new feature/improvement briefly below -->\r\n\r\n##### ISSUE TYPE\r\n- Feature Idea\r\n\r\n##... | c4ce4a6c032a72e98df907de2640311fd2a0e95f | {
"head_commit": "a149e92ed684223e4e0b830708fccbc35d106118",
"head_commit_message": "mysql_variables: add mode parameter, refactoring",
"patch_to_review": "diff --git a/changelogs/fragments/63547-mysql_variables_add_mode_param.yml b/changelogs/fragments/63547-mysql_variables_add_mode_param.yml\nnew file mode 1006... | [
{
"diff_hunk": "@@ -177,27 +222,52 @@ def main():\n else:\n module.fail_json(msg=\"unable to find %s. Exception message: %s\" % (config_file, to_native(e)))\n \n+ mysqlvar_val = None\n+ var_in_mysqld_auto_cnf = None\n+\n mysqlvar_val = getvariable(cursor, mysqlvar)\n if mysqlva... | 247203a226b1fe4a2d17b99dbca13ecb2cfe5071 | diff --git a/changelogs/fragments/63547-mysql_variables_add_mode_param.yml b/changelogs/fragments/63547-mysql_variables_add_mode_param.yml
new file mode 100644
index 00000000000000..3eeb05bda2a85d
--- /dev/null
+++ b/changelogs/fragments/63547-mysql_variables_add_mode_param.yml
@@ -0,0 +1,2 @@
+minor_changes:
+- mysql_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-63546@dd49d3f | ansible/ansible | Python | 63,546 | Bugfix of 23976: mysql_replication - allow to pass empty values to the module's parameters | ##### SUMMARY
Bugfix of #23976: mysql_replication - allow to pass empty values to the module's parameters
fixes #23976
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
```lib/ansible/modules/database/mysql/mysql_replication.py```
| 2019-10-16T07:07:14Z | mysql_replication does not allow setting blank values
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
Module: mysql_replication
##### ANSIBLE VERSION
```
ansible 2.3.0.0
config file = /home/XXX/..../ansible.cfg
configured module search path = Default w/o overrides
python version = 2.7.12+ (defaul... | I've been able to work around this by using strings that consist of a single space. This works okay for the SSL stuff, but I'm not sure that it would work for other fields.
cc @banyek
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
cc @Xyon @bma... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nModule: mysql_replication\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.3.0.0\r\n config file = /home/XXX/..../ansible.cfg\r\n configured module search path = Default w/o overrides\r\n python version = 2.7.12+ (default, Sep 17 201... | c4ce4a6c032a72e98df907de2640311fd2a0e95f | {
"head_commit": "dd49d3f1a364344d02215cd5ebb3a9d59289d3ee",
"head_commit_message": "Bugfix of 23976: mysql_replication - allow to pass blank lines, fix sanity",
"patch_to_review": "diff --git a/changelogs/fragments/63546-mysql_replication_allow_to_pass_empty_values.yml b/changelogs/fragments/63546-mysql_replicat... | [
{
"diff_hunk": "@@ -44,12 +46,13 @@\n master_password: \"{{ replication_pass }}\"\n master_log_file: \"{{ master_status.File }}\"\n master_log_pos: \"{{ master_status.Position }}\"\n+ master_ssl_ca: ' '",
"line": null,
"original_line": 49,
"original_start_line": null,
"path": "tes... | 7e5d47d4db45036e625130aa984940efc38d297f | diff --git a/changelogs/fragments/63546-mysql_replication_allow_to_pass_empty_values.yml b/changelogs/fragments/63546-mysql_replication_allow_to_pass_empty_values.yml
new file mode 100644
index 00000000000000..801bda2f9e912f
--- /dev/null
+++ b/changelogs/fragments/63546-mysql_replication_allow_to_pass_empty_values.yml... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-63126@26093ff | ansible/ansible | Python | 63,126 | VMware: new module vmware_guest_serial_port | ##### SUMMARY
- Fixes #54956
- The ask was to add an option in the vmware_guest itself
- Upon inspection, a serial port can be created in multiple ways and so can be a module in itself
- Therefore, created a new module called vmware_serial_port
##### ISSUE TYPE
- New Module Pull Request
##### COMPONENT ... | 2019-10-04T10:36:41Z | VMware: need an option to attach serial device to the virtual machine
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
Currently the latest documenation doesn't show how to attach a serial... | @Akasurde Can you please check if the feature is there or is it issue in documentation?
@devdil: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.
Here are the items we could not find in your description:
- ansible ver... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nCurrently the latest documenation doesn't show how to attach a serial console to the virtual machine\r\n\r\n####... | b91f452f4f7b120b82305ef95010d49c74e21182 | {
"head_commit": "26093ff91a2cf2fc7d8370e64cc0539faa76859d",
"head_commit_message": "Adding assertions to main.yml\nSigned-off-by: Anusha Hegde",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/vmware/vmware_serial_port.py b/lib/ansible/modules/cloud/vmware/vmware_serial_port.py\nnew file mode 100644\n... | [
{
"diff_hunk": "@@ -0,0 +1,345 @@\n+#!/usr/bin/python\n+# -*- coding: utf-8 -*-\n+\n+# Copyright: (c) 2019, Anusha Hegde <anushah@vmware.com>\n+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)\n+\n+ANSIBLE_METADATA = {'metadata_version': '1.1',\n+ '... | aa3be8d5aa49338793540e5eacaf1a1051802613 | diff --git a/lib/ansible/modules/cloud/vmware/vmware_guest_serial_port.py b/lib/ansible/modules/cloud/vmware/vmware_guest_serial_port.py
new file mode 100644
index 00000000000000..13525621a5e705
--- /dev/null
+++ b/lib/ansible/modules/cloud/vmware/vmware_guest_serial_port.py
@@ -0,0 +1,468 @@
+#!/usr/bin/python
+# -*- ... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-63034@58c2535 | ansible/ansible | Python | 63,034 | dnf - properly handle idempotent removal of wildcard globs | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #62809
Signed-off-by: Adam Miller <admiller@redhat.com>
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Reques... | 2019-10-02T02:25:11Z | dnf (and probly yum) wild-card match remove is not idempotence
##### SUMMARY
When using wild-card in package name to remove, the first run will remove the packages,
but the second run will fail with message `Failed to install some of the specified packages`
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
... | Files identified in the description:
* [`lib/ansible/modules/packaging/os/dnf.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/packaging/os/dnf.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bo... | [
{
"body": "##### SUMMARY\r\nWhen using wild-card in package name to remove, the first run will remove the packages,\r\nbut the second run will fail with message `Failed to install some of the specified packages`\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\n\r\n- dnf\r\n\r\n##### ANSIBL... | d6781a2a5a3b1f35d32bbf5749d4d95fd017d6fe | {
"head_commit": "58c2535d07fb3f28a7b9e13205ca55e7793d0f9a",
"head_commit_message": "dnf - properly handle idempotent removal of wildcard globs\n\nFixes #62809\n\nSigned-off-by: Adam Miller <admiller@redhat.com>",
"patch_to_review": "diff --git a/changelogs/fragments/62809-dnf-wildcard-absent-failure.yml b/change... | [
{
"diff_hunk": "@@ -334,16 +334,29 @@ def is_lockfile_pid_valid(self):\n # https://github.com/ansible/ansible/issues/57189\n return True\n \n- def _sanitize_dnf_error_msg(self, spec, error):\n+ def _sanitize_dnf_error_msg_install(self, spec, error):\n \"\"\"\n For unhandled... | c7421eee9b849bda852d8d5c32bdd0e67191062c | diff --git a/changelogs/fragments/62809-dnf-wildcard-absent-failure.yml b/changelogs/fragments/62809-dnf-wildcard-absent-failure.yml
new file mode 100644
index 00000000000000..a2a3db47465334
--- /dev/null
+++ b/changelogs/fragments/62809-dnf-wildcard-absent-failure.yml
@@ -0,0 +1,3 @@
+---
+minor_changes:
+ - dnf - Pr... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-62465@6fc14c6 | ansible/ansible | Python | 62,465 | Add some documentation about plugins in collections | ##### SUMMARY
Fixes #62231
Add some documentation about things that require FQCN, limitations on inventory caching, and code sharing.
Vars plugin documentation is in #61078. Vars plugins in collections are ignored prior to #61078.
##### ISSUE TYPE
- Docs Pull Request | 2019-09-17T22:57:14Z | Unclear how to use inventory plugins in collections
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain ... | Files identified in the description:
* [`lib/ansible/module_utils/common/collections.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/common/collections.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[cli... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 1b3bf33bdf2530adb3a7cbf8055007acb09b3bb2 | {
"head_commit": "6fc14c635cec62613075fccdf10f6c6d9b000da5",
"head_commit_message": "Clarify plugins that don't work in collections and make sure to use FQCN in examples where necessary",
"patch_to_review": "diff --git a/docs/docsite/rst/dev_guide/developing_collections.rst b/docs/docsite/rst/dev_guide/developing... | [
{
"diff_hunk": "@@ -416,35 +416,7 @@ For example test plugins, see the source code for the `test plugins included wit\n Vars plugins\n ------------\n \n-Vars plugins inject additional variable data into Ansible runs that did not come from an inventory source, playbook, or command line. Playbook constructs like ... | ae4a384890aeb90a523598761ea030da8a8cd4fd | diff --git a/docs/docsite/rst/dev_guide/developing_collections.rst b/docs/docsite/rst/dev_guide/developing_collections.rst
index 58999ede94d6c6..f7db43de1a8f1c 100644
--- a/docs/docsite/rst/dev_guide/developing_collections.rst
+++ b/docs/docsite/rst/dev_guide/developing_collections.rst
@@ -72,7 +72,9 @@ The ``ansible-d... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-62941@271a52b | ansible/ansible | Python | 62,941 | add UpdateUserName and UpdatePasswordPolicy | ##### SUMMARY
add UpdateUserName in redfish_command module to update existed user account's UserName.
add UpdatePasswordPolicy in redfish_command module to set account password policy under AccountService.
Fixes #62937
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
redfish_command
##### AD... | 2019-09-29T07:36:01Z | redfish_command - Accounts - UpdateUserName / UpdatePasswordPolicy
#### SUMMARY
This feature would implement a UpdateUserName command for the Accounts category of redfish_command, to update user name. And also implement a UpdatePasswordPolicy command for the Accounts category of redfish_command to change password poli... | Files identified in the description:
* [`lib/ansible/modules/remote_management/redfish/redfish_command.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/remote_management/redfish/redfish_command.py)
If these files are inaccurate, please update the `component name` section of the description or use... | [
{
"body": "#### SUMMARY\r\nThis feature would implement a UpdateUserName command for the Accounts category of redfish_command, to update user name. And also implement a UpdatePasswordPolicy command for the Accounts category of redfish_command to change password policy.\r\n\r\n##### ISSUE TYPE\r\n- Feature Idea\... | 75dfe6c88aee21b26e86b0aa03dacb07b627c80e | {
"head_commit": "271a52b9e509469492417837004144f995999846",
"head_commit_message": "fix error detected by ansible-test",
"patch_to_review": "diff --git a/lib/ansible/module_utils/redfish_utils.py b/lib/ansible/module_utils/redfish_utils.py\nindex 35eda9aa2d5735..1ade50024400ff 100644\n--- a/lib/ansible/module_ut... | [
{
"diff_hunk": "@@ -259,7 +308,8 @@\n \"PowerGracefulShutdown\", \"PowerReboot\", \"SetOneTimeBoot\"],\n \"Chassis\": [\"IndicatorLedOn\", \"IndicatorLedOff\", \"IndicatorLedBlink\"],\n \"Accounts\": [\"AddUser\", \"EnableUser\", \"DeleteUser\", \"DisableUser\",\n- \"Upda... | c8a7af851a7bdec4fadb45f30af3812384100758 | diff --git a/lib/ansible/module_utils/redfish_utils.py b/lib/ansible/module_utils/redfish_utils.py
index 35eda9aa2d5735..4a71d35e1ec5b7 100644
--- a/lib/ansible/module_utils/redfish_utils.py
+++ b/lib/ansible/module_utils/redfish_utils.py
@@ -987,6 +987,63 @@ def update_user_password(self, user):
return re... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-62442@91f6d21 | ansible/ansible | Python | 62,442 | Account for empty strings when splitting the host pattern | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Filter out empty strings when returning the list of hosts from `split_host_pattern()`.
Fixes #61964
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delet... | 2019-09-17T17:15:14Z | Ansible crashes when `--limit` expression includes superfluous comma
##### SUMMARY
Running ansible with `--limit a,` or `--limit a,,b` or `--limit ,` leads to (when `-vvv` is added)
```
ERROR! Unexpected Exception, this is probably a bug: string index out of range
the full traceback was:
Traceback (most recent c... | Potential fixes:
1. Change https://github.com/ansible/ansible/blob/devel/lib/ansible/inventory/manager.py#L133 to `return [p.strip() for p in patterns if p.strip()]`. Disadvantage: `--limit ,` is equivalent to no limit, which can be confusing. On the other hand, trailing or repeated commas would be simply ignored, w... | [
{
"body": "##### SUMMARY\r\nRunning ansible with `--limit a,` or `--limit a,,b` or `--limit ,` leads to (when `-vvv` is added)\r\n```\r\nERROR! Unexpected Exception, this is probably a bug: string index out of range\r\nthe full traceback was:\r\n\r\nTraceback (most recent call last):\r\n File \".../ansible/bin... | bad338aca6e1434fabc277b882d421f6b6b89617 | {
"head_commit": "91f6d21c09867a01310ea64188561bbd4b2ea647",
"head_commit_message": "Improve tests\n\n- add more unit test cases\n- add specific integration test with more cases",
"patch_to_review": "diff --git a/changelogs/fragments/split-host-pattern-empty-strings.yaml b/changelogs/fragments/split-host-pattern-... | [
{
"diff_hunk": "@@ -129,8 +130,7 @@ def split_host_pattern(pattern):\n )+ # occurring once or more\n '''), pattern, re.X\n )\n-\n- return [p.strip() for p in patterns]\n+ return [p for p in patterns if p]",
"line": null,
"original_line":... | 37bbf1abc2dd75082121f04c075709949ccb54d0 | diff --git a/changelogs/fragments/split-host-pattern-empty-strings.yaml b/changelogs/fragments/split-host-pattern-empty-strings.yaml
new file mode 100644
index 00000000000000..35af0f0e8bde31
--- /dev/null
+++ b/changelogs/fragments/split-host-pattern-empty-strings.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+ - account for empty ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-62419@42a3826 | ansible/ansible | Python | 62,419 | Remove Latin phrases from the docs | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
add styleguide about avoiding use of latin words"
TODO: replace latin words
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
... | 2019-09-17T14:13:57Z | Remove Latin phrases from the docs
##### SUMMARY
Latin words and phrases like `e.g.` or `etc.` are easily understood by native English speakers and speakers of European languages who speak some English. They are harder to understand for speakers of Asian languages who speak some English. They are also tricky for autom... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
Latin words/... | [
{
"body": "##### SUMMARY\r\nLatin words and phrases like `e.g.` or `etc.` are easily understood by native English speakers and speakers of European languages who speak some English. They are harder to understand for speakers of Asian languages who speak some English. They are also tricky for automated translati... | 84d9b3e58986d70ca64539e816e342a9d7d0b888 | {
"head_commit": "42a382651030fec2d767956cb6739062b6c74b50",
"head_commit_message": "remove latin in section community",
"patch_to_review": "diff --git a/docs/docsite/rst/community/committer_guidelines.rst b/docs/docsite/rst/community/committer_guidelines.rst\nindex 5c83718c3e9727..3218cc846ab846 100644\n--- a/do... | [
{
"diff_hunk": "@@ -48,6 +48,30 @@ Header case\n Headers should be written in sentence case. For example, this section's title is\n ``Header case``, not ``Header Case`` or ``HEADER CASE``.\n \n+\n+Avoid using latin phrases\n+-------------------------\n+\n+Latin words and phrases like ``e.g.`` or ``etc.``\n+are ... | 732ead0c7af08cae58c78bf9e5a4d2f006eee630 | diff --git a/docs/docsite/rst/community/committer_guidelines.rst b/docs/docsite/rst/community/committer_guidelines.rst
index 5c83718c3e9727..3218cc846ab846 100644
--- a/docs/docsite/rst/community/committer_guidelines.rst
+++ b/docs/docsite/rst/community/committer_guidelines.rst
@@ -10,12 +10,12 @@ These guidelines appl... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-62373@30950ec | ansible/ansible | Python | 62,373 | become - stop using play context in more places | ##### SUMMARY
There are still a few locations that are getting the become vars from play context and this can miss some options that are become specific, i.e. `ansible_<plugin>_pass` may not work for all plugins as they are defined as a plugin option and not in play context.
There are still some plugins that still ... | 2019-09-16T23:55:12Z | Deprecated variables do not point to the same data
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain t... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
The variable... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | f8f76628500052ad3521fbec16c073ae7f99d287 | {
"head_commit": "30950ec14b548b4ac71ac756c6cb165e9a01f97f",
"head_commit_message": "become - stop using play context in more places - ci_complete",
"patch_to_review": "diff --git a/changelogs/fragments/become-pass-precedence.yaml b/changelogs/fragments/become-pass-precedence.yaml\nnew file mode 100644\nindex 000... | [
{
"diff_hunk": "@@ -298,7 +311,7 @@ def _is_become_unprivileged(self):\n '''\n # if we don't use become then we know we aren't switching to a\n # different unprivileged user\n- if not self._play_context.become:\n+ if self._connection.become is None:",
"line": null,
... | a5a73ca867e4f3fa1c2a1184057af99634f4c17e | diff --git a/changelogs/fragments/become-pass-precedence.yaml b/changelogs/fragments/become-pass-precedence.yaml
new file mode 100644
index 00000000000000..8e21fe24e3668c
--- /dev/null
+++ b/changelogs/fragments/become-pass-precedence.yaml
@@ -0,0 +1,3 @@
+bugfixes:
+- become - Fix various plugins that still used play_... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-62344@d1636f3 | ansible/ansible | Python | 62,344 | Fix network_cli exec_command connection init |
##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes https://github.com/ansible/ansible/issues/61596
* Ensure connection is established before executing
exec_command network_cli connection method which is
invoked from the module code.
<!--- HINT: Include "... | 2019-09-16T09:18:12Z | playbooks using icx_modules that require enable mode fail in stable 2.9 branch but work in 2.8
##### SUMMARY
playbook that require enable mode work in Ansible 2.8 but fail in stable 2.9
##### ISSUE TYPE
When attached playbook is run using ansible-playbook binary in devel branch it fails. But when run with /usr... | Files identified in the description:
* [`lib/ansible/plugins/connection/network_cli.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/connection/network_cli.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click... | [
{
"body": "##### SUMMARY\r\nplaybook that require enable mode work in Ansible 2.8 but fail in stable 2.9 \r\n\r\n\r\n##### ISSUE TYPE\r\nWhen attached playbook is run using ansible-playbook binary in devel branch it fails. But when run with /usr/bin/ansible-playbook (2.8 version) it works fine.\r\n\r\n##### COM... | b4dcd7c835594143b43b36fe3ffb0e139f6fa0dc | {
"head_commit": "d1636f34b2468af6bdc0435afe978054d2043cac",
"head_commit_message": "Fix network_cli exec_command connection init\n\nFixes https://github.com/ansible/ansible/issues/61596\n\n* If `exec_command` method is invoked from module side\n on connection object to execute the command on target\n host che... | [
{
"diff_hunk": "@@ -138,6 +138,10 @@ def run(self):\n if log_messages:\n display.display(\"jsonrpc request: %s\" % data, log_only=True)\n \n+ request = json.loads(to_text(data, errors='surrogate_then_replace'))",
"line": null,
"original_line... | e5a89576059a6a64ec337f057e7545d34082940b | diff --git a/lib/ansible/cli/scripts/ansible_connection_cli_stub.py b/lib/ansible/cli/scripts/ansible_connection_cli_stub.py
index 5a61aa7167419f..487a00a52fc2d7 100755
--- a/lib/ansible/cli/scripts/ansible_connection_cli_stub.py
+++ b/lib/ansible/cli/scripts/ansible_connection_cli_stub.py
@@ -138,6 +138,10 @@ def run(... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-62323@a3e92cf | ansible/ansible | Python | 62,323 | Add examples for various inventory setups to the documentation | Fixes: #12480.
| 2019-09-15T09:49:09Z | Write sample inventory setups
##### ISSUE TYPE
Feature Idea
##### COMPONENT NAME
core
##### ANSIBLE VERSION
2.1
##### CONFIGURATION
##### OS / ENVIRONMENT
##### SUMMARY
Add a few examples of different inventory setups and classifications. Capture a few styles and business needs.
As example use a per environment ... | +1
Can we close this?
we can, but, i still think we should do it
Hi :) Would this be a good ticket for a first-time contributor? Right now it looks like I might have some time available in the next couple of months and would like to work on this 🙂
yes
Thanks :) Will do that then :)
@zerok thanks for offering to pick ... | [
{
"body": "##### ISSUE TYPE\nFeature Idea\n\n##### COMPONENT NAME\ncore\n\n##### ANSIBLE VERSION\n2.1\n\n##### CONFIGURATION\n\n\n##### OS / ENVIRONMENT\n\n\n##### SUMMARY\nAdd a few examples of different inventory setups and classifications. Capture a few styles and business needs.\nAs example use a per enviro... | a0bec0bc327d29f446a031abc803b8d2cad1949f | {
"head_commit": "a3e92cfd5b7c40f214440db5ff11a75932b16d9f",
"head_commit_message": "Add examples for various inventory setups to the documentation. This closes #12480.",
"patch_to_review": "diff --git a/docs/docsite/rst/user_guide/intro_inventory.rst b/docs/docsite/rst/user_guide/intro_inventory.rst\nindex efa71... | [
{
"diff_hunk": "@@ -649,6 +650,92 @@ For a full list with available plugins and examples, see :ref:`connection_plugin\n .. note:: If you're reading the docs from the beginning, this may be the first example you've seen of an Ansible playbook. This is not an inventory file.\n Playbooks will be covered ... | 3aa0b407b9e611c9d94e061771cedc7cac99ac56 | diff --git a/docs/docsite/rst/user_guide/intro_inventory.rst b/docs/docsite/rst/user_guide/intro_inventory.rst
index efa71055b862d8..74711565a7ec5a 100644
--- a/docs/docsite/rst/user_guide/intro_inventory.rst
+++ b/docs/docsite/rst/user_guide/intro_inventory.rst
@@ -141,6 +141,7 @@ You could also use nested groups to s... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-62222@56970a9 | ansible/ansible | Python | 62,222 | [Docs] Document the resource module builder | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Document the network resource module builder
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #61780
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Docs Pull Request
... | 2019-09-12T18:46:04Z | Add documentation for the network resource model builder
<!--- Verify first that your improvement is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!-... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner ---> | [
{
"body": "<!--- Verify first that your improvement is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem brief... | 69522951149f76a36e74f7ca492cea9ecaad903c | {
"head_commit": "56970a9f321e48798f952cf031b4a36605b6f606",
"head_commit_message": "copy-edit fixes",
"patch_to_review": "diff --git a/docs/docsite/rst/network/dev_guide/developing_resource_modules_network.rst b/docs/docsite/rst/network/dev_guide/developing_resource_modules_network.rst\nnew file mode 100644\nind... | [
{
"diff_hunk": "@@ -0,0 +1,379 @@\n+\n+.. _developing_resource_modules:\n+\n+***********************************\n+Developing network resource modules\n+***********************************\n+\n+.. contents::\n+ :local:\n+\n+The resource module builder is an Ansible Playbook that helps developers scaffold and m... | d1cfe2a93702fa87d83331256b3761cb12472941 | diff --git a/docs/docsite/rst/network/dev_guide/developing_resource_modules_network.rst b/docs/docsite/rst/network/dev_guide/developing_resource_modules_network.rst
new file mode 100644
index 00000000000000..09227b63ac6a8d
--- /dev/null
+++ b/docs/docsite/rst/network/dev_guide/developing_resource_modules_network.rst
@@... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-61812@8c69c93 | ansible/ansible | Python | 61,812 | luks_device.py: allows user explicity define luks format version | ##### SUMMARY
Allow user pass an option 'type' that explicits define the version of LUKS container.
- if type is defined and label too, label takes the preference (LUKS2 will be used)
- if type is defined and label not, luks format will use the preference of user.
- if type and label is not defined it will be us... | 2019-09-04T20:12:51Z | Support creating LUKS2 container in luks_device module
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Describe the new feature/improvement briefly below -->
Ansible by default onl... | Files identified in the description:
* [`lib/ansible/modules/crypto/luks_device.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/crypto/luks_device.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here fo... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Describe the new feature/improvement briefly below -->\r\nAnsible by default only creates LUKS1 format dev... | adfaefb7321616da2975c95c87a4973d77aea5c4 | {
"head_commit": "8c69c931095ec09c4106c8b7f6b5f074c87d9f5e",
"head_commit_message": "added the changelog fragment\n\nSigned-off-by: Alexandre Mulatinho <alex@mulatinho.net>",
"patch_to_review": "diff --git a/changelogs/fragments/58973-luks_device_add-type-option.yml b/changelogs/fragments/58973-luks_device_add-ty... | [
{
"diff_hunk": "@@ -115,6 +115,16 @@\n - \"Will only be used when I(device) and I(label) are not specified.\"\n type: str\n version_added: \"2.10\"\n+ type:\n+ description:\n+ - \"This option allow the user explicit define the format of LUKS\n+ conta... | e5a3b7e86b31f63884f44882af7fae1298a91fb4 | diff --git a/changelogs/fragments/58973-luks_device_add-type-option.yml b/changelogs/fragments/58973-luks_device_add-type-option.yml
new file mode 100644
index 00000000000000..78c1458cf568d4
--- /dev/null
+++ b/changelogs/fragments/58973-luks_device_add-type-option.yml
@@ -0,0 +1,2 @@
+minor_changes:
+- luks_device - a... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-61805@9dec0bd | ansible/ansible | Python | 61,805 | Azure _info modules: fix returned ansible_facts when called as _info | ##### SUMMARY
Fixes #61569. Also, `azure_rm_virtualmachinescaleset_info` current always returns an empty result (or `ansible_facts`) when called as `_info` module.
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
azure_rm_dnsrecordset_info
azure_rm_resourcegroup_info
azure_rm_storageaccount_info
... | 2019-09-04T18:42:24Z | Some azure _info modules still return ansible_facts when called as _info
##### SUMMARY
Some of the modules still return something in `ansible_facts`, even though the result in there is an empty list:
- ~~`azure_rm_publicipaddress_info`~~
- ~~`azure_rm_networkinterface_info`~~
- `azure_rm_storageaccount_info`
-... | Files identified in the description:
* [`lib/ansible/modules/cloud/azure/azure_rm_publicipaddress_info.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/azure/azure_rm_publicipaddress_info.py)
* [`lib/ansible/modules/cloud/azure/azure_rm_resourcegroup_info.py`](https://github.com/ansible/ansi... | [
{
"body": "##### SUMMARY\r\nSome of the modules still return something in `ansible_facts`, even though the result in there is an empty list:\r\n - ~~`azure_rm_publicipaddress_info`~~\r\n - ~~`azure_rm_networkinterface_info`~~\r\n - `azure_rm_storageaccount_info`\r\n - `azure_rm_virtualmachineimage_info`\r\n - `... | 4c8407fb83804518df5b14adfd8b8f8ec9b2d6a3 | {
"head_commit": "9dec0bdaf164291d31ed4eecfad73ba56f71b25d",
"head_commit_message": "Adjust PR #.",
"patch_to_review": "diff --git a/changelogs/fragments/61805-azure-facts-info.yml b/changelogs/fragments/61805-azure-facts-info.yml\nnew file mode 100644\nindex 00000000000000..aa04f7e5ca2fe6\n--- /dev/null\n+++ b/c... | [
{
"diff_hunk": "@@ -385,13 +382,11 @@ def exec_module(self, **kwargs):\n 'tags': vmss.get('tags')\n }\n \n- self.results['ansible_facts']['azure_vmss'][index] = updated\n+ result[index] = updated\n \n # proper result format we want to... | 4781bdc008444c256c31ed01c0985fd2443aeb13 | diff --git a/changelogs/fragments/61805-azure-facts-info.yml b/changelogs/fragments/61805-azure-facts-info.yml
new file mode 100644
index 00000000000000..aa04f7e5ca2fe6
--- /dev/null
+++ b/changelogs/fragments/61805-azure-facts-info.yml
@@ -0,0 +1,7 @@
+bugfixes:
+- "azure_rm_dnsrecordset_info - no longer returns empty... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-61245@cefcc74 | ansible/ansible | Python | 61,245 | Deprecate alias 'thirsty' from all usages | Fixes: #61236
##### SUMMARY
Deprecate alias 'thirsty' from all usages
Add handling for a `deprecated_aliases` option in `_handle_aliases` to account for mod_utils arg spec.
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/modules/files/copy.py
lib/ansible/modules/files/iso_extract.p... | 2019-08-23T20:03:26Z | Consider removing `thirsty` alias from the copy module (only the copy module)
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
When I read the `copy` documentation, I couldn't work out wha... | Files identified in the description:
* [`lib/ansible/modules/files/copy.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/files/copy.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](http... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nWhen I read the `copy` documentation, I couldn't work out what it meant. Unfortunately, this meant it sounded l... | fabd912fa5ef4c86592d9d0754317dbef09f4f7e | {
"head_commit": "cefcc742990a83319fd957a594b60d748a40c798",
"head_commit_message": "Handle deprecated aliases in mod_utils",
"patch_to_review": "diff --git a/lib/ansible/module_utils/basic.py b/lib/ansible/module_utils/basic.py\nindex 1e11bea4e58207..fd94843a908800 100644\n--- a/lib/ansible/module_utils/basic.py... | [
{
"diff_hunk": "@@ -1418,6 +1418,7 @@ def url_argument_spec():\n force_basic_auth=dict(type='bool', default=False),\n client_cert=dict(type='path'),\n client_key=dict(type='path'),\n+ deprecated_aliases=dict(alias='thirsty', version='2.13'),",
"line": null,
"original_line"... | 15534bc1352b2daaccd17ff73e3325e84898ab22 | diff --git a/lib/ansible/module_utils/basic.py b/lib/ansible/module_utils/basic.py
index 1e11bea4e58207..ad08cd694f3452 100644
--- a/lib/ansible/module_utils/basic.py
+++ b/lib/ansible/module_utils/basic.py
@@ -1427,6 +1427,18 @@ def _handle_aliases(self, spec=None, param=None, option_prefix=''):
alias_results... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-61777@79528e8 | ansible/ansible | Python | 61,777 | Unify ios_logging documentation with accepted options | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #61547
The documentation of the `name` parameter mentions options not supported by the module. This PR updates the description to remove them... | 2019-09-04T14:42:09Z | _net_logging and ios_logging dest: file
<!--- Verify first that your improvement is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain the pr... | Files identified in the description:
* [`lib/ansible/modules/network/ios/ios_logging.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/ios/ios_logging.py)
* [`lib/ansible/modules/network/system/_net_logging.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/network/syste... | [
{
"body": "<!--- Verify first that your improvement is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem brief... | a795f6941eb50c9e21ff20c297700c1e264223b5 | {
"head_commit": "79528e8bca40d77b457291550884a5829e73ad86",
"head_commit_message": "Unify ios_logging documentation with accepted options",
"patch_to_review": "diff --git a/lib/ansible/modules/network/ios/ios_logging.py b/lib/ansible/modules/network/ios/ios_logging.py\nindex 902c7bf2bdd0e1..efc1592dc76d2a 100644... | [
{
"diff_hunk": "@@ -41,9 +41,8 @@\n choices: ['on', 'host', 'console', 'monitor', 'buffered', 'trap']\n name:\n description:\n- - If value of C(dest) is I(file) it indicates file-name,\n- for I(user) it indicates username and for I(host) indicates\n- the host name to be notified.\n+... | 6a0f27bc5aa4db797cf03c8d40bf5e5e4c5b7436 | diff --git a/lib/ansible/modules/network/eos/eos_logging.py b/lib/ansible/modules/network/eos/eos_logging.py
index 39e45b4e884594..8fc7289f904f56 100644
--- a/lib/ansible/modules/network/eos/eos_logging.py
+++ b/lib/ansible/modules/network/eos/eos_logging.py
@@ -24,11 +24,11 @@
dest:
description:
- Desti... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-61603@5bf662a | ansible/ansible | Python | 61,603 | luks_device.py: Allow manipulate LUKS containers with label or UUID | Per default, on newer versions, cryptsetup creates LUKS containers with VERSION 2 format, but with this change it allow user create containers with `LABEL` identifier as requested on #58973 expliciting `LUKS2` format. It also allow manipulation of LUKS containers with `UUID`
- Allow create a LUKS2 container format w... | 2019-08-30T13:58:25Z | Support creating LUKS2 container in luks_device module
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Describe the new feature/improvement briefly below -->
Ansible by default onl... | Files identified in the description:
* [`lib/ansible/modules/crypto/luks_device.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/crypto/luks_device.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here fo... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Describe the new feature/improvement briefly below -->\r\nAnsible by default only creates LUKS1 format dev... | de6e2de0c461d0ed0d3d8c8cf93ea691f31376ce | {
"head_commit": "5bf662ade6b9839ae16595ba69c895aaaed950b3",
"head_commit_message": "test_luks_device.py: organizing tests to support labels\n\n- Add label on some tests and fix errors reported by Shippable\n\nSigned-off-by: Alexandre Mulatinho <alex@mulatinho.net>",
"patch_to_review": "diff --git a/lib/ansible/m... | [
{
"diff_hunk": "@@ -100,11 +100,29 @@\n the container can no longer be opened!\"\n type: bool\n default: no\n+ label:\n+ description:\n+ - \"This option allow the user to create a LUKS2 format container\n+ with label support, respectively to identi... | f4d6e2f7dafef4b2915c80854735bd7affc35427 | diff --git a/changelogs/fragments/58973_luks_device-add-label-and-uuid-support.yml b/changelogs/fragments/58973_luks_device-add-label-and-uuid-support.yml
new file mode 100644
index 00000000000000..a8a26030949e30
--- /dev/null
+++ b/changelogs/fragments/58973_luks_device-add-label-and-uuid-support.yml
@@ -0,0 +1,2 @@
+... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-60622@19d2ad7 | ansible/ansible | Python | 60,622 | docker_image_info: improve docs | ##### SUMMARY
Fixes #60605. Improves docs on return value and how to check for local image existence.
##### ISSUE TYPE
- Docs Pull Request
##### COMPONENT NAME
docker_image_info
| 2019-08-15T05:00:33Z | docker_image_info does not pull image automatically
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain ... | Files identified in the description:
* [`lib/ansible/modules/cloud/docker/docker_container_info.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/docker/docker_container_info.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!compone... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | c2160274c66831c29e5543e9acdee3051d694e82 | {
"head_commit": "19d2ad71815c48ec5177053a868b5def6b670d33",
"head_commit_message": "Improve example.",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/docker/docker_image_info.py b/lib/ansible/modules/cloud/docker/docker_image_info.py\nindex c1027162d5c1c3..dab9d19abb67b4 100644\n--- a/lib/ansible/mod... | [
{
"diff_hunk": "@@ -22,6 +22,11 @@\n \n description:\n - Provide one or more image names, and the module will inspect each, returning an array of inspection results.\n+ - Non-existing images will not be added to the result list. I.e. if you want to check whether an image exists\n+ locally, you ca... | 0be7822a0d2a5243099872b7ef8eedbffba93a88 | diff --git a/lib/ansible/modules/cloud/docker/docker_image_info.py b/lib/ansible/modules/cloud/docker/docker_image_info.py
index c1027162d5c1c3..306213dbcdbda3 100644
--- a/lib/ansible/modules/cloud/docker/docker_image_info.py
+++ b/lib/ansible/modules/cloud/docker/docker_image_info.py
@@ -22,6 +22,11 @@
description... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-60741@3c62089 | ansible/ansible | Python | 60,741 | openssl_certificate/csr(_info): add support for SubjectKeyIdentifier and AuthorityKeyIdentifier | ##### SUMMARY
Adds support for the `SubjectKeyIdentifier` and `AuthorityKeyIdentifier` extensions to the `openssl_certificate*` and `openssl_csr*` modules.
NOTE: since pyOpenSSL doesn't directly support the extensions, I decided to **only** add support for this for the cryptography backend. Adding support for the p... | 2019-08-18T07:02:09Z | In openssl csr & cert modules add support for v3 key identifier extensions
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
As a user, I'd like to supply the subjectKeyIdentifier and autho... | Files identified in the description:
* [lib/ansible/modules/crypto/openssl_certificate.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/crypto/openssl_certificate.py)
* [lib/ansible/modules/crypto/openssl_csr.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/crypto/openssl_csr.p... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nAs a user, I'd like to supply the subjectKeyIdentifier and authorityKeyIdentifier openssl v3 extensions when gen... | 0d88ec241fd6c24cd6194b4fa477a8478c7e4cbd | {
"head_commit": "3c620893662212e520c00938f49ee741be22cd21",
"head_commit_message": "Apparently the function call expected different args for cryptography < 2.7.",
"patch_to_review": "diff --git a/changelogs/fragments/60741-openssl-cert-csr-key-identifier.yml b/changelogs/fragments/60741-openssl-cert-csr-key-iden... | [
{
"diff_hunk": "@@ -238,10 +238,45 @@\n or not.\n returned: success\n type: dict\n+subject_key_identifier:\n+ description:\n+ - The CSR's subject key identifier.\n+ - The identifier is returned in hexadecial, with C(:) used to separate bytes.\n+ - Is C(none) if t... | fb21ea3bddd84efc408cb8719378acff61dac51e | diff --git a/changelogs/fragments/60741-openssl-cert-csr-key-identifier.yml b/changelogs/fragments/60741-openssl-cert-csr-key-identifier.yml
new file mode 100644
index 00000000000000..8d20b711a02aab
--- /dev/null
+++ b/changelogs/fragments/60741-openssl-cert-csr-key-identifier.yml
@@ -0,0 +1,6 @@
+minor_changes:
+- "op... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-60572@896fb60 | ansible/ansible | Python | 60,572 | Ensure k8s apply works with check mode | ##### SUMMARY
Update the new predicted object with fields from the previous object
before applying in check mode
Don't log output of `file` with `state: absent` on huge virtualenvs!
Fixes #60510
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
module_utils/k8s/raw.py | 2019-08-14T13:24:39Z | k8s module shows diff changes for metadata added by default when we changed nothing
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
... | Files identified in the description:
* [`lib/ansible/modules/clustering/k8s/k8s.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/clustering/k8s/k8s.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here fo... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nUsing the k8s module running in --che... | e4d4e49388770fcc4c39bbba4fddfb343f41b099 | {
"head_commit": "896fb60d7563b7a8393e011a22cd687464137bb1",
"head_commit_message": "Add changelog fragment for k8s apply check mode fix",
"patch_to_review": "diff --git a/changelogs/fragments/60510-k8s-apply-check-mode.yml b/changelogs/fragments/60510-k8s-apply-check-mode.yml\nnew file mode 100644\nindex 0000000... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+minor_bugfixes:",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "changelogs/fragments/60510-k8s-apply-check-mode.yml",
"start_line": null,
"text": "@user1:\n```suggestion\r\nbugfixes:\r\n```\r\nThere's `bugfixes` and `minor_chang... | 462113b6d280dd6c196ae668d0f3765fc17bc13a | diff --git a/changelogs/fragments/60510-k8s-apply-check-mode.yml b/changelogs/fragments/60510-k8s-apply-check-mode.yml
new file mode 100644
index 00000000000000..b71c115a4cedde
--- /dev/null
+++ b/changelogs/fragments/60510-k8s-apply-check-mode.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - k8s - ensure that apply works with chec... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-60553@3c0bac0 | ansible/ansible | Python | 60,553 | ansible-galaxy - define multiple galaxy instances in ansible.cfg | ##### SUMMARY
Add the ability to specify multiple galaxy servers in a configuration file for install. Also add a way to reference a server with authentication in the `requirements.yml`. I still am in the middle of manually testing a few scenarios but this should be enough to get people going.
Fixes https://github.c... | 2019-08-14T06:01:02Z | ansible-galaxy collections install -r requirements.yml to support multiple servers
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
Currently, a single api-server must be specified per `an... | Files identified in the description:
* [`lib/ansible/galaxy`](https://github.com/ansible/ansible/blob/devel/lib/ansible/galaxy)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibul... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nCurrently, a single api-server must be specified per `ansible-galaxy` invocation via `ansible-galaxy --server my... | c2160274c66831c29e5543e9acdee3051d694e82 | {
"head_commit": "3c0bac0b7f97effa5bd695d798ee4dc47d2b2dcb",
"head_commit_message": "Fix bugs after testing",
"patch_to_review": "diff --git a/docs/docsite/rst/dev_guide/collections_tech_preview.rst b/docs/docsite/rst/dev_guide/collections_tech_preview.rst\nindex d902f156b4e5e7..178198fba93858 100644\n--- a/docs/... | [
{
"diff_hunk": "@@ -1123,6 +1123,7 @@ def open(self, method, url, data=None, headers=None, use_proxy=None,\n :kwarg unix_socket: (optional) String of file system path to unix socket file to use when establishing\n connection to the provided url\n :kwarg ca_path: (optional) String of ... | eafcb6c0fd416c8e0c56a86483edfb691eb167ea | diff --git a/docs/docsite/rst/dev_guide/collections_tech_preview.rst b/docs/docsite/rst/dev_guide/collections_tech_preview.rst
index d902f156b4e5e7..4c29eff160c288 100644
--- a/docs/docsite/rst/dev_guide/collections_tech_preview.rst
+++ b/docs/docsite/rst/dev_guide/collections_tech_preview.rst
@@ -375,6 +375,74 @@ You ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-60496@03fef0a | ansible/ansible | Python | 60,496 | win_domain reboot required exception incorrectly reported | ##### SUMMARY
If the module fails because a reboot is pending it is stated in the exception message, but reboot_required is still false.
Fixes: #60493
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
win_domain
##### ADDITIONAL INFORMATION
```
fatal: [****-****]: FAILED! => {
"changed... | 2019-08-13T14:21:18Z | win_domain reboot required exception incorrectly reported
##### SUMMARY
If the module fails because a reboot is pending it is stated in the exception message, but reboot_required is still false.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
win_domain
##### ANSIBLE VERSION
```paste below
ansible 2.9.... | Files identified in the description:
* [`lib/ansible/modules/windows/win_domain.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_domain.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here fo... | [
{
"body": "##### SUMMARY\r\nIf the module fails because a reboot is pending it is stated in the exception message, but reboot_required is still false.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nwin_domain\r\n\r\n##### ANSIBLE VERSION\r\n```paste below\r\nansible 2.9.0.dev0\r\n confi... | 6b5c7f7c42874d65762c0a4dd83a2d990e3d2db4 | {
"head_commit": "03fef0ac33d89a6d31eedf45546e520b649806ef",
"head_commit_message": "Set reboot required dependent on exception message.",
"patch_to_review": "diff --git a/lib/ansible/modules/windows/win_domain.ps1 b/lib/ansible/modules/windows/win_domain.ps1\nindex de31134ba7de77..998eda0d50125e 100644\n--- a/li... | [
{
"diff_hunk": "@@ -127,6 +127,9 @@ if (-not $forest) {\n if ($_.Exception.ExitCode -eq 15) {\n $result.reboot_required = $true\n } else {\n+ if ($_.Exception.Message.Contains(\"A reboot is required.\")) {",
"line": null,
"original_line": 130,
"original_start_l... | f9288a6b2ac6291170a8f99ad9ea1e3fec38448f | diff --git a/lib/ansible/modules/windows/win_domain.ps1 b/lib/ansible/modules/windows/win_domain.ps1
index de31134ba7de77..546799b7063d8f 100644
--- a/lib/ansible/modules/windows/win_domain.ps1
+++ b/lib/ansible/modules/windows/win_domain.ps1
@@ -124,10 +124,10 @@ if (-not $forest) {
} catch [Microsoft.DirectorySe... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-60425@aeb58ee | ansible/ansible | Python | 60,425 | Fix Gitlab module deprecation warning | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fix and enchance deprecation warning for gitlab modules.
Also fix `required` parameters that should not be required.
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #59976
##### ISSUE TY... | 2019-08-12T15:05:23Z | gitlab_runner module: Misleading deprecation warnings in Ansible 2.8
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMAR... | Files identified in the description:
* [`lib/ansible/modules/source_control/gitlab_runner.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/source_control/gitlab_runner.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot comm... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nThe gitlab_runner module throws depre... | 022335669cc1732939cc609f8dcdc5ad75a42439 | {
"head_commit": "aeb58ee93bb3a5b24dc1ba921d2b8028cc0c5324",
"head_commit_message": "gitlab modules : Fix deprecation warnings and parameters\n\nAlso preparing for 2.10 deprecation",
"patch_to_review": "diff --git a/lib/ansible/modules/source_control/gitlab_deploy_key.py b/lib/ansible/modules/source_control/gitla... | [
{
"diff_hunk": "@@ -241,7 +241,9 @@ def deleteDeployKey(self):\n def deprecation_warning(module):\n deprecated_aliases = ['private_token', 'access_token']\n \n- module.deprecate(\"Aliases \\'{aliases}\\' are deprecated\".format(aliases='\\', \\''.join(deprecated_aliases)), \"2.10\")\n+ for aliase in d... | 3303b264bdd793a347efc5cc3957e2728173161e | diff --git a/lib/ansible/modules/source_control/gitlab_deploy_key.py b/lib/ansible/modules/source_control/gitlab_deploy_key.py
index d7bc52d9ab95f8..598c57eba72d64 100644
--- a/lib/ansible/modules/source_control/gitlab_deploy_key.py
+++ b/lib/ansible/modules/source_control/gitlab_deploy_key.py
@@ -241,7 +241,9 @@ def d... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-60388@91f4bee | ansible/ansible | Python | 60,388 | openssl_privatekey: add support for format option | ##### SUMMARY
Fixes #59253.
~~WIP since some things are missing:~~
* ~~idempotency~~
* ~~integration tests~~
##### ISSUE TYPE
- New Feature Pull Request
##### COMPONENT NAME
openssl_privatekey
| 2019-08-11T14:25:45Z | Allow to select openssl_privatekey format
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
Allow to specify a new "format" parameter in "openssl_privatekey". Today the output format is dec... | Files identified in the description:
* [`lib/ansible/modules/crypto/openssl_privatekey.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/crypto/openssl_privatekey.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nAllow to specify a new \"format\" parameter in \"openssl_privatekey\". Today the output format is decided by a v... | d4bbb8e2b8ab13ad0e48a2ee56f819d140b1b95b | {
"head_commit": "91f4bee73741c44846dee9a059154b15545e4640",
"head_commit_message": "Allow to convert private keys between different formats.",
"patch_to_review": "diff --git a/changelogs/fragments/60388-openssl_privatekey-format.yml b/changelogs/fragments/60388-openssl_privatekey-format.yml\nnew file mode 100644... | [
{
"diff_hunk": "@@ -123,6 +123,31 @@\n default: auto\n choices: [ auto, cryptography, pyopenssl ]\n version_added: \"2.8\"\n+ format:\n+ description:\n+ - Determines which format the private key is written in. By default, PKCS1 (traditional OpenSSL format)\n+ ... | e064cd4160e65c3ace8535d09f0fa76a85a03f77 | diff --git a/changelogs/fragments/60388-openssl_privatekey-format.yml b/changelogs/fragments/60388-openssl_privatekey-format.yml
new file mode 100644
index 00000000000000..ad3eff915ba11b
--- /dev/null
+++ b/changelogs/fragments/60388-openssl_privatekey-format.yml
@@ -0,0 +1,2 @@
+minor_changes:
+- "openssl_privatekey -... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
aws__aws-cli-4308@e3298df | aws/aws-cli | Python | 4,308 | Add txt files from examples to distributions | create-cluster-synopsis.rst was renamed to create-cluster-synopsis.txt
in order to pass the new documentation tests. This does not get included
in the distribution bundle, but will still work when tested as an
editable install.
fixes #4306
| 2019-07-11T22:07:07Z | aws emr create-cluster help command returns error
how to reproduce
1. upgrade to awscli 1.16.190 or 1.16.194 or 1.16.196
at the moment it's enough to install via pip either on macOS(1.16.194) or on linux(1.16.196), or using Homebrew(1.16.190) on macOS
```
# on Ubuntu 16.04 linux
$ pip install --upgrade awscli
... | @VitSkakun - Thank you for reporting this issue. I can confirm the behavior and will label it as such. We are looking into getting this resolved. Do you need any other guidance with the `aws emr create-cluster` command?
> Do you need any other guidance with the aws emr create-cluster command?
@justnance - it's ok... | [
{
"body": "how to reproduce \r\n\r\n1. upgrade to awscli 1.16.190 or 1.16.194 or 1.16.196\r\nat the moment it's enough to install via pip either on macOS(1.16.194) or on linux(1.16.196), or using Homebrew(1.16.190) on macOS\r\n```\r\n# on Ubuntu 16.04 linux \r\n$ pip install --upgrade awscli\r\n<... output skip... | 46409c6e7344e2631b376337b285d62d0df304b9 | {
"head_commit": "e3298dfa574d62381d46a33bc7f44cdbc780a320",
"head_commit_message": "Add txt files from examples to distributions\n\ncreate-cluster-synopsis.rst was renamed to create-cluster-synopsis.txt\nin order to pass the new documentation tests. This does not get included\nin the distribution bundle, but will ... | [
{
"diff_hunk": "@@ -258,3 +258,15 @@ def visit_literal_block(self, node):\n \n def default_visit(self, node):\n pass\n+\n+\n+\n+def test_only_rst_and_txt_example_files():\n+ for root, _, files in os.walk(EXAMPLES_DIR):\n+ for filename in files:\n+ filepath = '%s/%s' % (root, fil... | fc154d4b3dc0360d427308c91f337564daad4c61 | diff --git a/MANIFEST.in b/MANIFEST.in
index d5466ce03b74..74f10c7ffc00 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -1,5 +1,5 @@
include README.rst
include LICENSE.txt
include requirements.txt
-recursive-include awscli/examples *.rst
+recursive-include awscli/examples *.rst *.txt
recursive-include awscli/data *.j... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-60158@f1233db | ansible/ansible | Python | 60,158 | win_dns_record PTR docs update | ##### SUMMARY
Fixes: #60068
##### ISSUE TYPE
- Docs Pull Request
##### COMPONENT NAME
win_dns_record
##### ADDITIONAL INFORMATION
| 2019-08-06T20:09:30Z | win_dns_record incorrectly creates PTR records
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain the p... | Files identified in the description:
* [`lib/ansible/modules/windows/win_dns_record.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_dns_record.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 94f5e2d9ed964d32271e193445f40557bb5892b6 | {
"head_commit": "f1233dbd10e661c0884ee952bced6d21ea6de8a2",
"head_commit_message": "win_dns_record PTR docs update",
"patch_to_review": "diff --git a/lib/ansible/modules/windows/win_dns_record.py b/lib/ansible/modules/windows/win_dns_record.py\nindex 0e499515ad2baf..992653bc881c7d 100644\n--- a/lib/ansible/modul... | [
{
"diff_hunk": "@@ -76,6 +77,13 @@\n value: \"cgyl1404p.amer.example.com\"\n zone: \"amer.example.com\"\n \n+- name: PTR example\n+ win_dns_record:\n+ name: \"db1\"\n+ type: \"PTR\"\n+ value: \"1.1.1\"",
"line": null,
"original_line": 84,
"original_start_line": null,
"path": "l... | bdf9f573937c06c5761fc80d7910e61ad23df2b0 | diff --git a/lib/ansible/modules/windows/win_dns_record.py b/lib/ansible/modules/windows/win_dns_record.py
index 0e499515ad2baf..2eb5c42dc76417 100644
--- a/lib/ansible/modules/windows/win_dns_record.py
+++ b/lib/ansible/modules/windows/win_dns_record.py
@@ -51,6 +51,7 @@
value:
description:
- The value(s)... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
aws__aws-cli-4019@b9c3e63 | aws/aws-cli | Python | 4,019 | Support for packaging GlueJob resources | Fixes #3570
The AWS::Glue::Job resource has a ScriptLocation property under a Command property. This adds support for packaging that file.
In order to support this the base Resource property was updated to support nested properties.
By submitting this pull request, I confirm that you can use, modify, co... | 2019-03-20T21:26:25Z | Add `cloudformation package` support for AWS::Glue::Job resource type
Instead of having to upload Glue scripts to S3 manually, it would be nice if it could be done with `aws cloudformation package` command the same way it's done for `AWS::CloudFormation::Stack` or `AWS::Lambda::Function` resource types:
```yaml
Res... | @ilyasotkov Thanks for reaching out. This seems like it would be very helpful. I have changed the label to feature request. @sanathkr what are your thoughts on this idea?
What are the current workarounds ?
Kill me but i cant find how to provide inline code for glue in cloudformation template. I refuse to believe th... | [
{
"body": "Instead of having to upload Glue scripts to S3 manually, it would be nice if it could be done with `aws cloudformation package` command the same way it's done for `AWS::CloudFormation::Stack` or `AWS::Lambda::Function` resource types:\r\n\r\n```yaml\r\nResources:\r\n MyGlueJob:\r\n Type: AWS::Glu... | e46523aea98586768d68d09302a97593a88c45a9 | {
"head_commit": "b9c3e638c925d1167fd319d4fe0875468e629858",
"head_commit_message": "Implement recursion in nested property discovery",
"patch_to_review": "diff --git a/awscli/customizations/cloudformation/artifact_exporter.py b/awscli/customizations/cloudformation/artifact_exporter.py\nindex cba80c609aef..c338cb... | [
{
"diff_hunk": "@@ -94,6 +94,51 @@ def parse_s3_url(url,\n \"{0}\".format(url))\n \n \n+def get_nested_property_value(resource_dict, property_name):",
"line": null,
"original_line": 97,
"original_start_line": null,
"path": "awscli/customizations/cloudformation/artifact_expor... | 87f25bad5c5b22511a45cb88f92914748aee55c2 | diff --git a/awscli/customizations/cloudformation/artifact_exporter.py b/awscli/customizations/cloudformation/artifact_exporter.py
index cba80c609aef..67b65cf9df29 100644
--- a/awscli/customizations/cloudformation/artifact_exporter.py
+++ b/awscli/customizations/cloudformation/artifact_exporter.py
@@ -19,12 +19,15 @@
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
aws__aws-cli-2835@742cbcc | aws/aws-cli | Python | 2,835 | Make configure/set command properly handle spaces in profiles | Fixes #2806
A big thanks to @gtseres for submitting the fix.
I refactored his fix a little bit to make it a function so we can unit test it and apply it to the `set` command as well. | 2017-09-15T23:08:20Z | Profile does not return region or output format if it contains a SPACE character
The AWS CLI tool allows you to create a profile name with a space character in it, and writes the values to the credentials and config file as expected. However when getting that config using the quoted profile name, it doesn't return the ... | So after some debugging. Essentially the `configure` function for profile needs to check if the profile name has spaces and if so add single quotes around them. First off actual config loading happens in botocore and uses `shlex.split` on the profile section name:
https://github.com/boto/botocore/blob/develop/botoco... | [
{
"body": "The AWS CLI tool allows you to create a profile name with a space character in it, and writes the values to the credentials and config file as expected. However when getting that config using the quoted profile name, it doesn't return the region or default output format.\r\n\r\nSetting the profile cr... | 9cb1e23726da4df6b6c1674bd5e4d2b678699c2a | {
"head_commit": "742cbcc26d7a01f56c3f9e3160018f9b4957fd2a",
"head_commit_message": "Fix issue #2806: Support for section names that contain spaces",
"patch_to_review": "diff --git a/awscli/customizations/configure/configure.py b/awscli/customizations/configure/configure.py\nindex 263c8738439a..05b34c69ed6b 10064... | [
{
"diff_hunk": "@@ -36,3 +36,13 @@ def mask_value(current_value):\n return 'None'\n else:\n return ('*' * 16) + current_value[-4:]\n+\n+\n+def profile_to_section(profile_name):\n+ \"\"\"Converts a profile name to a section header to be used in the config.\"\"\"\n+\n+ if ' ' in profile_... | 45df487eae38fc9630f3bcd9bac9477ff44ae976 | diff --git a/.changes/next-release/bugfix-Config-5978.json b/.changes/next-release/bugfix-Config-5978.json
new file mode 100644
index 000000000000..f2b453e26363
--- /dev/null
+++ b/.changes/next-release/bugfix-Config-5978.json
@@ -0,0 +1,5 @@
+{
+ "category": "Config",
+ "type": "bugfix",
+ "description": "Properly ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-60086@a369f7b | ansible/ansible | Python | 60,086 | Add support to configure network_cli terminal related options | Depends-On: https://github.com/ansible/ansible/pull/60305
##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #59404
* Add network_cli configurable options to support platform specific login menu
* Add network_cli configurable options to support configurable option... | 2019-08-05T16:50:16Z | IOS Terminal: "ERROR" in an IOS log message causes terminal to incorrectly parse a stderr in response to a command.
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form... | I think it's this line that's the problem in terminal/ios.py:
` re.compile(br"[%\S] ?Error: ?[\s]+", re.I), `
If we were to just take out the re.I, this regex would no longer match my logs containing "ERROR". Might miss some legitimate error messages though.
@ganeshrn I think you committed this line way b... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | b55a54469c23bbec4909eadd5e526ba055ed119f | {
"head_commit": "a369f7bf774af751b6bcbdc6c650d71ecc8dc93b",
"head_commit_message": "Add support to configure terminal related options\n\nFixes https://github.com/ansible/ansible/issues/59404\n\n* Add network_cli configurable options to support platform specific login menu\n* Add network_cli configurable options ... | [
{
"diff_hunk": "@@ -561,6 +561,45 @@ To make this a permanent change, add the following to your ``ansible.cfg`` file:\n connect_retry_timeout = 30\n \n \n+Timeout issue due to platform specific login menu with ``network_cli`` connection type\n+-----------------------------------------------------------------... | 89663a6829ad0f3c6c2508e5e3b413f80a09f4fb | diff --git a/docs/docsite/rst/network/user_guide/network_debug_troubleshooting.rst b/docs/docsite/rst/network/user_guide/network_debug_troubleshooting.rst
index ba383a058c107f..81023e7da3610f 100644
--- a/docs/docsite/rst/network/user_guide/network_debug_troubleshooting.rst
+++ b/docs/docsite/rst/network/user_guide/net... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-59946@fbe8544 | ansible/ansible | Python | 59,946 | Fix issue with empty cow_whitelist | ##### SUMMARY
Fix issue with empty cow_whitelist. Fixes #45631
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/utils/display.py
##### ADDITIONAL INFORMATION
<!--- Include additional information to help people understand the change here -->
<!--- A step-by-step reproduction of the p... | 2019-08-01T17:55:51Z | An empty cow_whitelist while cow_selection is random causes no cows to be selected
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
!component l... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nWhen using random cow selection, and ... | 26fff6f5c32fa4396a8c72872c729b367739499c | {
"head_commit": "fbe854460ed2d86dc2b677e28e2970a1f1df4b33",
"head_commit_message": "Fix issue with empty cow_whitelist. Fixes #45631",
"patch_to_review": "diff --git a/changelogs/fragments/45631-empty-cow-whitelist.yml b/changelogs/fragments/45631-empty-cow-whitelist.yml\nnew file mode 100644\nindex 000000000000... | [
{
"diff_hunk": "@@ -110,7 +110,7 @@ def __init__(self, verbosity=0):\n cmd = subprocess.Popen([self.b_cowsay, \"-l\"], stdout=subprocess.PIPE, stderr=subprocess.PIPE)\n (out, err) = cmd.communicate()\n self.cows_available = set([to_text(c) for c in out.split()])\n... | 167b9142b6033418ac46be85be82e1552a2af4d1 | diff --git a/changelogs/fragments/45631-empty-cow-whitelist.yml b/changelogs/fragments/45631-empty-cow-whitelist.yml
new file mode 100644
index 00000000000000..dd556c63253b94
--- /dev/null
+++ b/changelogs/fragments/45631-empty-cow-whitelist.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- cowsay - Fix issue with an empty cow_whiteli... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-59500@29ebc13 | ansible/ansible | Python | 59,500 | Fix py3 decoding issues in cyberarkpassword.py | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This commit fixes the following error while using Python 3:
ERROR! Unexpected Exception, this is probably a bug: a bytes-like object is required, not 'str'
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing i... | 2019-07-24T09:07:54Z | cyberarkpassword: TypeError: a bytes-like object is required, not 'str'
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUM... | Files identified in the description:
* [lib/ansible/plugins/lookup/cyberarkpassword.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/lookup/cyberarkpassword.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nLookup cyberarkpassword results in Ty... | 5a7f579d86b52754d5634fd6719882158c01ec18 | {
"head_commit": "29ebc135f6f33e7107e5873e6956126a9573a223",
"head_commit_message": "Fix py3 decoding issues in cyberarkpassword.py\n\nThis commit fixes the following error while using Python 3:\r\n\r\nERROR! Unexpected Exception, this is probably a bug: a bytes-like object is required, not 'str'",
"patch_to_revi... | [
{
"diff_hunk": "@@ -144,9 +144,9 @@ def get(self):\n if \"passprops\" not in result_dict:\n result_dict[\"passprops\"] = {}\n output_prop_name = output_names[i][10:]\n- result_dict[\"passprops\"][output_prop_name] = output_values... | a401dae58813f4da27f469b8641f669534fd0fb2 | diff --git a/changelogs/fragments/59500-cyberarkpassword-fix-py3-decoding.yaml b/changelogs/fragments/59500-cyberarkpassword-fix-py3-decoding.yaml
new file mode 100644
index 00000000000000..0a04a2debd1da9
--- /dev/null
+++ b/changelogs/fragments/59500-cyberarkpassword-fix-py3-decoding.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-59711@245202d | ansible/ansible | Python | 59,711 | Remove UnsafeProxy | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Move the work from `UnsafeProxy` to `wrap_var` and add support for bytes.
Where `wrap_var` is not needed, use `AnsibleUnsafeBytes`/`AnsibleUnsafeText`
directly.
Fixes #59606
<!--- HINT: Include "Fixes #nnn" if you are fi... | 2019-07-29T08:36:24Z | Remove UnsafeProxy
##### SUMMARY
There is no real reason that `UnsafeProxy` needs to exist.
We need to add unsafe bytes support, and by doing so within `UnsafeProxy` over complicates matters.
`wrap_var` should effectively take over the work that `UnsafeProxy` is doing, and then just rely on `wrap_var` directly... | Files identified in the description:
* [`lib/ansible/utils/unsafe_proxy.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/utils/unsafe_proxy.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](http... | [
{
"body": "##### SUMMARY\r\nThere is no real reason that `UnsafeProxy` needs to exist. \r\n\r\nWe need to add unsafe bytes support, and by doing so within `UnsafeProxy` over complicates matters.\r\n\r\n`wrap_var` should effectively take over the work that `UnsafeProxy` is doing, and then just rely on `wrap_var... | 08d7905be2a45e51ceed315974e25d1008bf4263 | {
"head_commit": "245202dedad6f6d1b94e72f702a4fb1b078bb4fd",
"head_commit_message": "item is not always text",
"patch_to_review": "diff --git a/lib/ansible/executor/task_executor.py b/lib/ansible/executor/task_executor.py\nindex f453ddb81967d5..14fe3e4e9df85f 100644\n--- a/lib/ansible/executor/task_executor.py\n+... | [
{
"diff_hunk": "@@ -110,5 +115,8 @@ def wrap_var(v):\n elif isinstance(v, Set):\n v = _wrap_set(v)\n elif v is not None and not isinstance(v, AnsibleUnsafe):\n- v = UnsafeProxy(v)\n+ if isinstance(v, binary_type):",
"line": null,
"original_line": 118,
"original_start_li... | 4b02e43761a19df54bcd801101de268e9c35b474 | diff --git a/lib/ansible/executor/task_executor.py b/lib/ansible/executor/task_executor.py
index f453ddb81967d5..14fe3e4e9df85f 100644
--- a/lib/ansible/executor/task_executor.py
+++ b/lib/ansible/executor/task_executor.py
@@ -28,7 +28,7 @@
from ansible.template import Templar
from ansible.utils.collection_loader imp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
apache__tvm-15517@2507acd | apache/tvm | Python | 15,517 | [TIR] Shuffle in PointerValueTypeRewrite for scalar reads | Added an option `rewrite_scalar_read_to_vector_shuffle` in `PointerValueTypeRewrite` (currently
only enabled for Vulkan). When enabled, when a buffer has both scalar
and vector reads, the buffer will be vectorized if possible and scalar
reads will be achieved via T.Shuffle.
Close https://github.com/apache/tvm/iss... | 2023-08-09T22:15:27Z | [TensorIR] Enhance PointerTypeRewrite
Our current GPU backends sometimes can generate the following code:
```c++
void kernel(float* global_data, float* res) {
float data[4];
((float4*)data)[0] = ((float4*)global_data)[0];
res[0] = data[0] + data[1] + data[2] + data[3];
}
```
Here we are doing v... | I'm interested in working on this
I really like this idea, and it will simplify a lot of the codegen-time analysis that occurs to efficiently handle Ramp nodes.
Benefits:
* This mimics what is already done as part of the LLVM codegen ([link](https://github.com/apache/tvm/blob/main/src/target/llvm/codegen_llvm.cc#... | [
{
"body": "Our current GPU backends sometimes can generate the following code:\r\n\r\n```c++\r\nvoid kernel(float* global_data, float* res) {\r\n float data[4];\r\n ((float4*)data)[0] = ((float4*)global_data)[0];\r\n res[0] = data[0] + data[1] + data[2] + data[3];\r\n}\r\n```\r\n\r\nHere we are doing ... | 2b718e5d00948f56b880d14e13ab9fb3bad26a54 | {
"head_commit": "2507acd9ef599ec8b4ce10b4673c96457214c459",
"head_commit_message": "[TIR] Shuffle in PointerValueTypeRewrite for scalar reads\n\nAdded an option `rewrite_scalar_read_to_vector_shuffle` in `PointerValueTypeRewrite` (currently\nonly enabled for Vulkan). When enabled, when a buffer has both scalar\nan... | [
{
"diff_hunk": "@@ -1304,6 +1307,18 @@ class VectorTypeAccessChecker : public StmtExprVisitor {\n }\n }\n \n+ if (detect_scalar_read_patterns_ && is_buffer_load && indices.size()) {\n+ const PrimExpr last_dim_index = indices[indices.size() - 1];\n+ if (last_dim_index.dtype().lanes() == 1)... | d563055332bd5787b7bfcf104239f668221d2cf5 | diff --git a/python/tvm/tir/transform/transform.py b/python/tvm/tir/transform/transform.py
index 0cd54064a7b5..a46b2d10373f 100644
--- a/python/tvm/tir/transform/transform.py
+++ b/python/tvm/tir/transform/transform.py
@@ -230,6 +230,20 @@ def StorageRewrite():
return _ffi_api.StorageRewrite() # type: ignore
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
ansible__ansible-59271@58ad03c | ansible/ansible | Python | 59,271 | Fix gather facts ignoring gather_subsets config | fixes #58728
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
gather_facts | 2019-07-18T21:35:19Z | 'gather_subset' setting in ansible.cfg and ansible/roles are ignored
##### SUMMARY
'gather_subset' setting in ansible.cfg and ansible/roles are ignored
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
fact gathering
##### ANSIBLE VERSION
```
ansible 2.8.1
config file = /etc/ansible/ansible.cfg
con... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
needs_info
I... | [
{
"body": "##### SUMMARY\r\n'gather_subset' setting in ansible.cfg and ansible/roles are ignored\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nfact gathering\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.8.1\r\n config file = /etc/ansible/ansible.cfg\r\n configured module search pa... | aeb0245ebd0ab6c51da7132e5c03ab6eb76e03a2 | {
"head_commit": "58ad03c83f1c4d4417d85c3ebe7c4517c053ad81",
"head_commit_message": "Fix gather facts ignoring gather_subsets config\n\n fixes #58728",
"patch_to_review": "diff --git a/changelogs/fragments/gather_subset_defaults.yml b/changelogs/fragments/gather_subset_defaults.yml\nnew file mode 100644\nindex 00... | [
{
"diff_hunk": "@@ -57,7 +57,7 @@ class Play(Base, Taggable, CollectionSearch):\n \n # Facts\n _gather_facts = FieldAttribute(isa='bool', default=None, always_post_validate=True)\n- _gather_subset = FieldAttribute(isa='list', default=None, listof=string_types, always_post_validate=True)\n+ _gather... | 9911ef3031497884ed1aadfccc1a069139f25c63 | diff --git a/changelogs/fragments/gather_subset_defaults.yml b/changelogs/fragments/gather_subset_defaults.yml
new file mode 100644
index 00000000000000..7db2ef753afa42
--- /dev/null
+++ b/changelogs/fragments/gather_subset_defaults.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - Gather facts should use gather_subset config by d... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-59469@788e29b | ansible/ansible | Python | 59,469 | win_share - Implement append paramtere for access rules | ##### SUMMARY
Fixes: #59237
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
win_share.py
win_share.ps1
##### ADDITIONAL INFORMATION
| 2019-07-23T18:57:46Z | win_share: remove all other permissions of a share
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
I have a playbo... | Files identified in the description:
* [`lib/ansible/modules/windows/win_share.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_share.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for ... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nI have a playbook the user: App_Urb o... | 7b4ce9e4aee8f2d131ea0176456054b3ecbd4002 | {
"head_commit": "788e29b5f42ccf448bdaba0cc3fa4dc87ddd9409",
"head_commit_message": "Forgot the actual new parameter in the test",
"patch_to_review": "diff --git a/changelogs/fragments/win_share-Implement-append-paramtere-for-access-rules.yml b/changelogs/fragments/win_share-Implement-append-paramtere-for-access-... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+minor_changes:\n+ - \"win_share - Implement append paramtere for access rules (https://github.com/ansible/ansible/issues/59237)\"",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "changelogs/fragments/win_share-Implement-append-paramtere... | ae6f8d2e8f10cc56beecf9e225fa3bb978fb151e | diff --git a/changelogs/fragments/win_share-Implement-append-paramtere-for-access-rules.yml b/changelogs/fragments/win_share-Implement-append-paramtere-for-access-rules.yml
new file mode 100644
index 00000000000000..260f0688b8474c
--- /dev/null
+++ b/changelogs/fragments/win_share-Implement-append-paramtere-for-access-... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-59184@cd5bb7d | ansible/ansible | Python | 59,184 | ovirt search name with space | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
ovirt modules now will search names with spaces
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #59140
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
... | 2019-07-17T13:55:38Z | oVirt: when having network with spaces in name, the search fails to find it.
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
####... | Files identified in the description:
* [`lib/ansible/modules/cloud/ovirt/ovirt_network.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/ovirt/ovirt_network.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | b8eba8e1f0d3e05220b51064759f81ae8e5cc5e5 | {
"head_commit": "cd5bb7d35f9a56a53fcd6c5d2da59a1b9ebbf030",
"head_commit_message": "init ovirt_search_name_with_space",
"patch_to_review": "diff --git a/lib/ansible/module_utils/ovirt.py b/lib/ansible/module_utils/ovirt.py\nindex 4b2b48526c5823..da65bcbda8dbec 100644\n--- a/lib/ansible/module_utils/ovirt.py\n+++... | [
{
"diff_hunk": "@@ -254,7 +254,7 @@ def search_by_attributes(service, list_params=None, **kwargs):\n # Check if 'list' method support search(look for search parameter):\n if 'search' in inspect.getargspec(service.list)[0]:\n res = service.list(\n- search=' and '.join('{0}={1}'.format(... | d511fa1f6cb6679276769d8020b48bb64cb0c7d5 | diff --git a/lib/ansible/module_utils/ovirt.py b/lib/ansible/module_utils/ovirt.py
index 4b2b48526c5823..1ce6cb6e90b4c6 100644
--- a/lib/ansible/module_utils/ovirt.py
+++ b/lib/ansible/module_utils/ovirt.py
@@ -254,7 +254,8 @@ def search_by_attributes(service, list_params=None, **kwargs):
# Check if 'list' method ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-59080@b06ddef | ansible/ansible | Python | 59,080 | Module mail : Add Date header | ##### SUMMARY
Add Date header for emails sent by email module
Fixes #58808
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
mail
##### ADDITIONAL INFORMATION
Add Date header to the email.
This header is "nice to have" if you need to send out your emails on Internet
| 2019-07-14T20:31:06Z | mail module should send email with "Date" header
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
mail module does ... | Files identified in the description:
* [`lib/ansible/modules/notification/mail.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/notification/mail.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for ... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nmail module does not send email with ... | b6273e91cfbcf3f9c9ab849b6803c6a8a3aa7c3d | {
"head_commit": "b06ddefc7e2d850d1e66f27203f52a8824a210cb",
"head_commit_message": "Mail module : add date header (#58808)",
"patch_to_review": "diff --git a/changelogs/fragments/58808-mail-add-date-header.yaml b/changelogs/fragments/58808-mail-add-date-header.yaml\nnew file mode 100644\nindex 00000000000000..a3... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+minor_changes:\n+ - add date header to the email based on local time",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "changelogs/fragments/58808-mail-add-date-header.yaml",
"start_line": null,
"text": "@user1:\n```suggestion\r\n... | 986c11f40d6f960ae5a262a4b698a31b9ed6b224 | diff --git a/changelogs/fragments/58808-mail-add-date-header.yaml b/changelogs/fragments/58808-mail-add-date-header.yaml
new file mode 100644
index 00000000000000..a797e369cce4f2
--- /dev/null
+++ b/changelogs/fragments/58808-mail-add-date-header.yaml
@@ -0,0 +1,2 @@
+minor_changes:
+ - Add date header to the email ba... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-59079@2094e63 | ansible/ansible | Python | 59,079 | Fix AWS iam_user remove | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #59078
As Boto3 documentation tells (https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/iam.html#IAM.Client.delete_u... | 2019-07-14T19:41:46Z | iam_user module fails to remove an AWS user
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain the prob... | Files identified in the description:
* [`lib/ansible/modules/cloud/amazon/iam_user.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/amazon/iam_user.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click h... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | dbc9444572823545b2b18c74c57fb4efe25d6826 | {
"head_commit": "2094e631ce9141989b59065aef102bee9f588cf6",
"head_commit_message": "Make iam_user not fail on user deletion.\n\n- Use guard clause on already absent user\n- Refactor, use variable instead nested dict\n- Ensure needed prerequisites for boto3 delete_user successfully\n- Use AnsibleAWSModule on iam_us... | [
{
"diff_hunk": "@@ -227,38 +227,81 @@ def create_or_update_user(connection, module):\n \n def destroy_user(connection, module):\n \n- params = dict()\n- params['UserName'] = module.params.get('name')\n+ user_name = module.params.get('name')\n \n- if get_user(connection, module, params['UserName']):\... | 6d58aa95cdd39234470dc7224c00859638fd9995 | diff --git a/lib/ansible/modules/cloud/amazon/iam_user.py b/lib/ansible/modules/cloud/amazon/iam_user.py
index f5d319405e3eca..7ab90c6e0ac18c 100644
--- a/lib/ansible/modules/cloud/amazon/iam_user.py
+++ b/lib/ansible/modules/cloud/amazon/iam_user.py
@@ -99,14 +99,14 @@
'''
from ansible.module_utils._text import to... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-58680@80e3cbd | ansible/ansible | Python | 58,680 | win_find - Fix deduped files mistaken for directories | ##### SUMMARY
Fixes: #58511
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
win_find.ps1
##### ADDITIONAL INFORMATION
This was a fun one
| 2019-07-03T16:51:01Z | win_find module not returning deduplicated files
##### SUMMARY
Using the win_find module against a Windows share it is not returning some files. In this case .exe files.
The .exe files are deduplicated and looking at their properties in Windows explorer, they appear as something like this:
'Size: 100MB'
'Si... | Files identified in the description:
* [`lib/ansible/modules/windows/win_find.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_find.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bo... | [
{
"body": "\r\n\r\n##### SUMMARY\r\nUsing the win_find module against a Windows share it is not returning some files. In this case .exe files.\r\n\r\nThe .exe files are deduplicated and looking at their properties in Windows explorer, they appear as something like this:\r\n\r\n'Size: 100MB'\r\n'Size on disk: 0 ... | 737dbefd78cab9a4cad8ea32237fe9fc88798258 | {
"head_commit": "80e3cbda556b690f047794d9e1e09fc2634a8cdc",
"head_commit_message": "Update win_find.py",
"patch_to_review": "diff --git a/changelogs/fragments/win_find-fix-ignore-of-deduped-files.yml b/changelogs/fragments/win_find-fix-ignore-of-deduped-files.yml\nnew file mode 100644\nindex 00000000000000..1f97... | [
{
"diff_hunk": "@@ -244,13 +244,16 @@ Function Get-FileStat($file) {\n if ($attributes -contains 'ReparsePoint') {\n # TODO: Find a way to differenciate between soft and junction links\n $islnk = $true\n- $isdir = $true\n \n- # Try and get the symlink source, can result in fail... | 4a431fa02f13043dae835653cb512c6ede2e9b69 | diff --git a/changelogs/fragments/win_find-fix-ignore-of-deduped-files.yml b/changelogs/fragments/win_find-fix-ignore-of-deduped-files.yml
new file mode 100644
index 00000000000000..1f976214337be3
--- /dev/null
+++ b/changelogs/fragments/win_find-fix-ignore-of-deduped-files.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - "win_find... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-59024@a96912d | ansible/ansible | Python | 59,024 | Clear 'connection related' plugin vars for next loop iteration | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #58876
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short nam... | 2019-07-12T10:03:58Z | assigning variable to remote_user in loop only works first time
<!--- Verify first that your issue is not already reported on GitHub -->
it is not
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
####... | Files identified in the description:
* [`lib/ansible/plugins/connection/ssh.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/connection/ssh.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot he... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\nit is not\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the pr... | ec35cbc4378afa962f35739a619d20d4454b298b | {
"head_commit": "a96912d4c37102e2903f132877e60128e27ccb17",
"head_commit_message": "Clear 'connection related' plugin vars for next loop iteration\n\nFixes #58876",
"patch_to_review": "diff --git a/changelogs/fragments/58876-do-not-reuse-remote_user-from-prev-loop.yaml b/changelogs/fragments/58876-do-not-reuse-r... | [
{
"diff_hunk": "@@ -410,6 +410,19 @@ def _run_loop(self, items):\n results.append(res)\n del task_vars[loop_var]\n \n+ # clear 'connection related' plugin variables for next iteration\n+ clear_plugins = {\n+ 'connection': self._connection._load_name,\... | 21cee253a1c77f1e009eafe9ea8973384c36f115 | diff --git a/changelogs/fragments/58876-do-not-reuse-remote_user-from-prev-loop.yaml b/changelogs/fragments/58876-do-not-reuse-remote_user-from-prev-loop.yaml
new file mode 100644
index 00000000000000..d345b2254be2bf
--- /dev/null
+++ b/changelogs/fragments/58876-do-not-reuse-remote_user-from-prev-loop.yaml
@@ -0,0 +1,... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
activeloopai__deeplake-2249@7d31c43 | activeloopai/deeplake | Python | 2,249 | fix: hash_id catch wrong type. | ## 🚀 🚀 Pull Request
### Checklist:
- [x] [My code follows the style guidelines of this project](https://www.notion.so/activeloop/Engineering-Guidelines-d6e502306d0e4133a8ca507516d1baab) and the [Contributing document](https://github.com/activeloopai/Hub/blob/release/2.0/CONTRIBUTING.md)
- [x] I have commente... | 2023-03-20T15:15:26Z | [BUG] type of hash_id is never checked
## 🐛🐛 Bug Report
### ⚗️ Current Behavior
A clear and concise description of the behavior.
**Input Code**
```python
import deeplake
# load dataset
ds = deeplake.load("hub://activeloop/mnist-train")
# filter dataset
zeros = ds.filter("labels == 0")
# save view
zer... | [
{
"body": "## 🐛🐛 Bug Report\r\n\r\n\r\n### ⚗️ Current Behavior\r\nA clear and concise description of the behavior.\r\n\r\n**Input Code**\r\n```python\r\nimport deeplake\r\n# load dataset\r\nds = deeplake.load(\"hub://activeloop/mnist-train\")\r\n# filter dataset\r\nzeros = ds.filter(\"labels == 0\")\r\n# save... | e47e582a876051b5b655ad4f6c645d0a4881d83c | {
"head_commit": "7d31c43df885d596d7d512f6ceaf00d017529a00",
"head_commit_message": "chore: fix black formatting.",
"patch_to_review": "diff --git a/deeplake/core/dataset/dataset.py b/deeplake/core/dataset/dataset.py\nindex b9bf3c2c10..ab8d55984c 100644\n--- a/deeplake/core/dataset/dataset.py\n+++ b/deeplake/core... | [
{
"diff_hunk": "@@ -2877,6 +2877,8 @@ def save_view(\n Specifying ``path`` makes the view external. External views cannot be accessed using the parent dataset's :func:`Dataset.get_view`,\n :func:`Dataset.load_view`, :func:`Dataset.delete_view` methods. They have to be loaded using :func:... | 2f3ae47619f2396623326e77aaf59986fbd45df9 | diff --git a/deeplake/core/dataset/dataset.py b/deeplake/core/dataset/dataset.py
index b9bf3c2c10..0a6c60f866 100644
--- a/deeplake/core/dataset/dataset.py
+++ b/deeplake/core/dataset/dataset.py
@@ -2872,11 +2872,14 @@ def save_view(
Raises:
ReadOnlyModeError: When attempting to save a view inplac... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
activeloopai__deeplake-1697@1e3f198 | activeloopai/deeplake | Python | 1,697 | [AL-1796] Timestamps for video | ## 🚀 🚀 Pull Request
### Checklist:
- [ ] [My code follows the style guidelines of this project](https://www.notion.so/activeloop/Engineering-Guidelines-d6e502306d0e4133a8ca507516d1baab) and the [Contributing document](https://github.com/activeloopai/Hub/blob/release/2.0/CONTRIBUTING.md)
- [ ] I have commente... | 2022-05-27T08:05:38Z | [FEATURE] Please add API support for timestamp of each frame retrieved from video
## 🚨🚨 Feature Request
- [ ] A new implementation (Improvement, Extension)
### Is your feature request related to a problem?
Using Hub, we can get frames from a video. But currently there is no way to get timestamp of those fra... | Hi @nahidalam, can you tell us how you expect this output to look like?
Say a video is 10 minutes. The timestamps should be in seconds referring to anywhere in the video from 0 seconds to 10 minutes depending on the frame. | [
{
"body": "## 🚨🚨 Feature Request\r\n\r\n- [ ] A new implementation (Improvement, Extension) \r\n\r\n### Is your feature request related to a problem?\r\n\r\nUsing Hub, we can get frames from a video. But currently there is no way to get timestamp of those frames. \r\n\r\n### If your feature will improve `HUB`... | 7ee6993054834be25b7b2f2b6757c6698c636ace | {
"head_commit": "1e3f1983e6f4bd53baa8a1adaacb56828448d3d5",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/hub/api/tests/test_video.py b/hub/api/tests/test_video.py\nindex 1e0068f1c7..eafe5cbf7e 100644\n--- a/hub/api/tests/test_video.py\n+++ b/hub/api/tests/test_video.py\n@@ -1,9 +1,11 @@\n impor... | [
{
"diff_hunk": "@@ -909,3 +932,22 @@ def play(self):\n )\n else:\n webbrowser.open(self._get_video_stream_url())\n+\n+ @property\n+ def timestamp(self) -> np.ndarray:\n+ if get_compression_type(self.meta.sample_compression) != VIDEO_COMPRESSION:\n+ raise E... | b1a37a9be34ff677632c4e50005c5e12ef34cd0d | diff --git a/hub/api/tests/test_video.py b/hub/api/tests/test_video.py
index 1e0068f1c7..3bda00df5e 100644
--- a/hub/api/tests/test_video.py
+++ b/hub/api/tests/test_video.py
@@ -4,6 +4,7 @@
import hub
from hub.core.dataset import Dataset
+from hub.util.exceptions import DynamicTensorNumpyError
import numpy as n... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-58383@531e457 | ansible/ansible | Python | 58,383 | Make win_domain_user idempotent for password changes | ##### SUMMARY
win_domain_user always returns changed if a password is specified.
This pr implements an additional option to not only update the password "on_create" or "always", but also "when_changed"
Fixes #58246
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
win_domain_user
_OT side n... | 2019-06-26T10:54:41Z | win_domain_user not idempotent for setting passwords
##### SUMMARY
win_domain_user always returns changed if a password is specified.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
win_domain_user
##### ANSIBLE VERSION
```paste below
ansible 2.8.1
config file = /etc/ansible/ansible.cfg
configure... | Files identified in the description:
* [`lib/ansible/modules/windows/win_domain_user.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_domain_user.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[cli... | [
{
"body": "##### SUMMARY\r\nwin_domain_user always returns changed if a password is specified.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nwin_domain_user\r\n\r\n##### ANSIBLE VERSION\r\n```paste below\r\nansible 2.8.1\r\n config file = /etc/ansible/ansible.cfg\r\n configured module... | 7e22c7482e85cc98e14c4cdbc8b8ffb543917425 | {
"head_commit": "531e4579eedd60402d2c5f6ca9fb494e4f98a916",
"head_commit_message": "Update win_domain_user.ps1\n\nFix ci",
"patch_to_review": "diff --git a/changelogs/fragments/58246-win_domain_user-idempotency.yaml b/changelogs/fragments/58246-win_domain_user-idempotency.yaml\nnew file mode 100644\nindex 000000... | [
{
"diff_hunk": "@@ -4,6 +4,109 @@\n \n #Requires -Module Ansible.ModuleUtils.Legacy\n \n+Function Test-Credential {\n+ param(\n+ [String]$Username,\n+ [String]$Password,\n+ [String]$Domain = $null,\n+ $LOGON32_PROVIDER = 0, # Default",
"line": null,
"original_line": 12,
... | e2fd4642bddfe8e2a3bea515ef679930de675408 | diff --git a/changelogs/fragments/58246-win_domain_user-idempotency.yaml b/changelogs/fragments/58246-win_domain_user-idempotency.yaml
new file mode 100644
index 00000000000000..a68d9fdcdb78dc
--- /dev/null
+++ b/changelogs/fragments/58246-win_domain_user-idempotency.yaml
@@ -0,0 +1,3 @@
+---
+minor_changes:
+ - "win_... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
apache__tvm-9425@eff7824 | apache/tvm | Python | 9,425 | Fix repository URL in ubuntu_install_rocm.sh | Fix repository URL in ubuntu_install_rocm.sh:
* ROCm dependency installation process was following outdated procedures.
This PR makes the installation script to point to the correct repository
* Installation documentation is at:
https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html
* Fi... | 2021-11-02T11:49:43Z | [Bug] ubuntu_install_rocm.sh fails when generating ci-gpu image
The nightly Docker image rebuild job is failing for the `ci-gpu` with the following error:
```
---> Running in 4087679497b3
Warning: apt-key output should not be parsed (stdout is not a terminal)
gpg: no valid OpenPGP data found.
The command '/bin/... | OK, so it looks like http://repo.radeon.com/rocm/apt/debian/rocm.gpg.key disappeared, and this script then needs updating. | [
{
"body": "The nightly Docker image rebuild job is failing for the `ci-gpu` with the following error:\r\n\r\n```\r\n ---> Running in 4087679497b3\r\nWarning: apt-key output should not be parsed (stdout is not a terminal)\r\ngpg: no valid OpenPGP data found.\r\nThe command '/bin/sh -c bash /install/ubuntu_instal... | aaae58f18b9a0ab23e1e13940884e13327e62c15 | {
"head_commit": "eff7824d5a46dc0463fbbb602ddaed87da6d9f8b",
"head_commit_message": "Fix repository URL in ubuntu_install_rocm.sh\n\n* ROCm dependency installation process was following outdated procedures.\n This PR makes the installation script to point to the correct repository\n\n* Installation documentation i... | [
{
"diff_hunk": "@@ -21,8 +21,8 @@ set -u\n set -o pipefail\n \n # Install ROCm cross compilation toolchain.\n-wget -qO - http://repo.radeon.com/rocm/apt/debian/rocm.gpg.key | sudo apt-key add -\n-echo deb [arch=amd64] http://repo.radeon.com/rocm/apt/debian/ xenial main > /etc/apt/sources.list.d/rocm.list\n+wget... | 048689b8b197e8d62bb396f0fceee312955d2147 | diff --git a/docker/install/ubuntu_install_rocm.sh b/docker/install/ubuntu_install_rocm.sh
index 0945c582489f..2f28356da3c8 100755
--- a/docker/install/ubuntu_install_rocm.sh
+++ b/docker/install/ubuntu_install_rocm.sh
@@ -21,10 +21,10 @@ set -u
set -o pipefail
# Install ROCm cross compilation toolchain.
-wget -qO ... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
activeloopai__deeplake-1311@6d17986 | activeloopai/deeplake | Python | 1,311 | Disallow certain methods for dataset and tensor views | ## 🚀 🚀 Pull Request
### Checklist:
- [x] [My code follows the style guidelines of this project](https://www.notion.so/activeloop/Engineering-Guidelines-d6e502306d0e4133a8ca507516d1baab) and the [Contributing document](https://github.com/activeloopai/Hub/blob/release/2.0/CONTRIBUTING.md)
- [x] I have commente... | 2021-10-31T21:37:04Z | [FEATURE] Disallow certain methods for dataset and tensor views
## 🚨🚨 Feature Request
- [ ] Related to an existing [Issue](../issues)
- [x] A new implementation (Improvement, Extension)
Disallow certain methods for datasets and tensor views. A "view" is a result of slicing a dataset or tensor (ds[10:20], ten... | [
{
"body": "## 🚨🚨 Feature Request\r\n\r\n- [ ] Related to an existing [Issue](../issues) \r\n- [x] A new implementation (Improvement, Extension) \r\n\r\nDisallow certain methods for datasets and tensor views. A \"view\" is a result of slicing a dataset or tensor (ds[10:20], tensor[220:30], etc).\r\n\r\n**Datas... | 2893b40b28ba16e0fe28b3d591acf9cf7fcdc75c | {
"head_commit": "6d17986cdea3cf9945e3b23eb3bc2486251aa7cb",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/hub/api/tests/test_api.py b/hub/api/tests/test_api.py\nindex 4cb4b28a31..a4ea965302 100644\n--- a/hub/api/tests/test_api.py\n+++ b/hub/api/tests/test_api.py\n@@ -6,6 +6,7 @@\n from hub.core.... | [
{
"diff_hunk": "@@ -593,6 +593,16 @@ def __init__(self):\n )\n \n \n+class NoViewError(Exception):",
"line": null,
"original_line": 596,
"original_start_line": null,
"path": "hub/util/exceptions.py",
"start_line": null,
"text": "@user1:\ncould you rename this to InvalidOperationE... | cdbdb3347d201335575ff5ec43475e74bc1fdedb | diff --git a/hub/api/tests/test_api.py b/hub/api/tests/test_api.py
index 91f94a7088..37091c7d6d 100644
--- a/hub/api/tests/test_api.py
+++ b/hub/api/tests/test_api.py
@@ -10,6 +10,7 @@
from hub.tests.storage_fixtures import enabled_remote_storages
from hub.core.storage import GCSProvider
from hub.util.exceptions imp... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
ansible__ansible-58212@52d8b14 | ansible/ansible | Python | 58,212 | create scenario guide template file | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Add an rst file with outline for a scenario guide.
Fixes #46122
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Docs Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, ... | 2019-06-21T19:09:25Z | Create a scenario guide template
<!--- Verify first that your improvement is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain the problem b... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
@samccann Fo... | [
{
"body": "<!--- Verify first that your improvement is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem brief... | db81b1d0f5a9cbc415034f54d032934fe09dc0de | {
"head_commit": "52d8b14ad442ecc36c7acc93094a9209f50ab630",
"head_commit_message": "create scenario guide template file",
"patch_to_review": "diff --git a/docs/docsite/rst/dev_guide/developing_modules_in_groups.rst b/docs/docsite/rst/dev_guide/developing_modules_in_groups.rst\nindex 1ded61370efd56..cc88e6fe2013a... | [
{
"diff_hunk": "@@ -0,0 +1,53 @@\n+:orphan:\n+\n+.. _scenario_template:\n+\n+*************************************\n+Sample scenario for Ansible platforms\n+*************************************\n+\n+*Use this ``rst`` file as a starting point to create a scenario guide for your platform. The sections below are ... | e292f92a53ebc4d24b4247c6cfe2e62270887649 | diff --git a/docs/docsite/rst/dev_guide/developing_modules_in_groups.rst b/docs/docsite/rst/dev_guide/developing_modules_in_groups.rst
index 1ded61370efd56..cc88e6fe2013a6 100644
--- a/docs/docsite/rst/dev_guide/developing_modules_in_groups.rst
+++ b/docs/docsite/rst/dev_guide/developing_modules_in_groups.rst
@@ -136,6... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} |
activeloopai__deeplake-357@32e6582 | activeloopai/deeplake | Python | 357 | Improved composite transforms, added lazy mode toggle, added .compute() to Dataset and DatasetView | Improved composite transforms, added lazy mode toggle, added .compute() to Dataset and DatasetView.
Also refactored some old code in Dataset, DatasetView, and Tensorview.
Also, fixes transforms breaking from loop when some empty samples are returned.
New implementation of transform is more efficient for multiple ... | 2020-12-19T20:05:21Z | Uploading text dataset
I tried uploading text files to Hub using this code:
```
import numpy as np
from glob import glob
import time
import hub
from hub.schema import Text
from hub import schema, transform
my_schema = {
"stocks": Text(shape=(None,))
}
fnames = glob("/home/hemant/Downloads/D... | @Hemantr05 we just fixed a couple of transform-related issues. Could you please kindly test if the same issue persists in the `fixes/stacked_transform` branch?
@Hemantr05 I believe the issue here is that max_shape hasn't been set for the Text. max_shape is the max number of characters across all files that you expect... | [
{
"body": "I tried uploading text files to Hub using this code: \r\n\r\n```\r\nimport numpy as np\r\nfrom glob import glob\r\nimport time\r\n\r\nimport hub\r\nfrom hub.schema import Text\r\nfrom hub import schema, transform\r\n\r\nmy_schema = {\r\n \"stocks\": Text(shape=(None,))\r\n}\r\n\r\nfnames = glo... | 7e2ec1d71ac2c02235afa17680fa2411bb367985 | {
"head_commit": "32e6582d36292920ba34fb7078fc0f679671e16c",
"head_commit_message": "linting fix",
"patch_to_review": "diff --git a/hub/api/dataset.py b/hub/api/dataset.py\nindex 1cfda4f778..1536c8dcd5 100644\n--- a/hub/api/dataset.py\n+++ b/hub/api/dataset.py\n@@ -21,7 +21,12 @@\n from hub.log import logger\n fr... | [
{
"diff_hunk": "@@ -84,7 +89,6 @@ def store(\n ds: hub.Dataset\n uploaded dataset\n \"\"\"\n-\n _ds = ds or self._ds",
"line": null,
"original_line": 92,
"original_start_line": null,
"path": "hub/compute/ray.py",
"start_line": null,
"text": "@author:\n... | 82abb3c745d13b020821e6876ce6a7c9974fab2c | diff --git a/hub/api/dataset.py b/hub/api/dataset.py
index 1cfda4f778..1536c8dcd5 100644
--- a/hub/api/dataset.py
+++ b/hub/api/dataset.py
@@ -21,7 +21,12 @@
from hub.log import logger
from hub.api.tensorview import TensorView
from hub.api.datasetview import DatasetView
-from hub.api.dataset_utils import slice_extra... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-58090@f52ac4b | ansible/ansible | Python | 58,090 | win_psmodule - Missing SkipPublisherCheck in Prerq installations | ##### SUMMARY
Fixes: #58088
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
win_psmodule.ps1
##### ADDITIONAL INFORMATION | 2019-06-19T18:42:22Z | win_psmodule fails due to a prerequisite PowerShellGet module conflict
##### SUMMARY
win_psmodule fails to install the specified module due to a conflict with a prerequisite module PowerShellGet
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
win_psmodule
##### ANSIBLE VERSION
```
(windows) ➜ WindowsS... | @nitzmahone
cc @ShachafGoldstein @dlazz @if-meaton @it-praktyk @jborean93 @jhawkesworth
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "##### SUMMARY\r\nwin_psmodule fails to install the specified module due to a conflict with a prerequisite module PowerShellGet\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nwin_psmodule\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n(windows) ➜ WindowsServer2016 git:(master) ✗ ansib... | 8b6c6cf302dc307521bc41cc5ed4cb231c8a903d | {
"head_commit": "f52ac4b88419e0450473c567cb019bc6a9687a20",
"head_commit_message": "Handle different minors of PS5",
"patch_to_review": "diff --git a/changelogs/fragments/win_psmodule-PreReq-SkipPublisher-missing.yml b/changelogs/fragments/win_psmodule-PreReq-SkipPublisher-missing.yml\nnew file mode 100644\ninde... | [
{
"diff_hunk": "@@ -69,7 +69,11 @@ Function Install-PrereqModule {\n }\n else {\n try {\n- Install-Module -Name $Name -MinimumVersion $PrereqModules[$Name] -Force -WhatIf:$CheckMode | Out-Null\n+ if($host.Version -ge \"5.1\") {",
... | 256123deb4685dd783d46bf2ea03074fc4ba0440 | diff --git a/changelogs/fragments/win_psmodule-PreReq-SkipPublisher-missing.yml b/changelogs/fragments/win_psmodule-PreReq-SkipPublisher-missing.yml
new file mode 100644
index 00000000000000..f6bad58b748a1c
--- /dev/null
+++ b/changelogs/fragments/win_psmodule-PreReq-SkipPublisher-missing.yml
@@ -0,0 +1,2 @@
+bugfixes:... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-58299@83d0961 | ansible/ansible | Python | 58,299 | docker_swarm_service: Make secret_id and config_id optional | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This PR removes the requirement of parameters `secret_id` for `secrets` and `config_id` for `configs`. If these parameters are not set the `*_name` will be used to look up the `*_id`.
Not really sure if something should be ... | 2019-06-24T19:40:23Z | docker_swarm_service: don't require secret_id
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Describe the new feature/improvement briefly below -->
Match docker compose's short sy... | Files identified in the description:
* [lib/ansible/modules/cloud/docker/docker_swarm_service.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/docker/docker_swarm_service.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` ... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Describe the new feature/improvement briefly below -->\r\nMatch docker compose's short syntax which just r... | b78d23d4adcb8cb5e92bf0f277b3dbd97ff863c1 | {
"head_commit": "83d0961c0fe6551d43cf43d7bc4f68f00635375b",
"head_commit_message": "Python 2.6 compat",
"patch_to_review": "diff --git a/changelogs/fragments/58299-docker_swarm_service-remove-required-config-secret-id.yml b/changelogs/fragments/58299-docker_swarm_service-remove-required-config-secret-id.yml\nnew... | [
{
"diff_hunk": "@@ -64,20 +63,33 @@\n - config_id: \"{{ config_result_1.config_id|default('') }}\"\n config_name: \"{{ config_name_1 }}\"\n filename: \"/tmp/{{ config_name_1 }}.txt\"\n- - config_id: \"{{ config_result_2.config_id|default('') }}\"\n- config_name: \"{{ config_nam... | 1509a9750661936d68125934b08ced4e6a74072c | diff --git a/changelogs/fragments/58299-docker_swarm_service-remove-required-config-secret-id.yml b/changelogs/fragments/58299-docker_swarm_service-remove-required-config-secret-id.yml
new file mode 100644
index 00000000000000..c9c965e369eaf0
--- /dev/null
+++ b/changelogs/fragments/58299-docker_swarm_service-remove-re... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-57868@1d3295d | ansible/ansible | Python | 57,868 | crypto modules: Improve requirements / error messages | ##### SUMMARY
Improves error messages when library cannot be found. Fixes #53140.
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
get_certificate
openssl_certificate
openssl_certificate_info
openssl_csr
openssl_csr_info
openssl_privatekey
openssl_privatekey_info
openssl_publickey
| 2019-06-14T20:19:52Z | Incorrect error message from openssl_publickey
##### SUMMARY
I was attempting to make a playbook which would ensures that a target server (all RHEL 7 in this situation) has a key & CSR. openssl_privatekey runs but openssl_publickey fails with the message “the python pyOpenSSL module is required” despite it being i... | Ah, a check of the source reveals that the problem is that Red Hat characteristically ships a very old OpenSSL and the version check yields the generic not installed message rather than telling you that it's too old, especially because the version requirements vary across the openssl module family.
!component =lib/ansi... | [
{
"body": "\r\n##### SUMMARY\r\n\r\nI was attempting to make a playbook which would ensures that a target server (all RHEL 7 in this situation) has a key & CSR. openssl_privatekey runs but openssl_publickey fails with the message “the python pyOpenSSL module is required” despite it being installed\r\n\r\n##### ... | 019a48361b8f39e96e5b7b78a5882a8ac774b80a | {
"head_commit": "1d3295dbd360eed64f7e1c5693e365a2abb737bc",
"head_commit_message": "Include Python lib versions in lib required error messages, if available.",
"patch_to_review": "diff --git a/lib/ansible/modules/crypto/get_certificate.py b/lib/ansible/modules/crypto/get_certificate.py\nindex e84a6bbd1c8930..a8d... | [
{
"diff_hunk": "@@ -22,7 +22,8 @@\n - Keys are generated in PEM format.\n - This module works only if the version of PyOpenSSL is recent enough (> 16.0.0).\n requirements:\n- - python-pyOpenSSL\n+ - pyOpenSSL\n+ - cryptography (if I(format) is C(OpenSSL))",
"line": null,
"original_line"... | 16762a638507f7f18c0f35160c9fb3bd3cc502c7 | diff --git a/changelogs/fragments/57868-crypto-improve-req-errors.yml b/changelogs/fragments/57868-crypto-improve-req-errors.yml
new file mode 100644
index 00000000000000..44d5b0d7a99bdc
--- /dev/null
+++ b/changelogs/fragments/57868-crypto-improve-req-errors.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- "crypto modules - improve ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
activeloopai__deeplake-1288@09160c9 | activeloopai/deeplake | Python | 1,288 | tensor.clear() to delete all samples from tensor | ## 🚀 🚀 Pull Request
### Checklist:
- [x] [My code follows the style guidelines of this project](https://www.notion.so/activeloop/Engineering-Guidelines-d6e502306d0e4133a8ca507516d1baab) and the [Contributing document](https://github.com/activeloopai/Hub/blob/release/2.0/CONTRIBUTING.md)
- [x] I have commente... | 2021-10-24T21:24:02Z | [FEATURE] Add method to delete all samples from tensor
## 🚨🚨 Feature Request
- [ ] Related to an existing [Issue](../issues)
- [x] A new implementation (Improvement, Extension)
### If your feature will improve `HUB`
Add a `tensor.clear()` method that deletes all data from a tensor. The tensor itself shoul... | Hey, can I do this? I am interested but I will need some help since I am new to it.
Hey @pranatimittal, greetings and welcome to Hub! Great to hear that you're interested in contributing. Do you have an initial approach to solve this problem? We can help you out better that way!
@dhiganthrao I was think to take tensor ... | [
{
"body": "## 🚨🚨 Feature Request\r\n\r\n- [ ] Related to an existing [Issue](../issues) \r\n- [x] A new implementation (Improvement, Extension) \r\n\r\n### If your feature will improve `HUB`\r\n\r\nAdd a `tensor.clear()` method that deletes all data from a tensor. The tensor itself should not be deleted from ... | 536aa8882fd3e306827daaef1fbdf778bcbc8bd3 | {
"head_commit": "09160c900237218b44fc14a8a2c35541c3831b9e",
"head_commit_message": "update meta + test",
"patch_to_review": "diff --git a/hub/api/tests/test_api.py b/hub/api/tests/test_api.py\nindex 4cb4b28a31..1229609da9 100644\n--- a/hub/api/tests/test_api.py\n+++ b/hub/api/tests/test_api.py\n@@ -794,3 +794,20... | [
{
"diff_hunk": "@@ -543,6 +546,30 @@ def append(self, sample: SampleValue):\n \"\"\"Formats a single `sample` (compresseses/decompresses if applicable) and feeds it into `_append_bytes`.\"\"\"\n self.extend([sample])\n \n+ def clear(self):\n+ \"\"\"Deletes all samples.\"\"\"\n+ ... | 32c4ec2ddd3524d77cd839de6b3373b5fa766a0f | diff --git a/hub/api/tests/test_api.py b/hub/api/tests/test_api.py
index 807cb3a935..4c406c9508 100644
--- a/hub/api/tests/test_api.py
+++ b/hub/api/tests/test_api.py
@@ -8,6 +8,7 @@
from hub.tests.common import assert_array_lists_equal
from hub.tests.storage_fixtures import enabled_remote_storages
+from hub.tests.... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-57850@db64635 | ansible/ansible | Python | 57,850 | ssh: Ensure debug messages are properly converted to text | ##### SUMMARY
ssh: Ensure debug messages are properly converted to text. Fixes #57843
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/plugins/connection/ssh.py
##### ADDITIONAL INFORMATION
<!--- Include additional information to help people understand the change here -->
<!--- A st... | 2019-06-14T14:23:10Z | ssh: UnicodeDecodeError: 'ascii' codec can't decode byte
##### SUMMARY
Executing a playbook in verbose 3 (-vvv) leads to the following error:
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 63: ordinal not in range(128)
fatal: [server]: FAILED! => {
"msg": "Unexpected failure during mod... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner ---> | [
{
"body": "##### SUMMARY\r\nExecuting a playbook in verbose 3 (-vvv) leads to the following error:\r\n\r\n> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 63: ordinal not in range(128)\r\nfatal: [server]: FAILED! => {\r\n \"msg\": \"Unexpected failure during module execution.\",\r\n ... | 78f87f245130793d6ca14d2a6ced8f04e71101e5 | {
"head_commit": "db646357873922d55de7b85996f1903696da2464",
"head_commit_message": "surrogate_then_replace is default, be less explicit",
"patch_to_review": "diff --git a/changelogs/fragments/ssh-fix-text-conv.yml b/changelogs/fragments/ssh-fix-text-conv.yml\nnew file mode 100644\nindex 00000000000000..64eed8f4c... | [
{
"diff_hunk": "@@ -321,23 +321,23 @@ def _handle_error(remaining_retries, command, return_tuple, no_log, host, displa\n if command == b'sshpass':\n # Error 5 is invalid/incorrect password. Raise an exception to prevent retries from locking the account.\n if return_tuple[0] == 5:\n- ... | 08737ec0d36ecd771f39384ddcd9074e7daae13d | diff --git a/changelogs/fragments/ssh-fix-text-conv.yml b/changelogs/fragments/ssh-fix-text-conv.yml
new file mode 100644
index 00000000000000..64eed8f4c17c26
--- /dev/null
+++ b/changelogs/fragments/ssh-fix-text-conv.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- ssh connection plugin - Ensure that debug messages are properly enco... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-57744@dc0ceff | ansible/ansible | Python | 57,744 | Fix --diff to produce output when creating a new file | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
https://github.com/ansible/ansible/pull/51350 removed apending `state: absent` for missing files in the module's result. However `_get_diff_data` method was specifically checking for `absent` in the result. This changes that t... | 2019-06-12T10:25:51Z | Regression: --diff does not produce output when template creates new file
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### S... | Files identified in the description:
* [`lib/ansible/modules/files/template.py`](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/files/template.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot he... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 6537d1bc0f337c9e80f963230d42eafc3b16b7e4 | {
"head_commit": "dc0ceff89a3bc58a44457c1e1502b8289d431fc8",
"head_commit_message": "Fix --diff to produce output when creating a new file\n\nFixes #57618",
"patch_to_review": "diff --git a/changelogs/fragments/57618-fix-diff-on-absent-files.yaml b/changelogs/fragments/57618-fix-diff-on-absent-files.yaml\nnew fil... | [
{
"diff_hunk": "@@ -1104,7 +1104,7 @@ def _get_diff_data(self, destination, source, task_vars, source_file=True):\n \n if not peek_result.get('failed', False) or peek_result.get('rc', 0) == 0:\n \n- if peek_result.get('state') == 'absent':\n+ if peek_result.get('state') is None:",
... | 8dfcf7cfa401a407047a3911645cc3c2ecc24162 | diff --git a/changelogs/fragments/57618-fix-diff-on-absent-files.yaml b/changelogs/fragments/57618-fix-diff-on-absent-files.yaml
new file mode 100644
index 00000000000000..a45790319a0520
--- /dev/null
+++ b/changelogs/fragments/57618-fix-diff-on-absent-files.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+ - "Fix --diff to produce o... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-57222@f0c59d4 | ansible/ansible | Python | 57,222 | file: return 'useful' error message for recursion error | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #56397
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short nam... | 2019-05-31T12:03:32Z | state=directory and recursive=yes with symlink to the path throw an exception
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
###... | Files identified in the description:
* [lib/ansible/modules/files/file.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/files/file.py)
* [lib/ansible/modules/system/filesystem.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/filesystem.py)
If these files are inaccurate,... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 4c7fff315e0e970a3d80dbc89319d117433c747f | {
"head_commit": "f0c59d4cc08185ecaa6d1cf71f47c2442597bb7b",
"head_commit_message": "Fix line length",
"patch_to_review": "diff --git a/changelogs/fragments/56397-file-return-more-useful-error-for-recursion.yaml b/changelogs/fragments/56397-file-return-more-useful-error-for-recursion.yaml\nnew file mode 100644\ni... | [
{
"diff_hunk": "@@ -319,35 +319,44 @@ def get_state(path):\n # This should be moved into the common file utilities\n def recursive_set_attributes(b_path, follow, file_args, mtime, atime):\n changed = False\n- for b_root, b_dirs, b_files in os.walk(b_path):\n- for b_fsobj in b_dirs + b_files:\n- ... | 3749c575a54f042b35297aca1fb7a9577446d63c | diff --git a/changelogs/fragments/56397-file-return-more-useful-error-for-recursion.yaml b/changelogs/fragments/56397-file-return-more-useful-error-for-recursion.yaml
new file mode 100644
index 00000000000000..70bf4d87bc6833
--- /dev/null
+++ b/changelogs/fragments/56397-file-return-more-useful-error-for-recursion.yaml... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-57281@51bdea7 | ansible/ansible | Python | 57,281 | win_acl: Fix problems with special IDRef in different languages than english | ##### SUMMARY
Fixes #56757
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
win_acl.ps1
##### ADDITIONAL INFORMATION | 2019-06-02T17:31:02Z | win_acl: User Name to SID Conversion Issue
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
When trying to set the... | Files identified in the description:
* [lib/ansible/modules/windows/win_acl.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_acl.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot he... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nWhen trying to set the permission usi... | 012609b09af00de13e50fc25713594e46c490bdf | {
"head_commit": "51bdea7cabcce390ec1d7daed67dcca14c159408",
"head_commit_message": "Changelog added",
"patch_to_review": "diff --git a/changelogs/fragments/Make-Win_acl-Ignore-language-diff-in-IDRefs.yml b/changelogs/fragments/Make-Win_acl-Ignore-language-diff-in-IDRefs.yml\nnew file mode 100644\nindex 000000000... | [
{
"diff_hunk": "@@ -161,11 +161,12 @@ Try {\n # Workaround to handle special use case 'APPLICATION PACKAGE AUTHORITY\\ALL APPLICATION PACKAGES' and\n # 'APPLICATION PACKAGE AUTHORITY\\ALL RESTRICTED APPLICATION PACKAGES'- can't translate fully qualified name (win32 API bug/oddity)\n # 'ALL APPLICATI... | 64cce654a33c9d5dff7b1553de070d0018634024 | diff --git a/changelogs/fragments/Make-Win_acl-Ignore-language-diff-in-IDRefs.yml b/changelogs/fragments/Make-Win_acl-Ignore-language-diff-in-IDRefs.yml
new file mode 100644
index 00000000000000..af3cd622f2f064
--- /dev/null
+++ b/changelogs/fragments/Make-Win_acl-Ignore-language-diff-in-IDRefs.yml
@@ -0,0 +1,2 @@
+bug... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-56966@8b8b376 | ansible/ansible | Python | 56,966 | win_format - Add allocation_unit_size | ##### SUMMARY
Fixes #56961
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
win_format
##### ADDITIONAL INFORMATION
Added `allocation_unit_size` support for `win_format`. Was added initially then removed after the re-write. Putting it back in with this.
Added a note in the docs to specify us... | 2019-05-26T07:04:10Z | win_format: allocation_unit_size has no effect
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain the p... | Files identified in the description:
* [lib/ansible/modules/windows/win_format.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_format.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for ... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | a7837edcf26e1e8542109952a9117e145c4cba1d | {
"head_commit": "8b8b376aa8bb20fcf3be2e39083e4e98fbb04008",
"head_commit_message": "Update tests for 2012/R2",
"patch_to_review": "diff --git a/changelogs/fragments/56966-win_format-allocation-unit-size.yml b/changelogs/fragments/56966-win_format-allocation-unit-size.yml\nnew file mode 100644\nindex 000000000000... | [
{
"diff_hunk": "@@ -28,28 +28,31 @@\n drive_letter: T\n new_label: Formatted\n full: True\n+ allocation_unit_size: 8192\n register: format_result_check\n check_mode: True\n+ ignore_errors: True",
"line": null,
"original_line": 34,
"original_start_line": null,
"path": "test/in... | 682d7a3e5dd9e6ef356d3011d5087c58e0c06848 | diff --git a/changelogs/fragments/56966-win_format-allocation-unit-size.yml b/changelogs/fragments/56966-win_format-allocation-unit-size.yml
new file mode 100644
index 00000000000000..5ad05610e7eb29
--- /dev/null
+++ b/changelogs/fragments/56966-win_format-allocation-unit-size.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - win_fo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
apache__tvm-7083@ed30d60 | apache/tvm | Python | 7,083 | [RELAY,TOPI] Threefry PRNG: splittable and stateless | This PR adds a fast PRNG to Relay for use in dropout and batch norm. The PRNG is stateless: for a given key, it always returns the same random number. It is also splittable: for a given key, we can split the key to generate two new ones.
JAX provides a good explanation of stateless and splittable: https://jax.readth... | 2020-12-10T19:27:03Z | [RELAY] Support Random Number Generator
This is a consolidated thread of relay's PRNG support. PRNG are usually considered as stateful, as a result, we will need to support the following features
- Basic block normal form (allowing reading of ref in the begining of the basic block and write to write in the end)
- S... | cc @altanh @junrushao1994 @jroesch @antinucleon | [
{
"body": "This is a consolidated thread of relay's PRNG support. PRNG are usually considered as stateful, as a result, we will need to support the following features\r\n\r\n- Basic block normal form (allowing reading of ref in the begining of the basic block and write to write in the end)\r\n- Support referenc... | 7a3278af4aa8719fb0ffab0b839fceaee88a21b9 | {
"head_commit": "ed30d60595ab18e65d7ca7c23120a7fcd676fd22",
"head_commit_message": "lint fix",
"patch_to_review": "diff --git a/include/tvm/relay/attrs/random.h b/include/tvm/relay/attrs/random.h\nnew file mode 100644\nindex 000000000000..8238f102dab8\n--- /dev/null\n+++ b/include/tvm/relay/attrs/random.h\n@@ -0... | [
{
"diff_hunk": "@@ -0,0 +1,134 @@\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements. See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership. The ASF licenses this file\n+# to you under the Apache L... | e3e8af2ba3c737adf38c66880d1a611f5245a2ed | diff --git a/include/tvm/relay/attrs/random.h b/include/tvm/relay/attrs/random.h
new file mode 100644
index 000000000000..8238f102dab8
--- /dev/null
+++ b/include/tvm/relay/attrs/random.h
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-56679@5e79e31 | ansible/ansible | Python | 56,679 | Added 'use' option to hostname | fixes #25543
##### SUMMARY
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Feature Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
modules/hostname | 2019-05-20T23:04:40Z | hostname fails when systemd is installed but dbus is not running
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
hostname module
##### ANSIBLE VERSION
```
ansible 2.2.1.0
```
##### OS / ENVIRONMENT
Debian Jessie
##### SUMMARY
On systems without dbus, ansible's hostname module fails with error:
... | cc @alikins @saito-hideki
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
This error happens when `systemd` is installed but `dbus` isn't. I guess it could occur when remote user isn't `root` and `libpam-systemd` isn't installed.
When systemd... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\nhostname module\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.2.1.0\r\n```\r\n\r\n##### OS / ENVIRONMENT\r\nDebian Jessie\r\n\r\n##### SUMMARY\r\n\r\nOn systems without dbus, ansible's hostname module fails with error:\r\n\r\n```\r\n... | 493cf817a920542fc3d791e1bafdc52c05cbc06d | {
"head_commit": "5e79e318579490d50f7709170141369d986014c5",
"head_commit_message": "Added 'use' option to hostname\n\n fixes #25543",
"patch_to_review": "diff --git a/changelogs/fragments/hostname_use.yml b/changelogs/fragments/hostname_use.yml\nnew file mode 100644\nindex 00000000000000..bcf4e83625513b\n--- /d... | [
{
"diff_hunk": "@@ -724,7 +738,8 @@ class NeonHostname(Hostname):\n def main():\n module = AnsibleModule(\n argument_spec=dict(\n- name=dict(required=True)\n+ name=dict(type='str', required=True),\n+ use=dict(type='str', choices=['generic', 'debian', 'sles', 'redhat'... | 7628898e9571169fa10a785a4c815e511d67890e | diff --git a/changelogs/fragments/hostname_use.yml b/changelogs/fragments/hostname_use.yml
new file mode 100644
index 00000000000000..bcf4e83625513b
--- /dev/null
+++ b/changelogs/fragments/hostname_use.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - added ``use`` option to ``hostname`` module to allow user to override auto... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
apache__tvm-5368@3b87322 | apache/tvm | Python | 5,368 | [TIR] Fix lower_warp_memory when there are >1 warp buffers | Fix #5366.
Changes:
1. Fixed the recursion. (Just look at the code)
2. Added a test.
Requesting for a review. @tqchen | 2020-04-18T08:00:30Z | [TIR] lower_warp_memory cannot handle >1 warp buffers
Pass `lower_warp_memory` cannot handle more than one warp buffers. Buffers except the first one cannot be correctly transformed to warp shuffles.
To reproduce:
```python
import tvm ... | [
{
"body": "Pass `lower_warp_memory` cannot handle more than one warp buffers. Buffers except the first one cannot be correctly transformed to warp shuffles.\r\n\r\nTo reproduce:\r\n\r\n```python\r\nimport tvm ... | 3db8880d7d26e2e46063685d63e5fcb924556d25 | {
"head_commit": "3b873226b777365f24b4ab25175244ffa19fade5",
"head_commit_message": "fix recursion in lower_warp_memory",
"patch_to_review": "diff --git a/src/tir/transforms/lower_warp_memory.cc b/src/tir/transforms/lower_warp_memory.cc\nindex 71e7cfaf4832..543d098a654c 100644\n--- a/src/tir/transforms/lower_warp... | [
{
"diff_hunk": "@@ -379,7 +379,7 @@ class WarpMemoryRewriter : private StmtMutator {\n Stmt VisitStmt_(const AllocateNode* op) {\n if (warp_buffer_.count(op->buffer_var.get())) {\n WarpAccessRewriter rewriter(warp_size_, &analyzer_);\n- return rewriter.Rewrite(op);\n+ return StmtMutator::V... | 0fdb6dc13fc4ca73d76323902f68d4b134fec9b7 | diff --git a/src/tir/transforms/lower_warp_memory.cc b/src/tir/transforms/lower_warp_memory.cc
index 71e7cfaf4832..0aee3c284422 100644
--- a/src/tir/transforms/lower_warp_memory.cc
+++ b/src/tir/transforms/lower_warp_memory.cc
@@ -377,12 +377,13 @@ class WarpMemoryRewriter : private StmtMutator {
private:
Stmt V... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
ansible__ansible-56569@0fc34b1 | ansible/ansible | Python | 56,569 | Fix win_iis_virtualdirectory to remove a virtual directory that contains children | ##### SUMMARY
Fix #49755 - recursive removal
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
win_iis_virtualdirectory.ps1
##### ADDITIONAL INFORMATION
| 2019-05-17T10:25:57Z | win_iis_virtualdirectory - unable to remove virtual directory with children
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
#####... | Files identified in the description:
* [lib/ansible/modules/windows/win_iis_virtualdirectory.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/windows/win_iis_virtualdirectory.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bo... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 2897cf43cea3d61b9673ce14ba796a663d99f19d | {
"head_commit": "0fc34b1acbcabf67ef726d6fd2a676156cbaea91",
"head_commit_message": "FIX #49755",
"patch_to_review": "diff --git a/lib/ansible/modules/windows/win_iis_virtualdirectory.ps1 b/lib/ansible/modules/windows/win_iis_virtualdirectory.ps1\nindex 5d3542e3a8f600..92af7e9195032c 100644\n--- a/lib/ansible/mod... | [
{
"diff_hunk": "@@ -65,7 +65,7 @@ try {\n \n # Remove directory\n If ($state -eq 'absent' -and $directory) {\n- Remove-Item $directory_path\n+ Remove-Item $directory_path -Recurse",
"line": null,
"original_line": 68,
"original_start_line": null,
"path": "lib/ansible/modules/windows/win... | 2e025891961f12621a5c6b5aee60a7dd518d6c62 | diff --git a/changelogs/fragments/56569-Support-recursive-removal-win_iis_virtualdirectory.yml b/changelogs/fragments/56569-Support-recursive-removal-win_iis_virtualdirectory.yml
new file mode 100644
index 00000000000000..fb20dfd9262b5f
--- /dev/null
+++ b/changelogs/fragments/56569-Support-recursive-removal-win_iis_vi... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-56567@ce2e515 | ansible/ansible | Python | 56,567 | correct behaviour of win_iis when using site_id if site not found | ##### SUMMARY
Fixed #47057 , site_id not used if no sites exist already and creating a new site
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
win_iis_website .ps1
##### ADDITIONAL INFORMATION
<!--- Include additional information to help people understand the change here -->
<!--- A step-by... | 2019-05-17T09:35:42Z | win_iis_website site_id parameter does not work when there is no site in IIS
SUMMARY
When there is no site created in IIS, the site_id parameter is ignored and the new site is created with ID 1
ISSUE TYPE
Bug Report
COMPONENT NAME
win_iis_website
ANSIBLE VERSION
ansible 2.5.2
config file = /etc/an... | I think the problem is on line 87
if ($sites_list -eq $null) { $site_parameters.ID = 1 }
Hi @Tlanute, thank you for submitting this issue!
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: thank_submitter --->
cc @dagwieers @jborean93 @jhawkesworth @ni... | [
{
"body": "SUMMARY\r\nWhen there is no site created in IIS, the site_id parameter is ignored and the new site is created with ID 1\r\n\r\nISSUE TYPE\r\n Bug Report\r\n\r\nCOMPONENT NAME\r\n\r\nwin_iis_website\r\n\r\nANSIBLE VERSION\r\n\r\nansible 2.5.2\r\n config file = /etc/ansible/ansible.cfg\r\n configured... | c6b40f4d40448ac01ce366688c34dbf160ee5b79 | {
"head_commit": "ce2e5156b91511381fe7213f0081faf9b9935c23",
"head_commit_message": "Fix trailing whitespace",
"patch_to_review": "diff --git a/changelogs/fragments/56567-Fix-win_iis_website-id assignment-for-first-new-site.yml b/changelogs/fragments/56567-Fix-win_iis_website-id assignment-for-first-new-site.yml\... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+bugfixes:\n+ - win_iis_website - \"Fixed #47057 , site_id not used if no sites exist already and creating a new site\"",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "changelogs/fragments/56567-Fix-win_iis_website-id assignment-for-fir... | 7ca8d303da28b42b68dbcbcc929e76cfda1b42c4 | diff --git a/changelogs/fragments/56567-Fix-win_iis_website-id assignment-for-first-new-site.yml b/changelogs/fragments/56567-Fix-win_iis_website-id assignment-for-first-new-site.yml
new file mode 100644
index 00000000000000..515c1c2d88f267
--- /dev/null
+++ b/changelogs/fragments/56567-Fix-win_iis_website-id assignmen... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-56549@7ad87d1 | ansible/ansible | Python | 56,549 | apt: honor cache_update=false on auto-install deps | ##### SUMMARY
Fixed the issue the cache being updated while auto-installing its
dependencies even ``update_cache`` is set to false. Fixes #51489
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task o... | 2019-05-16T21:54:39Z | apt does not honor update_cache
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
ansible/lib/python2.7/site-packages/ansible/modules/packaging/os/apt.py
##### ANSIBLE VERSION
<!--- Paste verbatim output from "ansible --version" between quotes -->
```
ansible 2.7.6
config file = /etc/ansible/ansible.cf... | Files identified in the description:
* [lib/ansible/modules/packaging/os/apt.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/packaging/os/apt.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot ... | [
{
"body": "##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nansible/lib/python2.7/site-packages/ansible/modules/packaging/os/apt.py\r\n\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes -->\r\n```\r\nansible 2.7.6\r\n config file = /etc/ansible... | e41f1a4d7d8d7331bd338a62dcd880ffe27fc8ea | {
"head_commit": "7ad87d154bf280c82c7ed0db6a03a7f2fd50edf3",
"head_commit_message": "add porting guide",
"patch_to_review": "diff --git a/changelogs/fragments/51489-apt-not-honor-update-cache.yml b/changelogs/fragments/51489-apt-not-honor-update-cache.yml\nnew file mode 100644\nindex 00000000000000..4f9ebca4faa98... | [
{
"diff_hunk": "@@ -0,0 +1,4 @@\n+---\n+bugfixes:\n+- apt - Fixed the issue the cache being updated while auto-installing its\n+ dependencies even ``update_cache`` is set to false.",
"line": null,
"original_line": 4,
"original_start_line": null,
"path": "changelogs/fragments/51489-apt-not-honor... | b58c50ddfef9131e01478289c8d79011715f6370 | diff --git a/changelogs/fragments/51489-apt-not-honor-update-cache.yml b/changelogs/fragments/51489-apt-not-honor-update-cache.yml
new file mode 100644
index 00000000000000..ac04978a5010a3
--- /dev/null
+++ b/changelogs/fragments/51489-apt-not-honor-update-cache.yml
@@ -0,0 +1,4 @@
+---
+bugfixes:
+- apt - Fixed the is... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-56055@2258ba2 | ansible/ansible | Python | 56,055 | file: fix setting relative paths for src for hard links | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #55971
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short nam... | 2019-05-03T16:02:06Z | file state=hard fails with relative path, docs say it should pass
##### SUMMARY
The docs say that the file module accepts a relative path for `src`. But if you try that with `state=hard` it fails.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
file module
##### ANSIBLE VERSION
<!--- Paste verbati... | Files identified in the description:
* [lib/ansible/modules/files/file.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/files/file.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https:... | [
{
"body": "##### SUMMARY\r\n\r\nThe docs say that the file module accepts a relative path for `src`. But if you try that with `state=hard` it fails.\r\n\r\n##### ISSUE TYPE\r\n\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\n\r\nfile module\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansib... | 95d1564f703eda5ac5691b43b172513c0d5effcb | {
"head_commit": "2258ba21e8c40d0c5d783eaa986a0dd835ed0b3a",
"head_commit_message": "Add relpath test",
"patch_to_review": "diff --git a/changelogs/fragments/55971-file-relative-path-hard-link.yaml b/changelogs/fragments/55971-file-relative-path-hard-link.yaml\nnew file mode 100644\nindex 00000000000000..0d06c14c... | [
{
"diff_hunk": "@@ -588,12 +585,77 @@\n stat: path={{output_dir}}/test_follow_rec_target_dir/foo\n register: file_in_dir_result\n \n-- debug: var=file_result.stat.mode\n-- debug: var=dir_result.stat.mode\n-- debug: var=file_in_dir_result.stat.mode\n - name: assert that the link targets were modified\n ass... | 97f25ae1c5e6a4b00b4f89fb22699cb4cc6c3c86 | diff --git a/changelogs/fragments/55971-file-relative-path-hard-link.yaml b/changelogs/fragments/55971-file-relative-path-hard-link.yaml
new file mode 100644
index 00000000000000..0d06c14c34c028
--- /dev/null
+++ b/changelogs/fragments/55971-file-relative-path-hard-link.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+ - file - Fix s... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-55840@62980b2 | ansible/ansible | Python | 55,840 | fix combine filter using undefined vars | ##### SUMMARY
Fixes #55810
The combine filter ignores undefined variables leading to unexpected errors. Fail instead, with a helpful message.
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
lib/ansible/plugins/filter/core.py
| 2019-04-26T23:29:49Z | Combine filter does not produce dict(but text) if undefined variable is used
##### SUMMARY
When undefined variable is used inside combine filter and result output is not dict but plain text.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
combine() filter
##### ANSIBLE VERSION
```
ansible-playbook 2.... | Files identified in the description:
* [lib/ansible/plugins/filter](https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/filter)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/a... | [
{
"body": "##### SUMMARY\r\nWhen undefined variable is used inside combine filter and result output is not dict but plain text.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\ncombine() filter\r\n\r\n##### ANSIBLE VERSION\r\n\r\n```\r\nansible-playbook 2.7.9\r\n config file = /etc/ansibl... | 2feda390b5372b06e786b96941d98267830e9de0 | {
"head_commit": "62980b2d53db04a9eb9187a42c5e6c46fd96dc47",
"head_commit_message": "Add tests for the combine filter",
"patch_to_review": "diff --git a/lib/ansible/plugins/filter/core.py b/lib/ansible/plugins/filter/core.py\nindex a739e2bd5fa41b..b10841f0881528 100644\n--- a/lib/ansible/plugins/filter/core.py\n+... | [
{
"diff_hunk": "@@ -292,6 +292,20 @@ def mandatory(a):\n return a\n \n \n+def recursive_check_defined(item):",
"line": null,
"original_line": 295,
"original_start_line": null,
"path": "lib/ansible/plugins/filter/core.py",
"start_line": null,
"text": "@user1:\nthis might be better hou... | d7d05b93aeb5c4100c27096a7987935d01c36607 | diff --git a/changelogs/fragments/55840-combine-filter-undefined-variables.yaml b/changelogs/fragments/55840-combine-filter-undefined-variables.yaml
new file mode 100644
index 00000000000000..6b50d0904b25e4
--- /dev/null
+++ b/changelogs/fragments/55840-combine-filter-undefined-variables.yaml
@@ -0,0 +1,2 @@
+bugfixes:... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-55815@f479930 | ansible/ansible | Python | 55,815 | ovirt vmpools creating vm options | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
ovirt vmpools creating vm options
@machacekondra what other options should I add?
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #55344
##### ISSUE TYPE
<!--- Pick one below and delete th... | 2019-04-26T13:05:30Z | [RFE] Extend ovirt_pool Module - VM Definitions
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Describe the new feature/improvement briefly below -->
The ovirt_pool module needs... | Files identified in the description:
* [lib/ansible/modules/cloud/misc/cloud_init_data_facts.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/misc/cloud_init_data_facts.py)
* [lib/ansible/modules/cloud/ovirt/ovirt_vm.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Describe the new feature/improvement briefly below -->\r\n\r\nThe ovirt_pool module needs to be able to pr... | cef536fd5133205ea16353846ce42ba85acae6a9 | {
"head_commit": "f479930dad83ca048d128cb9b8f2ca979826091d",
"head_commit_message": "ovirt vm pools update docs",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py b/lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py\nindex a2f2adfdc13aae..f7383ca7bdc721 100644\n--- a/lib/ansible/modul... | [
{
"diff_hunk": "@@ -81,31 +81,152 @@\n description:\n - \"Number of VMs in the pool.\"\n - \"Default value is set by engine.\"\n+ vm:\n+ description:\n+ - \"For creating vm poool without editing template.\"\n+ - \"Note: You can use C(vm) only for c... | 4ed9dddf61016e0c4440b30cc57e268df158c23c | diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py b/lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py
index a2f2adfdc13aae..df4bad78dddb61 100644
--- a/lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py
+++ b/lib/ansible/modules/cloud/ovirt/ovirt_vmpool.py
@@ -81,6 +81,71 @@
description:
- "... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-55728@6a7c275 | ansible/ansible | Python | 55,728 | Restore ansible --version output | ##### SUMMARY
Fixes #55710
The default formatting class used by `argparse` strips newline characters, resulting in the output of `ansible --version` being a single string.
Implement a custom action to print out the already formatted version string and add tests to prevent future regressions.
##### ISSUE TYP... | 2019-04-24T19:01:19Z | Ansible --version no longer prints version on new line
##### SUMMARY
The syntax of the `ansible --version` changed unexpectedly, and is now more complex to parse, and breaks version parsing tools.
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
lib/ansible/cli/adhoc.py
##### ANSIBLE VERSION
```paste bel... | Files identified in the description:
* [lib/ansible/cli/adhoc.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/cli/adhoc.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansib... | [
{
"body": "##### SUMMARY\r\nThe syntax of the `ansible --version` changed unexpectedly, and is now more complex to parse, and breaks version parsing tools.\r\n\r\n##### ISSUE TYPE\r\n- Bug Report\r\n\r\n##### COMPONENT NAME\r\nlib/ansible/cli/adhoc.py\r\n\r\n##### ANSIBLE VERSION\r\n```paste below\r\nansible --... | 9b339de7b6f950450674f2ced2544d5779de9b53 | {
"head_commit": "6a7c2751294d089f4c89f9ee4ea9fc9009370667",
"head_commit_message": "Add integration test for checking ansible --version",
"patch_to_review": "diff --git a/lib/ansible/cli/arguments/option_helpers.py b/lib/ansible/cli/arguments/option_helpers.py\nindex 7ea478c5b0005a..595e3615284d6e 100644\n--- a/... | [
{
"diff_hunk": "@@ -0,0 +1,17 @@\n+#!/usr/bin/env python",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "test/integration/targets/ansible/test_version.py",
"start_line": null,
"text": "@user1:\nInstead of using a script that subprocesses ansible, you can add a t... | a7002181ca1f076f6d91265be45931fc4c67b2fa | diff --git a/docs/bin/generate_man.py b/docs/bin/generate_man.py
index 80253fcd23b415..d4b1ad27152318 100755
--- a/docs/bin/generate_man.py
+++ b/docs/bin/generate_man.py
@@ -116,7 +116,7 @@ def opts_docs(cli_class_name, cli_module_name):
# instantiate each cli and ask its options
cli_klass = getattr(__import... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-55659@af9cb6b | ansible/ansible | Python | 55,659 | remove deprecated get_md5 from stat | fixes #55309
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
stat | 2019-04-23T16:36:11Z | stat contains deprecated call to be removed in 2.9
##### SUMMARY
stat contains call to Display.deprecated or AnsibleModule.deprecate and is scheduled for removal
```
lib/ansible/modules/files/stat.py:468:8: ansible-deprecated-version Deprecated version (2.9) found in call to Display.deprecated or AnsibleModule.dep... | Files identified in the description:
* [lib/ansible/modules/files/stat.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/files/stat.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https:... | [
{
"body": "##### SUMMARY\r\nstat contains call to Display.deprecated or AnsibleModule.deprecate and is scheduled for removal\r\n\r\n```\r\nlib/ansible/modules/files/stat.py:468:8: ansible-deprecated-version Deprecated version (2.9) found in call to Display.deprecated or AnsibleModule.deprecate\r\n```\r\n\r\n###... | 93d24efe377aeafbb4a073cb490f70032fe77e20 | {
"head_commit": "af9cb6b125cbca93864ed92d42dafc4a34ba5a46",
"head_commit_message": "keep get_md5 but hide it",
"patch_to_review": "diff --git a/changelogs/fragments/stat_no_md5.yml b/changelogs/fragments/stat_no_md5.yml\nnew file mode 100644\nindex 00000000000000..070d23ab05d3f8\n--- /dev/null\n+++ b/changelogs/... | [
{
"diff_hunk": "@@ -0,0 +1,2 @@\n+minor_changes:\n+ - removed previously deprecated `get_md5` option from M(stat) module.",
"line": null,
"original_line": 2,
"original_start_line": null,
"path": "changelogs/fragments/stat_no_md5.yml",
"start_line": null,
"text": "@user1:\nDoes the `M(... | 02a16e14c53561196dacaeae3d6a10085f1b27be | diff --git a/changelogs/fragments/stat_no_md5.yml b/changelogs/fragments/stat_no_md5.yml
new file mode 100644
index 00000000000000..f8ea16504e89ee
--- /dev/null
+++ b/changelogs/fragments/stat_no_md5.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - removed previously deprecated ``get_md5`` option from M(stat) module.
diff --... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-55650@86849e9 | ansible/ansible | Python | 55,650 | ovirt vm clone from snapshot | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
ovirt vm clone from snapshot
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #55382
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Feature Pull Request
##### COMPONENT N... | 2019-04-23T13:28:55Z | Extend ovirt_vm module to be able to clone VM from snapshot
##### SUMMARY
Extend ovirt_vm module to be able to clone VM from existing snapshot of another VM.
##### ISSUE TYPE
- Feature Idea
##### COMPONENT NAME
ovirt_vm module
##### ADDITIONAL INFORMATION
There is no ability to clone VM's snapshot in any o... | Files identified in the description:
* [lib/ansible/modules/cloud/ovirt/ovirt_vm.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/ovirt/ovirt_vm.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here ... | [
{
"body": "##### SUMMARY\r\nExtend ovirt_vm module to be able to clone VM from existing snapshot of another VM.\r\n\r\n##### ISSUE TYPE\r\n- Feature Idea\r\n\r\n##### COMPONENT NAME\r\novirt_vm module\r\n\r\n##### ADDITIONAL INFORMATION\r\nThere is no ability to clone VM's snapshot in any of existing ovirt modu... | b442706b543d5e890940d14f9701ebdaae27d83e | {
"head_commit": "86849e979e3b203db53e0b8e71dfe5da967c0f07",
"head_commit_message": "ovirt snapshot update cluster",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_vm.py b/lib/ansible/modules/cloud/ovirt/ovirt_vm.py\nindex 247051b50dae90..52edaf06067311 100644\n--- a/lib/ansible/modules/cl... | [
{
"diff_hunk": "@@ -1254,17 +1273,52 @@ def __get_storage_domain_and_all_template_disks(self, template):\n \n return disks\n \n+ def __get_snapshot(self):\n+\n+ if self.param('srcvm') is None:\n+ return None\n+\n+ if self.param('snapshot') is None:\n+ return None\n... | ba2e13733f6efdf6f08ae68c661feb8e8cfe95f3 | diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_vm.py b/lib/ansible/modules/cloud/ovirt/ovirt_vm.py
index 247051b50dae90..ddba4641a70843 100644
--- a/lib/ansible/modules/cloud/ovirt/ovirt_vm.py
+++ b/lib/ansible/modules/cloud/ovirt/ovirt_vm.py
@@ -784,6 +784,18 @@
- NOTE - If there are multiple next run... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-55624@7ca49c8 | ansible/ansible | Python | 55,624 | Fix notifying handlers by using an exact match | ##### SUMMARY
Fixes #55575
Introduced in 2a469fd9597ac36099e991a1757193e6d3016e63.
'string' in 'stringwithmore' is True, so make sure to wrap listeners in a list to get only exact matches: 'string' in ['stringwithmore'] is False.
##### ISSUE TYPE
- Bugfix Pull Request
| 2019-04-22T20:50:11Z | notify calls an unexpected listener
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain the problem brie... | Files identified in the description:
* [lib/ansible/playbook/handler.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/playbook/handler.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://gi... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 03cac394cc318c7dfb75592920fcf0b4d49185fe | {
"head_commit": "7ca49c82ba1bd6d4de702b7486b550ad334de944",
"head_commit_message": "Fix notifying handlers by using an exact match rather than a string subset if listen is text rather than a list",
"patch_to_review": "diff --git a/lib/ansible/plugins/strategy/__init__.py b/lib/ansible/plugins/strategy/__init__.p... | [
{
"diff_hunk": "@@ -530,6 +530,8 @@ def search_handler_blocks_by_name(handler_name, handler_blocks):\n for listening_handler_block in iterator._play.handlers:\n for listening_handler in listening_handler_block.block:\n ... | d53c11c80b486d4674e740621a3c2580e863e5f4 | diff --git a/changelogs/fragments/55575_notify_handlers_by_exact_match_only.yaml b/changelogs/fragments/55575_notify_handlers_by_exact_match_only.yaml
new file mode 100644
index 00000000000000..ed0015cbac2d85
--- /dev/null
+++ b/changelogs/fragments/55575_notify_handlers_by_exact_match_only.yaml
@@ -0,0 +1,3 @@
+bugfix... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-55384@b7a2f43 | ansible/ansible | Python | 55,384 | Move missing library abort to use rather than import for netconf | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #55381
`ncclient` imports on implementing plugins have also been moved, but the check in the superclass should suffice for all of them.
##... | 2019-04-16T15:54:43Z | Many NXOS Modules fail with 'msg": "ncclient is not installed' for local connection plugin
##### SUMMARY
Many of our NX-OS integration tests started to fail on 4/12/2019 with the following message:
`"msg": "ncclient is not installed"`
We have also seen the problem in `stable-2.7`
NOTE: If we checkout a versio... | Files identified in the description:
* [lib/ansible/module_utils/network/nxos/__init__.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/network/nxos/__init__.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
... | [
{
"body": "##### SUMMARY\r\nMany of our NX-OS integration tests started to fail on 4/12/2019 with the following message:\r\n\r\n`\"msg\": \"ncclient is not installed\"`\r\n\r\nWe have also seen the problem in `stable-2.7`\r\n\r\nNOTE: If we checkout a version of `devel` on 4/7/2019 we don't see the problem.\r\n... | 272dceef4258fdfdc90281ce1d0b02236f16a797 | {
"head_commit": "b7a2f43e6f5fb514b2120cc5c3ec3abac58a6eab",
"head_commit_message": "Move missing library abort to use rather than import",
"patch_to_review": "diff --git a/lib/ansible/plugins/netconf/__init__.py b/lib/ansible/plugins/netconf/__init__.py\nindex 4920b4fbbb0689..a1c718c6b2eadb 100644\n--- a/lib/ans... | [
{
"diff_hunk": "@@ -101,6 +104,11 @@ class NetconfBase(AnsiblePlugin):\n __rpc__ = ['get_config', 'edit_config', 'get_capabilities', 'get']\n \n def __init__(self, connection):\n+ if not HAS_NCCLIENT:\n+ raise AnsibleError(\n+ 'The required \"ncclient\" python library is... | 93909fa153c9ebd36c749a37fd538574210a838a | diff --git a/lib/ansible/plugins/netconf/__init__.py b/lib/ansible/plugins/netconf/__init__.py
index 4920b4fbbb0689..b55bafbb1212a4 100644
--- a/lib/ansible/plugins/netconf/__init__.py
+++ b/lib/ansible/plugins/netconf/__init__.py
@@ -24,13 +24,17 @@
from ansible.errors import AnsibleError
from ansible.plugins impo... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-55379@060b0e9 | ansible/ansible | Python | 55,379 | template add cloud init | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
ovirt template add
usb_support
timezone
sso
soundcard_enabled
smartcard_enabled
nics
cloud_init_persist
cloud_init_nics
cloud_init
ballooning_enabled
Fixes #55342
##### ISSUE TYPE
<!--- Pick one below and d... | 2019-04-16T13:44:52Z | [RFE] Extend ovirt_template Module - VM Definitions
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Describe the new feature/improvement briefly below -->
The **ovirt_template**... | Files identified in the description:
* [lib/ansible/modules/cloud/misc/cloud_init_data_facts.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/misc/cloud_init_data_facts.py)
* [lib/ansible/modules/cloud/ovirt/ovirt_template.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Describe the new feature/improvement briefly below -->\r\n\r\nThe **ovirt_template** module needs to be ab... | 9495ddbc21da2a5c7967f01c4a958d32f203af65 | {
"head_commit": "060b0e9dfcfd87e986386c1b825ce204a5210e75",
"head_commit_message": "remove duplicate version",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_template.py b/lib/ansible/modules/cloud/ovirt/ovirt_template.py\nindex a39a628c477367..d123a7b96af865 100644\n--- a/lib/ansible/mod... | [
{
"diff_hunk": "@@ -189,6 +189,147 @@\n - Name for importing Template from storage domain.\n - If not defined, C(name) will be used.\n version_added: \"2.8\"\n+ usb_support:\n+ description:\n+ - \"I(True) enable USB support, I(False) to disable it. By default... | 762ce6507d4b223c3e45fe323367984c92a3321c | diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_template.py b/lib/ansible/modules/cloud/ovirt/ovirt_template.py
index a39a628c477367..2c7df5978f3bd3 100644
--- a/lib/ansible/modules/cloud/ovirt/ovirt_template.py
+++ b/lib/ansible/modules/cloud/ovirt/ovirt_template.py
@@ -189,6 +189,176 @@
- Name for imp... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-55217@77dd114 | ansible/ansible | Python | 55,217 | Allow botocore configuration for aws modules | ##### SUMMARY
~WIP while still looking at a possible solution for boto modules.~
This PR allows UserAgent to be set for boto modules and allows general configuration for boto3 modules. Many boto configurations can be set by a boto config file like connection timeout and proxy settings. UserAgent is not able to be c... | 2019-04-12T16:31:17Z | Add User-Agent Config for AWS Modules
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Describe the new feature/improvement briefly below -->
Add the ability to specify a user agent... | Files identified in the description:
* [lib/ansible/module_utils/aws/__init__.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/aws/__init__.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bo... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Describe the new feature/improvement briefly below -->\r\nAdd the ability to specify a user agent string f... | 6a8b1f867e03c8462798eb84f758fd48f2c3db2e | {
"head_commit": "77dd11453ffe02f50dd75778a62299f0c2c9f2f8",
"head_commit_message": "play nicely with modules that might be modifying config",
"patch_to_review": "diff --git a/lib/ansible/module_utils/ec2.py b/lib/ansible/module_utils/ec2.py\nindex d8d986dc90315a..4c5b5c94131c9b 100644\n--- a/lib/ansible/module_u... | [
{
"diff_hunk": "@@ -50,6 +50,13 @@ class ModuleDocFragment(object):\n - Uses a boto profile. Only works with boto >= 2.24.0.\n type: str\n version_added: \"1.6\"\n+ aws_config:\n+ description:\n+ - A dictionary to modify the botocore configuration.\n+ - Parameters can be found at U(h... | 94200d18286186d1eb8a038b809d2f808455cde6 | diff --git a/changelogs/fragments/55217-aws-modules-config.yml b/changelogs/fragments/55217-aws-modules-config.yml
new file mode 100644
index 00000000000000..7911c9931e08b3
--- /dev/null
+++ b/changelogs/fragments/55217-aws-modules-config.yml
@@ -0,0 +1,5 @@
+minor_changes:
+ - AWS modules now take an "aws_config" par... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-55089@4f991b0 | ansible/ansible | Python | 55,089 | setup: properly detect is_chroot on Btrfs | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #55006
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short nam... | 2019-04-10T11:50:35Z | is_chroot fails on btrfs for non-root user
##### SUMMARY
When the `setup` module runs with non-root privileges and the root filesystem is on a btrfs (sub-)volume, the `is_chroot` fact is always true, which obviously, is not always correct.
This is due to the the fallback code in [line 25 of `module_utils/facts/system... | Files identified in the description:
* [lib/ansible/module_utils/facts/system/chroot.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/facts/system/chroot.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[cli... | [
{
"body": "##### SUMMARY\r\nWhen the `setup` module runs with non-root privileges and the root filesystem is on a btrfs (sub-)volume, the `is_chroot` fact is always true, which obviously, is not always correct.\r\nThis is due to the the fallback code in [line 25 of `module_utils/facts/system/chroot.py`](../blob... | 56c553c55d75c995ad5a3e4bed590c3fc3679813 | {
"head_commit": "4f991b03f49c2e0fc9cce51420bbd5bcf8d0d7ce",
"head_commit_message": "Use get_bin_path for stat",
"patch_to_review": "diff --git a/changelogs/fragments/55006-setup-is_chroot-btrfs.yaml b/changelogs/fragments/55006-setup-is_chroot-btrfs.yaml\nnew file mode 100644\nindex 00000000000000..b47741bdc1cb1... | [
{
"diff_hunk": "@@ -22,7 +22,18 @@ def is_chroot():\n is_chroot = my_root.st_ino != proc_root.st_ino or my_root.st_dev != proc_root.st_dev\n except Exception:\n # I'm not root or no proc, fallback to checking it is inode #2\n- is_chroot = (my_root.st_ino != 2)\n+ ... | d3f63263d69537ad01744de9bb7461521081b461 | diff --git a/changelogs/fragments/55006-setup-is_chroot-btrfs.yaml b/changelogs/fragments/55006-setup-is_chroot-btrfs.yaml
new file mode 100644
index 00000000000000..b47741bdc1cb1f
--- /dev/null
+++ b/changelogs/fragments/55006-setup-is_chroot-btrfs.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+ - setup - properly detect is_chroot... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-54976@25e991f | ansible/ansible | Python | 54,976 | add wait_for_running option in azure_rm_rediscache module | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
add wait_for_running option to poll wait redis provisioning_state in azure_rm_rediscache module
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes https://github.com/ansible/ansible/issues/54932
... | 2019-04-08T08:05:24Z | azure_rm_rediscache needs to block by default on provisioning ops
##### SUMMARY
Currently, the `azure_rm_rediscache` module returns when the Create or Update operation completes, however this means that in general, the cache is not in a usable state, so further attempts to modify or use it will fail. This is even evid... | Files identified in the description:
* [lib/ansible/modules/cloud/azure/azure_rm_rediscache.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/azure/azure_rm_rediscache.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot ... | [
{
"body": "##### SUMMARY\r\nCurrently, the `azure_rm_rediscache` module returns when the Create or Update operation completes, however this means that in general, the cache is not in a usable state, so further attempts to modify or use it will fail. This is even evident in the tests, most of which require polli... | 4503426f3207ac7a37b34a8e7b7fb4dbc1e2521c | {
"head_commit": "25e991fc205c3cb4ceebfb645c4287dfa360be55",
"head_commit_message": "add wait_for_running",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/azure/azure_rm_rediscache.py b/lib/ansible/modules/cloud/azure/azure_rm_rediscache.py\nindex 308189a3e86eb4..f46146f760173e 100644\n--- a/lib/ansib... | [
{
"diff_hunk": "@@ -131,6 +131,13 @@\n choices:\n - primary\n - secondary\n+ wait_for_running:",
"line": null,
"original_line": 134,
"original_start_line": null,
"path": "lib/ansible/modules/cloud/azure/azure_rm_rediscache.py",
"star... | 8a134ef7ad82c020ca3c81f5a69364f05816229d | diff --git a/lib/ansible/modules/cloud/azure/azure_rm_rediscache.py b/lib/ansible/modules/cloud/azure/azure_rm_rediscache.py
index 308189a3e86eb4..41ccb9e7594f0b 100644
--- a/lib/ansible/modules/cloud/azure/azure_rm_rediscache.py
+++ b/lib/ansible/modules/cloud/azure/azure_rm_rediscache.py
@@ -131,6 +131,14 @@
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-54799@b2bc6f3 | ansible/ansible | Python | 54,799 | ufw: fix default, direction is not necessary for it | ##### SUMMARY
While implementing #49948 and #50402, we forgot to consider that `direction` is not required for `default`. This re-allows not specifying `direction` when `default` is used.
Fixes #53854.
CC @jbarotin
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
ufw
| 2019-04-03T18:21:26Z | Ufw module example does not work because of missing parameter
##### SUMMARY
Documentation for Ufw module gives this example:
```
- name: Allow everything and enable UFW
ufw:
state: enabled
policy: allow
```
Trying to run that task fails with error:
```
TASK [Ufw example] ************************... | Files identified in the description:
* [lib/ansible/modules/system/ufw.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/system/ufw.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https:... | [
{
"body": "##### SUMMARY\r\nDocumentation for Ufw module gives this example:\r\n\r\n```\r\n- name: Allow everything and enable UFW\r\n ufw:\r\n state: enabled\r\n policy: allow\r\n```\r\n\r\nTrying to run that task fails with error:\r\n```\r\nTASK [Ufw example] *******************************************... | e422f1889857dd0a094acf82b7340fbecb7f9023 | {
"head_commit": "b2bc6f3df29689f359dd9fc65f74ff042fa4d30a",
"head_commit_message": "'disabled' values cannot be changed.",
"patch_to_review": "diff --git a/changelogs/fragments/54799-ufw-default-direction.yml b/changelogs/fragments/54799-ufw-default-direction.yml\nnew file mode 100644\nindex 00000000000000..5e46... | [
{
"diff_hunk": "@@ -461,7 +461,7 @@ def ufw_version():\n execute(cmd + [[command], [value]])\n \n elif command == 'default':\n- if params['direction'] not in ['outgoing', 'incoming', 'routed']:\n+ if params['direction'] not in ['outgoing', 'incoming', 'routed', None... | 9dcf893413e02cf65fe21dae896b55e38684936b | diff --git a/changelogs/fragments/54799-ufw-default-direction.yml b/changelogs/fragments/54799-ufw-default-direction.yml
new file mode 100644
index 00000000000000..5e46fc60d9cf35
--- /dev/null
+++ b/changelogs/fragments/54799-ufw-default-direction.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- "ufw - when ``default`` is specified, ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-54633@c45f8d5 | ansible/ansible | Python | 54,633 | openssl_pkcs12: Add idempotency checks | ##### SUMMARY
Adds idempotency checks to the openssl_pkcs12 module and related tests.
Also decoupled `parse` and `generate` from the file write, as they are now used for multiple stuff that don't require the file to be written to disk.
Fixes #53221
##### ISSUE TYPE
- Bugfix Pull Request
##### COMPONENT NAME
... | 2019-03-30T13:36:40Z | openssl_pkcs12: idempotency check is not working
##### SUMMARY
The idempotency check of `openssl_pkcs12` is totally broken. It currently only checks whether the output file is there and has the correct permissions, and nothing else. There is code for a test which checks whether the private key is readable (with the pr... | Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: components_banner --->
!component =... | [
{
"body": "##### SUMMARY\r\nThe idempotency check of `openssl_pkcs12` is totally broken. It currently only checks whether the output file is there and has the correct permissions, and nothing else. There is code for a test which checks whether the private key is readable (with the provided passphrase), but that... | 44c2061c708ca16cebcfbf4fa60a4c73cb86b630 | {
"head_commit": "c45f8d5744070e8fdc8846b5068532784d2bb941",
"head_commit_message": "Added changelog and porting guide",
"patch_to_review": "diff --git a/changelogs/fragments/54633-openssl_pkcs12_idempotency_fixes.yaml b/changelogs/fragments/54633-openssl_pkcs12_idempotency_fixes.yaml\nnew file mode 100644\nindex... | [
{
"diff_hunk": "@@ -303,17 +338,29 @@ def parse(self, module):\n p12.get_privatekey())\n crt = crypto.dump_certificate(crypto.FILETYPE_PEM,\n p12.get_certificate())\n+ ca_certs = []",
"line": null,
... | c378c852e09da5220cec6a25b91af0313528739c | diff --git a/changelogs/fragments/54633-openssl_pkcs12_idempotency_fixes.yaml b/changelogs/fragments/54633-openssl_pkcs12_idempotency_fixes.yaml
new file mode 100644
index 00000000000000..c575f999280f0c
--- /dev/null
+++ b/changelogs/fragments/54633-openssl_pkcs12_idempotency_fixes.yaml
@@ -0,0 +1,2 @@
+minor_changes:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-54631@bbf0812 | ansible/ansible | Python | 54,631 | Added win_http_proxy and win_inet_proxy | ##### SUMMARY
Adds 2 modules that can be used to configure proxy settings on Windows;
* win_http_proxy - Configures proxy settings for WinHTTP
* win_inet_proxy - Configures proxy settings for WinINet (IE)
While the input options are similar, WinINet offers a few extra options and WinHTTP can also import from Wi... | 2019-03-30T11:17:04Z | Module proposal: win_wininet (configure IE proxy settings)
<!---
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release, and master branch are affected too.
-->
##### ISSUE TYPE
<!--- Pick one below and delete the rest: -->
- Feature Idea
##### COMPONENT NAME... | A module for this is acceptable. However win_wininet really looks weird. I wonder if another (more descriptive) name makes more sense, like **win_internet_options** or **win_proxy**.
I would say, go for it !
@dagwieers good point RE name, though **win_proxy** might too ambiguous (wininet vs winhttp); **win_internet_... | [
{
"body": "<!---\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release, and master branch are affected too.\r\n-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\nwin_wininet (propo... | 627c5e7f50cdc6a19c41f5913144e095cf74429a | {
"head_commit": "bbf08126d2cf86ee7f262bce78bb264a9d91a89f",
"head_commit_message": "Added win_http_proxy and win_inet_proxy",
"patch_to_review": "diff --git a/lib/ansible/modules/windows/win_http_proxy.ps1 b/lib/ansible/modules/windows/win_http_proxy.ps1\nnew file mode 100644\nindex 00000000000000..750bb1473dd00... | [
{
"diff_hunk": "@@ -0,0 +1,264 @@\n+#!powershell\n+\n+# Copyright: (c) 2019, Ansible Project\n+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)\n+\n+#AnsibleRequires -CSharpUtil Ansible.Basic\n+#Requires -Module Ansible.ModuleUtils.AddType\n+\n+$spec = @{\n+ option... | 5b6430dba276059b7aeeab4c3b761666abed8195 | diff --git a/lib/ansible/modules/windows/win_http_proxy.ps1 b/lib/ansible/modules/windows/win_http_proxy.ps1
new file mode 100644
index 00000000000000..04ea473b998db2
--- /dev/null
+++ b/lib/ansible/modules/windows/win_http_proxy.ps1
@@ -0,0 +1,267 @@
+#!powershell
+
+# Copyright: (c) 2019, Ansible Project
+# GNU Gener... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-54600@f9c0227 | ansible/ansible | Python | 54,600 | Add ovirt role | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Add ovirt role
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #54199
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- New Module Pull Request
##### COMPONENT NAME
<!--- W... | 2019-03-29T13:35:21Z | RFE: Create ovirt_configure module
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Describe the new feature/improvement briefly below -->
Create module to allow configuration of ... | [11_Configuring_VM_System_Types_Lab.pdf](https://github.com/ansible/ansible/files/2994201/11_Configuring_VM_System_Types_Lab.pdf)
[12_Config_RHVM_Custom_Roles_Lab.pdf](https://github.com/ansible/ansible/files/2994205/12_Config_RHVM_Custom_Roles_Lab.pdf)
Updated with attachments describing at least two (2) problems ... | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Describe the new feature/improvement briefly below -->\r\n\r\nCreate module to allow configuration of para... | b3e85b76d7f5c109ca932942abd1e3ccbb8ebe8c | {
"head_commit": "f9c0227208c01a92753411e9b7ec2cc7e3d78e0b",
"head_commit_message": "use correct syntax fo get_all_permits",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_role.py b/lib/ansible/modules/cloud/ovirt/ovirt_role.py\nnew file mode 100644\nindex 00000000000000..6d298033d71059\n-... | [
{
"diff_hunk": "@@ -0,0 +1,177 @@\n+#!/usr/bin/python\n+# -*- coding: utf-8 -*-\n+#\n+# Copyright (c) 2016 Red Hat, Inc.\n+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)\n+\n+ANSIBLE_METADATA = {'metadata_version': '1.1',\n+ 'status': ['preview'],... | 12910337909f390a004ec6ef5b1b575151ac8805 | diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_role.py b/lib/ansible/modules/cloud/ovirt/ovirt_role.py
new file mode 100644
index 00000000000000..9f1d94e79aa5d4
--- /dev/null
+++ b/lib/ansible/modules/cloud/ovirt/ovirt_role.py
@@ -0,0 +1,190 @@
+#!/usr/bin/python
+# -*- coding: utf-8 -*-
+#
+# Copyright (c) 2016 Re... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-54268@403b068 | ansible/ansible | Python | 54,268 | Add GetSupportedFirmwareUpdateMethods to redfish_facts/Update commands | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
This pull request implements GetSupportedFirmwareUpdateMethods, which returns as a list the supported firmware update methods as shown in the UpdateService schema.
<!--- HINT: Include "Fixes #nnn" if you are fixing an exis... | 2019-03-22T22:07:26Z | redfish_facts - Update - GetSupportedFirmwareUpdateMethods
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Describe the new feature/improvement briefly below -->
This feature would... | @samerhaj
cc @billdodd @jose-delarosa @mraineri @tomasg2012
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Describe the new feature/improvement briefly below -->\r\nThis feature would implement a GetSupportedFirmw... | 919e310b993e65fa671bf8b83951144afc5472f2 | {
"head_commit": "403b068aa2687727d08ed78e7e1b56048d609d42",
"head_commit_message": "fix overindent",
"patch_to_review": "diff --git a/lib/ansible/module_utils/redfish_utils.py b/lib/ansible/module_utils/redfish_utils.py\nindex c32b57bb4c6f7f..cce4a191250c29 100644\n--- a/lib/ansible/module_utils/redfish_utils.py... | [
{
"diff_hunk": "@@ -511,6 +511,42 @@ def update_user_password(self, user):\n return response\n return {'ret': True}\n \n+ def get_firmware_update_capabilities(self):\n+ result = {}\n+ response = self.get_request(self.root_uri + \"/redfish/v1\")",
"line": null,
"origi... | 850eab0b54caedb41f27a67622df0268b3cc2081 | diff --git a/lib/ansible/module_utils/redfish_utils.py b/lib/ansible/module_utils/redfish_utils.py
index c32b57bb4c6f7f..4120297340268f 100644
--- a/lib/ansible/module_utils/redfish_utils.py
+++ b/lib/ansible/module_utils/redfish_utils.py
@@ -511,6 +511,35 @@ def update_user_password(self, user):
return re... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-54030@1a228fd | ansible/ansible | Python | 54,030 | Template run_once for handlers | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
As we do for tasks.
Fixes #27237
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!... | 2019-03-19T13:08:08Z | issue with handlers notification and Jinja2 default value in run_once
##### ISSUE TYPE
- Bug Report
##### COMPONENT NAME
core
##### ANSIBLE VERSION
```
ansible 2.3.1.0
config file =
configured module search path = Default w/o overrides
python version = 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5... | For jinja2 filters you might want to use False as false can end up being interpreted as a string, when using it directly in YAML it will be interpreted as a boolean though.
@bcoca thank for your feedback
the issue still occurs with ` - { role: test-role, run_once: "{{ testvar | default(False) }}" }`
```
PLAY [all... | [
{
"body": "##### ISSUE TYPE\r\n - Bug Report\r\n\r\n##### COMPONENT NAME\r\ncore\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.3.1.0\r\n config file = \r\n configured module search path = Default w/o overrides\r\n python version = 2.7.12 (default, Nov 19 2016, 06:48:10) [GCC 5.4.0 20160609]\r\n```\r\n\r\n... | 2c473259cbc2c0dacc26724b72519bdfa2957972 | {
"head_commit": "1a228fd5167135ecf2bb6c925c20dd58e4dea30d",
"head_commit_message": "Add changelog",
"patch_to_review": "diff --git a/changelogs/fragments/27237-handlers-template-run_once.yaml b/changelogs/fragments/27237-handlers-template-run_once.yaml\nnew file mode 100644\nindex 00000000000000..3e15287fdb890a\... | [
{
"diff_hunk": "@@ -874,7 +872,9 @@ def _do_handler_run(self, handler, handler_name, iterator, play_context, notifie\n run_once = False\n try:\n action = action_loader.get(handler.action, class_only=True)\n- if handler.run_once or getattr(action, 'BYPASS_HOST_LOOP', False)... | 1856e31ead49e1b4fbe7f9a46da6107c274b7375 | diff --git a/changelogs/fragments/27237-handlers-template-run_once.yaml b/changelogs/fragments/27237-handlers-template-run_once.yaml
new file mode 100644
index 00000000000000..3e15287fdb890a
--- /dev/null
+++ b/changelogs/fragments/27237-handlers-template-run_once.yaml
@@ -0,0 +1,2 @@
+bugfixes:
+ - Fix handlers to al... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-54225@9071aa9 | ansible/ansible | Python | 54,225 | fix ansible/ansible#54223 | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #54223 by dropping gratuitous comma in argument_spec
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
#... | 2019-03-22T10:16:54Z | TypeError: unhashable type: 'list' in cloudflare_dns module (from extra comma in argument_spec)
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automa... | Files identified in the description:
* [lib/ansible/modules/net_tools/cloudflare_dns.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/net_tools/cloudflare_dns.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[cli... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\nworks in 2.7.9 but not in 2.8.0dev0. ... | 3c20a9b12b054a455ec54988983005401fe04868 | {
"head_commit": "9071aa9b490626f765d8827626d1e009e764be31",
"head_commit_message": "fix ansible/ansible#54223",
"patch_to_review": "diff --git a/lib/ansible/modules/net_tools/cloudflare_dns.py b/lib/ansible/modules/net_tools/cloudflare_dns.py\nindex 1e1bb6aa4a26af..2f3644f98d91e8 100644\n--- a/lib/ansible/module... | [
{
"diff_hunk": "@@ -794,7 +794,7 @@ def main():\n ('state', 'absent', ['record']),\n ('type', 'SRV', ['proto', 'service']),\n ('type', 'TLSA', ['proto', 'port']),\n- ],\n+ ]",
"line": null,
"original_line": 797,
"original_start_line": null,
"path... | 4c4476d8ac525d1aa944c430784c13ab4ed32631 | diff --git a/lib/ansible/modules/net_tools/cloudflare_dns.py b/lib/ansible/modules/net_tools/cloudflare_dns.py
index 1e1bb6aa4a26af..7dd9008bff7647 100644
--- a/lib/ansible/modules/net_tools/cloudflare_dns.py
+++ b/lib/ansible/modules/net_tools/cloudflare_dns.py
@@ -789,13 +789,12 @@ def main():
zone=dict(... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-54314@ced2047 | ansible/ansible | Python | 54,314 | Add GetChassisPower command to Chassis category of redfish_facts | ##### SUMMARY
This feature request adds a GetChassisPower command for the Chassis category of redfish_facts. The get_chassis_power() function added to redfish_utils implements the retrieval of various wattage-related data for each chassis in the system.
<!--- HINT: Include "Fixes #nnn" if you are fixing an existin... | 2019-03-25T01:58:20Z | redfish_facts - Chassis - GetChassisPower
<!--- Verify first that your feature was not already discussed on GitHub -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Describe the new feature/improvement briefly below -->
This feature would implement a GetC... | @samerhaj
I will code a PR for this.
cc @billdodd @jose-delarosa @mraineri @tomasg2012
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify ---> | [
{
"body": "<!--- Verify first that your feature was not already discussed on GitHub -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Describe the new feature/improvement briefly below -->\r\nThis feature would implement a GetChassisPower c... | c4004b5fb1c9ef2c8c53584c0ac9a199e6900a10 | {
"head_commit": "ced204787dc5096a8ac0903d932ffe64dc6c6ada",
"head_commit_message": "Update lib/ansible/module_utils/redfish_utils.py\n\nCo-Authored-By: xmadsen <xander.madsen@gmail.com>",
"patch_to_review": "diff --git a/lib/ansible/module_utils/redfish_utils.py b/lib/ansible/module_utils/redfish_utils.py\nindex... | [
{
"diff_hunk": "@@ -920,6 +920,44 @@ def get_fan_inventory(self):\n result[\"entries\"] = fan_results\n return result\n \n+ def get_chassis_power(self):\n+ result = {}\n+ key = \"Power\"\n+\n+ # Get these entries, but does not fail if not found\n+ properties = ['Na... | 0f3276cb4a0b6df70294dc3a5503903b1d4a7507 | diff --git a/lib/ansible/module_utils/redfish_utils.py b/lib/ansible/module_utils/redfish_utils.py
index 083b4c3c4c1881..2ea036050be977 100644
--- a/lib/ansible/module_utils/redfish_utils.py
+++ b/lib/ansible/module_utils/redfish_utils.py
@@ -920,6 +920,44 @@ def get_fan_inventory(self):
result["entries"] = fa... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-53934@038ae9f | ansible/ansible | Python | 53,934 | add suboptions in ovirt docs | ##### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Fixes #53797
First part of suboptions.
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Docs Pull Request
##### COMPONENT N... | 2019-03-18T06:35:13Z | Use suboptions in oVirt modules doc
<!--- Verify first that your improvement is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->
##### SUMMARY
<!--- Explain the proble... | Files identified in the description:
* [lib/ansible/module_utils/ovirt.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/ovirt.py)
If these files are inaccurate, please update the `component name` section of the description or use the `!component` bot command.
[click here for bot help](https:... | [
{
"body": "<!--- Verify first that your improvement is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem brief... | 50d56ca89de26317c41c4fb1a777fd7ccdc025a2 | {
"head_commit": "038ae9f05e089aa007b7b64a9aef912fc9f3135a",
"head_commit_message": "add suboptions in doc_fragments/ovirt",
"patch_to_review": "diff --git a/lib/ansible/plugins/doc_fragments/ovirt.py b/lib/ansible/plugins/doc_fragments/ovirt.py\nindex a47e6e2841d342..ac155ba25d9270 100644\n--- a/lib/ansible/plug... | [
{
"diff_hunk": "@@ -30,25 +30,46 @@ class ModuleDocFragment(object):\n auth:\n description:\n - \"Dictionary with values needed to create HTTP/HTTPS connection to oVirt:\"\n- - C(username)[I(required)] - The name of the user, something like I(admin@internal).\n- D... | 0e9cbc9128e6eb98e417f23cc2884e15f4136102 | diff --git a/.github/BOTMETA.yml b/.github/BOTMETA.yml
index 65ca515f9b46e4..423f0be7d33120 100644
--- a/.github/BOTMETA.yml
+++ b/.github/BOTMETA.yml
@@ -1058,6 +1058,8 @@ files:
$plugins/doc_fragments/postgres.py: *postgresql
$plugins/doc_fragments/proxysql.py: *mysql
$plugins/doc_fragments/vultr.py: *vultr
... | {
"difficulty": "low",
"estimated_review_effort": 3,
"problem_domain": "Documentation Updates"
} |
ansible__ansible-53973@ce15035 | ansible/ansible | Python | 53,973 | Handle gracefully a bad module 'results' key | fixes #53962
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- Bugfix Pull Request
##### COMPONENT NAME
<!--- Write the short name of the module, plugin, task or feature below -->
core | 2019-03-18T16:18:01Z | Unexpected Exception, this is probably a bug: argument of type 'int' is not iterable
<!--- Verify first that your issue is not already reported on GitHub -->
<!--- Also test if the latest release and devel branch are affected too -->
<!--- Complete *all* sections as described, this form is processed automatically -->... | Files identified in the description:
* [lib/ansible/modules/cloud/amazon/ec2_customer_gateway.py](https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/cloud/amazon/ec2_customer_gateway.py)
* [lib/ansible/modules/cloud/amazon/ec2_customer_gateway_facts.py](https://github.com/ansible/ansible/blob/devel/lib/a... | [
{
"body": "<!--- Verify first that your issue is not already reported on GitHub -->\r\n<!--- Also test if the latest release and devel branch are affected too -->\r\n<!--- Complete *all* sections as described, this form is processed automatically -->\r\n\r\n##### SUMMARY\r\n<!--- Explain the problem briefly bel... | 3fa39ac818e08a842ac00aa9e69522fef8f87082 | {
"head_commit": "ce150358b864e99ed56585813c3a722d893ba336",
"head_commit_message": "typo",
"patch_to_review": "diff --git a/changelogs/fragments/clean_results.yml b/changelogs/fragments/clean_results.yml\nnew file mode 100644\nindex 00000000000000..71c4fd423b2e0e\n--- /dev/null\n+++ b/changelogs/fragments/clean_... | [
{
"diff_hunk": "@@ -909,6 +910,12 @@ def _execute_module(self, module_name=None, module_args=None, tmp=None, task_var\n if data.pop(\"_ansible_suppress_tmpdir_delete\", False):\n self._cleanup_remote_tmp = False\n \n+ # NOTE: yum returns results .. but that made it 'compatible' with s... | 828952072d101ec90b407d04240436447a3d9eae | diff --git a/changelogs/fragments/clean_results.yml b/changelogs/fragments/clean_results.yml
new file mode 100644
index 00000000000000..71c4fd423b2e0e
--- /dev/null
+++ b/changelogs/fragments/clean_results.yml
@@ -0,0 +1,2 @@
+bugfixes:
+ - disallow non dict results from module and allow user to continue using with ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-53906@fc34346 | ansible/ansible | Python | 53,906 | docker: improve TLS config | ##### SUMMARY
This PR does several things:
- unify TLS setup for inventory plugin and docker modules (not done yet)
- make `tls` and `tls_verify` options no longer mutually exclusive, and let `tls_verify` (host verification) take precedence over `tls` (no host verification) in case both are set to `yes`.
This a... | 2019-03-16T17:41:41Z | docker_common TLS and TLS_Verify not mutually exclusive.
##### ISSUE TYPE
- Bug Report
##### ANSIBLE VERSION
```
ansible 2.1.0 (docker_common 8b50e93151) last updated 2016/04/25 15:04:12 (GMT -400)
lib/ansible/modules/core: (devel 804a8e6378) last updated 2016/04/21 18:24:50 (GMT -400)
lib/ansible/modules/extras: ... | I think that this bug is still valid and there is a very easy way to verify it: testing docker cli behavior.
```bash
# success:
DOCKER_TLS=1 DOCKER_TLS_VERIFY=0 docker ps
# failure with 'parameters are mutually exclusive: tls, tls_verify'
DOCKER_TLS=1 DOCKER_TLS_VERIFY=0 ansible -m docker ....
```
There is no ... | [
{
"body": "##### ISSUE TYPE\n- Bug Report\n##### ANSIBLE VERSION\n\n```\nansible 2.1.0 (docker_common 8b50e93151) last updated 2016/04/25 15:04:12 (GMT -400)\n lib/ansible/modules/core: (devel 804a8e6378) last updated 2016/04/21 18:24:50 (GMT -400)\n lib/ansible/modules/extras: (devel 3031105e78) last updated... | 955da2a0955ba0f527079cacc88fcb5a922af33e | {
"head_commit": "fc34346ab26561f0d1ca8781c54035ac87549266",
"head_commit_message": "PEP8.",
"patch_to_review": "diff --git a/lib/ansible/module_utils/docker/common.py b/lib/ansible/module_utils/docker/common.py\nindex 3c5dacece9dd5d..2af7433b04522d 100644\n--- a/lib/ansible/module_utils/docker/common.py\n+++ b/l... | [
{
"diff_hunk": "@@ -29,7 +29,9 @@\n required: true\n choices: docker_swarm\n host:",
"line": null,
"original_line": 31,
"original_start_line": null,
"path": "lib/ansible/plugins/inventory/docker_swarm.py",
"start_line": null,
"text": "@user1:\nneeds to be ... | bf4ed136906b36d93d6b1d64234a3eeb19dbb22c | diff --git a/lib/ansible/module_utils/docker/common.py b/lib/ansible/module_utils/docker/common.py
index 3c5dacece9dd5d..2af7433b04522d 100644
--- a/lib/ansible/module_utils/docker/common.py
+++ b/lib/ansible/module_utils/docker/common.py
@@ -93,9 +93,7 @@
debug=dict(type='bool', default=False)
)
-DOCKER_MUTUAL... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
ansible__ansible-53651@2dba3e9 | ansible/ansible | Python | 53,651 | AWS: new module ec2_transit_gateway fixes #49376 | ##### SUMMARY
AWS: new module ec2_transit_gateway Fixes #49376
##### ISSUE TYPE
<!--- Pick one below and delete the rest -->
- New Module Pull Request
##### COMPONENT NAME
ec2_transit_gateway
| 2019-03-11T19:15:37Z | Support for AWS new Transit gateway
##### SUMMARY
AWS recently launched a new type of gateway: transit gateway. This avoid having create 1000 of peering connections between many VPCs. It would be nice to be able to create / configure them from ansible.
##### ISSUE TYPE
- Feature Idea
##### COMPONENT NAME
aws... | Hi @forty, thank you for submitting this issue!
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: thank_submitter --->
Files identified in the description:
None
If these files are inaccurate, please update the `component name` section of the description or ... | [
{
"body": "##### SUMMARY\r\nAWS recently launched a new type of gateway: transit gateway. This avoid having create 1000 of peering connections between many VPCs. It would be nice to be able to create / configure them from ansible.\r\n\r\n##### ISSUE TYPE\r\n- Feature Idea\r\n\r\n##### COMPONENT NAME\r\n\r\naws_... | 9b6721909665813235f2e16615a77459d0853478 | {
"head_commit": "2dba3e99d6d0130197ec326e0c633b2f47413cec",
"head_commit_message": "AWS: new module ec2_transit_gateway fixes #49376",
"patch_to_review": "diff --git a/lib/ansible/modules/cloud/amazon/ec2_transit_gateway.py b/lib/ansible/modules/cloud/amazon/ec2_transit_gateway.py\nnew file mode 100644\nindex 00... | [
{
"diff_hunk": "@@ -0,0 +1,113 @@\n+---\n+# tasks file for test_ec2_transit_gateway\n+\n+- name: set up aws connection info\n+ set_fact:\n+ aws_connection_info: &aws_connection_info\n+ aws_access_key: \"{{ aws_access_key }}\"\n+ aws_secret_key: \"{{ aws_secret_key }}\"\n+ security_token: \"{{... | bdc6132dc35dad20abc261b0034919969746186d | diff --git a/hacking/aws_config/testing_policies/network-policy.json b/hacking/aws_config/testing_policies/network-policy.json
index a5f921be86b0a7..d28115ee4591dc 100644
--- a/hacking/aws_config/testing_policies/network-policy.json
+++ b/hacking/aws_config/testing_policies/network-policy.json
@@ -12,6 +12,16 @@
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
ansible__ansible-53593@c3b9460 | ansible/ansible | Python | 53,593 | openssl_privatekey: add backup option | ##### SUMMARY
Adds a `backup` option (similarly to the `copy` or `template` modules) and mention it as an option for paranoid/careless users. (Default is `off`.)
Fixes #32038.
##### ISSUE TYPE
- Feature Pull Request
##### COMPONENT NAME
openssl_privatekey
| 2019-03-09T21:00:56Z | openssl_privatekey: Do not recreate already existing private key
##### ISSUE TYPE
- Feature Idea
##### COMPONENT NAME
openssl_privatekey
##### ANSIBLE VERSION
<!--- Paste verbatim output from "ansible --version" between quotes below -->
```
ansible 2.4.0.0
config file = /etc/ansible/ansible.cfg
config... | cc @Spredzy
[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)
<!--- boilerplate: notify --->
I strongly disagree. If a specified criterion is not matched, some action has to be taken or the module should fail. If you are worried that keys could be regenerated, run the play in c... | [
{
"body": "##### ISSUE TYPE\r\n - Feature Idea\r\n\r\n##### COMPONENT NAME\r\nopenssl_privatekey\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes below -->\r\n```\r\nansible 2.4.0.0\r\n config file = /etc/ansible/ansible.cfg\r\n configured module search pat... | 57f706e5a042c22d03ec0a13704117a311cb5da0 | {
"head_commit": "c3b9460d3576ea4a28f1989139958c0c4619dc6e",
"head_commit_message": "Add tests for backup.",
"patch_to_review": "diff --git a/changelogs/fragments/53593-openssl_privatekey-backup.yml b/changelogs/fragments/53593-openssl_privatekey-backup.yml\nnew file mode 100644\nindex 00000000000000..55a9a4ddab7... | [
{
"diff_hunk": "@@ -23,6 +23,11 @@\n L(ECC,https://en.wikipedia.org/wiki/Elliptic-curve_cryptography)\n private keys.\n - Keys are generated in PEM format.\n+ - \"Please note that the module regenerates private keys if they don't match\n+ the module's options. In particular, if you provi... | 153d4ea8ce2905e7692f9567ba6a6bf1753225e7 | diff --git a/changelogs/fragments/53593-openssl_privatekey-backup.yml b/changelogs/fragments/53593-openssl_privatekey-backup.yml
new file mode 100644
index 00000000000000..55a9a4ddab795a
--- /dev/null
+++ b/changelogs/fragments/53593-openssl_privatekey-backup.yml
@@ -0,0 +1,2 @@
+minor_changes:
+- "openssl_privatekey -... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.