commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
861840222269924a6be2ccfc00d9292194def16b | Emilio Cobos Álvarez | 2020-06-09T13:21:54 | Bug 1643656 - Remove prefers-color-scheme: no-preference. r=gl,remote-protocol-reviewers,hiro,whimboo
It was removed from the spec. Bug 1643934 updates the WPT tests.
Differential Revision: https://phabricator.services.mozilla.com/D78834 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 4d60dc2ff..a02ddcfd6 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -278,6 +278,10 @@ enum PrefersReducedMotion {
Reduce,
}
+fn color_scheme_no_preference_enabled(_: &crate::parser::ParserContext)... | 1 | 5 | 0 |
89b3194472f26126bdad07c08199a2b0e3b93ce0 | Colomban Wendling | 2020-06-03T20:52:55 | Bug 1628762 - Fix tree column header color to follow theme. r=geckoview-reviewers,snorp
The background color for the tree column headers is drawn using the
system APIs, but the foreground uses custom colors, which didn't follow
theme. This can lead to unreadable text with specific colors, e.g.
leading to black on bla... | diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs
index e697f2523..4451e1b07 100644
--- a/style/values/specified/color.rs
+++ b/style/values/specified/color.rs
@@ -245,6 +245,12 @@ pub enum SystemColor {
MozGtkInfoBarText,
+ /// Color of tree column headers
+ #[parse(conditio... | 1 | 6 | 0 |
bb6cfbe3cdba5516bf23fc77afa442e2b87b581a | Cameron McCormack | 2020-06-05T00:39:50 | Bug 1642261 - Part 2: Add telemetry for -moz-appearance usage. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D77637 | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 2c4a5c8e4..e30b2229b 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -340,6 +340,21 @@ impl PropertyDeclarationBlock {
.find(|(declaration, _)| declaration.id()... | 3 | 32 | 1 |
a713ad7e498946ed82ed0c1a575be2becdc1cb87 | Emilio Cobos Álvarez | 2020-06-05T18:13:14 | Bug 1643230 - Clear last_parsed_property_id right after successfully parsing the value. r=jwatt
Rather than waiting until parsing another id (successfully or
unsuccessfully).
If we error before we even get to PropertyId::parse, we'd incorrectly
associate the error with the wrong property, incorrectly omitting it
some... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 76b7ed864..2c4a5c8e4 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -1339,7 +1339,6 @@ impl<'a, 'b, 'i> DeclarationParser<'i> for PropertyDeclarationParser<'a, 'b> {
... | 1 | 4 | 1 |
679bb78260a51b1ed0b3cb6877bb91ed1fb11728 | Dorel Luca | 2020-06-04T02:17:11 | Backed out changeset bde27b38c9c5 (bug 1643201) for causing Valgrind failures and build bustages | diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml
index 1763de6c0..a3e6db922 100644
--- a/selectors/Cargo.toml
+++ b/selectors/Cargo.toml
@@ -19,6 +19,7 @@ bench = []
[dependencies]
bitflags = "1.0"
+matches = "0.1"
cssparser = "0.27"
derive_more = "0.99"
fxhash = "0.2"
diff --git a/selectors/lib.rs b/sel... | 4 | 7 | 0 |
5fb8fb2adb3b336ec447ca3ef076207dbaa84ef3 | Emilio Cobos Álvarez | 2020-06-04T00:35:41 | Bug 1643201 - Rustfmt recent changes.
Depends on D78203
Differential Revision: https://phabricator.services.mozilla.com/D78204 | diff --git a/selectors/parser.rs b/selectors/parser.rs
index e66fa75c5..9980bdeeb 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -144,9 +144,7 @@ impl SelectorParsingState {
#[inline]
fn allows_non_functional_pseudo_classes(self) -> bool {
- !self.intersects(
- Self::AFTER_S... | 18 | 162 | 101 |
ce7a8d18ec7f0ba376f51d5d9e696097c0ab29d6 | Simon Sapin | 2020-06-04T00:35:30 | Bug 1643201 - Move most of `SequenceWriter::write_item` to non-generic functions.
The size of LLVM IR for the `style` crate is reduced by ~1.5% (27k lines out of 1.8M)
CC https://github.com/servo/servo/issues/26713
Depends on D78202
Differential Revision: https://phabricator.services.mozilla.com/D78203 | diff --git a/style_traits/values.rs b/style_traits/values.rs
index 66c1d79cd..df33c949f 100644
--- a/style_traits/values.rs
+++ b/style_traits/values.rs
@@ -197,33 +197,51 @@ where
where
F: FnOnce(&mut CssWriter<'b, W>) -> fmt::Result,
{
- let old_prefix = self.inner.prefix;
- if old_pr... | 1 | 43 | 25 |
c7585258299339ff0ba07c1e6d589312a9b54d6c | Emilio Cobos Álvarez | 2020-06-04T00:35:22 | Bug 1643201 - Cherry-pick servo changes to use the matches macro from the standard library.
Depends on D78201
Differential Revision: https://phabricator.services.mozilla.com/D78202 | diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml
index a3e6db922..1763de6c0 100644
--- a/selectors/Cargo.toml
+++ b/selectors/Cargo.toml
@@ -19,7 +19,6 @@ bench = []
[dependencies]
bitflags = "1.0"
-matches = "0.1"
cssparser = "0.27"
derive_more = "0.99"
fxhash = "0.2"
diff --git a/selectors/lib.rs b/sel... | 4 | 0 | 7 |
0864c7b69e02f3a59e0b9051a576a655eed014e7 | Emilio Cobos Álvarez | 2020-06-04T00:35:11 | Bug 1643201 - Cherry-pick some servo changes to derive_common.
Depends on D78199
Differential Revision: https://phabricator.services.mozilla.com/D78200 | diff --git a/derive_common/cg.rs b/derive_common/cg.rs
index 55a75398c..c51c0d775 100644
--- a/derive_common/cg.rs
+++ b/derive_common/cg.rs
@@ -7,7 +7,7 @@ use proc_macro2::{Span, TokenStream};
use quote::TokenStreamExt;
use syn::{self, AngleBracketedGenericArguments, Binding, DeriveInput, Field};
use syn::{Generic... | 1 | 5 | 1 |
4562a47a64db7ff4507a67b071e5f0a21286f9a6 | Emilio Cobos Álvarez | 2020-06-04T00:35:08 | Bug 1643201 - Miscellaneous build fixes.
Depends on D78198
Differential Revision: https://phabricator.services.mozilla.com/D78199 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 33a043695..96ed4fbe4 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -19,7 +19,7 @@ doctest = false
gecko = ["nsstring", "serde", "style_traits/gecko", "bindgen", "regex", "toml"]
servo = ["serde", "style_traits/servo", "servo_atoms", "servo_config", "htm... | 12 | 43 | 39 |
4af3b0e55d58912959f195e49419aa088505b888 | Anthony Ramine | 2020-06-04T00:35:00 | Bug 1643201 - servo: Return the root from the traversal.
Depends on D78196
Differential Revision: https://phabricator.services.mozilla.com/D78198 | diff --git a/style/driver.rs b/style/driver.rs
index aa39f3482..eab7c3a6a 100644
--- a/style/driver.rs
+++ b/style/driver.rs
@@ -63,7 +63,8 @@ pub fn traverse_dom<E, D>(
traversal: &D,
token: PreTraverseToken<E>,
pool: Option<&rayon::ThreadPool>,
-) where
+) -> E
+where
E: TElement,
D: DomTrave... | 1 | 4 | 1 |
f8201ca6ba01d5451f3617288ae6109ddb06fcf4 | Martin Robinson | 2020-06-04T00:34:53 | Bug 1643201 - servo: layout_2020: Add support for transitions and animations.
Depends on D78195
Differential Revision: https://phabricator.services.mozilla.com/D78196 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 8952b6c55..53aaf453d 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -161,7 +161,6 @@ ${helpers.predefined_type(
"Time",
"computed::Time::zero()",
engines... | 2 | 2 | 14 |
46674332fec93b40d30b5ff5ac95292330a4364d | Martin Robinson | 2020-06-04T00:34:45 | Bug 1643201 - servo: Implement `animation-fill-mode`.
Fixes #26460.
Depends on D78194
Differential Revision: https://phabricator.services.mozilla.com/D78195 | diff --git a/style/animation.rs b/style/animation.rs
index 40ba0847d..152692a0b 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -13,10 +13,10 @@ use crate::dom::{OpaqueNode, TElement, TNode};
use crate::font_metrics::FontMetricsProvider;
use crate::properties::animated_properties::AnimationValue;
use cra... | 3 | 340 | 182 |
8a2bf8fe39edaf7a1e36048ce7ebb5ca5484b17f | Simon Sapin | 2020-06-04T00:34:42 | Bug 1643201 - servo: `display: contents` computes to `block` on the root element.
Depends on D78193
Differential Revision: https://phabricator.services.mozilla.com/D78194 | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 2c63cd4f8..4f767e89b 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -354,7 +354,7 @@ impl Display {
///
/// Also used for :root style adjustments.
pub fn equivalent_block_display(&self, _is... | 1 | 1 | 1 |
ca4ea0bcc3a73db92a488de4446d71773f208add | Martin Robinson | 2020-06-04T00:34:34 | Bug 1643201 - servo: Remove AnimatedProperty.
This removes an extra layer of abstraction and allows Servo to share
more code with Gecko. In addition, we will need to handle raw
`AnimationValue` structs soon in order to fully implement "faster
reversing of interrupted transitions."
Depends on D78192
Differential Revi... | diff --git a/style/animation.rs b/style/animation.rs
index ea5fec7ca..40ba0847d 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -11,7 +11,7 @@ use crate::bezier::Bezier;
use crate::context::SharedStyleContext;
use crate::dom::{OpaqueNode, TElement, TNode};
use crate::font_metrics::FontMetricsProvider;
-u... | 2 | 88 | 221 |
a4b0b9749da5b07f5fc8ebc7a1a71a358c28d0a8 | Martin Robinson | 2020-06-04T00:34:31 | Bug 1643201 - servo: Move most animation processing to script.
This is preparation for sharing this code with layout_2020 and
implementing selective off-the-main-thread animations.
We still look for nodes not in the flow tree in the layout thread.
Depends on D78191
Differential Revision: https://phabricator.service... | diff --git a/style/animation.rs b/style/animation.rs
index 74950502b..ea5fec7ca 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -28,7 +28,7 @@ use servo_arc::Arc;
use std::fmt;
/// Represents an animation for a given property.
-#[derive(Clone, Debug)]
+#[derive(Clone, Debug, MallocSizeOf)]
pub struct P... | 1 | 7 | 6 |
6dac211fe5a2a456645bd87b2072d6b7690ff1ad | Martin Robinson | 2020-06-04T00:34:28 | Bug 1643201 - servo: layout_2020: Add initial support for getComputedStyle.
This implementation is more-or-less on par with the one from layout_2013
and in some cases better. There are still some cases where we don't
return the correct "resolved value," but this is enough to test
animations and transitions.
Depends o... | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 987a05674..2c63cd4f8 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -400,7 +400,7 @@ impl Display {
#[inline]
pub fn is_contents(&self) -> bool {
match *self {
- #[cfg(featur... | 1 | 1 | 1 |
8501e3c2e96428e940f7e2ce9dbb6163db9e6bda | Martin Robinson | 2020-06-04T00:34:18 | Bug 1643201 - servo: Start having animations conform to the HTML spec.
This is a small step toward fixing #19242. The main idea is that the
clock for animations should advance as the event loop ticks. We
accomplish this by moving the clock from layout and naming it the
"animation timeline" which is the spec language. ... | diff --git a/style/lib.rs b/style/lib.rs
index 277e9cf15..6c4355ff3 100644
--- a/style/lib.rs
+++ b/style/lib.rs
@@ -160,7 +160,6 @@ pub mod stylesheet_set;
pub mod stylesheets;
pub mod stylist;
pub mod thread_state;
-pub mod timer;
pub mod traversal;
pub mod traversal_flags;
pub mod use_counters;
diff --git a/st... | 2 | 0 | 64 |
01016c9a1e1fb864fb69ef9910b184b494756a8d | Martin Robinson | 2020-06-04T00:34:15 | Bug 1643201 - servo: Use a restyle for animation ticks.
This change corrects synchronization issues with animations, by
reworking the animation processing model to do a quick restyle and
incremental layout when ticking animations.
While this change adds overhead to animation ticks, the idea is that
this will be the f... | diff --git a/style/animation.rs b/style/animation.rs
index 8fe9ae3d1..49e185d2f 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -19,7 +19,6 @@ use crate::properties::{self, CascadeMode, ComputedValues, LonghandId};
use crate::properties::LonghandIdSet;
use crate::stylesheets::keyframes_rule::{KeyframesAni... | 3 | 143 | 130 |
68f0de8ca9efbf6125688a0a3b11d0d44cff886d | Martin Robinson | 2020-06-04T00:34:12 | Bug 1643201 - servo: Add support for animationend event.
This is triggered when an animation finishes. This is a high priority
because it allows us to start rooting nodes with animations in the
script thread.
This doesn't yet cause a lot of tests to pass because they rely on the
existence of `Document.getAnimations()... | diff --git a/style/animation.rs b/style/animation.rs
index 302dc021f..8fe9ae3d1 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -173,6 +173,17 @@ impl KeyframesAnimationState {
self.current_direction = old_direction;
self.started_at = new_started_at;
}
+
+ /// Calculate the active-... | 1 | 11 | 0 |
12db57560cd8a0990e58f0b1a53696399be133be | Martin Robinson | 2020-06-04T00:34:09 | Bug 1643201 - servo: Split animation cancellation from update_style_for_animation.
`update_style_for_animation` previously handled both canceling defunct
animations and also updating style to reflect current animation state.
This change splits those two concerns because we want to start handling
replaced or canceled a... | diff --git a/style/animation.rs b/style/animation.rs
index 59a921635..302dc021f 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -9,7 +9,7 @@
use crate::bezier::Bezier;
use crate::context::SharedStyleContext;
-use crate::dom::{OpaqueNode, TElement};
+use crate::dom::{OpaqueNode, TElement, TNode};
use cr... | 2 | 116 | 107 |
8f96d6b9298aba99717fa94c596d06acc3d1a0da | Martin Robinson | 2020-06-04T00:34:06 | Bug 1643201 - servo: Restyle should reflect animations and transitions.
When doing a restyle, we should apply animations and transitions to the
new style so that it is reflected in `getComputedStyle()` and the new
style information properly cascades. This is the first part of properly
ticking animations and transition... | diff --git a/style/animation.rs b/style/animation.rs
index 893f1f0ce..59a921635 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -443,14 +443,18 @@ impl ElementAnimationState {
false
}
- /// Compute before-change-style given an existing ElementAnimationState,
- /// information from the ... | 2 | 65 | 44 |
084c9acc1511a46eaf9ce8f69b52b0826aea6697 | Martin Robinson | 2020-06-04T00:34:02 | Bug 1643201 - servo: Add ElementAnimationState and PossibleElementAnimationState.
This refactor is preparation for implementing a specification
compliant transitions and animations processing model.
These data structures hold all the animation information about a single
node. Since adding, updating, and modifying ani... | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 367891d7c..33a043695 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -33,7 +33,6 @@ atomic_refcell = "0.1"
bitflags = "1.0"
byteorder = "1.0"
cssparser = "0.27"
-crossbeam-channel = { version = "0.4", optional = true }
derive_more = "0.99"
new_debug_un... | 5 | 189 | 234 |
d6f77c7ca94dfc325f5cfc634ff14928b54a7383 | Emilio Cobos Álvarez | 2020-06-03T22:43:49 | Bug 1643078 - Don't use lazy_static for media feature parsing. r=boris
This used to be needed when destructors in statics were not allowed, but
we can get rid of it nowadays.
Differential Revision: https://phabricator.services.mozilla.com/D78109 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 63d5ce107..d11aa0d68 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -538,225 +538,223 @@ macro_rules! system_metric_feature {
}};
}
-lazy_static! {
- /// Adding new media features requires (1) ... | 1 | 220 | 222 |
c3a78cb39ea39da1295812032188220cd7cfb7ae | Bogdan Tara | 2020-06-03T08:43:20 | Backed out 2 changesets (bug 1642261) for browser_use_counters.js failures CLOSED TREE
Backed out changeset dd4c99038ede (bug 1642261)
Backed out changeset 308d2f7a4a13 (bug 1642261) | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index f7e803214..76b7ed864 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -340,21 +340,6 @@ impl PropertyDeclarationBlock {
.find(|(declaration, _)| declaration.id()... | 3 | 1 | 32 |
3cc5ebf8d0fe8c6662aa3f9da6d62af5cb8b96c8 | Cameron McCormack | 2020-06-03T05:15:21 | Bug 1642261 - Part 2: Add telemetry for -moz-appearance usage. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D77637 | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 76b7ed864..f7e803214 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -340,6 +340,21 @@ impl PropertyDeclarationBlock {
.find(|(declaration, _)| declaration.id()... | 3 | 32 | 1 |
aeaa8f484a0343fe830fb67f1097ada8367868d8 | Narcis Beleuzu | 2020-06-03T04:30:23 | Backed out 2 changesets (bug 1642261) for mochitest failures on test_property_database.html . CLOSED TREE
Backed out changeset 32b26c1984f6 (bug 1642261)
Backed out changeset 68456151c046 (bug 1642261) | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index f7e803214..76b7ed864 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -340,21 +340,6 @@ impl PropertyDeclarationBlock {
.find(|(declaration, _)| declaration.id()... | 3 | 1 | 32 |
9e32f0a373f3a4030b6d986fa431576b743daf1e | Boris Chiou | 2020-05-27T21:43:00 | Bug 1640036 - Update aspec-ratio syntax for HTML IMG mapped ratio. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D76942 | diff --git a/style/values/generics/position.rs b/style/values/generics/position.rs
index 5f1659d39..2b4448f03 100644
--- a/style/values/generics/position.rs
+++ b/style/values/generics/position.rs
@@ -191,7 +191,7 @@ where
}
}
-/// A generic value for the `aspect-ratio` property.
+/// Ratio or None.
#[derive(
... | 2 | 71 | 15 |
abb1091c73e8da43ca78ef0b25c039a096f216dd | Emilio Cobos Álvarez | 2020-05-27T09:17:47 | Bug 1640843 - Finer grained invalidation for attribute changes. r=heycam
This should help out quite a bit with uBO, which has lots of very
general attribute selectors. We invalidate per attribute name rather
than using a SelectorMap, which prevents matching for attribute
selectors that can't have changed.
The idea is... | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index a46068d92..e5d332df6 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -229,17 +229,6 @@ impl NonTSPseudoClass {
NonTSPseudoClass::MozLWThemeDarkText
)
}
-
- /... | 5 | 68 | 113 |
3d710fa333b9662eee8dfd2e5f2ebfd4b3491a45 | Emilio Cobos Álvarez | 2020-05-27T00:00:52 | Bug 1640667 - Manually tweak inlining in stateless pseudo selector matching. r=boris
This addresses a minor regression in bloom-matching.html. The common
case here is that there's no selector to the right of the
pseudo-element, so keep that path inline, while keeping all other checks
out of line.
Differential Revisio... | diff --git a/selectors/matching.rs b/selectors/matching.rs
index f55833f7f..3414f9d6e 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -322,13 +322,8 @@ where
},
}
- for component in &mut iter {
- // The only other parser-allowed Components in this sequence are... | 2 | 30 | 8 |
245e37ddf1cf5c6a13dfe0821fda9900af98ec31 | Emilio Cobos Álvarez | 2020-05-26T21:58:25 | Bug 1640985 - Remove two useless mem::replace calls. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D76884 | diff --git a/style/values/generics/calc.rs b/style/values/generics/calc.rs
index 074dd97f4..cd3318183 100644
--- a/style/values/generics/calc.rs
+++ b/style/values/generics/calc.rs
@@ -337,7 +337,7 @@ impl<L: CalcNodeLeaf> CalcNode<L> {
($slot:expr) => {{
let dummy = Self::MinMax(Default::... | 1 | 2 | 2 |
85bce663192e5043de27a28dc06a24b21fa253ec | Emilio Cobos Álvarez | 2020-05-26T09:39:33 | Bug 1449753 - Remove the @-moz-document url-prefix() hack preference, enable it everywhere. r=jwatt
It doesn't seem like realistically we're going to be able to get rid of
this any time soon.
Differential Revision: https://phabricator.services.mozilla.com/D76809 | diff --git a/style/stylesheets/document_rule.rs b/style/stylesheets/document_rule.rs
index e779863f0..35c6b443f 100644
--- a/style/stylesheets/document_rule.rs
+++ b/style/stylesheets/document_rule.rs
@@ -264,10 +264,6 @@ impl DocumentCondition {
return true;
}
- if !pref!("layout.css.moz... | 1 | 0 | 4 |
69ed7c3ecbf594028924dd2104924377421d970b | Emilio Cobos Álvarez | 2020-05-25T23:54:10 | Bug 1635675 - Implement the ::file-chooser-button pseudo-element. r=jwatt
As per https://github.com/w3c/csswg-drafts/issues/5049.
Don't enable it unconditionally just yet, as the name may change.
I had to move some rules in forms.css because otherwise you get
specificity conflicts.
Differential Revision: https://ph... | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index b537295f7..631172d95 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -37,7 +37,8 @@ impl ::selectors::parser::PseudoElement for PseudoElement {
PseudoElement::Before |
PseudoE... | 1 | 6 | 5 |
df10ff3d6c9fc22e5ed5cdb83d18a9b160674477 | Narcis Beleuzu | 2020-05-25T10:49:39 | Backed out changeset 82df6f70ec60 (bug 1635675) for lint failure on file-chooser-button-001.tentative.html . CLOSED TREE | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index 631172d95..b537295f7 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -37,8 +37,7 @@ impl ::selectors::parser::PseudoElement for PseudoElement {
PseudoElement::Before |
PseudoE... | 1 | 5 | 6 |
d6c0487b3c6e0090cbd5c992f4ce5835106b7630 | Emilio Cobos Álvarez | 2020-05-21T12:10:34 | Bug 1639756 - Enable :is() and :where() in UA sheets. r=jwatt
This will allow us to clean them up.
Differential Revision: https://phabricator.services.mozilla.com/D76262 | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index adb410908..a46068d92 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -354,7 +354,7 @@ impl<'a, 'i> ::selectors::Parser<'i> for SelectorParser<'a> {
#[inline]
fn parse_is_and_where(&self) ->... | 1 | 1 | 1 |
5a6fe0841ba486cd26b93735568a479845304f7c | sefeng | 2020-05-23T01:45:33 | Bug 1637307 - Push/Pop dialog to top layer when needed r=smaug,emilio
This patch completes the top layer requirement for showModal()
Spec: https://html.spec.whatwg.org/multipage/interactive-elements.html#dom-dialog-showmodal
Differential Revision: https://phabricator.services.mozilla.com/D74922 | diff --git a/style/element_state.rs b/style/element_state.rs
index 190c1cc3e..3fe94f3e8 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -141,6 +141,10 @@ bitflags! {
///
/// https://drafts.csswg.org/selectors-4/#the-focus-visible-pseudo
const IN_FOCUS_VISIBLE_STATE = 1 << ... | 3 | 6 | 0 |
3692dddb887d83c5f7290638bffd7bd77805d0d3 | Emilio Cobos Álvarez | 2020-05-21T18:43:12 | Bug 1639905 - Derive parse for ShapeRadius. r=boris
Depends on D76331
Differential Revision: https://phabricator.services.mozilla.com/D76332 | diff --git a/style/values/generics/basic_shape.rs b/style/values/generics/basic_shape.rs
index 745d6e07b..60619b46e 100644
--- a/style/values/generics/basic_shape.rs
+++ b/style/values/generics/basic_shape.rs
@@ -270,6 +270,7 @@ pub struct Ellipse<H, V, NonNegativeLengthPercentage> {
Copy,
Debug,
MallocS... | 2 | 1 | 16 |
88ce1b565e63a432148fb254de476958c8d625ec | Emilio Cobos Álvarez | 2020-05-21T18:44:19 | Bug 1639905 - Derive parse for TextOverflowSide. r=boris
Depends on D76330
Differential Revision: https://phabricator.services.mozilla.com/D76331 | diff --git a/style/parser.rs b/style/parser.rs
index d1afc2e96..f506b8099 100644
--- a/style/parser.rs
+++ b/style/parser.rs
@@ -207,6 +207,12 @@ where
}
}
+impl Parse for crate::OwnedStr {
+ fn parse<'i, 't>(_: &ParserContext, input: &mut Parser<'i, 't>) -> Result<Self, ParseError<'i>> {
+ Ok(input.e... | 2 | 7 | 24 |
2598fca21c7eb76542c0258e9e0d809049f823ce | Emilio Cobos Álvarez | 2020-05-21T16:52:20 | Bug 1639905 - Clean up parsing of UnicodeRange. r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D76330 | diff --git a/style/parser.rs b/style/parser.rs
index c6f7321b2..d1afc2e96 100644
--- a/style/parser.rs
+++ b/style/parser.rs
@@ -208,10 +208,7 @@ where
}
impl Parse for UnicodeRange {
- fn parse<'i, 't>(
- _context: &ParserContext,
- input: &mut Parser<'i, 't>,
- ) -> Result<Self, ParseError<'i>... | 1 | 2 | 5 |
ed1cb5afdb6e3fd0eb0d0df8232f0f25a2abde6b | Emilio Cobos Álvarez | 2020-05-21T13:48:36 | Bug 1639689 - Support field_bound in #[derive(Parse)]. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D76268 | diff --git a/style_derive/parse.rs b/style_derive/parse.rs
index 80c214bd7..6dc2c8a71 100644
--- a/style_derive/parse.rs
+++ b/style_derive/parse.rs
@@ -15,7 +15,14 @@ pub struct ParseVariantAttrs {
pub condition: Option<Path>,
}
+#[darling(attributes(parse), default)]
+#[derive(Default, FromField)]
+pub struct... | 1 | 28 | 13 |
69bfb986a4be6e5b66c224bada7e9f8c645e514f | Boris Chiou | 2020-05-20T21:13:37 | Bug 1635939 - Use style::One for Integer to avoid implementing Mul. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D76207 | diff --git a/style/values/generics/font.rs b/style/values/generics/font.rs
index 2b29104ff..237e862d4 100644
--- a/style/values/generics/font.rs
+++ b/style/values/generics/font.rs
@@ -5,9 +5,9 @@
//! Generic types for font stuff.
use crate::parser::{Parse, ParserContext};
+use crate::One;
use byteorder::{BigEndia... | 2 | 6 | 10 |
86e9be4b82120b0a548833f835b646e51c4bd08c | Boris Chiou | 2020-05-20T21:13:35 | Bug 1635939 - Replace AspectRatio with computed::position::Ratio in media-queries. r=emilio
Also, we drop the pref, layout.css.aspect-ratio-number.enabled, becacuse
the spec of css-sizing-4 uses Number now.
Differential Revision: https://phabricator.services.mozilla.com/D75233 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index e3de8dbfa..63d5ce107 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -8,8 +8,9 @@ use crate::gecko_bindings::bindings;
use crate::gecko_bindings::structs;
use crate::media_queries::media_feature::{Allows... | 7 | 51 | 55 |
fdf34daba43f4c1ea9ad78a0d2dfa7c572354003 | Emilio Cobos Álvarez | 2020-05-20T23:53:34 | Bug 1639533 - Fix a no-longer valid assumption in pseudo-element matching / invalidation code. r=heycam
After bug 1632647, we can have pseudo-classes inside :not / :is /
:where, which the invalidation and matching code weren't handling.
Add a few tests for this stuff working as expected.
Differential Revision: https... | diff --git a/selectors/matching.rs b/selectors/matching.rs
index d8d4ad599..f55833f7f 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -322,14 +322,13 @@ where
},
}
- // The only other parser-allowed Component in this sequence is a state
- // class. We just don't m... | 3 | 65 | 19 |
db513470c540f8fe29fbcc69a7a9eafc78518c52 | Emilio Cobos Álvarez | 2020-05-20T23:54:16 | Bug 1639533 - Fix a case where we'd allow parsing functional :host incorrectly. r=heycam
This is a missing check I should've introduced in bug 1632647.
Differential Revision: https://phabricator.services.mozilla.com/D76161 | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 1548a6fdc..74f4a48de 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -2207,7 +2207,12 @@ where
"nth-last-of-type" => return parse_nth_pseudo_class(parser, input, state, Component::NthLastOfType),
"is" if parser.parse_is_and_whe... | 1 | 6 | 1 |
aa7c99e6cc50bd4e0abbac299e827a4aa432aab9 | Emilio Cobos Álvarez | 2020-05-20T12:16:22 | Bug 1632647 - Fix parsing of :is() and :where() to account for constraints from parent selectors. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D75856 | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 154407030..1548a6fdc 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -104,41 +104,59 @@ bitflags! {
/// disallowed. If this flag is set, `AFTER_PSEUDO_ELEMENT` must be set
/// as well.
const AFTER_NON_STATEFUL_PSEUDO_E... | 1 | 99 | 74 |
93f470566e1798b272c9f6cc94b94ed758e7c62c | Emilio Cobos Álvarez | 2020-05-18T10:54:16 | Bug 1636998 - Make ::-moz-focus-outer a no-op, and remove it on Nightly. r=jwatt
See https://bugzilla.mozilla.org/show_bug.cgi?id=932410#c2 for the
context for which this pseudo-element was added.
In the previous patch, I had to special-case range appearance because of
this pseudo-class, but that patch makes this pse... | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index 3ca06eea3..b537295f7 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -159,7 +159,13 @@ impl PseudoElement {
/// Whether this pseudo-element is enabled for all content.
pub fn enabled_in_content... | 1 | 7 | 1 |
8dbbcf9a8643bde4392bdb44ec32d90f19755960 | Csoregi Natalia | 2020-05-18T10:31:56 | Backed out changeset 62ad26fbfaf8 (bug 1636998) for reftest failures on 1174332-1.html. CLOSED TREE | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index b537295f7..3ca06eea3 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -159,13 +159,7 @@ impl PseudoElement {
/// Whether this pseudo-element is enabled for all content.
pub fn enabled_in_content... | 1 | 1 | 7 |
3fbe3a084e6c1d2f38cb1457e9638ef5a20394e4 | Emilio Cobos Álvarez | 2020-05-14T16:46:08 | Bug 312971 - Unprefix -moz-read-write / -moz-read-only. r=edgar
And remove some duplicated tests from WPT.
Differential Revision: https://phabricator.services.mozilla.com/D75231 | diff --git a/style/element_state.rs b/style/element_state.rs
index cf943cc3c..190c1cc3e 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -87,9 +87,9 @@ bitflags! {
/// <https://html.spec.whatwg.org/multipage/#selector-out-of-range>
const IN_OUTOFRANGE_STATE = 1 << 28;
/// <... | 4 | 8 | 6 |
d56c51c665ee23fc2daf67a53aaa8c5f53a213b2 | longsonr | 2020-05-13T09:10:54 | Bug 935056 - Don't apply minimum font sizes to SVG text. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D74581 | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 807e1d70f..ab60099b3 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -920,8 +920,8 @@ impl<'a, 'b: 'a> Cascade<'a, 'b> {
let builder = &mut self.context.builder;
- let parent_zoom = builder.get... | 3 | 8 | 8 |
0664fd3fb0faff666a58f693c4618b1f67e05eee | Noemi Erli | 2020-05-13T08:33:57 | Backed out changeset afdf4d60166d (bug 935056) for causing Android reftest failures CLOSED TREE | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index ab60099b3..807e1d70f 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -920,8 +920,8 @@ impl<'a, 'b: 'a> Cascade<'a, 'b> {
let builder = &mut self.context.builder;
- let parent_zoom = builder.get... | 3 | 8 | 8 |
77baf294b8c1ca50a3a95d5fb1a59f69ea7fc056 | Razvan Maries | 2020-05-12T19:16:12 | Backed out changeset 8eef199bbda9 (bug 935056) for perma failures at 935056-1.html. CLOSED TREE | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index ab60099b3..807e1d70f 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -920,8 +920,8 @@ impl<'a, 'b: 'a> Cascade<'a, 'b> {
let builder = &mut self.context.builder;
- let parent_zoom = builder.get... | 3 | 8 | 8 |
e6a26ed161114fc2affa14dc95b2f026dfcfb007 | Emilio Cobos Álvarez | 2020-05-11T21:33:31 | Bug 1636357 - Clean up cascade rule iteration. r=nordzilla
The current API was pretty awkward as a result of two things:
* Not being able to create empty iterators for smallbitvec.
* We used to call the `F` function multiple times, but turns out that
collecting the declarations in a SmallVec was a perf win.
So ... | diff --git a/style/animation.rs b/style/animation.rs
index 69ccf4e04..e01049e10 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -534,7 +534,13 @@ where
} => {
let guard = declarations.read_with(context.guards.author);
- let iter = || {
+ // This currently ignore... | 4 | 105 | 71 |
693e2a6ba3ab16d0fadaf68af49e073319c9b75b | Cameron McCormack | 2020-05-11T00:11:45 | Bug 1621773 - Gracefully handle errors creating shared memory UA style sheets. r=emilio
We still panic in a debug build, so that developers can notice when they
need to add a new static atom after modifying UA sheets.
We also add telemetry to note when this happens, add an app note to a
crash report, in case any cras... | diff --git a/derive_common/cg.rs b/derive_common/cg.rs
index 13c7b12df..55a75398c 100644
--- a/derive_common/cg.rs
+++ b/derive_common/cg.rs
@@ -85,9 +85,22 @@ pub fn add_predicate(where_clause: &mut Option<syn::WhereClause>, pred: WherePre
.push(pred);
}
-pub fn fmap_match<F>(input: &DeriveInput, bind_styl... | 10 | 185 | 123 |
4c51e3ad829e819f73034163bf00919f074960b1 | Philipp Zech | 2020-05-07T08:32:27 | Bug 1635160 - Convert style-font #defines to an enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D73728 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 545e8cc77..8b10d71c1 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -953,19 +953,19 @@ fn static_assert() {
if let Some(info) = v.keyword_info {
self.gecko.mFontSizeKeyword = m... | 1 | 20 | 20 |
ccdca43fe1657284bff03e7749cb43cd9ba1231f | Emily McDonough | 2020-05-06T19:35:03 | Bug 1628041 - Use fill length rather than index to indicate a repeat(auto) in subgrid from Servo r=mats
Differential Revision: https://phabricator.services.mozilla.com/D70066 | diff --git a/style/values/generics/grid.rs b/style/values/generics/grid.rs
index 0fbeebea1..a0970a6fb 100644
--- a/style/values/generics/grid.rs
+++ b/style/values/generics/grid.rs
@@ -714,7 +714,7 @@ impl Parse for LineNameList {
line_names.truncate(MAX_GRID_LINE as usize);
}
- let (fill... | 1 | 3 | 3 |
62feac88bf8f5c067087b7d8d516b45b46aa2392 | Simon Giesecke | 2020-05-05T10:42:23 | Bug 1626570 - Improve handling of copying arrays in layout/style/ and servo/. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D72351 | diff --git a/style/gecko_bindings/sugar/ns_t_array.rs b/style/gecko_bindings/sugar/ns_t_array.rs
index e3d4e5b86..04ba326c6 100644
--- a/style/gecko_bindings/sugar/ns_t_array.rs
+++ b/style/gecko_bindings/sugar/ns_t_array.rs
@@ -5,7 +5,7 @@
//! Rust helpers for Gecko's nsTArray.
use crate::gecko_bindings::bindings;... | 1 | 14 | 1 |
437c6e81165d539d1e6928154d7bf2d94eed45fd | Razvan Maries | 2020-05-05T10:37:08 | Backed out 10 changesets (bug 1626570) for build bustages. CLOSED TREE
Backed out changeset a3f17d392234 (bug 1626570)
Backed out changeset 5247e1ddd5d6 (bug 1626570)
Backed out changeset c339fd44c9f8 (bug 1626570)
Backed out changeset 4c69a4c013b3 (bug 1626570)
Backed out changeset e85450d69351 (bug 1626570)
Backed o... | diff --git a/style/gecko_bindings/sugar/ns_t_array.rs b/style/gecko_bindings/sugar/ns_t_array.rs
index 04ba326c6..e3d4e5b86 100644
--- a/style/gecko_bindings/sugar/ns_t_array.rs
+++ b/style/gecko_bindings/sugar/ns_t_array.rs
@@ -5,7 +5,7 @@
//! Rust helpers for Gecko's nsTArray.
use crate::gecko_bindings::bindings;... | 1 | 1 | 14 |
870e1f7e3258be3a15961c2a78cad53900fe0a4e | Simon Giesecke | 2020-05-05T09:09:01 | Bug 1633719 - Make NotNull move its member pointer where possible. r=jwalden
Differential Revision: https://phabricator.services.mozilla.com/D72827 | diff --git a/style/gecko_bindings/sugar/ownership.rs b/style/gecko_bindings/sugar/ownership.rs
index 5170b7dbc..0ece222a1 100644
--- a/style/gecko_bindings/sugar/ownership.rs
+++ b/style/gecko_bindings/sugar/ownership.rs
@@ -9,6 +9,7 @@ use std::marker::PhantomData;
use std::mem::{forget, transmute};
use std::ops::{D... | 1 | 14 | 0 |
8849dce7e85ed2984612c0dd40353b24c3ef6718 | Boris Chiou | 2020-05-04T19:15:43 | Bug 1633486 - Add ::marker when checking may_have_animations() during traversal. r=emilio
When unhidding a ::marker element, we construct its generated item, and
then call StyleNewSubtree() on this generated item. During traversal, we
may update any animation related values in Gecko_UpdateAnimations(), which
may updat... | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index d989380c0..3ca06eea3 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -92,6 +92,12 @@ impl PseudoElement {
EAGER_PSEUDOS[i].clone()
}
+ /// Whether the current pseudo element is animatabl... | 2 | 7 | 1 |
244abefccd383dc72f42d678089236e5f5d44a60 | Emilio Cobos Álvarez | 2020-04-30T00:09:19 | Bug 1632102 - Only override to default color in high-contrast / forced-colors mode if inheriting from transparent. r=morgan
That way elements inside links, form controls, etc have the right
contrast, even if the page overrides the color.
We can't do it when inheriting from transparent because we've already
forgotten ... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index e9a34d6bf..515239c44 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -384,10 +384,15 @@ fn tweak_when_ignoring_colors(
if color.0.is_transparent() {
return;
}
- ... | 1 | 9 | 4 |
c999a2aa661c52e994b790085ce91ebeb5781dd2 | Emilio Cobos Álvarez | 2020-04-23T19:20:35 | Bug 1509418 - Collect ancestor hashes from single-length :is and :where selector lists. r=heycam,boris
We can only collect hashes from single-length selectors, as described in
the comment.
Differential Revision: https://phabricator.services.mozilla.com/D71458 | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 0a3dd43ac..154407030 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -404,18 +404,68 @@ pub struct AncestorHashes {
pub packed_hashes: [u32; 3],
}
-impl AncestorHashes {
- pub fn new<Impl: SelectorImpl>(selector: &Selector<Impl>, quir... | 1 | 65 | 56 |
c36a34cde8040aa9893d5f312d4f70c0af768137 | Emilio Cobos Álvarez | 2020-04-23T19:20:27 | Bug 1509418 - Handle disjoint selectors in the selector map. r=heycam,boris
This way, something like:
*:where(.foo, .bar)
Will end up twice on the selector map, just as if you would've written
.foo, .bar.
But we're a bit careful to not be wasteful, so:
.foo:where(div, span)
Will still end up using the .foo bu... | diff --git a/style/selector_map.rs b/style/selector_map.rs
index 712506f77..ddf29f676 100644
--- a/style/selector_map.rs
+++ b/style/selector_map.rs
@@ -275,51 +275,90 @@ impl SelectorMap<Rule> {
}
impl<T: SelectorMapEntry> SelectorMap<T> {
- /// Inserts into the correct hash, trying id, class, localname and
- ... | 1 | 127 | 79 |
222f052c948aaebab4bca472dbaf2a365ed62be4 | Emilio Cobos Álvarez | 2020-04-23T19:20:17 | Bug 1509418 - Optimize invalidation by scanning the rightmost compound inside :where() and :is() with the outer visitor. r=heycam,boris
See the comment about why this is valuable. For a selector like:
.foo:is(.bar) > .baz
Before this patch we'd generate an Dependency for .bar like this:
Dependency {
... | diff --git a/style/invalidation/element/invalidation_map.rs b/style/invalidation/element/invalidation_map.rs
index b61475c76..8bc0f07a2 100644
--- a/style/invalidation/element/invalidation_map.rs
+++ b/style/invalidation/element/invalidation_map.rs
@@ -347,17 +347,20 @@ struct SelectorDependencyCollector<'a> {
impl<... | 1 | 41 | 14 |
fcb2a2032dde8ec50a3a0b05bd2ccb9d2495c72f | Emilio Cobos Álvarez | 2020-04-23T19:20:10 | Bug 1509418 - Make Invalidation work in terms of a dependency, not a selector. r=heycam,boris
That way we can look at the parent dependency as described in the previous
patch. An alternative would be to add a:
parent_dependency: Option<&'a Dependency>
on construction to `Invalidation`, but this way seems slightl... | diff --git a/style/dom_apis.rs b/style/dom_apis.rs
index 8f764dc89..685b5b4e8 100644
--- a/style/dom_apis.rs
+++ b/style/dom_apis.rs
@@ -9,6 +9,7 @@ use crate::context::QuirksMode;
use crate::dom::{TDocument, TElement, TNode, TShadowRoot};
use crate::invalidation::element::invalidator::{DescendantInvalidationLists, I... | 5 | 310 | 197 |
76b153809dcd22dc739bfee6d6d7d82f1eba1a55 | Emilio Cobos Álvarez | 2020-04-23T19:20:03 | Bug 1509418 - Keep track of nested dependencies for :where() and :is(). r=heycam,boris
The tricky part of :is() and :where() is that they can have combinators inside,
so something like this is valid:
foo:is(#bar > .baz) ~ taz
The current invalidation logic is based on the assumption that you can
represent a combin... | diff --git a/style/invalidation/element/invalidation_map.rs b/style/invalidation/element/invalidation_map.rs
index 00b0c80ff..f9195cb4c 100644
--- a/style/invalidation/element/invalidation_map.rs
+++ b/style/invalidation/element/invalidation_map.rs
@@ -47,6 +47,23 @@ pub struct Dependency {
/// The offset into t... | 2 | 245 | 146 |
46b4af2e835c989f75bde1c84e4b5b5480eeef23 | Daniel Holbert | 2020-04-23T05:01:07 | Bug 1626458 part 1: Remove pref for CSS Containment (layout.css.contain.enabled) r=AlaskanEmily
(Since we've been shipping with it default-enabled for a while now.)
See https://bugzilla.mozilla.org/show_bug.cgi?id=1466008#c9 through #c13 for
notes on the reftest.list change.
Differential Revision: https://phabricato... | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index a4f2cc670..c919eb9fb 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -623,9 +623,7 @@ ${helpers.predefined_type(
engines="gecko",
animation_value_type="none",
... | 1 | 0 | 2 |
3eb2844bd426c24d7b12b3763974b35e36f941fd | Simon Sapin | 2020-04-23T00:19:51 | Bug 1631721 - Use std::alloc instead of hashbrown::alloc in fallible r=manishearth
This works even if the Rust standard library’s allocator is not `libc::malloc`,
so we can remove the `known_system_malloc `feature flag
and make the `fallible` crate unconditional.
Differential Revision: https://phabricator.services.mo... | diff --git a/fallible/Cargo.toml b/fallible/Cargo.toml
index dc9133eee..c2a70e34e 100644
--- a/fallible/Cargo.toml
+++ b/fallible/Cargo.toml
@@ -13,14 +13,3 @@ path = "lib.rs"
smallvec = "1.0"
hashbrown = "0.7"
hashglobe = { path = "../hashglobe" }
-
-# This crate effectively does nothing except if the `known_system... | 3 | 31 | 57 |
ef12982de2c927a06555af1113b7928906cd6207 | Simon Sapin | 2020-04-23T00:19:51 | Bug 1631721 - Use hashbrown instead of hashglobe r=manishearth
Differential Revision: https://phabricator.services.mozilla.com/D71741 | diff --git a/fallible/Cargo.toml b/fallible/Cargo.toml
index 49064da33..dc9133eee 100644
--- a/fallible/Cargo.toml
+++ b/fallible/Cargo.toml
@@ -11,6 +11,7 @@ path = "lib.rs"
[dependencies]
smallvec = "1.0"
+hashbrown = "0.7"
hashglobe = { path = "../hashglobe" }
# This crate effectively does nothing except if ... | 10 | 88 | 64 |
390c503eb779d1c1c5720dc5330937e5e72fff5b | Simon Sapin | 2020-04-23T00:19:50 | Bug 1631721 - Vendor the hashbrown crate r=manishearth
This is the hash map implementation now used in the Rust standard library:
* https://blog.rust-lang.org/2019/07/04/Rust-1.36.0.html#a-new-hashmapk-v-implementation
* https://github.com/rust-lang/rust/pull/58623
* https://crates.io/crates/hashbrown
Differential R... | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 838de27e4..a0e4b4523 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -40,6 +40,7 @@ encoding_rs = {version = "0.8", optional = true}
euclid = "0.20"
fallible = { path = "../fallible" }
fxhash = "0.2"
+hashbrown = "0.7"
hashglobe = { path = "../hashglobe... | 1 | 1 | 0 |
6f3f56ae1406f0ae5b2d46d7c48352b59fec4bdc | Emilio Cobos Álvarez | 2020-04-23T03:02:03 | Bug 1632363 - Fix some warnings introduced by the previous patches.
MANUAL PUSH: Avoid reviewer information from previous patches from
getting lost. | diff --git a/style/animation.rs b/style/animation.rs
index 68316f8ed..69ccf4e04 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -12,10 +12,12 @@ use crate::bezier::Bezier;
use crate::context::SharedStyleContext;
use crate::dom::{OpaqueNode, TElement};
use crate::font_metrics::FontMetricsProvider;
-use cr... | 1 | 6 | 2 |
2ae72cdf2aef66a61e839704511787547b4ca1f8 | Martin Robinson | 2020-04-21T14:32:53 | Bug 1632363 - Add support for canceling CSS transitions. r=emilio
This change adds support for canceling CSS transitions when a property
is no longer transitionable or when an element becomes styled with
display:none. Support for canceling and replacing CSS transitions when
the end value changes is still pending. This... | diff --git a/style/animation.rs b/style/animation.rs
index b82d196fa..68316f8ed 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -15,7 +15,7 @@ use crate::font_metrics::FontMetricsProvider;
use crate::properties::animated_properties::{AnimatedProperty, TransitionPropertyIteration};
use crate::properties::l... | 3 | 133 | 52 |
a87459f269592e0ebc0715b6df6ce02797cd6ef8 | Martin Robinson | 2020-04-17T11:31:19 | Bug 1632363 - Eliminate `AnimationFrame`. r=emilio
This intermediate data structure doesn't really buy us anything and is a
bit confusing.
Cherry-picked from https://github.com/servo/servo/pull/26214
(though this is not part of the Gecko build). | diff --git a/style/animation.rs b/style/animation.rs
index 402c281a3..b82d196fa 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -204,7 +204,8 @@ pub enum Animation {
/// A transition is just a single frame triggered at a time, with a reflow.
///
/// the f64 field is the start time as returned... | 2 | 23 | 57 |
fe71596df08ec3ea92c467d6fcbbffd66803c50b | Anthony Ramine | 2020-04-23T02:34:13 | Bug 1632363 - Make the rule tree actually threadsafe. r=emilio
RuleTree::gc is now a safe method that any thread can call
at any time, and StrongRuleNode values can all be dropped
whenever their owner want to, on any thread.
Cherry-picked from https://github.com/servo/servo/pull/26227 | diff --git a/style/rule_tree/core.rs b/style/rule_tree/core.rs
index 5b0ff870d..ae1ba7bed 100644
--- a/style/rule_tree/core.rs
+++ b/style/rule_tree/core.rs
@@ -6,15 +6,15 @@
use crate::properties::Importance;
use crate::shared_lock::StylesheetGuards;
-use crate::thread_state;
use malloc_size_of::{MallocShallowSiz... | 2 | 313 | 313 |
37bc7e9767e344e34d842c3ff9aae88939b56949 | Anthony Ramine | 2020-04-20T12:11:45 | Bug 1632363 - Change Map::get_or_insert_with to Map::entry. r=emilio
Cherry-picked from https://github.com/servo/servo/pull/26227 | diff --git a/style/rule_tree/core.rs b/style/rule_tree/core.rs
index f51d218fc..5b0ff870d 100644
--- a/style/rule_tree/core.rs
+++ b/style/rule_tree/core.rs
@@ -13,11 +13,10 @@ use smallvec::SmallVec;
use std::fmt;
use std::hash;
use std::io::Write;
-use std::mem;
use std::ptr;
use std::sync::atomic::{AtomicPtr, A... | 2 | 66 | 46 |
f29fa9d417075041c4e8fe9991d4287e86d55f6d | Emilio Cobos Álvarez | 2020-04-20T11:07:22 | Bug 1631232 - Ensure that we hold an actual reference to the root, not to a field of a node we can just GC below. r=nox
Differential Revision: https://phabricator.services.mozilla.com/D71542 | diff --git a/style/rule_tree/core.rs b/style/rule_tree/core.rs
index 4fe4ab579..f51d218fc 100644
--- a/style/rule_tree/core.rs
+++ b/style/rule_tree/core.rs
@@ -644,7 +644,7 @@ impl Drop for StrongRuleNode {
return;
}
- let root = &node.root.as_ref().unwrap().p;
+ let root: &RuleNo... | 1 | 1 | 1 |
54739c7f4c4983de1286663366780c06a339ec4d | Anthony Ramine | 2020-04-18T10:10:09 | Bug 1631232 - Always upgrade existing weak child references in the rule tree. r=emilio
Just because we didn't find a child when read-locking a node children list
doesn't mean it still won't exist while we wait to upgrade the read lock
into a write lock to create the child.
This cherry-picks https://github.com/servo/s... | diff --git a/style/rule_tree/core.rs b/style/rule_tree/core.rs
index f3abef426..4fe4ab579 100644
--- a/style/rule_tree/core.rs
+++ b/style/rule_tree/core.rs
@@ -405,18 +405,31 @@ impl StrongRuleNode {
return child.upgrade();
}
let mut children = RwLockUpgradableReadGuard::upgrade(children... | 1 | 25 | 12 |
671042d9b24efdb2f570f86c502602fee9184785 | Emilio Cobos Álvarez | 2020-04-18T02:32:33 | Bug 1631154 - Fix a size test that was trying to test a now-private type.
MANUAL PUSH: bustage on a CLOSED TREE | diff --git a/style/rule_tree/core.rs b/style/rule_tree/core.rs
index 2c1186820..f3abef426 100644
--- a/style/rule_tree/core.rs
+++ b/style/rule_tree/core.rs
@@ -185,6 +185,9 @@ impl RuleTree {
/// where it likely did not result from a rigorous performance analysis.)
const RULE_TREE_GC_INTERVAL: usize = 300;
+/// Us... | 2 | 4 | 1 |
0df59e29c731f055a6516dafd7e583f89d60994e | Emilio Cobos Álvarez | 2020-04-18T01:46:24 | Bug 1631154 - Rustfmt and fix Servo build.
MANUAL PUSH: Review information would be lost. | diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs
index 9b8858fec..9caf427f4 100644
--- a/malloc_size_of/lib.rs
+++ b/malloc_size_of/lib.rs
@@ -748,9 +748,7 @@ where
Component::Slotted(ref selector) | Component::Host(Some(ref selector)) => {
selector.size_of(ops)
},
-... | 3 | 10 | 16 |
07823ee37d9c12facab4d4978a4388ffeae97165 | Emilio Cobos Álvarez | 2020-04-18T01:09:56 | Bug 1631154 - Fix some rebase messups. | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index 2af7989ca..ab5273db7 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -353,198 +353,6 @@ impl StrongRuleNode {
}
}
- /// Returns true if any properties specified by `rule_type_mask` was set by
- /// an author rul... | 2 | 1 | 219 |
be926a707d3148a0afee4d035ae5143e9d0e1866 | Martin Robinson | 2020-04-16T11:06:53 | Bug 1631154 - Add an iterator for transition properties. r=emilio
This simplifies the code a bit and also will allow us to more easily
make improvements to servo's animation implementation in the future. | diff --git a/style/animation.rs b/style/animation.rs
index d734acd6d..402c281a3 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -12,14 +12,13 @@ use crate::bezier::Bezier;
use crate::context::SharedStyleContext;
use crate::dom::{OpaqueNode, TElement};
use crate::font_metrics::FontMetricsProvider;
-use cr... | 4 | 144 | 141 |
ca9c205076b46d18cc3f80e38cf167a358ba6166 | Anthony Ramine | 2020-04-16T14:41:01 | Bug 1631154 - Introduce a new type UnsafeBox<T> in the rule tree. r=emilio
This lets us rely less on raw pointers, thus better tracking the lifetime
of the rule node values while dropping strong references etc. | diff --git a/style/rule_tree/core.rs b/style/rule_tree/core.rs
index 0e1dcc6c4..2c1186820 100644
--- a/style/rule_tree/core.rs
+++ b/style/rule_tree/core.rs
@@ -10,12 +10,15 @@ use crate::thread_state;
use malloc_size_of::{MallocShallowSizeOf, MallocSizeOf, MallocSizeOfOps};
use parking_lot::RwLock;
use smallvec::Sm... | 3 | 166 | 101 |
43d8e4c7ebe284dc92b82dc7c33b9dd14e958668 | Anthony Ramine | 2020-04-16T14:24:19 | Bug 1631154 - Make StrongRuleNode::downgrade be unsafe. r=emilio | diff --git a/style/rule_tree/core.rs b/style/rule_tree/core.rs
index d1aaa0d26..0e1dcc6c4 100644
--- a/style/rule_tree/core.rs
+++ b/style/rule_tree/core.rs
@@ -367,8 +367,8 @@ impl StrongRuleNode {
StrongRuleNode { p }
}
- fn downgrade(&self) -> WeakRuleNode {
- unsafe { WeakRuleNode::from_pt... | 1 | 4 | 4 |
0d2e9fae927b449806349af01373e66950827c70 | Anthony Ramine | 2020-04-16T14:20:47 | Bug 1631154 - Make StrongRuleNode::ensure_child take a StrongRuleNode for the root. r=emilio | diff --git a/style/rule_tree/core.rs b/style/rule_tree/core.rs
index 226108da9..d1aaa0d26 100644
--- a/style/rule_tree/core.rs
+++ b/style/rule_tree/core.rs
@@ -367,7 +367,7 @@ impl StrongRuleNode {
StrongRuleNode { p }
}
- pub(super) fn downgrade(&self) -> WeakRuleNode {
+ fn downgrade(&self) -> ... | 2 | 11 | 10 |
d7ca118747f47e6ad4c193ef9b29723a82233208 | Anthony Ramine | 2020-04-16T13:56:09 | Bug 1631154 - Remove WeakRuleNode::clone. r=emilio
MallocSizeOf for RuleTree should not keep around weak references in
case someone runs a GC meanwhile. | diff --git a/style/rule_tree/core.rs b/style/rule_tree/core.rs
index 4c96de291..226108da9 100644
--- a/style/rule_tree/core.rs
+++ b/style/rule_tree/core.rs
@@ -71,14 +71,14 @@ impl MallocSizeOf for RuleTree {
fn size_of(&self, ops: &mut MallocSizeOfOps) -> usize {
let mut n = 0;
let mut stack = ... | 1 | 2 | 3 |
219282dd08562fb2fae78a7afb3e565b5e581a46 | Anthony Ramine | 2020-04-16T12:39:14 | Bug 1631154 - Make WeakRuleNode::from_ptr be unsafe. r=emilio | diff --git a/style/rule_tree/core.rs b/style/rule_tree/core.rs
index 0b1afd854..4c96de291 100644
--- a/style/rule_tree/core.rs
+++ b/style/rule_tree/core.rs
@@ -369,7 +369,7 @@ impl StrongRuleNode {
}
pub(super) fn downgrade(&self) -> WeakRuleNode {
- WeakRuleNode::from_ptr(self.p)
+ unsafe { ... | 1 | 2 | 8 |
7dcf4db060d6486694e60306053798ac64eba4b9 | Anthony Ramine | 2020-04-16T12:34:24 | Bug 1631154 - Make StrongRuleNode::from_ptr be unsafe. r=emilio | diff --git a/style/rule_tree/core.rs b/style/rule_tree/core.rs
index 3103d416a..0b1afd854 100644
--- a/style/rule_tree/core.rs
+++ b/style/rule_tree/core.rs
@@ -361,10 +361,10 @@ impl StrongRuleNode {
debug!("Creating rule node: {:p}", ptr);
- StrongRuleNode::from_ptr(ptr)
+ unsafe { StrongRu... | 1 | 5 | 5 |
b84af51b94f8c2c307e86c0c8506d11e72456756 | Anthony Ramine | 2020-04-15T15:23:44 | Bug 1631154 - Move CascadeLevel to its own rule_tree submodule. r=emilio | diff --git a/style/rule_tree/level.rs b/style/rule_tree/level.rs
new file mode 100644
index 000000000..c46e63796
--- /dev/null
+++ b/style/rule_tree/level.rs
@@ -0,0 +1,277 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
... | 2 | 281 | 274 |
799b20c54a0d28fe5b84383cb39cad2ef0610a20 | Anthony Ramine | 2020-04-15T12:02:07 | Bug 1631154 - Refactor rule tree children. r=emilio
We move the data structure to its own module for better
encapsulation of unsafe code. | diff --git a/style/rule_tree/map.rs b/style/rule_tree/map.rs
new file mode 100644
index 000000000..11534d95f
--- /dev/null
+++ b/style/rule_tree/map.rs
@@ -0,0 +1,168 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * fi... | 2 | 201 | 172 |
7a072b6edb99ee4c36fa220ba0c0cc11aa6c82ae | Emilio Cobos Álvarez | 2020-04-17T13:37:59 | Bug 1629735 - Implement parsing / selector-matching for :is() and :where(). r=heycam
This implements the easy / straight-forward parts of the :where / :is
selectors.
The biggest missing piece is to handle properly invalidation when there
are combinators present inside the :where. That's the hard part of this,
actuall... | diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs
index 68935869a..9b8858fec 100644
--- a/malloc_size_of/lib.rs
+++ b/malloc_size_of/lib.rs
@@ -748,6 +748,9 @@ where
Component::Slotted(ref selector) | Component::Host(Some(ref selector)) => {
selector.size_of(ops)
},
+... | 9 | 329 | 211 |
ac2dc52557337c660222b4b06b70f69c5fcde2db | Emilio Cobos Álvarez | 2020-04-16T18:54:17 | Bug 1630676 - Fix two regressions from the previous patches.
MANUAL PUSH: Review information for upstream patches would get lost otherwise. | diff --git a/style/driver.rs b/style/driver.rs
index e8dfe7cf3..aa39f3482 100644
--- a/style/driver.rs
+++ b/style/driver.rs
@@ -89,7 +89,7 @@ pub fn traverse_dom<E, D>(
// ThreadLocalStyleContext on the main thread. If the main thread
// ThreadLocalStyleContext has not released its TLS borrow by that... | 2 | 12 | 10 |
9fa7a3113d42a3494e92275884e3b4edddb1cb24 | Josh Matthews | 2020-03-31T16:13:56 | Bug 1630676 - Refactor some Servo-only animations code. | diff --git a/style/animation.rs b/style/animation.rs
index 7f96e55b1..d734acd6d 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -328,8 +328,8 @@ impl PropertyAnimation {
let property_animation = PropertyAnimation {
property: animated_property,
- timing_function: timing_fun... | 2 | 65 | 70 |
9594c0a2ae830f6939af020e6b81108e199542e8 | Anthony Ramine | 2020-04-04T19:22:42 | Bug 1630676 - Rearrange FontLanguageOverride. r=emilio
Creating one from a u32 should be unsafe because we rely on the fact that the
value is a valid &str. | diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs
index 5e10eed61..bafcf6205 100644
--- a/style/values/computed/font.rs
+++ b/style/values/computed/font.rs
@@ -21,7 +21,6 @@ use crate::values::specified::font::{
use crate::values::specified::length::{FontBaseSize, NoCalcLength};
use crate::va... | 2 | 43 | 44 |
0ae6c3348354e954e603e5fe4ef0d01295487964 | Anthony Ramine | 2020-04-04T20:26:58 | Bug 1630676 - Replace ScopedTLS::unsafe_get by ScopedTLS::into_slots. r=emilio
We only ever look at the slots after we are done with the thread pool,
so we don't need to expose any unsafety to inspect the slots. | diff --git a/style/driver.rs b/style/driver.rs
index 88ec93387..e8dfe7cf3 100644
--- a/style/driver.rs
+++ b/style/driver.rs
@@ -165,10 +165,9 @@ pub fn traverse_dom<E, D>(
if dump_stats || report_stats {
let mut aggregate = mem::replace(&mut context.thread_local.statistics, Default::default());
... | 2 | 6 | 8 |
777cda4f3e39941e77b11603297b4286f1ebfdbf | Anthony Ramine | 2020-04-04T18:29:25 | Bug 1630676 - Don't use transmute to create PaintOrder values. r=emilio
I checked that rustc optimises the code just as well as with the transmute.
https://rust.godbolt.org/z/w6UJN4 | diff --git a/style/values/specified/svg.rs b/style/values/specified/svg.rs
index a8a20b5a3..cff899fce 100644
--- a/style/values/specified/svg.rs
+++ b/style/values/specified/svg.rs
@@ -146,8 +146,13 @@ impl SVGPaintOrder {
/// Get variant of `paint-order`
pub fn order_at(&self, pos: u8) -> PaintOrder {
- ... | 1 | 7 | 2 |
a1118d01f4d09957aa5a94ad25f2b3c0f6d04ba1 | Anthony Ramine | 2020-04-03T12:34:37 | Bug 1630676 - Don't expose any AtomicRefCell directly from style traits.
This lets us experiment with how we store this data on the DOM side. | diff --git a/style/dom.rs b/style/dom.rs
index 22a0a646f..c1c1f74ef 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -22,7 +22,7 @@ use crate::shared_lock::Locked;
use crate::stylist::CascadeData;
use crate::traversal_flags::TraversalFlags;
use crate::{Atom, LocalName, Namespace, WeakAtom};
-use atomic_refcell::{Atom... | 4 | 28 | 17 |
88a6ed9c0d425f6b1e0c653dda569e1a3a730f38 | Tipowol | 2020-04-03T18:10:57 | Bug 1630676 - Update Servo's attribute length parsing code to match spec. | diff --git a/style/attr.rs b/style/attr.rs
index 1d0d555d5..92ab7700f 100644
--- a/style/attr.rs
+++ b/style/attr.rs
@@ -539,28 +539,18 @@ pub fn parse_length(mut value: &str) -> LengthOrPercentageOrAuto {
value = value.trim_start_matches(HTML_SPACE_CHARACTERS);
// Step 4
- if value.is_empty() {
- ... | 1 | 2 | 12 |
48031720ef1810be9607c6fc5af426d5177b5eb1 | Martin Robinson | 2020-02-13T16:22:22 | Bug 1630676 - Cherry-pick some layout-2020 changes. | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 47aef2342..a4f2cc670 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -345,7 +345,6 @@ ${helpers.predefined_type(
"Transform",
"generics::transform::Transform::... | 11 | 46 | 33 |
bda9ee0b189a9fa3b2f7f953ebee2f9f0fe80166 | Josh Matthews | 2020-02-19T22:07:29 | Bug 1630676 - Update ipc-channel and crossbeam-channel in Servo. | diff --git a/style/Cargo.toml b/style/Cargo.toml
index e0ac029ea..838de27e4 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -33,7 +33,7 @@ atomic_refcell = "0.1"
bitflags = "1.0"
byteorder = "1.0"
cssparser = "0.27"
-crossbeam-channel = { version = "0.3", optional = true }
+crossbeam-channel = { version = "0... | 1 | 1 | 1 |
8b7d07e7f018a0f084a208c8845a9baad739714d | Simon Sapin | 2020-02-14T09:58:04 | Bug 1630676 - Fix some errors and formatting changes when updating rustc to 1.43.0-nightly (5d04ce67f 2020-02-13). | diff --git a/style/stylesheet_set.rs b/style/stylesheet_set.rs
index f2a3541d2..a9cd39eef 100644
--- a/style/stylesheet_set.rs
+++ b/style/stylesheet_set.rs
@@ -390,7 +390,8 @@ macro_rules! sheet_set_methods {
guard: &SharedRwLockReadGuard,
) {
if let Some(device) = device {
- ... | 3 | 6 | 5 |
436d708deeeb26a113ad36b56531a5daa3048c61 | Dzmitry Malyshau | 2020-04-12T19:14:43 | Bug 1629359 - Update parking_lot to 0.10 r=kats
Differential Revision: https://phabricator.services.mozilla.com/D70646 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index a48e17e2c..e0ac029ea 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -56,7 +56,7 @@ num-integer = "0.1"
num-traits = "0.2"
num-derive = "0.3"
owning_ref = "0.4"
-parking_lot = "0.9"
+parking_lot = "0.10"
precomputed-hash = "0.1.1"
rayon = "1"
selector... | 1 | 1 | 1 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.