commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
99f5cefa0984f3507b6eff05d4f0954d16d191df | Stefan Hindli | 2020-04-12T19:09:15 | Backed out changeset 01cb2f16985e (bug 1629359) for linux x64 qr webgpu bustage | diff --git a/style/Cargo.toml b/style/Cargo.toml
index e0ac029ea..a48e17e2c 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -56,7 +56,7 @@ num-integer = "0.1"
num-traits = "0.2"
num-derive = "0.3"
owning_ref = "0.4"
-parking_lot = "0.10"
+parking_lot = "0.9"
precomputed-hash = "0.1.1"
rayon = "1"
selector... | 1 | 1 | 1 |
183f0e2ffdf14f744e7334f7a5876dab1953c435 | Mike Hommey | 2020-04-12T01:25:21 | Bug 1629310 - Build mako-generated stylo rust sources deterministically. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D70633 | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 6811fd077..9baab22cb 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -737,7 +737,7 @@
aliases.append(alias)
%>
% if aliases:
- #[pa... | 2 | 3 | 3 |
6f7c9e9d22d4644646bcfa2aa106d31e27725625 | Bastien Orivel | 2020-04-11T08:55:12 | Bug 1581062 - Part 2: Remove the unicode feature from a few crates. r=froydnj,emilio,jgraham,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65863 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 5ffe1a3e1..a48e17e2c 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -84,6 +84,6 @@ void = "1.0.2"
lazy_static = "1"
log = "0.4"
bindgen = {version = "0.53", optional = true, default-features = false}
-regex = {version = "1.0", optional = true}
+regex = ... | 1 | 1 | 1 |
dad35a6e0828b3bc96583799fc470411b6cd0b58 | Erik Nordin | 2020-04-08T22:45:24 | Bug 1621849 - Add CSS Error for DisallowedImportRule r=emilio
- Add new CSS Error
- Add new test case for error
- Ensure that test cases use `replace()` and `replaceSync()`
Differential Revision: https://phabricator.services.mozilla.com/D69423 | diff --git a/style/stylesheets/rule_parser.rs b/style/stylesheets/rule_parser.rs
index d380f1798..74425afaf 100644
--- a/style/stylesheets/rule_parser.rs
+++ b/style/stylesheets/rule_parser.rs
@@ -193,7 +193,7 @@ impl<'a, 'i> AtRuleParser<'i> for TopLevelRuleParser<'a> {
}
if let All... | 2 | 3 | 2 |
5deba1ade2140d6bfc478c6b44d1bd1827265b6d | Cameron McCormack | 2020-04-08T05:31:26 | Bug 1623819 - Part 2: Assert that initial values in style structs match those in property definitions. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D67930 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 908735c60..f3db987d8 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -29,6 +29,7 @@ use crate::gecko_bindings::bindings::Gecko_nsStyleFont_CopyLangFrom;
use crate::gecko_bindings::structs;
use crate:... | 1 | 38 | 0 |
153d4c89b29dcbfa870113140af1730dfb74aa8b | Cameron McCormack | 2020-04-08T05:31:19 | Bug 1623819 - Part 1: Fix a few initial values in Rust property definitions. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D67929 | diff --git a/style/properties/longhands/background.mako.rs b/style/properties/longhands/background.mako.rs
index 38ccb99c5..1cbf601ad 100644
--- a/style/properties/longhands/background.mako.rs
+++ b/style/properties/longhands/background.mako.rs
@@ -35,8 +35,8 @@ ${helpers.predefined_type(
${helpers.predefined_type... | 8 | 16 | 9 |
a70bc5981671601e6086ff1b93fcee539c5234bd | Emilio Cobos Álvarez | 2020-04-06T10:25:08 | Bug 1624968 - Make :host::part work in the same shadow tree as the part. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D68249 | diff --git a/selectors/matching.rs b/selectors/matching.rs
index 8993a5ea0..e8fd8afeb 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -676,19 +676,22 @@ where
None => return false,
};
- loop {
- let outer_host = host.containing_shadow_host();
-... | 2 | 112 | 74 |
4f9516208381b5cb2b1a99991bb6b9d8239f8a35 | Cameron McCormack | 2020-04-05T03:21:24 | Bug 1623820 - Part 2: Make image-orientation initial value change be Nightly only. r=emilio
We'll let this ride the trains once Chrome 81 is set to be released.
Differential Revision: https://phabricator.services.mozilla.com/D67932 | diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs
index d2b66dc6a..fe2cc5ed0 100644
--- a/style/properties/longhands/inherited_box.mako.rs
+++ b/style/properties/longhands/inherited_box.mako.rs
@@ -85,7 +85,8 @@ ${helpers.single_keyword(
${helpers.single... | 1 | 2 | 1 |
07eb7f478abe903b2ae1962035563dbc6dcf252e | Cameron McCormack | 2020-04-05T03:21:16 | Bug 1623820 - Part 1: Add support for pref-controlled initial values. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D67931 | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 7a25b2569..7bfbed8b8 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -707,7 +707,8 @@
</%def>
<%def name="single_keyword(name, values, vector=False,
- extra_specified=None, needs... | 1 | 16 | 3 |
969410d3fad3d12d1ea2fbfe8561ea05f18b1cfd | Emilio Cobos Álvarez | 2020-03-30T15:09:33 | Bug 1625036 - Tweak background: transparent handling so that color: transparent doesn't override UA sheet backgrounds. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D68408 | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index d6c3180ac..e9a34d6bf 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -372,13 +372,12 @@ fn tweak_when_ignoring_colors(
// We honor color and background-color: transparent, and
// "revert-or-initi... | 1 | 5 | 6 |
f2ca98f75f08346ab5507c760bfbe6864d99faa9 | Philipp Zech | 2020-03-28T22:17:50 | Bug 1625699 - Convert control-character-visibility #defines to an enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D68705 | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index 41ac96b6d..0d9104481 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -374,7 +374,7 @@ ${helpers.single_keyword(
"-moz-co... | 1 | 1 | 1 |
d5e7cb6159ed2fdde1ec1d77da83360a1a18844d | Tim Nguyen | 2020-03-27T22:52:32 | Bug 1618997 - Omit center positions in conic/radial gradient serialization. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D67461 | diff --git a/style/values/computed/position.rs b/style/values/computed/position.rs
index 7b22c37f7..eb6463c2e 100644
--- a/style/values/computed/position.rs
+++ b/style/values/computed/position.rs
@@ -9,6 +9,7 @@
use crate::values::computed::{Integer, LengthPercentage, Percentage};
use crate::values::generics::posi... | 4 | 77 | 12 |
2973a1a9610af385ae73a63bbb27d5bdcecfa517 | Ciure Andrei | 2020-03-27T22:14:32 | Backed out changeset 9bbf5c41c5ce (bug 1618997) for causing for causing mochitest and wpt failures CLOSED TREE | diff --git a/style/values/computed/position.rs b/style/values/computed/position.rs
index eb6463c2e..7b22c37f7 100644
--- a/style/values/computed/position.rs
+++ b/style/values/computed/position.rs
@@ -9,7 +9,6 @@
use crate::values::computed::{Integer, LengthPercentage, Percentage};
use crate::values::generics::posi... | 4 | 12 | 77 |
a82b6e07d3006d0a848866f39ac5b7f033411834 | Ciure Andrei | 2020-03-27T19:50:25 | Backed out changeset 507a811671f8 (bug 1618997) for causing bustages CLOSED TREE | diff --git a/style/values/computed/position.rs b/style/values/computed/position.rs
index 20e6c2ce7..7b22c37f7 100644
--- a/style/values/computed/position.rs
+++ b/style/values/computed/position.rs
@@ -9,7 +9,6 @@
use crate::values::computed::{Integer, LengthPercentage, Percentage};
use crate::values::generics::posi... | 4 | 12 | 77 |
c4c071067c81468946e05acfdfa071ed17e69629 | Tim Nguyen | 2020-03-27T19:36:18 | Bug 1618997 - Omit center positions in conic/radial gradient serialization. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D67461 | diff --git a/style/values/computed/position.rs b/style/values/computed/position.rs
index 7b22c37f7..20e6c2ce7 100644
--- a/style/values/computed/position.rs
+++ b/style/values/computed/position.rs
@@ -9,6 +9,7 @@
use crate::values::computed::{Integer, LengthPercentage, Percentage};
use crate::values::generics::posi... | 4 | 77 | 12 |
3bd6fd5eb7207480d87017e1809c4902f16274d5 | Emilio Cobos Álvarez | 2020-03-26T16:48:01 | Bug 1624080 - Simplify the implementation of HasAuthorSpecifiedRules. r=heycam
This patch computes the author-specified properties during the CSS cascade, and
removes the complex rule-tree-based implementation that tries to do the cascade
again.
This changes behavior in two ways, one of them which is not observable t... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 9d3660730..d6c3180ac 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -13,7 +13,7 @@ use crate::media_queries::Device;
use crate::properties::{ComputedValues, StyleBuilder};
use crate::properties::{LonghandId, Lo... | 5 | 122 | 243 |
02c33fdc01432fb2f3f878b9e719bc9f6b85ed5b | Razvan Maries | 2020-03-26T14:52:18 | Backed out changeset ac0d06c0ca93 (bug 1624080) for assertion failures. CLOSED TREE | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 415c8084d..9d3660730 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -13,7 +13,7 @@ use crate::media_queries::Device;
use crate::properties::{ComputedValues, StyleBuilder};
use crate::properties::{LonghandId, Lo... | 5 | 243 | 127 |
9772f19d522af961ef9b08747607acd14a696e91 | Emilio Cobos Álvarez | 2020-03-26T13:23:42 | Bug 1624080 - Simplify the implementation of HasAuthorSpecifiedRules. r=heycam
This patch computes the author-specified properties during the CSS cascade, and
removes the complex rule-tree-based implementation that tries to do the cascade
again.
This changes behavior in two ways, one of them which is not observable t... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 9d3660730..415c8084d 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -13,7 +13,7 @@ use crate::media_queries::Device;
use crate::properties::{ComputedValues, StyleBuilder};
use crate::properties::{LonghandId, Lo... | 5 | 127 | 243 |
fb5a4a742227d0438d0647552122441ef5ca8335 | Emilio Cobos Álvarez | 2020-03-26T13:04:20 | Bug 1624298 - Ensure that derived types are right for optimized-away implementations. r=heycam
We have this optimization where, for non-generic structs, we generate just a
clone / move as the ToComputedValue / ToResolvedValue implementation.
This moves the optimization a bit further down, and refines it so that we st... | diff --git a/style/counter_style/mod.rs b/style/counter_style/mod.rs
index d131f3503..bffedd845 100644
--- a/style/counter_style/mod.rs
+++ b/style/counter_style/mod.rs
@@ -408,7 +408,7 @@ impl ToCss for System {
}
/// <https://drafts.csswg.org/css-counter-styles/#typedef-symbol>
-#[derive(Clone, Debug, Eq, MallocS... | 18 | 294 | 145 |
f3bb358e0c929de0133c06cc6192012d144a194e | Emilio Cobos Álvarez | 2020-03-26T11:44:01 | Bug 1546375 - Don't append the default namespace for featureless host selectors. r=heycam
Per the spec it shouldn't match, and the front-end has been bitten by this
multiple times.
Differential Revision: https://phabricator.services.mozilla.com/D68213 | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 92a5b039b..d354b0107 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -2013,27 +2013,45 @@ where
input.skip_whitespace();
let mut empty = true;
- if !parse_type_selector(parser, input, builder)? {
- if let Some(url) = parser... | 1 | 28 | 10 |
33333abf35517888ee6509f99f1187e31f0c8184 | Emilio Cobos Álvarez | 2020-03-26T11:34:12 | Bug 1623396 - Custom properties with invalid variable references should be unset, not invalid. r=heycam
See https://github.com/w3c/csswg-drafts/issues/4075.
There are tests that will get updated and this will make pass in bug 1623347.
Differential Revision: https://phabricator.services.mozilla.com/D67373 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 76a72276a..d97787062 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -579,9 +579,10 @@ impl<'a> CustomPropertiesBuilder<'a> {
match result {
Ok(new_value) => Arc::new(new_... | 1 | 31 | 12 |
cfcf20cbc22be157d474a545c38b17be6274593c | Dorel Luca | 2020-03-25T20:23:26 | Backed out 2 changesets (bug 1581062) for Toolchain failures. CLOSED TREE
Backed out changeset c333f6f9d1bd (bug 1581062)
Backed out changeset 485c738acdb1 (bug 1581062) | diff --git a/style/Cargo.toml b/style/Cargo.toml
index a48e17e2c..5ffe1a3e1 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -84,6 +84,6 @@ void = "1.0.2"
lazy_static = "1"
log = "0.4"
bindgen = {version = "0.53", optional = true, default-features = false}
-regex = {version = "1.0", optional = true, default-f... | 1 | 1 | 1 |
1925edb1a36a306a8ed28ed179842c077b41ee31 | Emily McDonough | 2020-03-19T22:11:48 | Bug 1341507 part 6 - Enable multiple grid repeat values in Servo r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D60931 | diff --git a/style/values/generics/grid.rs b/style/values/generics/grid.rs
index 1b95934e3..6f0f15591 100644
--- a/style/values/generics/grid.rs
+++ b/style/values/generics/grid.rs
@@ -696,14 +696,6 @@ impl Parse for LineNameList {
.take(num.value() as usize * names_list.len()),
... | 2 | 0 | 18 |
6bf7634d0535287be961b348eb323c33bf019277 | Emily McDonough | 2020-03-19T22:11:43 | Bug 1341507 part 4 - Add auto-fill length field to line name lists returned from Servo. r=mats,emilio
Rename fill_idx to fill_start, to indicate it is not a single value but a
range. Also change a numeric_limits<>::max() involving the fill_start to use
decltype() to ensure its type matches that of the auto-generated s... | diff --git a/style/values/generics/grid.rs b/style/values/generics/grid.rs
index 5666e2c58..1b95934e3 100644
--- a/style/values/generics/grid.rs
+++ b/style/values/generics/grid.rs
@@ -655,8 +655,10 @@ impl<L: ToCss, I: ToCss> ToCss for TrackList<L, I> {
pub struct LineNameList {
/// The optional `<line-name-list... | 1 | 19 | 14 |
19134f5ae0fb894888b3df4626affc4bf648f608 | Philipp Zech | 2020-03-19T13:48:57 | Bug 1623410 - Convert mask-composite #defines to an enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D67394 | diff --git a/style/properties/longhands/svg.mako.rs b/style/properties/longhands/svg.mako.rs
index 1d4c880f0..69e9ccaf2 100644
--- a/style/properties/longhands/svg.mako.rs
+++ b/style/properties/longhands/svg.mako.rs
@@ -165,6 +165,7 @@ ${helpers.single_keyword(
"mask-composite",
"add subtract intersect exclu... | 1 | 1 | 0 |
521a4ab0801d72b4c17141fb95d37af474db517d | Stefan Hindli | 2020-03-19T00:49:17 | Backed out 7 changesets (bug 1341507) for mochitest failures in dom/grid/test/chrome/test_grid_repeat_auto_fill.html CLOSED TREE
Backed out changeset e4e968fabe2b (bug 1341507)
Backed out changeset 6cafdef7eb79 (bug 1341507)
Backed out changeset eff4ad47440c (bug 1341507)
Backed out changeset 55432ee0cd4b (bug 1341507... | diff --git a/style/values/generics/grid.rs b/style/values/generics/grid.rs
index 6f0f15591..5666e2c58 100644
--- a/style/values/generics/grid.rs
+++ b/style/values/generics/grid.rs
@@ -655,10 +655,8 @@ impl<L: ToCss, I: ToCss> ToCss for TrackList<L, I> {
pub struct LineNameList {
/// The optional `<line-name-list... | 2 | 32 | 19 |
ee8e11557a04bd7b109a2b74245b4744faaecef2 | Emilio Cobos Álvarez | 2020-03-18T09:21:44 | Bug 1618260 - Fix number input so that it honors overflow-clip-box-block. r=mats
This never worked, but it's more visible with the new form controls which have
more padding.
Make the anonymous div and co a pseudo-element, so that they inherit from the
<input> properly in all cases. This works for non-number inputs be... | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index 8d05dd9bb..d989380c0 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -134,12 +134,6 @@ impl PseudoElement {
*self == PseudoElement::FirstLine
}
- /// Whether this pseudo-element is ::-mo... | 2 | 36 | 9 |
5625b8128551be3237eeb8e2d309b1a94d5e417c | Emilio Cobos Álvarez | 2020-03-17T21:48:33 | Bug 1623178 - Change the parsing order of border shorthands. r=mats
It's not ambiguous, and <width> <style> <color> seems like a more common order.
This is just a minor perf tweak, as the CSS parser token cache will most often
kick in to avoid re-tokenizing values.
Also remove a redundant continue statement.
Differ... | diff --git a/style/properties/shorthands/border.mako.rs b/style/properties/shorthands/border.mako.rs
index 1f77b9050..e5122153d 100644
--- a/style/properties/shorthands/border.mako.rs
+++ b/style/properties/shorthands/border.mako.rs
@@ -70,11 +70,10 @@ pub fn parse_border<'i, 't>(
let mut width = None;
let mu... | 1 | 6 | 7 |
cd7efd470bd715bb54f8349d62d0186b27b173d0 | Sam Mauldin | 2020-03-17T16:08:19 | Bug 1590894: Unprefix existing CSS4 system colors r=emilio
Expect forced-colors-mode-backplate tests to fail because they were passing for the wrong reason,
and the backplate is now properly applied, causing them to fail.
Remove tests for field and fieldtext from color-valid.html because they are tested again
in syst... | diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs
index be969f27c..e697f2523 100644
--- a/style/values/specified/color.rs
+++ b/style/values/specified/color.rs
@@ -140,8 +140,10 @@ pub enum SystemColor {
Windowframe,
Windowtext,
MozButtondefault,
- MozDefaultColor,
- Mo... | 1 | 15 | 10 |
332e1b74045b6815507f5b167b974b14f0c5e69c | Daniel Varga | 2020-03-15T21:09:42 | Backed out changeset a2030f611422 (bug 1590894) for causing mochitest failure at layout/style/test/test_value_computation.html | diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs
index e697f2523..be969f27c 100644
--- a/style/values/specified/color.rs
+++ b/style/values/specified/color.rs
@@ -140,10 +140,8 @@ pub enum SystemColor {
Windowframe,
Windowtext,
MozButtondefault,
- #[parse(aliases = "-moz-... | 1 | 10 | 15 |
14a97726c5e2e4f7c9615a78909d4b8711ca1faf | Philipp Zech | 2020-03-14T21:24:11 | Bug 1622332 - Convert style-blend #defines to an enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D66867 | diff --git a/style/properties/longhands/background.mako.rs b/style/properties/longhands/background.mako.rs
index a0b026c59..38ccb99c5 100644
--- a/style/properties/longhands/background.mako.rs
+++ b/style/properties/longhands/background.mako.rs
@@ -107,7 +107,7 @@ ${helpers.single_keyword(
"""normal multiply scree... | 2 | 2 | 2 |
9c56aca8b3ed1d41bd77f460153c23ebf7b6d858 | Erik Nordin | 2020-03-12T18:11:09 | Bug 1613511 - Disallow @import rules for all Constructable StyleSheets functions r=emilio
- Add enum AllowImportRules to CSS parsing.
- `replaceSync()` will skip over @import rules and continue parsing.
- `replace()` will skip over @import rules and continue parsing.
- `insertRule()` will throw a syntax error on @impo... | diff --git a/style/stylesheets/mod.rs b/style/stylesheets/mod.rs
index c9697ead6..9d007e45a 100644
--- a/style/stylesheets/mod.rs
+++ b/style/stylesheets/mod.rs
@@ -59,7 +59,7 @@ pub use self::rules_iterator::{AllRules, EffectiveRules};
pub use self::rules_iterator::{NestedRuleIterationCondition, RulesIterator};
pub ... | 4 | 34 | 3 |
540bdaf5ee72ce06b233168dc93705b20a168045 | Philipp Zech | 2020-03-11T20:58:23 | Bug 1621706 - Convert backface-visibility #defines to an enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D66487 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 9ef03273f..47aef2342 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -574,6 +574,7 @@ ${helpers.single_keyword(
"backface-visibility",
"visible hidden",
e... | 1 | 1 | 0 |
0b44c8aa92af912bf1dbd2b8ab074a1a43ef9f35 | Emilio Cobos Álvarez | 2020-03-10T21:07:34 | Bug 1621044 - Update in-tree consumers of bindgen. r=keeler,rhunt
Differential Revision: https://phabricator.services.mozilla.com/D66281 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index f2ff6c915..5ffe1a3e1 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -83,7 +83,7 @@ void = "1.0.2"
[build-dependencies]
lazy_static = "1"
log = "0.4"
-bindgen = {version = "0.51.1", optional = true, default-features = false}
+bindgen = {version = "0.53",... | 2 | 2 | 1 |
a8b15798e14f8a7ccd670d7ae3ba36c818b2ee55 | Emilio Cobos Álvarez | 2020-03-09T13:04:21 | Bug 1618509 - Allow to export a shadow part under multiple names. r=jwatt
Other browsers allow this and the spec doesn't really disallow it, so fix it,
add a test and carry on.
Differential Revision: https://phabricator.services.mozilla.com/D65107 | diff --git a/selectors/tree.rs b/selectors/tree.rs
index d6198c5a5..ac90fa1f0 100644
--- a/selectors/tree.rs
+++ b/selectors/tree.rs
@@ -117,13 +117,6 @@ pub trait Element: Sized + Clone + Debug {
case_sensitivity: CaseSensitivity,
) -> bool;
- /// Returns the mapping from the `exportparts` attribute... | 8 | 46 | 46 |
2b3d77d6623a3d0d7f32b4e54017bf411bb78595 | Philipp Zech | 2020-03-06T14:40:50 | Bug 1620034 - Convert vector-effect #defines to an enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D65718 | diff --git a/style/properties/longhands/svg.mako.rs b/style/properties/longhands/svg.mako.rs
index fbf240db2..1d4c880f0 100644
--- a/style/properties/longhands/svg.mako.rs
+++ b/style/properties/longhands/svg.mako.rs
@@ -10,6 +10,7 @@ ${helpers.single_keyword(
"vector-effect",
"none non-scaling-stroke",
... | 1 | 1 | 0 |
44406ced597a06820868708f61d61fd506dcae2d | Emilio Cobos Álvarez | 2020-03-05T21:13:46 | Bug 1620307 - Rename -moz-menulist-button to -moz-menulist-arrow-button. r=spohl
This should be less confusing. This is not supported outside of chrome:// or
user-agent stylesheets so we can name this however we want.
Differential Revision: https://phabricator.services.mozilla.com/D65605 | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index dbdaf2048..75da811f0 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -1601,7 +1601,7 @@ pub enum Appearance {
Meterchunk,
/// The "arrowed" part of the dropdown button that open up a dropdown lis... | 1 | 1 | 1 |
9d686f0a8bb1420718f99bb9dbb053c9021cfb9e | Emilio Cobos Álvarez | 2020-03-04T21:25:24 | Bug 1619701 - Respect the cascade properly when in high-contrast mode. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D65345 | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index da069b28f..9d3660730 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -337,94 +337,74 @@ where
context.builder.build()
}
-/// How should a declaration behave when ignoring document colors?
-enum Declaration... | 2 | 49 | 84 |
79e6160be2ff2352db610df5f4de86ed4486a037 | Makoto Kato | 2020-03-04T08:15:17 | Bug 1503656 - Part 5. Get safe area insets from Gecko. r=emilio
Add binding to get safe area insets from Gecko.
Differential Revision: https://phabricator.services.mozilla.com/D52509 | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 25ce9f5b3..1724f1605 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -310,6 +310,15 @@ impl Device {
/// Returns safe area insets
pub fn safe_area_insets(&self) -> SideOffsets2D<f32, CSSPixel> {
- ... | 1 | 10 | 1 |
9937c456096cd9c7dd23e6cd0c2e4fc17fe44876 | Csoregi Natalia | 2020-03-04T08:07:42 | Backed out 6 changesets (bug 1503656) as per request. CLOSED TREE
Backed out changeset 27faa3b167a9 (bug 1503656)
Backed out changeset 7111f9b5ad06 (bug 1503656)
Backed out changeset 43fdc889beac (bug 1503656)
Backed out changeset 332ceea26151 (bug 1503656)
Backed out changeset f31efa4ea2ec (bug 1503656)
Backed out ch... | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 1724f1605..25ce9f5b3 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -310,15 +310,6 @@ impl Device {
/// Returns safe area insets
pub fn safe_area_insets(&self) -> SideOffsets2D<f32, CSSPixel> {
- ... | 1 | 1 | 10 |
ba66902aa52fd5d207f5e856f4cbc2cc8af1ea26 | Morgan Reschenberg | 2020-03-04T01:19:41 | Bug 1617678: Modify background image styling to only apply URL-sourced images when backplate is enabled. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D64200 | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 50029da84..da069b28f 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -380,6 +380,9 @@ fn application_when_ignoring_colors(
// Here we check backplate status to decide if ignoring background-image
// is t... | 1 | 14 | 3 |
c53d67ccdbb70c76f3a5b4510539a09605ea3182 | Razvan Maries | 2020-03-03T21:16:37 | Backed out changeset dc3ad7ffa787 (bug 1617678) for perma failures on bg-image-div-001.html. CLOSED TREE | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index da069b28f..50029da84 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -380,9 +380,6 @@ fn application_when_ignoring_colors(
// Here we check backplate status to decide if ignoring background-image
// is t... | 1 | 3 | 14 |
e598f290a43d6bdc893f305f3db80ed41abbdc55 | Philipp Zech | 2020-02-29T15:41:13 | Bug 1617644 - Convert color-interpolation #defines to an enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D64813 | diff --git a/style/properties/longhands/inherited_svg.mako.rs b/style/properties/longhands/inherited_svg.mako.rs
index 1839f90d6..73db38e00 100644
--- a/style/properties/longhands/inherited_svg.mako.rs
+++ b/style/properties/longhands/inherited_svg.mako.rs
@@ -36,15 +36,16 @@ ${helpers.single_keyword(
engines="gec... | 1 | 2 | 1 |
12938d5aa0cb5e072ffd541467d08afd27b517a5 | Emilio Cobos Álvarez | 2020-02-27T02:26:39 | Bug 1618303 - Add an inherited style bit to know whether an element is in an opacity: 0 subtree. r=hiro
I think this should work for the animation throttling stuff.
Opacity works on the element tree, so I think this is sound.
Differential Revision: https://phabricator.services.mozilla.com/D64441 | diff --git a/style/properties/computed_value_flags.rs b/style/properties/computed_value_flags.rs
index 4363f3f36..b5294093a 100644
--- a/style/properties/computed_value_flags.rs
+++ b/style/properties/computed_value_flags.rs
@@ -67,6 +67,9 @@ bitflags! {
/// Whether this style is the style of the document el... | 2 | 23 | 13 |
416c5ae18ffa808eab89edab215e3a49abc75955 | Emilio Cobos Álvarez | 2020-02-27T01:46:10 | Bug 1617746 - Minor cleanup of ServoStyleSet. r=nordzilla
Removing unused arguments and so on.
The origin can always be inferred from the stylesheet so it wasn't being used.
Differential Revision: https://phabricator.services.mozilla.com/D64150 | diff --git a/style/stylesheet_set.rs b/style/stylesheet_set.rs
index d8c21d549..f2a3541d2 100644
--- a/style/stylesheet_set.rs
+++ b/style/stylesheet_set.rs
@@ -294,7 +294,9 @@ where
// Removing sheets makes us tear down the whole cascade and invalidation
// data, but only if the sheet has been involv... | 1 | 3 | 1 |
157ca9ae558534ff9ba6c14100fb098c54912ae9 | Cosmin Sabou | 2020-02-26T23:12:46 | Backed out 2 changesets (bug 1617746) assertion failures on ShadowRoot.cpp.
CLOSED TREE
Backed out changeset 6cb30e866b95 (bug 1617746)
Backed out changeset 3543162b815b (bug 1617746) | diff --git a/style/stylesheet_set.rs b/style/stylesheet_set.rs
index f2a3541d2..d8c21d549 100644
--- a/style/stylesheet_set.rs
+++ b/style/stylesheet_set.rs
@@ -294,9 +294,7 @@ where
// Removing sheets makes us tear down the whole cascade and invalidation
// data, but only if the sheet has been involv... | 1 | 1 | 3 |
93c0270bb5a1b92069c30539ce859cb8c1b3a615 | Emilio Cobos Álvarez | 2020-02-26T14:16:27 | Bug 1617600 - Remove no-longer-used argument to pseudo-class-list-macro. r=firefox-style-system-reviewers,jwatt
This used to be needed for Gecko interop, but now all this is in the Rust side
so we no longer need it.
Depends on D63861
Differential Revision: https://phabricator.services.mozilla.com/D63863 | diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs
index f8f23e1bf..ea5db9803 100644
--- a/style/gecko/non_ts_pseudo_class_list.rs
+++ b/style/gecko/non_ts_pseudo_class_list.rs
@@ -30,78 +30,78 @@ macro_rules! apply_non_ts_list {
($apply_macro:ident) => {
$apply... | 2 | 71 | 71 |
2d4c75dde73dcb30aa883de2d03fe447089fbe1f | Emilio Cobos Álvarez | 2020-02-26T14:16:20 | Bug 1617600 - Prototype :focus-visible behind a flag. r=smaug
The heuristic is that we show focus outlines for unknown or key focus, and not
for mouse / touch.
This is probably not the final heuristic we take, but this allows people to play
with it and file bugs.
Once this is mature enough we should remove :-moz-foc... | diff --git a/style/element_state.rs b/style/element_state.rs
index 8165c73ef..cf943cc3c 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -137,6 +137,10 @@ bitflags! {
const IN_AUTOFILL_STATE = 1 << 50;
/// Non-standard & undocumented.
const IN_AUTOFILL_PREVIEW_STATE = 1 << ... | 4 | 9 | 0 |
f73f14e97c1536642827a4cedc7b57cd2562bfee | Noemi Erli | 2020-02-25T23:46:31 | Backed out 3 changesets (bug 1617600) for causing wpt failures in focus-visible-009.html CLOSED TREE
Backed out changeset 73d1a5e10337 (bug 1617600)
Backed out changeset b722714830cd (bug 1617600)
Backed out changeset 45464d926bf0 (bug 1617600) | diff --git a/style/element_state.rs b/style/element_state.rs
index cf943cc3c..8165c73ef 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -137,10 +137,6 @@ bitflags! {
const IN_AUTOFILL_STATE = 1 << 50;
/// Non-standard & undocumented.
const IN_AUTOFILL_PREVIEW_STATE = 1 << ... | 4 | 70 | 79 |
40a8c8ca15a7dd41e0b75aae257817fd6e083944 | Emilio Cobos Álvarez | 2020-02-23T22:27:13 | Bug 1617069 - Minor LengthPercentage improvements. r=heycam
* Use debug_unreachable for really unreachable code (having a release
unreachable!() there gives us little to no benefit, as a borked union can
already confuse us into reading an arbitrary pointer as a CalcPercentage).
* Avoid a clone of the calc vari... | diff --git a/style/values/computed/length_percentage.rs b/style/values/computed/length_percentage.rs
index 4a796ba7b..7c87fdef2 100644
--- a/style/values/computed/length_percentage.rs
+++ b/style/values/computed/length_percentage.rs
@@ -170,6 +170,13 @@ enum Unpacked<'a> {
Percentage(Percentage),
}
+/// An unpa... | 1 | 27 | 12 |
7200459c7fc0b60cb889a0fbd22849f09973c278 | Emilio Cobos Álvarez | 2020-02-23T15:43:21 | Bug 1617425 - Minor cleanup of gecko.mako.rs. r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D63779 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 906cc75ad..6286b81d0 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -536,12 +536,7 @@ impl Clone for ${style_struct.gecko_struct_name} {
</%def>
-<%def name="impl_simple_type_with_conversion(iden... | 1 | 13 | 34 |
9ba0fd8581e6f8644484ab962c80c1ff73b51cac | Emilio Cobos Álvarez | 2020-02-23T15:43:03 | Bug 1617425 - Use cbindgen for SVG lengths. r=jwatt
Depends on D63777
Differential Revision: https://phabricator.services.mozilla.com/D63778 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index f4269ceb7..906cc75ad 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -387,112 +387,6 @@ def set_gecko_property(ffi_name, expr):
}
</%def>
-<%def name="impl_svg_length(ident, gecko_ffi_name)">
-... | 4 | 10 | 166 |
63a15d77ab69b5bead479962c109532c2e164d37 | Emilio Cobos Álvarez | 2020-02-23T13:07:30 | Bug 1617421 - Use cbindgen for cursors. r=jwatt
Pretty straight-forward.
Differential Revision: https://phabricator.services.mozilla.com/D63777 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 400f27fa4..f4269ceb7 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -22,7 +22,6 @@ use crate::gecko_bindings::bindings::Gecko_CopyConstruct_${style_struct.gecko_ff
use crate::gecko_bindings::bindings... | 4 | 39 | 77 |
4a4e250cfcce7b4053aea1ad076b3eaae7e69a9f | Emilio Cobos Álvarez | 2020-02-21T00:47:02 | Bug 1616691 - Properly reject numbers as part of <length-percentage>. r=heycam
We never fast-reject numbers (because they could be part of a product). Without
this refactoring we'd accept stuff like calc(10) and crash during the evaluation
for obvious reasons.
Differential Revision: https://phabricator.services.mozil... | diff --git a/style/values/computed/length_percentage.rs b/style/values/computed/length_percentage.rs
index 98b46454d..4a796ba7b 100644
--- a/style/values/computed/length_percentage.rs
+++ b/style/values/computed/length_percentage.rs
@@ -242,7 +242,7 @@ impl LengthPercentage {
mut node: CalcNode,
clamp... | 3 | 62 | 19 |
7c7e8cd64a8ea57fb68b2787fb9318e2e3dc8c41 | Emilio Cobos Álvarez | 2020-02-21T00:47:00 | Bug 1616691 - Fix one minor serialization issue which was causing test failures. r=heycam
We were serializing calc(10% + 4px) as calc(10% + calc(4px)).
Differential Revision: https://phabricator.services.mozilla.com/D63400 | diff --git a/style/values/generics/calc.rs b/style/values/generics/calc.rs
index d7ba5e398..99345b646 100644
--- a/style/values/generics/calc.rs
+++ b/style/values/generics/calc.rs
@@ -454,10 +454,10 @@ impl<L: CalcNodeLeaf> CalcNode<L> {
dest.write_str(" - ")?;
... | 1 | 2 | 2 |
6b2b769160d3edbbbc9c79a15a65d7a34409ce5d | Emilio Cobos Álvarez | 2020-02-21T00:46:53 | Bug 1616691 - Simplify math function resolution. r=heycam
So as to avoid allocating an intermediate tree in Rust to resolve
`<length-percentage>` values.
Differential Revision: https://phabricator.services.mozilla.com/D63399 | diff --git a/style/values/computed/length_percentage.rs b/style/values/computed/length_percentage.rs
index 4e2e6e569..98b46454d 100644
--- a/style/values/computed/length_percentage.rs
+++ b/style/values/computed/length_percentage.rs
@@ -656,23 +656,14 @@ impl CalcLengthPercentage {
/// Resolves the percentage.
... | 3 | 90 | 88 |
e1e3df6d709d0dbae896ef08b9450baf642d2a78 | Emilio Cobos Álvarez | 2020-02-21T00:46:50 | Bug 1616691 - Fix C++ side of <length-percentage> values. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D63398 | diff --git a/style/values/computed/length_percentage.rs b/style/values/computed/length_percentage.rs
index b70117f3b..4e2e6e569 100644
--- a/style/values/computed/length_percentage.rs
+++ b/style/values/computed/length_percentage.rs
@@ -552,6 +552,7 @@ impl<'de> Deserialize<'de> for LengthPercentage {
/// The leaves o... | 3 | 10 | 10 |
c0876909c3de4286c03de3c3c42a608f43459a9c | Emilio Cobos Álvarez | 2020-02-21T00:46:41 | Bug 1616691 - Make CalcNode the specified representation of <length> and <length-percentage> values. r=heycam
This is the meat of the patch. There are a couple improvements done in a couple
later patches which should hopefully be straight-forward.
Differential Revision: https://phabricator.services.mozilla.com/D63397 | diff --git a/style/values/animated/length.rs b/style/values/animated/length.rs
deleted file mode 100644
index 04690446e..000000000
--- a/style/values/animated/length.rs
+++ /dev/null
@@ -1,39 +0,0 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was no... | 9 | 321 | 386 |
b079405b1f7af838946337ab1715a60268eda0ee | Emilio Cobos Álvarez | 2020-02-21T00:46:33 | Bug 1616691 - Move the guts of calc nodes into a generic enum. r=heycam
We'll have different leaf nodes as we progress in the value computation stage.
Differential Revision: https://phabricator.services.mozilla.com/D63396 | diff --git a/style/values/generics/calc.rs b/style/values/generics/calc.rs
new file mode 100644
index 000000000..3a973f99f
--- /dev/null
+++ b/style/values/generics/calc.rs
@@ -0,0 +1,408 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distrib... | 3 | 488 | 365 |
a9facbe3bde9e96c4b3fd81df2cedc3e5892c9a8 | Emilio Cobos Álvarez | 2020-02-21T00:46:26 | Bug 1616691 - Implement ToCss for CalcNode. r=heycam
We'll use `CalcNode` as the specified value representation for <length> and
<length-percentage> values, so they'll have to implement ToCss.
There's one minor issue (two calls to to_css() instead of to_css_impl() which
are addressed later in the series).
Differenti... | diff --git a/style/values/specified/calc.rs b/style/values/specified/calc.rs
index 9736491ad..f20230b2f 100644
--- a/style/values/specified/calc.rs
+++ b/style/values/specified/calc.rs
@@ -287,6 +287,19 @@ impl PartialOrd for CalcNode {
}
impl CalcNode {
+ fn is_simple_negative(&self) -> bool {
+ match *s... | 3 | 144 | 5 |
b838584b5e847de54fec0a648ee373cfd7c377ed | Emilio Cobos Álvarez | 2020-02-20T08:43:08 | Bug 1607553 - Remove an invalid assert. r=heycam
This assert was wrong. The assert may fire if we resurrect the node from a
different thread and insert a kid fast enough.
We allow resurrecting nodes (bumping the nodes from zero to one) to avoid
allocation churn.
In particular, while the thread dropping the node gets... | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index 113fa9cb9..ddac85a80 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -136,29 +136,6 @@ impl StyleSource {
let _ = write!(writer, " -> {:?}", self.read(guard).declarations());
}
- // This is totally unsafe, should ... | 1 | 0 | 64 |
711767e89b735ae9cdf893fbf26a10c2806730e5 | Jonathan Kew | 2020-02-19T20:04:36 | Bug 1611965 - Add support for the 'all' value of text-decoration-skip-ink. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D61184 | diff --git a/style/values/specified/text.rs b/style/values/specified/text.rs
index 438b92680..0508a1bf7 100644
--- a/style/values/specified/text.rs
+++ b/style/values/specified/text.rs
@@ -1004,7 +1004,7 @@ pub enum OverflowWrap {
Anywhere,
}
-/// Implements text-decoration-skip-ink which takes the keywords aut... | 1 | 2 | 1 |
5d929bfb2324fd67a693864dd40208d763325f09 | Tim Nguyen | 2020-02-19T17:43:04 | Bug 1614202 - Implement parsing for CSS conic-gradient syntax. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D62148 | diff --git a/style/values/computed/image.rs b/style/values/computed/image.rs
index dc4bbe464..4e16c2311 100644
--- a/style/values/computed/image.rs
+++ b/style/values/computed/image.rs
@@ -13,7 +13,7 @@ use crate::values::computed::url::ComputedImageUrl;
use crate::values::computed::NumberOrPercentage;
use crate::val... | 3 | 114 | 31 |
51d859da0dd5be81a8aa5057150afb52b1ac9648 | Emilio Cobos Álvarez | 2020-02-19T14:48:43 | Bug 1615056 - Remove layout.css.webkit-appearance.enabled. r=jwatt
I don't think we want to keep the ugly widget hacks forever. Let me know if
you'd rather keep the property behind a pref but I don't think there's a point
in doing that.
Differential Revision: https://phabricator.services.mozilla.com/D62649 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 10fcb5128..9ef03273f 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -635,7 +635,7 @@ ${helpers.predefined_type(
"Appearance",
"computed::Appearance::None",
... | 1 | 1 | 1 |
522f6cbe97384112774b9383366f2ec762ce9e47 | Ciure Andrei | 2020-02-19T15:21:54 | Backed out changeset 912204a32651 (bug 1614202) for causing xpcshell and mochitests failures CLOSED TREE | diff --git a/style/values/computed/image.rs b/style/values/computed/image.rs
index 4e16c2311..dc4bbe464 100644
--- a/style/values/computed/image.rs
+++ b/style/values/computed/image.rs
@@ -13,7 +13,7 @@ use crate::values::computed::url::ComputedImageUrl;
use crate::values::computed::NumberOrPercentage;
use crate::val... | 3 | 31 | 109 |
52f973862f88ecfc975122d1c91453011c40b72d | Bogdan Tara | 2020-02-19T14:10:56 | Backed out changeset 222723ab0b5b (bug 1615056) for bustages complaining about nsNativeThemeWin.cpp CLOSED TREE | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 9ef03273f..10fcb5128 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -635,7 +635,7 @@ ${helpers.predefined_type(
"Appearance",
"computed::Appearance::None",
... | 1 | 1 | 1 |
69669cc3c81f208cae97373d7ce08b17affed6f9 | Tim Nguyen | 2020-02-19T13:55:36 | Bug 1614202 - Implement parsing for CSS conic-gradient syntax. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D62148 | diff --git a/style/values/computed/image.rs b/style/values/computed/image.rs
index dc4bbe464..4e16c2311 100644
--- a/style/values/computed/image.rs
+++ b/style/values/computed/image.rs
@@ -13,7 +13,7 @@ use crate::values::computed::url::ComputedImageUrl;
use crate::values::computed::NumberOrPercentage;
use crate::val... | 3 | 109 | 31 |
dc5584171bc549b3188058ce2248a77dc7fd6c02 | Cameron McCormack | 2020-02-14T11:11:27 | Bug 1607667 - Change initial value of image-orientation to from-image. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D62826 | diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs
index e8f3a0a45..d2b66dc6a 100644
--- a/style/properties/longhands/inherited_box.mako.rs
+++ b/style/properties/longhands/inherited_box.mako.rs
@@ -85,7 +85,7 @@ ${helpers.single_keyword(
${helpers.single... | 1 | 1 | 1 |
217c6de1f7a8c58cb21db43c16614bad6d931ab4 | Emilio Cobos Álvarez | 2020-02-16T11:00:45 | Bug 1615876 - Minor gradient parsing cleanup. r=ntim
I suggested the compat_mode bit in D62923 but it was somehow only applied to one
of the branches.
Also rustfmt the code for consistency, and add a local alias.
Differential Revision: https://phabricator.services.mozilla.com/D63015 | diff --git a/style/values/specified/image.rs b/style/values/specified/image.rs
index fdc3a795d..fcd6210c6 100644
--- a/style/values/specified/image.rs
+++ b/style/values/specified/image.rs
@@ -47,6 +47,8 @@ pub type Gradient = generic::Gradient<
Color,
>;
+type LengthPercentageItemList = crate::OwnedSlice<gener... | 1 | 20 | 20 |
6627623e8d2fcdcf859276ffd8534994df85dbd0 | Tim Nguyen | 2020-02-15T22:04:35 | Bug 1615489 - Refactor GenericGradient for conic-gradient support. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D62923 | diff --git a/style/values/generics/image.rs b/style/values/generics/image.rs
index f6206a9fb..56e3d183d 100644
--- a/style/values/generics/image.rs
+++ b/style/values/generics/image.rs
@@ -51,7 +51,7 @@ pub use self::GenericImage as Image;
/// <https://drafts.csswg.org/css-images/#gradients>
#[derive(Clone, Debug, Ma... | 4 | 120 | 105 |
cfcc4e0146bf25ca2888ce8f09a5880605dd7f0b | Arthur Iakab | 2020-02-15T19:50:33 | Backed out changeset 0721d0777474 (bug 1615489) for multiple build bustages.
DONTBUILD
CLOSED TREE | diff --git a/style/values/generics/image.rs b/style/values/generics/image.rs
index 56e3d183d..f6206a9fb 100644
--- a/style/values/generics/image.rs
+++ b/style/values/generics/image.rs
@@ -51,7 +51,7 @@ pub use self::GenericImage as Image;
/// <https://drafts.csswg.org/css-images/#gradients>
#[derive(Clone, Debug, Ma... | 4 | 105 | 120 |
910279c494b7f3594eef07404b8bab1f88fa3bdb | shindli | 2020-02-15T13:41:45 | Backed out changeset 07fc980b7ed8 (bug 1615489) for causing linux build bustages | diff --git a/style/values/generics/image.rs b/style/values/generics/image.rs
index 56e3d183d..f6206a9fb 100644
--- a/style/values/generics/image.rs
+++ b/style/values/generics/image.rs
@@ -51,7 +51,7 @@ pub use self::GenericImage as Image;
/// <https://drafts.csswg.org/css-images/#gradients>
#[derive(Clone, Debug, Ma... | 4 | 109 | 124 |
1a1d150714e0622c8dec3906df6edd2eeae79f42 | Tim Nguyen | 2020-02-15T13:16:36 | Bug 1615489 - Refactor GenericGradient for conic-gradient support. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D62923 | diff --git a/style/values/generics/image.rs b/style/values/generics/image.rs
index f6206a9fb..56e3d183d 100644
--- a/style/values/generics/image.rs
+++ b/style/values/generics/image.rs
@@ -51,7 +51,7 @@ pub use self::GenericImage as Image;
/// <https://drafts.csswg.org/css-images/#gradients>
#[derive(Clone, Debug, Ma... | 4 | 124 | 109 |
871751ba66ad2b6231f26e48114cdee40526a65d | Tim Nguyen | 2020-02-14T16:32:38 | Bug 1610597 - Re-introduce display: -moz-stack; as <legacy-stack>. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D62758 | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index fa5d5a2d4..dbdaf2048 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -104,6 +104,8 @@ pub enum DisplayInside {
#[cfg(feature = "gecko")]
MozGridLine,
#[cfg(feature = "gecko")]
+ MozStack,... | 1 | 6 | 0 |
aab631815c4bdf24f1a675edbe55f974e7fe5673 | Martin McNickle | 2020-02-14T15:48:10 | Bug 1615380 - Part 2 - Use the cbindgen output for GridAutoFlow directly in gecko. r=emilio
Depends on D62787
Differential Revision: https://phabricator.services.mozilla.com/D62910 | diff --git a/style/values/specified/position.rs b/style/values/specified/position.rs
index ff8cfade9..a3463315e 100644
--- a/style/values/specified/position.rs
+++ b/style/values/specified/position.rs
@@ -7,7 +7,6 @@
//!
//! [position]: https://drafts.csswg.org/css-backgrounds-3/#position
-use crate::gecko_bindings... | 1 | 4 | 18 |
7cfb2754e68c9d353fc05a1c3e0119bbb29112ab | Martin McNickle | 2020-02-14T15:48:01 | Bug 1615380 - Part 1 - Replace existing GridAutoFlow struct with a `bitflags!` backed one. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D62787 | diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs
index 5e3cbf132..5a150dc31 100644
--- a/style/properties/longhands/position.mako.rs
+++ b/style/properties/longhands/position.mako.rs
@@ -377,7 +377,7 @@ ${helpers.predefined_type(
${helpers.predefined_type(
"gr... | 3 | 75 | 112 |
753314c3180632bb233bc9b20cdb889a907b76a6 | Tim Nguyen | 2020-02-12T18:22:51 | Bug 1614648 - Make GradientItem and ColorStop support angular color stops. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D62544 | diff --git a/style/values/computed/image.rs b/style/values/computed/image.rs
index 8610888be..dc4bbe464 100644
--- a/style/values/computed/image.rs
+++ b/style/values/computed/image.rs
@@ -54,12 +54,6 @@ pub enum LineDirection {
Corner(HorizontalPositionKeyword, VerticalPositionKeyword),
}
-/// A computed gradi... | 6 | 26 | 32 |
435dba8a5a1b39425070df5d1ca3ee61abc4519c | Dorel Luca | 2020-02-12T12:33:04 | Backed out changeset 7e16a18f0f94 (bug 1614648) for build bustages in layout/painting/nsCSSRenderingGradients. CLOSED TREE | diff --git a/style/values/computed/image.rs b/style/values/computed/image.rs
index dc4bbe464..8610888be 100644
--- a/style/values/computed/image.rs
+++ b/style/values/computed/image.rs
@@ -54,6 +54,12 @@ pub enum LineDirection {
Corner(HorizontalPositionKeyword, VerticalPositionKeyword),
}
+/// A computed gradi... | 6 | 32 | 26 |
505f4d0a92b3e49f83acb1480037457a4e7465d4 | Emilio Cobos Álvarez | 2020-02-12T11:32:47 | Bug 1614348 - Make font-family serialization algorithm a bit more conservative. r=xidorn
So as to avoid serializing as identifiers font-families with spaces as part of
the identifier. This avoids serializing confusing escaped sequences if the
beginning of the stuff after the space happens to not be a valid ident start... | diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs
index 059885b13..bd7de2359 100644
--- a/style/values/computed/font.rs
+++ b/style/values/computed/font.rs
@@ -353,19 +353,22 @@ impl SingleFontFamily {
};
let mut value = first_ident.as_ref().to_owned();
+ let mut seri... | 1 | 4 | 1 |
1943968bb7b79c8e418a2369f3033552a03f9f95 | Boris Chiou | 2020-02-11T01:12:00 | Bug 1614407 - Drop fallback attribute from animate and distance. r=emilio
Still keep the discriminant checks to avoid generating terrible code.
Differential Revision: https://phabricator.services.mozilla.com/D62329 | diff --git a/style/values/animated/mod.rs b/style/values/animated/mod.rs
index 7e699542f..46a134108 100644
--- a/style/values/animated/mod.rs
+++ b/style/values/animated/mod.rs
@@ -109,9 +109,6 @@ pub fn animate_multiplicative_factor(
/// If a variant is annotated with `#[animation(error)]`, the corresponding
/// `ma... | 4 | 4 | 34 |
25b735d7ec63cb6cf009aba42a77efb29a4571c6 | Emilio Cobos Álvarez | 2020-02-11T23:34:53 | Bug 1614510 - Split clip-path and shape-outside values. r=boris
We don't actually share _that_ much code across them. This makes callers clearer
and code less confusing, IMHO.
This also has the benefit of not autocompleting path from devtools for
shape-outside.
Differential Revision: https://phabricator.services.moz... | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 90c8dc539..10fcb5128 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -681,10 +681,10 @@ ${helpers.predefined_type(
${helpers.predefined_type(
"shape-outside",
- ... | 6 | 131 | 105 |
0e10398807de8db74ad8f80f5ad9a58d8d696d92 | Emilio Cobos Álvarez | 2020-02-11T22:03:53 | Bug 1614510 - Use cbindgen for shape-outside and clip-path. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D62372 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 3a061c97c..8fbe3f475 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -15,159 +15,6 @@ use crate::stylesheets::RulesMutateError;
use crate::values::computed::transform::Matrix3D;
use crate::values::computed::TextAlig... | 2 | 1 | 234 |
7b381976229b8346497a5bab42422a610ba2aa0e | Emilio Cobos Álvarez | 2020-02-11T20:56:20 | Bug 1614198 - Use cbindgen instead of nsStyleImage. r=aosmond
The trickier part is that we represent -moz-image-rect as a Rect() type instead
of image with non-null clip-rect. So we need to add a bit of code to
distinguish "image request types" from other types of images.
But it's not too annoying, and we need to do ... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 52007c556..3a061c97c 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -10,87 +10,10 @@
#![allow(unsafe_code)]
-use crate::gecko_bindings::bindings;
-use crate::gecko_bindings::structs::{self, Matrix4x4Components};... | 2 | 15 | 119 |
883a4e28ae0460ce1d393a4423841992ba956d08 | Emilio Cobos Álvarez | 2020-02-11T20:56:13 | Bug 1614198 - Some preparation to start using cbindgen for shape-outside and clip-path. r=boris
Tweak the ShapeSourceRepresentation so that it doesn't store Option<>s.
Some renames so that GeometryBox doesn't conflict with the Gecko type, and some
other usual bits / re-exports to deal with cbindgen and generics.
Als... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 5390d904d..52007c556 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -99,7 +99,7 @@ pub mod basic_shape {
};
use crate::values::computed::basic_shape::{BasicShape, ClippingShape, FloatAreaShape};
use cr... | 5 | 76 | 68 |
858f3f1cdaaa078d452a2b4739d99818de216122 | Emilio Cobos Álvarez | 2020-02-11T01:23:37 | Bug 1614208 - Remove some include dependencies in nsStyleConsts.h. r=jfkthame,jgilbert
We include it everywhere because it's included from gfxTypes.h.
This should avoid including all the generated bindings _everywhere_.
Differential Revision: https://phabricator.services.mozilla.com/D62174 | diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs
index 658d34124..059885b13 100644
--- a/style/values/computed/font.rs
+++ b/style/values/computed/font.rs
@@ -309,8 +309,10 @@ pub enum SingleFontFamily {
#[allow(missing_docs)]
pub enum GenericFontFamily {
/// No generic family specified... | 1 | 3 | 1 |
a7355649fb937da980dd474c1b95beed425a00e7 | Emilio Cobos Álvarez | 2020-02-10T20:16:13 | Bug 1614198 - Remove trait bound and comment that snuck from a previous patch accidentally in a CLOSED TREE
MANUAL PUSH: Fixing accidental Lando-relanding of previous version of the patch. | diff --git a/style/values/specified/basic_shape.rs b/style/values/specified/basic_shape.rs
index 421cb130b..68938b4e6 100644
--- a/style/values/specified/basic_shape.rs
+++ b/style/values/specified/basic_shape.rs
@@ -71,8 +71,6 @@ impl Parse for ClippingShape {
context: &ParserContext,
input: &mut Par... | 1 | 1 | 3 |
ea0b2ac590759947c18bad8c78c686f4abc8498a | Emilio Cobos Álvarez | 2020-02-10T20:02:31 | Bug 1614198 - Merge ImageLayer and Image. r=heycam
ImageLayer is almost the only usage of Image, so keeping them in the same enum
makes the resulting C++ struct smaller, and makes it map more cleanly to
nsStyleImage.
Differential Revision: https://phabricator.services.mozilla.com/D62161 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 3deaeacad..5390d904d 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -23,6 +23,9 @@ impl nsStyleImage {
/// Set a given Servo `Image` value into this `nsStyleImage`.
pub fn set(&mut self, image: Image) {
... | 12 | 65 | 113 |
30d4d40af43cdbe14bb1768ab4749507318d4afc | Mihai Alexandru Michis | 2020-02-10T19:48:26 | Backed out changeset a3695dec8b66 (bug 1614198) for causing bustages in ImageLayer
CLOSED TREE | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 5390d904d..3deaeacad 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -23,9 +23,6 @@ impl nsStyleImage {
/// Set a given Servo `Image` value into this `nsStyleImage`.
pub fn set(&mut self, image: Image) {
... | 12 | 112 | 62 |
6847481d98586f96876300fe37c046a7cb2f31b4 | Emilio Cobos Álvarez | 2020-02-10T19:25:40 | Bug 1614198 - Merge ImageLayer and Image. r=heycam
ImageLayer is almost the only usage of Image, so keeping them in the same enum
makes the resulting C++ struct smaller, and makes it map more cleanly to
nsStyleImage.
Differential Revision: https://phabricator.services.mozilla.com/D62161 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 3deaeacad..5390d904d 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -23,6 +23,9 @@ impl nsStyleImage {
/// Set a given Servo `Image` value into this `nsStyleImage`.
pub fn set(&mut self, image: Image) {
... | 12 | 62 | 112 |
6439726f360be0f0d88e6e74452044c260db59c2 | Emilio Cobos Álvarez | 2020-02-10T18:18:27 | Bug 1614394 - Cherry-pick some more formatting changes.
Differential Revision: https://phabricator.services.mozilla.com/D62317 | diff --git a/style/values/computed/length_percentage.rs b/style/values/computed/length_percentage.rs
index b24933cc5..96bf76c98 100644
--- a/style/values/computed/length_percentage.rs
+++ b/style/values/computed/length_percentage.rs
@@ -65,10 +65,6 @@ pub struct CalcVariant {
ptr: *mut CalcLengthPercentage,
}
-... | 1 | 8 | 6 |
d0665a8b3f1a9f2c4bb48c423287e478fe113587 | Emilio Cobos Álvarez | 2020-02-10T17:32:37 | Bug 1614394 - Cherry-pick a selectors version bump.
Differential Revision: https://phabricator.services.mozilla.com/D62309 | diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml
index 8bf0ba716..21077f426 100644
--- a/selectors/Cargo.toml
+++ b/selectors/Cargo.toml
@@ -1,7 +1,7 @@
[package]
name = "selectors"
-version = "0.21.0"
+version = "0.22.0"
authors = ["The Servo Project Developers"]
documentation = "https://docs.rs/selector... | 1 | 1 | 1 |
5521f759b6b3ad7a34c346c230962d4cb8f028bb | Emilio Cobos Álvarez | 2020-02-10T17:32:35 | Bug 1614394 - Remove now unused dependency from the style system.
Differential Revision: https://phabricator.services.mozilla.com/D62308 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 9ff848af0..f2ff6c915 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -55,7 +55,6 @@ num_cpus = {version = "1.1.0"}
num-integer = "0.1"
num-traits = "0.2"
num-derive = "0.3"
-ordered-float = "1.0"
owning_ref = "0.4"
parking_lot = "0.9"
precomputed-hash... | 2 | 0 | 2 |
853d4ba1257d41b9896a9b7a93ba9b1a9015093f | Emilio Cobos Álvarez | 2020-02-10T17:32:27 | Bug 1614394 - Rustfmt recent changes.
Differential Revision: https://phabricator.services.mozilla.com/D62307 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index b7ef6cf21..76a72276a 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -12,7 +12,9 @@ use crate::properties::{CSSWideKeyword, CustomDeclaration, CustomDeclarationValu
use crate::selector_map::{PrecomputedHashMap, Preco... | 22 | 210 | 163 |
801c8dc3f5a1950ffed248a4336682418593b24c | Emilio Cobos Álvarez | 2020-02-10T17:32:25 | Bug 1614394 - Fix Servo build.
Differential Revision: https://phabricator.services.mozilla.com/D62306 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index ff5d5b5bf..d3e618675 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -2895,9 +2895,18 @@ pub struct ComputedValues {
/// We maintain this distinction in servo to reduce the amo... | 8 | 102 | 8 |
98abf2451ba99b9316bb68493c30fe1e065bd282 | Emilio Cobos Álvarez | 2020-02-10T17:32:18 | Bug 1614394 - Cherry-pick some servo-2020 changes to the style system.
Differential Revision: https://phabricator.services.mozilla.com/D62305 | diff --git a/style/properties/longhands/background.mako.rs b/style/properties/longhands/background.mako.rs
index 5cd0084b3..e0ef021f3 100644
--- a/style/properties/longhands/background.mako.rs
+++ b/style/properties/longhands/background.mako.rs
@@ -23,7 +23,6 @@ ${helpers.predefined_type(
"background-image",
... | 6 | 12 | 37 |
e0a90f165a72d4eef193e3963d22cee3ffd78ba3 | Patrick Shaughnessy | 2020-02-10T17:32:15 | Bug 1614394 - Cherry-pick Servo changes for :defined support.
Differential Revision: https://phabricator.services.mozilla.com/D62304 | diff --git a/style/servo/selector_parser.rs b/style/servo/selector_parser.rs
index 942dcdba1..599b603f4 100644
--- a/style/servo/selector_parser.rs
+++ b/style/servo/selector_parser.rs
@@ -278,6 +278,7 @@ pub enum NonTSPseudoClass {
Active,
AnyLink,
Checked,
+ Defined,
Disabled,
Enabled,
... | 1 | 4 | 0 |
f8065c4bd34ae07f85c0dd0d0d1a86061f9059d9 | Emilio Cobos Álvarez | 2020-02-10T17:32:13 | Bug 1614394 - Implement num_traits::Zero for CSSPixelLength.
Differential Revision: https://phabricator.services.mozilla.com/D62303 | diff --git a/style/values/computed/length.rs b/style/values/computed/length.rs
index 78c812996..0c59b6405 100644
--- a/style/values/computed/length.rs
+++ b/style/values/computed/length.rs
@@ -272,7 +272,7 @@ impl CSSPixelLength {
}
}
-impl Zero for CSSPixelLength {
+impl num_traits::Zero for CSSPixelLength {
... | 1 | 1 | 1 |
88fb51545e576d91177447670d82bfb461678214 | Simon Sapin | 2020-02-10T17:32:11 | Bug 1614394 - Move `OpaqueNode` to `style_traits`.
Differential Revision: https://phabricator.services.mozilla.com/D62302 | diff --git a/style/dom.rs b/style/dom.rs
index 74067e225..7629bb11e 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -32,26 +32,7 @@ use std::fmt::Debug;
use std::hash::Hash;
use std::ops::Deref;
-/// An opaque handle to a node, which, unlike UnsafeNode, cannot be transformed
-/// back into a non-opaque representati... | 3 | 28 | 20 |
52171c6b6973d58e0cbe669fddc46e2818521142 | Emilio Cobos Álvarez | 2020-02-10T17:32:09 | Bug 1614394 - Cherry-pick some servo-only changes to malloc_size_of.
Differential Revision: https://phabricator.services.mozilla.com/D62301 | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index eebe330c8..c33175ad0 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -22,9 +22,12 @@ servo = [
"webrender_api",
"xml5ever",
"content-security-policy",
+ "uuid",
+ "accountable-refcell",
]
[depende... | 2 | 20 | 0 |
267af6059296259d24128a2b74e63f00e2e30b05 | Simon Sapin | 2020-02-10T17:32:07 | Bug 1614394 - Parse `-moz-image-rect()` and `-moz-element()` only in Gecko.
Differential Revision: https://phabricator.services.mozilla.com/D62300 | diff --git a/style/traversal.rs b/style/traversal.rs
index ab2209e49..254d40f03 100644
--- a/style/traversal.rs
+++ b/style/traversal.rs
@@ -679,7 +679,7 @@ where
element.finish_restyle(context, data, new_styles, important_rules_changed)
}
-#[cfg(feature = "servo")]
+#[cfg(feature = "servo-layout-2013")]
fn no... | 4 | 56 | 12 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.