commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
2736f93bce09ee7c126697d26df1eca9ea119ddf | Emilio Cobos Álvarez | 2020-02-10T17:12:44 | Bug 1612301 - Fix LengthPercentage on big-endian machines. r=jfkthame
Always store the pointer in little-endian order so that the tag trick works.
Differential Revision: https://phabricator.services.mozilla.com/D61386 | diff --git a/style/values/computed/length_percentage.rs b/style/values/computed/length_percentage.rs
index f6537c3ec..218e45694 100644
--- a/style/values/computed/length_percentage.rs
+++ b/style/values/computed/length_percentage.rs
@@ -42,7 +42,7 @@ use style_traits::{CssWriter, ToCss};
#[derive(Copy, Clone)]
#[repr... | 1 | 38 | 19 |
6ccec9f9cfe7fccedd6ca23c7c64b173a5bd9c73 | Emilio Cobos Álvarez | 2020-02-10T14:09:38 | Bug 1613491 - Make rust generate better code for some of the functions introduced here. r=heycam
See https://github.com/rust-lang/rust/issues/68867.
Differential Revision: https://phabricator.services.mozilla.com/D61760 | diff --git a/style/values/specified/length.rs b/style/values/specified/length.rs
index 3580d1105..3b971b422 100644
--- a/style/values/specified/length.rs
+++ b/style/values/specified/length.rs
@@ -98,12 +98,22 @@ impl FontRelativeLength {
fn try_sum(&self, other: &Self) -> Result<Self, ()> {
use self::F... | 1 | 65 | 19 |
39d3bd702256574bb815d54653f46ade029aafec | Emilio Cobos Álvarez | 2020-02-10T14:09:27 | Bug 1613491 - Add some calc infrastructure to deal with simplification / sorting / etc. r=heycam
For now, we still bail out at the stage of getting the calc node into a
CalcLengthPercentage if we couldn't simplify the min() / max() / clamps()
involved.
After this plan is to use just CalcNode everywhere instead of
spe... | diff --git a/style/values/specified/calc.rs b/style/values/specified/calc.rs
index 6120c809b..18c2af379 100644
--- a/style/values/specified/calc.rs
+++ b/style/values/specified/calc.rs
@@ -10,11 +10,12 @@ use crate::parser::ParserContext;
use crate::values::computed;
use crate::values::specified::length::ViewportPerc... | 2 | 366 | 10 |
01028425e5ce39319724ecd2a178f127ebfd2070 | Emilio Cobos Álvarez | 2020-02-10T13:51:49 | Bug 1613517 - Make rust generate better code for derive(Animate) and derive(ComputeSquaredDistance). r=heycam
See https://github.com/rust-lang/rust/issues/68867.
This technically changes the semantics of #[animate(fallback)] and such when
combined with #[animate(error)]. But no such combination exists and the new
sem... | diff --git a/style/values/animated/mod.rs b/style/values/animated/mod.rs
index 7cac407ad..7e699542f 100644
--- a/style/values/animated/mod.rs
+++ b/style/values/animated/mod.rs
@@ -107,7 +107,7 @@ pub fn animate_multiplicative_factor(
/// be equal or an error is returned.
///
/// If a variant is annotated with `#[an... | 4 | 105 | 89 |
19fc60d3e829cf2ac08cd54ff64652e46df6a723 | Emilio Cobos Álvarez | 2020-02-10T00:37:36 | Bug 1612291 - Fix two issues with themed widgets in high contrast mode. r=heycam
There were two issues with the existing code that we use to determine whether a
widget is styled or not.
First, it was using `color == Color::transparent()` instead of
`color.is_transparent()` to check for transparent backgrounds. That i... | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index 1dbc17eaf..8a36e2f20 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -1458,7 +1458,6 @@ impl StrongRuleNode {
use crate::gecko_bindings::structs::NS_AUTHOR_SPECIFIED_PADDING;
use crate::properties::{CSSWideKeyword, ... | 1 | 4 | 5 |
b85ac49969eee7a8f7293171bbb0b3107665d875 | Tim Nguyen | 2020-02-09T15:11:43 | Bug 1614160 - Add AngleOrPercentage to style system. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D62158 | diff --git a/style/values/computed/mod.rs b/style/values/computed/mod.rs
index da5c84aed..aaa267777 100644
--- a/style/values/computed/mod.rs
+++ b/style/values/computed/mod.rs
@@ -465,6 +465,54 @@ trivial_to_computed_value!(String);
trivial_to_computed_value!(Box<str>);
trivial_to_computed_value!(crate::OwnedStr);
... | 3 | 93 | 3 |
2806f346a60c1a0eb9eaf38b9b2c29fe454f6810 | Emilio Cobos Álvarez | 2020-02-07T20:36:34 | Bug 1606628 - Remove nsStyleImageRequest. r=tnikkel,heycam
This removes nsStyleImageRequest by moving the load state to LoadData instead
(where other lazy state like the resolved URL and load id lives).
That way we can use cbindgen for more stuff (there's no blocker for using it for
all images now), and we can undo t... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 9bc9573bf..3deaeacad 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -15,7 +15,6 @@ use crate::gecko_bindings::structs::{self, Matrix4x4Components};
use crate::gecko_bindings::structs::{nsStyleImage, nsresult};
use ... | 3 | 38 | 82 |
b6beb37874578e933414d8c8d7760c50d6116f30 | Thomas Dolezal | 2020-02-07T12:35:30 | Bug 1611733 - Bug 1611633 - convert ns style position defines to enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D61958 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 70bfdc756..a3fabb7db 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -47,6 +47,7 @@ ${helpers.single_keyword(
values="static absolute relative fixed ${'sticky' if e... | 1 | 1 | 0 |
8aa27506d87f5a70e4af25efe40b9cbaf33a4580 | Emilio Cobos Álvarez | 2020-02-07T00:40:55 | Bug 1613010 - Don't use a binary tree representation for calc() sums / products. r=heycam
Keep a flat list of sum members. Simpify product and division ASAP.
I want to preserve the tree for a bit longer to implement min / max / clamp.
This doesn't do anything for it that we weren't doing already, but it helps to
even... | diff --git a/style/values/specified/calc.rs b/style/values/specified/calc.rs
index 4fb3c009e..6120c809b 100644
--- a/style/values/specified/calc.rs
+++ b/style/values/specified/calc.rs
@@ -13,6 +13,7 @@ use crate::values::specified::length::{AbsoluteLength, FontRelativeLength, NoCal
use crate::values::specified::{Angl... | 1 | 130 | 88 |
856deacf1df756b2effde7a38222a7836a40b10d | Mihai Alexandru Michis | 2020-02-06T21:19:55 | Backed out changeset c9f4dd3ed78b (bug 1606628) for causing failures in ImageLoader.cpp
CLOSED TREE | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 3deaeacad..9bc9573bf 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -15,6 +15,7 @@ use crate::gecko_bindings::structs::{self, Matrix4x4Components};
use crate::gecko_bindings::structs::{nsStyleImage, nsresult};
use ... | 3 | 82 | 38 |
2da3f9042fa64076ec864266845492554cdb792f | Emilio Cobos Álvarez | 2020-01-22T00:06:35 | Bug 1607553 - Try to collect some more crash information so that we can diagnose this better. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D59704 | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index fa859d79f..1dbc17eaf 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -136,6 +136,27 @@ impl StyleSource {
let _ = write!(writer, " -> {:?}", self.read(guard).declarations());
}
+ // This is totally unsafe, should ... | 1 | 38 | 1 |
1c5aa2c0e9b704681c4a63e223616863c88eb80d | Jonathan Kew | 2020-02-03T14:38:28 | Bug 1607308 - Move the from-font value from text-underline-offset to text-underline-position, as per recent spec changes, and fix interaction between position and offset. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D59778 | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index 9784e2529..f01bedb17 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -382,8 +382,8 @@ ${helpers.single_keyword(
// text unde... | 4 | 22 | 14 |
88f556d1958f07821032056c07fd29a4008786b5 | Jonathan Kew | 2020-02-03T14:21:32 | Bug 1607534 - Support percentage values for the CSS text-decoration-thickness and text-underline-offset properties. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D59777 | diff --git a/style/values/computed/text.rs b/style/values/computed/text.rs
index 3f9ffb2ad..57a142860 100644
--- a/style/values/computed/text.rs
+++ b/style/values/computed/text.rs
@@ -28,7 +28,7 @@ pub use crate::values::specified::{TextDecorationSkipInk, TextTransform};
pub type InitialLetter = GenericInitialLetter<... | 3 | 4 | 4 |
b03323b840fcfae9f5001391e091f5549e32e0cd | Ciure Andrei | 2020-02-03T14:17:02 | Backed out 2 changesets (bug 1607308, bug 1607534) for causing text-decoration-underline-position-vertical-ja.html to permafail CLOSED TREE
Backed out changeset e55052ed4064 (bug 1607308)
Backed out changeset 280bd106d48a (bug 1607534) | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index f01bedb17..9784e2529 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -382,8 +382,8 @@ ${helpers.single_keyword(
// text unde... | 4 | 17 | 25 |
2c917a6d8c8f694441d6c9f03d129c22252f9a00 | Tim Nguyen | 2020-02-03T09:55:51 | Bug 1610404 - Remove nsGroupBoxFrame (display: -moz-groupbox). r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D61422 | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 2f114b5bb..11fbe6afb 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -106,8 +106,6 @@ pub enum DisplayInside {
#[cfg(feature = "gecko")]
MozDeck,
#[cfg(feature = "gecko")]
- MozGroupbox,
... | 1 | 0 | 6 |
c6a2d23e1cde6e09fa84a3a9695921545306460f | Thomas Dolezal | 2020-02-01T21:43:31 | Bug 1612146 - Converting empty-cells defines into enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D61398 | diff --git a/style/properties/longhands/inherited_table.mako.rs b/style/properties/longhands/inherited_table.mako.rs
index 06b42e802..488fe5d26 100644
--- a/style/properties/longhands/inherited_table.mako.rs
+++ b/style/properties/longhands/inherited_table.mako.rs
@@ -20,7 +20,7 @@ ${helpers.single_keyword(
"empty... | 1 | 1 | 1 |
ad79452aab32cd8d1743288cec88ef96430a7ce5 | Thomas Dolezal | 2020-02-01T20:23:26 | Bug 1612148 - Replace transform style defines to an enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D61388 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 84dc84369..ba9c49758 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -53,7 +53,6 @@ use crate::values::computed::BorderStyle;
use crate::values::computed::font::FontSize;
use crate::values::generics:... | 3 | 3 | 24 |
7ec34e072b0583f989cf4f8fc276780b3daee4d8 | Narcis Beleuzu | 2020-02-01T17:23:06 | Backed out 2 changesets (bug 1612148) for reftest failures. CLOSED TREE
Backed out changeset e1432ef26779 (bug 1612148)
Backed out changeset 0c1831f15450 (bug 1612148) | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index ba9c49758..84dc84369 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -53,6 +53,7 @@ use crate::values::computed::BorderStyle;
use crate::values::computed::font::FontSize;
use crate::values::generics:... | 2 | 21 | 2 |
4ea218c2706ce53375b80667d6403e21a574001d | Emilio Cobos Álvarez | 2020-02-01T16:08:09 | Bug 1612148 - followup: Remove unused include.
MANUAL PUSH: Patch from contributor was missing this, causing bustage.
CLOSED TREE | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index e507c9f28..ba9c49758 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -53,7 +53,6 @@ use crate::values::computed::BorderStyle;
use crate::values::computed::font::FontSize;
use crate::values::generics:... | 1 | 0 | 1 |
741962951acf4bd01efe0dd9203601be45aaf5a9 | Thomas Dolezal | 2020-02-01T15:50:04 | Bug 1612148 - Replace transform style defines to an enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D61388 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 84dc84369..e507c9f28 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1473,7 +1473,7 @@ fn static_assert() {
animation-iteration-count animation-timing-function
... | 2 | 2 | 20 |
f52a9c3ff898347bc9d6922b4170f3a6c0a97298 | Emilio Cobos Álvarez | 2020-01-31T14:51:06 | Bug 1611912 - Add a style flag for the root element style. r=heycam
This is needed to make the root element not a containing block in presence of
filters or what not.
Differential Revision: https://phabricator.services.mozilla.com/D61167 | diff --git a/style/lib.rs b/style/lib.rs
index 33862461a..aa855b8b5 100644
--- a/style/lib.rs
+++ b/style/lib.rs
@@ -120,6 +120,8 @@ pub mod attr;
pub mod author_styles;
pub mod bezier;
pub mod bloom;
+#[path="properties/computed_value_flags.rs"]
+pub mod computed_value_flags;
pub mod context;
pub mod counter_styl... | 13 | 37 | 46 |
e5f5198db939c23fce6c25279711e4c623d94ccf | Jonathan Kew | 2020-01-31T10:11:19 | Bug 1612399 - Don't apply text-combine-upright in sideways-* writing modes. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D61326 | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index a66c9462c..2a897bbe1 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -281,7 +281,7 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
let writing_mode = self.style.get_inherited_box().clone_writing_mode();
let text_com... | 1 | 1 | 1 |
1fbc29a356ba500a9b67735538b0a4b0bb101ee1 | Thomas Dolezal | 2020-01-31T01:23:23 | Bug 1612143 - Replacing table-layout defines with an enum r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D61260 | diff --git a/style/properties/longhands/table.mako.rs b/style/properties/longhands/table.mako.rs
index 0564942fc..104c28b8e 100644
--- a/style/properties/longhands/table.mako.rs
+++ b/style/properties/longhands/table.mako.rs
@@ -12,6 +12,7 @@ ${helpers.single_keyword(
engines="gecko servo-2013",
gecko_ffi_nam... | 1 | 1 | 0 |
37b8a93e62ff8b77904b5e980c4d58b5ff33d903 | Emilio Cobos Álvarez | 2020-01-31T00:56:49 | Bug 1611583 - Use cbindgen for css-align types. r=dholbert
This provides stronger typing and removes a bunch of subtle constants matching.
Differential Revision: https://phabricator.services.mozilla.com/D61058 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 874bf1a83..8f384296c 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -957,48 +957,16 @@ fn static_assert() {
<% skip_position_longhands = " ".join(x.ident for x in SIDES) %>
<%self:impl_trait style... | 3 | 39 | 100 |
43dd22a4c6d092cf21b95909ba9a3773687c3a4e | Thomas Dolezal | 2020-01-30T03:34:32 | Bug 1611041 - Convert image-rendering #defines to an enum class. r=emilio
MANUAL PUSH: Contributor didn't use Phabricator and I don't want patch to rot | diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs
index e7715431b..e8f3a0a45 100644
--- a/style/properties/longhands/inherited_box.mako.rs
+++ b/style/properties/longhands/inherited_box.mako.rs
@@ -78,6 +78,7 @@ ${helpers.single_keyword(
extra_servo_20... | 1 | 1 | 0 |
a53514bd7d1d371bd053f48f5ba4e217874c8da8 | Martin McNickle | 2020-01-28T09:12:29 | Bug 1611829 - Convert scroll-behavior #defines to an enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D61164 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 169ab57c7..521a629d9 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -453,6 +453,7 @@ ${helpers.single_keyword(
engines="gecko",
spec="https://drafts.csswg.org... | 1 | 1 | 0 |
f1f434786bd7dc18cb03bf5dc6db2f1ef57c6a65 | Martin McNickle | 2020-01-27T14:59:41 | Bug 1611043 - Convert mask-type #defines to an enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D60987 | diff --git a/style/properties/longhands/svg.mako.rs b/style/properties/longhands/svg.mako.rs
index f25cbb8e0..724c38b2d 100644
--- a/style/properties/longhands/svg.mako.rs
+++ b/style/properties/longhands/svg.mako.rs
@@ -69,6 +69,7 @@ ${helpers.single_keyword(
"mask-type",
"luminance alpha",
engines="gec... | 1 | 1 | 0 |
743fdd2c3fce6bc782ef00ba779bd3a177dd26bd | Emilio Cobos Álvarez | 2020-01-26T22:57:21 | Bug 1610085 - Tweak background-color and color handling in ignored-colors mode. r=jwatt
We're resetting `color` to the default color when there's a declaration that
applies in order to make stuff like this:
<div style="color: transparent">
<div style="color: red">
Red
</div>
</div>
To not show transparent. B... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index f9f17a571..461bc0c1f 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -333,27 +333,37 @@ where
context.builder.build()
}
-fn should_ignore_declaration_when_ignoring_document_colors(
- device: &Device,
+/... | 1 | 79 | 38 |
85ae89b37ac8eeb8c4fefe391f0e8ff3be4531bc | Csoregi Natalia | 2020-01-26T21:14:39 | Backed out changeset 239f7622187e (bug 1610085) for background color failures on test_dont_use_document_colors.html. CLOSED TREE | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 461bc0c1f..f9f17a571 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -333,37 +333,27 @@ where
context.builder.build()
}
-/// How should a declaration behave when ignoring document colors?
-enum Declaration... | 1 | 38 | 79 |
4d477c4dd6bdf7cba23041eb27a73e16fae439a8 | Sakura Mochizuki | 2020-01-25T10:51:24 | Bug 1611040 - Convert dominant-baseline #defines to an enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D61046 | diff --git a/style/properties/longhands/inherited_svg.mako.rs b/style/properties/longhands/inherited_svg.mako.rs
index 7cb4e4f1d..1839f90d6 100644
--- a/style/properties/longhands/inherited_svg.mako.rs
+++ b/style/properties/longhands/inherited_svg.mako.rs
@@ -17,6 +17,7 @@ ${helpers.single_keyword(
engines="gecko... | 1 | 1 | 0 |
f4c3f92f67e40dda580c488930a09bf6430832fc | Boris Chiou | 2020-01-24T18:59:03 | Bug 1609786 - Make the empty svg path valid. r=emilio
Per SVG2 spec, the EBNF allows the path data string to be empty.
An empty path data string disables rendering of the path.
Therefore, we should make path('') a valid path string.
The related spec issue: https://github.com/w3c/fxtf-drafts/issues/392.
Now we seriali... | diff --git a/style/values/specified/svg_path.rs b/style/values/specified/svg_path.rs
index b5461bb37..288f396b7 100644
--- a/style/values/specified/svg_path.rs
+++ b/style/values/specified/svg_path.rs
@@ -42,7 +42,6 @@ impl SVGPathData {
/// Get the array of PathCommand.
#[inline]
pub fn commands(&self) ... | 1 | 0 | 5 |
efc6bd1d17011fcb47f010589aaf3ba49b624cde | Emilio Cobos Álvarez | 2020-01-24T11:46:14 | Bug 1611181 - Make direction use an enum class. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D60857 | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 4d3895440..7a25b2569 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -563,6 +563,7 @@
Copy,
Debug,
Eq,
+ FromPrimitive,
... | 2 | 3 | 2 |
08a463728a6a64bc45d473de2729d90ee8e6c683 | Martin McNickle | 2020-01-23T17:19:27 | Bug 1611044 - Convert stroke-linejoin #defines to an enum class. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D60865 | diff --git a/style/properties/longhands/inherited_svg.mako.rs b/style/properties/longhands/inherited_svg.mako.rs
index 1d75df08b..7cb4e4f1d 100644
--- a/style/properties/longhands/inherited_svg.mako.rs
+++ b/style/properties/longhands/inherited_svg.mako.rs
@@ -118,6 +118,7 @@ ${helpers.single_keyword(
engines="gec... | 1 | 1 | 0 |
cf2e1d2f54096918a7269ceede14c50f41aaebab | Emilio Cobos Álvarez | 2020-01-23T09:18:39 | Bug 1609737 - Simplify calc expressions earlier. r=boris
This simplifies a bit the code, and guarantees that all calc()s have percentages
and lengths.
I also wanted to remove unclamped_length() / specified_percentage() (for the
same reason as the above patch), but they're needed for animations for now. When
I impleme... | diff --git a/style/values/animated/length.rs b/style/values/animated/length.rs
index 837b3ee86..097243624 100644
--- a/style/values/animated/length.rs
+++ b/style/values/animated/length.rs
@@ -7,6 +7,7 @@
use super::{Animate, Procedure};
use crate::values::computed::length::LengthPercentage;
use crate::values::compu... | 7 | 67 | 140 |
e7efb7cad29497bf14e5a460f7c25bb9550c6db5 | Emilio Cobos Álvarez | 2020-01-23T09:18:39 | Bug 1609737 - Forbid accessing the length and percentage parts of a LengthPercentage separately. r=boris
This is just not a thing you can do if you have min() / max() / etc, as the min
/ max value may depend on the percentage basis.
Differential Revision: https://phabricator.services.mozilla.com/D60168 | diff --git a/style/values/animated/transform.rs b/style/values/animated/transform.rs
index 3d93ae93f..621ae6008 100644
--- a/style/values/animated/transform.rs
+++ b/style/values/animated/transform.rs
@@ -1168,10 +1168,11 @@ impl ComputeSquaredDistance for ComputedTransformOperation {
// However, dropp... | 1 | 5 | 4 |
25318c5671c77878c5241473916f025330beb301 | Cosmin Sabou | 2020-01-23T05:39:48 | Backed out 2 changesets (bug 1609737) for causing build bustages on nsCSSRenderingGradients after backing out Bug 1609711. CLOSED TREE
Backed out changeset d12980bbc425 (bug 1609737)
Backed out changeset 51f3f1a1efb8 (bug 1609737) | diff --git a/style/values/animated/length.rs b/style/values/animated/length.rs
index 097243624..837b3ee86 100644
--- a/style/values/animated/length.rs
+++ b/style/values/animated/length.rs
@@ -7,7 +7,6 @@
use super::{Animate, Procedure};
use crate::values::computed::length::LengthPercentage;
use crate::values::compu... | 8 | 144 | 72 |
080329a94c53e04f0b5be61fb197d9060368c60a | Emilio Cobos Álvarez | 2020-01-22T23:46:24 | Bug 1610801 - Remove font-size calc() hack to propagate keyword information. r=manishearth
It does not make any sense with min() / max() / clamp. So just forget the
keyword info when calc() is used. This also removes a bit of complex / hacky
code.
Differential Revision: https://phabricator.services.mozilla.com/D60663 | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 9a1196a11..ba1c724d5 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -956,9 +956,8 @@ impl FontMetricsProvider for GeckoFontMetricsProvider {
let (wm, font) = match base_size {
FontBaseSize::CurrentStyle => (s... | 3 | 8 | 51 |
1670231b7b47280d51d6f1fdf3017e7ffde903c0 | Boris Chiou | 2020-01-22T20:18:38 | Bug 1592822 - Use Serde for OffsetRotate and PositionOrAuto. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D60088 | diff --git a/style/values/computed/motion.rs b/style/values/computed/motion.rs
index 88a5b7c72..e2565ff34 100644
--- a/style/values/computed/motion.rs
+++ b/style/values/computed/motion.rs
@@ -23,8 +23,10 @@ fn is_auto_zero_angle(auto: &bool, angle: &Angle) -> bool {
ComputeSquaredDistance,
Copy,
Debug,
... | 2 | 7 | 0 |
135087a07fe42272cc7c81efebe3776718940e30 | Boris Chiou | 2020-01-22T20:18:35 | Bug 1592822 - Use Serde for SVGOffsetPath. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D60087 | diff --git a/style/values/generics/motion.rs b/style/values/generics/motion.rs
index 685eaad43..25ba5873a 100644
--- a/style/values/generics/motion.rs
+++ b/style/values/generics/motion.rs
@@ -73,13 +73,16 @@ pub struct RayFunction<Angle> {
/// The offset-path value.
///
/// https://drafts.fxtf.org/motion-1/#offset-... | 3 | 35 | 1 |
c64c5fe4a205078d93777a3df1e63c7fde0e022a | Boris Chiou | 2020-01-22T20:20:38 | Bug 1592822 - Use Serde for Transform. r=emilio
Though this may make us use more space when serializing
StyleTransform, but we don't have to do extra conversion on the compostior
side, and this makes us easier to maintain the Rust type.
Differential Revision: https://phabricator.services.mozilla.com/D60045 | diff --git a/style/values/generics/transform.rs b/style/values/generics/transform.rs
index d452b215c..42a519731 100644
--- a/style/values/generics/transform.rs
+++ b/style/values/generics/transform.rs
@@ -23,8 +23,10 @@ use style_traits::{CssWriter, ToCss};
Clone,
Copy,
Debug,
+ Deserialize,
Mall... | 2 | 29 | 0 |
5b5ff7b425baaf289538002bdda4d42a71c2d04a | Boris Chiou | 2020-01-22T20:18:31 | Bug 1592822 - Use Serde for rotate, scale, and translate properties. r=emilio
The only drawback is: we resolve LengthPercentage value before passing
translate property through IPC, so its percentage part is redundant.
However, this makes us easier to maintain the Rust type.
Differential Revision: https://phabricator.... | diff --git a/style/values/generics/transform.rs b/style/values/generics/transform.rs
index 3322323e7..d452b215c 100644
--- a/style/values/generics/transform.rs
+++ b/style/values/generics/transform.rs
@@ -611,8 +611,10 @@ pub fn get_normalized_vector_and_angle<T: Zero>(
Clone,
Copy,
Debug,
+ Deseriali... | 1 | 9 | 0 |
0063ddafecfc14f674d2e9057ddeba43994d77b4 | Bogdan Tara | 2020-01-22T19:17:39 | Backed out 6 changesets (bug 1592822) for bustages complaining about layout/painting/nsDisplayList.cpp CLOSED TREE
Backed out changeset 90d0f2ebd310 (bug 1592822)
Backed out changeset 9890bad86a0e (bug 1592822)
Backed out changeset 43870cc90433 (bug 1592822)
Backed out changeset d80e0e3f5b87 (bug 1592822)
Backed out c... | diff --git a/style/values/computed/motion.rs b/style/values/computed/motion.rs
index e2565ff34..88a5b7c72 100644
--- a/style/values/computed/motion.rs
+++ b/style/values/computed/motion.rs
@@ -23,10 +23,8 @@ fn is_auto_zero_angle(auto: &bool, angle: &Angle) -> bool {
ComputeSquaredDistance,
Copy,
Debug,
... | 7 | 1 | 80 |
24eaab26a538b2bde8771d2358819d0431c6d039 | Ting-Yu Lin | 2020-01-16T21:45:19 | Bug 1308636 Part 3 - Remove moz-prefixed aliases for column-gap and CSS multi-column properties. r=dbaron
Introduce a new pref "layout.css.prefixes.columns" to guard the prefixed
aliases.
The modification to `properties-db.js` was generated by
`./mach devtools-css-db`.
Differential Revision: https://phabricator.serv... | diff --git a/style/properties/longhands/column.mako.rs b/style/properties/longhands/column.mako.rs
index b98799084..1974e82d1 100644
--- a/style/properties/longhands/column.mako.rs
+++ b/style/properties/longhands/column.mako.rs
@@ -13,7 +13,7 @@ ${helpers.predefined_type(
engines="gecko servo-2013 servo-2020",
... | 3 | 11 | 10 |
5021aa46b3247992d3065ea63b2067f82b9a66ea | Emilio Cobos Álvarez | 2020-01-16T05:41:16 | Bug 1609489 - Remove lazy_static usage from custom_properties.rs. r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D60039 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 06d0e71cb..b7ef6cf21 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -62,14 +62,12 @@ fn get_safearea_inset_right(device: &Device) -> VariableValue {
VariableValue::pixel(device.safe_area_insets().right)
}
-la... | 1 | 6 | 8 |
abf26ade32b758dd521d55915b542da95d1525ca | Emilio Cobos Álvarez | 2020-01-15T19:43:08 | Bug 1609428 - Implement min() / max() / clamp() for simple css types behind a pref. r=boris
So for everything but <length> and <length-percentage>, which have more complex
mechanics.
The pref is off for now of course.
Differential Revision: https://phabricator.services.mozilla.com/D60012 | diff --git a/style/values/specified/calc.rs b/style/values/specified/calc.rs
index d951d0de0..4fb3c009e 100644
--- a/style/values/specified/calc.rs
+++ b/style/values/specified/calc.rs
@@ -20,9 +20,14 @@ use style_traits::{CssWriter, ParseError, SpecifiedValueInfo, StyleParseErrorKin
/// The name of the mathematical f... | 1 | 155 | 129 |
c7b57d735ec96d1ee3680c3094ce0a18991e828b | Emilio Cobos Álvarez | 2020-01-15T00:46:01 | Bug 1609256 - Centralize calc function parsing. r=boris
So that extending it to support other math functions like min / max / etc is
simpler.
There should be no behavior change with this patch, though I added a comment to
some places where we don't do calc() clamping correctly (though other browsers
don't either so..... | diff --git a/style/values/specified/angle.rs b/style/values/specified/angle.rs
index 458f4178e..6485bca6f 100644
--- a/style/values/specified/angle.rs
+++ b/style/values/specified/angle.rs
@@ -208,7 +208,9 @@ impl Angle {
input: &mut Parser<'i, 't>,
allow_unitless_zero: AllowUnitlessZeroAngle,
) ... | 7 | 116 | 58 |
9e64b9180d2ce4768103691f0d4cbd8e9a31577f | Emilio Cobos Álvarez | 2020-01-14T19:01:05 | Bug 981248 - Rewrite <input type=number> to avoid an anonymous input. r=masayuki,surkov,jwatt,ntim,jfkthame,smaug
Instead, subclass nsTextControlFrame. This simplifies the code and avoids
correctness issues.
I kept the localization functionality though it is not spec compliant. But I
filed a bug to remove it in a fol... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index e4b2d7f0b..9a1196a11 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1869,22 +1869,7 @@ impl<'le> ::selectors::Element for GeckoElement<'le> {
#[inline]
fn pseudo_element_originating_element(&self) -> Option<Self> {
... | 1 | 1 | 16 |
b2a035b299278bb3e847175f103580a5cd90e3ed | Emilio Cobos Álvarez | 2020-01-14T20:25:03 | Bug 844349 - Do not ignore color: transparent in high contrast mode. r=jwatt
PDFJS uses it, for example to allow text selection. It's not great if it shows
on top of the actual PDF :-)
Differential Revision: https://phabricator.services.mozilla.com/D58703 | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 39b99a4fe..ae4bad7a2 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -280,6 +280,11 @@ impl Device {
convert_nscolor_to_rgba(self.pref_sheet_prefs().mDefaultBackgroundColor)
}
+ /// Returns ... | 2 | 25 | 16 |
3983fee8b7c4c1d70f5fc258f1eadfbb3eb6f08a | Mihai Alexandru Michis | 2020-01-14T17:28:17 | Backed out 2 changesets (bug 981248) for causing multiple failures.
CLOSED TREE
Backed out changeset 7a96708cc8b7 (bug 981248)
Backed out changeset 1eace7bd28d9 (bug 981248) | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 9a1196a11..e4b2d7f0b 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -1869,7 +1869,22 @@ impl<'le> ::selectors::Element for GeckoElement<'le> {
#[inline]
fn pseudo_element_originating_element(&self) -> Option<Self> {
... | 1 | 16 | 1 |
6d879139e2627b816797e3c74c843f76e13fccb4 | Makoto Kato | 2020-01-08T11:56:25 | Bug 1503656 - Part 3. Don't use hardcoded value for safearea. r=emilio
To implement safe area support on Gecko, we should get safe area from Device.
Differential Revision: https://phabricator.services.mozilla.com/D52504 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index a8ccd96ef..06d0e71cb 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -12,7 +12,7 @@ use crate::properties::{CSSWideKeyword, CustomDeclaration, CustomDeclarationValu
use crate::selector_map::{PrecomputedHashMap, Preco... | 3 | 69 | 29 |
a7fbebe50267fb304560d2ee6d2b418cb0181fac | Makoto Kato | 2020-01-08T11:56:25 | Bug 1503656 - Part 2. Use Device for parameter instead of CssEnvironment. r=emilio
CssEnvironment alwasy is in Device, so use Device as parameter instead of CssEnvironment.
Differential Revision: https://phabricator.services.mozilla.com/D52507 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 3717e1f06..a8ccd96ef 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -7,6 +7,7 @@
//! [custom]: https://drafts.csswg.org/css-variables/
use crate::hash::map::Entry;
+use crate::media_queries::Device;
use crate::p... | 5 | 31 | 30 |
f2c5ca52dbdab4aceea994d1a79a1be075328155 | Makoto Kato | 2020-01-08T11:55:28 | Bug 1503656 - Part 1. Always use CssEnvironment from media query's device. r=emilio
Although CssEnvironment is in Device of media query implementation, some code
creates CssEnvironment instance without Device. So I would like always to use it from Device of media query.
Differential Revision: https://phabricator.serv... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 90dec0a47..d51701b2c 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -778,6 +778,7 @@ impl PropertyDeclarationBlock {
dest: &mut CssStringWriter,
computed_... | 1 | 3 | 8 |
ff578a35966dca78b4c48eb459cd1fb104e6bab0 | Emilio Cobos Álvarez | 2020-01-13T13:23:22 | Bug 1607049 - Pack LengthPercentage better. r=jwatt
So that it takes one pointer instead of two, and doesn't make nsStylePosition's
size blow up.
This is not as ugly as I was fearing, thankfully, though it requires a bit of
boilerplate. I think it's acceptable.
Differential Revision: https://phabricator.services.moz... | diff --git a/style/values/computed/length_percentage.rs b/style/values/computed/length_percentage.rs
index ad108b948..bf489197b 100644
--- a/style/values/computed/length_percentage.rs
+++ b/style/values/computed/length_percentage.rs
@@ -3,19 +3,83 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
/... | 2 | 315 | 58 |
2fe69500ba1f1321ebf2530147cb74cefae7d535 | Emilio Cobos Álvarez | 2020-01-13T13:23:44 | Bug 1607049 - Move LengthPercentage to its own file. r=jwatt
I'm (sadly) about to make it a bit more complicated to pack it better. So we
may as well do this so it is easier to reason about navigate.
I also reordered things a bit, and removed some From<> implementations and
such.
Differential Revision: https://phabr... | diff --git a/style/values/animated/length.rs b/style/values/animated/length.rs
index ece26a9c4..837b3ee86 100644
--- a/style/values/animated/length.rs
+++ b/style/values/animated/length.rs
@@ -5,7 +5,7 @@
//! Animation implementation for various length-related types.
use super::{Animate, Procedure};
-use crate::val... | 5 | 566 | 568 |
2164b933fb6856cadc69f087222a2b0ae59588c7 | Emilio Cobos Álvarez | 2020-01-13T13:21:58 | Bug 1607049 - Split LengthPercentage again. r=boris
This is needed to support min() / max() / clamp(), etc, as those need to be a
tree of values and thus need heap storage.
This unfortunately grows LengthPercentage to be two pointers, which is bad as
it blows up the size of nsStylePosition enough to trigger the size ... | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 3f82b832b..390c1d4fe 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -138,8 +138,7 @@ impl Device {
/// Set the font size of the root element (for rem)
pub fn set_root_font_size(&self, size: Au) {
... | 6 | 304 | 177 |
a6ff86b76b0ae811ef414782095a737f9a8c2c0d | Xidorn Quan | 2020-01-10T23:47:28 | Bug 1513275 - Ensure nested ruby level container don't escape from line break suppression. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D58351 | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 36463aad6..a66c9462c 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -547,7 +547,14 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
}
#[cfg(feature = "gecko")]
- fn should_suppress_linebreak(&self, layout_parent_style:... | 1 | 18 | 4 |
b4d666ee80dd87270aaa0c046d64b300f53bac90 | Emilio Cobos Álvarez | 2020-01-09T11:36:02 | No bug - Minor comment fix.
Differential Revision: https://phabricator.services.mozilla.com/D59310 | diff --git a/style/sharing/checks.rs b/style/sharing/checks.rs
index 9c860f025..5e8350e78 100644
--- a/style/sharing/checks.rs
+++ b/style/sharing/checks.rs
@@ -94,7 +94,7 @@ where
target.class_list() == candidate.class_list()
}
-/// Whether a given element has the same class attribute as a given candidate.
+//... | 1 | 1 | 1 |
bf344326dd23d4643bf9f908b8f9d39f0f1f808f | Emilio Cobos Álvarez | 2020-01-08T00:55:18 | Bug 1607553 - Make an assertion a release assert in nightly. r=heycam
If this can happen legitimately, this will help fuzzers to catch it.
Differential Revision: https://phabricator.services.mozilla.com/D59066 | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index 19e3accb8..fa859d79f 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -1719,7 +1719,10 @@ impl Drop for StrongRuleNode {
return;
}
- debug_assert!(node.children.read().is_empty());
+ if cfg!(debug... | 1 | 4 | 1 |
5131ecbed6cc3f42c53732d9ea6b6b194699b02e | Emilio Cobos Álvarez | 2020-01-07T21:00:42 | Bug 1606130 - Make display: -moz-box more similar to other display types for block layout. r=jfkthame,surkov
It is unexpected (see bug) that a -moz-box is affected by baseline alignment.
Make -moz-box be block-outside, and -moz-inline-box be inline-outside, instead
of the bespoke thing we have now.
This is more simil... | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 1549f66e8..2f114b5bb 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -98,8 +98,6 @@ pub enum DisplayInside {
#[cfg(feature = "gecko")]
MozBox,
#[cfg(feature = "gecko")]
- MozInlineBox,
- ... | 1 | 2 | 14 |
1a1e17c46fbc801c5c2e730945d15228c03cdb47 | Bogdan Tara | 2020-01-07T20:53:10 | Backed out changeset 23d862866f3a (bug 1606130) for android crashtest complaining about 1547420-1.html | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 2f114b5bb..1549f66e8 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -98,6 +98,8 @@ pub enum DisplayInside {
#[cfg(feature = "gecko")]
MozBox,
#[cfg(feature = "gecko")]
+ MozInlineBox,
+ ... | 1 | 14 | 2 |
51e16ab59db921bc723b38256b6b40ca8282ce65 | Emilio Cobos Álvarez | 2020-01-05T13:10:39 | Bug 1605803 - Use cbindgen for content property. r=xidorn
This cleans up and also allows us to keep the distinction between content: none
and content: normal, which allows us to fix the computed style we return from
getComputedStyle().
Do this last bit from the resolved value instead of StyleAdjuster, because
otherwi... | diff --git a/style/counter_style/mod.rs b/style/counter_style/mod.rs
index 25cdc3f87..d131f3503 100644
--- a/style/counter_style/mod.rs
+++ b/style/counter_style/mod.rs
@@ -409,6 +409,7 @@ impl ToCss for System {
/// <https://drafts.csswg.org/css-counter-styles/#typedef-symbol>
#[derive(Clone, Debug, Eq, MallocSize... | 13 | 122 | 343 |
a78c8e729f3ef1929d1abd52362844f773540c31 | Ting-Yu Lin | 2019-12-31T16:15:12 | Bug 1499281 - Remove column-span pref in column.mako.rs. r=dbaron
Differential Revision: https://phabricator.services.mozilla.com/D58399 | diff --git a/style/properties/longhands/column.mako.rs b/style/properties/longhands/column.mako.rs
index 8b49679ab..b98799084 100644
--- a/style/properties/longhands/column.mako.rs
+++ b/style/properties/longhands/column.mako.rs
@@ -69,17 +69,14 @@ ${helpers.predefined_type(
spec="https://drafts.csswg.org/css-mult... | 1 | 1 | 4 |
2f8bcbd735f8f75693110e602d179b4f36a391f2 | Emilio Cobos Álvarez | 2019-12-31T18:14:35 | Bug 1604989 - Do not incorrectly share style across elements with different part names. r=nordzilla
Do the same we do for classes for now. We could be more precise and achieve a
bit more sharing with some more effort (left a comment there), but it seems
unlikely to matter in practice (and if we did that, we'd probably... | diff --git a/style/sharing/checks.rs b/style/sharing/checks.rs
index 19c1c52ac..9c860f025 100644
--- a/style/sharing/checks.rs
+++ b/style/sharing/checks.rs
@@ -81,7 +81,7 @@ where
target.pres_hints() == candidate.pres_hints()
}
-/// Whether a given element has the same class attribute than a given candidate.
+... | 2 | 60 | 8 |
2a78403f11e812238825fba98a595dff0b8d4124 | Emilio Cobos Álvarez | 2019-12-26T22:17:35 | Bug 1606019 - Remove unused FFI function to refcount nsIReferrerInfo. r=xidorn
We don't use RefPtr<nsIReferrerInfo> in rust.
Differential Revision: https://phabricator.services.mozilla.com/D58274 | diff --git a/style/gecko_bindings/sugar/refptr.rs b/style/gecko_bindings/sugar/refptr.rs
index e27b4a28c..a141aef4e 100644
--- a/style/gecko_bindings/sugar/refptr.rs
+++ b/style/gecko_bindings/sugar/refptr.rs
@@ -303,11 +303,6 @@ impl_threadsafe_refcount!(
bindings::Gecko_AddRefURLExtraDataArbitraryThread,
bi... | 1 | 0 | 5 |
0ce931aa5e6c079ac839223fe315bf2dfc99a381 | Emilio Cobos Álvarez | 2019-12-19T20:43:06 | Bug 1604023 - Workaround LLVM ABI bug. r=froydnj
All the gory details in https://bugzilla.mozilla.org/show_bug.cgi?id=1600735 and
related LLVM / GCC bugs. Avoid the issue by forcing the relevant enum to be
32-bit wide, so as to not trigger the LLVM bug.
Differential Revision: https://phabricator.services.mozilla.com/... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 30a03f792..e4a07da1c 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -1803,8 +1803,11 @@ impl ToCss for PropertyId {
}
/// The counted unknown property list which is used for cs... | 1 | 4 | 1 |
beed5e47428f7225e6f428e80d709f1167b1dbdd | Emilio Cobos Álvarez | 2019-12-19T01:19:04 | Bug 1581467 - Do not use synthetic display-inside values. r=TYLin
This matches the new servo layout engine too, and thus removes some #[cfg]
gunk. Just use `flow` since it doesn't simplify the layout code as much.
Differential Revision: https://phabricator.services.mozilla.com/D45973 | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 6a3dc75f4..36463aad6 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -12,8 +12,6 @@ use crate::properties::longhands::float::computed_value::T as Float;
use crate::properties::longhands::overflow_x::computed_value::T as Overflow... | 2 | 16 | 40 |
d44a97e98a74eb2265fe9e6f0104f2870a4535ef | Sean Voisen | 2019-12-17T11:27:41 | Bug 1453472 - Add support for logical versions of overscroll-behavior. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D57363 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index f5f09f32e..169ab57c7 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -473,13 +473,15 @@ ${helpers.predefined_type(
animation_value_type="discrete",
)}
-% for axi... | 1 | 3 | 1 |
1a616ff3ff7bf940d738fda0f779feb39bdcb497 | Emilio Cobos Álvarez | 2019-12-16T13:34:23 | Bug 1604173 - Cherry-pick various servo-layout-2020 changes.
Depends on D57314
Differential Revision: https://phabricator.services.mozilla.com/D57315 | diff --git a/style/logical_geometry.rs b/style/logical_geometry.rs
index b6f2b11bd..d4d058adc 100644
--- a/style/logical_geometry.rs
+++ b/style/logical_geometry.rs
@@ -173,6 +173,11 @@ impl WritingMode {
self.intersects(WritingMode::VERTICAL)
}
+ #[inline]
+ pub fn is_horizontal(&self) -> bool {
... | 14 | 108 | 22 |
5d78e146e036f4666d358f9b298be886454b3d8c | Emilio Cobos Álvarez | 2019-12-16T13:34:20 | Bug 1604173 - Rustfmt recent changes.
Differential Revision: https://phabricator.services.mozilla.com/D57314 | diff --git a/selectors/builder.rs b/selectors/builder.rs
index 575517711..7a58e35d1 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -324,7 +324,7 @@ where
Component::LastOfType |
Component::OnlyOfType => {
specificity.class_like_selectors += 1;
- }
+... | 22 | 42 | 40 |
3e28c2e621f50ec14a50d9c998702294bf07cf7c | Emilio Cobos Álvarez | 2019-12-16T13:22:04 | Bug 1604062 - Use less Au in font code. r=boris
Font code is the only thing that was using Au in the style system without
interfacing with Gecko, and there was no real reason for it to do so.
This slightly simplifies the code.
Differential Revision: https://phabricator.services.mozilla.com/D57248 | diff --git a/style/font_metrics.rs b/style/font_metrics.rs
index 8e69118ad..5ceb2b0f4 100644
--- a/style/font_metrics.rs
+++ b/style/font_metrics.rs
@@ -8,16 +8,16 @@
use crate::context::SharedStyleContext;
use crate::Atom;
-use app_units::Au;
+use crate::values::computed::Length;
/// Represents the font metrics... | 13 | 62 | 89 |
f21d54b9209df6828597e6a96e2434436538279f | Emilio Cobos Álvarez | 2019-12-15T21:33:34 | Bug 1604063 - Make LengthPercentage not copy. r=boris
This is needed to support min() / max() / clamp(), etc.
Differential Revision: https://phabricator.services.mozilla.com/D57249 | diff --git a/style/logical_geometry.rs b/style/logical_geometry.rs
index cad7e1d00..deb98c16e 100644
--- a/style/logical_geometry.rs
+++ b/style/logical_geometry.rs
@@ -449,7 +449,7 @@ impl<T: Zero> LogicalSize<T> {
}
}
-impl<T: Copy> LogicalSize<T> {
+impl<T> LogicalSize<T> {
#[inline]
pub fn new(mod... | 5 | 58 | 49 |
477baeb6bc1a1903e85dc419e7c145e5d1e89981 | Emilio Cobos Álvarez | 2019-12-13T13:27:27 | Bug 1603455 - Remove full-screen-api.unprefix.enabled. r=xidorn,smaug
It's been enabled since Firefox 64.
Differential Revision: https://phabricator.services.mozilla.com/D56951 | diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs
index eca60fdc5..8d9fc3d2d 100644
--- a/style/gecko/non_ts_pseudo_class_list.rs
+++ b/style/gecko/non_ts_pseudo_class_list.rs
@@ -48,8 +48,7 @@ macro_rules! apply_non_ts_list {
("indeterminate", Indeterminate... | 3 | 4 | 12 |
8f482510a585e12f45ad1c699dd124eaff29a943 | jeffin143 | 2019-12-13T05:34:38 | Bug 1601856 : convert NS_STYLE_VISIBILITY_* to an enum class in nsStyleConsts.h r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D56140 | diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs
index 2542ee5e3..c9ddeb19f 100644
--- a/style/properties/longhands/inherited_box.mako.rs
+++ b/style/properties/longhands/inherited_box.mako.rs
@@ -16,6 +16,7 @@ ${helpers.single_keyword(
gecko_ffi_name... | 1 | 1 | 0 |
d476832fa046a14cb71d99424ec5b8155bb5e38c | Emilio Cobos Álvarez | 2019-12-12T13:57:54 | Bug 1602843 - Preserve CSS input exactly during sanitization. r=hsivonen
This avoids the mutation due to the different serialization in some cases.
Differential Revision: https://phabricator.services.mozilla.com/D56732 | diff --git a/style/stylesheets/mod.rs b/style/stylesheets/mod.rs
index b74413866..054708dbb 100644
--- a/style/stylesheets/mod.rs
+++ b/style/stylesheets/mod.rs
@@ -60,6 +60,7 @@ pub use self::rules_iterator::{NestedRuleIterationCondition, RulesIterator};
pub use self::style_rule::StyleRule;
pub use self::stylesheet:... | 2 | 87 | 4 |
da50fee5dcc1647ab74433cb746fc7d2774279d4 | Noemi Erli | 2019-12-12T21:49:35 | Backed out changeset d23f209ada8b (bug 1603455) for causing failures in test_fullscreen-api.html | diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs
index 8d9fc3d2d..eca60fdc5 100644
--- a/style/gecko/non_ts_pseudo_class_list.rs
+++ b/style/gecko/non_ts_pseudo_class_list.rs
@@ -48,7 +48,8 @@ macro_rules! apply_non_ts_list {
("indeterminate", Indeterminate... | 3 | 12 | 4 |
591b261efc2504746a0b29f9c3d9003fa887928e | jeffin143 | 2019-12-12T10:24:16 | Bug 1601990 : convert NS_STYLE_POINTER_EVENTS_* to an enum class in nsStyleConsts.h r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D56203 | diff --git a/style/properties/longhands/inherited_ui.mako.rs b/style/properties/longhands/inherited_ui.mako.rs
index d854d4a49..a8bc8e8cf 100644
--- a/style/properties/longhands/inherited_ui.mako.rs
+++ b/style/properties/longhands/inherited_ui.mako.rs
@@ -26,6 +26,7 @@ ${helpers.single_keyword(
animation_value_ty... | 1 | 1 | 0 |
25b8968507533322087ab07e0206bbb53563d2d3 | Emilio Cobos Álvarez | 2019-11-25T23:21:20 | Bug 1599181 - Fix serialization of @namespace rule. r=boris
This code comes from:
https://hg.mozilla.org/mozilla-central/rev/2418cfba72c33c5623f6fb4c243c5203819c8240
I audited other callers of write_str, they seem ok.
Differential Revision: https://phabricator.services.mozilla.com/D54601 | diff --git a/style/stylesheets/namespace_rule.rs b/style/stylesheets/namespace_rule.rs
index 81a92f1c3..d76703e4f 100644
--- a/style/stylesheets/namespace_rule.rs
+++ b/style/stylesheets/namespace_rule.rs
@@ -7,8 +7,9 @@
use crate::shared_lock::{SharedRwLockReadGuard, ToCssWithGuard};
use crate::str::CssStringWriter;... | 1 | 7 | 7 |
59fbedf518f1decb45a3fdcd483b2d60c2bb0fb2 | Emilio Cobos Álvarez | 2019-12-09T13:40:16 | Bug 1600773 - Invalidate shadow part pseudo-class styles correctly. r=heycam
I was going to send a test for `:focus` via wpt, but then realized it was
probably not spec-compliant with the new rules people want to follow for
:focus, so I filed https://github.com/w3c/csswg-drafts/issues/4555 instead.
Testing `:hover` /... | diff --git a/style/dom.rs b/style/dom.rs
index fbe35e2e4..adba4ff30 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -807,6 +807,9 @@ pub trait TElement:
/// data if it comes from Shadow DOM.
///
/// Returns whether normal document author rules should apply.
+ ///
+ /// TODO(emilio): We could separa... | 3 | 53 | 4 |
a8e0442920b2fc6dd47a2f29137985a82f240d0d | Cameron McCormack | 2019-12-09T03:16:03 | Bug 1571285 - Correctly style dark scrollbars in tree components. r=emilio
We need to ensure the rules that override all properties for scrollbar
part elements only apply to those that are NAC (and so will be eligible
for NAC style sharing). We have some uses of non-NAC <scrollbar>
elements that should continue to in... | diff --git a/selectors/builder.rs b/selectors/builder.rs
index 36a542a53..575517711 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -17,7 +17,7 @@
//! is non-trivial. This module encapsulates those details and presents an
//! easy-to-use API for the parser.
-use crate::parser::{Combinator, Component... | 6 | 31 | 4 |
ae186c95f6b22678668825cd8f99a34712d0d916 | jeffin143 | 2019-12-06T04:42:18 | Bug 1600481 : convert NS_STYLE_ISOLATION_* to an enum class in nsStyleConsts.h r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D55378 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index cfdeb197f..8783d1ee4 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -491,6 +491,7 @@ ${helpers.single_keyword(
engines="gecko",
spec="https://drafts.fxtf.org/... | 1 | 1 | 0 |
4be324c01952aded3bc8b0f4e9d985f246772e42 | Emilio Cobos Álvarez | 2019-12-05T23:30:59 | Bug 1601732 - Update in-tree dependencies to smallvec 1.0. r=glandium
We're vendoring it already so no reason not to. Only a couple dependencies left
after these to get rid of 0.6.
Differential Revision: https://phabricator.services.mozilla.com/D56044 | diff --git a/fallible/Cargo.toml b/fallible/Cargo.toml
index e8f531469..49064da33 100644
--- a/fallible/Cargo.toml
+++ b/fallible/Cargo.toml
@@ -10,7 +10,7 @@ name = "fallible"
path = "lib.rs"
[dependencies]
-smallvec = "0.6"
+smallvec = "1.0"
hashglobe = { path = "../hashglobe" }
# This crate effectively does ... | 12 | 21 | 21 |
050f485031b76bf2752388ef34df72ed41d8ae8b | Emilio Cobos Álvarez | 2019-12-05T22:46:59 | Bug 1587468 - Update derive_more. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D56043 | diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml
index d32e82a23..3b1720717 100644
--- a/selectors/Cargo.toml
+++ b/selectors/Cargo.toml
@@ -23,7 +23,7 @@ bench = []
bitflags = "1.0"
matches = "0.1"
cssparser = "0.27"
-derive_more = "0.13"
+derive_more = "0.99"
log = "0.4"
fxhash = "0.2"
phf = "0.8"
diff ... | 2 | 2 | 2 |
05cd2b3d6186aeef90d029c3501870320998cdae | Christian Holler | 2019-12-05T12:29:56 | Bug 1601597 - Avoid writing into the empty array header. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D55949 | diff --git a/style/gecko_bindings/sugar/ns_t_array.rs b/style/gecko_bindings/sugar/ns_t_array.rs
index e1d6aca75..e3d4e5b86 100644
--- a/style/gecko_bindings/sugar/ns_t_array.rs
+++ b/style/gecko_bindings/sugar/ns_t_array.rs
@@ -105,6 +105,9 @@ impl<T> nsTArray<T> {
where
T: Copy,
{
+ if self.... | 1 | 3 | 0 |
93aeb56c1b0a791ad07850821c1e0a82aa02ef14 | Emilio Cobos Álvarez | 2019-12-05T06:12:47 | Bug 1600998 - Remove layout.css.xul-box-display-values.survive-blockification.enabled. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D55898 | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 7fd5a250e..f69f25256 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -389,20 +389,11 @@ impl Display {
};
Display::from3(DisplayOutside::Block, inside, self.is_list_item()... | 1 | 3 | 12 |
9f52978ba8b39e29c3f7db0e5e374f97379acfde | enordin | 2019-12-05T00:13:49 | Bug 1598600 - Refactor InvalidationMap flags to bitflags r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D55862 | diff --git a/style/gecko/snapshot.rs b/style/gecko/snapshot.rs
index 02707682b..fa9914f62 100644
--- a/style/gecko/snapshot.rs
+++ b/style/gecko/snapshot.rs
@@ -71,7 +71,7 @@ impl GeckoElementSnapshot {
}
/// Returns true if the snapshot recorded an attribute change which isn't a
- /// class or id change... | 3 | 35 | 30 |
349925ab01206cc93a966a044ddca98e51168ffa | Emilio Cobos Álvarez | 2019-12-04T19:54:06 | Bug 1600443 - Update cssparser and phf. r=heycam
This aligns us with Servo. It pulls a new `rand` crate version, but I'm removing
one in https://phabricator.services.mozilla.com/D55351, so hopefully adds up :)
Differential Revision: https://phabricator.services.mozilla.com/D55359 | diff --git a/hashglobe/Cargo.toml b/hashglobe/Cargo.toml
index 1ff1b28bb..49bc0126c 100644
--- a/hashglobe/Cargo.toml
+++ b/hashglobe/Cargo.toml
@@ -13,4 +13,4 @@ readme = "README.md"
libc = "0.2"
[dev-dependencies]
-rand = "0.6"
+rand = "0.7"
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index... | 10 | 27 | 24 |
74e8abfd2d8b05de3764cb80f2577d1e0cef2d8e | enordin | 2019-12-03T18:28:32 | Bug 1594241 - Check for border-image-* initial specified values when serializing border shorthand r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D55588 | diff --git a/style/properties/shorthands/border.mako.rs b/style/properties/shorthands/border.mako.rs
index c1bf200fe..d584e568a 100644
--- a/style/properties/shorthands/border.mako.rs
+++ b/style/properties/shorthands/border.mako.rs
@@ -179,6 +179,16 @@ pub fn parse_border<'i, 't>(
impl<'a> ToCss for LonghandsTo... | 1 | 10 | 0 |
9e1ddbb485cde459948af57f09acd96849d1cc8d | jeffin143 | 2019-12-02T17:22:42 | Bug 1600482 : convert NS_STYLE_RUBY_POSITION_* to an enum class in nsStyleConsts.h r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D55379 | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index 2725113f1..6b2e94356 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -343,6 +343,7 @@ ${helpers.single_keyword(
engines=... | 1 | 1 | 0 |
8bfceaa91049ce1f8a9a1d9c128506a13a7936ef | jeffin143 | 2019-12-02T05:09:33 | Bug 1600484 : convert NS_STYLE_TEXT_SIZE_ADJUST_* to an enum class in nsStyleConsts.h r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D55382 | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index 910a86e1d..2725113f1 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -53,7 +53,7 @@ ${helpers.single_keyword(
"-moz-text... | 1 | 1 | 1 |
ccca62829ac5c9fc2be2effb4be3fdbd5755c3d2 | jeffin143 | 2019-12-01T13:08:49 | Bug 1600483 : convert NS_STYLE_RUBY_ALIGN_* to an enum class in nsStyleConsts.h r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D55380 | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index 428b40a10..910a86e1d 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -333,6 +333,7 @@ ${helpers.single_keyword(
"space-a... | 1 | 1 | 0 |
03e7d13ea5132cc0210b3dc38502453188829756 | jeffin143 | 2019-12-01T13:05:55 | Bug 1600476 : convert NS_STYLE_TOP_LAYER_* to an enum class in nsStyleConsts.h r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D55377 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index b8b6cbc8c..cfdeb197f 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -24,7 +24,7 @@ ${helpers.single_keyword(
"-moz-top-layer",
"none top",
engines="gecko... | 1 | 1 | 1 |
1866a4a7c6f80c6a45e5d8d342fd4c7dd8363cf0 | Emilio Cobos Álvarez | 2019-11-30T14:06:06 | Bug 1600436 - Fix servo build.
Depends on D55357
Differential Revision: https://phabricator.services.mozilla.com/D55358 | diff --git a/style/servo/selector_parser.rs b/style/servo/selector_parser.rs
index 72c47e65d..977a6c59a 100644
--- a/style/servo/selector_parser.rs
+++ b/style/servo/selector_parser.rs
@@ -700,6 +700,14 @@ impl ElementSnapshot for ServoElementSnapshot {
false
}
+ fn exported_part(&self, _: &Atom) -> ... | 1 | 8 | 0 |
eebb7af0970c07661202f0558f25761a8971d8c2 | Emilio Cobos Álvarez | 2019-11-30T14:05:50 | Bug 1600436 - Update some servo-2020 layout ifdefs.
Differential Revision: https://phabricator.services.mozilla.com/D55356 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index a68b179c4..b8b6cbc8c 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -63,6 +63,7 @@ ${helpers.predefined_type(
"Float",
"computed::Float::None",
engines="... | 5 | 5 | 13 |
c186cf184e515591e94a0e56145c3ce4f313ce76 | Simon Sapin | 2019-11-30T14:05:41 | Bug 1600436 - Fix some warnings new in Rust Nightly.
Differential Revision: https://phabricator.services.mozilla.com/D55354 | diff --git a/hashglobe/src/hash_map.rs b/hashglobe/src/hash_map.rs
index cc9f724ae..d2893627e 100644
--- a/hashglobe/src/hash_map.rs
+++ b/hashglobe/src/hash_map.rs
@@ -1702,7 +1702,7 @@ impl<'a, K, V> Iterator for Keys<'a, K, V> {
type Item = &'a K;
#[inline]
- fn next(&mut self) -> Option<(&'a K)> {
+ ... | 3 | 4 | 6 |
fe110e256a267887ce7d13c3ef97c379cef49727 | Federico Mena Quintero | 2019-11-30T14:05:34 | Bug 1600436 - derive_common: Fix example in documentation.
Differential Revision: https://phabricator.services.mozilla.com/D55353 | diff --git a/derive_common/cg.rs b/derive_common/cg.rs
index 7a8fbc244..13c7b12df 100644
--- a/derive_common/cg.rs
+++ b/derive_common/cg.rs
@@ -26,7 +26,9 @@ use synstructure::{self, BindStyle, BindingInfo, VariantAst, VariantInfo};
///
/// For example:
///
+/// ```ignore
/// <T as ToComputedValue>::ComputedVa... | 1 | 2 | 0 |
bf5313adcb12814342cfbb6731d8e63694095d54 | Emilio Cobos Álvarez | 2019-11-30T11:58:18 | Bug 1600320 - Avoid writing into the empty array header. r=jwatt
The only way for this to happen is calling set_len(0) on an already-empty array.
We should be replacing these bindings by the `ThinVec` crate, but this is easier
for now.
Differential Revision: https://phabricator.services.mozilla.com/D55291 | diff --git a/style/gecko_bindings/sugar/ns_t_array.rs b/style/gecko_bindings/sugar/ns_t_array.rs
index 64ca9ffab..e1d6aca75 100644
--- a/style/gecko_bindings/sugar/ns_t_array.rs
+++ b/style/gecko_bindings/sugar/ns_t_array.rs
@@ -89,9 +89,11 @@ impl<T> nsTArray<T> {
pub unsafe fn set_len(&mut self, len: u32) {
... | 1 | 4 | 2 |
3d62ed50cf1aec4c045df41b70af94eea7c0cbb4 | enordin | 2019-11-29T04:40:03 | Bug 1597642 - Have scale function and scale property accept percentage value. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D55012 | diff --git a/style/values/specified/transform.rs b/style/values/specified/transform.rs
index 6a33b6654..44f1afe83 100644
--- a/style/values/specified/transform.rs
+++ b/style/values/specified/transform.rs
@@ -12,7 +12,7 @@ use crate::values::generics::transform::{Matrix, Matrix3D};
use crate::values::specified::positi... | 1 | 17 | 13 |
6ebaeacbe99944d2e4af23ea3b25c425aa8ae777 | Emilio Cobos Álvarez | 2019-11-27T20:51:20 | Bug 1599324 - Fix Servo_IsCssPropertyRecordedInUseCounter so that we also report disabled properties. r=boris
When zoom is disabled, we still count it, but with the current code the testing
function will throw instead of returning the right value, which means we'd fail
layout/style/test/test_use_counters.html.
Differ... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index a568ff911..c2fcbf163 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -1815,8 +1815,8 @@ pub enum CountedUnknownProperty {
}
impl CountedUnknownProperty {
- /// Parse the coun... | 1 | 12 | 4 |
76d435fc567c104f234e28fe90fa4ec4a92078e6 | jeffin143 | 2019-11-26T04:50:04 | Bug 1598528 : convert NS_STYLE_TEXT_ORIENTATION_* to an enum class in nsStyleConsts.h r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D54252 | diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs
index 8db62bf56..2542ee5e3 100644
--- a/style/properties/longhands/inherited_box.mako.rs
+++ b/style/properties/longhands/inherited_box.mako.rs
@@ -51,6 +51,7 @@ ${helpers.single_keyword(
"mixed upright... | 1 | 1 | 0 |
470f6d5b92b69278d617983032c3dedc87ab7a3f | Emilio Cobos Álvarez | 2019-11-25T19:14:37 | Bug 1599115 - Simplify some code now that lifetimes are non-lexical. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D54529 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 639d32a97..3717e1f06 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -306,8 +306,7 @@ fn parse_declaration_value_block<'i, 't>(
) -> Result<(TokenSerializationType, TokenSerializationType), ParseError<'i>> {
let... | 11 | 261 | 257 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.