commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
7cf6de450050c1210e1c44d73f2ae5da1811168b
jeffin143
2019-11-25T16:00:23
Bug 1597893 : convert NS_STYLE_WINDOW_SHADOW_* to an enum class in nsStyleConsts.h r=emilio Differential Revision: https://phabricator.services.mozilla.com/D53920
diff --git a/style/properties/longhands/ui.mako.rs b/style/properties/longhands/ui.mako.rs index 9bb38a150..05d22abd9 100644 --- a/style/properties/longhands/ui.mako.rs +++ b/style/properties/longhands/ui.mako.rs @@ -59,7 +59,7 @@ ${helpers.single_keyword( "none default menu tooltip sheet", engines="gecko", ...
1
1
1
35e3be0e2a961ffb4a787484b0edb85939c2f305
jeffin143
2019-11-25T15:40:50
Bug 1598348 : convert NS_STYLE_OBJECT_FIT_* to an enum class in nsStyleConsts.h r=emilio Differential Revision: https://phabricator.services.mozilla.com/D54153
diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs index 1c2f5cc2e..95595f363 100644 --- a/style/properties/longhands/position.mako.rs +++ b/style/properties/longhands/position.mako.rs @@ -331,6 +331,7 @@ ${helpers.single_keyword( engines="gecko", animation_...
1
1
0
c69ee2250af8bfa937284226f6b2558e4d86aeb8
jeffin143
2019-11-25T15:41:18
Bug 1598539 : convert NS_STYLE_IME_MODE_* to an enum class in nsStyleConsts.h r=emilio Differential Revision: https://phabricator.services.mozilla.com/D54255
diff --git a/style/properties/longhands/ui.mako.rs b/style/properties/longhands/ui.mako.rs index 647028559..9bb38a150 100644 --- a/style/properties/longhands/ui.mako.rs +++ b/style/properties/longhands/ui.mako.rs @@ -15,6 +15,7 @@ ${helpers.single_keyword( "ime-mode", "auto normal active disabled inactive", ...
1
1
0
327bbf33e237606ca2c621308ac25c191d77f7ee
Mats Palmgren
2019-11-23T21:24:33
Bug 1598234 - [css-grid][cssom] Make 'grid-area'/'grid-column'/'grid-row' shorthands serialize to shortest possible form. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D54386
diff --git a/style/properties/shorthands/position.mako.rs b/style/properties/shorthands/position.mako.rs index 5c884243c..d9cb9da33 100644 --- a/style/properties/shorthands/position.mako.rs +++ b/style/properties/shorthands/position.mako.rs @@ -181,8 +181,18 @@ } impl<'a> ToCss for LonghandsToSerialize<'a> ...
2
55
4
6cc3314a1e4da31da9dd1098b1dfa0540ec8080f
Mats Palmgren
2019-11-23T19:58:35
Bug 1597884 - [css-grid] Make some grid/grid-template values serialize to a shorter form. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D53913
diff --git a/style/properties/shorthands/position.mako.rs b/style/properties/shorthands/position.mako.rs index 3e0ef2613..5c884243c 100644 --- a/style/properties/shorthands/position.mako.rs +++ b/style/properties/shorthands/position.mako.rs @@ -360,7 +360,7 @@ value } else { - ...
3
62
20
a2a19fdeec775b48c77ba8a0b4aeeb6318fc3bd3
Mats Palmgren
2019-11-23T19:56:34
Bug 1597639 - [css-grid] Don't accept two trailing <line-names> in the grid/grid-template shorthands. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D53909
diff --git a/style/properties/shorthands/position.mako.rs b/style/properties/shorthands/position.mako.rs index 81a54dbfa..3e0ef2613 100644 --- a/style/properties/shorthands/position.mako.rs +++ b/style/properties/shorthands/position.mako.rs @@ -301,27 +301,37 @@ % endfor let first_line_names = input...
1
25
15
1d4d9500e157a00e5a901d42370b1e55cce1c837
Noemi Erli
2019-11-22T20:04:00
Backed out changeset 8cdae49ab472 (bug 1598539) for causing build bustages in EditorBase.cpp CLOSED TREE
diff --git a/style/properties/longhands/ui.mako.rs b/style/properties/longhands/ui.mako.rs index 9bb38a150..647028559 100644 --- a/style/properties/longhands/ui.mako.rs +++ b/style/properties/longhands/ui.mako.rs @@ -15,7 +15,6 @@ ${helpers.single_keyword( "ime-mode", "auto normal active disabled inactive", ...
1
0
1
562dcfa1d458f66e7f18183029ad26da7c9bd6f2
Razvan Maries
2019-11-22T12:50:12
Backed out changeset dce49f743139 (bug 1597893) for build bustages on nsCocoaWindow.mm. CLOSED TREE
diff --git a/style/properties/longhands/ui.mako.rs b/style/properties/longhands/ui.mako.rs index af250fbfc..647028559 100644 --- a/style/properties/longhands/ui.mako.rs +++ b/style/properties/longhands/ui.mako.rs @@ -58,7 +58,7 @@ ${helpers.single_keyword( "none default menu tooltip sheet", engines="gecko", ...
1
1
1
295afc2a4e360df40cfd4c5561b313fd4915ffd9
jeffin143
2019-11-21T16:52:06
Bug 1597893 : convert NS_STYLE_WINDOW_SHADOW_* to an enum class in nsStyleConsts.h r=emilio Differential Revision: https://phabricator.services.mozilla.com/D53920
diff --git a/style/properties/longhands/ui.mako.rs b/style/properties/longhands/ui.mako.rs index 647028559..af250fbfc 100644 --- a/style/properties/longhands/ui.mako.rs +++ b/style/properties/longhands/ui.mako.rs @@ -58,7 +58,7 @@ ${helpers.single_keyword( "none default menu tooltip sheet", engines="gecko", ...
1
1
1
c0a11b02bd6e6530d2fd37d09b4c2ab1d64f6ea2
Boris Chiou
2019-11-20T22:38:26
Bug 1582554 - Add a preference for offset-path:ray(). r=emilio Differential Revision: https://phabricator.services.mozilla.com/D53110
diff --git a/style/values/specified/motion.rs b/style/values/specified/motion.rs index 90652b5ed..2351acecc 100644 --- a/style/values/specified/motion.rs +++ b/style/values/specified/motion.rs @@ -16,11 +16,24 @@ use style_traits::{ParseError, StyleParseErrorKind}; /// The specified value of `offset-path`. pub type O...
1
13
0
c2034f5827f9b49d93698c8643318386caab2863
Bogdan Tara
2019-11-21T13:35:09
Backed out changeset 726c8aa10d1a (bug 1597893) for bustages complaining about nsCocoaWindow.h CLOSED TREE
diff --git a/style/properties/longhands/ui.mako.rs b/style/properties/longhands/ui.mako.rs index af250fbfc..647028559 100644 --- a/style/properties/longhands/ui.mako.rs +++ b/style/properties/longhands/ui.mako.rs @@ -58,7 +58,7 @@ ${helpers.single_keyword( "none default menu tooltip sheet", engines="gecko", ...
1
1
1
26478288b9f6e7743a2c2c44f2970c7107eee35e
Emilio Cobos Álvarez
2019-11-21T10:32:10
Bug 1559076 - Invalidate parts in nested shadow trees correctly. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D54010
diff --git a/style/dom.rs b/style/dom.rs index ef571b8df..fbe35e2e4 100644 --- a/style/dom.rs +++ b/style/dom.rs @@ -523,6 +523,9 @@ pub trait TElement: /// Returns whether this element has a `part` attribute. fn has_part_attr(&self) -> bool; + /// Returns whether this element exports any part from its s...
6
104
43
2fd95bf9df159b563faf232bfd22091d1aaead15
Emilio Cobos Álvarez
2019-11-21T10:32:32
Bug 1559076 - Implement shadow part forwarding (minus invalidation). r=heycam Some of the stuff, in particular inside GeckoBindings stuff should be refactored to be less ugly and duplicate a bit less code, but the rest of the code should be landable as is. Some invalidation changes are already needed because we weren...
diff --git a/selectors/matching.rs b/selectors/matching.rs index 49b7f3dbd..8993a5ea0 100644 --- a/selectors/matching.rs +++ b/selectors/matching.rs @@ -8,6 +8,7 @@ use crate::nth_index_cache::NthIndexCacheInner; use crate::parser::{AncestorHashes, Combinator, Component, LocalName}; use crate::parser::{NonTSPseudoCla...
9
180
47
fbe9b7578e93230aa58ff53ef0bf74aef0e50ea9
jeffin143
2019-11-21T08:48:19
Bug 1597979 : convert NS_STYLE_TEXT_ANCHOR_* to an enum class in nsStyleConsts.h r=emilio Differential Revision: https://phabricator.services.mozilla.com/D53956
diff --git a/style/properties/longhands/inherited_svg.mako.rs b/style/properties/longhands/inherited_svg.mako.rs index 4ad94b6fb..1d75df08b 100644 --- a/style/properties/longhands/inherited_svg.mako.rs +++ b/style/properties/longhands/inherited_svg.mako.rs @@ -25,6 +25,7 @@ ${helpers.single_keyword( engines="gecko...
1
1
0
2238fc6525ef195b7821b3280fcc98d5ac80a700
jeffin143
2019-11-21T06:07:30
Bug 1597881 : convert NS_STYLE_STROKE_LINECAP_* to an enum class in nsStyleConsts.h r=emilio Differential Revision: https://phabricator.services.mozilla.com/D53908
diff --git a/style/properties/longhands/inherited_svg.mako.rs b/style/properties/longhands/inherited_svg.mako.rs index 487456cbe..4ad94b6fb 100644 --- a/style/properties/longhands/inherited_svg.mako.rs +++ b/style/properties/longhands/inherited_svg.mako.rs @@ -108,6 +108,7 @@ ${helpers.single_keyword( engines="gec...
1
1
0
622e062036dc093b006809f0404cac01c645ea9f
Emilio Cobos Álvarez
2019-11-20T05:46:56
Bug 1597588 - Make rust Atom use NonZeroUsize. r=heycam At first I thought this was going to enable simplifications in the selector parser (to simplify the attribute selector setup), but I couldn't end up shrinking the layout enough. However this should help with bug 1559076, which returns Option<Atom>, and it was ea...
diff --git a/style/gecko_string_cache/mod.rs b/style/gecko_string_cache/mod.rs index b209f316d..5d849a96f 100644 --- a/style/gecko_string_cache/mod.rs +++ b/style/gecko_string_cache/mod.rs @@ -26,6 +26,7 @@ use std::fmt::{self, Write}; use std::hash::{Hash, Hasher}; use std::iter::Cloned; use std::mem::{self, Manual...
1
9
8
acd32cbdfda31eb93bfcbea1f23e942637f60600
jeffin143
2019-11-20T00:49:19
Bug 1597741 : use Enum class for NS_STYLE_SHAPE_RENDERING instead of #define r=emilio Differential Revision: https://phabricator.services.mozilla.com/D53840
diff --git a/style/properties/longhands/inherited_svg.mako.rs b/style/properties/longhands/inherited_svg.mako.rs index bbb7eba1c..487456cbe 100644 --- a/style/properties/longhands/inherited_svg.mako.rs +++ b/style/properties/longhands/inherited_svg.mako.rs @@ -80,6 +80,7 @@ ${helpers.single_keyword( engines="gecko...
1
1
0
6a685ba16ec8f6f73608247af89e037e16185967
Emilio Cobos Álvarez
2019-11-19T06:47:12
Bug 1559076 - Minor debugging improvements. r=heycam These were useful when implementing forwarding, and forgot to send them earlier. Differential Revision: https://phabricator.services.mozilla.com/D53767
diff --git a/style/dom.rs b/style/dom.rs index 2ea64bbb3..ef571b8df 100644 --- a/style/dom.rs +++ b/style/dom.rs @@ -331,7 +331,7 @@ where } /// The ShadowRoot trait. -pub trait TShadowRoot: Sized + Copy + Clone + PartialEq { +pub trait TShadowRoot: Sized + Copy + Clone + Debug + PartialEq { /// The concrete n...
2
10
3
252b4cbd6391f844a733424d5e9dee8c90f32856
Boris Chiou
2019-11-18T20:47:01
Bug 1506746 - Update the expected direction vector of rotate property in wpt. r=birtles For interpolations with the primitive rotate3d(), the direction vectors of the transform functions get normalized first. This should also be applied to rotate property. https://drafts.csswg.org/css-transforms-2/#interpolation-of-t...
diff --git a/style/values/animated/transform.rs b/style/values/animated/transform.rs index 89bb3c084..5a6f3afb9 100644 --- a/style/values/animated/transform.rs +++ b/style/values/animated/transform.rs @@ -1249,7 +1249,11 @@ impl Animate for ComputedRotate { match (self, other) { (&Rotate::None, &R...
1
7
2
16dd61f661c44a09cc5affc617d0bf8b403a7e2f
Emilio Cobos Álvarez
2019-11-18T08:49:27
Bug 1597123 - Remove NODE_IS_ANONYMOUS_ROOT. r=smaug We no longer have multiple kinds of anonymous subtrees, so we can get back one node bit. Differential Revision: https://phabricator.services.mozilla.com/D53344
diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs index f76c0c5fd..ffa685573 100644 --- a/style/gecko/wrapper.rs +++ b/style/gecko/wrapper.rs @@ -761,13 +761,6 @@ impl<'le> GeckoElement<'le> { data.damage |= damage; } - /// This logic is duplicated in Gecko's nsIContent::IsRootOfAnonymousS...
1
2
14
6c323e5ecfb99d2fcc57aa12363f5f5bf410cc07
Emilio Cobos Álvarez
2019-11-17T23:28:39
Bug 1596712 - Use only Origin during the cascade, rather than CascadeLevel. r=heycam The micro-benchmark `style-attr-1.html` regressed slightly with my patch, after the CascadeLevel size increase. This benchmark is meant to test for the "changing the style attribute doesn't cause selector-matching" optimization (whic...
diff --git a/style/animation.rs b/style/animation.rs index c9b4fc5a6..7f96e55b1 100644 --- a/style/animation.rs +++ b/style/animation.rs @@ -16,8 +16,8 @@ use crate::properties::animated_properties::AnimatedProperty; use crate::properties::longhands::animation_direction::computed_value::single_value::T as AnimationDir...
3
26
23
489601d5e5f5ca5de8accdb0f9fb93ec73896dd6
Boris Chiou
2019-11-16T01:52:32
Bug 1596610 - Set WillChangeBits::TRANSFORM for offset-path and add tests for it. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D53109
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 2b4e3a420..2173c8f5f 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1151,7 +1151,9 @@ fn change_bits_for_longhand(longhand: LonghandId) -> WillChangeBits { LonghandId::Opacity => WillChangeBits:...
1
3
1
3aaef9c7c6e221957981c12608c13c18c039832e
Boris Chiou
2019-11-15T19:38:24
Bug 1594946 - Treat 3d translate/scale as 2d if the value can be expressed as 2d. r=emilio For the individual transform properties if they spec a value that can be expressed as 2d we treat as 2d and serialize accordingly. We drop Translate::Translate and Scale::Scale, and then rename Translate::Translate3D as Transla...
diff --git a/style/values/animated/transform.rs b/style/values/animated/transform.rs index 9ac64c3f2..89bb3c084 100644 --- a/style/values/animated/transform.rs +++ b/style/values/animated/transform.rs @@ -139,10 +139,10 @@ impl ComputeSquaredDistance for MatrixDecomposed2D { const RAD_PER_DEG: f64 = std::f64::...
3
149
154
fad5c0924df04c030bbccdb673ef642743dd5c2a
Emilio Cobos Álvarez
2019-11-15T13:39:08
Bug 1596050 - Centralize logic to ignore document colors. r=jfkthame This was a follow-up from the backplate stuff which I requested but didn't happen. Differential Revision: https://phabricator.services.mozilla.com/D53170
diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs index 2e68a889d..3463c1f95 100644 --- a/style/gecko/media_queries.rs +++ b/style/gecko/media_queries.rs @@ -274,13 +274,7 @@ impl Device { if doc.mIsBeingUsedAsImage() { return true; } - let document_color_use...
1
1
7
e72eb5bda76bbbc3bb93cf4a92375cde7e49cdbe
Emilio Cobos Álvarez
2019-11-14T14:16:18
Bug 1596391 - Fix silly boolean logic mistake. r=bustage a=dluca MANUAL PUSH: bustage
diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs index a7b3f7bb6..f76c0c5fd 100644 --- a/style/gecko/wrapper.rs +++ b/style/gecko/wrapper.rs @@ -300,7 +300,10 @@ impl<'ln> GeckoNode<'ln> { fn flattened_tree_parent_is_parent(&self) -> bool { use crate::gecko_bindings::structs::*; let f...
1
4
1
8f9994a98b74ac70671b895e99d6d1ee2acdfe9b
Emilio Cobos Álvarez
2019-11-14T12:54:00
Bug 1596391 - Remove NODE_MAY_BE_IN_BINDING_MNGR. r=smaug Never set anymore. Depends on D52993 Differential Revision: https://phabricator.services.mozilla.com/D52994
diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs index da989e5a7..a7b3f7bb6 100644 --- a/style/gecko/wrapper.rs +++ b/style/gecko/wrapper.rs @@ -300,7 +300,7 @@ impl<'ln> GeckoNode<'ln> { fn flattened_tree_parent_is_parent(&self) -> bool { use crate::gecko_bindings::structs::*; let fl...
1
1
1
8f4b4be5d3b643ffdb2fb7916584b4c560ce8050
Emilio Cobos Álvarez
2019-11-13T09:59:10
Bug 1588431 - Optimize storage of ApplicableDeclaration again. r=heycam So that we don't regress perf. Differential Revision: https://phabricator.services.mozilla.com/D52576
diff --git a/style/applicable_declarations.rs b/style/applicable_declarations.rs index ab83e5737..cc7d9c90d 100644 --- a/style/applicable_declarations.rs +++ b/style/applicable_declarations.rs @@ -19,27 +19,37 @@ use smallvec::SmallVec; /// However, it may depend a lot on workload, and stack space is cheap. pub type ...
2
85
11
649ea912d3a1a2f043736e5b4f2d092eb654c5df
Emilio Cobos Álvarez
2019-11-14T02:49:54
Bug 1588431 - Fix cascade order of shadow parts. r=heycam This moves the shadow cascade order into the cascade level, and refactors the code a bit for that. Differential Revision: https://phabricator.services.mozilla.com/D49988
diff --git a/style/applicable_declarations.rs b/style/applicable_declarations.rs index e4bf996a1..ab83e5737 100644 --- a/style/applicable_declarations.rs +++ b/style/applicable_declarations.rs @@ -5,11 +5,10 @@ //! Applicable declarations management. use crate::properties::PropertyDeclarationBlock; -use crate::rule...
9
238
283
8110a50e51c139cb61b1c1e0f0b846c4616c818a
Emilio Cobos Álvarez
2019-11-13T09:58:52
Bug 1588431 - Split collect_style_attribute_and_animation_rules. r=heycam Animations are their own cascade level per https://drafts.csswg.org/css-cascade-4/#cascade-origin Differential Revision: https://phabricator.services.mozilla.com/D52575
diff --git a/style/rule_collector.rs b/style/rule_collector.rs index f536b80b5..dd50d8467 100644 --- a/style/rule_collector.rs +++ b/style/rule_collector.rs @@ -377,7 +377,7 @@ where } } - fn collect_style_attribute_and_animation_rules(&mut self) { + fn collect_style_attribute(&mut self) { ...
1
5
2
7e6302a997a48dac0e8efea3a520af29021a8a36
Sam Mauldin
2019-11-14T00:17:23
Bug 1592189 - Remove SpecialColorKeyword enum and merge into SystemColor r=emilio Move all the entires of SpecialColorKeyword into SystemColor and rearrange their computation to match. Add the new SystemColor entries into the property list of nsXPLookAndFeel. Differential Revision: https://phabricator.services.mozill...
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index 01e5890d0..ddbdb5f4c 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -36,9 +36,6 @@ pub enum Color { /// A system color #[cfg(feature = "gecko")] System(SystemColor), - /// A spec...
1
23
38
79b07bcfb64b53cd8af9003b395e9e80e4333d96
Hiroyuki Ikezoe
2019-11-14T06:00:05
Bug 1586144 - Factor dynamic toolbar max height into layout metrics. r=emilio,botond Now * nsPresContext::mVisibleArea is excluding the toolbar max height so that ICB is now static regardless of the dynamic toolbar transition * nsPresContext::mSizeForViewportUnits is introduced to resolve viewport units which is i...
diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs index bb126e169..2e68a889d 100644 --- a/style/gecko/media_queries.rs +++ b/style/gecko/media_queries.rs @@ -237,7 +237,13 @@ impl Device { /// used for viewport unit resolution. pub fn au_viewport_size_for_viewport_unit_resolution(&self)...
1
7
1
68c2d976b8929e22ed2a4987a97442332c55ae45
Dzmitry Malyshau
2019-11-14T04:59:56
Bug 1575008 - WebGPU implementation basis r=baku,bzbarsky This change vendors `wgpu` library in-tree and hooks up the initialization bits. It implements adapter and device initialization and adds a simple test. Complementary ecosystem tracker - https://github.com/gfx-rs/wgpu/issues/374 Current status: - [x] General...
diff --git a/style/Cargo.toml b/style/Cargo.toml index 626c9ee43..764beee78 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -28,7 +28,7 @@ gecko_profiler = [] [dependencies] app_units = "0.7" -arrayvec = "0.4.6" +arrayvec = "0.5" atomic_refcell = "0.1" bitflags = "1.0" byteorder = "1.0" @@ -76,7 +76,7 @@...
1
2
2
ee0004015c77f18e308123102dde52238f26c0aa
Gurzau Raul
2019-11-13T19:38:23
Backed out 2 changesets (bug 1590167, bug 1575008) for lints failures at mapped_hyph.h on a CLOSED TREE. Backed out changeset 4d16c3d62cfc (bug 1575008) Backed out changeset 97b8c3759aae (bug 1590167)
diff --git a/style/Cargo.toml b/style/Cargo.toml index 764beee78..626c9ee43 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -28,7 +28,7 @@ gecko_profiler = [] [dependencies] app_units = "0.7" -arrayvec = "0.5" +arrayvec = "0.4.6" atomic_refcell = "0.1" bitflags = "1.0" byteorder = "1.0" @@ -76,7 +76,7 @@...
1
2
2
44db0f8ec911e393f3a42420abf078adc42d2c16
Dzmitry Malyshau
2019-11-13T12:48:33
Bug 1575008 - WebGPU implementation basis r=baku,bzbarsky This change vendors `wgpu` library in-tree and hooks up the initialization bits. It implements adapter and device initialization and adds a simple test. Complementary ecosystem tracker - https://github.com/gfx-rs/wgpu/issues/374 Current status: - [x] Archite...
diff --git a/style/Cargo.toml b/style/Cargo.toml index 626c9ee43..764beee78 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -28,7 +28,7 @@ gecko_profiler = [] [dependencies] app_units = "0.7" -arrayvec = "0.4.6" +arrayvec = "0.5" atomic_refcell = "0.1" bitflags = "1.0" byteorder = "1.0" @@ -76,7 +76,7 @@...
1
2
2
e5a392a1f332e8baedd2f957fd835182a44777a9
Emilio Cobos Álvarez
2019-11-12T20:30:42
Bug 1593951 - Use MaybeUninit in style struct clone impls / constructors. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D51788
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 7783c7eeb..b6cd74103 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -46,7 +46,7 @@ use crate::rule_tree::StrongRuleNode; use crate::selector_parser::PseudoElement; use servo_arc::{Arc, RawOffsetArc,...
1
14
8
c90d75b81b50545ed2fe949cff5dfabd801f3fcd
Tim Nguyen
2019-11-12T19:50:19
Bug 1576946 - Remove nsStackFrame platform code. r=mats Differential Revision: https://phabricator.services.mozilla.com/D49487
diff --git a/style/properties/longhands/xul.mako.rs b/style/properties/longhands/xul.mako.rs index 0862ce533..d5c4011ea 100644 --- a/style/properties/longhands/xul.mako.rs +++ b/style/properties/longhands/xul.mako.rs @@ -64,16 +64,6 @@ ${helpers.single_keyword( spec="Nonstandard (https://developer.mozilla.org/en-U...
2
0
16
386ba64c882cc24b54c04a3eb21851356c3aee32
Razvan Maries
2019-11-12T17:18:42
Backed out changeset 6cd92affba42 (bug 1593951) for Valgrind build bustages. CLOSED TREE
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 383b578c8..7783c7eeb 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -46,7 +46,7 @@ use crate::rule_tree::StrongRuleNode; use crate::selector_parser::PseudoElement; use servo_arc::{Arc, RawOffsetArc,...
1
8
8
c087435cbe3d1aeff771e2e65bc25a21df1c2c8b
Emilio Cobos Álvarez
2019-11-12T11:49:40
Bug 1593951 - Use MaybeUninit in style struct clone impls / constructors. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D51788
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 7783c7eeb..383b578c8 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -46,7 +46,7 @@ use crate::rule_tree::StrongRuleNode; use crate::selector_parser::PseudoElement; use servo_arc::{Arc, RawOffsetArc,...
1
8
8
12626d97a0f07a3fa61e2e0c8d503407696fdf28
Emilio Cobos Álvarez
2019-11-07T11:19:23
Bug 1593865 - Simplify code for keeping alive shared memory until all sheets go away. r=jwatt The existing code wasn't sound, as CSSOM objects also needed to go away before the shared memory goes away (as they keep references to them). This is sound assuming no presence of reference cycles introduced by CSSOM. We ma...
diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs index ad4489c10..bd6b52895 100644 --- a/servo_arc/lib.rs +++ b/servo_arc/lib.rs @@ -485,6 +485,14 @@ impl<T: ?Sized> Arc<T> { } } + /// Whether or not the `Arc` is a static reference. + #[inline] + pub fn is_static(&self) -> bool { + // Us...
2
13
4
fb71b7d3930ebad374e19cceb3686d45065dd8e3
Oana Pop Rus
2019-11-06T17:41:34
Backed out 2 changesets (bug 1593865) for multiple failures on asan_malloc_linux.cc on a CLOSED TREE Backed out changeset 40de560a7cad (bug 1593865) Backed out changeset 6fd25e6c3d1a (bug 1593865)
diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs index bd6b52895..ad4489c10 100644 --- a/servo_arc/lib.rs +++ b/servo_arc/lib.rs @@ -485,14 +485,6 @@ impl<T: ?Sized> Arc<T> { } } - /// Whether or not the `Arc` is a static reference. - #[inline] - pub fn is_static(&self) -> bool { - // Us...
1
4
9
fddfa9ff79eea154bcd4d775e1bff908015e90ce
Emilio Cobos Álvarez
2019-11-06T16:17:15
Bug 1593865 - Simplify code for keeping alive shared memory until all sheets go away. r=jwatt The existing code wasn't sound, as CSSOM objects also needed to go away before the shared memory goes away (as they keep references to them). This is sound assuming no presence of reference cycles introduced by CSSOM. We ma...
diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs index ad4489c10..bd6b52895 100644 --- a/servo_arc/lib.rs +++ b/servo_arc/lib.rs @@ -485,6 +485,14 @@ impl<T: ?Sized> Arc<T> { } } + /// Whether or not the `Arc` is a static reference. + #[inline] + pub fn is_static(&self) -> bool { + // Us...
1
9
4
1afc3c6a81645ce587a1d2b75e9a3cd0ecf3a65c
Emilio Cobos Álvarez
2019-11-06T05:54:17
Bug 1593009 - Make zoom: 0 mean the same as zoom: 1. r=heycam This matches the WebKit implementation, and is clearly a violation of the rules we generally use for ranges in CSS. But it seems to be depended-on legacy behavior, see the linked WebKit bug, this bug, and bug 1593317. Differential Revision: https://phabri...
diff --git a/style/properties/shorthands/box.mako.rs b/style/properties/shorthands/box.mako.rs index 7b4ce1319..351b8cec6 100644 --- a/style/properties/shorthands/box.mako.rs +++ b/style/properties/shorthands/box.mako.rs @@ -464,11 +464,13 @@ ${helpers.two_properties_shorthand( }; // Make sure that ...
1
6
4
a795aaa1f171df7fee8c5f4ba073c80611d673d2
Emilio Cobos Álvarez
2019-11-05T10:24:36
Bug 1591987 - Fix ElementWrapper::is_link. r=jwatt And do a full restyle only when the state goes from visited to unvisited or vice versa. That is, use regular invalidation for addition or removals of href attributes, for example. Differential Revision: https://phabricator.services.mozilla.com/D50821
diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs index c2c4a0c0f..da989e5a7 100644 --- a/style/gecko/wrapper.rs +++ b/style/gecko/wrapper.rs @@ -2191,8 +2191,7 @@ impl<'le> ::selectors::Element for GeckoElement<'le> { #[inline] fn is_link(&self) -> bool { - self.state() - .inte...
3
7
9
22d3a0e9741555ba6a01e4420766b8e1f5db5343
Emilio Cobos Álvarez
2019-11-04T16:55:33
Bug 1506842 - Always restyle / repaint when a visited query finishes. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D50810
diff --git a/style/invalidation/element/state_and_attributes.rs b/style/invalidation/element/state_and_attributes.rs index 30521fb8c..c4671b001 100644 --- a/style/invalidation/element/state_and_attributes.rs +++ b/style/invalidation/element/state_and_attributes.rs @@ -158,6 +158,14 @@ where // If we the visite...
1
8
0
f129f36d5f164e45f8de8c1c80836f778db94097
Emilio Cobos Álvarez
2019-11-04T12:53:09
Bug 1593642 - servo: Fix Servo build. Differential Revision: https://phabricator.services.mozilla.com/D51594
diff --git a/style/media_queries/media_feature_expression.rs b/style/media_queries/media_feature_expression.rs index 6323a8254..4704fab0f 100644 --- a/style/media_queries/media_feature_expression.rs +++ b/style/media_queries/media_feature_expression.rs @@ -242,9 +242,13 @@ fn consume_operation_or_colon(input: &mut Pars...
3
13
7
c771fc4c3f05c88bd7d77c95fb9a337ef113c184
Emilio Cobos Álvarez
2019-11-04T12:53:04
Bug 1593642 - Add a few commas that newer macros need. Servo is on a newer cssparser version. Differential Revision: https://phabricator.services.mozilla.com/D51592
diff --git a/style/counter_style/mod.rs b/style/counter_style/mod.rs index 289281011..25cdc3f87 100644 --- a/style/counter_style/mod.rs +++ b/style/counter_style/mod.rs @@ -220,9 +220,9 @@ macro_rules! counter_style_descriptors { // rather than returning it. let...
10
26
26
1be0ab233e79a6bed270cdfb30df984f075249d9
Simon Sapin
2019-11-04T12:53:01
Bug 1593642 - servo: 2020: enable CSS parsing of properties that are (somewhat) implemented Differential Revision: https://phabricator.services.mozilla.com/D51591
diff --git a/style/properties/longhands/border.mako.rs b/style/properties/longhands/border.mako.rs index 4b9ec84ec..4d68c8bfc 100644 --- a/style/properties/longhands/border.mako.rs +++ b/style/properties/longhands/border.mako.rs @@ -24,7 +24,6 @@ "border-%s-color" % side_name, "Color", "computed_value...
9
11
17
966e69821edc440a9d11a4f2d889ebca22016d08
Simon Sapin
2019-11-04T12:52:57
Bug 1593642 - More compact debug output for CSS values. ``` Rect { start_corner: Vec2 { i: 0.0 px, b: 0.0 px }, size: Vec2 { i: 1024.0 px, b: 20.0 px }, } ``` … instead of: ``` Rect { start_corner: Vec2 { inline: CSSPixelLength( 0.0, ), block: CSSPixelLength( ...
diff --git a/style/values/computed/length.rs b/style/values/computed/length.rs index 62a4781da..5665c1e73 100644 --- a/style/values/computed/length.rs +++ b/style/values/computed/length.rs @@ -613,7 +613,6 @@ impl Size { Clone, ComputeSquaredDistance, Copy, - Debug, Deserialize, MallocSizeOf...
1
7
1
12e4959afbc9891e083976eaa15eb35ab5ca6675
Matt Brubeck
2019-11-04T12:52:49
Bug 1593642 - Remove obsolete logic for LRUCache size. The LRUCache implementation has been replaced, and no longer requires a backing store larger than its capacity. Differential Revision: https://phabricator.services.mozilla.com/D51589
diff --git a/style/sharing/mod.rs b/style/sharing/mod.rs index 38fd62834..9b8c1275e 100644 --- a/style/sharing/mod.rs +++ b/style/sharing/mod.rs @@ -90,17 +90,14 @@ use uluru::{Entry, LRUCache}; mod checks; /// The amount of nodes that the style sharing candidate cache should hold at -/// most. We'd somewhat like ...
1
3
6
b80e448b20a80a38a960444ebab0988d0bed180e
Michael Howell
2019-11-04T12:52:47
Bug 1593642 - servo: Add simple implementation of content-security-policy on scripts / styles. This needs a lot more hooks before it'll actually be a good implementation, but for a start it can help get some feedback on if this is the right way to go about it. Part of servo/servo#4577 Servo commit: b8f3e8bb2e9 Diff...
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index ab8879ea8..82ad7a7ef 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -21,10 +21,12 @@ servo = [ "url", "webrender_api", "xml5ever", + "content-security-policy", ] [dependencies] app_units = "0.7" +c...
2
9
0
75915522b2c174a5bc28ecbb5e8bdd9cef2c968e
Simon Sapin
2019-11-04T12:52:44
Bug 1593642 - servo: 2020: parse `display: contents`. Differential Revision: https://phabricator.services.mozilla.com/D51587
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index b66b03b47..58d51f8c0 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -619,7 +619,7 @@ impl Parse for Display { // Now parse the single-keyword `display` values. Ok(try_match_ident_ignore_...
1
1
1
faefc4c5fdc347d0cd1a897a509f6163d1cbc780
Simon Sapin
2019-11-04T12:52:40
Bug 1593642 - servo: 2020: paint borders. Differential Revision: https://phabricator.services.mozilla.com/D51586
diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs index 5d9e6f54e..4d3895440 100644 --- a/style/properties/helpers.mako.rs +++ b/style/properties/helpers.mako.rs @@ -880,7 +880,8 @@ { // Define all of the expected variables that correspond to the shorthand ...
4
15
17
2443b5d31bd54ececf36bb5f32dc0a9ef542af57
Kitlith
2019-11-04T12:52:32
Bug 1593642 - servo: Remove usage of opts::get() from style. Part of #22854. Differential Revision: https://phabricator.services.mozilla.com/D51585
diff --git a/style/context.rs b/style/context.rs index 0c7d97441..d07cf6bd9 100644 --- a/style/context.rs +++ b/style/context.rs @@ -103,14 +103,29 @@ fn get_env_usize(name: &str) -> Option<usize> { }) } +/// A global variable holding the state of +/// `StyleSystemOptions::default().disable_style_sharing_cache`...
2
27
5
9f46f0668f27fca40ea6944b6a8b706744ccbea3
Emilio Cobos Álvarez
2019-11-04T12:52:29
Bug 1593642 - Rustfmt recent changes. Differential Revision: https://phabricator.services.mozilla.com/D51584
diff --git a/style/traversal.rs b/style/traversal.rs index d88c25004..862edb24f 100644 --- a/style/traversal.rs +++ b/style/traversal.rs @@ -497,8 +497,8 @@ pub fn recalc_style_at<E, D, F>( !child_cascade_requirement.can_skip_cascade() || is_servo_nonincremental_layout(); - traverse_children = tr...
2
6
3
b80b9fa8653d55d6cde578624646215cfa3c4952
Sam Mauldin
2019-11-02T21:28:49
Bug 1592389 - Rename Mozfield / Mozfieldtext to Field and Fieldtext r=emilio Split off of Bug 1590894 Rename these to support unprefixed version Also add alias to keep compatibility Differential Revision: https://phabricator.services.mozilla.com/D50989
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index acad33830..01e5890d0 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -119,6 +119,10 @@ pub enum SystemColor { Buttonshadow, Buttontext, Captiontext, + #[parse(aliases = "-moz-fiel...
1
4
2
c16ffe954d0b3ef0d86c5b1d26ebf57a94abeab5
Boris Chiou
2019-10-31T20:07:45
Bug 1429305 - Extend compositor properties for motion. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D50014
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 22c779a52..b8b6cbc8c 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -397,7 +397,7 @@ ${helpers.predefined_type( engines="gecko", animation_value_type="Compute...
1
4
1
d608af18434ac8afab23c1bdb57c0eee05aabc6a
Boris Chiou
2019-10-31T20:07:41
Bug 1429305 - Add new layer messages for passing motion path info. r=hiro,mattwoodrow This also includes the implementation of SetAnimatable, FromAnimatable, and merge the final matrix with motion path. Besides, we always use PathBuilderSkia for calculating the gfx::Path for web-renderer. Differential Revision: http...
diff --git a/style/values/specified/svg_path.rs b/style/values/specified/svg_path.rs index 4f49029b5..9a94af6a8 100644 --- a/style/values/specified/svg_path.rs +++ b/style/values/specified/svg_path.rs @@ -46,7 +46,7 @@ impl SVGPathData { /// Create a normalized copy of this path by converting each relative ...
1
7
4
2f20b42c3962b09eed6bfa947005bf629f8c1d17
Boris Chiou
2019-10-31T21:35:05
Bug 1429305 - Use serde to serialize LengthPercentage and StyleRayFunction. r=emilio We need to pass these two types into the compositor, so we need a better way to serialize these rust types. We use serde and bincode to serialize/deserialize them, and use ByteBuf to pass the &[u8] data through IPC. We define StyleVec...
diff --git a/style/Cargo.toml b/style/Cargo.toml index 7f3bbd83c..626c9ee43 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -16,7 +16,7 @@ path = "lib.rs" doctest = false [features] -gecko = ["nsstring", "style_traits/gecko", "fallible/known_system_malloc", "bindgen", "regex", "toml"] +gecko = ["nsstring", ...
9
19
9
e3d3c62888ac79dd9c7a533caf4e1c5c84881f37
Daniel Varga
2019-10-30T08:17:29
Backed out changeset ec25a8482342 (bug 1592389) for mochitest failure at layout/style/test/test_value_computation.html. On a CLOSED TREE
diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs index 01e5890d0..acad33830 100644 --- a/style/values/specified/color.rs +++ b/style/values/specified/color.rs @@ -119,10 +119,6 @@ pub enum SystemColor { Buttonshadow, Buttontext, Captiontext, - #[parse(aliases = "-moz-fiel...
1
2
4
c8b34a1fadcedd8b831c829397b6ff8f645d17d4
Emilio Cobos Álvarez
2019-10-26T11:37:33
Bug 1591297 - Remove -moz-binding, nsStyleDisplay::mBinding and similar. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D50556
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 97321fcbd..7783c7eeb 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -276,11 +276,6 @@ impl ComputedValuesInner { pub fn get_raw_visited_style(&self) -> &Option<RawOffsetArc<ComputedValues>> { ...
4
1
38
b7963ffbd855036eca724b1e9127117e929ee431
Emilio Cobos Álvarez
2019-10-25T12:19:21
Bug 1591297 - Remove some XBL code in the style system. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D50554
diff --git a/selectors/context.rs b/selectors/context.rs index d159891ff..44d586c8d 100644 --- a/selectors/context.rs +++ b/selectors/context.rs @@ -189,15 +189,6 @@ where } } - /// Override the quirks mode we're matching against. - /// - /// FIXME(emilio): This is a hack for XBL quirks-mode mi...
6
3
125
a07c2a9798217abadb536fdf682cac423bdd4ab3
Emilio Cobos Álvarez
2019-10-20T13:44:07
Bug 1588737 - Simplify media query code now that lifetimes are non-lexical. r=xidorn We can deindent and simplify a bunch of this code now. Differential Revision: https://phabricator.services.mozilla.com/D49509
diff --git a/style/media_queries/media_feature_expression.rs b/style/media_queries/media_feature_expression.rs index 2345a857b..6323a8254 100644 --- a/style/media_queries/media_feature_expression.rs +++ b/style/media_queries/media_feature_expression.rs @@ -244,7 +244,7 @@ fn consume_operation_or_colon(input: &mut Parse...
1
39
66
392d890765c7755314621c121c36fdb60c5dfbcc
Emilio Cobos Álvarez
2019-10-20T13:44:09
Bug 1588737 - Remove useless conditional compilation. r=xidorn Servo doesn't use this flag or -webkit- prefixed media queries, so no point in doing this conditionally. Differential Revision: https://phabricator.services.mozilla.com/D49508
diff --git a/style/media_queries/media_feature_expression.rs b/style/media_queries/media_feature_expression.rs index 5bebf35d0..2345a857b 100644 --- a/style/media_queries/media_feature_expression.rs +++ b/style/media_queries/media_feature_expression.rs @@ -303,12 +303,9 @@ impl MediaFeatureExpression { let...
1
3
6
5aa90a0ac70d4cf64294a0e98135232924b00ea7
Emilio Cobos Álvarez
2019-10-20T13:43:57
Bug 1588737 - Remove layout.css.prefixes.device-pixel-ratio-webkit. r=dholbert There's no effort to disable it any time soon, so I don't think it's useful to keep the pref around. Differential Revision: https://phabricator.services.mozilla.com/D49507
diff --git a/style/media_queries/media_feature_expression.rs b/style/media_queries/media_feature_expression.rs index 7fee093f8..5bebf35d0 100644 --- a/style/media_queries/media_feature_expression.rs +++ b/style/media_queries/media_feature_expression.rs @@ -243,9 +243,6 @@ fn consume_operation_or_colon(input: &mut Parse...
1
0
3
163333345f2b4079a1fc021dbb1f7aa81da0a96c
Emilio Cobos Álvarez
2019-10-20T13:44:16
Bug 1588737 - Hide -moz-touch-enabled media query in Nightly and Early Beta. r=xidorn This is effectively superseded by the hover / any-hover media queries, which actually are standard, and is also causing trouble in the wild. Not even the browser fronted uses it, so we should be able to just remove it everywhere at ...
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index ce084c9d1..e3de8dbfa 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -598,8 +598,7 @@ lazy_static! { atom!("device-pixel-ratio"), AllowsRanges::Yes, Evaluator::Float(...
3
18
10
ba4a2e1208c5402891edef9250c52825e2296945
Emilio Cobos Álvarez
2019-10-17T00:51:54
Bug 1548718 - Support multiple parts in ::part() selectors. r=boris Differential Revision: https://phabricator.services.mozilla.com/D48753
diff --git a/selectors/matching.rs b/selectors/matching.rs index 45acc13e7..49b7f3dbd 100644 --- a/selectors/matching.rs +++ b/selectors/matching.rs @@ -667,7 +667,7 @@ where match *selector { Component::Combinator(_) => unreachable!(), - Component::Part(ref part) => element.is_part(part), + ...
3
30
15
515e0f6281363ca4f86b2ec08e82126f21b77c1d
Emilio Cobos Álvarez
2019-10-15T12:40:14
Bug 1588743 - Remove old scroll-snap implementation, and scroll snapping prefs. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D49267
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index a75504be1..852b5eee4 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -454,7 +454,6 @@ ${helpers.predefined_type( "ScrollSnapAlign", "computed::ScrollSnapAlign:...
5
0
9
4026513c3c16c58b6489c26a4c422aa6c571babc
Coroiu Cristina
2019-10-15T12:35:50
Backed out changeset 1a951477dca5 (bug 1588743) for xpcshell failures at devtools/shared/tests/unit/test_css-properties-db.js on a CLOSED TREE
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 852b5eee4..a75504be1 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -454,6 +454,7 @@ ${helpers.predefined_type( "ScrollSnapAlign", "computed::ScrollSnapAlign:...
5
9
0
164d464d168af22dc542f3eb7396e098cd961110
Cameron McCormack
2019-10-09T10:44:29
Bug 1587235 - Report missing include filename in ServoBindings.toml. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D48625
diff --git a/style/build_gecko.rs b/style/build_gecko.rs index 86d2098d0..a502b7d45 100644 --- a/style/build_gecko.rs +++ b/style/build_gecko.rs @@ -109,7 +109,10 @@ fn add_headers_recursively(path: PathBuf, added_paths: &mut HashSet<PathBuf>) { fn add_include(name: &str) -> String { let mut added_paths = ADDED...
1
4
1
c2dfc0943255a73df79f7dc1be68240277455928
Emilio Cobos Álvarez
2019-10-10T09:44:19
Bug 1587368 - Revert ccov bustage workaround now that builds have been updated. Differential Revision: https://phabricator.services.mozilla.com/D48814
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 364fe8bde..a75504be1 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -53,7 +53,7 @@ ${helpers.single_keyword( > impl computed_value::T { pub fn is_absolutely_posi...
2
2
2
ca8dc284211caee68a8ec02de19f9e1891ded0e5
Emilio Cobos Álvarez
2019-10-09T20:22:05
Bug 1587468 - Update num_derive to 0.3. r=boris Differential Revision: https://phabricator.services.mozilla.com/D48731
diff --git a/style/Cargo.toml b/style/Cargo.toml index 5a7685f45..fbb2ff87f 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -55,7 +55,7 @@ nsstring = {path = "../../../xpcom/rust/nsstring/", optional = true} num_cpus = {version = "1.1.0"} num-integer = "0.1" num-traits = "0.2" -num-derive = "0.2" +num-derive...
1
1
1
616f026a6cf3bb27c08dfd504bdfabbfba15ad2e
Emilio Cobos Álvarez
2019-10-09T16:39:03
Bug 1587368 - follow-up: Unbust some ccov builds that are still using old Rust. a=shlindi MANUAL PUSH: bustage
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index a75504be1..364fe8bde 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -53,7 +53,7 @@ ${helpers.single_keyword( > impl computed_value::T { pub fn is_absolutely_posi...
2
2
2
2fe743fd333a7aa3f6b2b7889dba22facc65c52c
Emilio Cobos Álvarez
2019-10-09T11:34:07
Bug 1587368 - Stop using -oldsyn bindgen version now that we pull newer syn and proc_macro versions anyway. MANUAL PUSH: Cherry-picking upstream stuff, with reviewers that are not on phabricator.
diff --git a/style/Cargo.toml b/style/Cargo.toml index 60a37c8b4..5a7685f45 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -85,7 +85,7 @@ void = "1.0.2" [build-dependencies] lazy_static = "1" log = "0.4" -bindgen = {version = "0.51.1-oldsyn", optional = true, default-features = false} +bindgen = {version = ...
1
1
1
30cff922418aa5a94bfd0a9278e0917aa1e27ea0
Emilio Cobos Álvarez
2019-10-09T11:06:02
Bug 1587368 - Fix servo build.
diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs index d9f9d69ae..5266ed783 100644 --- a/style/properties/cascade.rs +++ b/style/properties/cascade.rs @@ -374,6 +374,7 @@ fn should_ignore_declaration_when_ignoring_document_colors( // In the future, if/when we remove the backplate pref...
3
7
3
83e5259b9144f99cd6517e7d42b94871a2e0c9b1
Emilio Cobos Álvarez
2019-10-09T10:54:35
Bug 1587368 - Rustfmt recent changes.
diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs index e2b959431..9bc9573bf 100644 --- a/style/gecko/conversions.rs +++ b/style/gecko/conversions.rs @@ -42,7 +42,7 @@ impl nsStyleImage { image_rect.left, ); } - } + ...
9
61
50
19df3934d5c48d40559071f771bebc160c804b3d
Emilio Cobos Álvarez
2019-10-09T10:51:41
Bug 1587368 - Cherry-pick updates towards syn 1. From: https://github.com/servo/servo/pull/24308
diff --git a/derive_common/Cargo.toml b/derive_common/Cargo.toml index a9b478ecd..411219810 100644 --- a/derive_common/Cargo.toml +++ b/derive_common/Cargo.toml @@ -9,8 +9,8 @@ publish = false path = "lib.rs" [dependencies] -darling = "0.9" -proc-macro2 = "0.4" -quote = "0.6" -syn = { version = "0.15", features = [...
7
22
23
a70228fcd4383c6ff77707f982f80073f8508159
Emilio Cobos Álvarez
2019-10-07T13:45:43
Bug 1587368 - Use consistent naming and shared code for out-of-flow stuff. r=nox Use the functions introduced in ee17eedf3a857f27ce2b6b775574a3a455df8aa3.
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 2fd692298..a75504be1 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -53,10 +53,7 @@ ${helpers.single_keyword( > impl computed_value::T { pub fn is_absolutely_pos...
3
12
17
bcdbb2160e51b9581dfc258a03cc5a1814973d21
Anthony Ramine
2019-09-27T11:24:49
Bug 1587368 - servo: Update html5ever to 0.24. r=emilio
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 0272c3b61..ab8879ea8 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -41,7 +41,7 @@ smallvec = "0.6" string_cache = { version = "0.7", optional = true } thin-slice = "0.1.0" time = { version = "0.1.17", optional = true...
2
3
3
cf9be9d9eee903778533b3dd47c48920ba49b455
Simon Sapin
2019-09-27T04:37:54
Bug 1587368 - servo: WebIDL codegen: Replace cmake with a single Python script. r=emilio When playing around with Cargo’s new timing visualization: https://internals.rust-lang.org/t/exploring-crate-graph-build-times-with-cargo-build-ztimings/10975/21 … I was surprised to see the `script` crate’s build script take 76 ...
diff --git a/style/build.rs b/style/build.rs index 83d996da1..4477e648a 100644 --- a/style/build.rs +++ b/style/build.rs @@ -27,52 +27,28 @@ mod build_gecko { pub fn generate() {} } -#[cfg(windows)] -fn find_python() -> String { - if Command::new("python2.7.exe") - .arg("--version") - .output()...
1
21
45
542c5348e86a49991a7abfada3626b3482d7acdc
Simon Sapin
2019-09-25T13:11:00
Bug 1587368 - servo: Fix error message for invalid combination of style crate feature flags. r=emilio Instead of ``cannot find value `engine` in this scope`` https://github.com/servo/servo/issues/24284
diff --git a/style/build.rs b/style/build.rs index 20b3bf5c7..83d996da1 100644 --- a/style/build.rs +++ b/style/build.rs @@ -75,7 +75,7 @@ lazy_static! { pub static ref PYTHON: String = env::var("PYTHON").ok().unwrap_or_else(find_python); } -fn generate_properties() { +fn generate_properties(engine: &str) { ...
1
15
23
1550901f5cfae47989074c9883fb86ce185e0f3b
Anthony Ramine
2019-09-19T09:58:07
Bug 1587368 - servo: Uncomment more stuff related to box construction. r=emilio
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 4dcc43aec..2fd692298 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -42,15 +42,24 @@ ${helpers.single_keyword( spec="Internal (not web-exposed)", )} -${helpers....
2
25
9
f284cdd4614d51c54da097480b6d075789ac7bae
Brendan Dahl
2019-10-08T23:52:26
Bug 1510785 - Add way to disable XBL in servo. r=emilio Adds a feature "moz_xbl" that when disabled causes the XBL code in servo to be stubbed out. Depends on D45613 Differential Revision: https://phabricator.services.mozilla.com/D45614
diff --git a/style/Cargo.toml b/style/Cargo.toml index 688c6065c..0ced22018 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -25,6 +25,7 @@ servo-layout-2020 = [] gecko_debug = [] gecko_refcount_logging = [] gecko_profiler = [] +moz_xbl = [] [dependencies] app_units = "0.7" diff --git a/style/gecko/wrappe...
2
33
1
ae9c336ef2dd1346f6a9382d3ad5defe785668bf
Brian Birtles
2019-10-08T01:27:29
Bug 1586643 - Don't make visibility additive; r=boris As per discussion here: https://github.com/web-platform-tests/wpt/pull/19160 This property type does not have a procedure for addition defined so it should not be additive. Differential Revision: https://phabricator.services.mozilla.com/D48454
diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs index 8bccd5a0b..c81e186a1 100644 --- a/style/properties/helpers/animated_properties.mako.rs +++ b/style/properties/helpers/animated_properties.mako.rs @@ -768,17 +768,22 @@ animated_list_impl!(<T> f...
1
13
8
4c8568108df2a6c4a08ea93556081bef312a987d
Savo
2019-10-04T10:34:28
Bug 1586068 - Replace #define NS_STYLE_FLEX_WRAP with enum class. r=emilio MANUAL PUSH: Rebasing contributor patch. Differential Revision: https://phabricator.services.mozilla.com/D48166
diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs index a63f7637d..680b6117c 100644 --- a/style/properties/longhands/position.mako.rs +++ b/style/properties/longhands/position.mako.rs @@ -91,6 +91,7 @@ ${helpers.single_keyword( extra_prefixes="webkit", anim...
1
1
0
1381bad62eb2aa01690759b5da83254e49cd1d2e
Morgan Reschenberg
2019-10-04T16:44:49
Bug 1539212: Add readability backplate for all elements containing text when HCM or a11y theme is active. r=dholbert,mattwoodrow,Jamie Differential Revision: https://phabricator.services.mozilla.com/D42979
diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs index da95840a0..d9f9d69ae 100644 --- a/style/properties/cascade.rs +++ b/style/properties/cascade.rs @@ -362,9 +362,19 @@ fn should_ignore_declaration_when_ignoring_document_colors( // Treat background-color a bit differently. If the specifie...
1
10
0
fe0586e199776147b9bb86d10c933c90491af8c2
Emilio Cobos Álvarez
2019-10-01T21:44:41
Bug 1583736 - Don't allow negative radii in radial gradients. r=boris Mostly renaming for clarity, as the gradient parsing code is a bit hairy. This also changes -webkit- gradients, which is, I think, the right thing to do (otherwise I need to give up on the type system and sprinkle parse_non_negatives around, which ...
diff --git a/style/values/computed/image.rs b/style/values/computed/image.rs index 67b432d5f..82fda5e4f 100644 --- a/style/values/computed/image.rs +++ b/style/values/computed/image.rs @@ -10,7 +10,7 @@ use crate::values::computed::position::Position; use crate::values::computed::url::ComputedImageUrl; use crate::va...
5
61
46
735846297bff0139c1ac5e5a5ea9ad86e148c674
Boris Chiou
2019-09-30T21:52:30
Bug 1510486 - Set WillChangeBits::TRANSFORM for individual transform. r=hiro We always check StyleWillChangeBits_TRANSFORM bit together with a transform-like property set, so using WillChangeBits::TRANSFORM bit to represent all transform-like properties is ok. However, it seems the new test case works well even if we...
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index cec3f4092..fd4ff6f8b 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1153,7 +1153,9 @@ bitflags! { fn change_bits_for_longhand(longhand: LonghandId) -> WillChangeBits { let mut flags = match longhan...
1
3
1
48c40e8c621e4d7442b8d619c37b6f327043eb71
Mats Palmgren
2019-09-30T17:32:52
Bug 1581106 part 3 - [css-grid-2] Implement 'repeat(auto-fill, <line-names>)' in subgridded axis. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D46895
diff --git a/style/values/generics/grid.rs b/style/values/generics/grid.rs index 29f634d10..807136d98 100644 --- a/style/values/generics/grid.rs +++ b/style/values/generics/grid.rs @@ -646,11 +646,8 @@ impl Parse for LineNameList { if let Ok((mut names_list, count)) = repeat_parse_result { ...
1
4
5
5221cda23a086ee36f150572a258ef22dd2d784e
Emilio Cobos Álvarez
2019-09-25T09:50:10
Bug 1583471 - Don't pull new syn / quote / etc. dependencies just yet. r=bbouvier Transition to syn 1.0 is ongoing, but these take a long time to build. Hopefully we already patch coreaudio-sys manually so all the crates dependent on bindgen are effectively in-tree. I published v0.51.1-oldsyn to avoid pulling all th...
diff --git a/style/Cargo.toml b/style/Cargo.toml index da73adec9..688c6065c 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -84,7 +84,7 @@ void = "1.0.2" [build-dependencies] lazy_static = "1" log = "0.4" -bindgen = {version = "0.51.1", optional = true, default-features = false} +bindgen = {version = "0.51.1...
1
1
1
6584c38c645c92480917102eda85966cf5545a23
Benjamin Bouvier
2019-09-25T09:50:10
Bug 1583471: Update bindgen to 0.51.1 througout the tree; r=emilio Differential Revision: https://phabricator.services.mozilla.com/D46962
diff --git a/style/Cargo.toml b/style/Cargo.toml index c698658c0..da73adec9 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -84,7 +84,7 @@ void = "1.0.2" [build-dependencies] lazy_static = "1" log = "0.4" -bindgen = {version = "0.51", optional = true, default-features = false} +bindgen = {version = "0.51.1",...
1
1
1
89d7123e870f7e2bfb342c1c09e088ac72afc9dc
Emilio Cobos Álvarez
2019-09-23T19:08:22
Bug 1579585 - Use fallible allocation for stylesheet invalidation. r=jwatt If the sets get too big we cannot allocate anything else, we'll just empty them and invalidate the whole document. Differential Revision: https://phabricator.services.mozilla.com/D46828
diff --git a/hashglobe/src/hash_set.rs b/hashglobe/src/hash_set.rs index 694e01c46..ef373ae37 100644 --- a/hashglobe/src/hash_set.rs +++ b/hashglobe/src/hash_set.rs @@ -17,6 +17,8 @@ use std::ops::{BitAnd, BitOr, BitXor, Sub}; use super::hash_map::{self, HashMap, Keys, RandomState}; use super::Recover; +use crate::...
2
26
9
a41ef925d0fb68cd0b3adb038f8f188e4fd3206f
Brian Birtles
2019-09-23T02:07:56
Bug 1576866 - Make various border-image-* properties interpolable; r=emilio Differential Revision: https://phabricator.services.mozilla.com/D46724
diff --git a/style/properties/longhands/border.mako.rs b/style/properties/longhands/border.mako.rs index 4098a9420..80e95ae84 100644 --- a/style/properties/longhands/border.mako.rs +++ b/style/properties/longhands/border.mako.rs @@ -126,7 +126,7 @@ ${helpers.predefined_type( initial_value="generics::rect::Rect::al...
4
23
4
960033a71bde3dda6152dd1c7df45157c54d3779
Brian Birtles
2019-09-23T02:07:16
Bug 1576866 - Parse '0' as a number for border-image-width; r=emilio As per CSS Values & Units: "However, if a 0 could be parsed as either a <number> or a <length> in a property (such as line-height), it must parse as a <number>." (https://drafts.csswg.org/css-values-4/#lengths) Differential Revision: https://phabr...
diff --git a/style/values/generics/border.rs b/style/values/generics/border.rs index f36062ce3..755a368a9 100644 --- a/style/values/generics/border.rs +++ b/style/values/generics/border.rs @@ -16,6 +16,7 @@ use style_traits::{CssWriter, ToCss}; Copy, Debug, MallocSizeOf, + Parse, PartialEq, ...
2
6
20
65831ffa5bdd3adf1bd8c42ffa2958398cc6d908
Emilio Cobos Álvarez
2019-09-21T12:18:39
Bug 1582814 - Let the CSS use counter prefs be independent. r=boris * Let layout.css.use-counters.enabled be independent from the unimplemented property counters. * Always count in the style system (that is, always create Document::mStyleUseCounters), so that the warning from bug 1582374 works irrespective ...
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index a0f97f41b..1bfde165e 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -1821,16 +1821,6 @@ impl CountedUnknownProperty { } } -#[cfg(feature = "gecko")] -fn is_counted_unknown_...
1
2
14
8adc05388df01a6814ac2c23adcae6386470c0b8
Emilio Cobos Álvarez
2019-09-20T05:02:57
Bug 1582627 - Always serialize aspect-ratio and font shorthand with spaces around the slash. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D46568
diff --git a/style/media_queries/media_feature_expression.rs b/style/media_queries/media_feature_expression.rs index 1eef9e57e..d4124450d 100644 --- a/style/media_queries/media_feature_expression.rs +++ b/style/media_queries/media_feature_expression.rs @@ -36,7 +36,7 @@ impl ToCss for AspectRatio { W: fmt::Wri...
2
2
2
dae0ac9eb3435a4f0691a271a00ec889d4da1c5c
Bogdan Tara
2019-09-20T00:59:03
Backed out changeset 928b755ef57b (bug 1539212) for backplate-bg-image-006.html failures
diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs index d9f9d69ae..da95840a0 100644 --- a/style/properties/cascade.rs +++ b/style/properties/cascade.rs @@ -362,19 +362,9 @@ fn should_ignore_declaration_when_ignoring_document_colors( // Treat background-color a bit differently. If the specifie...
1
0
10
750dc31fc94092dd3a32b19704addbd4ff5274b9
Morgan Reschenberg
2019-09-19T21:25:12
Bug 1539212: Add readability backplate for all elements containing text when HCM or a11y theme is active. r=dholbert,mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D42979
diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs index da95840a0..d9f9d69ae 100644 --- a/style/properties/cascade.rs +++ b/style/properties/cascade.rs @@ -362,9 +362,19 @@ fn should_ignore_declaration_when_ignoring_document_colors( // Treat background-color a bit differently. If the specifie...
1
10
0
fe2f4dd41238fe6571dce86bb4f69e10689feb29
Daniel Holbert
2019-09-19T03:58:53
Bug 1580012: In css 'display' blockification codepath, leave -moz-box alone and promote -moz-inline-box to -moz-box (if a new pref is set). r=emilio This is in the interests of allowing the frontend team to experiment with switching from XUL grid to CSS grid, without inadvertently changing the display values for the g...
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 3e18a23d9..cec3f4092 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -393,6 +393,20 @@ impl Display { }; Display::from3(DisplayOutside::Block, inside, self.is_list_item())...
1
14
0
0459e96fb8a63f08bc459a363700605317a4c8fb
Ting-Yu Lin
2019-09-19T02:37:14
Bug 1582224 - Split SIDEWAYS bit in WritingMode. r=jfkthame,emilio Currently, there's no way to tell whether the SIDEWAYS bit is set from `writing-mode:sideways-*` or `writing-mode:vertical-*; text-orientation:sideways;`. To be able to tell them apart, split SIDEWAYS bits into VERTICAL_SIDEWAYS and TEXT_SIDEWAYS. This...
diff --git a/style/logical_geometry.rs b/style/logical_geometry.rs index dd912da4a..cad7e1d00 100644 --- a/style/logical_geometry.rs +++ b/style/logical_geometry.rs @@ -50,16 +50,22 @@ bitflags!( const LINE_INVERTED = 1 << 3; /// direction is rtl. const RTL = 1 << 4; - /// Horizontal t...
1
16
10
dbc60ea562bc90c1828b3c2ea49efd63526b3e06
Emilio Cobos Álvarez
2019-09-19T00:20:04
Bug 1578661 - Report counted unknown properties as well. r=boris Differential Revision: https://phabricator.services.mozilla.com/D44717
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index a1b4cedcf..a0f97f41b 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -1793,7 +1793,7 @@ impl ToCss for PropertyId { } /// The counted unknown property list which is used for css...
1
1
1