commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
d623a03a7fc569977a205865db9b060912c3e7f4
Cosmin Sabou
2019-09-18T22:50:03
Backed out 10 changesets (bug 1578661) for linting failures on layout/style/ServoCSSPropList.py. CLOSED TREE Backed out changeset b1b5393b1099 (bug 1578661) Backed out changeset b87eebb0cf6e (bug 1578661) Backed out changeset 6ba2ee45f26e (bug 1578661) Backed out changeset 4a1d45160d60 (bug 1578661) Backed out changes...
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index a0f97f41b..a1b4cedcf 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -1793,7 +1793,7 @@ impl ToCss for PropertyId { } /// The counted unknown property list which is used for css...
1
1
1
472d6c85eed6351a46b31ade002f92488e7334eb
Andreea Pavel
2019-09-18T15:09:30
Backed out 10 changesets (bug 1578661) for lints failure at ServoCSSPropList.cpp on a CLOSED TREE Backed out changeset ed3c619100e7 (bug 1578661) Backed out changeset 027514a2eaf6 (bug 1578661) Backed out changeset f2e228282b20 (bug 1578661) Backed out changeset 67c36136dce7 (bug 1578661) Backed out changeset 2280b27c...
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index a0f97f41b..a1b4cedcf 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -1793,7 +1793,7 @@ impl ToCss for PropertyId { } /// The counted unknown property list which is used for css...
1
1
1
c9e5ff545446b624180715b2f89cee9719d423c3
Andreea Pavel
2019-09-18T10:53:34
Backed out 9 changesets (bug 1578661) for lints failure at ServoCSSPropList.py a=backout Backed out changeset d16463e5698c (bug 1578661) Backed out changeset c6d64ac858ba (bug 1578661) Backed out changeset db306f1467f7 (bug 1578661) Backed out changeset 273535aab82d (bug 1578661) Backed out changeset f643262a8c25 (bug...
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index a0f97f41b..a1b4cedcf 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -1793,7 +1793,7 @@ impl ToCss for PropertyId { } /// The counted unknown property list which is used for css...
1
1
1
8d0d7c089b188974f4bbd68182950d1f25a5f562
Boris Chiou
2019-09-16T23:24:48
Bug 1480665 - Support ray() in offset-path and make it animatable. r=emilio,birtles 1. Add `generics::motion::OffsetPath`, and use specified `Angle` and computed `Angle` to define specified `OffsetPath` and computed `OffsetPath`. 2. Add `ray` function into `OffsetPath`. We also tweak the degree from 150deg to 135d...
diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs index 5b777e890..e2b959431 100644 --- a/style/gecko/conversions.rs +++ b/style/gecko/conversions.rs @@ -42,7 +42,7 @@ impl nsStyleImage { image_rect.left, ); } - }, + ...
5
172
53
be43a3ce648da0df7f403f5b00b78ebaa1a9301f
Brindusan Cristian
2019-09-16T21:01:04
Backed out changeset f5b8fba989b4 (bug 1539212) for reftest failures on backplate-bg-image-001.html. CLOSED TREE
diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs index d9f9d69ae..da95840a0 100644 --- a/style/properties/cascade.rs +++ b/style/properties/cascade.rs @@ -362,19 +362,9 @@ fn should_ignore_declaration_when_ignoring_document_colors( // Treat background-color a bit differently. If the specifie...
1
0
10
b847a9413bc65695ddd1ba278c40113a9f5ec46f
Emilio Cobos Álvarez
2019-09-16T00:22:44
Bug 1315892 - Add a comment quoting the spec. r=me MANUAL PUSH: Contributor didn't manage to add author information to lando + comment only follow-up.
diff --git a/style/logical_geometry.rs b/style/logical_geometry.rs index c1e01216d..dd912da4a 100644 --- a/style/logical_geometry.rs +++ b/style/logical_geometry.rs @@ -140,6 +140,13 @@ impl WritingMode { TextOrientation::Mixed => {}, TextOrientation::Upright => { ...
1
7
0
bc33988fef8cdf4dbadb77435b405245dfc78ba9
fantasai
2019-09-16T00:19:43
Bug 1315892 - 'text-orientation: upright' forces used 'direction' to LTR. r=jfkthame
diff --git a/style/logical_geometry.rs b/style/logical_geometry.rs index 38ffb25a7..c1e01216d 100644 --- a/style/logical_geometry.rs +++ b/style/logical_geometry.rs @@ -140,6 +140,8 @@ impl WritingMode { TextOrientation::Mixed => {}, TextOrientation::Upright => { ...
1
2
0
599e3779a265645061be2ced76ea2d04d998801f
Bastien Orivel
2019-09-12T21:46:21
Bug 1580908 - Part 7: Update serde_bytes to 0.11. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D45716
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 3de67f45a..0272c3b61 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -34,7 +34,7 @@ hyper_serde = { version = "0.11", optional = true } keyboard-types = {version = "0.4.3", optional = true} selectors = { path = "../sele...
1
1
1
1dfda522c70589d0f30d32ce353448a69ed1e692
Emilio Cobos Álvarez
2019-09-12T21:09:39
Bug 1580963 - Cherry-pick style changes from servo's victor import. https://github.com/servo/servo/pull/24165 Differential Revision: https://phabricator.services.mozilla.com/D45740
diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs index 4f8794bc7..9f274917b 100644 --- a/style/style_adjuster.rs +++ b/style/style_adjuster.rs @@ -12,6 +12,7 @@ use crate::properties::longhands::float::computed_value::T as Float; use crate::properties::longhands::overflow_x::computed_value::T as Overflow...
4
195
17
ec0a052b794755cdf5612971ec8af7040800aa25
Emilio Cobos Álvarez
2019-09-12T21:09:27
Bug 1580963 - Cherry-pick some servo changes from a rustc upgrade. This cherry-picks from Servo commit 98e4a53b724. Differential Revision: https://phabricator.services.mozilla.com/D45738
diff --git a/style/stylesheets/viewport_rule.rs b/style/stylesheets/viewport_rule.rs index 8cc858f7a..7d0881e33 100644 --- a/style/stylesheets/viewport_rule.rs +++ b/style/stylesheets/viewport_rule.rs @@ -291,15 +291,18 @@ impl<'a, 'b, 'i> DeclarationParser<'i> for ViewportRuleParser<'a, 'b> { ) -> Result<Vec<View...
1
16
7
b45a99e669d11b29fda22ff018fc4df0154b9a60
Emilio Cobos Álvarez
2019-09-12T08:14:44
Bug 1577139 - Remove LengthPercentage::was_calc. r=heycam There should not be any behavior change between specifying a percentage using % or calc(%) per the resolution of https://github.com/w3c/csswg-drafts/issues/3482. Differential Revision: https://phabricator.services.mozilla.com/D43747
diff --git a/style/values/animated/length.rs b/style/values/animated/length.rs index 73957618c..04a0844db 100644 --- a/style/values/animated/length.rs +++ b/style/values/animated/length.rs @@ -26,13 +26,10 @@ impl Animate for LengthPercentage { .animate(&other.unclamped_length(), procedure)?; let ...
3
23
42
a179ada9e34275dd64facc2e93efc59ad1d420fa
Emilio Cobos Álvarez
2019-09-09T22:39:46
Bug 1577439 - Shutdown Servo's thread-pool in leak-checking builds, leak the atom table elsewhere. r=bholley Differential Revision: https://phabricator.services.mozilla.com/D44217
diff --git a/selectors/bloom.rs b/selectors/bloom.rs index c4b19e59e..98461d1ba 100644 --- a/selectors/bloom.rs +++ b/selectors/bloom.rs @@ -64,7 +64,7 @@ pub type BloomFilter = CountingBloomFilter<BloomStorageU8>; /// Similarly, using a KeySize of 10 would lead to a 4% false /// positive rate for N == 100 and to qui...
4
70
18
2772d0d01805c44b1fea15cf096768c26c542988
Michael Woerister
2019-09-09T17:23:20
Bug 1577171 - Remove duplicated logic from Stylo's Gecko wrapper. r=emilio Stylo's Gecko wrapper duplicated some logic from the C++ side so that the Rust compiler would be able to optimize better. Now that we have xLTO, this kind of manual inlining should not be neccessary anymore. Differential Revision: https://phab...
diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs index 39e3678ee..e2ae42fcb 100644 --- a/style/gecko/wrapper.rs +++ b/style/gecko/wrapper.rs @@ -706,44 +706,6 @@ impl<'le> GeckoElement<'le> { !self.xbl_binding_with_content().is_none() } - /// This duplicates the logic in Gecko's virtual n...
1
2
48
b656ea4854af3bff3a0822b38580e516cef56798
Boris Chiou
2019-09-10T21:51:54
Bug 1574222 - Tweak the serialization of text-decoration. r=emilio We are trying to not serialize `text-decoration-line: none` if there are other non-default values for the longhands. Differential Revision: https://phabricator.services.mozilla.com/D44908
diff --git a/style/properties/shorthands/text.mako.rs b/style/properties/shorthands/text.mako.rs index 33b4a0748..77b15d9a7 100644 --- a/style/properties/shorthands/text.mako.rs +++ b/style/properties/shorthands/text.mako.rs @@ -74,25 +74,49 @@ impl<'a> ToCss for LonghandsToSerialize<'a> { fn to_css<W>...
1
34
10
9487815bcad7c44038852621d78c34c60a18de22
Cameron McCormack
2019-09-09T04:49:55
Bug 1578147 - Align the Rust and C++ representations of WritingMode. r=emilio,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D44412
diff --git a/style/logical_geometry.rs b/style/logical_geometry.rs index 3817c12dc..38ffb25a7 100644 --- a/style/logical_geometry.rs +++ b/style/logical_geometry.rs @@ -26,16 +26,48 @@ pub enum InlineBaseDirection { // TODO: improve the readability of the WritingMode serialization, refer to the Debug:fmt() bitflags!(...
2
81
25
cd2c065213625cff73d00c5bf729f327eeda0490
Gurzau Raul
2019-09-07T16:03:27
Backed out changeset a396ec8f44fd (bug 1577439) for failing valgrind-test on a CLOSED TREE.
diff --git a/selectors/bloom.rs b/selectors/bloom.rs index 98461d1ba..c4b19e59e 100644 --- a/selectors/bloom.rs +++ b/selectors/bloom.rs @@ -64,7 +64,7 @@ pub type BloomFilter = CountingBloomFilter<BloomStorageU8>; /// Similarly, using a KeySize of 10 would lead to a 4% false /// positive rate for N == 100 and to qui...
4
18
70
797b170aed9bc659c6de5ecfdffc8677bdb4adf7
Emilio Cobos Álvarez
2019-09-02T23:11:26
Bug 1578295 - Use cbindgen for counters. r=mats Differential Revision: https://phabricator.services.mozilla.com/D44403
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 526304d87..97321fcbd 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -2579,8 +2579,7 @@ clip-path ${impl_simple('column_rule_style', 'mColumnRuleStyle')} </%self:impl_trait> -<%self:impl_trait ...
3
17
65
24f5bdc4571aaf34d2efaf220ef678f50da0b8b6
Emilio Cobos Álvarez
2019-09-02T09:55:28
No bug - Add a comment about a Send bound that may look confusing. MANUAL PUSH: comment only, no bug
diff --git a/style/scoped_tls.rs b/style/scoped_tls.rs index b4eed7509..e1e5209a0 100644 --- a/style/scoped_tls.rs +++ b/style/scoped_tls.rs @@ -15,6 +15,9 @@ use std::ops::DerefMut; /// /// We use this on Servo to construct thread-local contexts, but clear them once /// we're done with restyling. +/// +/// Note tha...
1
3
0
350442b6df03de324bd960dcac63ea269c0cb06e
Razvan Maries
2019-09-01T00:41:33
Backed out changeset 42ebd8a50978 (bug 1577439) for causing perma leakcheck | tab process: negative leaks caught.
diff --git a/style/global_style_data.rs b/style/global_style_data.rs index ceac977ee..eff53078c 100644 --- a/style/global_style_data.rs +++ b/style/global_style_data.rs @@ -12,7 +12,6 @@ use crate::shared_lock::SharedRwLock; use crate::thread_state; use rayon; use std::env; -use parking_lot::{RwLock, RwLockReadGuard...
1
4
24
f82319f2873e92c84f89de00ef6f7ace82268f5e
Emilio Cobos Álvarez
2019-08-31T23:28:26
Bug 1577439 - Shutdown Servo's thread-pool in leak-checking builds, leak the atom table elsewhere. r=bholley Differential Revision: https://phabricator.services.mozilla.com/D44217
diff --git a/style/global_style_data.rs b/style/global_style_data.rs index eff53078c..ceac977ee 100644 --- a/style/global_style_data.rs +++ b/style/global_style_data.rs @@ -12,6 +12,7 @@ use crate::shared_lock::SharedRwLock; use crate::thread_state; use rayon; use std::env; +use parking_lot::{RwLock, RwLockReadGuard...
1
24
4
c9b97c02f5688ee16479ed50e952f160af0c2dc0
Emilio Cobos Álvarez
2019-08-30T14:35:34
Bug 1576229 - Account for user stylesheets for Shadow DOM invalidation. r=jwatt Differential Revision: https://phabricator.services.mozilla.com/D43992
diff --git a/style/invalidation/element/state_and_attributes.rs b/style/invalidation/element/state_and_attributes.rs index eccc5f60b..30521fb8c 100644 --- a/style/invalidation/element/state_and_attributes.rs +++ b/style/invalidation/element/state_and_attributes.rs @@ -16,7 +16,7 @@ use crate::invalidation::element::inv...
1
2
2
1f6f6b4ae26e1239a4673e778213cc95002a8248
Mats Palmgren
2019-08-30T00:15:37
Bug 1576821 - [css-lists-3] Make 'none' invalid as a <counter-style> in counter()/counters(). r=emilio CSSWG resolution: https://github.com/w3c/csswg-drafts/issues/4163#issuecomment-521331100 Spec: https://drafts.csswg.org/css-lists-3/#counter-functions Differential Revision: https://phabricator.services.mozilla.co...
diff --git a/style/gecko/values.rs b/style/gecko/values.rs index f0c998f8f..b31485345 100644 --- a/style/gecko/values.rs +++ b/style/gecko/values.rs @@ -8,7 +8,7 @@ use crate::counter_style::{Symbol, Symbols}; use crate::gecko_bindings::structs::CounterStylePtr; -use crate::values::generics::CounterStyleOrNone; +us...
7
63
63
0dcae88b3da7d02c5172f273a6e6c6896e9b36b1
Joel Olsson
2019-08-29T10:48:52
Bug 1565562: Media Query - Enable single <number> and <number>/<number> for <aspect-ratio>. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D41557
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index a80c486a6..ce084c9d1 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -104,7 +104,7 @@ where }; let size = get_size(device); - let value = AspectRatio(size.width.0 as u32, size.height.0 as u3...
3
32
23
01084e84c87dabccae0f36ddc62b12ad1ecbdd78
Emilio Cobos Álvarez
2019-08-26T23:18:46
Bug 1576703 - Update cbindgen. r=boris This cleans up the pattern of "Use a private dtor so that the helper functions do the right thing" by enabling it everywhere using: https://github.com/eqrion/cbindgen/pull/377 It also caught some uninitialized value issues. I think they're mostly harmless since we zero-initi...
diff --git a/style/values/computed/text.rs b/style/values/computed/text.rs index bdb2ac507..4cccd248d 100644 --- a/style/values/computed/text.rs +++ b/style/values/computed/text.rs @@ -198,8 +198,6 @@ impl TextDecorationsInEffect { } /// Computed value for the text-emphasis-style property -/// -/// cbindgen:derive-...
11
0
28
0075edfe73aec8dbff2f524ea1d9bbe945576225
Emilio Cobos Álvarez
2019-08-26T23:09:47
Bug 1576666 - Use cbindgen for clip / -moz-image-region. r=boris This also fixes some of the issues with -moz-image-region, where we just minted an auto out of the blue. Depends on D43472 Differential Revision: https://phabricator.services.mozilla.com/D43474
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 8de2861f2..f751e872f 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -2162,7 +2162,7 @@ fn static_assert() { </%self:impl_trait> <%self:impl_trait style_struct_name="List" - skip_l...
5
52
194
b37bfd1422053b90acb789a79ef811afd5d2df01
Emilio Cobos Álvarez
2019-08-26T20:09:19
Bug 1576666 - Remove old warning allow which is no longer relevant. r=boris -moz-appearance uses cbindgen since a long time ago. Differential Revision: https://phabricator.services.mozilla.com/D43472
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 773901441..8de2861f2 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -345,10 +345,7 @@ def set_gecko_property(ffi_name, expr): </%def> <%def name="impl_keyword_clone(ident, gecko_ffi_name, keyword,...
1
1
4
d52b16a92ed7e7c3777de9b86179aed09738898b
Emilio Cobos Álvarez
2019-08-26T09:58:53
Bug 1576587 - Rustfmt declaration_block.rs and glue.rs Differential Revision: https://phabricator.services.mozilla.com/D43400
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index 6078f6712..930d4400d 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -6,34 +6,36 @@ #![deny(missing_docs)] +use super::*; use crate::context::QuirksMode; -use cssparse...
1
257
226
d6bb8628fb9badd0189e51cf9003e0e52b7f620b
Emilio Cobos Álvarez
2019-08-21T20:02:13
Bug 1575608 - Simplify -x-span property. r=boris Differential Revision: https://phabricator.services.mozilla.com/D42914
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index dc0ceceef..773901441 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -2296,20 +2296,7 @@ fn static_assert() { </%self:impl_trait> -<%self:impl_trait style_struct_name="Table" skip_longhands="-x-sp...
6
3
61
3b763e70e8e75b5c7676565e61500a90d5bd79d7
Emilio Cobos Álvarez
2019-08-21T19:47:53
Bug 1575608 - Avoid manual paint-order glue code. r=boris Differential Revision: https://phabricator.services.mozilla.com/D42913
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index e8f2c521a..dc0ceceef 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -2599,18 +2599,7 @@ clip-path </%self:impl_trait> <%self:impl_trait style_struct_name="InheritedSVG" - skip_lon...
2
6
16
6ade23b00b488298b2965d67b56e5e68ce7fc775
Emilio Cobos Álvarez
2019-08-21T18:35:31
Bug 1575608 - Avoid some signed -> unsigned conversions for box-ordinal-group. r=dholbert This is consistent with the `order` property anyhow, and allows to simplify some code. Negatives are still not parsed, but rust uses a similar representation for all CSS <integer> values and so should C++. Differential Revision...
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 4fc461502..e8f2c521a 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -3040,19 +3040,7 @@ clip-path ${impl_simple_type_with_conversion("_moz_force_broken_image_icon", "mForceBrokenImageIcon")} </%...
1
1
13
d15c90c6ba930f51371be1c9795f539471129e16
Emilio Cobos Álvarez
2019-08-21T22:45:26
Bug 1575559 - Make font-variant-alternates use cbindgen. r=boris Differential Revision: https://phabricator.services.mozilla.com/D42859
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index ae252f46a..4fc461502 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -1247,6 +1247,8 @@ fn static_assert() { ${impl_simple_type_with_conversion("font_synthesis", "mFont.synthesis")} + ${imp...
3
18
130
1d80dcced2c74cdec04868e93dc6d3b711337289
Emilio Cobos Álvarez
2019-08-21T18:25:21
Bug 1575559 - Remove unused impl_coord_copy. r=boris Differential Revision: https://phabricator.services.mozilla.com/D42857
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index bd02a7ac9..ae252f46a 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -321,18 +321,6 @@ impl ${style_struct.gecko_struct_name} { } </%def> -<%def name="impl_coord_copy(ident, gecko_ffi_name)"> -...
1
0
12
ddc273d8fff731cfbda841b765d135bd8c8b3244
Mats Palmgren
2019-08-19T21:19:04
Bug 1574994 part 2 - Remove display:-moz-inline-grid/-moz-inline-stack. r=emilio Depends on D42551 Differential Revision: https://phabricator.services.mozilla.com/D42552
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index a9abd6249..ad703fa65 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -92,16 +92,12 @@ pub enum DisplayInside { #[cfg(feature = "gecko")] MozGrid, #[cfg(feature = "gecko")] - MozInlineGrid...
1
0
17
1714d2d83e0f2e14366955c3430b4fad7a87792d
Boris Chiou
2019-08-20T01:30:43
Bug 1574957 - Clamp negative values for font-size-adjust animations. r=hiro Differential Revision: https://phabricator.services.mozilla.com/D42586
diff --git a/style/properties/longhands/font.mako.rs b/style/properties/longhands/font.mako.rs index 148b6fe33..b4b2ab059 100644 --- a/style/properties/longhands/font.mako.rs +++ b/style/properties/longhands/font.mako.rs @@ -80,7 +80,7 @@ ${helpers.predefined_type( engines="gecko", initial_value="computed::Fo...
1
1
1
9c2d3fb0f5ec3c9c7abae4f23dc9463e79ce3e39
Dzmitry Malyshau
2019-08-19T21:28:51
Bug 1575008 - Update parking_lot dependency to 0.9.0 r=aosmond Updating parking_lot would allow us to avoid dependency duplication when WebGPU tree is vendored. Differential Revision: https://phabricator.services.mozilla.com/D42557
diff --git a/style/Cargo.toml b/style/Cargo.toml index 0dbd92f33..c698658c0 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -57,7 +57,7 @@ num-traits = "0.2" num-derive = "0.2" ordered-float = "1.0" owning_ref = "0.4" -parking_lot = "0.8" +parking_lot = "0.9" precomputed-hash = "0.1.1" rayon = "1" selecto...
1
1
1
dea6f6f4167743a455fb5fa4c8ede37cbd20b146
Emilio Cobos Álvarez
2019-08-19T19:59:48
Bug 1572738 - Don't clamp font-size calc() factors too early. r=manishearth These two bugs (bug 1572738 and bug 1572451) are stylo regressions. When font-family changes, we try to recompute the font-size with a length / percentage combinations in case the generic family changes, so the user preferences are kept. Whe...
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 1f3e862df..bd02a7ac9 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -1146,7 +1146,7 @@ fn static_assert() { } pub fn set_font_size(&mut self, v: FontSize) { - use crate::values::gen...
8
159
170
2c2e2fa48c20d47618e4d3300b14b74a91c2950a
Mats Palmgren
2019-08-16T06:30:24
Bug 1574060 - Implement layout for 'display: flow-root list-item'. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D42087
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index f481b940e..a9abd6249 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -627,6 +627,7 @@ impl SpecifiedValueInfo for Display { "contents", "flex", "flow-root", + ...
1
1
0
5d75e5f26184076b1a43072ebe27b959db1bfe6d
Emilio Cobos Álvarez
2019-08-15T13:31:47
Bug 1574148 - Update itertools in the style crate. It was updated in Servo long ago. Differential Revision: https://phabricator.services.mozilla.com/D42131
diff --git a/style/Cargo.toml b/style/Cargo.toml index d00232fbf..0dbd92f33 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -43,7 +43,7 @@ fxhash = "0.2" hashglobe = { path = "../hashglobe" } html5ever = {version = "0.23", optional = true} indexmap = "1.0" -itertools = "0.7.6" +itertools = "0.8" itoa = "0.4...
1
1
1
2f23484094a61910674730062a52a1b1ecdbc4a7
Emilio Cobos Álvarez
2019-08-15T13:31:44
Bug 1574148 - Fix Servo build and unify display representation. Differential Revision: https://phabricator.services.mozilla.com/D42130
diff --git a/style/lib.rs b/style/lib.rs index 31356d911..35070b0f2 100644 --- a/style/lib.rs +++ b/style/lib.rs @@ -91,6 +91,7 @@ extern crate servo_config; extern crate servo_url; extern crate smallbitvec; extern crate smallvec; +#[cfg(feature = "gecko")] extern crate static_prefs; #[cfg(feature = "servo")] ext...
4
117
159
0cd2ef3776f47161403e5bdf9093053506d15040
Emilio Cobos Álvarez
2019-08-15T13:31:37
Bug 1574148 - Fix formatting of recent changes. Differential Revision: https://phabricator.services.mozilla.com/D42129
diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs index 9bea09b45..aa849ceee 100644 --- a/style/gecko/pseudo_element.rs +++ b/style/gecko/pseudo_element.rs @@ -187,8 +187,9 @@ impl PseudoElement { PseudoElement::FirstLine => PropertyFlags::APPLIES_TO_FIRST_LINE, Pseudo...
8
156
160
2cc5740d02872721c3e95072314e9a8d659eadb1
Emilio Cobos Álvarez
2019-08-15T13:31:36
Bug 1574148 - Cherry-pick some Servo build/formatting fixes. Differential Revision: https://phabricator.services.mozilla.com/D42128
diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs index 8f20b6cb2..18f5c466d 100644 --- a/style/properties/longhands/inherited_text.mako.rs +++ b/style/properties/longhands/inherited_text.mako.rs @@ -195,7 +195,7 @@ ${helpers.predefined_type( spec="h...
3
5
4
ee7e345f59ee56dea4b5da9ddf210060e417ca19
Mats Palmgren
2019-08-14T14:38:31
Bug 1557825 part 1 - Implement 'display:block ruby'. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D40211
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 3e4b3f573..015153c76 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -266,12 +266,12 @@ impl Display { /// Returns whether this `display` value is one of the types for ruby. pub fn is_ruby_type(&...
1
9
47
1f01bd7cec07a86ddab11d6c819053eae1623f88
Mats Palmgren
2019-08-14T14:37:03
Bug 1105868 part 3 - Implement 'inline list-item' and 'inline flow-root list-item' values for the 'display' property. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D39832
diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs index 38b908a16..747b945e7 100644 --- a/style/style_adjuster.rs +++ b/style/style_adjuster.rs @@ -8,6 +8,8 @@ use crate::dom::TElement; use crate::properties::computed_value_flags::ComputedValueFlags; use crate::properties::longhands::display::computed_v...
2
84
90
00c5eb5f71090717bd2621bb5ca675dd72854fba
Mats Palmgren
2019-08-14T14:35:56
Bug 1569825 - Hide some 'display' values in devtools auto-completion that we want to discourage authors from using. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D39810
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 8c369da1d..76ebecd1b 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -748,19 +748,6 @@ impl SpecifiedValueInfo for Display { "table-row-group", "-webkit-box", "-webkit-inli...
1
0
13
a81879811d7b681097a05dbc51cb472e369cf25e
Mats Palmgren
2019-08-14T14:34:37
Bug 1038294 part 12 - Implement multi-keyword 'display' values for Gecko. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D39764
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 346dc8f93..8c369da1d 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -16,6 +16,7 @@ use crate::values::specified::{AllowQuirks, Number}; use crate::values::{CustomIdent, KeyframesName}; use crate::Atom; ...
1
564
104
6efaf694cf7f10ca6dc2a00147e5ed17b1f62724
Charlie Marlow
2019-08-13T17:43:25
Bug 1558929: adding from-font support to text-underline-offset and text-decoration-thickness r=emilio Differential Revision: https://phabricator.services.mozilla.com/D41476
diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs index 341afd262..8f20b6cb2 100644 --- a/style/properties/longhands/inherited_text.mako.rs +++ b/style/properties/longhands/inherited_text.mako.rs @@ -382,8 +382,8 @@ ${helpers.single_keyword( // text unde...
7
59
9
a34b75fc88225fa138663f5a716b5be5bc829f92
Emilio Cobos Álvarez
2019-08-13T19:26:02
Bug 1573106 - Use shortest serialization for computed text-emphasis-style too. r=boris Differential Revision: https://phabricator.services.mozilla.com/D41513
diff --git a/style/values/computed/text.rs b/style/values/computed/text.rs index 94073306e..d2a619a3a 100644 --- a/style/values/computed/text.rs +++ b/style/values/computed/text.rs @@ -203,6 +203,7 @@ impl TextDecorationsInEffect { pub enum TextEmphasisStyle { /// [ <fill> || <shape> ] Keyword { + #[c...
1
1
0
f31044020341b4fcc5eebf34c038274f28484331
Narcis Beleuzu
2019-08-13T02:18:44
Backed out changeset 0836c998795b (bug 1573106) for wpt failures on accumulation-per-property.html . CLOSED TREE
diff --git a/style/values/computed/text.rs b/style/values/computed/text.rs index d2a619a3a..94073306e 100644 --- a/style/values/computed/text.rs +++ b/style/values/computed/text.rs @@ -203,7 +203,6 @@ impl TextDecorationsInEffect { pub enum TextEmphasisStyle { /// [ <fill> || <shape> ] Keyword { - #[c...
1
0
1
6d70c8739aed2a7e29109a8aa5f91dab806b843d
Emilio Cobos Álvarez
2019-08-11T20:47:15
Bug 1572805 - Adjust comment grammar as suggested by xidorn. r=comment-only MANUAL PUSH: Comment only post-review fixup DONTBUILD
diff --git a/style/values/specified/text.rs b/style/values/specified/text.rs index f78071544..d72b13904 100644 --- a/style/values/specified/text.rs +++ b/style/values/specified/text.rs @@ -785,7 +785,7 @@ impl Parse for TextEmphasisStyle { return Err(input.new_custom_error(StyleParseErrorKind::UnspecifiedE...
1
1
1
de06b78991a063d7baaf59259d1127c5b9a77679
Emilio Cobos Álvarez
2019-08-10T20:20:27
Bug 1572805 - Undo last minute serialization change so that I can land it with tests. r=me MANUAL PUSH: bustage, some WPTs need updating.
diff --git a/style/values/computed/text.rs b/style/values/computed/text.rs index d2a619a3a..94073306e 100644 --- a/style/values/computed/text.rs +++ b/style/values/computed/text.rs @@ -203,7 +203,6 @@ impl TextDecorationsInEffect { pub enum TextEmphasisStyle { /// [ <fill> || <shape> ] Keyword { - #[c...
1
0
1
6a97d9cca72157443d4e0d6ca5ab6e0b0d1e36a2
Emilio Cobos Álvarez
2019-08-10T18:11:31
Bug 1572805 - Use cbindgen for text-emphasis-style. r=boris I sent https://github.com/eqrion/cbindgen/pull/377 since I got sick of copy-pasting the private default constructor stuff :) Differential Revision: https://phabricator.services.mozilla.com/D41419
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 680dd3408..1f3e862df 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -2578,97 +2578,15 @@ fn static_assert() { <%self:impl_trait style_struct_name="InheritedText" - skip_longhands...
3
6
127
1dff96947ae87263f5817c50a1f3e309d56d9f10
Emilio Cobos Álvarez
2019-08-10T18:15:37
Bug 1572805 - Simplify text-emphasis-style. r=boris,xidorn Differential Revision: https://phabricator.services.mozilla.com/D41418
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 068ddfae9..680dd3408 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -2602,12 +2602,13 @@ fn static_assert() { self.clear_text_emphasis_style_if_string(); let (te, s) = match v { ...
4
82
85
6c6c8c4cb2c9371f69536003741076d75b73c2e6
Daniel Varga
2019-08-10T18:07:03
Backed out 2 changesets (bug 1572805) for build-rusttests failure. On a CLOSED TREE Backed out changeset 849ca4b3f9de (bug 1572805) Backed out changeset 81b56d76505a (bug 1572805)
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 1f3e862df..068ddfae9 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -2578,15 +2578,97 @@ fn static_assert() { <%self:impl_trait style_struct_name="InheritedText" - skip_longhands...
3
203
80
bb83d4a6e80ed4deb61d7a95b8bf7022a688db32
Emilio Cobos Álvarez
2019-08-10T16:39:19
Bug 1553545 - Remove now-incorrect comment. r=comment-only MANUAL PUSH: Comment-only fixup to an inbound patch. DONTBUILD
diff --git a/style/values/generics/font.rs b/style/values/generics/font.rs index d622026ff..eb8eac191 100644 --- a/style/values/generics/font.rs +++ b/style/values/generics/font.rs @@ -253,8 +253,6 @@ pub enum KeywordSize { XLarge, #[css(keyword = "xx-large")] XXLarge, - // This is not a real font key...
1
0
2
d8bcb4f036759047f9bb96728f43ce0d1f8644ff
Joel Olsson
2019-08-10T03:23:42
Bug 1553545 - Enable font-size:xxx-large. r=emilio MANUAL PUSH: Manually fixed up contributor's patch stack to squash the two patches in the bug. Differential Revision: https://phabricator.services.mozilla.com/D41240
diff --git a/style/values/generics/font.rs b/style/values/generics/font.rs index 59907ff79..d622026ff 100644 --- a/style/values/generics/font.rs +++ b/style/values/generics/font.rs @@ -255,7 +255,7 @@ pub enum KeywordSize { XXLarge, // This is not a real font keyword and will not parse // HTML font-size ...
1
1
1
f5c0cf701b69df30fb7c9a8d3015638997f02c82
Emilio Cobos Álvarez
2019-08-10T16:23:52
Bug 1572805 - Simplify text-emphasis-style. r=boris,xidorn Differential Revision: https://phabricator.services.mozilla.com/D41418
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 068ddfae9..680dd3408 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -2602,12 +2602,13 @@ fn static_assert() { self.clear_text_emphasis_style_if_string(); let (te, s) = match v { ...
3
82
84
8cc6eff18e618417c53561d2c980263aca8edc7c
Nicholas Nethercote
2019-08-07T22:58:55
Bug 1563555 - Use `static_prefs::pref!` in Stylo. r=emilio It's much nicer. One nice thing about this is that the new code is subject to the existing threadedness checking, which identified that several of these should be atomic because they're accessed off the main thread. Differential Revision: https://phabricator...
diff --git a/style/Cargo.toml b/style/Cargo.toml index 90b2d69be..d00232fbf 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -67,6 +67,7 @@ servo_atoms = {path = "../atoms", optional = true} servo_config = {path = "../config", optional = true} smallbitvec = "2.3.0" smallvec = "0.6.6" +static_prefs = { path = ...
17
26
60
c13289a5f5446b3ff287ba43d78e218b56e1fa85
Cosmin Sabou
2019-08-07T09:09:13
Backed out 2 changesets (bug 1563555) for causing marionette failures on test_profile_management.py. Backed out changeset 2559f5ddf8e0 (bug 1563555) Backed out changeset e3c86ffa168c (bug 1563555)
diff --git a/style/Cargo.toml b/style/Cargo.toml index d00232fbf..90b2d69be 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -67,7 +67,6 @@ servo_atoms = {path = "../atoms", optional = true} servo_config = {path = "../config", optional = true} smallbitvec = "2.3.0" smallvec = "0.6.6" -static_prefs = { path = ...
17
60
26
a13f3b0a1472680f3c43b7c31b514aff56819e11
Boris Chiou
2019-08-06T18:32:16
Bug 1339672 - Support multiple track sizes for grid-auto-{columns|rows}. r=emilio,mats Support `<track-size>+` on the implicit track sizing properties, grid-auto-columns and grid-auto-rows. Differential Revision: https://phabricator.services.mozilla.com/D38408
diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs index b2e8acaf6..a63f7637d 100644 --- a/style/properties/longhands/position.mako.rs +++ b/style/properties/longhands/position.mako.rs @@ -357,16 +357,13 @@ ${helpers.predefined_type( )} % endfor - /...
6
76
22
c7f0eb05e4b9d3ed611ea4383df9be5c28fbe363
Emilio Cobos Álvarez
2019-08-06T12:08:47
Bug 1571537 - Don't write manual glue code for the order property. r=boris The default code works just as well. Differential Revision: https://phabricator.services.mozilla.com/D40698
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index 9f8aa772d..068ddfae9 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -973,7 +973,7 @@ fn static_assert() { <% skip_position_longhands = " ".join(x.ident for x in SIDES) %> <%self:impl_trait style_s...
1
1
11
ead253b91300eb98c7fe7c7d8108d0cf22469ddc
Emilio Cobos Álvarez
2019-08-05T20:49:14
Bug 1519958 - followup: Fix bustage in 32-bit builds and rust unit tests. r=me CLOSED TREE
diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs index f5d1a1d1c..b2e8acaf6 100644 --- a/style/properties/longhands/position.mako.rs +++ b/style/properties/longhands/position.mako.rs @@ -375,7 +375,6 @@ ${helpers.predefined_type( "specified::GenericGridTemp...
1
0
1
1e7f364feee77a60963d0e773103f8a181511685
Emilio Cobos Álvarez
2019-07-01T23:35:50
Bug 1519958 - Improve stack size of grid templates and re-enable style struct size assertions disabled in the previous patch. r=boris This re-enables the assertion which was disabled on the previous patch by doing a bit of boxing around. Differential Revision: https://phabricator.services.mozilla.com/D36599
diff --git a/style/properties/shorthands/position.mako.rs b/style/properties/shorthands/position.mako.rs index ef59f6d03..4b7397719 100644 --- a/style/properties/shorthands/position.mako.rs +++ b/style/properties/shorthands/position.mako.rs @@ -353,8 +353,11 @@ GenericGridTemplateComponent::None ...
3
10
6
780ec33c29baf185e1da5c2e39b7fe5ff26296e7
Emilio Cobos Álvarez
2019-06-28T11:27:19
Bug 1519958 - Refactor grid types to preserve repeat() at computed value time and use cbindgen. r=mats,boris I'm _really_ sorry for the size of the patch. I tried to do this in two steps but it was a lot of work and pretty ugly. This patch makes us use cbindgen for grid-template-{rows,columns}, in order to: * Make ...
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index f00e5aafc..9f8aa772d 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -976,8 +976,7 @@ fn static_assert() { skip_longhands="${skip_position_longhands} order ...
8
142
505
49b9872a97f3c64fad4ae104b55da4491998b002
Emilio Cobos Álvarez
2019-08-03T10:05:14
Bug 1571151 - Expand and simplify a macro that's not very useful. r=boris Skip whitespace upfront rather than on each individual branch. The only difference in behavior is that we would've consumed some extra whitespace in the error case, but I don't think that matters at all. We were consuming some extra whitespace ...
diff --git a/style/values/specified/svg_path.rs b/style/values/specified/svg_path.rs index 7d40cae1f..4f49029b5 100644 --- a/style/values/specified/svg_path.rs +++ b/style/values/specified/svg_path.rs @@ -631,30 +631,20 @@ impl<'a> PathParser<'a> { } else { IsAbsolute::No }; -...
1
15
25
6409b461a2c07b67a29747f60369d9b7c85c1646
Emilio Cobos Álvarez
2019-08-03T10:01:58
Bug 1571151 - Deindent a bit SVG path parsing code. r=boris None cannot be returned, since we just called peek() and it returned something. Differential Revision: https://phabricator.services.mozilla.com/D40538
diff --git a/style/values/specified/svg_path.rs b/style/values/specified/svg_path.rs index e5282e0a1..7d40cae1f 100644 --- a/style/values/specified/svg_path.rs +++ b/style/values/specified/svg_path.rs @@ -625,40 +625,36 @@ impl<'a> PathParser<'a> { break; } - match self.chars....
1
28
32
d6d1c1a44dcf0a58f602f54fdaad0f5192867c6e
Emilio Cobos Álvarez
2019-08-01T11:22:53
Bug 1404140 - Remove the GetCSNeedsLayoutFlush flag, as it is unneeded now. r=heycam MANUAL PUSH: Would need to reorder the stack manually (https://bugzilla.mozilla.org/show_bug.cgi?id=1481539) Differential Revision: https://phabricator.services.mozilla.com/D40300
diff --git a/style/properties/longhands/border.mako.rs b/style/properties/longhands/border.mako.rs index 6ac01034b..4098a9420 100644 --- a/style/properties/longhands/border.mako.rs +++ b/style/properties/longhands/border.mako.rs @@ -58,7 +58,6 @@ animation_value_type="NonNegativeLength", logical=is_lo...
8
2
18
669af6861a4e6aacc1a0b1c36cb184044b54b828
Boris Chiou
2019-08-02T20:12:40
Bug 1559231 - Make offset-anchor animatable. r=birtles Per the spec issue, https://github.com/w3c/csswg-drafts/issues/3482, we update the wpt to keep the percentage in `calc()` for `offset-anchor`. Differential Revision: https://phabricator.services.mozilla.com/D39552
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 3dd1e419b..cc464740e 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -427,7 +427,7 @@ ${helpers.predefined_type( "PositionOrAuto", "computed::PositionOrAuto::a...
2
4
1
241853889f4d172df53b441589a7a6c3dabab2fa
Boris Chiou
2019-08-02T20:12:38
Bug 1559231 - Support offset-anchor. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D39432
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 40075a650..3dd1e419b 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -421,6 +421,19 @@ ${helpers.predefined_type( servo_restyle_damage="reflow_out_of_flow" )} +/...
6
57
2
72111b33e86b954ee036d6063a01c7f335588767
Brindusan Cristian
2019-08-02T18:55:37
Backed out 2 changesets (bug 1559231) for rusttests build bustages. CLOSED TREE Backed out changeset d47d9f4bf9a9 (bug 1559231) Backed out changeset 50f92d01c47a (bug 1559231)
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 904d1640f..40075a650 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -421,18 +421,6 @@ ${helpers.predefined_type( servo_restyle_damage="reflow_out_of_flow" )} -/...
6
2
59
31e206b4652d92501173abe9ece59381802b9113
Boris Chiou
2019-08-02T00:47:09
Bug 1559231 - Make offset-anchor animatable. r=birtles Per the spec issue, https://github.com/w3c/csswg-drafts/issues/3482, we update the wpt to keep the percentage in `calc()` for `offset-anchor`. Differential Revision: https://phabricator.services.mozilla.com/D39552
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 6089cc8f4..904d1640f 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -427,7 +427,7 @@ ${helpers.predefined_type( "PositionOrAuto", "computed::PositionOrAuto::a...
2
4
1
658feab70de86b5a2d8be92c50752cf2a98fc653
Boris Chiou
2019-08-02T00:43:11
Bug 1559231 - Support offset-anchor. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D39432
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 40075a650..6089cc8f4 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -421,6 +421,18 @@ ${helpers.predefined_type( servo_restyle_damage="reflow_out_of_flow" )} +/...
6
56
2
5dddf74d232b32a0053fe371e2ddf814c132fc76
Emilio Cobos Álvarez
2019-08-01T15:29:01
Bug 1570721 - Move the overrides to a separate struct in nsPresContext. r=heycam Just so that we can keep track of these together. Differential Revision: https://phabricator.services.mozilla.com/D40247
diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs index 876634735..ecd9115a4 100644 --- a/style/gecko/media_queries.rs +++ b/style/gecko/media_queries.rs @@ -213,11 +213,11 @@ impl Device { None => return MediaType::screen(), }; - // Gecko allows emulating random me...
1
6
7
1b7602ad3feccaf69b1ec7c2630c822b9fb00d56
Emilio Cobos Álvarez
2019-08-01T16:15:04
Bug 1570721 - Simplify emulated medium setup in nsPresContext. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D40246
diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs index 556470569..876634735 100644 --- a/style/gecko/media_queries.rs +++ b/style/gecko/media_queries.rs @@ -213,12 +213,11 @@ impl Device { None => return MediaType::screen(), }; - // Gecko allows emulating random me...
1
3
4
804717e0ea668b85803999923121993354e9d7ea
Emilio Cobos Álvarez
2019-07-31T18:18:21
Bug 1570182 - Fix cursor prefixed aliases to do the right thing. r=boris This was an oversight in bug 1520154. We kept the -moz- version in the specified value but not the computed value. That's a very peculiar way of making aliases work. This makes them work consistently as many other aliases instead. Also, add an ...
diff --git a/style/values/specified/ui.rs b/style/values/specified/ui.rs index 0cc20d960..46272b2ae 100644 --- a/style/values/specified/ui.rs +++ b/style/values/specified/ui.rs @@ -199,7 +199,9 @@ pub enum CursorKind { Move, NoDrop, NotAllowed, + #[parse(aliases = "-moz-grab")] Grab, + #[parse...
1
4
8
08e2a53260fb30a7847d29b4d2ac2628fddca7de
Emilio Cobos Álvarez
2019-07-30T09:56:07
Bug 1569911 - Fix some issues when importing the previous patches in Gecko. MANUAL PUSH: Manual cherry-pick of Servo code.
diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs index afef80aa8..f00e5aafc 100644 --- a/style/properties/gecko.mako.rs +++ b/style/properties/gecko.mako.rs @@ -1825,7 +1825,7 @@ fn static_assert() { for (gecko, servo) in self.gecko.mAnimations.iter_mut().take(input_len as usize)....
2
3
3
1a9547e9f21ea7bd2913fb5f3d6e800d7265c671
Mike Hommey
2019-07-27T00:36:18
Bug 1569331 - Update bindgen to 0.51. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D39580
diff --git a/style/Cargo.toml b/style/Cargo.toml index da64c7d7c..550a267a3 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -81,7 +81,7 @@ void = "1.0.2" [build-dependencies] lazy_static = "1" log = "0.4" -bindgen = {version = "0.49", optional = true, default-features = false} +bindgen = {version = "0.51", o...
1
1
1
6e164832101904fb32a26fe178592d364988dc55
Boris Chiou
2019-07-24T21:37:22
Bug 1568615 - Accept percentage for shape-image-threshold. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D39241
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 133960d03..6f2c5ab3c 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -603,8 +603,9 @@ ${helpers.predefined_type( // The spec issue for the parse_method: https://githu...
2
3
13
1b20944fa145b34aba7932624cf32082b9b6b215
Emilio Cobos Álvarez
2019-07-24T11:42:45
Bug 1568446 - followup: Properly refcount-log UniqueArcs created with new_uninitialized().
diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs index 1567fd3d4..ad4489c10 100644 --- a/servo_arc/lib.rs +++ b/servo_arc/lib.rs @@ -125,6 +125,12 @@ impl<T> UniqueArc<T> { .unwrap_or_else(|| alloc::handle_alloc_error(layout)) .cast::<ArcInner<mem::MaybeUninit<T>>>(); ptr:...
1
6
0
c21b9e06a70ebba110b7af05525413715f66c44a
Emilio Cobos Álvarez
2019-07-24T10:20:43
Bug 1568446 - Don't insta-free in UniqueArc::assume_init. r=SimonSapin Also sent to https://github.com/servo/servo/pull/23843.
diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs index 6e86ea7b5..1567fd3d4 100644 --- a/servo_arc/lib.rs +++ b/servo_arc/lib.rs @@ -144,7 +144,7 @@ impl<T> UniqueArc<mem::MaybeUninit<T>> { #[inline] pub unsafe fn assume_init(this: Self) -> UniqueArc<T> { UniqueArc(Arc { - p: this.0.p.cast...
1
1
1
b6ec1603da8811abf4b74dd48de9343e78ef77dc
Simon Sapin
2019-07-06T16:16:30
Bug 1568446 - Replace uses of mem::uninitialized with MaybeUninit. r=emilio Cherry-picked from: https://github.com/servo/servo/pull/23824
diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs index 089aa60f0..6e86ea7b5 100644 --- a/servo_arc/lib.rs +++ b/servo_arc/lib.rs @@ -52,25 +52,6 @@ use std::sync::atomic; use std::sync::atomic::Ordering::{Acquire, Relaxed, Release}; use std::{isize, usize}; -// Private macro to get the offset of a struct field in b...
9
60
68
975fbb3de2b64f06817583e3a9388f0048773318
Simon Sapin
2019-07-06T16:15:53
Bug 1568446 - Add UniqueArc::new_uninit, UniqueArc::assume_init. r=emilio Cherry-picked from: https://github.com/servo/servo/pull/23824
diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs index 53c7d7aaa..089aa60f0 100644 --- a/servo_arc/lib.rs +++ b/servo_arc/lib.rs @@ -34,7 +34,7 @@ use nodrop::NoDrop; #[cfg(feature = "servo")] use serde::{Deserialize, Serialize}; use stable_deref_trait::{CloneStableDeref, StableDeref}; -use std::alloc::Layout; +use ...
1
29
1
72653f8d98dd363b479c6ade0393d2bdc5707c84
Mihai Alexandru Michis
2019-07-24T09:38:39
Backed out 2 changesets (bug 1568446) for causing multiple failures Backed out changeset 6e7267a5b743 (bug 1568446) Backed out changeset 4c30e18adac2 (bug 1568446)
diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs index 6e86ea7b5..53c7d7aaa 100644 --- a/servo_arc/lib.rs +++ b/servo_arc/lib.rs @@ -34,7 +34,7 @@ use nodrop::NoDrop; #[cfg(feature = "servo")] use serde::{Deserialize, Serialize}; use stable_deref_trait::{CloneStableDeref, StableDeref}; -use std::alloc::{self, Layout...
9
69
89
587c3f26360939d019997ab0a79dcb4bd43a23ea
Emilio Cobos Álvarez
2019-07-22T10:53:09
Bug 1568083 - Fix a warning in Servo builds by moving a macro to where it's used.
diff --git a/style/stylesheets/mod.rs b/style/stylesheets/mod.rs index 6c30de2c3..91d1bbc30 100644 --- a/style/stylesheets/mod.rs +++ b/style/stylesheets/mod.rs @@ -178,25 +178,25 @@ impl UrlExtraData { } } -macro_rules! define_debug_struct { - ($struct_name:ident, $gecko_class:ident, $debug_fn:ident) => { -...
1
15
15
7335ed3b4caa3bdb803da375211725ff006fd1c2
Patrick Walton
2019-06-04T22:21:58
Bug 1568083 - WebRender units are no longer reexported. r=emilio This cherry-picks changes from Servo PR #23516.
diff --git a/style_traits/lib.rs b/style_traits/lib.rs index 4e89f6fdf..b2dcc8431 100644 --- a/style_traits/lib.rs +++ b/style_traits/lib.rs @@ -36,7 +36,7 @@ extern crate to_shmem_derive; #[cfg(feature = "servo")] extern crate webrender_api; #[cfg(feature = "servo")] -pub use webrender_api::DevicePixel; +pub use we...
1
1
1
5f8177ffece3975f10ed9b9ce81a2c62aa41418a
Emilio Cobos Álvarez
2019-07-22T10:18:06
Bug 1568083 - Servo doesn't still support backdrop-filter. This is a previous build fix that I forgot to sync to Gecko.
diff --git a/style/properties/longhands/effects.mako.rs b/style/properties/longhands/effects.mako.rs index 40a709f03..01b5abfd4 100644 --- a/style/properties/longhands/effects.mako.rs +++ b/style/properties/longhands/effects.mako.rs @@ -68,6 +68,7 @@ ${helpers.predefined_type( flags="CREATES_STACKING_CONTEXT FIXPO...
1
1
0
38c4b3cc6a8ca0e4a1865236564479a4a02100eb
Bastien Orivel
2019-06-24T21:04:13
Bug 1568083 - Update rayon in the style system. r=emilio As a bonus this also removes one version of crossbeam-utils This cherry-picks Servo PR #23630.
diff --git a/style/driver.rs b/style/driver.rs index 6b05bc852..88ec93387 100644 --- a/style/driver.rs +++ b/style/driver.rs @@ -133,7 +133,12 @@ pub fn traverse_dom<E, D>( let root_opaque = root.as_node().opaque(); let drain = discovered.drain(..); pool.install(|| { -...
3
10
11
4b4bd52ca62598854efdc567c2a4cd4f9d7e1830
longsonr
2019-07-19T11:57:54
Bug 1353164 Part 2 - Change dominant-baseline from reset to inherit r=heycam
diff --git a/style/properties/longhands/inherited_svg.mako.rs b/style/properties/longhands/inherited_svg.mako.rs index faa806a60..5becde6d2 100644 --- a/style/properties/longhands/inherited_svg.mako.rs +++ b/style/properties/longhands/inherited_svg.mako.rs @@ -10,6 +10,15 @@ // Section 10 - Text +${helpers.single_...
2
9
9
032fffe5d861a06210794d5a7a7a4c187d4eac09
Bogdan Tara
2019-07-19T13:50:35
Backed out changeset 5c8a0f41b86d (bug 1353164) for test_css-properties-db.js failures CLOSED TREE
diff --git a/style/properties/longhands/inherited_svg.mako.rs b/style/properties/longhands/inherited_svg.mako.rs index 5becde6d2..faa806a60 100644 --- a/style/properties/longhands/inherited_svg.mako.rs +++ b/style/properties/longhands/inherited_svg.mako.rs @@ -10,15 +10,6 @@ // Section 10 - Text -${helpers.single_...
2
9
9
04b13d74c6dfd17dd8ed535efeec64aa11f5e9c3
Emilio Cobos Álvarez
2019-07-18T23:39:14
Bug 1567333 - Remove the ability to build Gecko without the bindgen feature. r=heycam This is not used for anything, as far as I can tell. Differential Revision: https://phabricator.services.mozilla.com/D38584
diff --git a/style/Cargo.toml b/style/Cargo.toml index ddde0da3b..78f9a446a 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -16,8 +16,7 @@ path = "lib.rs" doctest = false [features] -gecko = ["nsstring", "style_traits/gecko", "fallible/known_system_malloc"] -use_bindgen = ["bindgen", "regex", "toml"] +gecko...
3
348
401
9ba606c901c8206303377e6a12ab166c32fd84f8
Nicolas Silva
2019-07-18T20:54:16
Bug 1567241 - Update to euclid 0.20. r=kvark, emilio. Differential Revision: https://phabricator.services.mozilla.com/D38530
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 271461ad9..3de67f45a 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -27,7 +27,7 @@ servo = [ app_units = "0.7" crossbeam-channel = { version = "0.3", optional = true } cssparser = "0.25" -euclid = "0.19" +euclid = "0....
16
39
38
1449fd14c78580522f56a1fadfefb9954176db39
Emilio Cobos Álvarez
2019-07-16T15:42:08
Bug 1564366 - Update animations when a pseudo-element had animations but no longer has, and has been re-framed in the meantime. r=birtles This is the easy fix. The hard fix (outlined in the comment) would be nice, but I don't think this bug alone justifies it. Differential Revision: https://phabricator.services.mozi...
diff --git a/style/matching.rs b/style/matching.rs index dfc568509..2c6b16d96 100644 --- a/style/matching.rs +++ b/style/matching.rs @@ -240,16 +240,31 @@ trait PrivateMatchMethods: TElement { let new_box_style = new_style.get_box(); let new_style_specifies_animations = new_box_style.specifies_animati...
2
26
6
b370e6a35bd905608cf7d777352a8b042abc07d9
Thomas Nguyen
2019-07-16T15:03:40
Bug 1546334 - Modify URLExtraData rust debug to include referrerInfo r=heycam Differential Revision: https://phabricator.services.mozilla.com/D36475
diff --git a/style/gecko_bindings/sugar/refptr.rs b/style/gecko_bindings/sugar/refptr.rs index a141aef4e..e27b4a28c 100644 --- a/style/gecko_bindings/sugar/refptr.rs +++ b/style/gecko_bindings/sugar/refptr.rs @@ -303,6 +303,11 @@ impl_threadsafe_refcount!( bindings::Gecko_AddRefURLExtraDataArbitraryThread, bi...
2
19
7
a716103edd4ca81ae5adf5e1ff52ae0460220830
longsonr
2019-07-13T14:35:08
Bug 1353164 Part 1 - Remove dominant-baseline values that no longer exist r=heycam
diff --git a/style/properties/longhands/svg.mako.rs b/style/properties/longhands/svg.mako.rs index 429717c1b..d51bc5992 100644 --- a/style/properties/longhands/svg.mako.rs +++ b/style/properties/longhands/svg.mako.rs @@ -8,8 +8,8 @@ ${helpers.single_keyword( "dominant-baseline", - """auto use-script no-chang...
1
2
2
44ae7cc7b86aaa42e996d97f0d157bc752ca8c9f
Boris Chiou
2019-07-12T19:49:32
Bug 1562086 - Add percentage for opacity (i.e. <alpha-value>). r=emilio The following properties accept <alpha-value> [1], which is "<number> | <percentage>", so we update the parser, spec links, and their web-platform-tests. 1. opacity 2. flood-opacity 3. fill-opacity 4. stroke-opacity 5. stop-opacity 6. -moz-window-...
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 718ceaa34..133960d03 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -601,8 +601,10 @@ ${helpers.predefined_type( spec="https://drafts.csswg.org/css-will-change/#wi...
5
42
13
7c721ab29a43c50ac5e6e46a46afe525e5119a85
Emilio Cobos Álvarez
2019-07-11T23:07:20
Bug 1565214 - Set the property restrictions flags from the centralized list. r=boris Differential Revision: https://phabricator.services.mozilla.com/D37721
diff --git a/style/properties/longhands/background.mako.rs b/style/properties/longhands/background.mako.rs index cc416bc3a..7422c4b47 100644 --- a/style/properties/longhands/background.mako.rs +++ b/style/properties/longhands/background.mako.rs @@ -15,8 +15,7 @@ ${helpers.predefined_type( animation_value_type="Ani...
13
29
90
80f0072dacbcb461cbc61482c82cac3ade4c75fc
Emilio Cobos Álvarez
2019-07-11T23:06:59
Bug 1565214 - scroll-margin properties shouldn't apply to first-line / first-letter. r=boris From https://drafts.csswg.org/css-scroll-snap-1/#placement: > None of the properties in this module apply to the ::first-line and > ::first-letter pseudo-elements. Differential Revision: https://phabricator.services.mozilla....
diff --git a/style/properties/longhands/margin.mako.rs b/style/properties/longhands/margin.mako.rs index c3289c34b..effd355df 100644 --- a/style/properties/longhands/margin.mako.rs +++ b/style/properties/longhands/margin.mako.rs @@ -38,7 +38,6 @@ logical=side[1], logical_group="scroll-margin", ...
1
0
1
7d4d8a2d3f5f0422b5da5e54527cd2f839f16b14
Emilio Cobos Álvarez
2019-07-11T23:06:50
Bug 1565214 - Update spec link for font-variation-settings. r=boris It had got outdated. Differential Revision: https://phabricator.services.mozilla.com/D37718
diff --git a/style/properties/longhands/font.mako.rs b/style/properties/longhands/font.mako.rs index 0323b8921..df3e5e933 100644 --- a/style/properties/longhands/font.mako.rs +++ b/style/properties/longhands/font.mako.rs @@ -180,13 +180,6 @@ ${helpers.predefined_type( spec="https://drafts.csswg.org/css-fonts/#prop...
1
1
8
3f322bd6bec233c375659144818891a5ae231324
Emilio Cobos Álvarez
2019-07-11T23:06:41
Bug 1565214 - Don't apply property restrictions to pseudo-elements in UA stylesheets. r=boris And remove some of the ::placeholder and ::cue hacks where we need to use !important to make the property not apply for content but apply on UA sheets. The comment about the white-space property was wrong, we don't enforce i...
diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs index 1e362fb1b..3d64dde7e 100644 --- a/style/properties/cascade.rs +++ b/style/properties/cascade.rs @@ -153,7 +153,7 @@ where // longhands are only allowed if they have our // restriction flag set....
6
2
21
27ac6b499ca89967f5c931ecc4d2c009c9399963
Boris Chiou
2019-07-10T20:25:25
Bug 1559276 - Part 2: Retire the support for 3-valued syntax for position. r=emilio According to this resolved spec issue: https://github.com/w3c/csswg-drafts/issues/2140, we retire the 3-valued <position> on 1. `object-position` 2. `perspective-origin`, 3. `mask-position` 4. `circle()` and `ellipse()` , but still kee...
diff --git a/style/properties/shorthands/background.mako.rs b/style/properties/shorthands/background.mako.rs index af98342bf..7986201e4 100644 --- a/style/properties/shorthands/background.mako.rs +++ b/style/properties/shorthands/background.mako.rs @@ -15,7 +15,7 @@ use crate::properties::longhands::background_cli...
2
29
6
cfe88ff989440fc6d9b3f5469e46a730dabc246f
Jonathan Kew
2019-07-09T08:59:27
Bug 1421938 - Add an 'auto' value for the CSS 'quotes' property, and make it use language-dependent quote marks. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D36429
diff --git a/style/values/computed/list.rs b/style/values/computed/list.rs index bdcf62ba2..2ae377604 100644 --- a/style/values/computed/list.rs +++ b/style/values/computed/list.rs @@ -7,28 +7,12 @@ #[cfg(feature = "gecko")] pub use crate::values::specified::list::ListStyleType; pub use crate::values::specified::lis...
4
39
25