commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
01295fdc8eadc9a4aa0cedc82a40abfc3cdf32da | alwu | 2019-07-09T01:42:45 | Bug 1305732 - part5 : set CSS properties directly on '::cue'. r=heycam,emilio
According to the spec [1], we have to set those CSS properties on the root node, and then this root node would have a child node, background box [2], which would contain all other child nodes.
In our case, the background box is `cueDiv` [3]... | diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs
index 94ed265de..f14c485b8 100644
--- a/style/properties/longhands/inherited_box.mako.rs
+++ b/style/properties/longhands/inherited_box.mako.rs
@@ -29,6 +29,7 @@ ${helpers.single_keyword(
servo_pref="la... | 2 | 2 | 0 |
c505b92bae8d01fba5b4b0df6bbf13d0221b62e8 | shindli | 2019-07-08T23:52:38 | Backed out 5 changesets (bug 1421938) for bustages in /builds/worker/workspace/build/src/layout/base/nsQuoteList.cpp CLOSED TREE
Backed out changeset 4e25a6db1f5b (bug 1421938)
Backed out changeset 11a8f9bc0418 (bug 1421938)
Backed out changeset f27980997dc5 (bug 1421938)
Backed out changeset adb2e2714c14 (bug 1421938... | diff --git a/style/values/computed/list.rs b/style/values/computed/list.rs
index 2ae377604..bdcf62ba2 100644
--- a/style/values/computed/list.rs
+++ b/style/values/computed/list.rs
@@ -7,12 +7,28 @@
#[cfg(feature = "gecko")]
pub use crate::values::specified::list::ListStyleType;
pub use crate::values::specified::lis... | 4 | 25 | 39 |
bb0c23d050e0552e14ba53193481c9fb6d08cccb | shindli | 2019-07-08T20:09:34 | Backed out 5 changesets (bug 1421938) for causing a bustage in /builds/worker/workspace/build/src/intl/locale/cldr-quotes.inc:21:448 CLOSED TREE
Backed out changeset 3958f2af0e34 (bug 1421938)
Backed out changeset 89a0866d1aa0 (bug 1421938)
Backed out changeset f150702af11f (bug 1421938)
Backed out changeset b8ebd4d24... | diff --git a/style/values/computed/list.rs b/style/values/computed/list.rs
index 2ae377604..bdcf62ba2 100644
--- a/style/values/computed/list.rs
+++ b/style/values/computed/list.rs
@@ -7,12 +7,28 @@
#[cfg(feature = "gecko")]
pub use crate::values::specified::list::ListStyleType;
pub use crate::values::specified::lis... | 4 | 25 | 39 |
24ae5019e464ad4584e4065ebf47285988fc1b16 | Emilio Cobos Álvarez | 2019-07-08T10:58:20 | Bug 1564085 - Appease tidy. | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 6838114d3..11bd30136 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1097,7 +1097,9 @@ fn static_assert() {
TrackListValue::TrackSize(size) => size,
... | 1 | 3 | 1 |
b3b04637decde034d706c2e69ccbad4c2c4bf9e4 | Emilio Cobos Álvarez | 2019-07-08T10:56:47 | Bug 1564085 - Rustfmt recent changes. | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index c2e5dd65e..53c7d7aaa 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -314,11 +314,7 @@ impl<T: ?Sized> Arc<T> {
fn record_drop(&self) {
#[cfg(feature = "gecko_refcount_logging")]
unsafe {
- NS_LogDtor(
- self... | 4 | 3 | 8 |
04c7d9f97a97fa916fed5a6746a1124d4cce6427 | Emilio Cobos Álvarez | 2019-07-08T10:51:49 | Bug 1564085 - simplify some recently-added code. | diff --git a/style/values/generics/transform.rs b/style/values/generics/transform.rs
index 64fb1e254..f6fd80024 100644
--- a/style/values/generics/transform.rs
+++ b/style/values/generics/transform.rs
@@ -542,11 +542,7 @@ impl<T: ToMatrix> Transform<T> {
)
};
- let (m, is_3d) = match self... | 1 | 1 | 5 |
ef5ddf33aacd6c33bef4b7e85e57e676ad4ea9a2 | Kagami Sascha Rosylight | 2019-06-30T09:01:42 | Bug 1564085 - Add a f64 version of to_transform_3d_matrix. r=emilio
This is cherry-picked from https://github.com/servo/servo/pull/23665. | diff --git a/style/values/generics/transform.rs b/style/values/generics/transform.rs
index ba0e32086..64fb1e254 100644
--- a/style/values/generics/transform.rs
+++ b/style/values/generics/transform.rs
@@ -542,6 +542,19 @@ impl<T: ToMatrix> Transform<T> {
)
};
+ let (m, is_3d) = match self... | 1 | 14 | 1 |
28c172df9a0138bacee174fe39e91db45ddd1d68 | Emilio Cobos Álvarez | 2019-07-06T09:41:01 | No bug - Remove a map(From::from) statement that does literally nothing. r=trivial | diff --git a/style/values/specified/border.rs b/style/values/specified/border.rs
index 338b0d18c..6ac569f33 100644
--- a/style/values/specified/border.rs
+++ b/style/values/specified/border.rs
@@ -242,7 +242,7 @@ impl Parse for BorderSpacing {
input: &mut Parser<'i, 't>,
) -> Result<Self, ParseError<'i>> ... | 1 | 1 | 1 |
46626b377a94908a8ec4503219d39ccaa9eb138c | Emilio Cobos Álvarez | 2019-07-06T08:31:02 | Bug 1563315 - Use cbindgen for fill and stroke r=boris
Differential Revision: https://phabricator.services.mozilla.com/D36807 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 7bf558020..6838114d3 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -523,110 +523,6 @@ def set_gecko_property(ffi_name, expr):
}
</%def>
-<%def name="impl_svg_paint(ident, gecko_ffi_name)">
- ... | 5 | 33 | 129 |
e0caa35b2b65d9742c216006adb058dd7088a7fa | Emilio Cobos Álvarez | 2019-07-06T08:24:39 | Bug 1563315 - Simplify parsing and storage of SVG paint server fallback. r=boris
Depends on D36805
Differential Revision: https://phabricator.services.mozilla.com/D36806 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 09082c518..7bf558020 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -525,8 +525,8 @@ def set_gecko_property(ffi_name, expr):
<%def name="impl_svg_paint(ident, gecko_ffi_name)">
#[allow(non_sna... | 5 | 71 | 99 |
1a337a5e709ef046b896958f68d442a85be5836b | Emilio Cobos Álvarez | 2019-07-05T22:19:42 | Bug 1563315 - Use more compact and ffi-friendly types for some svg props. r=boris
No functional change yet.
Differential Revision: https://phabricator.services.mozilla.com/D36805 | diff --git a/style/values/animated/mod.rs b/style/values/animated/mod.rs
index 267ef0c8e..ea43d0111 100644
--- a/style/values/animated/mod.rs
+++ b/style/values/animated/mod.rs
@@ -447,17 +447,13 @@ where
}
}
-impl<T> ToAnimatedZero for Box<[T]>
+impl<T> ToAnimatedZero for crate::OwnedSlice<T>
where
T: To... | 4 | 16 | 14 |
a819a140cd4a2cfada520b86dfe43046ad7859ae | Emilio Cobos Álvarez | 2019-07-05T21:31:40 | Bug 1563484 - Apply text-only zoom to system fonts. r=dbaron
Differential Revision: https://phabricator.services.mozilla.com/D36893 | diff --git a/style/properties/longhands/font.mako.rs b/style/properties/longhands/font.mako.rs
index 098cb06b3..d65afad69 100644
--- a/style/properties/longhands/font.mako.rs
+++ b/style/properties/longhands/font.mako.rs
@@ -412,7 +412,7 @@ ${helpers.predefined_type(
is_system_font: true,
... | 1 | 1 | 1 |
d04bd7d14a9c35104a0d78818f611bc47130f361 | Emilio Cobos Álvarez | 2019-07-01T21:39:47 | Bug 1561283 - Don't optimize out recascading of children when becoming or stopping being display: contents. r=dholbert
Since they can change whether descendants get blockified.
Differential Revision: https://phabricator.services.mozilla.com/D35818 | diff --git a/style/matching.rs b/style/matching.rs
index b4b472ea1..c34ada24a 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -503,32 +503,35 @@ trait PrivateMatchMethods: TElement {
let old_display = old_values.get_box().clone_display();
let new_display = new_values.get_box().clone_display(... | 1 | 25 | 22 |
aa00e63574a40a32b169bea6819cabae47d90213 | Emilio Cobos Álvarez | 2019-06-29T19:44:35 | No bug - rustfmt recent changes. r=whitespace-only | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 26159c568..5b777e890 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -35,7 +35,12 @@ impl nsStyleImage {
// Set CropRect
let ref mut rect = *self.mCropRect.mPtr;
- ... | 9 | 62 | 23 |
3328211ebdc646b0da92e32ec117b825c9127d51 | Hugh Gallagher | 2019-06-28T16:10:13 | Bug 1560494 - In CounterStyleOrNone check if SymbolsType is symbolic and skip if it is. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D36235 | diff --git a/style/values/generics/mod.rs b/style/values/generics/mod.rs
index 9989feec0..343aad876 100644
--- a/style/values/generics/mod.rs
+++ b/style/values/generics/mod.rs
@@ -103,7 +103,12 @@ pub enum CounterStyleOrNone {
Name(CustomIdent),
/// `symbols()`
#[css(function)]
- Symbols(SymbolsType,... | 1 | 6 | 1 |
d197ee18792b376ca7606ea3c73e6ac7c1df8e2c | Emilio Cobos Álvarez | 2019-06-28T09:46:26 | Bug 1561738 - Remove nsStyleCoord. r=boris
And move the useful bits of it somewhere else (ServoStyleConstInlines.h for the
inline function definitions, and nsFrame.cpp for the static assertions).
Differential Revision: https://phabricator.services.mozilla.com/D36120 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 6a008a09b..26159c568 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -10,49 +10,15 @@
#![allow(unsafe_code)]
-use crate::gecko::values::GeckoStyleCoordConvertible;
use crate::gecko_bindings::bindings;
-use crate... | 4 | 5 | 584 |
b44e35e9f4f437f9c51e3b7dd38189c9ef2c84fb | Emilio Cobos Álvarez | 2019-06-28T09:46:17 | Bug 1561738 - Stop using nsStyleSides for -moz-image-rect. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D36119 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 3d4e3dc85..6a008a09b 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -69,18 +69,7 @@ impl nsStyleImage {
// Set CropRect
let ref mut rect = *self.mCropRect.mPtr;
- ... | 1 | 10 | 37 |
cb631406b2018dbfde650bcafafa9dbec35ce3d1 | Emilio Cobos Álvarez | 2019-06-28T09:46:02 | Bug 1561738 - Use cbindgen for grid track sizing. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D36118 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index bf1b93422..3d4e3dc85 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -14,14 +14,11 @@ use crate::gecko::values::GeckoStyleCoordConvertible;
use crate::gecko_bindings::bindings;
use crate::gecko_bindings::structs::{s... | 6 | 75 | 257 |
8f46c7892d21b1a80a2ac119df200031e4f5735d | Cosmin Sabou | 2019-06-28T10:27:09 | Backed out 3 changesets (bug 1561738) for causing build bustages on nsGridContainerFrame.cpp CLOSED TREE
Backed out changeset 98f100abc2ba (bug 1561738)
Backed out changeset 9ed20d0fb9ba (bug 1561738)
Backed out changeset 483b1e134ace (bug 1561738) | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 26159c568..bf1b93422 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -10,15 +10,57 @@
#![allow(unsafe_code)]
+use crate::gecko::values::GeckoStyleCoordConvertible;
use crate::gecko_bindings::bindings;
-use crate... | 8 | 876 | 88 |
0a0678a3ab56adb233bfb5984439a4481f50b518 | Emilio Cobos Álvarez | 2019-06-27T00:53:45 | Bug 1552578 - Restrict properties that apply to ::marker for now. r=dbaron
Differential Revision: https://phabricator.services.mozilla.com/D31680 | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index defa6bec1..501611830 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -182,13 +182,18 @@ impl PseudoElement {
/// Property flag that properties must have to apply to this pseudo-element.
#[inline]... | 7 | 40 | 30 |
c0ea37c4c44ff9c2c7fbb7718beb8db6b095022a | Cameron McCormack | 2019-06-27T07:22:22 | Bug 1554571 - Part 3: Cache computed styles of scrollbar part anonymous content. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D33123 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 72a194b0c..c4b0d9ece 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -2836,6 +2836,19 @@ impl ComputedValues {
pub fn resolve_color(&self, color: computed::Color) -> RGBA {
... | 1 | 13 | 0 |
1b2e0b116d68b04400f46098780e2167f212493f | Mihai Alexandru Michis | 2019-06-27T04:09:55 | Backed out 4 changesets (bug 1554571) for causing failures in minimal-xul.css
Backed out changeset 1cc4e6374b8a (bug 1554571)
Backed out changeset 30728685499e (bug 1554571)
Backed out changeset c14e9c381345 (bug 1554571)
Backed out changeset a2143551d7bc (bug 1554571) | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index c4b0d9ece..72a194b0c 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -2836,19 +2836,6 @@ impl ComputedValues {
pub fn resolve_color(&self, color: computed::Color) -> RGBA {
... | 1 | 0 | 13 |
5ece8a45816640200adea973dbd8fc5a1a0cc490 | Mihai Alexandru Michis | 2019-06-27T02:52:48 | Backed out changeset 7423f5bc275c (bug 1552578) for causing failures in test_marker_restrictions.html. CLOSED TREE | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index 501611830..defa6bec1 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -182,18 +182,13 @@ impl PseudoElement {
/// Property flag that properties must have to apply to this pseudo-element.
#[inline]... | 7 | 30 | 40 |
f630bd94aa63a9b9a2fcbf2169612407d6de414d | Connor Brewster | 2019-06-26T23:02:16 | Bug 1555165 - Part 1: Parse backdrop-filter CSS property r=emilio,boris
Differential Revision: https://phabricator.services.mozilla.com/D35816 | diff --git a/style/properties/longhands/effects.mako.rs b/style/properties/longhands/effects.mako.rs
index 34bd110c3..983f54fc0 100644
--- a/style/properties/longhands/effects.mako.rs
+++ b/style/properties/longhands/effects.mako.rs
@@ -57,6 +57,21 @@ ${helpers.predefined_type(
spec="https://drafts.fxtf.org/filter... | 1 | 15 | 0 |
b6f6578965a3a7369f26d8ab3eb0d563344e39f4 | Emilio Cobos Álvarez | 2019-06-26T21:21:38 | Bug 1559814 - Use the cbindgen representation for grid line properties. r=mats
We clamp earlier (parse time rather than computed value time), but that's the
only behavior change, which I think doesn't really matter.
Differential Revision: https://phabricator.services.mozilla.com/D35198 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index ebc91a972..fce88b6f5 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -880,15 +880,8 @@ class Side(object):
self.ident = name.lower()
self.index = index
-class GridLine(object):
- ... | 3 | 25 | 56 |
8022ed6dfb40f09137808e6739bf646f7f818e02 | Emilio Cobos Álvarez | 2019-06-26T21:21:28 | Bug 1559814 - Generate top-level function and constant declarations for the style crate. r=heycam
This needs https://github.com/eqrion/cbindgen/pull/362, but I expect it to be
uncontroversial. I'll add a patch to this bug when it's merged to update it.
cbindgen historically didn't include these, but it turns out to b... | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index aa79140e0..c2e5dd65e 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -182,7 +182,7 @@ impl<T> Arc<T> {
// FIXME(emilio): Would be so amazing to have
// std::intrinsics::type_name() around, so that we could also report
... | 2 | 9 | 9 |
95a66f537ff2495cfdf473bc68700d9591f2779a | Emilio Cobos Álvarez | 2019-06-26T21:21:06 | Bug 1559814 - Use a more similar representation in Rust and C++ for grid lines. r=heycam
Option<> is not FFI-safe, so if we want to use the same representation
everywhere we need to get rid of it. This also makes it take the same amount of
memory as the C++ representation, and it's not very complex, I'd think.
Differ... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index fe0a1935e..ebc91a972 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1138,19 +1138,14 @@ fn static_assert() {
let line = &mut self.gecko.${value.gecko};
line.mLineName.set_move(uns... | 6 | 58 | 60 |
0513552c8a36af7af1954c1ac06896b0b3de6039 | Mihai Alexandru Michis | 2019-06-26T21:04:50 | Backed out 4 changesets (bug 1559814) for causing bustages. CLOSED TREE
Backed out changeset 11ec9de59076 (bug 1559814)
Backed out changeset fec03c5d3661 (bug 1559814)
Backed out changeset 62f9d89fb827 (bug 1559814)
Backed out changeset 362d9435ca4e (bug 1559814) | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index c2e5dd65e..aa79140e0 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -182,7 +182,7 @@ impl<T> Arc<T> {
// FIXME(emilio): Would be so amazing to have
// std::intrinsics::type_name() around, so that we could also report
... | 8 | 113 | 81 |
463e8f31581e6c3b503fd2468e40922c77b8def3 | Emilio Cobos Álvarez | 2019-06-26T20:32:49 | Bug 1559814 - Use a more similar representation in Rust and C++ for grid lines. r=heycam
Option<> is not FFI-safe, so if we want to use the same representation
everywhere we need to get rid of it. This also makes it take the same amount of
memory as the C++ representation, and it's not very complex, I'd think.
Differ... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index fe0a1935e..ebc91a972 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1138,19 +1138,14 @@ fn static_assert() {
let line = &mut self.gecko.${value.gecko};
line.mLineName.set_move(uns... | 5 | 58 | 59 |
e5e94fb68ed57a5d936744af9b7cbe95ab6828a8 | Nicholas Nethercote | 2019-06-25T00:36:59 | Bug 1561216 - Change `StaticPrefs` from a class to a namespace. r=froydnj
This doesn't change the way C++ code uses static prefs. But it does slightly
change how Rust code uses static prefs, specifically the name generated by
bindgen is slightly different.
The commit also improves some comments.
Differential Revisio... | diff --git a/style/font_face.rs b/style/font_face.rs
index c8e7e6578..50814c5f5 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -416,13 +416,13 @@ macro_rules! is_descriptor_enabled {
("font-display") => {
unsafe {
use crate::gecko_bindings::structs::mozilla;
- mozilla:... | 14 | 19 | 19 |
ef7dfc56f50c4c309df8970f83370bdef5f05dc0 | Alastor Wu | 2019-06-25T00:32:07 | Bug 1321488 - restrict CSS properties for '::cue' r=emilio
According to the spec [1], only those CSS properties listed on the spec can be applied on the `::cue`.
[1] https://www.w3.org/TR/webvtt1/#the-cue-pseudo-element
Differential Revision: https://phabricator.services.mozilla.com/D34262 | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index dffd5acf0..defa6bec1 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -186,6 +186,7 @@ impl PseudoElement {
PseudoElement::FirstLetter => Some(PropertyFlags::APPLIES_TO_FIRST_LETTER),
... | 9 | 50 | 41 |
c3df84be44aa5203f2d4d5e477613ddb982f5177 | Dorel Luca | 2019-06-25T00:08:45 | Backed out changeset 49799d898958 (bug 1321488) for Mochitest failures in dom/base/test/test_audioNotificationSilent_audioFile.html | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index defa6bec1..dffd5acf0 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -186,7 +186,6 @@ impl PseudoElement {
PseudoElement::FirstLetter => Some(PropertyFlags::APPLIES_TO_FIRST_LETTER),
... | 9 | 41 | 50 |
560f8fd0c3043a7364a484ee5372d9b8d6f1702f | violet | 2019-06-24T04:07:42 | Bug 1560828 - paint-order parsing has off-by-one error r=emilio
A couple of firefox only WPT failure caused by this off-by-one bug.
Differential Revision: https://phabricator.services.mozilla.com/D35630 | diff --git a/style/values/specified/svg.rs b/style/values/specified/svg.rs
index 578870a4a..2ce12ce46 100644
--- a/style/values/specified/svg.rs
+++ b/style/values/specified/svg.rs
@@ -200,7 +200,7 @@ impl Parse for SVGPaintOrder {
// fill in rest
for i in pos..PAINT_ORDER_COUNT {
- for p... | 1 | 1 | 1 |
293949725afd6734ad131006638cbc52580ebd0a | violet | 2019-06-23T23:01:47 | Bug 1557563 - Add computed value ZeroToOneNumber r=emilio,birtles
Correctly handle clamping to 1 behavior of grayscale(),
invert(), opacity() and sepia().
Differential Revision: https://phabricator.services.mozilla.com/D35509 | diff --git a/style/values/animated/effects.rs b/style/values/animated/effects.rs
index 49e751fec..2a073062f 100644
--- a/style/values/animated/effects.rs
+++ b/style/values/animated/effects.rs
@@ -19,8 +19,8 @@ pub type AnimatedSimpleShadow = GenericSimpleShadow<Color, Length, Length>;
/// An animated value for a si... | 6 | 130 | 71 |
ebaeaf3fadb31898c917f88de49430f2bde088d4 | Emilio Cobos Álvarez | 2019-06-23T12:34:45 | Bug 1560777 - followup: Servo doesn't implement white-space: break-spaces. | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index 3efd8123b..fc934d901 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -175,8 +175,8 @@ ${helpers.predefined_type(
<%helpers... | 1 | 5 | 8 |
3cf3b7b8e62446d0af0a2a20f4d757783b2a9f2e | Emilio Cobos Álvarez | 2019-06-23T11:13:21 | Bug 1560777 - Fix Servo build. | diff --git a/style/stylist.rs b/style/stylist.rs
index 33ce45015..ed9af91af 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -35,10 +35,9 @@ use crate::thread_state::{self, ThreadState};
use crate::{Atom, LocalName, Namespace, WeakAtom};
use fallible::FallibleVec;
use hashglobe::FailedAllocationError;
+use ma... | 2 | 4 | 6 |
00cd995342548571a4615071e2cdf3281f5c285d | Emilio Cobos Álvarez | 2019-06-23T10:57:18 | Bug 1560777 - Update various servo / test-only dependencies. | diff --git a/hashglobe/Cargo.toml b/hashglobe/Cargo.toml
index 4bde6d19f..1ff1b28bb 100644
--- a/hashglobe/Cargo.toml
+++ b/hashglobe/Cargo.toml
@@ -13,4 +13,4 @@ readme = "README.md"
libc = "0.2"
[dev-dependencies]
-rand = "0.4"
+rand = "0.6"
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index... | 3 | 4 | 4 |
b4874d379ea23a102dedbc685f89d04c37bdd6d7 | Emilio Cobos Álvarez | 2019-06-23T10:54:27 | Bug 1560777 - Fix various nightly warnings in Servo-only code. | diff --git a/style/attr.rs b/style/attr.rs
index 22f524bc5..1d0d555d5 100644
--- a/style/attr.rs
+++ b/style/attr.rs
@@ -508,9 +508,9 @@ pub fn parse_legacy_color(mut input: &str) -> Result<RGBA, ()> {
fn hex(ch: char) -> Result<u8, ()> {
match ch {
- '0'...'9' => Ok((ch as u8) - b'0'),
- ... | 4 | 12 | 12 |
7392d566b4d4cf1e0839fc4e6b6a004d141dd477 | Emilio Cobos Álvarez | 2019-06-23T10:40:00 | Bug 1560777 - Fix RuleNode::has_children_for_testing.
I fixed it in the last sync but forgot to do that in Gecko. | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index 9f76c9098..8f255898f 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -1205,7 +1205,7 @@ impl StrongRuleNode {
/// Returns whether this node has any child, only intended for testing
/// purposes, and called on a single-threa... | 1 | 1 | 1 |
796a19c28d8e7572ffe2f768f73ba9ba1b633b01 | Emilio Cobos Álvarez | 2019-06-23T10:39:32 | Bug 1560777 - Remove various bits of dead code removed in upstream servo. r=emilio | diff --git a/selectors/bloom.rs b/selectors/bloom.rs
index 738894ebf..c4b19e59e 100644
--- a/selectors/bloom.rs
+++ b/selectors/bloom.rs
@@ -18,11 +18,6 @@ const KEY_MASK: u32 = (1 << KEY_SIZE) - 1;
/// A counting Bloom filter with 8-bit counters.
pub type BloomFilter = CountingBloomFilter<BloomStorageU8>;
-/// A n... | 11 | 3 | 108 |
6708a6db9346dee417f448002a425f353b6fc88b | Emilio Cobos Álvarez | 2019-06-23T10:39:12 | Bug 1560777 - Fix a typo in a comment. | diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs
index a1831febf..2be7f565a 100644
--- a/malloc_size_of/lib.rs
+++ b/malloc_size_of/lib.rs
@@ -43,7 +43,7 @@
//! measured as well as the thing it points to. E.g.
//! `<Box<_> as MallocSizeOf>::size_of(field, ops)`.
//!
-//! Note: WebRender has a reduced... | 1 | 1 | 1 |
f8884afc13278af630c4bf2b93c547cf617ae466 | violet | 2019-06-22T10:09:51 | Bug 1547633 - Invalidate style for ::selection r=emilio
This patch invalidates the style for `::selection`, which will restore the behavior before the regression.
However, it's still not quite correct, because repaint is not triggered. Given that `::selection` requires some major change to implement https://github.co... | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index 7538b7858..dffd5acf0 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -116,6 +116,12 @@ impl PseudoElement {
*self == PseudoElement::Marker
}
+ /// Whether this pseudo-element is the ::se... | 3 | 25 | 0 |
b1495ff1a1a1ede1a9f44531863a284927bec295 | Boris Chiou | 2019-06-21T21:48:54 | Bug 1560198 - Fix the serialization of the computed value of background-size. r=emilio
This patch produces the following serialization:
```
input | computed value
------------------------------
1. "auto" "auto"
2. "auto auto" "auto"
3. "15px auto" "15px"
4. "15px" "15px"
`... | diff --git a/style/values/generics/background.rs b/style/values/generics/background.rs
index b64fccb60..d9b662459 100644
--- a/style/values/generics/background.rs
+++ b/style/values/generics/background.rs
@@ -6,13 +6,6 @@
use crate::values::generics::length::{GenericLengthPercentageOrAuto, LengthPercentageOrAuto};
... | 1 | 1 | 11 |
8433b12fbd1dc9c2244aea65ddc498f88e4bdfc7 | Emilio Cobos Álvarez | 2019-06-18T21:32:16 | Bug 1556602 - Fix various warnings with rust 1.37 nightly. r=froydnj
In particular:
* trait objects without an explicit `dyn` are deprecated
* `...` range patterns are deprecated
I think these shouldn't really warn by default and should be clippy / opt-in
lints, but anyway, doesn't hurt.
Differential Revision: ht... | diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs
index d65f8e957..a1831febf 100644
--- a/malloc_size_of/lib.rs
+++ b/malloc_size_of/lib.rs
@@ -92,7 +92,7 @@ use void::Void;
type VoidPtrToSizeFn = unsafe extern "C" fn(ptr: *const c_void) -> usize;
/// A closure implementing a stateful predicate on pointers... | 14 | 35 | 35 |
2bb657d91134db6f671dbee401741d51090fc467 | Emilio Cobos Álvarez | 2019-06-19T05:58:11 | Bug 1559546 - Use atoms for grid line names. r=mats
The style system already atomizes all CustomIdent values, which means that we're
just wasting memory and CPU by doing string copies all over the place.
This patch fixes it. This also simplifies further changes to use as much of the
rust data structures as possible.
... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 1105e7050..fe0a1935e 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1137,11 +1137,12 @@ fn static_assert() {
use crate::gecko_bindings::structs::{nsStyleGridLine_kMinLine, nsStyleGridLine_kM... | 2 | 34 | 29 |
258c6c3841cf8cd1effe0ed8f313d32438dfaa0f | Emilio Cobos Álvarez | 2019-06-18T22:29:58 | Bug 1559545 - Use servo for the representation of grid template areas. r=mats
Right now we do a lot of useless string copying. In order to avoid transcoding
to utf-16 during layout, make sure to use nsCString at a few related places.
I may revisit this since we're storing other line names as atoms in some places.
So ... | diff --git a/style/gecko_bindings/sugar/refptr.rs b/style/gecko_bindings/sugar/refptr.rs
index c52467339..a141aef4e 100644
--- a/style/gecko_bindings/sugar/refptr.rs
+++ b/style/gecko_bindings/sugar/refptr.rs
@@ -308,11 +308,6 @@ impl_threadsafe_refcount!(
bindings::Gecko_AddRefnsIURIArbitraryThread,
bindings... | 4 | 68 | 130 |
dc68f4e5662111c1b6556f4581630f0c387cec40 | Emilio Cobos Álvarez | 2019-06-17T15:44:21 | Bug 1559545 - Use more ffi-friendly types in grid template areas. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D35116 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 3ff3be2a2..5a2418112 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1433,7 +1433,7 @@ fn static_assert() {
Gecko_NewGridTemplateAreasValue(v.0.areas.len() as u32, v.0.strings.len() a... | 3 | 44 | 30 |
099691dd449894efddfd671349601d53a05a14c7 | violet | 2019-06-18T11:54:41 | Bug 1559796 - Should not serialize default radius of circle r=emilio
Should not serialize default shape-outside circle() function radius.
The ToCss impl of Circle and Ellipse turn out to be identical in specified and computed value, thus move them to generics.
Differential Revision: https://phabricator.services.mozi... | diff --git a/style/values/computed/basic_shape.rs b/style/values/computed/basic_shape.rs
index 9a245aa77..27a091a11 100644
--- a/style/values/computed/basic_shape.rs
+++ b/style/values/computed/basic_shape.rs
@@ -10,8 +10,6 @@
use crate::values::computed::url::ComputedUrl;
use crate::values::computed::{Image, LengthP... | 3 | 43 | 71 |
d61223eed139a461f9d59d767095d1714a4805a7 | Noemi Erli | 2019-06-18T05:44:42 | Backed out changeset a2a92e2fd645 (bug 1559796) for failing in shape-outside-circle-004.html | diff --git a/style/values/computed/basic_shape.rs b/style/values/computed/basic_shape.rs
index 27a091a11..9a245aa77 100644
--- a/style/values/computed/basic_shape.rs
+++ b/style/values/computed/basic_shape.rs
@@ -10,6 +10,8 @@
use crate::values::computed::url::ComputedUrl;
use crate::values::computed::{Image, LengthP... | 3 | 71 | 43 |
c61365311cf36d4711244f54160e9fe29bf35319 | violet | 2019-06-12T10:23:49 | Bug 1351432 - Implement the break-spaces value of the white-space property r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D34499 | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index 45b3ee35a..3efd8123b 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -175,7 +175,7 @@ ${helpers.predefined_type(
<%helpers... | 1 | 7 | 4 |
77252d62aa078a674fe23f059f21a54a5aebb450 | Emilio Cobos Álvarez | 2019-06-11T17:42:58 | Bug 1505489 - Add a pref and enable Shadow Parts in Nightly and for chrome stylesheets. r=heycam
I want to enable in Nightly to evaluate (in the medium term) shipping it without
the part forwarding, once the cascade order and importance issues are fixed, and
that we pass all the tests that don't involve forwarding.
T... | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index 18718446c..659200c37 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -5,7 +5,7 @@
//! Gecko-specific bits for selector-parsing.
use crate::element_state::{DocumentState, ElementState};
-use crate::... | 1 | 9 | 2 |
c665afc1732fa3373e9b0e8c203f4c3874a640dd | Emilio Cobos Álvarez | 2019-06-11T17:42:49 | Bug 1505489 - Implement GeckoElement::each_part. r=heycam
This should make all the pieces come together.
Note that we don't need to look at the snapshot for ::part() for now (other than
when selector-matching normally) because I decided to just restyle the element
for now when the part attribute changes.
::part() ca... | diff --git a/style/gecko/snapshot.rs b/style/gecko/snapshot.rs
index d294939ba..cffb78d3e 100644
--- a/style/gecko/snapshot.rs
+++ b/style/gecko/snapshot.rs
@@ -211,7 +211,7 @@ impl ElementSnapshot for GeckoElementSnapshot {
return;
}
- snapshot_helpers::each_class(&self.mClass, callback)... | 3 | 16 | 4 |
2aaa374149f8cc654e95f173eacf66153745ec5e | Emilio Cobos Álvarez | 2019-06-11T17:42:41 | Bug 1505489 - Add code to make part rules affect the style of the elements. r=heycam
I still haven't implemented each_part(), so this will do nothing yet.
The cascade order stuff is fishy, I know, and I'll fix in a followup if it's
fine with you. I moved the sorting of the rules to rule_collector, since it
seemed to ... | diff --git a/selectors/context.rs b/selectors/context.rs
index 95caa4055..3ecd4dd82 100644
--- a/selectors/context.rs
+++ b/selectors/context.rs
@@ -279,13 +279,13 @@ where
/// Runs F with a given shadow host which is the root of the tree whose
/// rules we're matching.
#[inline]
- pub fn with_shadow_... | 6 | 100 | 27 |
32a35ecc65c9393b2f1d30f53ac50f491816a39f | Emilio Cobos Álvarez | 2019-06-11T17:42:32 | Bug 1505489 - Collect ::part() rules during CascadeData rebuilds. r=heycam
Unlike for :host() or ::slotted(), or regular rules, we don't need a whole
SelectorMap<>, so gotta make the code a bit more generic.
Depends on D32645
Differential Revision: https://phabricator.services.mozilla.com/D32646 | diff --git a/selectors/parser.rs b/selectors/parser.rs
index fa43aaa38..d76defe81 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -606,6 +606,31 @@ impl<Impl: SelectorImpl> Selector<Impl> {
self.0.header.header.is_part()
}
+ #[inline]
+ pub fn part(&self) -> Option<&Impl::PartName> {... | 2 | 104 | 35 |
a600a4e9cc6104f60cd36b07373aa644df8f206b | Emilio Cobos Álvarez | 2019-06-11T17:42:23 | Bug 1505489 - Add an extra flag to flag ::part() to selectors. r=heycam
This grows the selector struct, but only in 32-bit, since in 64-bit we take
space from the alignment padding that we're paying due to having the size of the
slice as a word.
Depends on D32644
Differential Revision: https://phabricator.services.m... | diff --git a/selectors/builder.rs b/selectors/builder.rs
index c3e733cbe..cddaf7195 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -96,18 +96,24 @@ impl<Impl: SelectorImpl> SelectorBuilder<Impl> {
&mut self,
parsed_pseudo: bool,
parsed_slotted: bool,
+ parsed_part: boo... | 2 | 92 | 28 |
73abf57c3b17819759c1f9cc5512e3ca782e7369 | Emilio Cobos Álvarez | 2019-06-11T17:42:09 | Bug 1505489 - Don't go through all the part names if not there. r=jwatt
This uses the bit added for tracking part attributes in order to avoid doing
wasted work.
Depends on D32643
Differential Revision: https://phabricator.services.mozilla.com/D32644 | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index aa59df56b..70eaa552e 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -590,6 +590,9 @@ impl<'le> GeckoElement<'le> {
#[inline(always)]
fn get_part_attr(&self) -> Option<&structs::nsAttrValue> {
+ if !self.has_part_a... | 1 | 8 | 0 |
51171d5b41276ab69226b5271e6697082980f158 | Emilio Cobos Álvarez | 2019-06-11T17:41:51 | Bug 1505489 - Add plumbing code to invalidate shadow parts. r=heycam
Still does nothing, since we still do not collect part rules, but this is all
the plumbing that should allow us to invalidate parts when attributes or state
change on their ancestors.
Depends on D32641
Differential Revision: https://phabricator.ser... | diff --git a/style/dom.rs b/style/dom.rs
index 04d6a79b3..0a743c602 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -346,6 +346,14 @@ pub trait TShadowRoot: Sized + Copy + Clone + PartialEq {
where
Self: 'a;
+ /// Get the list of shadow parts for this shadow root.
+ fn parts<'a>(&self) -> &[<Self:... | 5 | 72 | 4 |
203cb239d8943c80a9a6ef0eed272dc42abbc670 | Emilio Cobos Álvarez | 2019-06-06T23:18:28 | Bug 1557403 - Handle default angle in radians. r=me
We were not copying the angle in this case for some reason, and I overlooked
this. | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 71e4de181..68f8d2327 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -389,6 +389,7 @@ impl nsStyleImage {
let angle = Angle::from_gecko_style_coord(&gecko_gradient.mAngle);
let line_d... | 1 | 1 | 0 |
ef980fa88b44291336d74cfe1d28c3559c87edbe | Charlie Marlow | 2019-06-06T17:12:22 | Bug 1555863 added text-decoration-width support to style system including mochitests and web platform tests r=emilio
from-font support will be added later
Differential Revision: https://phabricator.services.mozilla.com/D33392 | diff --git a/style/properties/longhands/text.mako.rs b/style/properties/longhands/text.mako.rs
index 723e26ae2..91412d2ee 100644
--- a/style/properties/longhands/text.mako.rs
+++ b/style/properties/longhands/text.mako.rs
@@ -69,3 +69,13 @@ ${helpers.predefined_type(
gecko_pref="layout.css.initial-letter.enabled",
... | 1 | 10 | 0 |
389a8d9aa3f39d5cb80de0706f5f9167bc2b82d5 | Emilio Cobos Álvarez | 2019-06-06T04:08:52 | Bug 1557110 - Cleanup gradient parsing by removing the simple-moz-gradient parsing pref. r=dholbert
It looks like bug 1547939 will stick, given how fast the other regressions came
in for bug 1337655.
We haven't seen any regression from this, and it seems unlikely that we'd want
this code back.
This blocks further im... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 0be8a81e6..71e4de181 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -65,7 +65,6 @@ impl From<Angle> for CoordDataValue {
}
fn line_direction(horizontal: LengthPercentage, vertical: LengthPercentage) -> LineDirect... | 5 | 50 | 443 |
b0e9fbd801463abaab12b34358f9be47d22bc90c | Charlie Marlow | 2019-06-04T22:04:14 | Bug 1555150: adding support for CSS text underline offset to the style system r=emilio
support for from-font listed in the CSS spec will be implemented in a later bug
Differential Revision: https://phabricator.services.mozilla.com/D33233 | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index 58331efa6..cb319f187 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -374,3 +374,14 @@ ${helpers.single_keyword(
product... | 1 | 11 | 0 |
0eda6ff99abf451817d7a7a9d0bdeef70f18f0d4 | Coroiu Cristina | 2019-06-04T04:52:50 | Backed out changeset ba1f75c56457 (bug 1555150) for xpcshell failures at devtools/shared/tests/unit/test_css-properties-db.js | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index cb319f187..58331efa6 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -374,14 +374,3 @@ ${helpers.single_keyword(
product... | 1 | 0 | 11 |
cd271a4e5fc2e3daefdd836e62d6592e829b11f8 | Emilio Cobos Álvarez | 2019-06-03T17:32:48 | Bug 1554150 - Hide some appearance values from content. r=mats
They're not used internally either, so remove all ability to address them.
I haven't removed the implementation yet, as some of them are quite complex, and
I don't have a mac / windows build. We should do that when this hits release
though.
Differential ... | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 542976d45..a64216087 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -1129,11 +1129,13 @@ pub enum Appearance {
ButtonArrowUp,
/// A rectangular button that contains complex content
/// like... | 1 | 5 | 0 |
6fc371c6106f9567425b67ca81c5bc03238465d9 | Emilio Cobos Álvarez | 2019-06-03T16:37:53 | Bug 1555867 - Report heap size of rule tree heap allocations as well. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D33353 | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index 04f2a50cd..bc027539d 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -14,8 +14,7 @@ use crate::properties::{Importance, LonghandIdSet, PropertyDeclarationBlock};
use crate::shared_lock::{Locked, SharedRwLockReadGuard, StylesheetGuar... | 1 | 16 | 7 |
fe27c9845dfecc5652fa553cd313cf86c966b95f | Emilio Cobos Álvarez | 2019-06-03T16:37:45 | Bug 1555867 - Inline one child in the rule tree. r=heycam
It is indeed the most common case according to a bit of measurement.
A non-atypical example from GitHub for example:
> Rule tree stats:
> 0 - 340
> 1 - 1403
> 2 - 28
> 3 - 8
> 4 - 2
> 6 - 1
> 7 - 3
> 8 - 2
> 12 - 2
> 14 - 1
> 41 - 1
> 45 - 1
> 67... | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index db17021a5..04f2a50cd 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -83,20 +83,16 @@ impl MallocSizeOf for RuleTree {
while let Some(node) = stack.pop() {
n += unsafe { ops.malloc_size_of(node.ptr()) };
- ... | 1 | 168 | 30 |
a20f18996b33ef28f558152e9b98e8711c176624 | Emilio Cobos Álvarez | 2019-06-03T16:37:34 | Bug 1555867 - Add some very basic rule tree stats that can be enabled with trace-level logging. r=heycam
This is useful to analyze the shape of the rule tree at a glance.
Differential Revision: https://phabricator.services.mozilla.com/D33350 | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index 395eefcc5..db17021a5 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -392,9 +392,58 @@ impl RuleTree {
/// This can only be called when no other threads is accessing this tree.
pub unsafe fn maybe_gc(&self) {
+ #[c... | 1 | 49 | 0 |
bed5356dd70b1ced381cfd5149cc23de445d455d | Evgeniy Reizner | 2019-05-26T16:10:24 | Bug 1556388 - Do not use borrowed types in the selectors::Element trait. r=emilio
This cherry-picks https://github.com/servo/servo/pull/23463 with a few fixes for
the Gecko build. | diff --git a/selectors/matching.rs b/selectors/matching.rs
index 6554f2f9c..45acc13e7 100644
--- a/selectors/matching.rs
+++ b/selectors/matching.rs
@@ -596,7 +596,7 @@ where
&local_name.lower_name,
)
.borrow();
- element.local_name() == name
+ element.has_local_name(name)
}
/// Determines ... | 5 | 54 | 23 |
6b56cfff36b55e423a0798263a43397474fc3e19 | Emilio Cobos Álvarez | 2019-06-03T12:22:30 | Bug 1556388 - Fix Servo build. | diff --git a/style/gecko/url.rs b/style/gecko/url.rs
index f8d0f4ec7..3a53f639a 100644
--- a/style/gecko/url.rs
+++ b/style/gecko/url.rs
@@ -260,12 +260,8 @@ pub struct SpecifiedImageUrl(pub SpecifiedUrl);
impl SpecifiedImageUrl {
/// Parse a URL from a string value that is a valid CSS token for a URL.
- pub... | 4 | 27 | 14 |
cf38b48c74c816e2d6c8281320189303f95d6068 | Emilio Cobos Álvarez | 2019-06-03T03:13:17 | Bug 1556388 - Appease tidy. | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index 288f68aaf..395eefcc5 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -96,7 +96,7 @@ impl MallocSizeOf for RuleTree {
}
}
-#[derive(Debug, Hash, PartialEq, Eq)]
+#[derive(Debug, Eq, Hash, PartialEq)]
struct ChildKey(CascadeLe... | 3 | 3 | 3 |
8976fd5d5efb74327205f4558f67ebb835b47d73 | Emilio Cobos Álvarez | 2019-06-03T03:09:42 | Bug 1556388 - Rustfmt recent changes. | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index 8d68d3183..aa79140e0 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -314,7 +314,11 @@ impl<T: ?Sized> Arc<T> {
fn record_drop(&self) {
#[cfg(feature = "gecko_refcount_logging")]
unsafe {
- NS_LogDtor(self.ptr() as *const _... | 8 | 46 | 26 |
c1c22c4f128a3453c6580740267ccfa8caef5060 | Cosmin Sabou | 2019-05-31T23:27:33 | Backed out changeset 118a2ee53436 (bug 1555150) for xpcshell failures on /test_css-properties-db.js. CLOSED TREE | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index cb319f187..58331efa6 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -374,14 +374,3 @@ ${helpers.single_keyword(
product... | 1 | 0 | 11 |
6f28eb75808079e96c02aded5a495816c7e72184 | Emilio Cobos Álvarez | 2019-05-31T16:13:49 | Bug 1555944 - Make nsIContent::GetBindingParent return an element. r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D33308 | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index 75254f089..3b784a608 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -704,9 +704,8 @@ impl<'le> GeckoElement<'le> {
.map(GeckoElement)
}
} else {
- let binding_parent = unsafe { s... | 1 | 4 | 5 |
056fc0ed79978cf14422f66896cd9fec2335022d | Emilio Cobos Álvarez | 2019-05-29T23:41:01 | Bug 1493420 - Use a RwLock'd HashMap instead of a lock-free linked list for rule node children. r=heycam
I need to profile this a bit more, but talos was pretty happy about this, and it
solves the known performance issues here such as the test-case from bug 1483963
for example. This also gets rid of a bunch of unsafe ... | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index 34463b526..8d68d3183 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -1305,11 +1305,18 @@ impl<A, B> ArcUnion<A, B> {
}
/// Returns true if the two values are pointer-equal.
+ #[inline]
pub fn ptr_eq(this: &Self, other: &Self) -> bool {
... | 2 | 95 | 191 |
2c18dc3932e41a992e5f2dcf0c76f9c27cfd5cbc | Emilio Cobos Álvarez | 2019-05-27T12:56:08 | Bug 1552080 - Rejigger a bit rust features so that rusttests still link. r=froydnj
We cannot compile with just feature(gecko + debug_assertions), since that's how
debug rusttests get compiled and they don't have the refcount logging stuff.
We were getting away with it for the pre-existing usage of the style crate,
be... | diff --git a/servo_arc/Cargo.toml b/servo_arc/Cargo.toml
index 8eb84601b..3581210c2 100644
--- a/servo_arc/Cargo.toml
+++ b/servo_arc/Cargo.toml
@@ -12,7 +12,7 @@ path = "lib.rs"
[features]
servo = ["serde"]
-gecko = []
+gecko_refcount_logging = []
[dependencies]
nodrop = {version = "0.1.8"}
diff --git a/servo_... | 4 | 10 | 9 |
b006bd504b15de21b4bf8103b12fc4cdf4fb3996 | Emilio Cobos Álvarez | 2019-05-16T02:35:34 | Bug 1552080 - Add refcount logging to servo_arc. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D32173 | diff --git a/servo_arc/Cargo.toml b/servo_arc/Cargo.toml
index 58f1ea8ef..8eb84601b 100644
--- a/servo_arc/Cargo.toml
+++ b/servo_arc/Cargo.toml
@@ -12,6 +12,7 @@ path = "lib.rs"
[features]
servo = ["serde"]
+gecko = []
[dependencies]
nodrop = {version = "0.1.8"}
diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs... | 11 | 101 | 24 |
cee917a2b8b68dae289209c20e071ea54026d182 | Emilio Cobos Álvarez | 2019-05-27T12:37:37 | Bug 1552878 - Use cbindgen for filters. r=jwatt
Had to implement some OwnedSlice bits that the canvas code used.
Differential Revision: https://phabricator.services.mozilla.com/D31799 | diff --git a/style/gecko/url.rs b/style/gecko/url.rs
index 8435895b8..4f1efdf05 100644
--- a/style/gecko/url.rs
+++ b/style/gecko/url.rs
@@ -256,7 +256,6 @@ impl ToComputedValue for SpecifiedUrl {
/// A specified image `url()` value.
#[derive(Clone, Debug, Eq, MallocSizeOf, PartialEq, SpecifiedValueInfo, ToCss, ToS... | 8 | 26 | 150 |
ad61a55c0776e63f71efd3688900b891e9043ed6 | Emilio Cobos Álvarez | 2019-05-27T11:45:12 | Bug 1552708 - Use cbindgen for URIs. r=heycam
This doesn't clean up as much as a whole, but it's a step in the right
direction. In particular, it allows us to start using simple bindings for:
* Filters
* Shapes and images, almost. Need to:
* Get rid of the complex -moz- gradient parsing (let
layout.css.simp... | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index 09f381c62..e1496b797 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -90,6 +90,9 @@ const STATIC_REFCOUNT: usize = usize::MAX;
/// usage of PhantomData.
///
/// [`Arc`]: https://doc.rust-lang.org/stable/std/sync/struct.Arc.html
+///
+/// cbindgen:derive-... | 11 | 233 | 292 |
4b78a7f2c6debed368eb3594a253b9dc1042d4c6 | Boris Chiou | 2019-05-28T18:31:48 | Bug 1429303 - Animate offset-rotate. r=birtles
Differential Revision: https://phabricator.services.mozilla.com/D32237 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index da9e5b2e7..7bfd1fa67 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -390,7 +390,7 @@ ${helpers.predefined_type(
"OffsetRotate",
"computed::OffsetRotate::auto(... | 2 | 14 | 2 |
a5f929d7c16b2d0c17e9620a6ce5f3ef28c30a55 | Emilio Cobos Álvarez | 2019-05-27T20:25:31 | Bug 1554433 - Hide -moz-gtk-buttonactivetext from content. r=stransky
This prevents exposing the value to web content.
Differential Revision: https://phabricator.services.mozilla.com/D32611 | diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs
index dd510e796..5405fc660 100644
--- a/style/values/specified/color.rs
+++ b/style/values/specified/color.rs
@@ -172,6 +172,7 @@ pub enum SystemColor {
MozOddtreerow,
/// Used for button text when pressed.
+ #[parse(condition... | 1 | 7 | 8 |
487154d7a83d905eba47dc781d9c5d5f5c008fee | Bogdan Tara | 2019-05-27T19:30:32 | Backed out changeset 8855dd7a2aa8 (bug 1554433) for browser_parsable_css.js failures CLOSED TREE | diff --git a/style/values/specified/color.rs b/style/values/specified/color.rs
index 5405fc660..dd510e796 100644
--- a/style/values/specified/color.rs
+++ b/style/values/specified/color.rs
@@ -172,7 +172,6 @@ pub enum SystemColor {
MozOddtreerow,
/// Used for button text when pressed.
- #[parse(condition... | 1 | 8 | 7 |
9f897abee8ecd52656d517bbe0e423a2f33c97a9 | Brindusan Cristian | 2019-05-27T14:00:03 | Backed out 3 changesets (bug 1552708, bug 1552878) for build bustages and compiler issues. CLOSED TREE
Backed out changeset 9d4f178bfcbd (bug 1552878)
Backed out changeset 80db9f845237 (bug 1552708)
Backed out changeset 1bdbfbb5b342 (bug 1552708) | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index e1496b797..09f381c62 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -90,9 +90,6 @@ const STATIC_REFCOUNT: usize = usize::MAX;
/// usage of PhantomData.
///
/// [`Arc`]: https://doc.rust-lang.org/stable/std/sync/struct.Arc.html
-///
-/// cbindgen:derive-... | 17 | 439 | 256 |
bd2dc1409772a5f6ba9e9389f9c3501433264c63 | Emilio Cobos Álvarez | 2019-05-27T12:20:26 | Bug 1552708 - Tweak rust tests to account for more compact URL representation. r=bustage
CLOSED TREE | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index da9e5b2e7..76334fe05 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -644,7 +644,6 @@ ${helpers.predefined_type(
"basic_shape::FloatAreaShape",
"generics::basi... | 1 | 0 | 1 |
ad72e0a03e1f6f8e0bb4e23ec6e686c0bf02e967 | Emilio Cobos Álvarez | 2019-05-27T11:45:12 | Bug 1552708 - Use cbindgen for URIs. r=heycam
This doesn't clean up as much as a whole, but it's a step in the right
direction. In particular, it allows us to start using simple bindings for:
* Filters
* Shapes and images, almost. Need to:
* Get rid of the complex -moz- gradient parsing (let
layout.css.simp... | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index 09f381c62..e1496b797 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -90,6 +90,9 @@ const STATIC_REFCOUNT: usize = usize::MAX;
/// usage of PhantomData.
///
/// [`Arc`]: https://doc.rust-lang.org/stable/std/sync/struct.Arc.html
+///
+/// cbindgen:derive-... | 10 | 233 | 291 |
a590ef676bb1d5a22deaac2d737758816f8799ad | Emilio Cobos Álvarez | 2019-05-26T13:10:00 | Bug 1554433 - Move system colors to values::specified::color. r=xidorn
This should be an idempotent patch. The way to come up with this patch has been:
* Run the first script attached to the bug and pipe it to xclip, then paste it
in color.rs
* Add the relevant #[derive] annotations and remove the color.mako.rs
... | diff --git a/style/properties/longhands/color.mako.rs b/style/properties/longhands/color.mako.rs
index a83787dd4..e2d4003a2 100644
--- a/style/properties/longhands/color.mako.rs
+++ b/style/properties/longhands/color.mako.rs
@@ -17,114 +17,3 @@ ${helpers.predefined_type(
ignored_when_colors_disabled="True",
s... | 2 | 223 | 131 |
254422a95b7f12535871ef22c0198df8bbf96914 | Emilio Cobos Álvarez | 2019-05-25T01:48:50 | Bug 1554347 - Fix servo build. | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index ca9700737..800d50c62 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -366,7 +366,7 @@
pub use self::single_value::SpecifiedValue as SingleSpecifiedValue;
- % if not simple_v... | 3 | 6 | 19 |
bc0d2cc91960c296aa963b5da23021ba546c0ff9 | Emilio Cobos Álvarez | 2019-05-25T01:22:21 | Bug 1554347 - Revert a change that ended up not being needed and busts the servo build. | diff --git a/style/values/animated/mod.rs b/style/values/animated/mod.rs
index 40edbce73..267ef0c8e 100644
--- a/style/values/animated/mod.rs
+++ b/style/values/animated/mod.rs
@@ -10,7 +10,7 @@
use crate::properties::PropertyId;
use crate::values::computed::length::LengthPercentage;
-use crate::values::computed::u... | 1 | 1 | 2 |
f1d6ae86b9d0fdd1f0d3f48ee26fdc6dd344fbbd | Emilio Cobos Álvarez | 2019-05-25T01:19:12 | Bug 1554347 - Appease tidy. | diff --git a/style/counter_style/mod.rs b/style/counter_style/mod.rs
index 72ccbd946..289281011 100644
--- a/style/counter_style/mod.rs
+++ b/style/counter_style/mod.rs
@@ -408,7 +408,7 @@ impl ToCss for System {
}
/// <https://drafts.csswg.org/css-counter-styles/#typedef-symbol>
-#[derive(Clone, Debug, Eq, Partial... | 3 | 9 | 6 |
dfefc66da9d8836f745185ff0e3ea216695f0511 | Emilio Cobos Álvarez | 2019-05-25T01:11:41 | Bug 1554347 - Reformat recent style system changes. | diff --git a/style/counter_style/mod.rs b/style/counter_style/mod.rs
index 9e2bc096e..72ccbd946 100644
--- a/style/counter_style/mod.rs
+++ b/style/counter_style/mod.rs
@@ -474,10 +474,7 @@ pub struct CounterRange {
/// Empty represents 'auto'
#[derive(Clone, Debug, ToShmem, ToCss)]
#[css(comma)]
-pub struct Counter... | 13 | 207 | 214 |
17251ced9b429bd93367ff8892b0d45706a019d0 | Jan Andre Ikenmeyer | 2019-05-10T13:03:19 | Bug 1554347 - Update MPL license to https. r=emilio | diff --git a/style/gecko/boxed_types.rs b/style/gecko/boxed_types.rs
index c32e06c97..47fc4fe57 100644
--- a/style/gecko/boxed_types.rs
+++ b/style/gecko/boxed_types.rs
@@ -1,6 +1,6 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed w... | 2 | 2 | 2 |
b3ac331900270875be081bc54e7819934b0eb44c | Emilio Cobos Álvarez | 2019-05-25T00:37:39 | Bug 1554347 - Sort derive list to keep tidy shut. | diff --git a/style_traits/arc_slice.rs b/style_traits/arc_slice.rs
index 6be97dfe7..be50e21c0 100644
--- a/style_traits/arc_slice.rs
+++ b/style_traits/arc_slice.rs
@@ -24,7 +24,7 @@ const ARC_SLICE_CANARY: u64 = 0xf3f3f3f3f3f3f3f3;
/// cbindgen:derive-eq=false
/// cbindgen:derive-neq=false
#[repr(C)]
-#[derive(Debu... | 1 | 1 | 1 |
595da99f4acada6d843e46ceeddbe6f96f998e16 | Bastien Orivel | 2019-05-19T19:29:26 | Bug 1554347 - Update xml5ever and html5ever. r=npotb | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index 609a977b1..bd351649b 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -43,5 +43,5 @@ thin-slice = "0.1.0"
time = { version = "0.1.17", optional = true }
url = { version = "1.2", optional = true }
webrender_api = { git =... | 2 | 2 | 2 |
71c46765f7d717e871e4cfd8b3d41f2af2dcb5cf | Bastien Orivel | 2019-05-21T22:32:38 | Bug 1554347 - Update darling to 0.9. r=emilio | diff --git a/derive_common/Cargo.toml b/derive_common/Cargo.toml
index 2a4fac644..a9b478ecd 100644
--- a/derive_common/Cargo.toml
+++ b/derive_common/Cargo.toml
@@ -9,7 +9,7 @@ publish = false
path = "lib.rs"
[dependencies]
-darling = "0.8"
+darling = "0.9"
proc-macro2 = "0.4"
quote = "0.6"
syn = { version = "0.... | 3 | 3 | 3 |
13c71134f08449ce000aa5cb6e5fbf6070732da4 | Martin Stransky | 2019-05-24T08:51:48 | Bug 1531338 - [Linux/Gtk] Get and use Gtk theme text color for active/pressed button, r=dao,emilio
- Follow Gtk and get theme button text color directly from "button" CSS node instead of "button label"
- Provide new -moz-gtk-buttonactivetext color for active/pressed button text color
- Replace ButtonText color with -m... | diff --git a/style/properties/longhands/color.mako.rs b/style/properties/longhands/color.mako.rs
index b367f2bbd..a83787dd4 100644
--- a/style/properties/longhands/color.mako.rs
+++ b/style/properties/longhands/color.mako.rs
@@ -35,6 +35,7 @@ pub mod system_colors {
-moz-eventreerow -moz-fie... | 1 | 1 | 0 |
fde5800e94e9dc64f985efb9a954cefe01f0893a | violet | 2019-05-24T04:48:46 | Bug 1553252 - Use cbindgen for text-overflow r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D32285 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 2c83e8cf6..dd5bcf2fe 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -3342,83 +3342,7 @@ fn static_assert() {
</%self:impl_trait>
-<%self:impl_trait style_struct_name="Text"
- ski... | 3 | 6 | 79 |
adbe378a5d4d3146e786f5bbd459aad62daae7fc | Emilio Cobos Álvarez | 2019-05-24T01:09:15 | Bug 1544242 - Cleanup selector-matching for nested pseudo-elements, match ::slotted correctly when there's no selector before it, and add tests. r=heycam,mats
D29542 fixed the bogus checks that was making nested pseudo-elements match
author rules. This adds tests and ends up being just a cleanup, though as it
turns ou... | diff --git a/selectors/builder.rs b/selectors/builder.rs
index b548ceb83..c3e733cbe 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -84,12 +84,6 @@ impl<Impl: SelectorImpl> SelectorBuilder<Impl> {
self.current_len = 0;
}
- /// Returns true if no simple selectors have ever been pushed ... | 9 | 35 | 38 |
66fa2bff03b4e572b85f291eaa737aaab1f88657 | Dzmitry Malyshau | 2019-05-23T19:54:25 | Bug 1552549 - Update rand dependency to 0.6 r=kats,froydnj,nika,jkt,jcj
Update rand version in u2fhid and xpcom
Differential Revision: https://phabricator.services.mozilla.com/D31669 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 54493548b..9d1cec77f 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -55,7 +55,7 @@ num-traits = "0.2"
num-derive = "0.2"
ordered-float = "1.0"
owning_ref = "0.4"
-parking_lot = "0.6"
+parking_lot = "0.8"
precomputed-hash = "0.1.1"
rayon = "1"
selecto... | 1 | 1 | 1 |
a0a58671c6ea3679dcd582c500708b94261cb6fb | Oana Pop Rus | 2019-05-23T14:52:21 | Backed out changeset 3304277f5bde (bug 1553252) for build bustages on Windows on a CLOSED TREE | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index dd5bcf2fe..2c83e8cf6 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -3342,7 +3342,83 @@ fn static_assert() {
</%self:impl_trait>
-<%self:impl_trait style_struct_name="Text" skip_longhands="initia... | 3 | 79 | 6 |
47b91a973b91d27fbadd28cfc2e2c553ad270255 | Emilio Cobos Álvarez | 2019-05-22T13:28:01 | Bug 1548342 - Fix nested-pseudo-elements matching author rules better. r=heycam
This makes *|*::marker do the intended thing in UA sheets, so I think it's
better, and it's a bit less special-casey.
We may want to re-introduce the changes for pseudo-elements at some point,
depending on the WG decision, but this patch ... | diff --git a/style/dom.rs b/style/dom.rs
index 9a81e2ec7..633dce836 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -801,24 +801,29 @@ pub trait TElement:
{
use rule_collector::containing_shadow_ignoring_svg_use;
- let mut doc_rules_apply = self.matches_user_and_author_rules();
+ let targe... | 4 | 26 | 9 |
74d769a317a9e2ced8517673321b1295dcbacb2b | Emilio Cobos Álvarez | 2019-05-22T11:34:23 | Bug 1552636 - Remove eStyleImageType_URL. r=TYLin
It was introduced in bug 1352096 to reduce complexity with Stylo (apparently).
Right now it doesn't look like it reduces any complexity, and it's a bit
annoying with some of the patches that I'm writing at the moment.
So unless there's any objection I think it should... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 43082a7c0..06e201bf2 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -383,7 +383,6 @@ impl nsStyleImage {
let atom = bindings::Gecko_GetImageElement(self);
Some(GenericImage::Element(... | 4 | 25 | 45 |
58e1f582c586c5bb5231c23be897519eff5fd399 | Emilio Cobos Álvarez | 2019-05-21T22:51:54 | Bug 1553227 - Remove old CSS scroll snap implementation. r=hiro
This will save us some time from figuring out what's the best thing to do in
bug 1552587, so that other patches I have in flight (mainly bug 1552708) can
land, since we cannot add a single byte to nsStyleDisplay right now otherwise.
The code removed here... | diff --git a/style/gecko/values.rs b/style/gecko/values.rs
index 8f777b9f7..8df853392 100644
--- a/style/gecko/values.rs
+++ b/style/gecko/values.rs
@@ -12,7 +12,6 @@ use crate::gecko_bindings::structs::{nsStyleCoord, CounterStylePtr};
use crate::gecko_bindings::sugar::ns_style_coord::{CoordData, CoordDataMut, CoordDa... | 9 | 2 | 192 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.