commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
9656dc62878e4a017901e22498f80e50dca2bd63 | Cosmin Sabou | 2019-05-21T23:05:22 | Backed out changeset a10cdf32fb5a (bug 1552549) for causing a spike in xpcshell failures. CLOSED TREE | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 9d1cec77f..54493548b 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -55,7 +55,7 @@ num-traits = "0.2"
num-derive = "0.2"
ordered-float = "1.0"
owning_ref = "0.4"
-parking_lot = "0.8"
+parking_lot = "0.6"
precomputed-hash = "0.1.1"
rayon = "1"
selecto... | 1 | 1 | 1 |
239ef952b7ebc2874ad5e1223c63b3dc9492d6b0 | Emilio Cobos Álvarez | 2019-05-21T21:07:55 | Bug 1553245 - Use cbindgen for border-image-width. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D32032 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 21e0c8d75..41fac1bd5 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -718,23 +718,6 @@ def set_gecko_property(ffi_name, expr):
}
</%def>
-<%def name="impl_style_sides(ident)">
- <% gecko_ffi... | 5 | 9 | 82 |
1154292862a4b2f630567c8e1a5fdf4783b73b44 | violet | 2019-05-21T15:35:41 | Bug 1550432 - Do not report error for unknown property if its known moz prefixed version is specified. r=emilio
Suppose that `prop` is a property that we haven't supported yet, while its `-moz-prop`
version is already supported.
If an author specifies in a declaration block this property in its standard form
as well ... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 1ce083c94..fcbfb717a 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -1301,11 +1301,9 @@ impl<'a, 'b, 'i> DeclarationParser<'i> for PropertyDeclarationParser<'a, 'b> {
... | 2 | 25 | 10 |
d4de2aadacb08ea7cd6d4421a79aa8060bf8615c | violet | 2019-05-16T13:21:19 | Bug 1383650 - Add SVG geometry property support in CSS r=emilio
This patch adds SVG geometry properties to CSS, it doesn't deal with
how SVG handles them.
Differential Revision: https://phabricator.services.mozilla.com/D29937 | diff --git a/style/properties/longhands/svg.mako.rs b/style/properties/longhands/svg.mako.rs
index 3e4d20739..8e93d03db 100644
--- a/style/properties/longhands/svg.mako.rs
+++ b/style/properties/longhands/svg.mako.rs
@@ -191,3 +191,66 @@ ${helpers.predefined_type(
animation_value_type="discrete",
flags="CREAT... | 1 | 63 | 0 |
8aae09e77954734751dd39d1ec42ff397437e40f | Boris Chiou | 2019-05-20T23:42:56 | Bug 1429299 - Part 4: Make offset-distance animatable. r=hiro
Use ComputedValue to animate offset-distance.
Differential Revision: https://phabricator.services.mozilla.com/D30584 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index a5c3b38b3..bddc56da8 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -413,7 +413,7 @@ ${helpers.predefined_type(
"LengthPercentage",
"computed::LengthPercentag... | 1 | 1 | 1 |
c97d78b6cdcdf15eaababc8478a979e5079a8241 | Boris Chiou | 2019-05-20T23:42:52 | Bug 1429299 - Part 2: Implement offset-distance. r=emilio
Define the offset-distance property in style system.
Differential Revision: https://phabricator.services.mozilla.com/D30582 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 032406274..a5c3b38b3 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -404,6 +404,19 @@ ${helpers.predefined_type(
gecko_pref="layout.css.motion-path.enabled",
... | 1 | 13 | 0 |
93ac30f074ff19436a2a34858a10765ee2eeda48 | Boris Chiou | 2019-05-20T23:42:50 | Bug 1429299 - Part 1: Unpack StyleMotion and use cbindgen for OffsetPath. r=emilio
Unpack StyleMotion and move its members into nsStyleDisplay, use
cbindgen to generate StyleOffsetPath.
Differential Revision: https://phabricator.services.mozilla.com/D31164 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 8c629bc44..21e0c8d75 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2205,8 +2205,7 @@ fn static_assert() {
transition-timing-function transition-property
... | 2 | 3 | 35 |
00f65129a09d0c31d43494df549c85a4f64e4c63 | Jonathan Kew | 2019-05-20T20:46:28 | Bug 1011369 - Add parsing of the loose|normal|strict values of the CSS line-break property. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D30785 | diff --git a/style/values/specified/text.rs b/style/values/specified/text.rs
index a78cb4135..1ab805cdc 100644
--- a/style/values/specified/text.rs
+++ b/style/values/specified/text.rs
@@ -1024,10 +1024,9 @@ pub enum WordBreak {
#[allow(missing_docs)]
pub enum LineBreak {
Auto,
- /// TODO: additional values n... | 1 | 3 | 4 |
9ac437b559a85b1bba42998025d68860766d53be | Emilio Cobos Álvarez | 2019-05-17T02:43:59 | Bug 1492739 - Unprefix user-select. r=mats
The CSSWG decided that our behavior regarding inheritance is what we want,
see [1].
[1]: https://github.com/w3c/csswg-drafts/issues/3344
Differential Revision: https://phabricator.services.mozilla.com/D11585 | diff --git a/style/properties/longhands/ui.mako.rs b/style/properties/longhands/ui.mako.rs
index 6d5258257..5c5156908 100644
--- a/style/properties/longhands/ui.mako.rs
+++ b/style/properties/longhands/ui.mako.rs
@@ -32,12 +32,11 @@ ${helpers.single_keyword(
)}
${helpers.predefined_type(
- "-moz-user-select",
+ ... | 1 | 2 | 3 |
5eeff82463405388631d4aa02f3266c7915a7636 | Brian Birtles | 2019-05-20T05:22:39 | Bug 1253476 - Use update() to update declarations from Servo_DeclarationBlock_SetPropertyToAnimationValue; r=emilio
This method is used when updating the SMIL override style and from Web
Animations' Animation.commitStyles method. By using update we accurately return
false when no change is made to a declaration block.... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 1e92066c7..ed71019b3 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -2337,6 +2337,14 @@ impl SourcePropertyDeclaration {
}
}
+ /// Create one with a single Prope... | 1 | 8 | 0 |
bad5573e5e0f5d189e1351bf8ef141ea9eb7baf7 | Brian Birtles | 2019-05-20T06:04:23 | Bug 1253476 - Implement Animation.commitStyles; r=boris,emilio,bzbarsky,smaug
Differential Revision: https://phabricator.services.mozilla.com/D30327 | diff --git a/style/gecko/boxed_types.rs b/style/gecko/boxed_types.rs
index 857f99e14..c32e06c97 100644
--- a/style/gecko/boxed_types.rs
+++ b/style/gecko/boxed_types.rs
@@ -5,12 +5,22 @@
//! FFI implementations for types listed in ServoBoxedTypeList.h.
use crate::gecko_bindings::sugar::ownership::{HasBoxFFI, HasFFI... | 2 | 10 | 9 |
2c3642857995b830865533c4d4d65b65d8f503ab | violet | 2019-05-20T07:01:29 | Bug 1520020 - Accept empty argument for some filters r=emilio
Filters blur(), invert(), etc. can omit argument.
Computed/specified style serialization is a little tricky w.r.t the shortest
serialization principle. Ideally we should serialize `invert(1)` to `invert()`,
but that will be a breaking change, so we always ... | diff --git a/style/values/specified/effects.rs b/style/values/specified/effects.rs
index d8c378a8a..3ffad2fa8 100644
--- a/style/values/specified/effects.rs
+++ b/style/values/specified/effects.rs
@@ -17,7 +17,7 @@ use crate::values::specified::color::Color;
use crate::values::specified::length::{Length, NonNegativeLe... | 1 | 41 | 10 |
65419f560a344ceda045705587820aff6aa2560b | Emilio Cobos Álvarez | 2019-05-18T04:48:16 | Bug 1552625 - Remove some more individual-transform dead code. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D31705 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index cffc1e50d..8c629bc44 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2197,38 +2197,6 @@ fn static_assert() {
${impl_copy_animation_value(ident, gecko_ffi_name)}
</%def>
-<%def name="impl_indiv... | 2 | 0 | 104 |
50d8fd343394ab8b965021888ebb1b7771494379 | Emilio Cobos Álvarez | 2019-05-16T23:06:17 | Bug 1551991 - Remove nsCSSValue bindings. r=jwatt
Depends on D31320
Differential Revision: https://phabricator.services.mozilla.com/D31321 | diff --git a/style/gecko/mod.rs b/style/gecko/mod.rs
index 43d38d7db..3ff2cfcf1 100644
--- a/style/gecko/mod.rs
+++ b/style/gecko/mod.rs
@@ -17,7 +17,6 @@ pub mod media_queries;
pub mod profiler;
pub mod pseudo_element;
pub mod restyle_damage;
-pub mod rules;
pub mod selector_parser;
pub mod snapshot;
pub mod sna... | 4 | 0 | 538 |
e0ce2ff4b03e492ff0090c94b5cbf169179f6b2f | Emilio Cobos Álvarez | 2019-05-16T23:05:00 | Bug 1551991 - Cleanup a bit the counter style code. r=jwatt
Use more compact types, and remove some manual implementations that can be
derived.
Differential Revision: https://phabricator.services.mozilla.com/D31315 | diff --git a/style/counter_style/mod.rs b/style/counter_style/mod.rs
index 77de5f52d..9e2bc096e 100644
--- a/style/counter_style/mod.rs
+++ b/style/counter_style/mod.rs
@@ -19,7 +19,6 @@ use selectors::parser::SelectorParseErrorKind;
use std::fmt::{self, Write};
use std::mem;
use std::num::Wrapping;
-use std::ops::R... | 2 | 57 | 81 |
5f23a071ebe2be9cd9cf8e00afede4143350e93e | Emilio Cobos Álvarez | 2019-05-16T23:25:10 | Bug 1529002 - Use cbindgen to back CSS transforms. r=boris
This avoids the expensive conversion, and cleans up a bunch.
Further cleanup is possible, just not done yet to avoid growing the patch even
more.
Differential Revision: https://phabricator.services.mozilla.com/D30748 | diff --git a/style/gecko_bindings/sugar/ns_css_value.rs b/style/gecko_bindings/sugar/ns_css_value.rs
index b59732bcc..96b48061c 100644
--- a/style/gecko_bindings/sugar/ns_css_value.rs
+++ b/style/gecko_bindings/sugar/ns_css_value.rs
@@ -276,29 +276,6 @@ impl nsCSSValue {
}
debug_assert!(values.next().... | 11 | 59 | 356 |
89099be3a7b0d370360be733859dc9256beb6ea8 | Emilio Cobos Álvarez | 2019-05-16T23:23:28 | Bug 1550554 - Use OwnedSlice for will-change. r=heycam
We could use ArcSlice if wanted I guess, your call. Though will change is not
supposed to be used very frequently.
Differential Revision: https://phabricator.services.mozilla.com/D30548 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 85befa09a..13b30b53b 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2513,7 +2513,7 @@ fn static_assert() {
transition-timing-function transition-property
... | 2 | 25 | 84 |
24a5118fc9e4965cd670abd5c2655d8daf974e1f | Emilio Cobos Álvarez | 2019-05-16T23:04:31 | Bug 1550554 - Use ArcSlice for quotes. r=heycam
This saves the intermediate allocation.
Differential Revision: https://phabricator.services.mozilla.com/D30546 | diff --git a/style/gecko/arc_types.rs b/style/gecko/arc_types.rs
index 309f23950..7aed10b65 100644
--- a/style/gecko/arc_types.rs
+++ b/style/gecko/arc_types.rs
@@ -23,7 +23,6 @@ use crate::gecko_bindings::structs::RawServoMediaRule;
use crate::gecko_bindings::structs::RawServoMozDocumentRule;
use crate::gecko_bindin... | 9 | 85 | 44 |
561743f0726ee69583470132417f69296829b5e1 | Emilio Cobos Álvarez | 2019-05-16T23:03:29 | Bug 1550554 - Share computed and specified value representation of -moz-context-properties. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D30545 | diff --git a/style/gecko_string_cache/mod.rs b/style/gecko_string_cache/mod.rs
index d71d19216..b8f3ff7f0 100644
--- a/style/gecko_string_cache/mod.rs
+++ b/style/gecko_string_cache/mod.rs
@@ -53,6 +53,7 @@ macro_rules! local_name {
/// This is either a strong reference to a dynamic atom (an nsAtom pointer),
/// or a... | 6 | 89 | 70 |
c4aec613e74f38870e114b564685405567e0ddbf | Emilio Cobos Álvarez | 2019-05-16T23:03:27 | Bug 1550554 - Use an ArcSlice as the computed value representation of inherited list properties. r=heycam
This adds a bit of complexity, which I think will pay off in the end. Removals
incoming.
Differential Revision: https://phabricator.services.mozilla.com/D30544 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 85345cb14..2f223fd97 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -3811,9 +3811,10 @@ fn static_assert() {
self.copy_text_shadow_from(other)
}
+ // FIXME(emilio): Remove by sharin... | 4 | 133 | 26 |
8d561b63b3abf3647703e8022ec5b105d9421247 | Emilio Cobos Álvarez | 2019-05-16T23:22:04 | Bug 1550554 - Implement ArcSlice::default(). r=heycam
Share a singleton to avoid allocating for empty lists.
Differential Revision: https://phabricator.services.mozilla.com/D30543 | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index f2f9fa006..09f381c62 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -612,16 +612,15 @@ impl<H, T> Arc<HeaderSlice<H, [T]>> {
use std::mem::{align_of, size_of};
assert_ne!(size_of::<T>(), 0, "Need to think about ZST");
+ let inner... | 4 | 52 | 21 |
6e779b285d7cf99e91420b390dfc59cebdb35eb8 | Emilio Cobos Álvarez | 2019-05-16T23:21:37 | Bug 1549593 - Use OwnedSlice in the specified and computed values of most vector properties. r=heycam
This is just a refactor in the right direction. Eventual goal is:
* All inherited properties use ArcSlice<>.
* All reset properties use OwnedSlice<> (or ThinVec<>).
No conversion happens at all, so we can remove a... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index fb651e7eb..85345cb14 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -3714,42 +3714,41 @@ fn static_assert() {
use crate::gecko_bindings::structs::NS_STYLE_FILTER_DROP_SHADOW;
use cra... | 9 | 100 | 107 |
83b9b2a59ad44883593a6c8b2bdf4e3df302231b | Emilio Cobos Álvarez | 2019-05-08T21:57:52 | Bug 1550554 - Share computed and specified value representation of -moz-context-properties. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D30545 | diff --git a/style/gecko_string_cache/mod.rs b/style/gecko_string_cache/mod.rs
index d71d19216..b8f3ff7f0 100644
--- a/style/gecko_string_cache/mod.rs
+++ b/style/gecko_string_cache/mod.rs
@@ -53,6 +53,7 @@ macro_rules! local_name {
/// This is either a strong reference to a dynamic atom (an nsAtom pointer),
/// or a... | 6 | 89 | 70 |
ed0017f9e7703db1c3c9a04053e18673a23355d2 | Emilio Cobos Álvarez | 2019-05-07T15:37:26 | Bug 1550554 - Implement ArcSlice::default(). r=heycam
Share a singleton to avoid allocating for empty lists.
Differential Revision: https://phabricator.services.mozilla.com/D30543 | diff --git a/style_traits/Cargo.toml b/style_traits/Cargo.toml
index 846579d46..acf464228 100644
--- a/style_traits/Cargo.toml
+++ b/style_traits/Cargo.toml
@@ -18,6 +18,7 @@ app_units = "0.7"
cssparser = "0.25"
bitflags = "1.0"
euclid = "0.19"
+lazy_static = "1"
malloc_size_of = { path = "../malloc_size_of" }
mal... | 3 | 34 | 7 |
90d85d2350fb470a2028c913f67c04fba0b90646 | Emilio Cobos Álvarez | 2019-05-15T08:57:36 | Bug 1550377 - Use ManuallyDrop for style structs. r=jwatt
We destroy them manually, so it's the right thing to do.
This allows us to not run destructors of any members of nsStyle*, which in turn allows us to:
* Remove the hack that replaced all nsStrings for nsStringReprs.
* Remove ns{,C}StringRepr (followup)
* A... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 703cbed2c..fb651e7eb 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -50,7 +50,7 @@ use crate::rule_tree::StrongRuleNode;
use crate::selector_parser::PseudoElement;
use servo_arc::{Arc, RawOffsetArc}... | 1 | 46 | 44 |
1ac1d74256bd2525160f347f1cfe1e0a9723416e | Brindusan Cristian | 2019-05-15T01:35:01 | Backed out changeset 2d0e8bded97a (bug 1550377) for build bustages on `self.gecko`. CLOSED TREE | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 4c37206db..703cbed2c 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -50,7 +50,7 @@ use crate::rule_tree::StrongRuleNode;
use crate::selector_parser::PseudoElement;
use servo_arc::{Arc, RawOffsetArc}... | 1 | 38 | 39 |
f7a0eb8d79120c55964835d17267c8f92c069a4b | Emilio Cobos Álvarez | 2019-05-14T22:44:40 | Bug 1550377 - Use ManuallyDrop for style structs. r=jwatt
We destroy them manually, so it's the right thing to do.
This allows us to not run destructors of any members of nsStyle*, which in turn allows us to:
* Remove the hack that replaced all nsStrings for nsStringReprs.
* Remove ns{,C}StringRepr (followup)
* A... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 703cbed2c..4c37206db 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -50,7 +50,7 @@ use crate::rule_tree::StrongRuleNode;
use crate::selector_parser::PseudoElement;
use servo_arc::{Arc, RawOffsetArc}... | 1 | 39 | 38 |
1027869c5c94dcfad3902b739899bfd30be79763 | Cameron McCormack | 2019-05-14T05:00:45 | Bug 1505908 - Add Gecko profiler labels for when the style threads are doing work. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D30869 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index e55a802fe..54493548b 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -22,6 +22,7 @@ servo = ["serde", "style_traits/servo", "servo_atoms", "servo_config", "html5eve
"cssparser/serde", "encoding_rs", "malloc_size_of/servo", "arrayvec/use_union",
... | 6 | 112 | 0 |
8c63d3d396f91eb2c916f94de8013bc3469b1f37 | Emilio Cobos Álvarez | 2019-05-09T17:21:58 | No bug - rustfmt recent style system changes. | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index b7c179cd1..f2f9fa006 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -687,7 +687,10 @@ impl<H, T> Arc<HeaderSlice<H, [T]>> {
}
// We should have consumed the buffer exactly, maybe accounting
// for some pad... | 7 | 31 | 27 |
23c7177dd2db28957af77a150d81a964c562ad1c | Emilio Cobos Álvarez | 2019-05-09T17:21:29 | No bug - Fix Servo build. | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 64239eeb8..6d754964e 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -680,5 +680,6 @@ ${helpers.predefined_type(
"Either::Second(None_)",
gecko_pref="layout.cs... | 1 | 1 | 0 |
759931808599177b01bb2759d580d4118eff4659 | Emilio Cobos Álvarez | 2019-05-09T12:43:19 | Bug 1549559 - Add bindings for ArcSlice and ThinArc, and use them to reduce copies of SVG path data. r=heycam
As I said over bug 1549593, the eventual goal is to use ArcSlice in all
inherited properties. But this seemed like a good first candidate that doesn't
require me to move around a lot more code, since we were a... | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index 09b819201..b7c179cd1 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -308,6 +308,9 @@ impl<T: ?Sized> Arc<T> {
impl<T: ?Sized> Clone for Arc<T> {
#[inline]
fn clone(&self) -> Self {
+ // NOTE(emilio): If you change anything here, make sure... | 5 | 39 | 41 |
f2d6c05ba10e173c063d1d190e8b10e6a83cbffb | Emilio Cobos Álvarez | 2019-05-09T10:53:50 | Bug 1549559 - Introduce ArcSlice, a small wrapper over ThinArc but without an explicit header. r=heycam
We could make the header PhantomData or something, but then we wouldn't be able
to bind to C++, since C++ doesn't have ZSTs. So add a canary instead to add a
runtime check of stuff being sane.
Differential Revision... | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index 40a8ff3d1..09b819201 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -784,6 +784,13 @@ pub struct ThinArc<H, T> {
phantom: PhantomData<(H, T)>,
}
+
+impl<H: fmt::Debug, T: fmt::Debug> fmt::Debug for ThinArc<H, T> {
+ fn fmt(&self, f: &mut fmt::Fo... | 6 | 98 | 3 |
ebdc92e71b92460c4f84c954c2df346005c55c31 | Emilio Cobos Álvarez | 2019-05-09T10:49:50 | Bug 1549593 - Move OwnedSlice to style_traits. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D30126 | diff --git a/style/lib.rs b/style/lib.rs
index 65f2eda52..10d454080 100644
--- a/style/lib.rs
+++ b/style/lib.rs
@@ -143,7 +143,6 @@ pub mod logical_geometry;
pub mod matching;
#[macro_use]
pub mod media_queries;
-pub mod owned_slice;
pub mod parallel;
pub mod parser;
pub mod rule_cache;
@@ -189,7 +188,7 @@ pub u... | 3 | 4 | 2 |
da8facf0b85b1875f011a03be14fcb7831ab13e0 | Emilio Cobos Álvarez | 2019-05-09T11:24:57 | Bug 1548691 - Use the owned slice type for basic shape polygon coordinates. r=TYLin,heycam
This enables destructors for tagged unions in cbindgen, implemented in:
* https://github.com/eqrion/cbindgen/pull/333
Which allow us to properly generate a destructor for the cbindgen-generated
StyleBasicShape (which now cont... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 4cd5722bd..748396630 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -532,28 +532,17 @@ impl nsStyleImage {
pub mod basic_shape {
//! Conversions from and to CSS shape representations.
-
- use crate::gecko:... | 9 | 79 | 218 |
2bddac9895864468bec247505b720cffc8f5eccb | Emilio Cobos Álvarez | 2019-05-09T10:49:22 | Bug 1548691 - Add an owned slice type which cbindgen can understand. r=heycam
Passing these by value won't be ok of course, but that's fine.
I plan to combine this with https://github.com/eqrion/cbindgen/pull/333 to
actually be able to share representation for ~all the things, this is just the
first bit.
Box<T>, Ato... | diff --git a/style/lib.rs b/style/lib.rs
index bd33dbeaf..65f2eda52 100644
--- a/style/lib.rs
+++ b/style/lib.rs
@@ -143,6 +143,7 @@ pub mod logical_geometry;
pub mod matching;
#[macro_use]
pub mod media_queries;
+pub mod owned_slice;
pub mod parallel;
pub mod parser;
pub mod rule_cache;
@@ -188,6 +189,8 @@ pub u... | 6 | 252 | 1 |
5d6e95d4b210e6f8a892a7dadedb880c78ab4f69 | Emilio Cobos Álvarez | 2019-05-09T03:45:10 | Bug 1550389 - Remove unnecessary mut usage. | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 5ce80955a..1ce083c94 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -1382,7 +1382,7 @@ fn report_css_errors(
selectors: Option<&SelectorList<SelectorImpl>>,
error... | 1 | 1 | 1 |
b8c9f10189b6188bc85cee629be7eae25c80b8fe | Emilio Cobos Álvarez | 2019-05-08T18:03:37 | Bug 1549969 - Fix an assertion that doesn't account for alignment padding. r=bholley
I'm hitting this when trying to add bindings for box shadows, which are 32-bit
aligned.
Depends on D30352
Differential Revision: https://phabricator.services.mozilla.com/D30353 | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index 3cc2b0e7f..40a8ff3d1 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -602,7 +602,7 @@ impl<H, T> Arc<HeaderSlice<H, [T]>> {
F: FnOnce(Layout) -> *mut u8,
I: Iterator<Item = T> + ExactSizeIterator,
{
- use std::mem::size_of;
+ ... | 1 | 21 | 3 |
2c948d339c14b4a4c38cf5f1b33179e8b8d49ff8 | Emilio Cobos Álvarez | 2019-05-08T17:54:25 | Bug 1549969 - Don't panic when creating empty ThinArcs. r=bholley
The change from [T; 1] to [T; 0] shouldn't change behavior since they have the
right alignment and we never poke at that particular array, but feels more
correct to avoid creating types that point to uninitialized data or outside of
their allocation, no... | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index 780f7485e..3cc2b0e7f 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -168,7 +168,7 @@ impl<T> Arc<T> {
pub fn new(data: T) -> Self {
let x = Box::new(ArcInner {
count: atomic::AtomicUsize::new(1),
- data: data,
+ ... | 1 | 31 | 17 |
b1087f2566a447104750b2bff79b100a42088286 | Emilio Cobos Álvarez | 2019-05-08T12:44:46 | Bug 1538101 - Don't report errors for properties for which we've parsed another value in the same declaration block. r=jdm
I thought a bit about how to test it and it's not particularly great.
test_css_parse_error_smoketest.html is great to assert that something _gets_
reported, but not that it doesn't :)
Differentia... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 29e6ce1fd..5ce80955a 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -1269,7 +1269,7 @@ pub fn parse_one_declaration_into(
struct PropertyDeclarationParser<'a, 'b: 'a> {
... | 1 | 23 | 2 |
4dbbba3e721c758da6b07f3a9cacf3cbc35c1704 | Dorel Luca | 2019-05-08T15:21:30 | Backed out changeset eee17e1b0435 (bug 1538101) for Browser-chrome and DT failures. CLOSED TREE | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 8ef55b21d..29e6ce1fd 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -1328,7 +1328,7 @@ type SmallParseErrorVec<'i> = SmallVec<[(ParseError<'i>, &'i str, Option<Propert
#[c... | 1 | 1 | 21 |
d3870738e16eef007c133d6437064582e01ab1dc | Emilio Cobos Álvarez | 2019-05-08T12:44:46 | Bug 1538101 - Don't report errors for properties for which we've parsed another value in the same declaration block. r=jdm
I thought a bit about how to test it and it's not particularly great.
test_css_parse_error_smoketest.html is great to assert that something _gets_
reported, but not that it doesn't :)
Differentia... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 29e6ce1fd..8ef55b21d 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -1328,7 +1328,7 @@ type SmallParseErrorVec<'i> = SmallVec<[(ParseError<'i>, &'i str, Option<Propert
#[c... | 1 | 21 | 1 |
20a699280b2f4597bbace079acaee82b38f493f9 | Emilio Cobos Álvarez | 2019-05-08T12:44:36 | Bug 1538101 - Centralize a bit invalid value error reporting. r=jdm
Also, buffer the errors, since we're going to want to look at the whole
declaration block to skip reporting them.
This shouldn't change behavior, just moves some work to the caller, and defers a
bit the work so that it happens only when error reporti... | diff --git a/style/parser.rs b/style/parser.rs
index f3190f7f7..f9322a7bc 100644
--- a/style/parser.rs
+++ b/style/parser.rs
@@ -136,6 +136,12 @@ impl<'a> ParserContext<'a> {
.expect("Rule type expected, but none was found.")
}
+ /// Returns whether CSS error reporting is enabled.
+ #[inline]
... | 3 | 87 | 43 |
6e4ae421b49c0b6bf019ae4012d7a53fe853031b | Emilio Cobos Álvarez | 2019-05-08T08:01:01 | Bug 1549596 - Use PhantomData<T> in servo_arc. r=bholley
See https://github.com/rust-lang/rust/pull/60594#issuecomment-489966933
Differential Revision: https://phabricator.services.mozilla.com/D30169 | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index 7d8923860..780f7485e 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -86,10 +86,14 @@ const STATIC_REFCOUNT: usize = usize::MAX;
/// See the documentation for [`Arc`] in the standard library. Unlike the
/// standard library `Arc`, this `Arc` does not supp... | 1 | 14 | 1 |
0b9c93e70b3b9b263e64e12ad0f69d1b01c79492 | Emilio Cobos Álvarez | 2019-05-07T03:16:21 | Bug 1549596 - ThinArc should use NonNull. r=bholley
If only for parallelism with Arc<>.
Differential Revision: https://phabricator.services.mozilla.com/D30131 | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index f4a929e23..7d8923860 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -21,7 +21,7 @@
//!
//! [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1360883
-// The semantics of `Arc` are alread documented in the Rust docs, so we don't
+// The semantics of `Ar... | 1 | 9 | 7 |
971951a99e7b4c441d179ace03cbcda7495b1de1 | Emilio Cobos Álvarez | 2019-05-07T10:59:40 | No bug - Cherry-pick some Servo removals from malloc_size_of. r=npotb | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index e7acb0de2..609a977b1 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -14,7 +14,6 @@ servo = [
"hyper",
"hyper_serde",
"keyboard-types",
- "mozjs",
"serde",
"serde_bytes",
"string_cache",
@... | 2 | 0 | 13 |
655244e96a1b1ed2cc6f9efbb3459b63b1c31f3b | Emilio Cobos Álvarez | 2019-05-06T21:31:16 | Bug 1549589 - scroll-snap-coordinate shouldn't use NotInitial. r=hiro
The initial value for this is indeed `none` (and thus empty). The Rust code was
confused.
This property is disabled by default these days, and I think the
get_initial_value() function, which is what could get confused, is not called
for this proper... | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 397393ed3..a7a2cb9e3 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -337,11 +337,11 @@ ${helpers.predefined_type(
"Position",
"computed::Position::zero()",
... | 1 | 1 | 1 |
2fb41aaf2b983dc3674c99822e0871e2f4dc3176 | Emilio Cobos Álvarez | 2019-05-06T08:06:26 | Bug 1549301 - Fix Servo build. | diff --git a/style/servo/selector_parser.rs b/style/servo/selector_parser.rs
index 9d94c467b..1ef49c87f 100644
--- a/style/servo/selector_parser.rs
+++ b/style/servo/selector_parser.rs
@@ -66,10 +66,6 @@ pub const PSEUDO_COUNT: usize = PseudoElement::ServoInlineAbsolute as usize + 1;
impl ::selectors::parser::Pseudo... | 1 | 13 | 4 |
4f3126074a564f23516340ce9e0cd7c356293e1d | Emilio Cobos Álvarez | 2019-05-05T11:35:24 | Bug 1549301 - Rustfmt recent style system changes. | diff --git a/selectors/builder.rs b/selectors/builder.rs
index 73c157537..b548ceb83 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -270,8 +270,7 @@ where
Component::Combinator(..) => {
unreachable!("Found combinator in simple selectors vector?");
},
- ... | 10 | 73 | 56 |
b052485bbe5e4692b4f895eaa8156504fa958daa | Emilio Cobos Álvarez | 2019-05-05T11:33:53 | Bug 1549301 - Import style system changes for Servo's Shadow DOM support. | diff --git a/style/author_styles.rs b/style/author_styles.rs
index ed2c42b11..58d9bda42 100644
--- a/style/author_styles.rs
+++ b/style/author_styles.rs
@@ -18,6 +18,7 @@ use crate::stylist::CascadeData;
/// A set of author stylesheets and their computed representation, such as the
/// ones used for ShadowRoot.
+#[... | 2 | 11 | 0 |
23c63985859414f27052319c75faa443327655e6 | Emilio Cobos Álvarez | 2019-05-05T11:29:14 | Bug 1549301 - Fix some warnings. | diff --git a/derive_common/lib.rs b/derive_common/lib.rs
index 1e8d20aa3..144153514 100644
--- a/derive_common/lib.rs
+++ b/derive_common/lib.rs
@@ -3,7 +3,6 @@
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
extern crate darling;
-extern crate proc_macro;
extern crate proc_macro2;
#[macro_use]
e... | 4 | 1 | 4 |
79c31a4dbee84f3fbf5cf0d5e94cdaea92bf4785 | Ian Moody | 2019-04-18T12:34:32 | Bug 1549301 - Remove :-servo-case-sensitive-type-attr().
No longer needed now that the case-sensitive flag for attributes selectors is
supported.
Update user-agent CSS sheet to use the standard flag.
Fixes #23227
This cherry-picks https://github.com/servo/servo/pull/23228. | diff --git a/style/servo/selector_parser.rs b/style/servo/selector_parser.rs
index d839654a6..a67f97025 100644
--- a/style/servo/selector_parser.rs
+++ b/style/servo/selector_parser.rs
@@ -282,7 +282,6 @@ pub enum NonTSPseudoClass {
ReadWrite,
ReadOnly,
ServoNonZeroBorder,
- ServoCaseSensitiveTypeAttr... | 1 | 6 | 26 |
5f3ea1099d2df73f683b783cc7371cebfe5084a3 | Mats Palmgren | 2019-05-06T00:43:50 | Bug 1549223 - [css-grid-2] Remove single keyword 'subgrid' as a valid value for the 'grid' and 'grid-template' shorthands. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D29974 | diff --git a/style/properties/shorthands/position.mako.rs b/style/properties/shorthands/position.mako.rs
index aaf97a067..6fdbe1235 100644
--- a/style/properties/shorthands/position.mako.rs
+++ b/style/properties/shorthands/position.mako.rs
@@ -254,7 +254,7 @@
use crate::parser::Parse;
use servo_arc::Arc;
... | 1 | 4 | 5 |
7b3a4dec2081ac2a810c47b7b05d5638d868bee6 | Jeremy Ir | 2019-05-05T23:39:27 | Bug 1548341 - Convert NS_STYLE_BORDER to an enum class in nsStyleConsts.h. r=dholbert
Converting the NS_STYLE_BORDER definitions in to enumerated classes as
per bug 1277133.
The original constants broke the convention used by the rest of the
definitions as the CSS property being described is `border-collapse`,
so cor... | diff --git a/style/properties/longhands/inherited_table.mako.rs b/style/properties/longhands/inherited_table.mako.rs
index 7dc4d73fe..246a073d2 100644
--- a/style/properties/longhands/inherited_table.mako.rs
+++ b/style/properties/longhands/inherited_table.mako.rs
@@ -9,7 +9,7 @@
${helpers.single_keyword(
"border... | 1 | 1 | 1 |
1e80f90ce6b75cf832536eb5d914d66ecf6bb488 | Masayuki Nakano | 2019-05-01T02:28:25 | Bug 253889 - part 3: Move all remaining members of nsIPresShell to mozilla::PresShell r=emilio
Additionally, this sorts out the order of member variables for minimizing the
instance size.
And also this changes `enum RenderFlags` to `enum class RenderingStateFlags`.
Differential Revision: https://phabricator.services... | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index b39e748ce..4c04d9573 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -169,7 +169,6 @@ impl Device {
self.document()
.mPresShell
.as_ref()?
- ._base... | 1 | 0 | 1 |
43bcef595e22aabe13d1f142fbdc14a32938d914 | Noemi Erli | 2019-05-01T19:03:06 | Backed out changeset 8c89fd37b79d (bug 1544242) for failures in browser_rules_shadowdom_slot_rules.js CLOSED TREE | diff --git a/selectors/builder.rs b/selectors/builder.rs
index 2e8c61411..73c157537 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -84,6 +84,12 @@ impl<Impl: SelectorImpl> SelectorBuilder<Impl> {
self.current_len = 0;
}
+ /// Returns true if no simple selectors have ever been pushed ... | 9 | 34 | 44 |
35f4419cc5ae70b6a720d29a2bf2a1f6f369b63b | Emilio Cobos Álvarez | 2019-05-01T17:28:23 | Bug 1545430 - Implement selector-matching for ::part(). r=heycam
Also fairly straight-forward. This may get more complicated when we do part
forwarding, if any.
I've opened https://github.com/w3c/csswg-drafts/issues/3841 in what I think
would be a cleaner model for forwarding.
Differential Revision: https://phabrica... | diff --git a/style/gecko/snapshot.rs b/style/gecko/snapshot.rs
index 6ac4003fa..d294939ba 100644
--- a/style/gecko/snapshot.rs
+++ b/style/gecko/snapshot.rs
@@ -183,13 +183,23 @@ impl ElementSnapshot for GeckoElementSnapshot {
snapshot_helpers::get_id(&*self.mAttrs)
}
+ #[inline]
+ fn is_part(&sel... | 4 | 40 | 12 |
64b71235e60a56b6e3a0fd61afc33ed147d0e5fe | Emilio Cobos Álvarez | 2019-05-01T17:25:13 | Bug 1545425 - Add parsing support for ::part(). r=heycam
Disabled for now of course. This should be pretty uncontroversial I'd think.
Differential Revision: https://phabricator.services.mozilla.com/D28060 | diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs
index 629cb1f08..ed3d76fbd 100644
--- a/malloc_size_of/lib.rs
+++ b/malloc_size_of/lib.rs
@@ -749,6 +749,7 @@ where
Component::ExplicitUniversalType |
Component::LocalName(..) |
Component::ID(..) |
+ Component::... | 10 | 106 | 17 |
96f1e57bcba2b78a8ba1cfa7d4fa83c580335c05 | Emilio Cobos Álvarez | 2019-05-01T17:19:08 | Bug 1544242 - Fix selector-matching for nested pseudo-elements. r=heycam,mats
We always include the combinator for pseudo-elements now (not including it was
just an optimization) in order to not match when nested pseudo-elements are
involved.
We could add a more generic check in `matches_simple_selector` like:
```
i... | diff --git a/selectors/builder.rs b/selectors/builder.rs
index 72404de10..f95ea0bfd 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -84,12 +84,6 @@ impl<Impl: SelectorImpl> SelectorBuilder<Impl> {
self.current_len = 0;
}
- /// Returns true if no simple selectors have ever been pushed ... | 9 | 44 | 34 |
870aac523d8dceb12bcc688591dc9153f7fe4f6f | Emilio Cobos Álvarez | 2019-04-29T05:58:56 | Bug 1544242 - Check iterator length in SelectorIter::is_featureless_host_selector. r=heycam
I'm going to unconditionally generate the PseudoElement combinator, and this
causes issues since we'll put the raw `::pseudo` selectors in the host bucket,
which is obviously wrong.
Differential Revision: https://phabricator.s... | diff --git a/selectors/parser.rs b/selectors/parser.rs
index e3afab57e..21459e4e4 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -736,7 +736,8 @@ impl<'a, Impl: 'a + SelectorImpl> SelectorIter<'a, Impl> {
/// combinators to the left.
#[inline]
pub(crate) fn is_featureless_host_selector(&mu... | 1 | 2 | 1 |
39aab3c6f5ce749b6fe6c76a5a440cab63e46636 | Emilio Cobos Álvarez | 2019-05-01T13:08:34 | Bug 1547985 - Use rust types for vertical-align. r=mats
The previous commit removed the dependence on the discriminant value, so we
don't need to keep discriminants different from text-align anymore.
Differential Revision: https://phabricator.services.mozilla.com/D29361 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 7b73f00e7..4cd5722bd 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -22,7 +22,6 @@ use crate::values::computed::url::ComputedImageUrl;
use crate::values::computed::{Angle, Gradient, Image};
use crate::values::compu... | 5 | 34 | 93 |
71175dece0213cf25cabbae05b4ea47f5eefb333 | Emilio Cobos Álvarez | 2019-04-30T20:37:54 | Bug 1547674 - Use rust types for gradient stops. r=boris
This doesn't clean up all that much, yet, but it's a step in the right
direction.
Differential Revision: https://phabricator.services.mozilla.com/D29168 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 44dbc1bb0..7b73f00e7 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -24,7 +24,7 @@ use crate::values::computed::{Integer, LengthPercentage};
use crate::values::computed::{Length, Percentage, TextAlign};
use crate::... | 4 | 52 | 63 |
bef5d33c86e7f273516a26be5f7a6be5fe39c6aa | Emilio Cobos Álvarez | 2019-04-30T19:48:27 | Bug 1547939 - Add a pref for a simpler -moz- gradient parsing. r=dholbert
This won't reintroduce any of the regressions that were triggered by our
previous attempts to turn off -moz prefixed gradients, and lets us massively
simplify the gradient code, if it sticks.
Differential Revision: https://phabricator.services.... | diff --git a/style/values/specified/image.rs b/style/values/specified/image.rs
index 572db0ca1..84571a43a 100644
--- a/style/values/specified/image.rs
+++ b/style/values/specified/image.rs
@@ -8,6 +8,8 @@
//! [image]: https://drafts.csswg.org/css-images/#image-values
use crate::custom_properties::SpecifiedValue;
+#... | 1 | 27 | 25 |
75b00976e7bc1174dd037ed494976bb54b3d12ad | Emilio Cobos Álvarez | 2019-04-29T08:04:22 | Bug 1547619 - Fix :-moz-svg-use-shadow-tree-root pseudo-class. r=violet
Turns out removing the pseudo-class and such ends up not being quite as trivial
as I initially thought, or possible at all, since the fact that the <symbol> is
a <symbol> is observable via selectors, added a test for that.
Differential Revision: ... | diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs
index c295b795f..079dde2f5 100644
--- a/style/gecko/wrapper.rs
+++ b/style/gecko/wrapper.rs
@@ -865,10 +865,11 @@ impl<'le> GeckoElement<'le> {
if !self.as_node().is_in_shadow_tree() {
return false;
}
- match self.contain... | 1 | 4 | 3 |
a7cbe6cc6c3fa3bc02176a06bdf39123523b8b77 | Emilio Cobos Álvarez | 2019-04-23T16:43:15 | Bug 1546046 - Remove support for XBL resources. r=TYLin
So much unsound code going away :-)
Differential Revision: https://phabricator.services.mozilla.com/D28380 | diff --git a/selectors/context.rs b/selectors/context.rs
index 3ecd4dd82..95caa4055 100644
--- a/selectors/context.rs
+++ b/selectors/context.rs
@@ -279,13 +279,13 @@ where
/// Runs F with a given shadow host which is the root of the tree whose
/// rules we're matching.
#[inline]
- pub fn with_shadow_... | 10 | 22 | 208 |
e6762b6765e9a690f7a0f29dd84e4bbaac3bd8fe | Emilio Cobos Álvarez | 2019-04-23T13:13:11 | Bug 1544886 - Allow CSS wide-keywords in custom property fallback. r=SimonSapin
Differential Revision: https://phabricator.services.mozilla.com/D28349 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 9943c3509..e7f9c7241 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -1085,6 +1085,8 @@ impl LonghandId {
}
}
+ // TODO(emilio): Should we use a function table li... | 1 | 77 | 59 |
62e18acfd9cef2f915c5d846c0fee0331e479139 | Bogdan Tara | 2019-04-23T03:55:29 | Backed out changeset e85cb54e5944 (bug 1546046) complementary backout after 1470880 was backed out CLOSED TREE | diff --git a/selectors/context.rs b/selectors/context.rs
index 95caa4055..3ecd4dd82 100644
--- a/selectors/context.rs
+++ b/selectors/context.rs
@@ -279,13 +279,13 @@ where
/// Runs F with a given shadow host which is the root of the tree whose
/// rules we're matching.
#[inline]
- pub fn with_shadow_... | 10 | 208 | 22 |
decb02da38e3fa6b8eae6412b2be745e2aeff691 | Emilio Cobos Álvarez | 2019-04-22T19:45:06 | Bug 1545979 - Drop unused user-agent cascade datas when not holding the cache lock. r=bholley
We want to drop the cascade data memory as soon as possible, so bug 1544546
introduced an UpdateStylistIfNeeded call from ShellDetachedFromDocument.
Unfortunately, this call can reenter into the global user-agent cascade dat... | diff --git a/style/stylist.rs b/style/stylist.rs
index ad7f9fd85..a22d85046 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -48,7 +48,8 @@ use selectors::visitor::SelectorVisitor;
use selectors::NthIndexCache;
use servo_arc::{Arc, ArcBorrow};
use smallbitvec::SmallBitVec;
-use std::ops;
+use smallvec::SmallV... | 1 | 34 | 15 |
295050ac6b287641863b9eb12101ded822bc8967 | Emilio Cobos Álvarez | 2019-04-19T04:41:17 | Bug 1545440 - Don't allow to parse XUL tree pseudo-elements with a single colon. r=mats
Now that they're not exposed to the web we can remove this special case.
Differential Revision: https://phabricator.services.mozilla.com/D28071 | diff --git a/selectors/parser.rs b/selectors/parser.rs
index afb728050..e3afab57e 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -191,12 +191,6 @@ pub trait Parser<'i> {
type Impl: SelectorImpl;
type Error: 'i + From<SelectorParseErrorKind<'i>>;
- /// Whether the name is a pseudo-element t... | 2 | 2 | 13 |
3c605e53dc758c12693242456967e2fe0bf44a05 | Emilio Cobos Álvarez | 2019-04-19T04:20:31 | Bug 1544535 - Bug 1542263 - Don't keep two list of stylesheets in ServoStyleSet. r=firefox-style-system-reviewers,jwatt
Just one set of stylesheets is enough. While at it, unify SheetType and Origin.
Differential Revision: https://phabricator.services.mozilla.com/D27564 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 43438438a..44dbc1bb0 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -13,9 +13,9 @@
use crate::gecko::values::GeckoStyleCoordConvertible;
use crate::gecko_bindings::bindings;
use crate::gecko_bindings::structs::{se... | 4 | 26 | 18 |
eaeaa1cf98d6a0d7f9c15b77bbc0156aefa9b123 | Razvan Maries | 2019-04-18T23:06:41 | Backed out changeset 24d0d307385d (bug 1545440) for perma failures on browser_parsable_css.js. CLOSED TREE | diff --git a/selectors/parser.rs b/selectors/parser.rs
index e3afab57e..afb728050 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -191,6 +191,12 @@ pub trait Parser<'i> {
type Impl: SelectorImpl;
type Error: 'i + From<SelectorParseErrorKind<'i>>;
+ /// Whether the name is a pseudo-element t... | 2 | 13 | 2 |
71b732814558d911cef65b6c1487864895fb54d8 | Mats Palmgren | 2019-04-17T23:16:03 | Bug 1500708 - [cssom][css-grid] 'grid-auto-flow: row dense' should serialize to 'dense' since 'row' is implied. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D28058 | diff --git a/style/values/specified/position.rs b/style/values/specified/position.rs
index f75af3f55..c0ac56c98 100644
--- a/style/values/specified/position.rs
+++ b/style/values/specified/position.rs
@@ -460,6 +460,11 @@ pub enum AutoFlow {
Column,
}
+/// If `dense` is specified, `row` is implied.
+fn is_row_d... | 1 | 6 | 0 |
c98d629d943f3b4ecd7c1df40a7214cd4a3bef83 | Emilio Cobos Álvarez | 2019-04-16T15:34:50 | No bug - Unify a bit Servo and Gecko code in properties.mako.rs.
Mostly removing #[cfg] statements, so npotb. | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 95afdd56a..2dde6af2a 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1104,9 +1104,6 @@ impl ${style_struct.gecko_struct_name} {
}
result
}
- pub fn get_gecko(&self) -> &${sty... | 2 | 2 | 7 |
f8f2b362e870b9c23788d005bc23b23364ec2693 | Emilio Cobos Álvarez | 2019-04-16T13:16:56 | Bug 1543808 - Refactor the selector parser to make implementing ::part() easier. r=xidorn
::slotted() is already weird in the sense that it supports a pseudo-element
afterwards (so ::slotted(*)::before is valid for example).
::part() is weirder because you are supposed to allow stuff like
::part(foo):hover, ::part(fo... | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 0515eaca1..afb728050 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -30,17 +30,10 @@ pub trait PseudoElement: Sized + ToCss {
/// Whether the pseudo-element supports a given state selector to the right
/// of it.
- fn supports_ps... | 3 | 189 | 191 |
ffba5f2d9d917524fbf5e23bd6171a18393cc4c0 | Emilio Cobos Álvarez | 2019-04-15T20:11:45 | Bug 1543672 - The counters code should use atoms rather than strings. r=mats,boris
Servo already atomizes the counter names, it makes no sense to copy the string
rather than bumping the refcount.
Differential Revision: https://phabricator.services.mozilla.com/D27061 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 81e1ee430..95afdd56a 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -4455,7 +4455,7 @@ clip-path
fn set_counter_function(
data: &mut nsStyleContentData,
content_type... | 2 | 31 | 19 |
0f9b45fb867ccb87e108f9892c6cde235e9b0d57 | Emilio Cobos Álvarez | 2019-04-11T21:55:42 | Bug 1543837 - Fix servo build and appease tidy. | diff --git a/style/Cargo.toml b/style/Cargo.toml
index caa4b33e7..e55a802fe 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -20,7 +20,7 @@ gecko = ["nsstring", "style_traits/gecko", "fallible/known_system_malloc"]
use_bindgen = ["bindgen", "regex", "toml"]
servo = ["serde", "style_traits/servo", "servo_atoms"... | 17 | 93 | 45 |
4facb0a81252b418d40cea4130629b793e8d1da4 | Emilio Cobos Álvarez | 2019-04-11T15:21:17 | Bug 1539171 - Make the list-item increment not visible from the computed style. r=mats
This is per https://drafts.csswg.org/css-lists/#declaring-a-list-item.
I intentionally kept <li value> defined using attribute mapping, I think that's
saner than special-casing it in layout.
Differential Revision: https://phabrica... | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index e0efe35c8..63af60e16 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -723,44 +723,6 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
}
}
- /// For HTML elements with 'display:list-item' we add a default 'counter-inc... | 1 | 0 | 39 |
7b279721a49aaba326f3798f66145c6700edf1e5 | Hiroyuki Ikezoe | 2019-04-11T06:22:01 | Bug 1531228 - Enable the new scroll snap and disable the old scroll snap on nightly. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D22804 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 87d4f59af..397393ed3 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -432,7 +432,6 @@ ${helpers.predefined_type(
"ScrollSnapType",
"computed::ScrollSnapType::n... | 1 | 0 | 1 |
692e08810c0223899ee665f2968f4c08238aeca8 | Emilio Cobos Álvarez | 2019-04-10T16:00:03 | Bug 1543401 - Use rust lengths for row-gap / column-gap. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D26915 | diff --git a/style/gecko/values.rs b/style/gecko/values.rs
index 946fa437d..8b05e1520 100644
--- a/style/gecko/values.rs
+++ b/style/gecko/values.rs
@@ -18,7 +18,7 @@ use crate::values::generics::gecko::ScrollSnapPoint;
use crate::values::generics::grid::{TrackBreadth, TrackKeyword};
use crate::values::generics::leng... | 8 | 48 | 72 |
0d573519fd940b9cf42045839799ef5bfce26451 | Emilio Cobos Álvarez | 2019-04-10T12:10:49 | Bug 1542178 - Fix ToResolvedValue implementation for caret-color, and serialize some color properties with Servo. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D26785 | diff --git a/style/values/generics/color.rs b/style/values/generics/color.rs
index 0f67f4eb7..5aa287baa 100644
--- a/style/values/generics/color.rs
+++ b/style/values/generics/color.rs
@@ -99,7 +99,6 @@ impl<RGBA> From<RGBA> for Color<RGBA> {
ToAnimatedZero,
ToComputedValue,
ToCss,
- ToResolvedValue,
... | 3 | 48 | 20 |
f64fdad861aace0ab1a65b142f4db29c79255a31 | Emilio Cobos Álvarez | 2019-04-10T12:10:40 | Bug 1542178 - Use ToResolvedValue for computed style serialization. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D26784 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index bb9a9ef64..5f44a2596 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -39,7 +39,7 @@ use style_traits::{SpecifiedValueInfo, StyleParseErrorKind, ToCss};
use to_shmem::impl_trivial_t... | 1 | 8 | 8 |
01302936c6e6f6be777694da7a60b3ed08835723 | Emilio Cobos Álvarez | 2019-04-10T12:10:11 | Bug 1542178 - Add derive code for a new ToResolvedValue trait, and a few trivial implementations. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D26782 | diff --git a/style/values/resolved/mod.rs b/style/values/resolved/mod.rs
new file mode 100644
index 000000000..8d5aa2211
--- /dev/null
+++ b/style/values/resolved/mod.rs
@@ -0,0 +1,208 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distribute... | 2 | 277 | 0 |
0504561188598df1e3148eafbfaec2cb738fcd9d | Mats Palmgren | 2019-04-09T21:01:44 | Bug 1543249 - Remove a note about <li value> style mapping that is no longer true. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D26814 | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 91e4bba99..e0efe35c8 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -740,9 +740,7 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
if self.style.pseudo.is_some() {
return;
}
- // Note that we map... | 1 | 1 | 3 |
c2cc07259a56831e5b817d0b6a3475f5d8414990 | Emilio Cobos Álvarez | 2019-04-09T18:03:41 | Bug 1540220 - Cleanup unused style traversal flags. r=dholbert
Some of these were unused, some of them were only used in combination with
others, so I've unified them.
In particular, Forgetful and ClearAnimationOnlyDirtyDescendants were used only
together for a very specific task (the final animation traversal), so I... | diff --git a/style/dom.rs b/style/dom.rs
index 63f82a375..967b978ba 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -642,15 +642,6 @@ pub trait TElement:
self.unset_dirty_descendants();
}
- /// Clear all element flags related to dirtiness.
- ///
- /// In Gecko, this corresponds to the regular d... | 5 | 10 | 60 |
2edccc9148f076a0f86e8708073e1f3af62adb9f | Emilio Cobos Álvarez | 2019-04-09T11:34:24 | No bug - Remove a redundant use statement. | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 486690989..e51ba6bfa 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -339,8 +339,6 @@ mod bindings {
}
fn setup_logging() -> bool {
- use log;
-
struct BuildLogger {
file: Option<Mutex<fs::File>>,
... | 1 | 0 | 2 |
cae53563eaf25edff7a810d4538ac7b143ac74a3 | Emilio Cobos Álvarez | 2019-04-09T01:48:18 | Bug 1542179 - Handle the non-generic path earlier in the derive code. r=heycam
No need to build the match body if there are no generics. This should hopefully
save some work too.
Depends on D26289
Differential Revision: https://phabricator.services.mozilla.com/D26290 | diff --git a/style_derive/to_computed_value.rs b/style_derive/to_computed_value.rs
index 87d4f8ba0..6010b7483 100644
--- a/style_derive/to_computed_value.rs
+++ b/style_derive/to_computed_value.rs
@@ -30,6 +30,21 @@ pub fn derive_to_value(
// to this token stream, which should be the body of the impl block.
n... | 1 | 15 | 13 |
657e71329a2dea7e0eeef4db1dabf5f9ed721101 | Emilio Cobos Álvarez | 2019-04-09T09:37:26 | Bug 1542179 - Share more code between ToAnimatedValue and ToComputedValue derive. r=heycam
I'm going to add a ToResolvedValue, and I don't want to add more copy-pasta.
This shouldn't change behavior.
Differential Revision: https://phabricator.services.mozilla.com/D26289 | diff --git a/derive_common/cg.rs b/derive_common/cg.rs
index a5f15a035..7a8fbc244 100644
--- a/derive_common/cg.rs
+++ b/derive_common/cg.rs
@@ -32,8 +32,8 @@ use synstructure::{self, BindStyle, BindingInfo, VariantAst, VariantInfo};
pub fn propagate_clauses_to_output_type(
where_clause: &mut Option<syn::WhereCla... | 3 | 122 | 101 |
5d4ccd82ca461c6075b515471139f655ae8bc12a | Emilio Cobos Álvarez | 2019-04-09T00:11:03 | Bug 1542762 - Use an explicit stack to measure rule tree memory usage. r=heycam
A patch of mine that makes us measure the rule tree more often triggers this.
Differential Revision: https://phabricator.services.mozilla.com/D26595 | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index 3e2696fff..d653b6be9 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -75,8 +75,15 @@ impl Drop for RuleTree {
#[cfg(feature = "gecko")]
impl MallocSizeOf for RuleTree {
fn size_of(&self, ops: &mut MallocSizeOfOps) -> usize {
-... | 1 | 9 | 14 |
2e1d0991de7e613874fc6eca56abaf91247030df | Emilio Cobos Álvarez | 2019-04-04T23:04:50 | Bug 760345 - Make color and text-decoration-line not early properties. r=heycam
The text-decoration-line is a drive-by thing, but I can put it in a separate
patch if you want. It was needed for Servo (to compute
-servo-text-decorations-in-effect), but I moved Servo away from that model a
while ago.
Differential Revis... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 99a911791..bb9a9ef64 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -1270,17 +1270,6 @@ impl LonghandId {
LonghandId::FontStyle |
LonghandId::FontFamily |... | 1 | 0 | 11 |
c3047d298563ef08c601e2eb474a5395874ef64d | Emilio Cobos Álvarez | 2019-04-06T17:47:58 | Bug 760345 - Remove the last usage of lossy currentcolor. r=heycam
We don't have lossy currentcolor in the style system anymore, except for a
single property -moz-font-smoothing-background-color.
I could've converted it into a proper StyleColor and thread down all the
necessary information to the font metrics code.
... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 44b76f28b..837a295fb 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -40,8 +40,6 @@ use crate::gecko_bindings::structs::nsCSSPropertyID;
use crate::gecko_bindings::structs::mozilla::PseudoStyleType;
... | 8 | 24 | 78 |
a29ea84dfbc5258f7c620e33520fa488a1866406 | Brindusan Cristian | 2019-04-05T04:49:09 | Backed out changeset 1ea4b3582033 (bug 760345) for build bustages at ia2AccessibleComponent.cpp. | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 837a295fb..44b76f28b 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -40,6 +40,8 @@ use crate::gecko_bindings::structs::nsCSSPropertyID;
use crate::gecko_bindings::structs::mozilla::PseudoStyleType;
... | 8 | 78 | 24 |
b178bdd4fccd40663830ccbec35d95c1285844fb | Emilio Cobos Álvarez | 2019-04-04T18:32:09 | Bug 1541913 - Use rust lengths for outline-offset. r=boris
Depends on D26155
Differential Revision: https://phabricator.services.mozilla.com/D26156 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 3c4a45666..44b76f28b 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1205,7 +1205,6 @@ impl Clone for ${style_struct.gecko_struct_name} {
# Types used with predefined_type()-defined properties th... | 1 | 0 | 1 |
f4447f6254defea5a4ff980fefd406dce30226b6 | Emilio Cobos Álvarez | 2019-04-04T18:29:57 | Bug 1541913 - Use Servo lengths for column-width. r=boris
Depends on D26154
Differential Revision: https://phabricator.services.mozilla.com/D26155 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 2e2a55a16..3c4a45666 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1204,7 +1204,6 @@ impl Clone for ${style_struct.gecko_struct_name} {
# Types used with predefined_type()-defined properties ... | 1 | 0 | 1 |
eb4b1d9601d4ce49d3abfd8b38e80243f8e182d5 | Emilio Cobos Álvarez | 2019-04-04T17:39:15 | Bug 1541913 - Trivially remove some dead code. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D26154 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 0eaab9191..2e2a55a16 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1204,13 +1204,9 @@ impl Clone for ${style_struct.gecko_struct_name} {
# Types used with predefined_type()-defined properties... | 3 | 0 | 16 |
454705fe01aa6e1bc4b11acdaaf3b2ecf396deff | Emilio Cobos Álvarez | 2019-04-04T11:35:33 | Bug 1541546 - Use only the new name for StyleColor. r=heycam
That is, change all uses of StyleComplexColor to just StyleColor.
Differential Revision: https://phabricator.services.mozilla.com/D25977 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index db9fb9fbd..5390c8e82 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -1293,7 +1293,7 @@ impl LonghandId {
///
/// In Gecko, there are some properties still that compute cu... | 1 | 1 | 1 |
bc46b05bfab8a2615e5a7bb9936bd9e268ca8190 | Emilio Cobos Álvarez | 2019-04-04T11:35:16 | Bug 1541546 - Use the rust color representation. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D25976 | diff --git a/style/gecko_bindings/sugar/mod.rs b/style/gecko_bindings/sugar/mod.rs
index 642b5ad20..de981bd28 100644
--- a/style/gecko_bindings/sugar/mod.rs
+++ b/style/gecko_bindings/sugar/mod.rs
@@ -15,4 +15,3 @@ mod ns_t_array;
pub mod origin_flags;
pub mod ownership;
pub mod refptr;
-mod style_complex_color;
dif... | 5 | 9 | 209 |
58dd54065dcd18b68b1819bb2e0dab123a48dd81 | Emilio Cobos Álvarez | 2019-04-04T11:34:56 | Bug 1541546 - Expose colors via cbindgen. r=heycam
Also s/Foreground/CurrentColor.
Differential Revision: https://phabricator.services.mozilla.com/D25975 | diff --git a/style/gecko_bindings/sugar/style_complex_color.rs b/style/gecko_bindings/sugar/style_complex_color.rs
index aec334969..de1fad3bb 100644
--- a/style/gecko_bindings/sugar/style_complex_color.rs
+++ b/style/gecko_bindings/sugar/style_complex_color.rs
@@ -49,8 +49,8 @@ impl From<ComputedColor> for StyleComplex... | 6 | 50 | 37 |
029bc58acb1b36837c5b39bb77d251c5e265793d | Cosmin Sabou | 2019-04-04T12:04:25 | Backed out 3 changesets (bug 1541546) for causing build bustages. CLOSED TREE
Backed out changeset 895863144707 (bug 1541546)
Backed out changeset 4da6fb98e8f9 (bug 1541546)
Backed out changeset ba71816514eb (bug 1541546) | diff --git a/style/gecko_bindings/sugar/mod.rs b/style/gecko_bindings/sugar/mod.rs
index de981bd28..642b5ad20 100644
--- a/style/gecko_bindings/sugar/mod.rs
+++ b/style/gecko_bindings/sugar/mod.rs
@@ -15,3 +15,4 @@ mod ns_t_array;
pub mod origin_flags;
pub mod ownership;
pub mod refptr;
+mod style_complex_color;
dif... | 10 | 240 | 52 |
a97b1bdf38d3bc45dc93fe038833a1d45165a11c | Emilio Cobos Álvarez | 2019-04-04T11:34:56 | Bug 1541546 - Expose colors via cbindgen. r=heycam
Also s/Foreground/CurrentColor.
Differential Revision: https://phabricator.services.mozilla.com/D25975 | diff --git a/style/gecko_bindings/sugar/style_complex_color.rs b/style/gecko_bindings/sugar/style_complex_color.rs
index aec334969..de1fad3bb 100644
--- a/style/gecko_bindings/sugar/style_complex_color.rs
+++ b/style/gecko_bindings/sugar/style_complex_color.rs
@@ -49,8 +49,8 @@ impl From<ComputedColor> for StyleComplex... | 5 | 49 | 37 |
d2c1cf66cf4bde3cf068a3fe153ddcd64857e3df | Emilio Cobos Álvarez | 2019-04-04T03:46:55 | Bug 1540385 - Fix revalidation in <svg:use> subtree. r=heycam
So as to avoid incorrectly sharing styles across elements.
Differential Revision: https://phabricator.services.mozilla.com/D25918 | diff --git a/style/dom.rs b/style/dom.rs
index 28798e280..63f82a375 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -825,11 +825,15 @@ pub trait TElement:
Self: 'a,
F: FnMut(&'a CascadeData, QuirksMode, Option<Self>),
{
+ use rule_collector::containing_shadow_ignoring_svg_use;
+
l... | 1 | 5 | 1 |
37d7844fd479bef8ff699c0edf79e383878d89fa | Emilio Cobos Álvarez | 2019-04-03T10:00:44 | No bug - Remove some redundant use statements. | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index e36ff141e..43438438a 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -418,10 +418,8 @@ impl nsStyleImage {
use self::structs::NS_STYLE_GRADIENT_SIZE_CLOSEST_SIDE as CLOSEST_SIDE;
use self::structs::N... | 7 | 4 | 20 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.