commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
fda133cb34827765f0c9d7bb95b48ea5d0ce588b | Emilio Cobos Álvarez | 2019-04-02T12:47:13 | No bug - Remove comment that is outdated since I fixed it in bug 1483808. | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 12417d38e..4b94571c8 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -127,10 +127,6 @@ fn eval_device_aspect_ratio(
}
/// https://compat.spec.whatwg.org/#css-media-queries-webkit-device-pixel-ratio
-//... | 1 | 0 | 4 |
da6411ecfb02b685e5e1be227b0b2780a733faf9 | Emilio Cobos Álvarez | 2019-04-01T21:48:08 | Bug 1537594 - Make the fixed generic family a parse-time alias to monospace. r=jfkthame
As discussed on IRC, fixed is only used for prefs right now, and:
* We already copy the fixed size to the monospace font.
* We already serialize the fixed family as "monospace" in the style system.
So it already works somewhat ... | diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs
index c1d2f1b74..d332cf4d8 100644
--- a/style/values/computed/font.rs
+++ b/style/values/computed/font.rs
@@ -303,39 +303,16 @@ pub enum GenericFontFamily {
None,
Serif,
SansSerif,
+ #[parse(aliases = "-moz-fixed")]
Monosp... | 1 | 1 | 24 |
b3f9265e95f7f7369f8e4f4a3fed0d81aede2651 | Emilio Cobos Álvarez | 2019-04-01T21:47:59 | Bug 1537575 - Cleanup generic font-family handling. r=jfkthame
To be more similar between Rust and C++. This introduces GenericFontFamily and
exposes that plus FontFamilyNameSyntax to C++, using that where appropriate
instead of plain uint8_t as we were doing.
As a follow-up, as discussed on IRC with Jonathan, we can... | diff --git a/style/font_metrics.rs b/style/font_metrics.rs
index 15b5fd453..ab2468e54 100644
--- a/style/font_metrics.rs
+++ b/style/font_metrics.rs
@@ -43,7 +43,7 @@ pub trait FontMetricsProvider {
}
/// Get default size of a given language and generic family.
- fn get_size(&self, font_name: &Atom, font... | 7 | 122 | 248 |
93f97d6defdd1c6ae824e200dacc7d05fd5a4a86 | Emilio Cobos Álvarez | 2019-04-01T21:47:43 | Bug 1537575 - Trivially cleanup and remove some dead font code. r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D24271 | diff --git a/style/values/specified/font.rs b/style/values/specified/font.rs
index fb4fa8052..03896bc9c 100644
--- a/style/values/specified/font.rs
+++ b/style/values/specified/font.rs
@@ -530,18 +530,8 @@ impl FontFamily {
/// Parse a specified font-family value
pub fn parse_specified<'i, 't>(input: &mut P... | 1 | 2 | 12 |
47baa8af3f7bf5da505cc881104ef77effae6a05 | arthur.iakab | 2019-04-01T20:41:04 | Backed out 3 changesets (bug 1537594, bug 1537575) for causing build bustages on mathml/nsMathMLChar.cpp CLOSED TREE
Backed out changeset 7375a830b5ef (bug 1537594)
Backed out changeset 0cd1411e2fb3 (bug 1537575)
Backed out changeset c7565f50239a (bug 1537575) | diff --git a/style/font_metrics.rs b/style/font_metrics.rs
index ab2468e54..15b5fd453 100644
--- a/style/font_metrics.rs
+++ b/style/font_metrics.rs
@@ -43,7 +43,7 @@ pub trait FontMetricsProvider {
}
/// Get default size of a given language and generic family.
- fn get_size(&self, font_name: &Atom, font... | 7 | 263 | 104 |
31554c526cce1ebde7822d0b8d93cad9d1c08967 | Cameron McCormack | 2019-03-30T00:16:29 | Bug 1474793 - Part 12: Add FFI API to create a StyleSheet backed by shared data. r=emilio
Depends on D17198
Differential Revision: https://phabricator.services.mozilla.com/D17199 | diff --git a/style/stylesheets/stylesheet.rs b/style/stylesheets/stylesheet.rs
index 77fa00861..5b8c87532 100644
--- a/style/stylesheets/stylesheet.rs
+++ b/style/stylesheets/stylesheet.rs
@@ -107,6 +107,34 @@ impl StylesheetContents {
}
}
+ /// Creates a new StylesheetContents with the specified pre... | 1 | 28 | 0 |
a8e1588afee61983b0ff9e7851a930fb930a97f1 | Cameron McCormack | 2019-03-30T00:16:27 | Bug 1474793 - Part 11: Add FFI API to use SharedMemoryBuilder. r=emilio
Depends on D17197
Differential Revision: https://phabricator.services.mozilla.com/D17198 | diff --git a/style/gecko/boxed_types.rs b/style/gecko/boxed_types.rs
new file mode 100644
index 000000000..857f99e14
--- /dev/null
+++ b/style/gecko/boxed_types.rs
@@ -0,0 +1,21 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with ... | 2 | 22 | 0 |
5f286b3cf36b0f6af4915198b272cd5418956966 | Cameron McCormack | 2019-03-30T00:16:23 | Bug 1474793 - Part 10.7: Add ToShmem impl for FontFamilyList. r=emilio
Depends on D17195
Differential Revision: https://phabricator.services.mozilla.com/D17196 | diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs
index 8e51072d9..b9b5d5bb6 100644
--- a/style/values/computed/font.rs
+++ b/style/values/computed/font.rs
@@ -25,10 +25,11 @@ use malloc_size_of::{MallocSizeOf, MallocSizeOfOps};
use std::fmt::{self, Write};
use std::hash::{Hash, Hasher};
#[c... | 1 | 20 | 1 |
5d9105fb82c100479f096506f7d8a16899b063a1 | Cameron McCormack | 2019-03-30T00:16:21 | Bug 1474793 - Part 10.6: Add ToShmem impl for UrlExtraData. r=emilio
Depends on D17194
Differential Revision: https://phabricator.services.mozilla.com/D17195 | diff --git a/style/stylesheets/mod.rs b/style/stylesheets/mod.rs
index 8e4ec499a..3dfc4a027 100644
--- a/style/stylesheets/mod.rs
+++ b/style/stylesheets/mod.rs
@@ -37,8 +37,9 @@ use malloc_size_of::{MallocSizeOfOps, MallocUnconditionalShallowSizeOf};
use servo_arc::Arc;
use std::fmt;
#[cfg(feature = "gecko")]
-use ... | 1 | 22 | 1 |
81af4d0a9c16acce08c1caa5abb74df1ff572f39 | Cameron McCormack | 2019-03-30T00:16:19 | Bug 1474793 - Part 10.5: Add ToShmem impl for URLValueSource. r=emilio
Depends on D17193
Differential Revision: https://phabricator.services.mozilla.com/D17194 | diff --git a/style/gecko/url.rs b/style/gecko/url.rs
index e5f1b32e0..a0bf3ff08 100644
--- a/style/gecko/url.rs
+++ b/style/gecko/url.rs
@@ -19,8 +19,10 @@ use nsstring::nsCString;
use servo_arc::Arc;
use std::collections::HashMap;
use std::fmt::{self, Write};
+use std::mem::ManuallyDrop;
use std::sync::RwLock;
us... | 1 | 11 | 0 |
c6dda24f49ba44d9a663b9d18745e32b2331c628 | Cameron McCormack | 2019-03-30T00:16:17 | Bug 1474793 - Part 10.4: Add ToShmem impl for shared_lock::Locked. r=emilio
Depends on D17192
Differential Revision: https://phabricator.services.mozilla.com/D17193 | diff --git a/style/shared_lock.rs b/style/shared_lock.rs
index f708ec58a..f5019326e 100644
--- a/style/shared_lock.rs
+++ b/style/shared_lock.rs
@@ -16,7 +16,10 @@ use std::fmt;
#[cfg(feature = "servo")]
use std::mem;
#[cfg(feature = "gecko")]
+use std::mem::ManuallyDrop;
+#[cfg(feature = "gecko")]
use std::ptr;
+u... | 1 | 23 | 0 |
5329652528d316db8f82889e4b2d6d7071c7d41c | Cameron McCormack | 2019-03-30T00:16:15 | Bug 1474793 - Part 10.3: Add ToShmem impl for Atom. r=emilio
Depends on D17191
Differential Revision: https://phabricator.services.mozilla.com/D17192 | diff --git a/style/gecko_string_cache/mod.rs b/style/gecko_string_cache/mod.rs
index 9c33f25d9..f4c875cb7 100644
--- a/style/gecko_string_cache/mod.rs
+++ b/style/gecko_string_cache/mod.rs
@@ -25,9 +25,11 @@ use std::char::{self, DecodeUtf16};
use std::fmt::{self, Write};
use std::hash::{Hash, Hasher};
use std::iter... | 1 | 11 | 1 |
1673e5b4cd71a5906bd74164db2c4d4f99877134 | Cameron McCormack | 2019-03-30T00:16:13 | Bug 1474793 - Part 10.2: Add ToShmem impls for collections and strings. r=emilio
Depends on D17190
Differential Revision: https://phabricator.services.mozilla.com/D17191 | diff --git a/to_shmem/Cargo.toml b/to_shmem/Cargo.toml
index 84c28f462..bebc45e82 100644
--- a/to_shmem/Cargo.toml
+++ b/to_shmem/Cargo.toml
@@ -16,3 +16,7 @@ gecko = []
[dependencies]
cssparser = "0.25"
serde = {version = "1.0", optional = true}
+servo_arc = { path = "../servo_arc" }
+smallbitvec = "2.1.1"
+smallve... | 2 | 276 | 1 |
98da27c1dc526fcfd501856281ffe4a4ad562966 | Cameron McCormack | 2019-03-30T00:16:11 | Bug 1474793 - Part 10.1: Add simple ToShmem implementations. r=emilio
Depends on D17189
Differential Revision: https://phabricator.services.mozilla.com/D17190 | diff --git a/style/lib.rs b/style/lib.rs
index bd33dbeaf..cb73df55f 100644
--- a/style/lib.rs
+++ b/style/lib.rs
@@ -100,7 +100,6 @@ extern crate style_traits;
extern crate thin_slice;
extern crate time;
extern crate to_shmem;
-#[macro_use]
extern crate to_shmem_derive;
extern crate uluru;
extern crate unicode_bi... | 7 | 85 | 3 |
6295f3ac01f00aac1cf179bd4ef2a74b2a23d248 | Cameron McCormack | 2019-03-30T00:16:08 | Bug 1474793 - Part 9: Add support for deriving ToShmem. r=emilio
Depends on D17188
Differential Revision: https://phabricator.services.mozilla.com/D17189 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index c1d8a6d54..caa4b33e7 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -70,6 +70,7 @@ style_traits = {path = "../style_traits"}
servo_url = {path = "../url", optional = true}
thin-slice = "0.1.0"
to_shmem = {path = "../to_shmem"}
+to_shmem_derive = {path =... | 5 | 121 | 0 |
dc311ddc4a7458815107fad6562c60c35c4d2276 | Cameron McCormack | 2019-03-30T00:16:01 | Bug 1474793 - Part 8: Factor out some of style_derive. r=emilio
Depends on D17187
Differential Revision: https://phabricator.services.mozilla.com/D17188 | diff --git a/derive_common/Cargo.toml b/derive_common/Cargo.toml
new file mode 100644
index 000000000..2a4fac644
--- /dev/null
+++ b/derive_common/Cargo.toml
@@ -0,0 +1,16 @@
+[package]
+name = "derive_common"
+version = "0.0.1"
+authors = ["The Servo Project Developers"]
+license = "MPL-2.0"
+publish = false
+
+[lib]
... | 13 | 40 | 9 |
086c2197e127010cf63e2a3de5bced0547913c52 | Cameron McCormack | 2019-03-30T00:15:59 | Bug 1474793 - Part 7: Add SharedMemoryBuilder type and ToShmem trait. r=emilio
Depends on D17186
Differential Revision: https://phabricator.services.mozilla.com/D17187 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index d8e4886da..c1d8a6d54 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -69,6 +69,7 @@ style_derive = {path = "../style_derive"}
style_traits = {path = "../style_traits"}
servo_url = {path = "../url", optional = true}
thin-slice = "0.1.0"
+to_shmem = {path ... | 4 | 193 | 0 |
58a4b361471216095aebe235e57fcae537df9a2d | Cameron McCormack | 2019-03-30T00:15:57 | Bug 1474793 - Part 6: Add support for static references to servo_arc::Arc. r=emilio
Depends on D17185
Differential Revision: https://phabricator.services.mozilla.com/D17186 | diff --git a/servo_arc/lib.rs b/servo_arc/lib.rs
index a18c63a1e..f4a929e23 100644
--- a/servo_arc/lib.rs
+++ b/servo_arc/lib.rs
@@ -16,6 +16,8 @@
//! * We can add methods to support our custom use cases [1].
//! * We have support for dynamically-sized types (see from_header_and_iter).
//! * We have support for thin... | 2 | 159 | 38 |
685a833927706937c62b09d41c68f1dccdb74cbd | Cameron McCormack | 2019-03-30T00:15:55 | Bug 1474793 - Part 5: Add support for read only SharedRwLocks, which don't need any locking. r=emilio
Depends on D17184
Differential Revision: https://phabricator.services.mozilla.com/D17185 | diff --git a/style/shared_lock.rs b/style/shared_lock.rs
index 09bfa1635..f708ec58a 100644
--- a/style/shared_lock.rs
+++ b/style/shared_lock.rs
@@ -28,6 +28,10 @@ use std::ptr;
/// Servo needs the blocking behavior for its unsynchronized animation setup,
/// but that may not be web-compatible and may need to be chan... | 1 | 47 | 12 |
14a789c4769b8b09e21d831aa7275f29893b4262 | Cameron McCormack | 2019-03-30T00:15:53 | Bug 1474793 - Part 4: Allow C++ URLValue objects to be lazily created from Rust SpecifiedUrls. r=emilio
This avoids having to support storing refcounted URLValue objects in shared memory,
which would be tricky.
Depends on D17183
Differential Revision: https://phabricator.services.mozilla.com/D17184 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 356636fc6..e36ff141e 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -123,14 +123,11 @@ impl nsStyleImage {
match image {
GenericImage::Gradient(boxed_gradient) => self.set_gradient(*boxed_gradie... | 3 | 126 | 26 |
f12aada6584ac8c49e38f7fc4256e0730f38d39e | Cameron McCormack | 2019-03-30T00:15:51 | Bug 1474793 - Part 3: Allow references to static, single-generic C++ SharedFontList objects from Rust FontFamilyList. r=emilio
UA style sheets only ever specify a single generic font family in font-family
properties, so we pre-create a unique, static SharedFontList for each generic
and change the representation of Fon... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 7c5f4a94c..5af9f5be7 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1993,7 +1993,9 @@ fn static_assert() {
} else {
v.families.single_generic().unwrap_or(structs::kGenericFont_N... | 4 | 59 | 23 |
51d4306076b915cfc78573e094058e6bb2472bef | Cameron McCormack | 2019-03-30T00:15:43 | Bug 1474793 - Part 2: Allow references to static C++ URLExtraData objects from Rust UrlExtraData. r=emilio
Each user agent style sheet has a unique URLExtraData object containing
its URL, but since they are refcounted objects, we can't share them
easily across processes. Rather than adding support for copying them
in... | diff --git a/style/stylesheets/mod.rs b/style/stylesheets/mod.rs
index 58922187d..8e4ec499a 100644
--- a/style/stylesheets/mod.rs
+++ b/style/stylesheets/mod.rs
@@ -23,6 +23,10 @@ mod stylesheet;
pub mod supports_rule;
pub mod viewport_rule;
+#[cfg(feature = "gecko")]
+use crate::gecko_bindings::sugar::refptr::RefC... | 1 | 72 | 11 |
8a109eae540d1d7c15174717aebd88ffbafc2a02 | Masayuki Nakano | 2019-03-29T15:12:47 | Bug 1540015 - part 3: Rename Document::GetShell() to Document::GetPresShell() and make it return PresShell* rather than nsIPresShell* r=smaug,emilio
This makes `Document::GetShell()` return `PresShell*` instead of `nsIPresShell`.
Additonally, "shell" is unclear ("docshell" vs. "presshell"). Therefore, this
also rena... | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 4c04d9573..b39e748ce 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -169,6 +169,7 @@ impl Device {
self.document()
.mPresShell
.as_ref()?
+ ._base... | 1 | 1 | 0 |
7be5e0ca2906562ef9f9443aa88126c2885fa8e2 | Dorel Luca | 2019-03-29T14:14:26 | Backed out 3 changesets (bug 1540015) for build bustage. CLOSED TREE
Backed out changeset 7b71c9da0214 (bug 1540015)
Backed out changeset 5723ddbc5c44 (bug 1540015)
Backed out changeset 9561d2c36fa5 (bug 1540015) | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index b39e748ce..4c04d9573 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -169,7 +169,6 @@ impl Device {
self.document()
.mPresShell
.as_ref()?
- ._base... | 1 | 0 | 1 |
c95beb3490d7fc62a9733af86e7509856916b36c | Emilio Cobos Álvarez | 2019-03-29T11:11:27 | Bug 1540093 - Unship line-height: -moz-block-height. r=mats
They're only used in forms.css, and only for some anonymous content, which are
not content-accessible in the first place.
The only place where this could be exposed is calling
getComputedStyle(input, "::placeholder"), so I think this should be pretty safe,
b... | diff --git a/style/values/generics/text.rs b/style/values/generics/text.rs
index 7dae932fa..509491c86 100644
--- a/style/values/generics/text.rs
+++ b/style/values/generics/text.rs
@@ -61,6 +61,14 @@ impl<Value> Spacing<Value> {
}
}
+#[cfg(feature = "gecko")]
+fn line_height_moz_block_height_enabled(context: &P... | 2 | 10 | 27 |
a4b007d8c23d8b6ac04bacfe9ad31eef54167c6b | Emilio Cobos Álvarez | 2019-03-29T11:12:12 | Bug 1540093 - Refactor some enabledness checks. r=mats
There are some common checks that could get some easy-to-use aliases.
Differential Revision: https://phabricator.services.mozilla.com/D25117 | diff --git a/style/media_queries/media_feature_expression.rs b/style/media_queries/media_feature_expression.rs
index 6a9db93e8..53e24ae5b 100644
--- a/style/media_queries/media_feature_expression.rs
+++ b/style/media_queries/media_feature_expression.rs
@@ -17,7 +17,6 @@ use crate::parser::{Parse, ParserContext};
#[cfg... | 4 | 111 | 105 |
c7c15c2fbf35b8be4ae9c2ce0be938e935a851d6 | Emilio Cobos Álvarez | 2019-03-28T13:50:13 | Bug 1538589 - Fix ::marker invalidation when we need to potentially insert a marker as a result of a style change. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D24888 | diff --git a/style/invalidation/element/invalidator.rs b/style/invalidation/element/invalidator.rs
index 7ed97c0b1..371c07711 100644
--- a/style/invalidation/element/invalidator.rs
+++ b/style/invalidation/element/invalidator.rs
@@ -750,8 +750,19 @@ where
//
// Note that we'll ... | 1 | 13 | 2 |
a744d391c86ee250914d89ee23743f18602a93ee | Emilio Cobos Álvarez | 2019-03-27T15:03:20 | Bug 1539267 - Bug 1539171 - Follow the list-item definition from the spec a bit more closely. r=mats
The HTML restriction doesn't match any browser.
This matches Edge, though I filed
https://github.com/w3c/csswg-drafts/issues/3766 about the pseudo-element
condition.
Differential Revision: https://phabricator.service... | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 070a22999..91e4bba99 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -728,10 +728,7 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
///
/// https://drafts.csswg.org/css-lists-3/#declaring-a-list-item
#[cfg(feature = "g... | 1 | 2 | 8 |
b58bd0ccad78e5ade56375f56be823ba13243f98 | Emilio Cobos Álvarez | 2019-03-27T14:39:41 | Bug 1529681 - Update bindgen. r=bbouvier
This works around an LLVM bug and also pulls a fair amount of bugfixes and perf
improvements. None of the breaking changes affect either the style system or
cranelift stuff.
Changelog for convenience:
https://github.com/rust-lang/rust-bindgen/compare/v0.43.2...v0.49.0
Differ... | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 0c860746c..d8e4886da 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -78,7 +78,7 @@ void = "1.0.2"
[build-dependencies]
lazy_static = "1"
log = "0.4"
-bindgen = { version = "0.43", optional = true, default-features = false }
+bindgen = {version = "0.49",... | 1 | 1 | 1 |
a1e6231e17f36736eb2f84c4ded0c87ff9207787 | Julian Descottes | 2019-03-27T12:12:55 | Bug 1537876 - Augment CSS errors with the CSS selector r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D24894 | diff --git a/style/error_reporting.rs b/style/error_reporting.rs
index c58964c05..9d54f62e3 100644
--- a/style/error_reporting.rs
+++ b/style/error_reporting.rs
@@ -10,12 +10,14 @@ use crate::stylesheets::UrlExtraData;
use cssparser::{BasicParseErrorKind, ParseErrorKind, SourceLocation, Token};
use std::fmt;
use sty... | 3 | 13 | 7 |
3c819a3f050baa317f67f07702b48edb6deb09ee | Emilio Cobos Álvarez | 2019-03-27T01:28:54 | Bug 1539326 - Fix servo build, and appease tidy checks. | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index f68ac6396..486690989 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -294,7 +294,9 @@ mod bindings {
fn generate_structs() {
let builder = Builder::get_initial_builder()
.enable_cxx_namespaces()
- .with_... | 15 | 155 | 78 |
b623794ccd5f9013eeaffbc590145140f0ca4bfc | Peter Hall | 2019-02-14T12:53:59 | Bug 1539326 - Cherry-pick changes for servo/servo#8539 (config preferences backend restructure). r=npotb | diff --git a/style/global_style_data.rs b/style/global_style_data.rs
index 7928db13d..90936ff71 100644
--- a/style/global_style_data.rs
+++ b/style/global_style_data.rs
@@ -66,11 +66,11 @@ lazy_static! {
Ok(num) => num,
#[cfg(feature = "servo")]
_ => {
+ use servo_c... | 3 | 6 | 9 |
87d55bc3216b0f6ffa18d068f614cf9f00715c9c | Emilio Cobos Álvarez | 2019-03-26T18:42:27 | Bug 1536718 - Honor browser.display.use_document_fonts again. r=manishearth,jwatt
Differential Revision: https://phabricator.services.mozilla.com/D24218 | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 638e36e24..7d4c8c627 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -673,9 +673,12 @@ impl<'a, 'b: 'a> Cascade<'a, 'b> {
true
}
- // The default font type (which is stored in FontFamilyList's
-... | 1 | 46 | 19 |
f9dc8942e25338ad97947020bc71c679cbad00ad | Emilio Cobos Álvarez | 2019-03-26T18:15:47 | Bug 1536584 - Remove bindings.rs. r=xidorn
I kept it building the most straight-forward way possible (pub use) because it
seems to me that bindings is not a bad name, and we should probably move
structs.rs to be bindings.rs rather than the other way around.
But that's a different bug in any case, need to think more a... | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index ba53068be..f68ac6396 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -32,7 +32,6 @@ mod bindings {
use toml::value::Table;
const STRUCTS_FILE: &'static str = "structs.rs";
- const BINDINGS_FILE: &'static str = "bindings.rs";
... | 2 | 7 | 39 |
aca63c39c6e7575c5cc41fb5da42ddf0d25fb9f3 | Mats Palmgren | 2019-03-24T22:13:53 | Bug 205202 part 3 - [css-lists][css-pseudo] Add support for the 'content' CSS property on ::marker pseudo elements. r=emilio | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 8df5bc222..54b7dfc8a 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -174,10 +174,15 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
/// Apply the blockification rules based on the table in CSS 2.2 section 9.7.
/// <https... | 1 | 7 | 0 |
8f79ff79df1c76cb6c342fe0dd08c7c66bafa8aa | Mats Palmgren | 2019-03-24T22:13:53 | Bug 205202 part 1 - [css-lists][css-pseudo] Add support for the ::marker pseudo element on list items. Alias :-moz-list-bullet/number to that in the parser. r=emilio | diff --git a/style/dom.rs b/style/dom.rs
index 1c6454331..28798e280 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -441,6 +441,11 @@ pub trait TElement:
None
}
+ /// The ::marker pseudo-element of this element, if it exists.
+ fn marker_pseudo_element(&self) -> Option<Self> {
+ None
+ }... | 5 | 24 | 2 |
6018e23e505b6fc14727fce9c8b1d9f7a19a90f7 | Mats Palmgren | 2019-03-24T22:13:52 | Bug 288704 part 2 - [css-lists] Implement display:list-item counters using a built-in 'list-item' CSS counter. r=emilio | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 8218e2706..8df5bc222 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -708,6 +708,47 @@ impl<'a, 'b: 'a> StyleAdjuster<'a, 'b> {
}
}
+ /// For HTML elements with 'display:list-item' we add a default 'counter-inc... | 1 | 42 | 0 |
6fdfb78ed5bd9ba9e33390f4437e289367ab6399 | Mats Palmgren | 2019-03-24T22:13:52 | Bug 1518201 - [css-lists] Implement the counter-set property. r=emilio | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 0879e5846..e3bd2ea55 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -4559,7 +4559,7 @@ clip-path
</%self:impl_trait>
<%self:impl_trait style_struct_name="Counters"
- skip_longhand... | 7 | 27 | 18 |
e0cec1ab3b1bd73b7e99e8ee4a660f93c0e0f959 | Emilio Cobos Álvarez | 2019-03-21T17:00:27 | Bug 1536586 - Simplify a bit our generated bindings by getting rid of FooBorrowed and FooBorrowedMut. r=heycam
This reduces a lot the boilerplate that's needed in order to add simple binding
functions.
This starts using &Foo and Option<&Foo> instead, and as a result we need to
remove the servo_function_signatures tes... | diff --git a/style/author_styles.rs b/style/author_styles.rs
index 101c2e173..37eb68ff4 100644
--- a/style/author_styles.rs
+++ b/style/author_styles.rs
@@ -77,7 +77,7 @@ where
#[cfg(feature = "gecko")]
unsafe impl HasFFI for AuthorStyles<crate::gecko::data::GeckoStyleSheet> {
- type FFIType = crate::gecko_bindi... | 9 | 68 | 150 |
4685aa6dd18118b9fdb2ce8ed1642630ae1f7ae6 | Cameron McCormack | 2019-03-21T04:50:47 | Bug 282126 - Part 4: Use horizontal metrics for ch in vertical mixed/sideways writing modes and for ex always. r=emilio
Depends on D23425
Differential Revision: https://phabricator.services.mozilla.com/D23426 | diff --git a/style/font_metrics.rs b/style/font_metrics.rs
index c1707d1fb..15b5fd453 100644
--- a/style/font_metrics.rs
+++ b/style/font_metrics.rs
@@ -20,6 +20,16 @@ pub struct FontMetrics {
pub zero_advance_measure: Option<Au>,
}
+/// Type of font metrics to retrieve.
+#[derive(Clone, Debug, PartialEq)]
+pub... | 3 | 42 | 8 |
02f3332d1c5c5cad788a23b895bef442a94a18e3 | Cameron McCormack | 2019-03-21T04:50:43 | Bug 282126 - Part 2: Allow FontMetricsProvider to produce ex height and zero width independently. r=emilio
We are always able to produce an x height, but depending on whether the
glyph exists, we sometimes can't produce a zero glyph width.
Depends on D23423
Differential Revision: https://phabricator.services.mozilla... | diff --git a/style/font_metrics.rs b/style/font_metrics.rs
index c8b4a655a..c1707d1fb 100644
--- a/style/font_metrics.rs
+++ b/style/font_metrics.rs
@@ -12,22 +12,12 @@ use app_units::Au;
/// Represents the font metrics that style needs from a font to compute the
/// value of certain CSS units like `ex`.
-#[derive(... | 3 | 29 | 38 |
b2cca978ffd3fc25904d82b81bc8125546db1985 | Emilio Cobos Álvarez | 2019-03-20T22:47:30 | Bug 1537576 - fix some rust-nightly warnings about unused doc comments. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D24287 | diff --git a/style/bloom.rs b/style/bloom.rs
index 92e6b2a48..d75d548ff 100644
--- a/style/bloom.rs
+++ b/style/bloom.rs
@@ -14,11 +14,13 @@ use selectors::bloom::BloomFilter;
use servo_arc::Arc;
use smallvec::SmallVec;
-/// Bloom filters are large allocations, so we store them in thread-local storage
-/// such tha... | 4 | 9 | 8 |
e0513bb789bf126ad640731753839b32af04ff4f | Emilio Cobos Álvarez | 2019-03-19T21:10:30 | Bug 1516780 - Remove ComputedStyle::mBits. r=jfkthame,heycam
Use the Servo flags instead.
Differential Revision: https://phabricator.services.mozilla.com/D20729 | diff --git a/style/properties/computed_value_flags.rs b/style/properties/computed_value_flags.rs
index 2f6851d3f..a86f8a4da 100644
--- a/style/properties/computed_value_flags.rs
+++ b/style/properties/computed_value_flags.rs
@@ -97,3 +97,22 @@ impl ComputedValueFlags {
self & Self::maybe_inherited_flags()
... | 1 | 19 | 0 |
edd89603b9f4912e9897a125da8664f7ccd98ae2 | Emilio Cobos Álvarez | 2019-03-19T21:10:13 | Bug 1516780 - Keep track of whether a style is affected by font metrics. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D20728 | diff --git a/style/properties/computed_value_flags.rs b/style/properties/computed_value_flags.rs
index 18fc886c7..2f6851d3f 100644
--- a/style/properties/computed_value_flags.rs
+++ b/style/properties/computed_value_flags.rs
@@ -56,10 +56,13 @@ bitflags! {
/// Whether the child explicitly inherits any reset pr... | 4 | 47 | 34 |
adeff7e3023f0c5346ea59ebb91ad256ae6e6daf | Boris Chiou | 2019-03-18T18:05:00 | Bug 1425837 - Part 6: Add individual transform properties into compositor animation list. r=hiro
Now, its time to let individual transform run on the compositor thread.
Depends on D19636
Differential Revision: https://phabricator.services.mozilla.com/D22566 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 1a8abfb36..dcfcb3430 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -365,7 +365,7 @@ ${helpers.predefined_type(
"generics::transform::Rotate::None",
animation... | 1 | 3 | 3 |
106143fb223acad9665e06866d3ea330f7e8eb03 | Emilio Cobos Álvarez | 2019-03-18T16:38:48 | Bug 1533201 - Make cssPropertySupportsType take an enum. r=heycam,rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D22427 | diff --git a/style_traits/specified_value_info.rs b/style_traits/specified_value_info.rs
index 3cb59e796..c978727b4 100644
--- a/style_traits/specified_value_info.rs
+++ b/style_traits/specified_value_info.rs
@@ -10,7 +10,7 @@ use std::sync::Arc as StdArc;
/// Type of value that a property supports. This is used by ... | 1 | 1 | 1 |
035c09ac5d9cf12e9d4bd071beeb28a5413dd6ff | Emilio Cobos Álvarez | 2019-03-18T16:27:54 | Bug 1529537 - Make all font-metrics-affecting properties cascade early. r=heycam
And make font-size computation work on the whole font of the parent, not just
accounting for the parent's font-size.
Differential Revision: https://phabricator.services.mozilla.com/D20656 | diff --git a/style/font_metrics.rs b/style/font_metrics.rs
index 0c37a4446..c8b4a655a 100644
--- a/style/font_metrics.rs
+++ b/style/font_metrics.rs
@@ -7,9 +7,6 @@
#![deny(missing_docs)]
use crate::context::SharedStyleContext;
-use crate::logical_geometry::WritingMode;
-use crate::media_queries::Device;
-use crate... | 4 | 36 | 38 |
0a143002e644cbe67414a5984b002670819c2bea | Emilio Cobos Álvarez | 2019-03-18T15:37:03 | Bug 1534494 - Try to bring some more sanity into our font code. r=manishearth
It's not very easy to understand on its current state, and it causes subtle bugs
like bug 1533654.
It could be simpler if we centralized where the interactions between properties
are handled. This patch does this.
This patch also changes h... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 60aa315b6..638e36e24 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -384,8 +384,6 @@ struct Cascade<'a, 'b: 'a> {
cascade_mode: CascadeMode<'a>,
seen: LonghandIdSet,
reverted: PerOrigin<LonghandIdS... | 8 | 279 | 487 |
6eb1725a5f100e3d593291b77763408a1b7a0ba9 | Emilio Cobos Álvarez | 2019-03-12T00:48:27 | Bug 1533654 - Don't call PrefillDefaultForGeneric when inheriting font-family. r=heycam
This is the low-risk fix for this issue, that we should get into 67.
What's going on here is that font-family is tracked via the font list, from the
POV of the style system the font list is generally just the
RefPtr<SharedFontList... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 23970d648..60aa315b6 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -744,7 +744,7 @@ impl<'a, 'b: 'a> Cascade<'a, 'b> {
// separately, so this boils down to just copying over the
// font... | 1 | 1 | 1 |
8948bca189d7c30ccaed1deb85d88223db3dda0b | Emilio Cobos Álvarez | 2019-03-14T22:30:37 | Bug 1533783 - Avoid crashing when calling insertRule("@import ...") on a detached sheet. r=heycam
This should unblock the fuzzers for now, though it's not the ideal solution.
It's the only reasonably easy solution to unblock them though, I think.
We should probably always keep track of the document a stylesheet was ... | diff --git a/style/stylesheets/rule_parser.rs b/style/stylesheets/rule_parser.rs
index 44943259b..a780ebce2 100644
--- a/style/stylesheets/rule_parser.rs
+++ b/style/stylesheets/rule_parser.rs
@@ -189,6 +189,13 @@ impl<'a, 'i> AtRuleParser<'i> for TopLevelRuleParser<'a> {
return Err(input.new_custo... | 1 | 7 | 0 |
b0cd2faeba7ffe0a02dad6c65b519a63abfa3b99 | Emilio Cobos Álvarez | 2019-03-13T21:29:13 | Bug 1535084 - followup: Add a comment to unbust the tree.
CLOSED TREE | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index a9a051ad9..39917659c 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -756,6 +756,7 @@ bitflags! {
#[repr(C)]
/// Constants for contain: https://drafts.csswg.org/css-contain/#contain-property
... | 1 | 1 | 0 |
f20bb3ccfca889eea1aa4b81be656f2d569d8995 | Emilio Cobos Álvarez | 2019-03-12T16:50:55 | Bug 1534726 - Fix servo build. | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 73965f90a..0153d6fe3 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -2591,6 +2591,7 @@ pub mod style_structs {
/// Whether the border-${side} property has nonz... | 3 | 5 | 6 |
e68571ca73d92be6c2203612c899ec58824293f7 | Emilio Cobos Álvarez | 2019-03-12T16:02:19 | Bug 1534726 - Reformat recent style system changes. | diff --git a/selectors/parser.rs b/selectors/parser.rs
index fa043b772..488628cd7 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -1959,8 +1959,9 @@ where
let name = match input.next_including_whitespace()? {
&Token::Ident(ref name) => name.clone(),
... | 22 | 91 | 63 |
cb522b7ba58abc2b1c8ebcf5bbbc57e6bd0cfbed | violet | 2019-03-09T13:05:56 | Bug 1508028 - Change stroke-miterlimit restriction from GreaterThanOrEqualToOneNumber to NonNegativeNumber. r=longsonr,emilio | diff --git a/style/properties/longhands/inherited_svg.mako.rs b/style/properties/longhands/inherited_svg.mako.rs
index 35d0a02aa..2bbdc2794 100644
--- a/style/properties/longhands/inherited_svg.mako.rs
+++ b/style/properties/longhands/inherited_svg.mako.rs
@@ -110,11 +110,11 @@ ${helpers.single_keyword(
${helpers.pr... | 1 | 3 | 3 |
2e64b22527c65c0991400dec8213904ad14c7393 | Emilio Cobos Álvarez | 2019-03-07T12:48:07 | Bug 1215878 - Optimize cascading of other wide keywords if possible. r=xidorn
The way the copy-on-write stuff works, and the way that we have to apply
properties from most specific to less specific guarantees that always that we're
going to inherit an inherited property, or reset a reset property, we have
already the ... | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 09b055b07..23970d648 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -11,7 +11,7 @@ use crate::font_metrics::FontMetricsProvider;
use crate::logical_geometry::WritingMode;
use crate::media_queries::Device;
use ... | 3 | 37 | 38 |
126857485e602ff22586bff25fd54f812e8cdd84 | Emilio Cobos Álvarez | 2019-03-07T11:59:36 | Bug 1215878 - Implement CSS revert keyword. r=heycam,birtles
The only fishy bit is the animation stuff. In particular, there are two places
where we just mint the revert behavior:
* When serializing web-animations keyframes (the custom properties stuff in
declaration_block.rs). That codepath is already not sound ... | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index f21929c70..93cd3488f 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -7,8 +7,9 @@
//! [custom]: https://drafts.csswg.org/css-variables/
use crate::hash::map::Entry;
-use crate::properties::{CSSWideKeyword, CustomD... | 9 | 119 | 20 |
4a6adacfab392686c55512e817b9f56f2c02d7e0 | Emilio Cobos Álvarez | 2019-03-06T23:14:43 | No bug - fix a typo.
DONTBUILD | diff --git a/style/traversal.rs b/style/traversal.rs
index f1821900b..d5a9a5c50 100644
--- a/style/traversal.rs
+++ b/style/traversal.rs
@@ -686,7 +686,7 @@ where
// sibling or cousin. Otherwise, recascading a bunch of identical
// elements would unnecessarily flood the cache with identical en... | 1 | 1 | 1 |
7a034b17da6954385640db8c202ffa7a6ef27d34 | Emilio Cobos Álvarez | 2019-03-06T23:14:06 | Bug 1532135 - followup: Add a comment as requested on Phabricator. | diff --git a/style/values/specified/length.rs b/style/values/specified/length.rs
index 735e829b8..677ca3901 100644
--- a/style/values/specified/length.rs
+++ b/style/values/specified/length.rs
@@ -992,6 +992,10 @@ impl NonNegativeLengthPercentage {
pub type LengthOrNormal = Either<Length, Normal>;
/// Either a `<le... | 1 | 4 | 0 |
80aff840b4b5c6136fc5df6b0775ff1d59ee5270 | Emilio Cobos Álvarez | 2019-03-06T21:37:48 | Bug 1532135 - Derive more stuff for clip rects. r=boris
I feel a bit weird for using LenghtPercentageOrAuto to implement LengthOrAuto,
but I don't think much other code will use it so it seemed a bit better to me.
Differential Revision: https://phabricator.services.mozilla.com/D21863 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index bf7bc9ace..6a4d4d87a 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -3748,6 +3748,7 @@ fn static_assert() {
#[allow(non_snake_case)]
pub fn set__moz_image_region(&mut self, v: longhands::_mo... | 8 | 139 | 250 |
b5dd241e5b5cc562b9b9c442adff282ebfe45a29 | Emilio Cobos Álvarez | 2019-03-06T21:36:12 | Bug 1530751 - Make the pres context optional in the style system. r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D21239 | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index e48656ee8..b70f376d7 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -7,7 +7,7 @@
use crate::context::QuirksMode;
use crate::dom::TElement;
use crate::gecko_bindings::bindings::{self, RawServoStyleSet};
-use crate::gecko_bindings::structs::{R... | 4 | 84 | 37 |
317799a3809d10d563dae1e8a20ff594c5d5d5a5 | Emilio Cobos Álvarez | 2019-03-06T21:34:30 | Bug 1530193 - Refactor preference stylesheet prefs to not require a pres context. r=jwatt
We really only have two sets of prefs, one for chrome-like documents
(stuff in chrome docshells + chrome-origin images), and one for the rest.
Differential Revision: https://phabricator.services.mozilla.com/D20946 | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index 80e34fe2e..e48656ee8 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -150,7 +150,7 @@ impl PerDocumentStyleData {
// right now not always honored, see bug 1405543...
//
// Should we just force XBL Stylists to be NoQuir... | 4 | 20 | 15 |
6a7f779dfce5441cd688945faa8eefa9bfb2c1dc | Daniel Holbert | 2019-03-06T20:44:37 | Bug 1530896: Drop css parser support for 'contain:style'. r=emilio
We're not sure we're going to ship support for this value, and it's been marked
as 'at-risk' in the spec, so let's stop pretending we support it in the parser.
Spec issue:
https://github.com/w3c/csswg-drafts/issues/3280
Differential Revision: https:/... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 8f4fcaec5..bf7bc9ace 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -3177,7 +3177,6 @@ fn static_assert() {
use crate::gecko_bindings::structs::NS_STYLE_CONTAIN_CONTENT;
use crate::g... | 2 | 8 | 20 |
c789cb82945bea6a9becb338f51caa5ac49f8be0 | Emilio Cobos Álvarez | 2019-03-03T11:31:54 | Bug 1532134 - Remove Options from TransformOperation. r=xidorn
This may or may not be part of the plan to get rid of nsCSSValue ;)
Option is not usable via FFI, and they should not be needed (we should be
following the shortest serialization principle instead). These patches also do
that, which matches the other tran... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 9ee8ab3c6..a22e74596 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -855,13 +855,13 @@ def set_gecko_property(ffi_name, expr):
transform_functions = [
("Matrix3D", "matrix3d", ["number"] * 16),
... | 6 | 78 | 100 |
aa7c821bf28dc02f5f5cbaf84fec346efd9b006f | Emilio Cobos Álvarez | 2019-03-03T11:31:40 | Bug 1532134 - Use contextual_skip_if for background-size. r=xidorn
Also drive-by cleanup.
Differential Revision: https://phabricator.services.mozilla.com/D21861 | diff --git a/style/values/generics/background.rs b/style/values/generics/background.rs
index 14ac9744b..3780f9a4f 100644
--- a/style/values/generics/background.rs
+++ b/style/values/generics/background.rs
@@ -5,8 +5,13 @@
//! Generic types for CSS values related to backgrounds.
use crate::values::generics::length::... | 1 | 12 | 28 |
d63a449d8a156c9e10c0f76f6cf7aa295f810ddd | Emilio Cobos Álvarez | 2019-03-03T11:31:30 | Bug 1532134 - Use skip_if for translate serialization. r=xidorn
Trivial drive-by cleanup.
Differential Revision: https://phabricator.services.mozilla.com/D21860 | diff --git a/style/values/generics/transform.rs b/style/values/generics/transform.rs
index d25d2d3a6..b0a121fd6 100644
--- a/style/values/generics/transform.rs
+++ b/style/values/generics/transform.rs
@@ -629,55 +629,34 @@ impl<Number: ToCss + PartialEq> ToCss for Scale<Number> {
}
#[derive(
- Clone, Debug, Mall... | 1 | 18 | 39 |
d0f7c5436f53b3491aa4a0140467518ed9bd45ef | Emilio Cobos Álvarez | 2019-03-03T11:31:21 | Bug 1532134 - When deriving something with an output type, map preconditions as well. r=xidorn
Otherwise, deriving ToComputedValue and ToAnimatedValue in structs or enums with
other where clauses just doesn't work.
Differential Revision: https://phabricator.services.mozilla.com/D21859 | diff --git a/style_derive/cg.rs b/style_derive/cg.rs
index 6eeca384b..880cb0737 100644
--- a/style_derive/cg.rs
+++ b/style_derive/cg.rs
@@ -12,6 +12,70 @@ use syn::{TypeParam, TypeParen, TypePath, TypeSlice, TypeTuple};
use syn::{Variant, WherePredicate};
use synstructure::{self, BindStyle, BindingInfo, VariantAst, ... | 3 | 76 | 0 |
6279795ff7ff7b1f7068822072630b0af7486bdf | Emilio Cobos Álvarez | 2019-03-03T11:31:06 | Bug 1532134 - Implement a version of #[css(skip_if)] that takes more context. r=xidorn
I called it contextual_skip_if, though better names welcome.
Differential Revision: https://phabricator.services.mozilla.com/D21858 | diff --git a/style_derive/to_css.rs b/style_derive/to_css.rs
index 4eabdcb83..3a1bc9f4c 100644
--- a/style_derive/to_css.rs
+++ b/style_derive/to_css.rs
@@ -148,12 +148,20 @@ fn derive_variant_fields_expr(
}
}
}
+
+ if let Some(condition) = attrs.contextual_skip_if {
+ ... | 2 | 24 | 2 |
97ce47f29654560fa212e1957175c816468c8e86 | Emilio Cobos Álvarez | 2019-03-02T01:09:19 | Bug 1218257 - Use rust lengths for the SVG lengths. r=boris
As it turns out we need this to avoid losing precision both during painting and
during serialization.
This patch also changes to serialize `context-value` if it's the computed value.
I could keep the previous behavior, but it makes no sense to serialize the... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 1c8fb3121..9ee8ab3c6 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -478,12 +478,12 @@ def set_gecko_property(ffi_name, expr):
}
}
};
- self.gecko.${gecko... | 2 | 7 | 16 |
7408c0b3f785c42d5116582cc98ff0b507fbdff5 | Emilio Cobos Álvarez | 2019-03-01T22:17:12 | Bug 1218257 - Cleanup and fix interpolation of SVG lengths. r=boris
Instead of storing them as LengthPercentage | Number, always store as
LengthPercentage, and use the unitless length quirk to parse numbers instead.
Further cleanups to use the rust representation can happen as a followup, which
will also get rid of t... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index cca1bd540..1c8fb3121 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -463,27 +463,22 @@ def set_gecko_property(ffi_name, expr):
// set on mContextFlags, and the length field is set to the initial ... | 7 | 92 | 278 |
a9dc9880e7a13b1a265aac54d1fb59f050afc118 | Emilio Cobos Álvarez | 2019-02-28T19:03:03 | Bug 1530847 - Add a Zero trait that doesn't require Add, and use it in place of num_traits and IsZeroLength. r=heycam
Use it to be consistent in InsetRect serialization and storage between Servo and
Gecko.
Differential Revision: https://phabricator.services.mozilla.com/D21493 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 4cbf759c2..64f0726b2 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -27,6 +27,7 @@ use crate::values::generics::box_::VerticalAlign;
use crate::values::generics::grid::{TrackListValue, TrackSize};
use crate::values... | 29 | 179 | 186 |
d292b9ddd34ebf82d1c2bde885a8775cad8de5af | Emilio Cobos Álvarez | 2019-02-26T23:34:25 | Bug 1530826 - Fix computed value clamping. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D21268 | diff --git a/style/values/computed/length.rs b/style/values/computed/length.rs
index f578bbbd5..23b7474e7 100644
--- a/style/values/computed/length.rs
+++ b/style/values/computed/length.rs
@@ -203,12 +203,7 @@ impl LengthPercentage {
return None;
}
- if self.clamping_mode.clamp(self.perce... | 1 | 3 | 9 |
288c11e0596fda4cb7725e7f942742b19856e79c | Hiroyuki Ikezoe | 2019-02-26T10:17:25 | Bug 1530571 - Explicitly specify animation_value_type for scroll-padding. r=boris
Otherwise the Trait for clamping negative animation value isn't generated thus
negative animating results are exposed in computed values.
Depends on D21152
Differential Revision: https://phabricator.services.mozilla.com/D21153 | diff --git a/style/properties/longhands/padding.mako.rs b/style/properties/longhands/padding.mako.rs
index 6c4e2b32c..a1262aee0 100644
--- a/style/properties/longhands/padding.mako.rs
+++ b/style/properties/longhands/padding.mako.rs
@@ -39,6 +39,6 @@
logical=side[1],
logical_group="scroll-padding",
... | 1 | 1 | 1 |
7c395403b6cf91d9cd472a6b4026efc041b31b79 | Cosmin Sabou | 2019-02-25T18:31:13 | Backed out changeset 4d220064bcf8 (bug 1529681) for causing Windows 2012 AArch64 build bustages. CLOSED TREE | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 091b93ad1..0c860746c 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -78,7 +78,7 @@ void = "1.0.2"
[build-dependencies]
lazy_static = "1"
log = "0.4"
-bindgen = {version = "0.47", optional = true, default-features = false}
+bindgen = { version = "0.43", ... | 1 | 1 | 1 |
387b654ae32a8fe84e14b579bfe2b3686c50363e | Emilio Cobos Álvarez | 2019-02-25T03:05:39 | Bug 1516454 - Make the generic size not use euclid under the hood. r=firefox-style-system-reviewers,boris
The euclid size is not really used for anything. Also rename it to Size2D to
avoid cbindgen conflicts with values::length::Size.
Depends on D20958
Differential Revision: https://phabricator.services.mozilla.com/... | diff --git a/style/values/computed/border.rs b/style/values/computed/border.rs
index e85b5a3e5..7b42dd0e8 100644
--- a/style/values/computed/border.rs
+++ b/style/values/computed/border.rs
@@ -12,7 +12,7 @@ use crate::values::generics::border::BorderImageSlice as GenericBorderImageSlice
use crate::values::generics::bo... | 4 | 32 | 55 |
b574559ee38929238c99d15b39b3ba5fdd83060a | Emilio Cobos Álvarez | 2019-02-25T03:03:15 | Bug 1516454 - Simplify border-radius serialization. r=firefox-style-system-reviewers,boris
Differential Revision: https://phabricator.services.mozilla.com/D20958 | diff --git a/style/values/generics/border.rs b/style/values/generics/border.rs
index ffd30e986..a722548e7 100644
--- a/style/values/generics/border.rs
+++ b/style/values/generics/border.rs
@@ -145,11 +145,7 @@ where
W: Write,
{
widths.to_css(dest)?;
- if widths.0 != heights.0 ||
- ... | 1 | 1 | 5 |
1aa2b44d0be80865099c0d4fb97b14a8fa5b3d87 | Emilio Cobos Álvarez | 2019-02-25T17:25:10 | Bug 1529681 - Update bindgen. r=bbouvier | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 0c860746c..091b93ad1 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -78,7 +78,7 @@ void = "1.0.2"
[build-dependencies]
lazy_static = "1"
log = "0.4"
-bindgen = { version = "0.43", optional = true, default-features = false }
+bindgen = {version = "0.47",... | 1 | 1 | 1 |
acc9dd34199c7a53c992416e0a6d998417fb4181 | Andreea Pavel | 2019-02-25T16:44:17 | Backed out changeset e99833064d36 (bug 1529681) for build bustages on a CLOSED TREE | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 091b93ad1..0c860746c 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -78,7 +78,7 @@ void = "1.0.2"
[build-dependencies]
lazy_static = "1"
log = "0.4"
-bindgen = {version = "0.47", optional = true, default-features = false}
+bindgen = { version = "0.43", ... | 1 | 1 | 1 |
ef4286c5fd24f295c2b3b1ee6412038874fc2a02 | Emilio Cobos Álvarez | 2019-02-25T09:43:11 | Bug 1529681 - Update bindgen. r=bbouvier
This works around an LLVM bug and also pulls a fair amount of bugfixes and perf
improvements. None of the breaking changes affect either the style system or
cranelift stuff.
Changelog for convenience:
https://github.com/rust-lang/rust-bindgen/compare/v0.43.2...v0.47.2
Differ... | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 0c860746c..091b93ad1 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -78,7 +78,7 @@ void = "1.0.2"
[build-dependencies]
lazy_static = "1"
log = "0.4"
-bindgen = { version = "0.43", optional = true, default-features = false }
+bindgen = {version = "0.47",... | 1 | 1 | 1 |
d5a3fd695a60a0f9956ed31916ee084e55d37f68 | Emilio Cobos Álvarez | 2019-02-24T04:55:08 | No bug - Appease tidy. r=whitespace-only | diff --git a/style/values/specified/transform.rs b/style/values/specified/transform.rs
index 77c92c366..c4f437354 100644
--- a/style/values/specified/transform.rs
+++ b/style/values/specified/transform.rs
@@ -231,7 +231,7 @@ impl Parse for Transform {
}
/// The specified value of a component of a CSS `<transform-or... | 1 | 1 | 1 |
0badbeb6e422b1ce99c16f5951223e336b588977 | Emilio Cobos Álvarez | 2019-02-24T04:42:49 | No bug - Remove unnecessary derive. r=npotb | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 02238bf13..2495cca3d 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -418,7 +418,6 @@ pub enum ScrollSnapAlignKeyword {
/// https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-align
#[allow(missing... | 1 | 0 | 1 |
46cbc79ddb82325f0cdb08d3e29e93857b47471f | Emilio Cobos Álvarez | 2019-02-24T04:40:02 | No bug - Rustfmt recent changes. r=whitespace-only | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index 6d509cf69..8fa2258ea 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -85,7 +85,9 @@ impl Device {
assert!(!pres_context.is_null());
Device {
pres_context,
- default_va... | 15 | 41 | 37 |
b8337d541fbf8140c8d601c4e78fb24036a5dec5 | Asfiya | 2019-02-19T17:01:59 | Bug 1528940 - convert NS_STYLE_FLEX_DIRECTION to an enum class in nsStyleConsts.h r=emilio
Converted the #define variable NS_STYLE_FLEX_DIRECTION to an enum class in nsStyleConsts.h and made changes in other files that access it
Differential Revision: https://phabricator.services.mozilla.com/D20291 | diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs
index 2e9517cc8..725f0862a 100644
--- a/style/properties/longhands/position.mako.rs
+++ b/style/properties/longhands/position.mako.rs
@@ -75,6 +75,7 @@ ${helpers.single_keyword(
extra_prefixes="webkit",
anim... | 1 | 1 | 0 |
62813efb7f74f1d464fb7ccfb9416c20caf2a0d5 | scharing | 2019-02-19T16:54:52 | Bug 1528464 - Convert NS_STYLE_MASK_MODE_* to enum class r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D20063 | diff --git a/style/properties/longhands/svg.mako.rs b/style/properties/longhands/svg.mako.rs
index f003fa522..1a84c1d66 100644
--- a/style/properties/longhands/svg.mako.rs
+++ b/style/properties/longhands/svg.mako.rs
@@ -96,6 +96,7 @@ ${helpers.predefined_type(
${helpers.single_keyword(
"mask-mode",
"match-s... | 1 | 1 | 0 |
6832151a7e310ade75321b9688a51e564aeb6c6f | Emilio Cobos Álvarez | 2019-02-14T19:45:10 | Bug 1528035 - Improve #[derive(Parse)]. r=xidorn
I want to do this so that I can get rid of Either<>. The reasons for getting rid
of either is multiple:
* It doesn't generate as nice C++ code using cbindgen.
* It isn't that nice to use either from Rust.
* cbindgen has bugs with zero-sized types.
I started using t... | diff --git a/style/gecko_bindings/sugar/style_complex_color.rs b/style/gecko_bindings/sugar/style_complex_color.rs
index 4d31459a6..69565950b 100644
--- a/style/gecko_bindings/sugar/style_complex_color.rs
+++ b/style/gecko_bindings/sugar/style_complex_color.rs
@@ -7,10 +7,8 @@
use crate::gecko::values::{convert_nscolo... | 24 | 238 | 362 |
f0611ae619d005ec828701b34ff6a503446a2db7 | Emilio Cobos Álvarez | 2019-02-18T14:03:47 | Bug 1528712 - Remove nsFont::featureValueLookup. r=jfkthame
It's a global object, it doesn't have to be stored in nsFont. Pass it from the
caller like the user font set and co.
Depends on D20141
Differential Revision: https://phabricator.services.mozilla.com/D20142 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index db7824c5f..74bae0287 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2641,11 +2641,8 @@ fn static_assert() {
pub fn set_font_variant_alternates(
&mut self,
v: values::computed::... | 2 | 0 | 11 |
2de9bcc458fe6e71d7ac9ee98d2a9665a2cd9f42 | Emilio Cobos Álvarez | 2019-02-19T11:17:28 | Bug 1528712 - Remove a couple trivial dependencies on nsPresContext. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D20141 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 24f2009a3..2547f2a45 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -461,7 +461,7 @@ fn eval_moz_is_glyph(
query_value: Option<bool>,
_: Option<RangeOrOperator>,
) -> bool {
- let is_glyph =... | 9 | 32 | 34 |
ea3257ff3e94951d84e7beacdaf53976737c99ac | Ciure Andrei | 2019-02-19T12:25:57 | Backed out 2 changesets (bug 1528712) for Linux spcshell and reftest failures (test_ext_browserSettings.js, 1022481-1.html) CLOSED TREE
Backed out changeset 2d5c4e71e258 (bug 1528712)
Backed out changeset d981515b874b (bug 1528712) | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 2547f2a45..24f2009a3 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -461,7 +461,7 @@ fn eval_moz_is_glyph(
query_value: Option<bool>,
_: Option<RangeOrOperator>,
) -> bool {
- let is_glyph =... | 9 | 43 | 30 |
04e1eca21e16189272696ca2e3c310e060b15752 | Emilio Cobos Álvarez | 2019-02-18T14:03:47 | Bug 1528712 - Remove nsFont::featureValueLookup. r=jfkthame
It's a global object, it doesn't have to be stored in nsFont. Pass it from the
caller like the user font set and co.
Depends on D20141
Differential Revision: https://phabricator.services.mozilla.com/D20142 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 0fd57cd38..6c1e98bb3 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2651,11 +2651,8 @@ fn static_assert() {
pub fn set_font_variant_alternates(
&mut self,
v: values::computed::... | 2 | 0 | 11 |
b981b1484123059608acab43f2b218ad7ef39ec1 | Emilio Cobos Álvarez | 2019-02-19T11:17:28 | Bug 1528712 - Remove a couple trivial dependencies on nsPresContext. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D20141 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 24f2009a3..2547f2a45 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -461,7 +461,7 @@ fn eval_moz_is_glyph(
query_value: Option<bool>,
_: Option<RangeOrOperator>,
) -> bool {
- let is_glyph =... | 9 | 32 | 34 |
32142900c6c47ed55ff0081135c7e11d22709a72 | Hiroyuki Ikezoe | 2019-02-18T02:25:54 | Bug 1528639 - Implement scroll-margin parser and serializer. r=emilio
The reason why we use RelaxedAtomBoolis that
ScrollSnapUtils::GetSnapPointForDestination() is called both from the main and
the compositor threads, and the function will have a branch depending on the
pref value.
Differential Revision: https://pha... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index cb64a3d1e..0260be793 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1661,14 +1661,19 @@ fn static_assert() {
}
</%self:impl_trait>
+<% skip_scroll_margin_longhands = " ".join(["scroll-margin-... | 3 | 50 | 1 |
d9b843203f1a220eebbaf3742c80e45ab350162c | Brian Birtles | 2019-02-15T06:35:04 | Bug 1524480 - Don't share styles when an element has animations applied to it; r=emilio
We already avoid putting styles in the shared style cache for an element that
has animations[1] but if we are doing the initial style of two siblings where
the _second_ has animations applied, there is nothing to stop us from tryin... | diff --git a/style/sharing/mod.rs b/style/sharing/mod.rs
index c7be23572..0675359ed 100644
--- a/style/sharing/mod.rs
+++ b/style/sharing/mod.rs
@@ -766,6 +766,11 @@ impl<E: TElement> StyleSharingCache<E> {
return None;
}
+ if target.element.has_animations() {
+ trace!("Miss: H... | 1 | 5 | 0 |
a76cc90f6e965a9e534ad65326b58cceeeb05e9b | Emilio Cobos Álvarez | 2019-02-11T10:59:49 | Bug 1526736 - Rename MozLength to Size, and MaxLength to MaxSize. r=heycam
MozLength is not a very descriptive name. If we're going to use it in both Gecko
and Servo we may as well name it something more accurate.
I would've chosen `ContentSize` per CSS2[1][2] if it wasn't a lie in presence
of box-sizing. I don't hav... | diff --git a/style/gecko/values.rs b/style/gecko/values.rs
index ac3495a75..33706f705 100644
--- a/style/gecko/values.rs
+++ b/style/gecko/values.rs
@@ -14,7 +14,7 @@ use crate::media_queries::Device;
use crate::values::computed::basic_shape::ShapeRadius as ComputedShapeRadius;
use crate::values::computed::FlexBasis ... | 11 | 130 | 138 |
7806bd2de87a578c3723a9321240ad3503594240 | Alan Jeffrey | 2019-02-05T01:35:03 | No bug - Cherry-pick changes from Servo PR #22825. r=npotb | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 8e838c350..223db1d6e 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -34,6 +34,17 @@ ${helpers.single_keyword(
spec="Internal (not web-exposed)",
)}
+// An inter... | 2 | 16 | 4 |
429df864db67bc257e382192a76439c8a45305b9 | Emilio Cobos Álvarez | 2019-01-26T10:00:22 | Bug 1523071 - Use the style system's LengthPercentage for shape-margin. r=jwatt
This also makes us pass a few WPTs because we stop losing precision when
serializing the computed value.
Differential Revision: https://phabricator.services.mozilla.com/D17738 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 970a807f0..a11d08ba4 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1396,7 +1396,7 @@ impl Clone for ${style_struct.gecko_struct_name} {
"MozLength": impl_style_coord,
"MozScriptMin... | 2 | 2 | 1 |
5ccc3c7f4c9feb95d914ae5743510b57ebcd3552 | Emilio Cobos Álvarez | 2019-02-08T22:40:26 | Bug 1525955 - Cleanup a bit after bug 1525371. r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D19001 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 5dc8a0f66..2c25a2095 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -80,7 +80,6 @@ pub struct ComputedValues(crate::gecko_bindings::structs::mozilla::ComputedStyle
impl ComputedValues {
pub fn... | 2 | 22 | 42 |
211f8070602d66e6a082c845fa7f8a50a97fad12 | Emilio Cobos Álvarez | 2019-02-04T15:57:12 | Bug 1440384 - Generate combined transform just once. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D18567 | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index 7fdbb7177..d881524de 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -629,6 +629,10 @@ impl<'a, 'b: 'a> Cascade<'a, 'b> {
#[cfg(feature = "gecko")]
{
+ if let Some(display) = builder... | 2 | 9 | 0 |
5c339dcfada5a99f53537d792bb1077982d32606 | Emilio Cobos Álvarez | 2019-01-30T20:55:54 | Bug 1523712 - Make -moz-binding chrome / UA only. r=boris
But enable it in all tests because a lot of them rely on using it in the
style="" attribute for example, or in inline stylesheets, which will no longer
parse this (even in chrome documents), and we don't want to rewrite all the XUL
and XBL tests.
Differential ... | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 10e610a32..8e838c350 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -591,6 +591,8 @@ ${helpers.predefined_type(
products="gecko",
animation_value_type="none",... | 1 | 2 | 0 |
8c61aaf189841b3bc360c2c50b2a8011912ebc06 | Emilio Cobos Álvarez | 2019-01-29T01:54:24 | No bug - rustfmt recent changes. | diff --git a/style/lib.rs b/style/lib.rs
index 4976c787a..2ea20088e 100644
--- a/style/lib.rs
+++ b/style/lib.rs
@@ -37,9 +37,9 @@ extern crate crossbeam_channel;
#[macro_use]
extern crate cssparser;
#[macro_use]
-extern crate derive_more;
-#[macro_use]
extern crate debug_unreachable;
+#[macro_use]
+extern crate de... | 2 | 24 | 4 |
71190afdec3f2d21d8bd62c68d12aa7f09383c2f | Emilio Cobos Álvarez | 2019-01-28T00:04:06 | Bug 1523142 - Simplify some conversion code used for mapped attributes. r=firefox-style-system-reviewers,boris
These days for the types we share computed value representation we don't really
need any special code.
Differential Revision: https://phabricator.services.mozilla.com/D17763 | diff --git a/style/properties/longhands/border.mako.rs b/style/properties/longhands/border.mako.rs
index b9d3425f8..c9d6b7f5e 100644
--- a/style/properties/longhands/border.mako.rs
+++ b/style/properties/longhands/border.mako.rs
@@ -61,15 +61,6 @@
)}
% endfor
-${helpers.gecko_keyword_conversion(
- Keyword('b... | 3 | 3 | 11 |
7788fe24af9ddd87a5c2fdba19b76099c7f794a1 | Emilio Cobos Álvarez | 2019-01-23T16:38:55 | Bug 1521405 - Cleanup a few shorthand properties. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D17082 | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index 3cbc5a2a3..59c978529 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -793,6 +793,58 @@
% endif
</%def>
+// A shorthand of kind `<property-1> <property-2>?` where both properties have
+/... | 5 | 144 | 236 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.