commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
db9f387106949f6a9d88bb91806ed22d6eb37eab
Bobby Holley
2019-01-18T20:39:29
Bug 1521187 - Derive more. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D17029
diff --git a/selectors/builder.rs b/selectors/builder.rs index e653af58f..80e8457cf 100644 --- a/selectors/builder.rs +++ b/selectors/builder.rs @@ -23,7 +23,6 @@ use servo_arc::{Arc, HeaderWithLength, ThinArc}; use smallvec::{self, SmallVec}; use std::cmp; use std::iter; -use std::ops::{Add, AddAssign}; use std::p...
8
14
91
41ffa9c80a21301193c14c82ba63c5be0c1e10f2
Bobby Holley
2019-01-18T20:32:22
Bug 1521187 - Add a dependency on derive_more. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D17028
diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml index b2437831b..bb8e5d7f8 100644 --- a/selectors/Cargo.toml +++ b/selectors/Cargo.toml @@ -23,6 +23,7 @@ bench = [] bitflags = "1.0" matches = "0.1" cssparser = "0.25" +derive_more = "0.13" log = "0.4" fxhash = "0.2" phf = "0.7.18" diff --git a/style/Cargo...
2
2
0
89ba61a06294c3d1d84e8a756c086de7e7857e1e
Emilio Cobos Álvarez
2019-01-21T01:35:00
Bug 1521399 - Remove layout.css.overflow.moz-scrollbars.enabled. r=mats We've been shipping it for a few releases already, see bug 1481125. Differential Revision: https://phabricator.services.mozilla.com/D17081
diff --git a/style/properties/shorthands/box.mako.rs b/style/properties/shorthands/box.mako.rs index 02763207c..3469d3f3f 100644 --- a/style/properties/shorthands/box.mako.rs +++ b/style/properties/shorthands/box.mako.rs @@ -11,47 +11,11 @@ spec="https://drafts.csswg.org/css-overflow/#propdef-overflow" > use...
1
0
36
6a2608d283d9a687a87b0684071394cc9a244e62
Emilio Cobos Álvarez
2019-01-20T15:48:19
Bug 1520229 - [css-logical] Implement the inset shorthand. r=mats Reviewers: mats Reviewed By: mats Bug #: 1520229 Differential Revision: https://phabricator.services.mozilla.com/D16704
diff --git a/style/properties/shorthands/position.mako.rs b/style/properties/shorthands/position.mako.rs index 561affe95..ad00ba8ea 100644 --- a/style/properties/shorthands/position.mako.rs +++ b/style/properties/shorthands/position.mako.rs @@ -763,6 +763,15 @@ } </%helpers:shorthand> +// See https://github.com...
1
9
0
36109fb77c9435be8bbc4f0df65627b78f4ed7cb
Emilio Cobos Álvarez
2019-01-20T15:26:36
Bug 1521392 - Cherry-pick Servo-only changes to malloc_size_of.
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 92b3db44c..e7acb0de2 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -33,6 +33,7 @@ hashglobe = { path = "../hashglobe" } hyper = { version = "0.12", optional = true } hyper_serde = { version = "0.9", optional = true } ...
2
1
8
44701fb8e2716c1df8aa56c8696f68334b910a1d
Emilio Cobos Álvarez
2019-01-20T14:38:14
Bug 1521392 - Fix servo build and rustfmt recent changes.
diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs index 365e53f62..0f6ac89c9 100644 --- a/style/gecko/conversions.rs +++ b/style/gecko/conversions.rs @@ -36,9 +36,7 @@ use style_traits::values::specified::AllowedNumericType; impl From<LengthPercentage> for nsStyleCoord_CalcValue { fn from(other...
7
45
36
3bd18689f234c08f3594d620d54edd4a968a50f1
Martin Stransky
2019-01-18T13:52:29
Bug 1433667 - Honour system titlebar button left/right placement, r=dao Differential Revision: https://phabricator.services.mozilla.com/D16466
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index e18b1cd8b..b6596c75d 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -526,7 +526,7 @@ lazy_static! { /// to support new types in these entries and (2) ensuring that either /// nsPresContext::Medi...
1
2
1
23e9441770ce276c6da00db6581a65c5bbe86659
Mats Palmgren
2019-01-17T20:49:07
Bug 1520684 part 2 - [css-logical] Implement the flow-relative border-radius properties. r=emilio
diff --git a/style/properties/longhands/border.mako.rs b/style/properties/longhands/border.mako.rs index 79df20d78..b9d3425f8 100644 --- a/style/properties/longhands/border.mako.rs +++ b/style/properties/longhands/border.mako.rs @@ -3,7 +3,7 @@ * file, You can obtain one at https://mozilla.org/MPL/2.0/. */ <%names...
1
15
5
7364d7787380281c6313f12c3034591ebf4a8825
Mats Palmgren
2019-01-17T19:02:41
Bug 1520236 - [css-logical] Implement the border-{block,inline}-{color,style,width} shorthands. r=emilio
diff --git a/style/properties/shorthands/border.mako.rs b/style/properties/shorthands/border.mako.rs index 949560823..255464892 100644 --- a/style/properties/shorthands/border.mako.rs +++ b/style/properties/shorthands/border.mako.rs @@ -356,6 +356,50 @@ pub fn parse_border<'i, 't>( } </%helpers:shorthand> +% fo...
1
44
0
03212d01e39b86c7a14eee944ba049ec980a0cbb
Martin Stransky
2019-01-17T12:44:49
Bug 1490344 - [Linux/Gtk] Enable hidden system titlebar by default on Gnome, r=dao This patch implements -moz-gtk-csd-hide-titlebar-by-default media query to check if the system titlebar should be disabled by default on Linux systems (it's already disabled on Window/Mac). It also removes explicit definition of browse...
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 82613c9e2..e18b1cd8b 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -526,7 +526,7 @@ lazy_static! { /// to support new types in these entries and (2) ensuring that either /// nsPresContext::Medi...
1
2
1
1934a66c9b89cf7e9b622f6f61feb7dae4db72a2
Noemi Erli
2019-01-16T23:18:00
Backed out changeset 009cf5f885ba (bug 1520236) for multiple failures in logical-box-border-color-visited-link-002.html
diff --git a/style/properties/shorthands/border.mako.rs b/style/properties/shorthands/border.mako.rs index 255464892..949560823 100644 --- a/style/properties/shorthands/border.mako.rs +++ b/style/properties/shorthands/border.mako.rs @@ -356,50 +356,6 @@ pub fn parse_border<'i, 't>( } </%helpers:shorthand> -% fo...
1
0
44
0c3df52f4e7880b00fc3abb55a957375cb082259
Mats Palmgren
2019-01-16T18:26:15
Bug 1520396 - [css-logical] Implement the border-block/border-inline shorthands. r=emilio
diff --git a/style/properties/shorthands/border.mako.rs b/style/properties/shorthands/border.mako.rs index 314d58248..255464892 100644 --- a/style/properties/shorthands/border.mako.rs +++ b/style/properties/shorthands/border.mako.rs @@ -399,3 +399,50 @@ pub fn parse_border<'i, 't>( </%helpers:shorthand> %...
1
47
0
1eeee36cb9bc9e3530212c66815b8ddbf59d569b
Mats Palmgren
2019-01-16T18:26:15
Bug 1520236 - [css-logical] Implement the border-{block,inline}-{color,style,width} shorthands. r=emilio
diff --git a/style/properties/shorthands/border.mako.rs b/style/properties/shorthands/border.mako.rs index 68b7ca5f6..314d58248 100644 --- a/style/properties/shorthands/border.mako.rs +++ b/style/properties/shorthands/border.mako.rs @@ -355,3 +355,47 @@ pub fn parse_border<'i, 't>( } } </%helpers:shortha...
1
44
0
d02ad36e0387928c0d5ef262c2cc5012e44f2da9
Mats Palmgren
2019-01-16T18:26:14
Bug 1520229 - [css-logical] Implement the inset-block/inline shorthands. r=emilio
diff --git a/style/properties/shorthands/position.mako.rs b/style/properties/shorthands/position.mako.rs index cb9ceb386..4b2dfd1ea 100644 --- a/style/properties/shorthands/position.mako.rs +++ b/style/properties/shorthands/position.mako.rs @@ -762,3 +762,46 @@ } } </%helpers:shorthand> + +% for axis in ...
1
43
0
75d8ffa347ce181e93da75cf9b21811a7a18aff2
Andreea Pavel
2019-01-16T11:33:24
Backed out changeset aa442da7cfd8 (bug 1490344) for failing bc at browser/components/customizableui/test/browser_970511_undo_restore_default.js on a CLOSED TREE
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index e18b1cd8b..82613c9e2 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -526,7 +526,7 @@ lazy_static! { /// to support new types in these entries and (2) ensuring that either /// nsPresContext::Medi...
1
1
2
6942e7d66db0b776c10e13390181794257959b58
Mats Palmgren
2019-01-15T01:27:44
Bug 1519944 - [css-logical] Implement the margin-block/inline shorthands. r=emilio
diff --git a/style/properties/shorthands/margin.mako.rs b/style/properties/shorthands/margin.mako.rs index 86e3b56a2..4e74427cd 100644 --- a/style/properties/shorthands/margin.mako.rs +++ b/style/properties/shorthands/margin.mako.rs @@ -8,3 +8,46 @@ ${helpers.four_sides_shorthand("margin", "margin-%s", "specified::Leng...
1
43
0
103b39c034dccdc8568d91fe1ba5dbe0fb4d3f86
Mats Palmgren
2019-01-14T18:22:03
Bug 1519847 - [css-logical] Implement the padding-block/inline shorthands. r=emilio
diff --git a/style/properties/shorthands/padding.mako.rs b/style/properties/shorthands/padding.mako.rs index 0314a4693..cf96c56d2 100644 --- a/style/properties/shorthands/padding.mako.rs +++ b/style/properties/shorthands/padding.mako.rs @@ -7,3 +7,46 @@ ${helpers.four_sides_shorthand("padding", "padding-%s", "specifie...
1
43
0
9768711a60853b10e887df928351847e1bedc74b
Emilio Cobos Álvarez
2019-01-13T20:49:46
Bug 1519729 - Rustfmt recent changes.
diff --git a/style/values/animated/grid.rs b/style/values/animated/grid.rs index 0943e97ce..2b59f32e4 100644 --- a/style/values/animated/grid.rs +++ b/style/values/animated/grid.rs @@ -11,15 +11,19 @@ // Animate for the computed types, instead of the generic types. use super::{Animate, Procedure, ToAnimatedZero}; -...
5
58
52
84d14e0930beb87bc726d6b81a107c1b0f67879a
lqd
2019-01-11T15:35:26
Bug 1519729 - Typo fix in new doc-comment. r=emilio Cherry-picks a commit from https://github.com/servo/servo/pull/22674 Co-Authored-By: SimonSapin <simon.sapin@exyr.org>
diff --git a/style_traits/values.rs b/style_traits/values.rs index 0d7ee3f50..582e34eb3 100644 --- a/style_traits/values.rs +++ b/style_traits/values.rs @@ -432,7 +432,7 @@ impl_to_css_for_predefined_type!(::cssparser::RGBA); impl_to_css_for_predefined_type!(::cssparser::Color); impl_to_css_for_predefined_type!(::css...
1
1
1
36007f570b19a12a904bbf2d952debb67be28150
Simon Sapin
2019-01-11T13:03:44
Bug 1519729 - Document public macros. r=emilio Undocumented public macros emit warnings in nightly-2019-01-11, and we #![deny] that warning. Cherry-picks a commit from https://github.com/servo/servo/pull/22674
diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs index 2d91273be..9220c3b1a 100644 --- a/style/properties/properties.mako.rs +++ b/style/properties/properties.mako.rs @@ -3821,7 +3821,14 @@ impl AliasId { } } -// NOTE(emilio): Callers are responsible to deal with prefs. +//...
2
17
2
ecb55e90ef0b1a5b3d737799287758b0f6ec285c
Simon Sapin
2019-01-11T13:02:28
Bug 1519729 - Remove unused macro. r=emilio Cherry-picks a commit from https://github.com/servo/servo/pull/22674
diff --git a/style_traits/values.rs b/style_traits/values.rs index 6da235c07..2851082c2 100644 --- a/style_traits/values.rs +++ b/style_traits/values.rs @@ -158,24 +158,6 @@ where } } -#[macro_export] -macro_rules! serialize_function { - ($dest: expr, $name: ident($( $arg: expr, )+)) => { - serialize_...
1
0
18
6e593d71ae31648f1691b6c04e9fb9a3e4955606
Cameron McCormack
2019-01-12T06:45:45
Bug 1519296 - Part 4: Remove ServoStyleSet::PrependStyleSheet r=emilio Depends on D16283 Differential Revision: https://phabricator.services.mozilla.com/D16284
diff --git a/style/stylesheet_set.rs b/style/stylesheet_set.rs index 507534edc..35060a959 100644 --- a/style/stylesheet_set.rs +++ b/style/stylesheet_set.rs @@ -345,14 +345,6 @@ where self.data_validity = cmp::max(validity, self.data_validity); } - fn prepend(&mut self, sheet: S) { - debug_ass...
2
0
28
66f404db93a4a6b03eb91e823097c876d53c7aa6
Boris Chiou
2019-01-12T02:22:39
Bug 1348519 - Part 2: Implement Animate for track lists on grid-template-{columns|rows}. r=emilio Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1348519#c6 and https://github.com/w3c/csswg-drafts/issues/3201: Currently grid-template-rows/columns interpolate “per computed value”, which means that if the number ...
diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs index a7a6910f9..cc5515dba 100644 --- a/style/properties/longhands/position.mako.rs +++ b/style/properties/longhands/position.mako.rs @@ -383,7 +383,7 @@ ${helpers.predefined_type( spec="https://drafts.csswg....
4
191
7
cd7cc0097de1ffc45627edd99939e1d1f46d00a9
Boris Chiou
2019-01-12T02:19:04
Bug 1348519 - Part 1: Support field_bound on Animate. r=emilio So we can derive Animate on more generic types. Differential Revision: https://phabricator.services.mozilla.com/D16339
diff --git a/style/values/animated/mod.rs b/style/values/animated/mod.rs index a4e79074e..00410e177 100644 --- a/style/values/animated/mod.rs +++ b/style/values/animated/mod.rs @@ -113,7 +113,8 @@ pub fn animate_multiplicative_factor( /// function has been specified through `#[animate(fallback)]`. /// /// Trait boun...
2
28
16
b32620593e1690ebd520f053890be9b6c95e2a24
Emilio Cobos Álvarez
2019-01-10T23:57:26
Bug 1519269 - Rustfmt recent changes.
diff --git a/style/gecko_string_cache/mod.rs b/style/gecko_string_cache/mod.rs index 197eca164..9c33f25d9 100644 --- a/style/gecko_string_cache/mod.rs +++ b/style/gecko_string_cache/mod.rs @@ -14,10 +14,10 @@ use crate::gecko_bindings::bindings::Gecko_AddRefAtom; use crate::gecko_bindings::bindings::Gecko_Atomize; us...
1
2
2
f7b098955cbfb5d1b89b9dda8271c2eedc8866f5
Shanavas M
2019-01-10T23:57:02
Bug 1519269 - Remove OrderedMap in favor of IndexMap. r=emilio This cherry-picks https://github.com/servo/servo/pull/22656.
diff --git a/style/Cargo.toml b/style/Cargo.toml index d1cc1c601..9b0b64c37 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -38,6 +38,7 @@ fallible = { path = "../fallible" } fxhash = "0.2" hashglobe = { path = "../hashglobe" } html5ever = {version = "0.22", optional = true} +indexmap = "1.0" itertools = "0...
3
11
132
f16d6e3804b03ca411f0470158349fe2c34450bf
Cameron McCormack
2019-01-10T06:01:03
Bug 1518992 - Remove unnecessary mem::transmute in MediaListKey r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D16147
diff --git a/style/invalidation/media_queries.rs b/style/invalidation/media_queries.rs index aeec7f1ac..75149a028 100644 --- a/style/invalidation/media_queries.rs +++ b/style/invalidation/media_queries.rs @@ -38,10 +38,8 @@ impl MediaListKey { pub trait ToMediaListKey: Sized { /// Get a `MediaListKey` for this it...
1
1
3
f2afb92be5c2cb06babc4d552442a9c78d96b766
Cameron McCormack
2019-01-07T09:50:25
Bug 1500362 - Make GkAtoms opaque to avoid lld-link.exe errors r=emilio Depends on D15078 Differential Revision: https://phabricator.services.mozilla.com/D15800
diff --git a/style/gecko_string_cache/mod.rs b/style/gecko_string_cache/mod.rs index d06091df8..197eca164 100644 --- a/style/gecko_string_cache/mod.rs +++ b/style/gecko_string_cache/mod.rs @@ -15,7 +15,9 @@ use crate::gecko_bindings::bindings::Gecko_Atomize; use crate::gecko_bindings::bindings::Gecko_Atomize16; use c...
1
26
3
a5a588115eb9b6853de4e170f4125ef087e408b6
Emilio Cobos Álvarez
2019-01-07T15:57:43
Bug 1517511, bug 1518098 - followup: Rustfmt so Servo's lints are happy.
diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs index 7e896b375..89cce99be 100644 --- a/style/gecko/conversions.rs +++ b/style/gecko/conversions.rs @@ -80,8 +80,8 @@ impl From<nsStyleCoord_CalcValue> for LengthPercentageOrAuto { // disappear as we move more stuff to cbindgen. impl From<nsStyleCoo...
14
85
98
ff88563476da67d766070cf165627d8e10752e49
Emilio Cobos Álvarez
2019-01-07T15:46:29
Bug 1517511 - followup: fix servo build.
diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs index 0df4ff524..a7a6910f9 100644 --- a/style/properties/longhands/position.mako.rs +++ b/style/properties/longhands/position.mako.rs @@ -297,7 +297,7 @@ ${helpers.predefined_type( ${helpers.predefined_type( ...
1
1
1
c1957691a5e9e22911b0070a6ebceff7e9472012
Emilio Cobos Álvarez
2019-01-07T12:42:40
Bug 1518098 - Manually rename some variables. r=jwatt#style lop is not an acceptable variable name for LengthPercentage. Differential Revision: https://phabricator.services.mozilla.com/D15813
diff --git a/style/gecko/values.rs b/style/gecko/values.rs index b4c26bc7d..4937b019b 100644 --- a/style/gecko/values.rs +++ b/style/gecko/values.rs @@ -185,7 +185,7 @@ impl GeckoStyleCoordConvertible for LengthPercentageOrAuto { fn to_gecko_style_coord<T: CoordDataMut>(&self, coord: &mut T) { match *self...
14
92
92
d87127391bddc8bca5c65d4ce5317201243fdc26
Bastien Orivel
2018-12-22T20:02:42
Bug 1518045 - Update owning_ref to 0.4. This cherry-picks https://github.com/servo/servo/pull/22534, plus the relevant re-vendoring.
diff --git a/style/Cargo.toml b/style/Cargo.toml index b3622dd7b..c59431106 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -52,7 +52,7 @@ num-integer = "0.1" num-traits = "0.2" num-derive = "0.2" ordered-float = "1.0" -owning_ref = "0.3.3" +owning_ref = "0.4" parking_lot = "0.6" precomputed-hash = "0.1.1"...
1
1
1
91d81b7bb3c38c311c07160aca55cd84cdcd325d
Emilio Cobos Álvarez
2019-01-06T23:00:55
Bug 1518045 - Rustfmt recent changes.
diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs index e077a9f96..266ebbd75 100644 --- a/style/gecko/conversions.rs +++ b/style/gecko/conversions.rs @@ -24,11 +24,11 @@ use crate::values::computed::{Angle, CalcLengthOrPercentage, Gradient, Image}; use crate::values::computed::{Integer, LengthOrPerc...
16
53
43
6e3881bcbe88839a5b4fc633dfdb16fef83da44c
Simon Sapin
2018-12-31T00:01:49
Bug 1518045 - Publish selectors 0.21.0 on crates.io. r=emilio This cherry-picks https://github.com/servo/servo/pull/22577, with the relevant lockfile update.
diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml index 86d4a7186..b2437831b 100644 --- a/selectors/Cargo.toml +++ b/selectors/Cargo.toml @@ -1,7 +1,7 @@ [package] name = "selectors" -version = "0.20.0" +version = "0.21.0" authors = ["The Servo Project Developers"] documentation = "https://docs.rs/selector...
1
1
1
08d08994510038281b1da1653e094a3a76893400
Bastien Orivel
2018-12-12T20:32:52
Bug 1518045 - Fix all clippy warnings in style_derive. r=emilio This cherry-picks https://github.com/servo/servo/pull/22439.
diff --git a/style_derive/cg.rs b/style_derive/cg.rs index b963e326c..6eeca384b 100644 --- a/style_derive/cg.rs +++ b/style_derive/cg.rs @@ -29,7 +29,7 @@ where }); s.each_variant(|variant| { let (mapped, mapped_fields) = value(variant, "mapped"); - let fields_pairs = variant.bindings().into_i...
4
12
14
b7f385c22e3d152c590cb8db52345a6034968fde
Emilio Cobos Álvarez
2018-12-17T22:46:42
Bug 1518045 - Make Servo use a single thread-pool for layout-related tasks per-process. r=jdm Instead of per-document. This also allows to reuse this thread-pool if needed for other stuff, like parallel CSS parsing (#22478), and to share more code with Gecko, which is always nice. This cherry-picks https://github.com...
diff --git a/style/Cargo.toml b/style/Cargo.toml index e75dca5b3..b3622dd7b 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -16,8 +16,7 @@ path = "lib.rs" doctest = false [features] -gecko = ["nsstring", "num_cpus", - "style_traits/gecko", "fallible/known_system_malloc"] +gecko = ["nsstring", "style...
5
32
19
20f4a091816dadd55a1bbaf078cb5f885bcc5b2d
bitnotri
2019-01-04T22:03:56
Bug 1461737 - Move nsstring-rs to a better location, r=nika Differential Revision: https://phabricator.services.mozilla.com/D15743
diff --git a/style/Cargo.toml b/style/Cargo.toml index b1d607b5f..e75dca5b3 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -47,7 +47,7 @@ log = "0.4" malloc_size_of = { path = "../malloc_size_of" } malloc_size_of_derive = { path = "../malloc_size_of_derive" } matches = "0.1" -nsstring = {path = "../../suppo...
1
1
1
ccb6a06e13328d188a0ec944b3c5a5f720c9dabb
Hiroyuki Ikezoe
2019-01-04T07:21:32
Bug 1517682 - Drop layout.css.background-blend-mode.enabled pref. r=heycam It was enabled by default in bug 970600. Depends on D15707 Differential Revision: https://phabricator.services.mozilla.com/D15708
diff --git a/style/properties/longhands/background.mako.rs b/style/properties/longhands/background.mako.rs index 934814567..b97545898 100644 --- a/style/properties/longhands/background.mako.rs +++ b/style/properties/longhands/background.mako.rs @@ -108,7 +108,6 @@ ${helpers.single_keyword( color-burn hard-light so...
1
0
1
458c40f76fc4cc7f4202351b18476c5cc6e67148
Hiroyuki Ikezoe
2019-01-04T07:21:53
Bug 1517682 - Drop layout.css.scroll-behavior.property-enabled pref. r=heycam It was enabled by default in bug 1041833 (for desktops) and bug 1087562 (for Fennect). Depends on D15706 Differential Revision: https://phabricator.services.mozilla.com/D15707
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index cb580cc93..48b83271d 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -389,7 +389,6 @@ ${helpers.predefined_type( ${helpers.single_keyword( "scroll-behavior", ...
1
0
1
d97718f7d79c05cf63138697729cef7b72f04109
Hiroyuki Ikezoe
2019-01-04T07:22:13
Bug 1517682 - Drop layout.css.mix-blend-mode.enabled pref. r=heycam It was enabled by default in bug 952643. Depends on D15705 Differential Revision: https://phabricator.services.mozilla.com/D15706
diff --git a/style/properties/longhands/effects.mako.rs b/style/properties/longhands/effects.mako.rs index 066ac4ca0..0b3f96f0d 100644 --- a/style/properties/longhands/effects.mako.rs +++ b/style/properties/longhands/effects.mako.rs @@ -62,6 +62,5 @@ ${helpers.single_keyword( gecko_constant_prefix="NS_STYLE_BLEND"...
1
0
1
2da018bb45dd880cfc60016568e00e011b8020ca
Hiroyuki Ikezoe
2019-01-04T07:22:27
Bug 1517682 - Drop layout.css.isolation.enabled pref. r=heycam It was enabled by default in bug 1091885. Depends on D15704 Differential Revision: https://phabricator.services.mozilla.com/D15705
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 7eb6ff002..cb580cc93 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -427,7 +427,6 @@ ${helpers.single_keyword( "isolation", "auto isolate", products="gec...
1
0
1
fee675039e9cc383e1cba3d522da82f73ae2b9c4
Hiroyuki Ikezoe
2019-01-04T07:22:52
Bug 1517682 - Drop layout.css.image-orientation.enabled pref. r=heycam It was enabled by default in bug 825771. Depends on D15703 Differential Revision: https://phabricator.services.mozilla.com/D15704
diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs index 4da616286..0e3799f6c 100644 --- a/style/properties/longhands/inherited_box.mako.rs +++ b/style/properties/longhands/inherited_box.mako.rs @@ -77,6 +77,5 @@ ${helpers.single_keyword( products="geck...
1
0
1
8c0172023fde149d82c25ac0a023b22a0c2c42fe
Hiroyuki Ikezoe
2019-01-04T07:23:38
Bug 1517682 - Drop layout.css.color-adjust.enabled pref. r=heycam It was enabled by default in bug 1209273. Depends on D15702 Differential Revision: https://phabricator.services.mozilla.com/D15703
diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs index aaa681517..4da616286 100644 --- a/style/properties/longhands/inherited_box.mako.rs +++ b/style/properties/longhands/inherited_box.mako.rs @@ -55,7 +55,6 @@ ${helpers.single_keyword( "color-adjust"...
1
0
1
ae55acb886851283c8499fda9cb48373f7babcc7
Hiroyuki Ikezoe
2019-01-04T07:23:07
Bug 1517682 - Drop layout.css.box-decoration-break.enabled pref. r=heycam It was enabled by default in bug 1006326. Differential Revision: https://phabricator.services.mozilla.com/D15702
diff --git a/style/properties/longhands/border.mako.rs b/style/properties/longhands/border.mako.rs index 2c304780e..3fcf73bf2 100644 --- a/style/properties/longhands/border.mako.rs +++ b/style/properties/longhands/border.mako.rs @@ -88,7 +88,6 @@ ${helpers.single_keyword( "box-decoration-break", "slice clone"...
1
0
1
b4e1db63ac71fbbd6a53da875e5dac9c940cf9e3
Emilio Cobos Álvarez
2019-01-02T13:05:23
Bug 1517241 - Rename nsIDocument to mozilla::dom::Document. r=smaug Summary: Really sorry for the size of the patch. It's mostly automatic s/nsIDocument/Document/ but I had to fix up in a bunch of places manually to add the right namespacing and such. Overall it's not a very interesting patch I think. nsDocument.cpp...
diff --git a/style/element_state.rs b/style/element_state.rs index a646a2a37..8165c73ef 100644 --- a/style/element_state.rs +++ b/style/element_state.rs @@ -144,7 +144,7 @@ bitflags! { /// Event-based document states. /// /// NB: Is important for this to remain in sync with Gecko's - /// dom/base/nsID...
4
12
13
9b26d5545d92344728c2b536bce0f5349100e002
Xidorn Quan
2018-12-30T08:37:19
Bug 1516829 - Replace trim_{left,right}* with trim_{start,end}*. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D15496
diff --git a/style/attr.rs b/style/attr.rs index eb7fd9ece..2e2372be2 100644 --- a/style/attr.rs +++ b/style/attr.rs @@ -548,7 +548,7 @@ pub fn parse_length(mut value: &str) -> LengthOrPercentageOrAuto { // Steps 1 & 2 are not relevant // Step 3 - value = value.trim_left_matches(HTML_SPACE_CHARACTERS); +...
4
4
4
a10dc311813788119e1faaca6d1d84741e4dc2e1
quasicomputational
2018-12-22T19:41:33
Bug 1422235 - Implement the 'overflow-inline' media query. r=emilio
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index 553757ff1..af166e609 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -327,6 +327,28 @@ fn eval_overflow_block(device: &Device, query_value: Option<OverflowBlock>) -> b } } +#[derive(Clone, Copy, De...
1
29
1
ae73ff291503339e578fcc0ea52092ca3a068446
quasicomputational
2018-12-27T14:43:34
Bug 1422235 - Implement the 'overflow-block' media query. r=emilio
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index de37629ca..553757ff1 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -10,7 +10,7 @@ use crate::gecko_bindings::structs; use crate::media_queries::media_feature::{AllowsRanges, ParsingRequirements}; use c...
1
40
2
93ed49a7e9da9f000948b93da32cf68818d95a6b
Emilio Cobos Álvarez
2018-12-25T23:09:29
Bug 1516365 - Update the Rust target version for bindgen. r=xidorn This brings us alignas support and also associated constants for bitfield enums. Differential Revision: https://phabricator.services.mozilla.com/D15334
diff --git a/style/build_gecko.rs b/style/build_gecko.rs index 4b5d36232..22a61d1d7 100644 --- a/style/build_gecko.rs +++ b/style/build_gecko.rs @@ -139,7 +139,9 @@ mod bindings { // Disable rust unions, because we replace some types inside of // them. - let mut builder = Builder:...
7
26
40
34500f9d66a4c1a975b8b696869867b5b2a55f50
Razvan Maries
2018-12-24T20:31:38
Backed out 2 changesets (bug 1422235) for failing reftests: tests/layout/reftests/css-mediaqueries/mq_print_iframe_overflow-block-ref.html. CLOSED TREE Backed out changeset 2f2f235a4cba (bug 1422235) Backed out changeset 849c2b71aae4 (bug 1422235)
diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs index af166e609..de37629ca 100644 --- a/style/gecko/media_features.rs +++ b/style/gecko/media_features.rs @@ -10,7 +10,7 @@ use crate::gecko_bindings::structs; use crate::media_queries::media_feature::{AllowsRanges, ParsingRequirements}; use c...
1
2
68
d529456a48cdb44b6aeda608ba508177abccdb50
sharath
2018-12-24T15:28:11
Bug 1516221 - changes to implement enum class for #define NS_STYLE_COLOR_ADJUST. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D15284
diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs index 65d5727f1..aaa681517 100644 --- a/style/properties/longhands/inherited_box.mako.rs +++ b/style/properties/longhands/inherited_box.mako.rs @@ -54,6 +54,7 @@ ${helpers.single_keyword( ${helpers.single_k...
1
1
0
06a6622ab09e392cca506dcf647862f803e5b891
Cameron McCormack
2018-12-20T01:49:42
Bug 1515533 - Bump smallvec and smallbitvec r=emilio Differential Revision: https://phabricator.services.mozilla.com/D15052
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 22840c89d..92b3db44c 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -37,7 +37,7 @@ selectors = { path = "../selectors" } serde = { version = "1.0.27", optional = true } serde_bytes = { version = "0.10", optional = true...
2
3
3
a80aa7a981fc4fb92fe632efb95b1f04c26ae035
Boris Chiou
2018-12-19T19:08:08
Bug 1512883 - Part 1: Clamp to non-negative value after doing interpolation for circle(), ellipse(), and inset(). r=emilio,birtles Replace LengthOrPercentage with NonNegativeLengthOrPercentage on ShapeRadius, Circle, Ellipse. And derive ToAnimatedValue for ShapeSource and its related types, so we clamp its interpolate...
diff --git a/style/gecko/values.rs b/style/gecko/values.rs index 662b777d0..a9162264b 100644 --- a/style/gecko/values.rs +++ b/style/gecko/values.rs @@ -286,7 +286,9 @@ impl GeckoStyleCoordConvertible for ComputedShapeRadius { None } }, - _ => LengthOrPercen...
10
110
27
d02dc3b6415d33f2d7c0d4350b08258c1217f83e
Boris Chiou
2018-12-18T18:47:39
Bug 1322780 - Part 3: Let logical height, block-size, accept keywords. r=emilio We should let block-size/min-block-size/max-block-size accept keywords as the initial value, just like width in vertical writing mode or height in horizontal writing mode. Depends on D7536 Differential Revision: https://phabricator.servi...
diff --git a/style/properties/longhands/position.mako.rs b/style/properties/longhands/position.mako.rs index c5e507da1..53a3acf81 100644 --- a/style/properties/longhands/position.mako.rs +++ b/style/properties/longhands/position.mako.rs @@ -244,21 +244,12 @@ ${helpers.predefined_type( if logical: ...
2
0
33
daec0ba018c5e9e2a1edda278dcdedad6ef71126
Boris Chiou
2018-12-18T18:47:37
Bug 1322780 - Part 2: Support unprefixed min-content and max-content. r=mats,emilio Support unprefixed min-content and max-content and treat the prefixed version as aliases for 1. width, min-width, max-width if inline-axis is horizontal, and 2. height, min-height, max-height if inline-axis is vertical, and 3. inline-s...
diff --git a/style/values/computed/length.rs b/style/values/computed/length.rs index c286e65fd..1af28587a 100644 --- a/style/values/computed/length.rs +++ b/style/values/computed/length.rs @@ -985,8 +985,10 @@ pub type NonNegativeLengthOrPercentageOrNormal = Either<NonNegativeLengthOrPerce )] #[repr(u8)] pub enum Ex...
1
4
2
64baa214e8fc8b41441da6f1aadde75cd3ce4d8f
Emilio Cobos Álvarez
2018-12-17T21:35:14
Bug 1514449 - Use NonNegative more in the border code. r=boris,#style This ended up not being so small of a patch as I'd have thought, since it propagated a bit. But most of it is mechanical. Interesting part is NonNegativeNumberOrPercentage and the actual uses of the NonNegative stuff and during parsing. This looks ...
diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs index 426d8c30a..4dfb989f7 100644 --- a/style/gecko/conversions.rs +++ b/style/gecko/conversions.rs @@ -5,6 +5,8 @@ //! This module contains conversion helpers between Servo and Gecko types //! Ideally, it would be in geckolib itself, but coherence ...
14
161
106
7260b174aeda1660491ac86b8ee12023921951f3
Emilio Cobos Álvarez
2018-12-16T09:13:49
Bug 1514449 - Cleanup some conversion code dealing with NonNegative. r=boris,xidorn,#style I'm about to introduce another use of it and I don't want to repeat the same copy-pasta again. Differential Revision: https://phabricator.services.mozilla.com/D14672
diff --git a/style/gecko/values.rs b/style/gecko/values.rs index 77be7b524..51a3337e6 100644 --- a/style/gecko/values.rs +++ b/style/gecko/values.rs @@ -14,12 +14,10 @@ use crate::gecko_bindings::sugar::ns_style_coord::{CoordData, CoordDataMut, Coor use crate::media_queries::Device; use crate::values::computed::basic...
1
16
32
e84ac0fe420fd5b6e71b9033e3eef55b8e4c35a9
Emilio Cobos Álvarez
2018-12-17T13:14:19
Bug 1513920 - Make <use> shadow trees lookup keyframe rules in the containing tree. r=heycam The same thing we do for rule matching. Differential Revision: https://phabricator.services.mozilla.com/D14548
diff --git a/style/rule_collector.rs b/style/rule_collector.rs index 6424cc237..6304a1af2 100644 --- a/style/rule_collector.rs +++ b/style/rule_collector.rs @@ -5,7 +5,7 @@ //! Collects a series of applicable rules for a given element. use crate::applicable_declarations::{ApplicableDeclarationBlock, ApplicableDecla...
2
53
38
bae2616a28f74578fe594e15d30becb5bd6e7f77
Daniel Holbert
2018-12-15T08:17:46
Bug 1501492: Enable CSS containment for frontend code. r=dbaron Differential Revision: https://phabricator.services.mozilla.com/D9963
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index 1e0629861..e8946c320 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -559,6 +559,7 @@ ${helpers.predefined_type( flags="CREATES_STACKING_CONTEXT FIXPOS_CB", ge...
1
1
0
764900b982eefb08038e685eac79700fde38cbe4
Emilio Cobos Álvarez
2018-12-15T02:50:09
Bug 1514439 - Fix tidy issues.
diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs index ddd7b5f2d..fe988e78f 100644 --- a/malloc_size_of/lib.rs +++ b/malloc_size_of/lib.rs @@ -472,7 +472,7 @@ macro_rules! malloc_size_of_hash_set { n } } - } + }; } malloc_size_of_hash_set!(std::collections::Has...
6
17
32
b633f2010cbe0b703e796c5a34665ad5c12b36de
Shotaro Yamada
2018-12-11T01:43:51
Bug 1514439 - Remove redundant `.clone()`s. r=emilio
diff --git a/style/stylist.rs b/style/stylist.rs index 01e015aa1..c5129520b 100644 --- a/style/stylist.rs +++ b/style/stylist.rs @@ -1024,7 +1024,7 @@ impl Stylist { ViewportRule { declarations: viewport_rule::Cascade::from_stylesheets( - stylesheets.clone(...
1
1
1
cefab5ff977dc4d3fb64ebb2a1317423fc5a16cf
Emilio Cobos Álvarez
2018-12-02T19:05:00
Bug 1514439 - Fix formatting of inverse transform matrix.
diff --git a/style/values/computed/transform.rs b/style/values/computed/transform.rs index e1d391462..e34931315 100644 --- a/style/values/computed/transform.rs +++ b/style/values/computed/transform.rs @@ -137,69 +137,69 @@ impl Matrix3D { det = 1.0 / det; let x = Matrix3D { m11: det * - ...
1
48
48
e42c1775ae1d6686d65c7a76bae25bff3ce297dd
Daniel Holbert
2018-12-14T21:24:17
Bug 1514309 part 1: Include the 'unsafe' keyword in serializations of css-align properties. r=emilio Previously we'd omit it since it was merely an explicit way of requesting the default behavior. But the spec has changed such that it's not necessarily equivalent to the default anymore: https://drafts.csswg.org/css-a...
diff --git a/style/values/specified/align.rs b/style/values/specified/align.rs index 4cf68c9b4..befeaa2ee 100644 --- a/style/values/specified/align.rs +++ b/style/values/specified/align.rs @@ -92,8 +92,7 @@ impl ToCss for AlignFlags { dest.write_char(' ')?; }, AlignFlags::SAFE...
1
1
2
d3951cf36e13487ca5f98f29f7a90834f2c5363e
Boris Zbarsky
2018-12-13T23:25:08
Bug 1514029. Fix serialization of explicitly case-sensitive attr selectors with a namespace. r=emilio Differential Revision: https://phabricator.services.mozilla.com/D14493
diff --git a/selectors/parser.rs b/selectors/parser.rs index 01dcfdd99..d88d6f38a 100644 --- a/selectors/parser.rs +++ b/selectors/parser.rs @@ -1302,7 +1302,7 @@ impl<Impl: SelectorImpl> ToCss for AttrSelectorWithOptionalNamespace<Impl> { ParsedCaseSensitivity::CaseSensitive | ...
1
1
1
f24be50136b3e1f118ff155aa7946922bf7f875a
Emilio Cobos Álvarez
2018-12-13T02:17:53
Bug 1512026 - Handle nested slots correctly in slotted matching and invalidation. r=heycam The patch and test should be pretty much self-descriptive. Differential Revision: https://phabricator.services.mozilla.com/D14063
diff --git a/selectors/matching.rs b/selectors/matching.rs index d8d083d7b..8a9a2790f 100644 --- a/selectors/matching.rs +++ b/selectors/matching.rs @@ -410,6 +410,7 @@ fn next_element_for_combinator<E>( element: &E, combinator: Combinator, selector: &SelectorIter<E::Impl>, + context: &MatchingContext...
3
45
17
86c3d7cebe54715740ac1620984b06a167708df6
Boris Zbarsky
2018-12-10T22:24:49
Bug 1512386. Add support for 's' flag on attribute selectors. r=emilio We could keep using ParsedCaseSensitivity::CaseSensitive as a temporary stand-in for "case-sensitive or maybe not depending on what HTML says" until we check the attribute list, but it seems better to make that explicit. Differential Revision: h...
diff --git a/selectors/attr.rs b/selectors/attr.rs index 38612f57b..35e678946 100644 --- a/selectors/attr.rs +++ b/selectors/attr.rs @@ -134,8 +134,13 @@ pub static SELECTOR_WHITESPACE: &'static [char] = &[' ', '\t', '\n', '\r', '\x0C #[derive(Clone, Copy, Debug, Eq, PartialEq)] pub enum ParsedCaseSensitivity { - ...
2
73
25
20dbedc9514092d14ca353737896f9f334aa610a
Emilio Cobos Álvarez
2018-12-11T00:11:18
Bug 1513058 - Deduplicate a bit the malloc_size_of code for hashmaps / hashsets. r=heycam This allows to experiment with other hash maps easily rather than depending on what hashglobe::fake::HashMap dereferences to. In particular I wrote it while trying to get a build working with hashbrown. Differential Revision: h...
diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs index 778082b5f..ddd7b5f2d 100644 --- a/malloc_size_of/lib.rs +++ b/malloc_size_of/lib.rs @@ -436,126 +436,89 @@ where } } -impl<T, S> MallocShallowSizeOf for std::collections::HashSet<T, S> -where - T: Eq + Hash, - S: BuildHasher, -{ - fn shal...
1
71
164
488697e60b0e1e1f45bfdc268c549d88419c5370
Bastien Orivel
2018-11-30T11:28:20
Bug 1511811 - Update syn and related dependencies. r=emilio
diff --git a/malloc_size_of_derive/Cargo.toml b/malloc_size_of_derive/Cargo.toml index 02bd4c3fc..4cfc2ee12 100644 --- a/malloc_size_of_derive/Cargo.toml +++ b/malloc_size_of_derive/Cargo.toml @@ -10,6 +10,6 @@ path = "lib.rs" proc-macro = true [dependencies] -quote = "0.5.1" -syn = { version = "0.13.1", features =...
13
66
55
2ade34a6a3fd85120223a3cfa566c12af7ca2f99
Olli Pettay
2018-12-06T13:58:40
Bug 1512256 - Move FragmentOrElement::mAttrs to Element, r=ehsan
diff --git a/style/gecko/wrapper.rs b/style/gecko/wrapper.rs index 9373f0bb2..ca991b412 100644 --- a/style/gecko/wrapper.rs +++ b/style/gecko/wrapper.rs @@ -581,7 +581,7 @@ impl<'le> GeckoElement<'le> { #[inline(always)] fn attrs(&self) -> &[structs::AttrArray_InternalAttr] { unsafe { - le...
1
1
1
707c61b1f418c4259b55a8f29912e7e6012cd776
Emilio Cobos Álvarez
2018-12-03T13:08:34
Bug 1511811 - Minor build fixup after the Servo crossbeam_channel update.
diff --git a/style/animation.rs b/style/animation.rs index c10663e99..6fac559a7 100644 --- a/style/animation.rs +++ b/style/animation.rs @@ -25,6 +25,7 @@ use crate::values::computed::TimingFunction; use crate::values::generics::box_::AnimationIterationCount; use crate::values::generics::easing::{StepPosition, Timing...
1
1
0
2d5c34ec89830fb9a4f6984fee243b0f22609f9c
Bastien Orivel
2018-11-07T18:48:07
Bug 1511811 - Update crossbeam-channel to 0.3. Cherry-picks https://github.com/servo/servo/pull/22142
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index f62afc21e..22840c89d 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -10,13 +10,13 @@ path = "lib.rs" [features] servo = [ + "crossbeam-channel", "hyper", "hyper_serde", "keyboard-types", "mozjs...
6
12
13
29770d6032c0cb5ecf69a6608b7c96dfbe99150c
Emilio Cobos Álvarez
2018-12-02T18:56:33
Bug 1511811 - Update Servo's version of encoding_rs.
diff --git a/style/Cargo.toml b/style/Cargo.toml index 074171615..b90992479 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -33,7 +33,7 @@ byteorder = "1.0" cfg-if = "0.1.0" cssparser = "0.25" new_debug_unreachable = "1.0" -encoding_rs = {version = "0.7", optional = true} +encoding_rs = {version = "0.8", opt...
1
1
1
8d51c181e68b81ac2633de815511309585d5cbf5
Paul Rouget
2018-11-19T08:11:54
Bug 1511811 - Update mozjs and enable 'init_once' feature for Android. Cherry-picks https://github.com/servo/servo/pull/22200
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 4ca42aa74..f62afc21e 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -32,7 +32,6 @@ hashglobe = { path = "../hashglobe" } hyper = { version = "0.12", optional = true } hyper_serde = { version = "0.9", optional = true } ...
1
6
1
54034d8620b2832634b00f04c349d067252cea2e
Emilio Cobos Álvarez
2018-12-02T15:13:05
Bug 1511811 - Make page-break-* Gecko-only. Servo doesn't support it.
diff --git a/style/properties/shorthands/box.mako.rs b/style/properties/shorthands/box.mako.rs index f424ddb37..02763207c 100644 --- a/style/properties/shorthands/box.mako.rs +++ b/style/properties/shorthands/box.mako.rs @@ -450,6 +450,7 @@ macro_rules! try_parse_one { <%helpers:shorthand name="page-break-befor...
1
2
0
87c01680a5d6ee4c14376ff5b3741be6f81da0af
Emilio Cobos Álvarez
2018-12-02T20:10:51
Bug 1511811 - Go back to bindgen 0.43 since I can't manage to make the tup build succeed.
diff --git a/style/Cargo.toml b/style/Cargo.toml index b3af242bf..146cc27a3 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -78,7 +78,7 @@ void = "1.0.2" [build-dependencies] lazy_static = "1" log = "0.4" -bindgen = { version = "0.44", optional = true, default-features = false } +bindgen = { version = "0.43"...
1
1
1
7152fc30b043fac0324f4f3a219cd449d90d74b0
Emilio Cobos Álvarez
2018-12-02T19:05:00
Bug 1511811 - Fix formatting of inverse transform matrix to appease tidy.
diff --git a/style/values/computed/transform.rs b/style/values/computed/transform.rs index e1d391462..e34931315 100644 --- a/style/values/computed/transform.rs +++ b/style/values/computed/transform.rs @@ -137,69 +137,69 @@ impl Matrix3D { det = 1.0 / det; let x = Matrix3D { m11: det * - ...
1
48
48
e8dbe07bdf1f85ce64e786452716c48135b95610
Bastien Orivel
2018-11-07T18:48:07
Bug 1511811 - Update crossbeam-channel to 0.3. Cherry-picks https://github.com/servo/servo/pull/22142
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index f62afc21e..22840c89d 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -10,13 +10,13 @@ path = "lib.rs" [features] servo = [ + "crossbeam-channel", "hyper", "hyper_serde", "keyboard-types", "mozjs...
6
12
13
fbaf3648ff1b96e98d7281090e813cf304340cfd
Emilio Cobos Álvarez
2018-12-02T18:56:33
Bug 1511811 - Update Servo's version of encoding_rs.
diff --git a/style/Cargo.toml b/style/Cargo.toml index 4b3c6f980..c5dd4a8ed 100644 --- a/style/Cargo.toml +++ b/style/Cargo.toml @@ -33,7 +33,7 @@ byteorder = "1.0" cfg-if = "0.1.0" cssparser = "0.25" new_debug_unreachable = "1.0" -encoding_rs = {version = "0.7", optional = true} +encoding_rs = {version = "0.8", opt...
1
1
1
0c4debdb20b7f93bee2687315d6a232405d0b948
Bastien Orivel
2018-11-30T11:28:20
Bug 1511811 - Update syn and related dependencies. r=emilio
diff --git a/malloc_size_of_derive/Cargo.toml b/malloc_size_of_derive/Cargo.toml index 02bd4c3fc..4cfc2ee12 100644 --- a/malloc_size_of_derive/Cargo.toml +++ b/malloc_size_of_derive/Cargo.toml @@ -10,6 +10,6 @@ path = "lib.rs" proc-macro = true [dependencies] -quote = "0.5.1" -syn = { version = "0.13.1", features =...
14
67
56
15b848a6a74c95bb8eb3461fcb9678d0a621a628
Emilio Cobos Álvarez
2018-11-30T05:16:52
Bug 1509717 - Move BorderStyle to border.rs. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D12858
diff --git a/style/values/specified/border.rs b/style/values/specified/border.rs index c64e5c999..04942856c 100644 --- a/style/values/specified/border.rs +++ b/style/values/specified/border.rs @@ -19,6 +19,47 @@ use cssparser::Parser; use std::fmt::{self, Write}; use style_traits::{CssWriter, ParseError, ToCss}; +/...
2
42
41
8ff82daf6feb74fd5591de30378be763856a5e2a
Emilio Cobos Álvarez
2018-11-30T05:35:47
Bug 775618 - Implement page-break-{before,after} as legacy shorthands for {before,after}. r=heycam This is all the style-system work needed for this. This implements the concept of legacy shorthands, teaches tests to understand it, and adds a few more tests for these properties in particular. The WPT even caught a f...
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index ff852bf2a..0f982515a 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -438,22 +438,22 @@ ${helpers.single_keyword( )} ${helpers.predefined_type( - "page-break-afte...
3
98
5
816ff2fdafa3d69e333df5efaadb2ad029af493c
Emilio Cobos Álvarez
2019-01-11T00:07:22
Bug 1518954 - Three-value position syntax uses calc() as its computed value representation. r=heycam This restores the previous behavior of using calc(). Note that background-position / object-position, which test this, weren't hitting the assertion because they use another codepath. I didn't add more extensive test...
diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs index 89cce99be..345e199a9 100644 --- a/style/gecko/conversions.rs +++ b/style/gecko/conversions.rs @@ -22,8 +22,8 @@ use crate::values::computed::transform::Matrix3D; use crate::values::computed::url::ComputedImageUrl; use crate::values::computed::...
2
8
2
c2fcb173e97d4df63f7be02254fda54ba3bcaf60
Emilio Cobos Álvarez
2018-11-20T04:39:36
Bug 775618 - Introduce the concept of legacy shorthands. r=heycam We need this because there's a weird mapping between these properties' values ('always' maps to 'page'). See https://drafts.csswg.org/css-cascade-4/#legacy-shorthand. Differential Revision: https://phabricator.services.mozilla.com/D12213
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index f2adcd319..00564c2e7 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -917,6 +917,10 @@ impl PropertyDeclarationBlock { } already_serialized...
2
24
9
7aa504ade5922cc28a454b2c09e1628bdaf95c42
Emilio Cobos Álvarez
2018-11-20T05:07:52
Bug 775618 - Introduce break-inside, and alias page-break-inside to it. r=heycam This property has no weird value mapping, so we can just do this. Differential Revision: https://phabricator.services.mozilla.com/D12212
diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs index f83b7928d..ff852bf2a 100644 --- a/style/properties/longhands/box.mako.rs +++ b/style/properties/longhands/box.mako.rs @@ -458,13 +458,13 @@ ${helpers.predefined_type( )} ${helpers.predefined_type( - "page-break-ins...
1
3
3
6f60866824e1966e53021769fae3562debf4bd1a
Shubham Kumaram
2018-11-30T05:08:46
Bug 1509664 - Change Text Rendering constants to enum classes in nsStyleConsts.h. r=heycam Differential Revision: https://phabricator.services.mozilla.com/D12839
diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs index e8c5629c3..24797de3d 100644 --- a/style/properties/longhands/inherited_text.mako.rs +++ b/style/properties/longhands/inherited_text.mako.rs @@ -337,6 +337,7 @@ ${helpers.single_keyword( ${helpers.si...
1
1
0
a863970d0ad1f9ae8284e65650b88c29f74074b1
Emilio Cobos Álvarez
2018-11-29T10:16:38
Bug 1510862 - Prevent exponential blowup of custom properties. r=jwatt Put a hard cap on the value length instead of counting substitutions, because it works best, see the comment. Differential Revision: https://phabricator.services.mozilla.com/D13352
diff --git a/style/custom_properties.rs b/style/custom_properties.rs index c9d4ab0b7..87c791993 100644 --- a/style/custom_properties.rs +++ b/style/custom_properties.rs @@ -283,18 +283,32 @@ impl VariableValue { } } - fn push( + fn push<'i>( &mut self, + input: &Parser<'i, '_>, ...
1
44
16
6f89223937cf8288b6bc2b691c0fc138dbfd978a
Dorel Luca
2018-11-29T10:35:42
Backed out changeset 3e5ea9da2cbb (bug 1510862) for Linting failure. CLOSED TREE
diff --git a/style/custom_properties.rs b/style/custom_properties.rs index 87c791993..c9d4ab0b7 100644 --- a/style/custom_properties.rs +++ b/style/custom_properties.rs @@ -283,32 +283,18 @@ impl VariableValue { } } - fn push<'i>( + fn push( &mut self, - input: &Parser<'i, '_>, ...
1
16
44
ed14466fa5e60ae6c97a74f25165c7dabd47db2b
Hiroyuki Ikezoe
2018-11-28T00:58:46
Bug 1504065 - Run background-color animations on the compositor. r=birtles Changes for nsIDOMWindowUtils.getOMTAValue is in the next commit with come test cases. Differential Revision: https://phabricator.services.mozilla.com/D13001
diff --git a/style/properties/longhands/background.mako.rs b/style/properties/longhands/background.mako.rs index 65df61a2e..3cba4cc9a 100644 --- a/style/properties/longhands/background.mako.rs +++ b/style/properties/longhands/background.mako.rs @@ -15,7 +15,8 @@ ${helpers.predefined_type( animation_value_type="Ani...
1
2
1
d69039faa033632465d7874644d568233a77a6ed
Andreea Pavel
2018-11-27T13:33:29
Backed out 2 changesets (bug 1504065) for failing Win reftest at child-in-animating-element-display-none.html on a CLOSED TREE Backed out changeset 129188370231 (bug 1504065) Backed out changeset 359e81b35cfb (bug 1504065)
diff --git a/style/properties/longhands/background.mako.rs b/style/properties/longhands/background.mako.rs index 3cba4cc9a..65df61a2e 100644 --- a/style/properties/longhands/background.mako.rs +++ b/style/properties/longhands/background.mako.rs @@ -15,8 +15,7 @@ ${helpers.predefined_type( animation_value_type="Ani...
1
1
2
8a969d180570bc04d8dd8c5ba37197189dc166a5
Emilio Cobos Álvarez
2018-11-26T18:56:14
Bug 1509945 - Remove the display: -moz-box overrides display: -webkit-box hack. r=dholbert display: -moz-box is no longer exposed to content so this is not necessary. See bug 1407701 for context. Differential Revision: https://phabricator.services.mozilla.com/D12961
diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs index dfe619fc7..f2adcd319 100644 --- a/style/properties/declaration_block.rs +++ b/style/properties/declaration_block.rs @@ -462,22 +462,6 @@ impl PropertyDeclarationBlock { return false; } ...
2
0
40
9a1174d5183c7cfc26cf8538e8670b03b036b005
Emilio Cobos Álvarez
2018-11-26T09:21:37
Bug 1506547 - Align user-select behavior more with other UAs. r=mats There's a few subtle behavior changes here, which I'll try to break down in the commit message. The biggest one is the EditableDescendantCount stuff going away. This was added in bug 1181130, to prevent clicking on the non-editable div from selectin...
diff --git a/style/properties/longhands/ui.mako.rs b/style/properties/longhands/ui.mako.rs index c077d4d8b..b73792104 100644 --- a/style/properties/longhands/ui.mako.rs +++ b/style/properties/longhands/ui.mako.rs @@ -39,6 +39,7 @@ ${helpers.predefined_type( gecko_ffi_name="mUserSelect", alias="-webkit-user-se...
2
2
15
22d4963b1f55e6f0163a2a222d176afc29f1af01
Brindusan Cristian
2018-11-26T01:03:14
Backed out changeset 1575904619b5 (bug 1506547) for mochitest failures on test_reftests_with_caret.html.
diff --git a/style/properties/longhands/ui.mako.rs b/style/properties/longhands/ui.mako.rs index b73792104..c077d4d8b 100644 --- a/style/properties/longhands/ui.mako.rs +++ b/style/properties/longhands/ui.mako.rs @@ -39,7 +39,6 @@ ${helpers.predefined_type( gecko_ffi_name="mUserSelect", alias="-webkit-user-se...
2
15
2
f397d694499aaf6a707386918e27b55cabf37978
Hiroyuki Ikezoe
2018-11-22T04:03:06
Bug 1506988 - Set the important rule change flag when a newly important rule is inserted. r=birtles Without this change an assertion checking IsInStyleRefresh() in EffectCompositor::PostRestyleForAnimation will be hit when we call FindAnimationsForCompositor from RestyleManager::DoProcessPendingRestyles that will be i...
diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs index 506cb346a..5855e4dd8 100644 --- a/style/rule_tree/mod.rs +++ b/style/rule_tree/mod.rs @@ -453,6 +453,7 @@ impl RuleTree { StyleSource::from_declarations(pdb.clone_arc()), level, ); +...
1
1
0
91bf8e207b86f3fb241af852af91c04a934aae13
Mats Palmgren
2018-11-21T21:05:20
Bug 1507905 - Add -webkit-appearance:textarea and make that the default for <textarea> for compatibility with other UAs. r=jwatt
diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs index 5229f839e..8010b3d66 100644 --- a/style/values/specified/box.rs +++ b/style/values/specified/box.rs @@ -1155,10 +1155,11 @@ pub enum Appearance { TabScrollArrowBack, #[parse(condition = "in_ua_or_chrome_sheet")] TabScrollArr...
1
4
3
50773c863a8fc037773bc56fc681954a8dd27de5
Emilio Cobos Álvarez
2018-11-17T08:57:43
Bug 1508026 - Cherry-pick some changes to malloc_size_of's Cargo.toml.
diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml index 252185fd0..4ca42aa74 100644 --- a/malloc_size_of/Cargo.toml +++ b/malloc_size_of/Cargo.toml @@ -31,8 +31,8 @@ euclid = "0.19" hashglobe = { path = "../hashglobe" } hyper = { version = "0.12", optional = true } hyper_serde = { version = "0.9", o...
1
2
2
52fd1527744346984b8067cedf989ad4ec668d78
CYBAI
2018-11-11T06:26:06
Bug 1508026 - Fix wrong spec link. r=emilio This cherry-picks servo/servo#22172.
diff --git a/style/values/specified/align.rs b/style/values/specified/align.rs index 8ab097c45..ddec5d546 100644 --- a/style/values/specified/align.rs +++ b/style/values/specified/align.rs @@ -287,7 +287,7 @@ impl From<AlignContent> for u16 { /// Value for the `justify-content` property. /// -/// <https://drafts.cs...
1
2
2
28c6f12e5690f1a3d0256977ba4b9f0450f47ff7
Emilio Cobos Álvarez
2018-11-17T08:48:01
Bug 1508026 - Fix formatting.
diff --git a/style/custom_properties.rs b/style/custom_properties.rs index c1d337ac2..c9d4ab0b7 100644 --- a/style/custom_properties.rs +++ b/style/custom_properties.rs @@ -335,7 +335,8 @@ impl VariableValue { let (first_token_type, css, last_token_type) = parse_self_contained_declaration_value(in...
7
34
20
ea21abfa276c2b709b653342e9b10fa8c39f3fd0
Boris Chiou
2018-11-16T19:06:16
Bug 1464791 - Add comments for the calculation of Procedure::Add on Scale and transform list. r=birtles Add more comments to let people know the intention of the special case. Differential Revision: https://phabricator.services.mozilla.com/D12070
diff --git a/style/values/animated/transform.rs b/style/values/animated/transform.rs index a8823d87c..89faff71e 100644 --- a/style/values/animated/transform.rs +++ b/style/values/animated/transform.rs @@ -851,6 +851,10 @@ impl Animate for ComputedTransform { fn animate(&self, other: &Self, procedure: Procedure) ->...
1
9
4
5faf149d42b47db0618d74c4ab99f63b4f433be9
Boris Chiou
2018-11-16T19:29:28
Bug 1424134 - Part 4: Expand the mako code of Matrix3D and move them into transform.rs. r=emilio Although the methods of Matrix3D in animated_properties.mako.rs could be simplified by mako, it's a little bit hard to read because they are far from the usage and definition. Therefore, we move them to the definition of c...
diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs index e6828197b..a21944325 100644 --- a/style/properties/helpers/animated_properties.mako.rs +++ b/style/properties/helpers/animated_properties.mako.rs @@ -23,14 +23,11 @@ use std::ptr; use std::mem...
3
265
225
1d41811b402ddf1a46bb88fdf4502ece499b5911
Boris Chiou
2018-11-16T18:58:41
Bug 1424134 - Part 3: Implement ComputeSquaredDistance for individual transforms. r=birtles We manually implement ComputeSquaredDistance for Translate, Rotate, and Scale because we have to handle mismatch cases, and actually we don't need to implement it for specified types. Depends on D11934 Differential Revision: ...
diff --git a/style/values/animated/transform.rs b/style/values/animated/transform.rs index 7d0c0e94f..7cd2b32e6 100644 --- a/style/values/animated/transform.rs +++ b/style/values/animated/transform.rs @@ -1309,19 +1309,8 @@ impl ComputeSquaredDistance for ComputedTransformOperation { &TransformOperatio...
2
70
17