commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
f64f4da889582fa4d8faecce0539bcd078cceb47 | Boris Chiou | 2018-11-16T18:58:37 | Bug 1424134 - Part 1: Factor the mako code out from transform functions. r=emilio
I'm trying to put all the mako code together, so we could move transform
code into a different file.
Differential Revision: https://phabricator.services.mozilla.com/D11933 | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 4efab0bc6..9ef1fcbaa 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1444,7 +1444,7 @@ impl From<MatrixDecompose... | 1 | 96 | 57 |
e6b28723342dc1b970ab4091f7c0b20ec3bd5243 | Alex Gaynor | 2018-11-15T16:42:54 | Bug 1507498 - fixed an unused import warning; r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D12028 | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index 1871d60a0..cde467b83 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -5,7 +5,6 @@
//! Gecko-specific bits for selector-parsing.
use crate::element_state::{DocumentState, ElementState};
-use crate::... | 1 | 0 | 1 |
a78b4ac5a0fce6632622ef897a51f4b154803227 | Emilio Cobos Álvarez | 2018-11-15T08:25:13 | Bug 1507305 - Add a mechanism to serialize shorthands for getComputedStyle(). r=heycam
This implements the mechanism reusing the animation machinery for now, so it
asserts in a few cases that this wouldn't handle correctly.
For shorthands that have colors and other bits we'd need a more sophisticated
mechanism with a... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index a6d736fb4..dfe619fc7 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -309,7 +309,9 @@ impl PropertyDeclarationBlock {
.find(|(declaration, _)| declaration.id() ... | 2 | 10 | 1 |
57c04acf4e853236f86df65792367b98dda327cb | Emilio Cobos Álvarez | 2018-11-15T08:22:31 | Bug 1507311 - Make the serialization of the mask shorthand more compact. r=heycam
This helps to preserve the old longhand form when possible (mask used to be a
longhand), which will be relevant when we serialize this for the computed
value.
Differential Revision: https://phabricator.services.mozilla.com/D11943 | diff --git a/style/properties/shorthands/svg.mako.rs b/style/properties/shorthands/svg.mako.rs
index e814a0404..b5888948c 100644
--- a/style/properties/shorthands/svg.mako.rs
+++ b/style/properties/shorthands/svg.mako.rs
@@ -148,21 +148,32 @@
% endfor
image.to_css(dest)?;
- ... | 1 | 27 | 14 |
901d86406a4f22421de00c914016eb75bcce9898 | Emilio Cobos Álvarez | 2018-11-15T03:23:39 | Bug 1507309 - Simplify background-repeat. r=heycam
This way we always serialize in the shortest form, and take less space.
This is useful because when serializing uncomputed values we'd like to compare
to the initial value to avoid serializing parts of a shorthand, but with the
existing implementation we would genera... | diff --git a/style/values/computed/background.rs b/style/values/computed/background.rs
index fd1348a9e..e3fbd17b2 100644
--- a/style/values/computed/background.rs
+++ b/style/values/computed/background.rs
@@ -5,12 +5,9 @@
//! Computed types for CSS values related to backgrounds.
use crate::values::computed::length:... | 2 | 46 | 100 |
455f7edcbdd361141ca10399bf628eeaf0862c77 | Timothy Guan-tin Chien | 2018-11-15T06:52:01 | Bug 1503019 - Part II, Remove dom.webcomponents.customelements.enabled pref r=smaug
This patch removes the following functions:
* nsContentUtils::IsCustomElementsEnabled()
* CustomElementRegistry::IsCustomElementEnabled(JSContext* aCx, JSObject* aObject)
* CustomElementRegistry::IsCustomElementEnabled(nsIDocument* aD... | diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs
index f7d8be418..cf21cbf89 100644
--- a/style/gecko/non_ts_pseudo_class_list.rs
+++ b/style/gecko/non_ts_pseudo_class_list.rs
@@ -37,7 +37,7 @@ macro_rules! apply_non_ts_list {
("visited", Visited, visited, I... | 2 | 1 | 4 |
b7d18613fd578613bb6e213c042759714d342e7b | Timothy Guan-tin Chien | 2018-11-15T06:51:07 | Bug 1503019 - Part I, Remove dom.webcomponents.shadowdom.enabled r=smaug
This patch removes the dom.webcomponents.shadowdom.enabled pref and all its
references, including the following functions:
* nsContentUtils::IsShadowDOMEnabled()
* nsIDocument::IsShadowDOMEnabled()
* nsDocument::IsShadowDOMEnabled(JSContext* aCx... | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index b8fd780b7..039c069d2 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -347,10 +347,7 @@ impl<'a, 'i> ::selectors::Parser<'i> for SelectorParser<'a> {
#[inline]
fn parse_slotted(&self) -> boo... | 1 | 1 | 4 |
c85da48d78929a28405a041cc104a43f3552b7c9 | Andreea Pavel | 2018-11-14T23:52:30 | Backed out 2 changesets (bug 1503019) for failing crashtests at dom/base/crashtests/1505811.html on a CLOSED TREE
Backed out changeset 06b12fd41ff1 (bug 1503019)
Backed out changeset 7b845eac9dd7 (bug 1503019) | diff --git a/style/gecko/non_ts_pseudo_class_list.rs b/style/gecko/non_ts_pseudo_class_list.rs
index cf21cbf89..f7d8be418 100644
--- a/style/gecko/non_ts_pseudo_class_list.rs
+++ b/style/gecko/non_ts_pseudo_class_list.rs
@@ -37,7 +37,7 @@ macro_rules! apply_non_ts_list {
("visited", Visited, visited, I... | 2 | 8 | 2 |
007026bf5b21b7844c7ddaf8acce19bee444b035 | Cameron McCormack | 2018-11-14T21:33:01 | Bug 1507050 - Store MediaFeatureDescription references as an index into the MEDIA_FEATURES array r=emilio
The current use of a static reference is incompatible with sharing style sheet data
across processes.
Differential Revision: https://phabricator.services.mozilla.com/D11845 | diff --git a/style/media_queries/media_feature_expression.rs b/style/media_queries/media_feature_expression.rs
index b6bfc0317..122b7ca05 100644
--- a/style/media_queries/media_feature_expression.rs
+++ b/style/media_queries/media_feature_expression.rs
@@ -10,8 +10,12 @@ use super::media_feature::{KeywordDiscriminant, ... | 1 | 26 | 19 |
ed2528a210596437a4effe8d34adc47dee50badc | Emilio Cobos Álvarez | 2018-11-14T11:15:38 | No bug - Remove outdated comment.
DONTBUILD, comment only. | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index b8e38da37..6a207d0a9 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -943,9 +943,6 @@ pub enum Resize {
/// The value for the `appearance` property.
///
/// https://developer.mozilla.org/en-US/docs/Web/... | 1 | 0 | 3 |
087522dbd6cc539948971e246c8e614811b70368 | Cameron McCormack | 2018-11-13T12:51:05 | Bug 1506760 - Store variable references with a boxed slice rather than a PrecomputedHashSet r=emilio
Once we've parsed the variable references, there is no need to keep an entire HashSet
object around, as all we do is iterate over the values.
Differential Revision: https://phabricator.services.mozilla.com/D11735 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 31c3dc207..c1d337ac2 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -109,7 +109,7 @@ pub struct VariableValue {
references_environment: bool,
/// Custom property names in var() functions.
- references:... | 1 | 8 | 3 |
cb56ecd1d4684ea93c29b16c476ecd3fbd954e7f | Boris Chiou | 2018-11-13T18:37:14 | Bug 1504327 - Support keywords [x|y|z] on rotate. r=emilio
Update the parser and the serialization to support the keywords, [x|y|z].
Differential Revision: https://phabricator.services.mozilla.com/D11531 | diff --git a/style/values/computed/mod.rs b/style/values/computed/mod.rs
index b8484a291..75c95e1a9 100644
--- a/style/values/computed/mod.rs
+++ b/style/values/computed/mod.rs
@@ -8,6 +8,7 @@ use super::animated::ToAnimatedValue;
use super::generics::grid::GridTemplateComponent as GenericGridTemplateComponent;
use s... | 4 | 85 | 8 |
ed27310fcd35a797af62f4d124fcbe148135a501 | Boris Chiou | 2018-11-12T19:21:32 | Bug 1505200 - Part 3: Parse any order of number and angle for Rotate. r=emilio
Rotate accepts rotate axis and angle in any order
(i.e. <number>{3} <angle> or <angle> <number>{3}), so we rewrite the
parser.
Depends on D11401
Differential Revision: https://phabricator.services.mozilla.com/D11417 | diff --git a/style/values/specified/transform.rs b/style/values/specified/transform.rs
index c1ffe202a..38ac07edf 100644
--- a/style/values/specified/transform.rs
+++ b/style/values/specified/transform.rs
@@ -357,17 +357,28 @@ impl Parse for Rotate {
return Ok(generic::Rotate::None);
}
- ... | 1 | 21 | 10 |
237f03d4d0f84f8fd23502d9337ffd9aa6f44d1e | Boris Chiou | 2018-11-12T23:17:19 | Bug 1505200 - Part 1: Rewrite the interpolation of Rotate to return correct type. r=birtles
The original implementation always returns Rotate::Rotate3D, but it is
not correct, so we have to rewrite it:
1. If both from value and to value are none, we don't have to convert it
into identity value, so just return None.... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 5ff4a10c3..4efab0bc6 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2108,7 +2108,7 @@ impl ComputedRotate {
... | 1 | 50 | 33 |
f53bba431573d41546cf3b75b68a3d75af54a655 | Emilio Cobos Álvarez | 2018-11-11T17:16:00 | Bug 1492958 - Allow user-select: -moz-text on user-agent stylesheets only. r=mats
It's only used in contenteditable.css, and same usage in comm-central. That
sheet is loaded as a ua sheet so let's restrict it to that. No relevant
external usage either. This value was introduced in bug 1181130.
Differential Revision: ... | diff --git a/style/properties/longhands/ui.mako.rs b/style/properties/longhands/ui.mako.rs
index b73792104..c077d4d8b 100644
--- a/style/properties/longhands/ui.mako.rs
+++ b/style/properties/longhands/ui.mako.rs
@@ -39,7 +39,6 @@ ${helpers.predefined_type(
gecko_ffi_name="mUserSelect",
alias="-webkit-user-se... | 2 | 11 | 1 |
a6794bd9bca13680c5bbde3288d346e2744e3351 | Emilio Cobos Álvarez | 2018-11-11T17:05:49 | Bug 1492958 - Remove user-select: -moz-all. r=mats
It's an attempt of an alias to `all`, except it doesn't get handled in all
places.
Seems unused both in comm-central and mozilla-central, and all external usage I
could find is followed by -webkit-user-select: all.
Differential Revision: https://phabricator.services... | diff --git a/style/values/specified/ui.rs b/style/values/specified/ui.rs
index 37dd4ebc9..6dbf910a6 100644
--- a/style/values/specified/ui.rs
+++ b/style/values/specified/ui.rs
@@ -163,11 +163,8 @@ pub enum UserSelect {
Text,
#[parse(aliases = "-moz-none")]
None,
- All,
/// Force selection of all... | 1 | 1 | 4 |
55c2a5088aec8835b9d6534e1e6cb74c804e846d | Emilio Cobos Álvarez | 2018-11-11T17:00:49 | Bug 1492958 - Remove unimplemented values of the user-select property. r=mats
Can't believe we literally had no code to handle them.
Differential Revision: https://phabricator.services.mozilla.com/D11581 | diff --git a/style/values/specified/ui.rs b/style/values/specified/ui.rs
index f11aae73b..37dd4ebc9 100644
--- a/style/values/specified/ui.rs
+++ b/style/values/specified/ui.rs
@@ -163,11 +163,7 @@ pub enum UserSelect {
Text,
#[parse(aliases = "-moz-none")]
None,
- Element,
- Elements,
All,
- ... | 1 | 0 | 4 |
b62e820835f68439c147a9fe60dd2163c558180a | Emilio Cobos Álvarez | 2018-11-12T10:19:24 | No bug - Remove outdated comment. | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index a5761d3f9..b8e38da37 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -52,9 +52,6 @@ fn moz_box_display_values_enabled(context: &ParserContext) -> bool {
/// If you change it, make sure to take a look at t... | 1 | 0 | 3 |
ed0dc3f638fbd1f081ce277e28726ed91482c8aa | Emilio Cobos Álvarez | 2018-11-12T09:21:17 | Bug 1473184: Remove serialize_basicshape_position. r=xidorn
Per https://github.com/w3c/csswg-drafts/issues/2274. There's a whole lot of new failures, but those need to be updated along with the spec changes in that issue.
We did resolve that position serialized the same everywhere though.
Differential Revision: http... | diff --git a/style/values/specified/basic_shape.rs b/style/values/specified/basic_shape.rs
index d394d8881..b371d709b 100644
--- a/style/values/specified/basic_shape.rs
+++ b/style/values/specified/basic_shape.rs
@@ -8,20 +8,17 @@
//! [basic-shape]: https://drafts.csswg.org/css-shapes/#typedef-basic-shape
use crate... | 1 | 3 | 82 |
eee5bd5e95d9324fd2beeaacd072ef8d9a838d6c | Emilio Cobos Álvarez | 2018-11-10T20:26:46 | Bug 1506391 - Manually extinguish multi-line use statements. | diff --git a/style/font_face.rs b/style/font_face.rs
index 8b3e3c865..c434e0957 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -14,12 +14,12 @@ use crate::shared_lock::{SharedRwLockReadGuard, ToCssWithGuard};
use crate::str::CssStringWriter;
use crate::values::computed::font::FamilyName;
use crate::valu... | 19 | 45 | 66 |
bf1040399fd20a6841d4fbeaffed858a95f0f65d | Emilio Cobos Álvarez | 2018-11-10T20:07:54 | Bug 1506391 - cargo fix on the merged changes + formatting. | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index 0b527e623..32b7db63a 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -33,9 +33,7 @@ impl ::selectors::parser::PseudoElement for PseudoElement {
fn valid_after_slotted(&self) -> bool {
matches... | 8 | 20 | 18 |
74cff7e762378af4e8cb39952f6194aaa1de55cc | Simon Sapin | 2018-11-01T12:41:10 | Bug 1506391 - Use 2018-style paths in code generated by style_derive. r=emilio | diff --git a/style_derive/animate.rs b/style_derive/animate.rs
index 0f7604015..42046f631 100644
--- a/style_derive/animate.rs
+++ b/style_derive/animate.rs
@@ -16,7 +16,7 @@ pub fn derive(mut input: DeriveInput) -> Tokens {
if !no_bound.contains(¶m.ident) {
cg::add_predicate(
... | 9 | 65 | 65 |
c15e3ea9e40e50845ecd5fb3246ecd5973d281d2 | Emilio Cobos Álvarez | 2018-11-09T13:27:10 | Bug 1392185 - Remove dynamic HTML5 atoms. r=njn,hsivonen
This is a rebase + manual refcounting on some places, + cleanup of the original
patch in the bug.
Co-authored-by: Nicholas Nethercote <nnethercote@mozilla.com>
Differential Revision: https://phabricator.services.mozilla.com/D11035 | diff --git a/style/gecko_string_cache/mod.rs b/style/gecko_string_cache/mod.rs
index aedf065aa..16b11de5d 100644
--- a/style/gecko_string_cache/mod.rs
+++ b/style/gecko_string_cache/mod.rs
@@ -14,7 +14,7 @@ use gecko_bindings::bindings::Gecko_AddRefAtom;
use gecko_bindings::bindings::Gecko_Atomize;
use gecko_bindings... | 1 | 2 | 2 |
564abce6de47def4311a5c0388c28e68c634eb5f | Mats Palmgren | 2018-11-09T03:25:56 | Bug 1501506 - Add -webkit-appearance:progress-bar and make that the default for <progress> for compatibility with other UAs. r=jwatt
Keep our old 'progressbar' as an alias for now, but unship
'progresschunk' by restricting it to UA/chrome sheets only.
Unship 'progresschunk-vertical' by removing it since it's
not used... | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index a2fad4977..737a47da2 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -1043,13 +1043,13 @@ pub enum Appearance {
/// For HTML's <input type=number>
NumberInput,
/// A horizontal progress bar.... | 1 | 3 | 3 |
a1a18929e14ef6490ca20b1f9ab14cfa37114c37 | Mats Palmgren | 2018-11-09T03:25:56 | Bug 1501483 - Add -webkit-appearance:meter and make that the default for <meter> for compatibility with other UAs. r=jwatt
Keep our old value 'meterbar' as an alias for now, but unship 'meterchunk'
by restricting it to UA/chrome sheets only. | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index 060cb093d..a2fad4977 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -1032,8 +1032,10 @@ pub enum Appearance {
#[parse(condition = "in_ua_or_chrome_sheet")]
Menuimage,
/// A horizontal meter... | 1 | 3 | 1 |
1cc6bbc7b99c6341e3667f5dfa108524b3bd06ff | Emilio Cobos Álvarez | 2018-11-08T23:07:40 | Bug 1505565 - Split up push_applicable_declarations. r=heycam
Introduce RuleCollector, which contains all the state we need during the
cascade, and allows to reuse a bit of code.
Differential Revision: https://phabricator.services.mozilla.com/D11233 | diff --git a/style/lib.rs b/style/lib.rs
index 29df16f61..45d7e2906 100644
--- a/style/lib.rs
+++ b/style/lib.rs
@@ -143,6 +143,7 @@ pub mod media_queries;
pub mod parallel;
pub mod parser;
pub mod rule_cache;
+pub mod rule_collector;
pub mod rule_tree;
pub mod scoped_tls;
pub mod selector_map;
diff --git a/style... | 3 | 426 | 293 |
7e19b73066302516a1e256691fb4ffd02cb87230 | Emilio Cobos Álvarez | 2018-11-08T22:57:18 | Bug 1505816 - Cleanup text-align. r=heycam
Use derive(FromPrimitive) instead.
Differential Revision: https://phabricator.services.mozilla.com/D11332 | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index 431e73e99..1e6eb98ae 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -137,7 +137,7 @@ ${helpers.single_keyword(
${helpers.pr... | 2 | 39 | 66 |
5dc5d26ee31e879f0f7316032724316e35fb4461 | Boris Chiou | 2018-11-08T22:41:00 | Bug 1505156 - Percentage values of translate are serialized as percent for computed values. r=emilio
Basically, we rewrite the type of generics::transform::Translate and its
ToCss to match the spec. Besides, we always serialize Translate by servo,
so we could drop a lot of duplicated code.
Differential Revision: http... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 2ab276872..85dfee741 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2102,12 +2102,12 @@ impl Matrix3D {
/// ... | 7 | 127 | 34 |
659a06c362550940d19682c826009e2def876201 | Emilio Cobos Álvarez | 2018-11-08T13:33:59 | Bug 1505213 - Allow ::slotted()::placeholder. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D11132 | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index b17a5e634..060cf77ec 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -27,12 +27,16 @@ include!(concat!(
impl ::selectors::parser::PseudoElement for PseudoElement {
type Impl = SelectorImpl;
+ //... | 1 | 9 | 5 |
3d2e8e11a7a368cf390dc2c9fcd924cacdcb3cc1 | Emilio Cobos Álvarez | 2018-11-08T00:03:45 | Bug 1505618 - Some minor follow-up formatting nits. | diff --git a/style/gecko/data.rs b/style/gecko/data.rs
index 7761d9c26..aae0104c4 100644
--- a/style/gecko/data.rs
+++ b/style/gecko/data.rs
@@ -8,10 +8,9 @@ use atomic_refcell::{AtomicRef, AtomicRefCell, AtomicRefMut};
use context::QuirksMode;
use dom::TElement;
use gecko_bindings::bindings::{self, RawServoStyleSet... | 11 | 54 | 74 |
fc7e524879541c246e320f24111e5e913539c5c6 | Emilio Cobos Álvarez | 2018-11-07T22:27:31 | Bug 1505618 - Fix code style of a recent commit. | diff --git a/style/values/generics/transform.rs b/style/values/generics/transform.rs
index cf0ac1ccd..589258e01 100644
--- a/style/values/generics/transform.rs
+++ b/style/values/generics/transform.rs
@@ -580,9 +580,9 @@ impl<Number: ToCss + PartialEq> ToCss for Scale<Number> {
where
W: fmt::Write,
{... | 1 | 4 | 4 |
920f877994659cda0bb7018b6149f3a873c50fac | Kristen Wright | 2018-11-07T19:56:17 | Bug 1460439 - Conversion from NS_STYLE_BORDER_STYLE_* macro to StyleBorderStyle::* enum class r=emilio
Converted NS_STYLE_BORDER_STYLE_* consts to enum class. Updated corresponding values to enum class. reduced BCCornerInfo struct values to fit StyleBorderStyle values inside struct. Added defaults to switches that do ... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index f0b8cef22..956e32467 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1516,7 +1516,9 @@ fn static_assert() {
<% border_style_keyword = Keyword("border-style",
- "n... | 3 | 8 | 3 |
f070cda13f6532d85deb10b6e7863f34b91dfa9c | Boris Chiou | 2018-11-06T23:44:24 | Bug 1500107 - Fix the default behavior of scale:<number>{1}. r=birtles
The current spec says: "If only the X value is given, the Y value
defaults to the same value.", so we should update the behavior.
Besides, we also update the serialization, so we serialization both
specified and computed value by servo. We enable ... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index ba1a6444d..2ab276872 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2212,7 +2212,6 @@ impl ComputedScale {
... | 4 | 65 | 23 |
21ef9b32a85c8eb150f7ba4631ec7dbaeb45408e | Emilio Cobos Álvarez | 2018-11-06T23:18:29 | Bug 1504034 - followup post-review nit. r=heycam | diff --git a/style/values/specified/list.rs b/style/values/specified/list.rs
index 80c899c86..e3a9bba21 100644
--- a/style/values/specified/list.rs
+++ b/style/values/specified/list.rs
@@ -86,8 +86,7 @@ pub struct QuotePair {
/// Specified and computed `quotes` property.
#[derive(Clone, Debug, MallocSizeOf, PartialEq... | 1 | 1 | 2 |
60fd3ada1bc033a5e4ca926af52d947751080ef0 | Cameron McCormack | 2018-11-06T23:03:24 | Bug 1504034 - Part 3: Store the Rust QuotePair slice as the computed quotes value in Gecko style structs r=emilio
Depends on D10651
Differential Revision: https://phabricator.services.mozilla.com/D10652 | diff --git a/style/gecko/arc_types.rs b/style/gecko/arc_types.rs
index 0a9bf4d5c..ad0b907e7 100644
--- a/style/gecko/arc_types.rs
+++ b/style/gecko/arc_types.rs
@@ -27,6 +27,7 @@ use gecko_bindings::structs::RawServoCssUrlData;
use gecko_bindings::structs::RawServoDeclarationBlock;
use gecko_bindings::structs::RawSer... | 5 | 26 | 33 |
e4a584b955b811fb17a4ce44f8b91a246cc0a327 | Cameron McCormack | 2018-11-06T23:03:33 | Bug 1504034 - Part 1: Make quotes property representation allocate less r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D10650 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index d51a43166..b79f08cb5 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -4187,9 +4187,9 @@ fn static_assert() {
UniqueRefPtr::from_addrefed(Gecko_NewStyleQuoteValues(other.0.len() as u32))
... | 4 | 52 | 63 |
1e71ffe557070d4e70104c9f9f517b2b9c8e1839 | Cameron McCormack | 2018-11-05T02:21:41 | Bug 1501261 - Part 2: Serialize `background-size: auto auto` as "auto" r=firefox-style-system-reviewers,emilio
With this change, all of Chrome, Edge, Firefox, and Safari serialize
background-size by omitting the second "auto" if the value is "auto
auto". Other keywords are still repeated.
Depends on D10445
Differen... | diff --git a/style/values/computed/length.rs b/style/values/computed/length.rs
index d32ddcfaf..83f46296f 100644
--- a/style/values/computed/length.rs
+++ b/style/values/computed/length.rs
@@ -11,7 +11,7 @@ use std::ops::{Add, Neg};
use style_traits::{CssWriter, ToCss};
use style_traits::values::specified::AllowedNum... | 4 | 53 | 3 |
c9cd3b2f52eb4800fdb267766901da56ba10eba3 | Ting-Yu Lin | 2018-11-05T15:27:36 | Bug 1504387 - Remove preference "layout.css.shape-outside.enabled". r=bradwerth,xidorn
shape-outside, shape-margin, shape-image-threshold have been shipped in Firefox
62. We can remove the preference.
The change in devtools/shared/css/generated/properties-db.js is generated by
"./mach devtools-css-db"
The actual sha... | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index d5e6a9b11..c06ed16a2 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -604,7 +604,6 @@ ${helpers.predefined_type(
${helpers.predefined_type(
"shape-image-threshold"... | 1 | 0 | 3 |
66600ed41944eb593e4990fbbe34b48b51bd55ea | Emilio Cobos Álvarez | 2018-11-05T11:39:54 | Bug 1504644 - Fix servo build. | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 6d7a198e0..574031453 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -25,6 +25,7 @@ use style_traits::{CssWriter, ParseError, StyleParseErrorKind, ToCss};
///
/// TODO(emilio): If this becomes a bit more complex we ... | 3 | 14 | 1 |
0fb1679291b8a9c4578cb15b4406ef2ef7c01227 | Emilio Cobos Álvarez | 2018-11-05T11:20:26 | Bug 1504644 - Fix tidy issues. | diff --git a/style/values/animated/font.rs b/style/values/animated/font.rs
index 26c88a2d3..5a85bc14b 100644
--- a/style/values/animated/font.rs
+++ b/style/values/animated/font.rs
@@ -4,11 +4,11 @@
//! Animation implementation for various font-related types.
+use super::{Animate, Procedure, ToAnimatedZero};
use ... | 4 | 4 | 6 |
7614c101d84de65c9d4c5eba533b2949fd656d85 | Emilio Cobos Álvarez | 2018-11-05T11:16:43 | Bug 1504644 - Cherry-pick servo/servo#21644. | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index ab7b50197..252185fd0 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -29,10 +29,10 @@ app_units = "0.7"
cssparser = "0.25"
euclid = "0.19"
hashglobe = { path = "../hashglobe" }
-hyper = { version = "0.10", optional = t... | 2 | 6 | 51 |
3a533aa4dc82e671c42cd1b747f1f72eeeb9878a | Emilio Cobos Álvarez | 2018-11-05T10:42:12 | Bug 1462233 - Simplify invalid custom property handling. r=xidorn
It's a bit useless to keep a set of invalid properties if we're going
to use them just to reject lookups into another key. This makes it more
consistent with the cascade / no-references code, and should not change
behavior.
Differential Revision: https... | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 344e38af8..6d7a198e0 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -230,18 +230,6 @@ where
self.index.remove(index);
self.values.remove(key)
}
-
- fn remove_set<S>(&mut self, set: &::hash::... | 1 | 12 | 61 |
2e9221b20c5df190f7fdf02af14a8b87a982d736 | Emilio Cobos Álvarez | 2018-11-05T10:39:46 | Bug 1462233 - Implement the env() function with hardcoded zeros for safe-area-inset. r=heycam,firefox-style-system-reviewers
Intent to Implement and Ship: https://groups.google.com/d/msg/mozilla.dev.platform/EVKyR1B87T0/_l-_qK8SAAAJ
Differential Revision: https://phabricator.services.mozilla.com/D9609 | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index e982925e5..ab7b50197 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -26,7 +26,7 @@ servo = [
[dependencies]
app_units = "0.7"
-cssparser = "0.24.0"
+cssparser = "0.25"
euclid = "0.19"
hashglobe = { path = "../hashg... | 10 | 346 | 136 |
b9dac167705da9fd44700c9ace805d4e84015454 | Emilio Cobos Álvarez | 2018-11-04T14:48:08 | Bug 1504536 - Simplify the SVG animation code. r=hiro,heycam
It's overly generic for no good reason.
Differential Revision: https://phabricator.services.mozilla.com/D10844 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 59beaea0a..d51a43166 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -561,17 +561,24 @@ def set_gecko_property(ffi_name, expr):
return SVGLength::ContextValue;
}
let leng... | 5 | 63 | 156 |
917f11ebab56ed3246627f0a2648be23489bb716 | Emilio Cobos Álvarez | 2018-11-04T13:56:21 | Bug 1504536 - Move animation of svg-related bits outside of animated_properties. r=hiro
Being in mako is unnecessary, and makes it harder to debug and such.
Differential Revision: https://phabricator.services.mozilla.com/D10843 | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 1936bacc3..79287e178 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -27,14 +27,12 @@ use hash::FxHashMap;
use s... | 3 | 215 | 205 |
5bfb86dac120ecdac2725da9c1c725f262026f06 | Emilio Cobos Álvarez | 2018-11-04T23:18:18 | Bug 1504536 - Move various font-related animation code to its own file. r=hiro
Similarly, the code is not trivial and doesn't really need to be in
mako.
Differential Revision: https://phabricator.services.mozilla.com/D10842 | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 85c588502..0e39495af 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -17,7 +17,6 @@ use itertools::{EitherOrBoth,... | 3 | 157 | 147 |
4e3eabae91e51c90a42bd1d09e10ae2841ba8e6f | Emilio Cobos Álvarez | 2018-11-04T23:16:07 | Bug 1504536 - Move various length animation implementations to its own file. r=hiro
It's nicer, I think.
Differential Revision: https://phabricator.services.mozilla.com/D10841 | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 0b7cc3db9..85c588502 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -31,10 +31,9 @@ use values::animated::{Anima... | 3 | 121 | 112 |
93c71d2603c25adc8803b7577e6db3898aa47c75 | Emilio Cobos Álvarez | 2018-11-04T23:12:24 | Bug 1504536 - Move the keyframes property priority stuff outside of animated_properties. r=hiro
Similarly, no need to be here.
Differential Revision: https://phabricator.services.mozilla.com/D10840 | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index cb8f2970c..0b7cc3db9 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -19,7 +19,6 @@ use properties::{CSSWideKeywo... | 2 | 64 | 64 |
5f38b3ce94243a0a7911df50c87b8c6537047d62 | Emilio Cobos Álvarez | 2018-11-04T23:10:17 | Bug 1504536 - Move shorthand IDL order stuff out of animated_properties. r=hiro
Doesn't really need to be in a mako file.
Differential Revision: https://phabricator.services.mozilla.com/D10839 | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index c8e72ca1d..cb8f2970c 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -3057,32 +3057,17 @@ pub fn compare_property... | 2 | 32 | 28 |
652dd81555ec823b80c114ecd95d2dc0eda86e97 | Emilio Cobos Álvarez | 2018-11-05T00:16:58 | Bug 1502751 - Don't keep a separate list of ignored-when-colors-disabled longhands. r=heycam
Most of the change is moving sets around to be static functions on
LonghandIdSet. I think I like that pattern, but I can also make the new set a
global static and add mako code to be `pub` or something.
Though I think the Lon... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 330ceea7f..027a3eba2 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -758,6 +758,41 @@ impl<'a> Iterator for LonghandIdSetIterator<'a> {
}
impl LonghandIdSet {
+ #[inline]
+ ... | 2 | 56 | 36 |
7e6ed26be3b3bcc780c2f0859c84fc25d93a1e14 | Emilio Cobos Álvarez | 2018-11-05T00:05:12 | Bug 1502893 - Don't match document author rules if not needed for revalidation. r=heycam,firefox-style-system-reviewers
When you're in a ShadowRoot and can share style with a sibling, the sharing code
is smart enough to skip document author rules.
But then it could get confused if you also include document rules, sin... | diff --git a/style/stylist.rs b/style/stylist.rs
index fe96fd78a..2772891a3 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -605,11 +605,11 @@ impl Stylist {
maybe = maybe || f(&*data);
});
- if maybe || !doc_author_rules_apply {
- return maybe;
+ if mayb... | 1 | 30 | 23 |
9bde117334f692f5ddad07d374e162c80a1c88fe | Emilio Cobos Álvarez | 2018-11-02T18:19:06 | Bug 1504078 - Use references in the shapes code. r=bradwerth,TYLin
It doesn't make much sense to return const UniquePtr<Foo>& for something that
can't be null, it's just confusing.
Also make more stuff actually const.
Differential Revision: https://phabricator.services.mozilla.com/D10647 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 6a2287dc0..eeb13fce7 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -718,7 +718,7 @@ pub mod basic_shape {
match other.mType {
StyleShapeSourceType::URL => unsafe {
... | 1 | 1 | 1 |
4f00bb4f1c9100f15ca4b3f07e276c5e54e546a7 | Cameron McCormack | 2018-11-01T01:37:26 | Bug 1496617 - Part 2: Fix inconsistent CRISPEDGES constant name r=emilio
Depends on D10451
Differential Revision: https://phabricator.services.mozilla.com/D10452 | diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs
index 2b49e0ca5..feee09556 100644
--- a/style/properties/longhands/inherited_box.mako.rs
+++ b/style/properties/longhands/inherited_box.mako.rs
@@ -59,8 +59,6 @@ ${helpers.single_keyword(
spec="https://... | 1 | 0 | 3 |
ecae391d400e806cbaa955505b6f94192a5d92f2 | Cameron McCormack | 2018-11-01T01:35:26 | Bug 1496617 - Part 1: Support unprefixed image-rendering:crisp-edges r=firefox-style-system-reviewers,emilio
For now, we keep supporting the prefixed version, since there are examples/instructions
on the Web that don't include an unprefixed value.
Differential Revision: https://phabricator.services.mozilla.com/D10451 | diff --git a/style/properties/longhands/inherited_box.mako.rs b/style/properties/longhands/inherited_box.mako.rs
index d810ec3d2..2b49e0ca5 100644
--- a/style/properties/longhands/inherited_box.mako.rs
+++ b/style/properties/longhands/inherited_box.mako.rs
@@ -65,9 +65,10 @@ ${helpers.single_keyword(
// And, firefox d... | 1 | 4 | 3 |
4a1a11cb5f078dd1b6e127aa3af22348da4a8585 | Cameron McCormack | 2018-10-31T10:40:56 | Bug 1497076 - Handle reversed ranges in @font-face descriptors r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D10327 | diff --git a/style/font_face.rs b/style/font_face.rs
index b78947dd4..b207b0291 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -151,10 +151,20 @@ impl_range!(FontWeightRange, AbsoluteFontWeight);
#[allow(missing_docs)]
pub struct ComputedFontWeightRange(f32, f32);
+#[inline]
+fn sort_range<T: PartialOr... | 1 | 19 | 4 |
6b000cdb467c7dfd8b947489751b3efe6c824941 | Boris Chiou | 2018-10-31T10:58:24 | Bug 1501116 - Part 8: Drop "mozilla" prefix in cbindgen_types in ServoBindings.toml. r=emilio
A minor update to drop the redundant "mozilla" namespace prefix in
`cbindgen_types` array.
Depends on D10305
Differential Revision: https://phabricator.services.mozilla.com/D10325 | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 3e4200d28..eff6d9402 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -395,8 +395,8 @@ mod bindings {
.handle_table_items("cbindgen-types", |b, item| {
let gecko = item["gecko"].as_str().unwrap();
... | 1 | 2 | 2 |
ee398d0c58c8627ae74957ff08ab50980db0820e | Boris Chiou | 2018-10-31T06:20:32 | Bug 1501116 - Part 6: Use alias for StylePathCommand. r=emilio
So we could drop transmute in svg_path related functions.
Differential Revision: https://phabricator.services.mozilla.com/D10140 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 8cfe0c981..6a2287dc0 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -701,18 +701,11 @@ pub mod basic_shape {
/// Generate a SVGPathData from StyleShapeSource if possible.
fn to_svg_path(&self) -> ... | 2 | 2 | 13 |
eab1240d33fd26d38cfd830e0ff09413d90a8c9d | Boris Chiou | 2018-10-31T06:20:07 | Bug 1501116 - Part 3: Use alias for StyleDisplay and StyleDisplayMode. r=emilio
Map these two types to their original rust type in rust-bindgen.
Differential Revision: https://phabricator.services.mozilla.com/D10141 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 9e84a7722..e6f08c60f 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -179,7 +179,7 @@ fn eval_device_orientation(device: &Device, value: Option<Orientation>) -> bool
}
/// Values for the display-mode m... | 2 | 9 | 18 |
613e4b7482bfb059a551dca4ad2f6681b88f844e | Boris Chiou | 2018-10-31T06:20:00 | Bug 1501116 - Part 2: Use alias for StyleAppearance. r=emilio
So we could avoid generating it in rust-bindgen and drop transmute.
Differential Revision: https://phabricator.services.mozilla.com/D10304 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 19d5ec8ba..471433438 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -368,34 +368,6 @@ def set_gecko_property(ffi_name, expr):
return "self.gecko.%s = %s;" % (ffi_name, expr)
%>
-<%def name="im... | 1 | 1 | 29 |
4556aca305e43247a05df120253a58c273dedb4b | Boris Chiou | 2018-10-31T06:19:52 | Bug 1501116 - Part 1: Add a special list for cbindgen types to avoid generating redundant rust types. r=emilio
We will blacklist this type and add a module raw line to map the gecko
type to its rust type (as an alias).
Differential Revision: https://phabricator.services.mozilla.com/D10303 | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index bee061fcc..3e4200d28 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -392,6 +392,12 @@ mod bindings {
.handle_str_items("whitelist-vars", |b, item| b.whitelist_var(item))
.handle_str_items("whitelist-types", |b, ite... | 1 | 6 | 0 |
1c0fcc0fc54016b8bfb866557ca68c8bb4fc7b61 | Brian Birtles | 2018-10-30T10:57:46 | Bug 1501176 - Interpolate the angle between mis-matched rotate() functions when the angle of one is zero; r=hiro | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index b079f30b1..c8e72ca1d 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -2351,10 +2351,21 @@ impl Animate for Comput... | 1 | 13 | 2 |
101c8b4b6a20cd63156c5d668db2e848c8e2779e | Emilio Cobos Álvarez | 2018-10-29T22:34:12 | Bug 1502617 - Support ::before / ::after on ::slotted pseudos. r=heycam
See https://github.com/w3c/csswg-drafts/issues/3150 for the issue that would
expand this to all pseudos.
Differential Revision: https://phabricator.services.mozilla.com/D9994 | diff --git a/selectors/parser.rs b/selectors/parser.rs
index fc4b26bb3..3e82a49b3 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -36,6 +36,11 @@ pub trait PseudoElement: Sized + ToCss {
) -> bool {
false
}
+
+ /// Whether this pseudo-element is valid after a ::slotted(..) pseudo.
+ ... | 2 | 111 | 57 |
07977e3de7a1b5a17f0c1429b6a6862c6a456921 | Sean Voisen | 2018-10-29T10:38:50 | Bug 1430969: Ignore border-image-source when overriding document colors r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D10017 | diff --git a/style/properties/longhands/border.mako.rs b/style/properties/longhands/border.mako.rs
index f4b9187b8..2f455a171 100644
--- a/style/properties/longhands/border.mako.rs
+++ b/style/properties/longhands/border.mako.rs
@@ -112,6 +112,7 @@ ${helpers.predefined_type(
animation_value_type="discrete",
f... | 2 | 4 | 2 |
688d4bd8e27b4a6bbd53de0f1774b49554a2b908 | Emilio Cobos Álvarez | 2018-10-29T12:04:25 | Bug 1497389 - Add a fast path for querySelector{,All} when we have classes or tags in the rightmost compound. r=heycam,firefox-style-system-reviewers
Before this patch we were only optimizing the case of a single selector, which
is fine, but not enough to catch ones like .foo .bar or so.
This patch allows us to optim... | diff --git a/style/dom_apis.rs b/style/dom_apis.rs
index 9d7ab917a..b7a5fbd24 100644
--- a/style/dom_apis.rs
+++ b/style/dom_apis.rs
@@ -13,7 +13,7 @@ use invalidation::element::invalidator::{InvalidationProcessor, InvalidationVect
use selectors::{Element, NthIndexCache, SelectorList};
use selectors::attr::CaseSensit... | 1 | 84 | 13 |
9ec98f2f106010118cfb768c540aa6c24867a7c9 | Emilio Cobos Álvarez | 2018-10-28T23:26:53 | Bug 1502185 - Don't allow auto in grid line names. r=mats
See https://github.com/w3c/csswg-drafts/issues/2856.
Differential Revision: https://phabricator.services.mozilla.com/D9882 | diff --git a/style/values/generics/grid.rs b/style/values/generics/grid.rs
index 56b6f4636..13c7fa542 100644
--- a/style/values/generics/grid.rs
+++ b/style/values/generics/grid.rs
@@ -120,7 +120,9 @@ impl Parse for GridLine<specified::Integer> {
if val_before_span || grid_line.ident.is_some() {
... | 2 | 4 | 2 |
13757f99ca4a6b743a797a409cff21fae9a710bb | Emilio Cobos Álvarez | 2018-10-28T22:34:48 | Bug 1502754 - Fix Servo build and tidy lints. | diff --git a/style/animation.rs b/style/animation.rs
index 057019950..70db7c2c5 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -27,8 +27,8 @@ use std::sync::mpsc::Sender;
use stylesheets::keyframes_rule::{KeyframesAnimation, KeyframesStep, KeyframesStepValue};
use timer::Timer;
use values::computed::Tim... | 6 | 27 | 20 |
1044df141f415b7d201a15605038baed28e14d9b | Mats Palmgren | 2018-10-28T22:00:13 | Bug 1501908 - Force line-height:normal for themed comboboxes for compat with other UAs. r=emilio | diff --git a/style/style_adjuster.rs b/style/style_adjuster.rs
index 7c6579828..bf5752e6e 100644
--- a/style/style_adjuster.rs
+++ b/style/style_adjuster.rs
@@ -9,8 +9,10 @@ use app_units::Au;
use dom::TElement;
use properties::{self, ComputedValues, StyleBuilder};
use properties::computed_value_flags::ComputedValue... | 1 | 25 | 0 |
bd289c582dce70af8799e888ae7a5fda61f52d9e | Emilio Cobos Álvarez | 2018-10-27T21:41:30 | Bug 1502679 - Properly handle exhaustive matches in animation keywords to avoid a warning.
Need to do the gecko_inexhaustive thing because those animation properties have
an EndGuard_ generated by IPDL I suspect. | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index d54c84186..430eb42bd 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -3000,7 +3000,9 @@ fn static_assert() {
% for value in keyword.gecko_values():
structs::${keyword.geck... | 2 | 4 | 0 |
949453782e05682b15e8712e49813eb73b148720 | Emilio Cobos Álvarez | 2018-10-27T11:16:48 | Bug 1416282 - Assert earlier to try to get a more helpful stack. | diff --git a/selectors/builder.rs b/selectors/builder.rs
index 33c0ec1b6..b17ed9bfc 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -72,7 +72,7 @@ impl<Impl: SelectorImpl> SelectorBuilder<Impl> {
/// Pushes a simple selector onto the current compound selector.
#[inline(always)]
pub fn pus... | 1 | 1 | 1 |
c326838150767a114242a8f8e62f77d37d1cba89 | Emilio Cobos Álvarez | 2018-10-27T11:10:57 | Bug 1416282 - Back out diagnostics for not being helpful enough at diagnosing.
The selectors that crash seem just corrupted data structures, none of the
selectors from crash dumps make sense, and the ones for which I could trace the
source found no issue. | diff --git a/selectors/builder.rs b/selectors/builder.rs
index 584a21015..33c0ec1b6 100644
--- a/selectors/builder.rs
+++ b/selectors/builder.rs
@@ -105,7 +105,7 @@ impl<Impl: SelectorImpl> SelectorBuilder<Impl> {
parsed_slotted: bool,
) -> ThinArc<SpecificityAndFlags, Component<Impl>> {
// Compu... | 1 | 9 | 16 |
a7d779ed99a96aec8babab6a8d2a43fd3ef1aa83 | Ting-Yu Lin | 2018-10-27T06:14:13 | Bug 1421105 Part 4 - Enable CSS column-span in UA stylesheet, and update test expectations. r=dbaron
We use "column-span: all" in ua.css in Part 3. To be able to flip the pref
in individual wpt tests, we need column-span to be always enabled
in UA stylesheets.
Depends on D5210
Differential Revision: https://phabrica... | diff --git a/style/properties/longhands/column.mako.rs b/style/properties/longhands/column.mako.rs
index adc9371e9..cc10d605e 100644
--- a/style/properties/longhands/column.mako.rs
+++ b/style/properties/longhands/column.mako.rs
@@ -65,6 +65,7 @@ ${helpers.predefined_type(
spec="https://drafts.csswg.org/css-multic... | 1 | 2 | 0 |
72e78e109174bd5f85cadfee267894e4e0558138 | Boris Chiou | 2018-10-26T18:03:37 | Bug 1496619 - part 7: Implement steps(jump-*) functions r=birtles
1. Add a new preference, layout.css.step-position-jump.enabled, for
step(_, jump-*) timing functions.
2. We still keep JumpEnd and End tags, even though there is no difference
between them. Therefore, we could disable the preference if needed.
3. ... | diff --git a/style/animation.rs b/style/animation.rs
index 311d10272..057019950 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -363,11 +363,39 @@ impl PropertyAnimation {
GenericTimingFunction::CubicBezier { x1, y1, x2, y2 } => {
Bezier::new(x1, y1, x2, y2).solve(time, epsilon... | 3 | 67 | 8 |
1dc9b32cc1be2169459fe2fbe37650a878986a71 | Boris Chiou | 2018-10-26T18:03:31 | Bug 1496619 - Part 4: Replace u32 with computed::Integer for computed::TimingFunction r=emilio
We make sure the step number is always positive, so using
computed::Integer is safe and can derive ToComputedValue.
Depends on D9311
Differential Revision: https://phabricator.services.mozilla.com/D9845 | diff --git a/style/gecko_bindings/sugar/ns_timing_function.rs b/style/gecko_bindings/sugar/ns_timing_function.rs
index ff3352ea6..3eb3b96bb 100644
--- a/style/gecko_bindings/sugar/ns_timing_function.rs
+++ b/style/gecko_bindings/sugar/ns_timing_function.rs
@@ -11,7 +11,7 @@ use values::generics::easing::TimingFunction ... | 4 | 9 | 54 |
d7da3033255db4e316e72d7724f6d9ea1a7c1074 | Boris Chiou | 2018-10-26T18:03:29 | Bug 1496619 - Part 3: Split TimingFunction into a separate file to match spec r=emilio
TimingFunction is defined in a separate spec (i.e. css-easing), instead
of transform, so we move it into a different file.
Depends on D9310
Differential Revision: https://phabricator.services.mozilla.com/D9311 | diff --git a/style/animation.rs b/style/animation.rs
index 59d45dc63..311d10272 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -28,9 +28,9 @@ use stylesheets::keyframes_rule::{KeyframesAnimation, KeyframesStep, KeyframesSt
use timer::Timer;
use values::computed::Time;
use values::computed::box_::Transit... | 11 | 230 | 193 |
1fda8f0debe19319376a0ca04b395f4449888189 | Boris Chiou | 2018-10-26T18:03:24 | Bug 1496619 - Part 1: Drop frames() timing function r=birtles
frames() timing function was removed from the spec, so we drop it.
Besides, some devtool tests are removed because they use frame(). I will
add them back by using new step function later.
Differential Revision: https://phabricator.services.mozilla.com/D930... | diff --git a/style/animation.rs b/style/animation.rs
index 5d96f5cac..59d45dc63 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -369,22 +369,6 @@ impl PropertyAnimation {
GenericTimingFunction::Steps(steps, StepPosition::End) => {
(time * (steps as f64)).floor() / (steps as f64... | 4 | 4 | 71 |
f1e8025f976c0fa0b19b4e0516ede507d6034228 | Emilio Cobos Álvarez | 2018-10-24T20:32:16 | Bug 1500885 - Remove tests and other similar bits. r=mats
Also remove specified-value-only keywords, since those are handled
only in Rust code and C++ doesn't need to know about them.
Differential Revision: https://phabricator.services.mozilla.com/D9634 | diff --git a/style/values/specified/text.rs b/style/values/specified/text.rs
index adeab96c9..6bd0af23e 100644
--- a/style/values/specified/text.rs
+++ b/style/values/specified/text.rs
@@ -488,12 +488,7 @@ impl TextAlign {
/// Convert an enumerated value coming from Gecko to a `TextAlign`.
#[cfg(feature = "ge... | 1 | 1 | 6 |
fed28b24b3ce619e95565bdf9c985bfd321449da | Brian Birtles | 2018-10-24T07:06:43 | Bug 1500820 - Compare absolute dot-product to 1.0 when interpolating quaternions; r=hiro
See the extended commit message for the following spec change:
https://github.com/w3c/csswg-drafts/commit/6b36d41ebc2e790c86cc768a6ea1dcfa81fffe75
Basically, by failing to take the absolute value, for certain content we can en... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 11ae9115f..b079f30b1 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1829,7 +1829,7 @@ impl Animate for Quaterni... | 1 | 1 | 1 |
81eaddecf5d5b0010b2a1b85e9ed514768774468 | tb120 | 2018-10-22T21:58:01 | Convert NS_STYLE_ANIMATION_PLAY_STATE_* to scoped enum StyleAnimationPlayState (Bug 1500439) r=emilio
This change removes directives NS_STYLE_ANIMATION_PLAY_STATE_* and replaces the values with those from a scoped enum called StyleAnimationPlayState.
Differential Revision: https://phabricator.services.mozilla.com/D93... | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index ed7839360..8cbba2d8b 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -258,6 +258,7 @@ ${helpers.single_keyword(
animation_value_type="none",
vector=True,
... | 1 | 1 | 0 |
5a921d0a395d568f92b8f205f3f28ef8f78af351 | Emilio Cobos Álvarez | 2018-10-22T11:59:09 | Bug 1500892 - Use searchfox links instead of dxr links for nsRuleNode. r=heycam,firefox-style-system-reviewers
Searchfox has better blame.
Differential Revision: https://phabricator.services.mozilla.com/D9375 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 10b177558..8cd9e4bdd 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -1032,13 +1032,13 @@ impl TrackSize<LengthOrPercentage> {
match *self {
TrackSize::FitContent(ref lop) => {
/... | 3 | 5 | 5 |
151fab769ba074a9f1ec4dcd073393202bb9f52c | Emilio Cobos Álvarez | 2018-10-22T07:41:30 | Bug 1500849 - Update bindgen. r=heycam,bbouvier
This pulls a new nom version, which is slightly unfortunate, but I do want some
of the fixes upstream, and it's build-only, so I think it's not a huge deal.
Differential Revision: https://phabricator.services.mozilla.com/D9362 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 4c06bcf1f..84907deca 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -78,7 +78,7 @@ void = "1.0.2"
[build-dependencies]
lazy_static = "1"
log = "0.4"
-bindgen = { version = "0.39", optional = true, default-features = false }
+bindgen = { version = "0.43"... | 1 | 1 | 1 |
d57552b2b81ae064fb9581f637deb3686a855389 | Brian Birtles | 2018-10-19T04:41:12 | Bug 1472917 - Implement the even more forgiving interpolation rules for transform lists; r=hiro
As discussed in:
https://github.com/w3c/csswg-drafts/issues/927
with tentative spec text:
https://github.com/w3c/csswg-drafts/pull/3215
Depends on D9184
Differential Revision: https://phabricator.services.mozilla.c... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 106c3b39d..4f5cede91 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1351,11 +1351,11 @@ fn is_matched_operation... | 1 | 102 | 69 |
23bd2f6f09474af9b08b5dcb73aa2ab4af26945d | Emilio Cobos Álvarez | 2018-10-18T22:46:28 | Bug 1500260 - Fix various tidy issues and Servo build. r=emilio | diff --git a/style/gecko/arc_types.rs b/style/gecko/arc_types.rs
index 66d96492b..0a9bf4d5c 100644
--- a/style/gecko/arc_types.rs
+++ b/style/gecko/arc_types.rs
@@ -23,12 +23,12 @@ use gecko_bindings::bindings::RawServoRuleNodeStrong;
use gecko_bindings::bindings::RawServoSupportsRule;
use gecko_bindings::bindings::S... | 10 | 16 | 11 |
1a764b78297e2547405c60783ed3205d390d0f76 | Josh Matthews | 2018-10-09T18:41:37 | Bug 1500260 - Update servo malloc_size_of after webrender update. r=emilio
This cherry-picks part of servo/servo#21725. | diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs
index df2b5a442..52b8412f6 100644
--- a/malloc_size_of/lib.rs
+++ b/malloc_size_of/lib.rs
@@ -917,8 +917,6 @@ malloc_size_of_is_0!(webrender_api::BorderRadius);
#[cfg(feature = "webrender_api")]
malloc_size_of_is_0!(webrender_api::BorderStyle);
#[cfg(feature... | 1 | 0 | 2 |
0cdec26a9969eccd941b32b5da05a07baaf5dbb5 | Pyfisch | 2018-10-06T15:35:45 | Bug 1500260 - Use keyboard-types crate. r=emilio
Have embedders send DOM keys to servo and use a strongly typed KeyboardEvent
from the W3C UI Events spec. All keyboard handling now uses the new types.
Introduce a ShortcutMatcher to recognize key bindings. Shortcuts are now
recognized in a uniform way.
Updated the wi... | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index cd05b5d50..e982925e5 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -12,6 +12,7 @@ path = "lib.rs"
servo = [
"hyper",
"hyper_serde",
+ "keyboard-types",
"mozjs",
"serde",
"serde_bytes",
@@ -3... | 2 | 17 | 0 |
98dde23d875e53b2c47d751807c97de34f30348e | Emilio Cobos Álvarez | 2018-05-06T16:45:16 | Bug 1500260 - More useful logging for transition-related stuff. r=emilio
Transitions are still broken, but I found these messages more helpful than the
previous ones when diagnosing problems.
This cherry-picks part of servo/servo#20757. | diff --git a/style/animation.rs b/style/animation.rs
index ae22e0b58..5d96f5cac 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -438,9 +438,16 @@ pub fn start_transitions_if_applicable(
.iter()
.any(|animation| animation.has_the_same_end_value_as(&property_animation))
... | 3 | 23 | 31 |
fb9955521e9632643fe9076b2adc5ccf5106045f | Emilio Cobos Álvarez | 2018-05-05T17:15:59 | Bug 1500260 - Expire keyframes animations when no longer referenced by the style. r=emilio
It's a long way to make this sound in general...
Fixes #20731
This cherry-picks part of servo/servo#20757. | diff --git a/style/animation.rs b/style/animation.rs
index d4a0b17e7..ae22e0b58 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -630,13 +630,31 @@ pub fn update_style_for_animation_frame(
true
}
+/// Returns the kind of animation update that happened.
+pub enum AnimationUpdate {
+ /// The style w... | 2 | 46 | 25 |
dd0c3f9c86ec0e8cd95bf554c979b4698250e211 | Emilio Cobos Álvarez | 2018-05-05T16:36:22 | Bug 1500260 - Remove unused expired boolean in Animation::Transition. r=emilio
The last caller who used was #14418, which did fix a problem but introduced
multiple. In particular, now transitions don't get expired ever, until they
finish running of course.
That is not ok, given you can have something that the user ca... | diff --git a/style/animation.rs b/style/animation.rs
index 1a054f679..d4a0b17e7 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -214,9 +214,7 @@ pub enum Animation {
/// A transition is just a single frame triggered at a time, with a reflow.
///
/// the f64 field is the start time as returned... | 2 | 6 | 19 |
f16e8c829a11f0fef0fea5da5852988a68ec312d | Emilio Cobos Álvarez | 2018-05-05T16:15:14 | Bug 1500260 - Cleanup some of the animation starting code. r=emilio
This cherry-picks part of servo/servo#20757. | diff --git a/style/animation.rs b/style/animation.rs
index 5c0a71034..1a054f679 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -544,10 +544,9 @@ where
let box_style = new_style.get_box();
for (i, name) in box_style.animation_name_iter().enumerate() {
- let name = if let Some(atom) = name... | 1 | 56 | 53 |
8aa95573d9df8011a56e5903d2b05e23d9a0c445 | Emilio Cobos Álvarez | 2018-10-14T22:33:43 | Bug 1500260 - Stop using PseudoElement::inherits_all. r=emilio
This was done that way just because Servo didn't support the `all` property at
the time.
We should do it this way and optimize it if it's slow. Though I suspect that
most of stuff doesn't actually need to be inherited, my patch at bug 1498943
should make ... | diff --git a/style/servo/selector_parser.rs b/style/servo/selector_parser.rs
index 47f1c73ea..de8257dcc 100644
--- a/style/servo/selector_parser.rs
+++ b/style/servo/selector_parser.rs
@@ -548,7 +548,7 @@ impl<'a, 'i> ::selectors::Parser<'i> for SelectorParser<'a> {
}
ServoInlineBlockW... | 1 | 1 | 1 |
60321fde166eeea7a6c477f9a0aec31defc9aedf | Emilio Cobos Álvarez | 2018-10-17T19:48:35 | Bug 1499778 - Remove StaticId. r=xidorn
Destructors in statics are ok now.
Differential Revision: https://phabricator.services.mozilla.com/D9004 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 0540d90be..330ceea7f 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -1671,53 +1671,30 @@ impl PropertyId {
///
/// Returns Err(()) for unknown non-custom properties.
... | 1 | 18 | 41 |
710c92346c0d859a8e43c1efbb1bc2769e781016 | Emilio Cobos Álvarez | 2018-10-17T15:12:13 | Bug 1499408 - followup test fix to the followup build fix. | diff --git a/style/properties/longhands/border.mako.rs b/style/properties/longhands/border.mako.rs
index 1066dbbc6..09e5abc00 100644
--- a/style/properties/longhands/border.mako.rs
+++ b/style/properties/longhands/border.mako.rs
@@ -111,7 +111,6 @@ ${helpers.predefined_type(
vector=False,
animation_value_type... | 1 | 0 | 1 |
c79510bdcb6228a97b26af3790358049b48d123e | Emilio Cobos Álvarez | 2018-10-17T12:08:14 | Bug 1499386 - Implement @supports selector() syntax. r=heycam
This implements the selector(<complex-selector>) syntax for @supports.
See https://github.com/w3c/csswg-drafts/issues/3207 for explainer and
discussion.
Probably would should wait for that to be sorted out to land this, or maybe we
should put it behind a ... | diff --git a/selectors/parser.rs b/selectors/parser.rs
index 8e26ff63d..fc4b26bb3 100644
--- a/selectors/parser.rs
+++ b/selectors/parser.rs
@@ -259,8 +259,13 @@ where
Impl: SelectorImpl,
{
let location = input.current_source_location();
- let selector = Selector::parse(parser, input)?;
- // Ensure the... | 5 | 159 | 67 |
0df2feebdff27659df629e82cd7dc8141f749cf7 | Emilio Cobos Álvarez | 2018-10-17T13:37:47 | Bug 1499603 - Clear host rules from clear_cascade_data. r=heycam
While at it, also measure them for about:memory.
Differential Revision: https://phabricator.services.mozilla.com/D8972 | diff --git a/style/stylist.rs b/style/stylist.rs
index e5249a52b..fe96fd78a 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -2415,6 +2415,9 @@ impl CascadeData {
if let Some(ref mut slotted_rules) = self.slotted_rules {
slotted_rules.clear();
}
+ if let Some(ref mut host_ru... | 1 | 6 | 0 |
70f5daa1f0d3315f938287d15dd9c1fadb5fdb6b | Cameron McCormack | 2018-10-17T09:43:45 | Bug 1495984 - Make css::URLValue::IsLocalRef call into CssUrlData::is_fragment. r=emilio
This fixes the issue that we should no longer be looking for control characters.
MozReview-Commit-ID: 8k89Aheq3NY
Differential Revision: https://phabricator.services.mozilla.com/D8876 | diff --git a/style/gecko/url.rs b/style/gecko/url.rs
index 3ee7c8307..811a02508 100644
--- a/style/gecko/url.rs
+++ b/style/gecko/url.rs
@@ -54,8 +54,9 @@ impl CssUrl {
/// Returns true if this URL looks like a fragment.
/// See https://drafts.csswg.org/css-values/#local-urls
+ #[inline]
pub fn is_f... | 1 | 8 | 1 |
8743e90a3a8417087f1bac8e0bda842010355202 | Cameron McCormack | 2018-10-17T09:43:32 | Bug 1499408 - Part 2: Have css::URLValue get URLExtraData from its CssUrlData. r=emilio
MozReview-Commit-ID: IqZGzkHlSZD
Depends on D8874
Differential Revision: https://phabricator.services.mozilla.com/D8875 | diff --git a/style/gecko/url.rs b/style/gecko/url.rs
index cdcfc37db..3ee7c8307 100644
--- a/style/gecko/url.rs
+++ b/style/gecko/url.rs
@@ -118,7 +118,6 @@ impl SpecifiedUrl {
let url_value = unsafe {
let ptr = bindings::Gecko_URLValue_Create(
url.0.clone().into_strong(),
- ... | 1 | 0 | 1 |
ac2802e19a289db8cd111603c4a00d59852d96e3 | Cameron McCormack | 2018-10-17T12:36:49 | Bug 1499408 - Part 1: Make css::URLValue hold on to a CssUrlData, not just its serialization. r=emilio
MozReview-Commit-ID: EWcbnVtDJCS
Differential Revision: https://phabricator.services.mozilla.com/D8874 | diff --git a/style/gecko/arc_types.rs b/style/gecko/arc_types.rs
index 7351cbfea..66d96492b 100644
--- a/style/gecko/arc_types.rs
+++ b/style/gecko/arc_types.rs
@@ -8,6 +8,7 @@
#![allow(non_snake_case, missing_docs)]
+use gecko::url::CssUrlData;
use gecko_bindings::bindings::RawServoCounterStyleRule;
use gecko_b... | 2 | 34 | 41 |
90254d549fc5bb8ef533a52eb02465f7a3bcee48 | Benjamin Bouvier | 2018-10-16T13:18:26 | Bug 1499359: Apply rustfmt on build_gecko.rs; r=emilio | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index e0dbbf581..bee061fcc 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -260,8 +260,7 @@ mod bindings {
fn get_types(filename: &str, macro_pat: &str) -> Vec<(String, String)> {
// Read the file
let path = DISTDIR_PATH.joi... | 1 | 16 | 16 |
c92a3dc75f73d699ec7e426e2a3dac7b43798241 | Benjamin Bouvier | 2018-10-16T13:17:10 | Bug 1499359; Remove unused HashMap import and remove namespacing around Table; r=emilio | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 9db123a42..e0dbbf581 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -17,7 +17,7 @@ mod bindings {
use bindgen::{Builder, CodegenConfig};
use regex::Regex;
use std::cmp;
- use std::collections::{HashMap, HashSet};
+ use ... | 1 | 2 | 2 |
602bca552fec6f07af2b25ec7d3a7e411d9838aa | Boris Chiou | 2018-10-16T01:07:41 | Bug 1496558 - Part 2: Move MozLength and MaxLength into generics r=emilio
Move MozLength and MaxLength into generics, and drop the manual implementation
of ToComputedValue.
Depends on D8290
Differential Revision: https://phabricator.services.mozilla.com/D8291 | diff --git a/style/gecko/values.rs b/style/gecko/values.rs
index 572c3db6b..2a164acd4 100644
--- a/style/gecko/values.rs
+++ b/style/gecko/values.rs
@@ -19,7 +19,7 @@ use std::cmp::max;
use values::{Auto, Either, None_, Normal};
use values::computed::{Angle, ExtremumLength, Length, LengthOrPercentage, LengthOrPercent... | 7 | 89 | 118 |
74d336e64b1e2a9439cb41528605e15d56fef159 | Boris Chiou | 2018-10-16T19:38:41 | Bug 1496558 - Part 1: Store the correct computed values for keywords for sizing properties r=mats
In order to get the correct computed value of these keywords, we have to
make sure we store the correct computed values in sizing properties in
both inline axis and block axis.
-moz-max-content and -moz-min-content shoul... | diff --git a/style/values/computed/length.rs b/style/values/computed/length.rs
index d3bc0b5eb..e7098c69f 100644
--- a/style/values/computed/length.rs
+++ b/style/values/computed/length.rs
@@ -5,9 +5,7 @@
//! `<length>` computed values, and related ones.
use app_units::Au;
-use logical_geometry::WritingMode;
use o... | 1 | 3 | 72 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.