commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
3a99fc3c8cc5f5aadb5e25580e120162de71036f | Emilio Cobos Álvarez | 2018-10-15T03:13:09 | Bug 1498943 - Remove PseudoElement::inherits_all. r=heycam
I plan to change servo to use all: inherit on its UA sheet.
I hope the patch below should make it good enough performance-wise. And also,
it's probably broken so I don't think it's worth supporting it specially.
Differential Revision: https://phabricator.ser... | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index 70b0e112c..23fea1018 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -57,15 +57,6 @@ impl PseudoElement {
PseudoElementCascadeType::Lazy
}
- /// Whether cascading this pseudo-element mak... | 4 | 0 | 63 |
ae8ab872b60c4deca7020b5c02c2ab1e09a0b275 | Emilio Cobos Álvarez | 2018-10-15T03:04:44 | Bug 1498943 - Don't copy structs to write the same value to them. r=heycam
This makes us not allocate useless style structs when you're doing something
like resetting an already-reset property, or inheriting an already-inherited
property.
Seemed simple enough that I think we should do it. In practice we don't even
sh... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 5968d84bd..109f21960 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -3137,7 +3137,8 @@ pub enum StyleStructRef<'a, T: 'static> {
}
impl<'a, T: 'a> StyleStructRef<'a, T>
- wh... | 1 | 26 | 5 |
cad286374e3693ddaa5cc59028e1158022661206 | Benjamin Bouvier | 2018-10-09T13:01:52 | Bug 1495669: Share bindgen flags globally; r=emilio, r=froydnj | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index c8e886c4b..9db123a42 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -58,22 +58,10 @@ mod bindings {
};
static ref BUILD_CONFIG: Table = {
// Load build-specific config overrides.
- // FIXME: We shou... | 1 | 4 | 47 |
33b9859a52c88dba8a5144e4f1a34bdd684d794e | Cameron McCormack | 2018-10-09T08:49:51 | Bug 1497406 - Use helper function to set length and copy into nsTArrays of PODs from Rust r=boris
Differential Revision: https://phabricator.services.mozilla.com/D8058 | diff --git a/style/gecko_bindings/sugar/ns_t_array.rs b/style/gecko_bindings/sugar/ns_t_array.rs
index bf5e168b5..72a7481fe 100644
--- a/style/gecko_bindings/sugar/ns_t_array.rs
+++ b/style/gecko_bindings/sugar/ns_t_array.rs
@@ -82,9 +82,9 @@ impl<T> nsTArray<T> {
/// Resize and set the length of the array to `l... | 3 | 40 | 55 |
7ac854dc2b5a65e0837d57fb9bc9275a409f642d | Cameron McCormack | 2018-10-14T00:06:13 | Bug 1498755 - Part 11: Move Gecko borrowed FFI types to a separate header file r=emilio
Depends on D8652
Differential Revision: https://phabricator.services.mozilla.com/D8653 | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index a30a2a8ae..c8e886c4b 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -300,7 +300,7 @@ mod bindings {
.expect("Unable to write output");
}
- fn get_types(filename: &str, macro_name: &str) -> Vec<String> {
+ fn get_ty... | 3 | 34 | 12 |
fd0f48339a4b34933fc3da4cc446acd812652cd3 | Cameron McCormack | 2018-10-14T00:06:05 | Bug 1498755 - Part 10: Move list of Servo Boxed types to a separate header file r=emilio
Depends on D8651
Differential Revision: https://phabricator.services.mozilla.com/D8652 | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index f3f5f110d..a30a2a8ae 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -300,21 +300,23 @@ mod bindings {
.expect("Unable to write output");
}
- fn get_arc_types() -> Vec<String> {
+ fn get_types(filename: &str, macro_... | 2 | 28 | 20 |
1c27e9cb2bf242e863d5950d25ec1bc5fff9c121 | Cameron McCormack | 2018-10-14T23:29:59 | Bug 1498755 - Part 8: Add comments to ServoBindingTypes.h r=emilio
Depends on D8649
Differential Revision: https://phabricator.services.mozilla.com/D8650 | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 1ecc7ec6f..f3f5f110d 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -310,7 +310,9 @@ mod bindings {
.expect("Fail to read ServoArcTypeList.h");
// Remove comments
let block_comment_re = Regex::new(r#"(?s)/\*.*... | 1 | 2 | 0 |
a577f8dc127b9fe811893cab8a496d38875aa4a5 | Diego Pino Garcia | 2018-10-13T22:42:24 | Bug 1498148 - Implement text-transform: full-size-kana. r=xidorn | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index de7b613a1..164f8a7de 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -23,7 +23,7 @@ ${helpers.predefined_type(
${helpers.sin... | 1 | 1 | 1 |
43f9e07cbff5d1637a522b36753fc6f57e2e5207 | Noemi Erli | 2018-10-13T21:12:12 | Backed out changeset a00b402fb8e8 (bug 1498148) for Linting failure in builds/worker/checkouts/gecko/tools/lint/wpt.yml CLOSED TREE | diff --git a/style/properties/longhands/inherited_text.mako.rs b/style/properties/longhands/inherited_text.mako.rs
index 164f8a7de..de7b613a1 100644
--- a/style/properties/longhands/inherited_text.mako.rs
+++ b/style/properties/longhands/inherited_text.mako.rs
@@ -23,7 +23,7 @@ ${helpers.predefined_type(
${helpers.sin... | 1 | 1 | 1 |
a3425ce5bd832eb286a0da229389304bf881a097 | Emilio Cobos Álvarez | 2018-10-13T01:14:36 | Bug 1498734 - remove unneeded cast. r=me | diff --git a/style/values/computed/angle.rs b/style/values/computed/angle.rs
index ccf5b0af8..04a3f3036 100644
--- a/style/values/computed/angle.rs
+++ b/style/values/computed/angle.rs
@@ -56,7 +56,7 @@ impl Angle {
/// quarter-turn for 225 degrees, for example.
#[inline]
pub fn radians64(&self) -> f64 {... | 1 | 1 | 1 |
23c05bca3f8e4426abfc906d2a3033782427e22d | Emilio Cobos Álvarez | 2018-10-13T00:41:03 | Bug 1498734 - Always compute angle values to degrees. r=xidorn
This matches the spec, https://drafts.csswg.org/css-values/#angles, which says:
> All <angle> units are compatible, and deg is their canonical unit.
And https://drafts.csswg.org/css-values/#compat, which says:
>When serializing computed values [...], co... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 84ad514c5..10b177558 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -11,7 +11,7 @@
use app_units::Au;
use gecko::values::GeckoStyleCoordConvertible;
use gecko_bindings::bindings;
-use gecko_bindings::structs::{sel... | 11 | 142 | 209 |
320ef6da772e40ef87b7c87b23840c5b8a711aaa | Mats Palmgren | 2018-10-12T19:36:02 | Bug 1496720 - [css-compat] Unship most of the -moz-appearance values that aren't supported by -webkit-appearance in other UAs. r=emilio | diff --git a/style/values/specified/box.rs b/style/values/specified/box.rs
index e23ec4a74..7e79fc892 100644
--- a/style/values/specified/box.rs
+++ b/style/values/specified/box.rs
@@ -966,20 +966,27 @@ pub enum Appearance {
/// A typical dialog button.
Button,
/// Various arrows that go in buttons
+ ... | 1 | 91 | 0 |
9074eb59da5c0096b83cf62e6a8fd2ef2b8023f0 | Emilio Cobos Álvarez | 2018-10-10T20:26:45 | Bug 1497986 - Some more nsCSSValue cleanup. r=mats
I had this around, I couldn't work on more stuff today, but I may as well land
this.
Differential Revision: https://phabricator.services.mozilla.com/D8277 | diff --git a/style/gecko_bindings/sugar/ns_css_value.rs b/style/gecko_bindings/sugar/ns_css_value.rs
index ed8892028..e06e09f4c 100644
--- a/style/gecko_bindings/sugar/ns_css_value.rs
+++ b/style/gecko_bindings/sugar/ns_css_value.rs
@@ -60,7 +60,7 @@ impl nsCSSValue {
pub unsafe fn array_unchecked(&self) -> &nsCSS... | 1 | 1 | 1 |
d9e01e5ba81af3df285bcaa0a131bde62ef4354f | Cameron McCormack | 2018-10-10T02:58:20 | Bug 1495994 - Part 4: Merge css::{URLValueData, ImageValue} into css::URLValue r=emilio
Depends on D7595
Differential Revision: https://phabricator.services.mozilla.com/D8061 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 846f2113f..84ad514c5 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -225,13 +225,13 @@ impl nsStyleImage {
match image {
GenericImage::Gradient(boxed_gradient) => self.set_gradient(*boxed_gradie... | 4 | 80 | 102 |
18c03978725c9f425f3b974db3ee7d2b4f65067f | Emilio Cobos Álvarez | 2018-10-09T18:27:38 | Bug 1497607 - Fix some style issues caught by servo-tidy. r=me | diff --git a/style/font_face.rs b/style/font_face.rs
index 987ddb829..b78947dd4 100644
--- a/style/font_face.rs
+++ b/style/font_face.rs
@@ -161,7 +161,7 @@ impl FontWeightRange {
/// The font-stretch descriptor:
///
/// https://drafts.csswg.org/css-fonts-4/#descdef-font-face-font-stretch
-#[derive(Clone, Debug, Par... | 3 | 3 | 3 |
aa6fbe765e32ff5d2725aceb810a0ca516dace3c | Emilio Cobos Álvarez | 2018-10-04T11:35:53 | Bug 1496486 - Remove some more leftover code. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D7755 | diff --git a/style/gecko/rules.rs b/style/gecko/rules.rs
index 11970151f..3bb605bfa 100644
--- a/style/gecko/rules.rs
+++ b/style/gecko/rules.rs
@@ -5,47 +5,9 @@
//! Bindings for CSS Rule objects
use counter_style::{self, CounterBound};
-use font_face::Source;
use gecko_bindings::structs::{self, nsCSSValue};
use ... | 2 | 0 | 54 |
ea5b743a64d1d03e007e6ee063c39881ee300bb6 | Emilio Cobos Álvarez | 2018-10-05T20:08:55 | Bug 1496008 - Serialize a bunch of image properties with Servo. r=heycam
I had to fix the conversion for BackgroundSize too, hopefully we can
simplify all this using cbindgen in the future instead of CalcValue.
Differential Revision: https://phabricator.services.mozilla.com/D7580 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index c6009c96d..bc0894c58 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -17,7 +17,7 @@ use gecko_bindings::sugar::ns_style_coord::{CoordData, CoordDataMut, CoordDataVa
use std::f32::consts::PI;
use stylesheets::{Origin... | 4 | 63 | 19 |
62142f3886ebb0ea1c64c7e83543fbd823795c97 | Ryan Hunt | 2018-10-01T19:26:23 | Bug 1352643 - Implement multi-position gradient color-stops syntax. r=emilio
This commit adds the multi-position gradient color-stops syntax.
GradientItem::parse_comma_separated is extended to attempt to parse
a LengthOrPercent after each color stop. If it succeeds, it appends
an additional color stop with a duplicat... | diff --git a/style/values/specified/image.rs b/style/values/specified/image.rs
index b1a611846..0a3a402e9 100644
--- a/style/values/specified/image.rs
+++ b/style/values/specified/image.rs
@@ -8,7 +8,7 @@
//! [image]: https://drafts.csswg.org/css-images/#image-values
use Atom;
-use cssparser::{Parser, Token};
+use ... | 1 | 35 | 9 |
6b8a6ec7d99f9c2616e0014044f4949491ba14cb | Coroiu Cristina | 2018-10-02T23:37:44 | Backed out changeset e85309ff67f4 (bug 1352643) for wpt failures at /css/css-images/gradient/color-stops-parsing.html on a CLOSED TREE | diff --git a/style/values/specified/image.rs b/style/values/specified/image.rs
index 0a3a402e9..b1a611846 100644
--- a/style/values/specified/image.rs
+++ b/style/values/specified/image.rs
@@ -8,7 +8,7 @@
//! [image]: https://drafts.csswg.org/css-images/#image-values
use Atom;
-use cssparser::{Parser, Token, Delimi... | 1 | 9 | 35 |
b7105a8fbccd0b929695087b2790c44efdd7b1de | Emilio Cobos Álvarez | 2018-09-26T21:43:22 | Bug 1494622 - Serialize -moz-image-region and clip with Servo. r=xidorn
This changes the serialization of -moz-image-region to be consistent with that
of clip(), but it's an internal property and the specified value is already
serialized by servo so I think it's the right thing to do.
There are also no internal calle... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 2275316bf..65ed6c4ed 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -4447,7 +4447,7 @@ fn static_assert() {
Some(Au(self.gecko.mClip.x + self.gecko.mClip.width).into())
}... | 1 | 1 | 1 |
25c4115e425c86295309fe512239d6e1e5b6ed9b | Xidorn Quan | 2018-09-27T00:38:16 | Bug 1494501 - Rename pref "layout.css.scrollbar-colors.enabled" to "layout.css.scrollbar-color.enabled". r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D7030 | diff --git a/style/properties/longhands/inherited_ui.mako.rs b/style/properties/longhands/inherited_ui.mako.rs
index 6bdd0ff51..e1c7b18ec 100644
--- a/style/properties/longhands/inherited_ui.mako.rs
+++ b/style/properties/longhands/inherited_ui.mako.rs
@@ -72,7 +72,7 @@ ${helpers.predefined_type(
"ui::ScrollbarCol... | 1 | 1 | 1 |
499fcf329a82f6786223fd96b4c6c1c3fe8a55dd | Martin Stransky | 2018-09-25T11:53:04 | Bug 1493145 - [CSD] Enable round corners by default by -moz-gtk-csd-transparent-background media query, r=dao
Replace mozilla.widget.use-argb-visuals pref by -moz-gtk-csd-transparent-background media query at browser.css
to draw transparent background. The media query is set by toolkit code and enabled when compatible... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 5c744f242..9e84a7722 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -479,7 +479,7 @@ lazy_static! {
/// to support new types in these entries and (2) ensuring that either
/// nsPresContext::Medi... | 1 | 2 | 1 |
52fe2d57786059cf12b2d48832a8e6ef1c5aab62 | Emilio Cobos Álvarez | 2018-09-24T20:41:39 | Bug 1493710 - Don't apply containing shadow-host rules to NAC. r=mats
This is a regression from bug 1487856.
Differential Revision: https://phabricator.services.mozilla.com/D6700 | diff --git a/style/stylist.rs b/style/stylist.rs
index c933897f8..445b61aa9 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -1134,7 +1134,7 @@ impl Stylist {
let rule_hash_target = element.rule_hash_target();
- let matches_user_rules = rule_hash_target.matches_user_and_author_rules();
+ ... | 1 | 58 | 48 |
828c3a1f7c8cd6c801aec69ff1977831529f2230 | Csoregi Natalia | 2018-09-25T00:57:36 | Backed out changeset 73a8628576e4 (bug 1493710) for failures on layout/reftests/forms/input/shadow-rules.html. CLOSED TREE | diff --git a/style/stylist.rs b/style/stylist.rs
index 445b61aa9..c933897f8 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -1134,7 +1134,7 @@ impl Stylist {
let rule_hash_target = element.rule_hash_target();
- let matches_user_and_author_rules = rule_hash_target.matches_user_and_author_rule... | 1 | 48 | 58 |
461f370986c193854984ed07f4bb11dafbcb06f3 | Emilio Cobos Álvarez | 2018-09-24T21:00:59 | No bug - Remove an outdated comment. r=me
This was fixed, css/css-scoping/shadow-cascade-order-001.html tests it.
DONTBUILD, since comment only. | diff --git a/style/stylist.rs b/style/stylist.rs
index c933897f8..d0e32778d 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -1208,11 +1208,6 @@ impl Stylist {
let mut shadow_cascade_order = 0;
// XBL / Shadow DOM rules, which are author rules too.
- //
- // TODO(emilio): Cascad... | 1 | 0 | 5 |
9ee6ccd18a270dcfda754fcc7b7f4e70dc282a90 | Emilio Cobos Álvarez | 2018-09-24T08:42:15 | Bug 1493507 - Avoid walking the rule tree three times from apply_declarations. r=xidorn
Just once is slow enough.
Differential Revision: https://phabricator.services.mozilla.com/D6574 | diff --git a/style/properties/cascade.rs b/style/properties/cascade.rs
index af5273e0a..82c8e1501 100644
--- a/style/properties/cascade.rs
+++ b/style/properties/cascade.rs
@@ -20,6 +20,7 @@ use selector_parser::PseudoElement;
use servo_arc::Arc;
use shared_lock::StylesheetGuards;
use smallbitvec::SmallBitVec;
+use ... | 1 | 6 | 3 |
55684e672023e9d5fa2de833d33a68e4fdfb74f7 | Matt Brubeck | 2018-09-23T00:24:47 | Bug 1493435 - Upgrade to uluru 0.3. r=nox,emilio
This cherry-picks servo/servo#21789. | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 79c8e4502..4c06bcf1f 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -70,7 +70,7 @@ style_traits = {path = "../style_traits"}
servo_url = {path = "../url", optional = true}
thin-slice = "0.1.0"
time = "0.1"
-uluru = "0.2"
+uluru = "0.3"
unicode-bidi = "... | 1 | 1 | 1 |
fc1622b2721b84dca311be7a992b2e691db644bd | Emilio Cobos Álvarez | 2018-09-22T16:47:57 | Bug 1493435 - Partially revert servo/servo#21746. r=ajeffrey
This reverts the relevant bits from #21746 so that style and dependencies can
build with stable.
This is important because:
* `selectors` is a published crate.
* Gecko compiles with stable (more or less).
I reviewed that PR under the assumption that th... | diff --git a/fallible/Cargo.toml b/fallible/Cargo.toml
index 7b5291304..e8f531469 100644
--- a/fallible/Cargo.toml
+++ b/fallible/Cargo.toml
@@ -10,7 +10,7 @@ name = "fallible"
path = "lib.rs"
[dependencies]
-smallvec = { version = "0.6", features = ["std", "union"] }
+smallvec = "0.6"
hashglobe = { path = "../has... | 4 | 4 | 4 |
3dc3be23a3cc20e562804662b9696d001809d195 | Andre Bogus | 2018-09-19T05:16:30 | Bug 1493435 - Update smallvec crate and enable the union feature. r=emilio
We had a mix of 0.6.2 and 0.6.5 (which is the current release),
this unifies to the latest version. It also enables the union
feature which removes the discriminant, reducing memory usage.
This cherry-picks servo/servo#21746. | diff --git a/fallible/Cargo.toml b/fallible/Cargo.toml
index 176355acd..7b5291304 100644
--- a/fallible/Cargo.toml
+++ b/fallible/Cargo.toml
@@ -10,7 +10,7 @@ name = "fallible"
path = "lib.rs"
[dependencies]
-smallvec = "0.6.2"
+smallvec = { version = "0.6", features = ["std", "union"] }
hashglobe = { path = "../h... | 4 | 4 | 4 |
9147902ce1c90aeef343a4fc9bcc1ebcef0bd911 | Andreea Pavel | 2018-09-22T16:40:38 | Backed out changeset 66d0b0be41ed (bug 1493435) for build plain bustages | diff --git a/fallible/Cargo.toml b/fallible/Cargo.toml
index 7b5291304..176355acd 100644
--- a/fallible/Cargo.toml
+++ b/fallible/Cargo.toml
@@ -10,7 +10,7 @@ name = "fallible"
path = "lib.rs"
[dependencies]
-smallvec = { version = "0.6", features = ["std", "union"] }
+smallvec = "0.6.2"
hashglobe = { path = "../h... | 4 | 4 | 4 |
7f2100792b33aaa9db5526d8eb0f3103eed874a1 | Boris Chiou | 2018-09-21T18:39:41 | Bug 1491954 - Flip boolean half way for path interpolation r=emilio
According to the new svg 2 spec update (#543), we flip the flag half way for
path interpolation.
Differential Revision: https://phabricator.services.mozilla.com/D6192 | diff --git a/style/values/specified/svg_path.rs b/style/values/specified/svg_path.rs
index 5d397558d..3f1fdc39d 100644
--- a/style/values/specified/svg_path.rs
+++ b/style/values/specified/svg_path.rs
@@ -13,7 +13,7 @@ use std::slice;
use style_traits::{CssWriter, ParseError, StyleParseErrorKind, ToCss};
use style_tr... | 1 | 29 | 3 |
e3b9dd80210e9c3ecd9dba6c99afdd3a3ad6b6ae | Emilio Cobos Álvarez | 2018-09-19T20:02:01 | Bug 1492567 - Back out bug 1481866. r=dbaron
Summary:
The behavior the WG proposed is way more subtle than what that bug implements,
including:
* Implementing two logical overflow longhands.
* Expanding the overflow shorthand to different longhands depending on the
syntax of that.
Meanwhile, Blink hasn't done t... | diff --git a/style/properties/shorthands/box.mako.rs b/style/properties/shorthands/box.mako.rs
index 960e608ce..3886c7d2d 100644
--- a/style/properties/shorthands/box.mako.rs
+++ b/style/properties/shorthands/box.mako.rs
@@ -7,7 +7,7 @@
<%helpers:shorthand
name="overflow"
flags="SHORTHAND_IN_GETCS"
- sub_... | 1 | 6 | 6 |
686e267826df6acf9e370704462a6a50ff7192bd | Xidorn Quan | 2018-09-19T05:33:12 | Bug 1483075 - Merge the two scrollbar color properties into scrollbar-color. r=heycam,hiro
Differential Revision: https://phabricator.services.mozilla.com/D6115 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 1de99ec16..2275316bf 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -5304,7 +5304,7 @@ clip-path
</%self:impl_trait>
<%self:impl_trait style_struct_name="InheritedUI"
- skip_longh... | 5 | 94 | 16 |
939f9b1b6a5bcb3b76483d6fdbd22080307f700f | Emilio Cobos Álvarez | 2018-09-18T09:46:23 | Bug 1475691 - Make Servo build. r=me
StrongRuleNode is really Sync. | diff --git a/style/rule_tree/mod.rs b/style/rule_tree/mod.rs
index 662c303be..ff8c1cc86 100644
--- a/style/rule_tree/mod.rs
+++ b/style/rule_tree/mod.rs
@@ -938,8 +938,6 @@ impl MallocSizeOf for RuleNode {
}
}
-// FIXME: use std::ptr::NonNull when Firefox requires Rust 1.25+
-
#[derive(Clone)]
struct WeakRule... | 1 | 1 | 2 |
4fd7bad489c2f0a0b614dd001b91939d7c4371cf | Emilio Cobos Álvarez | 2018-09-18T09:44:47 | Bug 1475691 - Fix tidy issues. r=me | diff --git a/selectors/tree.rs b/selectors/tree.rs
index bfa59898b..9db190c81 100644
--- a/selectors/tree.rs
+++ b/selectors/tree.rs
@@ -22,7 +22,7 @@ impl OpaqueElement {
/// Creates a new OpaqueElement from an arbitrarily-typed pointer.
pub fn new<T>(ptr: &T) -> Self {
unsafe {
- OpaqueE... | 3 | 13 | 15 |
342da89ece2437ee75353f06a4bd8bc471883e72 | Manish Goregaokar | 2018-09-18T09:19:18 | Bug 1475691: servo_arc cleanups for publishing r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D6034 | diff --git a/selectors/tree.rs b/selectors/tree.rs
index 112b02dbb..bfa59898b 100644
--- a/selectors/tree.rs
+++ b/selectors/tree.rs
@@ -8,18 +8,22 @@
use attr::{AttrSelectorOperation, CaseSensitivity, NamespaceConstraint};
use matching::{ElementSelectorFlags, MatchingContext};
use parser::SelectorImpl;
-use servo_a... | 4 | 229 | 154 |
5ab75632c78bdbd920934ed78a5cc316ee450b74 | Emilio Cobos Álvarez | 2018-09-18T09:15:12 | Bug 1491622 - Make LonghandId::flags an indexing operation. r=xidorn
I always see a bunch of time in our profiles in the iterator over the
declarations, this ensures it's not something dumb.
I suspect it's just a bunch of cache misses from walking the rule tree but in
any case this is consistent with the other getter... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 3ab358524..5968d84bd 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -1113,16 +1113,19 @@ impl LonghandId {
}
/// Returns PropertyFlags for given longhand property.
- ... | 1 | 11 | 8 |
6a29e6ac133c065923005ce1e4b879b689920bf5 | Jonathan Kew | 2018-09-18T08:34:21 | Bug 1490997 - Use nsAtom instead of nsString for font family name in the FontFamilyName struct, and switch its methods from 16-bit to 8-bit strings. r=lsalzman | diff --git a/style/values/computed/font.rs b/style/values/computed/font.rs
index 2c3d2853e..4cb8f7a7b 100644
--- a/style/values/computed/font.rs
+++ b/style/values/computed/font.rs
@@ -483,16 +483,19 @@ impl SingleFontFamily {
FontFamilyType::eFamily_fantasy => SingleFontFamily::Generic(atom!("fantasy")),
... | 1 | 16 | 7 |
a6f9356334c3c79eb4ed63e51a8a776f9ddd704a | Emilio Cobos Álvarez | 2018-09-17T00:53:37 | Bug 1491622 - Simplify CSSWideKeyword::parse. r=xidorn
Differential Revision: https://phabricator.services.mozilla.com/D5972 | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index c78bd8634..3ab358524 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -853,25 +853,22 @@ impl CSSWideKeyword {
CSSWideKeyword::Unset => "unset",
}
}
-
- ... | 1 | 11 | 14 |
40efe2778c572d3c0dfa0c38d8e5e50b80fb966a | Emilio Cobos Álvarez | 2018-09-16T19:35:16 | Bug 1440251 - Allow integer division inside calc() expressions. r=xidorn
Differential Revision: https://phabricator.services.mozilla.com/D5980 | diff --git a/style/values/specified/calc.rs b/style/values/specified/calc.rs
index 06c1dba29..696310699 100644
--- a/style/values/specified/calc.rs
+++ b/style/values/specified/calc.rs
@@ -47,8 +47,6 @@ pub enum CalcNode {
pub enum CalcUnit {
/// `<number>`
Number,
- /// `<integer>`
- Integer,
///... | 1 | 3 | 8 |
f31455d6871e033ff28a1cdcea894299d1d8a37a | Emilio Cobos Álvarez | 2018-09-17T04:47:02 | Bug 1491622 - Remove DeclaredValue. r=xidorn
I think it used to be the case that all PropertyDeclaration variants had a
DeclaredValueOwned<T> inside. But that's no longer the case, so this abstraction
seems less useful now.
Differential Revision: https://phabricator.services.mozilla.com/D5978 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 6ed6b6f32..331d2a743 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -10,7 +10,7 @@ use Atom;
use cssparser::{Delimiter, Parser, ParserInput, SourcePosition, Token, TokenSerializationType};
use hash::map::Entry;
us... | 5 | 36 | 59 |
31e29de1a61f53b7de8d3c82ac49996e0f2691a5 | Emilio Cobos Álvarez | 2018-09-17T14:12:27 | Bug 1491622 - Deindent the non-css-wide-keyword-related code from cascade_property. r=xidorn
There's no good reason we construct a DeclaredValue as an intermediate step.
Differential Revision: https://phabricator.services.mozilla.com/D5977 | diff --git a/style/properties/helpers.mako.rs b/style/properties/helpers.mako.rs
index bf262f581..c1f4fc9d4 100644
--- a/style/properties/helpers.mako.rs
+++ b/style/properties/helpers.mako.rs
@@ -312,20 +312,6 @@
declaration: &PropertyDeclaration,
context: &mut computed::Context,
) {... | 1 | 76 | 82 |
e893e703db4db9ac5c9cc7b8a95957387c6ea588 | Emilio Cobos Álvarez | 2018-09-17T01:33:15 | Bug 1491622 - Remove DeclaredValue::WithVariables. r=xidorn
We never construct it.
Differential Revision: https://phabricator.services.mozilla.com/D5976 | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index 985179db0..6ed6b6f32 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -543,7 +543,6 @@ impl<'a> CustomPropertiesBuilder<'a> {
self.may_have_cycles |= !specified_value.references.is_empty();
... | 3 | 0 | 10 |
6c3a00bbf4fd73baf06bcce1ad7f0418be8f220c | Emilio Cobos Álvarez | 2018-09-17T00:54:43 | Bug 1491622 - Make ExtremumLength::valid_for static. r=xidorn
Differential Revision: https://phabricator.services.mozilla.com/D5975 | diff --git a/style/values/computed/length.rs b/style/values/computed/length.rs
index f2d43e2ad..5acc26882 100644
--- a/style/values/computed/length.rs
+++ b/style/values/computed/length.rs
@@ -953,7 +953,7 @@ impl ExtremumLength {
/// TODO: After these values are supported for both axes (and maybe
/// unprefi... | 1 | 3 | 3 |
a55dce7b9a6a8323b46bf642c984143f26924bfb | Emilio Cobos Álvarez | 2018-09-17T05:31:16 | Bug 1491579 - Enable nsstring/gecko_debug in a place other than components/style. r=xidorn
That way I can unify Servo's and Gecko's Cargo.toml files.
This is the only conflict that exists since a while ago, and it causes
continuous manual merges when I sync changes around.
This moves it to ports/geckolib, which work... | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 5f6788a13..9e0db8c3c 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -22,7 +22,7 @@ use_bindgen = ["bindgen", "regex", "toml"]
servo = ["serde", "style_traits/servo", "servo_atoms", "servo_config", "html5ever",
"cssparser/serde", "encoding_rs", "... | 1 | 1 | 1 |
caeae9ef3d26979daaee50b05001c2dd6208bef5 | Emilio Cobos Álvarez | 2018-09-15T17:15:10 | Bug 1491577 - Fix Servo build and drop a FIXME. r=me | diff --git a/style/servo/url.rs b/style/servo/url.rs
index b4821f21e..91521c8a1 100644
--- a/style/servo/url.rs
+++ b/style/servo/url.rs
@@ -98,6 +98,18 @@ impl CssUrl {
resolved: ServoUrl::parse(url).ok(),
}
}
+
+ /// Parses a URL request and records that the corresponding request needs t... | 2 | 17 | 2 |
e7b4c969368178c1052380841961cb6903a8906d | Emilio Cobos Álvarez | 2018-09-15T17:10:34 | Bug 1491577 - Remove a useless type bound. r=me | diff --git a/style/values/specified/basic_shape.rs b/style/values/specified/basic_shape.rs
index e4c0544af..52343621b 100644
--- a/style/values/specified/basic_shape.rs
+++ b/style/values/specified/basic_shape.rs
@@ -97,7 +97,6 @@ impl Parse for FloatAreaShape {
impl<ReferenceBox, ImageOrUrl> ShapeSource<BasicShape, R... | 1 | 0 | 1 |
73ca31689d3fe04186a5f50b4a8abec90f94f85b | Emilio Cobos Álvarez | 2018-09-15T16:35:21 | Bug 1491577 - Fix Gecko build. r=me | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index 8a401dd01..cd05b5d50 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -15,6 +15,7 @@ servo = [
"mozjs",
"serde",
"serde_bytes",
+ "servo_channel",
"string_cache",
"time",
"url",
@@ -34,7 +3... | 4 | 14 | 3 |
eb9012880cb21d9bea7ab01e143282fe7d51415a | Simon Sapin | 2018-09-15T16:29:11 | Bug 1491577 - Replace mpsc with crossbeam/servo channel, update ipc-channel. r=emilio
This cherry-picks servo/servo#21325.
Co-authored-by: Gregory Terzian <gterzian@users.noreply.github.com> | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index 617985083..8a401dd01 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -34,6 +34,7 @@ selectors = { path = "../selectors" }
serde = { version = "1.0.27", optional = true }
serde_bytes = { version = "0.10", optional = true... | 6 | 9 | 5 |
692d95eea6427412030f463a62704d26ba82fae1 | Anshul Malik | 2018-09-11T18:54:20 | Bug 1491577 - Format components/selectors. r=emilio
This cherry-picks servo/servo#21679. | diff --git a/selectors/bloom.rs b/selectors/bloom.rs
index d9056665a..f868fc7df 100644
--- a/selectors/bloom.rs
+++ b/selectors/bloom.rs
@@ -318,8 +318,9 @@ fn create_and_insert_some_stuff() {
assert!(bf.might_contain_hash(hash_as_str(i)));
}
- let false_positives =
- (1001_usize..2000).filter... | 4 | 342 | 401 |
8ed83c36eea6f203dbc9e5b8712ff6b24f5d7ed1 | chansuke | 2018-09-10T12:31:38 | Bug 1491577 - Format component size_of_test. r=emilio
This cherry-picks servo/servo#21661. | diff --git a/size_of_test/lib.rs b/size_of_test/lib.rs
index fdd2cd62e..f190c2459 100644
--- a/size_of_test/lib.rs
+++ b/size_of_test/lib.rs
@@ -13,16 +13,22 @@ macro_rules! size_of_test {
panic!(
"Your changes have decreased the stack size of {} from {} to {}. \
... | 1 | 9 | 3 |
1622405a6d066b97a5e9c27a64edd2ca939ca9a1 | Matt Brubeck | 2018-09-15T16:04:12 | Bug 1491577 - Switch from new-ordered-float back to ordered-float. r=emilio
The `new-ordered-float` fork has been merged back into the original
`ordered-float` crate.
This cherry-pics servo/servo#21681. | diff --git a/style/Cargo.toml b/style/Cargo.toml
index d92fb049b..c89d9dce6 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -51,7 +51,7 @@ num_cpus = {version = "1.1.0", optional = true}
num-integer = "0.1"
num-traits = "0.2"
num-derive = "0.2"
-new-ordered-float = "1.0"
+ordered-float = "1.0"
owning_ref = ... | 1 | 1 | 1 |
fc1df5adde9ff119d2ea436f6ef4eaf389810382 | chansuke | 2018-09-05T15:32:36 | Bug 1491577 - Format component style_traits. r=emilio
This cherry-picks servo/servo#21620. | diff --git a/style_traits/lib.rs b/style_traits/lib.rs
index 737450b5e..fd80c648b 100644
--- a/style_traits/lib.rs
+++ b/style_traits/lib.rs
@@ -8,27 +8,35 @@
#![crate_name = "style_traits"]
#![crate_type = "rlib"]
-
#![deny(unsafe_code, missing_docs)]
extern crate app_units;
-#[macro_use] extern crate bitflags... | 4 | 121 | 64 |
e53ceabd99db6e985b3ff673e805f60a4e084efd | Brad Werth | 2018-09-12T22:54:24 | Bug 1418470 Part 1: Provide a specialized parse_method for mask-image to use CORS. r=emilio!
Differential Revision: https://phabricator.services.mozilla.com/D5714 | diff --git a/style/properties/longhands/svg.mako.rs b/style/properties/longhands/svg.mako.rs
index 361052476..acdb80913 100644
--- a/style/properties/longhands/svg.mako.rs
+++ b/style/properties/longhands/svg.mako.rs
@@ -183,6 +183,7 @@ ${helpers.predefined_type(
"ImageLayer",
"Either::First(None_)",
ini... | 2 | 15 | 0 |
d4ffeea31fb596cd00e170959c7b7dd027dae45b | Hiroyuki Ikezoe | 2018-08-17T11:29:37 | Bug 1483111 - Implement any-hover and any-pointer media queries features. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D3609 | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index d93d7432d..5999e8a24 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -310,6 +310,18 @@ bitflags! {
}
}
+fn primary_pointer_capabilities(device: &Device) -> PointerCapabilities {
+ PointerCapabil... | 1 | 53 | 13 |
e989cdb703a9deeac7acc97e8b356bc06ddc0906 | Hiroyuki Ikezoe | 2018-08-14T08:13:04 | Bug 1035774 - Add media feature keys for hover and pointer. r=heycam,emilio
Summary:
https://drafts.csswg.org/mediaqueries-4/#hover
https://drafts.csswg.org/mediaqueries-4/#pointer
In this patch series, we don't introduce any-hover and any-pointer media
features yet, but functionalities for them on each platform back... | diff --git a/style/gecko/media_features.rs b/style/gecko/media_features.rs
index 85f0ba27d..d93d7432d 100644
--- a/style/gecko/media_features.rs
+++ b/style/gecko/media_features.rs
@@ -8,6 +8,7 @@ use Atom;
use app_units::Au;
use euclid::Size2D;
use gecko_bindings::bindings;
+use gecko_bindings::structs;
use media_... | 1 | 74 | 1 |
5bb745295946dd37d5d712c4d65af3b20d3f4165 | Cameron McCormack | 2018-09-12T07:37:37 | Bug 1489529 - Update comments to no longer point to nsRuleNode. r=emilio
There are a few mentions of nsRuleNode left but they are mostly
historical references so it makes sense to keep them.
Differential Revision: https://phabricator.services.mozilla.com/D5505 | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 9e9a6835a..1de99ec16 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -2403,7 +2403,8 @@ fn static_assert() {
/// Calculates the constrained and unconstrained font sizes to be inherited
/// fr... | 3 | 19 | 18 |
bd9ee445c936ced4c124bdc77216bb0a7e9c4908 | Brad Werth | 2018-09-11T18:11:05 | Bug 1434963 Part 2: Expand the Parser trait to allow anonymous CORS to be applied. r=emilio
Depends on D5106
Differential Revision: https://phabricator.services.mozilla.com/D5341 | diff --git a/style/gecko/url.rs b/style/gecko/url.rs
index 2a1307985..c00fc8c27 100644
--- a/style/gecko/url.rs
+++ b/style/gecko/url.rs
@@ -201,6 +201,20 @@ impl SpecifiedImageUrl {
use gecko_bindings::structs::root::mozilla::CORSMode_CORS_NONE;
Self::from_css_url_with_cors(url, CORSMode_CORS_NONE)
... | 3 | 38 | 7 |
ac47032b04b62218426b55b57eff2b834facb72f | Brad Werth | 2018-09-11T18:11:02 | Bug 1434963 Part 1: Change Gecko_ImageValue_Create to take a CORS mode argument. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D5106 | diff --git a/style/gecko/url.rs b/style/gecko/url.rs
index 8d785cae6..2a1307985 100644
--- a/style/gecko/url.rs
+++ b/style/gecko/url.rs
@@ -9,6 +9,7 @@ use gecko_bindings::bindings;
use gecko_bindings::structs::ServoBundledURI;
use gecko_bindings::structs::mozilla::css::URLValueData;
use gecko_bindings::structs::ro... | 1 | 8 | 2 |
d5a7074bc2e25444dfaee4f66c8966b18337ce74 | Emilio Cobos Álvarez | 2018-09-11T14:19:55 | Bug 1490311 - Remove unused nsStyleFont::{EnableZoom, UnZoomText}. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D5530 | diff --git a/style/gecko/media_queries.rs b/style/gecko/media_queries.rs
index ccf5b7a51..65855b0a8 100644
--- a/style/gecko/media_queries.rs
+++ b/style/gecko/media_queries.rs
@@ -234,10 +234,13 @@ impl Device {
}
/// Applies text zoom to a font-size or line-height value (see nsStyleFont::ZoomText).
+ #... | 1 | 4 | 1 |
177cc45ff8668565eb889fc3e0dd2c60f9480140 | Emilio Cobos Álvarez | 2018-09-07T22:43:58 | Bug 1489676 - Teach ComputeSquaredDistance derive about #[animation(constant)]. r=xidorn
Differential Revision: https://phabricator.services.mozilla.com/D5337 | diff --git a/style/values/animated/effects.rs b/style/values/animated/effects.rs
index a201ec054..a86396506 100644
--- a/style/values/animated/effects.rs
+++ b/style/values/animated/effects.rs
@@ -11,7 +11,6 @@ use values::computed::{Angle, Number};
use values::computed::length::Length;
#[cfg(feature = "gecko")]
use... | 5 | 29 | 37 |
27e3555053e7077dcb4385d5b0217b1721aa8ea8 | Daniel Varga | 2018-09-10T10:36:56 | Backed out changeset 85d1a0c3f60c (bug 1489676) for mochitest failures at dom/animation/test/mozilla/test_distance_of_path_function.html on a CLOSED TREE | diff --git a/style/values/animated/effects.rs b/style/values/animated/effects.rs
index a86396506..a201ec054 100644
--- a/style/values/animated/effects.rs
+++ b/style/values/animated/effects.rs
@@ -11,6 +11,7 @@ use values::computed::{Angle, Number};
use values::computed::length::Length;
#[cfg(feature = "gecko")]
use... | 5 | 37 | 29 |
6d95eed46eb2411769043989ba1d00d065ab221c | Boris Chiou | 2018-09-07T22:25:59 | Bug 1486094 - Part 5: Use the standalone struct and enum for the flags in SVG path. r=emilio,birtles
We define the standalone types for using derive macro easily and overriding
the behaviors of this traits. This could avoid defining the general
behavior of booleans.
Depends on D4788
Differential Revision: https://ph... | diff --git a/style/values/animated/mod.rs b/style/values/animated/mod.rs
index 1d0ccd690..24cf40f84 100644
--- a/style/values/animated/mod.rs
+++ b/style/values/animated/mod.rs
@@ -141,20 +141,6 @@ impl Animate for f64 {
}
}
-/// This is only used in SVG PATH. We return Err(()) if the flags are mismatched.
-// ... | 3 | 101 | 130 |
975fefca02b6289f9533f68d3e1432b3f9655101 | Boris Chiou | 2018-09-07T22:29:12 | Bug 1486094 - Part 2: Make offset-path:path() animatable. r=birtles
Here, we change the animation type of offset-path as ComputedValue, so
we could do animation on it. Also enable the wpt for offset-path
interpolation. In test_transition_per_property.html, we add some basic tests
ifor offset-path.
ToAnimatedZero for ... | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 7dfc15cd1..ed7839360 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -379,7 +379,7 @@ ${helpers.predefined_type(
"OffsetPath",
"computed::OffsetPath::none()",
... | 4 | 75 | 5 |
8c4508c70f5fed9755a167d7624cfa83fc84a06a | Boris Chiou | 2018-09-07T22:15:50 | Bug 1486094 - Part 1: Make SVGPathData and |clip-path:path()| animatable. r=birtles
Implement Animate trait for SVGPathData.
The basic idea is: we normalize |this| and |other| svg paths, and then
do interpolation on the normalized svg paths. The normalization is to
convert relative coordinates into absolute coordinat... | diff --git a/style/values/animated/mod.rs b/style/values/animated/mod.rs
index 53d3719b0..f09e18861 100644
--- a/style/values/animated/mod.rs
+++ b/style/values/animated/mod.rs
@@ -141,6 +141,20 @@ impl Animate for f64 {
}
}
+/// This is only used in SVG PATH. We return Err(()) if the flags are mismatched.
+// ... | 4 | 175 | 4 |
373bfb2b6edb1b8ef464a6f6aaabd5e213e0a88e | chansuke | 2018-09-07T13:18:51 | Bug 1489667 - Format component of style_derive. r=emilio
This cherry-picks servo/servo#21635 | diff --git a/style_derive/animate.rs b/style_derive/animate.rs
index d591e3db1..0f7604015 100644
--- a/style_derive/animate.rs
+++ b/style_derive/animate.rs
@@ -31,7 +31,7 @@ pub fn derive(mut input: DeriveInput) -> Tokens {
Err(()) => {
append_error_clause = true;
return ... | 8 | 156 | 127 |
bead3a68248e0943619d3ab893accda6a63af139 | Pyfisch | 2018-09-05T08:32:44 | Bug 1488854: Rustfmt malloc_size_of & derive. r=emilio | diff --git a/malloc_size_of/lib.rs b/malloc_size_of/lib.rs
index 11e962541..945ff9418 100644
--- a/malloc_size_of/lib.rs
+++ b/malloc_size_of/lib.rs
@@ -107,9 +107,11 @@ pub struct MallocSizeOfOps {
}
impl MallocSizeOfOps {
- pub fn new(size_of: VoidPtrToSizeFn,
- malloc_enclosing_size_of: Option<V... | 2 | 161 | 107 |
1eb03fa0a8531135857abeee27801301b9e6aaf2 | kingdido999 | 2018-09-04T01:51:55 | Bug 1488854: Format components fallible and geometry. r=emilio
This cherry-picks servo/servo#21598. | diff --git a/fallible/lib.rs b/fallible/lib.rs
index c220699a7..ae6a40dc7 100644
--- a/fallible/lib.rs
+++ b/fallible/lib.rs
@@ -18,7 +18,6 @@ pub trait FallibleVec<T> {
fn try_push(&mut self, value: T) -> Result<(), FailedAllocationError>;
}
-
/////////////////////////////////////////////////////////////////
... | 1 | 19 | 27 |
0b03748aa04086b5cbc582ab4a4f0eb1a834b174 | Emilio Cobos Álvarez | 2018-09-05T13:35:06 | Bug 1488414 - Use decomposition to interpolate matched perspective transform operations. r=birtles
Looks like this produces sensible results for interpolation with 0, though I'm
not really convinced about the results from, let's say, 1px to 2000px in the
attached test-case, I would've expected a linear interpolation f... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index f6277a212..437232d38 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -1296,9 +1296,27 @@ impl Animate for Compute... | 2 | 22 | 3 |
5894cff51e68d8737bc451b31d5f03d55f844b41 | Emilio Cobos Álvarez | 2018-09-05T12:52:16 | Bug 1488155 - Only no-op visited <-> unvisited changes. r=heycam
Other changes should really be (and are) indistinguishable.
Differential Revision: https://phabricator.services.mozilla.com/D4847 | diff --git a/style/invalidation/element/state_and_attributes.rs b/style/invalidation/element/state_and_attributes.rs
index fa0ccdd8b..d13da58a8 100644
--- a/style/invalidation/element/state_and_attributes.rs
+++ b/style/invalidation/element/state_and_attributes.rs
@@ -155,22 +155,11 @@ where
return false;
... | 1 | 4 | 15 |
445617ad903c02c0e8535f14778b6daa08aee4db | Boris Chiou | 2018-09-05T04:50:33 | Bug 1487838 - Add a pref for |clip-path:path()|. r=xidorn
Add a preference, layout.css.clip-path-path.enabled, for |clip-path:path()|.
Differential Revision: https://phabricator.services.mozilla.com/D4965 | diff --git a/style/values/specified/basic_shape.rs b/style/values/specified/basic_shape.rs
index 824c13f1f..18541b8db 100644
--- a/style/values/specified/basic_shape.rs
+++ b/style/values/specified/basic_shape.rs
@@ -49,17 +49,24 @@ pub type ShapeRadius = generic::ShapeRadius<LengthOrPercentage>;
/// The specified val... | 1 | 12 | 5 |
dd888b4668e05d4192a161d0d3fbb9fbac3e10c3 | Emilio Cobos Álvarez | 2018-09-03T07:31:29 | Bug 1487856 - Make the author styles disabled stuff actually disable style attribute, animations, and XBL rules. r=heycam
This also removes one of my FIXMEs from when I was looking at this code.
We don't seem to have a pre-existing test for this feature, sigh. I'll try to
write one if I have cycles for it...
Note th... | diff --git a/style/stylist.rs b/style/stylist.rs
index 5501b751d..e9cd63e73 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -1129,8 +1129,6 @@ impl Stylist {
let rule_hash_target = element.rule_hash_target();
let matches_user_rules = rule_hash_target.matches_user_and_author_rules();
- ... | 1 | 90 | 92 |
38ddda644fef2ad076c3e7b0235e63d5c03e5fe3 | Emilio Cobos Álvarez | 2018-09-03T22:52:12 | Bug 1487259 - Make <svg:use> in shadow tree apply the rules from the originating tree. r=xidorn,firefox-style-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D4674 | diff --git a/style/stylist.rs b/style/stylist.rs
index 038c41ab1..5501b751d 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -1249,7 +1249,8 @@ impl Stylist {
}
}
- if let Some(containing_shadow) = rule_hash_target.containing_shadow() {
+ let mut current_cont... | 1 | 28 | 21 |
67e9b58dd59cf9d6765441795d96dcbc0c112a29 | Emilio Cobos Álvarez | 2018-09-03T10:56:30 | Bug 1488172 - Fix Servo and unit tests build. r=me | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index dcc292273..7dfc15cd1 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -378,10 +378,11 @@ ${helpers.predefined_type(
"offset-path",
"OffsetPath",
"computed:... | 4 | 9 | 4 |
b919a1ba5ca2c6ebb5eb7d31a6ccb1f3e6c92545 | Simon Sapin | 2018-08-24T18:22:27 | Bug 1488172 - Update bindgen to 0.39.0. r=emilio
This imports servo/servo#21516. | diff --git a/malloc_size_of/Cargo.toml b/malloc_size_of/Cargo.toml
index dafeb9381..617985083 100644
--- a/malloc_size_of/Cargo.toml
+++ b/malloc_size_of/Cargo.toml
@@ -29,7 +29,7 @@ euclid = "0.19"
hashglobe = { path = "../hashglobe" }
hyper = { version = "0.10", optional = true }
hyper_serde = { version = "0.8", o... | 3 | 4 | 11 |
0ec84dd78f781ef7633282b3cfd349e4540863e0 | Simon Sapin | 2018-08-23T15:22:38 | Bug 1488172 - Publish selectors v1.20.0. r=emilio
This imports servo/servo#21494. | diff --git a/selectors/Cargo.toml b/selectors/Cargo.toml
index 6d5a93b34..42f8985b5 100644
--- a/selectors/Cargo.toml
+++ b/selectors/Cargo.toml
@@ -1,7 +1,7 @@
[package]
name = "selectors"
-version = "0.19.0"
+version = "0.20.0"
authors = ["The Servo Project Developers"]
documentation = "https://docs.rs/selector... | 1 | 1 | 1 |
0807cb980693a209b7f001c52a36cf2099a74518 | Emilio Cobos Álvarez | 2018-09-03T10:39:02 | Bug 1488172 - Appease Servo's tidy lint. r=me | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index e85bc8ec3..3c1d334f4 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -722,7 +722,7 @@ pub mod basic_shape {
let result: Vec<PathCommand> =
gecko_path.mPath.iter().map(|gec... | 2 | 2 | 2 |
c89ed8eac9954fe72ed8e06b62d3b4deaf1cfcca | Craig Disselkoen | 2018-08-22T20:26:39 | Bug 1488172 - Remove outdated comment in stylist.rs. r=emilio
This imports servo/servo#21487. | diff --git a/style/stylist.rs b/style/stylist.rs
index 03b16b357..fbf2b1803 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -824,9 +824,6 @@ impl Stylist {
///
/// layout_parent_style is the style used for some property fixups. It's
/// the style of the nearest ancestor with a layout box.
- /... | 1 | 0 | 3 |
db6286cf58061514513541e4369b33436775eacb | Emilio Cobos Álvarez | 2018-09-02T22:54:12 | Bug 1487615 - Simplify the Lang pseudo-class stuff a bit. r=xidorn,firefox-style-system-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D4754 | diff --git a/style/dom.rs b/style/dom.rs
index 7552505a7..2f65a266f 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -19,7 +19,7 @@ use element_state::ElementState;
use font_metrics::FontMetricsProvider;
use media_queries::Device;
use properties::{AnimationRules, ComputedValues, PropertyDeclarationBlock};
-use select... | 5 | 45 | 70 |
c8c6d7f2118ce39919431cb227e1a4e3107ea2ba | Emilio Cobos Álvarez | 2018-09-02T22:54:57 | Bug 1487615 - Use proper escaping for pseudo-class strings. r=xidorn
We always serialize as an atom, which is the previous behavior (though previous
code was using string escaping which I think was not totally sound either...).
Differential Revision: https://phabricator.services.mozilla.com/D4753 | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index dcdb06e46..32a7b1f6a 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -21,6 +21,7 @@ use str::starts_with_ignore_ascii_case;
use string_cache::{Atom, Namespace, WeakAtom, WeakNamespace};
use style_tra... | 1 | 5 | 2 |
6f466c1168c026cb069b17560cdb6aea8eef3b67 | Emilio Cobos Álvarez | 2018-09-02T23:03:47 | Bug 1487137 - Shrink CascadeData by turning the bloom filters into hash sets. r=xidorn
We're wasting 1kb there, which is kind of stupid.
The only advantage of using a bloom filter is that memory usage doesn't increase
even if there's a gazillion attribute selectors and such. But:
* For IDs we already have a bunch o... | diff --git a/style/stylist.rs b/style/stylist.rs
index cc6617faa..03b16b357 100644
--- a/style/stylist.rs
+++ b/style/stylist.rs
@@ -24,11 +24,11 @@ use properties::{self, CascadeMode, ComputedValues};
use properties::{AnimationRules, PropertyDeclarationBlock};
use rule_cache::{RuleCache, RuleCacheConditions};
use r... | 1 | 18 | 45 |
8b0dd4a23173f83ce5125aa796fffb81ba039a94 | Cameron McCormack | 2018-08-31T07:05:56 | Bug 1487598 - Use an Atom to store pseudo-class string arguments. r=xidorn
Differential Revision: https://phabricator.services.mozilla.com/D4740 | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index e9652b838..dcdb06e46 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -37,7 +37,7 @@ bitflags! {
}
/// The type used for storing pseudo-class string arguments.
-pub type PseudoClassStringArg = ThinB... | 2 | 4 | 22 |
2c758584b69cb888ec12d6a5fbc15baf5c3a4ea8 | Cameron McCormack | 2018-08-31T05:18:59 | Bug 1487582 - Use an Atom to represent Direction values in pseudo-classes. r=xidorn
Differential Revision: https://phabricator.services.mozilla.com/D4730 | diff --git a/style/gecko/selector_parser.rs b/style/gecko/selector_parser.rs
index cc84f58aa..e9652b838 100644
--- a/style/gecko/selector_parser.rs
+++ b/style/gecko/selector_parser.rs
@@ -54,14 +54,14 @@ macro_rules! pseudo_class_name {
$s_name(PseudoClassStringArg),
)*
/// T... | 5 | 54 | 58 |
a72f0badb0744df0ded092357428b0072c3f7c96 | Emilio Cobos Álvarez | 2018-08-30T12:00:00 | Bug 1487135 - Make the allocation of AuthorStyles for ShadowRoot lazy. r=xidorn,firefox-style-system-reviewers
So that we don't waste a bunch of memory with stuff like <svg:use>. I
plan to shrink AuthorStyles further, but this should help regardless, and isn't
very complex.
Differential Revision: https://phabricator.... | diff --git a/style/dom.rs b/style/dom.rs
index 42f6e9ba0..7552505a7 100644
--- a/style/dom.rs
+++ b/style/dom.rs
@@ -342,7 +342,7 @@ pub trait TShadowRoot: Sized + Copy + Clone + PartialEq {
fn host(&self) -> <Self::ConcreteNode as TNode>::ConcreteElement;
/// Get the style data for this ShadowRoot.
- fn... | 3 | 41 | 28 |
73b1e75f21c9d71db67427e35f6221a266e83095 | Emilio Cobos Álvarez | 2018-08-21T10:31:11 | Bug 1425700 - Make the counters non-atomic counters and merge afterwards. r=bholley
This was consistently faster in the benchmark (even when counters were disabled,
which was slightly suspicious, but...).
Anyway, it's not really much code, most of it is FFI copy-pasta.
Differential Revision: https://phabricator.serv... | diff --git a/style/gecko/arc_types.rs b/style/gecko/arc_types.rs
index 271915f4f..7351cbfea 100644
--- a/style/gecko/arc_types.rs
+++ b/style/gecko/arc_types.rs
@@ -21,7 +21,6 @@ use gecko_bindings::bindings::RawServoRuleNode;
use gecko_bindings::bindings::RawServoRuleNodeStrong;
use gecko_bindings::bindings::RawServ... | 3 | 45 | 11 |
2201516ba79b3d289dfd649e79885dc5bae16e63 | Emilio Cobos Álvarez | 2018-08-20T20:07:19 | Bug 1425700 - Add a test for the use counters. r=heycam
Mostly testing that they work, and that they record what we expect them to
record, that is, the actual property that was parsed, and not the properties
that it'd resolve or expand to.
That may be another tricky part for CSSOM, I think style setters would fail an... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 95f2504fe..681e95566 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -1863,7 +1863,8 @@ impl PropertyId {
}
}
- fn non_custom_id(&self) -> Option<NonCustomPropert... | 2 | 22 | 5 |
42f44958666eac82dbc913345c90ba71334dd525 | Emilio Cobos Álvarez | 2018-08-20T17:03:11 | Bug 1425700 - Hook the use counters into StyleSheet parsing. r=heycam
Still not hooked into telemetry, I talked with :janerik and :gfritzsche about
that, but test incoming!
This intentionally doesn't handle CSSOM and such for now, will file followups
for those, though should be trivial.
I want to unify / clean up ho... | diff --git a/style/gecko/arc_types.rs b/style/gecko/arc_types.rs
index 7351cbfea..271915f4f 100644
--- a/style/gecko/arc_types.rs
+++ b/style/gecko/arc_types.rs
@@ -21,6 +21,7 @@ use gecko_bindings::bindings::RawServoRuleNode;
use gecko_bindings::bindings::RawServoRuleNodeStrong;
use gecko_bindings::bindings::RawServ... | 8 | 25 | 1 |
727dbe08e59d1e1b57471895563406179865cd78 | Emilio Cobos Álvarez | 2018-08-16T14:38:56 | Bug 1425700 - Add a very simple use counter implementation. r=heycam
As simple as I could make it, for now. We can improve on this.
Differential Revision: https://phabricator.services.mozilla.com/D3827 | diff --git a/style/lib.rs b/style/lib.rs
index 1c3630b09..03caab33e 100644
--- a/style/lib.rs
+++ b/style/lib.rs
@@ -157,6 +157,7 @@ pub mod thread_state;
pub mod timer;
pub mod traversal;
pub mod traversal_flags;
+pub mod use_counters;
#[macro_use]
#[allow(non_camel_case_types)]
pub mod values;
diff --git a/styl... | 4 | 105 | 45 |
2bc6f8ff3f5df653d7ab8950a623e61febfa3744 | Boris Chiou | 2018-08-27T18:14:49 | Bug 1485433 - Parse byte slice in PathParser. r=emilio
We only care about ascii char for svg path, so we could parse the string
as byte slice.
Differential Revision: https://phabricator.services.mozilla.com/D4168 | diff --git a/style/values/specified/svg_path.rs b/style/values/specified/svg_path.rs
index 8d92e94ae..48ae18547 100644
--- a/style/values/specified/svg_path.rs
+++ b/style/values/specified/svg_path.rs
@@ -7,8 +7,8 @@
use cssparser::Parser;
use parser::{Parse, ParserContext};
use std::fmt::{self, Write};
-use std::it... | 1 | 46 | 48 |
895b5425aad7ccffded51cbd235287c604139946 | Boris Chiou | 2018-08-15T01:58:18 | Bug 1246764 - Part 2: Define path() for clip-path. r=emilio
For now, |clip-path: path()| is chrome-only, and not for shape-outside,
so we only implement the parser for clip-path. Besides, I didn't put
path() in BasicShape because path() doesn't use the reference box to
resolve the percentage or keywords (i.e. SVG path... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index a3109a1f2..e85bc8ec3 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -670,10 +670,11 @@ pub mod basic_shape {
use values::computed::position;
use values::computed::url::ComputedUrl;
use values::generics... | 4 | 143 | 29 |
b1b253475f02a05d683ddbdd522c1e33dea886c1 | Boris Chiou | 2018-08-16T18:19:59 | Bug 1246764 - Part 1: Move SVGPathData and its parser into svg_path.rs. r=emilio
SVGPathData will be used by clip-path and offset-path (and/or more on the
properties which support <basic-shape>). Therefore, let's move
SVGPathData out of motion.rs.
Differential Revision: https://phabricator.services.mozilla.com/D3631 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 4dafe4573..a3109a1f2 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -743,7 +743,7 @@ pub mod basic_shape {
impl<'a> From<&'a StyleShapeSource> for OffsetPath {
fn from(other: &'a StyleShapeSource) -> Se... | 4 | 522 | 500 |
0c529bd874231c59a622de57d6e5135f849c5906 | Xidorn Quan | 2018-08-24T12:17:37 | Bug 1424106 - Accept unknown webkit pseudo-element. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D4186 | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index 73fe905eb..b30d7764d 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -14,7 +14,7 @@ use properties::{ComputedValues, PropertyFlags};
use properties::longhands::display::computed_value::T as Display;
use ... | 3 | 35 | 4 |
3879a3d06abc7f0731139a53776a39405411da11 | Emilio Cobos Álvarez | 2018-08-24T11:44:21 | Bug 1485951 - Adjust an assertion to account for the changes from bug 1485930. r=me | diff --git a/style/gecko/pseudo_element_definition.mako.rs b/style/gecko/pseudo_element_definition.mako.rs
index dd27dfd56..2395ff32f 100644
--- a/style/gecko/pseudo_element_definition.mako.rs
+++ b/style/gecko/pseudo_element_definition.mako.rs
@@ -257,7 +257,7 @@ impl PseudoElement {
/// Returns `None` if the pse... | 1 | 1 | 1 |
83e90085db3421b90cfd11ae5731fdd2a0386fc1 | Xidorn Quan | 2018-08-24T09:23:05 | Bug 1485930 - Make tree pseudo-element prefix not case-sensitive. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D4185 | diff --git a/style/gecko/pseudo_element.rs b/style/gecko/pseudo_element.rs
index a08da8d40..73fe905eb 100644
--- a/style/gecko/pseudo_element.rs
+++ b/style/gecko/pseudo_element.rs
@@ -14,6 +14,7 @@ use properties::{ComputedValues, PropertyFlags};
use properties::longhands::display::computed_value::T as Display;
use ... | 3 | 4 | 5 |
cb70cc496f39dac719bbf62a3f8f1f8f4c37cdcc | Boris Chiou | 2018-08-23T20:32:53 | Bug 1485766 - Drop the manually implementation of ToCSS for BasicShape::Polygon. r=emilio
The implementation of ToCSS for Polygon has some rule, and we could use skip_if
to handle and serialization of fill-rule. However, we should derive ToCSS for
the pair of LengthOrPercentages, so define a new type for it.
Differen... | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 3c1fcde28..4dafe4573 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -670,7 +670,7 @@ pub mod basic_shape {
use values::computed::position;
use values::computed::url::ComputedUrl;
use values::generics::... | 3 | 27 | 37 |
f29445b03203c17c84f3ae1900199a97271a991c | Emilio Cobos Álvarez | 2018-08-23T14:56:27 | Bug 1485655: Remove an assertion that doesn't hold in some cases. r=me | diff --git a/style/invalidation/element/state_and_attributes.rs b/style/invalidation/element/state_and_attributes.rs
index 1eb022b29..fa0ccdd8b 100644
--- a/style/invalidation/element/state_and_attributes.rs
+++ b/style/invalidation/element/state_and_attributes.rs
@@ -159,13 +159,18 @@ where
// force a restyle... | 1 | 10 | 5 |
8cd541f5550d41adf027f797f3eb6f82025c9603 | Emilio Cobos Álvarez | 2018-08-21T15:34:21 | Bug 1485044: Remove useless StyleDisplay conversion. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D3896 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 06742d45e..dcc292273 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -23,24 +23,6 @@ ${helpers.predefined_type(
needs_context=product == "gecko"
)}
-// FIXME(emi... | 2 | 2 | 20 |
a360972b36e67eabcec4237d03fb24427fd0d6a2 | Emilio Cobos Álvarez | 2018-08-21T14:42:27 | Bug 1474317: Make text-orientation, unicode-bidi, contain and will-change non-animatable. r=heycam
Per recent CSSWG resolutions:
https://github.com/w3c/csswg-drafts/issues/2737
https://github.com/w3c/csswg-drafts/issues/2751
Differential Revision: https://phabricator.services.mozilla.com/D3888 | diff --git a/style/properties/longhands/box.mako.rs b/style/properties/longhands/box.mako.rs
index 4ef45a502..c408bfe11 100644
--- a/style/properties/longhands/box.mako.rs
+++ b/style/properties/longhands/box.mako.rs
@@ -513,14 +513,16 @@ ${helpers.predefined_type(
servo_restyle_damage="reflow_out_of_flow"
)}
-... | 3 | 19 | 18 |
2ac78b582e23473ebc9f95632d6fff1da5ea1822 | Emilio Cobos Álvarez | 2018-08-17T18:26:29 | Bug 1484316: Serialize clip-path and shape-outside using Servo. r=xidorn
Differential Revision: https://phabricator.services.mozilla.com/D3653 | diff --git a/style/gecko/conversions.rs b/style/gecko/conversions.rs
index 154ad95bc..3c1fcde28 100644
--- a/style/gecko/conversions.rs
+++ b/style/gecko/conversions.rs
@@ -19,6 +19,7 @@ use stylesheets::{Origin, RulesMutateError};
use values::computed::{Angle, CalcLengthOrPercentage, Gradient, Image};
use values::co... | 2 | 85 | 43 |
fb89ddc4412cd15e3770993290efef5f8b280593 | Boris Chiou | 2018-07-13T23:04:37 | Bug 1429298 - Part 3: Use macro for path parser. r=emilio
There are a lot of duplicates, so we use macro to refine them.
Differential Revision: https://phabricator.services.mozilla.com/D2966 | diff --git a/style/values/specified/motion.rs b/style/values/specified/motion.rs
index 8b370369b..ffaaf7cff 100644
--- a/style/values/specified/motion.rs
+++ b/style/values/specified/motion.rs
@@ -70,6 +70,34 @@ struct PathParser<'a> {
path: Vec<PathCommand>,
}
+macro_rules! parse_arguments {
+ (
+ $p... | 1 | 78 | 163 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.