text stringlengths 0 2.35k |
|---|
[1408.88 --> 1409.66] Please don't. |
[1409.96 --> 1410.24] I was. |
[1410.52 --> 1413.10] That came across like I was being a little bit sassy. |
[1413.24 --> 1413.76] No, no, no, no. |
[1413.78 --> 1415.24] But it was a genuine question. |
[1415.24 --> 1417.40] I love making German jokes. |
[1417.52 --> 1417.74] Anything. |
[1419.18 --> 1421.06] I should have made it a German chocolate cake. |
[1421.14 --> 1421.90] I'm so sorry, Natalie. |
[1421.98 --> 1422.96] I missed that opportunity. |
[1423.14 --> 1423.86] Oh, my gosh. |
[1424.22 --> 1424.62] Eskule. |
[1425.50 --> 1426.46] This is Austrian. |
[1426.66 --> 1430.52] Natalie will be the final, like once the beautiful cake has been constructed. |
[1430.64 --> 1432.34] She is the ultimate SMA. |
[1432.40 --> 1433.72] Wait, did you use sugar or salt? |
[1433.88 --> 1435.12] The ultimate taste tester. |
[1435.12 --> 1456.70] This episode is brought to you by our friends at Fire Hydrant. |
[1457.10 --> 1459.74] Fire Hydrant is a reliability platform for every developer. |
[1460.24 --> 1462.72] Incidents are a win, not an if situation. |
[1462.72 --> 1467.24] And they impact everyone in the organization, not just SREs. |
[1467.34 --> 1470.86] And I'm here with Robert Ross, founder and CEO of Fire Hydrant. |
[1471.26 --> 1473.52] Robert, what is it about teams getting distracted by incidents |
[1473.52 --> 1476.84] and not being able to focus on the core product that upsets you? |
[1477.22 --> 1481.16] I think that incidents bring a lot of anxiety and sometimes fear |
[1481.16 --> 1485.36] and maybe even a level of shame that can cause this paralysis |
[1485.36 --> 1488.02] in an organization from progress. |
[1488.02 --> 1494.44] And when you have the confidence to manage incidents at any scale of any variety, |
[1494.76 --> 1496.72] everyone just has this breath of fresh air |
[1496.72 --> 1499.50] that they can go build the core product even more. |
[1499.86 --> 1502.88] I don't know if anyone's had the opportunity, maybe is the word, |
[1502.98 --> 1504.40] to call the fire department. |
[1504.60 --> 1507.24] But no matter what, when the fire department shows up, |
[1507.34 --> 1510.26] it doesn't matter if the building is hugely on fire. |
[1510.40 --> 1511.88] They are calm, cool, and collected |
[1511.88 --> 1513.94] because they know exactly what they're going to do. |
[1513.94 --> 1517.14] And that's what Fire Hydrant is built to help people achieve. |
[1517.14 --> 1518.52] Very cool. Thank you, Robert. |
[1518.64 --> 1522.90] If you want to operate as a calm, cool, collected team |
[1522.90 --> 1525.28] when incidents happen, you got to check out Fire Hydrant. |
[1525.60 --> 1528.22] Small teams, up to 10 people can get started for free |
[1528.22 --> 1531.20] with all the features, no credit card required to sign up. |
[1531.50 --> 1533.18] Get started at firehydrant.com. |
[1533.52 --> 1535.52] Again, firehydrant.com. |
[1535.52 --> 1548.40] Great. So you are going to review a PR. |
[1548.82 --> 1553.50] What are the almost like unspoken rules of PR review? |
[1553.50 --> 1556.60] Are there actual rules of PR review? |
[1557.18 --> 1561.22] Love to hear like, how do you approach reviewing your colleagues' PRs? |
[1561.22 --> 1565.28] I think it goes a long way if you lead with empathy, |
[1565.72 --> 1567.32] kind of like go through the PR, |
[1568.02 --> 1571.02] address anything that you think could be updated, |
[1571.24 --> 1573.76] but not in a way that you're talking down to people, |
[1574.36 --> 1578.34] having a willingness to learn, a willingness to teach. |
[1578.92 --> 1583.74] I mean, these are all like core factors of doing a good PR review. |
[1584.22 --> 1586.00] And then you can get into the nitty gritties |
[1586.00 --> 1590.82] of like your team's specific strategy and patterns and all of that. |
[1590.82 --> 1592.06] And like the correctness of the code. |
[1592.12 --> 1594.10] But I think that first part is really key. |
[1594.88 --> 1595.90] Yeah, I totally agree. |
[1596.00 --> 1600.26] And I think there are a lot of small behaviors |
[1600.26 --> 1601.82] that we as engineers can adopt |
[1601.82 --> 1604.98] to be more empathetic in our code reviews. |
[1605.22 --> 1607.50] I really enjoy some of the resources |
[1607.50 --> 1611.06] that other people have already written and shared around this. |
[1611.18 --> 1613.84] I particularly like Alex Hill's The Art of Giving |
[1613.84 --> 1617.22] and Receiving Code Reviews Gracefully. |
[1617.34 --> 1618.06] It's something like that. |
[1618.06 --> 1624.00] And that idea of giving a code review gracefully, |
[1624.08 --> 1626.08] I think ties into the empathy thing |
[1626.08 --> 1627.06] that you're talking about, Natasha. |
[1627.34 --> 1629.94] And just like putting yourself in the position |
[1629.94 --> 1631.86] of the person who's receiving the feedback. |
[1632.24 --> 1634.56] Ultimately, a pull request, |
[1634.70 --> 1637.18] like this code review is feedback |
[1637.18 --> 1641.94] and is collaboration in like our everyday as engineers. |
[1641.94 --> 1644.80] And so some of the simple things, |
[1645.26 --> 1648.32] like instead of saying you, saying we. |
[1648.56 --> 1651.64] And instead of making a statement, asking a question. |
[1652.22 --> 1653.92] So for example, instead of saying like, |
[1654.78 --> 1657.86] oh, like you should use this other function, |
[1657.96 --> 1659.52] it already does what you're doing here. |
[1660.62 --> 1664.08] Asking, oh, like can we use this other function here? |
[1664.18 --> 1665.72] Like is there something that we can reuse? |
[1665.72 --> 1670.64] And that gives the opportunity because you could be wrong. |
[1670.72 --> 1672.34] I'm a staff engineer and I'm wrong all the time. |
[1672.66 --> 1676.68] So if I'm just coming into a code review and saying like, |
[1676.74 --> 1678.60] oh, you should have done this and you should have done that. |
[1678.68 --> 1681.54] Like that not only is not giving feedback |
[1681.54 --> 1683.38] in a way that will be easily received, |
[1683.38 --> 1689.08] but it's really like assuming that I always know the answer |
[1689.08 --> 1690.52] and I always know what's best. |
[1690.52 --> 1694.50] And I think remembering that the person who's coming in |
[1694.50 --> 1698.62] with the pull request has spent so much time, |
[1698.78 --> 1701.26] presumably on this problem that yes, |
[1701.30 --> 1702.88] the fresh pair of eyes is really helpful |
[1702.88 --> 1704.98] and you might see something that they didn't, |
[1705.28 --> 1708.22] but also giving acknowledgement to the work |
[1708.22 --> 1710.30] that they've put in on this pull request |
[1710.30 --> 1713.04] and that they might have like thought through that problem |
[1713.04 --> 1715.50] and that there might be something that you're missing |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.