Datasets:
willtheorangeguy
/
2022-Go-Time-Transcripts

Dataset card Data Studio Files
xet
 Community
text
stringlengths
0
2.35k
[1715.50 --> 1717.16] because you haven't spent as much time
[1717.16 --> 1718.56] thinking about the solution.
[1719.32 --> 1720.50] So that empathy is really important.
[1720.52 --> 1721.20] Yeah.
[1721.50 --> 1722.28] Check your ego.
[1724.02 --> 1727.06] I would totally plus a thousand they've said so far.
[1727.24 --> 1728.14] It's definitely like for,
[1728.56 --> 1730.76] it's not just like it's a one side street, right?
[1730.78 --> 1731.24] It's two sides.
[1731.32 --> 1734.76] You can take something back from the review
[1734.76 --> 1736.10] and then they can take something forward.
[1736.46 --> 1738.48] It's always an opportunity to learn something new,
[1738.80 --> 1742.10] especially from people who have way more experience
[1742.10 --> 1742.60] than you do.
[1743.14 --> 1745.46] And it's just an opportunity to ask questions,
[1745.60 --> 1747.98] especially like, oh, why did you do this way
[1747.98 --> 1749.62] versus some other way, right?
[1749.62 --> 1752.72] And it's definitely a great opportunity
[1752.72 --> 1754.86] to kind of, you know,
[1754.86 --> 1757.52] just learn more about what they're working on
[1757.52 --> 1758.94] and learn more about the system.
[1759.48 --> 1760.92] There always has to be an eye for,
[1761.16 --> 1763.08] oh, is this like what we're trying to achieve
[1763.08 --> 1764.34] with this particular ticket?
[1764.88 --> 1766.60] But definitely leading with empathy
[1766.60 --> 1768.70] is something that's great.
[1768.70 --> 1770.46] I also want to look up that article now
[1770.46 --> 1771.56] because I've never read that,
[1772.26 --> 1773.48] the Alex Hill one, so.
[1774.12 --> 1774.84] It's really great.
[1775.02 --> 1776.84] I'll make sure I put it in the episode notes.
[1777.80 --> 1779.12] And it is a great article.
[1780.94 --> 1782.68] So when you're thinking about reviewing,
[1782.80 --> 1785.08] are you predominantly reviewing for functionality
[1785.08 --> 1787.06] and like, does this thing work?
[1787.32 --> 1789.86] Or are you also commenting slash what are the,
[1790.04 --> 1792.64] I guess, rules around commenting on like style?
[1793.04 --> 1794.66] Like how the code has been written,
[1794.82 --> 1796.82] the stylistic choices that have been made?
[1796.82 --> 1798.16] I think a bit of both.
[1798.80 --> 1800.00] Yeah, definitely.
[1800.44 --> 1802.84] And not to over-reference this article,
[1803.30 --> 1805.80] but one of the things I think is like
[1805.80 --> 1807.68] one of my key takeaways from this was
[1807.68 --> 1811.62] that there are those kinds of like code style things
[1811.62 --> 1813.64] that can be automated.
[1814.30 --> 1816.08] So having a team norm of like,
[1816.18 --> 1818.80] oh, we're all using this linter for this code base.
[1818.82 --> 1820.10] We're using this formatter.
[1820.66 --> 1821.76] Pre-commit hook,
[1821.84 --> 1824.44] those have to pass before you can make this pull request.
[1824.44 --> 1827.46] It just automates away a lot of the things
[1827.46 --> 1829.30] we can be kind of nitpicky over.
[1830.14 --> 1834.42] But sometimes there are more like code patterns
[1834.42 --> 1836.46] and those are harder to automate,
[1836.86 --> 1839.94] but they can be like a source of contention
[1839.94 --> 1842.18] because there can be a lot of very strong opinions
[1842.18 --> 1845.04] around how, what patterns we're following
[1845.04 --> 1846.42] and how code should be structured.
[1846.42 --> 1851.00] That's where I think having a set of norms on your team
[1851.00 --> 1855.42] that you regularly revisit when somebody new joins,
[1855.64 --> 1858.36] when you have a new, like a new repo you're working in,
[1858.72 --> 1862.28] those norms will help smooth that conversation
[1862.28 --> 1864.94] because if you have all already agreed,
[1865.10 --> 1866.64] like, oh, we're going to make sure
[1866.64 --> 1869.00] we follow dry practices or whatever,
[1869.20 --> 1871.76] like those kinds of agreements
[1871.76 --> 1876.60] make it a lot easier to have that code review conversation
[1876.60 --> 1880.22] because that's like a shared expectation that you have.
[1880.32 --> 1882.68] And it's the same thing for giving interpersonal feedback.
[1882.80 --> 1884.88] If you have a shared expectation and a shared goal,
[1885.10 --> 1887.30] then you can easily use that as a reference point
[1887.30 --> 1888.10] and be like, hey, like,
[1888.28 --> 1890.30] since this is something that we've agreed on as a team,
[1890.48 --> 1892.04] I'm noticing this here.
[1892.12 --> 1894.36] Do you think we could reshape this
[1894.36 --> 1895.56] so that it follows this practice
[1895.56 --> 1897.76] that we have agreed to use for this repo?
[1897.76 --> 1901.62] And that's a much easier conversation to have
[1901.62 --> 1904.48] than like, oh, I don't like how this is styled.
[1904.60 --> 1906.24] I think we should do it this way instead.
[1906.54 --> 1909.14] And kind of like bringing your perspective into it.
[1909.42 --> 1911.42] It's a lot easier to bring like a team norm
[1911.42 --> 1912.66] that you've already all agreed on
[1912.66 --> 1914.68] that's like the team's perspective on this
[1914.68 --> 1917.72] and the team's perspective on how to move forward.
[1918.46 --> 1919.28] It's really important,
[1919.34 --> 1920.82] like having that team understanding, right?
[1920.94 --> 1922.10] At least in my previous company,
[1922.10 --> 1924.88] we had like shared standards as to how things,
[1924.88 --> 1926.52] we had like pillars and everything,
[1926.52 --> 1928.30] that we had like a standards committee
[1928.30 --> 1929.80] that we were trying to do
[1929.80 --> 1932.14] for like code style and stuff like that.
[1932.70 --> 1934.86] But just like on the other side of the coin,
[1935.04 --> 1936.00] I'm kind of like,
[1936.44 --> 1938.72] sometimes if I see a spelling mistake,
[1938.72 --> 1940.14] I will point that out in the PR
[1940.14 --> 1941.98] just because it's like,
[1942.10 --> 1943.92] if it's already committed and I see it,